diff options
| author | Nicolai Hähnle <nicolai.haehnle@amd.com> | 2016-04-25 18:20:50 -0500 |
|---|---|---|
| committer | Nicolai Hähnle <nicolai.haehnle@amd.com> | 2016-04-29 11:52:59 -0500 |
| commit | 98c348d26b28a662d093543ecb7ca839e7883e8e (patch) | |
| tree | bd482743d87e110f06f7d21eb65e7cb01def16b6 /src/util | |
| parent | 59af21c3e991d13ffaf79494ea608a67b7d3e7f0 (diff) | |
| download | external_mesa3d-98c348d26b28a662d093543ecb7ca839e7883e8e.zip external_mesa3d-98c348d26b28a662d093543ecb7ca839e7883e8e.tar.gz external_mesa3d-98c348d26b28a662d093543ecb7ca839e7883e8e.tar.bz2 | |
st/glsl_to_tgsi: reduce stack explosion in recursive expression visitor
In optimized builds, visit(ir_expression *) experiences inlining with gcc that
leads the function to have a roughly 32KB stack frame. This is a problem given
that the function is called recursively. In non-optimized builds, the stack
frame is much smaller, hence one gets crashes that happen only in optimized
builds.
Arguably there is a compiler bug or at least severe misfeature here. In any
case, the easy thing to do for now seems to be moving the bulk of the
non-recursive code into a separate function. This is sufficient to convince my
version of gcc not to blow up the stack frame of the recursive part. Just to be
sure, add the gcc-specific noinline attribute to prevent this bug from
reoccuring if inliner heuristics change.
v2: put ATTRIBUTE_NOINLINE into macros.h
Cc: "11.1 11.2" <mesa-stable@lists.freedesktop.org>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=95133
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=95026
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92850
Reviewed-by: Ilia Mirkin <imirkin@alum.mit.edu>
Reviewed-by: Rob Clark <robdclark@gmail.com>
Diffstat (limited to 'src/util')
| -rw-r--r-- | src/util/macros.h | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/src/util/macros.h b/src/util/macros.h index 773e12f..c0bfb15 100644 --- a/src/util/macros.h +++ b/src/util/macros.h @@ -214,6 +214,12 @@ do { \ #define MUST_CHECK #endif +#if defined(__GNUC__) || (defined(__SUNPRO_C) && (__SUNPRO_C >= 0x590)) +#define ATTRIBUTE_NOINLINE __attribute__((noinline)) +#else +#define ATTRIBUTE_NOINLINE +#endif + /** Compute ceiling of integer quotient of A divided by B. */ #define DIV_ROUND_UP( A, B ) ( (A) % (B) == 0 ? (A)/(B) : (A)/(B)+1 ) |