diff options
author | Chris Wilson <chris@chris-wilson.co.uk> | 2011-09-30 21:58:59 +0100 |
---|---|---|
committer | Chris Wilson <chris@chris-wilson.co.uk> | 2011-09-30 22:00:05 +0100 |
commit | ebca47af8507e0fc3f03d6c0f49be6b2d4d9a8a4 (patch) | |
tree | 3cd2a65b934d9a6b37c38faaa0912e1d196e40f7 /src | |
parent | 8ccbcda5c64a8bea47f6b41d46bf015ba8e515fc (diff) | |
download | external_mesa3d-ebca47af8507e0fc3f03d6c0f49be6b2d4d9a8a4.zip external_mesa3d-ebca47af8507e0fc3f03d6c0f49be6b2d4d9a8a4.tar.gz external_mesa3d-ebca47af8507e0fc3f03d6c0f49be6b2d4d9a8a4.tar.bz2 |
i965: Assign instead of compare inside assert
This is from a Coverity defect report.
src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
1314 void
1315 vec4_visitor::emit_block_move(dst_reg *dst, src_reg *src,
1316 const struct glsl_type *type, bool
predicated)
...
1351 /* Do we need to worry about swizzling a swizzle? */
->1352 assert(src->swizzle = BRW_SWIZZLE_NOOP);
1353 src->swizzle = swizzle_for_size(type->vector_elements);
Reported-by: Vinson Lee <vlee@vmware.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=40158
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Diffstat (limited to 'src')
-rw-r--r-- | src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp index 98ecd25..5815e31 100644 --- a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp +++ b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp @@ -1472,7 +1472,7 @@ vec4_visitor::emit_block_move(dst_reg *dst, src_reg *src, dst->writemask = (1 << type->vector_elements) - 1; /* Do we need to worry about swizzling a swizzle? */ - assert(src->swizzle = BRW_SWIZZLE_NOOP); + assert(src->swizzle == BRW_SWIZZLE_NOOP); src->swizzle = swizzle_for_size(type->vector_elements); vec4_instruction *inst = emit(MOV(*dst, *src)); |