PFW: Display warning messages to help user

BZ: 54512

Display a warning message when a configuration cannot be applied because
the TuningMode is on, in order to help user to identify potential issues.
Display a warning message when a criterion change doesn't lead to a
configuration application (a check is performed each time a criterion
is changed).

Change-Id: Id872655c92770d1f6f1b01b20db2fde3db826ceb
Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com>
Reviewed-on: http://android.intel.com:8080/63845
Reviewed-by: Rocard, KevinX <kevinx.rocard@intel.com>
Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com>
Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com>
Tested-by: Barthes, FabienX <fabienx.barthes@intel.com>
Reviewed-by: buildbot <buildbot@intel.com>
Tested-by: buildbot <buildbot@intel.com>

1 files changed, 21 insertions, 1 deletions

diff --git a/parameter/SelectionCriterion.cpp b/parameter/SelectionCriterion.cpp
index 7f2809a..453f244 100644
--- a/parameter/SelectionCriterion.cpp
+++ b/parameter/SelectionCriterion.cpp
@@ -27,7 +27,7 @@
 
 #define base CElement
 
-CSelectionCriterion::CSelectionCriterion(const string& strName, const CSelectionCriterionType* pType) : base(strName), _iState(0), _pType(pType)
+CSelectionCriterion::CSelectionCriterion(const string& strName, const CSelectionCriterionType* pType) : base(strName), _iState(0), _pType(pType), _uiNbModifications(0)
 {
 }
 
@@ -36,6 +36,16 @@ string CSelectionCriterion::getKind() const
     return "SelectionCriterion";
 }
 
+bool CSelectionCriterion::hasBeenModified() const
+{
+    return _uiNbModifications != 0;
+}
+
+void CSelectionCriterion::resetModifiedStatus()
+{
+    _uiNbModifications = 0;
+}
+
 /// From ISelectionCriterionInterface
 // State
 void CSelectionCriterion::setCriterionState(int iState)
@@ -46,6 +56,16 @@ void CSelectionCriterion::setCriterionState(int iState)
         _iState = iState;
 
         log("Selection criterion changed event: %s", getFormattedDescription(false).c_str());
+
+        // Check if the previous criterion value has been taken into account (i.e. at least one Configuration was applied
+        // since the last criterion change)
+        if (_uiNbModifications > 0) {
+
+            log("Warning: Selection criterion \"%s\" has been modified %d time(s) without any configuration application", getName().c_str(), _uiNbModifications);
+        }
+
+        // Track the number of modifications for this criterion
+        _uiNbModifications++;
     }
 }