aboutsummaryrefslogtreecommitdiffstats
path: root/java/README.txt
diff options
context:
space:
mode:
authorDave Hawkey <dhawkey@google.com>2014-03-20 10:55:41 -0600
committerDave Hawkey <dhawkey@google.com>2014-03-21 09:27:23 -0600
commitc6e12c6702ca764486f952654ba1568f00efe813 (patch)
treeb1dcfb28a8cef29d898e45637852816eb490ddc2 /java/README.txt
parent51ef8f39de376fe71ce5d2c682abe4f974cf8074 (diff)
downloadexternal_protobuf-c6e12c6702ca764486f952654ba1568f00efe813.zip
external_protobuf-c6e12c6702ca764486f952654ba1568f00efe813.tar.gz
external_protobuf-c6e12c6702ca764486f952654ba1568f00efe813.tar.bz2
Don't reset cachedSize to 0 in getSerializedSize
This avoids a race-condition when cachedSize is momentarily set to 0 for non-empty messages if multiple threads call getSerializedSize (e.g. during serialization). Change-Id: I15a8ded92edbf41bf1c8d787960c5bbbc8a323c5
Diffstat (limited to 'java/README.txt')
-rw-r--r--java/README.txt9
1 files changed, 9 insertions, 0 deletions
diff --git a/java/README.txt b/java/README.txt
index 13865f6..f958d14 100644
--- a/java/README.txt
+++ b/java/README.txt
@@ -437,6 +437,15 @@ and the runtime overhead. An overview of Nano features:
MessageNano.
- The 'bytes' type translates to the Java type byte[].
+The generated messages are not thread-safe for writes, but may be
+used simultaneously from multiple threads in a read-only manner.
+In other words, an appropriate synchronization mechanism (such as
+a ReadWriteLock) must be used to ensure that a message, its
+ancestors, and descendants are not accessed by any other threads
+while the message is being modified. Field reads, getter methods,
+toByteArray(...), writeTo(...), getCachedSize(), and
+getSerializedSize() are all considered read-only operations.
+
IMPORTANT: If you have fields with defaults and opt out of accessors
How fields with defaults are serialized has changed. Because we don't