aboutsummaryrefslogtreecommitdiffstats
path: root/src/google/protobuf/unittest_simple_nano.proto
diff options
context:
space:
mode:
authorMax Cai <maxtroy@google.com>2013-07-29 17:20:50 +0100
committerMax Cai <maxtroy@google.com>2013-08-05 21:54:58 +0100
commit624c448fbef20a1a2fad2289f622b468c25763d1 (patch)
tree70294971235a3e23aea495f7b3c2ea39cbfedb66 /src/google/protobuf/unittest_simple_nano.proto
parentbe47f55e2f93df84abb55759e49cf381d2745cc5 (diff)
downloadexternal_protobuf-624c448fbef20a1a2fad2289f622b468c25763d1.zip
external_protobuf-624c448fbef20a1a2fad2289f622b468c25763d1.tar.gz
external_protobuf-624c448fbef20a1a2fad2289f622b468c25763d1.tar.bz2
Fix outer classname for javamicro/javanano.
- File class name is defined as the java_outer_classname option value or the file name ToCamelCase; never the single message's ClassName. - File-scope enums are translated to constants in the file class, regardless of java_multiple_files. - If java_multiple_files=true, and file's class name equals a message's class name, no error. This is done by detecting that the outer class is not needed and skipping the outer class codegen and clash checks. Note: there is a disparity between java[lite] and the previous java{micr|nan}o: when generating code for a single-message proto, the outer class is omitted by java{micr|nan}o if the file does not have java_outer_classname. This change makes java{micr|nan}o align with java[lite] codegen and create the outer class, but will print some info to warn of potential change of code. - Also fixed the "is_own_file" detection and made all parseX() methods static. Previously, all messages in a java_multiple_files=true file are (incorrectly) considered to be in their own files, including nested messages, causing them to become inner classes (instance- bound) and forcing the parseX() methods to lose the static modifier. - This change supersedes c/60164 and c/60086, which causes javanano to put enum values into enum shell classes if java_multiple_files=true. We now always use the parent class to host the enum values. A future change will add a command line option to provide more flexibility. - Elaborated in java/README.txt. Change-Id: I684932f90e0a028ef37c662b221def5ffa202439
Diffstat (limited to 'src/google/protobuf/unittest_simple_nano.proto')
-rw-r--r--src/google/protobuf/unittest_simple_nano.proto2
1 files changed, 2 insertions, 0 deletions
diff --git a/src/google/protobuf/unittest_simple_nano.proto b/src/google/protobuf/unittest_simple_nano.proto
index 287e962..0c780c7 100644
--- a/src/google/protobuf/unittest_simple_nano.proto
+++ b/src/google/protobuf/unittest_simple_nano.proto
@@ -34,6 +34,8 @@
package protobuf_unittest_import;
option java_package = "com.google.protobuf.nano";
+// Explicit outer classname to suppress legacy info.
+option java_outer_classname = "UnittestSimpleNano";
message SimpleMessageNano {
message NestedMessage {