diff options
| author | Kristian Monsen <kristianm@google.com> | 2010-11-05 10:45:07 +0000 |
|---|---|---|
| committer | Kristian Monsen <kristianm@google.com> | 2010-11-05 10:49:54 +0000 |
| commit | 18b98c9f527349208c3518828e590cf9652d57bd (patch) | |
| tree | 858c2839adafaab59dbb125350c945609d6480e4 | |
| parent | 07017de2da3288f802d8424d61aff826a72f736d (diff) | |
| download | external_webkit-18b98c9f527349208c3518828e590cf9652d57bd.zip external_webkit-18b98c9f527349208c3518828e590cf9652d57bd.tar.gz external_webkit-18b98c9f527349208c3518828e590cf9652d57bd.tar.bz2 | |
Update method to take const std::string& argument
It's safe to pass this across threads since NewRunnableMethod
copies the argument.
Change-Id: I620ebfe64ead7947ac3a6733507865938e04a8df
| -rw-r--r-- | WebKit/android/WebCoreSupport/WebRequest.cpp | 2 | ||||
| -rw-r--r-- | WebKit/android/WebCoreSupport/WebRequest.h | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/WebKit/android/WebCoreSupport/WebRequest.cpp b/WebKit/android/WebCoreSupport/WebRequest.cpp index f21c1a2..e939be4 100644 --- a/WebKit/android/WebCoreSupport/WebRequest.cpp +++ b/WebKit/android/WebCoreSupport/WebRequest.cpp @@ -130,7 +130,7 @@ void WebRequest::finish(bool success) m_urlLoader = 0; } -void WebRequest::appendFileToUpload(std::string filename) +void WebRequest::appendFileToUpload(const std::string& filename) { // AppendFileToUpload is only valid before calling start ASSERT(m_loadState == Created, "appendFileToUpload called on a WebRequest not in CREATED state: (%s)", m_url.c_str()); diff --git a/WebKit/android/WebCoreSupport/WebRequest.h b/WebKit/android/WebCoreSupport/WebRequest.h index c82096e..c7026a5 100644 --- a/WebKit/android/WebCoreSupport/WebRequest.h +++ b/WebKit/android/WebCoreSupport/WebRequest.h @@ -61,7 +61,7 @@ public: // Optional, but if used has to be called before start void appendBytesToUpload(Vector<char>* data); - void appendFileToUpload(std::string filename); + void appendFileToUpload(const std::string& filename); void start(bool isPrivateBrowsing); void cancel(); |