Merge "Remove inconsistency between HistoryItem writing/reading"

1 files changed, 7 insertions, 4 deletions

diff --git a/Source/WebKit/android/jni/WebHistory.cpp b/Source/WebKit/android/jni/WebHistory.cpp
index b6972e4..6b71d0f 100644
--- a/Source/WebKit/android/jni/WebHistory.cpp
+++ b/Source/WebKit/android/jni/WebHistory.cpp
@@ -472,10 +472,13 @@ static void writeItem(WTF::Vector<char>& vector, WebCore::HistoryItem* item)
     // Form data
     const WebCore::FormData* formData = item->formData();
     if (formData) {
-        writeString(vector, formData->flattenToString());
-        // save the identifier as it is not included in the flatten data
-        int64_t id = formData->identifier();
-        vector.append((char*)&id, sizeof(int64_t));
+        WTF::String flattenedFormData = formData->flattenToString();
+        writeString(vector, flattenedFormData);
+        if (!flattenedFormData.isEmpty()) {
+            // save the identifier as it is not included in the flatten data
+            int64_t id = formData->identifier();
+            vector.append((char*)&id, sizeof(int64_t));
+        }
     } else
         writeString(vector, WTF::String()); // Empty constructor does not allocate a buffer.