Fix a leaked JNI LocaRef in WebViewCore::jsPrompt()

Bug: 3470906
Change-Id: I8fb9ddcf4ff3dee35c2225a18a86b4015002da96

1 files changed, 3 insertions, 2 deletions

diff --git a/WebKit/android/jni/WebViewCore.cpp b/WebKit/android/jni/WebViewCore.cpp
index 6e6196a..66c78b5 100644
--- a/WebKit/android/jni/WebViewCore.cpp
+++ b/WebKit/android/jni/WebViewCore.cpp
@@ -3385,13 +3385,13 @@ bool WebViewCore::jsConfirm(const WTF::String& url, const WTF::String& text)
 bool WebViewCore::jsPrompt(const WTF::String& url, const WTF::String& text, const WTF::String& defaultValue, WTF::String& result)
 {
     JNIEnv* env = JSC::Bindings::getJNIEnv();
+    jstring jUrlStr = wtfStringToJstring(env, url);
     jstring jInputStr = wtfStringToJstring(env, text);
     jstring jDefaultStr = wtfStringToJstring(env, defaultValue);
-    jstring jUrlStr = wtfStringToJstring(env, url);
     jstring returnVal = static_cast<jstring>(env->CallObjectMethod(m_javaGlue->object(env).get(), m_javaGlue->m_jsPrompt, jUrlStr, jInputStr, jDefaultStr));
+    env->DeleteLocalRef(jUrlStr);
     env->DeleteLocalRef(jInputStr);
     env->DeleteLocalRef(jDefaultStr);
-    env->DeleteLocalRef(jUrlStr);
     checkException(env);
 
     // If returnVal is null, it means that the user cancelled the dialog.
@@ -3399,6 +3399,7 @@ bool WebViewCore::jsPrompt(const WTF::String& url, const WTF::String& text, cons
         return false;
 
     result = jstringToWtfString(env, returnVal);
+    env->DeleteLocalRef(returnVal);
     return true;
 }