summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSteve Block <steveblock@google.com>2010-02-04 06:55:40 -0800
committerAndroid (Google) Code Review <android-gerrit@google.com>2010-02-04 06:55:40 -0800
commit3db770bd97c5a59b6c7574ca80a39e5a51c1defd (patch)
tree5a34a5e6b794092738c2288158ad29a367579c71
parent3c0ba7aa180a1d6aae9a7f69a5d18261d2afb0a7 (diff)
parentf125a429feba24f77e5b1c6cda4dfadcbe50aa16 (diff)
downloadexternal_webkit-3db770bd97c5a59b6c7574ca80a39e5a51c1defd.zip
external_webkit-3db770bd97c5a59b6c7574ca80a39e5a51c1defd.tar.gz
external_webkit-3db770bd97c5a59b6c7574ca80a39e5a51c1defd.tar.bz2
Merge "Renames a variable in AddJavascriptInterface which shadows a parameter of the same name"
-rw-r--r--WebKit/android/jni/WebCoreFrameBridge.cpp6
1 files changed, 3 insertions, 3 deletions
diff --git a/WebKit/android/jni/WebCoreFrameBridge.cpp b/WebKit/android/jni/WebCoreFrameBridge.cpp
index 84cd70c..2e1d110 100644
--- a/WebKit/android/jni/WebCoreFrameBridge.cpp
+++ b/WebKit/android/jni/WebCoreFrameBridge.cpp
@@ -1308,8 +1308,8 @@ static void AddJavascriptInterface(JNIEnv *env, jobject obj, jint nativeFramePoi
PassRefPtr<JavaInstance> addedObject = WeakJavaInstance::create(javascriptObj);
const char* name = getCharactersFromJStringInEnv(env, interfaceName);
// Pass ownership of the added object to bindToWindowObject.
- NPObject* obj = JavaInstanceToNPObject(addedObject.releaseRef());
- pFrame->script()->bindToWindowObject(pFrame, name, obj);
+ NPObject* npObject = JavaInstanceToNPObject(addedObject.releaseRef());
+ pFrame->script()->bindToWindowObject(pFrame, name, npObject);
// bindToWindowObject calls NPN_RetainObject on the
// returned one (see createV8ObjectForNPObject in V8NPObject.cpp).
// bindToWindowObject also increases obj's ref count and decreases
@@ -1321,7 +1321,7 @@ static void AddJavascriptInterface(JNIEnv *env, jobject obj, jint nativeFramePoi
// we use WebCore/bindings/v8/npruntime.cpp (rather than
// WebCore/bridge/npruntime.cpp), so the function is implemented there.
// TODO: Combine the two versions of these NPAPI files.
- NPN_ReleaseObject(obj);
+ NPN_ReleaseObject(npObject);
releaseCharactersForJString(interfaceName, name);
}
#endif