activeDocumentLoader() causes crash in WebCoreFrameBridge.cpp

This is a fix for a crash found in real phones, there is cases when
activeDocumentLoader() can return null, probably related to closing of a
frame or canceling of a request.

Change-Id: Id340ab006b6e40e396645a4e668dcb58824a63e7

1 files changed, 13 insertions, 2 deletions

diff --git a/WebKit/android/jni/WebCoreFrameBridge.cpp b/WebKit/android/jni/WebCoreFrameBridge.cpp
index 250ffc9..c7f9eca 100644
--- a/WebKit/android/jni/WebCoreFrameBridge.cpp
+++ b/WebKit/android/jni/WebCoreFrameBridge.cpp
@@ -529,7 +529,12 @@ WebFrame::loadStarted(WebCore::Frame* frame)
 #ifdef ANDROID_INSTRUMENT
     TimeCounterAuto counter(TimeCounter::JavaCallbackTimeCounter);
 #endif
-    const WebCore::KURL& url = frame->loader()->activeDocumentLoader()->url();
+    // activeDocumentLoader() can return null.
+    DocumentLoader* documentLoader = frame->loader()->activeDocumentLoader();
+    if (documentLoader == NULL)
+        return;
+
+    const WebCore::KURL& url = documentLoader->url();
     if (url.isEmpty())
         return;
     LOGV("::WebCore:: loadStarted %s", url.string().ascii().data());
@@ -595,8 +600,14 @@ WebFrame::didFinishLoad(WebCore::Frame* frame)
     TimeCounterAuto counter(TimeCounter::JavaCallbackTimeCounter);
 #endif
     JNIEnv* env = getJNIEnv();
+
+    // activeDocumentLoader() can return null.
     WebCore::FrameLoader* loader = frame->loader();
-    const WebCore::KURL& url = loader->activeDocumentLoader()->url();
+    DocumentLoader* documentLoader = loader->activeDocumentLoader();
+    if (documentLoader == NULL)
+      return;
+
+    const WebCore::KURL& url = documentLoader->url();
     if (url.isEmpty())
         return;
     LOGV("::WebCore:: didFinishLoad %s", url.string().ascii().data());