diff options
| author | Grace Kloba <klobag@google.com> | 2009-10-20 16:08:58 -0700 |
|---|---|---|
| committer | Grace Kloba <klobag@google.com> | 2009-10-20 16:08:58 -0700 |
| commit | 87689f70d66dc2559c19e60ab6f759874eeea56a (patch) | |
| tree | 83716a996cfe39293616e750cf5b1098c5fd6e7a | |
| parent | e99015639226215f6e9089a7a49b196e40e625f0 (diff) | |
| download | external_webkit-87689f70d66dc2559c19e60ab6f759874eeea56a.zip external_webkit-87689f70d66dc2559c19e60ab6f759874eeea56a.tar.gz external_webkit-87689f70d66dc2559c19e60ab6f759874eeea56a.tar.bz2 | |
Back in 02/08 when we added android_atomic_inc/dec, for
some reason, it missed define WTF_USE_LOCKFREE_THREADSAFESHARED.
So we are using mutexlocker instead of refcount inc/dec.
Even mutex version should work, but it is not exercised
by win/darwin/gcc. Changing to use refcount version fixed
the crash seen in picasaweb.
Fix http://b/issue?id=2183371
Maybe fix http://b/issue?id=2165237. But I can't verify
as I can't reproduce it even before my change.
| -rw-r--r-- | JavaScriptCore/wtf/Threading.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/JavaScriptCore/wtf/Threading.h b/JavaScriptCore/wtf/Threading.h index bbfe8b5..95a0603 100644 --- a/JavaScriptCore/wtf/Threading.h +++ b/JavaScriptCore/wtf/Threading.h @@ -235,6 +235,7 @@ inline void atomicIncrement(int volatile* addend) { OSAtomicIncrement32Barrier(c inline int atomicDecrement(int volatile* addend) { return OSAtomicDecrement32Barrier(const_cast<int*>(addend)); } #elif defined ANDROID +#define WTF_USE_LOCKFREE_THREADSAFESHARED 1 inline void atomicIncrement(int volatile* addend) { android_atomic_inc(addend); } inline int atomicDecrement(int volatile* addend) { return android_atomic_dec(addend); } |