diff options
| author | Steve Block <steveblock@google.com> | 2011-05-20 11:51:35 +0100 |
|---|---|---|
| committer | Steve Block <steveblock@google.com> | 2011-05-20 13:19:51 +0100 |
| commit | f2f7d373c9827c5c27771dfda4ca627f173fbe10 (patch) | |
| tree | 93f19ca0d83ce2060f71ec8964fd6e76436cf289 /Source/WebCore/Android.derived.v8bindings.mk | |
| parent | 8d8e15107907178b19f50a476bb610afc97a3c07 (diff) | |
| download | external_webkit-f2f7d373c9827c5c27771dfda4ca627f173fbe10.zip external_webkit-f2f7d373c9827c5c27771dfda4ca627f173fbe10.tar.gz external_webkit-f2f7d373c9827c5c27771dfda4ca627f173fbe10.tar.bz2 | |
Do not process Inspector.idl using the V8 or JSC code generator
Unlike the other Inspector IDL files, Inspector.idl should not be
processed using the V8 or JSC code generator. Instead, it should use
the Inspector code generator.
See http://trac.webkit.org/changeset/62549, which introduced
CodeGeneratorInspector.pm. This change added InspectorFrontend2.idl,
which was later renamed to Inspector.idl.
In fact, we do not require V8/JSCInspector.cpp/h, so we can simply
remove Inspector.idl from our build.
Using the V8 or JSC code generator with Inspector.idl causes incorrect
output. Currently, this does not break our build as the generated
header is not required. However, from
http://trac.webkit.org/changeset/78212 onwards, a side-effect of this
incorrect output is that other, valid, generated files are overridden
with empty files, thus breaking the build.
Change-Id: Ib103214e65cfe43fba8dbf7befb6dcd5e7c81434
Diffstat (limited to 'Source/WebCore/Android.derived.v8bindings.mk')
| -rw-r--r-- | Source/WebCore/Android.derived.v8bindings.mk | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/Source/WebCore/Android.derived.v8bindings.mk b/Source/WebCore/Android.derived.v8bindings.mk index d708f63..e6ac529 100644 --- a/Source/WebCore/Android.derived.v8bindings.mk +++ b/Source/WebCore/Android.derived.v8bindings.mk @@ -661,10 +661,10 @@ $(patsubst %.h,%.cpp,$(GEN)): $(intermediates)/bindings/%.cpp : $(intermediates) #end # Inspector -# These headers are required by the V8 bindings even when Inspector is disabled +# These headers are required by the V8 bindings even when Inspector is disabled. +# Note that Inspector.idl should not be processed using the V8 generator. GEN := \ $(intermediates)/bindings/V8InjectedScriptHost.h \ - $(intermediates)/bindings/V8Inspector.h \ $(intermediates)/bindings/V8InspectorFrontendHost.h \ $(intermediates)/bindings/V8ScriptProfile.h |