diff options
author | Steve Block <steveblock@google.com> | 2011-05-25 08:15:24 -0700 |
---|---|---|
committer | Android (Google) Code Review <android-gerrit@google.com> | 2011-05-25 08:15:24 -0700 |
commit | fa91a01aee5d4a80ca6c80f722116b850f09996c (patch) | |
tree | f72740e60d3c3d4f0ab144e88c03d1f134944ce3 /Source/WebCore/bindings/js/ScriptDebugServer.cpp | |
parent | 96f37d6d1b390f6690858789706ee6ec25bc1677 (diff) | |
parent | feebf8e7a79ad68b04a1a948e2b8078d6e5f0048 (diff) | |
download | external_webkit-fa91a01aee5d4a80ca6c80f722116b850f09996c.zip external_webkit-fa91a01aee5d4a80ca6c80f722116b850f09996c.tar.gz external_webkit-fa91a01aee5d4a80ca6c80f722116b850f09996c.tar.bz2 |
Merge changes I78ff6a85,Ic85c6405,Ibf903baa,I3a0459db,I35140385,I54790419,I6bfe5d24,Ia9f39b83,I5bcecd5a,I1de96683,I543c6810,I8a5b0878,I0ae670bf,Ide4d58dc,I28ebaf3d,I499d6631,Ie5090e0d,I6d3e5f1f
* changes:
Merge WebKit at r78450: Update ThirdPartyProject.prop
Merge WebKit at r78450: Add new Font::canExpandAroundIdeographsInComplexText()
Merge WebKit at r78450: Add new ChromeClient::selectItemAlignmentFollowsMenuWritingDirection()
Merge WebKit at r78450: FrameLoaderClient::didRunInsecureContent() signature changed
Merge WebKit at r78450: HTMLAreaElement::getRect() renamed
Merge WebKit at r78450: FrameLoader::url() removed
Merge WebKit at r78450: HTMLParserQuirks removed
Merge WebKit at r78450: TextRun::padding() renamed
Merge WebKit at r78450: Use new FontMetrics
Merge WebKit at r78450: GraphicsContext current path removed
Merge WebKit at r78450: TransformationMatrix multiply methods renamed and meaning changed
Merge WebKit at r78450: FontCustomPlatformData::fontPlatformData() signature changed
Merge WebKit at r78450: IntRect::bottom()/right() renamed
Merge WebKit at r78450: Fix remaining conflicts
Merge WebKit at r78450: Fix conflicts due to new ENABLE_WEB_ARCHIVE guard
Merge WebKit at r78450: Fix conflicts in media controls
Merge WebKit at r78450: Fix Makefiles
Merge WebKit at r78450: Initial merge by git.
Diffstat (limited to 'Source/WebCore/bindings/js/ScriptDebugServer.cpp')
-rw-r--r-- | Source/WebCore/bindings/js/ScriptDebugServer.cpp | 46 |
1 files changed, 17 insertions, 29 deletions
diff --git a/Source/WebCore/bindings/js/ScriptDebugServer.cpp b/Source/WebCore/bindings/js/ScriptDebugServer.cpp index b516f6d..aed2ad4 100644 --- a/Source/WebCore/bindings/js/ScriptDebugServer.cpp +++ b/Source/WebCore/bindings/js/ScriptDebugServer.cpp @@ -117,20 +117,6 @@ void ScriptDebugServer::removeListener(ScriptDebugListener* listener, Page* page didRemoveListener(page); } -void ScriptDebugServer::pageCreated(Page* page) -{ - ASSERT_ARG(page, page); - - if (!hasListenersInterestedInPage(page)) - return; - page->setDebugger(this); -} - -bool ScriptDebugServer::isDebuggerAlwaysEnabled() -{ - return false; -} - bool ScriptDebugServer::hasListenersInterestedInPage(Page* page) { ASSERT_ARG(page, page); @@ -138,19 +124,21 @@ bool ScriptDebugServer::hasListenersInterestedInPage(Page* page) return m_pageListenersMap.contains(page); } -String ScriptDebugServer::setBreakpoint(const String& sourceID, unsigned lineNumber, const String& condition, bool enabled, unsigned* actualLineNumber) +String ScriptDebugServer::setBreakpoint(const String& sourceID, const ScriptBreakpoint& scriptBreakpoint, int* actualLineNumber, int* actualColumnNumber) { intptr_t sourceIDValue = sourceID.toIntPtr(); if (!sourceIDValue) return ""; - BreakpointsMap::iterator it = m_breakpoints.find(sourceIDValue); - if (it == m_breakpoints.end()) - it = m_breakpoints.set(sourceIDValue, SourceBreakpoints()).first; - if (it->second.contains(lineNumber)) + SourceIdToBreakpointsMap::iterator it = m_sourceIdToBreakpoints.find(sourceIDValue); + if (it == m_sourceIdToBreakpoints.end()) + it = m_sourceIdToBreakpoints.set(sourceIDValue, LineToBreakpointMap()).first; + if (it->second.contains(scriptBreakpoint.lineNumber + 1)) return ""; - it->second.set(lineNumber, ScriptBreakpoint(enabled, condition)); - *actualLineNumber = lineNumber; - return makeString(sourceID, ":", String::number(lineNumber)); + it->second.set(scriptBreakpoint.lineNumber + 1, scriptBreakpoint); + *actualLineNumber = scriptBreakpoint.lineNumber; + // FIXME(WK53003): implement setting breakpoints by line:column. + *actualColumnNumber = 0; + return makeString(sourceID, ":", String::number(scriptBreakpoint.lineNumber)); } void ScriptDebugServer::removeBreakpoint(const String& breakpointId) @@ -166,9 +154,9 @@ void ScriptDebugServer::removeBreakpoint(const String& breakpointId) unsigned lineNumber = tokens[1].toUInt(&success); if (!success) return; - BreakpointsMap::iterator it = m_breakpoints.find(sourceIDValue); - if (it != m_breakpoints.end()) - it->second.remove(lineNumber); + SourceIdToBreakpointsMap::iterator it = m_sourceIdToBreakpoints.find(sourceIDValue); + if (it != m_sourceIdToBreakpoints.end()) + it->second.remove(lineNumber + 1); } bool ScriptDebugServer::hasBreakpoint(intptr_t sourceID, unsigned lineNumber) const @@ -176,10 +164,10 @@ bool ScriptDebugServer::hasBreakpoint(intptr_t sourceID, unsigned lineNumber) co if (!m_breakpointsActivated) return false; - BreakpointsMap::const_iterator it = m_breakpoints.find(sourceID); - if (it == m_breakpoints.end()) + SourceIdToBreakpointsMap::const_iterator it = m_sourceIdToBreakpoints.find(sourceID); + if (it == m_sourceIdToBreakpoints.end()) return false; - SourceBreakpoints::const_iterator breakIt = it->second.find(lineNumber); + LineToBreakpointMap::const_iterator breakIt = it->second.find(lineNumber); if (breakIt == it->second.end() || !breakIt->second.enabled) return false; @@ -198,7 +186,7 @@ bool ScriptDebugServer::hasBreakpoint(intptr_t sourceID, unsigned lineNumber) co void ScriptDebugServer::clearBreakpoints() { - m_breakpoints.clear(); + m_sourceIdToBreakpoints.clear(); } void ScriptDebugServer::setBreakpointsActivated(bool activated) |