Always check weak global references before using them

We hold weak references to Java objects from native code in several
places to avoid circular reference problems. These objects may become
weakly reachable at any time, after which the GC could null our weak
reference, so we have to null-check at every use.

Note that weak references are nulled before the referent is finalized,
so we can't rely on doing work in the finalizer to wait for the
currently executing message to complete and to remove other messages
from the queue.

This effectively reverts
https://android-git.corp.google.com/g/#change,30955

Bug: 4336862
Change-Id: I431fcac11220cb406c26e31aacb9bda7ea22776e

1 files changed, 12 insertions, 5 deletions

diff --git a/Source/WebCore/platform/android/GeolocationServiceBridge.cpp b/Source/WebCore/platform/android/GeolocationServiceBridge.cpp
index 2e81b32..697b63b 100644
--- a/Source/WebCore/platform/android/GeolocationServiceBridge.cpp
+++ b/Source/WebCore/platform/android/GeolocationServiceBridge.cpp
@@ -87,21 +87,24 @@ GeolocationServiceBridge::~GeolocationServiceBridge()
 
 bool GeolocationServiceBridge::start()
 {
-    ASSERT(m_javaGeolocationServiceObject);
+    if (!m_javaGeolocationServiceObject)
+        return false;
     return getJNIEnv()->CallBooleanMethod(m_javaGeolocationServiceObject,
                                           javaGeolocationServiceClassMethodIDs[GeolocationServiceMethodStart]);
 }
 
 void GeolocationServiceBridge::stop()
 {
-    ASSERT(m_javaGeolocationServiceObject);
+    if (!m_javaGeolocationServiceObject)
+        return;
     getJNIEnv()->CallVoidMethod(m_javaGeolocationServiceObject,
                                 javaGeolocationServiceClassMethodIDs[GeolocationServiceMethodStop]);
 }
 
 void GeolocationServiceBridge::setEnableGps(bool enable)
 {
-    ASSERT(m_javaGeolocationServiceObject);
+    if (!m_javaGeolocationServiceObject)
+        return;
     getJNIEnv()->CallVoidMethod(m_javaGeolocationServiceObject,
                                 javaGeolocationServiceClassMethodIDs[GeolocationServiceMethodSetEnableGps],
                                 enable);
@@ -185,10 +188,13 @@ void GeolocationServiceBridge::startJavaImplementation(Frame* frame)
             env->GetMethodID(javaGeolocationServiceClass, "setEnableGps", "(Z)V");
 
     // Create the Java GeolocationService object.
+    jobject context = android::WebViewCore::getWebViewCore(frame->view())->getContext();
+    if (!context)
+        return;
     jlong nativeObject = reinterpret_cast<jlong>(this);
     jobject object = env->NewObject(javaGeolocationServiceClass,
                                     javaGeolocationServiceClassMethodIDs[GeolocationServiceMethodInit],
-                                    android::WebViewCore::getWebViewCore(frame->view())->getContext(),
+                                    context,
                                     nativeObject);
 
     m_javaGeolocationServiceObject = getJNIEnv()->NewGlobalRef(object);
@@ -232,7 +238,8 @@ void GeolocationServiceBridge::startJavaImplementation(Frame* frame)
 void GeolocationServiceBridge::stopJavaImplementation()
 {
     // Called by GeolocationServiceAndroid on WebKit thread.
-    ASSERT(m_javaGeolocationServiceObject);
+    if (!m_javaGeolocationServiceObject)
+        return;
     getJNIEnv()->DeleteGlobalRef(m_javaGeolocationServiceObject);
 }