diff options
| author | Steve Block <steveblock@google.com> | 2011-09-01 12:08:57 +0100 |
|---|---|---|
| committer | Steve Block <steveblock@google.com> | 2011-09-02 13:07:23 +0100 |
| commit | 70a54261052a5a78a33b5b91d4f3ab699b55e2ef (patch) | |
| tree | 9e67f3aa8c057ce4971736e8bee5eb3f90898f09 /Source/WebKit/android/jni/PictureSet.cpp | |
| parent | 24a08199b7204cfa19c1f61d93ea8df86d3bb99f (diff) | |
| download | external_webkit-70a54261052a5a78a33b5b91d4f3ab699b55e2ef.zip external_webkit-70a54261052a5a78a33b5b91d4f3ab699b55e2ef.tar.gz external_webkit-70a54261052a5a78a33b5b91d4f3ab699b55e2ef.tar.bz2 | |
Fix the Java bridge to correctly handle null strings
Passing null to methods expecting java/lang/String ...
- Previously null was converted to the empty string but should be
converted to Java null.
- convertNPVariantToJavaValue() already converts a null NPVariant to a
null WTF::String.
- Fixed javaValueToJvalue() to convert a null WTF::String to a null
jvalue.
Returning null from a method with return type java/lang/String ...
- Previously this would crash when trying to get the characters from
the null jstring, but should return JavaScript undefined.
- Fixed jvalueToJavaValue() to convert a null jvalue to a null
WTF::String.
- Fixed convertJavaValueToNPVariant() to convert a null WTF::String to
a void NPVariant.
Both of these are regressions from HC due to
http://trac.webkit.org/changeset/82194.
Added tests in https://android-git.corp.google.com/g/#/c/132580
Bug: 5222742
Change-Id: Id08bc7b40a51426fa7638ad0ed5260d09f3e28bb
Diffstat (limited to 'Source/WebKit/android/jni/PictureSet.cpp')
0 files changed, 0 insertions, 0 deletions