diff options
| author | Steve Block <steveblock@google.com> | 2011-07-07 18:48:21 +0100 |
|---|---|---|
| committer | Steve Block <steveblock@google.com> | 2011-07-08 11:15:43 +0100 |
| commit | 3bbdf589ce4def67f6fa976a6f7b310ed61baff1 (patch) | |
| tree | 9530f98f36b0193d8310cfa572557c51df859735 /Source/WebKit/android/jni/WebViewCore.cpp | |
| parent | 26c172852dc47910de9850e9e4b6d46687c1d1f0 (diff) | |
| download | external_webkit-3bbdf589ce4def67f6fa976a6f7b310ed61baff1.zip external_webkit-3bbdf589ce4def67f6fa976a6f7b310ed61baff1.tar.gz external_webkit-3bbdf589ce4def67f6fa976a6f7b310ed61baff1.tar.bz2 | |
Delete a JNI local ref in WebViewCore::openFileChooser()
Change-Id: I3a488125d86a4f8cc63691ae7035cad0eadaf514
Diffstat (limited to 'Source/WebKit/android/jni/WebViewCore.cpp')
| -rw-r--r-- | Source/WebKit/android/jni/WebViewCore.cpp | 13 |
1 files changed, 4 insertions, 9 deletions
diff --git a/Source/WebKit/android/jni/WebViewCore.cpp b/Source/WebKit/android/jni/WebViewCore.cpp index 966a540..1c51b14 100644 --- a/Source/WebKit/android/jni/WebViewCore.cpp +++ b/Source/WebKit/android/jni/WebViewCore.cpp @@ -2971,16 +2971,11 @@ void WebViewCore::openFileChooser(PassRefPtr<WebCore::FileChooser> chooser) checkException(env); env->DeleteLocalRef(jAcceptType); - const UChar* string = static_cast<const UChar*>(env->GetStringChars(jName, 0)); + WTF::String wtfString = jstringToWtfString(env, jName); + env->DeleteLocalRef(jName); - if (!string) - return; - - WTF::String webcoreString = jstringToWtfString(env, jName); - env->ReleaseStringChars(jName, string); - - if (webcoreString.length()) - chooser->chooseFile(webcoreString); + if (!wtfString.isEmpty()) + chooser->chooseFile(wtfString); } void WebViewCore::listBoxRequest(WebCoreReply* reply, const uint16_t** labels, size_t count, const int enabled[], size_t enabledCount, |