diff options
| author | Victoria Lease <violets@google.com> | 2012-01-26 17:24:36 -0800 |
|---|---|---|
| committer | Victoria Lease <violets@google.com> | 2012-01-27 09:25:30 -0800 |
| commit | 5b3bd4dbbb7d51b2c82d9ca57a2b9da362562697 (patch) | |
| tree | eacd5ec3519c0b26a017f0b17c4c1d86d056d20f /Source/WebKit/android/nav/WebView.cpp | |
| parent | 4fc7022b72b41f3959f1aa2651b38bb3209b01d5 (diff) | |
| download | external_webkit-5b3bd4dbbb7d51b2c82d9ca57a2b9da362562697.zip external_webkit-5b3bd4dbbb7d51b2c82d9ca57a2b9da362562697.tar.gz external_webkit-5b3bd4dbbb7d51b2c82d9ca57a2b9da362562697.tar.bz2 | |
Do not share SkPicture* between WebViewCore and CachedRoot.
Bug: 5879729
WebViewCore was in the rather naughty habit of forcefully deleting an
SkPicture pointer that was currently in use by CachedRoot on the UI
thread. It isn't even necessary for WebViewCore to hold this pointer
once it has been fed to the CachedRoot, so I have transferred ownership
to the CachedRoot itself, who instead of forcefully deleting the
SkPicture simply unref()s it when it is finished. This addresses the
nasty crashes we've been seeing when the UI thread attempts to do
something with the SkPicture that has been deleted behind its back by
the WebKit thread.
Change-Id: Ifb364f822fc03d2c3813b2edb2b038124c65fc1f
Diffstat (limited to 'Source/WebKit/android/nav/WebView.cpp')
0 files changed, 0 insertions, 0 deletions