diff options
author | Steve Block <steveblock@google.com> | 2011-06-08 08:26:01 -0700 |
---|---|---|
committer | Android (Google) Code Review <android-gerrit@google.com> | 2011-06-08 08:26:01 -0700 |
commit | 3742ac093d35d923c81693096ab6671e9b147700 (patch) | |
tree | c2add9100f789dad45ef1ec5328bddde02c47a4c /Source/WebKit/win/WebIconDatabase.cpp | |
parent | 901401d90459bc22580842455d4588b9a697514d (diff) | |
parent | e5926f4a0d6adc9ad4a75824129f117181953560 (diff) | |
download | external_webkit-3742ac093d35d923c81693096ab6671e9b147700.zip external_webkit-3742ac093d35d923c81693096ab6671e9b147700.tar.gz external_webkit-3742ac093d35d923c81693096ab6671e9b147700.tar.bz2 |
Merge changes I55c6d71a,Ifb3277d4,Ia1b847a2,I7ba9cf3f,Ida2b2a8a,I1280ec90,I72f818d5,I2e3b588b,I9a4e6289,Ia724c78b,Icd8612c8,Ie31b15d7,Ie125edae,I77941a88,I89dae78b,I3516e5ca,I1a4c17b5,I2c4ecc1a,I9c8e6537,Ifac13115,Ie1f80e09,Ia541ed77,I60ce9d78
* changes:
Merge WebKit at r82507: Update ThirdPartyProject.prop
Merge WebKit at r82507: Cherry-pick change r88166 to add INSPECTOR guards to ScriptProfiler
Merge WebKit at r82507: Work around a V8 bug
Merge WebKit at r82507: JNIType renamed to JavaType
Merge WebKit at r82507: IconDatabaseClient interface expanded
Merge WebKit at r82507: Don't use new loss-free code path in HTMLCanvasElement::toDataURL()
Merge WebKit at r82507: IcondDatabaseBase::iconForPageURL() renamed
Merge WebKit at r82507: IconDatabaseBase::Open() signature changed
Merge WebKit at r82507: Node::isContentEditable() renamed
Merge WebKit at r82507: Use icon database through IconDatabaseBase
Merge WebKit at r82507: toInputElement() is now a member of Node
Merge WebKit at r82507: FrameLoaderClient::objectContentType() signature changed
Merge WebKit at r82507: StringImpl::computeHash() removed
Merge WebKit at r82507: Stub out FontPlatformData::setOrientation()
Merge WebKit at r82507: Path::strokeBoundingRect() is now const
Merge WebKit at r82507: Add missing UnusedParam.h include in ApplicationCacheGroup.cpp
Merge WebKit at r82507: Continue to use Android's version of FontPlatformData.h
Merge WebKit at r82507: Update signature of FontCustomPlatformData::fontPlatformData()
Merge WebKit at r82507: Fix conflicts due to JNI refactoring
Merge WebKit at r82507: Fix conflicts due to new StorageTracker
Merge WebKit at r82507: Fix conflicts
Merge WebKit at r82507: Fix makefiles
Merge WebKit at r82507: Initial merge by git
Diffstat (limited to 'Source/WebKit/win/WebIconDatabase.cpp')
-rw-r--r-- | Source/WebKit/win/WebIconDatabase.cpp | 41 |
1 files changed, 31 insertions, 10 deletions
diff --git a/Source/WebKit/win/WebIconDatabase.cpp b/Source/WebKit/win/WebIconDatabase.cpp index 5ccf0b7..24e8f41 100644 --- a/Source/WebKit/win/WebIconDatabase.cpp +++ b/Source/WebKit/win/WebIconDatabase.cpp @@ -31,14 +31,13 @@ #include "COMPtr.h" #include "WebPreferences.h" #include "WebNotificationCenter.h" -#pragma warning(push, 0) #include <WebCore/BitmapInfo.h> #include <WebCore/BString.h> #include <WebCore/FileSystem.h> #include <WebCore/IconDatabase.h> #include <WebCore/Image.h> #include <WebCore/PlatformString.h> -#pragma warning(pop) +#include <WebCore/SharedBuffer.h> #include <wtf/MainThread.h> #include "shlobj.h" @@ -97,7 +96,7 @@ void WebIconDatabase::startUpIconDatabase() LOG_ERROR("Failed to construct default icon database path"); } - if (!iconDatabase().open(databasePath)) + if (!iconDatabase().open(databasePath, WebCore::IconDatabase::defaultDatabaseFilename())) LOG_ERROR("Failed to open icon database path"); } @@ -172,7 +171,7 @@ HRESULT STDMETHODCALLTYPE WebIconDatabase::iconForURL( Image* icon = 0; if (url) - icon = iconDatabase().iconForPageURL(String(url, SysStringLen(url)), intSize); + icon = iconDatabase().synchronousIconForPageURL(String(url, SysStringLen(url)), intSize); // Make sure we check for the case of an "empty image" if (icon && icon->width()) { @@ -234,7 +233,7 @@ HRESULT STDMETHODCALLTYPE WebIconDatabase::iconURLForURL( { if (!url || !iconURL) return E_POINTER; - BString iconURLBSTR(iconDatabase().iconURLForPageURL(String(url, SysStringLen(url)))); + BString iconURLBSTR(iconDatabase().synchronousIconURLForPageURL(String(url, SysStringLen(url)))); *iconURL = iconURLBSTR.release(); return S_OK; } @@ -272,11 +271,11 @@ HRESULT STDMETHODCALLTYPE WebIconDatabase::hasIconForURL( // Passing a size parameter of 0, 0 means we don't care about the result of the image, we just // want to make sure the read from disk to load the icon is kicked off. - iconDatabase().iconForPageURL(urlString, IntSize(0, 0)); + iconDatabase().synchronousIconForPageURL(urlString, IntSize(0, 0)); // Check to see if we have a non-empty icon URL for the page, and if we do, we have an icon for // the page. - *result = !(iconDatabase().iconURLForPageURL(urlString).isEmpty()); + *result = !(iconDatabase().synchronousIconURLForPageURL(urlString).isEmpty()); return S_OK; } @@ -320,7 +319,13 @@ HBITMAP WebIconDatabase::getOrCreateDefaultIconBitmap(LPSIZE size) // IconDatabaseClient -void WebIconDatabase::dispatchDidRemoveAllIcons() +bool WebIconDatabase::performImport() +{ + // Windows doesn't do any old-style database importing. + return true; +} + +void WebIconDatabase::didRemoveAllIcons() { // Queueing the empty string is a special way of saying "this queued notification is the didRemoveAllIcons notification" MutexLocker locker(m_notificationMutex); @@ -328,13 +333,29 @@ void WebIconDatabase::dispatchDidRemoveAllIcons() scheduleNotificationDelivery(); } -void WebIconDatabase::dispatchDidAddIconForPageURL(const String& pageURL) -{ +void WebIconDatabase::didImportIconURLForPageURL(const WTF::String& pageURL) +{ MutexLocker locker(m_notificationMutex); m_notificationQueue.append(pageURL.threadsafeCopy()); scheduleNotificationDelivery(); } +void WebIconDatabase::didImportIconDataForPageURL(const WTF::String& pageURL) +{ + // WebKit1 only has a single "icon did change" notification. + didImportIconURLForPageURL(pageURL); +} + +void WebIconDatabase::didChangeIconForPageURL(const WTF::String& pageURL) +{ + // WebKit1 only has a single "icon did change" notification. + didImportIconURLForPageURL(pageURL); +} + +void WebIconDatabase::didFinishURLImport() +{ +} + void WebIconDatabase::scheduleNotificationDelivery() { // Caller of this method must hold the m_notificationQueue lock |