Fix a memory leak caused by the binding code.

Old code reinitialize a context when a frame loading a new page, even when the page does not have JavaScript. It also initializes an empty context when before an iframe is destroyed.

A fix is made to Chromium project (not it is in WebKit), our next merge should pick up this fix.

1 files changed, 1 insertions, 7 deletions

diff --git a/V8Binding/binding/v8_proxy.cpp b/V8Binding/binding/v8_proxy.cpp
index 2d5ee4c..c0de3c6 100644
--- a/V8Binding/binding/v8_proxy.cpp
+++ b/V8Binding/binding/v8_proxy.cpp
@@ -1966,10 +1966,6 @@ void V8Proxy::clearForNavigation()
         m_context->DetachGlobal();
 
         DisposeContextHandles();
-
-        // Reinitialize the context so the global object points to
-        // the new DOM window.
-        InitContextIfNeeded();
     }
 }
 
@@ -2015,10 +2011,8 @@ void V8Proxy::updateDocument()
     if (!m_frame->document())
         return;
 
-    if (m_global.IsEmpty()) {
-        ASSERT(m_context.IsEmpty());
+    if (m_context.IsEmpty())
         return;
-    }
 
     // We have a new document and we need to update the cache.
     UpdateDocumentWrapperCache();