summaryrefslogtreecommitdiffstats
path: root/WebCore/ChangeLog
diff options
context:
space:
mode:
authorBen Murdoch <benm@google.com>2010-05-11 18:35:50 +0100
committerBen Murdoch <benm@google.com>2010-05-14 10:23:05 +0100
commit21939df44de1705786c545cd1bf519d47250322d (patch)
treeef56c310f5c0cdc379c2abb2e212308a3281ce20 /WebCore/ChangeLog
parent4ff1d8891d520763f17675827154340c7c740f90 (diff)
downloadexternal_webkit-21939df44de1705786c545cd1bf519d47250322d.zip
external_webkit-21939df44de1705786c545cd1bf519d47250322d.tar.gz
external_webkit-21939df44de1705786c545cd1bf519d47250322d.tar.bz2
Merge Webkit at r58956: Initial merge by Git.
Change-Id: I1d9fb60ea2c3f2ddc04c17a871acdb39353be228
Diffstat (limited to 'WebCore/ChangeLog')
-rw-r--r--WebCore/ChangeLog7746
1 files changed, 7742 insertions, 4 deletions
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 9700ffe..c6bf40b 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,7741 @@
+2010-05-07 Pavel Feldman <pfeldman@chromium.org>
+
+ Not reviewed: chromium dev tools tests fix.
+ Add a more strict check prior to accessing constructor property in
+ Web Inspector frontend.
+
+ * inspector/front-end/InjectedScript.js:
+ (injectedScriptConstructor):
+
+2010-05-07 Pavel Feldman <pfeldman@chromium.org>
+
+ Reviewed by Joseph Pecoraro.
+
+ Web Inspector: On Linux/Windows panel history is
+ traversed while iterating over words in text prompt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=38740
+
+ * inspector/front-end/TextPrompt.js:
+ (WebInspector.TextPrompt):
+ * inspector/front-end/inspector.js:
+ (WebInspector.documentKeyDown):
+
+2010-05-07 Pavel Feldman <pfeldman@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ Web Inspector: come up with InjectedScript._className that works for both JSC and V8.
+
+ https://bugs.webkit.org/show_bug.cgi?id=38755
+
+ * inspector/front-end/InjectedScript.js:
+ (injectedScriptConstructor):
+
+2010-05-07 Joseph Pecoraro <joepeck@webkit.org>
+
+ Reviewed by Adam Barth.
+
+ document.write is not synchronous after page load
+ https://bugs.webkit.org/show_bug.cgi?id=38146
+
+ If there are no pending scripts, a document.write call should be
+ synchronous. This matches other browsers and the HTML5 spec. Forcing
+ the tokenizer to be synchronous in Document::write does not affect
+ external scripts written by the write call. This should only change
+ behavior of document.write after the page is done loading.
+
+ Difficult to test reliably due to HTMLTokenizing relying on processing time.
+ I made a manual test because the test requires processing very large strings
+ synchronously and therefore can take some time.
+
+ Test: WebCore/manual-tests/dom/document-write-synchronous-after-page-load.html
+
+ * dom/Document.cpp:
+ (WebCore::SynchronousHTMLTokenizerGuard::SynchronousHTMLTokenizerGuard): if the provided tokenizer is an HTMLTokenizer make it synchronous
+ (WebCore::SynchronousHTMLTokenizerGuard::~SynchronousHTMLTokenizerGuard): if the provided tokenizer was an HTMLTokenizer return its synchronous state
+ (WebCore::Document::write): temporarily set the tokenizer to synchronous during document.write
+ * dom/Tokenizer.h:
+ (WebCore::Tokenizer::asHTMLTokenizer): default implementation returns 0, to be overridden by HTMLTokenizer
+ * html/HTMLTokenizer.h: allow access to to the force synchronous state
+ (WebCore::HTMLTokenizer::forceSynchronous): accessor
+ (WebCore::HTMLTokenizer::asHTMLTokenizer): override the default to return itself
+ * manual-tests/dom/document-write-synchronous-after-page-load.html: Added.
+
+2010-05-07 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] Fix rendering of -webkit-user-select: none
+
+ -webkit-user-select: none is implemented by filling
+ the area with an invalid default-constructed Color.
+ In most ports passing an invalid color down to the
+ graphics backend seems to produce transparent fills.
+
+ In Qt the behavior of painting with an invalid QColor
+ is undefined, and in practice it results in painting
+ black opaque areas.
+
+ One way to fix this would be to use Qt::transparent
+ when converting an undefined Color to a QColor, but
+ Qt does not have short circuits for fully transparent
+ painting, and we actually end up in slow code paths
+ due to the transparency. So, we're better of doing the
+ short circuit in WebKit.
+
+ https://bugs.webkit.org/show_bug.cgi?id=38523
+
+ * platform/graphics/qt/GraphicsContextQt.cpp:
+
+2010-05-07 Ben Murdoch <benm@google.com>
+
+ Reviewed by Darin Adler.
+
+ Potential crash in EventHandler::handleTouchEvent
+ https://bugs.webkit.org/show_bug.cgi?id=38646
+
+ Fix a ref counting bug that can cause a crash if the m_originatingouchPointTargets
+ hashmap holds the last ref to an EventTarget when the user lifts their finger.
+
+ This is very hard to reproduce in a consistent way and clearly a
+ simple logic error in the code, therefore no new tests.
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::handleTouchEvent): Don't let the RefPtr we get back from
+ the hasmap go out of scope so soon as it could delete the wrapped ptr if the
+ hashmap held the last ref (and we use the raw ptr that the RefPtr
+ wraps later in the WebCore::Touch constructor).
+
+2010-05-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
+
+ Rubber-stamped by Kenneth Rohde Christiansen.
+
+ [GTK] Fails to build on GTK+ < 2.14
+ https://bugs.webkit.org/show_bug.cgi?id=38746
+
+ Build fix only. Do basically the same as gtk_adjustment_configure
+ would do if we are bellow GTK+ 2.14.
+
+ * platform/gtk/ScrollViewGtk.cpp:
+ (WebCore::AdjustmentConfigure):
+
+2010-05-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
+
+ Rubber-stamped by Xan Lopez.
+
+ Crash with MgOpenModerna font, with non-UTF-8 character
+ https://bugs.webkit.org/show_bug.cgi?id=37795
+
+ NULL-check the font platform data, for now, to avoid the crash.
+
+ Could not yet figure out a way to get a test written that does not
+ involve adding the font to the tree, but there are doubts about
+ licensing.
+
+ * platform/graphics/cairo/FontCacheCairo.cpp:
+ (WebCore::FontCache::getFontDataForCharacters):
+
+2010-05-07 MORITA Hajime <morrita@google.com>
+
+ Reviewed by Eric Seidel.
+
+ [Chromium] RenderThemeChromiumMac.mm should share the code with RenderThemeMac.mm
+ https://bugs.webkit.org/show_bug.cgi?id=37204
+
+ Made RenderThemeChromiumMac subclass of RenderThemeMac, instead of RenderTheme.
+ Added some method to RenderThemeMac for overriding on RenderThemeChromiumMac.
+
+ No new tests; Should have no behavioural change.
+
+ * WebCore.gyp/WebCore.gyp:
+ * rendering/RenderThemeChromiumMac.h:
+ * rendering/RenderThemeChromiumMac.mm:
+ (WebCore::RenderThemeChromiumMac::usesTestModeFocusRingColor):
+ (WebCore::RenderThemeChromiumMac::documentViewFor):
+ (WebCore::RenderThemeChromiumMac::adjustMediaSliderThumbSize):
+ (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderTrack):
+ (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderThumb):
+ * rendering/RenderThemeMac.h:
+ (WebCore::RenderThemeMac::updateActiveState): Added for overriding
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderThemeMac::usesTestModeFocusRingColor): Added for overriding
+ (WebCore::RenderThemeMac::documentViewFor): Added for overriding
+ (WebCore::RenderThemeMac::paintMenuList):
+ (WebCore::RenderThemeMac::setPopupButtonCellState):
+ (WebCore::RenderThemeMac::paintSliderThumb):
+ (WebCore::RenderThemeMac::paintSearchField):
+ (WebCore::RenderThemeMac::setSearchCellState):
+ (WebCore::RenderThemeMac::paintSearchFieldCancelButton):
+ (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
+ (WebCore::RenderThemeMac::paintSearchFieldResultsButton):
+ (WebCore::RenderThemeMac::adjustSliderThumbSize):
+ (WebCore::RenderThemeMac::adjustMediaSliderThumbSize): Added for overriding
+ (WebCore::RenderThemeMac::extraMediaControlsStyleSheet):
+
+2010-05-06 Fumitoshi Ukai <ukai@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ JavaScriptCore/wtf/RandomNumber.h should provide using WTF::*
+ https://bugs.webkit.org/show_bug.cgi?id=38719
+
+ * platform/graphics/wince/FontCustomPlatformData.cpp:
+ (WebCore::createUniqueFontName):
+ Remove WTF:: prefix from randomNumber()
+ * platform/network/FormDataBuilder.cpp:
+ (WebCore::FormDataBuilder::generateUniqueBoundaryString):
+ Ditto.
+
+2010-04-27 Tony Chang <tony@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ [chromium] clicking a scrollbar in an iframe shouldn't lose the selection
+ https://bugs.webkit.org/show_bug.cgi?id=38189
+
+ Test: fast/events/mousedown-in-subframe-scrollbar.html
+
+ * page/chromium/EventHandlerChromium.cpp:
+ (WebCore::EventHandler::passMousePressEventToSubframe): If clicking on
+ a scrollbar, pass the event directly to the scrollbar. This matches
+ mac which passes the event to the NSScroller.
+
+2010-05-06 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Compositing layers that are clipped out by an overflow:scroll parent fail to get created on reveal
+ https://bugs.webkit.org/show_bug.cgi?id=38712
+
+ When compositing layer creation is testing layer overlap, we need to re-run the
+ algorithm when an overflow:scroll element scrolls, to create new layers for revealed
+ elements.
+
+ Test: compositing/layer-creation/overflow-scroll-overlap.html
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::scrollToOffset): First, move the compositing updates
+ until after the call to updateWidgetPositions(), so that this order is similar
+ to what we done when a FrameView scrolls. This change has no known side effects.
+ Second, if compositingConsultsOverlap() is true, we need to actually do a
+ compositing layer update to compute whether revealed/hidden layers should
+ be created/destroyed.
+
+2010-05-06 Maciej Stachowiak <mjs@apple.com>
+
+ Not reviewed, build fix.
+
+ Try again - with quotes this time. *facepalm*
+
+ * dom/Notation.cpp:
+
+2010-05-06 Maciej Stachowiak <mjs@apple.com>
+
+ Not reviewed, build fix.
+
+ Speculative fix for Qt and Gtk.
+
+ * dom/Notation.cpp:
+
+2010-05-06 Maciej Stachowiak <mjs@apple.com>
+
+ Not reviewed, build fix.
+
+ Fix an assert that I failed to update in my earlier change.
+
+ * dom/CharacterData.h:
+ (WebCore::CharacterData::CharacterData):
+
+2010-05-06 Alexey Proskuryakov <ap@apple.com>
+
+ Reviewed by Geoff Garen.
+
+ https://bugs.webkit.org/show_bug.cgi?id=38697
+ REGRESSION (r58299): Replying on reddit.com no longer works
+
+ * css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Don't recognize :first,
+ :left and :right. The aren't allowed in all contexts, and properly implementing them is out
+ of scope for this regression fix.
+
+2010-05-06 Jian Li <jianli@chromium.org>
+
+ Reviewed by Adam Barth.
+
+ Improve code generator scripts to support converting ScriptString.
+ https://bugs.webkit.org/show_bug.cgi?id=38699
+
+ Change both JSC and V8 generators to introduce "ConvertScriptString"
+ attribute to allow converting from ScriptString. Also updated the
+ bindings test result.
+
+ These changes are necessary in order to avoid adding custom binding codes
+ when we add the FileReader interface.
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * bindings/scripts/CodeGeneratorV8.pm:
+ * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
+ (webkit_dom_test_obj_get_script_string_attr):
+ (webkit_dom_test_obj_get_property):
+ (webkit_dom_test_obj_class_init):
+ * bindings/scripts/test/GObject/WebKitDOMTestObj.h:
+ * bindings/scripts/test/JS/JSTestObj.cpp:
+ (WebCore::):
+ (WebCore::jsTestObjScriptStringAttr):
+ * bindings/scripts/test/JS/JSTestObj.h:
+ * bindings/scripts/test/ObjC/DOMTestObj.h:
+ * bindings/scripts/test/ObjC/DOMTestObj.mm:
+ (-[DOMTestObj scriptStringAttr]):
+ * bindings/scripts/test/TestObj.idl:
+ * bindings/scripts/test/V8/V8TestObj.cpp:
+ (WebCore::TestObjInternal::scriptStringAttrAttrGetter):
+ (WebCore::):
+
+2010-05-06 Jian Li <jianli@chromium.org>
+
+ Reviewed by Adam Barth.
+
+ Improve code generator scripts to pass additional ScriptExecutionContext
+ argument to the constructor.
+ https://bugs.webkit.org/show_bug.cgi?id=38687
+
+ Change both JSC and V8 generators to introduce "CallWith=ScriptExecutionContext"
+ attribute to allow passing the additional ScriptExecutionContext argument to
+ the constructor. Also add another test IDL file to test interface-level
+ features.
+
+ These changes are necessary in order to avoid adding custom binding codes
+ when we add the FileReader interface.
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * bindings/scripts/CodeGeneratorV8.pm:
+ * bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp: Added.
+ * bindings/scripts/test/GObject/WebKitDOMTestInterface.h: Added.
+ * bindings/scripts/test/GObject/WebKitDOMTestInterfacePrivate.h: Added.
+ * bindings/scripts/test/JS/JSTestInterface.cpp: Added.
+ * bindings/scripts/test/JS/JSTestInterface.h: Added.
+ * bindings/scripts/test/ObjC/DOMTestInterface.h: Added.
+ * bindings/scripts/test/ObjC/DOMTestInterface.mm: Added.
+ * bindings/scripts/test/ObjC/DOMTestInterfaceInternal.h: Added.
+ * bindings/scripts/test/TestInterface.idl: Added.
+ * bindings/scripts/test/V8/V8TestInterface.cpp: Added.
+ * bindings/scripts/test/V8/V8TestInterface.h: Added.
+ * bindings/v8/V8Proxy.h:
+ (WebCore::V8Proxy::constructDOMObjectWithScriptExecutionContext):
+
+2010-05-06 Maciej Stachowiak <mjs@apple.com>
+
+ Build fix, not reviewed.
+
+ Speculative Windows and Debug build fixes for the last change.
+
+ * dom/Node.h:
+ (WebCore::Node::inDocument):
+ (WebCore::Node::setFlag):
+
+2010-05-06 James Robinson <jamesr@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Fix warnings emitted by gcc 4.4.1 on linux in chromium-specific platform graphics files.
+ https://bugs.webkit.org/show_bug.cgi?id=38158
+
+ Fixes:
+ - replace NULL with 0
+ - remove unusued locals
+ - add parens around ambiguous looking compound predicates like (a || b && c)
+
+ This also adds a check for x >= 0 to FontLinux.cpp's in this statement:
+ if (x < walker.width())
+ This is more documentation than anything else since walker.width() returns
+ an unsigned the current behavior is that x is promoted to unsigned and as
+ long as x + walker.width() is less than 2^31 all negative values of x
+ end up wrapping around and not being < walker.width(). This behavior is
+ tested by fast/text/international/khmer-selection.html
+
+ * platform/graphics/chromium/FontLinux.cpp:
+ (WebCore::adjustTextRenderMode):
+ (WebCore::TextRunWalker::TextRunWalker):
+ (WebCore::TextRunWalker::length):
+ (WebCore::TextRunWalker::width):
+ (WebCore::TextRunWalker::getTextRun):
+ (WebCore::TextRunWalker::getNormalizedTextRun):
+ (WebCore::Font::offsetForPositionForComplexText):
+ * platform/graphics/chromium/FontPlatformDataLinux.cpp:
+ (WebCore::FontPlatformData::setupPaint):
+ * platform/graphics/chromium/HarfbuzzSkia.cpp:
+ (WebCore::getOutlinePoint):
+ * platform/graphics/skia/GraphicsContext3DSkia.cpp:
+ (WebCore::GraphicsContext3D::getImageData):
+ * platform/graphics/skia/GraphicsContextSkia.cpp:
+ (WebCore::isCoordinateSkiaSafe):
+ (WebCore::GraphicsContext::fillRect):
+ (WebCore::GraphicsContext::strokePath):
+ (WebCore::GraphicsContext::strokeRect):
+
+2010-05-06 Ada Chan <adachan@apple.com>
+
+ Reviewed by David Kilzer.
+
+ https://bugs.webkit.org/show_bug.cgi?id=38695
+
+ Check the result from widget() for NULL before accessing it.
+
+ * rendering/RenderIFrame.cpp:
+ (WebCore::RenderIFrame::calcHeight):
+ (WebCore::RenderIFrame::calcWidth):
+
+2010-05-06 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Darin Adler.
+
+ further fixes towards REGRESSION (r57292): 1% PLT regression from visited link information leak fix
+ https://bugs.webkit.org/show_bug.cgi?id=38682
+ <rdar://problem/7859794>
+
+ Looks like a 1-2% speedup on PLT.
+
+ - Reorder CSS properties.
+ - Remove short circuit tag check in matchRulesForList which costs more than it saves.
+ - Inline initForStyleResolve.
+ - Optimize applyDeclarations to avoid switch and take fewer branches in the inner loop.
+
+ - Change the way Node handles flags - replace bitfield with a uint32_t and explicit masking,
+ to make it cheaper to initialize the bits and give faster access.
+ - Added new Node flags to check for isStyledElement, isHTMLElement, isSVGElement, isComment,
+ and devirtualize those methods.
+ - Inline constructors for Node, Element, Text, CharacterData, StyledElement, etc since
+ they are very simple and lots of nodes get constructed.
+
+ * css/CSSPropertyNames.in: Move a few of the properties up front so we can check for them
+ with < instead of switch statements
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::matchRulesForList): Remove unnecessary preflight check
+ for tag match before checking selector. This check very rarely short circuits anything,
+ since most rules with a tag end up in the appropriate tag bucket. So doing the check
+ cost more time than the time saved.
+ (WebCore::CSSStyleSelector::initForStyleResolve): Inline. Create RenderStyle in a better way.
+ (WebCore::CSSStyleSelector::applyDeclarations): Get rid of switch statement and use <= to
+ check for the high priority properties. Convert to template to avoid checking "applyFirst"
+ each time through the loop.
+ (WebCore::CSSStyleSelector::styleForElement): Adjust for new applyDeclarations() signature.
+ (WebCore::CSSStyleSelector::keyframeStylesForAnimation): ditto
+ (WebCore::CSSStyleSelector::pseudoStyleForElement): ditto
+ * css/CSSStyleSelector.h: Adjust for new applyDeclarations() signature.
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::RenderStyle::RenderStyle): Inline constructor.
+ * rendering/style/RenderStyle.h: Make constructor private so it can be inline.
+ * dom/Node.h:
+ (WebCore::): See high-level description of changes above. Redid the
+ way boolean flags work.
+ (WebCore::Node::isElementNode):
+ (WebCore::Node::isContainerNode):
+ (WebCore::Node::isTextNode):
+ (WebCore::Node::isHTMLElement):
+ (WebCore::Node::isSVGElement):
+ (WebCore::Node::isStyledElement):
+ (WebCore::Node::isCommentNode):
+ (WebCore::Node::hasID):
+ (WebCore::Node::hasClass):
+ (WebCore::Node::active):
+ (WebCore::Node::inActiveChain):
+ (WebCore::Node::inDetach):
+ (WebCore::Node::hovered):
+ (WebCore::Node::attached):
+ (WebCore::Node::setAttached):
+ (WebCore::Node::needsStyleRecalc):
+ (WebCore::Node::styleChangeType):
+ (WebCore::Node::childNeedsStyleRecalc):
+ (WebCore::Node::isLink):
+ (WebCore::Node::setHasID):
+ (WebCore::Node::setHasClass):
+ (WebCore::Node::setChildNeedsStyleRecalc):
+ (WebCore::Node::clearChildNeedsStyleRecalc):
+ (WebCore::Node::setInDocument):
+ (WebCore::Node::clearInDocument):
+ (WebCore::Node::setInActiveChain):
+ (WebCore::Node::clearInActiveChain):
+ (WebCore::Node::setIsLink):
+ (WebCore::Node::clearIsLink):
+ (WebCore::Node::setActive):
+ (WebCore::Node::setHovered):
+ (WebCore::Node::inDocument):
+ (WebCore::Node::):
+ (WebCore::Node::getFlag):
+ (WebCore::Node::setFlag):
+ (WebCore::Node::clearFlag):
+ (WebCore::Node::hasRareData):
+ (WebCore::Node::isParsingChildrenFinished):
+ (WebCore::Node::setIsParsingChildrenFinished):
+ (WebCore::Node::clearIsParsingChildrenFinished):
+ (WebCore::Node::isStyleAttributeValid):
+ (WebCore::Node::setIsStyleAttributeValid):
+ (WebCore::Node::clearIsStyleAttributeValid):
+ (WebCore::Node::isSynchronizingStyleAttribute):
+ (WebCore::Node::setIsSynchronizingStyleAttribute):
+ (WebCore::Node::clearIsSynchronizingStyleAttribute):
+ (WebCore::Node::areSVGAttributesValid):
+ (WebCore::Node::setAreSVGAttributesValid):
+ (WebCore::Node::clearAreSVGAttributesValid):
+ (WebCore::Node::isSynchronizingSVGAttributes):
+ (WebCore::Node::setIsSynchronizingSVGAttributes):
+ (WebCore::Node::clearIsSynchronizingSVGAttributes):
+ (WebCore::Node::hasRareSVGData):
+ (WebCore::Node::setHasRareSVGData):
+ (WebCore::Node::clearHasRareSVGData):
+ (WebCore::Node::initialRefCount):
+ * dom/Node.cpp:
+ (WebCore::Node::trackForDebugging): Adjusted for changes in
+ flag handling.
+ (WebCore::Node::ensureRareData): ditto
+ (WebCore::Node::setStyleChange): ditto
+ (WebCore::Node::setNeedsStyleRecalc): ditto
+ (WebCore::Node::lazyAttach): ditto
+ (WebCore::Node::attach): ditto
+ (WebCore::Node::detach): ditto
+ (WebCore::Node::insertedIntoDocument): ditto
+ (WebCore::Node::removedFromDocument): ditto
+ * dom/CharacterData.cpp:
+ * dom/CharacterData.h:
+ (WebCore::CharacterData::CharacterData): Inline the constructor (moved from .cpp)
+ * dom/Comment.cpp:
+ (WebCore::Comment::Comment): Tell the base class that we're a comment.
+ * dom/Comment.h: Remove isCommentNode override.
+ * dom/ContainerNode.cpp:
+ (WebCore::ContainerNode::detach): Adjusted for changes in flag
+ handling.
+ (WebCore::ContainerNode::removedFromDocument): ditto
+ * dom/Document.cpp:
+ (WebCore::Document::Document): Adjusted for changes in flag handling.
+ (WebCore::Document::recalcStyle): ditto
+ (WebCore::Document::setFocusedNode): ditto
+ * dom/Document.h:
+ (WebCore::Node::Node): Inline the Node constructor - goes here
+ because it uses Document.
+ * dom/DocumentFragment.cpp: include Document.h due to above change
+ * dom/EditingText.cpp: ditto
+ * dom/EntityReference.cpp: ditto
+ * dom/Element.cpp:
+ (WebCore::Element::getAttribute): Adjusted for changes in flag
+ handling.
+ (WebCore::Element::setAttribute): ditto
+ (WebCore::Element::hasAttributes): ditto
+ (WebCore::Element::recalcStyle): ditto
+ (WebCore::Element::finishParsingChildren): ditto
+ * dom/Element.h:
+ (WebCore::Element::Element): Inline (moved from .cpp)
+ (WebCore::Element::isFinishedParsingChildren):
+ (WebCore::Element::beginParsingChildren):
+ (WebCore::Element::attributes): Adjusted for changes in flag
+ handling.
+ * dom/StyledElement.cpp:
+ (WebCore::StyledElement::updateStyleAttribute): Adjust for
+ changes to flag handling.
+ (WebCore::StyledElement::mapToEntry): ditto
+ (WebCore::StyledElement::parseMappedAttribute): ditto
+ (WebCore::StyledElement::copyNonAttributeProperties): ditto
+ * dom/StyledElement.h:
+ (WebCore::StyledElement::StyledElement): Inline (moved from.cpp)
+ (WebCore::StyledElement::invalidateStyleAttribute): Adjust for
+ changes in flag handling.
+ * dom/Text.h:
+ (WebCore::Text::Text): Inline (moved from .cpp)
+ * dom/Text.cpp:
+ * html/HTMLAnchorElement.cpp:
+ (WebCore::HTMLAnchorElement::HTMLAnchorElement): Adjust for changes in
+ flag handling.
+ (WebCore::HTMLAnchorElement::parseMappedAttribute): ditto
+ * html/HTMLElement.cpp:
+ (WebCore::HTMLElement::create): Tell base class we're an HTML element.
+ * html/HTMLElement.h: ditto above; remove isHTMLElement override.
+ * html/HTMLFormControlElement.h: Tell base class we're an HTML element.
+ * html/HTMLFrameOwnerElement.cpp:
+ (WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement): ditto
+ * html/HTMLProgressElement.cpp:
+ (WebCore::HTMLProgressElement::HTMLProgressElement): ditto
+ * mathml/MathMLElement.cpp:
+ (WebCore::MathMLElement::MathMLElement): Tell base class we're a styled
+ element.
+ * rendering/MediaControlElements.cpp:
+ (WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement):
+ Adjust for changes in flag handling.
+ (WebCore::MediaControlElement::MediaControlElement): ditto
+ (WebCore::MediaControlInputElement::MediaControlInputElement): ditto
+ * rendering/RenderFileUploadControl.cpp:
+ (WebCore::RenderFileUploadControl::updateFromElement): ditto
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::updateHoverActiveState): ditto
+ * rendering/RenderProgress.cpp:
+ (WebCore::RenderProgress::updateValuePartState): ditto
+ * rendering/RenderSlider.cpp:
+ (WebCore::RenderSlider::updateFromElement): ditto
+ * rendering/SVGShadowTreeElements.cpp:
+ (WebCore::SVGShadowTreeRootElement::SVGShadowTreeRootElement): ditto
+ * rendering/TextControlInnerElements.cpp:
+ (WebCore::TextControlInnerElement::attachInnerElement): ditto
+ * svg/SVGAnimatedProperty.h:
+ (WebCore::SVGAnimatedPropertyTearOff::setBaseVal): ditto
+ (WebCore::SVGAnimatedPropertyTearOff::setAnimVal): ditto
+ * svg/SVGElement.cpp:
+ (WebCore::SVGElement::SVGElement): Tell base class we're
+ an svg element.
+ (WebCore::SVGElement::ensureRareSVGData): Adjust for flag handling
+ changes.
+ (WebCore::SVGElement::updateAnimatedSVGAttribute): ditto
+ * svg/SVGElement.h:
+ (WebCore::SVGElement::invalidateSVGAttributes): ditto
+ * svg/SVGPolyElement.cpp:
+ (WebCore::SVGPolyElement::svgAttributeChanged): ditto
+ * wml/WMLAnchorElement.cpp:
+ (WebCore::WMLAnchorElement::WMLAnchorElement): ditto
+ * wml/WMLElement.cpp:
+ (WebCore::WMLElement::WMLElement): Tell base class we're a styled
+ element.
+
+2010-05-06 Adam Barth <abarth@webkit.org>
+
+ Unreviewed. Fix indent. Sorry, my OCD was acting up.
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::handleMouseReleaseEvent):
+
+2010-05-06 Pavel Feldman <pfeldman@chromium.org>
+
+ Reviewed by Joseph Pecoraro.
+
+ Web Inspector: store selected Headers / Content tab on explicit switch and/or explicit navigate only.
+
+ https://bugs.webkit.org/show_bug.cgi?id=38660
+
+ * inspector/front-end/ResourceView.js:
+ (WebInspector.ResourceView):
+ (WebInspector.ResourceView.prototype._selectHeadersTab):
+ (WebInspector.ResourceView.prototype.selectContentTab):
+ * inspector/front-end/ResourcesPanel.js:
+ (WebInspector.ResourcesPanel.prototype.showResource):
+
+2010-05-06 Luiz Agostini <luiz.agostini@openbossa.org>
+
+ Rubber-stamped by Simon Hausmann.
+
+ [Qt] use QT_MOBILE_THEME in Symbian
+ https://bugs.webkit.org/show_bug.cgi?id=38440
+
+ Putting QT_MOBILE_THEME into use for Symbian.
+
+ * WebCore.pro:
+
+2010-05-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Unreviewed, build fix WinCE for QtWebKit.
+
+ [Qt] Compilation with Plugins disabled is broken
+ https://bugs.webkit.org/show_bug.cgi?id=31407
+
+ Rename platform/qt/TemporaryLinkStubs.cpp to avoid name collition on
+ Windows.
+
+ Thanks for Ismail "cartman" Donmez for help.
+
+ No new tests, as there is no new functionality.
+
+ * WebCore.gypi:
+ * WebCore.pro:
+ * platform/qt/TemporaryLinkStubs.cpp: Removed.
+ * platform/qt/TemporaryLinkStubsQt.cpp: Copied from WebCore/platform/qt/TemporaryLinkStubs.cpp.
+
+2010-05-06 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ [Qt] REGRESSION: Loading of external CSS and JS files over network fails in some cases
+ https://bugs.webkit.org/show_bug.cgi?id=36755
+
+ Enable the direct connection between QtNetwork and QtWebKit only for Qt versions
+ greater than 4.6.2, due to a bug in Qt that's been fixed after 4.6.2.
+
+ * platform/network/qt/QNetworkReplyHandler.cpp:
+
+2010-05-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
+
+ Reviewed by Xan Lopez.
+
+ Rework where we get page step and line step from, so we do not
+ depend on scrollbars existing. Caught by API test I forgot to run.
+
+ * platform/gtk/ScrollViewGtk.cpp:
+ (WebCore::ScrollView::setGtkAdjustments):
+
+2010-05-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
+
+ Reviewed by Xan Lopez.
+
+ [GTK] Adjustment resetting uses wrong values, and misses page_size and steps
+ https://bugs.webkit.org/show_bug.cgi?id=38657
+
+ Fix resetting adjustment values. In the page cache case, we were
+ confusing page_size and upper, leading to stray scrollbars
+ sometimes.
+
+ * platform/gtk/ScrollViewGtk.cpp:
+ (WebCore::ScrollView::setGtkAdjustments):
+
+2010-05-06 Darin Adler <darin@apple.com>
+
+ Reviewed by Beth Dakin.
+
+ Page::setCanStartMedia does not properly handle the case where a media listener is removed
+ https://bugs.webkit.org/show_bug.cgi?id=38602
+
+ We can't find any real case where this causes a crash at this time, but
+ we want to harden the code anyway. Thus there are no new regression tests.
+
+ * page/Page.cpp:
+ (WebCore::Page::removeMediaCanStartListener): Removed incorrect assertion.
+ (WebCore::Page::setCanStartMedia): Change algorithm so we notify listeners
+ one at a time and don't notify any listener that has already been removed
+ from the set.
+
+2010-05-05 Ojan Vafai <ojan@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ shift+click on an existing selection doesn't work right
+ https://bugs.webkit.org/show_bug.cgi?id=36542
+
+ NSTextView behavior is to move the end of the selection
+ closest to the shift-click. Win/Linux behavior is to always
+ move the focus end of the selection.
+
+ Test: editing/selection/shift-click.html
+
+ * page/EventHandler.cpp:
+ (WebCore::textDistance):
+ (WebCore::EventHandler::handleMousePressEventSingleClick):
+
+2010-05-06 Pavel Feldman <pfeldman@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ Web Inspector: implement panels history traversal on Cmd+Left/Right.
+
+ https://bugs.webkit.org/show_bug.cgi?id=38649
+
+ * inspector/front-end/inspector.js:
+ (WebInspector.set currentPanel):
+ (WebInspector.loaded):
+ (WebInspector.documentKeyDown):
+ (WebInspector.PanelHistory):
+ (WebInspector.PanelHistory.prototype.canGoBack):
+ (WebInspector.PanelHistory.prototype.goBack):
+ (WebInspector.PanelHistory.prototype.canGoForward):
+ (WebInspector.PanelHistory.prototype.goForward):
+ (WebInspector.PanelHistory.prototype.setPanel):
+
+2010-05-03 Evan Martin <evan@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ [chromium] use glyphDataForCharacter so we hit the glyphdata cache
+ https://bugs.webkit.org/show_bug.cgi?id=38500
+
+ Calling fontDataForCharacters() while rendering text is expensive.
+ Examining the relevant Mac code in WebKit revealed that calling the
+ similarly-named glyphDataForCharacters() results in caching the font
+ data on a per-glyph basis.
+
+ Since we now choose a font based on the first character in a run, we
+ need to be careful that all the glyphs within the run use the same font.
+ This is also similar to the WebKit Mac code. We need to remove all of
+ the script run bits eventually and this is a step in that direction.
+
+ Tests: fast/text/international/danda-space.html spacing changes slightly
+ (now matches Firefox better) and fast/text/international/thai-baht-space.html
+ now picks the correct (serif) font for the digits.
+
+ * platform/graphics/chromium/FontLinux.cpp:
+ (WebCore::TextRunWalker::nextScriptRun):
+ (WebCore::TextRunWalker::setupFontForScriptRun):
+
+2010-05-06 Martin Robinson <mrobinson@webkit.org>
+
+ Reviewed by Gustavo Noronha Silva.
+
+ [GTK] Enable DOM clipboard and drag-and-drop access
+ https://bugs.webkit.org/show_bug.cgi?id=30623
+
+ Convert dragging portion of drag-and-drop to use DataObjectGtk.
+
+ No new tests, because functionality has not changed.
+
+ * page/gtk/EventHandlerGtk.cpp:
+ (WebCore::EventHandler::createDraggingClipboard): Pass the DataObjectGtk as a parameter here.
+ * platform/gtk/ClipboardGtk.h:
+ (WebCore::ClipboardGtk::create): Take the DataObject as a parameter instead of creating it here.
+ (WebCore::ClipboardGtk::helper): Added.
+ (WebCore::ClipboardGtk::dataObject): Added.
+ * platform/gtk/PasteboardHelper.h: Make targetListForDataObject a public method.
+
+2010-05-06 Pavel Feldman <pfeldman@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ Web Inspector: Do not show content tab for resources
+ not supporting content preview.
+
+ https://bugs.webkit.org/show_bug.cgi?id=38635
+
+ * English.lproj/localizedStrings.js:
+ * inspector/front-end/FontView.js:
+ (WebInspector.FontView.prototype.hasContentTab):
+ * inspector/front-end/ImageView.js:
+ (WebInspector.ImageView.prototype.hasContentTab):
+ * inspector/front-end/ResourceView.js:
+ (WebInspector.ResourceView):
+ (WebInspector.ResourceView.prototype._selectTab):
+ (WebInspector.ResourceView.prototype.hasContentTab):
+ * inspector/front-end/SourceView.js:
+ (WebInspector.SourceView.prototype.hasContentTab):
+
+2010-05-06 Antonio Gomes <tonikitoo@webkit.org>
+
+ Reviewed by Kenneth Christiansen.
+
+ Spatial Navigation: adapt the logic of {deep}findFocusableNodeInDirection to do traversal starting from Node* not Document*
+ https://bugs.webkit.org/show_bug.cgi?id=37803
+
+ Instead of receiving a Document pointer as incoming parameter, patch modifies
+ findFocusableNodeInDirection and deepFindFocusableNodeInDirection methods to
+ receive a Node pointer as start for content traversal.
+ This way we can make good use of deepFindFocusableNodeInDirection to traverse
+ other scrollable container like scrollable div's, and not only frames or iframes.
+
+ Patch also makes use of 'while' instead of 'for' to loop control, that gives move
+ flexibility to the incremental step: e.g. if a scrollable div was processed, the incremental
+ step in the loop does not have to do node->traverseNextNode() but node->traverseNextSibling().
+
+ No behavior change. It is a preparation for supporting scrollable containers in Spatial
+ Navigation.
+
+ * page/FocusController.cpp:
+ (WebCore::FocusController::advanceFocusDirectionally):
+ (WebCore::FocusController::findFocusableNodeInDirection):
+ (WebCore::FocusController::deepFindFocusableNodeInDirection):
+ * page/FocusController.h:
+
+2010-05-06 Csaba Osztrogonác <ossy@webkit.org>
+
+ Unreviewed WinCE buildfix after r58842.
+ Preprocessor doesn't understand "true", changed to "1"
+
+ * platform/graphics/MediaPlayer.cpp:
+
+2010-05-06 Mikhail Naganov <mnaganov@chromium.org>
+
+ Reviewed by Pavel Feldman.
+
+ Temporarily disable 'console.profiles' until we can distinguish
+ functions from different frames
+
+ https://bugs.webkit.org/show_bug.cgi?id=38638
+
+ * bindings/v8/custom/V8ConsoleCustom.cpp:
+ (WebCore::V8Console::profilesAccessorGetter):
+
+2010-05-06 Steve Block <steveblock@google.com>
+
+ Reviewed by Eric Seidel.
+
+ MAC_JAVA_BRIDGE should be renamed JAVA_BRIDGE
+ https://bugs.webkit.org/show_bug.cgi?id=38544
+
+ No new tests, build fix only.
+
+ * DerivedSources.make:
+ * bindings/js/ScriptController.cpp:
+ (WebCore::ScriptController::ScriptController):
+ * bindings/js/ScriptController.h:
+ * bindings/js/ScriptControllerMac.mm:
+ (WebCore::ScriptController::createScriptInstanceForWidget):
+ * bridge/jni/JNIBridge.cpp:
+ * bridge/jni/JNIBridge.h:
+ * bridge/jni/JNIUtility.cpp:
+ * bridge/jni/JNIUtility.h:
+ * bridge/jni/jni_jsobject.h:
+ * bridge/jni/jni_jsobject.mm:
+ * bridge/jni/jni_objc.mm:
+ * bridge/jni/jsc/JNIBridgeJSC.cpp:
+ * bridge/jni/jsc/JNIBridgeJSC.h:
+ * bridge/jni/jsc/JNIUtilityPrivate.cpp:
+ * bridge/jni/jsc/JNIUtilityPrivate.h:
+ * bridge/jni/jsc/JavaClassJSC.cpp:
+ * bridge/jni/jsc/JavaClassJSC.h:
+ * bridge/jni/jsc/JavaInstanceJSC.cpp:
+ * bridge/jni/jsc/JavaInstanceJSC.h:
+ * loader/FrameLoaderClient.h:
+
+2010-05-05 Alejandro G. Castro <alex@igalia.com>
+
+ Reviewed by Xan Lopez.
+
+ Fixed the gobject introspection compilation with the new DOM
+ bindings, we needed to add DOM objects.
+
+ * GNUmakefile.am:
+
+2010-05-06 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ drop support for sessionStorage in sandbox iframes
+ https://bugs.webkit.org/show_bug.cgi?id=38151
+
+ This patch causes us to throw a security exception when a sandboxed
+ iframe attempts to access sessionStorage, matching our behavior for
+ localStorage. The letter of the spec asks us to create a separate
+ storage area for each unique origin. We might want to do that in a
+ future patch, but throwing a security error seems like a safe move now.
+
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::sessionStorage):
+ (WebCore::DOMWindow::localStorage):
+ * page/DOMWindow.h:
+ * page/DOMWindow.idl:
+ * page/SecurityOrigin.h:
+ (WebCore::SecurityOrigin::canAccessSessionStorage):
+ * storage/StorageEventDispatcher.cpp:
+ (WebCore::StorageEventDispatcher::dispatch):
+
+2010-05-06 Andy Estes <aestes@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ Allow forms submitting to target="_blank" to open popups if the submission
+ originated from a user gesture.
+
+ https://bugs.webkit.org/show_bug.cgi?id=37335
+ <rdar://problem/7884980>
+
+ Test: fast/events/popup-allowed-from-gesture-initiated-form-submit.html
+
+ * bindings/js/ScriptController.cpp:
+ (WebCore::ScriptController::processingUserGesture): If no DOM event is
+ being processed, consult UserGestureIndicator to determine return value.
+ * bindings/js/ScriptController.h: Moved the logic of processingUserGestureEvent()
+ into processingUserGesture().
+
+2010-05-06 Xan Lopez <xlopez@igalia.com>
+
+ Rubber-stamped by Eric Seidel.
+
+ [GTK] Refactor GenerateProperties in CodeGenerationGObject.pm
+ https://bugs.webkit.org/show_bug.cgi?id=38577
+
+ Thinko caught while refactoring, $custom variable was not
+ initialized.
+
+ * bindings/scripts/CodeGeneratorGObject.pm:
+ * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
+ (webkit_dom_test_obj_set_property):
+ (webkit_dom_test_obj_get_property):
+ (webkit_dom_test_obj_class_init):
+
+2010-05-06 Xan Lopez <xlopez@igalia.com>
+
+ Rubber-stamped by Eric Seidel.
+
+ [GTK] Refactor GenerateProperties in CodeGenerationGObject.pm
+ https://bugs.webkit.org/show_bug.cgi?id=38577
+
+ Refactor GenerateProperty out of GenerateProperties. This is in
+ preparation for EventListeren attributes, which won't generate
+ normal GObject properties.
+
+ * bindings/scripts/CodeGeneratorGObject.pm:
+
+2010-05-06 Pavel Feldman <pfeldman@chromium.org>
+
+ Reviewed by Joseph Pecoraro.
+
+ Web Inspector: follow up to linkify event listeners.
+
+ https://bugs.webkit.org/show_bug.cgi?id=38257
+
+ * bindings/js/ScriptEventListener.cpp:
+ (WebCore::eventListenerHandlerLocation):
+ * bindings/v8/ScriptEventListener.cpp:
+ (WebCore::eventListenerHandlerLocation):
+ * inspector/front-end/ElementsPanel.js:
+ (WebInspector.ElementsPanel.prototype.linkifyNodeReference):
+ * inspector/front-end/EventListenersSidebarPane.js:
+
+2010-05-05 Charles Wei <charles.wei@torchmobile.com.cn>
+
+ Reviewed by George Staikos
+
+ https://bugs.webkit.org/show_bug.cgi?id=37848
+ This patch adds WCSS -wap-input-format and -wap-input-required support to WebKit
+
+ Tests: fast/wcss/wap-input-format.xhtml
+ fast/wcss/wap-input-required.xhtml
+
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::parseValue):
+ (WebCore::CSSParser::parseWCSSInputProperty):
+ * css/CSSParser.h:
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::applyProperty):
+ * css/WCSSPropertyNames.in:
+ * dom/InputElement.cpp:
+ (WebCore::InputElement::sanitizeValue):
+ (WebCore::InputElement::handleBeforeTextInsertedEvent):
+ (WebCore::InputElementData::InputElementData):
+ (WebCore::formatCodes):
+ (WebCore::cursorPositionToMaskIndex):
+ (WebCore::InputElement::isConformToInputMask):
+ (WebCore::InputElement::validateInputMask):
+ * dom/InputElement.h:
+ (WebCore::InputElementData::inputFormatMask):
+ (WebCore::InputElementData::setInputFormatMask):
+ (WebCore::InputElementData::maxInputCharsAllowed):
+ (WebCore::InputElementData::setMaxInputCharsAllowed):
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::setWapInputFormat):
+ * html/HTMLInputElement.h:
+ (WebCore::HTMLInputElement::data):
+ * wml/WMLInputElement.h:
+ (WebCore::WMLInputElement::data):
+
+2010-05-05 MORITA Hajime <morrita@google.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=38150
+ Refactoring: webkitEditableContentChangedEvent should be handled by the owner of appropriate the renderer.
+
+ Moved a part of code chunk in HTMLFormControlElementWithState::defaultEventHandler()
+ which accesses the renderer from foreign node,
+ to TextControlInnerTextElement::defaultEventHandler() which owns the renderer.
+
+ No new tests. No behavioral change.
+
+ * html/HTMLFormControlElement.cpp:
+ (WebCore::HTMLFormControlElementWithState::defaultEventHandler):
+ * html/HTMLFormControlElement.h:
+ * html/HTMLInputElement.h:
+ * html/HTMLTextAreaElement.h:
+ * rendering/TextControlInnerElements.cpp:
+ (WebCore::TextControlInnerTextElement::defaultEventHandler):
+
+2010-05-05 Joseph Pecoraro <joepeck@webkit.org>
+
+ Reviewed by Timothy Hatcher.
+
+ Web Inspector: Line Numbers should be Aligned with the Source Code Line
+ https://bugs.webkit.org/show_bug.cgi?id=38593
+
+ If there is a message bubble, such as an error message, in a source view
+ the line number should be in line with the source code line, not centered
+ between the source and bubble.
+
+ * inspector/front-end/textViewer.css:
+ (.webkit-line-number): added vertical-align: top
+
+2010-05-05 Dan Bernstein <mitz@apple.com>
+
+ Fix the decelerated compositing build.
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::isEnclosedInCompositingLayer):
+ * page/FrameView.h:
+
+2010-05-05 Gavin Barraclough <barraclough@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Bug 38604 - workers-gc2 crashing on Qt
+
+ This appears to be due to a couple of issues.
+ (1) When the atomic string table is deleted it does not clear the 'inTable' bit
+ on AtomicStrings - it implicitly assumes that all AtomicStrings have already
+ been deleted at this point (otherwise they will crash in their destructor when
+ they try to remove themselves from the atomic string table).
+ (2) We don't fix the ordering in which WTF::WTFThreadData and
+ WebCore::ThreadGlobalData are destructed.
+
+ We should make sure that ThreadGlobalData is cleaned up before worker threads
+ terminate and WTF::WTFThreadData is destroyed, and we should clear the inTable
+ bit of members on atomic string table destruction.
+
+ WTF changes (fix issue 2, above) - clean up the thread data on worker termination.
+
+ * platform/ThreadGlobalData.cpp:
+ (WebCore::ThreadGlobalData::~ThreadGlobalData):
+ (WebCore::ThreadGlobalData::destroy):
+ * platform/ThreadGlobalData.h:
+ * workers/WorkerThread.cpp:
+ (WebCore::WorkerThread::workerThread):
+
+2010-05-05 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ <rdar://problem/7932072> Iframes in composited layers don’t repaint correctly (affects Yahoo! Mail with Flash Player 10.1)
+ https://bugs.webkit.org/show_bug.cgi?id=38427
+
+ Test: compositing/iframes/iframe-in-composited-layer.html
+
+ * WebCore.base.exp: Export FrameView::isEnclosedInCompositingLayer().
+ * page/FrameView.cpp:
+ (WebCore::FrameView::isEnclosedInCompositingLayer): Added this predicate.
+ * page/FrameView.h:
+
+2010-05-05 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ Got composited iframes showing up on Mac again
+ https://bugs.webkit.org/show_bug.cgi?id=38565
+
+ This was broken by http://trac.webkit.org/changeset/58798. That
+ change connected iframes through the parent document to the root
+ of the layer tree. That is correct for Windows, but not for Mac.
+ So the places where the linkage is made were wrapped in
+ shouldPropagateCompositingToIFrameParent() calls, which is
+ always false for Mac.
+
+ Test: compositing/iframes/composited-iframe-alignment.html
+
+ * rendering/RenderLayerCompositor.cpp:Avoid doing composited iframe linkage on Mac
+ (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
+ (WebCore::RenderLayerCompositor::didMoveOnscreen):
+ (WebCore::RenderLayerCompositor::willMoveOffscreen):
+ (WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
+
+2010-05-05 Alexey Proskuryakov <ap@apple.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=38260
+ <rdar://problem/7917548> Fix whitespace removing in deprecatedParseURL().
+
+ Broken all the way since r4 (yes, that's a revision number).
+
+ Test: http/tests/security/xss-DENIED-javascript-with-spaces.html
+
+ * css/CSSHelper.cpp: (WebCore::deprecatedParseURL): Fixed loop conditions for remaining length.
+
+2010-05-05 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Beth Dakin.
+
+ Many AXUnknown showing up in the hierarchy
+ https://bugs.webkit.org/show_bug.cgi?id=38607
+
+ The RenderTableSection should not be an accessible element.
+
+ Test: platform/mac/accessibility/parent-of-table-row-is-table.html
+
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
+
+2010-05-05 Csaba Osztrogonác <ossy@webkit.org>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt]Disable Qt Multimedia backend for HTML 5 Audio and Video elements
+ Fall back to the Phonon backend until the release situation has been cleared up.
+
+ https://bugs.webkit.org/show_bug.cgi?id=38612
+
+ Buildfix for QT_VERSION >= 0x040700 after r58810.
+
+ * platform/graphics/MediaPlayer.cpp:
+
+2010-05-05 Jian Li <jianli@chromium.org>
+
+ Reviewed by David Levin.
+
+ XMLHttpRequestUpload events do not fire when sending a raw file or FormData object.
+ https://bugs.webkit.org/show_bug.cgi?id=37771
+
+ Test: http/tests/local/formdata/upload-events.html
+
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::createRequest):
+
+2010-05-05 Csaba Osztrogonác <ossy@webkit.org>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] Qt port should use its own QUuid class to create UUID string.
+ https://bugs.webkit.org/show_bug.cgi?id=38581
+
+ * platform/UUID.cpp:
+ (WebCore::createCanonicalUUIDString): Added PLATFORM(QT) case.
+
+2010-05-05 Alexey Proskuryakov <ap@apple.com>
+
+ Roll out r58830 for breaking tests.
+
+ Was: https://bugs.webkit.org/show_bug.cgi?id=38546
+ Node.focus() fails to move focus from subframe properly
+
+ * html/HTMLFrameElementBase.cpp:
+ (WebCore::HTMLFrameElementBase::setFocus):
+
+2010-05-05 Jian Li <jianli@chromium.org>
+
+ Reviewed by Adam Barth.
+
+ Implement FileReader class.
+ https://bugs.webkit.org/show_bug.cgi?id=38157
+
+ This patch only contains the implementation of FileReader class as defined
+ in the File API spec: http://www.w3.org/TR/file-upload/#dfn-filereader.
+
+ New test will be added when a IDL is exposed and the FILE_READER is turned
+ on.
+
+ * GNUmakefile.am:
+ * WebCore.gypi:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * dom/EventNames.h:
+ * dom/EventTarget.cpp:
+ (WebCore::EventTarget::toFileReader):
+ * dom/EventTarget.h:
+ * html/FileError.h:
+ (WebCore::FileError::FileError):
+ * html/FileReader.cpp: Added.
+ * html/FileReader.h: Added.
+ * html/FileStream.cpp:
+ (WebCore::FileStream::FileStream):
+ (WebCore::FileStream::openForRead):
+ (WebCore::FileStream::close):
+ (WebCore::FileStream::read):
+ * html/FileStream.h:
+
+2010-05-05 Steve Falkenburg <sfalken@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ REGRESSION(r57969) Image decoder is repeatedly destroyed/created in CoreGraphics-based Windows WebKit
+ https://bugs.webkit.org/show_bug.cgi?id=38595
+
+ * platform/graphics/cg/ImageSourceCG.cpp:
+ (WebCore::ImageSource::setData):
+
+2010-05-05 Alexey Proskuryakov <ap@apple.com>
+
+ Reviewed by Adele Peterson.
+
+ https://bugs.webkit.org/show_bug.cgi?id=38546
+ Node.focus() fails to move focus from subframe properly
+
+ Test: fast/frames/take-focus-from-iframe.html
+
+ * html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::setFocus): Don't clear
+ focus if this frame doesn't have it. This can happen if page's and HTMLFrameElement's ideas
+ of focused frame get out of sync temporarily.
+
+2010-05-05 Alexey Proskuryakov <ap@apple.com>
+
+ Reviewed by Adele Peterson.
+
+ https://bugs.webkit.org/show_bug.cgi?id=26824
+ <rdar://problem/7018610> EventHandler can operate on a wrong frame if focus changes during
+ keyboard event dispatch.
+
+ EventHandler object is tied to a frame, so it's wrong for it to continue processing a keyboard
+ event if focused frame changes between keydown and keypress.
+
+ * manual-tests/focus-change-between-key-events.html: Added.
+
+ * page/EventHandler.cpp: (WebCore::EventHandler::keyEvent): Bail out early if focused frame
+ changes while dispatching keydown. Also made similar changes for Windows to maintain matching
+ behavior, even though EventHandler was re-entered anyway due to WM_KEYDOWN and WM_CHAR being
+ separate events.
+
+2010-05-05 Steve Block <steveblock@google.com>
+
+ Reviewed by Adam Barth.
+
+ MediaError.h is missing PassRefPtr.h include
+ https://bugs.webkit.org/show_bug.cgi?id=38575
+
+ No new tests, build fix only.
+
+ * html/MediaError.h:
+
+2010-05-05 Alexander Pavlov <apavlov@chromium.org>
+
+ Reviewed by Pavel Feldman.
+
+ Web Inspector: Audits panel: Resource counters get reset when switching panels while reloading page
+ https://bugs.webkit.org/show_bug.cgi?id=38579
+
+ * inspector/front-end/AuditLauncherView.js:
+ (WebInspector.AuditLauncherView.prototype.updateResourceTrackingState):
+ (WebInspector.AuditLauncherView.prototype._updateResourceProgress):
+
+2010-05-05 Pavel Feldman <pfeldman@chromium.org>
+
+ Reviewed by Joseph Pecoraro.
+
+ Web Inspector: Doubleclick on line number should not trigger source editing.
+
+ https://bugs.webkit.org/show_bug.cgi?id=38588
+
+ * inspector/front-end/TextViewer.js:
+ (WebInspector.TextViewer.prototype._handleDoubleClick):
+
+2010-05-05 Martin Robinson <mrobinson@webkit.org>
+
+ Reviewed by Gustavo Noronha.
+
+ [GTK] Enable DOM clipboard and drag-and-drop access
+ https://bugs.webkit.org/show_bug.cgi?id=30623
+
+ Add support in the PasteboardHelper for images, in preparation for drag-and-drop data.
+
+ No new tests as functionality has not changed.
+
+ * platform/gtk/PasteboardHelper.cpp:
+ (WebCore::PasteboardHelper::fillSelectionData): Add support for images here.
+ (WebCore::PasteboardHelper::targetListForDataObject): Add support for images here.
+
+2010-05-05 Stuart Morgan <stuartmorgan@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ Add a "focused" parameter to Widget::setFocus, and updates Document
+ so that Widget is informed of focus loss as well as focus gain.
+ Changes all existing setFocus implementations so that they ignore
+ the 'false' case, so no behavior is changed until individual
+ platforms are updated to handle the new case (if they want to).
+
+ https://bugs.webkit.org/show_bug.cgi?id=37961
+
+ * dom/Document.cpp:
+ (WebCore::Document::setFocusedNode):
+ * platform/Widget.h:
+ * platform/android/WidgetAndroid.cpp:
+ (WebCore::Widget::setFocus):
+ * platform/chromium/WidgetChromium.cpp:
+ (WebCore::Widget::setFocus):
+ * platform/efl/WidgetEfl.cpp:
+ (WebCore::Widget::setFocus):
+ * platform/gtk/WidgetGtk.cpp:
+ (WebCore::Widget::setFocus):
+ * platform/haiku/WidgetHaiku.cpp:
+ (WebCore::Widget::setFocus):
+ * platform/mac/WidgetMac.mm:
+ (WebCore::Widget::setFocus):
+ * platform/qt/WidgetQt.cpp:
+ (WebCore::Widget::setFocus):
+ * platform/win/WidgetWin.cpp:
+ (WebCore::Widget::setFocus):
+ * platform/wx/WidgetWx.cpp:
+ (WebCore::Widget::setFocus):
+ * plugins/PluginView.h:
+ * plugins/PluginViewNone.cpp:
+ (WebCore::PluginView::setFocus):
+ * plugins/gtk/PluginViewGtk.cpp:
+ (WebCore::PluginView::setFocus):
+ * plugins/mac/PluginViewMac.cpp:
+ (WebCore::PluginView::setFocus):
+ * plugins/qt/PluginViewQt.cpp:
+ (WebCore::PluginView::setFocus):
+ * plugins/symbian/PluginViewSymbian.cpp:
+ (WebCore::PluginView::setFocus):
+ * plugins/win/PluginViewWin.cpp:
+ (WebCore::PluginView::setFocus):
+
+2010-05-05 Steve Block <steveblock@google.com>
+
+ Reviewed by Pavel Feldman.
+
+ Move V8 ScriptDebugServer::topStackFrame() to ScriptCallStack
+ https://bugs.webkit.org/show_bug.cgi?id=38531
+
+ ScriptCallStack::create() uses ScriptDebugServer::topStackFrame(), but ScriptDebugServer
+ is guarded with ENABLE(JAVASCRIPT_DEBUGGER). This prevents ScriptCallStack from being
+ built on platforms that do not define ENABLE(JAVASCRIPT_DEBUGGER).
+
+ No new tests, build fix only.
+
+ * bindings/v8/ScriptCallStack.cpp:
+ (WebCore::ScriptCallStack::callLocation):
+ (WebCore::ScriptCallStack::createUtilityContext): Helper for topStackFrame, moved from ScriptDebugServer
+ (WebCore::ScriptCallStack::topStackFrame): Moved from ScriptDebugServer
+ * bindings/v8/ScriptCallStack.h:
+ (WebCore::ScriptCallStack::utilityContext): Helper for topStackFrame, moved from ScriptDebugServer
+ * bindings/v8/ScriptDebugServer.cpp:
+ * bindings/v8/ScriptDebugServer.h:
+
+2010-05-05 Csaba Osztrogonác <ossy@webkit.org>
+
+ Rubber-stamped by Simon Hausmann.
+
+ [Qt] REGRESSION(r56869): WinCE build is broken
+ https://bugs.webkit.org/show_bug.cgi?id=36929
+
+ * WebCore.pro: LIBS += -lOle32 added.
+
+2010-05-05 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Reviewed by Tor Arne Vestbø.
+
+ [Qt] Disable Qt Multimedia backend for HTML 5 Audio and Video elements
+
+ Fall back to the Phonon backend until the release situation has been cleared up.
+
+ * WebCore.pro:
+
+2010-05-05 Ilya Tikhonovsky <loislo@chromium.org>
+
+ Reviewed by Pavel Feldman.
+
+ WebInspector: Clickable links to resources should be used as 'details' part for the all suitable kinds of records.
+ https://bugs.webkit.org/show_bug.cgi?id=38542
+
+ * inspector/front-end/TimelinePanel.js:
+ (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
+ (WebInspector.TimelineRecordListRow):
+ (WebInspector.TimelineRecordListRow.prototype.update):
+ (WebInspector.TimelinePanel.FormattedRecord):
+ (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
+ (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
+ (WebInspector.TimelinePanel.PopupContentHelper):
+ (WebInspector.TimelinePanel.PopupContentHelper.prototype._createCell):
+ (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendTextRow):
+ (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendElementRow):
+ (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendLinkRow):
+
+2010-05-05 Nikolas Zimmermann <nzimmermann@rim.com>
+
+ Not reviewed. Add missing files generated by "run-bindings-test", after the DOMTestCallback.idl addition.
+
+ * bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp: Added.
+ (WebKit::kit):
+ (webkit_dom_test_callback_callback_with_class1param):
+ (webkit_dom_test_callback_callback_with_class2param):
+ (webkit_dom_test_callback_callback_with_non_bool_return_type):
+ (WebKit::wrapTestCallback):
+ (WebKit::core):
+ (webkit_dom_test_callback_finalize):
+ (webkit_dom_test_callback_set_property):
+ (webkit_dom_test_callback_get_property):
+ (webkit_dom_test_callback_class_init):
+ (webkit_dom_test_callback_init):
+ * bindings/scripts/test/GObject/WebKitDOMTestCallback.h: Added.
+ * bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h: Added.
+ * bindings/scripts/test/ObjC/DOMTestCallback.h: Added.
+ * bindings/scripts/test/ObjC/DOMTestCallback.mm: Added.
+ (-[DOMTestCallback dealloc]):
+ (-[DOMTestCallback finalize]):
+ (-[DOMTestCallback callbackWithClass1Param:]):
+ (-[DOMTestCallback callbackWithClass2Param:strArg:]):
+ (-[DOMTestCallback callbackWithNonBoolReturnType:]):
+ (-[DOMTestCallback customCallback:class6Param:]):
+ (core):
+ (kit):
+ * bindings/scripts/test/ObjC/DOMTestCallbackInternal.h: Added.
+
+2010-05-05 Joseph Pecoraro <joepeck@webkit.org>
+
+ Reviewed by Pavel Feldman.
+
+ Web Inspector: FontView needs Cleanup
+ https://bugs.webkit.org/show_bug.cgi?id=38567
+
+ FontView was missing some of the newer practices for initialization
+ that other Resource Views had. Also its width calculations could
+ result in a single character wrapping. This is general cleanup.
+
+ * inspector/front-end/FontView.js:
+ (WebInspector.FontView): move initialization into contentTabSelected
+ (WebInspector.FontView.prototype.contentTabSelected): handle initialization like other Resource Views
+ (WebInspector.FontView.prototype.updateFontPreviewSize): use a narrower width to prevent text from widowing
+
+2010-05-05 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Nikolas Zimmermann.
+
+ SVG hit testing is *way* too slow
+ https://bugs.webkit.org/show_bug.cgi?id=19312
+
+ Use the cached stroke and fill boundaries in RenderPath as a heuristik to
+ speed up SVG's hit testing.
+
+ No new tests added.
+
+ * rendering/RenderPath.cpp:
+ (WebCore::RenderPath::fillContains):
+ (WebCore::RenderPath::strokeContains):
+
+2010-05-04 Dumitru Daniliuc <dumi@chromium.org>
+
+ Reviewed by Adam Barth.
+
+ Auto-generate all Database callbacks.
+ https://bugs.webkit.org/show_bug.cgi?id=38503
+
+ * DerivedSources.cpp:
+ * DerivedSources.make:
+ * GNUmakefile.am:
+ * WebCore.gypi:
+ * WebCore.pri:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * bindings/js/JSBindingsAllInOne.cpp:
+ * bindings/js/JSCustomSQLStatementCallback.cpp: Removed.
+ * bindings/js/JSCustomSQLStatementCallback.h: Removed.
+ * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
+ (WebCore::JSSQLStatementErrorCallback::handleEvent):
+ * bindings/js/JSCustomSQLStatementErrorCallback.h: Removed.
+ * bindings/js/JSCustomSQLTransactionCallback.cpp: Removed.
+ * bindings/js/JSCustomSQLTransactionCallback.h: Removed.
+ * bindings/js/JSCustomSQLTransactionErrorCallback.cpp: Removed.
+ * bindings/js/JSCustomSQLTransactionErrorCallback.h: Removed.
+ * bindings/js/JSDatabaseCallback.cpp: Removed.
+ * bindings/js/JSDatabaseCallback.h: Removed.
+ * bindings/js/JSDatabaseCustom.cpp:
+ (WebCore::JSDatabase::changeVersion):
+ (WebCore::createTransaction):
+ * bindings/js/JSSQLTransactionCustom.cpp:
+ (WebCore::JSSQLTransaction::executeSql):
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * bindings/scripts/test/JS/JSTestCallback.cpp:
+ * bindings/v8/custom/V8CustomSQLStatementCallback.cpp: Removed.
+ * bindings/v8/custom/V8CustomSQLStatementCallback.h: Removed.
+ * bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
+ (WebCore::V8SQLStatementErrorCallback::handleEvent):
+ * bindings/v8/custom/V8CustomSQLStatementErrorCallback.h: Removed.
+ * bindings/v8/custom/V8CustomSQLTransactionCallback.cpp: Removed.
+ * bindings/v8/custom/V8CustomSQLTransactionCallback.h: Removed.
+ * bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp: Removed.
+ * bindings/v8/custom/V8CustomSQLTransactionErrorCallback.h: Removed.
+ * bindings/v8/custom/V8DatabaseCallback.cpp: Removed.
+ * bindings/v8/custom/V8DatabaseCallback.h: Removed.
+ * bindings/v8/custom/V8DatabaseCustom.cpp:
+ (WebCore::V8Database::changeVersionCallback):
+ (WebCore::createTransaction):
+ * bindings/v8/custom/V8SQLTransactionCustom.cpp:
+ (WebCore::V8SQLTransaction::executeSqlCallback):
+ * storage/DatabaseCallback.h:
+ * storage/DatabaseCallback.idl: Added.
+ * storage/SQLStatement.cpp:
+ (WebCore::SQLStatement::performCallback):
+ * storage/SQLStatementCallback.h:
+ * storage/SQLStatementCallback.idl: Added.
+ * storage/SQLStatementErrorCallback.idl: Added.
+ * storage/SQLTransaction.cpp:
+ (WebCore::SQLTransaction::deliverTransactionCallback):
+ * storage/SQLTransactionCallback.h:
+ * storage/SQLTransactionCallback.idl: Added.
+ * storage/SQLTransactionErrorCallback.h:
+ * storage/SQLTransactionErrorCallback.idl: Added.
+
+2010-05-04 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ Made composited iframes work on Windows
+ https://bugs.webkit.org/show_bug.cgi?id=32446
+
+ This completes the work in http://trac.webkit.org/changeset/57919
+ to create compositing layers in the parent document when an iframe has
+ a compositing layer. The parent document has a layer for the iframe
+ element and builds a layer tree to the page root. The layer tree for the
+ iframe document is then parented to the iframe element's GraphicsLayer.
+
+ The RenderLayerCompositor for the iframe document (which owns the
+ root of the layer tree) now has a clippingLayer which is the
+ parent of the layer tree root so it can be clipped to the parent
+ iframe's bounds, taking into account borders, padding, etc. in
+ the parent iframe element.
+
+ I also got rid of a no longer used function: RenderLayerCompositor::parentInRootLayer
+
+ Test: compositing/iframes/composited-parent-iframe.html
+
+ * rendering/RenderLayerBacking.cpp:Make calls to RenderLayerCompositor to set the clipping bounds for iframe content
+ * rendering/RenderLayerCompositor.cpp:Hook the iframe content to the parent iframe element
+ * rendering/RenderLayerCompositor.h:
+
+2010-05-03 Alexey Proskuryakov <ap@apple.com>
+
+ Reviewed by Adam Barth.
+
+ https://bugs.webkit.org/show_bug.cgi?id=38497
+ <rdar://problem/7759438> Make sure that http URLs always have a host in SecurityOrigin
+
+ This is a hardening fix, and behavior really depends on what an underlying networking layer
+ does. So, no test.
+
+ * page/SecurityOrigin.cpp:
+ (WebCore::schemeRequiresAuthority): List schemes that need an authority for successful loading.
+ (WebCore::SecurityOrigin::SecurityOrigin): Never let e.g. http origins with empty authorities
+ have the same security origin.
+
+2010-05-04 Zhenyao Mo <zmo@google.com>
+
+ Reviewed by Dimitri Glazkov.
+
+ getFramebufferAttachmentParameter should return the original WebGLTexture/WebGLRenderbuffer instead of creating new ones sharing names.
+ https://bugs.webkit.org/show_bug.cgi?id=38236
+
+ * html/canvas/CanvasObject.h: Add type check functions.
+ (WebCore::CanvasObject::isBuffer):
+ (WebCore::CanvasObject::isFramebuffer):
+ (WebCore::CanvasObject::isProgram):
+ (WebCore::CanvasObject::isRenderbuffer):
+ (WebCore::CanvasObject::isShader):
+ (WebCore::CanvasObject::isTexture):
+ * html/canvas/WebGLBuffer.h: Add type check functions.
+ (WebCore::WebGLBuffer::isBuffer):
+ * html/canvas/WebGLFramebuffer.h: Add type check functions.
+ (WebCore::WebGLFramebuffer::isFramebuffer):
+ * html/canvas/WebGLProgram.h: Add type check functions.
+ (WebCore::WebGLProgram::isProgram):
+ * html/canvas/WebGLRenderbuffer.cpp: remove constructor using existing name.
+ * html/canvas/WebGLRenderbuffer.h: Add type check functions; remove constructor using existing name.
+ (WebCore::WebGLRenderbuffer::isRenderbuffer):
+ * html/canvas/WebGLRenderingContext.cpp:
+ (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): Return original Texture/Renderbuffer instead of creating new ones.
+ (WebCore::WebGLRenderingContext::findTexture): Find a WebGLTexture using a name.
+ (WebCore::WebGLRenderingContext::findRenderbuffer): Find a WebGLRenderbuffer using a name.
+ * html/canvas/WebGLRenderingContext.h: Add find* functions.
+ * html/canvas/WebGLShader.h: Add type check functions.
+ (WebCore::WebGLShader::isShader):
+ * html/canvas/WebGLTexture.cpp: remove constructor using existing name.
+ * html/canvas/WebGLTexture.h: Add type check functions; remove constructor using existing name.
+ (WebCore::WebGLTexture::isTexture):
+
+2010-05-04 Luiz Agostini <luiz.agostini@openbossa.org>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] QT_MOBILE_THEME compile time flag
+ https://bugs.webkit.org/show_bug.cgi?id=38439
+
+ Replacing preprocessor conditional used in RenderThemeQt from Q_WS_MAEMO_5 to
+ USE(QT_MOBILE_THEME).
+
+ * WebCore.pro:
+ * platform/qt/RenderThemeQt.cpp:
+ (WebCore::RenderThemeQt::RenderThemeQt):
+ (WebCore::RenderThemeQt::qStyle):
+ (WebCore::RenderThemeQt::extraDefaultStyleSheet):
+ (WebCore::RenderThemeQt::adjustMenuListButtonStyle):
+ (WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
+ * platform/qt/RenderThemeQt.h:
+
+2010-05-04 Joseph Pecoraro <joepeck@webkit.org>
+
+ Reviewed by Dan Bernstein.
+
+ SVG fonts trigger GlyphPage::fill with null font
+ https://bugs.webkit.org/show_bug.cgi?id=38530
+
+ SVG fonts do not use the glyph page cache. This change detects when
+ attempting to fill a GlyphPage with an SVG font and indicates that
+ the glyphs were not available.
+
+ * platform/graphics/GlyphPageTreeNode.cpp:
+ (WebCore::fill): helper method which handles attempts to fill a GlyphPage with SVG or non-SVG fonts
+ (WebCore::GlyphPageTreeNode::initializePage): use the helper where appropriate
+
+2010-05-04 Kent Tamura <tkent@chromium.org>
+
+ Reviewed by David Levin (and unofficially by Enrica Casucci).
+
+ REGRESSION(r54368): Text drag-and-drop from input/textarea doesn't work
+ if the text is like a URL
+ https://bugs.webkit.org/show_bug.cgi?id=38374
+
+ Since r54368, documentFragmentFromDragData() creates an <a> element
+ with no anchor text for URL-like text dragged from input/textarea
+ element. If such text is dropped to input/textarea element, the text
+ is not inserted.
+ To fix this problem, use the original text or the URL as an anchor
+ text.
+
+ Test: editing/pasteboard/drag-drop-url-text.html
+
+ * page/DragController.cpp:
+ (WebCore::documentFragmentFromDragData):
+
+2010-05-04 Steve Block <steveblock@google.com>
+
+ Reviewed by Darin Adler.
+
+ JavaInstanceJSC.cpp and JNIUtilityPrivate.cpp need to include jni_jsobject.h for jlong_to_pt() and ptr_to_jlong()
+ https://bugs.webkit.org/show_bug.cgi?id=38525
+
+ No new tests, build fix only.
+
+ * bridge/jni/jni_jsobject.h: Guard Mac-specific code with PLATFORM(MAC)
+ * bridge/jni/jsc/JNIUtilityPrivate.cpp: Include jni_jsobject.h
+ * bridge/jni/jsc/JavaInstanceJSC.cpp: Include jni_jsobject.h
+
+2010-05-04 Steve Block <steveblock@google.com>
+
+ Reviewed by Darin Adler.
+
+ New FileSystemPOSIX functions cause linker errors on Android
+ https://bugs.webkit.org/show_bug.cgi?id=38521
+
+ No new tests, build fix only.
+
+ * platform/android/FileSystemAndroid.cpp: Remove closeFile, which is provided in FileSystemPOSIX.cpp
+ * platform/posix/FileSystemPOSIX.cpp: Guard writeToFile with !PLATFORM(ANDROID)
+
+2010-05-04 Pavel Feldman <pfeldman@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ Web Inspector: restore main and sidebar scroller positions
+ when switching between panels.
+
+ https://bugs.webkit.org/show_bug.cgi?id=38522
+
+ * inspector/front-end/ElementsPanel.js:
+ (WebInspector.ElementsPanel.prototype.elementsToRestoreScrollPositionsFor):
+ * inspector/front-end/Panel.js:
+ (WebInspector.Panel.prototype.show):
+ (WebInspector.Panel.prototype.hide):
+ (WebInspector.Panel.prototype.elementsToRestoreScrollPositionsFor):
+ (WebInspector.Panel.prototype._storeScrollPositions):
+ (WebInspector.Panel.prototype._restoreScrollPositions):
+ * inspector/front-end/ResourcesPanel.js:
+ (WebInspector.ResourcesPanel.prototype.elementsToRestoreScrollPositionsFor):
+ * inspector/front-end/ScriptsPanel.js:
+ (WebInspector.ScriptsPanel.prototype.elementsToRestoreScrollPositionsFor):
+
+2010-05-04 Steven Lai <steven_lai@asia.apple.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=37900
+ <rdar://problem/7806164> cloneNode() does not preserve z-index with more than six digits
+
+ Tests: fast/dom/HTMLInputElement/clone-input-checked.html
+ fast/dom/clone-node-z-index.html
+
+ * dom/Element.cpp: undid the order change of calling copyNonAttributeProperties() before setAttributes()
+ (WebCore::Element::cloneElementWithoutChildren): uncheck the previous radio button in the same radio button group only when the checked radio box is appended to the dom tree
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::updateCheckedRadioButtons):
+ (WebCore::HTMLInputElement::attach):
+ (WebCore::HTMLInputElement::setChecked):
+ * html/HTMLInputElement.h:
+
+2010-04-29 John Gregg <johnnyg@google.com>
+
+ Reviewed by Dmitry Titov.
+
+ notifications should have dir and replaceId attributes.
+ Note that tests are only enabled in Chromium, skipped elsewhere
+ since notifications aren't implemented.
+ https://bugs.webkit.org/show_bug.cgi?id=38336
+
+ Tests: fast/notifications/notifications-replace.html
+ fast/notifications/notifications-rtl.html
+
+ * notifications/Notification.h:
+ (WebCore::Notification::dir):
+ (WebCore::Notification::setDir):
+ (WebCore::Notification::replaceId):
+ (WebCore::Notification::setReplaceId):
+ * notifications/Notification.idl:
+
+2010-05-04 Alejandro G. Castro <alex@igalia.com>
+
+ Reviewed by Xan Lopez.
+
+ Fixed error defining the float/double minimum in the object
+ properties, the smallest value of a float/double is
+ -G_MAXDOUBLE/-G_MAXFLOAT.
+
+ * bindings/scripts/CodeGeneratorGObject.pm:
+
+2010-05-03 Joseph Pecoraro <joepeck@webkit.org>
+
+ Reviewed by Dan Bernstein.
+
+ REGRESSION: Text clipped in absolutely positioned search inputs
+ https://bugs.webkit.org/show_bug.cgi?id=38468
+
+ Previously I incorrectly added x() and y() to the tx and ty positioning.
+ This clips a search input like a text input, respecting the vertically
+ centered text.
+
+ * rendering/RenderTextControlSingleLine.cpp:
+ (WebCore::RenderTextControlSingleLine::layout): only the Y changes, so change setLocation to setY
+ (WebCore::RenderTextControlSingleLine::controlClipRect):
+
+2010-05-04 Alexander Pavlov <apavlov@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ Web Inspector: REGRESSION: Up/Down, PgUp/PgDown keys do not change numeric style properties
+ https://bugs.webkit.org/show_bug.cgi?id=38516
+
+ * inspector/front-end/StylesSidebarPane.js:
+ (WebInspector.StylePropertyTreeElement.prototype):
+
+2010-05-04 Ben Murdoch <benm@google.com>
+
+ Reviewed by Simon Hausmann.
+
+ Crash in handleTouchEvent: using dangling node ptrs in hashmap
+ https://bugs.webkit.org/show_bug.cgi?id=38514
+
+ When navigating away from a page, if you have your finger still
+ pressed and then lift it on the new page we see a crash if the
+ node got deleted as we still have a dangling pointer in the
+ m_originatingTouchPointTargets hashmap and try to use it as the
+ receiver to dispatch a touchend event.
+
+ Test: fast/events/touch/touch-stale-node-crash.html
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::clear): Clear the hashmap of touch targets.
+
+2010-05-04 Joseph Pecoraro <joepeck@webkit.org>
+
+ Reviewed by Pavel Feldman.
+
+ Web Inspector: Drawer Misbehaving when Docking / Undocking in Console Panel
+ https://bugs.webkit.org/show_bug.cgi?id=38510
+
+ * inspector/front-end/inspector.js:
+ (WebInspector.set attached): resize the drawer after docking/undocking
+
+2010-05-04 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Unreviewed, build fix for Symbian.
+
+ [Symbian] Build fix after r58598.
+
+ Use C99 integer types for the Symbian plugin
+ implementation.
+
+ No new tests, as there is no new functionality.
+
+ * plugins/symbian/PluginPackageSymbian.cpp:
+ (WebCore::PluginPackage::NPVersion):
+ * plugins/symbian/PluginViewSymbian.cpp:
+ (WebCore::PluginView::handlePostReadFile):
+
+2010-05-04 Nikolas Zimmermann <nzimmermann@rim.com>
+
+ Reviewed by Dirk Schulze.
+
+ Split SVGCharacterLayoutInfo in smaller pieces
+ https://bugs.webkit.org/show_bug.cgi?id=38513
+
+ Split SVGCharacterLayoutInfo into SVGCharacterLayoutInfo/SVGCharacterData and SVGTextChunkLayoutInfo.
+ This is a preparation for more work in the text area.
+
+ * Android.mk: Add SVGCharacterData.(cpp|h) and SVGTextChunkLayoutInfo.h to build.
+ * GNUmakefile.am: Ditto.
+ * WebCore.gypi: Ditto.
+ * WebCore.pro: Ditto
+ * WebCore.vcproj/WebCore.vcproj: Ditto.
+ * WebCore.xcodeproj/project.pbxproj: Ditto.
+ * rendering/SVGCharacterData.cpp: Copied from rendering/SVGCharacterLayoutInfo.cpp.
+ * rendering/SVGCharacterData.h: Copied from rendering/SVGCharacterLayoutInfo.h.
+ (WebCore::SVGChar::SVGChar):
+ * rendering/SVGCharacterLayoutInfo.cpp:
+ (WebCore::SVGCharacterLayoutInfo::isInitialLayout): Introduced new helper function to share code between addLayoutInformation/addStackContent.
+ (WebCore::SVGCharacterLayoutInfo::addLayoutInformation): Use new helper function.
+ (WebCore::SVGCharacterLayoutInfo::addStackContent): Ditto
+ * rendering/SVGCharacterLayoutInfo.h:
+ * rendering/SVGRootInlineBox.h: Include new files.
+ * rendering/SVGTextChunkLayoutInfo.h: Copied from rendering/SVGCharacterLayoutInfo.h.
+
+2010-05-04 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Holger Freyther.
+
+ [GTK] GObject DOM bindings
+ https://bugs.webkit.org/show_bug.cgi?id=33590
+
+ Use helper functions from CodeGenerator.pm to figure out whether a
+ type is "fundamental" or not (basically whether it's anything
+ other than a string or a non-pointer type).
+
+ * bindings/scripts/CodeGeneratorGObject.pm:
+
+2010-04-30 Alexander Pavlov <apavlov@chromium.org>
+
+ Reviewed by Yury Semikhatsky.
+
+ Web Inspector: REGRESSION: Disabled style properties are absent in Styles sidebar after WebInspector is re-opened
+ https://bugs.webkit.org/show_bug.cgi?id=38255
+
+ Moved stylesheet-related mappings into a separate object stored
+ in InspectorController rather than InspectorDOMAgent (which gets reset
+ on every frontend [dis]connect).
+
+ * GNUmakefile.am:
+ * WebCore.gypi:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * inspector/InspectorCSSStore.cpp: Added.
+ (WebCore::InspectorCSSStore::InspectorCSSStore):
+ (WebCore::InspectorCSSStore::~InspectorCSSStore):
+ (WebCore::InspectorCSSStore::reset):
+ * inspector/InspectorCSSStore.h: Added.
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::InspectorController):
+ (WebCore::InspectorController::setFrontend):
+ (WebCore::InspectorController::didCommitLoad):
+ * inspector/InspectorController.h:
+ * inspector/InspectorDOMAgent.cpp:
+ (WebCore::InspectorDOMAgent::InspectorDOMAgent):
+ (WebCore::InspectorDOMAgent::discardBindings):
+ (WebCore::InspectorDOMAgent::applyStyleText):
+ (WebCore::InspectorDOMAgent::setStyleText):
+ (WebCore::InspectorDOMAgent::setStyleProperty):
+ (WebCore::InspectorDOMAgent::toggleStyleEnabled):
+ (WebCore::InspectorDOMAgent::setRuleSelector):
+ (WebCore::InspectorDOMAgent::addRule):
+ (WebCore::InspectorDOMAgent::bindStyle):
+ (WebCore::InspectorDOMAgent::bindRule):
+ (WebCore::InspectorDOMAgent::buildObjectForStyle):
+ (WebCore::InspectorDOMAgent::buildObjectForRule):
+ * inspector/InspectorDOMAgent.h:
+ (WebCore::InspectorDOMAgent::create):
+ (WebCore::InspectorDOMAgent::cssStore):
+
+2010-05-04 Mikhail Naganov <mnaganov@chromium.org>
+
+ Reviewed by Pavel Feldman.
+
+ Display "Recording..." item when recording an user-initiated CPU profile.
+
+ https://bugs.webkit.org/show_bug.cgi?id=38043
+
+ * English.lproj/localizedStrings.js:
+ * inspector/front-end/ProfilesPanel.js:
+ (WebInspector.ProfilesPanel.prototype.addProfileHeader):
+ (WebInspector.ProfilesPanel.prototype.removeProfileHeader):
+ (WebInspector.ProfilesPanel.prototype.showProfile):
+ * inspector/front-end/inspector.js:
+ (WebInspector.setRecordingProfile):
+
+2010-05-04 Tucker Jay <jay.tucker@nokia.com>
+
+ Reviewed by Holger Freyther.
+
+ Animated GIF images does not animate 10x as expected by default.
+ https://bugs.webkit.org/show_bug.cgi?id=36818
+
+ Added test case to existing manual test to test the
+ fixed functionality.
+
+ * manual-tests/qt/qt-10loop-anim.gif: Added.
+ * manual-tests/qt/qt-gif-test.html:
+ * platform/graphics/qt/ImageDecoderQt.cpp:
+ (WebCore::ImageDecoderQt::repetitionCount):
+
+2010-05-04 Dirk Schulze <krit@webkit.org>
+
+ Unreviewed sort of XCodes project file.
+
+ * WebCore.xcodeproj/project.pbxproj:
+
+2010-05-03 Steven Lai <steven_lai@asia.apple.com>
+
+ Reviewed by Brady Eidson.
+
+ Reverted hashchange() event back to async.
+ (This change does not update HashChangeEvent to its new proposed interface)
+ https://bugs.webkit.org/show_bug.cgi?id=36201
+ rdar://problem/7780794
+ rdar://problem/7761278 (partial fix)
+
+ Tests: fast/loader/hashchange-event-async.html
+
+ * dom/Document.cpp: reverted hashchange() event back to async
+ (WebCore::Document::enqueueHashchangeEvent):
+
+2010-05-03 Holger Hans Peter Freyther <zecke@selfish.org>
+
+ Rubber-stamped by Xan Lopez.
+
+ [Cairo,WX] Stop leaking a FontPlatformData.
+ https://bugs.webkit.org/show_bug.cgi?id=37500
+
+ Stephan Aßmus pointed out that the pango font backend
+ is leaking memory and fixed it. The WX font backend
+ and the Cairo/Fontconfig backend have the same snippet
+ of code and are leaking memory as well. This commit is
+ fixing that.
+
+ * platform/graphics/cairo/SimpleFontDataCairo.cpp:
+ (WebCore::SimpleFontData::smallCapsFontData):
+ * platform/graphics/wx/SimpleFontDataWx.cpp:
+ (WebCore::SimpleFontData::smallCapsFontData):
+
+2010-05-03 James Robinson <jamesr@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Clean up a few compiler warnings
+ https://bugs.webkit.org/show_bug.cgi?id=38073
+
+ * html/TextMetrics.h:
+ (WebCore::TextMetrics::width):
+ * rendering/style/StyleRareInheritedData.h:
+ * rendering/style/StyleRareNonInheritedData.h:
+
+2010-05-02 Dumitru Daniliuc <dumi@chromium.org>
+
+ Reviewed by Adam Barth.
+
+ Add the ability to auto-generate callbacks to all code generators.
+ https://bugs.webkit.org/show_bug.cgi?id=38414
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * bindings/scripts/CodeGeneratorV8.pm:
+ * bindings/scripts/test/JS/JSTestCallback.cpp: Added.
+ (WebCore::JSTestCallback::JSTestCallback):
+ (WebCore::JSTestCallback::~JSTestCallback):
+ (WebCore::JSTestCallback::callbackWithClass1Param):
+ (WebCore::JSTestCallback::callbackWithClass2Param):
+ * bindings/scripts/test/JS/JSTestCallback.h: Added.
+ (WebCore::JSTestCallback::create):
+ * bindings/scripts/test/V8/JSTestCallback.cpp: Added.
+ (WebCore::V8TestCallback::V8TestCallback):
+ (WebCore::V8TestCallback::~V8TestCallback):
+ (WebCore::V8TestCallback::callbackWithClass1Param):
+ (WebCore::V8TestCallback::callbackWithClass2Param):
+ * bindings/scripts/test/V8/V8TestCallback.h: Added.
+ (WebCore::V8TestCallback::create):
+ * bindings/scripts/test/TestCallback.idl: Added.
+
+2010-05-03 Kevin Watters <kevinwatters@gmail.com>
+
+ Reviewed by Kevin Ollivier.
+
+ [wx] Build and use Mac's ComplexTextController to support complex text in wx.
+ https://bugs.webkit.org/show_bug.cgi?id=38482
+
+ * platform/graphics/FloatSize.h:
+ * platform/graphics/GlyphBuffer.h:
+ (WebCore::GlyphBuffer::advanceAt):
+ (WebCore::GlyphBuffer::add):
+ * platform/graphics/SimpleFontData.h:
+ (WebCore::SimpleFontData::getNSFont):
+ * platform/graphics/mac/ComplexTextController.cpp:
+ * platform/graphics/mac/ComplexTextController.h:
+ * platform/graphics/wx/FontCacheWx.cpp:
+ (WebCore::FontCache::getFontDataForCharacters):
+ (WebCore::FontCache::getLastResortFallbackFont):
+ * platform/graphics/wx/FontPlatformData.h:
+ (toCTFontRef):
+ (WebCore::FontPlatformData::FontPlatformData):
+ (WebCore::FontPlatformData::allowsLigatures):
+ * platform/graphics/wx/FontPlatformDataWx.cpp:
+ (WebCore::FontPlatformData::FontPlatformData):
+ (WebCore::FontPlatformData::cgFont):
+ * platform/graphics/wx/FontPlatformDataWxMac.mm: Added.
+ (WebCore::FontPlatformData::nsFont):
+ (WebCore::FontPlatformData::cacheNSFont):
+ * platform/graphics/wx/FontWx.cpp:
+ (WebCore::Font::canReturnFallbackFontsForComplexText):
+ (WebCore::Font::selectionRectForComplexText):
+ (WebCore::Font::drawComplexText):
+ (WebCore::Font::floatWidthForComplexText):
+ (WebCore::Font::offsetForPositionForComplexText):
+ * platform/graphics/wx/SimpleFontDataWx.cpp:
+ (WebCore::SimpleFontData::platformInit):
+ (WebCore::SimpleFontData::containsCharacters):
+ (WebCore::SimpleFontData::platformWidthForGlyph):
+ * platform/wx/wxcode/fontprops.h:
+ * platform/wx/wxcode/mac/carbon/fontprops.mm:
+ (wxFontContainsCharacters):
+ (GetTextExtent):
+ * platform/wx/wxcode/mac/carbon/non-kerned-drawing.cpp:
+ (WebCore::drawTextWithSpacing):
+ * platform/wx/wxcode/win/fontprops.cpp:
+ (wxFontContainsCharacters):
+ * wscript:
+
+2010-05-03 Abhishek Arya <inferno@chromium.org>
+
+ Reviewed by Adam Barth.
+
+ Add support for controlling clipboard access from javascript.
+ Clipboard access from javascript is disabled by default.
+ https://bugs.webkit.org/show_bug.cgi?id=27751
+
+ Test: editing/execCommand/clipboard-access.html
+
+ * WebCore.base.exp:
+ * editing/EditorCommand.cpp:
+ (WebCore::supportedCopyCut):
+ (WebCore::supportedPaste):
+ (WebCore::createCommandMap):
+ * page/Settings.cpp:
+ (WebCore::Settings::Settings):
+ (WebCore::Settings::setJavaScriptCanAccessClipboard):
+ * page/Settings.h:
+ (WebCore::Settings::javaScriptCanAccessClipboard):
+
+2010-05-03 Alexey Proskuryakov <ap@apple.com>
+
+ Reviewed by Adam Barth.
+
+ https://bugs.webkit.org/show_bug.cgi?id=38285
+ <rdar://problem/7903453> REGRESSION: Javascript command window.open does not work in empty tab
+
+ Cannot be tested, because new windows created in DRT always have an opener, and thus inherit
+ its security origin. Only new windows and tabs created by browser chrome had this problem.
+
+ * loader/FrameLoader.cpp: (WebCore::FrameLoader::init): Moved updateSandboxFlags() call to
+ the beginning, so that an initial document would get correct flags.
+
+2010-05-03 Noam Rosenthal <noam.rosenthal@nokia.com>
+
+ Reviewed by Darin Adler.
+
+ WebGL compile issue.
+ Added ExceptionCode.h to JSWebGLArrayBufferConstructor.cpp, for some reason it was missing.
+ https://bugs.webkit.org/show_bug.cgi?id=38453
+
+ No new tests: compile fix.
+
+ * bindings/js/JSWebGLArrayBufferConstructor.cpp:
+
+2010-05-03 Eric Seidel <eric@webkit.org>
+
+ Unreviewed, rolling out r58685.
+ http://trac.webkit.org/changeset/58685
+ https://bugs.webkit.org/show_bug.cgi?id=38461
+
+ Broke a test on Gtk
+
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+ (WebCore::MediaPlayerPrivateGStreamer::updateStates):
+
+2010-05-03 Yael Aharon <yael.aharon@nokia.com>
+
+ Reviewed by Darin Adler.
+
+ Use HTML5 number parsing in HTMLProgressElement
+ https://bugs.webkit.org/show_bug.cgi?id=38434
+
+ Use parseToDoubleForNumberType instead of toDouble.
+ Throw an exception when the number is NaN or Infinity.
+
+ * html/HTMLProgressElement.cpp:
+ (WebCore::HTMLProgressElement::value):
+ (WebCore::HTMLProgressElement::setValue):
+ (WebCore::HTMLProgressElement::max):
+ (WebCore::HTMLProgressElement::setMax):
+ * html/HTMLProgressElement.h:
+ * html/HTMLProgressElement.idl:
+
+2010-05-03 Jens Alfke <snej@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ [chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
+ https://bugs.webkit.org/show_bug.cgi?id=38397
+
+ No tests (functionality is exposed only through native WebKit API.)
+
+ * html/HTMLFormElement.cpp:
+ (WebCore::HTMLFormElement::prepareSubmit): Call frame loader's dispatchWillSendSubmitEvent
+ * loader/EmptyClients.h:
+ * loader/FrameLoaderClient.h:
+ (WebCore::FrameLoaderClient::dispatchWillSendSubmitEvent): New empty method
+
+2010-05-03 Philippe Normand <pnormand@igalia.com>
+
+ Reviewed by Eric Carlson.
+
+ [GStreamer] forgotten call to durationChanged in updateStates()
+ https://bugs.webkit.org/show_bug.cgi?id=38461
+
+ Notify MediaPlayer if duration is known after playback started.
+
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+ (WebCore::MediaPlayerPrivateGStreamer::updateStates):
+
+2010-05-03 Ryuan Choi <ryuan.choi@gmail.com>
+
+ Reviewed by Darin Adler.
+
+ fixing build break due to clearWatch() when Geolocation feature is
+ disabled.
+
+ https://bugs.webkit.org/show_bug.cgi?id=38091
+
+ no test because this is a build fix only
+
+ * page/Geolocation.cpp:
+ (WebCore::Geolocation::clearWatch):
+
+2010-05-03 Stephan Aßmus <superstippi@gmx.de>
+
+ Reviewed by Holger Freyther.
+
+ [Gtk] Fix leaking the FontPlatformData instance used to create the the
+ small caps font data.
+ https://bugs.webkit.org/show_bug.cgi?id=37500
+
+ No new tests needed.
+
+ * platform/graphics/gtk/SimpleFontDataPango.cpp:
+ (WebCore::SimpleFontData::smallCapsFontData):
+ - Use a stack allocated FontPlatformData instead of a heap allocated
+ one that is never freed.
+
+2010-05-03 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] GraphicsLayer: support webGL
+ https://bugs.webkit.org/show_bug.cgi?id=35388
+
+ Added support GraphicsContext3D to GraphicsLayer.
+ Added paint method to GraphicsContext3D for Qt platform that
+ uses drawTexture() when QGLWidget is used as viewport of
+ QGraphicsWebView.
+ Fine-tuned texture and handling and image to texture conversion to
+ work also when drawTexture() blitting is used.
+
+ * platform/graphics/GraphicsContext3D.h:
+ * platform/graphics/qt/GraphicsContext3DQt.cpp:
+ (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
+ (WebCore::GraphicsContext3D::beginPaint):
+ (WebCore::GraphicsContext3D::paint):
+ (WebCore::GraphicsContext3D::texImage2D):
+ (WebCore::GraphicsContext3D::texSubImage2D):
+ (WebCore::GraphicsContext3D::getImageData):
+ * platform/graphics/qt/GraphicsLayerQt.cpp:
+ (WebCore::GraphicsLayerQtImpl::):
+ (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl):
+ (WebCore::GraphicsLayerQtImpl::paint):
+ (WebCore::GraphicsLayerQtImpl::flushChanges):
+ (WebCore::GraphicsLayerQt::setContentsToGraphicsContext3D):
+ (WebCore::GraphicsLayerQt::setGraphicsContext3DNeedsDisplay):
+ * platform/graphics/qt/GraphicsLayerQt.h:
+
+2010-05-03 Janne Koskinen <janne.p.koskinen@digia.com>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] Fix qtlibraryinfix not to contain space
+
+ List catenation with += adds whitespace cutting the infix
+ from the final target.
+
+ * WebCore.pro:
+
+2010-05-03 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] Fix rendering of <button> elements on Mac OS X
+
+ The <button> element has ButtonPart appearance, not PushButton part,
+ so we have to include ButtonPart when we decide if we should draw the
+ button as raised on Mac OS X.
+
+ https://bugs.webkit.org/show_bug.cgi?id=38458
+
+ * platform/qt/RenderThemeQt.cpp:
+ (WebCore::RenderThemeQt::initializeCommonQStyleOptions):
+
+2010-04-30 Philippe Normand <pnormand@igalia.com>
+
+ Reviewed by Eric Seidel.
+
+ [GStreamer] endless loop after playback ended
+ https://bugs.webkit.org/show_bug.cgi?id=38384
+
+ At playback end ensure duration() will return a valid duration if
+ we managed to calculate it based on current position.
+
+ Test: media/video-duration-known-after-eos.html
+
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+ (WebCore::MediaPlayerPrivateGStreamer::didEnd):
+
+2010-05-03 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
+
+ [Qt] Fix build break on Mac OS X
+
+ * plugins/mac/PluginPackageMac.cpp: Use correct type
+ * WebCore.pro: Remove duplicate symbol, we now have a Qt implementation
+
+2010-05-03 Thomas Zander <t.zander@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] Fix library infix usage when compiling inside of Qt
+
+ Don't apply the infix when building inside Qt, as that's done through the
+ inclusion of qbase.pri.
+
+ * WebCore.pro:
+
+2010-05-02 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ Another case of <rdar://problem/7552959> REGRESSION: Infinite recursion in Position::getInlineBoxAndOffset()
+ https://bugs.webkit.org/show_bug.cgi?id=38445
+
+ Test: editing/selection/mixed-editability-11.html
+
+ * dom/Position.cpp:
+ (WebCore::downstreamIgnoringEditingBoundaries): Added. Returns the furthest visually equivalent
+ position downstream, crossing any editability boundaries.
+ (WebCore::upstreamIgnoringEditingBoundaries): Similarly for upstream.
+ (WebCore::Position::getInlineBoxAndOffset): Changed the logic for finding an inline box for positions
+ whose node is a block flow. Instead of traversing the DOM, advance downstream or upstream as far as
+ possible, crossing any editability boudaries. Infinite recursion is avoided by advancing all the way
+ and checking that the new position is different from the starting position. Also replaced the specific
+ test for buttons with the generic and more comprehensive canHaveChildrenForEditing().
+
+2010-05-02 Tasuku Suzuki <tasuku.suzuki@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] Fix compilation with QT_NO_BEARERMANAGEMENT
+ https://bugs.webkit.org/show_bug.cgi?id=38324
+
+ * platform/network/NetworkStateNotifier.h:
+ * platform/network/qt/NetworkStateNotifierQt.cpp:
+
+2010-04-29 Janne Koskinen <janne.p.koskinen@digia.com>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] QtWebKit versioning added
+ https://bugs.webkit.org/show_bug.cgi?id=37207
+
+ QtWebkit releases separated from Qt release cycle.
+
+ * WebCore.pro:
+
+2010-05-02 Joseph Pecoraro <joepeck@webkit.org>
+
+ Reviewed by Timothy Hatcher.
+
+ Web Inspector: Old Style trimWhitespace() should be trim()
+ https://bugs.webkit.org/show_bug.cgi?id=38441
+
+ * inspector/front-end/SourceFrame.js:
+ (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):
+
+2010-05-02 Tasuku Suzuki <tasuku.suzuki@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] Fix compilation with QT_NO_LINEEDIT
+ https://bugs.webkit.org/show_bug.cgi?id=38324
+
+ * platform/qt/RenderThemeQt.cpp:
+ (WebCore::RenderThemeQt::~RenderThemeQt):
+ (WebCore::RenderThemeQt::findFrameLineWidth):
+
+2010-05-02 Pavel Feldman <pfeldman@chromium.org>
+
+ Not reviewed: Touch inspector controller to kick windows tests.
+
+ * inspector/InspectorController.cpp:
+
+2010-05-02 Pavel Feldman <pfeldman@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ Web Inspector: IMG nodes are being added to the DOM tree late, sometimes hiding the revealed element.
+
+ https://bugs.webkit.org/show_bug.cgi?id=38432
+
+ * inspector/front-end/ElementsTreeOutline.js:
+ (WebInspector.ElementsTreeOutline.prototype._onmousemove):
+ (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):
+ (WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
+ (WebInspector.ElementsTreeElement.prototype.updateTitle):
+ (WebInspector.ElementsTreeElement.prototype._attributeHTML):
+ ():
+
+2010-05-02 Dirk Schulze <krit@webkit.org>
+
+ Reviewed by Nikolas Zimmermann.
+
+ SVG hkern implementation incomplete
+ https://bugs.webkit.org/show_bug.cgi?id=38407
+
+ Test: svg/text/text-hkern.svg
+
+ The current SVG hkern implementation is incomplete and partly wrong. We pass the ACID3 test
+ by accident.
+ The new implementation supports all glyph and unicode combinations that are allowed by the Spec
+ and fixes various of bugs. The parser moved from SVGFontElement to the general parsing code in
+ SVGParserUtilities.
+ Some clean-up makes the code more readable and reuseable for the upcoming vkern implementation.
+ hkern support for text on path is missing and will be added by a following patch.
+ Unicode strings of hkern elements are just parsed once and not on every glyph again anymore.
+
+ * rendering/SVGRootInlineBox.cpp:
+ (WebCore::calculateCSSKerning):
+ (WebCore::applySVGKerning):
+ (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
+ * svg/SVGFontElement.cpp:
+ (WebCore::stringMatchesUnicodeRange):
+ (WebCore::stringMatchesGlyphName):
+ (WebCore::matches):
+ (WebCore::SVGFontElement::getHorizontalKerningPairForStringsAndGlyphs):
+ * svg/SVGFontElement.h:
+ * svg/SVGHKernElement.cpp:
+ (WebCore::SVGHKernElement::buildHorizontalKerningPair):
+ * svg/SVGHKernElement.h:
+ * svg/SVGParserUtilities.cpp:
+ (WebCore::parseGlyphName):
+ (WebCore::parseUnicodeRange):
+ (WebCore::parseKerningUnicodeString):
+ * svg/SVGParserUtilities.h:
+
+2010-05-02 Pavel Feldman <pfeldman@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ Web Inspector: debugger shortcuts are processed twice if source frame has focus.
+
+ https://bugs.webkit.org/show_bug.cgi?id=38431
+
+ * inspector/front-end/SourceFrame.js:
+ (WebInspector.SourceFrame):
+ (WebInspector.SourceFrame.prototype._createViewerIfNeeded):
+
+2010-05-02 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
+
+ Reviewed by Eric Seidel.
+
+ [Qt] Build error in GraphicsContext3DQt.cpp
+ https://bugs.webkit.org/show_bug.cgi?id=38382
+
+ Removed duplicate implementation of isGLES2Compliant from
+ GraphicsContext3DQt.cpp. Removed deprecated API stuff for
+ texImage2D/texSubImage2D.
+ * platform/graphics/qt/GraphicsContext3DQt.cpp:
+
+2010-05-02 Garret Kelly <gdk@chromium.org>
+
+ Reviewed by David Levin.
+
+ Make the Touch RuntimeEnabledFeature disabled by default.
+ https://bugs.webkit.org/show_bug.cgi?id=38392
+
+ * bindings/generic/RuntimeEnabledFeatures.cpp: Disable the Touch feature by default.
+
+2010-05-02 Michael Nordman <michaeln@google.com>
+
+ Reviewed by Dmitry Titov.
+
+ Define two new ResourceRequestBase TargetTypes for worker and shared worker
+ main resources. Use the new target types where appropiate. Add logic to marshal
+ the target type specified by requests initiated on a background worker thread.
+
+ https://bugs.webkit.org/show_bug.cgi?id=38295
+
+ No new tests. This doesn't have script visible artifacts.
+
+ * platform/network/ResourceRequestBase.cpp: marshal the values
+ (WebCore::ResourceRequestBase::adopt):
+ (WebCore::ResourceRequestBase::copyData):
+ * platform/network/ResourceRequestBase.h: define the types
+ (WebCore::ResourceRequestBase::):
+ * workers/DefaultSharedWorkerRepository.cpp: use TargetIsSharedWorker
+ (WebCore::SharedWorkerScriptLoader::load):
+ * workers/Worker.cpp: use TargetIsWorker
+ (WebCore::Worker::Worker):
+ * workers/WorkerContext.cpp: use TargetIsScript for importScripts
+ (WebCore::WorkerContext::importScripts):
+ * workers/WorkerScriptLoader.cpp: add a data member for the target type
+ (WebCore::WorkerScriptLoader::WorkerScriptLoader):
+ (WebCore::WorkerScriptLoader::createResourceRequest):
+ * workers/WorkerScriptLoader.h:
+
+2010-05-02 Noam Rosenthal <noam.rosenthal@nokia.com>
+
+ Reviewed by Adele Peterson.
+
+ Webkit doesn't compile with 3D-canvas enabled and video disabled
+ https://bugs.webkit.org/show_bug.cgi?id=38297
+
+ Added a #ifdef ENABLE(VIDEO) to WebGL code
+
+ No new tests: compile fix.
+
+ * bindings/js/JSWebGLRenderingContextCustom.cpp:
+ (WebCore::JSWebGLRenderingContext::texImage2D):
+ (WebCore::JSWebGLRenderingContext::texSubImage2D):
+
+2010-05-01 Evan Stade <estade@chromium.org>
+
+ Reviewed by David Levin.
+
+ [chromium] Skia needs to fade DragImages
+ https://bugs.webkit.org/show_bug.cgi?id=38008
+
+ tested by DragImageTest
+
+ * platform/chromium/DragImageChromiumSkia.cpp:
+ (WebCore::dissolveDragImageToFraction):implement
+ (WebCore::createDragImageFromImage):deep copy instead of shallow
+
+2010-05-01 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ REGRESSION (r58273): Visited links do not change color immediately when Cmd-clicked
+ https://bugs.webkit.org/show_bug.cgi?id=38422
+ <rdar://problem/7921778>
+
+ Tests:
+ manual-tests/visited-link-new-window.html
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::initElement): Only cache the visited link state
+ when invoked as part of a helper call to styleForElement or pseudoStyleForElement,
+ to avoid caching the visited link state beyond the scope of a single style lookup.
+ (WebCore::CSSStyleSelector::styleForElement): Adjust for above change.
+ (WebCore::CSSStyleSelector::pseudoStyleForElement): Adjust for above change.
+ * css/CSSStyleSelector.h:
+ (WebCore::CSSStyleSelector::styleForElement): Change so "visited link helper mode"
+ can't accidentally be called from outside CSSStyleSelector itself.
+ (WebCore::CSSStyleSelector::pseudoStyleForElement): ditto
+ * manual-tests/visited-link-new-window.html: Added. I could not figure out any way
+ to make an automated test that supports visited link coloring.
+
+2010-05-01 Yael Aharon <yael.aharon@nokia.com>
+
+ Reviewed by Darin Adler.
+
+ Move number parsing code out of HTMLInputElement.
+ https://bugs.webkit.org/show_bug.cgi?id=38203
+
+ The numebr parsing code follows HTML5 parsing rules and should be available outside of HTMLInputElement.
+ No new tests as no new functionality was introduced.
+
+ * html/HTMLInputElement.cpp:
+ * html/HTMLInputElement.h:
+ * html/HTMLParser.cpp:
+ (WebCore::serializeForNumberType):
+ (WebCore::parseToDoubleForNumberType):
+ * html/HTMLParser.h:
+ * html/StepRange.cpp:
+ (WebCore::StepRange::clampValue):
+ (WebCore::StepRange::valueFromElement):
+ * html/ValidityState.cpp:
+ (WebCore::ValidityState::typeMismatch):
+ * rendering/RenderSlider.cpp:
+ (WebCore::RenderSlider::setValueForPosition):
+
+2010-05-01 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Oliver Hunt.
+
+ [GTK] GObject DOM bindings
+ https://bugs.webkit.org/show_bug.cgi?id=33590
+
+ Unify more logic to skip functions into SkipFunction, and
+ whitelist the two [Custom] methods in HTMLCollection.idl.
+
+ * bindings/scripts/CodeGeneratorGObject.pm:
+
+2010-05-01 Robert Hogan <robert@webkit.org>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] Add smart paste support
+
+ https://bugs.webkit.org/show_bug.cgi?id=38136
+
+ * WebCore.pro:
+ * editing/qt/SmartReplaceQt.cpp: Added.
+ (WebCore::isCharacterSmartReplaceExempt):
+ * platform/qt/PasteboardQt.cpp:
+ (WebCore::Pasteboard::writeSelection):
+ (WebCore::Pasteboard::canSmartReplace):
+
+2010-04-30 Yoshiki Hayashi <yhayashi@google.com>
+
+ Reviewed by Shinichiro Hamaji.
+
+ https://bugs.webkit.org/show_bug.cgi?id=38249
+
+ Fixes an issue where border height and padding height are ignored when computing vertically shrinking flexbox's height.
+
+ Test: fast/flexbox/child-flexing.html
+
+ * rendering/RenderFlexibleBox.cpp:
+ (WebCore::RenderFlexibleBox::allowedChildFlex):
+
+2010-04-30 Shinichiro Hamaji <hamaji@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ Add layoutTestController.setPrinting()
+ https://bugs.webkit.org/show_bug.cgi?id=37203
+
+ Use the renderer's width insteead of screen's width as the width of
+ a screen depends on machines.
+
+ * rendering/RenderTreeAsText.cpp:
+ (WebCore::externalRepresentation):
+
+2010-04-30 Joseph Pecoraro <joepeck@webkit.org>
+
+ Reviewed by Timothy Hatcher.
+
+ Web Inspector: Missing INSPECTOR Guard in Console::lastWMLErrorMessage
+ https://bugs.webkit.org/show_bug.cgi?id=38366
+
+ Console::lastWMLErrorMessage is only available if WML is enabled, however
+ its implementation only makes sense as long as INSPECTOR is enabled
+ as well. So this adds the ENABLE(INSPECTOR) guard in the function. A
+ browser without ENABLE(INSPECTOR) will always get an empty result.
+
+ * page/Console.cpp:
+
+2010-04-28 Joseph Pecoraro <joepeck@webkit.org>
+
+ Reviewed by Oliver Hunt.
+
+ REGRESSION(r58313): Regression evident in pixel tests: the search icon is always clipped at the bottom.
+ https://bugs.webkit.org/show_bug.cgi?id=38253
+
+ Test: fast/css/input-search-padding.html
+
+ An <input type="search"> contains an inner block, which is explicitly
+ centered in RenderTextControlSingleLine based on the height of the element.
+ However, the clipping rect was not using the set location, and instead
+ calculated off of the top border and padding alone. This also vertically
+ centers the Caps Lock indicator.
+
+ * rendering/RenderTextControl.cpp: moved controlClipRect implementation to RenderTextControlSingleLine
+ * rendering/RenderTextControl.h: allow a subclass implementation of controlClipRect, removed redundant hasControlClip implementation, and moved controlClipRect
+ * rendering/RenderTextControlSingleLine.cpp:
+ (WebCore::RenderTextControlSingleLine::paint): vertically center the Caps Lock indicator
+ (WebCore::RenderTextControlSingleLine::controlClipRect): use the set location of the anonymous inner block instead
+ * rendering/RenderTextControlSingleLine.h: allow for an implementation of controlClipRect for <input type="search">
+
+2010-04-30 Jon Honeycutt <jhoneycutt@apple.com>
+
+ Caret may fail to blink if a focus handler brings up a modal dialog
+ https://bugs.webkit.org/show_bug.cgi?id=38372
+
+ Reviewed by Darin Adler.
+
+ * manual-tests/onfocus-alert-blinking-caret.html: Added.
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::handleMousePressEvent):
+ Moved the call to setCaretBlinkingSuspended() from here...
+ (WebCore::EventHandler::handleMousePressEvent):
+ ... to here. This makes us suspend caret blinking before dispatching the
+ mouse down event. If dispatching the mouse down event allows the message
+ loop to run, we want mouse up events received in that message loop to be
+ able to resume caret blinking.
+ (WebCore::EventHandler::lostMouseCapture):
+ We've lost mouse capture and won't be notified of mouse up events;
+ resume caret blinking.
+
+ * page/EventHandler.h:
+ Declare lostMouseCapture().
+
+2010-04-30 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Unreviewed, build fix.
+
+ [Chromium] Added a simple IdentifierRep struct and removed dependency on
+ IdentifierRep.h.
+
+ * bindings/v8/V8NPObject.cpp: Added simple IdentifierRep struct.
+
+2010-04-30 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Unreviewed, build fix.
+
+ [Chromium] Remove bridge/ from include paths.
+
+ * WebCore.gyp/WebCore.gyp: Removed bridge/ from include path.
+
+2010-04-30 Abhishek Arya <inferno@chromium.org>
+
+ Reviewed by David Kilzer.
+
+ Convert m_documentUnderMouse, m_dragInitiator to RefPtr.
+ Eliminated unused m_dragInitiator accessor to prevent dereferencing.
+ https://bugs.webkit.org/show_bug.cgi?id=37618
+
+ Test: editing/pasteboard/drag-drop-iframe-refresh-crash.html
+
+ * page/DragController.cpp:
+ (WebCore::DragController::tryDocumentDrag):
+ (WebCore::DragController::concludeEditDrag):
+ * page/DragController.h:
+ (WebCore::DragController::draggingImageURL):
+ (WebCore::DragController::documentUnderMouse):
+
+2010-04-29 James Robinson <jamesr@chromium.org>
+
+ Reviewed by Simon Fraser.
+
+ Calls FrameView::scrollPositionChanged whenever a ScrollView is scrolled
+ https://bugs.webkit.org/show_bug.cgi?id=38286
+
+ When a ScrollView's scroll position is changed, we have to call
+ FrameView::scrollPositionChanged to generate repaint invalidation for
+ fixed position elements. This ends up getting called indirectly when
+ the ScrollView has a platformWidget through the port layer
+ (see WebHTMLView.mm's _frameOrBoundsChanged method for how the mac
+ port does it) but not when there is no platformWidget.
+
+ This is tested by the fast/repaint/fixed-* tests when run in pixel
+ mode.
+
+ Test: fast/repaint/fixed-move-after-keyboard-scroll.html
+
+ * page/FrameView.h:
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::valueChanged):
+ * platform/ScrollView.h:
+ (WebCore::ScrollView::scrollPositionChanged):
+
+2010-04-30 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Use C99 integer types in more places.
+
+ * manual-tests/NPN_Invoke/main.c:
+ (NPP_New):
+ (NPP_NewStream):
+ (NPP_WriteReady):
+ (NPP_Write):
+ (NPP_HandleEvent):
+ (functionPointerForTVector):
+ * plugins/mac/PluginViewMac.cpp:
+ (WebCore::PluginView::platformGetValueStatic):
+ (WebCore::PluginView::handlePostReadFile):
+
+2010-04-30 Darin Adler <darin@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ Remove unused scrollRectIntoViewRecursively function
+ https://bugs.webkit.org/show_bug.cgi?id=38403
+
+ * page/Chrome.cpp:
+ (WebCore::Chrome::scrollRectIntoView): Moved comment here that was previously
+ in the scrollRectIntoViewRecursively function.
+
+ * platform/ScrollView.cpp: Get rid scrollRectIntoViewRecursively.
+ * platform/ScrollView.h: Ditto. Fix comment that refers to the two functions.
+ Also correct all uses of the term "method" to use the C++ term "function" and
+ got rid of double spaces after periods.
+
+2010-04-30 Anders Carlsson <andersca@apple.com>
+
+ Another Qt build fix.
+
+ * plugins/qt/PluginViewQt.cpp:
+ (WebCore::PluginView::platformGetValueStatic):
+
+2010-04-30 Anders Carlsson <andersca@apple.com>
+
+ Add back TRUE, FALSE and NULL macros. They were not meant to be removed!
+
+ * bridge/npapi.h:
+
+2010-04-30 Anders Carlsson <andersca@apple.com>
+
+ Try to fix the Qt build this time.
+
+ * plugins/qt/PluginPackageQt.cpp:
+ (WebCore::staticPluginQuirkRequiresGtkToolKit_NPN_GetValue):
+ (WebCore::PluginPackage::NPVersion):
+
+2010-04-30 Anders Carlsson <andersca@apple.com>
+
+ Yet another build fix.
+
+ * plugins/gtk/PluginPackageGtk.cpp:
+ (WebCore::PluginPackage::NPVersion):
+
+2010-04-30 Anders Carlsson <andersca@apple.com>
+
+ Fix build.
+
+ * bridge/npapi.h:
+
+2010-04-30 Jian Li <jianli@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ [chromium] Add WebFileSystem interface and hook up with all FileSystem methods.
+ https://bugs.webkit.org/show_bug.cgi?id=38228
+
+ * platform/chromium/ChromiumBridge.h:
+ * platform/chromium/FileSystemChromium.cpp:
+ (WebCore::openFile):
+ (WebCore::closeFile):
+ (WebCore::seekFile):
+ (WebCore::truncateFile):
+ (WebCore::readFromFile):
+ (WebCore::writeToFile):
+
+2010-04-30 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Final part of
+
+ https://bugs.webkit.org/show_bug.cgi?id=20784
+ move npapi.h to C99 integer types
+
+ * bridge/npapi.h:
+ Remove the old types.
+
+2010-04-30 Sheriff Bot <webkit.review.bot@gmail.com>
+
+ Unreviewed, rolling out r58569.
+ http://trac.webkit.org/changeset/58569
+ https://bugs.webkit.org/show_bug.cgi?id=38399
+
+ This broke the GTK bots due to bad GC behavior (Requested by
+ ericu on #webkit).
+
+ * bindings/js/JSWorkerContextCustom.cpp:
+ * bindings/v8/custom/V8WorkerContextCustom.cpp:
+ * storage/Database.idl:
+ * storage/SQLError.idl:
+ * storage/SQLResultSet.idl:
+ * storage/SQLResultSetRowList.idl:
+ * storage/SQLTransaction.idl:
+ * workers/WorkerContext.cpp:
+ (WebCore::WorkerContext::openDatabase):
+ * workers/WorkerContext.h:
+ (WebCore::WorkerContext::databaseExceededQuota):
+ * workers/WorkerContext.idl:
+
+2010-04-30 Anders Carlsson <andersca@apple.com>
+
+ Fix GTK+ build.
+
+ * plugins/gtk/PluginViewGtk.cpp:
+ (WebCore::PluginView::handlePostReadFile):
+ (WebCore::PluginView::platformGetValueStatic):
+
+2010-04-30 Anders Carlsson <andersca@apple.com>
+
+ Fix Qt build.
+
+ * plugins/qt/PluginViewQt.cpp:
+ (WebCore::PluginView::handlePostReadFile):
+ (WebCore::PluginView::platformGetValue):
+
+2010-04-30 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Timothy Hatcher.
+
+ Next step towards fixing
+
+ https://bugs.webkit.org/show_bug.cgi?id=20784
+ move npapi.h to C99 integer types
+
+ Use the C99 types everywhere. The "old" types are still around but will be removed
+ in a subsequent commit.
+
+ * bridge/npapi.h:
+ (_NPCocoaEvent::):
+ * plugins/PluginPackage.h:
+ * plugins/PluginStream.cpp:
+ (WebCore::PluginStream::deliverData):
+ * plugins/PluginStream.h:
+ * plugins/PluginView.cpp:
+ (WebCore::PluginView::postURLNotify):
+ (WebCore::PluginView::postURL):
+ (WebCore::PluginView::write):
+ (WebCore::PluginView::handlePost):
+ * plugins/PluginView.h:
+ * plugins/PluginViewNone.cpp:
+ (WebCore::PluginView::handlePostReadFile):
+ * plugins/npapi.cpp:
+ (NPN_MemAlloc):
+ (NPN_MemFlush):
+ (NPN_PostURLNotify):
+ (NPN_PostURL):
+ (NPN_Write):
+ * plugins/npfunctions.h:
+ * plugins/win/PluginPackageWin.cpp:
+ (WebCore::PluginPackage::NPVersion):
+ * plugins/win/PluginViewWin.cpp:
+ (WebCore::PluginView::handlePostReadFile):
+
+2010-04-30 Peter Kasting <pkasting@google.com>
+
+ Reviewed by David Levin.
+
+ Make all image decoders set the "failed" bit if an image could not be
+ completely decoded, but no more data is coming. The ICO and BMP
+ decoders already did this.
+ https://bugs.webkit.org/show_bug.cgi?id=35411
+
+ "Failed" does not cause the image to not be displayed, it simply causes
+ us to not bother to try to decode again if future requests are made, and
+ for some decoders, lets the decoder clean up some of its temporary
+ objects.
+
+ No layout tests because this does not change the visible output of decoding in any way.
+
+ * platform/image-decoders/gif/GIFImageDecoder.cpp:
+ (WebCore::GIFImageDecoder::frameComplete): Return whether the frame could be marked as complete.
+ (WebCore::GIFImageDecoder::decode): Fail if read() needs more data (and thus returns false) and no more is coming.
+ * platform/image-decoders/gif/GIFImageDecoder.h:
+ * platform/image-decoders/gif/GIFImageReader.cpp:
+ (GIFImageReader::do_lzw): Instead of returning true for buffer underrun and false for failure, return false for both and set the failure flag on failure.
+ (GIFImageReader::read): Ditto.
+ * platform/image-decoders/gif/GIFImageReader.h:
+ * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
+ (WebCore::):
+ (WebCore::JPEGImageReader::decode): See do_lzw() comment above.
+ (WebCore::JPEGImageDecoder::decode): Fail if decode() needs more data (and thus returns false) and no more is coming.
+ * platform/image-decoders/jpeg/JPEGImageDecoder.h:
+ * platform/image-decoders/png/PNGImageDecoder.cpp:
+ (WebCore::PNGImageReader::decode): Return true for decode success, false for buffer underrun or decode failure, and set the failure flag on decode failure.
+ (WebCore::PNGImageDecoder::decode): See JPEGImageDecoder::decode() comment above.
+ * platform/image-decoders/png/PNGImageDecoder.h:
+
+2010-04-30 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Eric Carlson.
+
+ <rdar://problem/7902467> - Audio plays upon loading of npr.org but shouldn't
+
+ No new tests. (Currently no way to test such site specific hack behavior)
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::HTMLMediaElement):
+ (WebCore::HTMLMediaElement::asyncEventTimerFired): If the event to be dispatched is the canplay
+ event, wrap the dispatch with m_dispatchingCanPlayEvent set.
+ (WebCore::HTMLMediaElement::play): If m_dispatchingCanPlayEvent is true and the site is npr.org,
+ don't perform the play().
+ * html/HTMLMediaElement.h: Add m_dispatchingCanPlayEvent member.
+
+2010-04-30 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Adele Peterson.
+
+ Part of <rdar://problem/6649734> Text repainting does not account for glyphs which draw outside the typographic bounds of the font
+ https://bugs.webkit.org/show_bug.cgi?id=6274
+
+ Account for glyph overflow of characters in the range U+1E00..U+2000, but without sending them
+ through the complex text code path. Instead, introduce a variant of the fast path that tracks
+ glyph overflow.
+
+ * platform/graphics/Font.cpp:
+ (WebCore::Font::drawText): Use codePath().
+ (WebCore::Font::floatWidth): Use codePath(). Pass the GlyphOverflow pointer through to
+ floatWidthForSimpleText() if the code path is SimpleWithGlyphOverflow.
+ (WebCore::Font::selectionRectForText): Use codePath().
+ (WebCore::Font::offsetForPosition): Ditto.
+ * platform/graphics/Font.h: Replaced canUseGlyphCache() with codePath(). Added a GlyphOverflow
+ parameter to floatWidthForSimpleText().
+ * platform/graphics/FontFastPath.cpp:
+ Removed ROMAN_AND_GREEK_DIACRITICS_CAN_USE_GLYPH_CACHE.
+ (WebCore::Font::codePath): Renamed canUseGlyphCache() to this. Where it used to return false,
+ it now returns Complex. Where it used to return true, it now returns Simple, except for
+ the range U+1E00..U+2000, where it now returns SimpleWithGlyphOverflow.
+ (WebCore::Font::floatWidthForSimpleText): Added a GlyphOverflow parameter. If not 0, have the
+ width iterator account for glyph bounds, then update the GlyphOverflow accordingly.
+ * platform/graphics/WidthIterator.cpp:
+ (WebCore::WidthIterator::WidthIterator): Added boolean parameter telling the width iterator
+ whether to account for glyph bounds. Initialize m_accountForGlyphBounds accordingly. Initialize
+ m_maxGlyphBoundingBoxY, m_minGlyphBoundingBoxY, m_firstGlyphOverflow and m_lastGlyphOverflow.
+ (WebCore::WidthIterator::advance): If accounting for glyph bounds, update the above member variables.
+ * platform/graphics/WidthIterator.h:
+ (WebCore::WidthIterator::maxGlyphBoundingBoxY): Added this accessor.
+ (WebCore::WidthIterator::minGlyphBoundingBoxY): Ditto.
+ (WebCore::WidthIterator::firstGlyphOverflow): Ditto.
+ (WebCore::WidthIterator::lastGlyphOverflow): Ditto.
+
+2010-04-30 Chris Marrin <cmarrin@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ Reversed the order of the CSSMatrix.multiply method
+ https://bugs.webkit.org/show_bug.cgi?id=38337
+
+ Test: transforms/svg-vs-css.xhtml
+
+ * css/WebKitCSSMatrix.cpp:
+ (WebCore::WebKitCSSMatrix::multiply):
+ * platform/graphics/transforms/TransformationMatrix.cpp:
+
+2010-04-30 Kevin Ollivier <kevino@theolliviers.com>
+
+ Unreviewed. Attempt to fix the Chromium Mac build after the last commit.
+
+ * WebCore.gypi:
+
+2010-04-30 Kevin Ollivier <kevino@theolliviers.com>
+
+ Reviewed by Dan Bernstein.
+
+ Allow other ports to compile ATSUI and CoreText functions in SimpleFontData for Mac.
+ https://bugs.webkit.org/show_bug.cgi?id=38334
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * platform/graphics/mac/SimpleFontDataATSUI.mm: Copied from WebCore/platform/graphics/mac/SimpleFontDataMac.mm.
+ * platform/graphics/mac/SimpleFontDataCoreText.cpp: Copied from WebCore/platform/graphics/mac/SimpleFontDataMac.mm.
+ * platform/graphics/mac/SimpleFontDataMac.mm:
+
+2010-04-30 Shinichiro Hamaji <hamaji@chromium.org>
+
+ Reviewed by Simon Fraser.
+
+ SHOULD NEVER BE REACHED assertion loading forbes.com
+ https://bugs.webkit.org/show_bug.cgi?id=38272
+
+ Ignore page media related pseudo classes.
+
+ Test: printing/pseudo-class-outside-page.html
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
+
+2010-04-30 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Unreviewed, build fix.
+
+ Fix compiler warning "suggest parentheses around"
+
+ No new tests as there is no new functionality.
+
+ * svg/SVGAnimateElement.cpp:
+ (WebCore::SVGAnimateElement::calculateFromAndToValues):
+
+2010-04-30 Kent Tamura <tkent@chromium.org>
+
+ Unreviewed. Regression fix.
+
+ Revert a part of r58564 to be compatible with prior behavior
+ https://bugs.webkit.org/show_bug.cgi?id=38383
+
+ * rendering/RenderTextControlSingleLine.cpp:
+ (WebCore::RenderTextControlSingleLine::forwardEvent):
+ r58564 made a region check for the cancel button stricter, but it
+ made some tests failing on Chromium. So, relax the check again.
+
+2010-04-29 Jeremy Orlow <jorlow@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ Change StorageEvent.uri to StorageEvent.url to match the spec
+ https://bugs.webkit.org/show_bug.cgi?id=38331
+
+ As I mentioned in http://www.mail-archive.com/public-webapps@w3.org/msg08495.html
+ WebKit is the only one who places the document's URL in a 'uri' property
+ rather than a 'url' property. Even though we've shipped several versions of
+ browsers with the old name, we probably should change this to comply with the
+ spec.
+
+ This stuff is covered by existing tests.
+
+ * storage/StorageEvent.cpp:
+ (WebCore::StorageEvent::create):
+ (WebCore::StorageEvent::StorageEvent):
+ (WebCore::StorageEvent::initStorageEvent):
+ * storage/StorageEvent.h:
+ (WebCore::StorageEvent::url):
+ * storage/StorageEvent.idl:
+
+2010-04-30 Nikolas Zimmermann <nzimmermann@rim.com>
+
+ Reviewed by Dirk Schulze.
+
+ REGRESSION: RenderPath does not handle repaints correctly anymore if bounds changed
+ https://bugs.webkit.org/show_bug.cgi?id=38385
+
+ The last SVG performance patch broke repainting if bounds of a RenderPath get smaller.
+ It would only repaint the smaller part, not the original larger bounds.
+
+ Remove all lazy calculation of the repaint rects, instead calculate object/strokeBoundingBox and repaintRectInLocalCoordinates
+ once in layout - after LayoutRepainter grabbed the initial bounds, before calling repaintAfterLayout(). We can now inline
+ all these functions, and save a lot of m_path.isEmpty() checks, which are expensive. No need to store a seperated markerBoundingBox(),
+ combine with strokeBoundingBox() -> save one FloatRect per RenderPath. Move strokeBoundingBox() from SVGRenderBase to RenderObject,
+ right next to objectBoundingBox() - to save unnecessary toSVGRenderBase() calls. Completly remove this method.
+
+ Overall this is a regression fix, a performance improvement and saves memory. Something for everyone.
+
+ Tests: svg/custom/repaint-stroke-width-changes.svg
+
+ * rendering/RenderObject.cpp: Added strokeBoundingBox() here, to avoid the toSVGRenderBase() dance.
+ (WebCore::RenderObject::strokeBoundingBox):
+ * rendering/RenderObject.h: Ditto.
+ * rendering/RenderPath.cpp:
+ (WebCore::RenderPath::RenderPath):
+ (WebCore::RenderPath::layout): Fix regression, do repainting correctly, by recalculating the boundaries, if needed, instead of nulling them.
+ (WebCore::RenderPath::paint): Cache SVGRenderStyle in local variable, remove no longer valid FIXME.
+ (WebCore::RenderPath::calculateMarkerBoundsIfNeeded): Return a FloatRect, to avoid having to store the marker bounding box seperated.
+ (WebCore::RenderPath::styleWillChange): Mark boundaries as dirty.
+ (WebCore::RenderPath::updateCachedBoundaries): New function to (re-)calculate all cached boundaries, only called from layout().
+ * rendering/RenderPath.h: Rename cached rect variables to have more sensible names.
+ (WebCore::RenderPath::objectBoundingBox): Inlined, just returns the cached value - no more lazy creation. Huge speedup as this is hot code.
+ (WebCore::RenderPath::strokeBoundingBox): Ditto.
+ (WebCore::RenderPath::repaintRectInLocalCoordinates): Ditto.
+ * rendering/RenderSVGBlock.h: Remove toSVGRenderBase() method.
+ * rendering/RenderSVGImage.h: Ditto.
+ * rendering/RenderSVGInline.cpp: No need to call toSVGRenderBase() just to get the strokeBoundingBox(). Unifies code to retrieve bounding boxes.
+ (WebCore::RenderSVGInline::strokeBoundingBox):
+ * rendering/RenderSVGInline.h: Remove toSVGRenderBase() method.
+ * rendering/RenderSVGModelObject.h: Ditto.
+ * rendering/RenderSVGResourceFilter.cpp: No need to call toSVGRenderBase() anymore, just grab the strokeBoundingBox() from the RenderObject.
+ (WebCore::RenderSVGResourceFilter::applyResource):
+ * rendering/RenderSVGText.h: Remove toSVGRenderBase() method.
+ * rendering/SVGRenderSupport.h: Ditto. Remove markerBoundingBox() method, now combined with strokeBoundingBox().
+ (WebCore::SVGRenderBase::strokeBoundingBox):
+ * rendering/SVGRootInlineBox.h: Remove toSVGRenderBase() method.
+ * rendering/style/SVGRenderStyle.h: Add hasMarkers() helper method, to avoid doing unnecessary work in RenderPath.
+ (WebCore::SVGRenderStyle::hasMarkers):
+
+2010-04-30 Eric Uhrhane <ericu@chromium.org>
+
+ Reviewed by Dmitry Titov.
+
+ Add bindings for async DB API in Workers.
+ https://bugs.webkit.org/show_bug.cgi?id=34992
+
+ Tests: storage/change-version-handle-reuse-worker.html
+ storage/execute-sql-args-worker.html
+
+ * bindings/js/JSWorkerContextCustom.cpp: Add openDatabase binding.
+ (WebCore::JSWorkerContext::openDatabase):
+
+ * bindings/v8/custom/V8WorkerContextCustom.cpp: Add openDatabase stub; Chromium will need work both in V8 and in the browser process before we can turn this on there.
+ (WebCore::V8WorkerContext::openDatabaseCallback):
+
+ Add NoStaticTables flags to all objects now shared with workers.
+ * storage/Database.idl:
+ * storage/SQLError.idl:
+ * storage/SQLResultSet.idl:
+ * storage/SQLResultSetRowList.idl:
+ * storage/SQLTransaction.idl:
+
+ * workers/WorkerContext.h: Add databaseExceededQuota.
+ * workers/WorkerContext.cpp:
+ (WebCore::WorkerContext::databaseExceededQuota): Add stub implementation for testing; you just get 5MB for now.
+ (WebCore::WorkerContext::openDatabase): Remove invalid assertion.
+
+ Add the IDL for the call to openDatabase.
+ * workers/WorkerContext.idl:
+
+2010-04-30 Shinichiro Hamaji <hamaji@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ Unnecessary PrintContext::end() calls
+ https://bugs.webkit.org/show_bug.cgi?id=38247
+
+ Refactoring only, so no new tests.
+
+ * page/PrintContext.cpp:
+ (WebCore::PrintContext::pageNumberForElement):
+ (WebCore::PrintContext::numberOfPages):
+
+2010-04-30 Kent Tamura <tkent@chromium.org>
+
+ Reviewed by Adele Peterson.
+
+ Implement interactive behavior of spin buttons.
+ https://bugs.webkit.org/show_bug.cgi?id=35686
+
+ Introduce SpinButtonElement. It is a shadow element class for
+ spin buttons. If the upper side of the element is clicked, calls
+ HTMLInputElement::stepUpFromRenderer(1). If the lower button is
+ clicked, calls HTMLInputElement::stepUpFromRenderer(-1).
+
+ SpinButtonElement tracks the mouse pointer position, and
+ RenderTheme sets ControlStates::SpinUpState if the pointer is on
+ the upper side.
+
+ Test: platform/mac/fast/forms/input-number-click.html
+
+ * dom/Element.h:
+ (WebCore::Element::isSpinButtonElement):
+ * editing/VisibleSelection.cpp:
+ (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries):
+ Remove an assertion. lastEditablePositionBeforePositionInRoot() can
+ return null in a case that m_end is at a shadow element (a spin button)
+ and baseRoot is another shadow element (inner text block) in the same
+ node (an INPUT element).
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::stepUpFromRenderer):
+ * html/HTMLInputElement.h:
+ (WebCore::HTMLInputElement::hasSpinButton):
+ Add types supporting step attribute except RANGE.
+ * rendering/RenderTextControlSingleLine.cpp:
+ (WebCore::RenderTextControlSingleLine::nodeAtPoint):
+ (WebCore::RenderTextControlSingleLine::forwardEvent):
+ (WebCore::RenderTextControlSingleLine::preferredContentWidth):
+ (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded):
+ * rendering/RenderTextControlSingleLine.h:
+ * rendering/RenderTheme.cpp:
+ (WebCore::RenderTheme::controlStatesForRenderer):
+ (WebCore::RenderTheme::isSpinUpButtonPartPressed):
+ (WebCore::RenderTheme::isSpinUpButtonPartHovered):
+ * rendering/RenderTheme.h:
+ * rendering/TextControlInnerElements.cpp:
+ (WebCore::SpinButtonElement::SpinButtonElement):
+ (WebCore::SpinButtonElement::defaultEventHandler):
+ * rendering/TextControlInnerElements.h:
+ (WebCore::SpinButtonElement::isSpinButtonElement):
+ (WebCore::SpinButtonElement::isEnabledFormControl):
+ (WebCore::SpinButtonElement::onUpButton):
+
+2010-04-30 Yael Aharon <yael.aharon@nokia.com>
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ [Qt] Enable DOMWindow constructor for HTMLProgressElement
+ https://bugs.webkit.org/show_bug.cgi?id=38333
+
+ Add ENABLE_PROGRESS_TAG to FEATURES_DEFINES_JAVASCRIPT.
+
+ * WebCore.pri:
+
+2010-04-30 Kent Tamura <tkent@chromium.org>
+
+ Reviewed by Adele Peterson.
+
+ Mac implementation of outer-spin-button appearance, and anonymous
+ element generation for <input type=number>.
+ https://bugs.webkit.org/show_bug.cgi?id=32813
+
+ The implementation uses NSStepperCell. Like the other Mac
+ controls, it has only three candidates for sizes.
+
+ The editable block of an input element is shrunk, and the
+ anonymous block for a spin button is put on the right of the
+ editable block.
+
+ Tests: platform/mac/fast/forms/input-appearance-spinbutton-size.html
+ platform/mac/fast/forms/input-appearance-spinbutton.html
+
+ * dom/Element.cpp:
+ (WebCore::Element::pseudoStyleCacheIsInvalid):
+ * dom/InputElement.h:
+ (WebCore::InputElement::hasSpinButton):
+ * html/HTMLInputElement.h:
+ (WebCore::HTMLInputElement::hasSpinButton): Return true for NUMBER type.
+ * platform/mac/ThemeMac.mm:
+ (WebCore::sizeFromNSControlSize): Split the main part of sizeFromFont()
+ to this in order to use stepperControlSizeForFont() instead of
+ controlSizeForFont().
+ (WebCore::sizeFromFont): Just calls sizeFromNSControlSize() with
+ sizeFromFont(). No behavior changes.
+ (WebCore::stepperSizes): Returns sizes for mini, small, and regular.
+ (WebCore::stepperControlSizeForFont):
+ Dedicated version of controlSizeForFont().
+ (WebCore::stepper): Returns NSStepperCell object with specified settings.
+ (WebCore::paintStepper):
+ (WebCore::ThemeMac::controlSize): Support for OuterSpinButton.
+ (WebCore::ThemeMac::minimumControlSize): ditto.
+ (WebCore::ThemeMac::inflateControlPaintRect): ditto.
+ (WebCore::ThemeMac::paint): ditto.
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::paintBoxDecorations):
+ Move the content to paintBoxDecorationsWithSize().
+ (WebCore::RenderBox::paintBoxDecorationsWithSize):
+ * rendering/RenderBox.h: Declare paintBoxDecorationsWithSize().
+ * rendering/RenderTextControlSingleLine.cpp:
+ (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
+ (WebCore::RenderTextControlSingleLine::paintBoxDecorations):
+ Call paintBoxDecorationsWithSize() with smaller width by decorationWidthRight().
+ (WebCore::RenderTextControlSingleLine::addFocusRingRects):
+ Add a rectangle of which width is smaller by decorationWidthRight().
+ (WebCore::RenderTextControlSingleLine::layout):
+ Adjust m_outerSpinButton position.
+ (WebCore::RenderTextControlSingleLine::styleDidChange):
+ (WebCore::RenderTextControlSingleLine::textBlockWidth):
+ (WebCore::RenderTextControlSingleLine::decorationWidthRight):
+ (WebCore::RenderTextControlSingleLine::preferredDecorationWidthRight):
+ (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded):
+ Creates an element for m_outerSpinButton if it is needed.
+ (WebCore::RenderTextControlSingleLine::createInnerTextStyle):
+ (WebCore::RenderTextControlSingleLine::createOuterSpinButtonStyle):
+ * rendering/RenderTextControlSingleLine.h: Declare new methods and m_outerSpinButton.
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderThemeMac::adjustRepaintRect): Support for OuterSpinButton.
+
+2010-04-29 Adam Barth <abarth@webkit.org>
+
+ Unreviewed. Update JSC CodeGenerator baseline. Not sure how I missed
+ this one earlier.
+
+ * bindings/scripts/test/JS/JSTestObj.cpp:
+ (WebCore::jsTestObjPrototypeFunctionSerializedValue):
+
+2010-04-29 Justin Garcia <justin.garcia@apple.com>
+
+ Reviewed by Adele Peterson.
+
+ Need to updateLayout after typing commands too
+ https://bugs.webkit.org/show_bug.cgi?id=38352
+
+ Replaced !m_parent checks in EditCommand.cpp by the more descriptive isTopLevelCommand().
+ Move the post editing operation updateLayout() call to {un,re}appliedEditing so that text insertions,
+ which don't go through EditCommand::{un,re}apply() can benefit from it too. No test case possible
+ since most platforms have a layout performed as a side effect of post operation selection code.
+
+ * editing/EditCommand.cpp:
+ (WebCore::EditCommand::apply):
+ (WebCore::EditCommand::unapply):
+ (WebCore::EditCommand::reapply):
+ * editing/EditCommand.h:
+ (WebCore::EditCommand::isTopLevelCommand):
+ * editing/Editor.cpp:
+ (WebCore::Editor::appliedEditing):
+ (WebCore::Editor::unappliedEditing):
+ (WebCore::Editor::reappliedEditing):
+
+2010-04-29 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ <rdar://problem/7918086> REGRESSION (r57820): Controller is not displayed in window when opening a MP3 file in browser window
+ https://bugs.webkit.org/show_bug.cgi?id=38350
+
+ Tests: media/audio-only-video-intrinsic-size.html
+ media/media-document-audio-size.html
+
+ * rendering/RenderVideo.cpp:
+ (WebCore::RenderVideo::RenderVideo): Until metadata is available, ignore the natural size
+ reported by the player.
+ (WebCore::RenderVideo::videoSizeChanged): Respect a natural size of zero if reported by the
+ player, except in standalone media documents.
+
+2010-04-29 Anders Carlsson <andersca@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ First part of
+ https://bugs.webkit.org/show_bug.cgi?id=20784
+ move npapi.h to C99 integer types.
+
+ Add nptypes.h to the build.
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * bridge/npapi.h:
+ * bridge/npruntime.h:
+ * bridge/nptypes.h: Added.
+
+2010-04-29 Xan Lopez <xlopez@igalia.com>
+
+ Rubber-stamped by Adam Barth.
+
+ Update GObject bindings test results. We are actually moving
+ backwards here, but we'll update them again when we figure out
+ what broke.
+
+ * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
+ (webkit_dom_test_obj_set_property):
+ (webkit_dom_test_obj_get_property):
+
+2010-04-29 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Anders Carlsson.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=38277
+ MiniBrowser: -[WebCoreFlippedView currentEditor]: unrecognized selector
+
+ * platform/mac/ThemeMac.mm:
+ (-[WebCoreFlippedView currentEditor]): Added currentEditor nil implementation.
+
+2010-04-29 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ CodeGeneratorJS.pm should be consistent about castedThis versus castedThisObj
+ https://bugs.webkit.org/show_bug.cgi?id=38338
+
+ Currently CodeGeneratorJS.pm uses castThis for methods and
+ castedThisObj for attributes. This inconsistency makes it difficult to
+ factor common code genereration code into methods shared by both kinds
+ of bindings. This match aligns the names so that a future patch (e.g.,
+ in https://bugs.webkit.org/show_bug.cgi?id=38313) can reduce copy/paste
+ code.
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * bindings/scripts/test/JS/JSTestObj.cpp:
+ (WebCore::setJSTestObjIntAttr):
+ (WebCore::setJSTestObjLongLongAttr):
+ (WebCore::setJSTestObjUnsignedLongLongAttr):
+ (WebCore::setJSTestObjStringAttr):
+ (WebCore::setJSTestObjTestObjAttr):
+ (WebCore::setJSTestObjAttrWithException):
+ (WebCore::setJSTestObjAttrWithSetterException):
+ (WebCore::setJSTestObjAttrWithGetterException):
+ (WebCore::jsTestObjPrototypeFunctionVoidMethod):
+ (WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
+ (WebCore::jsTestObjPrototypeFunctionIntMethod):
+ (WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
+ (WebCore::jsTestObjPrototypeFunctionObjMethod):
+ (WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
+ (WebCore::jsTestObjPrototypeFunctionMethodWithException):
+ (WebCore::jsTestObjPrototypeFunctionCustomMethod):
+ (WebCore::jsTestObjPrototypeFunctionCustomMethodWithArgs):
+ (WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
+ (WebCore::jsTestObjPrototypeFunctionAddEventListener):
+ (WebCore::jsTestObjPrototypeFunctionRemoveEventListener):
+ (WebCore::jsTestObjPrototypeFunctionWithDynamicFrame):
+ (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg):
+ (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg):
+ (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture):
+ (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):
+ (WebCore::jsTestObjPrototypeFunctionWithScriptStateVoid):
+ (WebCore::jsTestObjPrototypeFunctionWithScriptStateObj):
+ (WebCore::jsTestObjPrototypeFunctionWithScriptStateVoidException):
+ (WebCore::jsTestObjPrototypeFunctionWithScriptStateObjException):
+ (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
+ (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
+ (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
+
+2010-04-29 Gustavo Noronha Silva <gustavo.noronhaollabora.co.uk>
+
+ Reviewed by Xan Lopez.
+
+ [GTK] pointerCursor should use the default cursor set for the window, not GDK_LEFT_PTR
+ https://bugs.webkit.org/show_bug.cgi?id=36963
+
+ Use the default cursor instead of hard-coding left pointer.
+
+ * platform/gtk/CursorGtk.cpp:
+ (WebCore::Cursor::Cursor):
+ (WebCore::pointerCursor):
+
+2010-04-29 Ilya Tikhonovsky <loislo@chromium.org>
+
+ Reviewed by Yury Semikhatsky.
+
+ WebInspector: If Timeline panel is in recording mode and is not visible and has received
+ new events then these events do not appear in the panel when the panel becomes visible.
+ Timeline popup may appear in the upper left window corner when you switch to another panel.
+ https://bugs.webkit.org/show_bug.cgi?id=38322
+
+ * inspector/front-end/Popover.js:
+ (WebInspector.PopoverHelper.prototype._mouseMove.doHide):
+ (WebInspector.PopoverHelper.prototype._mouseMove):
+ (WebInspector.PopoverHelper.prototype.hidePopup):
+ (WebInspector.PopoverHelper.prototype._hidePopup):
+ * inspector/front-end/TimelinePanel.js:
+ (WebInspector.TimelinePanel.prototype.show):
+ (WebInspector.TimelinePanel.prototype._scheduleRefresh):
+ (WebInspector.TimelinePanel.prototype._refresh):
+
+2010-04-29 Anton Muhin <antonm@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ Let's cache nodelists instead of DynamicNodeList::Caches
+ https://bugs.webkit.org/show_bug.cgi?id=33696
+
+ Test: fast/dom/Element/node-list-identity.html
+
+ * bindings/js/JSNodeCustom.cpp:
+ (WebCore::JSNode::markChildren): Mark all cached node lists as well
+ * dom/ClassNodeList.cpp:
+ (WebCore::ClassNodeList::ClassNodeList): Don't need DynamicNodeList::Caches argument any more
+ (WebCore::ClassNodeList::~ClassNodeList): Remove from the cache
+ * dom/ClassNodeList.h: Added a field with original class names to be used as a key for removal from the cache
+ (WebCore::ClassNodeList::create): Don't need DynamicNodeList::Caches argument any more
+ * dom/NameNodeList.cpp:
+ (WebCore::NameNodeList::NameNodeList): Don't need DynamicNodeList::Caches argument any more
+ (WebCore::NameNodeList::~NameNodeList): Remove from the cache
+ * dom/NameNodeList.h:
+ (WebCore::NameNodeList::create): Don't need DynamicNodeList::Caches argument any more
+ * dom/Node.cpp:
+ (WebCore::Node::removeCachedClassNodeList): Remove ClassNodeList from the cache
+ (WebCore::Node::removeCachedNameNodeList): Remove NameNodeList from the cache
+ (WebCore::Node::removeCachedTagNodeList): Remove TagNodeList from the cache
+ (WebCore::Node::getElementsByTagNameNS): Switch to caching node lists themselves, not the data
+ (WebCore::Node::getElementsByName): Switch to caching node lists themselves, not the data
+ (WebCore::Node::getElementsByClassName): Switch to caching node lists themselves, not the data
+ (WebCore::NodeListsNodeData::invalidateCaches): Switch to caching node lists themselves, not the data
+ (WebCore::NodeListsNodeData::invalidateCachesThatDependOnAttributes): Switch to caching node lists themselves, not the data
+ (WebCore::NodeListsNodeData::isEmpty): Switch to caching node lists themselves, not the data
+ (WebCore::markNodeLists): Helper to mark all the node lists in the cache
+ (WebCore::Node::markCachedNodeListsSlow): Mark all the cached node lists if any could be present
+ * dom/Node.h:
+ (WebCore::Node::markCachedNodeLists): Fast-path marking of cached node lists---bails out if there is no rare data
+ * dom/NodeRareData.h: Changed type of caches to hold raw pointers to node lists, not RefPtr's to data
+ * dom/TagNodeList.cpp:
+ (WebCore::TagNodeList::TagNodeList): Don't need DynamicNodeList::Caches argument any more
+ (WebCore::TagNodeList::~TagNodeList): Remove from the cache
+ * dom/TagNodeList.h:
+ (WebCore::TagNodeList::create): Don't need DynamicNodeList::Caches argument any more
+
+2010-04-29 Mikhail Naganov <mnaganov@chromium.org>
+
+ Reviewed by Yury Semikhatsky.
+
+ [Chromium] Update ScriptProfileNode to retrieve execution time in milliseconds.
+
+ https://bugs.webkit.org/show_bug.cgi?id=38330
+
+ * bindings/v8/ScriptProfileNode.cpp:
+ (WebCore::ScriptProfileNode::totalTime):
+ (WebCore::ScriptProfileNode::selfTime):
+
+2010-04-28 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ A form without a submit button unexpectedly performs its action when Return is pressed
+ https://bugs.webkit.org/show_bug.cgi?id=9756
+
+ Implemented implicit form submission algorithm as defined in HTML5 spec:
+ http://www.whatwg.org/specs/web-apps/current-work/multipage/association-of-controls-and-forms.html#implicit-submission,
+ falling back to match IE's behavior in the edge cases.
+
+ The underlying rules are:
+
+ * If the form has no enabled submit buttons, submit if Enter/Return is pressed on the only single-line text field.
+
+ * Otherwise, submit form using first enabled submit button if Enter/Return is pressed on a field
+ that's not a textarea or a select.
+
+ Test: fast/forms/implicit-submission.html
+
+ * dom/SelectElement.cpp:
+ (WebCore::SelectElement::menuListDefaultEventHandler): Ripped out implicit submission for select elements.
+ (WebCore::SelectElement::listBoxDefaultEventHandler): Ditto.
+ (WebCore::SelectElement::defaultEventHandler): Ditto.
+ * dom/SelectElement.h: Ditto.
+ (WebCore::HTMLFormElement::submitImplicitly): Renamed submitClick to submitImplicitly to better match HTML5 spec
+ language, changed the logic to match the rules above.
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::defaultEventHandler): Reamed clickDefaultButton to implicitSubmission to better match
+ HTML5 spec language, made radio element to trigger implicit submission.
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::defaultEventHandler): Removed passing of form() as parameter, because it's no longer
+ necessary.
+
+2010-04-29 Paweł Hajdan, Jr. <phajdan.jr@chromium.org>
+
+ Reviewed by Jeremy Orlow.
+
+ Fix building with libpng-1.4.
+ https://bugs.webkit.org/show_bug.cgi?id=33287
+
+ No new tests (no behavior change).
+
+ Original patch by John Bowler <jbowler@acm.org>
+
+ * platform/image-encoders/skia/PNGImageEncoder.cpp:
+ (WebCore::PNGImageEncoder::encode):
+
+2010-04-29 Adam Langley <agl@chromium.org>
+
+ Reviewed by David Levin.
+
+ This patch adds support for WOFF in Chromium. Since Chromium
+ already transcodes all OpenType files for security reasons we
+ are adding WOFF support into the transcoder.
+
+ https://bugs.webkit.org/show_bug.cgi?id=38217
+
+ * css/CSSFontFaceSrcValue.cpp:
+ (WebCore::CSSFontFaceSrcValue::isSupportedFormat):
+ Recognise "woff" as a font-face format value (guarded by
+ ENABLE(OPENTYPE_SANITIZER) at this point)
+ * platform/graphics/opentype/OpenTypeSanitizer.cpp:
+ (WebCore::OpenTypeSanitizer::sanitize):
+ Change so that the transcoded font can be larger than the original.
+ (WOFF files are compressed, so the transcoded TTF is typically
+ larger.)
+
+2010-04-29 Alex Milowski <alex@milowski.com>
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Updates to the Qt build to enable building MathML support.
+
+ * WebCore.pri:
+ * WebCore.pro:
+
+2010-04-29 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Gustavo Noronha.
+
+ [GTK] GObject DOM bindings
+ https://bugs.webkit.org/show_bug.cgi?id=33590
+
+ Do not generate unneeded boilerplate in {get,set}_property methods
+ when there are no properties to generate code for. This gets rid
+ of lots of compiler warnings.
+
+ * bindings/scripts/CodeGeneratorGObject.pm:
+
+2010-04-29 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ [Qt] Speed up text layouting
+ https://bugs.webkit.org/show_bug.cgi?id=31719
+
+ Use QFontMetrics::width() for the text width calculation instead
+ of QTextLayout. This avoids expensive bearing calculations and the
+ line breaking code.
+
+ * platform/graphics/qt/FontQt.cpp:
+ (WebCore::Font::floatWidthForComplexText):
+
+2010-04-29 Kwang Yul Seo <skyul@company100.net>
+
+ Reviewed by Simon Hausmann.
+
+ [WINCE] Export g_stackBase with JS_EXPORTDATA
+ https://bugs.webkit.org/show_bug.cgi?id=37437
+
+ Declare g_stackBase with JS_EXPORTDATA as it is imported from JavaScriptCore.
+
+ * platform/wince/SharedTimerWince.cpp:
+
+2010-04-29 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ Remove custom bindings for PopStateEvent.initPopStateEvent
+ https://bugs.webkit.org/show_bug.cgi?id=38311
+
+ Our code generation of SerializedScriptValue was slightly buggy, but
+ it's easy to fix. Notice that the conversion to an atomic string is
+ handled by the C++ type system and doesn't require logic in the code
+ generator.
+
+ * bindings/js/JSPopStateEventCustom.cpp:
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * bindings/scripts/CodeGeneratorV8.pm:
+ * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
+ (webkit_dom_test_obj_serialized_value):
+ * bindings/scripts/test/GObject/WebKitDOMTestObj.h:
+ * bindings/scripts/test/JS/JSTestObj.cpp:
+ (WebCore::):
+ (WebCore::jsTestObjPrototypeFunctionSerializedValue):
+ * bindings/scripts/test/JS/JSTestObj.h:
+ * bindings/scripts/test/ObjC/DOMTestObj.h:
+ * bindings/scripts/test/ObjC/DOMTestObj.mm:
+ (-[DOMTestObj serializedValue:]):
+ * bindings/scripts/test/TestObj.idl:
+ * bindings/scripts/test/V8/V8TestObj.cpp:
+ (WebCore::TestObjInternal::serializedValueCallback):
+ (WebCore::ConfigureV8TestObjTemplate):
+ * bindings/v8/custom/V8PopStateEventCustom.cpp:
+ * dom/PopStateEvent.idl:
+
+2010-04-29 Kent Tamura <tkent@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ Fix a bug that selection drag-and-drop doesn't work for input/textarea.
+ https://bugs.webkit.org/show_bug.cgi?id=38175
+
+ The code supposed the selected region was in the destination text
+ field. It is not true in a case of drag-and-drop.
+
+ Test: editing/pasteboard/drag-drop-input-textarea.html
+
+ * dom/InputElement.cpp:
+ (WebCore::InputElement::handleBeforeTextInsertedEvent):
+ * html/HTMLTextAreaElement.cpp:
+ (WebCore::HTMLTextAreaElement::handleBeforeTextInsertedEvent):
+
+2010-04-29 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ Remove custom bindings for NodeFilter.acceptNode
+ https://bugs.webkit.org/show_bug.cgi?id=38309
+
+ This "custom" code was just an instance of the CallWith=ScriptState
+ pattern. Also, it looks like V8 just had a garbage implemenation that
+ did nothing.
+
+ * WebCore.gypi:
+ * bindings/js/JSNodeFilterCustom.cpp:
+ * bindings/v8/custom/V8NodeFilterCustom.cpp: Removed.
+ * dom/NodeFilter.idl:
+
+2010-04-29 Noam Rosenthal <noam.rosenthal@nokia.com>
+
+ Reviewed by Laszlo Gombos.
+
+ [Qt] QtWebkit doesn't link with 3D canvas
+ https://bugs.webkit.org/show_bug.cgi?id=38299
+
+ Added implementation for GraphicsContext3D::isGLES2Compliant, which returns the correct value based on a Qt #define.
+
+ No new tests: build fix
+
+ * platform/graphics/qt/GraphicsContext3DQt.cpp:
+ (WebCore::GraphicsContext3D::isGLES2Compliant):
+
+2010-04-29 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Reviewed by Tor Arne Vestbø.
+
+ [Qt] REGRESSION(r57638): tst_qwebframe::objectDeleted() fails
+ https://bugs.webkit.org/show_bug.cgi?id=38316
+
+ Accessing properties of a deleted objects doesn't throw an exception
+ anymore.
+
+ Continue to expose the QObject class wrapper for objects that
+ previously existed but don't exist anymore. QtClass is safe to
+ use with a deleted QObject.
+
+ * bridge/qt/qt_instance.cpp:
+ (JSC::Bindings::QtInstance::getClass): Return null only if m_class
+ doesn't exist yet and there's no m_object.
+
+2010-04-29 Noam Rosenthal <noam.rosenthal@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ Reverse animations don't work in some use cases
+ https://bugs.webkit.org/show_bug.cgi?id=38075
+
+ This was due to a code path special-casing reverse animations, that became obselete when we aligned our animation code
+ with the CA implementation. That special case code path is now a bug - and this patch removes it.
+
+ http://staff.washington.edu/fmf/2009/03/25/iphone-3d-css-transformations/ now runs the reverse
+ animation correctly.
+
+ * platform/graphics/qt/GraphicsLayerQt.cpp:
+ (WebCore::TransformAnimationQt::applyFrame):
+
+2010-04-29 Jan Hanssen <jhanssen@codeaurora.org>
+
+ Reviewed by Adam Barth.
+
+ HTMLOptionElement::ownerSelectElement() needs to consider keygen elements
+ https://bugs.webkit.org/show_bug.cgi?id=26016
+
+ Patch written by Grace Kloba <klobag@gmail.com>, test fixed by me.
+
+ Test: fast/dom/HTMLKeygenElement/keygen-option-select.html
+
+ * html/HTMLOptionElement.cpp:
+ (WebCore::HTMLOptionElement::ownerSelectElement):
+ Make HTMLOptionElement::ownerSelectElement() consider the keygen element in addition to the current select element.
+
+2010-04-29 Gustavo Sverzut Barbieri <barbieri@profusion.mobi>
+
+ Reviewed by Eric Seidel.
+
+ Add EFL-specific code to Widget.h and move the empty
+ frameRectsChanged() definition to Widget.cpp, since the EFL port
+ needs to override that.
+ http://webkit.org/b/36317
+
+ No new tests required.
+
+ * WebCore.base.exp:
+ * platform/Widget.cpp:
+ (WebCore::Widget::frameRectsChanged):
+ * platform/Widget.h:
+
+2010-04-29 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] GraphicsContext3DQt.cpp does not implement isGLES2Compliant()
+ https://bugs.webkit.org/show_bug.cgi?id=38216
+
+ * platform/graphics/qt/GraphicsContext3DQt.cpp:
+ (WebCore::GraphicsContext3D::isGLES2Compliant):
+
+2010-04-29 Zhenyao Mo <zmo@google.com>
+
+ Reviewed by Dimitri Glazkov.
+
+ Remove the unnecessary texImage2D function with Image as input in GraphicsContext3D
+ https://bugs.webkit.org/show_bug.cgi?id=38235
+
+ * html/canvas/WebGLRenderingContext.cpp:
+ (WebCore::WebGLRenderingContext::texImage2D): Add extractImageData; add a common entry point for texImage2D with image input.
+ (WebCore::WebGLRenderingContext::texImage2DBase): Add this function as the common entry point for texImage2D.
+ (WebCore::WebGLRenderingContext::texSubImage2D): Add extractImageData; add a common entry point for texSubImage2D with image input.
+ (WebCore::WebGLRenderingContext::texSubImage2DBase): Add this function as the common entry point for texSubImage2D.
+ * html/canvas/WebGLRenderingContext.h: Add tex*Image{Base/Image} function declaration.
+ * platform/graphics/GraphicsContext3D.h: Remove tex*Image declaration with Image input.
+ * platform/graphics/mac/GraphicsContext3DMac.cpp: Remove tex*Image implementation with Image input.
+ (WebCore::GraphicsContext3D::texImage2D):
+ (WebCore::GraphicsContext3D::texSubImage2D):
+
+2010-04-29 Noam Rosenthal <noam.rosenthal@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] GraphicsLayer: flicker when starting an animation before the previous one ended.
+ https://bugs.webkit.org/show_bug.cgi?id=38076
+
+ This was due to the cude in the removeAnimations functions, which called deleteLater() without stopping the
+ animation synchronously. The delay between the call to that function and the actual call to the animation's destructor
+ is when the flicker occured. We fix this by calling stop() synchronously, and making sure that the value is reverted
+ upon stop (updateState) and not upon the object's destruction.
+
+ http://staff.washington.edu/fmf/2009/03/25/iphone-3d-css-transformations/ now doesn't flicker when
+ the animation is toggled frequently.
+
+ * platform/graphics/qt/GraphicsLayerQt.cpp:
+ (WebCore::TransformAnimationQt::~TransformAnimationQt):
+ (WebCore::TransformAnimationQt::applyFrame):
+ (WebCore::TransformAnimationQt::updateState):
+ (WebCore::OpacityAnimationQt::~OpacityAnimationQt):
+ (WebCore::OpacityAnimationQt::updateState):
+ (WebCore::GraphicsLayerQt::removeAnimationsForProperty):
+ (WebCore::GraphicsLayerQt::removeAnimationsForKeyframes):
+
+2010-04-28 Luiz Agostini <luiz.agostini@openbossa.org>
+
+ Reviewed by Simon Fraser.
+
+ Media queries empty values
+ https://bugs.webkit.org/show_bug.cgi?id=38116
+
+ Adding isValid() method to MediaQueryExp to make it possible to differentiate
+ between queries with empty values and queries with invalid values.
+
+ Test: fast/media/media-query-invalid-value.html
+
+ * css/MediaQueryEvaluator.cpp:
+ (WebCore::MediaQueryEvaluator::eval):
+ * css/MediaQueryExp.cpp:
+ (WebCore::MediaQueryExp::MediaQueryExp):
+ * css/MediaQueryExp.h:
+ (WebCore::MediaQueryExp::isValid):
+
+2010-04-28 Pavel Feldman <pfeldman@chromium.org>
+
+ Reviewed by Yury Semikhatsky.
+
+ Web Inspector: Allow editing script resources when resource tracking is enabled.
+
+ https://bugs.webkit.org/show_bug.cgi?id=38269
+
+ * inspector/front-end/ScriptView.js:
+ * inspector/front-end/ScriptsPanel.js:
+ (WebInspector.ScriptsPanel.prototype.canEditScripts):
+ (WebInspector.ScriptsPanel.prototype.editScriptSource):
+ * inspector/front-end/SourceFrame.js:
+ (WebInspector.SourceFrame.prototype.get textModel):
+ * inspector/front-end/SourceView.js:
+ (WebInspector.SourceView):
+ (WebInspector.SourceView.prototype._addBreakpoint):
+ (WebInspector.SourceView.prototype._editLine):
+ (WebInspector.SourceView.prototype._editLineComplete):
+ (WebInspector.SourceView.prototype._sourceIDForLine):
+
+2010-04-25 Antonio Gomes <tonikitoo@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Clicking a scrollbar blurs the currently focused element
+ https://bugs.webkit.org/show_bug.cgi?id=16809
+
+ WebKit ports that do not use native (platform) widgets for rendering the scrollbars
+ are currently mismatching a common behaviour of other browser vendors (including
+ Firefox and Opera): clicking on a frame scrollbar *should not* steal focus from content.
+ WebKit browsers based ports that do use WebCore for handling scrollbars, like QtWebKit for
+ instance, can observe the opposite behaviour.
+
+ Patch fixes this behaviour by checking if current MouseDown event targets a frame scrollbar.
+ If that is the case, it bails out and do not change focus behavior at all.
+
+ It is important to note that the given way this is implemented by this patch, non-frame
+ scrollbars (e.g. a vertical scrollbar of an overflowed textareas or divs) will keep working
+ in the same way as it works currently.
+
+ Tests: scrollbars/scrollbar-click-does-not-blur-content.html
+ scrollbars/scrollbar-iframe-click-does-not-blur-content.html
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::dispatchMouseEvent):
+
+2010-04-28 Dan Bernstein <mitz@apple.com>
+
+ Rubber-stamped by Maciej Stachowiak.
+
+ Try to fix test failures seen on the Leopard build bot after r58467
+
+ * platform/graphics/SimpleFontData.cpp:
+ (WebCore::SimpleFontData::platformGlyphInit): Initialize m_zeroWidthSpaceGlyph before
+ calling widthForGlyph(), as the latter uses the former.
+
+2010-04-28 Martin Robinson <mrobinson@webkit.org>
+
+ Reviewed by Gustavo Noronha.
+
+ [GTK] Enable DOM clipboard and drag-and-drop access
+ https://bugs.webkit.org/show_bug.cgi?id=30623
+
+ Make ClipboardGtk a "live" DataTransfer object, able to modify
+ the clipboard when setData(...) is called.
+
+ * platform/gtk/ClipboardGtk.cpp:
+ (WebCore::Editor::newGeneralClipboard): Pass the GtkClipboard into the factory method.
+ (WebCore::ClipboardGtk::ClipboardGtk): Create two separate constructors, one for DnD data and one for clipboard data.
+ (WebCore::dataObjectTypeFromHTMLClipboardType): Added.
+ (WebCore::ClipboardGtk::clearData): Clear the member DataObject, optionally write the clipboard.
+ (WebCore::ClipboardGtk::clearAllData): Ditto.
+ (WebCore::joinURIList): Added.
+ (WebCore::ClipboardGtk::getData): Get the data from the clipboard, if possible.
+ (WebCore::ClipboardGtk::setData): Write data to the DataObject and maybe the clipboard.
+ (WebCore::ClipboardGtk::types): Read the clipboard/DataObject to find applicable types.
+ (WebCore::ClipboardGtk::files): Read the clipboard/DataObject to find the files.
+ (WebCore::ClipboardGtk::writeURL): Write to the DataObject and maybe the clipboard.
+ (WebCore::ClipboardGtk::writeRange): Ditto.
+ (WebCore::ClipboardGtk::writePlainText): Ditto.
+ (WebCore::ClipboardGtk::hasData): Query the clipboard/DataObject.
+ * platform/gtk/ClipboardGtk.h:
+ (WebCore::ClipboardGtk::create): Added one factory for pasteboard-backed DataObjects and one for DnD-backed objects.
+ * platform/gtk/DataObjectGtk.cpp:
+ (WebCore::replaceNonBreakingSpaceWithSpace): Added this helper function to clean &nbsp; from plain text.
+ (WebCore::DataObjectGtk::markup): Actually return the range if it's set.
+ (WebCore::DataObjectGtk::setText): Clean &nbsp; from plain text.
+ (WebCore::DataObjectGtk::clearText): Added.
+ (WebCore::DataObjectGtk::clearMarkup): Added.
+ * platform/gtk/DataObjectGtk.h:
+ (WebCore::DataObjectGtk::clearURIList): Added.
+ (WebCore::DataObjectGtk::clearImage): Added.
+ * platform/gtk/PasteboardHelper.cpp:
+ (WebCore::PasteboardHelper::initializeTargetList): Added target ID's for URI list and Netscape URL targets.
+ (WebCore::urisToKURLVector): Added.
+ (WebCore::PasteboardHelper::getClipboardContents): Added.
+ (WebCore::PasteboardHelper::fillSelectionData): Added logic for URI lists and Netscape URLs.
+ (WebCore::PasteboardHelper::targetListForDataObject): Ditto.
+ * platform/gtk/PasteboardHelper.h: Added default argument to writeClipboardContents and new method.
+
+2010-04-28 Martin Robinson <mrobinson@webkit.org>
+
+ Reviewed by Gustavo Noronha.
+
+ [GTK] Enable DOM clipboard and drag-and-drop access
+ https://bugs.webkit.org/show_bug.cgi?id=30623
+
+ Use the length of the UTF-8 markup data in bytes when filling GtkSelectionData.
+
+ No new tests, because pasteboard DataTransfer tests will be enabled
+ with the completion of the GTK+ DataTransfer object.
+
+ * platform/gtk/PasteboardGtk.cpp:
+ (WebCore::clipboard_get_contents_cb): Use strlen here instead of g_utf8_strlen.
+
+2010-04-28 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Adele Peterson.
+
+ More of <rdar://problem/7855777> REGRESSION: Memory usage increase caused by storing glyph bounds in GlyphMetricsMap
+ https://bugs.webkit.org/show_bug.cgi?id=37936
+
+ Assigning zero width and empty bounds to the ZERO WIDTH SPACE glyph often allocates a width map
+ page and a bounds map page for the glyph, each of which pages contains 255 unused entries. Save
+ this space by not storing the zero width and empty bounds in the metrics maps.
+
+ * platform/graphics/SimpleFontData.cpp:
+ (WebCore::SimpleFontData::SimpleFontData): Initialize m_zeroWidthSpaceGlyph.
+ (WebCore::SimpleFontData::platformGlyphInit): Set m_zeroWidthSpaceGlyph. Don’t create entries
+ for the ZERO WIDTH SPACE glyph in the width map and in the bounds map.
+ * platform/graphics/SimpleFontData.h:
+ (WebCore::SimpleFontData::boundsForGlyph): Return empty bounds for the ZERO WIDTH SPACE glyph
+ without consulting the bounds map.
+ (WebCore::SimpleFontData::widthForGlyph): Return zero for the ZERO WIDTH SPACE glyph without
+ consulting the width map.
+
+2010-04-28 Mark Rowe <mrowe@apple.com>
+
+ Reviewed by Adele Peterson.
+
+ <rdar://problem/7847573> Safari welcome page logs JavaScript exception during page load
+
+ The Safari welcome page runs afoul of the same-origin restriction on access to stylesheet rules
+ that was added to address <https://bugs.webkit.org/show_bug.cgi?id=20527>. To work around this we're
+ adding a temporary site-specific quirk that relaxes this restriction for the particular cross-origin
+ access that occurs on the Safari welcome page.
+
+ * css/CSSStyleSheet.cpp:
+ (WebCore::CSSStyleSheet::cssRules):
+
+2010-04-28 Mike Thole <mthole@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ Add separate exports file for symbols dependent on WTF_USE_PROTECTION_SPACE_AUTH_CALLBACK.
+
+ * DerivedSources.make: Updated for WebCore.ProtectionSpaceAuthCallback.exp.
+ * WebCore.ProtectionSpaceAuthCallback.exp: Added.
+ * WebCore.xcodeproj/project.pbxproj:
+
+2010-04-28 Evan Martin <evan@chromium.org>
+
+ Reviewed by David Levin.
+
+ [chromium] revert getFontDataForCharacters change in r58341
+ https://bugs.webkit.org/show_bug.cgi?id=38288
+
+ It caused a performance regression.
+
+ * platform/chromium/ChromiumBridge.h:
+ * platform/graphics/chromium/FontCacheLinux.cpp:
+ (WebCore::FontCache::getFontDataForCharacters):
+
+2010-04-28 Eric Seidel <eric@webkit.org>
+
+ Unreviewed, rolling out r58441.
+ http://trac.webkit.org/changeset/58441
+ https://bugs.webkit.org/show_bug.cgi?id=37618
+
+ Broke 3 test on Qt.
+
+ * page/DragController.cpp:
+ (WebCore::DragController::tryDocumentDrag):
+ (WebCore::DragController::concludeEditDrag):
+ * page/DragController.h:
+ (WebCore::DragController::setDragInitiator):
+ (WebCore::DragController::dragInitiator):
+ (WebCore::DragController::documentUnderMouse):
+
+2010-04-28 Darin Adler <darin@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Remove some obsolete scrolling code
+ https://bugs.webkit.org/show_bug.cgi?id=38293
+
+ * page/Chrome.cpp:
+ (WebCore::Chrome::scrollRectIntoView): Removed ScrollView* argument.
+ * page/Chrome.h: Made scrollRectIntoView non-virtual, and removed ScrollView* argument.
+
+ * page/FrameView.cpp: Removed scrollRectIntoViewRecursively.
+ * page/FrameView.h: Removed scrollRectIntoViewRecursively and made
+ setScrollPosition non-virtual, since there is no class derived from
+ this class, and ScrollView's setScrollPosition is non-virtual.
+
+ * platform/HostWindow.h: Removed scrollRectIntoView.
+
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::scrollRectIntoViewRecursively): Updated comment
+ since I was able to do most of the tasks listed here.
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::scrollRectToVisible): Removed 0 passed for
+ ScrollView* argument to Chrome::scrollRectIntoView.
+
+2010-04-28 Mike Thole <mthole@apple.com>
+
+ Reviewed by David Kilzer.
+
+ Add canAuthenticateAgainstProtectionSpace() to frame loader so that a protection space
+ can be inspected before attempting to authenticate against it
+ https://bugs.webkit.org/show_bug.cgi?id=38271
+
+ * loader/EmptyClients.h:
+ (WebCore::EmptyFrameLoaderClient::canAuthenticateAgainstProtectionSpace): Added.
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::canAuthenticateAgainstProtectionSpace): Added.
+ * loader/FrameLoader.h:
+ * loader/FrameLoaderClient.h:
+ * loader/ResourceLoader.cpp:
+ (WebCore::ResourceLoader::canAuthenticateAgainstProtectionSpace): Added.
+ * loader/ResourceLoader.h:
+ (WebCore::ResourceLoader::canAuthenticateAgainstProtectionSpace): Added.
+ * platform/network/ProtectionSpace.h:
+ (WebCore::):
+ * platform/network/ResourceHandle.h:
+ * platform/network/ResourceHandleClient.h:
+ (WebCore::ResourceHandleClient::canAuthenticateAgainstProtectionSpace): Added.
+ * platform/network/mac/AuthenticationMac.mm:
+ (WebCore::mac):
+ Add cases for case ProtectionSpaceAuthenticationSchemeServerTrustEvaluationRequested and
+ ProtectionSpaceAuthenticationSchemeClientCertificateRequested. Guarded with the
+ #if USE(PROTECTION_SPACE_AUTH_CALLBACK) as the new NSURLProtectionSpace constants don't
+ exist prior to Mac OS X 10.6.
+ (WebCore::core): Ditto.
+ * platform/network/mac/ResourceHandleMac.mm:
+ (WebCore::ResourceHandle::canAuthenticateAgainstProtectionSpace): Added.
+ (-[WebCoreResourceHandleAsDelegate connection:canAuthenticateAgainstProtectionSpace:]): Added.
+
+2010-04-28 Abhishek Arya <inferno@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Convert m_documentUnderMouse, m_dragInitiator to RefPtr.
+ Eliminated unused m_dragInitiator accessor to prevent dereferencing.
+ https://bugs.webkit.org/show_bug.cgi?id=37618
+
+ Test: editing/pasteboard/drag-drop-iframe-refresh-crash.html
+
+ * page/DragController.cpp:
+ (WebCore::DragController::tryDocumentDrag):
+ (WebCore::DragController::concludeEditDrag):
+ * page/DragController.h:
+ (WebCore::DragController::draggingImageURL):
+ (WebCore::DragController::documentUnderMouse):
+
+2010-04-28 Dumitru Daniliuc <dumi@chromium.org>
+
+ Unreviewed, fixing a build problem introduced by the previous patch.
+
+ * storage/DatabaseSync.cpp:
+ (WebCore::DatabaseSync::openDatabaseSync):
+
+2010-04-23 Dumitru Daniliuc <dumi@chromium.org>
+
+ Reviewed by Jeremy Orlow.
+
+ Adding some required classes for the sync WebSQLDatabases API.
+ https://bugs.webkit.org/show_bug.cgi?id=34994
+
+ * GNUmakefile.am:
+ * WebCore.gypi:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * storage/DatabaseSync.cpp: Added.
+ (WebCore::DatabaseSync::databaseInfoTableName):
+ (WebCore::DatabaseSync::setIsAvailable):
+ (WebCore::DatabaseSync::isAvailable):
+ (WebCore::DatabaseSync::openDatabaseSync):
+ (WebCore::DatabaseSync::DatabaseSync):
+ (WebCore::DatabaseSync::~DatabaseSync):
+ (WebCore::DatabaseSync::version):
+ (WebCore::DatabaseSync::changeVersion):
+ (WebCore::DatabaseSync::transaction):
+ * storage/DatabaseSync.h: Added.
+ (WebCore::DatabaseSync::databaseDebugName):
+ * storage/SQLTransactionSync.cpp: Added.
+ (WebCore::SQLTransactionSync::create):
+ (WebCore::SQLTransactionSync::SQLTransactionSync):
+ (WebCore::SQLTransactionSync::~SQLTransactionSync):
+ (WebCore::SQLTransactionSync::executeSQL):
+ * storage/SQLTransactionSync.h: Added.
+ (WebCore::SQLTransactionSync::database):
+ (WebCore::SQLTransactionSync::isReadOnly):
+ * storage/SQLTransactionSyncCallback.h: Added.
+ (WebCore::SQLTransactionSyncCallback::~SQLTransactionSyncCallback):
+
+2010-04-28 İsmail Dönmez <ismail@namtrac.org>
+
+ Reviewed by Simon Hausmann.
+
+ Fix compilation with QT_NO_CURSOR defined.
+
+ * platform/qt/QWebPageClient.h:
+ (QWebPageClient::resetCursor):
+ (QWebPageClient::setCursor):
+
+2010-04-28 Abhishek Arya <inferno@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Added a check to make sure that resources from a different https origin are not cached.
+ https://bugs.webkit.org/show_bug.cgi?id=33456
+
+ Test: http/tests/appcache/different-https-origin-resource-main.html
+
+ * loader/appcache/ManifestParser.cpp:
+ (WebCore::parseManifest):
+
+2010-04-28 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Mark Rowe.
+
+ Only set -allowable_client WebKit2 for engineering builds on SnowLeopard
+ and later.
+
+ * Configurations/WebCore.xcconfig:
+
+2010-04-28 Darin Adler <darin@apple.com>
+
+ Reviewed by Adele Peterson.
+
+ REGRESSION: Autoscroll does not work in Mail messages
+ https://bugs.webkit.org/show_bug.cgi?id=38267
+ rdar://problem/7559799
+
+ Still haven't figured out a good way to test this with DumpRenderTree
+ or with Safari. Testing has to be done with Mail for now.
+
+ The machinery to make autoscrolling work on Mac OS X when a WebView is embedded in another
+ view had gotten broken in multiple ways. For some reason, a combination of bugs made it
+ partly work until around r48064. This brings it back.
+
+ There were three problems:
+
+ 1) Code in EventHandler decided there was nothing to scroll, so didn't start
+ the autoscroll timer.
+ 2) The wrong rectangle was passed to Chrome::scrollRectIntoView.
+ 3) The Mac WebKit implementation of ChromeClient::scrollRectIntoView did incorrect
+ coordinate conversion.
+
+ I verified that none of these have any effect on regression tests, or behavior in
+ web browsers, or behavior on platforms other than Mac.
+
+ * page/EventHandler.cpp:
+ (WebCore::canAutoscroll): Added. Returns true for boxes that can scroll directly
+ and for the top level box of the top frame.
+ (WebCore::EventHandler::handleMouseDraggedEvent): Use canAutoscroll.
+ (WebCore::EventHandler::updateAutoscrollRenderer): Ditto.
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::scrollToAnchor): Fixed comment.
+
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::scrollRectIntoViewRecursively): Put ASSERT_NOT_REACHED into this
+ now-unused function along with some comments about removing some obsolete code.
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::scrollRectToVisible): Removed call to scrollRectIntoViewRecursively
+ since from the WebKit point of view this is the topmost scroll view anyway. Instead call
+ setScrollPosition. Moved the code to call Chrome::scrollRectIntoView here since it needs
+ to use a different rectangle anyway.
+
+2010-04-21 Ojan Vafai <ojan@chromium.org>
+
+ Reviewed by Adele Peterson.
+
+ http://trac.webkit.org/changeset/57215 caused perf/memory regressions
+ https://bugs.webkit.org/show_bug.cgi?id=37292
+
+ #if out the canUseGlyphCache Changes from r57215 as they caused a
+ 8% perf regression on Chromium's international page load tests so that
+ the perf regression can be fixed properly without being left in the tree.
+
+ * platform/graphics/FontFastPath.cpp:
+ (WebCore::Font::canUseGlyphCache):
+
+2010-04-28 Beth Dakin <bdakin@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Fix for <rdar://problem/7474349>
+
+ Add a synchronous display mechanism for WKCACFLayerRenderer.
+
+ * platform/graphics/win/WKCACFLayerRenderer.cpp:
+ (WebCore::WKCACFLayerRenderer::setRootContentsAndDisplay): This is
+ just like setRootContents(), but it calls paint() instead of
+ renderSoon().
+ * platform/graphics/win/WKCACFLayerRenderer.h:
+
+2010-04-28 Dmitry Titov <dimich@chromium.org>
+
+ Reviewed by Geoffrey Garen.
+
+ REGRESSION: fast/workers/wrapper-map-gc.html crashes on Snow Leopard Release Bot
+ https://bugs.webkit.org/show_bug.cgi?id=37554
+
+ The flaky fast/workers/wrapper-map-gc.html will stop being flaky.
+
+ * bindings/js/JSEventListener.cpp:
+ (WebCore::JSEventListener::handleEvent):
+ check if JS execution was terminated, as in cases of Worker.terminate() or WorkerGlobalScope.close().
+ * bindings/js/JSWorkerContextBase.cpp:
+ (WebCore::toJS): ASSERT the value of workerContextWrapper, it should never be 0.
+ * bindings/js/WorkerScriptController.h:
+ (WebCore::WorkerScriptController::workerContextWrapper): remove returning 0 if JS execution was forbidden.
+ (WebCore::WorkerScriptController::isExecutionForbidden):
+ * bindings/v8/WorkerScriptController.h:
+ (WebCore::WorkerScriptController::isExecutionForbidden):
+
+ Add ScriptExecutionContext::isJSExecutionTerminated(), it is always 'false' for Document
+ and 'true' for WorkerContext when script is terminated.
+ * dom/ScriptExecutionContext.h:
+ * dom/Document.h:
+ (WebCore::Document::isJSExecutionTerminated):
+ * workers/WorkerContext.cpp:
+ (WebCore::WorkerContext::isJSExecutionTerminated):
+ * workers/WorkerContext.h:
+
+2010-04-28 Ilya Tikhonovsky <loislo@chromium.org>
+
+ Reviewed by Yury Semikhatsky.
+
+ WebInspector: Multiple Main Resource Content Loaded marks appear in Resource panel.
+ https://bugs.webkit.org/show_bug.cgi?id=38270
+
+ * inspector/front-end/ResourcesPanel.js:
+ (WebInspector.ResourcesPanel.prototype.updateGraphDividersIfNeeded):
+
+2010-04-28 Ilya Tikhonovsky <loislo@chromium.org>
+
+ Reviewed by Yury Semikhatsky.
+
+ WebInspector: Timeline: We can have precise urls in the EvaluateScript records.
+ https://bugs.webkit.org/show_bug.cgi?id=38264
+
+ * inspector/front-end/TimelinePanel.js:
+ (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
+ (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
+
+2010-04-28 Pavel Feldman <pfeldman@chromium.org>
+
+ Reviewed by Timothy Hatcher.
+
+ Web Inspector: Linkify node and function in the event listeners panel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=38251
+
+ * bindings/js/ScriptEventListener.cpp:
+ (WebCore::eventListenerHandlerBody):
+ (WebCore::eventListenerHandlerLocation):
+ * bindings/js/ScriptEventListener.h:
+ * bindings/v8/ScriptEventListener.cpp:
+ (WebCore::eventListenerHandlerBody):
+ (WebCore::eventListenerHandlerLocation):
+ * bindings/v8/ScriptEventListener.h:
+ * inspector/InspectorDOMAgent.cpp:
+ (WebCore::InspectorDOMAgent::buildObjectForEventListener):
+ * inspector/front-end/ElementsPanel.js:
+ (WebInspector.ElementsPanel.prototype.linkifyNodeReference):
+ (WebInspector.ElementsPanel.prototype.linkifyNodeReference.preventDefault):
+ * inspector/front-end/EventListenersSidebarPane.js:
+ (WebInspector.EventListenersSidebarPane.prototype.update.callback):
+ (WebInspector.EventListenersSidebarPane.prototype.update):
+ ():
+ * inspector/front-end/StylesSidebarPane.js:
+ (WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
+ * inspector/front-end/inspector.css:
+ (.node-link):
+
+2010-04-28 Julien Chaffraix <jchaffraix@webkit.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ [XHR] Cross-Origin synchronous request with credential raises NETWORK_ERR
+ https://bugs.webkit.org/show_bug.cgi?id=37781
+ <rdar://problem/7905150>
+
+ Tests: http/tests/xmlhttprequest/access-control-preflight-credential-async.html
+ http/tests/xmlhttprequest/access-control-preflight-credential-sync.html
+
+ Rolling the patch in as I could not reproduce Qt results locally.
+
+ * loader/DocumentThreadableLoader.cpp:
+ (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Now we remove the
+ credential from the request here to avoid forgetting to do so in the different code path.
+ (WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest): Just add the
+ "Origin" header.
+ (WebCore::DocumentThreadableLoader::loadRequest): Check here the the credential have
+ been removed so that we don't leak them. Also tweaked a comment to make it clear that
+ the URL check has issue when credential is involved.
+
+2010-04-28 Noam Rosenthal <noam.rosenthal@nokia.com>
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ [Qt] GraphicsLayer: preserves-3d and backface visibility
+ https://bugs.webkit.org/show_bug.cgi?id=35312
+
+ Implement preserves-3d by maintaining the 3D transformation heirarchy inside GraphicsLayerQt, and extrapolating
+ the relative QTransform. When the extrapolation fails (un-invertible matrix) we ignore the transformation change.
+
+ WebKitSite/blog-files/3d-transforms test now work with Qt.
+
+ * platform/graphics/qt/GraphicsLayerQt.cpp:
+ (WebCore::GraphicsLayerQtImpl::updateTransform):
+ (WebCore::GraphicsLayerQtImpl::opaqueArea):
+ (WebCore::GraphicsLayerQtImpl::boundingRect):
+ (WebCore::GraphicsLayerQtImpl::paint):
+ (WebCore::GraphicsLayerQtImpl::flushChanges):
+
+2010-04-28 Ilya Tikhonovsky <loislo@chromium.org>
+
+ Reviewed by Yury Semikhatsky.
+
+ Web Inspector: View frame selector for Timeline overview panel is redesigned a bit.
+ Now it is possible to adjust view frame by resizer bars and by click-n-drag in overview pane.
+ https://bugs.webkit.org/show_bug.cgi?id=38251
+
+ * inspector/front-end/TimelineOverviewPane.js:
+ (WebInspector.TimelineOverviewPane):
+ (WebInspector.TimelineOverviewPane.prototype.reset):
+ (WebInspector.TimelineOverviewPane.prototype._dragWindow):
+ (WebInspector.TimelineOverviewPane.prototype._windowSelectorDragging):
+ (WebInspector.TimelineOverviewPane.prototype._endWindowSelectorDragging):
+ (WebInspector.TimelineOverviewPane.prototype._resizeWindowLeft):
+ (WebInspector.TimelineOverviewPane.prototype._resizeWindowRight):
+ (WebInspector.TimelineOverviewPane.prototype._setWindowPosition):
+ (WebInspector.TimelinePanel.WindowSelector):
+ (WebInspector.TimelinePanel.WindowSelector.prototype._createSelectorElement):
+ (WebInspector.TimelinePanel.WindowSelector.prototype._close):
+ (WebInspector.TimelinePanel.WindowSelector.prototype._updatePosition):
+ * inspector/front-end/inspector.css:
+ (#timeline-overview-grid):
+ (.timeline-window-selector):
+ (#timeline-overview-window):
+ (.timeline-overview-dividers-background):
+ (.timeline-overview-window-rulers):
+ (.timeline-window-resizer):
+
+2010-04-28 Marcus Bulach <bulach@chromium.org>
+
+ Reviewed by Jeremy Orlow.
+
+ Reverts 58340 (https://bugs.webkit.org/show_bug.cgi?id=38158) due to regression on fast/text/international/khmer-selection.html
+ https://bugs.webkit.org/show_bug.cgi?id=38254
+
+ * platform/graphics/chromium/FontLinux.cpp:
+ (WebCore::adjustTextRenderMode):
+ (WebCore::TextRunWalker::getTextRun):
+ (WebCore::TextRunWalker::getNormalizedTextRun):
+ (WebCore::TextRunWalker::setGlyphXPositions):
+ (WebCore::glyphIndexForXPositionInScriptRun):
+ (WebCore::Font::offsetForPositionForComplexText):
+ (WebCore::Font::selectionRectForComplexText):
+ * platform/graphics/chromium/FontPlatformDataLinux.cpp:
+ (WebCore::FontPlatformData::setupPaint):
+ * platform/graphics/chromium/HarfbuzzSkia.cpp:
+ (WebCore::getOutlinePoint):
+ * platform/graphics/skia/GraphicsContext3DSkia.cpp:
+ (WebCore::GraphicsContext3D::getImageData):
+ * platform/graphics/skia/GraphicsContextSkia.cpp:
+ (WebCore::isCoordinateSkiaSafe):
+ (WebCore::GraphicsContext::fillRect):
+ (WebCore::GraphicsContext::strokePath):
+ (WebCore::GraphicsContext::strokeRect):
+
+2010-04-28 Andrey Kosyakov <caseq@chromium.org>
+
+ Reviewed by Yury Semikhatsky.
+
+ Log error message to inspector console if a resource fails to load.
+ Disable checking of mime-type consistency for failed resources.
+ https://bugs.webkit.org/show_bug.cgi?id=37215
+
+ Test: http/tests/inspector/console-resource-errors.html
+
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::didReceiveResponse):
+ (WebCore::InspectorController::didFailLoading):
+ * inspector/front-end/Resource.js:
+ (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
+ * inspector/front-end/ResourcesPanel.js:
+ (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
+
+2010-04-28 Yury Semikhatsky <yurys@chromium.org>
+
+ Reviewed by Pavel Feldman.
+
+ Support pause on exceptions in v8 implementation of ScriptDebugServer.
+
+ https://bugs.webkit.org/show_bug.cgi?id=38205
+
+ * bindings/v8/ScriptDebugServer.cpp:
+ (WebCore::ScriptDebugServer::addListener):
+ (WebCore::ScriptDebugServer::pauseOnExceptionsState):
+ (WebCore::ScriptDebugServer::setPauseOnExceptionsState):
+ (WebCore::ScriptDebugServer::currentCallFrame):
+ (WebCore::ScriptDebugServer::handleV8DebugMessage):
+ (WebCore::ScriptDebugServer::dispatchDidParseSource):
+ * bindings/v8/ScriptDebugServer.h:
+
+2010-04-28 Sheriff Bot <webkit.review.bot@gmail.com>
+
+ Unreviewed, rolling out r58313.
+ http://trac.webkit.org/changeset/58313
+ https://bugs.webkit.org/show_bug.cgi?id=38253
+
+ Regression evident in pixel tests: the search icon is always
+ clipped at the bottom. (Requested by jorlow on #webkit).
+
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::controlClipRect):
+ * rendering/RenderTextControl.h:
+ (WebCore::RenderTextControl::hasControlClip):
+ * rendering/RenderTextControlSingleLine.cpp:
+ (WebCore::RenderTextControlSingleLine::paint):
+ * rendering/RenderTextControlSingleLine.h:
+
+2010-04-28 Justin McPherson <justin.mcpherson@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] Fix detection of Qt 4.7's multimedia libraries
+
+ QtMultimedia has been split into an additional media services library, which
+ we're using. mediaservices depends on multimedia.
+
+ * WebCore.pro:
+
+2010-04-28 Shinichiro Hamaji <hamaji@chromium.org>
+
+ Unreviewed attempt to fix the chromium build.
+
+ Add layoutTestController.setPrinting()
+ https://bugs.webkit.org/show_bug.cgi?id=37203
+
+ * rendering/RenderTreeAsText.cpp:
+
+2010-04-27 Shinichiro Hamaji <hamaji@chromium.org>
+
+ Reviewed by Darin Adler and Eric Seidel.
+
+ Add layoutTestController.setPrinting()
+ https://bugs.webkit.org/show_bug.cgi?id=37203
+
+ Added RenderAsTextPrintingMode as a behavior of externalRepresentation.
+
+ Now ~PrintContext() calls end() automatically.
+
+ * page/PrintContext.cpp:
+ (WebCore::PrintContext::~PrintContext):
+ * rendering/RenderTreeAsText.cpp:
+ (WebCore::externalRepresentation):
+ * rendering/RenderTreeAsText.h:
+ (WebCore::):
+
+2010-04-27 Yuzo Fujishima <yuzo@google.com>
+
+ Reviewed by Eric Seidel.
+
+ Enhance CSS parser for Paged Media (Iteration 4)
+ Implement page property parsing as specified at http://dev.w3.org/csswg/css3-page/#using-named-pages.
+ https://bugs.webkit.org/show_bug.cgi?id=35853
+
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::parseValue):
+ (WebCore::CSSParser::parsePage):
+ * css/CSSParser.h:
+
+2010-04-27 Yuzo Fujishima <yuzo@google.com>
+
+ Reviewed by Dimitri Glazkov.
+
+ Enhance CSS parser for Paged Media (Iteration 3)
+ Implement size parameter parsing for Paged Media.
+ https://bugs.webkit.org/show_bug.cgi?id=35851
+
+ I believe size property hasn't been used so far because (1) it hasn't been properly parsed and
+ (2) a comment in CSSComputedStyleDeclaration::getPropertyCSSValue says so.
+ Changing the way of parsing it should not cause any regressions -- no existing tests fail because of this change.
+
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::parseValue):
+ (WebCore::CSSParser::parseSize):
+ (WebCore::CSSParser::parseSizeParameter):
+ * css/CSSParser.h:
+ (WebCore::CSSParser::):
+ * css/CSSValueKeywords.in:
+
+2010-04-27 Yuzo Fujishima <yuzo@google.com>
+
+ Reviewed by Eric Seidel.
+
+ Enhance CSS parser for Paged Media (Iteration 2)
+ Parse and hold paged media rules in CSSStyleSelector.
+
+ https://bugs.webkit.org/show_bug.cgi?id=35782
+
+ Test: printing/page-rule-css-text.html
+
+ * css/CSSGrammar.y:
+ * css/CSSPageRule.cpp:
+ (WebCore::CSSPageRule::CSSPageRule):
+ (WebCore::CSSPageRule::selectorText):
+ * css/CSSPageRule.h:
+ (WebCore::CSSPageRule::create):
+ (WebCore::CSSPageRule::isPageRule):
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::createPageRule):
+ * css/CSSStyleRule.h:
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSRuleSet::getPageRules):
+ (WebCore::CSSRuleSet::CSSRuleSet):
+ (WebCore::CSSRuleSet::~CSSRuleSet):
+ (WebCore::CSSRuleSet::addPageRule):
+ (WebCore::CSSRuleSet::addRulesFromSheet):
+ * css/CSSStyleSelector.h:
+ * css/StyleBase.h:
+ (WebCore::StyleBase::isPageRule):
+
+2010-04-27 Daniel Bates <dbates@rim.com>
+
+ Reviewed by Oliver Hunt.
+
+ https://bugs.webkit.org/show_bug.cgi?id=37686
+
+ Fixes an issue where the canvas method strokeRect will stroke a
+ rectangle whose dimensions are 0 when lineWidth > 1.
+
+ As per the definition of strokeRect in the HTML Canvas 2D Context
+ spec. <http://www.w3.org/TR/2dcontext/#dom-context-2d-strokerect>,
+ this method should have no effect when both the height and width
+ are zero.
+
+ Tests: fast/canvas/canvas-clearRect.html
+ fast/canvas/canvas-fillRect.html
+
+ * html/canvas/CanvasRenderingContext2D.cpp:
+ (WebCore::validateRectForCanvas): Return false if height, width == 0.
+
+2010-04-27 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ Remove obsolete custom bindings file
+ https://bugs.webkit.org/show_bug.cgi?id=38223
+
+ We don't need these files anymore because they are empty.
+
+ * Android.jscbindings.mk:
+ * GNUmakefile.am:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * bindings/js/JSAbstractWorkerCustom.cpp: Removed.
+ * bindings/js/JSBindingsAllInOne.cpp:
+ * bindings/js/JSDocumentFragmentCustom.cpp: Removed.
+ * bindings/js/JSEventSourceCustom.cpp: Removed.
+
+2010-04-27 Daniel Cheng <dcheng@chromium.org>
+
+ Reviewed by Jian Li.
+
+ [Chromium] Filter out URLs with a file scheme from text/uri-list when dragging.
+ https://bugs.webkit.org/show_bug.cgi?id=38227
+
+ Unfortunately, the simple fix of not populating the drag data with file URLs doesn't work
+ since the default drop handling uses the drag data URL to navigate to dropped files/URLs.
+ For now, we hack around the problem in the Chromium platform, but the proper long term
+ solution is to change DragController::performDrag to check dragData::asFilenames().
+
+ No new tests.
+
+ * platform/chromium/ClipboardChromium.cpp:
+ (WebCore::ClipboardChromium::getData):
+ (WebCore::ClipboardChromium::types):
+
+2010-04-27 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by the inimitable Dan Bernstein.
+
+ SVG as background image renders incorrectly after zooming
+ https://bugs.webkit.org/show_bug.cgi?id=38215
+
+ When doing a partial redraw of an SVGImage used as a CSS background
+ image, we're limited to drawing the entire Frame, clipped to the dirty rect.
+ Because of this, we need to fix up the CTM so that the origin is at the
+ top left of the unclipped image, rather than the top left of the
+ portion being redrawn.
+
+ Test: fast/images/svg-background-partial-redraw.html
+
+ * svg/graphics/SVGImage.cpp:
+ (WebCore::SVGImage::draw):
+
+2010-04-27 Yuzo Fujishima <yuzo@google.com>
+
+ Reviewed by David Hyatt.
+
+ Retry of: Enhance CSS parser for Paged Media (Iteration 1)
+
+ In this change, the grammar is extended and skeletal methods for creating page rules and margin at-rules are defined.
+ The contents of the methods should be implemented by other changes.
+
+ https://bugs.webkit.org/show_bug.cgi?id=35329
+
+ Test: fast/css/parsing-page-rule.html
+
+ * css/CSSGrammar.y:
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::CSSParser):
+ (WebCore::CSSParser::clearProperties):
+ (WebCore::CSSParser::createPageRule):
+ (WebCore::CSSParser::createMarginAtRule):
+ (WebCore::CSSParser::startDeclarationsForMarginBox):
+ (WebCore::CSSParser::endDeclarationsForMarginBox):
+ * css/CSSParser.h:
+ * css/CSSSelector.cpp:
+ (WebCore::CSSSelector::pseudoId):
+ (WebCore::nameToPseudoTypeMap):
+ (WebCore::CSSSelector::extractPseudoType):
+ * css/CSSSelector.h:
+ (WebCore::CSSSelector::):
+ * css/tokenizer.flex:
+
+2010-04-27 Julien Chaffraix <jchaffraix@webkit.org>
+
+ Unreviewed, rolling out my changes as it rendered the Qt bot unreliable.
+
+ * loader/DocumentThreadableLoader.cpp:
+ (WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
+ (WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest):
+ (WebCore::DocumentThreadableLoader::loadRequest):
+
+2010-04-27 Julien Chaffraix <jchaffraix@webkit.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ [XHR] Cross-Origin synchronous request with credential raises NETWORK_ERR
+ https://bugs.webkit.org/show_bug.cgi?id=37781
+ <rdar://problem/7905150>
+
+ Tests: http/tests/xmlhttprequest/access-control-preflight-credential-async.html
+ http/tests/xmlhttprequest/access-control-preflight-credential-sync.html
+
+ * loader/DocumentThreadableLoader.cpp:
+ (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Now we remove the
+ credential from the request here to avoid forgetting to do so in the different code path.
+ (WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest): Just add the
+ "Origin" header.
+ (WebCore::DocumentThreadableLoader::loadRequest): Check here the the credential have
+ been removed so that we don't leak them. Also tweaked a comment to make it clear that
+ the URL check has issue when credential is involved.
+
+2010-04-27 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=38238
+ Allow both WebKit and WebKit2 to link to the same WebCore.framework
+
+ * Configurations/WebCore.xcconfig: Use -allowable_client WebKit2 to add
+ WebKit2 to the list of frameworks that can link directly to WebCore. It
+ is not necessary for it to be an umbrella since we don't need to reexport
+ any symbols.
+
+2010-04-27 Dumitru Daniliuc <dumi@chromium.org>
+
+ Reviewed by David Levin.
+
+ Turn on AUTO_VACUUM = INCREMENTAL for all HTML5 databases.
+ https://bugs.webkit.org/show_bug.cgi?id=38191
+
+ Vacuum all databases when the number of free pages is at least 10%
+ of the number of total pages. Also, add a guard against a bug that
+ was fixed in SQLite only starting with version 3.6.16.
+
+ * platform/sql/SQLiteDatabase.cpp:
+ (WebCore::SQLiteDatabase::maximumSize):
+ (WebCore::SQLiteDatabase::freeSpaceSize):
+ (WebCore::SQLiteDatabase::totalSize):
+ (WebCore::SQLiteDatabase::runIncrementalVacuumCommand):
+ (WebCore::SQLiteDatabase::turnOnIncrementalAutoVacuum):
+ * platform/sql/SQLiteDatabase.h:
+ (WebCore::SQLiteDatabase::):
+ * platform/sql/SQLiteStatement.cpp:
+ (WebCore::SQLiteStatement::prepare):
+ (WebCore::SQLiteStatement::step):
+ * storage/Database.cpp:
+ (WebCore::Database::performOpenAndVerify):
+ (WebCore::Database::incrementalVacuumIfNeeded):
+ * storage/Database.h:
+ * storage/SQLTransaction.cpp:
+ (WebCore::SQLTransaction::postflightAndCommit):
+
+2010-04-27 Garret Kelly <gdk@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ Turn all of the touch event handlers into RuntimeEnabledFeatures, and
+ modify the createEvent methond on Document so that it won't create a
+ TouchEvent if the feature is disabled.
+ https://bugs.webkit.org/show_bug.cgi?id=37485
+
+ * bindings/generic/RuntimeEnabledFeatures.cpp:
+ * bindings/generic/RuntimeEnabledFeatures.h:
+ (WebCore::RuntimeEnabledFeatures::touchEnabled):
+ (WebCore::RuntimeEnabledFeatures::setTouchEnabled):
+ (WebCore::RuntimeEnabledFeatures::ontouchstartEnabled):
+ (WebCore::RuntimeEnabledFeatures::ontouchmoveEnabled):
+ (WebCore::RuntimeEnabledFeatures::ontouchendEnabled):
+ (WebCore::RuntimeEnabledFeatures::ontouchcancelEnabled):
+ * dom/Document.cpp:
+ (WebCore::Document::createEvent):
+ * dom/Document.idl:
+ * dom/Element.idl:
+ * page/DOMWindow.idl:
+
+2010-04-27 Jens Alfke <snej@chromium.org>
+
+ Reviewed by Darin Fisher.
+
+ [Chromium] Add some notifications and an accessor to WebKit API
+ https://bugs.webkit.org/show_bug.cgi?id=37625
+
+ * dom/Node.cpp:
+ (WebCore::Node::hasNonEmptyBoundingBox): New method.
+ * dom/Node.h:
+ * html/HTMLAnchorElement.cpp:
+ (WebCore::HTMLAnchorElement::isKeyboardFocusable): Moved part of method into new Node method
+
+2010-04-27 Jochen Eisinger <jochen@chromium.org>
+
+ Reviewed by Shinichiro Hamaji.
+
+ Fix gyp build on Mac OS X with enable_svg=0.
+ https://bugs.webkit.org/show_bug.cgi?id=38192
+
+ * WebCore.gyp/WebCore.gyp: Only generate SVG symbols if enable_svg!=0.
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Add missing unimplemented CSS properties to switch statement.
+
+2010-04-27 Kinuko Yasuda <kinuko@chromium.org>
+
+ Reviewed by Jian Li.
+
+ [V8] Handle OR ('|') conditional in action_derivedsourcesallinone.py
+ https://bugs.webkit.org/show_bug.cgi?id=38207
+
+ No new tests.
+
+ * WebCore.gyp/scripts/action_derivedsourcesallinone.py:
+
+2010-04-27 François Sausset <sausset@gmail.com>
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Implementation of the MathML mroot & msqrt elements.
+ https://bugs.webkit.org/show_bug.cgi?id=37044
+
+ Test: mathml/presentation/roots.xhtml
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * css/mathml.css:
+ (mroot):
+ (mroot > * + *):
+ (mroot > * + mrow, mroot > * + mfenced):
+ * mathml/MathMLInlineContainerElement.cpp:
+ (WebCore::MathMLInlineContainerElement::createRenderer):
+ * mathml/RenderMathMLRoot.cpp: Added.
+ (WebCore::RenderMathMLRoot::RenderMathMLRoot):
+ (WebCore::RenderMathMLRoot::addChild):
+ (WebCore::RenderMathMLRoot::paint):
+ (WebCore::RenderMathMLRoot::layout):
+ * mathml/RenderMathMLRoot.h: Added.
+ * mathml/RenderMathMLSquareRoot.cpp: Added.
+ (WebCore::RenderMathMLSquareRoot::RenderMathMLSquareRoot):
+ (WebCore::RenderMathMLSquareRoot::paint):
+ (WebCore::RenderMathMLSquareRoot::layout):
+ * mathml/RenderMathMLSquareRoot.h: Added.
+
+2010-04-27 Darin Adler <darin@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ I noticed an unused forwarding header.
+
+ * ForwardingHeaders/runtime/PropertyMap.h: Removed.
+
+2010-04-27 James Robinson <jamesr@chromium.org>
+
+ Reviewed by Adam Barth.
+
+ Fix gcc 4.4.1 warnings on Linux in the chromium V8 bindings code.
+ https://bugs.webkit.org/show_bug.cgi?id=38153
+
+ * bindings/scripts/CodeGeneratorV8.pm:
+ * bindings/v8/V8Proxy.cpp:
+ (WebCore::V8Proxy::callFunction):
+
+2010-04-27 Eric Seidel <eric@webkit.org>
+
+ Unreviewed, rolling out r58318.
+ http://trac.webkit.org/changeset/58318
+ https://bugs.webkit.org/show_bug.cgi?id=37215
+
+ Broke test on Tiger. Might just need updated results,
+ unclear.
+
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::didReceiveResponse):
+ (WebCore::InspectorController::didFailLoading):
+ * inspector/front-end/Resource.js:
+ (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
+ * inspector/front-end/ResourcesPanel.js:
+ (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
+
+2010-04-27 Evan Martin <evan@chromium.org>
+
+ Reviewed by David Levin.
+
+ [chromium] bold bengali text not rendered properly on Linux
+ https://bugs.webkit.org/show_bug.cgi?id=37904
+
+ We must let Skia do font fallback, rather than picking a font name
+ then handing that to Skia. For example, if we have Bengali text and
+ choose FreeSans + fake bold, and then later reuse the name, Skia will
+ helpfully use FreeSansBold (which doesn't cover Bengali).
+
+ Test: fast/text/international/bold-bengali.html
+
+ * platform/graphics/chromium/FontCacheLinux.cpp:
+ (WebCore::FontCache::getFontDataForCharacters):
+
+2010-04-27 James Robinson <jamesr@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ Fix warnings emitted by gcc 4.4.1 on linux in chromium-specific platform graphics files.
+ https://bugs.webkit.org/show_bug.cgi?id=38158
+
+ Most of the issues are signed/unsigned mismatches, but there are a few unusued variables
+ and functions mixed in.
+
+ * platform/graphics/chromium/FontLinux.cpp:
+ (WebCore::adjustTextRenderMode):
+ (WebCore::TextRunWalker::getTextRun):
+ (WebCore::TextRunWalker::getNormalizedTextRun):
+ (WebCore::TextRunWalker::setGlyphXPositions):
+ (WebCore::glyphIndexForXPositionInScriptRun):
+ (WebCore::Font::offsetForPositionForComplexText):
+ (WebCore::Font::selectionRectForComplexText):
+ * platform/graphics/chromium/FontPlatformDataLinux.cpp:
+ (WebCore::FontPlatformData::setupPaint):
+ * platform/graphics/chromium/HarfbuzzSkia.cpp:
+ (WebCore::getOutlinePoint):
+ * platform/graphics/skia/GraphicsContext3DSkia.cpp:
+ (WebCore::GraphicsContext3D::getImageData):
+ * platform/graphics/skia/GraphicsContextSkia.cpp:
+ (WebCore::isCoordinateSkiaSafe):
+ (WebCore::GraphicsContext::fillRect):
+ (WebCore::GraphicsContext::strokePath):
+ (WebCore::GraphicsContext::strokeRect):
+
+2010-04-27 Jian Li <jianli@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ Sending a package file using FormData crashes WebKit on Mac.
+ https://bugs.webkit.org/show_bug.cgi?id=37882
+
+ Can't add a layout test because DRT does not support generating the file name.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::submitForm):
+ (WebCore::FrameLoader::navigateToDifferentDocument):
+ * platform/network/FormData.cpp:
+ (WebCore::FormData::appendDOMFormData):
+ * platform/network/FormData.h:
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::send):
+
+2010-04-27 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ Remove custom NodeIterator bindings
+ https://bugs.webkit.org/show_bug.cgi?id=38188
+
+ Another example of CallWith=ScriptState. This case shows us the right
+ way to handle the interaction with exception codes.
+
+ In my previous patch, I put the exception code handling after the
+ ScriptState exception handling. It turns out this was a mistake
+ (although a harmless one at the time because no IDL caused us to
+ generate that code). Now that we're generating both kinds of exception
+ handling, we need to generate them in the right order.
+
+ * WebCore.gypi:
+ * bindings/js/JSNodeIteratorCustom.cpp:
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * bindings/scripts/CodeGeneratorV8.pm:
+ * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
+ (webkit_dom_test_obj_with_script_state_void_exception):
+ (webkit_dom_test_obj_with_script_state_obj_exception):
+ * bindings/scripts/test/GObject/WebKitDOMTestObj.h:
+ * bindings/scripts/test/JS/JSTestObj.cpp:
+ (WebCore::):
+ (WebCore::jsTestObjPrototypeFunctionWithScriptStateVoidException):
+ (WebCore::jsTestObjPrototypeFunctionWithScriptStateObjException):
+ * bindings/scripts/test/JS/JSTestObj.h:
+ * bindings/scripts/test/ObjC/DOMTestObj.h:
+ * bindings/scripts/test/ObjC/DOMTestObj.mm:
+ (-[DOMTestObj withScriptStateVoidException]):
+ (-[DOMTestObj withScriptStateObjException]):
+ * bindings/scripts/test/TestObj.idl:
+ * bindings/scripts/test/V8/V8TestObj.cpp:
+ (WebCore::TestObjInternal::withScriptStateVoidCallback):
+ (WebCore::TestObjInternal::withScriptStateObjCallback):
+ (WebCore::TestObjInternal::withScriptStateVoidExceptionCallback):
+ (WebCore::TestObjInternal::withScriptStateObjExceptionCallback):
+ (WebCore::):
+ * bindings/v8/custom/V8NodeIteratorCustom.cpp: Removed.
+ * dom/NodeIterator.idl:
+
+2010-04-27 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Darin Adler.
+
+ Remove copy/paste addEventListener "custom" bindings via code generation
+ https://bugs.webkit.org/show_bug.cgi?id=38210
+
+ It's somewhat lame to special case addEventListener and
+ removeEventListener in the code generator, but it saves a large amount
+ of boilerplate "custom" bindings code.
+
+ Idea shamelessly stolen from the V8 code generator.
+
+ This patch points to some good refactoring opportunities in
+ CodeGeneratorJS.pm, but I'm going to hold off on those for a future
+ patch. By generating test coverage for the code generator, we make
+ these future refactorings easier.
+
+ * bindings/js/JSAbstractWorkerCustom.cpp:
+ * bindings/js/JSDOMApplicationCacheCustom.cpp:
+ * bindings/js/JSDesktopNotificationsCustom.cpp:
+ * bindings/js/JSEventSourceCustom.cpp:
+ * bindings/js/JSMessagePortCustom.cpp:
+ * bindings/js/JSNodeCustom.cpp:
+ * bindings/js/JSSVGElementInstanceCustom.cpp:
+ * bindings/js/JSWebSocketCustom.cpp:
+ * bindings/js/JSWorkerContextCustom.cpp:
+ * bindings/js/JSXMLHttpRequestCustom.cpp:
+ * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
+ * bindings/scripts/test/GObject/WebKitDOMTestObj.h:
+ * bindings/scripts/test/JS/JSTestObj.cpp:
+ (WebCore::):
+ (WebCore::jsTestObjPrototypeFunctionAddEventListener):
+ (WebCore::jsTestObjPrototypeFunctionRemoveEventListener):
+ * bindings/scripts/test/JS/JSTestObj.h:
+ * bindings/scripts/test/ObjC/DOMTestObj.h:
+ * bindings/scripts/test/ObjC/DOMTestObj.mm:
+ (-[DOMTestObj addEventListener:listener:useCapture:]):
+ (-[DOMTestObj removeEventListener:listener:useCapture:]):
+ * bindings/scripts/test/TestObj.idl:
+ * bindings/scripts/test/V8/V8TestObj.cpp:
+ (WebCore::TestObjInternal::addEventListenerCallback):
+ (WebCore::TestObjInternal::removeEventListenerCallback):
+ (WebCore::):
+ * dom/MessagePort.idl:
+ * dom/Node.idl:
+ * loader/appcache/DOMApplicationCache.idl:
+ * notifications/Notification.idl:
+ * page/EventSource.idl:
+ * svg/SVGElementInstance.idl:
+ * websockets/WebSocket.idl:
+ * workers/AbstractWorker.idl:
+ * workers/WorkerContext.idl:
+ * xml/XMLHttpRequest.idl:
+ * xml/XMLHttpRequestUpload.idl:
+
+2010-04-27 Sam Weinig <sam@webkit.org>
+
+ Rubber-stamped by Beth Dakin.
+
+ Remove now unnecessary EXPERIMENTAL_SINGLE_VIEW_MODE #define.
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::EventHandler):
+ (WebCore::EventHandler::clearDragState):
+ * page/EventHandler.h:
+ * page/mac/DragControllerMac.mm:
+ * page/mac/EventHandlerMac.mm:
+ * platform/mac/PopupMenuMac.mm:
+
+2010-04-27 Ben Murdoch <benm@google.com>
+
+ Reviewed by Simon Hausmann.
+
+ The TouchStationary state of WebCore::PlatformTouchPoint is not handled inside the touch event handler.
+ https://bugs.webkit.org/show_bug.cgi?id=37609
+
+ No new tests required, only updating documentation.
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::handleTouchEvent): Improve the documentation for handling
+ the TouchStationary state as a result of discussions in bug 37609.
+
+2010-04-27 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Darin Adler, Maciej Stachowiak.
+
+ REGRESSION (r57919): Some pages opened in background tabs don't render the first time you activate their tab
+ https://bugs.webkit.org/show_bug.cgi?id=38183
+
+ Rather than sprinkle PLATFORM #ifdefs around, add a new method,
+ RenderLayerCompositor::shouldPropagateCompositingToIFrameParent(), that indicates whether
+ an iframe with composited content should trigger compositing mode in the enclosing document
+ (a behavior that differs between platforms).
+
+ Use this new method to determine whether to trigger a style recalc in the parent document
+ when an iframe becomes composited.
+
+ Move the code formerly in RenderView::compositingStateChanged() into RenderLayerCompositor().
+
+ * manual-tests/compositing/accel-comp-iframe-tab-repaint.html: Added.
+ * manual-tests/compositing/resources/flash-frame.html: Added.
+ * manual-tests/compositing/resources/tab-repaint-part-2.html: Added.
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::enableCompositingMode):
+ (WebCore::RenderLayerCompositor::shouldPropagateCompositingToIFrameParent):
+ (WebCore::RenderLayerCompositor::requiresCompositingForIFrame):
+ * rendering/RenderLayerCompositor.h:
+ * rendering/RenderView.cpp:
+ * rendering/RenderView.h:
+
+2010-04-27 Andrey Kosyakov <caseq@chromium.org>
+
+ Reviewed by Yury Semikhatsky.
+
+ Log error message to inspector console if a resource fails to load.
+ Disable checking of mime-type consistency for failed resources.
+ https://bugs.webkit.org/show_bug.cgi?id=37215
+
+ Test: http/tests/inspector/console-resource-errors.html
+
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::didReceiveResponse):
+ (WebCore::InspectorController::didFailLoading):
+ * inspector/front-end/Resource.js:
+ (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
+ * inspector/front-end/ResourcesPanel.js:
+ (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
+
+2010-04-27 Vitaly Repeshko <vitalyr@chromium.org>
+
+ Reviewed by Nate Chapin.
+
+ [V8] Fix XHR memory leak in GC controller.
+ https://bugs.webkit.org/show_bug.cgi?id=38202
+
+ http://trac.webkit.org/changeset/55798 simplified processing of
+ active DOM objects but introduced a subtle bug in garbage
+ collection of XHRs. ActiveDOMObject is not a direct base class of
+ XHR and so upcasting changes pointer identity and breaks DOM
+ maps. This leads to forever live persistent handles to XHR that
+ had pending activity while V8 GC happened.
+
+ * bindings/v8/V8GCController.cpp:
+ (WebCore::GCEpilogueVisitor::visitDOMWrapper):
+
+2010-04-27 Adam Barth <abarth@webkit.org>
+
+ Unreviewed. Regenerate reference bindings code generator output.
+
+ * bindings/scripts/test/V8/V8TestObj.cpp:
+ (WebCore::TestObjInternal::withScriptStateVoidCallback):
+ (WebCore::TestObjInternal::withScriptStateObjCallback):
+
+2010-04-27 Joseph Pecoraro <joepeck@webkit.org>
+
+ Reviewed by Dan Bernstein.
+
+ <input type="search"> with uneven padding causes text clipping
+ https://bugs.webkit.org/show_bug.cgi?id=38160
+
+ Test: fast/css/input-search-padding.html
+
+ An <input type="search"> contains an inner block, which is explicitly
+ centered in RenderTextControlSingleLine based on the height of the element.
+ However, the clipping rect was not using the set location, and instead
+ calculated off of the top border and padding alone. This also vertically
+ centers the Caps Lock indicator.
+
+ * rendering/RenderTextControl.cpp: moved controlClipRect implementation to RenderTextControlSingleLine
+ * rendering/RenderTextControl.h: allow a subclass implementation of controlClipRect, removed redundant hasControlClip implementation, and moved controlClipRect
+ * rendering/RenderTextControlSingleLine.cpp:
+ (WebCore::RenderTextControlSingleLine::paint): vertically center the Caps Lock indicator
+ (WebCore::RenderTextControlSingleLine::controlClipRect): use the set location of the anonymous inner block instead
+ * rendering/RenderTextControlSingleLine.h: allow for an implementation of controlClipRect for <input type="search">
+
+2010-04-27 Thomas Zander <t.zander@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] Fix linking on Symbian on Linux using the Makefile based mkspec.
+
+ Disable thumb mode due to library size limitations, just like it's done
+ for the sbs/sbsv2 based build system.
+
+ * WebCore.pro:
+
+2010-04-21 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ [Qt] Make sure WebKit is not compiled using C++0x.
+ https://bugs.webkit.org/show_bug.cgi?id=37867
+
+ As the rest of Qt compiles in the C++0x mode, people might start
+ compiling it in this mode. WebKit don't support this yet.
+
+ Patch by Thiago Macieira <thiago.macieira@nokia.com>
+
+ * WebCore.pro:
+
+2010-04-27 Jeremy Orlow <jorlow@chromium.org>
+
+ Unreviewed build fix.
+
+ Revert 58274 and 58269 (WebSQLDatabase changes)
+ https://bugs.webkit.org/show_bug.cgi?id=38191
+
+ Chromium bots are hitting ASSERTS when running layout tests.
+
+ * platform/sql/SQLiteDatabase.cpp:
+ (WebCore::SQLiteDatabase::maximumSize):
+ (WebCore::SQLiteDatabase::freeSpaceSize):
+ * platform/sql/SQLiteDatabase.h:
+ * platform/sql/SQLiteStatement.cpp:
+ (WebCore::SQLiteStatement::prepare):
+ * storage/Database.cpp:
+ (WebCore::Database::performOpenAndVerify):
+ * storage/Database.h:
+ * storage/SQLTransaction.cpp:
+ (WebCore::SQLTransaction::postflightAndCommit):
+
+2010-04-27 Yuzo Fujishima <yuzo@google.com>
+
+ Unreviewed, fix build breakage by reverting r58299.
+
+ * css/CSSGrammar.y:
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::CSSParser):
+ (WebCore::CSSParser::clearProperties):
+ * css/CSSParser.h:
+ * css/CSSSelector.cpp:
+ (WebCore::CSSSelector::pseudoId):
+ (WebCore::nameToPseudoTypeMap):
+ (WebCore::CSSSelector::extractPseudoType):
+ * css/CSSSelector.h:
+ (WebCore::CSSSelector::):
+ * css/tokenizer.flex:
+
+2010-04-27 Yuzo Fujishima <yuzo@google.com>
+
+ Reviewed by Shinichiro Hamaji.
+
+ WebCore::CSSSelector::RareData::parseNth doesn't check whether the search for '-' in the argument was successful.
+ This results in incorrect parsing.
+ For example, '3n' is parsed as if it were '3n-3'. The code has been working OK just accidentally.
+
+ https://bugs.webkit.org/show_bug.cgi?id=37787
+
+ No new tests are added because the original behavior is accidentally OK.
+
+ * css/CSSSelector.cpp:
+ (WebCore::CSSSelector::RareData::parseNth):
+
+2010-04-27 Yuzo Fujishima <yuzo@google.com>
+
+ Reviewed by David Hyatt.
+
+ Enhance CSS parser for Paged Media (Iteration 1)
+
+ In this change, the grammar is extended and skeletal methods for creating page rules and margin at-rules are defined.
+ The contents of the methods should be implemented by other changes.
+
+ https://bugs.webkit.org/show_bug.cgi?id=35329
+
+ Test: fast/css/parsing-page-rule.html
+
+ * css/CSSGrammar.y:
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::CSSParser):
+ (WebCore::CSSParser::clearProperties):
+ (WebCore::CSSParser::lex):
+ (WebCore::CSSParser::text):
+ (WebCore::CSSParser::createPageRule):
+ (WebCore::CSSParser::createMarginAtRule):
+ (WebCore::CSSParser::startDeclarationsForMarginBox):
+ (WebCore::CSSParser::endDeclarationsForMarginBox):
+ * css/CSSParser.h:
+ * css/CSSSelector.cpp:
+ (WebCore::CSSSelector::extractPseudoType):
+ * css/CSSSelector.h:
+ (WebCore::CSSSelector::):
+ * css/tokenizer.flex:
+
+2010-04-27 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ Remove custom bindings for TreeWalker
+ https://bugs.webkit.org/show_bug.cgi?id=38182
+
+ This custom code is just CallWith=ScriptState.
+
+ * WebCore.gypi:
+ * bindings/js/JSTreeWalkerCustom.cpp:
+ (WebCore::JSTreeWalker::markChildren):
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * bindings/scripts/CodeGeneratorV8.pm:
+ * bindings/scripts/test/TestObj.idl:
+ * bindings/v8/custom/V8TreeWalkerCustom.cpp: Removed.
+ * dom/TreeWalker.idl:
+
+2010-04-27 Eric Seidel <eric@webkit.org>
+
+ Reviewed by Adam Barth.
+
+ Move code out of GenerateImplementation to make it more smaller
+ https://bugs.webkit.org/show_bug.cgi?id=38176
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ - Move some code into a new GenerateAttributesHashTable method.
+
+2010-04-26 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ Add CallWith=DynamicFrame to CodeGenerator
+ https://bugs.webkit.org/show_bug.cgi?id=38174
+
+ I've only used this in one instance, but this is infrastructure that I
+ think will help remove a bunch of custom bindings code. Also, added a
+ few tests of tricky argument cases.
+
+ * bindings/js/JSHTMLFormElementCustom.cpp:
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * bindings/scripts/CodeGeneratorV8.pm:
+ * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
+ (webkit_dom_test_obj_with_dynamic_frame):
+ (webkit_dom_test_obj_with_dynamic_frame_and_arg):
+ (webkit_dom_test_obj_with_dynamic_frame_and_optional_arg):
+ (webkit_dom_test_obj_with_dynamic_frame_and_user_gesture):
+ (webkit_dom_test_obj_with_dynamic_frame_and_user_gesture_asad):
+ * bindings/scripts/test/GObject/WebKitDOMTestObj.h:
+ * bindings/scripts/test/JS/JSTestObj.cpp:
+ (WebCore::):
+ (WebCore::jsTestObjPrototypeFunctionWithDynamicFrame):
+ (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg):
+ (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg):
+ (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture):
+ (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):
+ * bindings/scripts/test/JS/JSTestObj.h:
+ * bindings/scripts/test/ObjC/DOMTestObj.h:
+ * bindings/scripts/test/ObjC/DOMTestObj.mm:
+ (-[DOMTestObj withDynamicFrame]):
+ (-[DOMTestObj withDynamicFrameAndArg:]):
+ (-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]):
+ (-[DOMTestObj withDynamicFrameAndUserGesture:]):
+ (-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]):
+ * bindings/scripts/test/TestObj.idl:
+ * bindings/scripts/test/V8/V8TestObj.cpp:
+ (WebCore::TestObjInternal::withDynamicFrameCallback):
+ (WebCore::TestObjInternal::withDynamicFrameAndArgCallback):
+ (WebCore::TestObjInternal::withDynamicFrameAndOptionalArgCallback):
+ (WebCore::TestObjInternal::withDynamicFrameAndUserGestureCallback):
+ (WebCore::TestObjInternal::withDynamicFrameAndUserGestureASADCallback):
+ (WebCore::):
+ * bindings/v8/custom/V8HTMLFormElementCustom.cpp:
+ * html/HTMLFormElement.idl:
+
+2010-04-26 Adam Barth <abarth@webkit.org>
+
+ Unreviewed. Update comment to better reflect reality.
+
+ * bindings/scripts/test/TestObj.idl:
+
+2010-04-26 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ Add ObjC and GObject to run-bindings-test
+ https://bugs.webkit.org/show_bug.cgi?id=38168
+
+ Added expected results.
+
+ * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Added.
+ (WebKit::kit):
+ (webkit_dom_test_obj_void_method):
+ (webkit_dom_test_obj_void_method_with_args):
+ (webkit_dom_test_obj_int_method):
+ (webkit_dom_test_obj_int_method_with_args):
+ (webkit_dom_test_obj_obj_method):
+ (webkit_dom_test_obj_obj_method_with_args):
+ (webkit_dom_test_obj_method_with_exception):
+ (webkit_dom_test_obj_method_with_optional_arg):
+ (webkit_dom_test_obj_method_with_non_optional_arg_and_optional_arg):
+ (webkit_dom_test_obj_method_with_non_optional_arg_and_two_optional_args):
+ (webkit_dom_test_obj_get_read_only_int_attr):
+ (webkit_dom_test_obj_get_read_only_string_attr):
+ (webkit_dom_test_obj_get_read_only_test_obj_attr):
+ (webkit_dom_test_obj_get_int_attr):
+ (webkit_dom_test_obj_set_int_attr):
+ (webkit_dom_test_obj_get_string_attr):
+ (webkit_dom_test_obj_set_string_attr):
+ (webkit_dom_test_obj_get_test_obj_attr):
+ (webkit_dom_test_obj_set_test_obj_attr):
+ (webkit_dom_test_obj_get_attr_with_exception):
+ (webkit_dom_test_obj_set_attr_with_exception):
+ (webkit_dom_test_obj_get_attr_with_setter_exception):
+ (webkit_dom_test_obj_set_attr_with_setter_exception):
+ (webkit_dom_test_obj_get_attr_with_getter_exception):
+ (webkit_dom_test_obj_set_attr_with_getter_exception):
+ (WebKit::wrapTestObj):
+ (WebKit::core):
+ (webkit_dom_test_obj_finalize):
+ (webkit_dom_test_obj_set_property):
+ (webkit_dom_test_obj_get_property):
+ (webkit_dom_test_obj_class_init):
+ (webkit_dom_test_obj_init):
+ * bindings/scripts/test/GObject/WebKitDOMTestObj.h: Added.
+ * bindings/scripts/test/GObject/WebKitDOMTestObjPrivate.h: Added.
+ * bindings/scripts/test/ObjC/DOMTestObj.h: Added.
+ * bindings/scripts/test/ObjC/DOMTestObj.mm: Added.
+ (-[DOMTestObj dealloc]):
+ (-[DOMTestObj finalize]):
+ (-[DOMTestObj readOnlyIntAttr]):
+ (-[DOMTestObj readOnlyStringAttr]):
+ (-[DOMTestObj readOnlyTestObjAttr]):
+ (-[DOMTestObj intAttr]):
+ (-[DOMTestObj setIntAttr:]):
+ (-[DOMTestObj stringAttr]):
+ (-[DOMTestObj setStringAttr:]):
+ (-[DOMTestObj testObjAttr]):
+ (-[DOMTestObj setTestObjAttr:]):
+ (-[DOMTestObj attrWithException]):
+ (-[DOMTestObj setAttrWithException:]):
+ (-[DOMTestObj attrWithSetterException]):
+ (-[DOMTestObj setAttrWithSetterException:]):
+ (-[DOMTestObj attrWithGetterException]):
+ (-[DOMTestObj setAttrWithGetterException:]):
+ (-[DOMTestObj customAttr]):
+ (-[DOMTestObj setCustomAttr:]):
+ (-[DOMTestObj voidMethod]):
+ (-[DOMTestObj voidMethodWithArgs:strArg:objArg:]):
+ (-[DOMTestObj intMethod]):
+ (-[DOMTestObj intMethodWithArgs:strArg:objArg:]):
+ (-[DOMTestObj objMethod]):
+ (-[DOMTestObj objMethodWithArgs:strArg:objArg:]):
+ (-[DOMTestObj methodWithException]):
+ (-[DOMTestObj customMethod]):
+ (-[DOMTestObj customMethodWithArgs:strArg:objArg:]):
+ (-[DOMTestObj methodWithOptionalArg:]):
+ (-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]):
+ (-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]):
+ (core):
+ (kit):
+ * bindings/scripts/test/ObjC/DOMTestObjInternal.h: Added.
+
+2010-04-26 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ Add testing infrastructure for JSC bindings generator
+ https://bugs.webkit.org/show_bug.cgi?id=38167
+
+ This required moving the test files around a bit more.
+
+ * bindings/scripts/test/JS/JSTestObj.cpp: Added.
+ (WebCore::):
+ (WebCore::JSTestObjConstructor::JSTestObjConstructor):
+ (WebCore::JSTestObjConstructor::classInfo):
+ (WebCore::JSTestObjConstructor::createStructure):
+ (WebCore::JSTestObjConstructor::getOwnPropertySlot):
+ (WebCore::JSTestObjConstructor::getOwnPropertyDescriptor):
+ (WebCore::JSTestObjPrototype::self):
+ (WebCore::JSTestObjPrototype::getOwnPropertySlot):
+ (WebCore::JSTestObjPrototype::getOwnPropertyDescriptor):
+ (WebCore::JSTestObj::JSTestObj):
+ (WebCore::JSTestObj::~JSTestObj):
+ (WebCore::JSTestObj::createPrototype):
+ (WebCore::JSTestObj::getOwnPropertySlot):
+ (WebCore::JSTestObj::getOwnPropertyDescriptor):
+ (WebCore::jsTestObjReadOnlyIntAttr):
+ (WebCore::jsTestObjReadOnlyStringAttr):
+ (WebCore::jsTestObjReadOnlyTestObjAttr):
+ (WebCore::jsTestObjIntAttr):
+ (WebCore::jsTestObjStringAttr):
+ (WebCore::jsTestObjTestObjAttr):
+ (WebCore::jsTestObjAttrWithException):
+ (WebCore::jsTestObjAttrWithSetterException):
+ (WebCore::jsTestObjAttrWithGetterException):
+ (WebCore::jsTestObjCustomAttr):
+ (WebCore::jsTestObjConstructor):
+ (WebCore::JSTestObj::put):
+ (WebCore::setJSTestObjIntAttr):
+ (WebCore::setJSTestObjStringAttr):
+ (WebCore::setJSTestObjTestObjAttr):
+ (WebCore::setJSTestObjAttrWithException):
+ (WebCore::setJSTestObjAttrWithSetterException):
+ (WebCore::setJSTestObjAttrWithGetterException):
+ (WebCore::setJSTestObjCustomAttr):
+ (WebCore::JSTestObj::getConstructor):
+ (WebCore::jsTestObjPrototypeFunctionVoidMethod):
+ (WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
+ (WebCore::jsTestObjPrototypeFunctionIntMethod):
+ (WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
+ (WebCore::jsTestObjPrototypeFunctionObjMethod):
+ (WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
+ (WebCore::jsTestObjPrototypeFunctionMethodWithException):
+ (WebCore::jsTestObjPrototypeFunctionCustomMethod):
+ (WebCore::jsTestObjPrototypeFunctionCustomMethodWithArgs):
+ (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
+ (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
+ (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
+ (WebCore::toJS):
+ (WebCore::toTestObj):
+ * bindings/scripts/test/JS/JSTestObj.h: Added.
+ (WebCore::JSTestObj::classInfo):
+ (WebCore::JSTestObj::createStructure):
+ (WebCore::JSTestObj::impl):
+ (WebCore::JSTestObjPrototype::classInfo):
+ (WebCore::JSTestObjPrototype::createStructure):
+ (WebCore::JSTestObjPrototype::JSTestObjPrototype):
+ * bindings/scripts/test/TestObj.idl:
+ * bindings/scripts/test/V8/V8TestObj.cpp: Renamed from WebCore/bindings/scripts/test/V8TestObj.cpp.
+ (WebCore::):
+ (WebCore::TestObjInternal::V8_USE):
+ (WebCore::TestObjInternal::readOnlyIntAttrAttrGetter):
+ (WebCore::TestObjInternal::readOnlyStringAttrAttrGetter):
+ (WebCore::TestObjInternal::readOnlyTestObjAttrAttrGetter):
+ (WebCore::TestObjInternal::intAttrAttrGetter):
+ (WebCore::TestObjInternal::intAttrAttrSetter):
+ (WebCore::TestObjInternal::stringAttrAttrGetter):
+ (WebCore::TestObjInternal::stringAttrAttrSetter):
+ (WebCore::TestObjInternal::testObjAttrAttrGetter):
+ (WebCore::TestObjInternal::testObjAttrAttrSetter):
+ (WebCore::TestObjInternal::attrWithExceptionAttrGetter):
+ (WebCore::TestObjInternal::attrWithExceptionAttrSetter):
+ (WebCore::TestObjInternal::attrWithSetterExceptionAttrGetter):
+ (WebCore::TestObjInternal::attrWithSetterExceptionAttrSetter):
+ (WebCore::TestObjInternal::attrWithGetterExceptionAttrGetter):
+ (WebCore::TestObjInternal::attrWithGetterExceptionAttrSetter):
+ (WebCore::TestObjInternal::voidMethodCallback):
+ (WebCore::TestObjInternal::voidMethodWithArgsCallback):
+ (WebCore::TestObjInternal::intMethodCallback):
+ (WebCore::TestObjInternal::intMethodWithArgsCallback):
+ (WebCore::TestObjInternal::objMethodCallback):
+ (WebCore::TestObjInternal::objMethodWithArgsCallback):
+ (WebCore::TestObjInternal::methodWithExceptionCallback):
+ (WebCore::TestObjInternal::methodWithOptionalArgCallback):
+ (WebCore::TestObjInternal::methodWithNonOptionalArgAndOptionalArgCallback):
+ (WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
+ (WebCore::TestObjInternal::overloadedMethod1Callback):
+ (WebCore::TestObjInternal::overloadedMethod2Callback):
+ (WebCore::TestObjInternal::overloadedMethod3Callback):
+ (WebCore::TestObjInternal::overloadedMethod4Callback):
+ (WebCore::TestObjInternal::overloadedMethodCallback):
+ (WebCore::ConfigureV8TestObjTemplate):
+ (WebCore::V8TestObj::GetRawTemplate):
+ (WebCore::V8TestObj::GetTemplate):
+ (WebCore::V8TestObj::toNative):
+ (WebCore::V8TestObj::HasInstance):
+ (WebCore::V8TestObj::wrap):
+ (WebCore::toV8):
+ (WebCore::V8TestObj::derefObject):
+ * bindings/scripts/test/V8/V8TestObj.h: Renamed from WebCore/bindings/scripts/test/V8TestObj.h.
+
+2010-04-26 Oliver Hunt <oliver@apple.com>
+
+ Reviewed by Gavin Barraclough.
+
+ Need to support more efficient dispatch of lightweight builtins
+ https://bugs.webkit.org/show_bug.cgi?id=38155
+
+ Update bindings generation to include new thunk generator field
+ in the property map hash tables.
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+
+2010-04-26 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ Move bindings test directory into the scripts directory
+ https://bugs.webkit.org/show_bug.cgi?id=38161
+
+ This test is really of the bindings scripts not of the bindings
+ themselves. By moving the files into the scripts directory, we'll be
+ able to test JSC as well.
+
+ * bindings/scripts/test/TestObj.idl: Renamed from WebCore/bindings/v8/test/TestObj.idl.
+ * bindings/scripts/test/V8TestObj.cpp: Renamed from WebCore/bindings/v8/test/V8TestObj.cpp.
+ (WebCore::):
+ (WebCore::TestObjInternal::V8_USE):
+ (WebCore::TestObjInternal::readOnlyIntAttrAttrGetter):
+ (WebCore::TestObjInternal::readOnlyStringAttrAttrGetter):
+ (WebCore::TestObjInternal::readOnlyTestObjAttrAttrGetter):
+ (WebCore::TestObjInternal::intAttrAttrGetter):
+ (WebCore::TestObjInternal::intAttrAttrSetter):
+ (WebCore::TestObjInternal::stringAttrAttrGetter):
+ (WebCore::TestObjInternal::stringAttrAttrSetter):
+ (WebCore::TestObjInternal::testObjAttrAttrGetter):
+ (WebCore::TestObjInternal::testObjAttrAttrSetter):
+ (WebCore::TestObjInternal::attrWithExceptionAttrGetter):
+ (WebCore::TestObjInternal::attrWithExceptionAttrSetter):
+ (WebCore::TestObjInternal::attrWithSetterExceptionAttrGetter):
+ (WebCore::TestObjInternal::attrWithSetterExceptionAttrSetter):
+ (WebCore::TestObjInternal::attrWithGetterExceptionAttrGetter):
+ (WebCore::TestObjInternal::attrWithGetterExceptionAttrSetter):
+ (WebCore::TestObjInternal::voidMethodCallback):
+ (WebCore::TestObjInternal::voidMethodWithArgsCallback):
+ (WebCore::TestObjInternal::intMethodCallback):
+ (WebCore::TestObjInternal::intMethodWithArgsCallback):
+ (WebCore::TestObjInternal::objMethodCallback):
+ (WebCore::TestObjInternal::objMethodWithArgsCallback):
+ (WebCore::TestObjInternal::methodWithExceptionCallback):
+ (WebCore::TestObjInternal::methodWithOptionalArgCallback):
+ (WebCore::TestObjInternal::methodWithNonOptionalArgAndOptionalArgCallback):
+ (WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
+ (WebCore::TestObjInternal::overloadedMethod1Callback):
+ (WebCore::TestObjInternal::overloadedMethod2Callback):
+ (WebCore::TestObjInternal::overloadedMethod3Callback):
+ (WebCore::TestObjInternal::overloadedMethod4Callback):
+ (WebCore::TestObjInternal::overloadedMethodCallback):
+ (WebCore::ConfigureV8TestObjTemplate):
+ (WebCore::V8TestObj::GetRawTemplate):
+ (WebCore::V8TestObj::GetTemplate):
+ (WebCore::V8TestObj::toNative):
+ (WebCore::V8TestObj::HasInstance):
+ (WebCore::V8TestObj::wrap):
+ (WebCore::toV8):
+ (WebCore::V8TestObj::derefObject):
+ * bindings/scripts/test/V8TestObj.h: Renamed from WebCore/bindings/v8/test/V8TestObj.h.
+
+2010-04-26 Daniel Cheng <dcheng@chromium.org>
+
+ Reviewed by Jian Li.
+
+ [chromium] Fix ChromiumDataObject::setURL to not populate its internal URL list with empty URLs.
+ https://bugs.webkit.org/show_bug.cgi?id=38159
+
+ No new tests.
+
+ * platform/chromium/ChromiumDataObject.h:
+ (WebCore::ChromiumDataObject::setURL):
+
+2010-04-26 Daniel Cheng <dcheng@chromium.org>
+
+ Reviewed by Jian Li.
+
+ [Chromium] Don't make file paths available in text/uri-list when dragging files.
+ https://bugs.webkit.org/show_bug.cgi?id=25882
+
+ Test will be checked in with WebCore/platform/mac fix.
+
+ * platform/chromium/ClipboardChromium.cpp:
+ (WebCore::ClipboardChromium::getData):
+ (WebCore::ClipboardChromium::types):
+
+2010-04-26 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Darin Adler.
+
+ REGRESSION (r57292): 1.5% page load speed regression from visited link information leak fix
+ https://bugs.webkit.org/show_bug.cgi?id=38131
+
+ I did a number of separate optimizations which speed up style
+ resolution enough to more than make up for the regression. This
+ measures as a total PLT speedup of somewhere between 1.5% and
+ 3.7%.
+
+ Optimizations done:
+ - Cache determineLinkState results, to avoid the need to repeatedly compute
+ the visited link hash for the same element. This directly addresses much
+ of the slowdown, since all elements get their style computed twice now.
+ - Added a fast way to get the length of a CSSMutableStyleDeclaration, and use
+ in CSSStyleSelector::matchRulesForList, since it was hot there.
+ - Hoist some loop invariant code that's not detected by the compiler out of the
+ main loop in matchRulesForList
+ - inline CSSStyleSelector::initElement and locateSharedStyle,
+ since there is only one call site in each case
+ - Inline the common non-line fast case of determineLinkState, and split the rest into
+ out-of-line determineLinkStateSlowCase.
+ - Added inline versions of the functions called by
+ visitedLinkHash (the version called by determineLinkState).
+
+ * css/CSSMutableStyleDeclaration.cpp:
+ (WebCore::CSSMutableStyleDeclaration::length): Implemented in terms of new
+ inline nonvirtual mutableLength().
+ * css/CSSMutableStyleDeclaration.h:
+ (WebCore::CSSMutableStyleDeclaration::mutableLength): Added new nonvirtual
+ inline way to get the length if you know you have a mutable style decl.
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::init): Clear cached link state.
+ (WebCore::CSSStyleSelector::matchRulesForList): hoist some code out of the main
+ loop and get style decl length more efficiently.
+ (WebCore::CSSStyleSelector::initElement): inline (only one call site)
+ (WebCore::CSSStyleSelector::SelectorChecker::determineLinkState): Inline fast
+ case, call slow case.
+ (WebCore::CSSStyleSelector::SelectorChecker::determineLinkStateSlowCase): Split
+ most of the above function into this slow case helper.
+ (WebCore::CSSStyleSelector::canShareStyleWithElement): Use the cache-enabled
+ way to get the current link state.
+ (WebCore::CSSStyleSelector::locateSharedStyle): inline
+ (WebCore::CSSStyleSelector::styleForElement): Use the cache-enabled way
+ to get the current link state.
+ * css/CSSStyleSelector.h:
+ (WebCore::CSSStyleSelector::currentElementLinkState): inline way to
+ get link state for the current element; manages the cache
+ * platform/LinkHash.cpp:
+ (WebCore::visitedLinkHashInline): inline version of below function
+ (WebCore::visitedLinkHash): call the inline version
+ (WebCore::visitedURLInline): inline version of below function
+ (WebCore::visitedURL): call the inline version
+ (WebCore::visitedURL): call inline versions of above two functions
+
+2010-04-26 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Remove last use of WEB_THREAD.
+
+ * platform/mac/WebCoreObjCExtras.mm:
+ (WebCoreObjCScheduleDeallocateOnMainThread): This can always use
+ isMainThread().
+
+2010-04-26 Dumitru Daniliuc <dumi@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ Turn on AUTO_VACUUM = INCREMENTAL for all HTML5 databases, and
+ vacuum all databases when the number of free pages is at least 10%
+ of the number of total pages. Also, adding a guard against a bug
+ that was fixed in SQLite only starting with version 3.6.16.
+
+ https://bugs.webkit.org/show_bug.cgi?id=36251
+
+ * platform/sql/SQLiteDatabase.cpp:
+ (WebCore::SQLiteDatabase::totalSize):
+ (WebCore::SQLiteDatabase::runIncrementalVacuumCommand):
+ (WebCore::SQLiteDatabase::turnOnIncrementalAutoVacuum):
+ * platform/sql/SQLiteDatabase.h:
+ * platform/sql/SQLiteStatement.cpp:
+ (WebCore::SQLiteStatement::prepare):
+ * storage/Database.cpp:
+ (WebCore::Database::performOpenAndVerify):
+ (WebCore::Database::incrementalVacuumIfNeeded):
+ * storage/Database.h:
+ * storage/SQLTransaction.cpp:
+ (WebCore::SQLTransaction::postflightAndCommit):
+
+2010-04-26 Geoffrey Garen <ggaren@apple.com>
+
+ Reviewed by Sam Weinig.
+
+ <rdar://problem/7766413>
+
+ Fixed a crash seen when using the JavaScriptCore API with WebKit.
+
+ No layout test because DumpRenderTree doesn't use the JavaScriptCore API
+ in this way.
+
+ * bindings/js/JSEventListener.cpp:
+ (WebCore::JSEventListener::JSEventListener): Don't assign 0 to a WeakGCPtr.
+ JavaScriptCore no longer allows this.
+
+ * bindings/js/ScriptWrappable.h:
+ (WebCore::ScriptWrappable::setWrapper): No need to initialize a WeakGCPtr
+ to 0, or ASSERT a non-0 value before assigning to a WeakGCPtr -- both are
+ default behaviors.
+
+2010-04-25 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Maciej Stachowiak.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=38097
+ Disentangle initializing the main thread from initializing threading
+
+ * WebCore.xcodeproj/project.pbxproj: Sort files.
+
+ * accessibility/mac/AccessibilityObjectWrapper.mm: Remove unnessary
+ +initialize method. The AccessibilityObjectWrapper has no data members
+ that need to be derefed, so it does not need to be finalized on the main
+ thread.
+
+ * bindings/js/ScriptController.cpp:
+ (WebCore::ScriptController::initializeThreading): Add call to initializeMainThread.
+ * bindings/objc/WebScriptObject.mm:
+ (+[WebScriptObject initialize]): Add call to initializeMainThreadToProcessMainThread.
+ * bindings/v8/ScriptController.cpp:
+ (WebCore::ScriptController::initializeThreading): Add call to initializeMainThread.
+ * platform/mac/SharedBufferMac.mm:
+ (+[WebCoreSharedBufferData initialize]): Add call to initializeMainThreadToProcessMainThread.
+
+2010-04-26 Yongjun Zhang <yongjun_zhang@apple.com>
+
+ Reviewed by Alexey Proskuryakov.
+
+ https://bugs.webkit.org/show_bug.cgi?id=38128
+ Don't add empty credential to CredentialStorage.
+
+ An empty credential is currently regarded as a invalid login because it means a missing value in
+ protectionSpaceToCredentialMap. This change makes it consistent with current WebCore's behavior
+ by ignoring empty credentials.
+
+ No new tests added since this only affects credential entered by user from credential dialog,
+ which is not testable in DRT.
+
+ * platform/network/mac/ResourceHandleMac.mm:
+ (WebCore::ResourceHandle::receivedCredential):
+
+2010-04-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] Clean-up WebCore.pro after now that JavaScriptCore is built separately
+ https://bugs.webkit.org/show_bug.cgi?id=38123
+
+ HAVE_STDINT_H, and HAVE_PTHREAD_NP_H no longer needs to be defined
+ for QtWebKit as JavaScriptCore is built separately. These defines are only
+ used by JavaScriptCore and for JavaScriptCore these are already
+ properly defined in JavaScriptCore/config.h.
+
+ No new tests, no new functionality.
+
+ * WebCore.pro:
+
+2010-04-26 Roman Gershman <romange@google.com>
+
+ Reviewed by Adam Barth.
+
+ [Chromium] Font size in suggestions popup menu should be correlated with the font size of its text field.
+ The following manual test checks for desired behavior.
+
+ https://bugs.webkit.org/show_bug.cgi?id=37977
+
+ * manual-tests/chromium/suggestions-popup-font-change.html: Added.
+
+2010-04-26 Luiz Agostini <luiz.agostini@openbossa.org>
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ View modes names in CSSValueKeywords.in
+ https://bugs.webkit.org/show_bug.cgi?id=38125
+
+ View mode names has changed in previous patch but CSSValueKeywords.in file was
+ not updated.
+
+ * css/CSSValueKeywords.in:
+
+2010-04-26 Simon Hausmann <simon.hausmann@nokia.com>
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ [Qt] Fix compilation with RVCT 4
+ https://bugs.webkit.org/show_bug.cgi?id=37727
+
+ Swap extern and declspec to fix visibility of symbol imported from QtGui.
+
+ * page/qt/EventHandlerQt.cpp:
+
+2010-04-26 Ruben Van Boxem <vanboxem.ruben@gmail.com>
+
+ Reviewed by Adam Roben.
+
+ Fixes for Win64 compilation under gcc (mingw-w64)
+
+ * WebCore/bridge/npapi.h: for win64 compatibility, mirroring mozilla-central, see Mozilla bug 560298
+ * WebCore/platform/Arena.h: uword is used to cast from pointers here. unsigned long is 32-bit on Windows (but 64-bit on mac), and too small to hold a pointer. uintptr_t is 32-bit on 32-bit systems (mac, linux and windows) and 64-bit on all 64-bit systems
+ * WebCore/platform/graphics/transforms/TransformationMatrix.h: let mingw-w64/w32 use MSVC codepath
+ * WebCore/platform/text/TextStream.cpp: let mingw-w64 use MSVC codepath
+ * WebCore/platform/text/TextStream.h: let mingw-w64 use MSVC codepath
+ * WebCore/plugins/PluginView.cpp: fix pointer casts on WIN64 and let mingw-w64 use MSVC codepath
+ * WebCore/plugins/win/PluginViewWin.cpp: fix pointer casts on WIN64
+
+2010-04-26 Markus Goetz <Markus.Goetz@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] HTTP pipelining efficiency increase
+ https://bugs.webkit.org/show_bug.cgi?id=38062
+
+ Increase number of network requests that are fed into
+ QNetworkAccessManager.
+
+ * platform/network/qt/ResourceRequestQt.cpp:
+ (WebCore::initializeMaximumHTTPConnectionCountPerHost):
+
+2010-04-26 Ilya Tikhonovsky <loislo@chromium.org>
+
+ Reviewed by Yury Semikhatsky.
+
+ Web Inspector: undefined shows up on inspector.
+ https://bugs.webkit.org/show_bug.cgi?id=38120
+
+ * inspector/front-end/ScriptsPanel.js:
+ (WebInspector.ScriptsPanel.prototype.hide):
+ * inspector/front-end/SourceFrame.js:
+ (WebInspector.SourceFrame.prototype.set visible):
+
+2010-04-26 Bruno Schmidt <bruno.schmidt@gmail.com>
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ [Qt] Exposing an QVariantMap containing QObjectStar to Javascript
+ causes Segmentation Fault
+ https://bugs.webkit.org/show_bug.cgi?id=34729
+
+ If an QVariantMap containing QObjectStar is added to the to QtWebkit
+ Javascript, it's use causes Segmentation Fault.
+ It happens because, in the case QMetaType::QVariantMap, the "root"
+ object that is inside of a PassRefPtr is passed recursively inside a
+ loop to recover the content of the map, but the PassRefPtr semantics
+ prohibit its use inside a loop, so the "root" object mus be passed
+ using the method "PassRefPtr::get" in order to keep the current
+ reference.
+
+ * bridge/qt/qt_runtime.cpp:
+ (JSC::Bindings::convertValueToQVariant):
+ (JSC::Bindings::convertQVariantToValue): change to root.get()
+
+2010-04-26 Pavel Feldman <pfeldman@chromium.org>
+
+ Reviewed by Yury Semikhatsky.
+
+ Web Inspector: Render clip in summary bar using "arc", not "quadraticCurveTo".
+
+ https://bugs.webkit.org/show_bug.cgi?id=38107
+
+ * inspector/front-end/SummaryBar.js:
+ (WebInspector.SummaryBar.prototype._drawSummaryGraph.drawPill):
+ (WebInspector.SummaryBar.prototype._drawSummaryGraph):
+
+2010-04-26 Andreas Kling <andreas.kling@nokia.com>
+
+ Reviewed by Tor Arne Vestbø.
+
+ [Qt] Fix compilation against Qt 4.7
+
+ Some QtMultimedia things have been moved into QtMediaServices
+ https://bugs.webkit.org/show_bug.cgi?id=38111
+
+ * WebCore.pro:
+ * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
+ (WebCore::MediaPlayerPrivate::supportsType):
+ (WebCore::MediaPlayerPrivate::totalBytes):
+
+2010-04-26 Zoltan Herczeg <zherczeg@webkit.org>
+
+ Reviewed by Dirk Schulze.
+
+ Call setStrokeStyle in applyStrokeStyleToContext
+ https://bugs.webkit.org/show_bug.cgi?id=37849
+
+ Not all platforms set the stroke style to solid if they
+ get an empty line dash array. Some just ignore the operation.
+
+ * rendering/SVGRenderSupport.cpp:
+ (WebCore::applyStrokeStyleToContext):
+
+2010-04-23 Ilya Tikhonovsky <loislo@chromium.org>
+
+ Reviewed by Pavel Feldman.
+
+ WebInspector: Aggregated stats of time spent in children records should be visible
+ in the popup panel of parent record. Crash in pushGCEventRecord also was fixed.
+ https://bugs.webkit.org/show_bug.cgi?id=37820
+
+ * English.lproj/localizedStrings.js:
+ * inspector/InspectorTimelineAgent.cpp:
+ (WebCore::InspectorTimelineAgent::pushGCEventRecords):
+ * inspector/front-end/TimelinePanel.js:
+ (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
+ (WebInspector.TimelinePanel.prototype._createRootRecord):
+ (WebInspector.TimelinePanel.prototype._showPopover):
+ (WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages):
+ (WebInspector.TimelineCalculator.prototype.computeBarGraphWindowPosition):
+ (WebInspector.TimelineRecordGraphRow):
+ (WebInspector.TimelineRecordGraphRow.prototype.update):
+ (WebInspector.TimelinePanel.FormattedRecord):
+ (WebInspector.TimelinePanel.FormattedRecord.prototype._generateAggregatedInfo):
+ (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
+ (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
+ (WebInspector.TimelinePanel.FormattedRecord.prototype._calculateAggregatedStats):
+ * inspector/front-end/inspector.css:
+ (.timeline-graph-bar.with-children):
+ (.timeline-graph-bar.cpu):
+ (.timeline-aggregated-category):
+ (.timeline-loading):
+ (.timeline-scripting):
+ (.timeline-rendering):
+ (.popover .timeline-aggregated-category.timeline-loading):
+ (.timeline-details-title):
+
+2010-04-25 Kent Tamura <tkent@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ WebKit crashes with deeply nested divs
+ https://bugs.webkit.org/show_bug.cgi?id=18282
+
+ The HTML parser caps a tree depth by MAX_DOM_TREE_DEPTH defined in
+ TreeDepthLimit.h. This is performance-efficient, but does not work for
+ DOM operations such as Node.appendChild().
+
+ Test: fast/parser/element-nesting-cap.html
+
+ * dom/Node.h:
+ * dom/XMLTokenizer.cpp:
+ (WebCore::XMLTokenizer::pushCurrentNode):
+ * html/HTMLParser.cpp:
+
+ * GNUmakefile.am:
+ * WebCore.gypi:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * dom/TreeDepthLimit.h:
+ Added. Define MAX_DOM_TREE_DEPTH. The default value is 5000.
+ * dom/XMLTokenizer.cpp: Use maxDOMTreeDepth.
+ (WebCore::XMLTokenizer::pushCurrentNode):
+ * html/HTMLParser.cpp:
+ Introduce m_treeDepth, which counts the depth of the tree.
+ Unlike m_blocksInStack, it contains the number of non-block nodes.
+ (WebCore::HTMLParser::HTMLParser):
+ (WebCore::HTMLParser::reset):
+ (WebCore::HTMLParser::limitDepth):
+ Renamed from limitBlockDepth. Add check for m_nodeDepth.
+ (WebCore::HTMLParser::insertNodeAfterLimitDepth):
+ Renamed from insertNodeAfterLimitBlockDepth.
+ (WebCore::HTMLParser::parseToken):
+ (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
+ (WebCore::HTMLParser::pushBlock):
+ (WebCore::HTMLParser::popOneBlockCommon):
+ (WebCore::HTMLParser::freeBlock):
+ * html/HTMLParser.h:
+
+2010-04-25 Andrey Kosyakov <caseq@chromium.org>
+
+ Reviewed by Adam Barth.
+
+ Get context properly when event handler was created on
+ the main world.
+ https://bugs.webkit.org/show_bug.cgi?id=37947
+
+ Test: http/tests/security/isolatedWorld/dispatchEvent.html
+
+ * bindings/v8/WorldContextHandle.cpp:
+ (WebCore::WorldContextHandle::adjustedContext):
+
+2010-04-25 yael aharon <yael.aharon@nokia.com>
+
+ Reviewed by Adele Peterson.
+
+ Allow styling of HTMLProgressElement.
+ https://bugs.webkit.org/show_bug.cgi?id=37901
+
+ Added a new pseudo element to represent the value portion of the progress element.
+ Web developers can style this pseudo element separate from the rest of the progress element.
+
+ Test: fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html
+
+ * css/CSSPrimitiveValueMappings.h:
+ (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+ * css/CSSSelector.cpp:
+ (WebCore::CSSSelector::pseudoId):
+ (WebCore::nameToPseudoTypeMap):
+ (WebCore::CSSSelector::extractPseudoType):
+ * css/CSSSelector.h:
+ * css/CSSValueKeywords.in:
+ * platform/ThemeTypes.h:
+ * rendering/RenderProgress.cpp:
+ (WebCore::ProgressValueElement::isShadowNode):
+ (WebCore::ProgressValueElement::shadowParentNode):
+ (WebCore::ProgressValueElement::ProgressValueElement):
+ (WebCore::RenderProgress::RenderProgress):
+ (WebCore::RenderProgress::~RenderProgress):
+ (WebCore::RenderProgress::layout):
+ (WebCore::RenderProgress::styleDidChange):
+ (WebCore::RenderProgress::updateFromElement):
+ (WebCore::RenderProgress::updateValuePartState):
+ (WebCore::RenderProgress::createStyleForValuePart):
+ (WebCore::RenderProgress::updateAnimationState):
+ * rendering/RenderTheme.cpp:
+ (WebCore::RenderTheme::isControlStyled):
+ * rendering/RenderProgress.h:
+ * rendering/style/RenderStyleConstants.h:
+
+2010-04-24 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Don't propagate compositing out of iframes on Mac
+ https://bugs.webkit.org/show_bug.cgi?id=38072
+
+ Propagating compositing out of iframes caused too many regressions on Mac,
+ so only do it for other platforms that may need to hook compositing layers
+ together across iframe boundaries.
+
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::requiresCompositingForIFrame):
+
+2010-04-24 Anton Muhin <antonm@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ Allow to construct HashTraits<WebCore::QualifiedName>::constructDeletedValue
+
+ Former implementation attempted to use AtomicString(HashTableDeletedValue)
+ however those values cannot be used that way: one cannot construct
+ QualifiedNameImpl out of such AtomicString as we'll try to lookup this string
+ in the table, for example.
+ https://bugs.webkit.org/show_bug.cgi?id=37722
+
+ * dom/QualifiedName.cpp:
+ (WebCore::QualifiedName::deref): check that hash table deleted values never derefed
+ * dom/QualifiedName.h:
+ (WebCore::QualifiedName::QualifiedName): add a constructor to create hash table deleted values
+ (WebCore::QualifiedName::isHashTableDeletedValue): add a check if given instance is hash table deleted value
+ (WTF::):
+
+2010-04-24 Julien Chaffraix <jchaffraix@webkit.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ protocolHostAndPortEquals host check makes a wrong assumption
+ https://bugs.webkit.org/show_bug.cgi?id=37777
+
+ The host check assumed that both host started at the same position. This is true
+ if both URL are the same but sometimes one has credential and the other does not.
+ In this case, the method would compare invalid positions.
+
+ Test: http/tests/appcache/credential-url.html
+
+ * platform/KURL.cpp:
+ (WebCore::protocolHostAndPortAreEqual):
+ * platform/KURLGoogle.cpp:
+ (WebCore::protocolHostAndPortAreEqual):
+ Fix the host check to take both URL's credential into account.
+
+2010-04-24 Nikolas Zimmermann <nzimmermann@rim.com>
+
+ Not reviewed. Fix linkage on several bots (no idea, why it worked in a from-scratch rebuild on Leopard on my machine!) -> include NodeRenderStyle.h
+ Having to include NodeRenderStyle.h just to pull in the renderStyle() is a crazy concept, but I see what it tries to avoid (including RenderObject.h in Node.h)
+
+ * rendering/SVGRenderSupport.cpp:
+
+2010-04-24 Nikolas Zimmermann <nzimmermann@rim.com>
+
+ Not reviewed. Fix release builds, wrap resourceMode assertion in NDEBUG blocks, use UNUSED_PARAM() otherwhise.
+
+ * rendering/RenderSVGResourceClipper.cpp:
+ (WebCore::RenderSVGResourceClipper::applyResource):
+ * rendering/RenderSVGResourceFilter.cpp:
+ (WebCore::RenderSVGResourceFilter::applyResource):
+ (WebCore::RenderSVGResourceFilter::postApplyResource):
+ * rendering/RenderSVGResourceMasker.cpp:
+ (WebCore::RenderSVGResourceMasker::applyResource):
+
+2010-04-24 Nikolas Zimmermann <nzimmermann@rim.com>
+
+ Reviewed by Dirk Schulze.
+
+ SVGPaintServer needs to be converted to the new RenderSVGResource* system
+ https://bugs.webkit.org/show_bug.cgi?id=37986
+
+ Huge speedup for SVG painting using paint servers (gradient/patterns). Cache underlying
+ WebCore::Gradient/Pattern datastructures, do not rebuild them on every painting. This marks
+ the finish of the SVGResource -> RenderSVGResource transition.
+
+ Outline of same key changes:
+ - RenderSVGResource is an abstract base class now, and the previous class is now named RenderSVGResourceContainer
+ All resources except RenderSVGResourceSolidColor now inherit from RenderSVGResourceContainer, as they are all
+ associated with a SVG*Element class. RenderSVGResourceSolidColor inherits from RenderSVGResource, and is not
+ associated with any SVG*Element class. RenderSVGResourceSolidColor is not a render tree object, despite its name.
+ The reason for that is consistency with all other painting resources.
+ - RenderSVGResourceSolidColor does not live in the render tree, and exists only as static object, which is shared
+ and always used when filling/stroking with solid colors - just like the old SVGPaintServerSolid.
+ - RenderSVGResourceGradient/RenderSVGResourcePattern now store the underlying WebCore::Gradient/Pattern object
+ instead of rebuilding it everytime we're asked to paint -> this is the main difference with the old concept, leading
+ to much faster speed.
+ - SVGResource has vanished. All resources (clipper/filter/marker/masker/gradient/pattern) now share the same codepaths
+ to handle updates and client invalidation - which is a huge benefit, and makes the code easier to understand.
+
+ * Android.mk: Remove svg/graphics/SVGResource*, svg/graphics/SVGPaintServer.h from build.
+ * GNUmakefile.am: Ditto.
+ * WebCore.gypi: Ditto.
+ * WebCore.pro: Ditto.
+ * WebCore.vcproj/WebCore.vcproj: Ditto.
+ * WebCore.xcodeproj/project.pbxproj: Ditto.
+ * platform/graphics/Gradient.cpp: Add addColorStop() method taking a ColorStop const-reference.
+ (WebCore::Gradient::addColorStop):
+ * platform/graphics/Gradient.h: Ditto.
+ * platform/graphics/TextRun.h: Rename SVGPaintServer to RenderSVGResource
+ (WebCore::TextRun::TextRun):
+ (WebCore::TextRun::activePaintingResource): Renamed from activePaintServer.
+ (WebCore::TextRun::setActivePaintingResource): Renamed from setActivePaintServer.
+ * platform/graphics/win/GraphicsContextWin.cpp: Remove references to SVGResourceImage, which was removed a long time ago.
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::toRenderSVGResourceContainer): Renamed from toRenderSVGResource().
+ * rendering/RenderObject.h:
+ (WebCore::RenderObject::isSVGGradientStop): Added.
+ (WebCore::RenderObject::isSVGResourceContainer): Renamed from isSVGResource().
+ * rendering/RenderPath.cpp: Utilize RenderSVGResource::fill/strokePaintingResource to request paint servers, instead of SVGPaintServer.
+ (WebCore::RenderPath::fillContains): Adapt to new concept.
+ (WebCore::RenderPath::strokeContains): Ditto.
+ (WebCore::fillAndStrokePath): Ditto.
+ (WebCore::RenderPath::paint): Ditto.
+ * rendering/RenderSVGGradientStop.cpp:
+ (WebCore::RenderSVGGradientStop::styleDidChange): Ditto.
+ * rendering/RenderSVGGradientStop.h: Fixed indention.
+ * rendering/RenderSVGResource.cpp: Refactored old SVGPaintServer code to request fill/stroke painting resources, splitted up in several methods to aid readability.
+ (WebCore::registerPendingResource):
+ (WebCore::adjustColorForPseudoRules):
+ (WebCore::RenderSVGResource::fillPaintingResource):
+ (WebCore::RenderSVGResource::strokePaintingResource):
+ (WebCore::RenderSVGResource::sharedSolidPaintingResource):
+ (WebCore::RenderSVGResource::markForLayoutAndResourceInvalidation):
+ * rendering/RenderSVGResource.h: Make RenderSVGResource an abstract base class, see above for the reasoning.
+ (WebCore::RenderSVGResource::RenderSVGResource):
+ (WebCore::RenderSVGResource::~RenderSVGResource):
+ (WebCore::RenderSVGResource::postApplyResource):
+ * rendering/RenderSVGResourceClipper.cpp: Inherit from RenderSVGResourceContainer instead of RenderSVGResource.
+ (WebCore::RenderSVGResourceClipper::RenderSVGResourceClipper):
+ (WebCore::RenderSVGResourceClipper::invalidateClient):
+ (WebCore::RenderSVGResourceClipper::applyResource): Adapt to signature changes (add RenderStyle* and resource mode parameters)
+ (WebCore::RenderSVGResourceClipper::applyClippingToContext):
+ * rendering/RenderSVGResourceClipper.h:
+ * rendering/RenderSVGResourceContainer.h: Added. Renamed from RenderSVGResource. Now inherits from RenderSVGHiddenContainer and RenderSVGResource.
+ (WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer):
+ (WebCore::RenderSVGResourceContainer::~RenderSVGResourceContainer):
+ (WebCore::RenderSVGResourceContainer::idChanged):
+ (WebCore::RenderSVGResourceContainer::isSVGResourceContainer):
+ (WebCore::RenderSVGResourceContainer::drawsContents):
+ (WebCore::RenderSVGResourceContainer::toRenderSVGResourceContainer):
+ (WebCore::getRenderSVGResourceContainerById):
+ (WebCore::getRenderSVGResourceById):
+ * rendering/RenderSVGResourceFilter.cpp: Inherit from RenderSVGResourceContainer instead of RenderSVGResource.
+ (WebCore::RenderSVGResourceFilter::RenderSVGResourceFilter):
+ (WebCore::RenderSVGResourceFilter::invalidateClient):
+ (WebCore::RenderSVGResourceFilter::applyResource): Adapt to signature changes (add RenderStyle* and resource mode parameters)
+ (WebCore::RenderSVGResourceFilter::postApplyResource):
+ * rendering/RenderSVGResourceFilter.h:
+ * rendering/RenderSVGResourceGradient.cpp: Moved from SVGPaintServerGradient, cleaned up and refactored.
+ (WebCore::RenderSVGResourceGradient::RenderSVGResourceGradient):
+ (WebCore::RenderSVGResourceGradient::~RenderSVGResourceGradient):
+ (WebCore::RenderSVGResourceGradient::invalidateClients):
+ (WebCore::RenderSVGResourceGradient::invalidateClient):
+ (WebCore::createMaskAndSwapContextForTextGradient):
+ (WebCore::clipToTextMask):
+ (WebCore::RenderSVGResourceGradient::applyResource):
+ * rendering/RenderSVGResourceGradient.h:
+ (WebCore::RenderSVGResourceGradient::resourceBoundingBox):
+ * rendering/RenderSVGResourceLinearGradient.cpp: Moved from SVGPaintServerLinearGradient, cleaned up and refactored.
+ (WebCore::RenderSVGResourceLinearGradient::RenderSVGResourceLinearGradient):
+ (WebCore::RenderSVGResourceLinearGradient::~RenderSVGResourceLinearGradient):
+ (WebCore::RenderSVGResourceLinearGradient::buildGradient):
+ * rendering/RenderSVGResourceLinearGradient.h:
+ (WebCore::RenderSVGResourceLinearGradient::renderName):
+ (WebCore::RenderSVGResourceLinearGradient::resourceType):
+ * rendering/RenderSVGResourceMarker.cpp: Inherit from RenderSVGResourceContainer instead of RenderSVGResource.
+ (WebCore::RenderSVGResourceMarker::RenderSVGResourceMarker):
+ (WebCore::RenderSVGResourceMarker::invalidateClient):
+ * rendering/RenderSVGResourceMarker.h:
+ (WebCore::RenderSVGResourceMarker::applyResource):
+ * rendering/RenderSVGResourceMasker.cpp: Inherit from RenderSVGResourceContainer instead of RenderSVGResource.
+ (WebCore::RenderSVGResourceMasker::RenderSVGResourceMasker):
+ (WebCore::RenderSVGResourceMasker::invalidateClient):
+ (WebCore::RenderSVGResourceMasker::applyResource):
+ * rendering/RenderSVGResourceMasker.h:
+ (WebCore::MaskerData::MaskerData):
+ * rendering/RenderSVGResourcePattern.cpp: Moved from SVGPaintServerPattern, cleaned up and refactored.
+ (WebCore::RenderSVGResourcePattern::RenderSVGResourcePattern):
+ (WebCore::RenderSVGResourcePattern::~RenderSVGResourcePattern):
+ (WebCore::RenderSVGResourcePattern::invalidateClients):
+ (WebCore::RenderSVGResourcePattern::invalidateClient):
+ (WebCore::RenderSVGResourcePattern::applyResource):
+ (WebCore::RenderSVGResourcePattern::postApplyResource):
+ (WebCore::calculatePatternBoundaries):
+ (WebCore::RenderSVGResourcePattern::calculatePatternBoundariesIncludingOverflow):
+ (WebCore::RenderSVGResourcePattern::createTileImage):
+ (WebCore::RenderSVGResourcePattern::buildPattern):
+ * rendering/RenderSVGResourcePattern.h:
+ (WebCore::RenderSVGResourcePattern::renderName):
+ (WebCore::RenderSVGResourcePattern::resourceBoundingBox):
+ (WebCore::RenderSVGResourcePattern::resourceType):
+ * rendering/RenderSVGResourceRadialGradient.cpp: Moved from SVGPaintServerRadialGradient, cleaned up and refactored.
+ (WebCore::RenderSVGResourceRadialGradient::RenderSVGResourceRadialGradient):
+ (WebCore::RenderSVGResourceRadialGradient::~RenderSVGResourceRadialGradient):
+ (WebCore::RenderSVGResourceRadialGradient::buildGradient):
+ * rendering/RenderSVGResourceRadialGradient.h:
+ (WebCore::RenderSVGResourceRadialGradient::renderName):
+ (WebCore::RenderSVGResourceRadialGradient::resourceType):
+ * rendering/RenderSVGResourceSolidColor.cpp: Moved from SVGPaintServerSolid, cleaned up and refactored.
+ (WebCore::RenderSVGResourceSolidColor::RenderSVGResourceSolidColor):
+ (WebCore::RenderSVGResourceSolidColor::~RenderSVGResourceSolidColor):
+ (WebCore::RenderSVGResourceSolidColor::applyResource):
+ (WebCore::RenderSVGResourceSolidColor::postApplyResource):
+ * rendering/RenderSVGResourceSolidColor.h:
+ (WebCore::RenderSVGResourceSolidColor::invalidateClients):
+ (WebCore::RenderSVGResourceSolidColor::invalidateClient):
+ (WebCore::RenderSVGResourceSolidColor::resourceBoundingBox):
+ (WebCore::RenderSVGResourceSolidColor::resourceType):
+ (WebCore::RenderSVGResourceSolidColor::color):
+ (WebCore::RenderSVGResourceSolidColor::setColor):
+ * rendering/RenderSVGText.cpp:
+ (WebCore::RenderSVGText::paint): Early exit if painting is disabled.
+ * rendering/RenderTreeAsText.cpp:
+ (WebCore::write): Add RenderSVGGradientStop dumping.
+ (WebCore::externalRepresentation): Remove SVGResource dumping.
+ * rendering/SVGInlineTextBox.cpp: Adapt to SVGPaintServer changes (paint server request).
+ (WebCore::SVGInlineTextBox::paintCharacters):
+ (WebCore::SVGInlineTextBox::paintDecoration):
+ * rendering/SVGInlineTextBox.h: Ditto.
+ (WebCore::SVGTextPaintInfo::SVGTextPaintInfo):
+ * rendering/SVGRenderSupport.cpp: Ditto.
+ (WebCore::SVGRenderBase::prepareToRenderSVGContent):
+ (WebCore::SVGRenderBase::finishRenderSVGContent):
+ (WebCore::invalidatePaintingResource):
+ (WebCore::deregisterFromResources):
+ (WebCore::dashArrayFromRenderingStyle): Moved here from SVGPaintServer.
+ (WebCore::applyStrokeStyleToContext): Ditto.
+ * rendering/SVGRenderSupport.h:
+ * rendering/SVGRenderTreeAsText.cpp: Add new gradient/pattern dumping code. Stops are now properly dumped as well!
+ (WebCore::operator<<):
+ (WebCore::writeSVGPaintingResource):
+ (WebCore::writeStyle):
+ (WebCore::boundingBoxModeString):
+ (WebCore::writeCommonGradientProperties):
+ (WebCore::writeSVGResourceContainer):
+ (WebCore::writeSVGGradientStop):
+ * rendering/SVGRenderTreeAsText.h:
+ * rendering/SVGRootInlineBox.cpp: Adapt to SVGPaintServer changes (paint server request).
+ (WebCore::SVGRootInlineBoxPaintWalker::SVGRootInlineBoxPaintWalker):
+ (WebCore::SVGRootInlineBoxPaintWalker::~SVGRootInlineBoxPaintWalker):
+ (WebCore::SVGRootInlineBoxPaintWalker::teardownFillPaintServer):
+ (WebCore::SVGRootInlineBoxPaintWalker::teardownStrokePaintServer):
+ (WebCore::SVGRootInlineBoxPaintWalker::setupBackground):
+ (WebCore::SVGRootInlineBoxPaintWalker::setupFill):
+ (WebCore::SVGRootInlineBoxPaintWalker::setupFillSelection):
+ (WebCore::SVGRootInlineBoxPaintWalker::setupStroke):
+ (WebCore::SVGRootInlineBoxPaintWalker::setupStrokeSelection):
+ (WebCore::SVGRootInlineBoxPaintWalker::setupForeground):
+ (WebCore::SVGRootInlineBoxPaintWalker::activePaintingResource):
+ (WebCore::SVGRootInlineBoxPaintWalker::paintChunk):
+ * svg/GradientAttributes.h: Remove SVGGradientStop, use Gradient::ColorStop vector. Cleanup.
+ (WebCore::GradientAttributes::stops):
+ (WebCore::GradientAttributes::setStops):
+ * svg/LinearGradientAttributes.h: Move ENABLE(SVG) guard to correct location.
+ * svg/PatternAttributes.h: Add missing includes and class forwards.
+ * svg/RadialGradientAttributes.h: Move ENABLE(SVG) guard to correct location.
+ * svg/SVGClipPathElement.cpp: Rename invalidateCanvasResources() to invalidateResourceClients().
+ (WebCore::SVGClipPathElement::svgAttributeChanged):
+ (WebCore::SVGClipPathElement::childrenChanged): Only call invalidateResourceClients() when !changedByParser is set.
+ * svg/SVGClipPathElement.h:
+ * svg/SVGDocumentExtensions.cpp: Change HashMaps to hash AtomicStrings instead of Strings. Rename RenderSVGResource to RenderSVGResourceContainer.
+ (WebCore::SVGDocumentExtensions::addResource):
+ (WebCore::SVGDocumentExtensions::removeResource):
+ (WebCore::SVGDocumentExtensions::resourceById):
+ (WebCore::SVGDocumentExtensions::addPendingResource):
+ * svg/SVGDocumentExtensions.h:
+ * svg/SVGElement.cpp:
+ (WebCore::SVGElement::insertedIntoDocument): Remove reference to SVGResource::invalidateClients(), handled differently now.
+ (WebCore::SVGElement::updateAnimatedSVGAttribute): Change assertion, that is incorrect now.
+ * svg/SVGElement.h: Make updateAnimatedSVGAttribute() public.
+ * svg/SVGFont.cpp: Adapt to SVGPaintServer changes (paint server request).
+ (WebCore::Font::drawTextUsingSVGFont):
+ * svg/SVGGElement.cpp: If style()->display() is NONE, create a RenderSVGHiddenContainer, removing hacks in SVGStopElement for pservers-grad-19-b.svg (yes, SVG is crazy.)
+ (WebCore::SVGGElement::createRenderer):
+ * svg/SVGGElement.h: Remove childrenChanged() method which _always_ called renderer->setNeedsLayout(true), which is completly wrong and unnecessary.
+ (WebCore::SVGGElement::rendererIsNeeded): Always return true.
+ * svg/SVGGradientElement.cpp: Adapt to new RenderSVGResourceGradient code.
+ (WebCore::SVGGradientElement::svgAttributeChanged):
+ (WebCore::SVGGradientElement::childrenChanged): Only call invalidateResourceClients() when !changedByParser is set.
+ (WebCore::SVGGradientElement::buildStops):
+ * svg/SVGGradientElement.h:
+ * svg/SVGLinearGradientElement.cpp: Adapt to new RenderSVGResourceLinearGradient code.
+ (WebCore::SVGLinearGradientElement::svgAttributeChanged):
+ (WebCore::SVGLinearGradientElement::createRenderer):
+ (WebCore::SVGLinearGradientElement::collectGradientProperties):
+ (WebCore::SVGLinearGradientElement::calculateStartEndPoints):
+ * svg/SVGLinearGradientElement.h:
+ * svg/SVGMarkerElement.cpp: Rename invalidateCanvasResources() to invalidateResourceClients().
+ (WebCore::SVGMarkerElement::svgAttributeChanged):
+ (WebCore::SVGMarkerElement::childrenChanged): Only call invalidateResourceClients() when !changedByParser is set.
+ (WebCore::SVGMarkerElement::setOrientToAuto):
+ (WebCore::SVGMarkerElement::setOrientToAngle):
+ * svg/SVGMaskElement.cpp: Rename invalidateCanvasResources() to invalidateResourceClients().
+ (WebCore::SVGMaskElement::svgAttributeChanged):
+ (WebCore::SVGMaskElement::childrenChanged): Only call invalidateResourceClients() when !changedByParser is set.
+ * svg/SVGPatternElement.cpp: Rename invalidateCanvasResources() to invalidateResourceClients().
+ (WebCore::SVGPatternElement::svgAttributeChanged):
+ (WebCore::SVGPatternElement::childrenChanged): Only call invalidateResourceClients() when !changedByParser is set.
+ (WebCore::SVGPatternElement::createRenderer):
+ * svg/SVGPatternElement.h:
+ * svg/SVGPolyElement.h: Remove unneded rendererIsNeeded() override.
+ * svg/SVGRadialGradientElement.cpp: Adapt to new RenderSVGResourceRadialGradient code.
+ (WebCore::SVGRadialGradientElement::svgAttributeChanged):
+ (WebCore::SVGRadialGradientElement::createRenderer):
+ (WebCore::SVGRadialGradientElement::collectGradientProperties):
+ (WebCore::SVGRadialGradientElement::calculateFocalCenterPointsAndRadius):
+ * svg/SVGRadialGradientElement.h:
+ * svg/SVGStopElement.cpp: Clean up code, moved stop color calculation from SVGGradientElement to here, where it belongs.
+ (WebCore::SVGStopElement::parseMappedAttribute):
+ (WebCore::SVGStopElement::stopColorIncludingOpacity):
+ * svg/SVGStopElement.h:
+ * svg/SVGStyledElement.cpp:
+ (WebCore::SVGStyledElement::~SVGStyledElement):
+ (WebCore::SVGStyledElement::svgAttributeChanged): Only invalidateResourcesInAncestorChain()/deregisterFromResources() when we're not parsing.
+ (WebCore::SVGStyledElement::invalidateResourcesInAncestorChain): Early exit if we find a parent resources, there is no resource nesting.
+ (WebCore::SVGStyledElement::invalidateResourceClients): Renamed from invalidateCanvasResources()
+ (WebCore::SVGStyledElement::childrenChanged): Only invalidate SVGElementInstances when !changedByParser is set.
+ * svg/SVGStyledElement.h: Remove canvasResource() logic, remove detach() method.
+ * svg/SVGTextPathElement.h:
+ * svg/graphics/SVGPaintServer.h: Removed.
+ * svg/graphics/SVGResource.cpp: Removed.
+ * svg/graphics/SVGResource.h: Removed.
+
+2010-04-23 Zhenyao Mo <zmo@google.com>
+
+ Reviewed by Darin Fisher.
+
+ Add isGLES2Compliant to GraphicsContext3D: make the method const.
+ https://bugs.webkit.org/show_bug.cgi?id=37872
+
+ * platform/graphics/GraphicsContext3D.h: Make isGLES2Compliant() const.
+ * platform/graphics/mac/GraphicsContext3DMac.cpp: Ditto.
+ (WebCore::GraphicsContext3D::isGLES2Compliant):
+
+2010-04-23 Qi Zhang <qi.2.zhang@nokia.com>
+
+ Reviewed by Laszlo Gombos.
+
+ [Qt] LayoutTests/fast/canvas/pointInPath.html passed, actually it failed
+ https://bugs.webkit.org/show_bug.cgi?id=37276
+
+ QPainterPath::contains doesn't count the point on the bound.
+
+ * platform/graphics/qt/PathQt.cpp:
+ (WebCore::isPointOnPathBorder):
+ (WebCore::Path::contains):
+
+2010-04-23 Sam Weinig <sam@webkit.org>
+
+ Reviewed by David Levin.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=38060
+ Split up Threading.h
+
+ Add necessary forwarding headers.
+
+ * ForwardingHeaders/wtf/Atomics.h: Added.
+ * ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
+ * ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.
+
+2010-04-23 Rafael Weinstein <rafaelw@grafaelw.sfo.corp.google.com>
+
+ Reviewed by Darin Fisher.
+
+ This patch adds a vector of additionalFeatures to WindowFeatures
+ and populates it with any feature strings that evaluate to "yes"
+ and aren't directly observed in WindowFeatures. This allows
+ clients to capture experimental window features.
+
+ https://bugs.webkit.org/show_bug.cgi?id=38013
+
+ * page/WindowFeatures.cpp:
+ (WebCore::WindowFeatures::setWindowFeature):
+ * page/WindowFeatures.h:
+
+2010-04-23 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ <rdar://problem/7898436> :after content is duplicated
+
+ Test: fast/css-generated-content/after-duplicated-after-split.html
+
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::splitInlines): Pass the correct owner of the child list.
+
+2010-04-23 Adele Peterson <adele@apple.com>
+
+ Fixing the Tiger build for real.
+
+ * platform/graphics/mac/SimpleFontDataMac.mm:
+
+2010-04-23 Adele Peterson <adele@apple.com>
+
+ Fixing the Tiger build.
+
+ * platform/graphics/mac/SimpleFontDataMac.mm:
+ (WebCore::SimpleFontData::platformBoundsForGlyph):
+
+2010-04-23 Jian Li <jianli@chromium.org>
+
+ Reviewed by Dmitry Titov.
+
+ Add FileError for File API.
+ https://bugs.webkit.org/show_bug.cgi?id=37840
+
+ The test will be added when implementing FileReader and FilerWriter.
+
+ * Android.derived.jscbindings.mk:
+ * Android.derived.v8bindings.mk:
+ * DerivedSources.cpp:
+ * DerivedSources.make:
+ * GNUmakefile.am:
+ * WebCore.gypi:
+ * WebCore.pri:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * dom/ExceptionCode.h:
+ (WebCore::):
+ * html/FileError.h: Added.
+ * html/FileError.idl: Added.
+ * page/DOMWindow.idl:
+
+2010-04-23 Jian Li <jianli@chromium.org>
+
+ Reviewed by Adam Barth.
+
+ Improve code generator scripts to handle OR ('|') condition in the
+ extended attributes.
+ https://bugs.webkit.org/show_bug.cgi?id=37998
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ * bindings/scripts/CodeGeneratorObjC.pm:
+ * bindings/scripts/CodeGeneratorV8.pm:
+ * bindings/scripts/IDLStructure.pm:
+
+2010-04-23 Adele Peterson <adele@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Fix for <rdar://problem/7855777> REGRESSION: Memory usage increase caused by storing glyph bounds in GlyphMetricsMap
+ https://bugs.webkit.org/show_bug.cgi?id=37936
+
+ This change breaks the GlyphMetricsMap into two maps - one for width and one for bounds, so that we don't store
+ a FloatRect for the glyph bounds unless we need to.
+
+ Covered by existing tests. This should not cause any change in functionality.
+
+ Updated for removal of GlyphMetricsMap.cpp
+ * Android.mk:
+ * GNUmakefile.am:
+ * WebCore.gypi:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+
+ Made GlyphMetricsMap a template, so it can be used for separate width and bounds maps.
+ * platform/graphics/GlyphMetricsMap.cpp: Removed.
+ * platform/graphics/GlyphMetricsMap.h:
+ (WebCore::GlyphMetricsMap::metricsForGlyph):
+ (WebCore::GlyphMetricsMap::setMetricsForGlyph):
+ (WebCore::GlyphMetricsMap::GlyphMetricsPage::metricsForGlyph):
+ (WebCore::GlyphMetricsMap::GlyphMetricsPage::setMetricsForGlyph):
+ (WebCore::GlyphMetricsMap::GlyphMetricsPage::setMetricsForIndex):
+ (WebCore::::unknownMetrics):
+ (WebCore::::locatePageSlowCase):
+
+ * platform/graphics/mac/ComplexTextController.cpp: (WebCore::ComplexTextController::adjustGlyphsAndAdvances):
+ Call boundsForGlyph instead of metricsForGlyph.
+ * platform/graphics/win/UniscribeController.cpp: (WebCore::UniscribeController::shapeAndPlaceItem):
+ ditto.
+ * platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::platformGlyphInit):
+ Call setMetricsForGlyph for both glyph maps.
+
+ Break getters and setters for metricsForGlyph into widthForGlyph and boundsForGlyph, maintaining present behavior.
+ * platform/graphics/SimpleFontData.h:
+ (WebCore::):
+ (WebCore::SimpleFontData::boundsForGlyph):
+ (WebCore::SimpleFontData::widthForGlyph):
+ * platform/graphics/cairo/SimpleFontDataCairo.cpp:
+ (WebCore::SimpleFontData::platformBoundsForGlyph):
+ (WebCore::SimpleFontData::platformWidthForGlyph):
+ * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
+ (WebCore::SimpleFontData::platformBoundsForGlyph):
+ (WebCore::SimpleFontData::platformWidthForGlyph):
+ * platform/graphics/chromium/SimpleFontDataLinux.cpp:
+ (WebCore::SimpleFontData::platformBoundsForGlyph):
+ (WebCore::SimpleFontData::platformWidthForGlyph):
+ * platform/graphics/gtk/SimpleFontDataPango.cpp:
+ (WebCore::SimpleFontData::platformBoundsForGlyph):
+ (WebCore::SimpleFontData::platformWidthForGlyph):
+ * platform/graphics/mac/SimpleFontDataMac.mm:
+ (WebCore::SimpleFontData::platformBoundsForGlyph):
+ (WebCore::SimpleFontData::platformWidthForGlyph):
+ * platform/graphics/win/SimpleFontDataCGWin.cpp:
+ (WebCore::SimpleFontData::platformBoundsForGlyph):
+ (WebCore::SimpleFontData::platformWidthForGlyph):
+ * platform/graphics/win/SimpleFontDataCairoWin.cpp:
+ (WebCore::SimpleFontData::platformBoundsForGlyph):
+ * platform/graphics/win/SimpleFontDataWin.cpp:
+ (WebCore::SimpleFontData::boundsForGDIGlyph):
+ (WebCore::SimpleFontData::widthForGDIGlyph):
+ * platform/graphics/wince/SimpleFontDataWince.cpp:
+ (WebCore::SimpleFontData::platformBoundsForGlyph):
+ * platform/graphics/wx/SimpleFontDataWx.cpp:
+ (WebCore::SimpleFontData::platformBoundsForGlyph):
+ (WebCore::SimpleFontData::platformWidthForGlyph):
+
+2010-04-23 Xiaomei Ji <xji@chromium.org>
+
+ Reviewed by Dan Bernstein and Darin Adler
+
+ Fix issue "caret does not paint after type in characters in right
+ aligned div or after delete all characters in RTL div or
+ 0px right padding RTL textarea"
+ https://bugs.webkit.org/show_bug.cgi?id=25319
+
+ Test: editing/inserting/caret-position.html
+
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::localCaretRect):
+
+2010-04-23 No'am Rosenthal <noam.rosenthal@nokia.com>
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ [Qt] [Performance] GraphicsLayer: constructing the layers takes too long
+ https://bugs.webkit.org/show_bug.cgi?id=36365
+
+ The issue came from using QGraphicsView's cache as is. The problem is that
+ several code-paths require re-rendering of the item, but not re-rendering
+ of the web content into the cache.
+
+ The way to solve it is by having GraphicsLayerQt manage the cache directly
+ via QPixmapCache, instead of using QGraphicsItem cache modes.
+
+ FPS measurement shows significant improvement (20FPS before, 40FPS after)
+ on several use-cases, including blog-files/leaves on a desktop environment.
+
+ * platform/graphics/qt/GraphicsLayerQt.cpp:
+ (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl):
+ (WebCore::GraphicsLayerQtImpl::recache):
+ (WebCore::GraphicsLayerQtImpl::paint):
+ (WebCore::GraphicsLayerQtImpl::flushChanges):
+
+2010-04-23 James Robinson <jamesr@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ Avoid marking symbols as dllexport in chromium win builds
+ https://bugs.webkit.org/show_bug.cgi?id=38058
+
+ No new tests.
+
+ * config.h:
+
+2010-04-23 MORITA Hajime <morrita@google.com>
+
+ Reviewed by Nikolas Zimmermann.
+
+ https://bugs.webkit.org/show_bug.cgi?id=37187
+ SVG <use href="foo"> is interpreted as <use href="#foo">
+
+ getTarget() did return url parameter as is if doesn't have
+ fragment identifier. So fixed to return empty string in such case
+ because we need to distinguish "yyy.html" from "xxx.svg#yyy.html".
+
+ Test: svg/custom/broken-internal-references.svg
+
+ * svg/SVGElement.cpp:
+ (WebCore::SVGElement::insertedIntoDocument):
+ * svg/SVGURIReference.cpp:
+ (WebCore::SVGURIReference::getTarget):
+
+2010-04-23 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ ASSERT(willBeComposited == needsToBeComposited(layer)); on gmail.com
+ https://bugs.webkit.org/show_bug.cgi?id=38066
+
+ When a layer goes into compositing mode because it has a negative z-index child that is going
+ into compositing mode, then set willBeComposited to true. Also add another assertion to catch
+ any other cases where the state of willBeComposited is mismanaged.
+
+ Test: compositing/composited-negative-zindex-child.html
+
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::computeCompositingRequirements):
+
+2010-04-23 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ When webkitAnimationEnd event fires, on-screen rendering should show the last frame of animation
+ https://bugs.webkit.org/show_bug.cgi?id=37955
+
+ After r37484, animation and transition end events were fired on a timer, after the animation/transition
+ ended. This opened up one event loop cycle in which the non-animating state of the element was visible
+ before the event fired, resulting in flashes in content that reset style from the event handler.
+
+ Fix by firing these events in the same event cycle as the animation end, once all animations
+ have been updated. This also required moving the place that start animations are fixed until
+ a later state in the state machine, so that animations have their start time set at the point
+ the event is fired (to avoid an assertion when using the freeze API in DRT).
+
+ Not testable, since the flash is very transitory and cannot be captured in a pixel test.
+
+ * page/animation/AnimationBase.cpp:
+ (WebCore::AnimationBase::updateStateMachine): Move the firing of 'start' events into the state
+ where the start time is known.
+ * page/animation/AnimationControllerPrivate.h:
+ * page/animation/AnimationController.cpp:
+ (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired): Call the new fireEventsAndUpdateStyle()
+ method.
+ (WebCore::AnimationControllerPrivate::fireEventsAndUpdateStyle): New method to share code that used to be in
+ updateStyleIfNeededDispatcherFired().
+ (WebCore::AnimationControllerPrivate::animationTimerFired): Call fireEventsAndUpdateStyle() once we've
+ processed all animations.
+
+2010-04-23 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ CompositeAnimation::updateKeyframeAnimations() can make a KeyframeAnimation for animation "none"
+ https://bugs.webkit.org/show_bug.cgi?id=38017
+
+ Check to see if the animation name is "none", and don't fire off a keyframe animation in
+ that case.
+
+ * page/animation/CompositeAnimation.cpp:
+ (WebCore::CompositeAnimation::updateKeyframeAnimations):
+
+2010-04-23 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ [Qt] Disable Netscape plugin support for minimal configuration
+ https://bugs.webkit.org/show_bug.cgi?id=38026
+
+ No new tests, as there is no new functionality.
+
+ * WebCore.pri:
+
+2010-04-23 Shinichiro Hamaji <hamaji@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ Need borderAndPadding(Width|Height)
+ https://bugs.webkit.org/show_bug.cgi?id=38046
+
+ Refactoring only, so no new tests.
+
+ * rendering/InlineBox.cpp:
+ (WebCore::InlineBox::height):
+ * rendering/RenderApplet.cpp:
+ (WebCore::RenderApplet::createWidgetIfNecessary):
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::isSelfCollapsingBlock):
+ (WebCore::RenderBlock::calcPrefWidths):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::calcBorderBoxWidth):
+ (WebCore::RenderBox::calcBorderBoxHeight):
+ (WebCore::RenderBox::calcContentBoxWidth):
+ (WebCore::RenderBox::calcContentBoxHeight):
+ (WebCore::RenderBox::calcWidth):
+ (WebCore::RenderBox::calcHeight):
+ (WebCore::RenderBox::calcPercentageHeight):
+ (WebCore::RenderBox::calcReplacedHeightUsing):
+ (WebCore::RenderBox::availableHeightUsing):
+ (WebCore::RenderBox::calcAbsoluteHorizontal):
+ (WebCore::RenderBox::calcAbsoluteVertical):
+ (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
+ (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
+ (WebCore::RenderBox::positionForPoint):
+ * rendering/RenderBoxModelObject.h:
+ (WebCore::RenderBoxModelObject::borderAndPaddingHeight):
+ (WebCore::RenderBoxModelObject::borderAndPaddingWidth):
+ * rendering/RenderDataGrid.cpp:
+ (WebCore::RenderDataGrid::calcPrefWidths):
+ * rendering/RenderFieldset.cpp:
+ (WebCore::RenderFieldset::calcPrefWidths):
+ * rendering/RenderFileUploadControl.cpp:
+ (WebCore::RenderFileUploadControl::calcPrefWidths):
+ * rendering/RenderFlexibleBox.cpp:
+ (WebCore::RenderFlexibleBox::calcPrefWidths):
+ (WebCore::RenderFlexibleBox::allowedChildFlex):
+ * rendering/RenderImage.cpp:
+ (WebCore::RenderImage::calcPrefWidths):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::resize):
+ * rendering/RenderListBox.cpp:
+ (WebCore::RenderListBox::calcPrefWidths):
+ (WebCore::RenderListBox::calcHeight):
+ * rendering/RenderMenuList.cpp:
+ (WebCore::RenderMenuList::calcPrefWidths):
+ * rendering/RenderReplaced.cpp:
+ (WebCore::RenderReplaced::calcPrefWidths):
+ * rendering/RenderSVGRoot.cpp:
+ (WebCore::RenderSVGRoot::calcPrefWidths):
+ * rendering/RenderSlider.cpp:
+ (WebCore::RenderSlider::calcPrefWidths):
+ (WebCore::RenderSlider::layout):
+ * rendering/RenderTableCell.cpp:
+ (WebCore::RenderTableCell::styleOrColWidth):
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::textBlockHeight):
+ (WebCore::RenderTextControl::textBlockWidth):
+ (WebCore::RenderTextControl::calcHeight):
+ (WebCore::RenderTextControl::calcPrefWidths):
+ * rendering/RenderTextControlSingleLine.cpp:
+ (WebCore::RenderTextControlSingleLine::layout):
+ * rendering/RenderWidget.cpp:
+ (WebCore::RenderWidget::updateWidgetPosition):
+
+2010-04-23 David Kilzer <ddkilzer@apple.com>
+
+ Size mismatch between format string and argument in dumpTextEncodingNameMap()
+
+ Reviewed by Darin Adler.
+
+ See Bug 38030 and r58157.
+
+ * platform/text/TextEncodingRegistry.cpp:
+ (WebCore::dumpTextEncodingNameMap): Assigned
+ textEncodingNameMap->size() to an unsigned variable before using
+ it in the fprintf() statement.
+
+2010-04-23 David Kilzer <ddkilzer@apple.com>
+
+ BUILD FIX: Attempt to fix Windows build after Bug 36187 landed in r58168
+
+ * DerivedSources.cpp: Changed include of JSMedia.cpp to
+ JSStyleMedia.cpp.
+
+2010-04-23 David Kilzer <ddkilzer@apple.com>
+
+ BUILD FIX: Fix Mac build after Bug 36187 landed in r58168
+
+ * WebCore.xcodeproj/project.pbxproj: Renamed DOMMedia.h,
+ DOMMedia.mm, DOMMediaInternal.h to DOMStyleMedia.h,
+ DOMStyleMedia.mm, DOMStyleMediaInternal.h.
+
+2010-04-23 Kenneth Rohde Christiansen <kenneth@webkit.org>
+
+ Unreviewed build fix.
+
+ Change Media to StyleMedia
+
+ * DerivedSources.make:
+
+2010-04-23 Xan Lopez <xlopez@igalia.com>
+
+ Try to fix the GTK+ bots.
+
+ * GNUmakefile.am:
+
+2010-04-22 Kenneth Rohde Christiansen <kenneth@webkit.org>
+
+ Reviewed by Laszlo Gombos.
+
+ Rename window.media to window.styleMedia
+ https://bugs.webkit.org/show_bug.cgi?id=36187
+
+ Rename the interface Media to StyleMedia as required by the
+ new CSSOM View spec.
+
+ * Android.derived.jscbindings.mk:
+ * Android.derived.v8bindings.mk:
+ * GNUmakefile.am:
+ * WebCore.gypi:
+ * WebCore.pri:
+ * WebCore.pro:
+ * WebCore.vcproj/WebCore.vcproj:
+ * WebCore.xcodeproj/project.pbxproj:
+ * css/Media.cpp: Removed.
+ * css/Media.h: Removed.
+ * css/Media.idl: Removed.
+ * css/StyleMedia.cpp: Added.
+ (WebCore::StyleMedia::StyleMedia):
+ (WebCore::StyleMedia::type):
+ (WebCore::StyleMedia::matchMedium):
+ * css/StyleMedia.h: Added.
+ (WebCore::StyleMedia::create):
+ (WebCore::StyleMedia::disconnectFrame):
+ * css/StyleMedia.idl: Added.
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::styleMedia):
+ * page/DOMWindow.h:
+ (WebCore::DOMWindow::optionalMedia):
+ * page/DOMWindow.idl:
+
+2010-04-23 Yury Semikhatsky <yurys@chromium.org>
+
+ Reviewed by Pavel Feldman.
+
+ Web Inspector: provide JSC implementation for scopeType method on
+ call frame and use same jsvascript code for JSC and v8 when collecting
+ scope chain data.
+
+ https://bugs.webkit.org/show_bug.cgi?id=37663
+
+ * bindings/js/JSInjectedScriptHostCustom.cpp:
+ (WebCore::JSInjectedScriptHost::currentCallFrame):
+ * bindings/js/JSJavaScriptCallFrameCustom.cpp:
+ (WebCore::JSJavaScriptCallFrame::scopeType):
+ * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
+ (WebCore::V8InjectedScriptHost::currentCallFrameCallback):
+ * inspector/InjectedScriptHost.idl:
+ * inspector/front-end/InjectedScript.js:
+ (injectedScriptConstructor.):
+
+2010-04-23 Alexander Pavlov <apavlov@chromium.org>
+
+ Reviewed by Pavel Feldman.
+
+ Web Inspector: Audits (Image Dimensions): full image URLs are prefixed with the hosting page name
+ https://bugs.webkit.org/show_bug.cgi?id=37988
+
+ * inspector/front-end/AuditRules.js:
+ (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
+
+2010-04-23 Ilya Tikhonovsky <loislo@chromium.org>
+
+ Reviewed by Yury Semikhatsky.
+
+ WebInspector: Flaky Inspector tests.
+ https://bugs.webkit.org/show_bug.cgi?id=36217
+
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::didCommitLoad):
+
+2010-04-23 Yaar Schnitman <yaar@chromium.org>
+
+ Reviewed by Adam Barth.
+
+ Auto-generate WebGLRenderingContext overloads in V8
+ https://bugs.webkit.org/show_bug.cgi?id=37818
+
+ * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
+ * html/canvas/WebGLRenderingContext.cpp: Added missing overloads for the following:.
+ (WebCore::WebGLRenderingContext::texImage2D)
+ (WebCore::WebGLRenderingContext::texSubImage2D)
+ * html/canvas/WebGLRenderingContext.h: Added missing overloads.
+ * html/canvas/WebGLRenderingContext.idl: IDL definition of overloads.
+
+2010-04-23 Jeff Schiller <codedread@gmail.com>
+
+ Reviewed by Nikolas Zimmermann.
+
+ Display tooltips when hovering over SVG elements, Bug 16854
+ https://bugs.webkit.org/show_bug.cgi?id=16854
+
+ Manual test added for verifying tooltips.
+
+ * manual-tests/svg-tooltip.svg: Added.
+ * svg/SVGAElement.cpp:
+ (WebCore::SVGAElement::title): xlink:title takes precedence, otherwise SVGStyledElement::title() is used
+ * svg/SVGStyledElement.cpp:
+ (WebCore::SVGStyledElement::title): checks for a shadow parent and uses that title, otherwise uses the content's title
+ * svg/SVGStyledElement.h: add title() method declaration
+
+2010-04-23 David Kilzer <ddkilzer@apple.com>
+
+ <http://webkit.org/b/38032> No need to content sniff 304 responses
+ <rdar://problem/7891726>
+
+ Reviewed by Brady Eidson.
+
+ * platform/network/mac/ResourceHandleMac.mm:
+ (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
+ No need to adjust the MIME type on 304 responses since they're
+ only used to determine if the resource needs to be refetched.
+
+2010-04-23 David Kilzer <ddkilzer@apple.com>
+
+ <http://webkit.org/b/38030> Add WebCore::dumpTextEncodingNameMap() to dump text encoding map on debug builds
+
+ Reviewed by Alexey Proskuryakov.
+
+ * platform/text/TextEncodingRegistry.cpp:
+ (WebCore::dumpTextEncodingNameMap): Added.
+ * platform/text/TextEncodingRegistry.h:
+ (WebCore::dumpTextEncodingNameMap): Added declaration.
+
+2010-04-22 Tony Chang <tony@chromium.org>
+
+ Reviewed by Dan Bernstein.
+
+ Crash in WebCore::TextIterator::handleTextNode() encountered in Google rich-text products
+ https://bugs.webkit.org/show_bug.cgi?id=37950
+
+ Test: editing/text-iterator/rtl-selection-crash.html
+
+ * editing/TextIterator.cpp:
+ (WebCore::TextIterator::handleTextNode):
+
+2010-04-22 Maciej Stachowiak <mjs@apple.com>
+
+ Reviewed by Dan Bernstein and Beth Dakin.
+
+ Links around blocks (e.g. divs) results in too many VoiceOver call outs
+ https://bugs.webkit.org/show_bug.cgi?id=37079
+ <rdar://problem/7234118>
+
+ The basic change is to modify the AccessibilityRenderObject tree
+ traversal methods to account for inline continuations in the
+ render tree and make the accessibility tree look as if
+ continuations didn't exist - the same as if CSS blocks could just
+ sit in CSS inlines. This is slightly tricky code but creates a
+ much saner accessibility tree.
+
+ Tests: accessibility/image-link-inline-cont.html
+ accessibility/image-link.html
+ accessibility/inline-continuations.html
+
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::isInlineWithContinuation): Helper function for traversal functions to use in accounting for continuations.
+ (WebCore::firstChildInContinuation): ditto
+ (WebCore::firstChildConsideringContinuation): ditto
+ (WebCore::lastChildConsideringContinuation): ditto
+ (WebCore::startOfContinuations): ditto
+ (WebCore::endOfContinuations): ditto
+ (WebCore::childBeforeConsideringContinuations): ditto
+ (WebCore::firstChildIsInlineContinuation): ditto
+ (WebCore::lastChildHasContinuation): ditto
+ (WebCore::AccessibilityRenderObject::firstChild): Account for inline continuations.
+ (WebCore::AccessibilityRenderObject::lastChild): ditto
+ (WebCore::AccessibilityRenderObject::previousSibling): Account for inline continuations
+ and their anonymous block parents.
+ (WebCore::AccessibilityRenderObject::nextSibling): ditto
+ (WebCore::AccessibilityRenderObject::parentObjectIfExists): Account for inline continuations.
+ (WebCore::AccessibilityRenderObject::parentObject): Account for inline continuations.
+ * rendering/RenderInline.h: Make RenderInline::inlineContinuation public.
+
+2010-04-22 Shinichiro Hamaji <hamaji@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ REGRESSION: TextIterator may use freed memory
+ https://bugs.webkit.org/show_bug.cgi?id=37973
+
+ Added TextIterator::m_text to hold the returned String.
+
+ No new tests because there are no behavior change, but
+ copy-backslash-with-euc.html on chromium-win should test this.
+
+ * editing/TextIterator.cpp:
+ (WebCore::TextIterator::emitText):
+ * editing/TextIterator.h:
+
+2010-04-22 Michael Forney <mforney@mforney.org>
+
+ Reviewed by Adam Barth.
+
+ https://bugs.webkit.org/show_bug.cgi?id=37761
+
+ Only include JSDatabase.h and JSDatabaseCallback.h when database is
+ enabled. This partially fixes building with --disable-database.
+
+ * bindings/js/JSDOMWindowCustom.cpp: Add a check for database around
+ database-related headers.
+
+2010-04-22 Ray Rischpater <Raymond.Rischpater@Nokia.com>
+
+ Reviewed by Darin Adler.
+
+ In HTMLInputElement.cpp, shouldUseInputMethod does not return true for
+ some text input types (TELEPHONE, NUMBER, URL, and EMAIL). Addressed
+ this by changing shouldUseInputMethod to use internal methods to
+ check that the field is a text field that isn't a password field.
+
+ No new tests.
+
+ Fixes <https://bugs.webkit.org/show_bug.cgi?id=37719>
+
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::shouldUseInputMethod):
+
+2010-04-22 Yaar Schnitman <yaar@chromium.org>
+
+ Reviewed by Adam Barth.
+
+ Integrate v8 testing utility with webkit tests
+ https://bugs.webkit.org/show_bug.cgi?id=37731
+
+ * bindings/v8/test/run_tests.py: Removed.
+
+2010-04-22 Zhenyao Mo <zmo@google.com>
+
+ Reviewed by Darin Fisher.
+
+ Add isGLES2Compliant to GraphicsContext3D
+ https://bugs.webkit.org/show_bug.cgi?id=37872
+
+ * html/canvas/WebGLRenderingContext.cpp: Add isGLES2Compliant().
+ (WebCore::WebGLRenderingContext::isGLES2Compliant):
+ * html/canvas/WebGLRenderingContext.h: Ditto.
+ * platform/graphics/GraphicsContext3D.h: Ditto.
+ * platform/graphics/mac/GraphicsContext3DMac.cpp: Ditto.
+ (WebCore::GraphicsContext3D::isGLES2Compliant):
+
+2010-04-22 Fumitoshi Ukai <ukai@chromium.org>
+
+ Reviewed by Adam Barth.
+
+ MD5 is required for WebSocket new protocol implementation
+ https://bugs.webkit.org/show_bug.cgi?id=37913
+
+ * ForwardingHeaders/wtf/MD5.h: Added.
+
+2010-04-22 Alexey Proskuryakov <ap@apple.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=38012
+ REGRESSION: Ctrl- and Option- shortcuts get wrong keyCode on non-QWERTY keyboard
+
+ * platform/mac/KeyEventMac.mm: (WebCore::windowsKeyCodeForKeyEvent): Also look at unmodified
+ characters, to avoid falling through to virtual key code lookup for Roman characters.
+
+2010-04-22 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
+
+ Reviewed by Darin Adler.
+
+ Fix the MSVC 64bit build.
+ https://bugs.webkit.org/show_bug.cgi?id=37980
+
+ * platform/text/TextStream.cpp:
+ * platform/text/TextStream.h:
+ * plugins/win/PluginViewWin.cpp:
+ (WebCore::PluginView::platformStart):
+
+2010-04-22 Dave Moore <davemoore@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ Added notification when the favicons for a page are changed
+ from a script.
+ The Document object will notify the frame loader, which will
+ notify the client. Implementations of FrameLoaderClient will
+ have to add one method; dispatchDidChangeIcons().
+
+ https://bugs.webkit.org/show_bug.cgi?id=33812
+
+ Test: fast/dom/icon-url-property.html
+
+ * dom/Document.cpp:
+ (WebCore::Document::setIconURL):
+ * loader/DocumentLoader.cpp:
+ (WebCore::DocumentLoader::setIconURL):
+ * loader/DocumentLoader.h:
+ (WebCore::DocumentLoader::iconURL):
+ * loader/EmptyClients.h:
+ (WebCore::EmptyFrameLoaderClient::dispatchDidChangeIcons):
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::setIconURL):
+ (WebCore::FrameLoader::didChangeIcons):
+ * loader/FrameLoader.h:
+ * loader/FrameLoaderClient.h:
+
+2010-04-22 Xan Lopez <xlopez@igalia.com>
+
+ Reviewed by Gustavo Noronha.
+
+ [GTK] GObject DOM bindings
+ https://bugs.webkit.org/show_bug.cgi?id=33590
+
+ Extend the bindings to cover most of Document.idl
+
+ * GNUmakefile.am:
+ * bindings/gobject/WebKitDOMBinding.cpp:
+ (WebKit::createWrapper):
+ (WebKit::kit):
+ * bindings/gobject/WebKitDOMBinding.h:
+ * bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: Added.
+ (WebKit::createAnchorWrapper):
+ (WebKit::createAppletWrapper):
+ (WebKit::createAreaWrapper):
+ (WebKit::createBaseWrapper):
+ (WebKit::createBaseFontWrapper):
+ (WebKit::createBlockquoteWrapper):
+ (WebKit::createBodyWrapper):
+ (WebKit::createBRWrapper):
+ (WebKit::createButtonWrapper):
+ (WebKit::createCanvasWrapper):
+ (WebKit::createTableCaptionWrapper):
+ (WebKit::createTableColWrapper):
+ (WebKit::createModWrapper):
+ (WebKit::createDirectoryWrapper):
+ (WebKit::createDivWrapper):
+ (WebKit::createDListWrapper):
+ (WebKit::createEmbedWrapper):
+ (WebKit::createFieldSetWrapper):
+ (WebKit::createFontWrapper):
+ (WebKit::createFormWrapper):
+ (WebKit::createFrameWrapper):
+ (WebKit::createFrameSetWrapper):
+ (WebKit::createHeadingWrapper):
+ (WebKit::createHeadWrapper):
+ (WebKit::createHRWrapper):
+ (WebKit::createHtmlWrapper):
+ (WebKit::createIFrameWrapper):
+ (WebKit::createImageWrapper):
+ (WebKit::createInputWrapper):
+ (WebKit::createIsIndexWrapper):
+ (WebKit::createLabelWrapper):
+ (WebKit::createLegendWrapper):
+ (WebKit::createLIWrapper):
+ (WebKit::createLinkWrapper):
+ (WebKit::createMapWrapper):
+ (WebKit::createMarqueeWrapper):
+ (WebKit::createMenuWrapper):
+ (WebKit::createMetaWrapper):
+ (WebKit::createObjectWrapper):
+ (WebKit::createOListWrapper):
+ (WebKit::createOptGroupWrapper):
+ (WebKit::createOptionWrapper):
+ (WebKit::createParagraphWrapper):
+ (WebKit::createParamWrapper):
+ (WebKit::createPreWrapper):
+ (WebKit::createQuoteWrapper):
+ (WebKit::createScriptWrapper):
+ (WebKit::createSelectWrapper):
+ (WebKit::createStyleWrapper):
+ (WebKit::createTableWrapper):
+ (WebKit::createTableSectionWrapper):
+ (WebKit::createTableCellWrapper):
+ (WebKit::createTextAreaWrapper):
+ (WebKit::createTitleWrapper):
+ (WebKit::createTableRowWrapper):
+ (WebKit::createUListWrapper):
+ (WebKit::createHTMLElementWrapper):
+ * bindings/gobject/WebKitHTMLElementWrapperFactory.h: Added.
+ * bindings/scripts/CodeGeneratorGObject.pm:
+ * dom/Node.idl:
+
+2010-04-22 Eric Carlson <eric.carlson@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ Do not pause movie when readyState drops below HAVE_FUTURE_DATA
+ https://bugs.webkit.org/show_bug.cgi?id=37991
+ <rdar://problem/7893937>
+
+ No new tests, we don't have infrastructure in DRT to test with streamed
+ movies.
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_readyStateMaximum.
+ (WebCore::HTMLMediaElement::prepareForLoad): Reset m_readyStateMaximum.
+ (WebCore::HTMLMediaElement::setReadyState): Maintain m_readyStateMaximum.
+ (WebCore::HTMLMediaElement::potentiallyPlaying): Also return true if the readyState was
+ previously >= HAVE_FUTURE_DATA.
+ * html/HTMLMediaElement.h:
+
+2010-04-22 Zhenyao Mo <zmo@google.com>
+
+ Reviewed by Dimitri Glazkov.
+
+ Regression: framebufferRenderbuffer crashes with null renderBuffer
+ https://bugs.webkit.org/show_bug.cgi?id=37963
+
+ * html/canvas/WebGLRenderingContext.cpp:
+ (WebCore::WebGLRenderingContext::framebufferRenderbuffer): Dealing with null renderbuffer input.
+
+2010-04-22 Zhenyao Mo <zmo@google.com>
+
+ Reviewed by Dimitri Glazkov.
+
+ Emulate GL_IMPLEMENTATION_COLOR_READ_FORMAT/TYPE for glGet
+ https://bugs.webkit.org/show_bug.cgi?id=37281
+
+ * html/canvas/WebGLRenderingContext.cpp:
+ (WebCore::WebGLRenderingContext::WebGLRenderingContext): Remove error check because two enums are supported now.
+ (WebCore::WebGLRenderingContext::getParameter): Add two enums.
+ (WebCore::WebGLRenderingContext::readPixels): Fix a tiny bug.
+ * platform/graphics/mac/GraphicsContext3DMac.cpp:
+ (WebCore::GraphicsContext3D::getIntegerv): Emulate two enums.
+
+2010-04-22 Diego Escalante Urrelo <descalante@igalia.com>
+
+ Reviewed by Xan Lopez.
+
+ [GTK] Mute/unmute button on <video> elements are backwards
+ https://bugs.webkit.org/show_bug.cgi?id=33967
+
+ Fix mute/unmute buttons icons-action relation and explain why their
+ variable names and corresponding icons seem to be misleading but are
+ actually right. Original patch by Mike Hommey.
+
+ * platform/gtk/RenderThemeGtk.cpp:
+ (WebCore::RenderThemeGtk::initMediaStyling):
+
+2010-04-22 Gustavo Sverzut Barbieri <barbieri@profusion.mobi>
+
+ Reviewed by Eric Seidel.
+
+ Fix build if NPAPI support is disabled
+ https://bugs.webkit.org/show_bug.cgi?id=36621
+
+ No new tests, this is a build fix.
+ Re-submit r58043 with fix for EFL.
+
+ * plugins/PluginViewNone.cpp:
+
+2010-04-22 Diego Escalante Urrelo <descalante@igalia.com>
+
+ Reviewed by Xan Lopez.
+
+ [Gtk] Evaluate and create tests for all the AtkRole's implemented by
+ WebKitGtk
+ https://bugs.webkit.org/show_bug.cgi?id=34449
+
+ Implement ATK_ROLE_COMBO_BOX.
+
+ * accessibility/gtk/AccessibilityObjectAtk.cpp:
+ (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
+ * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
+ (atkRole):
+
+2010-04-22 Nikolas Zimmermann <nzimmermann@rim.com>
+
+ Reviewed by Dirk Schulze.
+
+ SVGPaintServer needs to be converted to the new RenderSVGResource* system
+ https://bugs.webkit.org/show_bug.cgi?id=37986
+
+ No functional changes, just move the SVGPaintServer* classes from svg/graphics/ to rendering/, the new location for the RenderSVGResource* classes.
+ This is a preparation for the real patch which follows soon.
+
+ * Android.mk: Rename files and move to the right location.
+ * GNUmakefile.am: Ditto.
+ * WebCore.gypi: Ditto.
+ * WebCore.pro: Ditto.
+ * WebCore.vcproj/WebCore.vcproj: Ditto.
+ * WebCore.xcodeproj/project.pbxproj: Ditto.
+ * rendering/RenderSVGResource.cpp: Copied from svg/graphics/SVGPaintServer.cpp.
+ * rendering/RenderSVGResourceGradient.cpp: Copied from svg/graphics/SVGPaintServerGradient.cpp.
+ * rendering/RenderSVGResourceGradient.h: Copied from svg/graphics/SVGPaintServerGradient.h.
+ * rendering/RenderSVGResourceLinearGradient.cpp: Copied from svg/graphics/SVGPaintServerLinearGradient.cpp.
+ * rendering/RenderSVGResourceLinearGradient.h: Copied from svg/graphics/SVGPaintServerLinearGradient.h.
+ * rendering/RenderSVGResourcePattern.cpp: Copied from svg/graphics/SVGPaintServerPattern.cpp.
+ * rendering/RenderSVGResourcePattern.h: Copied from svg/graphics/SVGPaintServerPattern.h.
+ * rendering/RenderSVGResourceRadialGradient.cpp: Copied from svg/graphics/SVGPaintServerRadialGradient.cpp.
+ * rendering/RenderSVGResourceRadialGradient.h: Copied from svg/graphics/SVGPaintServerRadialGradient.h.
+ * rendering/RenderSVGResourceSolidColor.cpp: Copied from svg/graphics/SVGPaintServerSolid.cpp.
+ * rendering/RenderSVGResourceSolidColor.h: Copied from svg/graphics/SVGPaintServerSolid.h.
+ * rendering/SVGRenderTreeAsText.cpp: Change include file names.
+ * svg/SVGFont.cpp: Ditto.
+ * svg/SVGGradientElement.cpp: Ditto.
+ * svg/SVGGradientElement.h: Ditto.
+ * svg/SVGLinearGradientElement.cpp: Ditto.
+ * svg/SVGPatternElement.cpp: Ditto.
+ * svg/SVGPatternElement.h: Ditto.
+ * svg/SVGRadialGradientElement.cpp: Ditto.
+ * svg/graphics/SVGPaintServer.cpp: Removed.
+ * svg/graphics/SVGPaintServerGradient.cpp: Removed.
+ * svg/graphics/SVGPaintServerGradient.h: Removed.
+ * svg/graphics/SVGPaintServerLinearGradient.cpp: Removed.
+ * svg/graphics/SVGPaintServerLinearGradient.h: Removed.
+ * svg/graphics/SVGPaintServerPattern.cpp: Removed.
+ * svg/graphics/SVGPaintServerPattern.h: Removed.
+ * svg/graphics/SVGPaintServerRadialGradient.cpp: Removed.
+ * svg/graphics/SVGPaintServerRadialGradient.h: Removed.
+ * svg/graphics/SVGPaintServerSolid.cpp: Removed.
+ * svg/graphics/SVGPaintServerSolid.h: Removed.
+ * svg/graphics/SVGResourceListener.h: Removed.
+
+2010-04-22 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] Hide the OpenGL and QtMultimedia dependencies from syncqt.
+
+ This prevents the dependent headers from being included by
+ qt/include/QtWebKit/QtWebKit
+
+ * WebCore.pro:
+
+2010-04-22 Gustavo Sverzut Barbieri <barbieri@profusion.mobi>
+
+ Reviewed by Adam Roben.
+
+ EFL does not support PluginDatabase yet.
+ http://webkit.org/b/37854
+
+ No behavior changes, so no new tests were added.
+
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::defaultObjectContentType):
+
+2010-04-22 Ilya Tikhonovsky <loislo@chromium.org>
+
+ Reviewed by Yury Semikhatsky.
+
+ Web Inspector: Timeline scrolling speed is slow if it has more than 1k timeline marks.
+ https://bugs.webkit.org/show_bug.cgi?id=37924
+
+ * inspector/front-end/TimelineGrid.js:
+ (WebInspector.TimelineGrid.prototype.updateDividers):
+ (WebInspector.TimelineGrid.prototype.addEventDividers):
+ * inspector/front-end/TimelineOverviewPane.js:
+ (WebInspector.TimelineOverviewPane.prototype.updateEventDividers):
+ * inspector/front-end/TimelinePanel.js:
+ (WebInspector.TimelinePanel.prototype._updateEventDividers):
+ (WebInspector.TimelinePanel.prototype._refresh):
+
+2010-04-22 Kenneth Rohde Christiansen <kenneth@webkit.org>
+
+ Reviewed by Simon Fraser.
+
+ Rename window.media to window.styleMedia
+ https://bugs.webkit.org/show_bug.cgi?id=36187
+
+ It has been defined that the AbstractView media extension
+ defined in the CSSOM View spec should be renamed to styleMedia.
+ This patch does that and updates the current layout tests
+ making use of it.
+
+ * page/AbstractView.idl:
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::styleMedia):
+ * page/DOMWindow.h:
+ * page/DOMWindow.idl:
+
+2010-04-22 Anton Muhin <antonm@chromium.org>
+
+ Reviewed by Adam Barth.
+
+ [v8] Do not pass empty handle into SetHiddenValue which would crash.
+ https://bugs.webkit.org/show_bug.cgi?id=37801
+
+ * bindings/v8/V8AbstractEventListener.cpp:
+ (WebCore::V8AbstractEventListener::handleEvent): add couple of asserts to check for unexpected paths
+ (WebCore::V8AbstractEventListener::invokeEventHandler): bail out of jsEvent is empty handle
+
+2010-04-22 Stephan Aßmus <superstippi@gmx.de>
+
+ Reviewed by David Levin.
+
+ [Haiku] Implement ImageBuffer support
+ https://bugs.webkit.org/show_bug.cgi?id=35288
+
+ Covered by existing tests.
+
+ Complete implementation of ImageBuffer for Haiku. Uses StillImage
+ class to export a WebCore::Image and associated GraphicsContext
+ to perform arbitrary drawing in the offscreen BBitmap buffer.
+
+ * platform/graphics/haiku/ImageBufferData.h:
+ * platform/graphics/haiku/ImageBufferHaiku.cpp,
+ (WebCore::ImageBufferData::ImageBufferData),
+ (WebCore::ImageBufferData::~ImageBufferData),
+ (WebCore::ImageBuffer::ImageBuffer),
+ (WebCore::ImageBuffer::~ImageBuffer),
+ (WebCore::ImageBuffer::context),
+ (WebCore::ImageBuffer::image):
+ Implementation uses offscreen BBitmap and BView, wraps StillImage
+ around those to provide WebCore::Image interface.
+ (WebCore::ImageBuffer::platformTransformColorSpace):
+ (WebCore::convertFromData):
+ Method just performs BGRA <-> RGBA conversion.
+ (WebCore::convertFromInternalData):
+ Method just performs BGRA <-> RGBA conversion and handles
+ pre-multiplying the color values if requested.
+ (WebCore::convertToInternalData):
+ Method just performs BGRA <-> RGBA conversion and handles
+ de.multiplying the color values if requested.
+ (WebCore::getImageData):
+ Common code for the next two methods.
+ (WebCore::ImageBuffer::getUnmultipliedImageData),
+ (WebCore::ImageBuffer::getPremultipliedImageData):
+ Implemented.
+ (WebCore::putImageData):
+ Common code for the next two methods.
+ (WebCore::ImageBuffer::putUnmultipliedImageData),
+ (WebCore::ImageBuffer::putPremultipliedImageData):
+ Implemented.
+ (WebCore::ImageBuffer::toDataURL):
+ Uses Haiku "Translation Kit" to convert image data to data
+ of the requested mime type.
+
+2010-04-22 Adam Barth <abarth@webkit.org>
+
+ Unreviewed, rolling out r58069.
+ http://trac.webkit.org/changeset/58069
+ https://bugs.webkit.org/show_bug.cgi?id=27751
+
+ Broke compile on Windows.
+
+ * WebCore.base.exp:
+ * editing/EditorCommand.cpp:
+ (WebCore::supportedPaste):
+ (WebCore::createCommandMap):
+ * page/Settings.cpp:
+ (WebCore::Settings::Settings):
+ * page/Settings.h:
+
+2010-04-22 Abhishek Arya <inferno@chromium.org>
+
+ Reviewed by Adam Barth.
+
+ Add support for controlling clipboard access from javascript.
+ Clipboard access from javascript is disabled by default.
+ https://bugs.webkit.org/show_bug.cgi?id=27751
+
+ Test: editing/execCommand/clipboard-access.html
+
+ * WebCore.base.exp:
+ * editing/EditorCommand.cpp:
+ (WebCore::supportedCopyCut):
+ (WebCore::supportedPaste):
+ (WebCore::createCommandMap):
+ * page/Settings.cpp:
+ (WebCore::Settings::Settings):
+ (WebCore::Settings::setJavaScriptCanAccessClipboard):
+ * page/Settings.h:
+ (WebCore::Settings::javaScriptCanAccessClipboard):
+
+2010-04-22 Stephan Aßmus <superstippi@gmx.de>
+
+ Reviewed by David Levin.
+
+ [Haiku] Improve SimpleFontDataHaiku
+ https://bugs.webkit.org/show_bug.cgi?id=37411
+
+ Covered by existing tests.
+
+ * platform/graphics/haiku/SimpleFontDataHaiku.cpp:
+ - Cleaned up includes
+ - Removed prototype "charUnicodeToUTF8HACK"
+ (WebCore::SimpleFontData::platformInit):
+ - Use const BFont pointer
+ (WebCore::SimpleFontData::smallCapsFontData):
+ - "fontPlatformData" was leaked. It is only
+ used as the key for the font cache lookup.
+ (WebCore::SimpleFontData::platformMetricsForGlyph):
+ - Use existing WebCore encoding infrastructure
+ instead of adding a hack for Haiku.
+
+2010-04-21 Steve Block <steveblock@google.com>
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Replace Geolocation::suspend()/resume() which are required by Android.
+ https://bugs.webkit.org/show_bug.cgi?id=37942
+
+ These methods were removed in Bug 36255.
+
+ Build fix only, no new tests.
+
+ * page/Geolocation.cpp:
+ (WebCore::Geolocation::suspend):
+ (WebCore::Geolocation::resume):
+ * page/Geolocation.h:
+
+2010-04-21 Ray Rischpater <Raymond.Rischpater@Nokia.com>
+
+ In HTMLInputElement.cpp there are numerous style
+ violations.
+
+ This patch includes style changes to fix existing style
+ deviations in this file.
+
+ Rubber stamped by Darin Adler.
+
+ Fixes <https://bugs.webkit.org/show_bug.cgi?id=37881>
+
+ * html/HTMLInputElement.cpp:
+
+2010-04-21 Gustavo Sverzut Barbieri <barbieri@profusion.mobi>
+
+ Reviewed by Adam Roben.
+
+ Add missing EFL WebCore file.
+ http://webkit.org/b/37854
+
+ No behavior changes, so no new tests were added.
+
+ * bindings/js/ScriptControllerEfl.cpp: Added.
+ (WebCore::ScriptController::createScriptInstanceForWidget):
+
+2010-04-21 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Dan Bernstein.
+
+ Printing Core Animation-based plug-ins is broken
+ https://bugs.webkit.org/show_bug.cgi?id=37967
+
+ When we do a "flattening" paint because of printing, we need to stash
+ the flattening flag in the FrameView's m_paintBehavior, because
+ WebBaseNetscapePluginView needs to find it there to decide whether
+ to grab a bitmap for printing, for CA plug-ins.
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::paintContents):
+
+2010-04-21 François Sausset <sausset@gmail.com>
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Fix to take into account a change made in "StringImpl".
+ https://bugs.webkit.org/show_bug.cgi?id=37763
+
+ * mathml/RenderMathMLOperator.cpp:
+ (WebCore::RenderMathMLOperator::updateFromElement):
+
+2010-04-21 Andy Estes <aestes@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Create a template for creating reference-counted Windows GDI handles.
+ Refactor RefCountedHFONT to use this template.
+
+ https://bugs.webkit.org/show_bug.cgi?id=37952
+
+ No change in behavior.
+
+ * WebCore.vcproj/WebCore.vcproj: Add RefCountedHFONT.h
+ * platform/graphics/cairo/FontPlatformData.h:
+ (WebCore::FontPlatformData::hfont): Refactor to return m_hfont->handle() instead of m_hfont->hfont().
+ * platform/graphics/cg/FontPlatformData.h:
+ (WebCore::FontPlatformData::hfont): Same.
+ * platform/graphics/win/FontPlatformDataCGWin.cpp:
+ (WebCore::FontPlatformData::FontPlatformData): Instantiate m_hfont with a RefCountedGDIHandle<HFONT>.
+ * platform/graphics/win/FontPlatformDataWin.cpp:
+ (WebCore::FontPlatformData::FontPlatformData): Same.
+ * platform/graphics/win/RefCountedGDIHandle.h: Added. Interface is identical to RefCountedHFONT with exception of renaming hfont() to handle().
+ (WebCore::RefCountedGDIHandle::create):
+ (WebCore::RefCountedGDIHandle::createDeleted):
+ (WebCore::RefCountedGDIHandle::~RefCountedGDIHandle):
+ (WebCore::RefCountedGDIHandle::handle): Return the GDI handle.
+ (WebCore::RefCountedGDIHandle::hash):
+ (WebCore::RefCountedGDIHandle::RefCountedGDIHandle):
+ * platform/graphics/win/RefCountedHFONT.h: Removed.
+
+2010-04-21 Laszlo Gombos <laszlo.1.gombos@nokia.com>
+
+ Reviewed by Darin Adler.
+
+ Fix build if NPAPI support is disabled
+ https://bugs.webkit.org/show_bug.cgi?id=36621
+
+ No new tests, this is a build fix.
+ Re-submit r56585 with fix for Chromium.
+
+ * plugins/PluginView.cpp: Guard getValueStatic() with
+ NETSCAPE_PLUGIN_API
+ (WebCore::PluginView::getValue):
+ * plugins/PluginView.h: Guard getValue() with NETSCAPE_PLUGIN_API
+ * plugins/PluginViewNone.cpp: Guard platformGetValue() and
+ platformGetValueStatic with NETSCAPE_PLUGIN_API;
+ Guard privateBrowsingStateChanged() and setJavaScriptPaused() with
+ PLATFORM(MAC) or PLATFORM(CHROMIUM)
+
+2010-04-21 David Yonge-Mallo <davinci@chromium.org>
+
+ Reviewed by Dan Bernstein.
+
+ ZWNJ - Display non-printing, invisible character
+ https://bugs.webkit.org/show_bug.cgi?id=16131
+
+ Fix the (non)display of glyphs for ZWJ and ZWNJ in simple font code path.
+
+ Tests: fast/text/format-control.html
+ fast/text/zero-width-characters.html
+
+ * platform/graphics/Font.h:
+ (WebCore::Font::operator!=):
+ (WebCore::Font::treatAsZeroWidthSpace): treat ZWNJ and ZWJ as ZWSP.
+ * platform/graphics/GlyphPageTreeNode.cpp:
+ (WebCore::GlyphPageTreeNode::initializePage): added ZWNJ and ZWJ.
+ * platform/text/CharacterNames.h: added ZWNJ and ZWJ.
+
+2010-04-21 Charles Wei <charles.wei@torchmobile.com.cn>
+
+ Reviewed by George Staikos.
+
+ Fix webkit build problem when xhtmlmp enabled, which is introduced by revision 57927, for
+ bug fix of 37175 , which seperates DocumentWriter from FrameLoader
+ https://bugs.webkit.org/show_bug.cgi?id=37915
+
+ No new tests since this only fixes the build problem.
+
+ * dom/Document.cpp:
+ (WebCore::Document::isXHTMLMPDocument):
+
+2010-04-21 Shinichiro Hamaji <hamaji@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ Call sites of TextIterator constructor are difficult to read
+ https://bugs.webkit.org/show_bug.cgi?id=37909
+
+ Now we use enum parameters instead of boolean parameters and
+ boolean version of constructors are eliminated.
+
+ This change also changes the names of boolean members so they are
+ now third person singular.
+
+ No new tests because this is just a refactoring.
+
+ * WebCore.base.exp:
+ * editing/TextIterator.cpp:
+ (WebCore::TextIterator::TextIterator):
+ (WebCore::TextIterator::advance):
+ (WebCore::TextIterator::handleReplacedElement):
+ (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
+ (WebCore::TextIterator::shouldEmitSpaceBeforeAndAfterNode):
+ (WebCore::TextIterator::handleNonTextNode):
+ (WebCore::TextIterator::exitNode):
+ (WebCore::TextIterator::emitCharacter):
+ (WebCore::TextIterator::emitText):
+ (WebCore::CharacterIterator::CharacterIterator):
+ (WebCore::TextIterator::rangeLength):
+ (WebCore::TextIterator::rangeFromLocationAndLength):
+ (WebCore::findPlainText):
+ * editing/TextIterator.h:
+ (WebCore::):
+ * editing/VisibleSelection.cpp:
+ (WebCore::VisibleSelection::appendTrailingWhitespace):
+ * editing/visible_units.cpp:
+ (WebCore::nextBoundary):
+
+2010-04-21 Jesus Sanchez-Palencia <jesus@webkit.org>
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Add PageClientQt files.
+
+ [Qt] PageClientQt specific implementation for QWidget
+ https://bugs.webkit.org/show_bug.cgi?id=37858
+
+ * WebCore.pro:
+
+2010-04-21 Diego Escalante Urrelo <descalante@igalia.com>
+
+ Reviewed by Xan Lopez.
+
+ [Gtk] Evaluate and create tests for all the AtkRole's implemented by
+ WebKitGtk
+ https://bugs.webkit.org/show_bug.cgi?id=34449
+
+ Implement ATK_ROLE_SEPARATOR.
+
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
+ * accessibility/gtk/AccessibilityObjectAtk.cpp:
+ (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
+
+2010-04-21 David Leong <david.leong@nokia.com>
+
+ Reviewed by Simon Hausmann.
+
+ [Qt] Symbian apps crash on exit due to a bad qObject_cast.
+
+ https://bugs.webkit.org/show_bug.cgi?id=37303
+
+ Added check for NULL to avoid the crash. Reworked to fix memory leak
+
+ * plugins/symbian/PluginViewSymbian.cpp:
+ (WebCore::PluginView::platformDestroy):
+
2009-04-21 Chris Fleizach <cfleizach@apple.com>
Reviewed by Alexey Proskuryakov.
@@ -833,8 +8571,8 @@
declaration ( e.g. every "namespace WebCore { class String; }" much change to
"namespace WTF { class String; }").
- Moving the files, but leaving the classes logically in the WebCore namespace –
- which is technically a layering violation – I'll come back and fix this up in a
+ Moving the files, but leaving the classes logically in the WebCore namespace -
+ which is technically a layering violation - I'll come back and fix this up in a
subsequent patch.
* Android.mk:
@@ -29869,7 +37607,7 @@
https://bugs.webkit.org/show_bug.cgi?id=34728 addressed the symptoms of this
problem, and it is probably cleaner to make the client data's normal world no
longer be a member (since it is a ref-counted object), however they should be
- no requirement to 'detatch' – it makes no sense for anyone to be referencing
+ no requirement to 'detatch' - it makes no sense for anyone to be referencing
the world after the JSGlobalData has gone away (the world's purpose is to hold
wrapper objects in the JSGlobalData's heap). Keep the restructuring that makes
the normal world no longer be a member, but remove the detach mechanism this
@@ -35769,7 +43507,7 @@
https://bugs.webkit.org/show_bug.cgi?id=34335
* bindings/js/ScriptCallStack.cpp:
- (WebCore::ScriptCallStack::ScriptCallStack): If the caller is unknown, the line number and source information is still availble so pass it to the ScriptCallFrame being constructed.
+ (WebCore::ScriptCallStack::ScriptCallStack): If the caller is unknown, the line number and source information is still available so pass it to the ScriptCallFrame being constructed.
2010-02-01 Dirk Schulze <krit@webkit.org>