summaryrefslogtreecommitdiffstats
path: root/WebCore/bindings/v8
diff options
context:
space:
mode:
authorGrace Kloba <klobag@google.com>2010-05-26 16:24:10 -0700
committerGrace Kloba <klobag@google.com>2010-05-27 09:43:51 -0700
commita2ddcf62b5b53f477089aac4b07bb68aaab4d056 (patch)
tree0a47070416cf9cddea6c3f2a351cf44bfa3dfe25 /WebCore/bindings/v8
parent7b582e96e4e909ed7dba1e07153d20fbddaec3f7 (diff)
downloadexternal_webkit-a2ddcf62b5b53f477089aac4b07bb68aaab4d056.zip
external_webkit-a2ddcf62b5b53f477089aac4b07bb68aaab4d056.tar.gz
external_webkit-a2ddcf62b5b53f477089aac4b07bb68aaab4d056.tar.bz2
Fix popup window default size.
The change has been submitted to WebKit. https://bugs.webkit.org/show_bug.cgi?id=39835
Diffstat (limited to 'WebCore/bindings/v8')
-rw-r--r--WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp10
1 files changed, 9 insertions, 1 deletions
diff --git a/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp b/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp
index de4fcbf..921d756 100644
--- a/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp
+++ b/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp
@@ -686,7 +686,7 @@ v8::Handle<v8::Value> V8DOMWindow::openCallback(const v8::Arguments& args)
windowFeatures.height = windowRect.height();
windowFeatures.width = windowRect.width();
- // If either of the origin coordinates weren't set in the original
+ // If either of the origin coordinates or dimensions weren't set in the original
// string, make sure they aren't set now.
if (!rawFeatures.xSet) {
windowFeatures.x = 0;
@@ -696,6 +696,14 @@ v8::Handle<v8::Value> V8DOMWindow::openCallback(const v8::Arguments& args)
windowFeatures.y = 0;
windowFeatures.ySet = false;
}
+ if (!rawFeatures.widthSet) {
+ windowFeatures.width = 0;
+ windowFeatures.widthSet = false;
+ }
+ if (!rawFeatures.heightSet) {
+ windowFeatures.height = 0;
+ windowFeatures.heightSet = false;
+ }
frame = V8BindingDOMWindow::createWindow(V8BindingState::Only(), callingFrame, enteredFrame, frame, urlString, frameName, windowFeatures, v8::Local<v8::Value>());