summaryrefslogtreecommitdiffstats
path: root/WebCore/page/Geolocation.cpp
diff options
context:
space:
mode:
authorSteve Block <steveblock@google.com>2009-07-24 13:59:28 +0100
committerSteve Block <steveblock@google.com>2009-07-24 15:47:30 +0100
commit75505f2fc5827c662d9bb0a0a8b90219c23e7e85 (patch)
tree9e4a274651aa9702fb5433cb692350319fc1fe16 /WebCore/page/Geolocation.cpp
parent30a03ae510e4341d0ad55d27ff9a4f818dcd16cb (diff)
downloadexternal_webkit-75505f2fc5827c662d9bb0a0a8b90219c23e7e85.zip
external_webkit-75505f2fc5827c662d9bb0a0a8b90219c23e7e85.tar.gz
external_webkit-75505f2fc5827c662d9bb0a0a8b90219c23e7e85.tar.bz2
Fixes WebKit Geolocation bug 27255.
We should not call the error callback if the success callback raises an exception. This is currently being submitted to WebKit as bug 27255.
Diffstat (limited to 'WebCore/page/Geolocation.cpp')
-rw-r--r--WebCore/page/Geolocation.cpp14
1 files changed, 2 insertions, 12 deletions
diff --git a/WebCore/page/Geolocation.cpp b/WebCore/page/Geolocation.cpp
index 8abe8a6..8df6990 100644
--- a/WebCore/page/Geolocation.cpp
+++ b/WebCore/page/Geolocation.cpp
@@ -182,12 +182,7 @@ void Geolocation::sendPositionToOneShots(Geoposition* position)
ASSERT(notifier->m_successCallback);
notifier->m_timer.stop();
- bool shouldCallErrorCallback = false;
- notifier->m_successCallback->handleEvent(position, shouldCallErrorCallback);
- if (shouldCallErrorCallback) {
- RefPtr<PositionError> error = PositionError::create(PositionError::UNKNOWN_ERROR, "An exception was thrown");
- handleError(error.get());
- }
+ notifier->m_successCallback->handleEvent(position);
}
}
@@ -202,12 +197,7 @@ void Geolocation::sendPositionToWatchers(Geoposition* position)
ASSERT(notifier->m_successCallback);
notifier->m_timer.stop();
- bool shouldCallErrorCallback = false;
- notifier->m_successCallback->handleEvent(position, shouldCallErrorCallback);
- if (shouldCallErrorCallback) {
- RefPtr<PositionError> error = PositionError::create(PositionError::UNKNOWN_ERROR, "An exception was thrown");
- handleError(error.get());
- }
+ notifier->m_successCallback->handleEvent(position);
}
}