diff options
| author | Steve Block <steveblock@google.com> | 2009-12-16 12:57:38 +0000 |
|---|---|---|
| committer | Steve Block <steveblock@google.com> | 2009-12-17 18:00:54 +0000 |
| commit | c7d0c5294bbef1855c84c8072058813371f1af16 (patch) | |
| tree | e8ebb02bd67423d5caede10b77af130c9c3a848f /WebCore/platform/android/GeolocationServiceAndroid.cpp | |
| parent | 7a747c0b98a39b08f04bfbf16595228a6c841541 (diff) | |
| download | external_webkit-c7d0c5294bbef1855c84c8072058813371f1af16.zip external_webkit-c7d0c5294bbef1855c84c8072058813371f1af16.tar.gz external_webkit-c7d0c5294bbef1855c84c8072058813371f1af16.tar.bz2 | |
Fixes a Geolocation bug with cached positions.
In the case where a watch request returns a cached position, we must clear the cached position to prevent it from being used repeatedly in the case where the watch timer later fires.
Also cleans up some code and adds some comments.
This will be upstreamed to webkit.org in https://bugs.webkit.org/show_bug.cgi?id=30676
Change-Id: I4968731453c3dfd34a8d3466fdaee91d4c4158be
Diffstat (limited to 'WebCore/platform/android/GeolocationServiceAndroid.cpp')
| -rw-r--r-- | WebCore/platform/android/GeolocationServiceAndroid.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/WebCore/platform/android/GeolocationServiceAndroid.cpp b/WebCore/platform/android/GeolocationServiceAndroid.cpp index d44b3f0..43a8f5f 100644 --- a/WebCore/platform/android/GeolocationServiceAndroid.cpp +++ b/WebCore/platform/android/GeolocationServiceAndroid.cpp @@ -92,7 +92,7 @@ bool GeolocationServiceAndroid::startUpdating(PositionOptions* options) void GeolocationServiceAndroid::stopUpdating() { // Called when the Geolocation object has no watches or one shots in - // progress. + // progress. This may be called repeatedly. m_javaBridge.clear(); // Reset last position and error to make sure that we always try to get a // new position from the system service when a request is first made. |