diff options
| author | Russell Brenner <russellbrenner@google.com> | 2011-03-23 14:36:13 -0700 |
|---|---|---|
| committer | Russell Brenner <russellbrenner@google.com> | 2011-03-23 17:06:37 -0700 |
| commit | dd816e39169b0fd3390257c1b43fb96f9b87577b (patch) | |
| tree | 12177a604612f591eeb8da34364c5a0cc14576de /WebCore/wml/WMLDoElement.cpp | |
| parent | 9ae96f817b1e51451a4e20bb1a1ceb225ba2d9e5 (diff) | |
| download | external_webkit-dd816e39169b0fd3390257c1b43fb96f9b87577b.zip external_webkit-dd816e39169b0fd3390257c1b43fb96f9b87577b.tar.gz external_webkit-dd816e39169b0fd3390257c1b43fb96f9b87577b.tar.bz2 | |
Add defensive code for crash in FontPlatformData
bug: 4163318
In FontPlatformData, both 0 and -1 are used as special values for
mTypeface. Skia has checks to handle null typefaces, but -1 is a
special value (hashTableDeletedFontValue) unique to FontPlatformData.
The constructors and operators appear to have the necessary guards,
but setupPaint(), uniqueID(), and isFixedPitch() needed some touchup
to better handle 0 or -1.
There's still the question of whether or not it's appropriate to be
calling any of those functions with the typeface set to 0 or -1, so
these changes may simply be deflecting the underlying problem, but
these changes should guard against the immediate failure.
Change-Id: Ib68a64ba6d4eeffbd502f29b68074e38c511a746
Diffstat (limited to 'WebCore/wml/WMLDoElement.cpp')
0 files changed, 0 insertions, 0 deletions