Refactor AutoFill so it runs lazily.

This CL refactors the AutoFill code so that we only search for forms
when we need to, i.e. the user has focused a form field. This helps
page load times. We also re-search the document for forms if the dom
version number has changed. These changes fix a bug where a crash
occurs if the form is focused before the page has finished loading.

We also move the callsite of formFieldFocused so that it only occurs
when the IME is requested which is a more appropriate place called less
frequently than it's current callsite in EditorClientAndroid.

Bug: 3243567
Change-Id: I04fe13944d3f8248197d71a0e58c21f01c4abdd0

1 files changed, 2 insertions, 8 deletions

diff --git a/WebKit/android/jni/WebSettings.cpp b/WebKit/android/jni/WebSettings.cpp
index 75f42b3..dc3723d 100644
--- a/WebKit/android/jni/WebSettings.cpp
+++ b/WebKit/android/jni/WebSettings.cpp
@@ -504,17 +504,11 @@ public:
         // (see chrome/browser/autofill/autofill_manager.cc:405). This
         // setting should probably be synced into Chromium also.
 
-        // If we toggle from disabled to enabled, then re search the document
-        // for forms.
-        bool oldAutoFillSetting = s->autoFillEnabled();
         s->setAutoFillEnabled(flag);
 
-        EditorClientAndroid* editorC = static_cast<EditorClientAndroid*>(pFrame->page()->editorClient());
-        WebAutoFill* webAutoFill = editorC->getAutoFill();
-        if (!oldAutoFillSetting && flag)
-            webAutoFill->searchDocument(pFrame);
-
         if (flag) {
+            EditorClientAndroid* editorC = static_cast<EditorClientAndroid*>(pFrame->page()->editorClient());
+            WebAutoFill* webAutoFill = editorC->getAutoFill();
             // Set the active AutoFillProfile data.
             jobject autoFillProfile = env->GetObjectField(obj, gFieldIds->mAutoFillProfile);
             if (autoFillProfile)