diff options
author | Cary Clark <cary@android.com> | 2010-11-11 10:14:14 -0500 |
---|---|---|
committer | Cary Clark <cary@android.com> | 2010-11-11 13:00:17 -0500 |
commit | 2b36633c8e1183d3b024dea63d958eaff71bdc64 (patch) | |
tree | 47056c594121600289392f2951ccac4ed600aad1 /WebKit/android/nav/SelectText.h | |
parent | 5d93c28b5a1fcbe16e88da9bc1260a75054f7992 (diff) | |
download | external_webkit-2b36633c8e1183d3b024dea63d958eaff71bdc64.zip external_webkit-2b36633c8e1183d3b024dea63d958eaff71bdc64.tar.gz external_webkit-2b36633c8e1183d3b024dea63d958eaff71bdc64.tar.bz2 |
use layer id to maintain selection
The pictures used to draw the page content can change
in response to refreshes, as the selection is moved or
as the screen is scrolled or zoomed.
Track the layer id, instead of the picture pointer,
to find the picture that contains the current selection.
Before, the selection would disappear as the screen
was pinched, or the highlight might disappear even
though the anchors draw, or the highlight and anchors
might be drawn offset from the screen data. This change
eliminates this class of bugs.
Change-Id: Ifc440b8aa0c9d6d232e298e42c4c544a41629442
http://b/3183492
Diffstat (limited to 'WebKit/android/nav/SelectText.h')
-rw-r--r-- | WebKit/android/nav/SelectText.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/WebKit/android/nav/SelectText.h b/WebKit/android/nav/SelectText.h index d210117..8247356 100644 --- a/WebKit/android/nav/SelectText.h +++ b/WebKit/android/nav/SelectText.h @@ -73,6 +73,7 @@ private: SkIRect m_selEnd; int m_startBase; int m_endBase; + int m_layerId; SkIRect m_visibleRect; // constrains picture computations to visible area SkRegion m_selRegion; // computed from sel start, end SkPicture m_startControl; |