diff options
author | John Reck <jreck@google.com> | 2010-11-04 12:00:17 -0700 |
---|---|---|
committer | John Reck <jreck@google.com> | 2010-11-09 11:35:04 -0800 |
commit | e14391e94c850b8bd03680c23b38978db68687a8 (patch) | |
tree | 3fed87e6620fecaf3edc7259ae58a11662bedcb2 /WebKit/win | |
parent | 1bd705833a68f07850cf7e204b26f8d328d16951 (diff) | |
download | external_webkit-e14391e94c850b8bd03680c23b38978db68687a8.zip external_webkit-e14391e94c850b8bd03680c23b38978db68687a8.tar.gz external_webkit-e14391e94c850b8bd03680c23b38978db68687a8.tar.bz2 |
Merge Webkit at r70949: Initial merge by git.
Change-Id: I77b8645c083b5d0da8dba73ed01d4014aab9848e
Diffstat (limited to 'WebKit/win')
-rw-r--r-- | WebKit/win/ChangeLog | 148 | ||||
-rwxr-xr-x | WebKit/win/Interfaces/IWebFramePrivate.idl | 2 | ||||
-rw-r--r-- | WebKit/win/Interfaces/IWebView.idl | 1 | ||||
-rw-r--r-- | WebKit/win/Interfaces/WebKit.idl | 3 | ||||
-rw-r--r-- | WebKit/win/WebBackForwardList.cpp | 12 | ||||
-rw-r--r-- | WebKit/win/WebBackForwardList.h | 8 | ||||
-rw-r--r-- | WebKit/win/WebCookieManagerCFNet.cpp | 2 | ||||
-rw-r--r-- | WebKit/win/WebCoreSupport/WebChromeClient.cpp | 13 | ||||
-rw-r--r-- | WebKit/win/WebCoreSupport/WebChromeClient.h | 2 | ||||
-rw-r--r-- | WebKit/win/WebCoreSupport/WebContextMenuClient.cpp | 2 | ||||
-rw-r--r-- | WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp | 15 | ||||
-rw-r--r-- | WebKit/win/WebCoreSupport/WebFrameLoaderClient.h | 5 | ||||
-rw-r--r-- | WebKit/win/WebElementPropertyBag.cpp | 5 | ||||
-rw-r--r-- | WebKit/win/WebFrame.cpp | 17 | ||||
-rw-r--r-- | WebKit/win/WebFrame.h | 6 | ||||
-rw-r--r-- | WebKit/win/WebKitPrefix.h | 2 | ||||
-rw-r--r-- | WebKit/win/WebView.cpp | 11 | ||||
-rw-r--r-- | WebKit/win/WebView.h | 7 |
18 files changed, 229 insertions, 32 deletions
diff --git a/WebKit/win/ChangeLog b/WebKit/win/ChangeLog index 0f4c32c..fb8f19e 100644 --- a/WebKit/win/ChangeLog +++ b/WebKit/win/ChangeLog @@ -1,3 +1,151 @@ +2010-10-29 Darin Adler <darin@apple.com> + + Reviewed by Sam Weinig. + + Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring + https://bugs.webkit.org/show_bug.cgi?id=48574 + + * WebBackForwardList.cpp: + (backForwardListWrappers): + (WebBackForwardList::WebBackForwardList): + (WebBackForwardList::createInstance): + * WebBackForwardList.h: + * WebView.cpp: + (WebView::backForwardList): + Use BackForwardListImpl. + +2010-10-29 Adam Roben <aroben@apple.com> + + Windows build fix + + * WebKitPrefix.h: Touched to force a rebuild. + +2010-10-29 Alexey Proskuryakov <ap@apple.com> + + Reviewed by Darin Adler. + + https://bugs.webkit.org/show_bug.cgi?id=48576 + Let WebKit2 client know when a frame is a frameset + + Added a blank implementation of the new FrameLoaderClient method. + + * WebCoreSupport/WebFrameLoaderClient.h: + * WebCoreSupport/WebFrameLoaderClient.cpp: + (WebFrameLoaderClient::dispatchDidBecomeFrameset): + +2010-10-26 Brent Fulgham <bfulgham@webkit.org> + + Unreviewed build fix. + + * WebView.cpp: Conditionalize includes for CFNetwork-specific + Cookie implementation. + * WebView.h: Conditionalize includes for ACCELERATED_COMPOSITION. + WinCairo doesn't use CoreAnimation. + +2010-10-26 Jenn Braithwaite <jennb@chromium.org> + + Reviewed by Dmitry Titov. + + Resource tracking failure when trying to move a frame between documents + https://bugs.webkit.org/show_bug.cgi?id=44713 + + * WebCoreSupport/WebFrameLoaderClient.cpp: + (WebFrameLoaderClient::transferLoadingResourceFromPage): + Empty method. + * WebCoreSupport/WebFrameLoaderClient.h: + +2010-10-25 Patrick Gansterer <paroga@webkit.org> + + Reviewed by David Kilzer. + + Replace _countof with WTF_ARRAY_LENGTH + https://bugs.webkit.org/show_bug.cgi?id=48229 + + * WebCoreSupport/WebContextMenuClient.cpp: + (isPreInspectElementTagSafari): + * WebView.cpp: + (WebView::interpretKeyEvent): + +2010-10-24 Dan Bernstein <mitz@apple.com> + + Build fix. + + * Interfaces/WebKit.idl: Touched. + +2010-10-24 Dan Bernstein <mitz@apple.com> + + Reviewed by Anders Carlsson. + + Expose HitTestResult::absoluteMediaURL() via WebKit API + https://bugs.webkit.org/show_bug.cgi?id=48219 + + * Interfaces/IWebView.idl: Added WebElementMediaURLKey. + * WebElementPropertyBag.cpp: + (WebElementPropertyBag::Read): Map WebElementMediaURLKey to absoluteMediaURL(). + +2010-10-22 Andy Estes <aestes@apple.com> + + Fix the Windows build. + + * WebCookieManagerCFNet.cpp: Rename CookieStorageWin.h to CookieStorageCFNet.h. + * WebView.cpp: Ditto. + +2010-10-22 Jenn Braithwaite <jennb@chromium.org> + + Reviewed by Adam Roben. + + Windows client needs updating when live iframe element is moved between pages + https://bugs.webkit.org/show_bug.cgi?id=46915 + + * WebCoreSupport/WebFrameLoaderClient.cpp: + (WebFrameLoaderClient::didTransferChildFrameToNewDocument): + Update WebView in WebFrame to match that of the current page. + * WebFrame.cpp: + (WebFrame::setWebView): + Added. + * WebFrame.h: + +2010-10-22 Sam Weinig <sam@webkit.org> + + Fix windows build. + + * WebCoreSupport/WebChromeClient.h: + +2010-10-22 Sam Weinig <sam@webkit.org> + + Reviewed by Anders Carlsson. + + WebKit2 needs to pass the current event modifier flags when requesting a new window + https://bugs.webkit.org/show_bug.cgi?id=48140 + + * WebCoreSupport/WebChromeClient.cpp: + (WebChromeClient::createWindow): + * WebCoreSupport/WebFrameLoaderClient.cpp: + (WebFrameLoaderClient::dispatchCreatePage): + * WebCoreSupport/WebFrameLoaderClient.h: + Add NavigationAction parameter. + +2010-10-21 MORITA Hajime <morrita@google.com> + + Unreviewed, touched it to fix the build. + + * Interfaces/WebKit.idl: + +2010-10-21 MORITA Hajime <morrita@google.com> + + Reviewed by Kent Tamura. + + [Win][DRT] should have LayoutTestController.hasSpellingMarker() + https://bugs.webkit.org/show_bug.cgi?id=47885 + + Added IWebFramePrivate::hasSpellingMarker() and impelmented it for + LayoutTestController. + + * Interfaces/IWebFramePrivate.idl: + * WebFrame.cpp: + (WebFrame::hasSpellingMarker): + * WebFrame.h: + 2010-10-20 Dumitru Daniliuc <dumi@chromium.org> Reviewed by David Levin. diff --git a/WebKit/win/Interfaces/IWebFramePrivate.idl b/WebKit/win/Interfaces/IWebFramePrivate.idl index 190681c..279cbbf 100755 --- a/WebKit/win/Interfaces/IWebFramePrivate.idl +++ b/WebKit/win/Interfaces/IWebFramePrivate.idl @@ -117,4 +117,6 @@ interface IWebFramePrivate : IUnknown HRESULT resumeAnimations(); HRESULT loadPlainTextString([in] BSTR string, [in] BSTR url); + + HRESULT hasSpellingMarker([in] UINT from, [in] UINT length, [out, retval] BOOL* result); } diff --git a/WebKit/win/Interfaces/IWebView.idl b/WebKit/win/Interfaces/IWebView.idl index e3ec98a..6c414f8 100644 --- a/WebKit/win/Interfaces/IWebView.idl +++ b/WebKit/win/Interfaces/IWebView.idl @@ -82,6 +82,7 @@ const LPCOLESTR WebElementImageKey = L"WebElementImageKey"; const LPCOLESTR WebElementImageRectKey = L"WebElementImageRectKey"; const LPCOLESTR WebElementImageURLKey = L"WebElementImageURLKey"; const LPCOLESTR WebElementIsSelectedKey = L"WebElementIsSelectedKey"; +const LPCOLESTR WebElementMediaURLKey = L"WebElementMediaURLKey"; const LPCOLESTR WebElementSpellingToolTipKey = L"WebElementSpellingToolTipKey"; const LPCOLESTR WebElementTitleKey = L"WebElementTitleKey"; const LPCOLESTR WebElementLinkURLKey = L"WebElementLinkURLKey"; diff --git a/WebKit/win/Interfaces/WebKit.idl b/WebKit/win/Interfaces/WebKit.idl index 470b052..e936af6 100644 --- a/WebKit/win/Interfaces/WebKit.idl +++ b/WebKit/win/Interfaces/WebKit.idl @@ -22,7 +22,7 @@ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ - + cpp_quote("/*") cpp_quote(" * Copyright (C) 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.") cpp_quote(" *") @@ -300,4 +300,3 @@ library WebKit [default] interface IWebUserContentURLPattern; } } - diff --git a/WebKit/win/WebBackForwardList.cpp b/WebKit/win/WebBackForwardList.cpp index e8c2930..2faaf7e 100644 --- a/WebKit/win/WebBackForwardList.cpp +++ b/WebKit/win/WebBackForwardList.cpp @@ -32,7 +32,7 @@ #include "WebKit.h" #include "WebPreferences.h" -#include <WebCore/BackForwardList.h> +#include <WebCore/BackForwardListImpl.h> #include <WebCore/HistoryItem.h> using std::min; @@ -40,13 +40,15 @@ using namespace WebCore; // WebBackForwardList ---------------------------------------------------------------- -static HashMap<BackForwardList*, WebBackForwardList*>& backForwardListWrappers() +// FIXME: Instead of this we could just create a class derived from BackForwardListImpl +// with a pointer to a WebBackForwardList in it. +static HashMap<BackForwardListImpl*, WebBackForwardList*>& backForwardListWrappers() { - static HashMap<BackForwardList*, WebBackForwardList*> staticBackForwardListWrappers; + static HashMap<BackForwardListImpl*, WebBackForwardList*> staticBackForwardListWrappers; return staticBackForwardListWrappers; } -WebBackForwardList::WebBackForwardList(PassRefPtr<BackForwardList> backForwardList) +WebBackForwardList::WebBackForwardList(PassRefPtr<BackForwardListImpl> backForwardList) : m_refCount(0) , m_backForwardList(backForwardList) { @@ -68,7 +70,7 @@ WebBackForwardList::~WebBackForwardList() gClassNameCount.remove("WebBackForwardList"); } -WebBackForwardList* WebBackForwardList::createInstance(PassRefPtr<BackForwardList> backForwardList) +WebBackForwardList* WebBackForwardList::createInstance(PassRefPtr<BackForwardListImpl> backForwardList) { WebBackForwardList* instance; diff --git a/WebKit/win/WebBackForwardList.h b/WebKit/win/WebBackForwardList.h index 9375193..aebfa15 100644 --- a/WebKit/win/WebBackForwardList.h +++ b/WebKit/win/WebBackForwardList.h @@ -34,15 +34,15 @@ #include <WTF/RefPtr.h> namespace WebCore { - class BackForwardList; + class BackForwardListImpl; } class WebBackForwardList : public IWebBackForwardList, IWebBackForwardListPrivate { public: - static WebBackForwardList* createInstance(PassRefPtr<WebCore::BackForwardList>); + static WebBackForwardList* createInstance(PassRefPtr<WebCore::BackForwardListImpl>); protected: - WebBackForwardList(PassRefPtr<WebCore::BackForwardList>); + WebBackForwardList(PassRefPtr<WebCore::BackForwardListImpl>); ~WebBackForwardList(); public: @@ -109,7 +109,7 @@ public: protected: ULONG m_refCount; - RefPtr<WebCore::BackForwardList> m_backForwardList; + RefPtr<WebCore::BackForwardListImpl> m_backForwardList; }; #endif diff --git a/WebKit/win/WebCookieManagerCFNet.cpp b/WebKit/win/WebCookieManagerCFNet.cpp index 415a679..c2ef493 100644 --- a/WebKit/win/WebCookieManagerCFNet.cpp +++ b/WebKit/win/WebCookieManagerCFNet.cpp @@ -28,7 +28,7 @@ #include "WebCookieManager.h" #include <CFNetwork/CFHTTPCookiesPriv.h> -#include <WebCore/CookieStorageWin.h> +#include <WebCore/CookieStorageCFNet.h> using namespace WebCore; diff --git a/WebKit/win/WebCoreSupport/WebChromeClient.cpp b/WebKit/win/WebCoreSupport/WebChromeClient.cpp index 7a025a7..b1332ed 100644 --- a/WebKit/win/WebCoreSupport/WebChromeClient.cpp +++ b/WebKit/win/WebCoreSupport/WebChromeClient.cpp @@ -38,7 +38,6 @@ #include "WebDesktopNotificationsDelegate.h" #include "WebSecurityOrigin.h" #include "WebView.h" -#pragma warning(push, 0) #include <WebCore/BString.h> #include <WebCore/Console.h> #include <WebCore/ContextMenu.h> @@ -48,23 +47,23 @@ #include <WebCore/FrameLoadRequest.h> #include <WebCore/FrameView.h> #include <WebCore/Geolocation.h> -#if USE(ACCELERATED_COMPOSITING) -#include <WebCore/GraphicsLayer.h> -#endif #include <WebCore/HTMLNames.h> #include <WebCore/Icon.h> #include <WebCore/LocalWindowsContext.h> #include <WebCore/LocalizedStrings.h> +#include <WebCore/NavigationAction.h> #include <WebCore/NotImplemented.h> #include <WebCore/Page.h> #include <WebCore/SecurityOrigin.h> #include <WebCore/PopupMenuWin.h> #include <WebCore/SearchPopupMenuWin.h> #include <WebCore/WindowFeatures.h> -#pragma warning(pop) - #include <tchar.h> +#if USE(ACCELERATED_COMPOSITING) +#include <WebCore/GraphicsLayer.h> +#endif + using namespace WebCore; // When you call GetOpenFileName, if the size of the buffer is too small, @@ -195,7 +194,7 @@ static COMPtr<IPropertyBag> createWindowFeaturesPropertyBag(const WindowFeatures return COMPtr<IPropertyBag>(AdoptCOM, COMPropertyBag<COMVariant>::adopt(map)); } -Page* WebChromeClient::createWindow(Frame*, const FrameLoadRequest& frameLoadRequest, const WindowFeatures& features) +Page* WebChromeClient::createWindow(Frame*, const FrameLoadRequest& frameLoadRequest, const WindowFeatures& features, const NavigationAction&) { COMPtr<IWebUIDelegate> delegate = uiDelegate(); if (!delegate) diff --git a/WebKit/win/WebCoreSupport/WebChromeClient.h b/WebKit/win/WebCoreSupport/WebChromeClient.h index 5a796eb..5167c06 100644 --- a/WebKit/win/WebCoreSupport/WebChromeClient.h +++ b/WebKit/win/WebCoreSupport/WebChromeClient.h @@ -58,7 +58,7 @@ public: virtual void focusedNodeChanged(WebCore::Node*); - virtual WebCore::Page* createWindow(WebCore::Frame*, const WebCore::FrameLoadRequest&, const WebCore::WindowFeatures&); + virtual WebCore::Page* createWindow(WebCore::Frame*, const WebCore::FrameLoadRequest&, const WebCore::WindowFeatures&, const WebCore::NavigationAction&); virtual void show(); virtual bool canRunModal(); diff --git a/WebKit/win/WebCoreSupport/WebContextMenuClient.cpp b/WebKit/win/WebCoreSupport/WebContextMenuClient.cpp index ab1f79e..24178f2 100644 --- a/WebKit/win/WebCoreSupport/WebContextMenuClient.cpp +++ b/WebKit/win/WebCoreSupport/WebContextMenuClient.cpp @@ -60,7 +60,7 @@ static bool isPreInspectElementTagSafari(IWebUIDelegate* uiDelegate) return false; TCHAR modulePath[MAX_PATH]; - DWORD length = ::GetModuleFileName(0, modulePath, _countof(modulePath)); + DWORD length = ::GetModuleFileName(0, modulePath, WTF_ARRAY_LENGTH(modulePath)); if (!length) return false; diff --git a/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp b/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp index ffc41b2..6591347 100644 --- a/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp +++ b/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp @@ -426,7 +426,7 @@ void WebFrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout() frameLoadDelegatePrivate->didFirstVisuallyNonEmptyLayoutInFrame(webView, m_webFrame); } -Frame* WebFrameLoaderClient::dispatchCreatePage() +Frame* WebFrameLoaderClient::dispatchCreatePage(const NavigationAction&) { WebView* webView = m_webFrame->webView(); @@ -714,6 +714,10 @@ void WebFrameLoaderClient::transitionToCommittedForNewPage() core(m_webFrame)->createView(IntRect(rect).size(), backgroundColor, transparent, IntSize(), false); } +void WebFrameLoaderClient::dispatchDidBecomeFrameset(bool) +{ +} + bool WebFrameLoaderClient::canCachePage() const { return true; @@ -730,6 +734,15 @@ PassRefPtr<Frame> WebFrameLoaderClient::createFrame(const KURL& url, const Strin void WebFrameLoaderClient::didTransferChildFrameToNewDocument(Page*) { + Frame* coreFrame = core(m_webFrame); + ASSERT(coreFrame); + WebView* webView = kit(coreFrame->page()); + if (m_webFrame->webView() != webView) + m_webFrame->setWebView(webView); +} + +void WebFrameLoaderClient::transferLoadingResourceFromPage(unsigned long, DocumentLoader*, const ResourceRequest&, Page*) +{ } PassRefPtr<Frame> WebFrameLoaderClient::createFrame(const KURL& URL, const String& name, HTMLFrameOwnerElement* ownerElement, const String& referrer) diff --git a/WebKit/win/WebCoreSupport/WebFrameLoaderClient.h b/WebKit/win/WebCoreSupport/WebFrameLoaderClient.h index 7ec344c..981daec 100644 --- a/WebKit/win/WebCoreSupport/WebFrameLoaderClient.h +++ b/WebKit/win/WebCoreSupport/WebFrameLoaderClient.h @@ -78,7 +78,7 @@ public: virtual void dispatchDidFirstLayout(); virtual void dispatchDidFirstVisuallyNonEmptyLayout(); - virtual WebCore::Frame* dispatchCreatePage(); + virtual WebCore::Frame* dispatchCreatePage(const WebCore::NavigationAction&); virtual void dispatchShow(); virtual void dispatchDidLoadMainResource(WebCore::DocumentLoader*); @@ -108,11 +108,14 @@ public: virtual void transitionToCommittedFromCachedFrame(WebCore::CachedFrame*); virtual void transitionToCommittedForNewPage(); + virtual void dispatchDidBecomeFrameset(bool); + virtual bool canCachePage() const; virtual PassRefPtr<WebCore::Frame> createFrame(const WebCore::KURL& url, const WTF::String& name, WebCore::HTMLFrameOwnerElement* ownerElement, const WTF::String& referrer, bool allowsScrolling, int marginWidth, int marginHeight); virtual void didTransferChildFrameToNewDocument(WebCore::Page*); + virtual void transferLoadingResourceFromPage(unsigned long, WebCore::DocumentLoader*, const WebCore::ResourceRequest&, WebCore::Page*); virtual PassRefPtr<WebCore::Widget> createPlugin(const WebCore::IntSize&, WebCore::HTMLPlugInElement*, const WebCore::KURL&, const Vector<WTF::String>&, const Vector<WTF::String>&, const WTF::String&, bool loadManually); virtual void redirectDataToPlugin(WebCore::Widget* pluginWidget); diff --git a/WebKit/win/WebElementPropertyBag.cpp b/WebKit/win/WebElementPropertyBag.cpp index e68b92e..e68360c 100644 --- a/WebKit/win/WebElementPropertyBag.cpp +++ b/WebKit/win/WebElementPropertyBag.cpp @@ -159,7 +159,10 @@ HRESULT STDMETHODCALLTYPE WebElementPropertyBag::Read(LPCOLESTR pszPropName, VAR else V_BOOL(pVar) = VARIANT_FALSE; return S_OK; - } else if (isEqual(WebElementSpellingToolTipKey, key)) { + } + if (isEqual(WebElementMediaURLKey, key)) + return convertStringToVariant(pVar, m_result->absoluteMediaURL().string()); + if (isEqual(WebElementSpellingToolTipKey, key)) { TextDirection dir; return convertStringToVariant(pVar, m_result->spellingToolTip(dir)); } else if (isEqual(WebElementTitleKey, key)) { diff --git a/WebKit/win/WebFrame.cpp b/WebKit/win/WebFrame.cpp index 8dfe8bb..9db6a2a 100644 --- a/WebKit/win/WebFrame.cpp +++ b/WebKit/win/WebFrame.cpp @@ -1019,6 +1019,18 @@ HRESULT STDMETHODCALLTYPE WebFrame::unused2() return E_NOTIMPL; } +HRESULT STDMETHODCALLTYPE WebFrame::hasSpellingMarker( + /* [in] */ UINT from, + /* [in] */ UINT length, + /* [retval][out] */ BOOL* result) +{ + Frame* coreFrame = core(this); + if (!coreFrame) + return E_FAIL; + *result = coreFrame->editor()->selectionStartHasSpellingMarkerFor(from, length); + return S_OK; +} + // IWebDocumentText ----------------------------------------------------------- HRESULT STDMETHODCALLTYPE WebFrame::supportsTextEncoding( @@ -2574,6 +2586,11 @@ WebView* WebFrame::webView() const return d->webView; } +void WebFrame::setWebView(WebView* webView) +{ + d->webView = webView; +} + COMPtr<IAccessible> WebFrame::accessible() const { Frame* coreFrame = core(this); diff --git a/WebKit/win/WebFrame.h b/WebKit/win/WebFrame.h index 147daa8..bdc28ab 100644 --- a/WebKit/win/WebFrame.h +++ b/WebKit/win/WebFrame.h @@ -273,6 +273,11 @@ public: virtual HRESULT STDMETHODCALLTYPE layerTreeAsText(BSTR*); + virtual HRESULT STDMETHODCALLTYPE hasSpellingMarker( + /* [in] */ UINT from, + /* [in] */ UINT length, + /* [retval][out] */ BOOL *result); + // IWebDocumentText virtual HRESULT STDMETHODCALLTYPE supportsTextEncoding( /* [retval][out] */ BOOL* result); @@ -371,6 +376,7 @@ public: WebCore::KURL url() const; WebView* webView() const; + void setWebView(WebView*); COMPtr<IAccessible> accessible() const; diff --git a/WebKit/win/WebKitPrefix.h b/WebKit/win/WebKitPrefix.h index 9b2fc85..5c2001f 100644 --- a/WebKit/win/WebKitPrefix.h +++ b/WebKit/win/WebKitPrefix.h @@ -34,7 +34,7 @@ #define WINVER 0x0500 #endif -// If we don't define these, they get defined in windef.h. +// If we don't define these, they get defined in windef.h. // We want to use std::min and std::max. #ifndef max #define max max diff --git a/WebKit/win/WebView.cpp b/WebKit/win/WebView.cpp index b57e06a..fb62809 100644 --- a/WebKit/win/WebView.cpp +++ b/WebKit/win/WebView.cpp @@ -67,13 +67,12 @@ #include <WebCore/AXObjectCache.h> #include <WebCore/ApplicationCacheStorage.h> #include <WebCore/BString.h> -#include <WebCore/BackForwardList.h> +#include <WebCore/BackForwardListImpl.h> #include <WebCore/BitmapInfo.h> #include <WebCore/Cache.h> #include <WebCore/Chrome.h> #include <WebCore/ContextMenu.h> #include <WebCore/ContextMenuController.h> -#include <WebCore/CookieStorageWin.h> #include <WebCore/Cursor.h> #include <WebCore/Document.h> #include <WebCore/DragController.h> @@ -148,6 +147,7 @@ #if USE(CFNETWORK) #include <CFNetwork/CFURLCachePriv.h> #include <CFNetwork/CFURLProtocolPriv.h> +#include <WebCore/CookieStorageCFNet.h> #include <WebKitSystemInterface/WebKitSystemInterface.h> #endif @@ -1833,10 +1833,10 @@ const char* WebView::interpretKeyEvent(const KeyboardEvent* evt) keyDownCommandsMap = new HashMap<int, const char*>; keyPressCommandsMap = new HashMap<int, const char*>; - for (unsigned i = 0; i < _countof(keyDownEntries); i++) + for (size_t i = 0; i < WTF_ARRAY_LENGTH(keyDownEntries); ++i) keyDownCommandsMap->set(keyDownEntries[i].modifiers << 16 | keyDownEntries[i].virtualKey, keyDownEntries[i].name); - for (unsigned i = 0; i < _countof(keyPressEntries); i++) + for (size_t i = 0; i < WTF_ARRAY_LENGTH(keyPressEntries); ++i) keyPressCommandsMap->set(keyPressEntries[i].modifiers << 16 | keyPressEntries[i].charCode, keyPressEntries[i].name); } @@ -2870,13 +2870,14 @@ HRESULT STDMETHODCALLTYPE WebView::focusedFrame( return webFrame->QueryInterface(IID_IWebFrame, (void**) frame); } + HRESULT STDMETHODCALLTYPE WebView::backForwardList( /* [out][retval] */ IWebBackForwardList** list) { if (!m_useBackForwardList) return E_FAIL; - *list = WebBackForwardList::createInstance(m_page->backForwardList()); + *list = WebBackForwardList::createInstance(static_cast<WebCore::BackForwardListImpl*>(m_page->backForwardList())); return S_OK; } diff --git a/WebKit/win/WebView.h b/WebKit/win/WebView.h index 61eb946..424b03a 100644 --- a/WebKit/win/WebView.h +++ b/WebKit/win/WebView.h @@ -35,12 +35,15 @@ #include <WebCore/RefCountedGDIHandle.h> #include <WebCore/SuspendableTimer.h> #include <WebCore/WindowMessageListener.h> -#include <WebCore/WKCACFLayer.h> -#include <WebCore/WKCACFLayerRenderer.h> #include <wtf/HashSet.h> #include <wtf/OwnPtr.h> #include <wtf/RefPtr.h> +#if USE(ACCELERATED_COMPOSITING) +#include <WebCore/WKCACFLayer.h> +#include <WebCore/WKCACFLayerRenderer.h> +#endif + class FullscreenVideoController; class WebBackForwardList; class WebFrame; |