summaryrefslogtreecommitdiffstats
path: root/WebKit
diff options
context:
space:
mode:
authorGrace Kloba <klobag@google.com>2009-09-28 09:39:05 -0700
committerGrace Kloba <klobag@google.com>2009-09-28 11:41:48 -0700
commit1e67e45d20ead40b0407618abbc5e20840dc3c80 (patch)
tree63b92edeb25b1013cc291dbcf164223410790907 /WebKit
parentb3dd806a1bdd3101bd82696ed615e8ffe2091a2e (diff)
downloadexternal_webkit-1e67e45d20ead40b0407618abbc5e20840dc3c80.zip
external_webkit-1e67e45d20ead40b0407618abbc5e20840dc3c80.tar.gz
external_webkit-1e67e45d20ead40b0407618abbc5e20840dc3c80.tar.bz2
Update the comment for checking null in needtouchevents.
Add the header in WebCoreJni.cpp so that LOGE will be print out.
Diffstat (limited to 'WebKit')
-rw-r--r--WebKit/android/jni/WebCoreJni.cpp1
-rw-r--r--WebKit/android/jni/WebViewCore.cpp4
2 files changed, 3 insertions, 2 deletions
diff --git a/WebKit/android/jni/WebCoreJni.cpp b/WebKit/android/jni/WebCoreJni.cpp
index b757e3a..e7088b2 100644
--- a/WebKit/android/jni/WebCoreJni.cpp
+++ b/WebKit/android/jni/WebCoreJni.cpp
@@ -26,6 +26,7 @@
#include "config.h"
+#include "NotImplemented.h"
#include "WebCoreJni.h"
#include "jni_utility.h"
#include <jni.h>
diff --git a/WebKit/android/jni/WebViewCore.cpp b/WebKit/android/jni/WebViewCore.cpp
index 1cf96d5..359da03 100644
--- a/WebKit/android/jni/WebViewCore.cpp
+++ b/WebKit/android/jni/WebViewCore.cpp
@@ -904,8 +904,8 @@ void WebViewCore::needTouchEvents(bool need)
#if ENABLE(TOUCH_EVENTS) // Android
JNIEnv* env = JSC::Bindings::getJNIEnv();
AutoJObject obj = m_javaGlue->object(env);
- // if this is called after DESTROY is handled in WebViewCore.java, mNativeClass
- // will be null. Do nothing.
+ // if it is called during DESTROY is handled, the real object of WebViewCore
+ // can be gone. Check before using it.
if (env && obj.get()) {
env->CallVoidMethod(obj.get(), m_javaGlue->m_needTouchEvents, need);
checkException(env);