diff options
author | Grace Kloba <klobag@google.com> | 2010-01-14 18:25:41 -0800 |
---|---|---|
committer | Android Git Automerger <android-git-automerger@android.com> | 2010-01-14 18:25:41 -0800 |
commit | 7c0867874e2a40013c795b99d5b1d7220a6a5d04 (patch) | |
tree | bb4d0f209c11360b356c0fed95d17266e24e8fe0 /WebKit | |
parent | 7e4ab561c4c9340f9ef887d1f0fbb7c2972d5bfd (diff) | |
parent | 8a2903f5d11d14c8cb827d22a0a877a6e3507906 (diff) | |
download | external_webkit-7c0867874e2a40013c795b99d5b1d7220a6a5d04.zip external_webkit-7c0867874e2a40013c795b99d5b1d7220a6a5d04.tar.gz external_webkit-7c0867874e2a40013c795b99d5b1d7220a6a5d04.tar.bz2 |
am 8a2903f5: am b8a54826: Don\'t use static jclass unless we hold a reference.
Merge commit '8a2903f5d11d14c8cb827d22a0a877a6e3507906'
* commit '8a2903f5d11d14c8cb827d22a0a877a6e3507906':
Don't use static jclass unless we hold a reference.
Diffstat (limited to 'WebKit')
-rw-r--r-- | WebKit/android/jni/MIMETypeRegistry.cpp | 23 |
1 files changed, 9 insertions, 14 deletions
diff --git a/WebKit/android/jni/MIMETypeRegistry.cpp b/WebKit/android/jni/MIMETypeRegistry.cpp index 4e9ae68..b85b4a5 100644 --- a/WebKit/android/jni/MIMETypeRegistry.cpp +++ b/WebKit/android/jni/MIMETypeRegistry.cpp @@ -37,25 +37,20 @@ namespace WebCore { -static jmethodID gMimeTypeFromExtension; -static jclass gMimeClass; - String MIMETypeRegistry::getMIMETypeForExtension(const String& ext) { JNIEnv* env = JSC::Bindings::getJNIEnv(); - if (!gMimeTypeFromExtension) { - gMimeClass = env->FindClass("android/webkit/MimeTypeMap"); - LOG_ASSERT(gMimeClass, "Could not find class MimeTypeMap"); - gMimeTypeFromExtension = env->GetStaticMethodID(gMimeClass, - "mimeTypeFromExtension", - "(Ljava/lang/String;)Ljava/lang/String;"); - LOG_ASSERT(gMimeTypeFromExtension, - "Could not find method mimeTypeFromExtension"); - } + jclass mimeClass = env->FindClass("android/webkit/MimeTypeMap"); + LOG_ASSERT(mimeClass, "Could not find class MimeTypeMap"); + jmethodID mimeTypeFromExtension = env->GetStaticMethodID(mimeClass, + "mimeTypeFromExtension", + "(Ljava/lang/String;)Ljava/lang/String;"); + LOG_ASSERT(mimeTypeFromExtension, + "Could not find method mimeTypeFromExtension"); jstring extString = env->NewString((const jchar*) ext.characters(), ext.length()); - jobject mimeType = env->CallStaticObjectMethod(gMimeClass, - gMimeTypeFromExtension, extString); + jobject mimeType = env->CallStaticObjectMethod(mimeClass, + mimeTypeFromExtension, extString); String result = android::to_string(env, (jstring) mimeType); env->DeleteLocalRef(extString); env->DeleteLocalRef(mimeType); |