diff options
| author | Steve Block <steveblock@google.com> | 2010-04-27 16:31:00 +0100 |
|---|---|---|
| committer | Steve Block <steveblock@google.com> | 2010-05-11 14:42:12 +0100 |
| commit | dcc8cf2e65d1aa555cce12431a16547e66b469ee (patch) | |
| tree | 92a8d65cd5383bca9749f5327fb5e440563926e6 /WebKitTools/ChangeLog | |
| parent | ccac38a6b48843126402088a309597e682f40fe6 (diff) | |
| download | external_webkit-dcc8cf2e65d1aa555cce12431a16547e66b469ee.zip external_webkit-dcc8cf2e65d1aa555cce12431a16547e66b469ee.tar.gz external_webkit-dcc8cf2e65d1aa555cce12431a16547e66b469ee.tar.bz2 | |
Merge webkit.org at r58033 : Initial merge by git
Change-Id: If006c38561af287c50cd578d251629b51e4d8cd1
Diffstat (limited to 'WebKitTools/ChangeLog')
| -rw-r--r-- | WebKitTools/ChangeLog | 10304 |
1 files changed, 10304 insertions, 0 deletions
diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog index 6a4b7b3..a03ae52 100644 --- a/WebKitTools/ChangeLog +++ b/WebKitTools/ChangeLog @@ -1,3 +1,10307 @@ +2010-04-21 Chris Fleizach <cfleizach@apple.com> + + Reviewed by Alexey Proskuryakov. + + aria-liveregion-notifications.html fails on leopard release bot + https://bugs.webkit.org/show_bug.cgi?id=37112 + + Change the way that notifications are listened for by forcing clients + to call a remove listener as well to match the add listener. DRT will + assert if those are not done in the correct order. + + * DumpRenderTree/AccessibilityUIElement.cpp: + (removeNotificationListenerCallback): + (AccessibilityUIElement::getJSClass): + * DumpRenderTree/AccessibilityUIElement.h: + * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: + (AccessibilityUIElement::removeNotificationListener): + * DumpRenderTree/mac/AccessibilityUIElementMac.mm: + (-[AccessibilityNotificationHandler initWithPlatformElement:]): + (-[AccessibilityNotificationHandler dealloc]): + (-[AccessibilityNotificationHandler _notificationReceived:]): + (-[AccessibilityNotificationHandler setCallback:]): + (AccessibilityUIElement::AccessibilityUIElement): + (AccessibilityUIElement::~AccessibilityUIElement): + (AccessibilityUIElement::addNotificationListener): + (AccessibilityUIElement::removeNotificationListener): + * DumpRenderTree/win/AccessibilityUIElementWin.cpp: + (AccessibilityUIElement::removeNotificationListener): + +2010-04-21 Anders Carlsson <andersca@apple.com> + + Reviewed by Sam Weinig. + + Add debug menu items to show/hide the Web View. + https://bugs.webkit.org/show_bug.cgi?id=37958 + + * MiniBrowser/mac/BrowserWindowController.h: + * MiniBrowser/mac/BrowserWindowController.m: + (-[BrowserWindowController showHideWebView:]): + (-[BrowserWindowController removeReinsertWebView:]): + (-[BrowserWindowController validateMenuItem:]): + * MiniBrowser/mac/English.lproj/MainMenu.xib: + +2010-04-21 Eric Seidel <eric@webkit.org> + + Unreviewed. Rolling out unicode() changes as they broke NRWT for chromium. + Rolling out: + http://trac.webkit.org/changeset/58014 + http://trac.webkit.org/changeset/58016 + http://trac.webkit.org/changeset/58020 + + REGRESSION(57531): the commit-queue still hates Tor Arne Vestbo + https://bugs.webkit.org/show_bug.cgi?id=37765 + + * Scripts/webkitpy/common/checkout/api_unittest.py: + * Scripts/webkitpy/common/checkout/changelog.py: + * Scripts/webkitpy/common/checkout/changelog_unittest.py: + * Scripts/webkitpy/common/checkout/commitinfo.py: + * Scripts/webkitpy/common/checkout/scm.py: + * Scripts/webkitpy/common/checkout/scm_unittest.py: + * Scripts/webkitpy/common/config/committers.py: + * Scripts/webkitpy/common/net/bugzilla.py: + * Scripts/webkitpy/common/net/buildbot.py: + * Scripts/webkitpy/common/net/buildbot_unittest.py: + * Scripts/webkitpy/common/net/statusserver.py: + * Scripts/webkitpy/common/prettypatch.py: + * Scripts/webkitpy/common/system/autoinstall.py: + * Scripts/webkitpy/common/system/deprecated_logging.py: + * Scripts/webkitpy/common/system/executive.py: + * Scripts/webkitpy/common/system/executive_unittest.py: + * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: + * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: + * Scripts/webkitpy/layout_tests/port/apache_http_server.py: + * Scripts/webkitpy/layout_tests/port/chromium.py: + * Scripts/webkitpy/layout_tests/port/chromium_linux.py: + * Scripts/webkitpy/layout_tests/port/chromium_mac.py: + * Scripts/webkitpy/layout_tests/port/gtk.py: + * Scripts/webkitpy/layout_tests/port/mac.py: + * Scripts/webkitpy/layout_tests/port/mac_unittest.py: + * Scripts/webkitpy/layout_tests/port/qt.py: + * Scripts/webkitpy/layout_tests/port/server_process.py: + * Scripts/webkitpy/layout_tests/port/webkit.py: + * Scripts/webkitpy/layout_tests/port/websocket_server.py: + * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + * Scripts/webkitpy/layout_tests/test_types/image_diff.py: + * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: + * Scripts/webkitpy/layout_tests/test_types/text_diff.py: + * Scripts/webkitpy/style/filereader_unittest.py: + * Scripts/webkitpy/thirdparty/__init__.py: + * Scripts/webkitpy/tool/commands/earlywarningsystem.py: + * Scripts/webkitpy/tool/commands/queues.py: + * Scripts/webkitpy/tool/commands/queues_unittest.py: + * Scripts/webkitpy/tool/commands/upload.py: + * Scripts/webkitpy/tool/mocktool.py: + * Scripts/webkitpy/tool/steps/abstractstep.py: + * Scripts/webkitpy/tool/steps/postdiff.py: + * Scripts/webkitpy/tool/steps/postdiffforcommit.py: + * Scripts/webkitpy/tool/steps/postdiffforrevert.py: + * Scripts/webkitpy/tool/steps/steps_unittest.py: + +2010-04-21 Eric Seidel <eric@webkit.org> + + Unreviewed, fixing NRWT for real this time. + + REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø + https://bugs.webkit.org/show_bug.cgi?id=37765 + + * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: + - Add a hack to fix new-run-webkit-tests + my understanding of codecs.open(encoding=None) + must have been wrong. + +2010-04-21 Eric Seidel <eric@webkit.org> + + Unreviewed, just fixing exception seen on builders. + + REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø + https://bugs.webkit.org/show_bug.cgi?id=37765 + + * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: + - Pass and encoding to _write_into_file_at_path + +2010-04-21 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø + https://bugs.webkit.org/show_bug.cgi?id=37765 + + I fixed the queue to not ignore Tor as a reviwer in r57531, + but instead it throws an exception every time his name is in a patch. + + This fixes our Executive.run_command code to work around a Popen + bug http://bugs.python.org/issue5290 whereby python versions before 2.6 + do not correctly handle unicode objects as input or output to + Popen.communicate. + + Following the advice of: + http://farmdev.com/talks/unicode/ + I have changed all of webkitpy to use unicode() objects as strings + instead of str objects (which in Python 3 are renamed "bytes"). + + String literals were left as "foo" instead of converting to u"foo" + as u"foo" is only required if the string has a non-ascii code point. + Python is smart about comparing str() and unicode() values and will + log an error to the console if the comparison is ever invalid. + + Executive.run* now correctly accept and return unicode() objects. + I attempted to fix all the places that we call .write() to make sure we + encode any unicode() objects into utf-8. + + I removed several uses of StringIO. StringIO should generally always be + passed a unicode() value. + + Likewise I replaced most calls to open() with codecs.open(). + codecs.open() matches Python 3 open semantics in requiring an encoding + parameter. Files opened with codecs.open() with a unicode-compatible + encoding will vend unicode() objects from their read() calls, like how + StringIO created with a unicode() object will do. + + I also deployed "with" statements wider (now that the project has + settled on Python 2.5) to close a bunch of file descriptor leaks. + + * Scripts/webkitpy/common/checkout/api_unittest.py: + - Read/write utf-8 files instead of ascii. + - Update the tests to use test for proper unicode() handling. + * Scripts/webkitpy/common/checkout/changelog.py: + - Document that parse_latest_entry_from_file expects + file-like objects which return unicode strings. + * Scripts/webkitpy/common/checkout/changelog_unittest.py: + - Use unicode() strings instead of str() byte arrays. + - Deploy "with" to close file descriptor leaks. + * Scripts/webkitpy/common/checkout/commitinfo.py: + - Remove unneeded import. + * Scripts/webkitpy/common/checkout/scm.py: + - Remove use of str(). + * Scripts/webkitpy/common/checkout/scm_unittest.py: + - Read/write utf-8 files and use unicode() strings in testing. + * Scripts/webkitpy/common/config/committers.py: + - Use \u instead of \x to make slightly clearer what we're doing. + * Scripts/webkitpy/common/net/bugzilla.py: + - Add a new _string_contents() method and explain why + we have to call unicode() on the result of soup.string + and why it's safe to do so w/o needing to pass a codec name. + - Remove the (unused) support for passing a file object to add_patch_to_bug(). + * Scripts/webkitpy/common/net/buildbot.py: + - Use unicode() instead of str() when needing to coax a + NavigableString object into a unicode() object. + * Scripts/webkitpy/common/net/buildbot_unittest.py: + - Add a test which contains a unicode builder name. + * Scripts/webkitpy/common/net/statusserver.py: + - Remove use of str() + * Scripts/webkitpy/common/prettypatch.py: + - Write out the patch file as utf-8. + * Scripts/webkitpy/common/system/autoinstall.py: + - Write out files with a explicit encodings. + - Deploy "with" to close file descriptor leaks. + * Scripts/webkitpy/common/system/deprecated_logging.py: + - Write out log files as utf-8. + * Scripts/webkitpy/common/system/executive.py: + - Make run* properly take and return unicode() objects. + - Cleaned up input handling in run_command a little by adding + a _compute_input() method which can return early instead of having + such a long/cluttered if-block. + * Scripts/webkitpy/common/system/executive_unittest.py: + - Added a unit test to make sure we don't break Tor again! + * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: + - Write out the test list as utf-8. + * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: + - Write out json files as utf-8. + * Scripts/webkitpy/layout_tests/port/apache_http_server.py: + - Deploy "with" to close file descriptor leaks. + * Scripts/webkitpy/layout_tests/port/chromium.py: Add Executive.py FIXME. + * Scripts/webkitpy/layout_tests/port/chromium_linux.py: ditto. + * Scripts/webkitpy/layout_tests/port/chromium_mac.py: ditto. + * Scripts/webkitpy/layout_tests/port/gtk.py: ditto. + * Scripts/webkitpy/layout_tests/port/mac.py: ditto. + * Scripts/webkitpy/layout_tests/port/mac_unittest.py: + - Make the skipped file parsing test unicode. + * Scripts/webkitpy/layout_tests/port/qt.py: Add Executive.py FIXME. + * Scripts/webkitpy/layout_tests/port/server_process.py: ditto. + * Scripts/webkitpy/layout_tests/port/webkit.py: + - Deploy "with" to close file descriptor leaks. + * Scripts/webkitpy/layout_tests/port/websocket_server.py: + - Make explicit the encodings of log files and pid files. + * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: + - Make encodings explicit and deploy "with". + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: ditto. + * Scripts/webkitpy/layout_tests/test_types/image_diff.py: ditto. + * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: ditto. + * Scripts/webkitpy/layout_tests/test_types/text_diff.py: ditto. + * Scripts/webkitpy/style/filereader_unittest.py: ditto. + * Scripts/webkitpy/thirdparty/__init__.py: ditto. + * Scripts/webkitpy/tool/commands/earlywarningsystem.py: + - Removed extra import. + * Scripts/webkitpy/tool/commands/queues.py: + - No need to map args to strings now that run_command does. + - Update test results to match args changes. + - Document our global argument hacks. + * Scripts/webkitpy/tool/commands/upload.py: + - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper. + * Scripts/webkitpy/tool/mocktool.py: + - Rename add_patch_to_bug argument to match bugzilla.py + * Scripts/webkitpy/tool/steps/abstractstep.py: + - Executive.run_* now require lists instead of strings. + The lack of this change was what broke webkit-patch + for svn users the first time this was landed. + * Scripts/webkitpy/tool/steps/postdiff.py: + - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper. + * Scripts/webkitpy/tool/steps/postdiffforcommit.py: ditto + * Scripts/webkitpy/tool/steps/postdiffforrevert.py: ditto + * Scripts/webkitpy/tool/steps/steps_unittest.py: + - Fixed spurious logging seen when running test-webkitpy + +2010-04-21 Kinuko Yasuda <kinuko@chromium.org> + + Unreviewed. + + Add myself in committers.py. + + * Scripts/webkitpy/common/config/committers.py: + +2010-04-21 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Dimitri Glazkov. + + new-run-webkit-tests: fix a bug in the Chromium port where we would + try to talk to a crashed test_shell and raise exceptions that weren't + being caught. + + https://bugs.webkit.org/show_bug.cgi?id=37941 + + * Scripts/webkitpy/layout_tests/port/chromium.py: + +2010-04-21 Laszlo Gombos <laszlo.1.gombos@nokia.com> + + Unreviewed. + + [Qt] [Symbian] Build fix. + + Work around a Qt quirk. Some versions of Symbian port Qt + QFontDatabase::removeAllApplicationFonts symbol is not available. + + * DumpRenderTree/qt/DumpRenderTreeQt.cpp: + (WebCore::DumpRenderTree::open): + +2010-04-21 Alexey Proskuryakov <ap@apple.com> + + Unreviewed. + + https://bugs.webkit.org/show_bug.cgi?id=37933 + <rdar://problem/7719540> XMLHttpRequest.withCredentials should be better enforced. + + Adding stub implementation of authenticateSession(). Depending on platform loader behavior, + a real implementation may or may not be necessary for the one test that currently uses it + to pass. + + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::authenticateSession): + * DumpRenderTree/qt/LayoutTestControllerQt.h: + +2010-04-21 Alexey Proskuryakov <ap@apple.com> + + Reviewed by Brady Eidson. + + https://bugs.webkit.org/show_bug.cgi?id=37933 + <rdar://problem/7719540> XMLHttpRequest.withCredentials should be better enforced. + + Adding authenticateSession() method that adds credentials to per-process credential storage + (for platforms that even have such). No Windows implementation, because writing another + loader for DRT is painful. + + * DumpRenderTree/LayoutTestController.cpp: + (authenticateSessionCallback): + (LayoutTestController::staticFunctions): + * DumpRenderTree/LayoutTestController.h: + * DumpRenderTree/mac/LayoutTestControllerMac.mm: + (-[SynchronousLoader dealloc]): + (-[SynchronousLoader connectionShouldUseCredentialStorage:]): + (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]): + (-[SynchronousLoader connection:didFailWithError:]): + (-[SynchronousLoader connectionDidFinishLoading:]): + (+[SynchronousLoader makeRequest:withUsername:password:]): + (LayoutTestController::authenticateSession): + + * DumpRenderTree/win/LayoutTestControllerWin.cpp: + (LayoutTestController::authenticateSession): + * DumpRenderTree/wx/LayoutTestControllerWx.cpp: + (LayoutTestController::authenticateSession): + * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: + (LayoutTestController::authenticateSession): + Stub implementations. + +2010-04-21 Kent Tamura <tkent@chromium.org> + + Reviewed by Dimitri Glazkov. + + [DRT/Chromium] Make DRT compilable in Chromium tree + https://bugs.webkit.org/show_bug.cgi?id=37923 + + We need to use different GYPs in a case of WebKit-only checkout + and a case of whole Chromium checkout because the relative paths + from webkit/ to WebKit/chromium/features.gypi are different in + these cases and we can't use 'conditions' for 'includes' in GYPs. + + * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: + +2010-04-21 Jakub Wieczorek <jwieczorek@webkit.org> + + Reviewed by Darin Adler. + + List item markers are not always updated after changes in the DOM. + https://bugs.webkit.org/show_bug.cgi?id=37060 + + * DumpRenderTree/LayoutTestController.cpp: + (markerTextForListItemCallback): A function that returns the marker text for a given list item. + (LayoutTestController::staticFunctions): + * DumpRenderTree/LayoutTestController.h: + * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: + (LayoutTestController::markerTextForListItem): Implement it in the GTK port. + * DumpRenderTree/mac/LayoutTestControllerMac.mm: + (LayoutTestController::markerTextForListItem): Add a stub. + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::LayoutTestController): + (LayoutTestController::markerTextForListItem): Implement it in the Qt port. + * DumpRenderTree/qt/LayoutTestControllerQt.h: + * DumpRenderTree/win/LayoutTestControllerWin.cpp: + (LayoutTestController::markerTextForListItem): Add a stub. + +2010-04-21 Adam Roben <aroben@apple.com> + + Exclude leaks in CGGradientCreateWithColorComponents from + run-webkit-tests leaks output + + The leak in CG is covered by <rdar://problem/7888492>. + + Fixes <http://webkit.org/b/37927>. + + Reviewed by Eric Carlson. + + * Scripts/old-run-webkit-tests: + (sub countAndPrintLeaks): Exclude leaks in + CGGradientCreateWithColorComponents on certain OSs. + +2010-04-21 Kent Tamura <tkent@chromium.org> + + Reviewed by Shinichiro Hamaji. + + [DRT/Chromium] Import MockSpellCheck from Chromium + https://bugs.webkit.org/show_bug.cgi?id=37910 + + Import webkit/tools/test_shell/mock_spellcheck.{cc,h} rev.37241 of Chromium. + + * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: + Add ICU explicitly because WTFString.h includes ICU headers. + Add MockSpellCheck.{cpp,h}. + * DumpRenderTree/chromium/MockSpellCheck.cpp: Added. + * DumpRenderTree/chromium/MockSpellCheck.h: Added. + * DumpRenderTree/chromium/WebViewHost.cpp: + (WebViewHost::spellCheck): + * DumpRenderTree/chromium/WebViewHost.h: + * DumpRenderTree/chromium/config.h: Define JS_EXPORTDATA, which is used + by wtf/text/AtomicString.h included by wtf/text/WTFString.h. + +2010-04-21 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Add webkit-patch pretty-diff + https://bugs.webkit.org/show_bug.cgi?id=37892 + + This is slightly lame because it asks you whether the diff is correct, + but it's a starting point. + + * Scripts/webkitpy/tool/commands/__init__.py: + * Scripts/webkitpy/tool/commands/prettydiff.py: Added. + * Scripts/webkitpy/tool/main.py: + +2010-04-21 Adam Barth <abarth@webkit.org> + + Reviewed by Darin Adler. + + Remove mention of non-existant --no-build option + https://bugs.webkit.org/show_bug.cgi?id=37893 + + The option doesn't exist! + + * Scripts/webkitpy/tool/commands/stepsequence.py: + +2010-04-21 Balazs Kelemen <kb@inf.u-szeged.hu> + + Reviewed by Kenneth Rohde Christiansen. + + [Qt] Interrupting JavaScript is cumbersome when you use QtLaucher for testing or profiling. + https://bugs.webkit.org/show_bug.cgi?id=37198 + + * QtLauncher/main.cpp: + (LauncherWindow::toggleInterruptingJavaScriptEnabled): + (LauncherWindow::newWindow): + (LauncherWindow::cloneWindow): + (LauncherWindow::createChrome): + (main): + * QtLauncher/webpage.cpp: + (WebPage::WebPage): + (WebPage::shouldInterruptJavaScript): + * QtLauncher/webpage.h: + (WebPage::setInterruptingJavaScriptEnabled): + +2010-04-21 Eric Seidel <eric@webkit.org> + + Unreviewed, rolling out r57963. + http://trac.webkit.org/changeset/57963 + https://bugs.webkit.org/show_bug.cgi?id=37759 + + Three tests started crashing on the Qt bot. + + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + * DumpRenderTree/qt/LayoutTestControllerQt.h: + +2010-04-21 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> + + Reviewed by Eric Seidel. + + Make new-run-webkit-tests work for the Qt port + https://bugs.webkit.org/show_bug.cgi?id=37588 + + * Scripts/webkitpy/layout_tests/port/qt.py: + +2010-04-21 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> + + Reviewed by Eric Seidel. + + new-run-webkit-tests: try to detect alternate apache path + https://bugs.webkit.org/show_bug.cgi?id=37587 + + _check_port_build() also needs to return true in the + base implementation to not fail the check_build step. + + * Scripts/webkitpy/layout_tests/port/webkit.py: + +2010-04-21 Yi Shen <yi.4.shen@nokia.com> + + Reviewed by Simon Hausmann. + + [Qt] Add LayoutTestController interface: computedStyleIncludingVisitedInfo + https://bugs.webkit.org/show_bug.cgi?id=37759 + + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::computedStyleIncludingVisitedInfo): + * DumpRenderTree/qt/LayoutTestControllerQt.h: + +2010-04-21 Eric Seidel <eric@webkit.org> + + Unreviewed, test fix only. + + new-run-webkit-tests: implement a --log trace message to be able to display detailed output of an individual test run + https://bugs.webkit.org/show_bug.cgi?id=37726 + + This change seems to have broken a test. + Attempting to handle the case where we don't have any + timing information. Dirk may have to correct this change. + + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + +2010-04-19 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + new-run-webkit-tests has much higher startup latency than run-webkit-tests + https://bugs.webkit.org/show_bug.cgi?id=37643 + + I got rid of the -expected.checksum reads during startup. + This makes startup noticably better on my laptop. + + * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: + - Use image_hash() instead of .image_hash now that expected.checksum + file reads are done lazily. + * Scripts/webkitpy/layout_tests/port/http_server_base.py: + - Add debug logging for this sleep call. + In my testing I never saw this sleep() hit. + * Scripts/webkitpy/layout_tests/port/websocket_server.py: + - Sleep a shorter interval to make websocket server + startup more responsive. On my machine startup was + taking around 1 second. + - Remove the unconditional .5s delay on startup. + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + - Make image_hash file reads done lazily in a new image_hash() function. + - Add a "Starting testing ..." meter update after DRT threads have + been started, but before we get updates from the first one. + - Rename variable "t" to a full english name to match WebKit style. + +2010-04-20 Daniel Bates <dbates@rim.com> + + Reviewed by Eric Seidel. + + https://bugs.webkit.org/show_bug.cgi?id=37748 + + Make Sheriffbot more inspirational. + + * Scripts/webkitpy/common/net/bugzilla.py: + * Scripts/webkitpy/common/net/bugzilla_unittest.py: + * Scripts/webkitpy/tool/bot/irc_command.py: + * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: + * Scripts/webkitpy/tool/mocktool.py: + +2010-04-20 Kent Tamura <tkent@chromium.org> + + Reviewed by Dimitri Glazkov. + + [DRT/Chromium] Import Chromium image_diff as ImageDiff + https://bugs.webkit.org/show_bug.cgi?id=37790 + + ImageDiff.cpp is based on tools/imagediff/image_diff.cc r41911 of Chromium. + + * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: + * DumpRenderTree/chromium/ImageDiff.cpp: Added. + * Scripts/webkitpy/layout_tests/port/chromium_mac.py: + +2010-04-20 Dirk Pranke <dpranke@chromium.org> + + This patch to new-run-webkit-tests adds a --log 'trace' option + that prints out detailed info about a given test as it executes + (where the baselines are, what the expectation is, what we got, + how long it took). + + https://bugs.webkit.org/show_bug.cgi?id=37726 + + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + - use the newly exposed TestResult class and implement + --log trace + * Scripts/webkitpy/layout_tests/layout_package/dump_render_thread.py: + - rename TestStats to TestResult and make it more public, resulting + in cleaner code + * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: + - add expectation_to_string() as a separate callable function + +2010-04-20 Eric Seidel <eric@webkit.org> + + Unreviewed, rolling out r57907. + http://trac.webkit.org/changeset/57907 + https://bugs.webkit.org/show_bug.cgi?id=37765 + + Appears to have broken MacEWS and possibly webkit-patch upload + for svn users. Needs further investigation. + + * Scripts/webkitpy/common/checkout/api.py: + * Scripts/webkitpy/common/checkout/api_unittest.py: + * Scripts/webkitpy/common/checkout/changelog.py: + * Scripts/webkitpy/common/checkout/changelog_unittest.py: + * Scripts/webkitpy/common/checkout/commitinfo.py: + * Scripts/webkitpy/common/checkout/scm.py: + * Scripts/webkitpy/common/checkout/scm_unittest.py: + * Scripts/webkitpy/common/config/committers.py: + * Scripts/webkitpy/common/net/bugzilla.py: + * Scripts/webkitpy/common/net/buildbot.py: + * Scripts/webkitpy/common/net/buildbot_unittest.py: + * Scripts/webkitpy/common/net/statusserver.py: + * Scripts/webkitpy/common/prettypatch.py: + * Scripts/webkitpy/common/system/autoinstall.py: + * Scripts/webkitpy/common/system/deprecated_logging.py: + * Scripts/webkitpy/common/system/executive.py: + * Scripts/webkitpy/common/system/executive_unittest.py: + * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: + * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: + * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py: + * Scripts/webkitpy/layout_tests/port/mac_unittest.py: + * Scripts/webkitpy/tool/commands/earlywarningsystem.py: + * Scripts/webkitpy/tool/commands/queues.py: + * Scripts/webkitpy/tool/commands/queues_unittest.py: + * Scripts/webkitpy/tool/commands/upload.py: + * Scripts/webkitpy/tool/mocktool.py: + * Scripts/webkitpy/tool/steps/abstractstep.py: + * Scripts/webkitpy/tool/steps/postdiff.py: + * Scripts/webkitpy/tool/steps/postdiffforcommit.py: + * Scripts/webkitpy/tool/steps/postdiffforrevert.py: + * Scripts/webkitpy/tool/steps/steps_unittest.py: + +2010-04-20 Nate Chapin <japhet@chromium.org> + + Unreviewed. + + Update my irc handle in committers.py (natechapin -> japhet). + + * Scripts/webkitpy/common/config/committers.py: + +2010-04-20 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø + https://bugs.webkit.org/show_bug.cgi?id=37765 + + I fixed the queue to not ignore Tor as a reviwer in r57531, + but instead it throws an exception every time his name is in a patch. + + This fixes our Executive.run_command code to work around a Popen + bug http://bugs.python.org/issue5290 whereby python versions before 2.6 + do not correctly handle unicode objects as input or output to + Popen.communicate. + + Following the advice of: + http://farmdev.com/talks/unicode/ + I'm attempting to take the python unicode plunge and use unicode() + objects as strings instead of str() objects everywhere in webkitpy. + + We do not have to use u"" instead of "" because u"a" == "a" as expected + in Python. Python will generate a warning to the console in cases where + a unicode() == str() operation cannot be performed. + + I also cleaned up the input handling in run_command a little by adding + a new _compute_input() method which can return early instead of having + such a long/cluttered if-block. + + Executive.run* now correctly accept and return unicode() objects. + I attempted to fix all the places that we call .write() to make sure we + encode any unicode() objects into utf-8. + + All places which use StringIO need to be sure to pass StringIO a + pre-encoded byte-array (str object) instead of unicode so that + clients which read from the StringIO don't have encoding exceptions. + To make this easier, I removed the patch_file_object support from + add_patch_to_bug, and changed the 4 places which previously used + StringIO to create a fake patch file. + + I attempted to document any places where we are not correctly converting + to/from bytes (str() objects) to strings (unicode() objects). + + * Scripts/webkitpy/common/checkout/api_unittest.py: + - Read/write utf-8 files instead of ascii. + - Update the tests to use test for proper unicode() handling. + * Scripts/webkitpy/common/checkout/changelog_unittest.py: + - Use unicode() strings instead of str() byte arrays. + * Scripts/webkitpy/common/checkout/scm.py: + - Remove use of str(). + * Scripts/webkitpy/common/checkout/scm_unittest.py: + - Read/write utf-8 files and use unicode() strings in testing. + * Scripts/webkitpy/common/config/committers.py: + - Use \u instead of \x to make slightly clearer what we're doing. + * Scripts/webkitpy/common/net/bugzilla.py: + - Add a new _string_contents() method and explain why + we have to call unicode() on the result of soup.string + and why it's safe to do so w/o needing to pass a codec name. + - Remove the (unused) support for passing a file object to add_patch_to_bug(). + * Scripts/webkitpy/common/net/buildbot.py: + - Use unicode() instead of str() when needing to coax a + NavigableString object into a unicode() object. + * Scripts/webkitpy/common/net/statusserver.py: + - Remove use of str() + * Scripts/webkitpy/common/prettypatch.py: + - Write out the patch file as utf-8. + * Scripts/webkitpy/common/system/autoinstall.py: + - Add a FIXME about encoding. + * Scripts/webkitpy/common/system/deprecated_logging.py: + - Document that tee() works on bytes, not strings. + * Scripts/webkitpy/common/system/executive.py: + - Make run* properly take and return unicode() objects. + * Scripts/webkitpy/common/system/executive_unittest.py: + - Added a unit test to make sure we don't break Tor again! + * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: + - Write out the test list as utf-8. + * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: + - Write out json files as utf-8. + * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py: + - Add FIXME about encoding handling. + * Scripts/webkitpy/tool/commands/upload.py: + - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper. + * Scripts/webkitpy/tool/mocktool.py: + - Rename add_patch_to_bug argument to match bugzilla.py + * Scripts/webkitpy/tool/steps/postdiff.py: + - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper. + * Scripts/webkitpy/tool/steps/postdiffforcommit.py: ditto. + * Scripts/webkitpy/tool/steps/postdiffforrevert.py: ditto. + * Scripts/webkitpy/tool/steps/steps_unittest.py: + - Fixed spurious logging seen when running test-webkitpy + +2010-04-20 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Shinichiro Hamaji. + + For check-webkit-style, implemented __eq__() and __ne__() (the + built-in equality and inequality methods) for the + DefaultStyleErrorHandler class. + + https://bugs.webkit.org/show_bug.cgi?id=37850 + + This will facilitate unit-testing for a subsequent patch, + namely for https://bugs.webkit.org/show_bug.cgi?id=37850 + + * Scripts/webkitpy/style/error_handlers.py: + - Added __eq__() and __ne__() to the DefaultStyleErrorHandler + class. + + * Scripts/webkitpy/style/error_handlers_unittest.py: + - Added unit tests for __eq__() and __ne__(). + - Also included a minor clean-up refactoring of combining the + StyleErrorHandlerTestBase class (which has not needed to + be separate due to previous changes) into the + DefaultStyleErrorHandlerTest class. + +2010-04-20 Jakub Wieczorek <jwieczorek@webkit.org> + + Unreviewed. + + Add my IRC nick to the committers.py list. + + * Scripts/webkitpy/common/config/committers.py: + +2010-04-20 Kim Grönholm <kim.gronholm@nomovok.com> + + Reviewed by Simon Hausmann. + + [Qt] Multitouch mocking in QtLauncher doesn't work with QGraphicsView + https://bugs.webkit.org/show_bug.cgi?id=37816 + + Fix multi-touch mocking in QtLauncher when using QGraphicsView. + Test: https://bug-32434-attachments.webkit.org/attachment.cgi?id=44955 + + * QtLauncher/main.cpp: + (LauncherWindow::eventFilter): + (LauncherWindow::initializeView): + +2010-04-20 MORITA Hajime <morrita@google.com> + + Unreviewed, add myself to the committers list. + + * Scripts/webkitpy/common/config/committers.py: + +2010-04-20 Kent Tamura <tkent@chromium.org> + + Reviewed by Shinichiro Hamaji. + + [DRT/Chromium] Fix some unexpected results of editing + https://bugs.webkit.org/show_bug.cgi?id=37843 + + This change fixes about 70 unexpected results. + The original test_webview_delegate.cc doesn't have this bug. + The bug was introduced when I ported it to WebKit tree. + + * DumpRenderTree/chromium/WebViewHost.cpp: + (printRangeDescription): Replace the latter startContainer() with endContainer(). + +2010-04-19 Dirk Pranke <dpranke@chromium.org> + + Unreviewed, build fix. + + Turn off some unit tests for now - the new-run-webkit-tests dryrun + tests for chromium won't work if you don't have a chromium checkout. + + https://bugs.webkit.org/show_bug.cgi?id=37841 + + * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: + +2010-04-19 Dirk Pranke <dpranke@chromium.org> + + Unreviewed, build fix. + + (Re-)add dryrun.py; this was renamed from passing.py in the previous + CL but apparently somehow didn't get checked in. + + https://bugs.webkit.org/show_bug.cgi?id=37841 + + * Scripts/webkitpy/layout_tests/port/dryrun.py: Added. + +2010-04-19 Shinichiro Hamaji <hamaji@chromium.org> + + Reviewed by David Levin. + + check-webkit-style: exits when encountering a deleted file + https://bugs.webkit.org/show_bug.cgi?id=37122 + + This reverts the quick fix done by r57119 and makes check_patch + not call check_file for deleted files. + + Also this change fixes the behavior for "-", which should mean + stdin. Before this change, the style checker just ignored "-" + with a warning message. + + * Scripts/webkitpy/style/checker.py: + * Scripts/webkitpy/style/checker_unittest.py: + +2010-04-19 Daniel Bates <dbates@rim.com> + + No review, rolling out 57868. + http://trac.webkit.org/changeset/57868 + https://bugs.webkit.org/show_bug.cgi?id=37748 + + Sheriffbot wasn't very inspirational after this patch. + Instead, he was silent when you said hi :-(. Rolling + out this patch so that I can debug/test this some more. + + * Scripts/webkitpy/common/net/bugzilla.py: + * Scripts/webkitpy/common/net/bugzilla_unittest.py: + * Scripts/webkitpy/tool/bot/irc_command.py: + * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: + * Scripts/webkitpy/tool/mocktool.py: + +2010-04-19 Daniel Bates <dbates@rim.com> + + Reviewed by Adam Barth. + + https://bugs.webkit.org/show_bug.cgi?id=37748 + + Make Sheriffbot more inspirational. + + * Scripts/webkitpy/common/net/bugzilla.py: + * Scripts/webkitpy/common/net/bugzilla_unittest.py: + * Scripts/webkitpy/tool/bot/irc_command.py: + * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: + * Scripts/webkitpy/tool/mocktool.py: + +2010-04-19 Kevin Ollivier <kevino@theolliviers.com> + + [wx] Build fix, add missing header. + + * DumpRenderTree/wx/LayoutTestControllerWx.cpp: + +2010-04-19 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Adam Barth. + + new-run-webkit-tests - repurpose the "Passing" port as "Dryrun" port + that can be used to test platforms other than the one you are running + on. This can be useful for checking baselines and testing code + coverage. + + Note that running the code on the "wrong" port requires each + port-specific implementation to actually not require any + platform-specific python code (e.g., the chromium-win port must + test for the existence of windows functions before calling them). + + https://bugs.webkit.org/show_bug.cgi?id=37782 + + * Scripts/webkitpy/layout_tests/port/chromium_win.py: + * Scripts/webkitpy/layout_tests/port/dryrun.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/port/passing.py. + * Scripts/webkitpy/layout_tests/port/factory.py: + * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: + +2010-04-19 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Eric Seidel. + + new-run-webkit-tests: add --build (default) and --no-build + options to make that step optional. This flag modifies what happens + in port.check_build(). + + https://bugs.webkit.org/show_bug.cgi?id=37786 + + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + * Scripts/webkitpy/layout_tests/port/chromium.py: + * Scripts/webkitpy/layout_tests/port/webkit.py: + +2010-04-19 Dirk Pranke <dpranke@chromium.org> + + Unreviewed, build fix. + + new-run-webkit-tests - fix a typo in r57480 that caused us to stop + logging the actual list of unexpected results. + + https://bugs.webkit.org/show_bug.cgi?id=37831 + + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + +2010-04-19 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Adam Barth. + + From a patch by Tor Arne Vestbo <tor.arne.vestbo@nokia.com> + + new-run-webkit-tests: make the retry step more explicit + https://bugs.webkit.org/show_bug.cgi?id=37606 + + It might be confusing to see the test and percent counters + reset without any notice of what's going on, so we make the + message that a retry-run is started explicit. + + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + +2010-04-19 Sam Weinig <weinig@apple.com> + + Reviewed by Anders Carlsson. + + Add support for opening a new window (File->New Window) to + Windows MiniBrowser. Accelerator doesn't work. + + * MiniBrowser/win/BrowserView.cpp: + (createNewPage): Use BrowserView::create. + * MiniBrowser/win/BrowserWindow.cpp: + (BrowserWindow::onCommand): Respond to ID_FILE_NEW_WINDOW + by creating a new window. + * MiniBrowser/win/BrowserWindow.h: + (BrowserWindow::create): Added. Don't allow creating + BrowserWindows on the stack by making constructor + private and exposing the create function. + * MiniBrowser/win/MiniBrowser.cpp: + (MiniBrowser::createNewWindow): Move new window creation + logic here. + * MiniBrowser/win/MiniBrowser.h: + * MiniBrowser/win/MiniBrowser.rc: + * MiniBrowser/win/main.cpp: + (_tWinMain): Use the new MiniBrowser::createNewWindow(). + +2010-04-19 Chris Fleizach <cfleizach@apple.com> + + Reviewed by Beth Dakin. + + AX: aria-haspopup needs to be exposed + https://bugs.webkit.org/show_bug.cgi?id=37808 + + * DumpRenderTree/mac/AccessibilityUIElementMac.mm: + (AccessibilityUIElement::hasPopup): + +2010-04-19 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Eric Seidel. + + Submit a better workaround for r57806 than the one in r57831 - log + an error and exit if you try to run new-run-webkit-tests with --use-drt + on Windows. + + https://bugs.webkit.org/show_bug.cgi?id=37822 + + * Scripts/webkitpy/layout_tests/port/chromium.py: + +2010-04-19 Jesus Sanchez-Palencia <jesus@webkit.org> + + Unreviewed. + + Just adding myself as a committer. + + * Scripts/webkitpy/common/config/committers.py: + +2010-04-19 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Eric Seidel. + + Add slightly better logging to the websocket python wrapper script, + including a --verbose flag for debug output. + + https://bugs.webkit.org/show_bug.cgi?id=37233 + + * Scripts/webkitpy/layout_tests/port/websocket_server.py: + * Scripts/new-run-webkit-websocketserver: + +2010-04-19 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Eric Seidel. + + new-run-webkit-tests: add a way (--print-unexpected-results) to + (re-)print out the tests that produced unexpected results in the + last run. Also add a way (--retry-unexpected-results) to + automatically re-test them. + + https://bugs.webkit.org/show_bug.cgi?id=37783 + + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + +2010-04-19 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Eric Seidel. + + Restructure the logging in new-run-webkit-tests so that many of log + messages that were logged to the MeteredStream also get logged in + --verbose mode. + + https://bugs.webkit.org/show_bug.cgi?id=37780 + + * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py: + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + +2010-04-19 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Eric Seidel. + + new-run-webkit-tests: add 'summary' and 'unexpected-results' options + to the --log flag. Also add a 'progress' flag to enable the regular + progress bar (as opposed to 'detailed-progress', which enables the + dots). Also add a 'nothing' flag to allow you to be explicit that + you don't want any logging on the command line. + + The default is + '--log detailed-progress,summary,unexpected,unexpected-results' + + (The default logging is unchanged by this patch, this just makes things + properly configurable). + + Note that 'nothing' doesn't work properly yet; I need a couple other + patches to land to avoid rewriting things several different ways. + + https://bugs.webkit.org/show_bug.cgi?id=37785 + + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + +2010-04-19 Kenneth Rohde Christiansen <kenneth@webkit.org> + + Reviewed by Simon Hausmann. + + Make the URL change on committed load. + + * QtLauncher/mainwindow.cpp: + (MainWindow::buildUI): + (MainWindow::setAddressUrl): + * QtLauncher/mainwindow.h: + +2010-04-19 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Eric Seidel. + + Fix a typo in the rebaselining tool that causes us to use "debug" + instead of "Debug" in a directory path, which fails on platforms with + case-sensitive filesystems. + + https://bugs.webkit.org/show_bug.cgi?id=37819 + + * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: + +2010-04-19 Dirk Pranke <dpranke@chromium.org> + + Unreviewed, build fix. + + Fix breakage of chromium-win canary bots caused by r57806. That patch + introduced the option of using Chrome's new port of DumpRenderTree, + but unfortunately that port relies on the webkit.py class + implementation which uses non-blocking I/O that isn't available on + Windows. This patch turns off that option and doesn't import the + class if we're running on Windows. + + https://bugs.webkit.org/show_bug.cgi?id=37817 + + * Scripts/webkitpy/layout_tests/port/chromium.py: + +2010-04-19 James Robinson <jamesr@chromium.org> + + Reviewed by abarth. + + Fix a typo + + * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: + +2010-04-19 Adam Roben <aroben@apple.com> + + Fix run-webkit-tests when there are spaces in the path + + Fixes <http://webkit.org/b/37809> + + Reviewed by Adam Barth. + + * Scripts/run-webkit-tests: Use an "indirect object" to specify the + path to the harness to exec(). According to perldoc, this usage will + prohibit perl from parsing the arguments to exec() via the shell, + which would incorrectly split paths with spaces in them, etc. + +2010-04-19 Dimitri Glazkov <dglazkov@chromium.org> + + Reviewed by Adam Roben. + + WinLauncher.h should use LF line-endings and use native line-endings style. + https://bugs.webkit.org/show_bug.cgi?id=37807 + + * WinLauncher/WinLauncher.h: Added property svn:eol-style, converted to LF line-endings. + +2010-04-19 Kent Tamura <tkent@chromium.org> + + Reviewed by Shinichiro Hamaji. + + [DRT/Chromium] Fix a test initialization problem + https://bugs.webkit.org/show_bug.cgi?id=37791 + + * DumpRenderTree/chromium/DumpRenderTree.cpp: + (runTest): Call resetTestController() before runFileTest(). Some + controllers initialize their fields in reset() and not in their + constructors. + +2010-04-19 Kent Tamura <tkent@chromium.org> + + Reviewed by Eric Seidel. + + [Chromium] new-run-webkit-tests should use WebKitDriver for --use-drt + https://bugs.webkit.org/show_bug.cgi?id=37793 + + We need to use WebKitDriver instead of ChromiumDriver for Chromium + DRT because its interface is different from test_shell. + + Chromium DRT has no UI. So we can't use it to show test results. + + * Scripts/webkitpy/layout_tests/port/chromium.py: + +2010-04-18 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Roben. + + Make failure-reason more forgiving + https://bugs.webkit.org/show_bug.cgi?id=37525 + + Removed search_limit, which wasn't very useful anyway. + Added a log about the long load time loading from the builders. + Prompt the user for what revision to start walking from (makes it easy to restart upon failure). + + * Scripts/webkitpy/common/net/buildbot.py: + * Scripts/webkitpy/tool/commands/queries.py: + +2010-04-18 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Shinichiro Hamaji. + + Created a class for check-webkit-style that encapsulates iterating + over text files and reading them. + + https://bugs.webkit.org/show_bug.cgi?id=37754 + + This revision is an intermediate step towards separating our + style-checking code from the logic of iterating over files and + reading them. + + * Scripts/webkitpy/common/system/logtesting.py: + - Added a logMessages() method to the LoggingTestCase class. + This method provides unit tests with access to the raw list + of log messages in case the tester needs to do something more + than simply assert the list of existing messages. + + * Scripts/webkitpy/style/checker.py: + - Added a ProcessorBase class that processors of lists of lines + should eventually inherit from. + - Also added a FIXME to use the ProcessorBase class and the + TextFileReader class added below. + + * Scripts/webkitpy/style/filereader.py: Added. + - Created a TextFileReader class that encapsulates reading + and iterating over text files. + + * Scripts/webkitpy/style/filereader_unittest.py: Added. + - Added a TextFileReaderTest class to unit-test the + new TextFileReader class. + +2010-04-15 Tony Chang <tony@chromium.org> + + Reviewed by Adam Barth. + + [chromium] new-run-webkit-tests should be able to use chromium DRT + https://bugs.webkit.org/show_bug.cgi?id=37645 + + Make sure that the lack of a chromium checkout doesn't cause the script to + fail. + + * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: + * Scripts/webkitpy/layout_tests/port/chromium.py: + * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Fix up a few paths + to be relative to an upstream output dir. + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --use-drt flag. + +2010-04-18 Eric Seidel <eric@webkit.org> + + Unreviewed, fixing the Qt bot. + + Add a layer of indirection when calling run-webkit-tests to allow testing new-run-webkit-tests on various platforms + https://bugs.webkit.org/show_bug.cgi?id=37632 + + * Scripts/run-webkit-tests: + - Exit non-zero of launching the harness fails. + +2010-04-18 Eric Seidel <eric@webkit.org> + + Unreviewed, fixing the Qt bot. + + Add a layer of indirection when calling run-webkit-tests to allow testing new-run-webkit-tests on various platforms + https://bugs.webkit.org/show_bug.cgi?id=37632 + + * Scripts/run-webkit-tests: + - Fix the wrapper to work for users who do not + have WebKitTools/Scripts in their path. + +2010-04-14 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + Add a layer of indirection when calling run-webkit-tests to + allow testing new-run-webkit-tests on various platforms. + https://bugs.webkit.org/show_bug.cgi?id=37632 + + This will let us test and fix bugs in new-run-webkit-tests + without needing to restart the buildbot master between tests. + + Currently this change leaves run-webkit-tests as-is, but once + its landed we will easily be able to turn on/off + new-run-webkit-tests for various ports/configurations. + + I will send a note out to webkit-dev about how we will + be using this launcher script to test on the bots. + + * Scripts/old-run-webkit-tests: Copied from WebKitTools/Scripts/run-webkit-tests. + * Scripts/run-webkit-tests: + - A new script which decides whether to run new- or old- + run-webkit-tests based on the platform. + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + - Add some dummy argument handling for arguments which + old-run-webkit-tests supports but new-run-webkit-tests + does not yet. + +2010-04-18 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + Add Gtk bots to the list of "core builders" (builders which stop the commit-queue when they turn red) + https://bugs.webkit.org/show_bug.cgi?id=33295 + + The Gtk builders have been green every time I've looked + at them in the last 5 days or so. It would appear webkit + is now keeping them green and we should update the core + builder list to match reality. + + * Scripts/webkitpy/common/net/buildbot.py: + * Scripts/webkitpy/common/net/buildbot_unittest.py: + +2010-04-18 Robert Hogan <robert@webkit.org> + + Reviewed by Simon Hausmann. + + [Qt] Add support for LayoutTestController commands: + setSmartInsertDeleteEnabled + setSelectTrailingWhitespaceEnabled + execCommand + isCommandEnabled + + https://bugs.webkit.org/show_bug.cgi?id=35844 + + * DumpRenderTree/qt/DumpRenderTreeQt.cpp: + (WebCore::WebPage::resetSettings): + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::setSmartInsertDeleteEnabled): + (LayoutTestController::setSelectTrailingWhitespaceEnabled): + (LayoutTestController::execCommand): + (LayoutTestController::isCommandEnabled): + * DumpRenderTree/qt/LayoutTestControllerQt.h: + +2010-04-17 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Remove steps_references and commands_references + https://bugs.webkit.org/show_bug.cgi?id=37758 + + We tried using the mumble_references convention to manage our + dependencies, but it doesn't seem to be providing much value for the + steps and commands module because these modules are small pieces of the + larger tool module. In this patch, I've removed the references file + for these modules. + + I've left the style_references file for the style module because that + module seems better isolated from the rest of webkitpy and the + style_references file appears to be providing some value. + + * Scripts/webkitpy/tool/commands/commandtest.py: + * Scripts/webkitpy/tool/commands/download_unittest.py: + * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: + * Scripts/webkitpy/tool/commands/queries_unittest.py: + * Scripts/webkitpy/tool/commands/queues_unittest.py: + * Scripts/webkitpy/tool/commands/queuestest.py: + * Scripts/webkitpy/tool/commands/upload.py: + * Scripts/webkitpy/tool/commands/upload_unittest.py: + * Scripts/webkitpy/tool/commands_references.py: Removed. + * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py: + * Scripts/webkitpy/tool/steps/steps_unittest.py: + * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py: + * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: + * Scripts/webkitpy/tool/steps_references.py: Removed. + +2010-04-17 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + WebKit needs a Chromium Mac EWS Builder + https://bugs.webkit.org/show_bug.cgi?id=37742 + + * Scripts/webkitpy/tool/commands/earlywarningsystem.py: + +2010-04-17 Adam Barth <abarth@webkit.org> + + Fix expected results for unit test broken by + http://trac.webkit.org/changeset/57772 + + * Scripts/webkitpy/common/net/buildbot_unittest.py: + +2010-04-17 Sam Weinig <weinig@apple.com> + + Reviewed by Adam Roben. + + Teach windows MiniBrowser how to work with window.open() + and targeted links. + + * MiniBrowser/win/BrowserView.cpp: + (createNewPage): Create a new BrowserWindow and return its page. + (showPage): Show the page. + (closePage): Empty implementation. + (runJavaScriptAlert): Empty implementation. + (BrowserView::create): Register a UIClient. + * MiniBrowser/win/BrowserView.h: + (BrowserView::webView): Added. + Change create to take a BrowserWindow instead of an HWND. + + * MiniBrowser/win/BrowserWindow.cpp: + (BrowserWindow::wndProc): Respond to WM_NCDESTROY. + (BrowserWindow::goToURL): Added. Forwards to BrowserView. + (BrowserWindow::onCreate): Don't always go to the default + url. Let the caller do this. + (BrowserWindow::onNCDestroy): Delete the window. + * MiniBrowser/win/BrowserWindow.h: + (BrowserWindow::view): Added. + (BrowserWindow::window): Added. + + * MiniBrowser/win/main.cpp: + (_tWinMain): + Go to the default URL for the initial page. Allocate the initial + window on the heap for correctness. + +2010-04-16 Adam Roben <aroben@apple.com> + + Add the Windows Debug (Test) builder to the list of core builders + + It's been green for a few days now, and all the known Windows + flakiness is Release-only. + + Rubber-stamped by Mark Rowe. + + * Scripts/webkitpy/common/net/buildbot.py: + (BuildBot.core_builder_name_regexps): Added a regular expression to + match the "Windows Debug (Test)" builder. + +2010-04-16 Sam Weinig <sam@webkit.org> + + Reviewed by Anders Carlsson. + + Fix window.open() and targeted links. + + * MiniBrowser/mac/BrowserWindowController.m: + (_createNewPage): Use the correct initializer to and load the window. + +2010-04-16 Adam Roben <aroben@apple.com> + + Fix links to layout test results from build status pages + + Reviewed by Mark Rowe. + + * BuildSlaveSupport/build.webkit.org-config/master.cfg: + (ExtractTestResults.finished): Prepend "/" on the URL of the test + results page so that it is treated as an absolute URL. + +2010-04-16 Tony Chang <tony@chromium.org> + + Reviewed by Dimitri Glazkov. + + [chromium] build DRT on Linux + https://bugs.webkit.org/show_bug.cgi?id=37690 + + * Scripts/build-dumprendertree: Add support for win and linux + +2010-04-16 Sam Weinig <weinig@apple.com> + + Reviewed by Adam Roben. + + Use the threaded process model for MiniBrowser if holding down + the shift key on startup. + + * MiniBrowser/win/BrowserView.cpp: + (BrowserView::create): + +2010-04-15 Tony Chang <tony@chromium.org> + + Reviewed by Dimitri Glazkov. + + [chromium] Add TestShellGtk.cpp so we can link on Linux + https://bugs.webkit.org/show_bug.cgi?id=37561 + + * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Add new file and + add platform file exceptions. + * DumpRenderTree/chromium/TestShellGtk.cpp: Added. + (AlarmHandler): + (TestShell::waitTestFinished): + +2010-04-15 Tony Chang <tony@chromium.org> + + Reviewed by Dimitri Glazkov. + + build DRT on chromium mac + https://bugs.webkit.org/show_bug.cgi?id=37639 + + * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: + * Scripts/build-dumprendertree: enable build-dumprendertree --chromium + +2010-04-15 Kent Tamura <tkent@chromium.org> + + Reviewed by Dimitri Glazkov. + + [DRT/Chromium] Add LayoutTestHelper for Mac + https://bugs.webkit.org/show_bug.cgi?id=37668 + + LayouTestHelper.mm is based on webkit/tools/test_shell/mac/layout_test_helper.mm + of Chromium. + + * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: + * DumpRenderTree/chromium/LayoutTestHelper.mm: Added. + +2010-04-15 Alexey Proskuryakov <ap@apple.com> + + Reviewed by Geoff Garen. + + https://bugs.webkit.org/show_bug.cgi?id=37494 + <rdar://problem/7857060> REGRESSION (r57340): fast/events/mouse-drag-from-frame-to-other-frame.html + fails on Windows + + * DumpRenderTree/win/EventSender.cpp: (makeEventSender): + * DumpRenderTree/win/EventSender.h: + Tell EventSender if it's being created for a top frame. + + * DumpRenderTree/win/FrameLoadDelegate.cpp: + (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld): We only want to reset + EventSender machinery when a new test is loaded, not when an iframe (or just its global + object) is created. + +2010-04-15 Adam Roben <aroben@apple.com> + + Fix Windows WebKit2 build. + + * MiniBrowser/win/MiniBrowser.cpp: + +2010-04-15 Ojan Vafai <ojan@chromium.org> + + Reviewed by Adam Barth. + + Include codereview issue number in patch description + https://bugs.webkit.org/show_bug.cgi?id=37677 + + This lets us know which rietveld issue this patch is tied to. + + Also, make it so that --fancy-review overrides --no-review. + + * Scripts/webkitpy/tool/steps/postcodereview.py: + * Scripts/webkitpy/tool/steps/postdiff.py: + +2010-04-15 Adam Roben <aroben@apple.com> + + Make --exit-after-n-failures work when all tests are timing out or crashing + + Fixes <http://webkit.org/b/37679>. + + Reviewed by Jon Honeycutt. + + * Scripts/run-webkit-tests: + (top level): When a test crashes or times out, break out of the main loop if + stopRunningTestsEarlyIfNeeded returns true. Moved some code from the bottom of the main loop + from here... + (stopRunningTestsEarlyIfNeeded): ...to here. + +2010-04-15 Sam Weinig <sam@webkit.org> + + Reviewed by Anders Carlsson. + + Add WebHistoryClient support. + https://bugs.webkit.org/show_bug.cgi?id=37671 + + Add HistoryClient logging. + + * MiniBrowser/mac/BrowserWindowController.m: + (_didNavigateWithNavigationData): + (_didPerformClientRedirect): + (_didPerformServerRedirect): + (_didUpdateHistoryTitle): + (-[BrowserWindowController awakeFromNib]): + +2010-04-15 Anders Carlsson <andersca@apple.com> + + Reviewed by Sam Weinig. + + Start the mini browser in threaded mode if shift is pressed during startup. + https://bugs.webkit.org/show_bug.cgi?id=37670 + + * MiniBrowser/mac/AppDelegate.m: + (-[BrowserAppDelegate init]): + +2010-04-15 Chris Fleizach <cfleizach@apple.com> + + Reviewed by Beth Dakin. + + AXHelp is being appended from ancestors incorrectly + https://bugs.webkit.org/show_bug.cgi?id=37659 + + * DumpRenderTree/AccessibilityUIElement.cpp: + (getHelpTextCallback): + (AccessibilityUIElement::getJSClass): + * DumpRenderTree/AccessibilityUIElement.h: + * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: + (AccessibilityUIElement::helpText): + * DumpRenderTree/mac/AccessibilityUIElementMac.mm: + (AccessibilityUIElement::helpText): + * DumpRenderTree/win/AccessibilityUIElementWin.cpp: + (AccessibilityUIElement::helpText): + +2010-04-15 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Adam Barth. + + Re-format run-webkit-tests to fit in 80-columns for PEP-8 compliance. + (broken by r57463 and r57381, at least). I've also filed bug 37477 + to fix check-webkit-style to catch these things. + + https://bugs.webkit.org/show_bug.cgi?id=38586 + + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + +2010-04-15 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Dimitri Glazkov. + + Add a way to override the user-visible name for the test binary since + some ports don't call it DumpRenderTree (e.g., Chromium Win uses + test_shell, Chromium Mac uses TestShell) by adding a driver_name() + method to the Port interface. + + https://bugs.webkit.org/show_bug.cgi?id=37631 + + * Scripts/webkitpy/layout_tests/port/base.py: + * Scripts/webkitpy/layout_tests/port/chromium.py: + * Scripts/webkitpy/layout_tests/port/chromium_mac.py: + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + +2010-04-14 Anders Carlsson <andersca@apple.com> + + Reviewed by Adam Roben. + + Add "Force Repaint" to debug menu. + https://bugs.webkit.org/show_bug.cgi?id=37627 + + * MiniBrowser/mac/BrowserWindowController.h: + * MiniBrowser/mac/BrowserWindowController.m: + (-[BrowserWindowController forceRepaint:]): + * MiniBrowser/mac/English.lproj/MainMenu.xib: + +2010-04-15 Sam Weinig <sam@webkit.org> + + Reviewed by Adam Roben. + + Add debug-minibrowser script. + + * Scripts/debug-minibrowser: Copied from Scripts/run-minibrowser. + * Scripts/webkitdirs.pm: + +2010-04-15 Roland Steiner <rolandsteiner@chromium.org> + + Reviewed by Dimitri Glazkov. + + Bug 37636 - [DRT/Chromium] Implement DRT/Chromium for Windows + https://bugs.webkit.org/show_bug.cgi?id=37636 + + Second patch: add Windows-specific implementation parts + of TestShell. + + * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: + * DumpRenderTree/chromium/TestShell.h: + (TestShell::finishedEvent): + * DumpRenderTree/chromium/TestShellWin.cpp: + (watchDogThread): + (TestShell::waitTestFinished): + +2010-04-15 Roland Steiner <rolandsteiner@chromium.org> + + Reviewed by Dimitri Glazkov. + + Bug 37636 - [DRT/Chromium] Implement DRT/Chromium for Windows + https://bugs.webkit.org/show_bug.cgi?id=37636 + + First patch: fix compiler errors. + + * DumpRenderTree/chromium/EventSender.cpp: + (EventSender::reset): + (EventSender::dispatchMessage): + * DumpRenderTree/chromium/LayoutTestController.cpp: + (LayoutTestController::pathToLocalResource): + * DumpRenderTree/chromium/TestWebWorker.h: + * DumpRenderTree/chromium/TextInputController.cpp: + * DumpRenderTree/chromium/WebViewHost.h: + * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: + +2010-04-14 Luiz Agostini <luiz.agostini@openbossa.org> + + Reviewed by Simon Hausmann. + + [Qt] Moving setViewMode from DumpRenderTreeSupportQt to qwebpage.cpp + https://bugs.webkit.org/show_bug.cgi?id=37622 + + Method qt_wrt_setViewMode was removed from qwebpage.cpp by mistake in r57433 + (bug 35844). Moving it back. + + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::setViewModeMediaFeature): + +2010-04-15 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Adam Barth. + + Add some very minimal unit tests for new-run-webkit-tests. This should + be enough to catch egregious brokenness like syntax errors and import + declaration issues. + + https://bugs.webkit.org/show_bug.cgi?id=37432 + + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Added. + +2010-04-14 Brian Weinstein <bweinstein@apple.com> + + Reviewed by Adam Roben. + + Add a way for the buildbot to kill any old processes that are running. This + is useful because the Windows bots can get in states where a process remains + running (httpd.exe, DumpRenderTree.exe), which causes the bots to get in a red + state, and the processes must be killed manually. + + * BuildSlaveSupport/build.webkit.org-config/master.cfg: If we are on Windows, kill + the old processes that might be running. + * BuildSlaveSupport/win/kill-old-processes: Added. + +2010-04-14 Sam Weinig <sam@webkit.org> + + Reviewed by Anders Carlsson. + + Tear down WebKit more completely on window closing and application + termination. We still don't block application termination for pending + close, but this is a step in the right direction. + + * MiniBrowser/mac/AppDelegate.m: + (-[BrowserAppDelegate applicationWillTerminate:]): + * MiniBrowser/mac/BrowserWindowController.h: + * MiniBrowser/mac/BrowserWindowController.m: + (-[BrowserWindowController dealloc]): + (-[BrowserWindowController windowWillClose:]): + (-[BrowserWindowController applicationTerminating]): + +2010-04-14 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Use pretty patch for confirming webkit-patch diffs + https://bugs.webkit.org/show_bug.cgi?id=37489 + + * Scripts/webkitpy/common/prettypatch.py: Added. + * Scripts/webkitpy/tool/commands/download_unittest.py: + * Scripts/webkitpy/tool/commands/upload_unittest.py: + * Scripts/webkitpy/tool/mocktool.py: + * Scripts/webkitpy/tool/steps/confirmdiff.py: + +2010-04-14 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + Teach webkit-patch how to handle revisions missing ChangeLogs + https://bugs.webkit.org/show_bug.cgi?id=37519 + + Make commit_info_for_revision return None when revision + is missing a ChangeLog. Previously we would throw an array index + exception. + Teach callers how to handle None. + + * Scripts/webkitpy/common/checkout/api.py: + * Scripts/webkitpy/common/checkout/api_unittest.py: + * Scripts/webkitpy/tool/commands/download.py: + * Scripts/webkitpy/tool/commands/queries.py: + * Scripts/webkitpy/tool/commands/sheriffbot.py: + +2010-04-13 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Roben. + + Add Qt Bot to the list of "core builders" (builders which block the commit-queue when red) + https://bugs.webkit.org/show_bug.cgi?id=33297 + + This is an experiment. The bots have been green for + a while. We'll see if adding them under sheriff-bot protection + will keep them green. + + * Scripts/webkitpy/common/net/buildbot.py: + * Scripts/webkitpy/common/net/buildbot_unittest.py: + +2010-04-13 Eric Seidel <eric@webkit.org> + + Unreviewed, just fixing a constant in the Rietveld unit test. + + * Scripts/webkitpy/common/net/rietveld_unittest.py + +2010-04-13 Eric Seidel <eric@webkit.org> + + Unreviewed, just adding missing Mock to fix python tests. + + * Scripts/webkitpy/tool/mocktool.py: + +2010-04-13 Ojan Vafai <ojan@chromium.org> + + Reviewed by David Levin. + + Add experimental prototype Rietveld integration to webkit-patch upload + https://bugs.webkit.org/show_bug.cgi?id=37418 + + This patch adds bare-bones integration with Rietveld for code reviews. + The behavior is hidden behind the --fancy-review command line flag. + Currently, there's no support for uploading more than one patch per + issue (which is a nice feature of Rietveld). The plan is to play with + this for a bit and see if it's useful. + + Modified from Adam's original patch to autoinstall the rietveld upload script. + + * Scripts/webkitpy/common/config/__init__.py: + * Scripts/webkitpy/common/net/rietveld.py: Added. + * Scripts/webkitpy/common/net/rietveld_unitttest.py: Added. + * Scripts/webkitpy/tool/commands/queues_unittest.py: + * Scripts/webkitpy/tool/commands/upload.py: + * Scripts/webkitpy/tool/commands/upload_unittest.py: + * Scripts/webkitpy/tool/main.py: + * Scripts/webkitpy/tool/mocktool.py: + * Scripts/webkitpy/tool/steps/__init__.py: + * Scripts/webkitpy/tool/steps/options.py: + * Scripts/webkitpy/tool/steps/postcodereview.py: Added. + * Scripts/webkitpy/tool/steps/postdiff.py: + +2010-04-13 Sam Weinig <sam@webkit.org> + + Rubber-stamped by Mark Rowe. + + Add Makefile to MiniBrowser. + + * MiniBrowser/Makefile: Added. + +2010-04-13 Eric Seidel <eric@webkit.org> + + Unreviewed, just adding a sanity check. + + Add check to make sure commit-queue can never commit too short a message + https://bugs.webkit.org/show_bug.cgi?id=37528 + + The commit-queue made bogus messages here: + http://trac.webkit.org/changeset/57532 + http://trac.webkit.org/changeset/57534 + + This was a regression caused by adding unicode parsing for + our ChangeLog files. Popen does not seem to play nice with + unicode strings. + + I'm also adding an "assert" to make sure short ChangeLogs never happen again. + + * Scripts/webkitpy/common/system/executive.py: + - Cast input to strings before passing to POpen + * Scripts/webkitpy/tool/steps/commit.py: + - Validate that commit messages are not to short. + +2010-04-13 Adam Roben <aroben@apple.com> + + Robustify new-run-webkit-tests against paths with spaces in them + + Reviewed by Eric Seidel. + + * Scripts/webkitpy/layout_tests/port/apache_http_server.py: + (LayoutTestApacheHttpd.__init__): Quote all paths that we pass to + Apache to ensure that paths with spaces in them are interpreted + correctly. + +2010-04-13 Csaba Osztrogonác <ossy@webkit.org> + + Unreviewed buildfix after r57537. + + * DumpRenderTree/qt/LayoutTestControllerQt.h: Declaration of removeOriginAccessWhitelistEntry() added. + +2010-04-13 Sam Weinig <sam@webkit.org> + + Reviewed by Maciej Stachowiak. + + Make building new webkit API and MiniBrowser a little easier. + + * Scripts/build-webkit: Make building with --webkit2 build the + MiniBrowser as well and tell you how to use it. + * Scripts/run-minibrowser: Copied from Scripts/run-safari. + * Scripts/webkitdirs.pm: Add runMiniBrowser function. + +2010-04-12 Timothy Hatcher <timothy@apple.com> + + SecurityOrigin needs a way to remove individual OriginAccessEntries + https://bugs.webkit.org/show_bug.cgi?id=37449 + + Reviewed by Dave Hyatt. + + * DumpRenderTree/LayoutTestController.cpp: + (removeOriginAccessWhitelistEntryCallback): Added. Call LayoutTestController::removeOriginAccessWhitelistEntry. + (LayoutTestController::staticFunctions): Added removeOriginAccessWhitelistEntry. + * DumpRenderTree/LayoutTestController.h: + * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: + (LayoutTestController::removeOriginAccessWhitelistEntry): Added. FIXME to implement. + * DumpRenderTree/mac/LayoutTestControllerMac.mm: + (LayoutTestController::removeOriginAccessWhitelistEntry): Added. + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::removeOriginAccessWhitelistEntry): Added. FIXME to implement. + * DumpRenderTree/win/LayoutTestControllerWin.cpp: + (LayoutTestController::removeOriginAccessWhitelistEntry): Added. + * DumpRenderTree/wx/LayoutTestControllerWx.cpp: + (LayoutTestController::whiteListAccessFromOrigin): FIXME to implement. + (LayoutTestController::removeOriginAccessWhitelistEntry): Added. FIXME to implement. + +2010-04-13 Timothy Hatcher <timothy@apple.com> + + Rename SecurityOrigin::whiteListAccessFromOrigin to addOriginAccessWhitelistEntry. + And LayoutTestController.whiteListAccessFromOrigin to addOriginAccessWhitelistEntry. + And SecurityOrigin::resetOriginAccessWhiteLists to resetOriginAccessWhitelists. + + SecurityOrigin needs a way to remove individual OriginAccessEntries + https://bugs.webkit.org/show_bug.cgi?id=37449 + + Reviewed by Dave Hyatt. + + * DumpRenderTree/LayoutTestController.cpp: + (addOriginAccessWhitelistEntryCallback): + (LayoutTestController::staticFunctions): + * DumpRenderTree/LayoutTestController.h: + * DumpRenderTree/chromium/LayoutTestController.cpp: + (LayoutTestController::LayoutTestController): + (LayoutTestController::addOriginAccessWhitelistEntry): + * DumpRenderTree/chromium/LayoutTestController.h: + * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: + (LayoutTestController::addOriginAccessWhitelistEntry): + * DumpRenderTree/mac/DumpRenderTree.mm: + (resetWebViewToConsistentStateBeforeTesting): + * DumpRenderTree/mac/LayoutTestControllerMac.mm: + (LayoutTestController::addOriginAccessWhitelistEntry): + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::addOriginAccessWhitelistEntry): + * DumpRenderTree/qt/LayoutTestControllerQt.h: + * DumpRenderTree/win/DumpRenderTree.cpp: + (resetWebViewToConsistentStateBeforeTesting): + * DumpRenderTree/win/LayoutTestControllerWin.cpp: + (LayoutTestController::addOriginAccessWhitelistEntry): + * DumpRenderTree/wx/LayoutTestControllerWx.cpp: + (LayoutTestController::addOriginAccessWhitelistEntry): + +2010-04-13 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> + + Reviewed by Eric Seidel. + + Remove duplicate function for new-run-webkit-tests + https://bugs.webkit.org/show_bug.cgi?id=37517 + + The version() function was already implemented. + + * Scripts/webkitpy/layout_tests/port/webkit.py: + +2010-04-13 Eric Seidel <eric@webkit.org> + + Reviewed by David Levin. + + the commit-queue hates Tor Arne Vestbø + https://bugs.webkit.org/show_bug.cgi?id=37511 + + We were failing to read reviewers out of ChangeLogs + when the reviewer has unicode characters in his/her name. + I fixed this by explicitly decoding from utf8 every time we + read in a ChangeLog file (they are always UTF8). + + * Scripts/webkitpy/common/checkout/changelog.py: + * Scripts/webkitpy/common/checkout/changelog_unittest.py: + +2010-04-13 Adam Roben <aroben@apple.com> + + Fix run-webkit-tests on Windows with spaces in the path + + Fixes <http://webkit.org/b/37509>. + + Reviewed by Steve Falkenburg. + + * Scripts/run-webkit-tests: + (convertPathUsingCygpath): Remove spaces from the path before passing + them to cygpath, then add them back in after conversion, as some + versions of cygpath seem to convert spaces into newlines. + +2010-04-13 Adam Barth <abarth@webkit.org> + + Unreviewed, but approved by Dumitru Daniliuc. (This patch is intended + to fix the downstream Chromium build bots. Hopefully it will work!) + + Add a driver script for the new websocket server + https://bugs.webkit.org/show_bug.cgi?id=37495 + + websocket_server.py can't be run directly because its a module and not + a standalone script. This used to work by accident because it didn't + depend on any other modules. + + * Scripts/new-run-webkit-websocketserver: Added. + * Scripts/webkitpy/layout_tests/port/websocket_server.py: + +2010-04-12 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + Make new-run-webkit-test PrettyPatch failure reporting more awesome + https://bugs.webkit.org/show_bug.cgi?id=37487 + + I also fixed an Executive/executive typo. + + * Scripts/webkitpy/layout_tests/port/base.py: + +2010-04-12 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + new-run-webkit-tests should only build java support files on Mac + https://bugs.webkit.org/show_bug.cgi?id=37482 + + Only the mac needs java support files, so I pushed _build_java + down into the Mac port using a new hook "_check_port_build". + In the process I noticed a bunch of code which could be shared + between all ports and thus got rid of _tests_for_disabled_features + and version() copy/paste between all webkit ports. + I also made check_build only bother to check for ImageDiff if we're + using pixel tests. + + * Scripts/webkitpy/layout_tests/port/gtk.py: + * Scripts/webkitpy/layout_tests/port/mac.py: + * Scripts/webkitpy/layout_tests/port/qt.py: + * Scripts/webkitpy/layout_tests/port/webkit.py: + * Scripts/webkitpy/layout_tests/port/win.py: + +2010-04-12 Dumitru Daniliuc <dumi@chromium.org> + + Unreviewed, trying to make scripts work on machines without + Ruby... + + * Scripts/webkitpy/layout_tests/port/base.py: + +2010-04-12 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> + + Reviewed by Eric Seidel. + + Add stub files for running new-run-webkit-tests for the Qt port + + * Scripts/webkitpy/layout_tests/port/factory.py: + * Scripts/webkitpy/layout_tests/port/qt.py: Added. + +2010-04-12 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Eric Seidel. + + Modify run_webkit_tests.py to not call sys.exit() at the end of test + run; doing so makes it more difficult to embed the routine for, + among other things, unit tests. We push the exit calling up into + new-run-webkit-tests. + + https://bugs.webkit.org/show_bug.cgi?id=37464 + + * Scripts/new-run-webkit-tests: + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + +2010-04-12 Eric Seidel <eric@webkit.org> + + Unreviewed. + + Add stub Gtk implementation for new-run-webkit-tests. + + * Scripts/webkitpy/layout_tests/port/factory.py: + * Scripts/webkitpy/layout_tests/port/gtk.py: Added. + +2010-04-12 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + new-run-webkit-tests fails with exception on systems missing ruby + https://bugs.webkit.org/show_bug.cgi?id=37441 + + * Scripts/webkitpy/layout_tests/port/base.py: + - Catch failures similar to how wdiff code path does. + - After one failure, stop trying. + +2010-04-12 Tony Chang <tony@chromium.org> + + Reviewed by Eric Seidel. + + Fix how we import simplejson based on how it's used in this file. + This fixes exceptions raised when trying to write the simplejson output. + + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + +2010-04-11 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Shinichiro Hamaji. + + Refactored check-webkit-style so that the StyleChecker class + has no dependencies on patch-related concepts. + + https://bugs.webkit.org/show_bug.cgi?id=37065 + + This patch is an intermediate step towards making the StyleChecker + class a generalized file processor that can do arbitary operations + on the files corresponding to a list of paths. This patch + also simplifies the unit-testing of patch-checking code. + + * Scripts/check-webkit-style: + - Updated to use the new PatchChecker class. + + * Scripts/webkitpy/style/checker.py: + - Refactored the StyleChecker.check_patch() method into the + check() method of a new PatchChecker class. + + * Scripts/webkitpy/style/checker_unittest.py: + - Refactored the unit tests as necessary, changing the + StyleCheckerCheckPatchTest class to a PatchCheckerTest class. + +2010-04-11 Adam Barth <abarth@webkit.org> + + Unreviewed. + + Fix new-run-webkit-tests regressions cased by Eric's option parsing patch + https://bugs.webkit.org/show_bug.cgi?id=37430 + + We need some basic unit testing of this script, or we're going to keep + breaking it like this. Added missing namespace qualifiers and + propagated renaming of an option. + + * Scripts/webkitpy/common/config/ports.py: + * Scripts/webkitpy/layout_tests/driver_test.py: + * Scripts/webkitpy/layout_tests/port/base.py: + * Scripts/webkitpy/layout_tests/port/mac.py: + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + +2010-04-11 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + Break new-run-webkit-tests options into groups for easier re-use and possible relocation + https://bugs.webkit.org/show_bug.cgi?id=37408 + + new-run-webkit-tests currently has one huge function for + dealing with all options-parsing. + This patch is a first attempt at trying to split that large + function down into smaller (hopefully more readable?) chunks + dealing with the different areas of options. + For example, it would make sense to move configuration + options off into some module which deals with the vagries of + WebKit's configuration system. It would also make sense to move + Chromium options off onto the Chromium port object (where they are used). + It may make sense to move results.json options over to the results.json code. + This change is a first iteration, and we will certainly need more + refinement to this code over time. Hopefully I didn't make things + harder to read here. + + * Scripts/webkitpy/layout_tests/driver_test.py: + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + +2010-04-11 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + create-rollout copy needs to be updated to reflect removal of --no-build + https://bugs.webkit.org/show_bug.cgi?id=37425 + + Removed --no-build and --no-test from the instructions because these + don't exist anymore. + + * Scripts/webkitpy/tool/commands/download_unittest.py: + - Updated the expected results to reflect the new copy. + * Scripts/webkitpy/tool/steps/postdiffforrevert.py: + +2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r57460. + http://trac.webkit.org/changeset/57460 + https://bugs.webkit.org/show_bug.cgi?id=37424 + + broke chromium builders (Requested by tony^work on #webkit). + + * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: + +2010-04-11 Tony Chang <tony@chromium.org> + + Reviewed by Darin Fisher. + + [chromium] update chromium DEPS for upstream compile + https://bugs.webkit.org/show_bug.cgi?id=36578 + + * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Small fix to avoid a circular dependency between + WebKit.gyp and webkit.gyp. + +2010-04-11 Joseph Pecoraro <joepeck@webkit.org> + + Reviewed by Eric Seidel. + + svn-apply errors out when removing directories in git + https://bugs.webkit.org/show_bug.cgi?id=34871 + + * Scripts/svn-apply: + (isDirectoryEmptyForRemoval): early break if the directory doesn't exist + (scmRemove): have git ignore unmatched files + +2010-04-11 Daniel Bates <dbates@rim.com> + + No review, rolling out 57440. + http://trac.webkit.org/changeset/57440 + https://bugs.webkit.org/show_bug.cgi?id=27204 + + Did not handle Git patches that included both file and property + changes to the same file. Rolling this change out while I look + into this. + + * Scripts/VCSUtils.pm: + * Scripts/svn-apply: + * Scripts/svn-unapply: + * Scripts/webkitperl/VCSUtils_unittest/appendSVNExecutableBitChangeToPatch.pl: Removed. + * Scripts/webkitperl/VCSUtils_unittest/parseGitFileMode.pl: Removed. + * Scripts/webkitperl/VCSUtils_unittest/parseStartOfPatchOrPropertyChangeAndEndOfPropertyChange.pl: Removed. + +2010-04-11 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Fix typo in log path for AbstractQueue + https://bugs.webkit.org/show_bug.cgi?id=37414 + + * Scripts/webkitpy/tool/commands/queues.py: + * Scripts/webkitpy/tool/commands/queues_unittest.py: + +2010-04-11 Adam Barth <abarth@webkit.org> + + Unreviewed. Add missing import statement. + + * Scripts/webkitpy/common/system/executive.py: + +2010-04-11 Robert Hogan <robert@webkit.org> + + Reviewed by Simon Hausmann. + + [Qt] Add setWillSendRequestReturnsNull and setWillSendRequestClearHeader + + https://bugs.webkit.org/show_bug.cgi?id=37410 + + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::reset): + (LayoutTestController::setWillSendRequestReturnsNull): + (LayoutTestController::setWillSendRequestClearHeader): + * DumpRenderTree/qt/LayoutTestControllerQt.h: + +2010-04-11 Csaba Osztrogonác <ossy@webkit.org> + + [Qt] Unreviewed buildfix for --debug build after r57433. + + Refactor Qt DRT support in QtWebKit + https://bugs.webkit.org/show_bug.cgi?id=35844 + + * QtLauncher/main.cpp: qt_drt_garbageCollector_collect(); renamed to DumpRenderTreeSupportQt::garbageCollectorCollect(); + (launcherMain): + +2010-04-11 Joseph Pecoraro <joepeck@webkit.org> + + Reviewed by Mark Rowe. + + Make commit-log-editor Rubber-stamp aware. And other minor cleanups. + https://bugs.webkit.org/show_bug.cgi?id=37407 + + * Scripts/commit-log-editor: + +2010-04-11 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + Add PrettyPatch links to new-run-webkit-tests output + https://bugs.webkit.org/show_bug.cgi?id=37406 + + * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: + - We're leaking a file handle here, add a FIXME. + * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: + - Add pretty diff links. + * Scripts/webkitpy/layout_tests/port/base.py: + - Add support for generating pretty diffs using PrettyPatch. + * Scripts/webkitpy/layout_tests/port/webkit.py: + - We're leaking another file handle here, another FIXME. + * Scripts/webkitpy/layout_tests/test_types/image_diff.py: + - Update write_output_files signature. + * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: + - Remove unused arguments from write_output_files. + - Add support for dumping pretty diffs to write_output_files. + - Fix a bunch of file descriptor leaks in this file. + * Scripts/webkitpy/layout_tests/test_types/text_diff.py: + - Update write_output_files signature. + +2010-04-10 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + kill_process is copy/pasted in five places + https://bugs.webkit.org/show_bug.cgi?id=37405 + + We shouldn't replicate the kill_process logic in every port. Instead, + we should move the process interaction to Executive. + + Dirk mentioned that he wanted this abstraction to make it easier to + mock things out for testing. It turns out this function is only used + in one place where it can't be used as a mock point for testing because + the corresponding create process actually creates a real process. In + the long term, we should indirect both these calls through a non-static + Executive as a mock point. However, we should wait on that until we + actually want to write the test. + + * Scripts/webkitpy/layout_tests/port/base.py: + * Scripts/webkitpy/layout_tests/port/chromium_linux.py: + * Scripts/webkitpy/layout_tests/port/chromium_mac.py: + * Scripts/webkitpy/layout_tests/port/chromium_win.py: + * Scripts/webkitpy/layout_tests/port/mac.py: + * Scripts/webkitpy/layout_tests/port/websocket_server.py: + * Scripts/webkitpy/layout_tests/port/win.py: + +2010-04-10 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + new-run-webkit-tests shouldn't alter its path to import packages + https://bugs.webkit.org/show_bug.cgi?id=37404 + + * Scripts/new-run-webkit-tests: + * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: + * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: + * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: + * Scripts/webkitpy/layout_tests/test_types/image_diff.py: + * Scripts/webkitpy/layout_tests/test_types/text_diff.py: + * Scripts/webkitpy/thirdparty/simplejson/decoder.py: + +2010-04-10 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + new-run-webkit-tests should store results to a directory under the build tree + https://bugs.webkit.org/show_bug.cgi?id=37380 + + * Scripts/webkitpy/layout_tests/port/webkit.py: + +2010-04-10 Daniel Bates <dbates@rim.com> + + Reviewed by Eric Seidel. + + https://bugs.webkit.org/show_bug.cgi?id=27204 + + Implement support for changing the executable bit of a file. + The executable bit is among the most changed file properties. + Future support can include other property changes. + + Currently, if a patch changes the executable bit of a file + it is not respected by svn-apply or svn-unapply. Since the + commit-queue bot uses these tools as part of its workflow, + such patches cannot be committed by it. That is, such patches + need to be committed by hand. Instead, we should add support + for the executable bit so that such patches can be committed + by the commit-queue bot. + + * Scripts/VCSUtils.pm: Also change reference to Apple Computer, Inc. + in copyright to Apple, Inc. + * Scripts/svn-apply: + * Scripts/svn-unapply: + * Scripts/webkitperl/VCSUtils_unittest/appendSVNExecutableBitChangeToPatch.pl: Added. + * Scripts/webkitperl/VCSUtils_unittest/parseGitFileMode.pl: Added. + * Scripts/webkitperl/VCSUtils_unittest/parseStartOfPatchOrPropertyChangeAndEndOfPropertyChange.pl: Added. + +2010-04-10 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + WinEWS bot fails to svn update because scm.clean_working_directory leaves files around + https://bugs.webkit.org/show_bug.cgi?id=37401 + + The Git-based bots don't have this trouble because + Git.clean_working_directory fully removes files that were + marked as "add". SVN.clean_working_directory previously just + called "svn revert" which would leave added files in the + working directory untracked. This patch makes + SVN.clean_working_directory function more like + Git.clean_working_directory by removing added files after revert. + + * Scripts/webkitpy/common/checkout/scm.py: + - Add SCM.absolute_path for easy conversion between + repository-relative paths and absolute paths. + - Add SCM.add and SCM.added_files + - Make SVN.clean_working_directory remove any added_files after svn revert. + - The new unit tests found a bug in Git.status_command, change to use git diff --name-status instead. + * Scripts/webkitpy/common/checkout/scm_unittest.py: + - Add tests for added code. + +2010-04-10 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + new-run-webkit-tests can't find ImageDiff on Windows + https://bugs.webkit.org/show_bug.cgi?id=37403 + + It turns out the build directory on Windows is structured differently + than it is on other platforms. Instead of assuming the normal + structure, we should just ask perl to figure it out for us. + + * Scripts/webkitpy/layout_tests/port/webkit.py: + +2010-04-10 Adam Barth <abarth@webkit.org> + + Rubber-stamped by Eric Seidel. + + Change "Gathering files" status line to "Collecting tests". Gathering + the files sounds silly to me. + + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + +2010-04-10 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Fix bugs to make new-run-webkit-tests almost run on windows + https://bugs.webkit.org/show_bug.cgi?id=37400 + + Fix some minor bugs that prevent new-run-webkit-tests from being run on + Windows. I still haven't run it to completion, but I'm getting + further. + + * Scripts/webkitpy/layout_tests/port/factory.py: + * Scripts/webkitpy/layout_tests/port/webkit.py: + +2010-04-10 Robert Hogan <robert@webkit.org> + + Reviewed by Kenneth Rohde Christiansen. + + Refactor Qt DRT support in QtWebKit + + Update Qt DRT to use new DumpRenderTreeSupportQt static class. + + https://bugs.webkit.org/show_bug.cgi?id=35844 + + * DumpRenderTree/qt/DumpRenderTreeQt.cpp: + (WebCore::DumpRenderTree::DumpRenderTree): + (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): + (WebCore::DumpRenderTree::dumpFramesAsText): + * DumpRenderTree/qt/DumpRenderTreeQt.h: + * DumpRenderTree/qt/GCControllerQt.cpp: + (GCController::collect): + (GCController::collectOnAlternateThread): + (GCController::getJSObjectCount): + * DumpRenderTree/qt/GCControllerQt.h: + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::counterValueForElementById): + (LayoutTestController::setViewModeMediaFeature): + (LayoutTestController::setMediaType): + (LayoutTestController::closeWebInspector): + (LayoutTestController::showWebInspector): + (LayoutTestController::evaluateInWebInspector): + (LayoutTestController::setFrameFlatteningEnabled): + (LayoutTestController::setJavaScriptProfilingEnabled): + (LayoutTestController::setTimelineProfilingEnabled): + (LayoutTestController::pauseAnimationAtTimeOnElementWithId): + (LayoutTestController::pauseTransitionAtTimeOnElementWithId): + (LayoutTestController::sampleSVGAnimationForElementAtTime): + (LayoutTestController::numberOfActiveAnimations): + (LayoutTestController::whiteListAccessFromOrigin): + (LayoutTestController::setCaretBrowsingEnabled): + (LayoutTestController::setDomainRelaxationForbiddenForURLScheme): + (LayoutTestController::workerThreadCount): + (LayoutTestController::pageNumberForElementById): + (LayoutTestController::numberOfPages): + * DumpRenderTree/qt/LayoutTestControllerQt.h: + +2010-04-10 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Move global queue log to the logs directory so it survives git clean -f + https://bugs.webkit.org/show_bug.cgi?id=37395 + + * Scripts/webkitpy/tool/commands/queues.py: + +2010-04-10 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + SheriffBot should spam when it encounters errors + https://bugs.webkit.org/show_bug.cgi?id=37329 + + We need to always update the status server so we don't get stuck in a + spam loop. I tried writing a test for this change, but it kind of + got out of control. We need a better way to do failure injection. + + * Scripts/webkitpy/tool/commands/sheriffbot.py: + +2010-04-10 Adam Barth <abarth@webkit.org> + + Unreviewed attempt to fix the Chromium Mac canary. + + * Scripts/webkitpy/common/config/ports.py: + * Scripts/webkitpy/common/config/ports_unittest.py: + * Scripts/webkitpy/common/system/executive.py: + +2010-04-10 Adam Barth <abarth@webkit.org> + + Unreviewed. + + Add the Apache bits to win.py for new-run-webkit-tests + https://bugs.webkit.org/show_bug.cgi?id=37397 + + I still have run this yet, but I looked around to figure out what the + various paths appear to be. I'll figure out a way to remove the + copy/paste code in a future patch. + + * Scripts/webkitpy/layout_tests/port/mac.py: + * Scripts/webkitpy/layout_tests/port/webkit.py: + * Scripts/webkitpy/layout_tests/port/win.py: + +2010-04-10 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Sketch out the win port for new-run-webkit-tests + https://bugs.webkit.org/show_bug.cgi?id=37393 + + I haven't tried running this yet, but we've got to start somewhere. + + * Scripts/webkitpy/layout_tests/port/factory.py: + * Scripts/webkitpy/layout_tests/port/mac.py: + * Scripts/webkitpy/layout_tests/port/webkit.py: + * Scripts/webkitpy/layout_tests/port/win.py: Added. + +2010-04-10 Ojan Vafai <ojan@chromium.org> + + Reviewed by Adam Barth. + + webkit-patch land should not build and test by default + https://bugs.webkit.org/show_bug.cgi?id=33631 + + Reverse the sense of --no-build and --no-test to be --build and --test. + Also, decoupled the build and test options so you can test without + building. + + (Patch manngled by Adam Barth. All bugs are his fault.) + + * Scripts/webkitpy/tool/commands/earlywarningsystem.py: + * Scripts/webkitpy/tool/commands/queues.py: + * Scripts/webkitpy/tool/commands/queues_unittest.py: + * Scripts/webkitpy/tool/steps/options.py: + * Scripts/webkitpy/tool/steps/runtests.py: + +2010-04-10 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Factor WebKitPort out of MacPort to allow for WinPort + https://bugs.webkit.org/show_bug.cgi?id=37388 + + The split is a bit of a guess. We might have to adjust things once we + actually have a second port to work with. + + * Scripts/webkitpy/layout_tests/port/apache_http_server.py: + * Scripts/webkitpy/layout_tests/port/mac.py: + * Scripts/webkitpy/layout_tests/port/webkit.py: Added. + * Scripts/webkitpy/layout_tests/port/websocket_server.py: + +2010-04-10 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + run_webkit_tests.py shouldn't have platform-specific logic + https://bugs.webkit.org/show_bug.cgi?id=37387 + + Dirk Pranke pointed out that my last patch was wrong because I + introduced platform-specific logic into run_webkit_tests.py, limiting + the parallelism in Chromium to work around a bug in the main Mac port. + + * Scripts/webkitpy/common/system/executive.py: + - Fix a typo pointed out by Chris Jerdonek. + * Scripts/webkitpy/layout_tests/port/base.py: + * Scripts/webkitpy/layout_tests/port/mac.py: + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + +2010-04-10 Robert Hogan <robert@webkit.org> + + Unreviewed fix to regressions in r57416. + + [Qt] Fix regressions in http/tests/navigation from r57416 + + Reset willSendRequestReturnsNullOnRedirect after each test to + prevent it leaking to subsequent tests. + + Error pointed out by Jakub Wieczorek. + + https://bugs.webkit.org/show_bug.cgi?id=37237 + + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::reset): + +2010-04-11 Robert Hogan <robert@webkit.org> + + Reviewed by Simon Hausmann. + + [Qt] Update layoutTestController.DumpResourceLoadCallbacks to match other ports. + + Add support for layoutTestController.setWillSendRequestReturnsNullOnRedirect to Qt DRT. + Prevent dumping resource load callbacks once layout test has dumped. + + https://bugs.webkit.org/show_bug.cgi?id=37237 + + * DumpRenderTree/qt/DumpRenderTreeQt.cpp: + (WebCore::DumpRenderTree::dump): + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::setWillSendRequestReturnsNullOnRedirect): + * DumpRenderTree/qt/LayoutTestControllerQt.h: + +2010-04-10 Laszlo Gombos <laszlo.1.gombos@nokia.com> + + Reviewed by Kenneth Rohde Christiansen. + + [Qt] Implement Desktop Notifications API for QtWebKit + https://bugs.webkit.org/show_bug.cgi?id=35503 + + DRT stubs for notification. Enables to run and pass + 3 (currently disabled) tests. + + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::LayoutTestController): + (LayoutTestController::grantDesktopNotificationPermission): + (LayoutTestController::checkDesktopNotificationPermission): + * DumpRenderTree/qt/LayoutTestControllerQt.h: + +2010-04-09 Dumitru Daniliuc <dumi@chromium.org> + + Unreviewed, another change to executive.py to make it run with + python 2.4. + + * Scripts/webkitpy/common/system/executive.py: + +2010-04-09 Dumitru Daniliuc <dumi@chromium.org> + + Unreviewed, attempting to make executive.py run with python 2.4 + (which is still used on Chromium's Windows canary bot). + + * Scripts/webkitpy/common/system/executive.py: + +2010-04-09 Kevin Watters <kevinwatters@gmail.com> + + Reviewed by Eric Seidel. + + [wx] Basic implementation of SVG support for wx port. + + * wx/build/settings.py: + +2010-04-09 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Don't reinvent Executive.cpu_count for every port + https://bugs.webkit.org/show_bug.cgi?id=37377 + + mac.py and chromium_mac.py had some copy/paste code. This code doesn't + actually have anything to do with WebKit ports. It's really just + something in the multiprocessing package. The lame bit is that package + isn't available in older versions of Python, so we need to implement a + fallback. However, we already have the fallback in common. We don't + need to reinvent it specificly for layout_tests. + + * Scripts/webkitpy/common/system/executive.py: + * Scripts/webkitpy/layout_tests/port/base.py: + * Scripts/webkitpy/layout_tests/port/chromium.py: + * Scripts/webkitpy/layout_tests/port/chromium_linux.py: + * Scripts/webkitpy/layout_tests/port/chromium_mac.py: + * Scripts/webkitpy/layout_tests/port/chromium_win.py: + * Scripts/webkitpy/layout_tests/port/mac.py: + * Scripts/webkitpy/layout_tests/port/test.py: + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + +2010-04-09 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + new-run-webkit-tests --release fails to build release DRT when global configuration is Debug + https://bugs.webkit.org/show_bug.cgi?id=37376 + + We need to explicitly pass the --release flag. I bet there are more + instances of this bug. + + * Scripts/webkitpy/layout_tests/port/base.py: + * Scripts/webkitpy/layout_tests/port/mac.py: + +2010-04-09 Tony Chang <tony@chromium.org> + + Reviewed by Eric Seidel. + + [chromium] DRT compile fix on win/linux + https://bugs.webkit.org/show_bug.cgi?id=37314 + + Looks like this was missed when upstreaming. + + * DumpRenderTree/chromium/EventSender.cpp: + (applyKeyModifier): + +2010-04-09 Adam Barth <abarth@webkit.org> + + Unreviewed, but approved by Dirk Pranke. + + rename test_expectations_test.py to test_expectations_unittest.py so it actually gets run + https://bugs.webkit.org/show_bug.cgi?id=37372 + + We need to end unit tests with _unittest.py for them to be autodetected + by the test harness. +6 tests. + + * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/test_expectations_test.py. + +2010-04-09 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + new-run-webkit-tests should talk about DumpRenderTree not test_shell + https://bugs.webkit.org/show_bug.cgi?id=37371 + + test_shell is some strange Chromium thing. + DumpRenderTree (tm) is the real deal. + + * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: Added. + * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: + * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: + * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: Removed. + * Scripts/webkitpy/layout_tests/port/chromium.py: + * Scripts/webkitpy/layout_tests/port/server_process.py: + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + +2010-04-09 Zoltan Horvath <zoltan@webkit.org> + + Reviewed by Alexey Proskuryakov. + + Fix 2 issues (what were introduced in r56524) in svn-create-patch's generateDiff() + https://bugs.webkit.org/show_bug.cgi?id=32582 + + Add missing return variable. Initialize $patch variable and remove unnecessary condition. + + * Scripts/svn-create-patch: + +2010-04-09 Kevin Ollivier <kevino@theolliviers.com> + + [wx] Build fix after addition of LayoutTestController method. + + * DumpRenderTree/wx/LayoutTestControllerWx.cpp: + (LayoutTestController::computedStyleIncludingVisitedInfo): + +2010-04-09 Sam Weinig <sam@webkit.org> + + Reviewed by Anders Carlsson. + + Fix for https://bugs.webkit.org/show_bug.cgi?id=37368 + Add MiniBrowser. + + * MiniBrowser: Added. + * MiniBrowser/MiniBrowser.vcproj: Added. + * MiniBrowser/MiniBrowser.xcodeproj: Added. + * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Added. + * MiniBrowser/mac: Added. + * MiniBrowser/mac/AppDelegate.h: Added. + * MiniBrowser/mac/AppDelegate.m: Added. + * MiniBrowser/mac/BrowserWindowController.h: Added. + * MiniBrowser/mac/BrowserWindowController.m: Added. + * MiniBrowser/mac/English.lproj: Added. + * MiniBrowser/mac/English.lproj/BrowserWindow.xib: Added. + * MiniBrowser/mac/English.lproj/InfoPlist.strings: Added. + * MiniBrowser/mac/English.lproj/MainMenu.xib: Added. + * MiniBrowser/mac/MiniBrowser-Info.plist: Added. + * MiniBrowser/mac/MiniBrowser_Prefix.pch: Added. + * MiniBrowser/mac/main.m: Added. + * MiniBrowser/win: Added. + * MiniBrowser/win/BrowserView.cpp: Added. + * MiniBrowser/win/BrowserView.h: Added. + * MiniBrowser/win/BrowserWindow.cpp: Added. + * MiniBrowser/win/BrowserWindow.h: Added. + * MiniBrowser/win/MiniBrowser.cpp: Added. + * MiniBrowser/win/MiniBrowser.h: Added. + * MiniBrowser/win/MiniBrowser.rc: Added. + * MiniBrowser/win/Resources: Added. + * MiniBrowser/win/main.cpp: Added. + * MiniBrowser/win/resource.h: Added. + * MiniBrowser/win/stdafx.cpp: Added. + * MiniBrowser/win/stdafx.h: Added. + +2010-04-09 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + webkit-patch attached my patch to the wrong bug + https://bugs.webkit.org/show_bug.cgi?id=37015 + + The problem here is that SVN was violating SCM's implicit + contract of always returning paths relative to the repository root. + That can easily be fixed by telling SVN that the CWD is the repository root. + + When fixing this I realized there are a large number of places in SCM.py where + we want to consider explicitly passing self.checkout_root as the CWD. + That would allow scm methods to be executed even when the CWD is not inside + the scm tree at all, and would also make sure (in the case of SVN) that paths + returned are relative to the root. Git (almost always) returns paths relative + to the repository root. + + * Scripts/webkitpy/common/checkout/scm.py: + - Explicitly pass self.checkout_root as cwd in run_status_and_extract_filenames + - Add a ton of FIXMEs about the need to go back and decide which methods require cwd=self.checkout_root + and which do not. We'll probably add a helper function to scm (likely SCM._run) which + always passes cwd=self.checkout_root to Executive.run_command + * Scripts/webkitpy/common/checkout/scm_unittest.py: + - Add a test for this change. + * Scripts/webkitpy/tool/commands/upload.py: + - Removed the explicit os.chdir to the repository root, since scm.py methods + should be robust against the cwd not being equal to the root. + +2010-04-09 Adam Roben <aroben@apple.com> + + Don't return 0 as a JSValueRef + + That is an illegal use of the JSC API. + + Fixes <http://webkit.org/b/37333> REGRESSION (r57292): :visited tests + are asserting on debug Windows and GTK builds + + Reviewed by Anders Carlsson. + + * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: + (LayoutTestController::computedStyleIncludingVisitedInfo): + * DumpRenderTree/win/LayoutTestControllerWin.cpp: + (LayoutTestController::computedStyleIncludingVisitedInfo): + Return an "undefined" JSValueRef instead of 0. + +2010-04-09 Csaba Osztrogonác <ossy@webkit.org> + + Reviewed by Eric Seidel. + + Make DumpRenderTree parallelizable + https://bugs.webkit.org/show_bug.cgi?id=36899 + + * DumpRenderTree/mac/DumpRenderTree.mm: + (libraryPathForDumpRenderTree): Use DUMPRENDERTREE_TEMP if exist. + * DumpRenderTree/qt/DumpRenderTreeQt.cpp: + (WebCore::DumpRenderTree::DumpRenderTree): Use DUMPRENDERTREE_TEMP if exist. + * Scripts/run-webkit-tests: + - Create a unique temporary directory and pass its path to + DumpRenderTree with DUMPRENDERTREE_TEMP environment variable. + +2010-04-09 Mark Rowe <mrowe@apple.com> + + Reviewed by Oliver Hunt. + + <http://webkit.org/b/37326> IDL files are being copied in to the WebCore framework again + + Add a script to detect the presence of inappropriate files in the frameworks. At present + it only looks for .css, .idl and .in files in the top level of WebCore.framework/Resources, + as these are the only cases we've encountered recently. It can be extended to check the + other frameworks or for other inappropriate files in the future. + + * Scripts/check-for-inappropriate-files-in-framework: Added. + +2010-04-08 Sam Weinig <sam@webkit.org> + + Reviewed by Darin Adler. + + Add option to build WebKit2 to build-webkit. + + * Scripts/build-webkit: + +2010-04-08 Darin Adler <darin@apple.com> + + Reviewed by Alexey Proskuryakov. + + run-webkit-tests should respect argument order + https://bugs.webkit.org/show_bug.cgi?id=37257 + + * Scripts/run-webkit-tests: Changed so that sorting is done only + on the results of iterating directories. Test order is based on + what's passed on the command line. Removed code that aimed to + eliminate duplicates since it can be useful to run the same test + more than once. + +2010-04-07 David Hyatt <hyatt@apple.com> + + Reviewed by Oliver Hunt. + + https://bugs.webkit.org/show_bug.cgi?id=24300, don't expose history info via CSS. Add a new method for + obtaining computed style with :visited info included. This allows layout tests to actually tell that + :visited is in effect. + + * DumpRenderTree/LayoutTestController.cpp: + (computedStyleIncludingVisitedInfoCallback): + (LayoutTestController::staticFunctions): + * DumpRenderTree/LayoutTestController.h: + * DumpRenderTree/mac/LayoutTestControllerMac.mm: + (LayoutTestController::computedStyleIncludingVisitedInfo): + +2010-04-07 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Adam Barth. + + Enable rebaseline-chromium-webkit-tests to run from a webkit-only + checkout (i.e., you don't need anything from the Chromium tree checked + out). This requires us to introduce the concept of a "target" + port/platform that we use to get configuration information from as well + as the "running" port that we use to make directories and diff images + and the "rebaselining" port we use to actually manage baselines. + + https://bugs.webkit.org/show_bug.cgi?id=37238 + + * Scripts/webkitpy/layout_tests/port/mac.py: + * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: + +2010-04-05 Antonio Gomes <tonikitoo@webkit.org> + + Reviewed by Simon Hausmann. + + [Qt] REGRESSION:(r50665) QWebFrame::setScrollBarPolicy(Qt::Vertical,Qt::ScrollBarAlwaysOff) has no effect. + https://bugs.webkit.org/show_bug.cgi?id=29431 + + Added stubs for Mac, win, gtk and wx DRTs to implement setScrollbarPolicy method. + + * DumpRenderTree/LayoutTestController.cpp: + (setScrollbarPolicyCallback): + (LayoutTestController::staticFunctions): + * DumpRenderTree/LayoutTestController.h: + * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: + (LayoutTestController::setScrollbarPolicy): + * DumpRenderTree/mac/LayoutTestControllerMac.mm: + (LayoutTestController::setScrollbarPolicy): + * DumpRenderTree/win/LayoutTestControllerWin.cpp: + (LayoutTestController::setScrollbarPolicy): + * DumpRenderTree/wx/LayoutTestControllerWx.cpp: + (LayoutTestController::setScrollbarPolicy): + +2010-04-01 Antonio Gomes <tonikitoo@webkit.org> + + Reviewed by David Hyatt. + + [Qt] REGRESSION:(r50665) QWebFrame::setScrollBarPolicy(Qt::Vertical,Qt::ScrollBarAlwaysOff) has no effect. + https://bugs.webkit.org/show_bug.cgi?id=29431 + + Make possible to DRT to set scrollbar policies (on, off or auto). + + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::setScrollbarPolicy): + * DumpRenderTree/qt/LayoutTestControllerQt.h: + * QtLauncher/main.cpp: + (LauncherWindow::toggleScrollbars): + (LauncherWindow::createChrome): + +2010-04-08 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + new-run-webkit-tests should give a percent complete indication + https://bugs.webkit.org/show_bug.cgi?id=37258 + + Because it's awesome. + + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + +2010-04-08 Adam Barth <abarth@webkit.org> + + Unreviewed. + + Add back the --target option because it's needed by the downstream + Chromium bots. + + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + +2010-04-08 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + new-run-webkit-tests should understand set-webkit-configuration + https://bugs.webkit.org/show_bug.cgi?id=37252 + + * Scripts/webkitpy/layout_tests/port/base.py: + * Scripts/webkitpy/layout_tests/port/mac.py: + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + +2010-04-08 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Rename target to configuration in new-run-webkit-tests to match the rest of WebKit + https://bugs.webkit.org/show_bug.cgi?id=37251 + + The rest of our tools call --debug or --release the configuration. + It's confusing to call it target in this script. + + * Scripts/webkitpy/layout_tests/driver_test.py: + * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: + * Scripts/webkitpy/layout_tests/port/base.py: + * Scripts/webkitpy/layout_tests/port/chromium.py: + * Scripts/webkitpy/layout_tests/port/chromium_linux.py: + * Scripts/webkitpy/layout_tests/port/chromium_mac.py: + * Scripts/webkitpy/layout_tests/port/chromium_win.py: + * Scripts/webkitpy/layout_tests/port/mac.py: + * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: + * Scripts/webkitpy/layout_tests/test_types/image_diff.py: + * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: + * Scripts/webkitpy/layout_tests/test_types/text_diff.py: + +2010-04-07 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Remove depricated op.popen2 call in new-run-webkit-tests + https://bugs.webkit.org/show_bug.cgi?id=37249 + + Python complains that this API is depricated. We already solved this + problem in executive.py. + + * Scripts/webkitpy/layout_tests/port/mac.py: + +2010-04-07 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + new-run-webkit-tests crashes when run on a 64-bit machine + https://bugs.webkit.org/show_bug.cgi?id=37248 + + * Scripts/webkitpy/layout_tests/port/mac.py: + - The code was trying to always run the 32-bit intel version + of the DumpRenderTree binary. DRT does not build 32-bit on 64-bit + machines so that makes no sense. This may have made sense for test_shell + at some point, but I think we should just remove this for DRT. + +2010-04-07 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + WebKit Apache configs only listen on IPv4 addresses, causing random timeouts + https://bugs.webkit.org/show_bug.cgi?id=37104 + + Add warnings that the partial support for specifying what port numbers + apache should bind to is even more broken after this fix. + + * Scripts/run-webkit-httpd: + * Scripts/run-webkit-tests: + +2010-04-07 Shinichiro Hamaji <hamaji@chromium.org> + + Reviewed by Darin Adler. + + LayoutTestController::m_handlesAuthenticationChallenges isn't initialized + https://bugs.webkit.org/show_bug.cgi?id=37190 + + * DumpRenderTree/LayoutTestController.cpp: + (LayoutTestController::LayoutTestController): + +2010-03-31 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + Add webkit-patch command to crawl buildbot history and find when tests + started to fail. + https://bugs.webkit.org/show_bug.cgi?id=36911 + + This is a very bare-bones implementation, which works, but isn't pretty. + We will need further re-factoring and improvement to this code, but + after long discussions with Adam, I think it's best that we land this + and iterate from there. + + * Scripts/webkitpy/common/net/buildbot.py: + - Add revision_build_pairs_with_results for cleaner code and possible + optimization of this command. + - Return None if a build number can't be found for a revision in + build_for_revision + - Separate out suspect_revisions_for_transition for re-use by + FailureReason + - Add LayoutTestResults.failing_tests() and make our parsing code + explict about what tables it accepts. + * Scripts/webkitpy/tool/commands/queries.py: + - Move _print_blame_information_for_commit out of WhatBroke for re-use + by FailureReason. + - Add FailureReason command which can crawl a given builder and explain + why it is currently red on a per-test basis. + +2010-04-06 Kent Tamura <tkent@chromium.org> + + Reviewed by Dimitri Glazkov. + + [DRT/Chromium] Add DumpRenderTree.gyp, and some small fixes + https://bugs.webkit.org/show_bug.cgi?id=37137 + + - Add DumpRenderTree.gyp + - Remove some dependencies to base/string_util.h, + base/compiler_specific.h, base/file_path.h, base/file_util.h, + base/message_loop.h, base/sys_string_conversions.h, + + * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Added. + * DumpRenderTree/chromium/CppVariant.cpp: + (CppVariant::toStringVector): + * DumpRenderTree/chromium/EventSender.cpp: + (EventSender::EventSender): + (EventSender::keyDown): + (EventSender::scheduleAsynchronousClick): + (EventSender::beginDragWithFiles): + * DumpRenderTree/chromium/LayoutTestController.cpp: + (LayoutTestController::setUserStyleSheetLocation): + (LayoutTestController::pathToLocalResource): + * DumpRenderTree/chromium/TextInputController.cpp: + (TextInputController::markedRange): + (TextInputController::selectedRange): + +2010-04-06 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Eric Seidel. + + Write stack traces into the results directory for new-run-webkit-tests, + instead of writing them alongside the test file. + + https://bugs.webkit.org/show_bug.cgi?id=36504 + + * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: + +2010-04-06 Dirk Pranke <dpranke@chromium.org> + + Unreviewed build fix. + + Enable pixel tests by default in new-run-webkit-tests unless + explicitly set by the port or by the command line. This was broken in + the fix for bug 36801 (rev. 57173). + + https://bugs.webkit.org/show_bug.cgi?id=37184 + + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + +2010-04-06 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Eric Seidel. + + Disable pixel tests on the mac port by default. + + Also, revamp the way we check for pixel tests being enabled or + disabled. We now look for options.pixel_tests instead of + options.no_pixel_tests, and we have the "--pixel-tests" (force enable) + and "--no-pixel-tests" (force disable) flags. + + https://bugs.webkit.org/show_bug.cgi?id=36801 + + * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: + * Scripts/webkitpy/layout_tests/layout_package/test_expectations_test.py: + * Scripts/webkitpy/layout_tests/port/chromium.py: + * Scripts/webkitpy/layout_tests/port/mac.py: + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + +2010-04-06 Diego Gonzalez <diego.gonzalez@openbossa.org> + + Reviewed by Laszlo Gombos. + + [Qt] Added the iPhone and iPad latest user agent in QtLauncher UA switcher + https://bugs.webkit.org/show_bug.cgi?id=37159 + + * QtLauncher/useragentlist.txt: + +2010-04-06 Laszlo Gombos <laszlo.1.gombos@nokia.com> + + Reviewed by Kenneth Rohde Christiansen. + + [Qt] Add current user-agent string for Symbian for QtLauncher + https://bugs.webkit.org/show_bug.cgi?id=37131 + + * QtLauncher/useragentlist.txt: + +2010-04-06 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Explain how to handle rollout patches + https://bugs.webkit.org/show_bug.cgi?id=37139 + + We need to set expectations for how long landing rollout patches with + the commit-queue takes. The commit-queue is optimized for safety, not + performance. Also, give folks an alternative way to land patches + quickly. + + In addition, improve our testing of add_patch_to_bug by having + MockBugzilla log. This caused me to tighten a bunch of tests and + notice that one of our tests wasn't being run. + + * Scripts/webkitpy/tool/commands/download_unittest.py: + * Scripts/webkitpy/tool/commands/upload_unittest.py: + * Scripts/webkitpy/tool/mocktool.py: + * Scripts/webkitpy/tool/steps/postdiffforrevert.py: + +2010-04-06 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Turns out commit_info.committer() can be None + https://bugs.webkit.org/show_bug.cgi?id=37106 + + When the committer isn't in committers.py, the committer() property on + commit_info can be None. We need to handle that case gracefully. + + * Scripts/webkitpy/common/checkout/commitinfo.py: + * Scripts/webkitpy/tool/bot/sheriff.py: + * Scripts/webkitpy/tool/bot/sheriff_unittest.py: + * Scripts/webkitpy/tool/commands/queries.py: + +2010-04-06 Laszlo Gombos <laszlo.1.gombos@nokia.com> + + Reviewed by Kenneth Rohde Christiansen. + + [Qt] [Symbian] Build fix for Dumprendertree if Qt printing is not supported + https://bugs.webkit.org/show_bug.cgi?id=37082 + + Use the QT_NO_PRINTER guard to flag QPrinter dependent code. + + * DumpRenderTree/qt/DumpRenderTreeQt.cpp: + (WebCore::DumpRenderTree::dryRunPrint): + +2010-04-05 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + SheriffBot should force_build builders that are idle and have failed exactly once + https://bugs.webkit.org/show_bug.cgi?id=37059 + + We can get into a deadlocked state where the commit-queue is stopped + because the builders are red but the SheriffBot hasn't taken action + because the builder has failed only once. The SheriffBot should force + build idle builders that have failed exactly once to either turn the + tree green again (if the test was flaky) or trigger the "failed twice" + remedies (IRC and bug posts). + + * Scripts/webkitpy/common/net/buildbot.py: + * Scripts/webkitpy/tool/bot/sheriff.py: + * Scripts/webkitpy/tool/bot/sheriff_unittest.py: + * Scripts/webkitpy/tool/commands/sheriffbot.py: + * Scripts/webkitpy/tool/mocktool.py: + +2010-04-05 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Shinichiro Hamaji. + + Fixed check-webkit-style issue where the script was prematurely + exiting when encountering deleted files in patches. + + https://bugs.webkit.org/show_bug.cgi?id=37122 + + * Scripts/webkitpy/style/checker.py: + - Changed non-existent file message from ERROR to WARN. + - StyleChecker.check_file() no longer raises an exception when + a file is not found. + + * Scripts/webkitpy/style/checker_unittest.py: + - Updated unit tests as necessary. + +2010-04-05 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + SheriffBot should include blamelist when posting to bugs + https://bugs.webkit.org/show_bug.cgi?id=37113 + + When posting on bugs, we should include the full list of SVN revisions + that caused the regression to folks have a better sense of whether they + are to blame. + + * Scripts/webkitpy/tool/bot/sheriff.py: + * Scripts/webkitpy/tool/bot/sheriff_unittest.py: + * Scripts/webkitpy/tool/commands/sheriffbot.py: + * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py: + * Scripts/webkitpy/tool/commands/upload_unittest.py: + * Scripts/webkitpy/tool/mocktool.py: + +2010-04-05 Chris Jerdonek <cjerdonek@webkit.org> + + Unreviewed after discussion with Adam, Darin, and Eric. + + Deleted the auto-install directory since it is no longer needed in + source control (it is auto-generated). + + Also added webkitpy/thirdparty/autoinstalled to webkitpy/thirdparty's + svn:ignore property. + + * Scripts/webkitpy/thirdparty/autoinstalled: Removed. + +2010-04-05 Mark Rowe <mrowe@apple.com> + + Reviewed by Adele Peterson. + + Test case for <http://webkit.org/b/37115> / <rdar://problem/7829331>. + REGRESSION(r56989): Crash in Mail in WebCore::Position::isCandidate when deleting block using block deletion UI + + Add a JavaScript hook in DRT to call through to WebView's -setEditable:. This is required in order to reproduce + the crash. + + * DumpRenderTree/LayoutTestController.cpp: + (setWebViewEditableCallback): + (LayoutTestController::staticFunctions): + * DumpRenderTree/LayoutTestController.h: + * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: + (LayoutTestController::setWebViewEditable): + * DumpRenderTree/mac/DumpRenderTree.mm: + (resetWebViewToConsistentStateBeforeTesting): + * DumpRenderTree/mac/LayoutTestControllerMac.mm: + (LayoutTestController::setWebViewEditable): + * DumpRenderTree/win/LayoutTestControllerWin.cpp: + (LayoutTestController::setWebViewEditable): + * DumpRenderTree/wx/LayoutTestControllerWx.cpp: + (LayoutTestController::setWebViewEditable): + (LayoutTestController::layerTreeAsText): + +2010-04-05 Darin Adler <darin@apple.com> + + Ignore more files the Python tools strew about the working directory. + + * Scripts/webkitpy: Added property svn:ignore. + * Scripts/webkitpy/common: Added property svn:ignore. + * Scripts/webkitpy/common/checkout: Added property svn:ignore. + * Scripts/webkitpy/common/config: Added property svn:ignore. + * Scripts/webkitpy/common/net: Added property svn:ignore. + * Scripts/webkitpy/common/thread: Added property svn:ignore. + * Scripts/webkitpy/python24: Added property svn:ignore. + * Scripts/webkitpy/thirdparty/autoinstalled: Modified property svn:ignore. + * Scripts/webkitpy/tool/bot: Added property svn:ignore. + +2010-04-05 Adam Barth <abarth@webkit.org> + + Unreviewed. Add Vitaly Repeshko as a committer. + + * Scripts/webkitpy/common/config/committers.py: + +2010-04-05 Adam Barth <abarth@webkit.org> + + Unreviewed. Update kenne's IRC nick to his registered nick. + + * Scripts/webkitpy/common/config/committers.py: + +2010-04-05 Ojan Vafai <ojan@chromium.org> + + Reviewed by Eric Seidel. + + assorted helper functions and cleanup of git utilities + https://bugs.webkit.org/show_bug.cgi?id=37103 + + * Scripts/webkitpy/common/checkout/scm.py: + No code currently uses the optional dry_run argument. So removing it. + Change all uses of "trunk" to read the correct value out of the git config. + Made the dcommit call actually get called when dry_run==true. + * Scripts/webkitpy/common/checkout/scm_unittest.py: + * Scripts/webkitpy/common/net/credentials.py: + Move the git config call into scm. + * Scripts/webkitpy/common/net/credentials_unittest.py: + * Scripts/webkitpy/common/system/executive.py: + If return_exit_code==true, don't error out, just return the exit_code. + +2010-04-05 Ojan Vafai <ojan@chromium.org> + + Reviewed by Eric Seidel. + + prepare-ChangeLog should take a merge-base for which git branch to diff against. + https://bugs.webkit.org/show_bug.cgi?id=36394 + + * Scripts/prepare-ChangeLog: + +2010-04-05 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Shinichiro Hamaji. + + Removed the PatchStyleErrorHandler class and incorporated its + functionality into the DefaultStyleErrorHandler class. + + https://bugs.webkit.org/show_bug.cgi?id=37067 + + * Scripts/webkitpy/style/checker.py: + - In the StyleChecker class: + - Added a line_number parameter to the check_file() method. + - Renamed the handle_style_error parameter to + mock_handle_style_error to be consistent with the other mock_* + parameter names. + - Added a mock_check_file parameter to the check_patch() method + to facilitate unit testing the changes in this patch. + - Rewrote the check_patch() method with the patch-parsing logic + taken from the PatchStyleErrorHandler class. + + * Scripts/webkitpy/style/checker_unittest.py: + - Added a StyleCheckerCheckFileBase class and sub-classed the + existing StyleCheckerCheckFileTest class from it. + - Added a StyleCheckerCheckPatchTest class to unit-test the + rewritten check_patch() method. + - Removed the vestigial __main__ code at the bottom of the file. + This is left over from when check-webkit-style was implemented + as a module and a wrapper module. + + * Scripts/webkitpy/style/error_handlers.py: + - Added an optional line_numbers parameter to the + DefaultStyleErrorHandler class constructor and adjusted the + __call__() method as necessary. + - Removed the PatchStyleErrorHandler class. + + * Scripts/webkitpy/style/error_handlers_unittest.py: + - Removed the PatchStyleErrorHandlerTest class which unit-tested + the PatchStyleErrorHandler class which is being removed in this + patch. + - Added a test_line_numbers() test method to the + DefaultStyleErrorHandlerTest class to test use of the + DefaultStyleErrorHandler's new line_numbers attribute. + +2010-04-05 Adam Barth <abarth@webkit.org> + + Unreviewed. + + Tighten SheriffBot's flaky test detector + https://bugs.webkit.org/show_bug.cgi?id=37063 + + Instead of just looking for two sequential red builds, look for two + sequential failures of the same test. This should reduce sheriffbot + false positive substantially. + + I'm landing this change unreviewed because I've noticed SheriffBot + triggering a lot more false positives now that we've expanded the set + of core builders. I've tried to take Eric's comments on Bug 37063 into + account. I'm happy to iterate on this patch tomorrow once Eric wakes + up. + + * Scripts/webkitpy/common/net/buildbot.py: + * Scripts/webkitpy/common/net/buildbot_unittest.py: + * Scripts/webkitpy/tool/commands/queries.py: + +2010-04-04 John Gregg <johnnyg@google.com> + + Unreviewed, add myself to the committers list. + + * Scripts/webkitpy/common/config/committers.py: + +2010-04-04 Robert Hogan <robert@webkit.org> + + Unreviewed, add myself to the committers list. + + * Scripts/webkitpy/common/config/committers.py: + +2010-04-04 Dumitru Daniliuc <dumi@chromium.org> + + Unreviewed, adding my IRC nickname to committers.py + + * Scripts/webkitpy/common/config/committers.py: + +2010-04-04 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Shinichiro Hamaji. + + Refactored check-webkit-style's option-parsing code. + + https://bugs.webkit.org/show_bug.cgi?id=37064 + + * Scripts/check-webkit-style: + - Moved the "WebKit checkout not found" check from + ArgumentParser.parse() to the calling code. + - Moved the --git-commit argument validation from the calling + code to ArgumentParser.parse(). + + * Scripts/webkitpy/style/checker_unittest.py: + - Updated a unit test as necessary. + + * Scripts/webkitpy/style/optparser.py: + - Renamed ArgumentParser._exit_with_help() to _parse_error() + and made its error_message parameter required. + - Removed the found_checkout parameter from ArgumentParser.parse(). + - Removed the "WebKit checkout not found" check and moved it + to the calling code. + - Added --git-commit argument checking. + + * Scripts/webkitpy/style/optparser_unittest.py: + - Adjusted the import statements to be fully qualified. + - Changed the ArgumentParserTest class to inherit from + LoggingTestCase, and updated the class as necessary. + - Added a unit-test for the --git-commit validation. + - Added unit tests for the --git-diff and --git-since variants + of --git-commit. + +2010-04-03 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Shinichiro Hamaji. + + The check-webkit-style script now logs an ERROR and exits when + encountering a file path that does not exist. Previously, it failed + silently on such paths. + + https://bugs.webkit.org/show_bug.cgi?id=36957 + + * Scripts/webkitpy/common/system/logtesting.py: + - Added a FIXME to rename the LoggingTestCase class to + LoggingTestCaseBase. + + * Scripts/webkitpy/style/checker.py: + - In the StyleChecker.check_file() method: + - Added a mock_os_path_exists parameter. + - Renamed the process_file parameter to mock_process_file. + - Added logic to log an error and exist if the given path does + not exist. + + * Scripts/webkitpy/style/checker_unittest.py: + - Refactored the StyleCheckerCheckFileTest class slightly to + inherit from LoggingTestCase. + - Added a test method to unit-test the case of a file that + does not exist. + - Adjusted the other test methods as necessary. + +2010-04-03 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Add Tiger Bot to the list of "core builders" (builders which block the commit-queue when red) + https://bugs.webkit.org/show_bug.cgi?id=33289 + + Add Tiger and SnowLeopard Tests to the core builders. This is a bit of + an experiment now that the bots are green. Hopefully we can keep them + on the list and have the tree stay greener. + + * Scripts/webkitpy/common/net/buildbot.py: + +2010-04-02 Adam Barth <abarth@webkit.org> + + Unreviewed. + + Have Eric and Adam watch the SheriffBot + https://bugs.webkit.org/show_bug.cgi?id=37054 + + * Scripts/webkitpy/tool/bot/sheriff.py: + * Scripts/webkitpy/tool/bot/sheriff_unittest.py: + * Scripts/webkitpy/tool/commands/sheriffbot.py: + +2010-04-02 Adam Barth <abarth@webkit.org> + + Reviewed by Darin Adler. + + commit-queue should ignore builders when landing rollouts + https://bugs.webkit.org/show_bug.cgi?id=37051 + + When we moved the "builders are red" check into the master process, we + forgot about rollouts. I thought we had a test covering this case, but + looking at the test, it was a bit too loose. I added a new test and + introduced some new logging technology into MockTool to make the test + tighter. + + * Scripts/webkitpy/tool/commands/queues.py: + * Scripts/webkitpy/tool/commands/queues_unittest.py: + * Scripts/webkitpy/tool/mocktool.py: + +2010-04-02 David Levin <levin@chromium.org> + + Reviewed by Adam Barth. + + sherrifbot should ensure that the rollout reason doesn't start with - (and fix webkit-patch upload). + https://bugs.webkit.org/show_bug.cgi?id=37030 + + * Scripts/webkitpy/tool/bot/sheriff.py: Ensure that the rollout reason doesn't + start with -. + * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: A test with a rollout + reason which starts with -. + * Scripts/webkitpy/tool/steps/createbug.py: Fix webkit-patch upload. + +2010-04-02 Chris Jerdonek <cjerdonek@webkit.org> + + Unreviewed. + + Fixed check-webkit-style to recognize the short form of the + --verbose option, as stated in --help. + + * Scripts/check-webkit-style: + - Tweaked one line. + +2010-04-02 Kevin Ollivier <kevino@theolliviers.com> + + [wx] Build fix for DumpRenderTree after addition of layerTreeAsText. + + * DumpRenderTree/wx/LayoutTestControllerWx.cpp: + (LayoutTestController::layerTreeAsText): + +2010-04-02 Laszlo Gombos <laszlo.1.gombos@nokia.com> + + Reviewed by Eric Seidel. + + Accept XHTML-MP content type as XHTML content + https://bugs.webkit.org/show_bug.cgi?id=34262 + + Register xhtmlmp file extension as the new type + for XHTML-MP test content. + + * Scripts/run-webkit-tests: + * Scripts/webkitpy/layout_tests/layout_package/test_files.py: + * Scripts/webkitpy/layout_tests/port/lighttpd.conf: + +2010-04-02 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + create-rollout doesn't fill out ChangeLog + https://bugs.webkit.org/show_bug.cgi?id=37010 + + The contract between apply_reverse_diff and PrepareChangeLogForRevert + was unclear. I broke filling out the ChangeLog during rollout earlier + when I changed apply_reverse_diff to revert the ChangeLogs because + PrepareChangeLogForRevert thought that it was supposed to do that. + I've now taught PrepareChangeLogsForRevert the new contract. + + It's unclear to me how to test this change because it's essentially an + integration issue that requires the file system. At some point we + should think about a testing strategy for integration. As the system + becomes larger, we're running into more of these issues. + + * Scripts/webkitpy/common/checkout/api.py: + * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py: + +2010-04-02 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Add cr-win-ews to QueueStatusServer + https://bugs.webkit.org/show_bug.cgi?id=37004 + + * QueueStatusServer/model/queues.py: + * QueueStatusServer/templates/dashboard.html: + * QueueStatusServer/templates/statusbubble.html: + +2010-04-02 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Adam Barth. + + Unit-test networktransaction.py's log messages, and add a base + class to make unit-testing log messages even easier. + + https://bugs.webkit.org/show_bug.cgi?id=36958 + + The purpose of this patch is also to provide a mini-tutorial on + how to unit-test Python logging.py messages. + + * Scripts/webkitpy/common/net/networktransaction_unittest.py: + - Unit-tested the log messages in test_retry(). + + * Scripts/webkitpy/common/system/logtesting.py: + - Adjusted the LogTesting class by moving the code that clears + the array of log messages into a finally block. This prevents + redundant AssertionErrors from getting rendered to the screen + while running unit tests. + - Added a LoggingTestCase class so the setUp() and tearDown() + methods do not need to be implemented in order to test logging. + Rather, TestCase classes can simply inherit from this class. + +2010-04-02 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Shinichiro Hamaji. + + Re-wrote check-webkit-style's argument parsing code to use + Python's optparser module and more uniform error-handling logic. + + https://bugs.webkit.org/show_bug.cgi?id=34676 + + * Scripts/webkitpy/style/optparser.py: + - Removed "option help" from check-webkit-style's usage string + since that is provided separately by the OptionParser class. + - Also changed the usage string from a function to a constant + string _USAGE. + - Added an _EPILOG string which renders after OptionParser's + usage string and option help. + - In the ArgumentParser class: + - Changed the constructor's stderr_write parameter to a + mock_stderr since the OptionParser accepts a sys.stderr + substitute rather than a sys.stderr.write substitute. + - Changed the constructor to set a _parser data attribute with + an OptionParser instance. + - Added a _create_option_parser() method which instantiates + the OptionParser. + - Updated _exit_with_help() to interact with the OptionParser's + help method. + - Updated the parse() method as necessary. Also changed the + raising of ValueErrors to calls to _exit_with_help(). + + * Scripts/webkitpy/style/optparser_unittest.py: + - Removed the CreateUsageTest class since the create_usage method + was replaced by a constant string. + - Added a _MockStdErr class to the ArgumentParserTest class. + - Updated the unit tests as necessary. + + +2010-04-02 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + The master commit-queue process should take responsibility for checking that the builders are green + https://bugs.webkit.org/show_bug.cgi?id=37009 + + We had a failure where the child process noticed that the builders were + red. We've always had this race condition, but the new optimistic + design made it easier to trigger. + + * Scripts/webkitpy/tool/commands/queues.py: + +2010-04-02 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Tweak rollout changelog to pass ValidateReviewer check + https://bugs.webkit.org/show_bug.cgi?id=37019 + + We need to use the magic word "unreviewed" to make the commit-queue + happy when landing rollouts. + + * Scripts/webkitpy/common/checkout/changelog.py: + * Scripts/webkitpy/common/checkout/changelog_unittest.py: + +2010-04-02 Chris Jerdonek <cjerdonek@webkit.org> + + Unreviewed. + + Removed duplicate ChangeLog entry. + +2010-04-02 Chris Jerdonek <cjerdonek@webkit.org> + + Rubber-stamped by Eric Seidel. + + To the Python 2.4 error message, added a link to the wiki page + that contains instructions on how to upgrade. + + * Scripts/test-webkitpy: + - Eliminated a use of the ternary operator in configure_logging() + to let the version warning display in case of Python 2.4. + + * Scripts/webkitpy/python24/versioning.py: + - Added this link to the error text: + http://trac.webkit.org/wiki/PythonGuidelines + + * Scripts/webkitpy/python24/versioning_unittest.py: + - Updated unit test text. + +2010-04-02 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Record the IRC nick of folks who request rollouts + https://bugs.webkit.org/show_bug.cgi?id=36999 + + * Scripts/webkitpy/common/net/irc/ircbot.py: + * Scripts/webkitpy/tool/bot/irc_command.py: + * Scripts/webkitpy/tool/bot/sheriffircbot.py: + * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: + +2010-04-01 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Add cr-win-ews + https://bugs.webkit.org/show_bug.cgi?id=36974 + + Adds support for an Early Warning System for Chromium on Linux. The + interface to the Chromium port is the same on every platform, so we + don't need to create a new Port object for this queue. + + * Scripts/webkitpy/tool/commands/earlywarningsystem.py: + * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: + +2010-04-01 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Using a failure exit code when failing to load a required import + https://bugs.webkit.org/show_bug.cgi?id=37000 + + Well spotted by Mark Rowe. + + * Scripts/webkitpy/common/system/user.py: + +2010-04-01 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Eric Seidel. + + Rewrote the revision (r56942) to disable the 79 character line + length limit Python/PEP8 style check. + + https://bugs.webkit.org/show_bug.cgi?id=33639#c39 + + This rewrite puts the disabling not in the PythonProcessor but + in the calling code's default filter rule configuration. This + allows the user to check line-length style from the command-line + if desired. + + * Scripts/webkitpy/style/checker.py: + - Added "-pep8/E501" to the _BASE_FILTER_RULES configuration + variable to disable the line-length check. + - Added "-pep8/E501" to the list of recognized style categories + to permit the category to be checked from the command line. + + * Scripts/webkitpy/style/processors/python.py: + - Reverted r56942: http://trac.webkit.org/changeset/56942 + +2010-04-01 Kinuko Yasuda <kinuko@chromium.org> + + Reviewed by Dmitry Titov. + + Add FileThread for async file operation support in FileReader and FileWriter + https://bugs.webkit.org/show_bug.cgi?id=36896 + + Add options to enable FILE_READER and FILE_WRITER support. + + * Scripts/build-webkit: + +2010-04-01 Kent Tamura <tkent@chromium.org> + + Unreviewed. Add missing license header. + + * DumpRenderTree/chromium/TestShellMac.mm: + +2010-04-01 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Improve the error handling in rollout a bit + https://bugs.webkit.org/show_bug.cgi?id=36995 + + This patch does a few things to make the error handling in rollout a + bit more robust. + + * Scripts/webkitpy/common/checkout/api.py: + The old logic here was wrong. We don't want to resolve the + ChangeLogs (that would remove the old ChangeLog entry). Instead, + we want to revert the ChangeLogs so we can fill them with the new + message. + * Scripts/webkitpy/tool/commands/download_unittest.py: + Update test expectations because we're using a different mock object. + * Scripts/webkitpy/tool/commands/download.py: + - Added an update command to make updating from the SheriffBot more + robust. + - Now that we have CommitInfo, we can automatically CC the + responsible parties on the bug we create. + - Re-ordered the steps in create-rollout. Our original thinking + was that we always wanted to create the bug, but that's not + really true given how things appear to be playing out. If we + fail to apply the reverse diff, we don't want to create the bug. + * Scripts/webkitpy/tool/commands/sheriffbot.py: + - Use the new, more robust update command. + * Scripts/webkitpy/tool/steps/createbug.py: + Allow commands to pre-load who they want to be CCed on a new bug. + +2010-04-01 Kent Tamura <tkent@chromium.org> + + Reviewed by Dimitri Glazkov. + + [DRT/Chromium] Add TestShell and WebViewHost class, main(), and so on + https://bugs.webkit.org/show_bug.cgi?id=36814 + + This change introduces: + - WebViewHost class + It's an implementation of some delegates required by Chromium + WebKit API, and manages painting of a WebView. It's base on + src/webkit/tools/test_shell/test_webview_delegate.{cc,h} of + Chromium rev.40492. + - TestShell class + The TestShell instance holds global states of DumpRenderTree process. + Unlike TestShell class of Chromium test_shell, TestShell instance is + created just once. + - DumpRenderTree.cpp + The program entry. + + * DumpRenderTree/chromium/DumpRenderTree.cpp: Added. + * DumpRenderTree/chromium/TestShell.cpp: Added. + * DumpRenderTree/chromium/TestShell.h: Added. + * DumpRenderTree/chromium/TestShellMac.mm: Added. + * DumpRenderTree/chromium/WebViewHost.cpp: Added. + * DumpRenderTree/chromium/WebViewHost.h: Added. + * DumpRenderTree/chromium/config.h: Added. + +2010-04-01 David Levin <levin@chromium.org> + + Reviewed by Adam Barth. + + sheriffbot rollout should verify that the svn revision is a number. + https://bugs.webkit.org/show_bug.cgi?id=37001 + + * Scripts/webkitpy/common/net/bugzilla.py: Allow for the message to be None. + * Scripts/webkitpy/tool/bot/sheriff.py: Did verification that svn revision + is a number. Fixed the imports (since the files uses ScriptError and log) + and a typo. + * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Added a test to verify + the behavior. + +2010-04-01 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Print an error message for readline bogosity in MacPorts + https://bugs.webkit.org/show_bug.cgi?id=36979 + + * Scripts/webkitpy/common/system/user.py: + +2010-04-01 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Don't pass --non-interactive to create-rollout + https://bugs.webkit.org/show_bug.cgi?id=36989 + + It turns out you can't pass --non-interactive to create-rollout. Also, + improve our error reporting slighly to catch the case where we error + out after creating the rollout bug. + + * Scripts/webkitpy/tool/bot/irc_command.py: + * Scripts/webkitpy/tool/bot/sheriff.py: + +2010-04-01 Ojan Vafai <ojan@chromium.org> + + Reviewed by Eric Seidel. + + webkit-patch can incorrectly think the working directory is modified + https://bugs.webkit.org/show_bug.cgi?id=36985 + + If a file's modification time is modified, but the contents are not, + then diff-index will think the file has been modified unless you do + some crazy update-index call. Instead, call diff --name-only, which + has the index update builtin. + + Tried to write a test, but could not reproduce this in a unittest. + To test manually: + touch file-in-repo + git diff-index HEAD + git diff HEAD --name-only + + The diff-index call incorrectly shows file-in-repo as modified. + + * Scripts/webkitpy/common/checkout/scm.py: + +2010-04-01 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Add rollout command to sheriffbot + https://bugs.webkit.org/show_bug.cgi?id=36986 + + This IRC command creates a new bug an attaches a rollout patch. To + actually commit the rollout, a committer needs to mark the patch + commit-queue+ in bugs.webkit.org. + + Also, factored out some of the logic from the queue into a separate + object for easier testing. + + * Scripts/webkitpy/common/system/executive.py: + * Scripts/webkitpy/tool/bot/irc_command.py: + * Scripts/webkitpy/tool/bot/sheriff.py: Added. + * Scripts/webkitpy/tool/bot/sheriff_unittest.py: Added. + * Scripts/webkitpy/tool/bot/sheriffircbot.py: + * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: + * Scripts/webkitpy/tool/commands/queues.py: + * Scripts/webkitpy/tool/commands/sheriffbot.py: + * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py: + +2010-04-01 Eric Seidel <eric@webkit.org> + + Unreviewed, only ignoring chatty style errors. + + check-webkit-style: WebKit needs a python style checker + https://bugs.webkit.org/show_bug.cgi?id=33639 + + Remove the 79 char line limit by ignoring + pep8/E501. Because we have our own report_error + implementation we have to ignore E501 by hand + instead of passing --ignore=E501. + + Right now over 1400 lines of our existing python + fail E501 so this rule just generates needless noise. + The rest of WebKit has no wrapping rule so it makes + little sense for our Python to differ here. + + * Scripts/webkitpy/style/processors/python.py: + +2010-04-01 Adam Barth <abarth@webkit.org> + + Unreviewed. Add cmarrin's IRC nickname. + + * Scripts/webkitpy/common/config/committers.py: + +2010-04-01 Adam Barth <abarth@webkit.org> + + Unreviewed. + + EWS spins hot when unable to build + https://bugs.webkit.org/show_bug.cgi?id=36981 + + The problem is that the queue engine things we have more work to do, + but the bot isn't actually able to do anything. After this change, we + back off the usual amount. + + * Scripts/webkitpy/tool/bot/queueengine.py: + * Scripts/webkitpy/tool/bot/queueengine_unittest.py: + * Scripts/webkitpy/tool/commands/queues.py: + * Scripts/webkitpy/tool/commands/sheriffbot.py: + +2010-04-01 Chris Marrin <cmarrin@apple.com> + + Reviewed by Simon Fraser. + + Added layerTreeAsText function to DRT (for Mac) + https://bugs.webkit.org/show_bug.cgi?id=36782 + + This is the DRT side. It exposes the call to JavaScript + through the LayoutTestController. + + * DumpRenderTree/LayoutTestController.cpp:Platform independent JavaScript shim + (layerTreeAsTextCallback): + (LayoutTestController::staticFunctions): + * DumpRenderTree/LayoutTestController.h: + * DumpRenderTree/mac/LayoutTestControllerMac.mm:Mac specific plumbing to WebKit + (LayoutTestController::layerTreeAsText): + * DumpRenderTree/win/LayoutTestControllerWin.cpp:Windows specific plumbing to WebKit + (LayoutTestController::layerTreeAsText): + +2010-04-01 Kevin Ollivier <kevino@theolliviers.com> + + [wx] Build fix after addition of JavaScriptCore/wtf/text directory. + + * wx/build/settings.py: + +2010-04-01 Jian Li <jianli@chromium.org> + + Rubber-stamped by David Levin. + + Add myself to the reviewers list. + + * Scripts/webkitpy/common/config/committers.py: + +2010-04-01 Adam Barth <abarth@webkit.org> + + Unreviewed. + + Turns out the Chromium Windows bots don't have pdevenv installed. + + * Scripts/webkitdirs.pm: + +2010-04-01 Adam Barth <abarth@webkit.org> + + Reviewed by Dimitri Glazkov. + + Let Chromium Windows build with Visual Studio Express + https://bugs.webkit.org/show_bug.cgi?id=36919 + + This is horrible, horrible copy/paste code, but that seems to be the + way of webkitdirs.pm. :( + + Someone needs to go through an cleanup this code, but I don't have the + heart to do it in this patch. + + * Scripts/webkitdirs.pm: + +2010-04-01 Ilya Tikhonovsky <loislo@chromium.org> + + Reviewed by Yury Semikhatsky. + + Add myself to the committers list. + https://bugs.webkit.org/show_bug.cgi?id=36953 + + * Scripts/webkitpy/common/config/committers.py: + +2010-04-01 Eric Seidel <eric@webkit.org> + + Rubber-stamped by Adam Barth. + + Add Snow Leopard Release bot to the list of "core builders" (builders which stop the commit-queue when they turn red) + https://bugs.webkit.org/show_bug.cgi?id=33292 + + Just adding the "Build" builder for now. + We'll add the "Test" builders when the tests + are less flaky. + + * Scripts/webkitpy/common/net/buildbot.py: + * Scripts/webkitpy/common/net/buildbot_unittest.py: + +2010-04-01 Yury Semikhatsky <yurys@chromium.org> + + Reviewed by David Levin. + + Add myself to the reviewers list. + + https://bugs.webkit.org/show_bug.cgi?id=36935 + + * Scripts/webkitpy/common/config/committers.py: + +2010-03-31 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Dave Levin. + + Added Python style checking to check-webkit-style using + the third-party pep8 module (via autoinstall). + + https://bugs.webkit.org/show_bug.cgi?id=33639 + + * Scripts/webkitpy/style/checker.py: + - Added PYTHON to FileType. + - Updated ProcessorDispatcher to return a PythonProcessor + for *.py files. + + * Scripts/webkitpy/style/checker_unittest.py: + - Updated the ProcessorDispatcher unit tests for *.py files. + + * Scripts/webkitpy/style/processors/python.py: Added. + - Added PythonProcessor class. + + * Scripts/webkitpy/style/processors/python_unittest.py: Added. + - Added PythonProcessor unit tests. + + * Scripts/webkitpy/style/processors/python_unittest_input.py: Added. + - Added a sample Python file to test the PythonProcessor.process() + code path (since pep8 accepts a file path). + + * Scripts/webkitpy/style/unittests.py: + - Updated the style unit test file to import python_unittest.py. + + * Scripts/webkitpy/style_references.py: + - Adjusted style references to import pep8. + +2010-03-31 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Dave Levin. + + Rewrote autoinstall.py to support unzipping *.zip files after + download, unzipping and extracting *.tar.gz files after download, + and copying installed files to a given destination directory. + + https://bugs.webkit.org/show_bug.cgi?id=35163 + + These changes will let us autoinstall pep8.py from the web and put + our third-party autoinstalled code in an explicit directory like + webkitpy/thirdparty/autoinstalled. These changes should also speed + up the execution of autoinstalled *.zip packages slightly since + *.pyc files cannot be generated when importing from zipped + packages using the current autoinstall. + + * Scripts/test-webkitpy: + - Addressed the FIXME to enable auto-install logging once + autoinstall was rewritten not to log as verbosely. + + * Scripts/webkitpy/common/net/bugzilla.py: + - Updated mechanize import statement. + + * Scripts/webkitpy/common/net/buildbot.py: + - Updated mechanize import statement. + + * Scripts/webkitpy/common/net/irc/ircbot.py: + - Updated ircbot and irclib import statements. + + * Scripts/webkitpy/common/net/networktransaction.py: + - Updated mechanize import statement. + + * Scripts/webkitpy/common/net/networktransaction_unittest.py: + - Updated mechanize import statement. + + * Scripts/webkitpy/common/net/statusserver.py: + - Updated mechanize import statement. + + * Scripts/webkitpy/common/system/autoinstall.py: Added. + - Added AutoInstaller class. + - Added sample/testing usage to the __main__ block. + + * Scripts/webkitpy/thirdparty/__init__.py: + - Updated the autoinstall lines to use the new autoinstall methods. + - Added pep8.py to the list of auto-installed packages. + - Added a README file to the target autoinstallation directory + so users know that the directory is safe to delete. + + * Scripts/webkitpy/thirdparty/autoinstall.py: Removed. + - This is replaced by the rewritten autoinstall + webkitpy/common/system/autoinstall.py. + + * Scripts/webkitpy/thirdparty/autoinstalled/__init__.py: Removed. + - The target autoinstallation directory is now auto-generated. + +2010-03-31 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Shinichiro Hamaji. + + Tweak webkitpy's logtesting.LogTesting class to get more mileage out + of our unit tests that test log messages. + + https://bugs.webkit.org/show_bug.cgi?id=36886 + + This patch adds to the LogTesting class's tearDown() method a line + asserting that the array of remaining log messages is empty. This + ensures that no extra log messages are getting logged that the caller + might not be aware of or may have forgotten to check for. + + * Scripts/webkitpy/common/system/logtesting.py: + - Modified the tearDown() method as described above. + - Also modified the assertMessages() method to clear the array + of log messages after asserting. + +2010-03-31 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Adam Barth. + + Added support for a --verbose-logging flag to test-webkitpy. + + https://bugs.webkit.org/show_bug.cgi?id=36429 + + Verbose logging is useful for debugging test-webkitpy code that + runs before the actual unit tests -- things like autoinstalling and + unit-test auto-detection logic. This is different from verbose + logging of the unit tests themselves (which corresponds to the + unittest module's --verbose flag). + + * Scripts/test-webkitpy: + - In the configure_logging() method-- + - Added an is_verbose_logging parameter that sets the logging + level to logging.DEBUG instead of logging.INFO. + - Changed the method to throttle the logging level on the + root logger's handler instead of directly on the root logger + itself. + - Enabled logging of the autoinstall module when the flag is set. + + * Scripts/webkitpy/thirdparty/autoinstalled/__init__.py: + - Added a work-around for a bug in Python 2.6's logging module + that was discovered while working on this patch. + +2010-03-31 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Adam Barth. + + Enabled Python's logging module for webkit-patch, and replaced + deprecated_logging with Python logging in networktransaction.py. + This eliminates some spurious output when running test-webkitpy. + + https://bugs.webkit.org/show_bug.cgi?id=36725 + + * Scripts/webkit-patch: + - Replaced the configure_logging() function with a call to + the new logutils.configure_logging() function. + + * Scripts/webkitpy/common/net/networktransaction.py: + - Replaced the use of deprecated_logging with Python logging. + + * Scripts/webkitpy/common/system/logutils.py: + - Added _default_handlers() which creates the default logging + handler for webkitpy. + - Added configure_logging() which configures default logging + for webkitpy. + + * Scripts/webkitpy/common/system/logutils_unittest.py: + - Added unit tests for logutils.configure_logging(). + + * Scripts/webkitpy/style/checker.py: + - Refactored check-webkit-style's configure_logging() method + to call the new logutils.configure_logging(). + + * Scripts/webkitpy/style_references.py: + - Updated references as necessary. + +2010-03-31 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + webkit-patch land fails if not run from the root directory + https://bugs.webkit.org/show_bug.cgi?id=35822 + + The root of the problem was that ChangeLog.__init__ expects a path + relative to the current working directory, and SCM expects to + return paths relative to the SCM root. Fix it by converting from + SCM-relative to absolute paths in Checkout.modified_changelogs + + * Scripts/webkitpy/common/checkout/api.py: + * Scripts/webkitpy/common/checkout/api_unittest.py: + +2010-03-31 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Add more tests for webkitpy.common.checkout + https://bugs.webkit.org/show_bug.cgi?id=36926 + + We don't have a great way of testing checkout, sadly. + + * Scripts/webkitpy/common/checkout/api_unittest.py: + +2010-03-31 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + REGRESSION: EWS crashes on failure + https://bugs.webkit.org/show_bug.cgi?id=36924 + + Turns out we need to pass one more argument. My test is kind of lame, + but at least it's there. + + * Scripts/webkitpy/tool/commands/earlywarningsystem.py: + * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: + +2010-03-31 Chris Jerdonek <cjerdonek@webkit.org> + + Unreviewed. + + Fixed typo in WebKitTools/ChangeLog: opsys -> ospath. + +2010-03-31 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Make the EWS go faster by being optimistic + https://bugs.webkit.org/show_bug.cgi?id=36916 + + Have the EWS be optimistic that a patch will correctly build. This + should speed up the common case by not requiring two builds for every + patch. + + * Scripts/webkitpy/tool/commands/earlywarningsystem.py: + * Scripts/webkitpy/tool/commands/queues.py: + +2010-03-31 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Add the ability to restart sheriffbot from IRC + https://bugs.webkit.org/show_bug.cgi?id=36909 + + * Scripts/webkitpy/tool/bot/irc_command.py: + * Scripts/webkitpy/tool/bot/queueengine.py: + * Scripts/webkitpy/tool/bot/sheriffircbot.py: + * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: + +2010-03-31 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Add win-ews to QueueStatusServer + https://bugs.webkit.org/show_bug.cgi?id=36876 + + The win-ews is still experimental, but it seems to be more or less + running. We should show its results to the people. + + * QueueStatusServer/model/queues.py: + * QueueStatusServer/templates/dashboard.html: + * QueueStatusServer/templates/statusbubble.html: + +2010-03-30 Victor Wang <victorw@chromium.org> + + Reviewed by Eric Seidel. + + Update rebaseline tool to check the release image diff binary and + fallback to debug if the release version does not exist. + + https://bugs.webkit.org/show_bug.cgi?id=36245 + + * Scripts/webkitpy/layout_tests/port/base.py: + * Scripts/webkitpy/layout_tests/port/chromium.py: + * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: + +2010-03-31 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + Teach buildbot.py how to parse builder activity from /one_box_per_builder + https://bugs.webkit.org/show_bug.cgi?id=36898 + + I also removed some obsolete FIXMEs and + refactored one_box_per_builder parsing into multiple + methods for easier reading. + + * Scripts/webkitpy/common/net/buildbot.py: + * Scripts/webkitpy/common/net/buildbot_unittest.py: + +2010-03-31 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Eric Seidel. + + Fix logging in new-run-webkit-tests so that we don't report IMAGE + expected failures as unexpected passes when we run with pixel tests + disabled. + + This change splits some of the logic embedded into the TestExpectations + classes out into separate pure functions (result_was_expected, + remove_image_failures) to make them easier to test. This also adds + a parameter to matches_an_expected_result() to indicate whether or + not pixel test results should be included in the expectations. + + https://bugs.webkit.org/show_bug.cgi?id=36771 + + * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: + * Scripts/webkitpy/layout_tests/layout_package/test_expectations_test.py: + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + +2010-03-31 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Eric Seidel. + + In webkitpy, refactored two calls to os.path.relpath() replacements + to use a common method. + + https://bugs.webkit.org/show_bug.cgi?id=36891 + + * Scripts/webkitpy/common/net/bugzilla.py: + - Replaced the relpath implementation with a call to + webkitpy.common.system.ospath.relpath(). + + * Scripts/webkitpy/common/system/ospath.py: Added. + - Moved the relpath() implementation from style/main.py. + + * Scripts/webkitpy/common/system/ospath_unittest.py: Added. + - Moved the relpath() unit tests from style/main_unittest.py. + + * Scripts/webkitpy/style/main.py: + - Replaced the relpath implementation with a call to + webkitpy.common.system.ospath.relpath(). + + * Scripts/webkitpy/style/main_unittest.py: + - Moved the relpath unit tests to ospath_unittest.py. + +2010-03-31 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Add a Builder.force_build method + https://bugs.webkit.org/show_bug.cgi?id=36875 + + We plan to eventually use this in SheriffBot to break deadlocks created + by flaky tests. + + * Scripts/webkitpy/common/net/buildbot.py: + +2010-03-31 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + webkit-patch reads wrong bug url from unified diff context + https://bugs.webkit.org/show_bug.cgi?id=36477 + + Instead of trying to figure out the bug_id from the diff, we should + just get the information from the Checkout object, which understands + these concepts. + + * Scripts/webkitpy/common/checkout/api.py: + * Scripts/webkitpy/common/checkout/commitinfo.py: + * Scripts/webkitpy/tool/commands/download.py: + * Scripts/webkitpy/tool/commands/upload.py: + * Scripts/webkitpy/tool/mocktool.py: + +2010-03-31 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + webkit-patch commit-queue should land patches optimistically + https://bugs.webkit.org/show_bug.cgi?id=34187 + + This patch adds an optimistic path to commit-queue and a "fail twice" + requirement for rejecting patches. That means we'll land good patches + faster (via the optmistic first run) and we'll reject many fewer + patches due to flaky tests. + + * Scripts/webkitpy/tool/commands/queues.py: + +2010-03-31 Diego Gonzalez <diego.gonzalez@openbossa.org> + + Reviewed by Kenneth Rohde Christiansen. + + [Qt] Custom user agent for user agent switcher + https://bugs.webkit.org/show_bug.cgi?id=36757 + + * QtLauncher/main.cpp: + (LauncherWindow::showUserAgentDialog): + +2010-03-31 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + path to committers.py in commit-queue rejection message is wrong + https://bugs.webkit.org/show_bug.cgi?id=36865 + + This fix would have only been 3 lines long if we had + 1. Had access to an SCM object or tool to give us the checkout root + 2. Been able to depend on Python 2.6 + Instead I've added a bunch of hack code, but at least now + we should never have to update this string again as the location + of committers.py is fully dynamically discovered. :p + + * Scripts/webkitpy/common/net/bugzilla.py: + * Scripts/webkitpy/common/net/bugzilla_unittest.py: + +2010-03-31 Shinichiro Hamaji <hamaji@chromium.org> + + Unreviewed test fix for r56809. + + webkit-patch what-broke throws exception + https://bugs.webkit.org/show_bug.cgi?id=36852 + + * Scripts/webkitpy/common/checkout/api_unittest.py: + +2010-03-30 Chris Jerdonek <cjerdonek@webkit.org> + + Rubber stamped by Dave Levin. + + Made check-webkit-style less chatty. + + Examples include: + - https://bugs.webkit.org/show_bug.cgi?id=36866#c4 + - https://bugs.webkit.org/show_bug.cgi?id=36472#c9 + + * Scripts/webkitpy/style/checker.py: + - Changed unrecognized file type log message from info to debug. + +2010-03-30 Kevin Ollivier <kevino@theolliviers.com> + + [wx] Build fix after new method added. + + * DumpRenderTree/wx/LayoutTestControllerWx.cpp: + (LayoutTestController::callShouldCloseOnWebView): + +2010-03-30 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + webkit-patch what-broke throws exception + https://bugs.webkit.org/show_bug.cgi?id=36852 + + * Scripts/webkitpy/common/checkout/api.py: Add missing import StringIO. + * Scripts/webkitpy/common/checkout/api_unittest.py: Test the function which previously threw and exception. + +2010-03-30 Alexey Proskuryakov <ap@apple.com> + + Reviewed by Darin Adler. + + https://bugs.webkit.org/show_bug.cgi?id=36616 + Dvorak-Qwerty keyboard layout gives unexpected results in javascript keydown + + https://bugs.webkit.org/show_bug.cgi?id=36797 + For non-Roman layouts, keydown Event.keyCode is always 0 + + * DumpRenderTree/mac/EventSendingController.mm: + (-[EventSendingController keyDown:withModifiers:withLocation:]): Generate a correct keyCode + for keys used in tests (we used to always pass 0 for 'A'). + +2010-03-30 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Implement win-ews + https://bugs.webkit.org/show_bug.cgi?id=36809 + + * Scripts/webkitpy/common/config/ports.py: + * Scripts/webkitpy/tool/commands/earlywarningsystem.py: + +2010-03-30 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Eric Seidel. + + Adjusted test-webkitpy to delete all orphaned *.pyc files + from webkitpy/ prior to importing any modules from webkitpy. + This ensures that no import statements in webkitpy falsely + succeed because of leftover *.pyc files. + + https://bugs.webkit.org/show_bug.cgi?id=36599 + + * Scripts/test-webkitpy: + - Added _clean_pyc_files() to delete orphaned *.pyc files + from a directory. + - Added _clean_webkitpy_with_test() to call and test + _clean_pyc_files(). + - Moved the "import webkitpy.python24.versioning" statement + from the top of the module to the init() method -- immediately + after the call to _clean_webkitpy_with_test(). + +2010-03-30 Fumitoshi Ukai <ukai@chromium.org> + + Reviewed by Shinichiro Hamaji. + + [Chromium-Win] subprocess.call should be called with stdin=open(os.devnull,'r') + https://bugs.webkit.org/show_bug.cgi?id=36811 + + subproess.Popen() on Python 2.4/Windows with stdout,stdout, but no stdin will fail, because it uses return value of GetStdHandle(STD_INPUT_HANDLE), but DuplicateHandle requires integer, not the handle. + We don't need stdin, so use devnull as stdin. + Same as https://bugs.webkit.org/show_bug.cgi?id=36586 + + * Scripts/webkitpy/layout_tests/port/chromium_win.py: open os.devnull for stdin + +2010-03-29 Eric Seidel <eric@webkit.org> + + Unreviewed, build fix only. + + * Scripts/webkitpy/tool/steps/validatereviewer.py: Add missing import. + +2010-03-29 Hayato Ito <hayato@chromium.org> + + Reviewed by Shinichiro Hamaji. + + Remove '_flymake' suffix from base part of file name so that + check-webkit-style uses a correct header guard name when it is called from Emacs's flymake. + + https://bugs.webkit.org/show_bug.cgi?id=36573 + + * Scripts/webkitpy/style/processors/cpp.py: + * Scripts/webkitpy/style/processors/cpp_unittest.py: + +2010-03-29 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Eric Seidel. + + Get the following test-webkitpy unit test working again: + scm_unittest.SVNTest.test_svn_apply(). + + https://bugs.webkit.org/show_bug.cgi?id=36696 + + * Scripts/webkitpy/common/checkout/scm_unittest.py: + - Add leading spaces to the empty lines of the ChangeLog strings. + - Manually set the _reviewer attribute on the Attachment object + to get the tests to pass. + +2010-03-29 Martin Robinson <mrobinson@webkit.org> + + Reviewed by Holger Freyther. + + [GTK] suppress (un)desired launcher output that can make layout test to fail with stderr + https://bugs.webkit.org/show_bug.cgi?id=36390 + + Suppress debugging messages sent to the GLib logger during DRT runs. + + * DumpRenderTree/gtk/DumpRenderTree.cpp: + (logHandler): Added. + (main): Use logHandler as the default GLib log message handler. + +2010-03-29 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + sheriff-bot should comment on bugs when builders break + https://bugs.webkit.org/show_bug.cgi?id=36786 + + * Scripts/webkitpy/tool/commands/sheriffbot.py: + - Add a new _post_blame_comment_to_bug and all it from process_work_item + - Move commit-queue logic into _post_rollout_patch to make its api match the other _post commands. + * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py: + - Test the new _post_blame_comment_to_bug call + +2010-03-29 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + sheriff-bot fails to get information about certain builds + https://bugs.webkit.org/show_bug.cgi?id=36768 + + This seems to be caused by: + http://buildbot.net/trac/ticket/753 + I have no work-around, but for now at least we're logging + the error better. I also added allow_none to our ServerProxy + creation in case that fixes things for other versions of python. + + * Scripts/webkitpy/common/net/buildbot.py: + +2010-03-29 Victor Wang <victorw@chromium.org> + + Reviewed by Adam Barth. + + Add sign in/out link to TestResults appengine + + Add a link to main menu for sign in/out to this appengine. + People signed in with admin privilege could perform + actions that are only allowed to admins like deleting files. + + https://bugs.webkit.org/show_bug.cgi?id=36767 + + * TestResultServer/handlers/menu.py: + * TestResultServer/stylesheets/menu.css: + (.sign): + * TestResultServer/templates/menu.html: + +2010-03-29 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + ValidateReviewer step is draconian and un-tested + https://bugs.webkit.org/show_bug.cgi?id=36792 + + ValidateReviewer logic was commented out in + http://trac.webkit.org/changeset/56744 + That was a symptom of the fact that validatereviewer.py + is too inflexible to be used when real humans are driving webkit-patch. + For now we just disable ValidateReviewer when humans are at the keyboard. + + * Scripts/webkitpy/tool/steps/validatereviewer.py: + - Only run when in non-interactive mode. + * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: Added. + - Test our validation logic to make sure it's sane. + +2010-03-29 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Shinichiro Hamaji. + + Eliminate explicit slash characters from check-webkit-style's + _rel_path() method to make its implementation more platform + independent. + + https://bugs.webkit.org/show_bug.cgi?id=36759 + + * Scripts/webkitpy/style/main.py: + - Changed to use os.sep instead of slash_chars "/\\". This can + be done since os.path.abspath() converts slashes to os.sep. + +2010-03-29 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Dimitri Glazkov. + + Change new-run-webkit-tests to not use more than four threads by + default on the mac port until + https://bugs.webkit.org/show_bug.cgi?id=36622 is fixed. + + https://bugs.webkit.org/show_bug.cgi?id=36687 + + * Scripts/webkitpy/layout_tests/port/mac.py: + +2010-03-29 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Dimitri Glazkov. + + Reformat port/mac.py to fit witin 80 columns for PEP-8 compliance. + + https://bugs.webkit.org/show_bug.cgi?id=36691 + + * Scripts/webkitpy/layout_tests/port/mac.py: + +2010-03-29 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + new-run-webkit-tests fails java/lc3 on a clean checkout + https://bugs.webkit.org/show_bug.cgi?id=36078 + + * Scripts/webkitpy/layout_tests/port/mac.py: + - Build the java support files in check_build + - Unwrap a line which would still fit under 80col + +2010-02-26 Kenneth Rohde Christiansen <kenneth@webkit.org> + + Reviewed by Simon Fraser. + + Add support for Widgets 1.0: View Mode Media Feature + https://bugs.webkit.org/show_bug.cgi?id=35446 + + Add hooks to the Qt DRT for testing the view mode media feature. + + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::setViewModeMediaFeature): + * DumpRenderTree/qt/LayoutTestControllerQt.h: + +2010-03-29 Adam Barth <abarth@webkit.org> + + Unreviewed. Update expected results for unit tests. + + * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: + * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py: + +2010-03-29 Adam Barth <abarth@webkit.org> + + Unreviewed. I think Eric meant svn_revision. + + * Scripts/webkitpy/tool/commands/sheriffbot.py: + +2010-03-26 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + webkit-patch commit-queue should notice if it breaks builders (and roll out its own changes) + https://bugs.webkit.org/show_bug.cgi?id=29311 + + Now that we have sheriff-bot watching the tree, it can post + rollout patches on behalf of the commit queue. + + * Scripts/webkitpy/common/checkout/commitinfo.py: add responsible_parties() + * Scripts/webkitpy/common/checkout/commitinfo_unittest.py: test responsible_parties() + * Scripts/webkitpy/tool/commands/sheriffbot.py: + - Break IRC logic out into _post_irc_warning for easier testing. + - Add _post_rollout_patch for posting rollout patches to bugzilla. + * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py: + - Test _rollout_reason + * Scripts/webkitpy/tool/grammar.py: + - Fix join_with_separators to not add Adam's "oxford comma" for two item lists. + * Scripts/webkitpy/tool/grammar_unittest.py: + - Test join_with_separators + +2010-03-29 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Sheriffbot should actually run commands + https://bugs.webkit.org/show_bug.cgi?id=36776 + + Some minor changes to Sheriffbot: + + 1) We should actually run commands (by giving control back to the + command processing object. + + 2) Use URLs instead of just numbers to represent SVN revisions (making + it easier to folks in IRC ot followup). + + * Scripts/webkitpy/tool/bot/irc_command.py: + * Scripts/webkitpy/tool/bot/queueengine.py: + * Scripts/webkitpy/tool/commands/sheriffbot.py: + +2010-03-26 Kenneth Rohde Christiansen <kenneth@webkit.org> + + Reviewed by Antti Koivisto. + + Renaming of frame flattening LayoutTestController method + to setFrameFlatteningEnabled(bool) + + * DumpRenderTree/LayoutTestController.cpp: + (setFrameFlatteningEnabledCallback): + (LayoutTestController::staticFunctions): + * DumpRenderTree/LayoutTestController.h: + * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: + (LayoutTestController::setFrameFlatteningEnabled): + * DumpRenderTree/mac/DumpRenderTree.mm: + (resetDefaultsToConsistentValues): + * DumpRenderTree/mac/LayoutTestControllerMac.mm: + (LayoutTestController::setFrameFlatteningEnabled): + * DumpRenderTree/qt/DumpRenderTreeQt.cpp: + (WebCore::WebPage::resetSettings): + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::setFrameFlatteningEnabled): + * DumpRenderTree/qt/LayoutTestControllerQt.h: + * DumpRenderTree/win/DumpRenderTree.cpp: + (resetDefaultsToConsistentValues): + * DumpRenderTree/win/LayoutTestControllerWin.cpp: + (LayoutTestController::setFrameFlatteningEnabled): + * DumpRenderTree/wx/LayoutTestControllerWx.cpp: + (LayoutTestController::setFrameFlatteningEnabled): + +2010-03-28 Gustavo Noronha Silva <gns@gnome.org> + + No review, rolling out r56679. + http://trac.webkit.org/changeset/56679 + https://bugs.webkit.org/show_bug.cgi?id=36454 + + Lots of tests broken. + + * DumpRenderTree/gtk/DumpRenderTree.cpp: + (createWebView): + +2010-03-28 Chris Jerdonek <cjerdonek@webkit.org> + + Unreviewed. + + Fixed typo in deprecated_logging_unittest.py, which is masking + sys.stderr while running test-webkitpy. + + See also-- https://bugs.webkit.org/show_bug.cgi?id=36725#c3 + + * Scripts/webkitpy/common/system/deprecated_logging_unittest.py: + +2010-03-28 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Shinichiro Hamaji. + + Renamed check-webkit-style's --debug flag to --verbose to be more + in line with other WebKit scripts. Also renamed the current + --verbose flag to --min-confidence to allow the --debug rename. + + https://bugs.webkit.org/show_bug.cgi?id=36521 + + We also renamed the internal "verbose" variables to "confidence" or + "min_confidence," as appropriate, to avoid confusion with the + --verbose flag, and because the new names are more accurate. + + * Scripts/check-webkit-style: + - Renamed is_debug to is_verbose. + + * Scripts/webkitpy/style/checker.py: + - Renamed _DEFAULT_VERBOSITY to _DEFAULT_CONFIDENCE. + - Renamed "verbosity" parameters to "min_confidence" throughout. + - Renamed configure_logging()'s is_debug parameter to is_verbose. + + * Scripts/webkitpy/style/checker_unittest.py: + - Updated the unit tests as necessary. + + * Scripts/webkitpy/style/error_handlers.py: + - Updated the call to StyleCheckerConfiguration.write_style_error(). + + * Scripts/webkitpy/style/error_handlers_unittest.py: + - Updated the unit tests as necessary. + + * Scripts/webkitpy/style/optparser.py: + - Updated the usage string with the new flag names. + - Renamed the verbosity parameter to min_confidence throughout. + - Renamed the is_debug parameter to is_verbose throughout. + + * Scripts/webkitpy/style/optparser_unittest.py: + - Updated the unit tests as necessary. + + * Scripts/webkitpy/style/processors/cpp.py: + - Renamed the verbosity parameter to min_confidence throughout. + + * Scripts/webkitpy/style/processors/cpp_unittest.py: + - Updated the unit tests as necessary. + +2010-03-28 Chris Jerdonek <cjerdonek@webkit.org> + + Unreviewed. + + Added back a line that accidentally got deleted in r56690. + + * Scripts/check-webkit-style: + +2010-03-28 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Shinichiro Hamaji. + + Add to check-webkit-style support for checking directories. + + https://bugs.webkit.org/show_bug.cgi?id=35234 + + * Scripts/check-webkit-style: + - Replaced the call to check_file() with a call to check_paths(). + + * Scripts/webkitpy/style/checker.py: + - In the StyleChecker class: + - Added a check_paths() method that accepts a list of paths + to files and directories. + - Added a _check_directory() method that checks the files + in a directory. + + * Scripts/webkitpy/style/checker_unittest.py: + - Added a StyleCheckerCheckPathsTest to unit-test the new + check_paths() method. + + * Scripts/webkitpy/style/optparser.py: + - Updated the usage string. + +2010-03-28 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Shinichiro Hamaji. + + Changed check-webkit-style to convert paths to paths relative to + the checkout root when invoking check-webkit-style with path + arguments. Also added warning messages where appropriate. + + https://bugs.webkit.org/show_bug.cgi?id=35498 + + Converting paths to paths relative to the checkout root ensures + that style checking will behave as expected (since path-specific + rules assume input paths are relative to a source root). + + * Scripts/check-webkit-style: + - Added debug logging of whether the current directory was found + to be in a WebKit checkout. + - Added the found_checkout parameter to the call to parser.parse(). + - Renamed the files variable to paths. + - Added a call to change_directory() prior to checking style. + + * Scripts/webkitpy/style/checker.py: + - For StyleChecker.check_file(): + - Updated the docstring. + - Added two log messages. + + * Scripts/webkitpy/style/checker_unittest.py: + - Updated a call to parser.parse() with the found_checkout parameter. + + * Scripts/webkitpy/style/main.py: Added. + - Added a new file so the code in this patch could be unit-tested, + as opposed to adding new code to check-webkit-style. + - Added the method _rel_path() as a substitute for os.path.relpath(), + which is available only in Python 2.6. + - Added the method change_directory(), which contains most of the + new functionality in this patch. + + * Scripts/webkitpy/style/main_unittest.py: Added. + - Added RelPathTest to test main._rel_path(). + - Added ChangeDirectoryTest to test main.change_directory(). + + * Scripts/webkitpy/style/optparser.py: + - Updated check-webkit-style's usage string. + - For the ArgumentParser.parse() method: + - Added a found_checkout parameter. + - Renamed filenames to paths. + - Added logic so that an error is raised if no paths are passed + if found_checkout is False. + + * Scripts/webkitpy/style/optparser_unittest.py: + - Updated the ArgumentParser.parse() unit tests to include + coverage for the new found_checkout parameter. + + * Scripts/webkitpy/style/unittests.py: + - Added an import statement for main_unittest. + + * Scripts/webkitpy/style_references.py: + - Renamed SimpleScm to WebKitCheckout. + - Added a detect_checkout() function to allow returning None + instead of a WebKitCheckout instance if no checkout is found. + - Renamed checkout_root to root_path. + +2010-03-27 Sergio Villar Senin <svillar@igalia.com> + + Reviewed by Eric Seidel. + + Print didHandleOnloadEventsForFrame in the callback of + onload-event signal comming from frame loader + + [GTK] Improve reporting of frame loader callbacks in DRT + https://bugs.webkit.org/show_bug.cgi?id=36454 + + * DumpRenderTree/gtk/DumpRenderTree.cpp: + (webViewOnloadEvent): + (createWebView): added connection to signal::onload-event and + signal callback + +2010-03-27 Sergio Villar Senin <svillar@igalia.com> + + Reviewed by Eric Seidel. + + Print didCommitLoadForFrame in the callback of signal::load-committed + + [GTK] Improve reporting of frame loader callbacks in DRT + https://bugs.webkit.org/show_bug.cgi?id=36454 + + * DumpRenderTree/gtk/DumpRenderTree.cpp: + (webViewLoadCommitted): + (createWebView): added connection to sinal::load-committed and + signal callback + +2010-03-27 Sergio Villar Senin <svillar@igalia.com> + + Reviewed by Eric Seidel. + + Print didStartProvisionalLoadForFrame in the callback of + notify::load-status property change notification + + [GTK] Improve reporting of frame loader callbacks in DRT + https://bugs.webkit.org/show_bug.cgi?id=36454 + + * DumpRenderTree/gtk/DumpRenderTree.cpp: + (webInspectorCloseWindow): + (webInspectorInspectWebView): + (createWebView): added connection to notify::load-status and + signal callback + +2010-03-27 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Adam Barth. + + In webkitpy/, deleted the /unittests.py files since test-webkitpy + now auto-detects all *_unittest.py files. + + https://bugs.webkit.org/show_bug.cgi?id=36712 + + * Scripts/webkitpy/common/net/irc/unittests.py: Removed. + * Scripts/webkitpy/common/system/unittests.py: Removed. + * Scripts/webkitpy/common/thread/unittests.py: Removed. + * Scripts/webkitpy/common/unittests.py: Removed. + * Scripts/webkitpy/python24/unittests.py: Removed. + * Scripts/webkitpy/style/unittests.py: Removed. + * Scripts/webkitpy/tool/unittests.py: Removed. + * Scripts/webkitpy/unittests.py: Removed. + +2010-03-27 Sergio Villar Senin <svillar@igalia.com> + + Reviewed by Eric Seidel. + + Add a CR after printing didFinishDocumentLoadForFrame + + [GTK] Improve reporting of frame loader callbacks in DRT + https://bugs.webkit.org/show_bug.cgi?id=36454 + + * DumpRenderTree/gtk/DumpRenderTree.cpp: + (webViewLoadFinished): + +2010-03-27 Chris Jerdonek <cjerdonek@webkit.org> + + Rubber-stamped by Adam Barth. + + Fixed the name of a unit test file in webkitpy. + + * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py. + * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py: Removed. + +2010-03-26 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Adam Barth. + + The test-webkitpy script now automatically detects all unit-test + files in webkitpy/. This lets us eliminate the need to have and + maintain all of the unittests.py files. + + https://bugs.webkit.org/show_bug.cgi?id=36591 + + * Scripts/test-webkitpy: + - Replaced the "from webkitpy.unittests import *" with a call + to webkitpy.test.main.Tester().run_tests(). + + * Scripts/webkitpy/test/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py. + - Required file for the new webkitpy/test/ directory. + + * Scripts/webkitpy/test/main.py: Added. + - Added a Tester class that contains the following methods: + - _find_unittest_files() to detect all the unit-test files. + - _modules_from_paths() to convert the paths to the unit-test + files to fully-qualified module names. + - run_tests() which calls the above two methods and then passes + the module names to Python's unittest module. + +2010-03-27 Robert Hogan <robert@webkit.org> + + Reviewed by Simon Fraser. + + [Qt/Win] Add support to unix and windows NS plugin for executing scripts on setWindow. + + https://bugs.webkit.org/show_bug.cgi?id=36701 + + * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: + (webkit_test_plugin_new_instance): Add onSetWindow. + (webkit_test_plugin_destroy_instance): Add onSetWindow. + (webkit_test_plugin_set_window): Add onSetWindow. + * DumpRenderTree/win/TestNetscapePlugin/main.cpp: + (NPP_New): Add onSetWindow. + (NPP_Destroy): Add onSetWindow. + (NPP_SetWindow): Add onSetWindow. + +2010-03-26 Robert Hogan <robert@roberthogan.net> + + Reviewed by Simon Hausmann. + + Allow plugins implemented by the application, such as mimetype 'x-qt-plugin', + when pluginsEnabled is false. + + Add support for LayoutTestController.WebKitPluginsEnabled + + https://bugs.webkit.org/show_bug.cgi?id=32196 + + * DumpRenderTree/gtk/DumpRenderTree.cpp: + (resetDefaultsToConsistentValues): + * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: + (copyWebSettingKey): + * DumpRenderTree/qt/DumpRenderTreeQt.cpp: + (WebCore::WebPage::resetSettings): + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::overridePreference): + +2010-03-26 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Add some basic IRC commands to sheriffbot + https://bugs.webkit.org/show_bug.cgi?id=36684 + + Adds support for sheriffbot to respond to a "hi" command and a + "last-green-revision" command. It's lame that we're rebuilding + MultiCommandTool, but as discussed in person we'll intergrate the two + once we see what the requirements are. + + * Scripts/webkitpy/tool/bot/irc_command.py: Added. + * Scripts/webkitpy/tool/bot/queueengine.py: + * Scripts/webkitpy/tool/bot/queueengine_unittest.py: + * Scripts/webkitpy/tool/bot/sheriffircbot.py: + * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Added. + * Scripts/webkitpy/tool/commands/queues.py: + * Scripts/webkitpy/tool/commands/queuestest.py: + * Scripts/webkitpy/tool/commands/sheriffbot.py: + * Scripts/webkitpy/tool/main.py: + * Scripts/webkitpy/tool/mocktool.py: + * Scripts/webkitpy/tool/unittests.py: + +2010-03-26 Adam Barth <abarth@webkit.org> + + Unreviewed. More errors in the IRC module. I have no idea how to test + ircbot.py, which is too bad. Hopefully we've abstracted it away enough + that we don't have to touch it very much after this patch. + + * Scripts/webkitpy/common/net/irc/ircbot.py: + +2010-03-26 Adam Barth <abarth@webkit.org> + + Unreviewed. Add a missing "_". + + * Scripts/webkitpy/common/net/irc/ircproxy.py: + * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py: Added. + * Scripts/webkitpy/common/net/irc/unittests.py: + +2010-03-26 Adam Barth <abarth@webkit.org> + + Unreviewed. Fix a the commit queue after my recent change. + + * Scripts/webkitpy/tool/bot/queueengine.py: + +2010-03-26 Dirk Pranke <dpranke@chromium.org> + + Unreviewed fix. + + Fix the return value for port/base.diff_image (changed from 1/0 to + True/False in bug 34826. + + * Scripts/webkitpy/layout_tests/port/base.py: + +2010-03-26 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Eric Seidel. + + Change the Mac port of new-run-webkit-tests to look for a + test_expectations.txt file in addition to the Skipped files, so we + can track pixel failures. + + https://bugs.webkit.org/show_bug.cgi?id=36619 + + * Scripts/webkitpy/layout_tests/port/mac.py: + +2010-03-26 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Eric Seidel. + + Implement pixel tests (image diff) properly on the Mac port. + + This change introduces a new "ServerPocess" class that can be used + to manage processes that the run-webkit-tests harness forks off and + expects to stay up for longer than a single request/response session. + Both DumpRenderTree and ImageDiff use this style of communication, + although the current code forks off a new ImageDiff for each diff + (We need to restructure other parts of the code to be able to do this + safely in a multi-threaded environment). + + Also, now that the ServerProcess abstraction exists, we can probably + clean up and simplify some of the thread management logic in + test_shell_thread as well. + + https://bugs.webkit.org/show_bug.cgi?id=34826 + + * Scripts/webkitpy/layout_tests/port/mac.py: + * Scripts/webkitpy/layout_tests/port/server_process.py: + * Scripts/webkitpy/layout_tests/test_types/image_diff.py: + +2010-03-26 Sergio Villar Senin <svillar@igalia.com> + + Reviewed by Eric Seidel. + + Print didFinishLoadForFrame outcome in DRT + + [GTK] Improve reporting of frame loader callbacks in DRT + https://bugs.webkit.org/show_bug.cgi?id=36454 + + * DumpRenderTree/gtk/DumpRenderTree.cpp: + (webViewLoadCommitted): + +2010-03-26 Eric Seidel <eric@webkit.org> + + Unreviewed test fix. + My change conflicted with one of Adam's causing test-webkitpy to fail. + + Move commit_message_for_this_commit from scm to checkout + https://bugs.webkit.org/show_bug.cgi?id=36629 + + * Scripts/webkitpy/common/checkout/api_unittest.py: + - modified_changelogs is now on Checkout instead of scm. + +2010-03-26 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Refactor IRCBot controller logic to allow for commands + https://bugs.webkit.org/show_bug.cgi?id=36676 + + We need to move the controller logic into the tool package so it can + know about commands. The changes to queueengine could go in a + different patch, but we're going to need it anyway. + + * Scripts/webkitpy/common/config/irc.py: Added. + * Scripts/webkitpy/common/net/irc/ircbot.py: + * Scripts/webkitpy/common/net/irc/ircproxy.py: + * Scripts/webkitpy/tool/bot/queueengine.py: + * Scripts/webkitpy/tool/bot/sheriffircbot.py: Added. + * Scripts/webkitpy/tool/commands/sheriffbot.py: + * Scripts/webkitpy/tool/main.py: + * Scripts/webkitpy/tool/mocktool.py: + +2010-03-26 Adam Barth <abarth@webkit.org> + + Rubber stamped by Eric Seidel. + + Move the threading code into its own module. (It has nothing to do with IRC.) + + * Scripts/webkitpy/common/net/irc/ircbot.py: + * Scripts/webkitpy/common/net/irc/ircproxy.py: + * Scripts/webkitpy/common/net/irc/messagepump.py: Removed. + * Scripts/webkitpy/common/net/irc/messagepump_unittest.py: Removed. + * Scripts/webkitpy/common/net/irc/threadedmessagequeue.py: Removed. + * Scripts/webkitpy/common/net/irc/threadedmessagequeue_unittest.py: Removed. + * Scripts/webkitpy/common/net/irc/unittests.py: + * Scripts/webkitpy/common/thread: Added. + * Scripts/webkitpy/common/thread/__init__.py: Added. + * Scripts/webkitpy/common/thread/messagepump.py: Copied from Scripts/webkitpy/common/net/irc/messagepump.py. + * Scripts/webkitpy/common/thread/messagepump_unittest.py: Copied from Scripts/webkitpy/common/net/irc/messagepump_unittest.py. + * Scripts/webkitpy/common/thread/threadedmessagequeue.py: Copied from Scripts/webkitpy/common/net/irc/threadedmessagequeue.py. + * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py: Copied from Scripts/webkitpy/common/net/irc/threadedmessagequeue_unittest.py. + * Scripts/webkitpy/common/thread/unittests.py: Added. + * Scripts/webkitpy/common/unittests.py: + +2010-03-26 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + Move commit_message_for_this_commit from scm to checkout + https://bugs.webkit.org/show_bug.cgi?id=36629 + + Finally add some basic unit testing for Checkout.commit_message_for_this_commit + + * Scripts/webkitpy/common/checkout/api.py: + * Scripts/webkitpy/common/checkout/api_unittest.py: Added. + * Scripts/webkitpy/common/unittests.py: + +2010-03-26 Diego Gonzalez <diego.gonzalez@openbossa.org> + + [Qt] User Agent Switcher on QtLauncher + https://bugs.webkit.org/show_bug.cgi?id=36451 + + Patch by Diego Gonzalez <diego.gonzalez@openbossa.org> on 2010-03-26 + Reviewed by Simon Hausmann. + + Make possible to change the QtLauncher user agent via + a predefined list. + + * QtLauncher/QtLauncher.pro: + * QtLauncher/QtLauncher.qrc: Added. + * QtLauncher/main.cpp: + (LauncherWindow::showUserAgentDialog): + (LauncherWindow::createChrome): + * QtLauncher/useragentlist.txt: Added. + * QtLauncher/webpage.cpp: + (WebPage::userAgentForUrl): + * QtLauncher/webpage.h: + (WebPage::setUserAgent): + +2010-03-26 Victor Wang <victorw@chromium.org> + + Reviewed by Adam Barth. + + Host layout test flakiness dashboard in TestResultServer appengine. + + Flakiness dashboard is a tool to monitor layout test status and + help layout test regression diagnostics. + + https://bugs.webkit.org/show_bug.cgi?id=36195 + + * TestResultServer/handlers/dashboardhandler.py: Added. + - New handler to handle dashboard request + * TestResultServer/handlers/menu.py: + - Add new dashboard links + * TestResultServer/handlers/testfilehandler.py: + - Request routes refactory + * TestResultServer/index.yaml: + * TestResultServer/main.py: + - Add new dashboard request routes and refactor test result file rountes. + * TestResultServer/model/dashboardfile.py: Added. + - Model to access datastore for dashboard files + * TestResultServer/model/testfile.py: + * TestResultServer/stylesheets/dashboardfile.css: Added. + * TestResultServer/templates/dashboardfilelist.html: Added. + * TestResultServer/templates/showfilelist.html: + +2010-03-26 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Remove some evil statics from CommitInfo + https://bugs.webkit.org/show_bug.cgi?id=36637 + + These methods should really be on checkout. You can tell because they + know about ChangeLogs and take an SCM as an argument. :) + + * Scripts/webkitpy/common/checkout/api.py: + * Scripts/webkitpy/common/checkout/changelog.py: + * Scripts/webkitpy/common/checkout/commitinfo.py: + * Scripts/webkitpy/tool/commands/queries.py: + +2010-03-23 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> + + Reviewed by Simon Hausmann. + + Add an option to QtLauncher to enable/disable a QGLWidget as Viewport + of the QGraphicsView when the launcher is running on graphicsview mode. + + [Qt] QtLauncher needs an option to Enable/Disable a QGLWidget as Viewport + https://bugs.webkit.org/show_bug.cgi?id=36270 + + * QtLauncher/QtLauncher.pro: + * QtLauncher/main.cpp: + (LauncherWindow::toggleQGLWidgetViewport): + (LauncherWindow::createChrome): + +2010-03-26 Fumitoshi Ukai <ukai@chromium.org> + + Reviewed by Shinichiro Hamaji. + + [Chromium-Win] websocket_server.py failed to start + https://bugs.webkit.org/show_bug.cgi?id=36586 + + subproess.Popen() on Python 2.4/Windows with stdout,stdout, but no stdin will fail, because it uses return value of GetStdHandle(STD_INPUT_HANDLE), but DuplicateHandle requires integer, not the handle. + We don't need stdin, so use devnull as stdin. + + * Scripts/webkitpy/layout_tests/port/websocket_server.py: open os.devnull for stdin + +2010-03-26 Kent Tamura <tkent@chromium.org> + + Reviewed by Dimitri Glazkov. + + [DRT/Chromium] Add TestNavigationController and TestWebWorker + https://bugs.webkit.org/show_bug.cgi?id=36520 + + Add LayoutTestController class, which is going to be used by + DumpRenderTree Chromium port. These files are based on: + - src/webkit/tools/test_shell/layout_test_controller.cc + - src/webkit/tools/test_shell/layout_test_controller.h + of Chromium rev.40492. + + * DumpRenderTree/chromium/LayoutTestController.cpp: Added. + * DumpRenderTree/chromium/LayoutTestController.h: Added. + +2010-03-25 Charlie Reis <creis@chromium.org> + + Reviewed by Adam Barth. + + onbeforeunload not called at window close + frame or iframe focused + https://bugs.webkit.org/show_bug.cgi?id=27481 + + Adds a callShouldCloseOnWebView method to LayoutTestController, + to allow automated testing for bug 27481. + + * DumpRenderTree/LayoutTestController.cpp: + (callShouldCloseOnWebViewCallback): + (LayoutTestController::staticFunctions): + * DumpRenderTree/LayoutTestController.h: + * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: + (LayoutTestController::callShouldCloseOnWebView): + * DumpRenderTree/mac/LayoutTestControllerMac.mm: + (LayoutTestController::callShouldCloseOnWebView): + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::callShouldCloseOnWebView): + * DumpRenderTree/qt/LayoutTestControllerQt.h: + * DumpRenderTree/win/LayoutTestControllerWin.cpp: + (LayoutTestController::callShouldCloseOnWebView): + +2010-03-25 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + Add webkit-patch lkgr for finding last known good revision + https://bugs.webkit.org/show_bug.cgi?id=36626 + + This is rather slow for now because the command + has to compute this information from the buildbot. + A better long-term solution would be to have a server + somewhere store a pre-computed LKGR and then any + script (like webkit-patch) could just fetch it. + + * Scripts/webkitpy/common/net/buildbot.py: + * Scripts/webkitpy/tool/commands/queries.py: + +2010-03-25 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Move modified_changelogs (and friends) from scm to checkout + https://bugs.webkit.org/show_bug.cgi?id=36636 + + These functions know about ChangeLogs, which is forbidden knowledge in + scm.py. + + * Scripts/webkitpy/common/checkout/api.py: + * Scripts/webkitpy/common/checkout/changelog.py: + * Scripts/webkitpy/common/checkout/scm.py: + * Scripts/webkitpy/tool/mocktool.py: + * Scripts/webkitpy/tool/steps/abstractstep.py: + * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py: + * Scripts/webkitpy/tool/steps/revertrevision.py: + * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: + * Scripts/webkitpy/tool/steps/validatereviewer.py: + +2010-03-25 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Move apply_patch from scm to checkout + https://bugs.webkit.org/show_bug.cgi?id=36635 + + SCM shouldn't have any knowledge of WebKit scripts. + + * Scripts/webkitpy/common/checkout/api.py: + * Scripts/webkitpy/common/checkout/scm.py: + * Scripts/webkitpy/common/checkout/scm_unittest.py: + * Scripts/webkitpy/tool/mocktool.py: + * Scripts/webkitpy/tool/steps/applypatch.py: + +2010-03-25 Eric Seidel <eric@webkit.org> + + Unreviewed build fix to un-break webkit-patch land. + Test-case coming in follow-up commit. + + Move commit_message_for_this_commit from scm to checkout + https://bugs.webkit.org/show_bug.cgi?id=36629 + + * Scripts/webkitpy/common/checkout/api.py: import scm.CommitMessage + +2010-03-25 Dan Bernstein <mitz@apple.com> + + Reviewed by Darin Adler. + + <rdar://problem/7728903> Support color bitmap fonts + + * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added ColorBits.ttf + and ColorBits-A.png. + * DumpRenderTree/fonts/ColorBits-A.png: Copied from WebCore/inspector/front-end/Images/successGreenDot.png. + * DumpRenderTree/fonts/ColorBits.ttf: Added. + * DumpRenderTree/mac/DumpRenderTree.mm: + (activateFonts): Activate ColorBits.ttf. + +2010-03-25 Mark Rowe <mrowe@apple.com> + + Remove a printf that was causing commit-log-editor to spew the name of the editor + to the terminal many times during a commit. + + * Scripts/commit-log-editor: + +2010-03-25 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Move commit_message_for_this_commit from scm to checkout + https://bugs.webkit.org/show_bug.cgi?id=36629 + + This function requires knowledge of ChangeLogs, but scm shouldn't know + about ChangeLogs. + + * Scripts/webkitpy/common/checkout/api.py: + * Scripts/webkitpy/common/checkout/scm.py: + * Scripts/webkitpy/tool/commands/upload.py: + * Scripts/webkitpy/tool/commands/upload_unittest.py: + * Scripts/webkitpy/tool/mocktool.py: + * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py: + * Scripts/webkitpy/tool/steps/commit.py: + +2010-03-25 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + REGRESSION: webkit-patch land can't land "rubber-stamped" patches + https://bugs.webkit.org/show_bug.cgi?id=36582 + + Allow a "-" in rubber stamped. + + * Scripts/webkitpy/tool/steps/validatereviewer.py: + +2010-03-25 Adam Barth <abarth@webkit.org> + + Unreviewed. Fix some copyright lines to remove extraneous comma and + python directive. + + * Scripts/webkitpy/tool/bot/patchcollection.py: + * Scripts/webkitpy/tool/bot/patchcollection_unittest.py: + * Scripts/webkitpy/tool/bot/queueengine.py: + * Scripts/webkitpy/tool/bot/queueengine_unittest.py: + * Scripts/webkitpy/tool/commands/download.py: + * Scripts/webkitpy/tool/commands/earlywarningsystem.py: + * Scripts/webkitpy/tool/commands/queries.py: + * Scripts/webkitpy/tool/commands/queues.py: + * Scripts/webkitpy/tool/commands/sheriffbot.py: + * Scripts/webkitpy/tool/comments.py: + * Scripts/webkitpy/tool/grammar.py: + * Scripts/webkitpy/tool/multicommandtool.py: + * Scripts/webkitpy/tool/multicommandtool_unittest.py: + +2010-03-25 Simon Fraser <simon.fraser@apple.com> + + Reviewed by Darin Adler, Alexey Proskuryakov. + + https://bugs.webkit.org/show_bug.cgi?id=36631 + Allow the test plugin to run scripts in response to NPP_SetWindow calls + + Hook up the ability for the TestNetscapePlugIn to run JavaScript in + response to NPP_SetWindow. + + * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: + (pluginAllocate): + * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: + * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: + (NPP_New): + (NPP_Destroy): + (NPP_SetWindow): + +2010-03-25 Laszlo Gombos <laszlo.1.gombos@nokia.com> + + Unreviewed, build fix. + + [Qt] Fix QtLauncher guards. + + * QtLauncher/main.cpp: + (LauncherWindow::showFPS): + (LauncherWindow::updateFPS): + +2010-03-25 Yury Semikhatsky <yurys@chromium.org> + + Reviewed by Pavel Feldman. + + Allow running tests with enabled developer extras and closed Web Inspector. Tests that have inspector-enabled/ in their path/url will have developer extras enabled. + + https://bugs.webkit.org/show_bug.cgi?id=36610 + + * DumpRenderTree/LayoutTestController.h: + * DumpRenderTree/gtk/DumpRenderTree.cpp: + (shouldEnableDeveloperExtras): + (runTest): + * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: + (LayoutTestController::setJavaScriptProfilingEnabled): + (LayoutTestController::setDeveloperExtrasEnabled): + (LayoutTestController::showWebInspector): + (LayoutTestController::closeWebInspector): + * DumpRenderTree/mac/DumpRenderTree.mm: + (shouldEnableDeveloperExtras): + (runTest): + * DumpRenderTree/mac/LayoutTestControllerMac.mm: + (LayoutTestController::setJavaScriptProfilingEnabled): + (LayoutTestController::setDeveloperExtrasEnabled): + (LayoutTestController::showWebInspector): + (LayoutTestController::closeWebInspector): + * DumpRenderTree/qt/DumpRenderTreeQt.cpp: + (WebCore::shouldEnableDeveloperExtras): + (WebCore::DumpRenderTree::open): + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::closeWebInspector): + (LayoutTestController::setDeveloperExtrasEnabled): + (LayoutTestController::showWebInspector): + (LayoutTestController::setJavaScriptProfilingEnabled): + * DumpRenderTree/win/DumpRenderTree.cpp: + (shouldEnableDeveloperExtras): + (runTest): + * DumpRenderTree/win/LayoutTestControllerWin.cpp: + (LayoutTestController::setJavaScriptProfilingEnabled): + (LayoutTestController::setDeveloperExtrasEnabled): + (LayoutTestController::showWebInspector): + (LayoutTestController::closeWebInspector): + +2010-03-25 Adam Barth <abarth@webkit.org> + + Rubber stamped by Eric Seidel. + + Tweaks to sheriffbot to improve latency by keeping the working copy up + to date even when there's no build break. Also, officially move + sheriffbot to #webkit. + + (Also teach ValidateReviewer to understand rubber stamps.) + + * Scripts/webkitpy/common/net/irc/ircbot.py: + * Scripts/webkitpy/tool/commands/sheriffbot.py: + * Scripts/webkitpy/tool/steps/validatereviewer.py: + +2010-03-22 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> + + Reviewed by Simon Hausmann. + + Not displaying FPS info on the terminal. On S60 and Maemo the + Window title will be used and Status bar will used on desktop. + + [Qt] QtLauncher's FPS info should not be displayed on the terminal + https://bugs.webkit.org/show_bug.cgi?id=36244 + + * QtLauncher/main.cpp: + (LauncherWindow::initializeView): + (LauncherWindow::showFPS): + (LauncherWindow::updateFPS): + * QtLauncher/webview.cpp: + (WebViewGraphicsBased::setFrameRateMeasurementEnabled): + (WebViewGraphicsBased::updateFrameRate): + * QtLauncher/webview.h: + (WebViewGraphicsBased::frameRateMeasurementEnabled): + +2010-03-25 Diego Gonzalez <diego.gonzalez@openbossa.org> + + Reviewed by Kenneth Christiansen. + + Added missing frame flattening activation on + fast/frames/flattening/frameset-flattening-grid.html; + removed unnecessary CONSOLE MESSAGE from the expected file; + reset the setFrameSetFlatteningEnabled for each test. + + * DumpRenderTree/qt/DumpRenderTreeQt.cpp: + (WebCore::WebPage::resetSettings): + +2010-03-25 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Adam Barth. + + Moved deprecated_logging unit test import statement from + webkitpy/unittests.py to webkitpy/common/system/unittests.py. + + https://bugs.webkit.org/show_bug.cgi?id=36093 + + This is part of the master bug to reorganize webkitpy. + + * Scripts/webkitpy/common/system/unittests.py: + * Scripts/webkitpy/unittests.py: + +2010-03-25 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Adam Barth. + + Moved webkit_logging.py to common/system/deprecated_logging.py + inside webkitpy. + + https://bugs.webkit.org/show_bug.cgi?id=36093 + + This is part of the master bug to reorganize webkitpy. + + * Scripts/validate-committer-lists: + * Scripts/webkitpy/common/checkout/changelog.py: + * Scripts/webkitpy/common/checkout/scm.py: + * Scripts/webkitpy/common/net/bugzilla.py: + * Scripts/webkitpy/common/net/buildbot.py: + * Scripts/webkitpy/common/net/credentials.py: + * Scripts/webkitpy/common/net/irc/ircproxy.py: + * Scripts/webkitpy/common/net/networktransaction.py: + * Scripts/webkitpy/common/net/statusserver.py: + * Scripts/webkitpy/common/system/deprecated_logging.py: Copied from WebKitTools/Scripts/webkitpy/webkit_logging.py. + * Scripts/webkitpy/common/system/deprecated_logging_unittest.py: Copied from WebKitTools/Scripts/webkitpy/webkit_logging_unittest.py. + * Scripts/webkitpy/common/system/executive.py: + * Scripts/webkitpy/tool/bot/queueengine.py: + * Scripts/webkitpy/tool/commands/download.py: + * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: + * Scripts/webkitpy/tool/commands/openbugs.py: + * Scripts/webkitpy/tool/commands/queries.py: + * Scripts/webkitpy/tool/commands/queues.py: + * Scripts/webkitpy/tool/commands/sheriffbot.py: + * Scripts/webkitpy/tool/commands/stepsequence.py: + * Scripts/webkitpy/tool/commands/upload.py: + * Scripts/webkitpy/tool/main.py: + * Scripts/webkitpy/tool/mocktool.py: + * Scripts/webkitpy/tool/multicommandtool.py: + * Scripts/webkitpy/tool/steps/abstractstep.py: + * Scripts/webkitpy/tool/steps/applypatch.py: + * Scripts/webkitpy/tool/steps/build.py: + * Scripts/webkitpy/tool/steps/checkstyle.py: + * Scripts/webkitpy/tool/steps/closebug.py: + * Scripts/webkitpy/tool/steps/closebugforlanddiff.py: + * Scripts/webkitpy/tool/steps/confirmdiff.py: + * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py: + * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py: + * Scripts/webkitpy/tool/steps/obsoletepatches.py: + * Scripts/webkitpy/tool/steps/preparechangelog.py: + * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py: + * Scripts/webkitpy/tool/steps/runtests.py: + * Scripts/webkitpy/tool/steps/update.py: + * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: + * Scripts/webkitpy/tool/steps/validatereviewer.py: + * Scripts/webkitpy/unittests.py: + * Scripts/webkitpy/webkit_logging.py: Removed. + * Scripts/webkitpy/webkit_logging_unittest.py: Removed. + +2010-03-25 Julien Chaffraix <jchaffraix@webkit.org> + + Reviewed by Kenneth Rohde Christiansen. + + commit-log-editor can call itself in an infinite loop + https://bugs.webkit.org/show_bug.cgi?id=35291 + + if $editor ends up being commit-log-editor, the script will exec itself + in an infinite loop. + + To avoid this, we now check that the $editor variable is not + commit-log-editor to avoid this case. + + * Scripts/commit-log-editor: Added an isCommitLogEditor method and + reworked the $editor setting to add this check. + +2010-03-25 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> + + Reviewed by Kenneth Rohde Christiansen. + + Add a Toggle Frame Flattening option to QtLauncher. + It will be enabled by default on Maemo5 and S60 platforms. + + [Qt] Add enable/disable Frame Flattening option to QtLauncher + https://bugs.webkit.org/show_bug.cgi?id=36558 + + * QtLauncher/main.cpp: + (LauncherWindow::applyPrefs): + (LauncherWindow::toggleFrameFlattening): + (LauncherWindow::createChrome): + +2010-03-25 Zoltan Horvath <zoltan@webkit.org> + + Reviewed by Eric Seidel. + + svn-create-patch prints a warning for large patches + https://bugs.webkit.org/show_bug.cgi?id=32582 + + svn-create-patch prints a warning message for larger patches than 20k. + + * Scripts/svn-create-patch: + +2010-03-25 Adam Barth <abarth@webkit.org> + + Unreviewed. Renamed early_warning_system.py to earlywarningsystem.py. + https://bugs.webkit.org/show_bug.cgi?id=36093 + + * Scripts/webkitpy/tool/commands/early_warning_system.py: Removed. + * Scripts/webkitpy/tool/commands/early_warning_system_unittest.py: Removed. + * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Copied from Scripts/webkitpy/tool/commands/early_warning_system.py. + * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Copied from Scripts/webkitpy/tool/commands/early_warning_system_unittest.py. + * Scripts/webkitpy/tool/main.py: + * Scripts/webkitpy/tool/unittests.py: + +2010-03-25 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Adam Barth. + + In webkitpy, pushed the unit test import statements in + webkitpy/unittests.py into appropriate unittests.py files in the + new root-level packages beneath webkitpy. + + https://bugs.webkit.org/show_bug.cgi?id=36093 + + This is part of the master bug to reorganize webkitpy. + + * Scripts/webkitpy/common/system/unittests.py: + * Scripts/webkitpy/common/unittests.py: Added. + * Scripts/webkitpy/python24/unittests.py: Added. + * Scripts/webkitpy/tool/unittests.py: Added. + * Scripts/webkitpy/unittests.py: + +2010-03-25 Adam Barth <abarth@webkit.org> + + Unreviewed. Move WebKitCheckout into the webkitpy.common.checkout + package. + https://bugs.webkit.org/show_bug.cgi?id=36093 + + * Scripts/webkitpy/common/checkout/api.py: Copied from Scripts/webkitpy/webkitcheckout.py. + * Scripts/webkitpy/tool/main.py: + * Scripts/webkitpy/tool/mocktool.py: + * Scripts/webkitpy/webkitcheckout.py: Removed. + +2010-03-25 Adam Barth <abarth@webkit.org> + + Unreviewed. Move OutputCapture to webkitpy.common.system. + https://bugs.webkit.org/show_bug.cgi?id=36093 + + * Scripts/webkitpy/common/net/bugzilla_unittest.py: + * Scripts/webkitpy/common/net/credentials_unittest.py: + * Scripts/webkitpy/common/system/outputcapture.py: Copied from Scripts/webkitpy/outputcapture.py. + * Scripts/webkitpy/outputcapture.py: Removed. + * Scripts/webkitpy/tool/commands/commandtest.py: + * Scripts/webkitpy/tool/commands/queues_unittest.py: + * Scripts/webkitpy/tool/commands/queuestest.py: + * Scripts/webkitpy/tool/multicommandtool_unittest.py: + * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py: + * Scripts/webkitpy/tool/steps/steps_unittest.py: + * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py: + +2010-03-25 Adam Barth <abarth@webkit.org> + + Unreviewed. Move user.py to webkitpy.common.system. + + * Scripts/webkitpy/common/checkout/scm.py: + * Scripts/webkitpy/common/net/bugzilla.py: + * Scripts/webkitpy/common/net/credentials.py: + * Scripts/webkitpy/common/system/user.py: Copied from Scripts/webkitpy/user.py. + * Scripts/webkitpy/common/system/user_unittest.py: Copied from Scripts/webkitpy/user_unittest.py. + * Scripts/webkitpy/tool/commands/upload.py: + * Scripts/webkitpy/tool/main.py: + * Scripts/webkitpy/unittests.py: + * Scripts/webkitpy/user.py: Removed. + * Scripts/webkitpy/user_unittest.py: Removed. + +2010-03-25 Adam Barth <abarth@webkit.org> + + Unreviewed. Move executive.py to webkitpy.common.system. + https://bugs.webkit.org/show_bug.cgi?id=36093 + + * Scripts/webkitpy/common/checkout/scm.py: + * Scripts/webkitpy/common/checkout/scm_unittest.py: + * Scripts/webkitpy/common/config/ports.py: + * Scripts/webkitpy/common/config/ports_unittest.py: + * Scripts/webkitpy/common/net/credentials.py: + * Scripts/webkitpy/common/net/credentials_unittest.py: + * Scripts/webkitpy/common/system/executive.py: Copied from Scripts/webkitpy/executive.py. + * Scripts/webkitpy/common/system/executive_unittest.py: Copied from Scripts/webkitpy/executive_unittest.py. + * Scripts/webkitpy/executive.py: Removed. + * Scripts/webkitpy/executive_unittest.py: Removed. + * Scripts/webkitpy/layout_tests/port/mac.py: + * Scripts/webkitpy/tool/bot/queueengine.py: + * Scripts/webkitpy/tool/bot/queueengine_unittest.py: + * Scripts/webkitpy/tool/commands/download.py: + * Scripts/webkitpy/tool/commands/early_warning_system.py: + * Scripts/webkitpy/tool/commands/queues.py: + * Scripts/webkitpy/tool/commands/stepsequence.py: + * Scripts/webkitpy/tool/main.py: + * Scripts/webkitpy/tool/steps/checkstyle.py: + * Scripts/webkitpy/tool/steps/preparechangelog.py: + * Scripts/webkitpy/unittests.py: + * Scripts/webkitpy/webkit_logging_unittest.py: + +2010-03-25 Adam Barth <abarth@webkit.org> + + Unreviewed. Move grammary.py into webkitpy.tool. + https://bugs.webkit.org/show_bug.cgi?id=36093 + + * Scripts/webkitpy/grammar.py: Removed. + * Scripts/webkitpy/grammar_unittest.py: Removed. + * Scripts/webkitpy/tool/commands/download.py: + * Scripts/webkitpy/tool/commands/queries.py: + * Scripts/webkitpy/tool/commands/queues.py: + * Scripts/webkitpy/tool/commands/upload.py: + * Scripts/webkitpy/tool/grammar.py: Copied from Scripts/webkitpy/grammar.py. + * Scripts/webkitpy/tool/grammar_unittest.py: Copied from Scripts/webkitpy/grammar_unittest.py. + * Scripts/webkitpy/tool/multicommandtool.py: + * Scripts/webkitpy/tool/steps/obsoletepatches.py: + * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: + * Scripts/webkitpy/unittests.py: + +2010-03-25 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Adam Barth. + + In webkitpy, moved init/ to common/system/. + + https://bugs.webkit.org/show_bug.cgi?id=36093 + + This is part of the master bug to reorganize webkitpy. + + * Scripts/webkitpy/common/system: Copied from WebKitTools/Scripts/webkitpy/init. + * Scripts/webkitpy/common/system/logutils.py: + * Scripts/webkitpy/common/system/logutils_unittest.py: + * Scripts/webkitpy/init: Removed. + * Scripts/webkitpy/init/__init__.py: Removed. + * Scripts/webkitpy/init/logtesting.py: Removed. + * Scripts/webkitpy/init/logutils.py: Removed. + * Scripts/webkitpy/init/logutils_unittest.py: Removed. + * Scripts/webkitpy/init/unittests.py: Removed. + * Scripts/webkitpy/python24/versioning_unittest.py: + * Scripts/webkitpy/style_references.py: + * Scripts/webkitpy/unittests.py: + +2010-03-25 Adam Barth <abarth@webkit.org> + + Unreviewed. Move stepsequence to webkitpy.tool.commands. + https://bugs.webkit.org/show_bug.cgi?id=36093 + + * Scripts/webkitpy/stepsequence.py: Removed. + * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py: + * Scripts/webkitpy/tool/commands/download.py: + * Scripts/webkitpy/tool/commands/queues.py: + * Scripts/webkitpy/tool/commands/stepsequence.py: Copied from Scripts/webkitpy/stepsequence.py. + +2010-03-25 Adam Barth <abarth@webkit.org> + + Unreviewed. Create webkitpy.common.checkout as described in + https://bugs.webkit.org/show_bug.cgi?id=36093 + + * Scripts/webkitpy/changelogs.py: Removed. + * Scripts/webkitpy/changelogs_unittest.py: Removed. + * Scripts/webkitpy/commitinfo.py: Removed. + * Scripts/webkitpy/commitinfo_unittest.py: Removed. + * Scripts/webkitpy/common/checkout: Added. + * Scripts/webkitpy/common/checkout/__init__.py: Copied from Scripts/webkitpy/common/__init__.py. + * Scripts/webkitpy/common/checkout/changelog.py: Copied from Scripts/webkitpy/changelogs.py. + * Scripts/webkitpy/common/checkout/changelog_unittest.py: Copied from Scripts/webkitpy/changelogs_unittest.py. + * Scripts/webkitpy/common/checkout/commitinfo.py: Copied from Scripts/webkitpy/commitinfo.py. + * Scripts/webkitpy/common/checkout/commitinfo_unittest.py: Copied from Scripts/webkitpy/commitinfo_unittest.py. + * Scripts/webkitpy/common/checkout/diff_parser.py: Copied from Scripts/webkitpy/diff_parser.py. + * Scripts/webkitpy/common/checkout/diff_parser_unittest.py: Copied from Scripts/webkitpy/diff_parser_unittest.py. + * Scripts/webkitpy/common/checkout/scm.py: Copied from Scripts/webkitpy/scm.py. + * Scripts/webkitpy/common/checkout/scm_unittest.py: Copied from Scripts/webkitpy/scm_unittest.py. + * Scripts/webkitpy/common/net/credentials.py: + * Scripts/webkitpy/diff_parser.py: Removed. + * Scripts/webkitpy/diff_parser_unittest.py: Removed. + * Scripts/webkitpy/layout_tests/port/base.py: + * Scripts/webkitpy/scm.py: Removed. + * Scripts/webkitpy/scm_unittest.py: Removed. + * Scripts/webkitpy/stepsequence.py: + * Scripts/webkitpy/style_references.py: + * Scripts/webkitpy/tool/commands/download.py: + * Scripts/webkitpy/tool/commands/queries.py: + * Scripts/webkitpy/tool/comments.py: + * Scripts/webkitpy/tool/main.py: + * Scripts/webkitpy/tool/mocktool.py: + * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py: + * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: + * Scripts/webkitpy/tool/steps/validatereviewer.py: + * Scripts/webkitpy/unittests.py: + * Scripts/webkitpy/webkitcheckout.py: + +2010-03-25 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Adam Barth. + + In webkitpy, moved init/versioning.py to python24/. + + https://bugs.webkit.org/show_bug.cgi?id=36093 + + This is part of the master bug to reorganize webkitpy. + + * Scripts/test-webkitpy: + * Scripts/webkit-patch: + * Scripts/webkitpy/init/unittests.py: + * Scripts/webkitpy/init/versioning.py: Removed. + * Scripts/webkitpy/init/versioning_unittest.py: Removed. + * Scripts/webkitpy/python24: Added. + * Scripts/webkitpy/python24/__init__.py: Copied from WebKitTools/Scripts/webkitpy/tool/__init__.py. + * Scripts/webkitpy/python24/versioning.py: Copied from WebKitTools/Scripts/webkitpy/init/versioning.py. + * Scripts/webkitpy/python24/versioning_unittest.py: Copied from WebKitTools/Scripts/webkitpy/init/versioning_unittest.py. + * Scripts/webkitpy/unittests.py: + +2010-03-25 Adam Barth <abarth@webkit.org> + + Unreviewed. + + Create webkitpy.common.net as described in + https://bugs.webkit.org/show_bug.cgi?id=36093 + + * Scripts/webkitpy/bugzilla.py: Removed. + * Scripts/webkitpy/bugzilla_unittest.py: Removed. + * Scripts/webkitpy/buildbot.py: Removed. + * Scripts/webkitpy/buildbot_unittest.py: Removed. + * Scripts/webkitpy/commitinfo.py: + * Scripts/webkitpy/common/net: Added. + * Scripts/webkitpy/common/net/__init__.py: Added. + * Scripts/webkitpy/common/net/bugzilla.py: Copied from Scripts/webkitpy/bugzilla.py. + * Scripts/webkitpy/common/net/bugzilla_unittest.py: Copied from Scripts/webkitpy/bugzilla_unittest.py. + * Scripts/webkitpy/common/net/buildbot.py: Copied from Scripts/webkitpy/buildbot.py. + * Scripts/webkitpy/common/net/buildbot_unittest.py: Copied from Scripts/webkitpy/buildbot_unittest.py. + * Scripts/webkitpy/common/net/credentials.py: Copied from Scripts/webkitpy/credentials.py. + * Scripts/webkitpy/common/net/credentials_unittest.py: Copied from Scripts/webkitpy/credentials_unittest.py. + * Scripts/webkitpy/common/net/irc: Copied from Scripts/webkitpy/irc. + * Scripts/webkitpy/common/net/irc/ircbot.py: + * Scripts/webkitpy/common/net/irc/ircproxy.py: + * Scripts/webkitpy/common/net/irc/messagepump_unittest.py: + * Scripts/webkitpy/common/net/irc/threadedmessagequeue_unittest.py: + * Scripts/webkitpy/common/net/irc/unittests.py: + * Scripts/webkitpy/common/net/networktransaction.py: Copied from Scripts/webkitpy/networktransaction.py. + * Scripts/webkitpy/common/net/networktransaction_unittest.py: Copied from Scripts/webkitpy/networktransaction_unittest.py. + * Scripts/webkitpy/common/net/statusserver.py: Copied from Scripts/webkitpy/statusserver.py. + * Scripts/webkitpy/credentials.py: Removed. + * Scripts/webkitpy/credentials_unittest.py: Removed. + * Scripts/webkitpy/irc: Removed. + * Scripts/webkitpy/irc/__init__.py: Removed. + * Scripts/webkitpy/irc/ircbot.py: Removed. + * Scripts/webkitpy/irc/ircproxy.py: Removed. + * Scripts/webkitpy/irc/messagepump.py: Removed. + * Scripts/webkitpy/irc/messagepump_unittest.py: Removed. + * Scripts/webkitpy/irc/threadedmessagequeue.py: Removed. + * Scripts/webkitpy/irc/threadedmessagequeue_unittest.py: Removed. + * Scripts/webkitpy/irc/unittests.py: Removed. + * Scripts/webkitpy/networktransaction.py: Removed. + * Scripts/webkitpy/networktransaction_unittest.py: Removed. + * Scripts/webkitpy/scm_unittest.py: + * Scripts/webkitpy/statusserver.py: Removed. + * Scripts/webkitpy/tool/bot/queueengine.py: + * Scripts/webkitpy/tool/commands/download.py: + * Scripts/webkitpy/tool/commands/queries.py: + * Scripts/webkitpy/tool/commands/queries_unittest.py: + * Scripts/webkitpy/tool/commands/queues.py: + * Scripts/webkitpy/tool/commands/queues_unittest.py: + * Scripts/webkitpy/tool/commands/queuestest.py: + * Scripts/webkitpy/tool/commands/upload.py: + * Scripts/webkitpy/tool/main.py: + * Scripts/webkitpy/tool/mocktool.py: + * Scripts/webkitpy/tool/steps/postdiffforrevert.py: + * Scripts/webkitpy/unittests.py: + +2010-03-25 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Adam Barth. + + In webkitpy, renamed MockBugzillaTool to MockTool. + + * Scripts/webkitpy/tool/commands/commandtest.py: + * Scripts/webkitpy/tool/commands/queries_unittest.py: + * Scripts/webkitpy/tool/commands/queues_unittest.py: + * Scripts/webkitpy/tool/commands/queuestest.py: + * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py: + * Scripts/webkitpy/tool/commands/upload_unittest.py: + * Scripts/webkitpy/tool/mocktool.py: + * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py: + * Scripts/webkitpy/tool/steps/steps_unittest.py: + * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py: + +2010-03-25 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Adam Barth. + + In Scripts/webkitpy, moved webkitport.py and committers.py into + common/config/ (also creating common/config/). + + https://bugs.webkit.org/show_bug.cgi?id=36093 + + This is part of the master bug to reorganize webkitpy. + + * Scripts/validate-committer-lists: + * Scripts/webkitpy/bugzilla.py: + * Scripts/webkitpy/bugzilla_unittest.py: + * Scripts/webkitpy/changelogs.py: + * Scripts/webkitpy/commitinfo.py: + * Scripts/webkitpy/commitinfo_unittest.py: + * Scripts/webkitpy/committers.py: Removed. + * Scripts/webkitpy/committers_unittest.py: Removed. + * Scripts/webkitpy/common: Added. + * Scripts/webkitpy/common/__init__.py: Copied from WebKitTools/Scripts/webkitpy/style/__init__.py. + * Scripts/webkitpy/common/config: Added. + * Scripts/webkitpy/common/config/__init__.py: Copied from WebKitTools/Scripts/webkitpy/style/__init__.py. + * Scripts/webkitpy/common/config/committers.py: Copied from WebKitTools/Scripts/webkitpy/committers.py. + * Scripts/webkitpy/common/config/committers_unittest.py: Copied from WebKitTools/Scripts/webkitpy/committers_unittest.py. + * Scripts/webkitpy/common/config/ports.py: Copied from WebKitTools/Scripts/webkitpy/webkitport.py. + * Scripts/webkitpy/common/config/ports_unittest.py: Copied from WebKitTools/Scripts/webkitpy/webkitport_unittest.py. + * Scripts/webkitpy/mock_bugzillatool.py: + * Scripts/webkitpy/tool/commands/early_warning_system.py: + * Scripts/webkitpy/tool/commands/queries.py: + * Scripts/webkitpy/tool/commands/sheriffbot.py: + * Scripts/webkitpy/tool/commands/upload.py: + * Scripts/webkitpy/tool/steps/abstractstep.py: + * Scripts/webkitpy/unittests.py: + * Scripts/webkitpy/webkitport.py: Removed. + * Scripts/webkitpy/webkitport_unittest.py: Removed. + +2010-03-25 Adam Barth <abarth@webkit.org> + + Unreviewed. Move mock_bugzillatool.py to tool/mocktool.py. + + * Scripts/webkitpy/mock_bugzillatool.py: Removed. + * Scripts/webkitpy/tool/commands/commandtest.py: + * Scripts/webkitpy/tool/commands/queries_unittest.py: + * Scripts/webkitpy/tool/commands/queues_unittest.py: + * Scripts/webkitpy/tool/commands/queuestest.py: + * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py: + * Scripts/webkitpy/tool/commands/upload_unittest.py: + * Scripts/webkitpy/tool/mocktool.py: Copied from Scripts/webkitpy/mock_bugzillatool.py. + * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py: + * Scripts/webkitpy/tool/steps/steps_unittest.py: + * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py: + +2010-03-24 Adam Barth <abarth@webkit.org> + + Unreviewed. Move comments.py and multicommandtool.py to their new + home. + + * Scripts/webkitpy/comments.py: Removed. + * Scripts/webkitpy/multicommandtool.py: Removed. + * Scripts/webkitpy/multicommandtool_unittest.py: Removed. + * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py: + * Scripts/webkitpy/tool/commands/download.py: + * Scripts/webkitpy/tool/commands/openbugs.py: + * Scripts/webkitpy/tool/commands/queries.py: + * Scripts/webkitpy/tool/commands/queues.py: + * Scripts/webkitpy/tool/commands/upload.py: + * Scripts/webkitpy/tool/comments.py: Copied from Scripts/webkitpy/comments.py. + * Scripts/webkitpy/tool/main.py: + * Scripts/webkitpy/tool/multicommandtool.py: Copied from Scripts/webkitpy/multicommandtool.py. + * Scripts/webkitpy/tool/multicommandtool_unittest.py: Copied from Scripts/webkitpy/multicommandtool_unittest.py. + * Scripts/webkitpy/tool/steps/closebugforlanddiff.py: + * Scripts/webkitpy/tool/steps/closepatch.py: + * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py: + * Scripts/webkitpy/unittests.py: + +2010-03-24 Adam Barth <abarth@webkit.org> + + Unreviewed. Fixup one import statement I didn't find because the .pyc + masked the error. + + * Scripts/webkitpy/stepsequence.py: + +2010-03-24 Adam Barth <abarth@webkit.org> + + Unreviewed. Move queueengine.py to its new home. + + * Scripts/webkitpy/queueengine.py: Removed. + * Scripts/webkitpy/queueengine_unittest.py: Removed. + * Scripts/webkitpy/tool/bot/queueengine.py: Copied from Scripts/webkitpy/queueengine.py. + * Scripts/webkitpy/tool/bot/queueengine_unittest.py: Copied from Scripts/webkitpy/queueengine_unittest.py. + * Scripts/webkitpy/tool/commands/early_warning_system.py: + * Scripts/webkitpy/tool/commands/queues.py: + * Scripts/webkitpy/unittests.py: + +2010-03-24 Adam Barth <abarth@webkit.org> + + Unreviewed. Move patchcollection.py to its new home. + + * Scripts/webkitpy/patchcollection.py: Removed. + * Scripts/webkitpy/patchcollection_unittest.py: Removed. + * Scripts/webkitpy/tool/bot: Added. + * Scripts/webkitpy/tool/bot/__init__.py: Added. + * Scripts/webkitpy/tool/bot/patchcollection.py: Copied from WebKitTools/Scripts/webkitpy/patchcollection.py. + * Scripts/webkitpy/tool/bot/patchcollection_unittest.py: Copied from WebKitTools/Scripts/webkitpy/patchcollection_unittest.py. + * Scripts/webkitpy/tool/commands/queues.py: + * Scripts/webkitpy/unittests.py: + +2010-03-24 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Adam Barth. + + In Scripts/webkitpy, moved steps_references.py and the steps + folder into webkitpy/patch. + + https://bugs.webkit.org/show_bug.cgi?id=36093 + + * Scripts/webkitpy/steps: Removed. + * Scripts/webkitpy/steps/__init__.py: Removed. + * Scripts/webkitpy/steps/abstractstep.py: Removed. + * Scripts/webkitpy/steps/applypatch.py: Removed. + * Scripts/webkitpy/steps/applypatchwithlocalcommit.py: Removed. + * Scripts/webkitpy/steps/build.py: Removed. + * Scripts/webkitpy/steps/checkstyle.py: Removed. + * Scripts/webkitpy/steps/cleanworkingdirectory.py: Removed. + * Scripts/webkitpy/steps/cleanworkingdirectorywithlocalcommits.py: Removed. + * Scripts/webkitpy/steps/closebug.py: Removed. + * Scripts/webkitpy/steps/closebugforlanddiff.py: Removed. + * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py: Removed. + * Scripts/webkitpy/steps/closepatch.py: Removed. + * Scripts/webkitpy/steps/commit.py: Removed. + * Scripts/webkitpy/steps/confirmdiff.py: Removed. + * Scripts/webkitpy/steps/createbug.py: Removed. + * Scripts/webkitpy/steps/editchangelog.py: Removed. + * Scripts/webkitpy/steps/ensurebuildersaregreen.py: Removed. + * Scripts/webkitpy/steps/ensurelocalcommitifneeded.py: Removed. + * Scripts/webkitpy/steps/metastep.py: Removed. + * Scripts/webkitpy/steps/obsoletepatches.py: Removed. + * Scripts/webkitpy/steps/options.py: Removed. + * Scripts/webkitpy/steps/postdiff.py: Removed. + * Scripts/webkitpy/steps/postdiffforcommit.py: Removed. + * Scripts/webkitpy/steps/postdiffforrevert.py: Removed. + * Scripts/webkitpy/steps/preparechangelog.py: Removed. + * Scripts/webkitpy/steps/preparechangelogforrevert.py: Removed. + * Scripts/webkitpy/steps/promptforbugortitle.py: Removed. + * Scripts/webkitpy/steps/reopenbugafterrollout.py: Removed. + * Scripts/webkitpy/steps/revertrevision.py: Removed. + * Scripts/webkitpy/steps/runtests.py: Removed. + * Scripts/webkitpy/steps/steps_unittest.py: Removed. + * Scripts/webkitpy/steps/update.py: Removed. + * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py: Removed. + * Scripts/webkitpy/steps/updatechangelogswithreviewer.py: Removed. + * Scripts/webkitpy/steps/validatereviewer.py: Removed. + * Scripts/webkitpy/steps_references.py: Removed. + * Scripts/webkitpy/stepsequence.py: + * Scripts/webkitpy/tool/commands/download.py: + * Scripts/webkitpy/tool/commands/upload.py: + * Scripts/webkitpy/tool/steps: Copied from WebKitTools/Scripts/webkitpy/steps. + * Scripts/webkitpy/tool/steps/__init__.py: + * Scripts/webkitpy/tool/steps/applypatch.py: + * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py: + * Scripts/webkitpy/tool/steps/build.py: + * Scripts/webkitpy/tool/steps/checkstyle.py: + * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py: + * Scripts/webkitpy/tool/steps/cleanworkingdirectorywithlocalcommits.py: + * Scripts/webkitpy/tool/steps/closebug.py: + * Scripts/webkitpy/tool/steps/closebugforlanddiff.py: + * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py: + * Scripts/webkitpy/tool/steps/closepatch.py: + * Scripts/webkitpy/tool/steps/commit.py: + * Scripts/webkitpy/tool/steps/confirmdiff.py: + * Scripts/webkitpy/tool/steps/createbug.py: + * Scripts/webkitpy/tool/steps/editchangelog.py: + * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py: + * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py: + * Scripts/webkitpy/tool/steps/metastep.py: + * Scripts/webkitpy/tool/steps/obsoletepatches.py: + * Scripts/webkitpy/tool/steps/postdiff.py: + * Scripts/webkitpy/tool/steps/postdiffforcommit.py: + * Scripts/webkitpy/tool/steps/postdiffforrevert.py: + * Scripts/webkitpy/tool/steps/preparechangelog.py: + * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py: + * Scripts/webkitpy/tool/steps/promptforbugortitle.py: + * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py: + * Scripts/webkitpy/tool/steps/revertrevision.py: + * Scripts/webkitpy/tool/steps/runtests.py: + * Scripts/webkitpy/tool/steps/steps_unittest.py: + * Scripts/webkitpy/tool/steps/update.py: + * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py: + * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: + * Scripts/webkitpy/tool/steps/validatereviewer.py: + * Scripts/webkitpy/tool/steps_references.py: Copied from WebKitTools/Scripts/webkitpy/steps_references.py. + * Scripts/webkitpy/unittests.py: + +2010-03-24 Eric Seidel <eric@webkit.org> + + Unreviewed, build fix only. + + Abstract LayoutTestResults logic for easier reuse + https://bugs.webkit.org/show_bug.cgi?id=36579 + + * Scripts/webkitpy/buildbot_unittest.py: Add a missing import. + +2010-03-24 Adam Barth <abarth@webkit.org> + + Unreviewed. Fix a stray comma to test landing an patch without review. + + * Scripts/webkitpy/commitinfo.py: + +2010-03-24 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Adam Barth. + + In Scripts/webkitpy, moved commands_references.py and the commands + folder into webkitpy/patch. + + https://bugs.webkit.org/show_bug.cgi?id=36483 + + This is part of master bug 36093 to organize webkitpy. + + * Scripts/webkitpy/commands: Removed. + * Scripts/webkitpy/commands/__init__.py: Removed. + * Scripts/webkitpy/commands/abstractsequencedcommand.py: Removed. + * Scripts/webkitpy/commands/commandtest.py: Removed. + * Scripts/webkitpy/commands/download.py: Removed. + * Scripts/webkitpy/commands/download_unittest.py: Removed. + * Scripts/webkitpy/commands/early_warning_system.py: Removed. + * Scripts/webkitpy/commands/early_warning_system_unittest.py: Removed. + * Scripts/webkitpy/commands/openbugs.py: Removed. + * Scripts/webkitpy/commands/openbugs_unittest.py: Removed. + * Scripts/webkitpy/commands/queries.py: Removed. + * Scripts/webkitpy/commands/queries_unittest.py: Removed. + * Scripts/webkitpy/commands/queues.py: Removed. + * Scripts/webkitpy/commands/queues_unittest.py: Removed. + * Scripts/webkitpy/commands/queuestest.py: Removed. + * Scripts/webkitpy/commands/sheriffbot.py: Removed. + * Scripts/webkitpy/commands/sheriffbot_unittest.py: Removed. + * Scripts/webkitpy/commands/upload.py: Removed. + * Scripts/webkitpy/commands/upload_unittest.py: Removed. + * Scripts/webkitpy/commands_references.py: Removed. + * Scripts/webkitpy/tool/commands: Copied from WebKitTools/Scripts/webkitpy/commands. + * Scripts/webkitpy/tool/commands/commandtest.py: + * Scripts/webkitpy/tool/commands/download.py: + * Scripts/webkitpy/tool/commands/download_unittest.py: + * Scripts/webkitpy/tool/commands/early_warning_system.py: + * Scripts/webkitpy/tool/commands/early_warning_system_unittest.py: + * Scripts/webkitpy/tool/commands/openbugs_unittest.py: + * Scripts/webkitpy/tool/commands/queries_unittest.py: + * Scripts/webkitpy/tool/commands/queues_unittest.py: + * Scripts/webkitpy/tool/commands/queuestest.py: + * Scripts/webkitpy/tool/commands/sheriffbot.py: + * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py: + * Scripts/webkitpy/tool/commands/upload.py: + * Scripts/webkitpy/tool/commands/upload_unittest.py: + * Scripts/webkitpy/tool/commands_references.py: Copied from WebKitTools/Scripts/webkitpy/commands_references.py. + * Scripts/webkitpy/tool/main.py: + * Scripts/webkitpy/unittests.py: + +2010-03-24 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Rename webkitpy.patch to webkitpy.tool + https://bugs.webkit.org/show_bug.cgi?id=36580 + + This is in preparation for the great webkitpy naming cleanup. + + * Scripts/webkit-patch: + * Scripts/webkitpy/patch: Removed. + * Scripts/webkitpy/patch/__init__.py: Removed. + * Scripts/webkitpy/patch/patcher.py: Removed. + * Scripts/webkitpy/tool: Copied from WebKitTools/Scripts/webkitpy/patch. + * Scripts/webkitpy/tool/main.py: Copied from WebKitTools/Scripts/webkitpy/patch/patcher.py. + * Scripts/webkitpy/tool/patcher.py: Removed. + +2010-03-24 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + Abstract LayoutTestResults logic for easier reuse + https://bugs.webkit.org/show_bug.cgi?id=36579 + + * Scripts/webkitpy/buildbot.py: + - Split out logic into new LayoutTestResults class. + * Scripts/webkitpy/buildbot_unittest.py: + - Rename the testing class to match. + * Scripts/webkitpy/commands/queries.py: + - Use the new LayoutTestResults class. + +2010-03-24 Eric Seidel <eric@webkit.org> + + Reviewed by Eric Seidel. + + Move Bugzilla.prompt_for_component to User.prompt_with_list for re-use + https://bugs.webkit.org/show_bug.cgi?id=36577 + + * Scripts/webkitpy/bugzilla.py: + - Move prompt_for_component to User + * Scripts/webkitpy/commands/queries.py: + - Add a missing argument_names declaration. + * Scripts/webkitpy/user.py: + - Add prompt_with_list + - Make staticmethods classmethods for easier mocking + +2010-03-24 David Kilzer <ddkilzer@apple.com> + + <http://webkit.org/b/36572> commit-log-editor: thinks mergeChangeLogs.pl is a ChangeLog file + + Reviewed by Eric Seidel. + + Fixes the following error when committing a file with + "ChangeLog" in the name that isn't a ChangeLog (like + mergeChangeLogs.pl from r56471 and r56472): + + $ git commit . + Can't open WebKitTools/Scripts/webkitperl/VCSUtils_unittest/mergeChangeLog at commit-log-editor line 132. + error: There was a problem with the editor 'commit-log-editor'. + Please supply the message using either -m or -F option. + + * Scripts/commit-log-editor: Added '$' to anchor "ChangeLog" to + the end of the file name when searching for ChangeLog files in a + commit. + +2010-03-24 David Kilzer <ddkilzer@apple.com> + + <http://webkit.org/b/36570> resolve-ChangeLogs: fall back to git-merge-file if ChangeLog can't be merged + + Reviewed by Eric Seidel. + + * Scripts/resolve-ChangeLogs: Switched to exec git-merge-file if + the merge attempt fails. + +2010-03-24 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + webkit-patch or pre-commit hook should validate reviewer lines before committing + https://bugs.webkit.org/show_bug.cgi?id=26927 + + Validate that patches have valid reivewers listed in their ChangeLogs + before landing. For patches without reviewers can be landed if their + ChangeLogs state that they are unreviewed. + + * Scripts/webkitpy/changelogs.py: + * Scripts/webkitpy/commands/download.py: + * Scripts/webkitpy/commitinfo.py: + * Scripts/webkitpy/commitinfo_unittest.py: + * Scripts/webkitpy/mock_bugzillatool.py: + * Scripts/webkitpy/steps/__init__.py: + * Scripts/webkitpy/steps/validatereviewer.py: Added. + +2010-03-19 Holger Hans Peter Freyther <zecke@selfish.org> + + Reviewed by David Levin. + + Undefined names reported by pyflakes in python scripts + https://bugs.webkit.org/show_bug.cgi?id=36403 + + Attempt to use names that exist or can exist in the lexical + scope instead of not being available at all. + + * Scripts/webkitpy/changelogs.py: Use self._content. + * Scripts/webkitpy/layout_tests/port/base.py: Use os.stat + * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Use self._port + * Scripts/webkitpy/style/processors/cpp_unittest.py: Use expected_message_re + +2010-03-24 David Kilzer <ddkilzer@apple.com> + + <http://webkit.org/b/36560> resolve-ChangeLogs: git-rebase fails when resolve-ChangeLogs can't merge + + Reviewed by Eric Seidel. + + When resolve-ChangeLogs fails to merge a patch while running as + a git merge driver, it deletes the original file, which causes + an internal failure and stops git mid-merge: + + fatal: Failed to execute internal merge + + The fix is to use the --force switch with patch so that it will + always attempt to apply the patch. (The change in + mergeChangeLogs() for the previous commit also fixed this, but + adding --force also prevents any potential user interaction that + patch may want to display.) + + * Scripts/VCSUtils.pm: + (mergeChangeLogs): Added --force switch to patch command. Also + changed to use the exit status from the patch command to + determine the return value for this method. + * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl: Added + test to cover this bug. + +2010-03-24 David Kilzer <ddkilzer@apple.com> + + <http://webkit.org/b/36560> resolve-ChangeLogs: move mergeChanges() into VCSUtils package + + Reviewed by Eric Seidel. + + * Scripts/VCSUtils.pm: + (mergeChangeLogs): Copied from mergeChanges() in + resolve-ChangeLogs and renamed. Added method documentation. + Fixed bug found by new tests where the original file to be + patched was deleted when cleaning up after a traditinal rejected + patch failed to apply. + * Scripts/resolve-ChangeLogs: Switched to using + mergeChangeLogs(). + (mergeChanges): Moved to VCSUtils.pm and renamed to + mergeChangeLogs(). + * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl: Added. + +2010-03-24 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + Add support for qt's unassigned list to webkit-patch assign-to-committer + https://bugs.webkit.org/show_bug.cgi?id=36559 + + * Scripts/webkitpy/bugzilla.py: + - Move Bugzilla.unassigned_email into Bug and make it a set. + * Scripts/webkitpy/bugzilla_unittest.py: + - Test the new Bug.is_unassigned method + * Scripts/webkitpy/commands/upload.py: + - Use the new Bug.is_unassigned method instead of an explicit == + * Scripts/webkitpy/mock_bugzillatool.py: + - Bugzilla.unassigned_email no longer needs mocking + +2010-03-24 Kent Hansen <kent.hansen@nokia.com> + + Reviewed by Simon Hausmann. + + [Qt] Rename QWebSettings::XSSAuditorEnabled to XSSAuditingEnabled + https://bugs.webkit.org/show_bug.cgi?id=36522 + + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::setXSSAuditorEnabled): Use the new name. + +2010-03-24 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Shinichiro Hamaji. + + Added to check-webkit-style support for a --debug flag. + + https://bugs.webkit.org/show_bug.cgi?id=36100 + + The --debug flag adjusts the logging level to DEBUG and + includes the logger name and level in each log message. + + * Scripts/check-webkit-style: + - Changed the code to check for the --debug flag and pass + the result to the configure_logging() method. + * Scripts/webkitpy/style/checker.py: + - Added an is_debug parameter to configure_logging(). + - Refactored configure_logging() by adding calls to + the following two methods: _create_log_handlers() and + _create_debug_log_handlers(). + * Scripts/webkitpy/style/checker_unittest.py: + - Added unit tests for configure_logging() with is_debug True + by splitting the ConfigureLoggingTest class into + ConfigureLoggingTest and ConfigureLoggingTestBase, and + adding ConfigureLoggingDebugTest. + * Scripts/webkitpy/style/optparser.py: + - Updated the usage string. + - Added an is_debug data attribute to the CommandOptionValues + class. + - Added support for the --debug flag to the ArgumentParser.parse() + method. + - Also added extra error information to the parse() method in + the case of an invalid flag. + * Scripts/webkitpy/style/optparser_unittest.py: + - Updated the unit tests as necessary. + - Also fixed an issue with the CommandOptionValuesTest.test_eq() + unit test. + +2010-03-23 Kent Tamura <tkent@chromium.org> + + Reviewed by Dimitri Glazkov. + + [DRT/Chromium] Add TestNavigationController and TestWebWorker + https://bugs.webkit.org/show_bug.cgi?id=36489 + + Add TestNavigationController and TestWebWorker classes, which are + going to be used by DumpRenderTree Chromium port. These files are + based on: + - src/webkit/tools/test_shell/test_navigation_controller.{cc,h} + - src/webkit/tools/test_shell/test_web_worker.h + of Chromium rev.40492. + + TestNavigationController has non-style changes. + - Change ContentState type: binary string -> WebHistoryItem + - Remove TestShell dependency by introducing NavigationHost interface. + + * DumpRenderTree/chromium/TestNavigationController.cpp: Added. + * DumpRenderTree/chromium/TestNavigationController.h: Added. + * DumpRenderTree/chromium/TestWebWorker.h: Added. + +2010-03-23 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + Add support for revision -> build lookup in buildbot.py and layout test result parsing + https://bugs.webkit.org/show_bug.cgi?id=36474 + + * Scripts/webkitpy/bugzilla_unittest.py: Added a FIXME about sharing code. + * Scripts/webkitpy/buildbot.py: + - Add support for looking up builds by revision number. + - Add support for fetching and parsing results.html files from buildbot. + - build_for_revision has an allow_failed_lookups option to work around the fact that + our buildbot's xmlrpc calls return failure on old revision numbers. + - Add parsing support for twisted directory listings. + * Scripts/webkitpy/buildbot_unittest.py: + - Unit test all the new code. + * Scripts/webkitpy/commands/queries.py: + - Add a new results-for command which prints all the results for a given revision (very slow due to slow revision lookup) + +2010-03-23 Daniel Bates <dbates@rim.com> + + Reviewed by Adam Roben. + + https://bugs.webkit.org/show_bug.cgi?id=36048 + + Detect if the Windows Platform SDK is missing when building with + Visual C++ Express Edition and inform the user to download it. + + * Scripts/webkitdirs.pm: + +2010-03-23 Darin Adler <darin@apple.com> + + Tell Subversion about more directories that expect to have .pyc files. + + * Scripts/webkitpy: Modified property svn:ignore. + * Scripts/webkitpy/irc: Added property svn:ignore. + +2010-03-23 Daniel Bates <dbates@rim.com> + + Reviewed by Adam Barth. + + https://bugs.webkit.org/show_bug.cgi?id=36149 + + Import the GNU readline interface to modify the behavior + of raw_input so as to provide line editing support. In + particular this will prevent "delete" characters from + appearing in the returned value for function raw_input. + + * Scripts/webkitpy/user.py: + +2010-03-23 Laszlo Gombos <laszlo.1.gombos@nokia.com> + + Reviewed by Kenneth Rohde Christiansen. + + [Qt] Remove support for Qt v4.4 + https://bugs.webkit.org/show_bug.cgi?id=36389 + + * DumpRenderTree/qt/main.cpp: + (main): + * QtLauncher/mainwindow.cpp: + (MainWindow::MainWindow): + +2010-03-22 Csaba Osztrogonác <ossy@webkit.org> + + Reviewed by Adam Barth. + + Make build_webkit_command() pass MAKEFLAGS environment variable to make. + https://bugs.webkit.org/show_bug.cgi?id=36440 + + * Scripts/webkitpy/webkitport.py: + * Scripts/webkitpy/webkitport_unittest.py: + +2010-03-22 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Dimitri Glazkov. + + Change baseline_path() to point to the upstream locations for the + Chromium ports. Also change the reabselining scripts to use the + correct functions to get the baseline directories, and fix the + script's sys.path to pull in simplejson correctly. + + https://bugs.webkit.org/show_bug.cgi?id=36417 + + * Scripts/rebaseline-chromium-webkit-tests: + - fix sys.path to pick up simplejson properly + * Scripts/webkitpy/layout_tests/port/chromium.py: + - change baseline_path() to use webkit_baseline_path() + - error out correctly if we can't find the chromium base dir + * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: + - call baseline_path(), not chromium_baseline_path() + +2010-03-22 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Adam Barth. + + Refactored the cpu_count() code in executive.py. + + https://bugs.webkit.org/show_bug.cgi?id=36437 + + * Scripts/webkitpy/executive.py: + - Moved the import of the multiprocessing module to the top + of the file rather than importing from within a function. + +2010-03-22 Antonio Gomes <tonikitoo@webkit.org> + + Unreviewed. + + Rolling out r56183: http://trac.webkit.org/changeset/56183 + + https://bugs.webkit.org/show_bug.cgi?id=36244 + + Need to roll out because this patch will be re-worked by the author + and other reviewers agreed on it. + +2010-03-22 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Adam Barth. + + Created a function for getting a module-specific logging.logger + based on the __file__ value of the module. + + https://bugs.webkit.org/show_bug.cgi?id=35821 + + This function allows us to get the module-specific logger for + a module without having to hard-code the fully-qualified name + of the module in the module itself. The code can be the same + in every case: "_log = logutils.get_logger(__file__)". + + * Scripts/webkitpy/init/logutils.py: Added. + - Added a module with a get_logger() function to return + a module-specific logger based on the module's __file__ + variable. + + * Scripts/webkitpy/init/logutils_unittest.py: Added. + - Added unit tests for logutils.py. + + * Scripts/webkitpy/init/unittests.py: + - Added logutils_unittest to the list of imports. + +2010-03-22 Kenneth Rohde Christiansen <kenneth@webkit.org> + + Reviewed by Simon Hausmann. + + [Qt] REGRESSION (r56209): fast/media/print-restores-previous-mediatype.htm crashes + https://bugs.webkit.org/show_bug.cgi?id=36386 + + Fix the regression by implementing a null printer for Qt DRT. + + * DumpRenderTree/qt/DumpRenderTreeQt.cpp: + (WebCore::NullPrinter::NullPaintEngine::begin): + (WebCore::NullPrinter::NullPaintEngine::end): + (WebCore::NullPrinter::NullPaintEngine::type): + (WebCore::NullPrinter::NullPaintEngine::drawPixmap): + (WebCore::NullPrinter::NullPaintEngine::updateState): + (WebCore::NullPrinter::paintEngine): + (WebCore::DumpRenderTree::dryRunPrint): + +2010-03-20 Martin Robinson <mrobinson@webkit.org> + + Reviewed by Xan Lopez. + + [GTK] eventSender.zoomPageOut() bug? + https://bugs.webkit.org/show_bug.cgi?id=30575 + + Make zoomPage{In/Out}Callback respect the 1.2f zoom factor that DRT should be using. + + * DumpRenderTree/gtk/EventSender.cpp: + (zoomIn): Added. + (zoomOut): Added. + (textZoomInCallback): Use zoomIn helper function. + (textZoomOutCallback): Use zoomOut helper function. + (zoomPageInCallback): Use zoomIn helper function, which respects zoom factor. + (zoomPageOutCallback): Use zoomOut helper function, which respects zoom factor. + +2010-03-20 Kevin Ollivier <kevino@theolliviers.com> + + [wx] Build fix after recent database API change. + + * wx/browser/browser.cpp: + (MyApp::OnInit): + +2010-03-20 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Adam Barth. + + Renamed UnitTestLogStream to TestLogStream in webkitpy. + + https://bugs.webkit.org/show_bug.cgi?id=36099 + + TestLogStream is more concise and more consistent with the name of + the module (logtesting rather than logunittesting) and its main + class (LogTesting rather than LogUnitTesting). + + * Scripts/webkitpy/init/logtesting.py: + - Renamings. + + * Scripts/webkitpy/style/checker_unittest.py: + - Renamings. + + * Scripts/webkitpy/style_references.py: + - Renamings. + +2010-03-20 Kevin Ollivier <kevino@theolliviers.com> + + [wx] Build fixes for new method in LayoutTestController. + + * DumpRenderTree/wx/LayoutTestControllerWx.cpp: + (LayoutTestController::setSpatialNavigationEnabled): + * wx/build/settings.py: + +2010-03-20 Dimitri Glazkov <dglazkov@chromium.org> + + Unreviewed, tool fix. + + Remove vestiges of downstream directory names to unbreak rebaselining tool. + + * Scripts/webkitpy/layout_tests/port/chromium.py: Changed paths to use WebKit repo. + +2010-03-20 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Dimitri Glazkov. + + Re-enable the downstream test_expectations overrides file that was + disabled in bug 36396 / r56287. + + https://bugs.chromium.org/show_bug.cgi?id=36401 + + * Scripts/webkitpy/layout_tests/port/chromium.py: + +2010-03-19 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Dimitri Glazkov. + + Disable the downstream override expectations temporarily to allow + us to test that we've upstreamed everything correctly. Also, stop + looking at the downstream baselines at all (now you will only be + able to update baselines upstream). In theory this should work, but + if we need to we can always add the downstream dirs back in. + + https://bugs.webkit.org/show_bug.cgi?id=36396 + + * Scripts/webkitpy/layout_tests/port/chromium.py: + * Scripts/webkitpy/layout_tests/port/chromium_linux.py: + * Scripts/webkitpy/layout_tests/port/chromium_mac.py: + * Scripts/webkitpy/layout_tests/port/chromium_win.py: + +2010-03-19 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Dimitri Glazkov. + + fix typo in chromium test expectations overrides routine + https://bugs.webkit.org/show_bug.cgi?id=36397 + + * Scripts/webkitpy/layout_tests/port/chromium.py: + +2010-03-19 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Dimitri Glazkov. + + Flip the Chromium ports to look first for the test expectations + in LayoutTests/platform/chromium and only afterwards look in the + Chromium repo downstream for overrides. + + https://bugs.webkit.org/show_bug.cgi?id=36326 + + * Scripts/webkitpy/layout_tests/port/chromium.py: + +2010-03-19 James Hawkins <jhawkins@chromium.org> + + Unreviewed. + + Add myself to the committers list. + + * Scripts/webkitpy/committers.py: + +2010-03-19 Adam Barth <abarth@webkit.org> + + Unreviewed. + + Fix SheriffBot exception lock when we can't retrieve the first build + from buildbot. (I'll ask Eric to review this change after the fact, + but he's at lunch and I want to get the bot unlocked.) + + * Scripts/webkitpy/buildbot.py: + * Scripts/webkitpy/buildbot_unittest.py: + +2010-03-19 Alexey Proskuryakov <ap@apple.com> + + Reviewed by Darin Adler. + + https://bugs.webkit.org/show_bug.cgi?id=36380 + websocket/tests/frame-lengths.html times out on Tiger bot + + https://bugs.webkit.org/show_bug.cgi?id=35041 + websocket/tests/frame-lengths.html / websocket/tests/simple-stress.html fail on Windows bot + + Double the timeout (from 15 seconds to 30 seconds). We can increase it more, if necessary - + sampling the DRT process on Mac OS X takes much longer anyway, so it's better to avoid + timing out than to detect it early. + + * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: + (LayoutTestController::setWaitToDump): + * DumpRenderTree/mac/LayoutTestControllerMac.mm: + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::waitUntilDone): + * DumpRenderTree/win/LayoutTestControllerWin.cpp: + * Scripts/run-webkit-tests: + +2010-03-19 Laszlo Gombos <laszlo.1.gombos@nokia.com> + + Unreviewed. + + Buildfix for Qt v4.5. + + * QtLauncher/main.cpp: + (LauncherWindow::LauncherWindow): + (LauncherWindow::applyZoom): + +2010-03-19 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Operational tweaks to SheriffBot + https://bugs.webkit.org/show_bug.cgi?id=36385 + + These changes aren't pretty, but they're helpful to make SheriffBot + work operationally. I plan to iterate in these areas, but I wanted to + get this patch landed so I could be running the bot against TOT. + + * Scripts/webkitpy/commands/sheriffbot.py: + * Scripts/webkitpy/irc/ircbot.py: + * Scripts/webkitpy/thirdparty/autoinstalled/__init__.py: + +2010-03-19 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + Help sheriff-bot avoid warning about flaky tests (and add more unit testing) + https://bugs.webkit.org/show_bug.cgi?id=36354 + + * Scripts/webkitpy/buildbot.py: + - Make Build creation easier to Mock and test + * Scripts/webkitpy/buildbot_unittest.py: + - Test finding green to red transitions and suspect revisions + * Scripts/webkitpy/commands/queries.py: + - Make what-broke note when builders have only failed once. + +2010-03-19 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Dimitri Glazkov. + + Fix the rebaselining tool, which was broken by r36324 when I + added the concept of overridding expectations. + + https://bugs.webkit.org/show_bug.cgi?id=36374 + + * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: + +2010-03-19 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Misc bug fixes to make the SheriffBot actually work + https://bugs.webkit.org/show_bug.cgi?id=36355 + + With these changes, I can actually run the sheriff-bot from start to + finish. + + * Scripts/webkitpy/irc/ircproxy.py: + * Scripts/webkitpy/patch/patcher.py: + * Scripts/webkitpy/statusserver.py: + +2010-03-19 Adam Barth <abarth@webkit.org> + + Unreviewed. + + Actually import the sheriff-bot command so we can run it. Also, move + the bot to #webkit-test so it doesn't cause a ruckus while we test it. + + * Scripts/webkitpy/patch/patcher.py: + * Scripts/webkitpy/irc/ircbot.py: + +2010-03-19 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Second cut at SheriffBot + https://bugs.webkit.org/show_bug.cgi?id=36353 + + This patch should contain a complete SheriffBot that's capable of + saying reasonable things on IRC. I had to refactor the use of + CommitInfo to make the SheriffBot testable, but I did the minimum + necessary. We should grow webkitcheckout over time to contain the + knowledge of ChangeLogs from scm. + + * Scripts/webkitpy/commands/sheriffbot.py: + * Scripts/webkitpy/commands/sheriffbot_unittest.py: + * Scripts/webkitpy/mock_bugzillatool.py: + * Scripts/webkitpy/patch/patcher.py: + * Scripts/webkitpy/webkitcheckout.py: Added. + +2010-03-19 Adam Barth <abarth@webkit.org> + + Unreviewed. + + Fix Hyatt's IRC nickname. + + * Scripts/webkitpy/committers.py: + +2010-03-19 Adam Barth <abarth@webkit.org> + + Unreviewed. + + Add IRC nicknames for the non-reviewer committers. + + * Scripts/webkitpy/committers.py: + +2010-03-19 Adam Barth <abarth@webkit.org> + + Unreviewed. + + More reviewer IRC nicknames. + + * Scripts/webkitpy/committers.py: + +2010-03-19 Adam Barth <abarth@webkit.org> + + Unreviewed. + + Add a bunch of IRC nicknames for reviewers. + + * Scripts/webkitpy/committers.py: + +2010-03-19 Zoltan Horvath <zoltan@webkit.org> + + Reviewed by Oliver Hunt. + + Added USE_SYSTEM_MALLOC flag to build-webkit + https://bugs.webkit.org/show_bug.cgi?id=21272 + + Add system-alloc flag to build-webkit. It makes easy to switch + between system allocator and TCmalloc. + + * Scripts/build-webkit: + +2010-03-19 Adam Barth <abarth@webkit.org> + + Unreviewed "build" fix. + + Of course, I caused a regression in the file that isn't tested. :( + + * Scripts/webkitpy/statusserver.py: + +2010-03-19 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + Add basic "who-broke-it" command and revision -> broken builder association code + https://bugs.webkit.org/show_bug.cgi?id=36352 + + The "what-broke" command prints builders and what revisions we suspect + broke them. who-broke-it prints revisions and what builders we suspect + they broke. The sheriff-bot needs this revision to broken builder mapping + so this change adds it! + + * Scripts/webkitpy/buildbot.py: + * Scripts/webkitpy/commands/queries.py: + +2010-03-19 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + Simplify BuildBot core builder code for easier re-use + https://bugs.webkit.org/show_bug.cgi?id=36350 + + I simply couldn't see anything through all this Yak-hair. + + * Scripts/webkitpy/buildbot.py: + * Scripts/webkitpy/commands/queries.py: + +2010-03-19 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + committers.py should know IRC nicknames + https://bugs.webkit.org/show_bug.cgi?id=36349 + + I'll add the actual nicknames in another patch. + + * Scripts/webkitpy/committers.py: + * Scripts/webkitpy/committers_unittest.py: + +2010-03-18 Anders Bakken <agbakken@gmail.com> + + Reviewed by Simon Hausmann. + + https://bugs.webkit.org/show_bug.cgi?id=36318 + + QtLauncher runs as a GuiClient by default in Qt Embedded which will + make it try to connect to an existing GuiServer. This patch makes it + run like a stand-alone app. + + * QtLauncher/main.cpp: + (LauncherApplication::LauncherApplication): + +2010-03-19 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + Move find_green_to_red_transition out of "what-broke" onto Builder for easier re-use + https://bugs.webkit.org/show_bug.cgi?id=36345 + + * Scripts/webkitpy/buildbot.py: + * Scripts/webkitpy/commands/queries.py: + +2010-03-19 Adam Barth <abarth@webkit.org> + + Reviewed by Adam Barth. + + Actually pass the IRC password to the IRC object + https://bugs.webkit.org/show_bug.cgi?id=36346 + + I wanted to do this before, but both patches were in flight. This + patch finally closes the loop and makes the IRCProxy system complete. + + * Scripts/webkitpy/patch/patcher.py: + +2010-03-18 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Add a StatusServer front end to the SVNRevision table on QueueStatusServer + https://bugs.webkit.org/show_bug.cgi?id=36344 + + No test because Browser was too hard to mock. :( I couldn't figure + out how to make Mock be a dictionary as well as an object. + + * Scripts/webkitpy/statusserver.py: + +2010-03-18 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + Split out CommitInfo class and add unit tests + https://bugs.webkit.org/show_bug.cgi?id=36343 + + Move more logic out of "what-broke" into a shared CommitInfo + class so that it can be used by other commands and unit tested. + + * Scripts/webkitpy/commands/queries.py: + * Scripts/webkitpy/commitinfo.py: Added. + * Scripts/webkitpy/commitinfo_unittest.py: Added. + * Scripts/webkitpy/unittests.py: + +2010-03-18 Laszlo Gombos <laszlo.1.gombos@nokia.com> + + Reviewed by Kenneth Rohde Christiansen. + + [Qt] Fix LayoutTests/http/tests/appcache/max-size.html + https://bugs.webkit.org/show_bug.cgi?id=36207 + + Implement setAppCacheMaximumSize() for Qt. + + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::setAppCacheMaximumSize): + * DumpRenderTree/qt/LayoutTestControllerQt.h: + +2010-03-18 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + QueueStatusServer should be able to log broken bots + https://bugs.webkit.org/show_bug.cgi?id=36341 + + We need to add a new table to the QueueStatusServer to store persistent + information for the SheriffBot. The new table will keep track of which + bots each SVN revision broke. + + * QueueStatusServer/handlers/__init__.py: + * QueueStatusServer/handlers/svnrevision.py: Added. + * QueueStatusServer/handlers/updatebase.py: Added. + * QueueStatusServer/handlers/updatestatus.py: + * QueueStatusServer/handlers/updatesvnrevision.py: Added. + * QueueStatusServer/index.yaml: + * QueueStatusServer/main.py: + * QueueStatusServer/model/__init__.py: + * QueueStatusServer/model/svnrevision.py: Added. + * QueueStatusServer/templates/updatesvnrevision.html: Added. + +2010-03-18 Kenneth Rohde Christiansen <kenneth@webkit.org> + + Reviewed by Darin Adler. + + Add a new method to the Qt LayoutTestController for + changing media type and make the DRT support dry-run printing. + + * DumpRenderTree/qt/DumpRenderTreeQt.cpp: + (WebCore::DumpRenderTree::DumpRenderTree): + (WebCore::DumpRenderTree::dryRunPrint): + * DumpRenderTree/qt/DumpRenderTreeQt.h: + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::setMediaType): + * DumpRenderTree/qt/LayoutTestControllerQt.h: + +2010-03-18 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Dimitri Glazkov. + + Add upstream LayoutTests/platform/chromium* directories to the + baseline search path for new-run-webkit-tests in preparation for + upstreaming all of the Chromium baselines. Note that this does + not actually create the directories themselves, but that's okay. + + https://bugs.webkit.org/show_bug.cgi?id=36324 + + * Scripts/webkitpy/layout_tests/port/chromium_linux.py: + * Scripts/webkitpy/layout_tests/port/chromium_mac.py: + * Scripts/webkitpy/layout_tests/port/chromium_win.py: + +2010-03-18 Alexey Proskuryakov <ap@apple.com> + + Reviewed by Anders Carlsson. + + https://bugs.webkit.org/show_bug.cgi?id=36327 + Test that a plug-in can override Node methods of its element + + * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: + (normalizeOverride): + (pluginInvoke): + Override "normalize", and call back to let a test know that the plug-in was called. + +2010-03-17 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Dimitri Glazkov. + + Add the concept of an "overrides" file for expectations so that we + can store test_expectations both upstream and downstream for a port + that runs both in webkit.org and in a separate repository (like + Chromium). Also add some unit tests for the expectations module. + + https://bugs.webkit.org/show_bug.cgi?id=36249 + + * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: + * Scripts/webkitpy/layout_tests/layout_package/test_expectations_test.py: Added. + * Scripts/webkitpy/layout_tests/port/base.py: + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + +2010-03-18 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> + + Reviewed by Kenneth Rohde Christiansen. + + Add an overlay QGraphicsTextItem to QtLauncher so we can display FPS info + on the launcher and not on the terminal anymore. + + [Qt] QtLauncher's FPS info should be displayed on an overlay text item + https://bugs.webkit.org/show_bug.cgi?id=36244 + + * QtLauncher/webview.cpp: + (WebViewGraphicsBased::WebViewGraphicsBased): + (WebViewGraphicsBased::setFrameRateMeasurementEnabled): + (WebViewGraphicsBased::updateFrameRate): + * QtLauncher/webview.h: + +2010-03-18 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + First cut at SheriffBot + https://bugs.webkit.org/show_bug.cgi?id=36253 + + This patch contains a first attempt at writing a sheriff bot. + Currently, we're missing the logic that actually finds the SVN revision + numbers to complain about, but once we have that, we'll have the rest + of the infrustructure to ping IRC and to file bugs. + + There's a lot to fill in for the SheriffBot, but this patch give us the + framework in which to do it. + + This patch required a bit of refactoring of AbstractQueue because + SheriffBot is the first bot that doesn't process patches (it processes + SVN revisions). Accordingly, I've factored out AbstractPatchQueue to + hold the parts of AbstractQueue that are specific to dealing with + patches. Some of the choices here might not be obvious yet, but we can + tweak them as our needs become clearer. + + * Scripts/webkitpy/commands/queues.py: + * Scripts/webkitpy/commands/queues_unittest.py: + * Scripts/webkitpy/commands/sheriffbot.py: Added. + * Scripts/webkitpy/commands/sheriffbot_unittest.py: Added. + * Scripts/webkitpy/mock_bugzillatool.py: + Added a MockIRC object to the mock tool. + * Scripts/webkitpy/multicommandtool.py: + Added a finalize method so the tool can disconnect from IRC + cleanly instead of just droping the socket. + * Scripts/webkitpy/multicommandtool_unittest.py: + * Scripts/webkitpy/patch/patcher.py: + Added support for talking to IRC. + * Scripts/webkitpy/unittests.py: + We should add a commands/unittests.py file at some point to make + the commands module more self-contained. + +2010-03-18 Antti Koivisto <koivisto@iki.fi> + + Reviewed by Kenneth Rohde Christiansen. + + https://bugs.webkit.org/show_bug.cgi?id=36102 + [Qt] Scaling control API for tiled backing store + + Add animated smooth zooming to Qt launcher when in tiled mode. + + * QtLauncher/main.cpp: + (LauncherWindow::LauncherWindow): + (LauncherWindow::zoomAnimationFinished): + (LauncherWindow::applyZoom): + (LauncherWindow::zoomIn): + (LauncherWindow::zoomOut): + * QtLauncher/webview.h: + (WebViewGraphicsBased::graphicsWebView): + +2010-03-18 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Support using IRC accounts with a password + https://bugs.webkit.org/show_bug.cgi?id=36287 + + Add a global option to specify an IRC password so we can use the + sheriffbot account (which needs a password). + + * Scripts/webkitpy/irc/ircbot.py: + * Scripts/webkitpy/irc/ircproxy.py: + * Scripts/webkitpy/patch/patcher.py: + +2010-03-18 Eric Seidel <eric@webkit.org> + + Just fixing missing parenthesis typo, no review. + + * Scripts/webkitpy/commands/queries.py: '%' has higher precedence than 'or', use parentheses. + +2010-03-18 Alexey Proskuryakov <ap@apple.com> + + Reviewed by Adam Roben and Anders Carlsson. + + https://bugs.webkit.org/show_bug.cgi?id=36210 + plugins/resize-from-plugin.html fails on some platforms + + Turns out that most platforms don't use "cross-platform" main.cpp. Copied code added for + the test to their versions of the file. + + * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: + (webkit_test_plugin_set_window): + * DumpRenderTree/win/TestNetscapePlugin/main.cpp: + (NPP_SetWindow): + +2010-03-18 Leandro Pereira <leandro@profusion.mobi> + + Reviewed by Kenneth Rohde Christiansen. + + Add support to run-launcher to open the EFL example browser. + http://webkit.org/b/36181 + + * Scripts/webkitdirs.pm: + * Scripts/run-launcher: + +2010-03-18 Sergio Villar Senin <svillar@igalia.com> + + Reviewed by Xan Lopez. + + [GTK] Failing tests http/tests/misc/image-blocked-src-change.html + & http/tests/misc/image-blocked-src-no-change.html + https://bugs.webkit.org/show_bug.cgi?id=36227 + + * DumpRenderTree/gtk/DumpRenderTree.cpp: + (webViewConsoleMessage): print only the file name instead of the + whole URI when printing messages with local URI's + +2010-03-18 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + Teach what-broke how to look up reviewer and author Committer objects by name + https://bugs.webkit.org/show_bug.cgi?id=36264 + + * Scripts/webkitpy/commands/queries.py: + - Add committer_by_name lookups for both reviewer and author + - Improve printing in the cases where lookups fail. + * Scripts/webkitpy/committers.py: + - Add committer_by_name + * Scripts/webkitpy/committers_unittest.py: + - Test committer_by_name + +2010-03-17 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + create-rollout should actually fill out the description + https://bugs.webkit.org/show_bug.cgi?id=36261 + + * Scripts/webkitpy/commands/download.py: + The % operator was applied to the wrong string. + * Scripts/webkitpy/commands/download_unittest.py: + * Scripts/webkitpy/commands/upload_unittest.py: + * Scripts/webkitpy/mock_bugzillatool.py: + Add support for seeing what we actually do with create_bug. + +2010-03-17 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> + + Reviewed by Kenneth Rohde Christiansen. + + Accelerated Compositing is now default on QtWebKit so the option + in QtLauncher must be true as default. + + [Qt] QtLauncher's Accelerated Compositing option must be true as default + https://bugs.webkit.org/show_bug.cgi?id=36234 + + * QtLauncher/main.cpp: + (LauncherWindow::applyPrefs): + (LauncherWindow::toggleAcceleratedCompositing): + (LauncherApplication::handleUserOptions): + +2010-03-17 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Commit queue should ignore (probably red) builders when landing rollouts + https://bugs.webkit.org/show_bug.cgi?id=36169 + + When landing a rollout, the builders are probably red, so we need to + ignore them in the subprocess too. Also, we might as well update the + working copy because we haven't validated anything about the current + revision prior to trying to land. + + This change is testable, but it requires changing the mock executive to + log its arguments. That will generate a lot of expectation changes, so + I'd like to do that in a separate patch. + + * Scripts/webkitpy/commands/queues.py: + +2010-03-17 Chang Shu <chang.shu@nokia.com> + + Reviewed by Laszlo Gombos. + + https://bugs.webkit.org/show_bug.cgi?id=36139 + [Qt] Clean up cache each time DumpRenderTree starts. This behavior + matches other platforms, such as mac and gtk. + + * DumpRenderTree/qt/DumpRenderTreeQt.cpp: + (WebCore::DumpRenderTree::DumpRenderTree): + +2010-03-17 Adam Barth <abarth@webkit.org> + + Unreviewed. + + Turns out this needs to be a string. + + * Scripts/webkitpy/bugzilla.py: + +2010-03-17 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + Add more infrastructure for sheriff-bot, including making what-broke more awesome + https://bugs.webkit.org/show_bug.cgi?id=36254 + + * Scripts/webkitpy/bugzilla.py: + - Made the various URL methods return None when passed None. + * Scripts/webkitpy/bugzilla_unittest.py: + - Test that the url methods work as expected. + * Scripts/webkitpy/buildbot.py: + - Add a static Build.build_url so that its possible to generate a build url without a Build object. + - Give users a URL in _fetch_xmlrpc_build_dictionary error message. + * Scripts/webkitpy/changelogs.py: + - Add a new ChangeLogEntry class to encapsulate entry-parsing logic. + - Add is_path_to_changelog to greatly simplify SCM.modified_changelogs code. + - Make ChangeLog.parse_latest_entry_from_file a public method. + * Scripts/webkitpy/changelogs_unittest.py: + - Add tests for new ChangeLog entry parsing. + * Scripts/webkitpy/commands/queries.py: + - Make "what-broke" not print "ok" builders, only failing ones. + - Print much more information on failing builders, including links and authorship/reviewer information. + * Scripts/webkitpy/commands/queues_unittest.py: + - Use a fake_checkout path since fixing the cwd (as part of fixing scm_unittests.py) was breaking tests. + * Scripts/webkitpy/mock_bugzillatool.py: + - Move MockSCM away from using os.getcwd() as that was fragile (and wrong). + * Scripts/webkitpy/patch/patcher.py: + - Remove code which was broken now that this file has moved. + - Code was also redundant now that SCM.find_checkout_root() exists. + * Scripts/webkitpy/scm.py: + - Greatly simplify modified_changelogs now that I understand list comprehensions. + - Expect ChangeLogEntry objects instead of raw strings. + - Add changed_files_for_revision, committer_email_for_revision and contents_at_revision + - Add commit_with_message argument to all sites since someone half-added it before. :( + - Get rid of copy/paste code using _status_regexp() + * Scripts/webkitpy/scm_unittest.py: + - Fix these tests! + - Add new tests for new scm code. + - Fix spelling of "awsome" to "awesome". + +2010-03-17 Daniel Bates <dbates@rim.com> + + Rubber-stamped by David Levin. + + Add myself to the list of reviewers. + + * Scripts/webkitpy/committers.py: + +2010-03-17 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Change post-rollout to create-rollout and have it make a new bug + instead of posting the rollout to the old bug. + https://bugs.webkit.org/show_bug.cgi?id=36250 + + The new bug blocks the old bug instead of adding more complexity to the + old bug. One tricky question is whether to create the bug if we're + unable to create a rollout patch. In this patch, we do create the bug, + but we might revist this question in the future. + + * Scripts/webkitpy/bugzilla.py: + * Scripts/webkitpy/commands/download.py: + * Scripts/webkitpy/commands/download_unittest.py: + * Scripts/webkitpy/steps/createbug.py: + +2010-03-17 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Add a way for the bots to send messages to IRC + https://bugs.webkit.org/show_bug.cgi?id=36235 + + We'll use these classes to notify #webkit about bad SVN revisions. + This patch just has some skeleton code for us to play with. + + * Scripts/webkitpy/irc/__init__.py: Added. + * Scripts/webkitpy/irc/ircbot.py: Added. + A bot that knows how to talk to IRC. + * Scripts/webkitpy/irc/ircproxy.py: Added. + We need to run the bot on its own thread because the irclib needs + its own mainloop. This class provides an abstraction of the + threading. + * Scripts/webkitpy/irc/messagepump.py: Added. + * Scripts/webkitpy/irc/messagepump_unittest.py: Added. + * Scripts/webkitpy/irc/threadedmessagequeue.py: Added. + A thread-safe message queue for sending messages from the main + thread to the IRC thread. + * Scripts/webkitpy/irc/threadedmessagequeue_unittest.py: Added. + * Scripts/webkitpy/irc/unittests.py: Added. + * Scripts/webkitpy/thirdparty/autoinstalled/__init__.py: + Autoinstall irclib + * Scripts/webkitpy/unittests.py: + +2010-03-17 Victor Wang <victorw@chromium.org> + + Reviewed by Dimitri Glazkov. + + Fix image_diff syntax in webkitpy/port/base.py. + The syntax is wrong if diff_filename is specified. + + https://bugs.webkit.org/show_bug.cgi?id=36230 + + * Scripts/webkitpy/layout_tests/port/base.py: + +2010-03-16 Diego Gonzalez <diego.gonzalez@openbossa.org> + + Reviewed by Kenneth Christiansen. + + Provide to QtLauncher a way to change the ViewportUpdateMode + when it's in graphics based mode. + + [Qt] Make QtLaucher able to select the ViewportUpdateMode + https://bugs.webkit.org/show_bug.cgi?id=36175 + + * QtLauncher/main.cpp: + (LauncherWindow::selectViewportUpdateMode): + (LauncherWindow::createChrome): + +2010-03-17 Zoltan Horvath <zoltan@webkit.org> + + Reviewed by Darin Adler. + + Ambiguous error message when building for unspecified platform + https://bugs.webkit.org/show_bug.cgi?id=30203 + + Add an extra line information to the error message. + + * Scripts/webkitdirs.pm: + +2010-03-16 Adam Barth <abarth@webkit.org> + + No review, rolling out r56044. + http://trac.webkit.org/changeset/56044 + https://bugs.webkit.org/show_bug.cgi?id=36048 + + This patch broke Windows Debug (Tests) + + * Scripts/webkitdirs.pm: + +2010-03-16 John Abd-El-Malek <jam@chromium.org> + + Reviewed by Darin Fisher. + + Give keyboard focus to PluginDocuments by default + https://bugs.webkit.org/show_bug.cgi?id=36147 + + * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: + (pluginAllocate): + * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: + * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: + (NPP_New): + (NPP_SetWindow): + (handleEventCarbon): + (handleEventCocoa): + +2010-03-16 Sam Weinig <sam@webkit.org> + + Reviewed by Mark Rowe. + + Fix run-webkit-httpd on Windows. + + * Scripts/webkitperl/httpd.pm: + +2010-03-16 Alexey Proskuryakov <ap@apple.com> + + Tiger build fix. + + * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginGetProperty): + Added more type casts to shut down warnings. + +2010-03-16 Alexey Proskuryakov <ap@apple.com> + + Reviewed by Darin Adler. + + https://bugs.webkit.org/show_bug.cgi?id=36184 + YouTube video resizing doesn't work with OOP plug-ins + + Added a resizeTo() method, which calls resizePlugin() in JS with the same arguments, + and a lastSetWindowArguments property, which returns a string describing the last NPWindow + passed to NPN_SetWindow. + + * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: + (pluginGetProperty): + (testResizeTo): + (pluginInvoke): + * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: + * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: + (NPP_SetWindow): + +2010-03-16 Joanmarie Diggs <joanmarie.diggs@gmail.com> + + Reviewed by Xan Lopez. + + https://bugs.webkit.org/show_bug.cgi?id=35504 + [Gtk] Evaluate and fix AtkTable for layout tables + + Implements rowCount and columnCount for Gtk in DRT. + + * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: + (AccessibilityUIElement::rowCount): + (AccessibilityUIElement::columnCount): + +2010-03-15 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + Add "what-broke" command for debugging when the tree broke + https://bugs.webkit.org/show_bug.cgi?id=36157 + + This is another step towards automated sheriffing of the webkit tree. + With this logic our scripts are able to determine what revision broke the + tree. Buildbot should do this for us, but unfortunately buildbot doesn't + expose this kind of aggregate information. + + * Scripts/webkitpy/buildbot.py: + - Add new Builder and Build classes (which will eventually replace the custom dictionaries previously used). + - Split out more network logic into _fetch methods which will eventually be their own class for mocking. + - Use XMLRPC to communicate with the buildbot master instead of scraping build pages. + * Scripts/webkitpy/buildbot_unittest.py: + - Test the newly added buildbot classes. + * Scripts/webkitpy/commands/queries.py: + - Add an experimental what-broke command. + +2010-03-15 Daniel Bates <dbates@rim.com> + + Reviewed by Eric Seidel. + + https://bugs.webkit.org/show_bug.cgi?id=36048 + + Detect if the Windows Platform SDK is missing when building with + Visual C++ Express Edition and inform the user to download it. + + * Scripts/webkitdirs.pm: + +2010-03-15 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Let commit-queue land rollout patches even when the tree is red + https://bugs.webkit.org/show_bug.cgi?id=36155 + + Now the commit-queue will land patches whose name begins with "ROLLOUT " + even if the tree is red. The patches still go through the usual build + and test process, but they can be landed while the tree is on fire. + + * Scripts/webkitpy/bugzilla.py: + * Scripts/webkitpy/commands/queues.py: + * Scripts/webkitpy/commands/queues_unittest.py: + * Scripts/webkitpy/commands/queuestest.py: + * Scripts/webkitpy/mock_bugzillatool.py: + +2010-03-15 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Add webkit-patch post-rollout to upload rollouts to bugs.webkit.org for easy committing + https://bugs.webkit.org/show_bug.cgi?id=36154 + + This new command is a mashup of prepare-rollout and post. This command + will be used by an experimental bot to post rollouts of patches that + break things to bugs.webkit.org where they can be landed with the + greatest of ease. + + * Scripts/webkitpy/commands/download.py: + * Scripts/webkitpy/commands/download_unittest.py: + * Scripts/webkitpy/steps/__init__.py: + * Scripts/webkitpy/steps/postdiffforrevert.py: Added. + +2010-03-15 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + webkit-patch rollout should error out on conflicts + https://bugs.webkit.org/show_bug.cgi?id=36151 + + Instead of blindingly plowing ahead, we now throw an exception if there + are conflicts after applying a reverse diff. + + * Scripts/webkitpy/scm.py: + +2010-03-15 Chris Fleizach <cfleizach@apple.com> + + Unreviewed layout test fix. + + VO not able to perform a VO-spacebar on facebook links + https://bugs.webkit.org/show_bug.cgi?id=36132 + + GTK needs to implement press for this test to work. + + * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: + (AccessibilityUIElement::press): + +2010-03-15 Chris Fleizach <cfleizach@apple.com> + + Unreviewed layout test fix. + + VO not able to perform a VO-spacebar on facebook links + https://bugs.webkit.org/show_bug.cgi?id=36132 + + Windows needs to implement press in DRT. + + * DumpRenderTree/win/AccessibilityUIElementWin.cpp: + (AccessibilityUIElement::press): + +2010-03-15 Chris Fleizach <cfleizach@apple.com> + + Unreviewed. Fix break of layout tests on win and gtk. + + VO not able to perform a VO-spacebar on facebook links + https://bugs.webkit.org/show_bug.cgi?id=36132 + + Attempting to implement press action for windows and gtk. + + * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: + (AccessibilityUIElement::press): + * DumpRenderTree/win/AccessibilityUIElementWin.cpp: + (AccessibilityUIElement::press): + +2010-03-15 Chris Fleizach <cfleizach@apple.com> + + Reviewed by Beth Dakin. + + VO not able to perform a VO-spacebar on facebook links + https://bugs.webkit.org/show_bug.cgi?id=36132 + + * DumpRenderTree/AccessibilityUIElement.cpp: + (pressCallback): + (AccessibilityUIElement::getJSClass): + * DumpRenderTree/AccessibilityUIElement.h: + * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: + (AccessibilityUIElement::press): + * DumpRenderTree/mac/AccessibilityUIElementMac.mm: + (AccessibilityUIElement::press): + * DumpRenderTree/win/AccessibilityUIElementWin.cpp: + (AccessibilityUIElement::press): + +2010-03-15 Mark Rowe <mrowe@apple.com> + + Add a new build slave to replace the existing SnowLeopard Leaks build slave which + appears to be suffering a slow and painful death at the hands of its graphics hardware. + + * BuildSlaveSupport/build.webkit.org-config/config.json: + +2010-03-15 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Alexey Proskuryakov. + + Fix a minor case where we'd deference a null pointer if we tried + to run new-run-webkit-tests on an unsupported platform (e.g. + Cygwin's python version). + + https://bugs.webkit.org/show_bug.cgi?id=36076 + + * Scripts/webkitpy/layout_tests/port/factory.py: + +2010-03-15 Darin Adler <darin@apple.com> + + Tell Subversion about more directories that expect to have .pyc files. + + * Scripts/webkitpy/layout_tests: Added property svn:ignore. + * Scripts/webkitpy/layout_tests/port: Added property svn:ignore. + +2010-03-15 Adam Barth <abarth@webkit.org> + + Reviewed by Darin Adler. + + Operational scripts from running the EWS + https://bugs.webkit.org/show_bug.cgi?id=36097 + + These are the scripts I use to manage the EWS on EC2. If someone other + than me wants to run the EWS, these scripts might be helpful. + + * EWSTools/boot.sh: Added. + * EWSTools/create-webkit-git: Added. + * EWSTools/screen-config: Added. + * EWSTools/start-queue.sh: Added. + +2010-03-14 Adam Barth <abarth@webkit.org> + + Unreviewed. + + Fix the webkit-patch bots. Turns out they need the path of the main + script to run properly. + + * Scripts/webkit-patch: + * Scripts/webkitpy/patch/patcher.py: + +2010-03-14 Darin Adler <darin@apple.com> + + Tell Subversion about more directories that expect to have .pyc files. + + * Scripts/webkitpy/init: Added property svn:ignore. + * Scripts/webkitpy/patch: Added property svn:ignore. + * Scripts/webkitpy/thirdparty: Added property svn:ignore. + * Scripts/webkitpy/thirdparty/autoinstalled: Added property svn:ignore. + +2010-03-14 Antti Koivisto <koivisto@iki.fi> + + Reviewed by Simon Hausmann. + + https://bugs.webkit.org/show_bug.cgi?id=35146 + Support tiled backing store + + QtLauncher support and build flag in build-webkit. + + * QtLauncher/main.cpp: + (LauncherWindow::applyPrefs): + (LauncherWindow::toggleTiledBackingStore): + (LauncherWindow::toggleResizesToContents): + (LauncherWindow::createChrome): + (LauncherApplication::handleUserOptions): + * QtLauncher/webview.cpp: + (WebViewGraphicsBased::WebViewGraphicsBased): + (WebViewGraphicsBased::setResizesToContents): + (WebViewGraphicsBased::resizeEvent): + * QtLauncher/webview.h: + * Scripts/build-webkit: + +2010-03-13 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Adam Barth. + + The webkit-patch script now displays a warning if run using + a version of Python less than 2.5. This will help users + understand why webkit-patch is erroring out if they are + using Python 2.4, for example. + + https://bugs.webkit.org/show_bug.cgi?id=31533 + + * Scripts/webkit-patch: + - Moved most of the file contents to webkitpy/patch/patcher.py + so the Python version can be checked before interpreting + any code that can cause the script to error out. + - Added a configure_logging() method to enable any version + warnings to show up. + - Added a main() method with calls to configure_logging(), + check_version(), and the main webkit patch method. + + * Scripts/webkitpy/patch/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py. + - This file is required to make a folder a package. + + * Scripts/webkitpy/patch/patcher.py: Added. + - Moved code from Scripts/webkit-patch. + +2010-03-13 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Adam Barth. + + Changed test-webkitpy so that messages logged as a side-effect + of unit-testing code do not get displayed to the screen. These + messages clutter up the unit test results if not filtered out. + + https://bugs.webkit.org/show_bug.cgi?id=35835 + + * Scripts/test-webkitpy: + - Adjusted the configure_logging() method to filter out any + log messages from webkitpy. + - Also added an INFO message stating that most console logging + is getting suppressed. + + * Scripts/webkitpy/init/versioning.py: + - Added a log parameter to the check_version() method. + + * Scripts/webkitpy/init/versioning_unittest.py: + - Qualified a call to check_version() with the parameter names. + +2010-03-13 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Adam Barth. + + The test-webkitpy script now warns the user if the script is + being run using a Python version different from the minimum + version the webkitpy package was meant to support. + + https://bugs.webkit.org/show_bug.cgi?id=35788 + + Warning developers if their Python version is too low will help + them understand why test-webkitpy is failing. Secondly, warning + developers if their Python version is higher than the minimum will + help them understand that their changes may not be okay for the + minimum supported version, even if test-webkitpy is passing. + + * Scripts/test-webkitpy: + - Moved the "from ..._unittest import *" lines to the new + file Scripts/webkitpy/unittests.py. This will allow the + version-check warning to be displayed even if an error occurs + while interpreting (i.e. importing) the unit test code. + - Added configure_logging() to configur logging for test-webkitpy. + - Added an init() method to configure logging and check the + current Python version. + + * Scripts/webkitpy/init/unittests.py: Added. + - Added a file to import all unit test modules in the + webkitpy.init package. + + * Scripts/webkitpy/init/versioning.py: Added. + - Added a _MINIMUM_SUPPORTED_PYTHON_VERSION variable and set + it equal to 2.5. + - Added a compare_version() method to compare the current Python + version against a target version. + - Added a check_version() method to check the current Python + version against the current minimum supported version, and to + log a warning message if the check fails. + + * Scripts/webkitpy/init/versioning_unittest.py: Added. + - Added unit tests for the functions in versioning.py. + + * Scripts/webkitpy/style/unittests.py: + - Fixed/updated a code comment. + + * Scripts/webkitpy/unittests.py: Added. + - Moved the "from ..._unittest import *" lines from test-webkitpy. + +2010-03-13 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Adam Barth. + + Moved all code in webkitpy/__init__.py to another location. + + https://bugs.webkit.org/show_bug.cgi?id=35828 + + Keeping webkitpy/__init__.py free of non-trivial code allows + calling code to import initialization code from webkitpy + before any errors or log messages occur due to code in + __init__.py. Such initialization code can include things like + version checking code and logging configuration code. This + also lets us move the autoinstall initialization code to a + location where it only executes if it is needed -- something + we have done in this patch. + + * Scripts/webkitpy/__init__.py: + - Moved all executable code to the following location: + webkitpy/thirdparty/autoinstalled/__init__.py + - Added a code comment to keep this file free of non-trivial + code. + + * Scripts/webkitpy/bugzilla.py: + - Updated mechanize import statement. + + * Scripts/webkitpy/networktransaction.py: + - Updated mechanize import statement. + + * Scripts/webkitpy/networktransaction_unittest.py: + - Updated mechanize import statement. + + * Scripts/webkitpy/statusserver.py: + - Updated mechanize import statement. + + * Scripts/webkitpy/thirdparty/autoinstalled/__init__.py: Added. + - Copied the code from webkitpy/__init__.py and updated it + as necessary. + +2010-03-13 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Adam Barth. + + Moved webkitpy/mock.py into webkitpy/thirdparty since it is + third-party code. + + https://bugs.webkit.org/show_bug.cgi?id=35499 + + Updated the import statement in all of the below except where noted. + + * Scripts/webkitpy/bugzilla_unittest.py: + * Scripts/webkitpy/commands/commandtest.py: + * Scripts/webkitpy/commands/download_unittest.py: + * Scripts/webkitpy/commands/early_warning_system_unittest.py: + * Scripts/webkitpy/commands/queries_unittest.py: + * Scripts/webkitpy/commands/queues_unittest.py: + * Scripts/webkitpy/commands/queuestest.py: + * Scripts/webkitpy/commands/upload.py: + * Scripts/webkitpy/commands/upload_unittest.py: + * Scripts/webkitpy/commands_references.py: Added. + - Added a file containing an absolute import of Mock so that + the imports in the commands folder can import from this file + (similar to style_references.py). This helps limit the + number of affected files in future refactorings. + + * Scripts/webkitpy/credentials_unittest.py: + * Scripts/webkitpy/mock.py: Removed. + - Moved to Scripts/webkitpy/thirdparty. + + * Scripts/webkitpy/mock_bugzillatool.py: + * Scripts/webkitpy/patchcollection_unittest.py: + * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py: + * Scripts/webkitpy/steps/steps_unittest.py: + * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py: + * Scripts/webkitpy/steps_references.py: Added. + - Added a file containing an absolute import of Mock so that + the imports in the steps folder can import from this file + (similar to style_references.py). This helps limit the + number of affected files in future refactorings. + + * Scripts/webkitpy/thirdparty/mock.py: Copied from WebKitTools/Scripts/webkitpy/mock.py. + - Also eliminated trailing white space and carriage returns. + +2010-03-12 Robert Hogan <robert@webkit.org> + + Reviewed by Adam Barth. + + Amend incorrect typo patch for QtLauncher. + + https://bugs.webkit.org/show_bug.cgi?id=35877 + + * QtLauncher/webview.cpp: + (WebViewGraphicsBased::setFrameRateMeasurementEnabled): + +2010-03-13 Victor Wang <victorw@chromium.org> + + Add appengine app to host and serve webkit layout test results. + + The app allows you post test result files (json) and serve them up. + Chromium flakiness dashboard will first use this app to host results.json + and expectations.json, but the files hosted by this app are not limited + to chromium results or json files. It can be used to host other files if needed. + + https://bugs.webkit.org/show_bug.cgi?id=35944 + + * TestResultServer: Added. + * TestResultServer/app.yaml: Added. + * TestResultServer/handlers: Added. + * TestResultServer/handlers/__init__.py: Added. + * TestResultServer/handlers/menu.py: Added. + * TestResultServer/handlers/testfilehandler.py: Added. + * TestResultServer/index.yaml: Added. + * TestResultServer/main.py: Added. + * TestResultServer/model: Added. + * TestResultServer/model/__init__.py: Added. + * TestResultServer/model/testfile.py: Added. + * TestResultServer/stylesheets: Added. + * TestResultServer/stylesheets/form.css: Added. + * TestResultServer/stylesheets/menu.css: Added. + * TestResultServer/stylesheets/testfile.css: Added. + * TestResultServer/templates: Added. + * TestResultServer/templates/menu.html: Added. + * TestResultServer/templates/showfilelist.html: Added. + * TestResultServer/templates/uploadform.html: Added. + +2010-03-13 Dimitri Glazkov <dglazkov@chromium.org> + + Reviewed by David Levin. + + new-run-webkit-tests fails with --debug option. + https://bugs.webkit.org/show_bug.cgi?id=36067 + + * Scripts/webkitpy/layout_tests/port/mac.py: + +2010-03-13 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> + + Reviewed by Kenneth Rohde Christiansen. + + Add "Show FPS" menu option to QtLauncher. + + [Qt] QtLauncher need a menu option to show/hide FPS + https://bugs.webkit.org/show_bug.cgi?id=35794 + + * QtLauncher/main.cpp: + (LauncherWindow::showFPS): + (LauncherWindow::createChrome): + +2010-03-13 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> + + Reviewed by Kenneth Rohde Christiansen. + + Add a "Toggle FullScreen" option to QtLauncher Menu. + + [Qt] QtLauncher needs an option to toggle FullScreen Mode + https://bugs.webkit.org/show_bug.cgi?id=35755 + + * QtLauncher/main.cpp: + (LauncherWindow::init): + (LauncherWindow::eventFilter): + (LauncherWindow::initializeView): + (LauncherWindow::toggleFullScreenMode): + (LauncherWindow::createChrome): + +2010-03-12 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Dimitri Glazkov. + + Fix typo in websocket_server (path_from_base instead of + path_from_chromium_base). + + https://bugs.webkit.org/show_bug.cgi?id=36074 + + * Scripts/webkitpy/layout_tests/port/websocket_server.py: + +2010-03-12 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Adam Barth. + + new-run-webkit-tests --new-baseline doesn't work at all. + + It attempts to call a method that isn't defined. To fix it, I + removed the unnecessary and unnecessarily confusing 'platform' + argument to the test_type constructor and use the Port object that + is passed in instead, since we are only ever generating a baseline + from the port that is currently executing. + + https://bugs.webkit.org/show_bug.cgi?id=36046 + + * Scripts/webkitpy/layout_tests/port/mac.py: + * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: + +2010-03-12 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Adam Barth. + + Fix new-run-webkit-tests --run-singly + + This script option is currently broken - the script attempts to + dereference methods and variables that don't exist, which causes + the Chromium Linux valgrind bot to be quite unhappy. This has been + broken since r54449 when I renamed Port.start_test_driver to + Port.start_driver. + + https://bugs.webkit.org/show_bug.cgi?id=36042 + + * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: + +2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> + + Fix critical being printed to stderr on every test. This is + because the jar is only being created when soup hits the HTTP + path. We should reconsider the time of its creation. + + * DumpRenderTree/gtk/DumpRenderTree.cpp: + (resetDefaultsToConsistentValues): + +2010-03-12 Adam Roben <aroben@apple.com> + + Teach prepare-ChangeLog to find modified selectors in CSS files + + Reviewed by Tim Hatcher. + + Fixes <http://webkit.org/b/36064> prepare-ChangeLog should extract + modified selectors from CSS files + + * Scripts/prepare-ChangeLog: + (get_function_line_ranges): Call get_selector_line_ranges_for_css for + .css files. + (get_selector_line_ranges_for_css): Added. Finds selectors and their + line ranges and returns them. + +2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> + + Build fix (for EWS). Make sure the new code builds on older soup. + + Thanks to Dan Winship. + + * DumpRenderTree/gtk/DumpRenderTree.cpp: + (resetDefaultsToConsistentValues): + * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: + (LayoutTestController::setAlwaysAcceptCookies): + +2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> + + Reviewed by Eric Carlson. + + [GTK] DRT does not handle cookie policy setting + https://bugs.webkit.org/show_bug.cgi?id=36056 + + Implement cookie accept policy setting for GTK+'s LayoutTestController. + + * DumpRenderTree/gtk/DumpRenderTree.cpp: + (resetDefaultsToConsistentValues): + * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: + (LayoutTestController::setAlwaysAcceptCookies): + +2010-03-12 Adam Langley <agl@chromium.org> + + Reviewed by Dimitri Glazkov. + + [chromium]: update Linux layout test scripts for RedHat like systems. + + (Tested on Fedora 12.) + + https://bugs.webkit.org/show_bug.cgi?id=35867 + + * Scripts/webkitpy/layout_tests/port/chromium_linux.py: + +2010-03-12 Adam Roben <aroben@apple.com> + + Make svn-create-patch's diffs of ObjC header files more readable + + Fixes <http://webkit.org/b/36055>. + + Reviewed by John Sullivan. + + * Scripts/svn-create-patch: + (diffOptionsForFile): Added. Returns the options that should be passed + to diff for the given file. All the options are the same for all + files, except for the option to specify which lines should be used as + hunk headers. + (generateDiff): Use diffOptionsForFile to get the options to pass to + diff. + (hunkHeaderLineRegExForFile): Added. Returns the regular expression + that should be used by diff to identify lines that should be included + after the "@@" in the hunk header lines of the diff. For ObjC[++] + source files, we use any lines starting with -, +, or + @implementation/@interface/@protocol. For ObjC[++] header files (which + we assume to be any .h files in a mac/ or objc/ directory), we use any + lines starting with @implementation/@interface/@protocol. + +2010-03-12 Jochen Eisinger <jochen@chromium.org> + + Reviewed by Jeremy Orlow. + + Introduce setWillSendRequestClearHeader to LayoutTestController to selectively remove headers in willSendRequest. Used in http/tests/security/no-referrer.html + https://bugs.webkit.org/show_bug.cgi?id=35920 + + * DumpRenderTree/LayoutTestController.cpp: + (setWillSendRequestClearHeaderCallback): + (LayoutTestController::staticFunctions): + * DumpRenderTree/LayoutTestController.h: + (LayoutTestController::willSendRequestClearHeaders): + (LayoutTestController::setWillSendRequestClearHeader): + * DumpRenderTree/mac/ResourceLoadDelegate.mm: + (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): + * DumpRenderTree/win/ResourceLoadDelegate.cpp: + (ResourceLoadDelegate::willSendRequest): + +2010-03-11 Fumitoshi Ukai <ukai@chromium.org> + + Unreviewed. + + Fix typo in websocket_server.py + + * Scripts/webkitpy/layout_tests/port/websocket_server.py: + +2010-03-11 Garret Kelly <gdk@chromium.org> + + Reviewed by Darin Adler. + + Fixing minor typo in the commit queue status page. + https://bugs.webkit.org/show_bug.cgi?id=35979 + + * Scripts/webkitpy/commands/queues.py: + +2010-03-11 Fumitoshi Ukai <ukai@chromium.org> + + Unreviewed. + + Fix for WebSocket layout test runner on chromium/win port. + + * Scripts/webkitpy/layout_tests/port/websocket_server.py: register_cygwin and set CYGWIN_PATH + +2010-03-11 Mark Rowe <mrowe@apple.com> + + Reviewed by David Kilzer. + + <rdar://problem/7745082> Make it possible to build WebKit for older Mac OS X versions from the current Mac OS X version + + Default to using the appropriate SDK if the target Mac OS X version is not the current Mac OS X version. + + * DumpRenderTree/mac/Configurations/Base.xcconfig: + +2010-03-11 Victor Wang <victorw@chromium.org> + + Reviewed by dglazkov@chromium.org. + + rebaseline_chromium_webkit_tests can generate new baselines for + all platforms so it needs to know two ports in order to work correctly: + the port that the script is running on and the port that it generates + new baselines for. Update rebaselining tool to handle both port correctly. + + https://bugs.webkit.org/show_bug.cgi?id=36032 + + * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: + +2010-03-11 Mark Rowe <mrowe@apple.com> + + Reviewed by Tim Hatcher. + + <rdar://problem/7745082> Make it possible to build WebKit for older Mac OS X versions from the current Mac OS X version + + Introduce TARGET_MAC_OS_X_VERSION_MAJOR to represent the Mac OS X version that is being targeted. It defaults to the + current Mac OS X version unless otherwise specified. + + Key off TARGET_MAC_OS_X_VERSION_MAJOR where we'd previously been keying off MAC_OS_X_VERSION_MAJOR. + + Explicitly map from the target Mac OS X version to the preferred compiler since Xcode's default compiler choice + may not be usable when targetting a different Mac OS X version. + + Key off TARGET_GCC_VERSION rather than MAC_OS_X_VERSION_MAJOR in locations where we'd previously been keying off + MAC_OS_X_VERSION_MAJOR but the decision is really related to the compiler version being used. + + * DumpRenderTree/mac/Configurations/Base.xcconfig: + * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: + * DumpRenderTree/mac/DumpRenderTree.mm: Wrap the include of mach-o/getsect.h in 'extern "C"' as some versions of the + header in older SDKs do not do this inside the header. + +2010-03-11 Alexey Proskuryakov <ap@apple.com> + + Reviewed by Geoff Garen. + + https://bugs.webkit.org/show_bug.cgi?id=35965 + <rdar://problem/7742771> Crash when passing an object returned from plug-in back to the plug-in + + Made rememberedObject a member of PluginObject. A plug-in must not use its references + to browser NPObjects after being destroyed, but this wasn't the case with static variable. + + * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: + (pluginInvoke): + (pluginInvalidate): + (pluginAllocate): + (pluginDeallocate): + * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: + +2010-03-11 Simon Fraser <simon.fraser@apple.com> + + Reviewed by Oliver Hunt. + + https://bugs.webkit.org/show_bug.cgi?id=35905 + REGRESSION(55699?): media/video-no-autoplay.html times out on Leopard Commit Bot + + Make sure we reset the WebGL preference, so that WebGL doesn't get left + on after being enabled via layoutTestController.overridePreference(), + which in turn causes accelerated compositing to be enabled on Leopard + when we don't want it to be. + + * DumpRenderTree/mac/DumpRenderTree.mm: + (resetDefaultsToConsistentValues): + +2010-03-10 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Dimitri Glazkov. + + rebaseline_chromium_webkit_tests doesn't handle other plaforms + correctly (e.g., if you run on the Mac platform and try to + rebaseline the WIN results, the result gets written into + platform/mac instead of platform/chromium-win). Also, this script + doesn't work on non-Chromium ports, so we need to fix that at some + point. + + https://bugs.webkit.org/show_bug.cgi?id=35982 + + * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: + +2010-03-10 Daniel Bates <dbates@rim.com> + + Reviewed by Simon Hausmann. + + https://bugs.webkit.org/show_bug.cgi?id=35840 + + Updates the subroutine builtDylibPathForName() so that it adds the "d" suffix to + the QtWebKit library name on Windows. This change makes run-launcher work again + under Windows. Moreover, this change corresponds to the change made in change- + set 53924 <http://trac.webkit.org/changeset/53924>. + + * Scripts/webkitdirs.pm: + +2010-03-10 Adam Roben <aroben@apple.com> + + Roll out the prepare-ChangeLog part of r55870 + + This change wasn't needed (prepare-ChangeLog calls svn-create-patch + when it's asked to print out diffs for the user) and was screwing up + its ability to find changed function names. + + * Scripts/prepare-ChangeLog: + (diffCommand): Change the options we pass to svn-diff back to their + pre-r55870 form. + +2010-03-10 Robert Hogan <robert@webkit.org> + + Reviewed by Simon Hausmann. + + [Qt] Add Support for WebKitEnableCaretBrowsing to Qt DRT + + Unskip test fast/events/multiline-link-arrow-navigation.html + + https://bugs.webkit.org/show_bug.cgi?id=35593 + + * DumpRenderTree/qt/DumpRenderTreeQt.cpp: + (WebCore::WebPage::resetSettings): + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::overridePreference): + (LayoutTestController::setCaretBrowsingEnabled): + * DumpRenderTree/qt/LayoutTestControllerQt.h: + +2010-03-10 Robert Hogan <robert@webkit.org> + + Reviewed by Holger Freyther. + + QtLauncher: Fix typo in conditional statement in + WebViewGraphicsBased::setFrameRateMeasurementEnabled. + + '=' should be '=='! + + https://bugs.webkit.org/show_bug.cgi?id=35877 + + * QtLauncher/webview.cpp: + (WebViewGraphicsBased::setFrameRateMeasurementEnabled): + +2010-03-10 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Shinichiro Hamaji. + + Refactored and cleaned up the code for unit-testing logging. + + https://bugs.webkit.org/show_bug.cgi?id=35845 + + * Scripts/webkitpy/init/logtesting.py: + - Added more information to the module docstring. + - Added an assertMessages() method to the UnitTestLogStream + class. This simplifies the calling code. + - Renamed the UnitTestLog class to LogTesting, and reformulated + it as follows: + - Moved the logging configuration code from the __init__ + method to a new static setUp() method. + - Documented the __init__ method to be private. + - Improved the code so that the root logger does not have + its logging level changed. Instead we set the handler's + level. This makes the unit testing more unintrusive. + - Updated the assertMessages() method to call the + UnitTestLogStream class's assertMessages() method. + - More fully documented the class. + + * Scripts/webkitpy/style/checker.py: + - Added a logger parameter to the configure_logging() method. + This allows us to prevent test messages from being sent + to the root logger during unit testing, which may be + rendering to the screen, etc. + - Simplified the code by removing the _LevelLoggingFilter class. + - Replaced the _LevelLoggingFilter class with a one-line lambda + expression in configure_logging(). + + * Scripts/webkitpy/style/checker_unittest.py: + - Changed relative imports to absolute to comply more with PEP8. + - In the ConfigureLoggingTest class: + - Changed the setUp() method to prevent test messages from + being propagated to the root logger. + - Changed the _log() method to a data attribute. + - Updated to accommodate changes to logtesting.py. + + * Scripts/webkitpy/style_references.py: + - Updated an import statement. + +2010-03-10 Evan Martin <evan@chromium.org> + + Reviewed by Darin Adler. + + Python code for GDB 7 to support native printing of some WebCore types. + + * gdb/webcore.py: Added. + +2010-03-10 Adam Roben <aroben@apple.com> + + Make svn-create-patch and prepare-ChangeLog show better section + headings for ObjC files + + This makes the text at the end of each "@@" line in a diff actually + show the ObjC method or interface that contains the change, rather + than whatever the most-recently-defined C function was. + + Fixes <http://webkit.org/b/35970>. + + Reviewed by John Sullivan. + + * Scripts/svn-create-patch: Pass -F'^[-+@]' to diff so that it will + treat any lines starting with -, +, or @ as section heading lines. + This works well for ObjC files, and shouldn't affect other types of + files. + + * Scripts/prepare-ChangeLog: Changed the options passed to diff to + match those used in svn-create-patch. + +2010-03-10 Simon Hausmann <simon.hausmann@nokia.com> + + Reviewed by Tor Arne Vestbø. + + Link QtLauncher against the WebKit library using a relative rpath. + + This makes the launcher and the lib relocatable. + + * QtLauncher/QtLauncher.pro: + +2010-03-10 Holger Hans Peter Freyther <zecke@selfish.org> + + Rubber-stamped by Simon Hausmann. + + [iExploder] Add new CSS Properties and HTML Attributes + + The update-iexploder-cssproperties script was used to update + the various input files. The autobuffer HTML Attribute was removed + from WebKit and I manually added it back to the htmlattrs.in like + we have done it for other attributes in the past. + + * iExploder/htdocs/cssproperties.in: + * iExploder/htdocs/htmlattrs.in: + * iExploder/htdocs/htmltags.in: + +2010-03-09 Fumitoshi Ukai <ukai@chromium.org> + + Unreviewed. + + Obvious fix for --cgi-paths of pywebsocket. + + * Scripts/run-webkit-websocketserver: + * Scripts/webkitpy/layout_tests/port/websocket_server.py: + +2010-03-09 Jakub Wieczorek <jwieczorek@webkit.org> + + Unreviewed. + + Adding myself to committers.py. + + * Scripts/webkitpy/committers.py: + +2010-03-09 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Nate Chapin. + + Fix --clobber-old-results in new-run-webkit-tests. + + https://bugs.webkit.org/show_bug.cgi?id=35778 + + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + +2010-03-09 Andy Estes <aestes@apple.com> + + Reviewed by Adele Peterson. + + Add the ability to dispatch scroll wheel events in DRT. This was + necessary in order to write a test for + https://bugs.webkit.org/show_bug.cgi?id=34700. + + * DumpRenderTree/mac/EventSendingController.mm: Add support for two + new methods to EventSender: mouseScrollBy(x, y) and + continuousMouseScrollBy(x, y). The API to generate scroll events on + the mac was added in 10.5, so these methods are NOOPs on Tiger. + (+[EventSendingController isSelectorExcludedFromWebScript:]): + Regiester mouseScrollByX:andY: and continuousMouseScrollByX:andY: + (+[EventSendingController webScriptNameForSelector:]): Map JavaScript + method names to ObjC selectors. + (-[EventSendingController mouseScrollByX:andY:continuously:]): Generate + a scroll wheel event using CGEventCreateScrollWheelEvent() and dispatch + it to WebKit. + (-[EventSendingController continuousMouseScrollByX:andY:]): Generate a + continuous scrolling event by x and y pixels. + (-[EventSendingController mouseScrollByX:andY:]): Generate a notchy + scrolling event by x and y lines. + +2010-03-09 Chris Fleizach <cfleizach@apple.com> + + DRT build fix for Tiger. No review. + + AX: hit testing a list box doesn't work anymore + https://bugs.webkit.org/show_bug.cgi?id=35893 + + * DumpRenderTree/mac/AccessibilityControllerMac.mm: + (AccessibilityController::elementAtPoint): + +2010-03-09 Chris Fleizach <cfleizach@apple.com> + + Reviewed by Darin Adler. + + AX: hit testing a list box doesn't work anymore + https://bugs.webkit.org/show_bug.cgi?id=35893 + + * DumpRenderTree/AccessibilityController.cpp: + (getElementAtPointCallback): + (AccessibilityController::getJSClass): + * DumpRenderTree/AccessibilityController.h: + * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: + (AccessibilityController::elementAtPoint): + * DumpRenderTree/mac/AccessibilityControllerMac.mm: + (AccessibilityController::elementAtPoint): + * DumpRenderTree/win/AccessibilityControllerWin.cpp: + (AccessibilityController::elementAtPoint): + +2010-03-03 Fumitoshi Ukai <ukai@chromium.org> + + Reviewed by Alexey Proskuryakov. + + pywebsocket should support html and cgi in the same directory. + https://bugs.webkit.org/show_bug.cgi?id=34879 + + Import pywebsocket 0.4.9.2 + Specify --server-host 127.0.0.1, so that it only binds listening socket + to 127.0.0.1 to prevent access from non-localhost. + Change --cgi-paths from /websocket/tests/cookies to /websocket/tests, + because pywebsocket 0.4.9.2 supports html and cgi in the same directory + and only executable (httponly-cookies.pl) will be handled as cgi + script. + + * Scripts/run-webkit-tests: + * Scripts/run-webkit-websocketserver: + * Scripts/webkitpy/layout_tests/port/websocket_server.py: + * Scripts/webkitpy/thirdparty/pywebsocket/README.webkit: + * Scripts/webkitpy/thirdparty/pywebsocket/example/echo_client.py: + * Scripts/webkitpy/thirdparty/pywebsocket/example/handler_map.txt: Added. + * Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/standalone.py: + * Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/util.py: + * Scripts/webkitpy/thirdparty/pywebsocket/setup.py: + * Scripts/webkitpy/thirdparty/pywebsocket/test/test_util.py: + * Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/README: Added. + * Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/hello.pl: Added. + +2010-03-09 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Shinichiro Hamaji. + + Simplified check-webkit-style's argument parsing code by removing + support for the vestigial "extra flag values" parameter. + + https://bugs.webkit.org/show_bug.cgi?id=34677 + + The "extra flag values" parameter was needed before WebKit + forked check-webkit-style from Google. It was used to pass + through the option parser those command-line flags that WebKit + required but that Google's parser did not support (the --git-commit + flag in particular). + We can remove the parameter now because it is no longer + needed and unnecessarily clutters the argument-parsing code. + + * Scripts/webkitpy/style/optparser.py: + - Removed the extra_flag_values parameter from the + CommandOptionValues class's constructor. + - Removed the extra_flags parameter from the ArgumentParser + class's parse() method. + + * Scripts/webkitpy/style/optparser_unittest.py: + - Removed from the unit tests all references to the + extra_flag_values variable. + +2010-03-08 Kent Tamura <tkent@chromium.org> + + Reviewed by Dimitri Glazkov. + + [DRT/Chromium] Add EventSender + https://bugs.webkit.org/show_bug.cgi?id=35859 + + Add EventSender classes, which are going to be used by + DumpRenderTree Chromium port. These files are based on: + - src/webkit/tools/test_shell/event_sending_controller.cc + - src/webkit/tools/test_shell/event_sending_controller.h + of Chromium rev.40492. + + * DumpRenderTree/chromium/EventSender.cpp: Added. + * DumpRenderTree/chromium/EventSender.h: Added. + +2010-03-08 Kent Tamura <tkent@chromium.org> + + Reviewed by Dimitri Glazkov. + + [DRT/Chromium] Add PlainTextController and TextInputController + https://bugs.webkit.org/show_bug.cgi?id=35852 + + Add PlainTextController and TextInputController classes, which are going + to be used by DumpRenderTree Chromium port. These files are based on: + - src/webkit/tools/test_shell/plain_text_controller.{cc,h} and + - src/webkit/tools/test_shell/text_input_controller.{cc,h} + of Chromium rev.40492. + + * DumpRenderTree/chromium/PlainTextController.cpp: Added. + * DumpRenderTree/chromium/PlainTextController.h: Added. + * DumpRenderTree/chromium/TextInputController.cpp: Added. + * DumpRenderTree/chromium/TextInputController.h: Added. + +2010-03-08 Dumitru Daniliuc <dumi@chromium.org> + + Unreviewed, Chromium build fix. + + Reverting r55689. + + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + +2010-03-08 Fumitoshi Ukai <ukai@chromium.org> + + Reviewed by Adam Barth. + + Fix webkit-patch post and land to work well with security bug + https://bugs.webkit.org/show_bug.cgi?id=35733 + + Bugzilla requires authentication to access security bug page, + so call authenticate() if it failed to fetch bug page. + + * Scripts/webkitpy/bugzilla.py: + +2010-03-04 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Dimitry Glazkov. + + Fix --clobber-old-results in new-run-webkit-tests. + + https://bugs.webkit.org/show_bug.cgi?id=35778 + + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + +2010-03-08 Brady Eidson <beidson@apple.com> + + Reviewed by NOBODY (but suggested by Steve Falkenburg and fixing a boneheaded mistake on my part last week) + + Followup to https://bugs.webkit.org/show_bug.cgi?id=35532 + + * DumpRenderTree/win/LayoutTestControllerWin.cpp: + (LayoutTestController::apiTestGoToCurrentBackForwardItem): Can't pass in a null BOOL to WebKit APIs. + +2010-03-08 Chris Jerdonek <cjerdonek@webkit.org> + + Unreviewed. + + Fixed incorrect import statement in validate-committer-lists: + webkitpy.BeautifulSoup -> webkitpy.thirdparty.BeautifulSoup. + + * Scripts/validate-committer-lists: + +2010-03-08 Jian Li <jianli@chromium.org> + + Reviewed by Dmitry Titov. + + Blob.slice support. + https://bugs.webkit.org/show_bug.cgi?id=32993 + + Add ENABLE_BLOB_SLICE feature define and flag for build-webkit. It is + currently only turned on for Mac. + + * Scripts/build-webkit: + +2010-03-08 Gustavo Noronha Silva <gns@gnome.org> + + No review, rolling out r55662. + http://trac.webkit.org/changeset/55662 + https://bugs.webkit.org/show_bug.cgi?id=35863 + + Need to be coordinated with bots setup + + * Scripts/run-webkit-tests: + +2010-03-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> + + Reviewed by Holger Freyther. + + [GTK] Tests fail when running with ipv6 addresses available, on Debian systems + https://bugs.webkit.org/show_bug.cgi?id=35863 + + If running on a Debian-based system, also listen on the ipv6 address. + + * Scripts/run-webkit-tests: + +2010-03-08 Holger Hans Peter Freyther <zecke@selfish.org> + + Reviewed by Darin Adler. + + [iexploder] Automatically update htmltags.in and htmlattrs.in too + https://bugs.webkit.org/show_bug.cgi?id=33755 + + Change the update-iexploder-cssproperites script to update + the htmlattrs.in and htmltags.in of WebKitTools/iExploder/htdocs + automatically as well. + + Change the reading and writing code to work with parameters + and extend the method that is parsing the .in files to handle + the HTMLTagNames.in and the HTMLAttributeNames.in files. + + Remove custom code to determine the revision of files with a + utility of VCUtils.pm to determine the revision of the directory + these files are located in. This will also work with git checkout. + + * Scripts/update-iexploder-cssproperties: + +2010-03-07 Shinichiro Hamaji <hamaji@chromium.org> + + Reviewed by Eric Seidel. + + check-webkit-style: false positive for empty loop + https://bugs.webkit.org/show_bug.cgi?id=35717 + + * Scripts/webkitpy/style/processors/cpp.py: + * Scripts/webkitpy/style/processors/cpp_unittest.py: + +2010-03-07 Kent Tamura <tkent@chromium.org> + + Reviewed by Dimitri Glazkov. + + [DRT/Chromium] Add AccessibilityController and AccessibilityUIElement + https://bugs.webkit.org/show_bug.cgi?id=35774 + + Add AccessibilityController and AccessibilityUIElement classes, + which are going to be used by DumpRenderTree Chromium port. These + files are based on: + - src/webkit/tools/test_shell/accessibility_controller.{cc,h} and + - src/webkit/tools/test_shell/accessibility_ui_element.{cc,h} + of Chromium rev.40492. + + * DumpRenderTree/chromium/AccessibilityController.cpp: Added. + * DumpRenderTree/chromium/AccessibilityController.h: Added. + * DumpRenderTree/chromium/AccessibilityUIElement.cpp: Added. + * DumpRenderTree/chromium/AccessibilityUIElement.h: Added. + +2010-03-06 Hironori Bono <hbono@chromium.org> + + Reviewed by Eric Seidel. + + [Chromium] Typing into Flash with wmode = opaque|transparent and + non-latin language active outputs as if US keyboard layout active + + https://bugs.webkit.org/show_bug.cgi?id=34936 + + To test keyboard events on the test plugin, this change implements + NPCocoaEventKeyDown and NPCocoaEventKeyUp handlers so the plugin + can write log messages. + + * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: + (handleEventCocoa): Implemented the event handlers for NPCocoaKeyDown + and NPCocoaEventKeyUp. + +2010-03-05 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> + + Reviewed by Eric Seidel. + + Fix Print option on QtLauncher by calling print directly from QWebFrame. + + [Qt] QtLauncher Print option is not working on QGraphicsView mode + https://bugs.webkit.org/show_bug.cgi?id=35769 + + * QtLauncher/main.cpp: + (LauncherWindow::print): + +2010-03-05 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Eric Seidel. + + Changed the logging code for new-run-webkit-tests to use + module-specific loggers rather than the root logger. This is + a standard practice that allows logging specific to a package + to be configured independently of other modules. + + https://bugs.webkit.org/show_bug.cgi?id=35194 + + Added a line of the form "_log = logging.getLogger(<module>)" + to each module below, where <module> is the fully-qualified + name of the module, and updated the log lines to use the new + _log logger. + + * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: + * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: + * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: + * Scripts/webkitpy/layout_tests/port/apache_http_server.py: + * Scripts/webkitpy/layout_tests/port/chromium.py: + * Scripts/webkitpy/layout_tests/port/chromium_linux.py: + * Scripts/webkitpy/layout_tests/port/chromium_mac.py: + * Scripts/webkitpy/layout_tests/port/chromium_win.py: + * Scripts/webkitpy/layout_tests/port/http_server.py: + * Scripts/webkitpy/layout_tests/port/http_server_base.py: + * Scripts/webkitpy/layout_tests/port/mac.py: + * Scripts/webkitpy/layout_tests/port/websocket_server.py: + * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: + * Scripts/webkitpy/layout_tests/test_types/image_diff.py: + * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: + * Scripts/webkitpy/layout_tests/test_types/text_diff.py: + +2010-03-05 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Eric Siedel. + + Split the command-line invocation of the Chromium/python LigHTTPd + server implementation out into its own top level script to make it + a more "public" interface and to resolve some awkward layering + issues. This script will be called directly by other test scripts in + the Chromium tree. + + At some point this script should be made to work with Apache-based + implementations and on other ports. I have filed + https://bugs.webkit.org/show_bug.cgi?id=35820 for this. + + Also fix a bug in port/factory where options.chromium could be + dereferenced even if it wasn't set, raising an exception. + + https://bugs.webkit.org/show_bug.cgi?id=35812 + + * Scripts/webkitpy/layout_tests/port/factory.py: + * Scripts/webkitpy/layout_tests/port/http_server.py: + * Scripts/new-run-webkit-httpd: Added + +2010-03-02 Antonio Gomes <tonikitoo@webkit.org> + + Reviewed by Holger Freyther + Patch by Antonio Gomes <tonikitoo@webkit.org> + + [Gtk] Implement setSpatialNavigationEnabled in DRT. + https://bugs.webkit.org/show_bug.cgi?id=35705 + + * DumpRenderTree/gtk/DumpRenderTree.cpp: + (resetDefaultsToConsistentValues): + * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: + (LayoutTestController::setSpatialNavigationEnabled): + +2010-02-23 Antonio Gomes <tonikitoo@webkit.org> + + Reviewed by Kenneth Christiansen. + Patch by Antonio Gomes <tonikitoo@webkit.org> + + Add toggle on/off stub methods for Spatial Navigation in win, gtk and mac LayoutTestController class implementations. + https://bugs.webkit.org/show_bug.cgi?id=35699 + + * DumpRenderTree/LayoutTestController.cpp: + (setSpatialNavigationEnabledCallback): + (LayoutTestController::staticFunctions): + * DumpRenderTree/LayoutTestController.h: + * DumpRenderTree/gtk/DumpRenderTree.cpp: + * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: + (LayoutTestController::setSpatialNavigationEnabled): + * DumpRenderTree/mac/LayoutTestControllerMac.mm: + (LayoutTestController::setSpatialNavigationEnabled): + * DumpRenderTree/win/LayoutTestControllerWin.cpp: + (LayoutTestController::setSpatialNavigationEnabled): + +2010-02-18 Antonio Gomes <tonikitoo@webkit.org> + + Reviewed by Kenneth Christiansen. + Patch by Antonio Gomes <tonikitoo@webkit.org> + + Add toggle on/off mechanism for Spatial Navigation in QtLauncher. + + * QtLauncher/main.cpp: + (LauncherWindow::toggleSpatialNavigation): + (LauncherWindow::setupUI): + +2010-03-02 Antonio Gomes <tonikitoo@webkit.org> + + Reviewed by Simon Hausmann. + Patch by Antonio Gomes <tonikitoo@webkit.org> + + [Qt] Add setSpatialNavigationEnabled method DRT + https://bugs.webkit.org/show_bug.cgi?id=33715 + + * DumpRenderTree/qt/DumpRenderTreeQt.cpp: + (WebCore::WebPage::WebPage): + (WebCore::WebPage::resetSettings): + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::setSpatialNavigationEnabled): + * DumpRenderTree/qt/LayoutTestControllerQt.h: + + Unskipped fast/events/spatialnavigation/ + +2010-03-04 Mark Rowe <mrowe@apple.com> + + Rubber-stamped by Alice Liu. + + Find the framework relative to TARGET_BUILD_DIR as that has a more obvious value during production builds. + + * Scripts/check-for-webkit-framework-include-consistency: + +2010-03-04 Kent Tamura <tkent@chromium.org> + + Reviewed by Dimitri Glazkov. + + [DRT/Chromium] Add CppVariant and CppBoundClass + https://bugs.webkit.org/show_bug.cgi?id=35634 + + Add CppVariant and CppBoundClass classes, which are going to be + used by DumpRenderTree Chromium port. These files are based on: + - src/webkit/glue/cpp_variant.{cc,h} and + - src/webkit/glue/cpp_bound_class.{cc,h} + of Chromium rev.40492. + + * DumpRenderTree/chromium/CppBoundClass.cpp: Added. + * DumpRenderTree/chromium/CppBoundClass.h: Added. + * DumpRenderTree/chromium/CppVariant.cpp: Added. + * DumpRenderTree/chromium/CppVariant.h: Added. + +2010-03-04 Mark Rowe <mrowe@apple.com> + + Build fix for older versions of Ruby. + + * Scripts/check-for-webkit-framework-include-consistency: + +2010-03-04 Mark Rowe <mrowe@apple.com> + + Reviewed by Sam Weinig. + + Add a script to verify that WebKit framework headers are internally consistent. + + This script detects the following problematic situations: + * An exported WebKit header that includes a header from WebCore. + * An exported WebKit header that includes a header that does not exist in the WebKit framework. + * A public WebKit header that includes a private WebKit header. + + * Scripts/check-for-webkit-framework-include-consistency: Added. + +2010-03-04 Dumitru Daniliuc <dumi@chromium.org> + + Reviewed by Adam Roben. + + Making sure that the correct path is set before invoking + DumpRenderTree on cygwin. + + https://bugs.webkit.org/show_bug.cgi?id=35768 + + * Scripts/run-webkit-tests: + +2010-03-04 Simon Fraser <simon.fraser@apple.com> + + Revert the exceptions I just added, and make the error clearer. + + * Scripts/check-for-global-initializers: + +2010-03-04 Simon Fraser <simon.fraser@apple.com> + + Build fix: add exceptions to the check-for-global-initializers script + for FocusController and SpatialNavigation, and improve the script + to actually print out the globals found. + + * Scripts/check-for-global-initializers: + +2010-03-04 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Dimitri Glazkov. + + Fix dangling reference to "port" instead of "self._port_obj" that + was preventing the http_server from starting on Windows. + + * Scripts/webkitpy/layout_tests/port/http_server.py: + +2010-03-04 Diego Gonzalez <diego.gonzalez@openbossa.org> + + Reviewed by Simon Hausmann. + + Make Qt DumpRenderTree EventSender able to send double click events + + LayoutTests: + fast/events/dblclick-addEventListener.html + + [Qt] DRT: Send double click event from EventSender + https://bugs.webkit.org/show_bug.cgi?id=35255 + + * DumpRenderTree/qt/DumpRenderTreeQt.cpp: + (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): + * DumpRenderTree/qt/EventSenderQt.cpp: + (EventSender::EventSender): + (EventSender::mouseDown): + * DumpRenderTree/qt/EventSenderQt.h: + (EventSender::resetClickCount): + +2010-03-04 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> + + Reviewed by Tor Arne Vestbø. + + [Qt] Make the OUTPUT_DIR variable in qmake projects independent of build-webkit's logic. + + This also allows shadow builds relying only on qmake to work properly. + + * DumpRenderTree/qt/DumpRenderTree.pro: + * DumpRenderTree/qt/ImageDiff.pro: + * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: + * QtLauncher/QtLauncher.pro: + +2010-03-04 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> + + Reviewed by Kenneth Rohde Christiansen. + + Enable to use built-product-archive on Qt platform. + + * BuildSlaveSupport/built-product-archive: + +2010-03-03 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> + + Reviewed by Simon Hausmann. + + Add a missing 'm_' to class variables names. + + [Qt] QtLauncher is not respecting class variable names + https://bugs.webkit.org/show_bug.cgi?id=35542 + + * QtLauncher/main.cpp: + (LauncherWindow::LauncherWindow): + (LauncherWindow::init): + (LauncherWindow::sendTouchEvent): + (LauncherWindow::eventFilter): + (LauncherWindow::zoomIn): + (LauncherWindow::zoomOut): + (LauncherWindow::resetZoom): + (LauncherWindow::setEditable): + (LauncherWindow::setTouchMocking): + (LauncherWindow::initializeView): + (LauncherWindow::createChrome): + +2010-03-03 Alexey Proskuryakov <ap@apple.com> + + Rubber-stamped by Mark Rowe. + + Exclude leaks in Java that build bot complains about. + + * Scripts/run-webkit-tests: + +2010-03-03 Chris Marrin <cmarrin@apple.com> + + Reviewed by Simon Fraser. + + Additional change to separate Accelerated Compositing test from 3D Rendering test + https://bugs.webkit.org/show_bug.cgi?id=35610 + + I am now using #if ENABLED(3D_RENDERING) to emit the 3DRendering string from + DRT or not. This allows these flags to set independently. I also improved + the code flow in run-webkit-tests a bit. + + * DumpRenderTree/win/DumpRenderTree.cpp: + (main): + * Scripts/run-webkit-tests: + +2010-03-03 Chris Marrin <cmarrin@apple.com> + + Reviewed by Simon Fraser. + + Added ability to print supported features to console to DRT + https://bugs.webkit.org/show_bug.cgi?id=35610 + + This currently only prints whether or not Accelerated Compositing + and 3D Rendering are supported, which is the only way to tell if you + can run the compositing LayoutTests on Windows. But it can be expanded + to give more information as needed. Currently it prints that both + AcceleratedCompositing and 3DRendering are available if accelerated compositing + is enabled since both have to be turned on together. This allows me to maintain + separate checks for them. + + * DumpRenderTree/win/DumpRenderTree.cpp:Added --print-supported-features flag + (main): + * Scripts/run-webkit-tests:Runs DRT and enabled compositing tests if HW comp is available on Windows + +2010-03-03 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> + + Reviewed by Simon Hausmann. + + Refactor QtLauncher so it respects command line arguments + and inherits settings when you clone or create a new window. + + Implemented with help of Kenneth Rohde Christiansen. + + [Qt] QtLauncher must be refactored to fix command line arguments usage + https://bugs.webkit.org/show_bug.cgi?id=35536 + + * QtLauncher/main.cpp: + (LauncherWindow::LauncherWindow): + (LauncherWindow::init): + (LauncherWindow::isGraphicsBased): + (applySetting): + (LauncherWindow::applyPrefs): + (LauncherWindow::initializeView): + (LauncherWindow::newWindow): + (LauncherWindow::cloneWindow): + (LauncherWindow::createChrome): + (main): + * QtLauncher/webview.cpp: + (WebViewGraphicsBased::WebViewGraphicsBased): + (WebViewGraphicsBased::setFrameRateMeasurementEnabled): + * QtLauncher/webview.h: + (WebViewGraphicsBased::itemCacheMode): + (WebViewGraphicsBased::frameRateMeasurementEnabled): + +2010-03-02 Arno Renevier <arno@renevier.net> + + Reviewed by Gustavo Noronha Silva. + + [Gtk] implements ChromeClient::requestGeolocationPermissionForFrame + https://bugs.webkit.org/show_bug.cgi?id=35210 + + * DumpRenderTree/gtk/DumpRenderTree.cpp: + (geolocationPolicyDecisionRequested): + (createWebView): + +2010-03-02 Dirk Pranke <dpranke@chromium.org> + + Reviewed by David Levin. + + Revert r55339 - the Chromium codebase downstream had a temporary + need for WebKitTools/pywebsocket to still exist after Chris Jerdonek + had moved it (scripts still referenced the old location). Those + scripts have been updated to the new location, so it should be safe + to delete this now. + + https://bugs.webkit.org/show_bug.cgi?id=35614 + + * pywebsocket/mod_pywebsocket/standalone.py: Removed. + +2010-03-02 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Dimitri Glazkov. + + new-run-webkit-tests on chromium-linux tests to see if + layout_test_helper exists, but we don't use layout_test_helper on + linux. The test derefences a None object, and we crash. This fixes + that. + + https://bugs.webkit.org/show_bug.cgi?id=35602 + + * Scripts/webkitpy/layout_tests/port/chromium.py: + + 2010-03-02 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Dimitri Glazkov. + + r55388 (bug 35553) worked around a bug in Python's subprocess.Popen() + that was causing DRT to hang on exit in new-run-webkit-tests. + Unfortunately, that workaround doesn't work on chromium-win + (and the script fails completely). The good news is that the check + isn't actually necessary, and so this change makes it conditional. + + https://bugs.webkit.org/show_bug.cgi?id=35601 + + * Scripts/webkitpy/layout_tests/port/chromium.py: + +2010-03-02 Mark Rowe <mrowe@apple.com> + + Reviewed by Darin Adler. + + Bug 35576: WebKit should tell plug-in instances when private browsing state changes + <http://webkit.org/b/35576> + + TestNetscapePlugin is another bit of plug-in code where copy-paste was heavily used + when porting. Update the Windows and UNIX implementations of NPP_New and NPP_SetValue + to provide the expected behavior related to NPNVprivateModeBool. Hopefully this code + duplication can be cleaned up in the future. + + * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: + (webkit_test_plugin_new_instance): + (webkit_test_plugin_set_value): + * DumpRenderTree/win/TestNetscapePlugin/main.cpp: + (NPP_New): + (NPP_SetValue): + +2010-03-02 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> + + Reviewed by Alexey Proskuryakov. + + Test plugin still has issues with releasing objects, and variants + https://bugs.webkit.org/show_bug.cgi?id=35587 + + Fix the conditions for releasing the variants after calling + invoke, and avoid having a number of objects leak. + + * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: + (testDocumentOpen): + (testWindowOpen): + +2010-03-02 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Shinichiro Hamaji. + + Refactored the StyleChecker class's file-processing method + _process_file(). This will make it easier to add new + file-processing capabilities to check-webkit-style. + + https://bugs.webkit.org/show_bug.cgi?id=35490 + + * Scripts/webkitpy/style/checker.py: + - Added a _read_lines() method to the StyleChecker class + that extracts the lines from a file. + - Replaced part of _process_file() with a call to the new + _read_lines() method. + - Replaced another part of _process_file() with a call + to the new CarriageReturnProcessor.process() method. + + * Scripts/webkitpy/style/processors/common.py: + - Replaced the check_no_carriage_return() function with a + new CarriageReturnProcessor class. + + * Scripts/webkitpy/style/processors/common_unittest.py: + - Renamed the CarriageReturnTest class to + CarriageReturnProcessorTest and updated it as necessary. + +2010-03-02 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Shinichiro Hamaji. + + Started using the logging module in check-webkit-style. + This provides more options for debugging and a more flexible, + uniform way to report messages to the end-user. + + https://bugs.webkit.org/show_bug.cgi?id=35484 + + Also included classes in a central location to facilitate + the unit testing of logging code (setUp and tearDown of unit + test logging configurations, etc). + + * Scripts/check-webkit-style: + - Added a call to configure_logging() in the beginning of main(). + - Replaced two calls to sys.stderr.write() with appropriate + logging calls. + + * Scripts/webkitpy/init/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py. + + * Scripts/webkitpy/init/logtesting.py: Added. + - Added a UnitTestLogStream class to capture log output + during unit tests. + - Added a UnitTestLog class that provides convenience methods + for unit-testing logging code. + + * Scripts/webkitpy/style/checker.py: + - Added a configure_logging() method. + - Added a _LevelLoggingFilter class to filter out log messages + above a certain logging level. + - Removed the _stderr_write() method from the StyleChecker class + and replaced its use with appropriate logging calls. + + * Scripts/webkitpy/style/checker_unittest.py: + - Added a ConfigureLoggingTest class to unit test the + configure_logging() method. + - Updated the StyleCheckerCheckFileTest class as necessary. + + * Scripts/webkitpy/style_references.py: + - Added references to logtesting.UnitTestLog and + logtesting.UnitTestLogStream. + +2010-03-01 Chris Fleizach <cfleizach@apple.com> + + Fixing broken DRT on Leopard/Tiger. Second try. + + AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver + https://bugs.webkit.org/show_bug.cgi?id=35514 + + * DumpRenderTree/mac/AccessibilityUIElementMac.mm: + +2010-03-01 Chris Fleizach <cfleizach@apple.com> + + Fixing broken DRT on Leopard/Tiger. + + AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver + https://bugs.webkit.org/show_bug.cgi?id=35514 + + * DumpRenderTree/mac/AccessibilityUIElementMac.mm: + +2010-03-01 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> + + Reviewed by Eric Seidel. + + [GTK] plugins/setProperty.html fails on 64bit Release + https://bugs.webkit.org/show_bug.cgi?id=35425 + + Check invoke's return code before releasing the variant, since + there's a chance it won't be properly initialized, leading to + memory corruption, in some cases. + + * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: + (testCallback): + (testEnumerate): + (testDocumentOpen): + (testWindowOpen): + (handleCallback): + +2010-03-01 Dirk Pranke <dpranke@chromium.org> + + Reviewed by nobody. Build bustage :( + + Fix stupid typo that I committed even after David Levin pointed + it out to me :( + + https://bugs.webkit.org/show_bug.cgi?id=35553 + + * Scripts/webkitpy/layout_tests/port/mac.py: + +2010-03-01 Chris Fleizach <cfleizach@apple.com> + + Reviewed by Darin Adler. + + AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver + https://bugs.webkit.org/show_bug.cgi?id=35514 + + Add rowCount, columnCount for tables. + + * DumpRenderTree/AccessibilityUIElement.cpp: + (rowCountCallback): + (columnCountCallback): + (AccessibilityUIElement::getJSClass): + * DumpRenderTree/AccessibilityUIElement.h: + * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: + (AccessibilityUIElement::rowCount): + (AccessibilityUIElement::columnCount): + * DumpRenderTree/mac/AccessibilityUIElementMac.mm: + (AccessibilityUIElement::rowCount): + (AccessibilityUIElement::columnCount): + * DumpRenderTree/win/AccessibilityUIElementWin.cpp: + (AccessibilityUIElement::rowCount): + (AccessibilityUIElement::columnCount): + +2010-03-01 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Eric Seidel. + + Work around a bug in Python's subprocess.Popen() that keeps us from + cleaning up DumpRenderTree / test_shell properly when we finish the + tests in new-run-webkit-tests. + + https://bugs.webkit.org/show_bug.cgi?id=35553 + + * Scripts/webkitpy/layout_tests/port/chromium.py: + * Scripts/webkitpy/layout_tests/port/mac.py: + +2010-03-01 Arno Renevier <arno@renevier.net> + + Reviewed by Xan Lopez. + + webkit-build could pass unknown arguments to autogen.sh + https://bugs.webkit.org/show_bug.cgi?id=35454 + + * Scripts/build-webkit: + +2010-03-01 Dirk Pranke <dpranke@chromium.org> + + Rubber-stamped by Dimitri Glazkov. + + Fix breakage from r55372. + + https://bugs.webkit.org/show_bug.cgi?id=35549 + + * Scripts/webkitpy/layout_tests/port/chromium.py: + +2010-03-01 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + EWS can hang for five hours when compile output is too big + https://bugs.webkit.org/show_bug.cgi?id=35545 + + * Scripts/webkitpy/commands/queues.py: Limit uploads to 1MB instead of + 5MB. AppEngine seems to not like 5MB uploads. I'm not sure what the + limit is. Let's try 1MB for a while and see how it goes. + * Scripts/webkitpy/networktransaction.py: Tune the default parameters + to our exponential backoff. I'm not sure why I picked five hours as + the retry limit. That seems way too large. + +2010-03-01 Brady Eidson <beidson@apple.com> + + Reviewed by Sam Weinig. + + REGRESSION: Telling a WebView to go to its current WebHistoryItem is broken. + <rdar://problem/7699371> and https://bugs.webkit.org/show_bug.cgi?id=35532 + + * DumpRenderTree/LayoutTestController.cpp: + (apiTestGoToCurrentBackForwardItemCallback): + (LayoutTestController::staticFunctions): + * DumpRenderTree/LayoutTestController.h: + * DumpRenderTree/mac/LayoutTestControllerMac.mm: + (LayoutTestController::apiTestGoToCurrentBackForwardItem): + + Stubs for now: + * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: + (LayoutTestController::apiTestGoToCurrentBackForwardItem): + * DumpRenderTree/win/LayoutTestControllerWin.cpp: + (LayoutTestController::apiTestGoToCurrentBackForwardItem): + * DumpRenderTree/wx/LayoutTestControllerWx.cpp: + (LayoutTestController::apiTestGoToCurrentBackForwardItem): + +2010-03-01 Dirk Pranke <dpranke@chromium.org> + + Reviewed by David Levin. + + General cleanup of error handling in new-run-webkit-tests. + + Add Port.check_build() call that is separate from Port.check_sys_deps() + (and add a --nocheck-build flag to skip). This breaks a circular + dependency where you would start the layout test helper before + checking sys deps, but checking sys deps was the thing that told + you if your binaries where there. + + Also, made Port.check_sys_deps(), start_helper() and stop_helper() + optional by providing default implementations in the base class + rather than requiring ports to implement the routines regardless + of whether or not they were needed. + + Lastly, tweak a bunch of log messages to be cleaner, including + changing messages in thirdparty/autoinstall.py to be silent at + the default log level. + + http://bugs.webkit.org/show_bug.cgi?id=35416 + + * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: + * Scripts/webkitpy/layout_tests/port/base.py: + * Scripts/webkitpy/layout_tests/port/chromium.py: + * Scripts/webkitpy/layout_tests/port/chromium_linux.py: + * Scripts/webkitpy/layout_tests/port/chromium_mac.py: + * Scripts/webkitpy/layout_tests/port/chromium_win.py: + * Scripts/webkitpy/layout_tests/port/mac.py: + * Scripts/webkitpy/layout_tests/port/passing.py: + * Scripts/webkitpy/layout_tests/port/test.py: + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + * Scripts/webkitpy/thirdparty/autoinstall.py + +2010-03-01 Dirk Pranke <dpranke@chromium.org> + + Reviewed by David Levin. + + new-chromium-webkit-tests --platform=mac-leopard diffs are backwards + https://bugs.webkit.org/show_bug.cgi?id=35265 + + Some parts of the code passed arguments as + "actual, expected" and some passed as "expected, actual". + As you might imagine, this lead to great confusion and wrongness. + Standardize on "expected, actual" as that's the order which is + passed to the underlying diff tool. + + Based on a patch by Eric Siedel <eric@webkit.org>. + + * Scripts/webkitpy/layout_tests/port/base.py: + * Scripts/webkitpy/layout_tests/port/chromium.py: + * Scripts/webkitpy/layout_tests/port/test.py: + * Scripts/webkitpy/layout_tests/test_types/image_diff.py + +2010-03-01 Chris Jerdonek <cjerdonek@webkit.org> + + Unreviewed. + + Rolling out: http://trac.webkit.org/changeset/55348 + + https://bugs.webkit.org/show_bug.cgi?id=35163 + + Rolling out since the changes to autoinstall do not work + with Python 2.4. In particular, ZipFile.extractall() was + added in Python 2.6. + + * Scripts/webkitpy/__init__.py: + * Scripts/webkitpy/bugzilla.py: + * Scripts/webkitpy/init/__init__.py: Removed. + * Scripts/webkitpy/init/autoinstall.py: Removed. + * Scripts/webkitpy/networktransaction.py: + * Scripts/webkitpy/networktransaction_unittest.py: + * Scripts/webkitpy/statusserver.py: + * Scripts/webkitpy/thirdparty/autoinstall.py: Added. + +2010-03-01 Chris Jerdonek <cjerdonek@webkit.org> + + Unreviewed. + + Rolling out r55350: http://trac.webkit.org/changeset/55350 + + https://bugs.webkit.org/show_bug.cgi?id=33639 + + Need to roll out because this patch (pep8) depends on the newly + rewritten autoinstall.py (r55348), which is breaking for people + with Python 2.4: + + https://bugs.webkit.org/show_bug.cgi?id=35163#c21 + + That revision also needs to be rolled out and will be rolled out next. + + * Scripts/webkitpy/style/checker.py: + * Scripts/webkitpy/style/checker_unittest.py: + * Scripts/webkitpy/style/processors/python.py: Removed. + * Scripts/webkitpy/style/processors/python_unittest.py: Removed. + * Scripts/webkitpy/style/processors/python_unittest_input.py: Removed. + * Scripts/webkitpy/style/unittests.py: + * Scripts/webkitpy/style_references.py: + +2010-02-28 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Shinichiro Hamaji. + + Exempted WebKitTools/Scripts/webkitpy/thirdparty from all + style checks except for the whitespace/carriage_return check + and the pep8 tab and trailing white space checks. + + https://bugs.webkit.org/show_bug.cgi?id=35497 + + * Scripts/webkitpy/style/checker.py: + - Adjusted the _PATH_RULES_SPECIFIER configuration as necessary. + - Added enough pep8 categories to _all_categories() for the + unit tests to pass. + + * Scripts/webkitpy/style/checker_unittest.py: + - Updated the test_path_rules_specifier() unit test. + +2010-02-27 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by David Levin. + + Added Python style checking to check-webkit-style using + the third-party pep8 module (via autoinstall). + + https://bugs.webkit.org/show_bug.cgi?id=33639 + + * Scripts/webkitpy/style/checker.py: + - Added PYTHON to FileType. + - Updated ProcessorDispatcher to return a PythonProcessor + for *.py files. + + * Scripts/webkitpy/style/checker_unittest.py: + - Updated the ProcessorDispatcher unit tests for *.py files. + + * Scripts/webkitpy/style/processors/python.py: Added. + - Added PythonProcessor class. + + * Scripts/webkitpy/style/processors/python_unittest.py: Added. + - Added PythonProcessor unit tests. + + * Scripts/webkitpy/style/processors/python_unittest_input.py: Added. + - Added a sample Python file to test the PythonProcessor.process() + code path (since pep8 accepts a file path). + + * Scripts/webkitpy/style/unittests.py: + - Updated the style unit test file to import python_unittest.py. + + * Scripts/webkitpy/style_references.py: + - Adjusted style references to import pep8. + +2010-02-26 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by David Levin. + + Rewrote autoinstall.py to support unzipping *.zip files after + download, unzipping and extracting *.tar.gz files after download, + and copying installed files to a destination directory. + + https://bugs.webkit.org/show_bug.cgi?id=35163 + + These changes will allow us to autoinstall pep8.py from the web + and to put our third-party autoinstalled code in an explicit + directory like webkitpy/thirdparty/autoinstalled. They should + also speed up imports from autoinstalled *.zip packages slightly + since *.pyc files cannot be generated when importing from + zipped packages. + + * Scripts/webkitpy/__init__.py: + - Updated the autoinstall lines to use the new autoinstall methods. + - Added pep8.py to the list of auto-installed packages. + + * Scripts/webkitpy/bugzilla.py: + - Updated mechanize import path. + + * Scripts/webkitpy/init/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py. + + * Scripts/webkitpy/init/autoinstall.py: Added. + - Added AutoInstaller class. + - Added sample testing usage to __main__. + + * Scripts/webkitpy/networktransaction.py: + - Updated mechanize import path. + + * Scripts/webkitpy/networktransaction_unittest.py: + - Updated mechanize import path. + + * Scripts/webkitpy/statusserver.py: + - Updated mechanize import path. + + * Scripts/webkitpy/thirdparty/autoinstall.py: Removed. + - Replaced with rewritten autoinstall in init/autoinstall.py. + +2010-02-26 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Adam Barth. + + Change the default port for new-run-webkit-tests when running on + a Mac from 'chromium-mac' to 'mac'. Add a '--chromium' switch to + pick up the default platform-specific version of chromium instead. + + https://bugs.webkit.org/show_bug.cgi?id=35462 + + * Scripts/webkitpy/layout_tests/port/factory.py: + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + +2010-02-26 Dirk Pranke <dpranke@chromium.org> + + Unreviewed, build fix + + third time's the charm getting this path right? + + * pywebsocket/mod_pywebsocket/standalone.py: + +2010-02-26 Dumitru Daniliuc <dumi@chromium.org> + + Unreviewed, build fix. + + * pywebsocket/mod_pywebsocket/standalone.py: + +2010-02-26 Dumitru Daniliuc <dumi@chromium.org> + + Reviewed by Dimitri Glazkov. + + Moving the script to the right location. + + * pywebsocket/mod_pywebsocket: Added. + * pywebsocket/mod_pywebsocket/standalone.py: Copied from WebKitTools/pywebsocket/standalone.py. + * pywebsocket/standalone.py: Removed. + +2010-02-26 Dumitru Daniliuc <dumi@chromium.org> + + Unreviewed, fixing the license. + + * pywebsocket/standalone.py: + +2010-02-26 Dumitru Daniliuc <dumi@chromium.org> + + Reviewed by Adam Barth. + + Adding pywebsocket/standalone.py back to fix the Chromium webkit + canaries. Once all layout tests pass, we can get in the patch that + moves this directorty to WebKitTools/Scripts, update all Chromium + scripts, and revert this patch. + + https://bugs.webkit.org/show_bug.cgi?id=35464 + + * pywebsocket: Added. + * pywebsocket/standalone.py: Added. + +2010-02-26 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> + + Reviewed by Xan Lopez. + + [GTK] Needs proper reporting of frame loader callbacks, in DRT + https://bugs.webkit.org/show_bug.cgi?id=32170 + + Fix reporting of unload handlers, so that it is emitted where + needed, not after it. + + * DumpRenderTree/gtk/DumpRenderTree.cpp: + (webViewLoadFinished): + (webViewDocumentLoadFinished): + (createWebView): + +2010-02-26 Antonio Gomes <tonikitoo@webkit.org> + + Reviewed by Gustavo Noronha. + Patch by Antonio Gomes <tonikitoo@webkit.org> + + [Gtk] Make DRT EventSender::keyDown to consider 'hardware_keycode' field when synthesizing an event. + https://bugs.webkit.org/show_bug.cgi?id=35432 + + When a directional key-press event (arrow keys, End, Home, PageUp, + PageDown, etc) is synthesized by DRT's EventSender and it targets + an editor (e.g. <input type=text>, <textare>, etc), event is processed + by WebCore::EventHandler. On the other hand, if event target is not + an editor, event is bubbled up to Gtk+ for processing. In such cases, + if 'hardware_keycode' is not provided at event synthesize time + its processing fails (at some point in gtk_bindings_activate_event), + and no scroll action is performed. + + Unskip fast/events/node-event-anchor-lock.html + + * DumpRenderTree/win/EventSender.cpp: + (keyDownCallback): + * platform/gtk/Skipped: + +2010-02-26 Dimitri Glazkov <dglazkov@chromium.org> + + Reviewed by David Levin. + + new-webkit-run-tests: Extraneous parenthesis in websocket_server.py + https://bugs.webkit.org/show_bug.cgi?id=35436 + + * Scripts/webkitpy/layout_tests/port/websocket_server.py: Removed extra paren. + +2010-02-26 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by David Levin. + + Moved pywebsocket into the webkitpy/thirdparty directory and added + an associated README.webkit file to the pywebsocket directory. + This makes pywebsocket more consistent with the other third-party + Python code in our repository. + + https://bugs.webkit.org/show_bug.cgi?id=35198 + + * Scripts/run-webkit-tests: + - Updated paths to pywebsocket. + + * Scripts/run-webkit-websocketserver: + - Updated paths to pywebsocket. + + * Scripts/webkitpy/layout_tests/port/websocket_server.py: + - Updated paths to pywebsocket. + + * Scripts/webkitpy/thirdparty/pywebsocket: Copied from WebKitTools/pywebsocket. + * Scripts/webkitpy/thirdparty/pywebsocket/README.webkit: Added. + - Added a file containing information about the contents + of the pywebsocket directory. This will make it easier to + understand where the third-party code came from and what + local changes have been made. + + * pywebsocket: Removed. + * pywebsocket/COPYING: Removed. + * pywebsocket/MANIFEST.in: Removed. + * pywebsocket/README: Removed. + * pywebsocket/example: Removed. + * pywebsocket/example/echo_client.py: Removed. + * pywebsocket/example/echo_wsh.py: Removed. + * pywebsocket/mod_pywebsocket: Removed. + * pywebsocket/mod_pywebsocket/__init__.py: Removed. + * pywebsocket/mod_pywebsocket/dispatch.py: Removed. + * pywebsocket/mod_pywebsocket/handshake.py: Removed. + * pywebsocket/mod_pywebsocket/headerparserhandler.py: Removed. + * pywebsocket/mod_pywebsocket/memorizingfile.py: Removed. + * pywebsocket/mod_pywebsocket/msgutil.py: Removed. + * pywebsocket/mod_pywebsocket/standalone.py: Removed. + * pywebsocket/mod_pywebsocket/util.py: Removed. + * pywebsocket/setup.py: Removed. + * pywebsocket/test: Removed. + * pywebsocket/test/config.py: Removed. + * pywebsocket/test/mock.py: Removed. + * pywebsocket/test/run_all.py: Removed. + * pywebsocket/test/test_dispatch.py: Removed. + * pywebsocket/test/test_handshake.py: Removed. + * pywebsocket/test/test_memorizingfile.py: Removed. + * pywebsocket/test/test_mock.py: Removed. + * pywebsocket/test/test_msgutil.py: Removed. + * pywebsocket/test/test_util.py: Removed. + * pywebsocket/test/testdata: Removed. + * pywebsocket/test/testdata/handlers: Removed. + * pywebsocket/test/testdata/handlers/blank_wsh.py: Removed. + * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Removed. + * pywebsocket/test/testdata/handlers/sub: Removed. + * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Removed. + * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Removed. + * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Removed. + * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Removed. + * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Removed. + * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Removed. + +2010-02-26 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Eric Seidel. + + Changed the diff_parser module to log to a module-specific + logging.logger rather than the root logger. + + https://bugs.webkit.org/show_bug.cgi?id=35391 + + * Scripts/webkitpy/diff_parser.py: + +2010-02-26 Csaba Osztrogonác <ossy@webkit.org> + + Reviewed by Kenneth Rohde Christiansen. + + [Qt] LayoutTestController.numberOfPages() should have default parameters + https://bugs.webkit.org/show_bug.cgi?id=35428 + + * DumpRenderTree/qt/DumpRenderTreeQt.cpp: maxViewWidth and maxViewHeight moved to + LayoutTestController to converge to platform independent implementation. + (WebCore::DumpRenderTree::DumpRenderTree): + (WebCore::DumpRenderTree::open): + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Initialization of maxViewWidth and maxViewHeight added. + * DumpRenderTree/qt/LayoutTestControllerQt.h: + - Default parameters for LayoutTestController.numberOfPages() added. + - maxViewWidth and maxViewHeight members added. + +2010-02-26 Jamey Hicks <jamey.hicks@nokia.com> + + Reviewed by Laszlo Gombos. + + [Qt] added QWebSettings::setInspectorUrl() and QWebSettings::inspectorUrl() + + Enables the use of alternate Web Inspector frontends by changing + the location of the frontend. The location is specified by providing + -inspector-url url + as an argument to QtLauncher. + + This is required so that the Web Inspector may be run from an + external process or an external tool such as Eclipse or Aptana may + be used instead of the in-process Web Inspector UI. + + https://bugs.webkit.org/show_bug.cgi?id=35340 + + * QtLauncher/main.cpp: + (LauncherWindow::init): + (LauncherApplication::handleUserOptions): + +2010-02-25 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Eric Seidel. + + Add a 'passing' port implementation to new-run-webkit-tests that + acts as a wrapper around an existing implementation but stubs out + the actual test invocations (instead, the expected results are echoed + back to the harness). This is useful for coverage and perf testing + of the harness (especially perf testing as it essentially provides + a lower bound on how fast the harness can run). + + Also added a --nostart-helper flag to new-run-webkit-tests so that + you can skip starting the layout_test_helper and actually run the + harness even if you don't have a build of that port. + + Also fix a bug in the 'test' port implementation to actually + create the results directory under /tmp instead of /. + + https://bugs.webkit.org/show_bug.cgi?id=35370 + + * Scripts/webkitpy/layout_tests/port/factory.py: Modified. + * Scripts/webkitpy/layout_tests/port/passing.py: Added. + * Scripts/webkitpy/layout_tests/port/test.py: Added. + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Modified. + +2010-02-25 Eric Seidel <eric@webkit.org> + + Fix typo in my last change. No review. + + Rename run-chromium-webkit-tests to new-run-webkit-tests to stop confusion + https://bugs.webkit.org/show_bug.cgi?id=35408 + + * Scripts/new-run-webkit-tests: + +2010-02-25 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + Rename run-chromium-webkit-tests to new-run-webkit-tests to stop confusion + https://bugs.webkit.org/show_bug.cgi?id=35408 + + * Scripts/new-run-webkit-tests: Added. + * Scripts/run-chromium-webkit-tests: Removed. + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py. + +2010-02-25 Adam Barth <abarth@webkit.org> + + Reviewed by David Levin. + + EWS leaks memory slowly + https://bugs.webkit.org/show_bug.cgi?id=35395 + + The EWS bots leak memory very slowly. If you run them for about a + month, each one will take up around 1 GB of virutal memory. If you run + several of them on one machine, you'll eventually exhaust all available + memory and grind the bots to a halt. + + This patch introduces a --exit-after-iteration option to the queues so + that we run them for a finite amount of time. Once they exit and + restart, they'll reclaim the leaked memory. I'm not sure how many + iterations I'll end up running them for. I'll need to sort that out + operationally, but my initial guess is around 1000. + + * Scripts/webkitpy/commands/queues.py: + * Scripts/webkitpy/commands/queues_unittest.py: + +2010-02-25 Jarkko Sakkinen <jarkko.sakkinen@tieto.com> + + Reviewed by Kenneth Rohde Christiansen. + + Qt WebGL support + + Adds toggling of WebGL support to QtLauncher. + https://bugs.webkit.org/show_bug.cgi?id=35153 + + * QtLauncher/main.cpp: + (LauncherWindow::toggleWebGL): + (LauncherWindow::setupUI): + +2010-02-25 Ben Murdoch <benm@google.com> + + Reviewed by Kenneth Rohde Christiansen. + + The target element of a Touch should be the target where that touch originated, not where it is now. + https://bugs.webkit.org/show_bug.cgi?id=34585 + + * DumpRenderTree/qt/EventSenderQt.cpp: + (EventSender::addTouchPoint): Fix a bug where touch points were not being given unique ids. + +2010-02-24 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> + + Reviewed by Kenneth Rohde Christiansen. + + [Qt] QtLauncher has a border when running on QGraphicsView mode + https://bugs.webkit.org/show_bug.cgi?id=35352 + + Fix 2-pixels frame on each border of QtLauncher when running on QGraphicsView mode. + + * QtLauncher/webview.cpp: + (WebViewGraphicsBased::WebViewGraphicsBased): + +2010-02-23 Dirk Pranke <dpranke@chromium.org> + + Reviewed by David Levin. + + When the run-chromium-webkit-tests code was landed and the code was + refactored into the 'port' package, I accidentally broke using + http_server.py or websocket_server.py as command-line scripts + (the constructors needed a port object they weren't getting). This + change fixes them so that --server start|stop actually works. + + As a part of this, the two files need to be able to call port.get(), + but doing that is awkward from a file inside the package, so I moved + get() into factory.py and imported that into __init__.py so that + http_server.py and websocket_server.py can just import factory. + + https://bugs.webkit.org/show_bug.cgi?id=35316 + + * Scripts/webkitpy/layout_tests/port/__init__.py: + * Scripts/webkitpy/layout_tests/port/factory.py: + * Scripts/webkitpy/layout_tests/port/http_server.py: + * Scripts/webkitpy/layout_tests/port/websocket_server.py: + +2010-02-24 Dirk Pranke <dpranke@chromium.org> + + Reviewed by David Levin. + + Fix the function signature for check_sys_deps on the mac port, and + fix the ordering of port_obj.check_sys_deps() and + port_obj.start_helper() (helper needs to be started before we check + the system configuration). + + http://bugs.webkit.org/show_bug.cgi?id=35367 + + * Scripts/webkitpy/layout_tests/port/mac.py: + * Scripts/webkitpy/layout_tests/port/test.py: + * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py: + +2010-02-24 James Robinson <jamesr@chromium.org> + + Reviewed by Eric Seidel. + + Provide default username parameter to SVN.commit_with_message(). + + * Scripts/webkitpy/scm.py: + +2010-02-24 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Eric Siedel. + + Check the proper directory for a WebKit SVN version (Chromium does + not check out the entire WebKit tree directly, but rather pulls + individual subdirectories. So, checking for the SVN version in + WebKit/WebCore rather than just in WebKit works more reliably across + different ports). + + http://bugs.webkit.org/show_bug.cgi?id=35321 + + * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: + +2010-02-24 Alexey Proskuryakov <ap@apple.com> + + Reviewed by Dan Bernstein. + + https://bugs.webkit.org/show_bug.cgi?id=35357 + Two editing tests fail after DumpRenderTree run loop changes + + AppKit decided that it wanted to group all editing commands for some reason (and thus undo + reverted them all at once). + + * DumpRenderTree/mac/DumpRenderTree.mm: + (dump): Reverted the change that made DumpRenderTree use -[NSApplication run]. + (runTest): Ditto. + (-[DumpRenderTreeApplication isRunning]): Override isRunning with a function that always + returns YES. This is another way to make the Java plug-in work. + +2010-02-23 Adam Roben <aroben@apple.com> + + Make commit-log-editor find just-added ChangeLog files + + Fixes <http://webkit.org/b/35294> commit-log-editor doesn't find + just-added ChangeLog files + + Reviewed by Dave Levin. + + * Scripts/commit-log-editor: + (top level): Modified the regular expression that's used to find + modified ChangeLog files to also look for just-added ChangeLog files. + +2010-02-24 Shinichiro Hamaji <hamaji@chromium.org> + + Reviewed by Darin Adler. + + check-webkit-style false positive for WebCore forwarding header + https://bugs.webkit.org/show_bug.cgi?id=34604 + + * Scripts/webkitpy/style/checker.py: + * Scripts/webkitpy/style/checker_unittest.py: + +2010-02-23 Alexey Proskuryakov <ap@apple.com> + + Reviewed by Mark Rowe. + + https://bugs.webkit.org/show_bug.cgi?id=22602 + Enable Java in DumpRenderTree (on Mac) + + * DumpRenderTree/mac/DumpRenderTree.mm: + (exitApplicationRunLoop): + (dump): + (runTest): + DumpRenderTree now runs an NSApplication, not just an event loop. This way, the Java plug-in + can start without freezing. + + * Scripts/run-webkit-tests: Compile java sources in LayputTests/java. + +2010-02-23 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> + + Reviewed by Kenneth Rohde Christiansen. + + [Qt] Need a final integration between QtLauncher and QGVLauncher + https://bugs.webkit.org/show_bug.cgi?id=35292 + + WebKit coding style fixes. + + * QtLauncher/main.cpp: + (LauncherWindow::resetZoom): + +2010-02-23 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> + + Reviewed by Kenneth Rohde Christiansen. + + [Qt] Need a final integration between QtLauncher and QGVLauncher + https://bugs.webkit.org/show_bug.cgi?id=35292 + + Add cloneWindow feature to QtLauncher, when running on QGraphicsView mode. + + * QtLauncher/main.cpp: + (LauncherWindow::LauncherWindow): + (LauncherWindow::~LauncherWindow): + (LauncherWindow::init): + (LauncherWindow::cloneWindow): + (LauncherWindow::setupUI): + +2010-02-23 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Dimitri Glazkov. + + Fix handling of check_wdiff_install when wdiff isn't installed. + + http://bugs.webkit.org/show_bug.cgi?id=35304 + + * Scripts/webkitpy/layout_tests/port/chromium_mac.py: + +2010-02-23 Leandro Pereira <leandro@profusion.mobi> + + Reviewed by NOBODY. + + Fix false positives for 'delete *pointer' statements. + http://webkit.org/b/35235 + + * WebKitTools/Scripts/webkitpy/style/processors/cpp.py: + +2010-02-23 Shinichiro Hamaji <hamaji@chromium.org> + + Reviewed by Eric Seidel. + + [Gtk] Implement layoutTestController.numberOfPages + https://bugs.webkit.org/show_bug.cgi?id=35228 + + * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: + (LayoutTestController::numberOfPages): + +2010-02-23 Laszlo Gombos <laszlo.1.gombos@nokia.com> + + Reviewed by Kenneth Rohde Christiansen. + + [Qt] QtLauncher should not use internal JavaScriptCore and WebCore interfaces + https://bugs.webkit.org/show_bug.cgi?id=35248 + + * QtLauncher/QtLauncher.pro: + * QtLauncher/utils.h: + +2010-02-23 Daniel Bates <dbates@rim.com> + + Reviewed by Eric Seidel. + + https://bugs.webkit.org/show_bug.cgi?id=34439 + + Prompts a person for their SVN username if not already cached (by Subversion). + + Currently, webkit-patch is unable to commit to the SVN repo. unless the + WebKit SVN username is already cached (from of a prior commit by hand) + because "svn commit" (called by webkit-patch) defaults to using the system + login name unless the username is already cached or specified on the + command line. + + * Scripts/webkitpy/scm.py: Added methods SVN.has_authorization_for_realm and + modified SVN.commit_with_message to call it. Added optional username parameter + to method SVN.commit_with_message. + * Scripts/webkitpy/scm_unittest.py: Added unit test methods: SVNTest.test_commit_with_username, + SVNTest.test_has_authorization_for_realm, and SVNTest.test_not_have_authorization_for_realm. + +2010-02-22 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Eric Siedel. + + Add more checking for missing binaries and packages to check_sys_deps() + + https://bugs.webkit.org/show_bug.cgi?id=35062 + + * Scripts/webkitpy/layout_tests/port/base.py: + * Scripts/webkitpy/layout_tests/port/chromium.py: + * Scripts/webkitpy/layout_tests/port/chromium_linux.py: + * Scripts/webkitpy/layout_tests/port/chromium_mac.py: + * Scripts/webkitpy/layout_tests/port/chromium_win.py: + * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py: + +2010-02-22 Shinichiro Hamaji <hamaji@chromium.org> + + Reviewed by David Levin. + + [Gtk] check-webkit-style: GTK style should be allowed in WebKitTools/DumpRenderTree/gtk + https://bugs.webkit.org/show_bug.cgi?id=35229 + + * Scripts/webkitpy/style/checker.py: + * Scripts/webkitpy/style/checker_unittest.py: + +2010-02-22 James Robinson <jamesr@chromium.org> + + Unreviewed. Adding myself to committers list. + + * Scripts/webkitpy/committers.py: + +2010-02-22 Simon Fraser <simon.fraser@apple.com> + + Reviewed by Darin Adler. + + Remove DRT hack that turns off hardware acceleration with older QuickTimes + https://bugs.webkit.org/show_bug.cgi?id=35275 + + Now that WebKit does a version check to avoid a QuickTime-related + crash (r55100), DumpRenderTree does not need to. + + * DumpRenderTree/mac/DumpRenderTree.mm: + (resetDefaultsToConsistentValues): + +2010-02-22 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> + + Reviewed by Kenneth Rohde Christiansen. + + [Qt] Build the DRT in debug on Mac OS X + + * DumpRenderTree/qt/DumpRenderTree.pro: + +2010-02-22 Laszlo Gombos <laszlo.1.gombos@nokia.com> + + Reviewed by Kenneth Rohde Christiansen. + + [Qt] Add support for layout tests on Symbian + https://bugs.webkit.org/show_bug.cgi?id=31589 + + * DumpRenderTree/qt/DumpRenderTree.pro: + * DumpRenderTree/qt/DumpRenderTreeQt.cpp: + * DumpRenderTree/qt/main.cpp: + (main): + +2010-02-20 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Adam Barth. + + Moved simplejson into webkitpy/thirdparty directory. + + https://bugs.webkit.org/show_bug.cgi?id=35196 + + * Scripts/run-chromium-webkit-tests: + - Added webkitpy/thirdparty to the script's search path. + + * Scripts/webkitpy/thirdparty/simplejson: Copied from WebKitTools/simplejson. + - Copied simplejson directory. + + * simplejson: Removed. + * simplejson/LICENSE.txt: Removed. + * simplejson/README.txt: Removed. + * simplejson/__init__.py: Removed. + * simplejson/_speedups.c: Removed. + * simplejson/decoder.py: Removed. + * simplejson/encoder.py: Removed. + * simplejson/jsonfilter.py: Removed. + * simplejson/scanner.py: Removed. + +2010-02-20 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Adam Barth. + + Moved BeautifulSoup to webkitpy/thirdparty directory. + + https://bugs.webkit.org/show_bug.cgi?id=35195 + + * Scripts/webkitpy/BeautifulSoup.py: Removed. + - Moved to webkitpy/thirdparty. + + * Scripts/webkitpy/bugzilla.py: + - Updated import statement. + + * Scripts/webkitpy/bugzilla_unittest.py: + - Updated import statement. + + * Scripts/webkitpy/buildbot.py: + - Updated import statement. + + * Scripts/webkitpy/buildbot_unittest.py: + - Updated import statement. + + * Scripts/webkitpy/statusserver.py: + - Updated import statement. + + * Scripts/webkitpy/thirdparty/BeautifulSoup.py: Copied from WebKitTools/Scripts/webkitpy/BeautifulSoup.py. + +2010-02-20 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Adam Barth. + + Created a directory for third-party Python code, and moved + autoinstall.py into it. + + https://bugs.webkit.org/show_bug.cgi?id=34540 + + * Scripts/webkitpy/__init__.py: + - Updated "import autoinstall" statement. + + * Scripts/webkitpy/autoinstall.py: Removed. + - Moved to thirdparty/autoinstall.py. + + * Scripts/webkitpy/thirdparty: Added. + * Scripts/webkitpy/thirdparty/__init__.py: Added. + * Scripts/webkitpy/thirdparty/autoinstall.py: Copied from WebKitTools/Scripts/webkitpy/autoinstall.py. + +2010-02-20 Gustavo Noronha Silva <gns@gnome.org> + + Unreviewed, obvious fix for the python failure in our new buildbot + step: + + http://build.webkit.org/builders/GTK Linux 32-bit Release/builds/9075/steps/API tests/logs/err.text + + * BuildSlaveSupport/build.webkit.org-config/master.cfg: + +2010-02-19 Maciej Stachowiak <mjs@apple.com> + + Reviewed by David Levin. + + Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases + https://bugs.webkit.org/show_bug.cgi?id=35147 + + * Scripts/build-webkit: Handle new flag. + +2010-02-19 Leandro Pereira <leandro@profusion.mobi> + + Reviewed by Shinichiro Hamaji. + + [style-queue] should not complain about identifier names with underscores under WebKit/efl/ewk/ + https://bugs.webkit.org/show_bug.cgi?id=35091 + + White list unix_hacker_style names in WebKit/efl/ewk because these + are used in the EFL API. + + * Scripts/webkitpy/style/checker.py: + - Filter out readability/naming on WebKit/efl/ewk. + +2010-02-19 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + Split out "prepare-rollout" from "rollout" and make --complete-rollout default + https://bugs.webkit.org/show_bug.cgi?id=33745 + + * Scripts/webkitpy/commands/download.py: + - Add a new AbstractRolloutPrepCommand to share code between PrepareRollout and Rollout + - Add PrepareRollout + * Scripts/webkitpy/commands/download_unittest.py: Test PrepareRollout, remove CompleteRollout tests. + * Scripts/webkitpy/steps/__init__.py: include ReopenBugAfterRollout step. + * Scripts/webkitpy/steps/completerollout.py: Removed. + * Scripts/webkitpy/steps/options.py: remove complete_rollout + * Scripts/webkitpy/steps/reopenbugafterrollout.py: Added. + 2010-02-19 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> Reviewed by Kenneth Rohde Christiansen. |