summaryrefslogtreecommitdiffstats
path: root/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_linux.py
diff options
context:
space:
mode:
authorBen Murdoch <benm@google.com>2010-05-11 18:35:50 +0100
committerBen Murdoch <benm@google.com>2010-05-14 10:23:05 +0100
commit21939df44de1705786c545cd1bf519d47250322d (patch)
treeef56c310f5c0cdc379c2abb2e212308a3281ce20 /WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_linux.py
parent4ff1d8891d520763f17675827154340c7c740f90 (diff)
downloadexternal_webkit-21939df44de1705786c545cd1bf519d47250322d.zip
external_webkit-21939df44de1705786c545cd1bf519d47250322d.tar.gz
external_webkit-21939df44de1705786c545cd1bf519d47250322d.tar.bz2
Merge Webkit at r58956: Initial merge by Git.
Change-Id: I1d9fb60ea2c3f2ddc04c17a871acdb39353be228
Diffstat (limited to 'WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_linux.py')
-rw-r--r--WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_linux.py14
1 files changed, 3 insertions, 11 deletions
diff --git a/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_linux.py b/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_linux.py
index 9a595f2..a01bd14 100644
--- a/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_linux.py
+++ b/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_linux.py
@@ -31,9 +31,7 @@
import logging
import os
-import platform
import signal
-import subprocess
import chromium
@@ -122,15 +120,9 @@ class ChromiumLinuxPort(chromium.ChromiumPort):
_log.error(' Please install using: "sudo apt-get install '
'wdiff"')
_log.error('')
+ # FIXME: The ChromiumMac port always returns True.
return result
-
- def _kill_all_process(self, process_name):
- null = open(os.devnull)
- subprocess.call(['killall', '-TERM', '-u', os.getenv('USER'),
- process_name], stderr=null)
- null.close()
-
def _path_to_apache(self):
if self._is_redhat_based():
return '/usr/sbin/httpd'
@@ -187,8 +179,8 @@ class ChromiumLinuxPort(chromium.ChromiumPort):
# TODO(mmoss) This isn't ideal, since it could conflict with
# lighttpd processes not started by http_server.py,
# but good enough for now.
- self._kill_all_process('lighttpd')
- self._kill_all_process('apache2')
+ self._executive.kill_all("lighttpd")
+ self._executive.kill_all("apache2")
else:
try:
os.kill(server_pid, signal.SIGTERM)