diff options
| -rw-r--r-- | WebCore/ChangeLog | 13 | ||||
| -rw-r--r-- | WebCore/bindings/v8/V8DOMMap.h | 3 |
2 files changed, 16 insertions, 0 deletions
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog index d4ff396..dfbec52 100644 --- a/WebCore/ChangeLog +++ b/WebCore/ChangeLog @@ -1,3 +1,16 @@ +2010-02-02 Steve Block <steveblock@google.com> + + Reviewed by Adam Barth. + + Adds virtual destructors for AbstractWeakReferenceMap and AbstractWeakReferenceMap::Visitor + https://bugs.webkit.org/show_bug.cgi?id=34434 + + No new tests, build fix only. + + * bindings/v8/V8DOMMap.h: Modified. + (WebCore::AbstractWeakReferenceMap::~AbstractWeakReferenceMap): Added. + (WebCore::AbstractWeakReferenceMap::Visitor::~Visitor): Added. + 2010-02-01 Philippe Normand <pnormand@igalia.com> Rubber stamped by Xan Lopez. diff --git a/WebCore/bindings/v8/V8DOMMap.h b/WebCore/bindings/v8/V8DOMMap.h index d42daa4..a7e03a0 100644 --- a/WebCore/bindings/v8/V8DOMMap.h +++ b/WebCore/bindings/v8/V8DOMMap.h @@ -44,10 +44,13 @@ namespace WebCore { template <class KeyType, class ValueType> class AbstractWeakReferenceMap { public: AbstractWeakReferenceMap(v8::WeakReferenceCallback callback) : m_weakReferenceCallback(callback) { } + virtual ~AbstractWeakReferenceMap() { } class Visitor { public: virtual void visitDOMWrapper(KeyType* key, v8::Persistent<ValueType> object) = 0; + protected: + virtual ~Visitor() { } }; virtual v8::Persistent<ValueType> get(KeyType* obj) = 0; |