diff options
Diffstat (limited to 'Tools/ChangeLog')
| -rw-r--r-- | Tools/ChangeLog | 3082 |
1 files changed, 3082 insertions, 0 deletions
diff --git a/Tools/ChangeLog b/Tools/ChangeLog index 479fd41..a45d6a0 100644 --- a/Tools/ChangeLog +++ b/Tools/ChangeLog @@ -1,3 +1,3085 @@ +2011-04-19 Ojan Vafai <ojan@chromium.org> + + Fix check for whether a failure is expected to deal with + flaky tests and FAIL expectations. + * Scripts/webkitpy/layout_tests/layout_package/json_results.html: + +2011-04-19 Ojan Vafai <ojan@chromium.org> + + Reviewed by Eric Seidel. + + don't show missing text results for tests that only dump image results + https://bugs.webkit.org/show_bug.cgi?id=58931 + + * Scripts/webkitpy/layout_tests/layout_package/json_results.html: + * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: + +2011-04-19 Ojan Vafai <ojan@chromium.org> + + Reviewed by Eric Seidel. + + don't show failures table if there are only new tests + https://bugs.webkit.org/show_bug.cgi?id=58929 + + * Scripts/webkitpy/layout_tests/layout_package/json_results.html: + +2011-04-19 Ojan Vafai <ojan@chromium.org> + + Reviewed by Eric Seidel. + + don't show failures table if there are only new tests + https://bugs.webkit.org/show_bug.cgi?id=58929 + + * Scripts/webkitpy/layout_tests/layout_package/json_results.html: + +2011-04-19 Ojan Vafai <ojan@chromium.org> + + Fix unittest failures from http://trac.webkit.org/changeset/84294. + + * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py: + * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py: + +2011-04-18 Ojan Vafai <ojan@chromium.org> + + Reviewed by Eric Seidel. + + switch new-run-webkit-tests to using the new results file + https://bugs.webkit.org/show_bug.cgi?id=58861 + + * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: + * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py: + * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: + +2011-04-19 Renata Hodovan <reni@webkit.org> + + Reviewed by Eric Seidel. + + Move the alignment related macros from Vector.h to new Alignment.h. + https://bugs.webkit.org/show_bug.cgi?id=56000 + + Adding the new file to the forwarding headers of Tools. + + * DumpRenderTree/ForwardingHeaders/wtf/Alignment.h: Added. + +2011-04-19 Kevin Ollivier <kevino@theolliviers.com> + + [wx] Unreviewed build fix for Win / wx 2.9 wxPython installation. + + * wx/packaging/build-win-installer.py: + * wx/packaging/wxWebKitInstaller.iss.in: + +2011-04-19 Adam Roben <aroben@apple.com> + + Skip another accelerated-compositing-sensitive test when accelerated compositing is disabled + + * Scripts/old-run-webkit-tests: Skip media/controls-without-preload.html on Windows when + accelerated compositing is disabled. + +2011-04-19 Ojan Vafai <ojan@chromium.org> + + Remove accidentally committed debug code. + * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: + +2011-04-19 Brent Fulgham <bfulgham@webkit.org> + + Unreviewed build correction. + + Avoid duplicate stub implementation of test routine + for WinCairo build. + + * WebKitTestRunner/win/TestInvocationWin.cpp: Exclude + WinCairo from using this stub. + +2011-04-18 Ojan Vafai <ojan@chromium.org> + + Reviewed by Eric Seidel. + + make results file work with audio and reftests + https://bugs.webkit.org/show_bug.cgi?id=58860 + + Also fix bug with timeout tests and store a bit in the JSON + for new image tests instead of loading the image result to check if it's there. + + * Scripts/webkitpy/layout_tests/layout_package/json_results.html: + * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: + +2011-04-19 Jer Noble <jer.noble@apple.com> + + Reviewed by Adam Roben. + + REGRESSION (r84206): 50 tests failing on SnowLeopard Intel Release (WebKit2 Tests) due to extra "supportsFullScreen() == true" output + https://bugs.webkit.org/show_bug.cgi?id=58890 + + Add a layoutTestController flag which controls when full screen callbacks are written to stdout. + Defaults to false. + + * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpFullScreenCallbacks(). + * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: + (WTR::InjectedBundlePage::supportsFullScreen): Only write to stdout if shouldDumpFullScreenCallbacks is set. + (WTR::InjectedBundlePage::enterFullScreenForElement): Ditto. + (WTR::InjectedBundlePage::exitFullScreenForElement): Ditto. + * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: + (WTR::LayoutTestController::LayoutTestController): Initialize new ivar. + * WebKitTestRunner/InjectedBundle/LayoutTestController.h: + (WTR::LayoutTestController::dumpFullScreenCallbacks): Added. + (WTR::LayoutTestController::shouldDumpFullScreenCallbacks): Added. + +2011-04-19 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> + + Reviewed by Andreas Kling. + + [Qt] fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html fails (DRT sideeffect) + https://bugs.webkit.org/show_bug.cgi?id=35086 + + fast/xmlhttprequest/xmlhttprequest-no-file-access.html caused + a DRT sideeffect problem, because the resetSettings didn't set + the default value of LocalContentCanAccessFileUrls. + + * DumpRenderTree/qt/DumpRenderTreeQt.cpp: + (WebCore::WebPage::resetSettings): + +2011-04-18 Zan Dobersek <zandobersek@gmail.com> + + Reviewed by Martin Robinson. + + [GTK] Need support for dumping focus rectangles in pixel results + https://bugs.webkit.org/show_bug.cgi?id=53647 + + Dump the selection rect if it has been requested. + + * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: + (createBitmapContextFromWebView): + +2011-04-18 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + test-webkitpy should run the ActiveWorkItems tests + https://bugs.webkit.org/show_bug.cgi?id=58859 + + Also make the unit tests pass. :) + + * QueueStatusServer/model/activeworkitems.py: + * QueueStatusServer/model/queue.py: + * QueueStatusServer/model/workitems.py: + +2011-04-18 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + queues.webkit.org should show trailing-days pass counts for queues + https://bugs.webkit.org/show_bug.cgi?id=58812 + + This lets us see if each bot is pulling its own weight or not. + Before I wrote this patch our suspicious was that one of the + cq bots was doing most of the work. Turns out they're actually + pretty even in their recent pass counts. + + * QueueStatusServer/handlers/queuestatus.py: + * QueueStatusServer/index.yaml: + * QueueStatusServer/templates/queuestatus.html: + +2011-04-18 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Eric Seidel. + + new-run-webkit-tests: obsolete old threading code, part 1 + https://bugs.webkit.org/show_bug.cgi?id=58752 + + This patch removes support for the 'old-inline' and + 'old-threads' worker models, and deletes the corresponding code. + Now that the new code is stable, this stuff is no longer + necessary. + + * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: Removed. + * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Removed. + * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Removed. + * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: + +2011-04-18 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Eric Seidel. + + new-run-webkit-tests: add an --additional-drt-flag option + https://bugs.webkit.org/show_bug.cgi?id=58680 + + NRWT has a bunch of command line flags that exist to pass + custom flags to DRT, especially on chromium. It would be nice + if there was a generic mechanism to pass through flags so we + didn't have all the custom ones. + + * Scripts/webkitpy/layout_tests/port/chromium.py: + * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: + * Scripts/webkitpy/layout_tests/port/port_testcase.py: + * Scripts/webkitpy/layout_tests/port/test.py: + * Scripts/webkitpy/layout_tests/port/webkit.py: + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + +2011-04-05 Jer Noble <jer.noble@apple.com> + + Reviewed by Sam Weinig. + + WebKit2: WKTR should support WebKit2 full screen APIs + https://bugs.webkit.org/show_bug.cgi?id=56318 + + Respond to enterFullScreenForElement() and exitFullScreenForElement(), allowing + WKTR to test the LayoutTest/fullscreen/ tests. + + * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: + (WTR::InjectedBundlePage::InjectedBundlePage): Add support for WKBundlePageFullScreenClient. + (WTR::InjectedBundlePage::supportsFullScreen): Added. + (WTR::InjectedBundlePage::enterFullScreenForElement): Added. + (WTR::InjectedBundlePage::exitFullScreenForElement): Added. + * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: + * WebKitTestRunner/TestController.cpp: + (WTR::TestController::resetStateToConsistentValues): Enable the full screen preference. + +2011-04-18 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Tony Chang. + + new-run-webkit-tests: remove chromium-specific relpath hack for --results-directory + https://bugs.webkit.org/show_bug.cgi?id=58388 + + * Scripts/webkitpy/layout_tests/port/chromium.py: + +2011-04-18 Evan Martin <evan@chromium.org> + + Reviewed by Eric Seidel. + + [chromium] expose title direction to webkit client + https://bugs.webkit.org/show_bug.cgi?id=58823 + + * DumpRenderTree/chromium/LayoutTestController.cpp: + (LayoutTestController::LayoutTestController): + (LayoutTestController::reset): + * DumpRenderTree/chromium/LayoutTestController.h: + (LayoutTestController::setTitleTextDirection): + Add member and setter to let us stash the title direction at load time. + + * DumpRenderTree/chromium/WebViewHost.cpp: + (WebViewHost::didReceiveTitle): + * DumpRenderTree/chromium/WebViewHost.h: + Adapt to new API; push the title into layoutTestController when we + receive it. + +2011-04-18 Dirk Pranke <dpranke@chromium.org> + + Unreviewed. + + Re-land r84112. It was rolled out in r84127 but it didn't need + to be. Only r84111 actually broke things. + + * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: + * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: + +2011-04-18 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Tony Chang. + + new-run-webkit-tests: don't run more processes than necessary + https://bugs.webkit.org/show_bug.cgi?id=58751 + + Previously NRWT would start up 1 process for each processor on + the machine by default, which was a waste if we were only + running a few shards of tests. + + * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: + * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py: + * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: + +2011-04-18 Ojan Vafai <ojan@chromium.org> + + Reviewed by Eric Seidel. + + include links to actual.png files for new pixel tests + https://bugs.webkit.org/show_bug.cgi?id=58831 + + Load image elements to confirm whether the files exist. + Image elements will load without being appended to the DOM. + + * Scripts/webkitpy/layout_tests/layout_package/json_results.html: + +2011-04-18 Ojan Vafai <ojan@chromium.org> + + Reviewed by Eric Seidel. + + add a zoomed view for pixel results to the new results html file + https://bugs.webkit.org/show_bug.cgi?id=58827 + + * Scripts/webkitpy/layout_tests/layout_package/json_results.html: + +2011-04-18 Ojan Vafai <ojan@chromium.org> + + Reviewed by Eric Seidel. + + add labels to results html page + https://bugs.webkit.org/show_bug.cgi?id=58803 + + -fix iframe size to be the size of the png results + -fix a bunch of aesthetic nits + -fix some incorrectly styled code + + * Scripts/webkitpy/layout_tests/layout_package/json_results.html: + +2011-04-18 Chang Shu <cshu@webkit.org> + + Reviewed by Eric Seidel. + + WebKitTestRunner needs layoutTestController.pathToLocalResource + https://bugs.webkit.org/show_bug.cgi?id=42541 + + * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: + * WebKitTestRunner/InjectedBundle/LayoutTestController.h: + * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm: + (WTR::LayoutTestController::pathToLocalResource): + * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: + (WTR::LayoutTestController::pathToLocalResource): + * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp: + (WTR::LayoutTestController::pathToLocalResource): + +2011-04-18 Timothy Hatcher <timothy@apple.com> + + Make update-webkit-localizable-strings put WebKit/win strings in WebCore + now that all localized strings in WebKit/win use WEB_UI_STRING. + + https://webkit.org/b/58747 + + Reviewed by Dan Bernstein. + + * Scripts/update-webkit-localizable-strings: Remove the code that updated WebKit/win differently. + +2011-04-18 Patrick Gansterer <paroga@webkit.org> + + Reviewed by Adam Roben. + + [WIN] Use WCHAR instead of TCHAR + https://bugs.webkit.org/show_bug.cgi?id=58755 + + We always use the UNICODE versions of windows functions, so + the usage of TCHAR makes no sense and mixing them is bad style. + + * WinLauncher/PrintWebUIDelegate.cpp: + Also fix various style issues (including indentation and removal of ugly C-casts). + * WinLauncher/WinLauncher.cpp: + +2011-04-18 Dominic Cooney <dominicc@chromium.org> + + Reviewed by Andreas Kling. + + Add layoutTestController.shadowRoot to Qt DRT. + https://bugs.webkit.org/show_bug.cgi?id=58759 + + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::shadowRoot): Added. + * DumpRenderTree/qt/LayoutTestControllerQt.h: + +2011-04-18 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r84111. + http://trac.webkit.org/changeset/84111 + https://bugs.webkit.org/show_bug.cgi?id=58771 + + Chromium linux layout tests are broken. (Requested by loislo2 + on #webkit). + + * Scripts/webkitpy/layout_tests/port/chromium.py: + * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: + * Scripts/webkitpy/layout_tests/port/mock_drt.py: + +2011-04-18 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r84112. + http://trac.webkit.org/changeset/84112 + https://bugs.webkit.org/show_bug.cgi?id=58770 + + Chromium linux layout tests are broken. (Requested by loislo2 + on #webkit). + + * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: + * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: + +2011-04-17 Daniel Bates <dbates@webkit.org> + + Reviewed by Eric Seidel and Adam Barth. + + webkit-patch land hangs if svn prompts for credentials + https://bugs.webkit.org/show_bug.cgi?id=31500 + + Prompt for username and password when using git-svn and there aren't cached SVN credentials. + + * Scripts/webkitpy/common/checkout/scm.py: + - Added mixin class SVNRepository and made both class SVN and Git inherit from it. + - Moved SVN.has_authorization_for_realm() to class SVNRepository and removed default value + for argument realm; modified call sites as needed. + - Modified AuthenticationError constructor to take optional prompt_for_password argument. + - Modified {SCM, SVN, Git}.commit_with_message() to take optional password argument. + - Modified Git._commit_on_branch() to take optional username and password argument. + - Modified Git.push_local_commits_to_server() to take optional username and password + argument and to call has_authorization_for_realm(). + * Scripts/webkitpy/common/checkout/scm_unittest.py: + - Modified SVNTest.test_commit_without_authorization() to take dummy realm argument. + - Modified SVNTest.test_not_have_authorization_for_realm() to pass realm argument to + SVN.has_authorization_for_realm(). + * Scripts/webkitpy/common/net/credentials.py: + - Modified Credentials.read_credentials() to call User.prompt_password() instead + of using getpass.getpass() directly. + * Scripts/webkitpy/common/system/user.py: + - Added User.prompt_password(). + * Scripts/webkitpy/tool/steps/commit.py: + - Modified Commit.run() to prompt for a password if needed. + +2011-04-17 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Ojan Vafai. + + new-run-webkit-tests: save stderr into the layout-test-results dir + https://bugs.webkit.org/show_bug.cgi?id=58690 + + * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: + * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: + +2011-04-17 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Ojan Vafai. + + new-run-webkit-tests: read stderr from chromium DRT separately + https://bugs.webkit.org/show_bug.cgi?id=58708 + + * Scripts/webkitpy/layout_tests/port/chromium.py: + * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: + * Scripts/webkitpy/layout_tests/port/mock_drt.py: + +2011-04-17 Patrick Gansterer <paroga@webkit.org> + + Reviewed by Adam Barth. + + Rename PLATFORM(CA) to USE(CA) + https://bugs.webkit.org/show_bug.cgi?id=58742 + + * DumpRenderTree/mac/DumpRenderTree.mm: + (resetDefaultsToConsistentValues): + +2011-04-17 Patrick Gansterer <paroga@webkit.org> + + Reviewed by Adam Barth. + + Rename PLATFORM(CG) to USE(CG) + https://bugs.webkit.org/show_bug.cgi?id=58729 + + * DumpRenderTree/PixelDumpSupport.cpp: + * DumpRenderTree/chromium/WebViewHost.cpp: + (WebViewHost::paintRect): + * DumpRenderTree/config.h: + * DumpRenderTree/win/PixelDumpSupportWin.cpp: + (createBitmapContextFromWebView): + * TestWebKitAPI/PlatformWebView.h: + * WebKitTestRunner/config.h: + * WebKitTestRunner/win/TestInvocationWin.cpp: + +2011-04-16 Patrick Gansterer <paroga@webkit.org> + + Reviewed by Eric Seidel. + + Rename PLATFORM(CAIRO) to USE(CAIRO) + https://bugs.webkit.org/show_bug.cgi?id=55192 + + * DumpRenderTree/PixelDumpSupport.cpp: + * DumpRenderTree/config.h: + * DumpRenderTree/win/PixelDumpSupportWin.cpp: + (createBitmapContextFromWebView): + * WebKitTestRunner/config.h: + +2011-04-16 Ojan Vafai <ojan@chromium.org> + + Reviewed by Eric Seidel. + + show diffs+test inline in the results page + https://bugs.webkit.org/show_bug.cgi?id=58723 + + Put each row in it's own tbody and sort based on tbodies. That way + we can append the results to the tbody inline as another table row. + + * Scripts/webkitpy/layout_tests/layout_package/json_results.html: + +2011-04-16 Ojan Vafai <ojan@chromium.org> + + Reviewed by Eric Seidel. + + handle new tests in the new results html file + https://bugs.webkit.org/show_bug.cgi?id=58715 + + * Scripts/webkitpy/layout_tests/layout_package/json_results.html: + +2011-04-15 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Ojan Vafai. + + old-run-webkit-tests: save the list of tests actually run to a file + https://bugs.webkit.org/show_bug.cgi?id=58692 + + * Scripts/old-run-webkit-tests: + +2011-04-15 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Ojan Vafai. + + fix MockFileSystem.abspath() on windows + https://bugs.webkit.org/show_bug.cgi?id=58713 + + The existing code was borked on Windows if a path was passed + in using a drive letter (e.g., "d:\foo.txt"), and would go + into an infinite recursive loop. While win paths shouldn't + normally be passed into the mock filesystem, this just + bulletproofs things a bit (note that "/foo.txt" is considered + an absolute path on windows python as well. + + * Scripts/webkitpy/common/system/filesystem_mock.py: + +2011-04-15 Ojan Vafai <ojan@chromium.org> + + Reviewed by Eric Seidel. + + show stderr files and httpd log files + https://bugs.webkit.org/show_bug.cgi?id=58714 + + * Scripts/webkitpy/layout_tests/layout_package/json_results.html: + * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: + +2011-04-15 Shishir Agrawal <shishir@chromium.org> + + Reviewed by James Robinson. + + Add a flag to guard Page Visibility API changes. + https://bugs.webkit.org/show_bug.cgi?id=58464 + + * Scripts/build-webkit: + +2011-04-15 Chang Shu <cshu@webkit.org> + + Reviewed by Alexey Proskuryakov. + + When a message with url embedded is added to console, the "file:" scheme + and path should be stripped. + https://bugs.webkit.org/show_bug.cgi?id=58665 + + * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: + (WTR::lastFileURLPathComponent): + (WTR::InjectedBundlePage::willAddMessageToConsole): + +2011-04-15 Jeff Miller <jeffm@apple.com> + + Reviewed by Sam Weinig. + + Add takeFocus callback to WKPageUIClient + https://bugs.webkit.org/show_bug.cgi?id=58686 + + Add empty WKPageUIClient entries for the takeFocus callback in the MiniBrowser and WebKitTestRunner. + + * MiniBrowser/mac/BrowserWindowController.m: + (-[BrowserWindowController awakeFromNib]): Added empty takeFocus entry. + * MiniBrowser/win/BrowserView.cpp: + (BrowserView::create): Added empty takeFocus entry. + * WebKitTestRunner/TestController.cpp: + (WTR::TestController::createOtherPage): Added empty takeFocus entry. + (WTR::TestController::initialize): Added empty takeFocus entry. + +2011-04-15 Ojan Vafai <ojan@chromium.org> + + Reviewed by Eric Seidel. + + only show pretty-diff/wdiff if they were generated + https://bugs.webkit.org/show_bug.cgi?id=58682 + + * Scripts/webkitpy/layout_tests/layout_package/json_results.html: + * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: + * Scripts/webkitpy/layout_tests/port/base.py: + +2011-04-15 Andreas Kling <kling@webkit.org> + + Reviewed by Antonio Gomes. + + [Qt] DRT: Default custom policy delegate decision should be Ignore. + + If layoutTestController.setCustomPolicyDelegate() is called with only + one argument, the second ("permissive") should default to false. + + * DumpRenderTree/qt/LayoutTestControllerQt.h: + +2011-04-15 Ojan Vafai <ojan@chromium.org> + + Reviewed by Eric Seidel. + + fix path to layout test in new results file + https://bugs.webkit.org/show_bug.cgi?id=58618 + + * Scripts/webkitpy/layout_tests/layout_package/json_results.html: + * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: + +2011-04-15 Ojan Vafai <ojan@chromium.org> + + Reviewed by Eric Seidel. + + fix sorting in new results file + https://bugs.webkit.org/show_bug.cgi?id=58616 + + -Fix the custom sort to return -1, 0, 1 instead of true/false. + -Secondary sort by test name when sort values are equal. + -Sort by test name by default. + + * Scripts/webkitpy/layout_tests/layout_package/json_results.html: + +2011-04-15 Dmitry Lomov <dslomov@google.com> + + Reviewed by David Levin. + + check-webkit-style shouldn't complain about not including a primary header file + if none exists + https://bugs.webkit.org/show_bug.cgi?id=39514 + + * Scripts/webkitpy/style/checkers/cpp.py: + * Scripts/webkitpy/style/checkers/cpp_unittest.py: + +2011-04-15 Eric Seidel <eric@webkit.org> + + Reviewed by Mihai Parparita. + + queues.webkit.org should display when a bot last rebooted + https://bugs.webkit.org/show_bug.cgi?id=58562 + + There is more repeated code here than I would like. I fear + my django-fu isn't quite up to snuff. + + * QueueStatusServer/handlers/queuestatus.py: + * QueueStatusServer/templates/queuestatus.html: + +2011-04-14 Alok Priyadarshi <alokp@chromium.org> + + Reviewed by Adam Barth. + + Remove dependency on chromium skia::PlatformCanvas + https://bugs.webkit.org/show_bug.cgi?id=57563 + + Fixed compile error on Mac when using Core Graphics. + + * DumpRenderTree/chromium/WebViewHost.cpp: + (WebViewHost::paintRect): + +2011-04-14 Alok Priyadarshi <alokp@chromium.org> + + Reviewed by James Robinson. + + Remove dependency on chromium skia::PlatformCanvas + https://bugs.webkit.org/show_bug.cgi?id=57563 + + * DumpRenderTree/chromium/TestShell.cpp: + (makeCanvasOpaque): + (TestShell::dumpImage): + * DumpRenderTree/chromium/TestShell.h: + * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: + (WebThemeControlDRTWin::WebThemeControlDRTWin): + (WebThemeControlDRTWin::draw): + (WebThemeControlDRTWin::drawTextField): + (WebThemeControlDRTWin::drawProgressBar): + * DumpRenderTree/chromium/WebThemeControlDRTWin.h: + * DumpRenderTree/chromium/WebViewHost.cpp: + (WebViewHost::canvas): + * DumpRenderTree/chromium/WebViewHost.h: + +2011-04-14 Keith Kyzivat <keith.kyzivat@nokia.com> + + Reviewed by Laszlo Gombos. + + [Qt] Add -maximize flag to QtTestBrowser and MiniBrowser + https://bugs.webkit.org/show_bug.cgi?id=58007 + + Adds flag to start the test browsers maximized. + Symbian started maximized on QtTestBrowser - made MiniBrowser follow + suit. + Also fixes some ToggleFullScreen issues so that prior window state is + restored. + + * MiniBrowser/qt/BrowserWindow.cpp: + (BrowserWindow::BrowserWindow): + (BrowserWindow::toggleFullScreenMode): + * MiniBrowser/qt/MiniBrowserApplication.cpp: + (MiniBrowserApplication::handleUserOptions): + * MiniBrowser/qt/MiniBrowserApplication.h: + (WindowOptions::WindowOptions): + * QtTestBrowser/launcherwindow.cpp: + (LauncherWindow::init): + (LauncherWindow::toggleFullScreenMode): + * QtTestBrowser/launcherwindow.h: + (WindowOptions::WindowOptions): + * QtTestBrowser/main.cpp: + (LauncherApplication::handleUserOptions): + +2011-04-14 Ojan Vafai <ojan@chromium.org> + + Reviewed by Eric Seidel. + + add checkbox to only show unexpected results to new results file + https://bugs.webkit.org/show_bug.cgi?id=58606 + + * Scripts/webkitpy/layout_tests/layout_package/json_results.html: + +2011-04-13 Brent Fulgham <bfulgham@webkit.org> + + Reviewed by Martin Robinson. + + [WinCairo] Implement ImageDiff Logic. + http://bugs.webkit.org/show_bug.cgi?id=58486 + + * DumpRenderTree/win/ImageDiffCairo.cpp: Added. + (strtof): + (readFromData): + (createImageFromStdin): + (releaseMallocBuffer): + (createDifferenceImage): + (imageHasAlpha): + (writeToData): + (main): + * DumpRenderTree/win/ImageDiff.vcproj: Updated for new + ImageDiffCairo.cpp (excluding from Apple builds). + * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Use + new ImageDiffWinCairoCommon.vsprops file. + * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Use + new ImageDiffWinCairoCommon.vsprops file. + * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Added. + * Scripts/old-run-webkit-tests: Make sure proper executable + is built and executed for WinCairo port. + +2011-04-14 Ojan Vafai <ojan@chromium.org> + + Reviewed by Eric Seidel. + + only show expected failure type for ports that use an expectations file + https://bugs.webkit.org/show_bug.cgi?id=58588 + + * Scripts/webkitpy/layout_tests/layout_package/json_results.html: + * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: + +2011-04-14 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + commit-queue fails to catch IOError when results.html is missing + https://bugs.webkit.org/show_bug.cgi?id=58589 + + * Scripts/webkitpy/tool/commands/queues.py: + * Scripts/webkitpy/tool/commands/queues_unittest.py: + +2011-04-14 Kevin Ollivier <kevino@theolliviers.com> + + [wx] Unreviewed build fix for Mac installation script. + + * wx/packaging/build-mac-installer.py: + +2011-04-14 Ojan Vafai <ojan@chromium.org> + + Reviewed by Tony Chang. + + sort columns in the new json_results.html file + https://bugs.webkit.org/show_bug.cgi?id=58581 + + Also fix padding on TDs and the path to layout tests. + + * Scripts/webkitpy/layout_tests/layout_package/json_results.html: + +2011-04-14 Eric Seidel <eric@webkit.org> + + Reviewed by Dimitri Glazkov. + + queues.webkit.org should display when a bot last passed a patch + https://bugs.webkit.org/show_bug.cgi?id=58546 + + I am suspicious that some of our commit-queue instances are never + actually passing anything. + + This will let us know if those bots are never passing patches. + + * QueueStatusServer/handlers/queuestatus.py: + * QueueStatusServer/index.yaml: + * QueueStatusServer/templates/queuestatus.html: + +2011-04-14 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Adam Roben. + + REGRESSION (r83764): webkitpy.layout_tests.port.chromium_win_unittest.ChromiumWinTest.test_default_worker_model fails on apple-windows-13 + https://bugs.webkit.org/show_bug.cgi?id=58545 + + Remove platform-specific overrides; the default behavior should + be working everywhere now, I think. + + * Scripts/webkitpy/layout_tests/port/chromium_win.py: + * Scripts/webkitpy/layout_tests/port/mac.py: + +2011-04-14 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + commit-queues are hitting an exception trying to land when the tree is red + https://bugs.webkit.org/show_bug.cgi?id=58558 + + Just an un-tested (and thus broken) code path from yesterday's changes. + + * Scripts/webkitpy/common/net/layouttestresults.py: + * Scripts/webkitpy/common/net/layouttestresults_unittest.py: + * Scripts/webkitpy/tool/commands/queues.py: + * Scripts/webkitpy/tool/commands/queues_unittest.py: + +2011-04-14 Kevin Ollivier <kevino@theolliviers.com> + + [wx] Unreviewed build fixes for wxMSW and wx 2.9.1.1. + + * DumpRenderTree/wx/LayoutTestControllerWx.cpp: + (LayoutTestController::shadowRoot): + * wx/build/wxpresets.py: + +2011-04-14 Victoria Kirst <vrk@google.com> + + Reviewed by James Robinson. + + [chromium] Failing GPU video tests + https://bugs.webkit.org/show_bug.cgi?id=57926 + + Added/updated GPU directory names for rebaseline tool. + + * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: + +2011-04-13 Daniel Bates <dbates@rim.com> + + Reviewed by Adam Barth. + + Perl unit test removeEOL.pl should print test case name on failure + https://bugs.webkit.org/show_bug.cgi?id=58513 + + * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl: Pass $title as + second argument of Test::Simple::ok(). + +2011-04-13 Kent Tamura <tkent@chromium.org> + + Reviewed by Eric Seidel. + + gdb-safari should pass arguments to safari. + https://bugs.webkit.org/show_bug.cgi?id=58439 + + We can do: + gdb-safari --debug LayoutTests/.../foo.html + + * Scripts/gdb-safari: Passing @ARGV to Safari via gdb --arg. + +2011-04-13 Dirk Pranke <dpranke@chromium.org> + + Unreviewed, build fix. + https://bugs.webkit.org/show_bug.cgi?id=52763 + + r83799 broke test-webkitpy because it assumed we always have + access to a real filesystem (we don't during the unit tests). + Stubbing out the copy for now but we might need a better + solution at some point. + + * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: + +2011-04-13 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Tony Chang. + + new-run-webkit-tests --run-singly option is busted + https://bugs.webkit.org/show_bug.cgi?id=55909 + + Python's broken lexical scoping strikes again :(. + + * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py: + * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: + +2011-04-13 Ojan Vafai <ojan@chromium.org> + + Reviewed by Eric Seidel. + + generated unexpected_results.html from unexpected_results.json + https://bugs.webkit.org/show_bug.cgi?id=52763 + + Eventually, we'll merge this with results.html and have a single richer results page. + For now, I just want to get something checked in that we can iterate on. + + * Scripts/webkitpy/layout_tests/layout_package/json_results.html: Added. + * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: + +2011-04-13 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + Up the failure limit to allow the commit-queue to actually land when the tree is red + https://bugs.webkit.org/show_bug.cgi?id=58499 + + This change increases the --exit-after-N-failures limit used by the commit-queue + from 1 to 10. This will cause the code added in bug 58494 to actually get + exercised and the queues should start being able to land when the trees are red. + + When testing I found that test_runtests_leopard_commit_queue_hack_command was the + only unit test to actually detect this change! Since we don't actually + run on leopard anymore, I removed the hack code and repurposed the test. + + * Scripts/webkitpy/tool/bot/commitqueuetask.py: + * Scripts/webkitpy/tool/steps/runtests.py: + * Scripts/webkitpy/tool/steps/steps_unittest.py: + +2011-04-13 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + commit-queue should be able to land when tree is red + https://bugs.webkit.org/show_bug.cgi?id=58494 + + There is some yak hair on my hands, I will admit. + + This change is mostly about adding an ExpectedFailures + class to track when the bots are red and we should be + ignoring failures when landing from the commit-queue. + + However, to make intelligent decisions about patches we + need to know whether the run hit the --exit-after-N-failures limit + or not. Right now that information is not saved off in results.html + so we have to pull the information from RunTests. + + I've plumbed the --exit-after-N-failures information into + LayoutTestResults for now to make the ExpectedFailures code cleaner. + + As a result of adding all these additional calls to delegate.layout_test_results() + I broke some of our flaky test detection tests and had to re-write them + to not depend on the number of layout_test_results code. + + At the same time I updated the commit-queue to use the newer filesystem + API (to allow us to use MockFileSystem) which required further changes + to the layout tests. Changes were required in either case, since + we're now calling layout_test_results() in more cases, which previously + would try and hit the disk (until I moved it to use tool.filesystem). + + I should note that *all* of this code is disabled for now, since our + --exit-after-N-failures limit is currently 1! (Thus were always in the + case where we can't actually tell if the layout test results are legit.) + I will up that limit in a second patch (which may require a couple more unit test tweaks). + + * Scripts/webkitpy/common/net/layouttestresults.py: + * Scripts/webkitpy/tool/bot/commitqueuetask.py: + * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: + * Scripts/webkitpy/tool/bot/expectedfailures.py: Added. + * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py: Added. + * Scripts/webkitpy/tool/commands/queues.py: + * Scripts/webkitpy/tool/commands/queues_unittest.py: + * Scripts/webkitpy/tool/commands/queuestest.py: + * Scripts/webkitpy/tool/steps/runtests.py: + +2011-04-13 Brent Fulgham <bfulgham@webkit.org> + + Unreviewed build correction. + + * TestWebKitAPI/PlatformWebView.h: Limit include of + <CoreGraphics/CGGeometry> to PLATFORM(CG) users. + +2011-04-13 Mihai Parparita <mihaip@chromium.org> + + Reviewed by Eric Seidel. + + [NRWT] Rename --baseline-search-patch to --additional-platform-directory to match ORWT + https://bugs.webkit.org/show_bug.cgi?id=58489 + + r83743 added --additional-platform-directory to old-run-webkit-tests, + rename the equivalent flag in new-run-webkit-tests to be consistent. + + * Scripts/webkitpy/layout_tests/port/base.py: + * Scripts/webkitpy/layout_tests/port/base_unittest.py: + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: + +2011-04-13 Mihai Parparita <mihaip@chromium.org> + + Reviewed by Eric Seidel. + + Rebaseline queue server + https://bugs.webkit.org/show_bug.cgi?id=57891 + + Adds a simple rebaseline queue server (meant to run at + http://rebaseline-queue.appspot.com/). It presents a list of all (NRWT) + builders and their failing tests, and allows those tests to be added to + a per-builer rebaseline queue. + + A subsequent change will add a mode to NRWT (and/or a wrapper script) + for pulling the tests to be rebaselined from the server and running them + with --reset-results (the initial use-case is for the GPU hardware bots, + which do not have checked-in baselines, therefore there is no need for a + check-in step yet). + + * RebaselineQueueServer/app.yaml: Added. + * RebaselineQueueServer/handlers/__init__.py: Added. + * RebaselineQueueServer/handlers/builderqueue.py: Added. + * RebaselineQueueServer/handlers/pages.py: Added. + * RebaselineQueueServer/index.yaml: Added. + * RebaselineQueueServer/main.py: Added. + * RebaselineQueueServer/model/__init__.py: Added. + * RebaselineQueueServer/model/queueentry.py: Added. + * RebaselineQueueServer/static/builder-frame-empty.html: Added. + * RebaselineQueueServer/static/styles.css: Added. + * RebaselineQueueServer/templates/builder-picker.html: Added. + * RebaselineQueueServer/templates/builder-queue-edit.html: Added. + * RebaselineQueueServer/templates/builder-queue-list.html: Added. + * RebaselineQueueServer/templates/home.html: Added. + +2011-04-13 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Mihai Parparita. + + nrwt: enable multiple processes by default on Chromium Win. + https://bugs.webkit.org/show_bug.cgi?id=55163 + + Re-land r79268; it should be more stable now and will hopefully + work. + + * Scripts/webkitpy/layout_tests/port/chromium_win.py: + * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: + +2011-04-13 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Ojan Vafai. + + new-run-webkit-tests: configure logging in child processes properly + https://bugs.webkit.org/show_bug.cgi?id=58296 + + Logging propagated properly from manager to worker processes on + Unix but not on Windows; this fixes that. + + * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py: + * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py: + +2011-04-13 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Ojan Vafai. + + new-run-webkit-tests: suppress extraneous pretty patch warnings + https://bugs.webkit.org/show_bug.cgi?id=58295 + + NRWT wasn't being careful about when it logged messages from + PrettyPatch not being available; it should only log during + check_build(), and be silent otherwise. This was causing us to + get multiple errors at runtime, which was confusing. + + * Scripts/webkitpy/layout_tests/port/base.py: + * Scripts/webkitpy/layout_tests/port/base_unittest.py: + * Scripts/webkitpy/layout_tests/port/chromium.py: + +2011-04-13 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Jian Li. + + add chromium-linux-x86_64 to rebaseline-chromium-webkit-tests + https://bugs.webkit.org/show_bug.cgi?id=58461 + + * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: + +2011-04-13 Tony Chang <tony@chromium.org> + + Unreviewed, fix NRWT. Stack: + + return super(ChromiumPort, self).results_directory(self) + TypeError: results_directory() takes exactly 1 argument (2 given) + + * Scripts/webkitpy/layout_tests/port/chromium.py: + +2011-04-13 Adam Roben <aroben@apple.com> + + Teach ORWT about extra platform-specific directories to be searched before the default ones + + Fixes <http://webkit.org/b/58446> ORWT needs a way to look in a user-specified directory for + platform-specific results + + Reviewed by Anders Carlsson. + + * Scripts/old-run-webkit-tests: + (top-level): Added @additionalPlatformDirectories and hooked up + --additional-platform-directories to populate it. + (buildPlatformResultHierarchy): Prepend the additional platform directories to the default + list (after filtering out any of the additional directories that don't exist). + +2011-04-13 Lucas Forschler <lforschler@apple.com> + + Reviewed by Adam Roben. + + Add the /T command to taskkill.exe. + This will kill spawned child processes. + + * BuildSlaveSupport/win/kill-old-processes: + +2011-04-13 Lucas Forschler <lforschler@apple.com> + + Reviewed by Adam Roben. + + Sort kill list alphabeticaly. + Fixed capitalization on VcBuildHelper. + + * BuildSlaveSupport/win/kill-old-processes: + +2011-04-13 Lucas Forschler <lforschler@apple.com> + + Reviewed by Adam Roben. + + https://bugs.webkit.org/show_bug.cgi?id=58384 + Update kill-old-processes to include a few new ones. + + * BuildSlaveSupport/win/kill-old-processes: + +2011-04-13 Gustavo Noronha Silva <gns@gnome.org> + + Reviewed by Martin Robinson. + + [GTK] PluginPackage should check whether a plugin mixes GTK+ 2 and 3 symbols itself + https://bugs.webkit.org/show_bug.cgi?id=58297 + + Do not disable flash specifically when built with GTK+ 3 - + PluginPackage should do the right thing while loading plugins. + + * GtkLauncher/main.c: + (main): + +2011-04-12 Kent Tamura <tkent@chromium.org> + + Reviewed by Dimitri Glazkov. + + [Chromium] Add WebSettings::setValidationMessageTimerMagnification() + https://bugs.webkit.org/show_bug.cgi?id=57426 + + * DumpRenderTree/chromium/WebPreferences.cpp: + (WebPreferences::applyTo): Disable the validation message timer. + +2011-04-12 James Kozianski <koz@chromium.org> + + Unreviewed. + + Adding myself to committers.py. + + * Scripts/webkitpy/common/config/committers.py: + +2011-04-12 Brent Fulgham <bfulgham@webkit.org> + + Unreviewed build correction for WinCairo bot after r83639. + https://bugs.webkit.org/show_bug.cgi?id=51790 + + Correct typo for the new "update-webkit-wincairo-libs" script. + + * Scripts/build-webkit: Incorrectly calling the + update-webkit-cairo-libs which does not exist. + +2011-04-12 Alice Liu <alice.liu@apple.com> + + Reviewed by Jon Honeycutt. + + A change that should have been part of http://trac.webkit.org/changeset/83628 + + * DumpRenderTree/win/DumpRenderTree.cpp: + (resetDefaultsToConsistentValues): Setting should be off for most tests. Reset to false. + +2011-04-12 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Tony Chang. + + new-run-webkit-tests: --results-directory is relative to builddir, not $PWD + https://bugs.webkit.org/show_bug.cgi?id=58272 + + NRWT was interpreting the --results-directory cmd line arg as + relative to the build directory, not the current working + directory (ORWT uses the latter, which is much more intuitive). + + This patch fixes the base case, but includes an override for + Chromium that is needed until the bots can be updated. + + * Scripts/webkitpy/layout_tests/port/base.py: + * Scripts/webkitpy/layout_tests/port/base_unittest.py: + * Scripts/webkitpy/layout_tests/port/chromium.py: + * Scripts/webkitpy/layout_tests/port/port_testcase.py: + * Scripts/webkitpy/layout_tests/port/test.py: + * Scripts/webkitpy/layout_tests/port/webkit.py: + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: + +2011-04-12 Philippe Normand <pnormand@igalia.com> + + Unreviewed, roll out r83621 as it broke the GTK build. + + [GTK] arguments passed to build-jsc and build-webkit scripts are not taken into account + https://bugs.webkit.org/show_bug.cgi?id=58333 + + * Scripts/build-jsc: + * Scripts/build-webkit: + +2011-04-12 Carl Lobo <carllobo@gmail.com> and Brent Fulgham <bfulgham@webkit.org> + + Reviewed by Adam Roben. + + Patch to download the WinCairo dependancies as part of build-webkit. + https://bugs.webkit.org/show_bug.cgi?id=51790 + + This patch downloads the dependancies from + http://idisk.mac.com/bfulgham-Public/WinCairoRequirements.zip + checking the modification timestamp etc. + + * Tools/Scripts/build-webkit + * Tools/Scripts/update-webkit: Modified to understand the --wincairo + flag, and to update WinCairo dependencies when used. + * Tools/Scripts/update-webkit-cairo-libs: added + * Tools/Scripts/update-webkit-dependency: added + * Tools/Scripts/update-webkit-auxiliary-libs + +2011-04-12 Jeff Miller <jeffm@apple.com> + + Reviewed by Adam Roben. + + WebKit2: Pressing Tab in Web Inspector's console does not cycle through completion options + https://bugs.webkit.org/show_bug.cgi?id=56020 + + Don't call TranslateMessage() in the MiniBrowser or TestWebKitAPI for key messages destined for a WebKit2 view, + since WebKit will do this for us. If we didn't do this, TranslateMessage() would be called twice, + which would generate two characters for every keypress (for example). I didn't bother doing this for + WebKitTestRunner, since it doesn't get any WM_KEYDOWN events. + + Add new WebKit2/TranslateMessageGeneratesWMChar test to test expected TranslateMessage() behavior. + + * MiniBrowser/win/main.cpp: + (shouldTranslateMessage): Added. + (_tWinMain): Don't call TranslateMessage() unless shouldTranslateMessage() says to. + * TestWebKitAPI/PlatformUtilities.h: Added shouldTranslateMessage() on Windows. + * TestWebKitAPI/PlatformWebView.h: Added simulateAKeyDown(). + * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp: Added. + (TestWebKitAPI::didNotHandleKeyEventCallback): Added. + (TestWebKitAPI::runAndWatchForWMChar): Added. + (TestWebKitAPI::TEST): Added. + * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: + (TestWebKitAPI::Util::run): Don't call TranslateMessage() unless shouldTranslateMessage() says to. + (TestWebKitAPI::Util::shouldTranslateMessage): Added. + * TestWebKitAPI/win/PlatformWebViewWin.cpp: + (TestWebKitAPI::PlatformWebView::simulateAKeyDown): Added. + * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added TranslateMessageGeneratesWMChar.cpp. + +2011-04-12 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Tony Chang. + + new-run-webkit-tests: update code to use port.results_directory() instead of options.results_directory + https://bugs.webkit.org/show_bug.cgi?id=58290 + + This is some preliminary refactoring for bug 58272. + + * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: + * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: + * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: + * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py: + * Scripts/webkitpy/layout_tests/port/test.py: + * Scripts/webkitpy/layout_tests/port/chromium.py: + * Scripts/webkitpy/layout_tests/port/base.py: + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + +2011-04-12 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Eric Seidel. + + webkitpy: fix mock_filesystem abspath to handle relative paths + and add filesystem.chdir() and filesystem.getcwd() to be able + to test this and mock it out. + + https://bugs.webkit.org/show_bug.cgi?id=58288 + + * Scripts/webkitpy/common/system/filesystem.py: + * Scripts/webkitpy/common/system/filesystem_mock.py: + * Scripts/webkitpy/common/system/filesystem_unittest.py: + +2011-04-12 Alice Liu <alice.liu@apple.com> + + Reviewed by Sam Weinig. + + https://bugs.webkit.org/show_bug.cgi?id=58292 + Provide new setting to allow site icon loading despite disabling automatic image loading in general. + + * DumpRenderTree/mac/DumpRenderTree.mm: + (resetDefaultsToConsistentValues): Setting should be off for most tests. Reset to false. + +2011-04-12 Thouraya ANDOLSI <thouraya.andolsi@st.com> + + Reviewed by Eric Seidel. + + [Qt] Enable JIT build for SH4 platforms. + https://bugs.webkit.org/show_bug.cgi?id=58317 + + + * DumpRenderTree/qt/DumpRenderTree.pro: + * QtTestBrowser/QtTestBrowser.pro: + * Scripts/webkitdirs.pm: + +2011-04-12 Tony Chang <tony@chromium.org> + + Reviewed by Andreas Kling. + + [Qt] embed checksums in PNGs written by Qt-DRT + https://bugs.webkit.org/show_bug.cgi?id=58173 + + * DumpRenderTree/qt/DumpRenderTreeQt.cpp: + (WebCore::DumpRenderTree::dump): + +2011-04-12 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + commit-queue should upload failure diffs when tests fail + https://bugs.webkit.org/show_bug.cgi?id=58348 + + This change was mostly just plumbing. We were already saving + this information for flaky test reporting. I just made it possible + for normal failures to report archives as well. + + I did a little abstraction work to try and share some code between + flakytestreporter.py and this new code. There is still more we could do. + + In making this change I also went through and updated the various + places we have urls hard-coded in our python and pointed them at + common.config.urls. + + * Scripts/webkitpy/common/checkout/scm.py: + * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: + * Scripts/webkitpy/common/net/buildbot/buildbot.py: + * Scripts/webkitpy/common/net/statusserver.py: + * Scripts/webkitpy/layout_tests/port/base.py: + * Scripts/webkitpy/tool/bot/botinfo.py: Added. + * Scripts/webkitpy/tool/bot/botinfo_unittest.py: Added. + * Scripts/webkitpy/tool/bot/commitqueuetask.py: + * Scripts/webkitpy/tool/bot/flakytestreporter.py: + * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: + * Scripts/webkitpy/tool/commands/queues.py: + +2011-04-12 Daniel Bates <dbates@rim.com> + + Rubber-stamped by Eric Seidel. + + svn-apply and/or patch(1) has trouble applying patches that makes changes to files + with Windows line endings + https://bugs.webkit.org/show_bug.cgi?id=53625 + + Fixes an issue where a patch made on a SCM checkout on a Unix file system cannot be + applied to an SCM checkout on a Windows file system and vice-versa. + + This issue manifests itself due to custom SCM settings as well as differences in + gitattributes support in older versions of Git (e.g. 1.7.0.3). We implement support + into svn-apply/unapply to compensate for differences in line endings by converting + the line endings in a patch to match the line endings in the target file (if it exists). + + * Scripts/VCSUtils.pm: + - Added parseFirstEOL(), which returns the first end-of-line character(s) that appear in the + content read from the specified file handle. Obviously, this heuristic will not work + for files with mixed line endings, but I don't envision such files to be the norm. If + this turns out to be an issue then we can improve the heuristic. + - Added firstEOLInFile(). + - Modified parsePatch() and parseDiff() to take an optional hash reference to an options hash. + In particular, added the hash key shouldNotUseIndexPathEOL to control whether to use the line + endings in the diff instead of the line endings in the target file. + - Extracted local variable $chunkRangeRegEx from fixChangeLogPatch() so that it can be + re-used in parseDiff(). + * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Modified to pass {shouldNotUseIndexPathEOL => 1} + to parsePatch() since these unit tests don't create mock files. Instead, created unit tests that use + mock files in file VCSUtils_unittest/parseDiffWithMockFiles.pl. + * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl: Added. + * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl: Added. + +2011-04-12 Sam Weinig <sam@webkit.org> + + Reviewed by Adam Roben. + + REGRESSION (r83550): Multiple http tests crashing in the web process in SQLite beneath CFNetwork on Windows 7 Release (WebKit2 Tests) + https://bugs.webkit.org/show_bug.cgi?id=58336 + + * WebKitTestRunner/TestController.cpp: + (WTR::TestController::resetStateToConsistentValues): + Remove cache clearing as that is causing tests to crash on Windows 7. + +2011-04-11 Sam Weinig <sam@webkit.org> + + Reviewed by Anders Carlsson. + + REGRESSION(r77974): http/tests/security/aboutBlank/security-context-window-open.html is failing + <rdar://problem/8981346> + https://bugs.webkit.org/show_bug.cgi?id=54159 + + * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: + (WTR::InjectedBundlePage::InjectedBundlePage): + (WTR::InjectedBundlePage::decidePolicyForNavigationAction): + (WTR::InjectedBundlePage::decidePolicyForNewWindowAction): + (WTR::InjectedBundlePage::decidePolicyForResponse): + (WTR::InjectedBundlePage::unableToImplementPolicy): + * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: + Add short-circuited policy client which matches WebKit1. + + * WebKitTestRunner/TestController.cpp: + (WTR::TestController::resetStateToConsistentValues): + Clear the cache between tests to ensure consistent results. + +2011-04-11 George Guo <George.Guo@nokia.com> + + Reviewed by Eric Seidel. + + prepare-ChangeLog support email input but -h did not show the option + https://bugs.webkit.org/show_bug.cgi?id=58164 + + Add email option to -h to improve the usability + + * Scripts/prepare-ChangeLog: + +2011-04-11 Dimitri Glazkov <dglazkov@chromium.org> + + Reviewed by Eric Carlson. + + Rename MediaControls to MediaControlRootElement. + https://bugs.webkit.org/show_bug.cgi?id=58250 + + * Scripts/do-webcore-rename: Documented the renaming. + +2011-04-11 Sam Weinig <sam@webkit.org> + + Fix Windows build. + + * MiniBrowser/win/BrowserView.cpp: + (BrowserView::create): + +2011-04-11 Sam Weinig <sam@webkit.org> + + Reviewed by Anders Carlsson. + + Move focus management out of WebKit via the UIClient + <rdar://problem/8784068> + https://bugs.webkit.org/show_bug.cgi?id=58278 + + * MiniBrowser/mac/BrowserWindowController.m: + (-[BrowserWindowController awakeFromNib]): + * WebKitTestRunner/TestController.cpp: + (WTR::TestController::createOtherPage): + (WTR::TestController::initialize): + Add stubs for new UIClient functions. + +2011-02-03 Martin Robinson <mrobinson@igalia.com> + + Reviewed by Eric Seidel. + + [GTK] The GTK+ DRT needs an implementation of the PlainTextController + https://bugs.webkit.org/show_bug.cgi?id=53605 + + Add an implementation of the PlainTextController for the GTK+ DRT. + + * DumpRenderTree/gtk/DumpRenderTree.cpp: + (addControllerToWindow): Added this helper method. + (webViewWindowObjectCleared): Use the new helper to add EventSender + and the PlainTextController to the window object. + * GNUmakefile.am: Added PlainTextController source files. + * DumpRenderTree/gtk/PlainTextController.cpp: Added. This will rely + on DumpRenderTreeSupportGtk to convert a JSValueRef into a WebKitDOMRange + until that functionality exists somewhere in the WebKitGTK+ stack. + * DumpRenderTree/gtk/PlainTextController.h: Added. + +2011-04-11 Yael Aharon <yael.aharon@nokia.com> + + Unreviewed. + + Adding my IRC nick. + + * Scripts/webkitpy/common/config/committers.py: + +2011-04-11 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Adam Roben. + + new-run-webkit-tests: fix crash when running under windows cmd.exe + https://bugs.webkit.org/show_bug.cgi?id=58197 + + We would intermittently crash when running NRWT directly under + cmd.exe on windows because we were sharing the stdin file + descriptor between the python process and the http server. + cmd.exe really didn't like that, and there was no reason to + share the descriptor, so we now use a PIPE instead. + + * Scripts/webkitpy/layout_tests/port/http_server.py: + +2011-04-11 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Ojan Vafai. + + new-run-webkit-tests: add unit tests for Port.diff_image() + https://bugs.webkit.org/show_bug.cgi?id=58196 + + Add the unit tests for the fix in bug 58195. + + * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: + * Scripts/webkitpy/layout_tests/port/port_testcase.py: + * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: + +2011-04-11 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Tony Chang. + + new-run-webkit-tests: implement support for audio, take two + https://bugs.webkit.org/show_bug.cgi?id=58195 + + Attempt to re-land the fix for bug 58101 (which was initially + landed in r83330, but rolled out). This is the same patch but + fixes crashes in Port.diff_image() caused by the change for + empty image files being None instead of ''. + + * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: + * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: + * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: + * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: + * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: + * Scripts/webkitpy/layout_tests/port/base.py: + * Scripts/webkitpy/layout_tests/port/chromium.py: + * Scripts/webkitpy/layout_tests/port/dryrun.py: + * Scripts/webkitpy/layout_tests/port/mock_drt.py: + * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: + * Scripts/webkitpy/layout_tests/port/test.py: + * Scripts/webkitpy/layout_tests/port/webkit.py: + +2011-04-11 Mario Sanchez Prada <msanchez@igalia.com> + + Reviewed by Xan Lopez. + + [GTK] Implement AccessibilityUIElement::{row|column}IndexRange in DRT + https://bugs.webkit.org/show_bug.cgi?id=57854 + + Implement missing features in GTK's DRT. + + * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: + (indexRangeInTable): New helper function to get the range string + for the current cell inside the parent table, either from the + point of view of rows or columns. + (AccessibilityUIElement::rowIndexRange): Implemented by relying on + the new helper function indexRangeInTable(). + (AccessibilityUIElement::columnIndexRange): Ditto. + +2011-04-11 Mario Sanchez Prada <msanchez@igalia.com> + + Reviewed by Chris Fleizach. + + [GTK] Implement AccessibilityUIElement::cellForColumnAndRow in DRT + https://bugs.webkit.org/show_bug.cgi?id=57826 + + Implement missing feature in GTK's DRT. + + * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: + (AccessibilityUIElement::cellForColumnAndRow): Implemented, by + relying on the analogous function from the AtkTable interface. + +2011-04-05 Timothy Hatcher <timothy@apple.com> + + Fix the extract-localizable-strings script errors that started after + WEB_UI_STRING was added to LocalizedStrings.h in WebCore. + + * Scripts/extract-localizable-strings: Skip LocalizedStrings.h. + +2011-04-11 Tony Chang <tony@chromium.org> + + Reviewed by Eric Seidel. + + fix crc computation on 64 bit machines + https://bugs.webkit.org/show_bug.cgi?id=58243 + + unsigned long is dependenct on CPU architecture, so use unsigned which is always 32 bits + + * DumpRenderTree/CyclicRedundancyCheck.cpp: + (makeCrcTable): + (computeCrc): + * DumpRenderTree/CyclicRedundancyCheck.h: + * DumpRenderTree/PixelDumpSupport.cpp: + (appendIntToVector): + (convertChecksumToPNGComment): + +2011-04-10 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com> + + Reviewed by Eric Seidel. + + Require no undefined symbols during compilation. + + [Qt] [WK2] WebKitTestRunner, QtWebProcess and WTRInjectBundle should fail to compile when there's undefined symbols + https://bugs.webkit.org/show_bug.cgi?id=54896 + + Add -Wl,--no-undefined to catch missing symbols early. + + * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: + * WebKitTestRunner/qt/WebKitTestRunner.pro: + +2011-04-10 Kevin Ollivier <kevino@theolliviers.com> + + [wx] Unreviewed build fix. Remove collector dirs from the list of build dirs. + + * wx/build/settings.py: + +2011-04-10 Kevin Ollivier <kevino@theolliviers.com> + + [wx] Unreviewed build fix. Add Source/JavaScriptCore/heap to the list of directories. + + * wx/build/settings.py: + +2011-04-10 David Levin <levin@chromium.org> + + Reviewed by Dimitri Glazkov. + + REGRESSION(r83384): Change to chromium.py is resulting in failures of the test framework on linux. + https://bugs.webkit.org/show_bug.cgi?id=58201 + + * Scripts/webkitpy/layout_tests/port/chromium.py: Commented out the assert for now, + and filed bug 58202. + +2011-04-09 David Levin <levin@chromium.org> + + Unreviewed, rolling out r83394. + http://trac.webkit.org/changeset/83394 + https://bugs.webkit.org/show_bug.cgi?id=53625 + + Patch was incorrect as noted in the bug. + + * Scripts/svn-apply: + +2011-04-09 David Levin <levin@chromium.org> + + Reviewed by Adam Barth. + + svn-apply and/or patch(1) has trouble applying patches that makes changes to files with Windows line endings + https://bugs.webkit.org/show_bug.cgi?id=53625 + + * Scripts/svn-apply: Ensure that the portions of patches + which are for vcproj/vsprops files has DOS line endings. + +2011-04-09 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Tony Chang. + + It looks like NRWT has not been stopping DRT/TestShell + instances properly on windows, probably for a long time. + This would go a long way to explaining why we often have + processes lying around :) + + https://bugs.webkit.org/show_bug.cgi?id=57807 + + * Scripts/webkitpy/layout_tests/port/chromium.py: + * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: + +2011-04-09 Keith Kyzivat <keith.kyzivat@nokia.com> + + Reviewed by Laszlo Gombos. + + [Qt] Don't link against fontconfig or X11 if embedded + https://bugs.webkit.org/show_bug.cgi?id=58104 + + * DumpRenderTree/qt/DumpRenderTree.pro: fontconfig !included in embedded + * QtTestBrowser/QtTestBrowser.pro: ditto + * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: ditto + * WebKitTestRunner/qt/WebKitTestRunner.pro: ditto + +2011-04-08 Jon Honeycutt <jhoneycutt@apple.com> + + http/tests/loading/preload-append-scan.php is failing on Windows + https://bugs.webkit.org/show_bug.cgi?id=58178 + + Reviewed by Brian Weinstein. + + * DumpRenderTree/win/DumpRenderTree.cpp: + (lastPathComponent): + Use CFURL API to find the last path component, rather than + PathFindFileName(), because the latter will include the query string. + +2011-04-08 Jian Li <jianli@chromium.org> + + Unreviewed, rolling out r83327, r83330 since these patches are very + likely to break chromium webkit mac10.6 builders. + + * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: + * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: + * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: + * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: + * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: + * Scripts/webkitpy/layout_tests/port/base.py: + * Scripts/webkitpy/layout_tests/port/chromium.py: + * Scripts/webkitpy/layout_tests/port/dryrun.py: + * Scripts/webkitpy/layout_tests/port/mock_drt.py: + * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: + * Scripts/webkitpy/layout_tests/port/test.py: + * Scripts/webkitpy/layout_tests/port/webkit.py: + +2011-04-08 Vincent Scheib <scheib@chromium.org> + + Reviewed by Eric Seidel. + + add chromium-gpu-linux-x86_64 to the recognized list of ports + https://bugs.webkit.org/show_bug.cgi?id=58099 + + Add chromium-gpu-linux-x86_64 to fix assert. + + * Scripts/webkitpy/layout_tests/port/chromium_linux.py: + +2011-04-08 Alpha Lam <hclam@chromium.org> + + Unreviewed, rolling out r83335. + http://trac.webkit.org/changeset/83335 + https://bugs.webkit.org/show_bug.cgi?id=53556 + + GTK and QT bots are broken + + * Scripts/build-webkit: + +2011-04-07 Anna Cavender <annacc@chromium.org> + + Reviewed by Eric Carlson. + + Setup ENABLE(TRACK) feature define + https://bugs.webkit.org/show_bug.cgi?id=53556 + + * Scripts/build-webkit: + +2011-04-08 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Adam Roben. + + new-run-webkit-tests: configure a NRWT test bot for Mac SL + https://bugs.webkit.org/show_bug.cgi?id=58114 + + This change removes the old new-run-webkit-tests entry and + updates it for a new test-only bot. + + * BuildSlaveSupport/build.webkit.org-config/config.json: + +2011-04-08 Dominic Cooney <dominicc@google.com> + + Reviewed by Adam Roben. + + Make layoutTestController.shadowRoot return null, not undefined, + when its argument is invalid. + https://bugs.webkit.org/show_bug.cgi?id=58121 + + * DumpRenderTree/mac/LayoutTestControllerMac.mm: + (LayoutTestController::shadowRoot): + * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: + (WTR::LayoutTestController::shadowRoot): + +2011-04-08 Pere Martir <pere.martir4@gmail.com> + + Reviewed by Adam Roben. + + Locate NSTD.EXE in 64-bit Windows + https://bugs.webkit.org/show_bug.cgi?id=57847 + + * Scripts/old-run-webkit-tests: + +2011-04-08 Adam Roben <aroben@apple.com> + + Qt build fix + + * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Pull in stdarg.h for va_list. + +2011-04-07 Adam Roben <aroben@apple.com> + + Test that NPP_SetWindow is passed a null window handle during plugin destruction on non-Mac platforms + + Test for <http://webkit.org/b/47009> WebKit2 needs to call NPP_SetWindow when destroying a + plugin + + Reviewed by Anders Carlsson. + + * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: + (pluginLogWithArguments): Moved code to format and log the message here... + (pluginLog): ...from here. + + * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Added pluginLogWithArguments. + + * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: + (PluginTest::log): Added. Calls through to pluginLogWithArguments. + + * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added log. + + * DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp: Added. + (NPPSetWindowCalledDuringDestruction::setWillBeDestroyed): Records that destruction is about + to begin. + (NPPSetWindowCalledDuringDestruction::NPPSetWindowCalledDuringDestruction): Simple + constructor. + (NPPSetWindowCalledDuringDestruction::NPP_GetValue): Creates and returns a ScriptObject that + can be used to invoke our setWillBeDestroyed function. + (NPPSetWindowCalledDuringDestruction::NPP_SetWindow): Records what has happened (and logs if + anything unexpected happens). + (NPPSetWindowCalledDuringDestruction::NPP_Destroy): On Mac, logs a failure message if + NPP_SetWindow was called during destruction. On other platforms, logs a failure message if + NPP_SetWindow was *not* called during destruction. + (NPPSetWindowCalledDuringDestruction::ScriptObject::hasMethod): Return true for our only + method, setWillBeDestroyed. + (NPPSetWindowCalledDuringDestruction::ScriptObject::invoke): Call through to the PluginTest + object. + + * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: + * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: + * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: + * GNUmakefile.am: + Added new test. + + * Scripts/old-run-webkit-tests: Skip the new test when using out-of-process plugins with + WebKit1 on Mac, since it can't work properly due to <http://webkit.org/b/58077>. + +2011-04-08 Mario Sanchez Prada <msanchez@igalia.com> + + Reviewed by Martin Robinson. + + [GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement + https://bugs.webkit.org/show_bug.cgi?id=58039 + + Implement missing functions in GTK's DRT. + + * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: + (AccessibilityUIElement::increment): Implemented. + (AccessibilityUIElement::decrement): Implemented. + +2011-04-08 Dominic Cooney <dominicc@google.com> + + Reviewed by Kent Tamura. + + Make WK2 layoutTestController.shadowRoot return undefined, not + null, when its argument is not an element. + https://bugs.webkit.org/show_bug.cgi?id=58121 + + * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: + (WTR::LayoutTestController::shadowRoot): + +2011-04-07 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Mihai Parparita. + + Change reference port for Mac GPU baselines from + Leopard to SnowLeopard, XP to Win7, and Linux-x86 + to Linux x86-64. + + https://bugs.webkit.org/show_bug.cgi?id=58099 + + * Scripts/webkitpy/layout_tests/port/chromium.py: + +2011-04-07 Andrew Scherkus <scherkus@chromium.org> + + Revert ENABLE_TRACK patch due to compile failures. + + * Scripts/build-webkit: + +2011-04-07 Tony Chang <tony@chromium.org> + + Reviewed by Eric Seidel. + + update DRT to embed checksums in png files + https://bugs.webkit.org/show_bug.cgi?id=57871 + + We insert the bytes for the comment in printPNG rather than at encode + time because each platform does its own PNG encoding (either using CG + or cairo). Putting this in pringPNG avoids having to duplicate this + code, although it's not as clean as doing it at encoding time. + + We insert the comment right after the IHDR chunk of the PNG. + + * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: + * DumpRenderTree/CyclicRedundancyCheck.cpp: Added. + (makeCrcTable): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js + (computeCrc): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js + * DumpRenderTree/CyclicRedundancyCheck.h: Added. + * DumpRenderTree/PixelDumpSupport.cpp: + (dumpWebViewAsPixelsAndCompareWithExpected): + (convertChecksumToPNGComment): Generate the bytes to insert. + (printPNG): Insert the png comment before the first IDAT section. + * DumpRenderTree/PixelDumpSupport.h: + * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp: + (printPNG): + (dumpBitmap): + * DumpRenderTree/cg/PixelDumpSupportCG.cpp: + (printPNG): + (dumpBitmap): + * DumpRenderTree/win/DumpRenderTree.vcproj: + * GNUmakefile.am: + +2011-04-07 Jeff Miller <jeffm@apple.com> + + Reviewed by Adam Roben. + + Replace WKStringGetCharactersPtr() with WKStringGetCharacters() + https://bugs.webkit.org/show_bug.cgi?id=58058 + + * TestWebKitAPI/Tests/WebKit2/WKString.cpp: + (TestWebKitAPI::TEST): Add tests for WKStringGetLength() and WKStringGetCharactersPtr(). + +2011-04-07 Chang Shu <cshu@webkit.org> + + Reviewed by Darin Adler. + + WebKitTestRunner needs layoutTestController.isPageBoxVisible + https://bugs.webkit.org/show_bug.cgi?id=42695 + + * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: + * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: + (WTR::LayoutTestController::isPageBoxVisible): + * WebKitTestRunner/InjectedBundle/LayoutTestController.h: + +2011-04-07 Adam Roben <aroben@apple.com> + + Build fix + + * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added a missing import. + +2011-04-07 Adam Roben <aroben@apple.com> + + Move ExtractTestResults[AndLeaks]'s summarizing code back from commandComplete() to finished() + + commandComplete() is never called for MasterShellCommands like ExtractTestResults[AndLeaks]. + (Unfortunately the buildbot documentation does not make this clear.) finished() is the only + hook we have, so we have to do our work there. I added a new addCustomURLs method which can + be overridden by subclasses to provide extra URLs before we call up to the base class (after + which adding more URLs is no longer possible). + + Really hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks + bot results page + + Reviewed by John Sullivan. + + * BuildSlaveSupport/build.webkit.org-config/master.cfg: + (ExtractTestResults.addCustomURLs): Moved code to add the "view results" URL here... + (ExtractTestResults.finished): ...from here. This replaces commandComplete, since that + method is never called for MasterShellCommands. + (ExtractTestResultsAndLeaks.addCustomURLs): Replaced commandComplete (which is never called) + with this method (which is). + +2011-04-07 Adam Roben <aroben@apple.com> + + Move ExtractTestResults[AndLeaks]'s summarizing code from finished() to commandComplete() + + This matches how most of our other build steps work, so is good just for improving + consistency between build steps. It should also make it possible for + ExtractTestResultsAndLeaks to successfully add a URL to Leaks Viewer. (Previously we were + trying to do this in finished() after we had called up to the base class, but that was + apparently too late to add more URLs.) + + Hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot + results page + + Reviewed by John Sullivan. + + * BuildSlaveSupport/build.webkit.org-config/master.cfg: + (ExtractTestResults): Added a descriptionDone property so that we don't have to manually + call setText to get the right text to show up for this step. This matches how most of our + other build steps work. + (ExtractTestResults.commandComplete): Replaced our override of finished with this function. + This is how most of our other build steps work. + (ExtractTestResultsAndLeaks.commandComplete): Replaced our override of finished with this + function, to match the base class. + +2011-04-07 Adam Barth <abarth@webkit.org> + + Reviewed by Maciej Stachowiak. + + webkit-patch shouldn't state the whole working copy when calling check-webkit-style + https://bugs.webkit.org/show_bug.cgi?id=58022 + + Previously, we were ignoring the args variable! This patch fixes the + regression introduced in http://trac.webkit.org/changeset/82771. + + * Scripts/webkitpy/tool/commands/download_unittest.py: + * Scripts/webkitpy/tool/mocktool.py: + * Scripts/webkitpy/tool/steps/checkstyle.py: + +2011-04-07 Maciej Stachowiak <mjs@apple.com> + + Reviewed by Adam Barth. + + REGRESSION: "webkit-patch land" doesn't work correctly in SVN subdirectories + https://bugs.webkit.org/show_bug.cgi?id=58017 + + * Scripts/webkitpy/common/checkout/scm.py: + * Scripts/webkitpy/common/checkout/scm_unittest.py: + +2011-04-06 Chang Shu <cshu@webkit.org> + + Reviewed by Darin Adler. + + WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels + https://bugs.webkit.org/show_bug.cgi?id=57984 + + * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: + * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: + (WTR::LayoutTestController::pageSizeAndMarginsInPixels): + * WebKitTestRunner/InjectedBundle/LayoutTestController.h: + +2011-04-06 Chris Rogers <crogers@google.com> + + Reviewed by Tony Chang. + + Add web audio support to DumpRenderTree (mac port) + https://bugs.webkit.org/show_bug.cgi?id=57969 + + * DumpRenderTree/LayoutTestController.cpp: + (LayoutTestController::LayoutTestController): + (setEncodedAudioDataCallback): + (LayoutTestController::staticFunctions): + * DumpRenderTree/LayoutTestController.h: + (LayoutTestController::dumpAsAudio): + (LayoutTestController::setDumpAsAudio): + (LayoutTestController::encodedAudioData): + (LayoutTestController::setEncodedAudioData): + * DumpRenderTree/mac/DumpRenderTree.mm: + (dumpAudio): + (dump): + +2011-04-06 Benjamin Poulain <benjamin.poulain@nokia.com> + + Reviewed by Kenneth Rohde Christiansen. + + [Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests + https://bugs.webkit.org/show_bug.cgi?id=56086 + + Add the missing method. + + * DumpRenderTree/qt/DumpRenderTreeQt.cpp: + (WebCore::DumpRenderTree::getAllPages): Add a method to return all the pages allocated for the current test. + * DumpRenderTree/qt/DumpRenderTreeQt.h: + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::numberOfPendingGeolocationPermissionRequests): + +2011-04-06 Dai Mikurube <dmikurube@chromium.org> + + Reviewed by David Levin. + + Add QUOTA build flag for unified quota API + https://bugs.webkit.org/show_bug.cgi?id=57918 + + * Scripts/build-webkit: Added QUOTA build flag + +2011-04-06 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Tony Chang. + + Adjust the apple webkit port's default timeout to match + old-run-webkit-tests at 35 seconds. + + https://bugs.webkit.org/show_bug.cgi?id=37738 + + * Scripts/webkitpy/layout_tests/port/mac.py: + +2011-04-06 Scott Cameron <sccameron@rim.com> + + Reviewed by Eric Seidel. + + Remove global variable $httpdPath and replace with the return value of + getHTTPDPath(). Also remove unnecessary calls to getHTTPDPath(). + https://bugs.webkit.org/show_bug.cgi?id=53499 + + * Scripts/run-iexploder-tests: + * Scripts/webkitperl/httpd.pm: + +2011-04-06 Kevin Ollivier <kevino@theolliviers.com> + + Reviewed by Darin Adler. + + Make sure JS_EXPORT_PRIVATE is an empty define when we aren't using the export macros. + + https://bugs.webkit.org/show_bug.cgi?id=27551 + + * DumpRenderTree/config.h: + * WebKitAPITest/config.h: + * WebKitTestRunner/config.h: + +2011-04-06 Tony Chang <tony@chromium.org> + + Reviewed by Darin Adler. + + teach run-webkit-tests to read checksums from png files + https://bugs.webkit.org/show_bug.cgi?id=57993 + + * Scripts/old-run-webkit-tests: Read the first 2k of a .png if there's + no .checksum and look for the checksum in there. + +2011-04-06 David Dorwin <ddorwin@chromium.org> + + Reviewed by David Levin. + + Enable fullscreen layout tests for Chromium + https://bugs.webkit.org/show_bug.cgi?id=55726 + + Make DumpRenderTree always run with fullscreen enabled (equivalent of --enable-fullscreen). + + * DumpRenderTree/chromium/WebPreferences.cpp: + (WebPreferences::applyTo): + +2011-04-06 Adam Roben <aroben@apple.com> + + Add a "view leaks" link to builds on SnowLeopard Intel Leaks + + Fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot results page + + Reviewed by David Kilzer. + + * BuildSlaveSupport/build.webkit.org-config/master.cfg: + (ExtractTestResults.resultDirectoryURL): Added. Moved code to calculate the URL for the + build's results directory here... + (ExtractTestResults.finished): ...from here. + (ExtractTestResultsAndLeaks): New class that's used by the leaks builder + (ExtractTestResultsAndLeaks.finished): Calls up to the base class, but also adds a "view + leaks" link to point to Leaks Viewer for this build. + (TestFactory): Added ExtractTestResultsClass abstraction. This isn't overridden anywhere, + but it seemed good to add for consistency with BuildAndTestFactory. + (BuildAndTestFactory): Added ExtractTestResultsClass abstraction. + (BuildAndTestLeaksFactory): Use ExtractTestResultsAndLeaks as our ExtractTestResultsClass so + that we'll get a "view leaks" link. + +2011-04-06 Zan Dobersek <zandobersek@gmail.com> + + Reviewed by Eric Seidel. + + [Gtk] plugins/set-status.html fails + https://bugs.webkit.org/show_bug.cgi?id=57844 + + Allow an empty status text to be dumped. + + * DumpRenderTree/gtk/DumpRenderTree.cpp: + (webViewStatusBarTextChanged): + +2011-04-06 Chang Shu <cshu@webkit.org> + + Reviewed by Darin Adler. + + WebKitTestRunner needs layoutTestController.pageNumberForElementById + https://bugs.webkit.org/show_bug.cgi?id=42329 + + * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: + * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: + (WTR::LayoutTestController::pageNumberForElementById): + * WebKitTestRunner/InjectedBundle/LayoutTestController.h: + +2011-04-06 Sergio Villar Senin <svillar@igalia.com> + + Reviewed by Martin Robinson. + + [GTK] DumpRenderTree: do not try to free NULL SoupURIs + https://bugs.webkit.org/show_bug.cgi?id=57932 + + Some Layout tests have invalid URIs that do not generate valid + SoupURI instances. Do not try to free those NULL SoupURIs. + + * DumpRenderTree/gtk/DumpRenderTree.cpp: + (willSendRequestCallback): + +2011-04-06 Csaba Osztrogonác <ossy@webkit.org> + + Reviewed by Andreas Kling. + + ORWT shouldn't generate diff files for tests without expected files + https://bugs.webkit.org/show_bug.cgi?id=57846 + + * Scripts/old-run-webkit-tests: + +2011-04-05 Kevin Ollivier <kevino@theolliviers.com> + + [wx] Mac build fix. Handle cases where 10.4 SDK is not installed, and also add x86_64 arch + to deps. + + * wx/install-unix-extras: + +2011-04-05 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r82978, r82999, and r83001. + http://trac.webkit.org/changeset/82978 + http://trac.webkit.org/changeset/82999 + http://trac.webkit.org/changeset/83001 + https://bugs.webkit.org/show_bug.cgi?id=57913 + + Does not work in Python 2.5 (Requested by abarth on #webkit). + + * Scripts/webkitpy/common/system/executive.py: + * Scripts/webkitpy/common/system/executive_unittest.py: + +2011-04-05 Chang Shu <cshu@webkit.org> + + Reviewed by Darin Adler. + + WebKitTestRunner needs layoutTestController.numberOfPages + https://bugs.webkit.org/show_bug.cgi?id=42694 + + * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: + * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: + (WTR::LayoutTestController::numberOfPages): + * WebKitTestRunner/InjectedBundle/LayoutTestController.h: + +2011-04-05 Tony Chang <tony@chromium.org> + + Reviewed by Mihai Parparita. + + [chromium] stop putting results downloaded from WebKit Linux in chromium-linux-x86_64 + https://bugs.webkit.org/show_bug.cgi?id=57889 + + * Scripts/webkitpy/layout_tests/port/chromium.py: + * Scripts/webkitpy/layout_tests/port/test.py: + * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: + +2011-04-05 Adam Barth <abarth@webkit.org> + + Silly with statement, from the future! + + * Scripts/webkitpy/common/system/executive.py: + +2011-04-05 Adam Barth <abarth@webkit.org> + + Reviewed by Tony Chang. + + Don't use Exception.message because it's deprecated + https://bugs.webkit.org/show_bug.cgi?id=57892 + + Suppress the warning for now. When we move to Python 3, we might need + to something more dramatic. + + * Scripts/webkitpy/common/system/executive.py: + +2011-04-05 Mihai Parparita <mihaip@chromium.org> + + Reviewed by Ojan Vafai. + + Add builders.js to dashboard file list + https://bugs.webkit.org/show_bug.cgi?id=57899 + + Add file added by http://crrev.com/80538 to dashboard file list. + + * TestResultServer/handlers/dashboardhandler.py: + +2011-04-05 MORITA Hajime <morrita@google.com> + + Reviewed by Adam Barth. + + webkit-patch should print git's stderr when git svn dcommit fail + http://webkit.org/b/57861 + + * Scripts/webkitpy/common/checkout/scm.py: + +2011-04-05 Mihai Parparita <mihaip@chromium.org> + + Reviewed by Tony Chang. + + Add --baseline-search-path to NRWT + https://bugs.webkit.org/show_bug.cgi?id=56233 + + Add NRWT option to specify additional directories to look for baselines + (will be used by hardware GPU bots which will have local per-bot + expectations for some tests) + + * Scripts/webkitpy/common/system/filesystem_mock.py: + * Scripts/webkitpy/layout_tests/port/base.py: + * Scripts/webkitpy/layout_tests/port/base_unittest.py: + * Scripts/webkitpy/layout_tests/run_webkit_tests.py: + +2011-04-05 Adam Roben <aroben@apple.com> + + Strip off /results.html from results URLs before trying to load leaks files from them + + r82734 changed build.webkit.org's "view results" URLs to point straight to the results.html + files, rather than pointing to the directory that contains them. This is more convenient for + people browsing build.webkit.org, but confused Leaks Viewer. + + Fixes <http://webkit.org/b/57869> REGRESSION (r82734): Links in Leaks Viewer's Recent Builds + list don't work + + Reviewed by Joseph Pecoraro. + + * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: + (RecentBuildsLoader.prototype.start): Strip off "/results.html" from the results URL. + +2011-04-05 Carol Szabo <carol@webkit.org> + + Unreviewed. + + Updated my info in committers.py + + Scripts\webkitpy\common\config\committers.py + +2011-04-05 Csaba Osztrogonác <ossy@webkit.org> + + Reviewed by Laszlo Gombos. + + [Qt] Make WebKitLibraries optional for building QtWebKit + https://bugs.webkit.org/show_bug.cgi?id=57542 + + * Scripts/build-webkit: + +2011-04-05 Chang Shu <cshu@webkit.org> + + Reviewed by Laszlo Gombos. + + [Qt] MiniBrowser defaultUrl does not work + https://bugs.webkit.org/show_bug.cgi?id=57021 + + Match the behavior and coding of MiniBrowser to QtTestBrowser. + * MiniBrowser/qt/main.cpp: + (main): + +2011-04-05 Jade Han <jade.han@nokia.com> + + Reviewed by Laszlo Gombos. + + [Qt] [Symbian] Disable WebKitTestRunner for Symbian + https://bugs.webkit.org/show_bug.cgi?id=54977 + + This change is a preparation to enable building webkit2 for Symbian. + Bug 57834 is filed to fix and enable WebKitTestRunner for Symbian. + + * Tools.pro: + +2011-04-05 Zoltan Horvath <zoltan@webkit.org> + + Reviewed by Andreas Kling. + + [Qt] Fix timeoutTimer of MiniBrowser's UrlLoader + https://bugs.webkit.org/show_bug.cgi?id=57832 + + Only QWKPage has loadFinished signal so connect to it instead of BrowserWindow. + + * MiniBrowser/qt/UrlLoader.cpp: + (UrlLoader::UrlLoader): + +2011-04-05 Zoltan Horvath <zoltan@webkit.org> + + [Qt] Linux Release minimal build fix after r82919. + + * MiniBrowser/qt/BrowserWindow.cpp: + (BrowserWindow::loadURLListFromFile): + * QtTestBrowser/launcherwindow.cpp: + (LauncherWindow::loadURLListFromFile): + +2011-04-05 Zoltan Horvath <zoltan@webkit.org> + + Reviewed by Andreas Kling. + + [Qt] Make URL loader accessible from testbrowser's menus + https://bugs.webkit.org/show_bug.cgi?id=57823 + + Add "Load URLs from file" to QtTestBrowser's and to MiniBrowser's menu. + + * MiniBrowser/qt/BrowserWindow.cpp: + (BrowserWindow::BrowserWindow): + (BrowserWindow::loadURLListFromFile): + (BrowserWindow::~BrowserWindow): + * MiniBrowser/qt/BrowserWindow.h: + * QtTestBrowser/launcherwindow.cpp: + (LauncherWindow::LauncherWindow): + (LauncherWindow::~LauncherWindow): + (LauncherWindow::createChrome): + (LauncherWindow::loadURLListFromFile): + * QtTestBrowser/launcherwindow.h: + +2011-04-04 Sam Weinig <sam@webkit.org> + + Reviewed by Brian Weinstein. + + Remove duplicate API from WKContext + <rdar://problem/8727879> + https://bugs.webkit.org/show_bug.cgi?id=57815 + + * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: + * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Removed. + * TestWebKitAPI/win/TestWebKitAPI.vcproj: + Remove SendingMessagesToTheWebProcessBeforeItIsValid since the API it was testing is now removed. + +2011-04-04 Tony Chang <tony@chromium.org> + + Reviewed by Ojan Vafai. + + [chromium] don't write .checksum files if a fallback platform has an embedded checksum + https://bugs.webkit.org/show_bug.cgi?id=57783 + + * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: + * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: + +2011-04-04 Kevin Ollivier <kevino@theolliviers.com> + + [wx] Unreviewed build fix, run uninstall when cleaning to remove built files + from WebKitBuild. + + * Scripts/webkitdirs.pm: + +2011-04-04 Martin Robinson <mrobinson@igalia.com> + + Reviewed by Gustavo Noronha Silva. + + [GTK] WebGL support + https://bugs.webkit.org/show_bug.cgi?id=31517 + + Add support to the DRT for turning on WebGL when a layout tests requests it. + + * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: + (LayoutTestController::overridePreference): Allow turning on WebGL from tests. + +2011-04-04 Chang Shu <cshu@webkit.org> + + Reviewed by Darin Adler. + + WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs + https://bugs.webkit.org/show_bug.cgi?id=57572 + + * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: + * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: + (WTR::LayoutTestController::setAllowFileAccessFromFileURLs): + * WebKitTestRunner/InjectedBundle/LayoutTestController.h: + +2011-04-04 Keith Kyzivat <keith.kyzivat@nokia.com> + + Reviewed by Csaba Osztrogonác. + + [Qt] DumpRenderTree breaks compilation in some uClibc environments + https://bugs.webkit.org/show_bug.cgi?id=57602 + + * DumpRenderTree/qt/main.cpp: + (get_backtrace): + +2011-04-04 Kevin Ollivier <kevino@theolliviers.com> + + [wx] Unreviewed build fix, add new LayoutTestController method stub to wx. + + * DumpRenderTree/wx/LayoutTestControllerWx.cpp: + (LayoutTestController::shadowRoot): + +2011-04-04 Pavel Podivilov <podivilov@chromium.org> + + Unreviewed, fix exception in rebaseline tool. + + * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: + +2011-04-02 Beth Dakin <bdakin@apple.com> + + Rubber-stamped by Geoff Garen. + + For Dan! + * DumpRenderTree/mac/DumpRenderTree.mm: + (resetWebViewToConsistentStateBeforeTesting): + +2011-04-02 Beth Dakin <bdakin@apple.com> + + Rubber-stamped by Geoff Garen. + + Need to reset the scale, much like zoom. + * DumpRenderTree/mac/DumpRenderTree.mm: + (resetWebViewToConsistentStateBeforeTesting): + +2011-04-02 Sam Weinig <sam@webkit.org> + + Reviewed by Beth Dakin. + + https://bugs.webkit.org/show_bug.cgi?id=57605 + Frame::pageScaleFactor() should not affect getBoundingClientRect() or + getClientRects() + -and corresponding- + <rdar://problem/9194541> + + Add DRT support for the scaleWebView SPI. + * DumpRenderTree/mac/EventSendingController.mm: + (+[EventSendingController isSelectorExcludedFromWebScript:]): + (+[EventSendingController webScriptNameForSelector:]): + (-[EventSendingController scalePageBy:atX:andY:]): + * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: + * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: + (WTR::EventSendingController::scalePageBy): + * WebKitTestRunner/InjectedBundle/EventSendingController.h: + * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: + (WTR::InjectedBundlePage::reset): + +2011-04-02 Dominic Cooney <dominicc@google.com> + + Reviewed by Martin Robinson. + + Add layoutTestController.shadowRoot to GTK DumpRenderTree. + https://bugs.webkit.org/show_bug.cgi?id=57551 + + * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: + (LayoutTestController::shadowRoot): + +2011-04-02 Patrick Gansterer <paroga@webkit.org> + + Reviewed by Eric Seidel. + + Remove AbstractStep._run_script and move script names to ports.py + https://bugs.webkit.org/show_bug.cgi?id=57704 + + Replace deprecated _run_script with _tool.executive.run_and_throw_if_fail. + + * Scripts/webkitpy/common/config/ports.py: + * Scripts/webkitpy/tool/commands/download_unittest.py: + * Scripts/webkitpy/tool/commands/roll_unittest.py: + * Scripts/webkitpy/tool/commands/upload_unittest.py: + * Scripts/webkitpy/tool/steps/abstractstep.py: + * Scripts/webkitpy/tool/steps/checkstyle.py: + * Scripts/webkitpy/tool/steps/preparechangelog.py: + * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: + * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py: + +2011-04-02 Patrick Gansterer <paroga@webkit.org> + + Reviewed by Eric Seidel. + + Emulate shebang on Win32 + https://bugs.webkit.org/show_bug.cgi?id=55927 + + Scripts on Windows work only if they are called with the explicit interpreter. + Read the first line of scripts to detect the correct executable. + + * Scripts/webkitpy/common/config/ports.py: + * Scripts/webkitpy/common/system/executive.py: Added interpreter_for_script(). + * Scripts/webkitpy/common/system/executive_unittest.py: + +2011-04-01 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + apos entities shouldn't show up in ChangeLogs when using webkit-patch + https://bugs.webkit.org/show_bug.cgi?id=57692 + + Previously, we were using BeautifulSoup to process XML from + bugs.webkit.org, but that's incorrect. We should be using + BeautifulStoneSoup to process the XML. We were getting the ' + entity wrong because ' is an XML entity but not an HTML entity. + + * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: + * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: + +2011-04-01 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r82721. + http://trac.webkit.org/changeset/82721 + https://bugs.webkit.org/show_bug.cgi?id=57687 + + This patch introduced assertion failures on the GTK+ bots. + (Requested by mrobinson on #webkit). + + * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: + (LayoutTestController::shadowRoot): + +2011-04-01 Csaba Osztrogonác <ossy@webkit.org> + + Unreviewed buildfix. + + [Qt][WK2] Build Webkit2 using "-2" option on Qt + https://bugs.webkit.org/show_bug.cgi?id=55074 + + * Scripts/build-webkit: Ensure that "-2" isn't passed to qmake. + (The isWK2() function removes it from @ARGV, but not from @options.) + +2011-04-01 Keith Kyzivat <keith.kyzivat@nokia.com> + + Reviewed by Csaba Osztrogonác. + + [Qt] [WK2] MiniBrowser.qrc not found - regression from rev 82671 + https://bugs.webkit.org/show_bug.cgi?id=57666 + + * MiniBrowser/qt/MiniBrowser.qrc: Renamed from Tools/MiniBrowser/MiniBrowser.qrc. + +2011-04-01 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Adam Barth. + + new-run-webkit-tests: fix feature detection, skipped platform lists on mac + + We apparently never implemented the code to skip tests based on + what was compiled into DRT. Also, change the logic used to skip + platform directories to match what old-run-webkit-tests does: + skip every test not in a directory in the baseline search path. + + https://bugs.webkit.org/show_bug.cgi?id=57662 + + * Scripts/webkitpy/layout_tests/port/mac.py: + * Scripts/webkitpy/layout_tests/port/mac_unittest.py: + * Scripts/webkitpy/layout_tests/port/webkit.py: + +2011-03-29 Mark Rowe <mrowe@apple.com> + + Reviewed by Jon Honeycutt. + + <http://webkit.org/b/56730> new-run-webkit-tests fails on Lion seed + + Teach new-run-webkit-tests about the concept of an unreleased version of Mac OS X. + + * Scripts/webkitpy/layout_tests/port/chromium_mac.py: + * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: + * Scripts/webkitpy/layout_tests/port/mac.py: + * Scripts/webkitpy/layout_tests/port/mac_unittest.py: + +2011-04-01 Chang Shu <cshu@webkit.org> + + Reviewed by Csaba Osztrogonác. + + [Qt][WK2] Build Webkit2 using "-2" option on Qt + https://bugs.webkit.org/show_bug.cgi?id=55074 + + * Scripts/build-webkit: + +2011-04-01 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Tony Chang. + + new-run-webkit-tests: remove spurious port version override in webkit.py + base.py provides a default implementation so this is just + breaking things. + + https://bugs.webkit.org/show_bug.cgi?id=57667 + + * Scripts/webkitpy/layout_tests/port/webkit.py: + * Scripts/webkitpy/layout_tests/port/mac_unittest.py: + +2011-04-01 Csaba Osztrogonác <ossy@webkit.org> + + Reviewed by Adam Roben. + + Make view results on waterfall direct link to results.html + https://bugs.webkit.org/show_bug.cgi?id=57671 + + * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add "/results.html" to the URL. + * Scripts/old-run-webkit-tests: Add links to httpd access and error logs. + +2011-04-01 Sam Weinig <sam@webkit.org> + + Fix windows build. + + * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: + (TestWebKitAPI::TEST): + * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp: + (TestWebKitAPI::flushMessages): + +2011-04-01 Sam Weinig <sam@webkit.org> + + Reviewed by Adam Roben. + + Add adoptWK to WKRetainPtr.h + https://bugs.webkit.org/show_bug.cgi?id=57670 + + * TestWebKitAPI/PlatformUtilities.h: + * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: + * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: + * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: + * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: + * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp: + * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: + * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp: + * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: + (TestWebKitAPI::createSessionStateContainingFormData): + * WebKitTestRunner/StringFunctions.h: + Replace custom versions of adoptWK with the API on in WebKit2/WKRetainPtr.h. + +2011-04-01 Sam Weinig <sam@webkit.org> + + Reviewed by Adam Roben. + + Fix leak noticed by Adam Roben in LayoutTestController::shadowRoot. + + * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: + (WTR::LayoutTestController::shadowRoot): + Make judicious use of adoptWK(). + +2011-04-01 Sam Weinig <sam@webkit.org> + + Reviewed by Timothy Hatcher. + + Fix extract-localizable-strings for macro change from UI_STRING -> WEB_UI_STRING. + + * Scripts/extract-localizable-strings: + +2011-04-01 Anders Carlsson <andersca@apple.com> + + Reviewed by Sam Weinig. + + Shockwave plug-in doesn't accept mouse events + https://bugs.webkit.org/show_bug.cgi?id=57653 + <rdar://problem/8483273> + + Add a plug-in test. + + * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: + * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: + (PluginTest::indicateTestFailure): + Move code from NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject here. + + (PluginTest::NPN_ConvertPoint): + * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: + * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp: + (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject): + Call indicateTestFailure. + + * DumpRenderTree/TestNetscapePlugIn/Tests/mac: Added. + * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp: Added. + (ConvertPoint::ConvertPoint): + (ConvertPoint::testConvert): + (ConvertPoint::NPP_New): + +2011-04-01 Dominic Cooney <dominicc@google.com> + + Reviewed by Martin Robinson. + + Add layoutTestController.shadowRoot to GTK DumpRenderTree. + https://bugs.webkit.org/show_bug.cgi?id=57551 + + * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: + (LayoutTestController::shadowRoot): + +2011-04-01 Sam Weinig <sam@webkit.org> + + Reviewed by Anders Carlsson. + + WebKitTestRunner needs layoutTestController.shadowRoot + https://bugs.webkit.org/show_bug.cgi?id=57661 + + * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: + * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: + (WTR::LayoutTestController::shadowRoot): + * WebKitTestRunner/InjectedBundle/LayoutTestController.h: + Implement layoutTestController.shadowRoot for WebKit2. + +2011-04-01 Chang Shu <cshu@webkit.org> + + Reviewed by Darin Adler. + + WebKitTestRunner needs layoutTestController.setDatabaseQuota + https://bugs.webkit.org/show_bug.cgi?id=57568 + + * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: + * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: + (WTR::LayoutTestController::setDatabaseQuota): + * WebKitTestRunner/InjectedBundle/LayoutTestController.h: + +2011-04-01 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Tony Chang. + + This patch completes the cleanup of + rebaseline-chromium-webkit-tests to work with all of the + variants of a platform (we can now rebaseline gpu- and non-gpu + files at the same time). + + When the rebaselining is complete, any lines declared as + REBASELINE in the expectations file that matches a test that was + actually rebaselined will be deleted, even if only one of the + variants was actually rebaselined. This may cause odd problems, + but is better than where we're at today. + + This change removes the -g flag and deprecates -w. The -g flag is gone + because GPU baselines are handled just like any other variant. + The -w flag is deprecated because this tool now only works + against the canaries, since that's the only place we have a full + set of bots. It will be trivial to change this to + build.webkit.org if we decide that's where we want them to be. + + Also, this patch deletes a lot of cruft that is no longer needed + in the test_expectations code and the port-specific code. + + https://bugs.webkit.org/show_bug.cgi?id=55191 + + * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: + * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py: + * Scripts/webkitpy/layout_tests/port/base.py: + * Scripts/webkitpy/layout_tests/port/base_unittest.py: + * Scripts/webkitpy/layout_tests/port/chromium.py: + * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: + * Scripts/webkitpy/layout_tests/port/chromium_linux.py: + * Scripts/webkitpy/layout_tests/port/chromium_mac.py: + * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: + * Scripts/webkitpy/layout_tests/port/chromium_win.py: + * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: + * Scripts/webkitpy/layout_tests/port/mac.py: + * Scripts/webkitpy/layout_tests/port/test.py: + * Scripts/webkitpy/layout_tests/port/webkit.py: + * Scripts/webkitpy/layout_tests/port/win.py: + * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: + * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: + +2011-04-01 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Adam Barth. + + rebaseline-chromium-webkit-tests does not work correctly with + version-specific baselines. This patch updates the tool to use + all of the version-specific bots on the canaries, and will now + attempt to rebaseline all of the versions by default, although + it will not update both GPU and CPU versions. + + Also, it will no longer modify the test_expectations.txt file + *at all*. You will have to manually delete the REBASELINE lines + after running the tool and determining that it did what you + wanted it to do. This should be fixed in a separate bug - see + webkit bug #55191. + + https://bugs.webkit.org/show_bug.cgi?id=55608 + + * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: + * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py: + * Scripts/webkitpy/layout_tests/port/chromium.py: + * Scripts/webkitpy/layout_tests/port/test.py: + * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: + * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: + +2011-03-31 Tony Chang <tony@chromium.org> + + Reviewed by Ojan Vafai. + + [chromium] update the rebaseline tool to know about pngs with checksums + https://bugs.webkit.org/show_bug.cgi?id=57481 + + * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Skip over .checksum files if the checksum is already in the png + * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: + +2011-04-01 Adam Roben <aroben@apple.com> + + Retrieve revision numbers from the build's got_revision property in Leaks Viewer + + Previously, we were getting the revision of the first revision that triggered a build. + Choosing the last revision would have been more accurate. But got_revision is what is used + everywhere else on build.webkit.org, and should work even when there were no changes that + triggered a build (e.g., if someone clicked the Force Build button). + + Fixes <http://webkit.org/b/57630> Leaks viewer gets some revision numbers wrong in the + recent builds list + + Reviewed by Anders Carlsson. + + * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: + (RecentBuildsLoader.prototype.start): Pull the revision number out of the got_revision + property, rather than out of the first (i.e., earliest) change in the sourceStamp object. + + * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js: + (Array.prototype.first): Added this helper function to return the first element in an array + that matches the given predicate, or null if no such element exists. + +2011-03-31 Adam Roben <aroben@apple.com> + + Prefer (but don't require) bug URLs to be on their own line when parsing bug numbers from ChangeLogs + + Fixes <http://webkit.org/b/57579> webkit-patch is too strict about bug URL formatting + + Reviewed by Darin Adler. + + * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: + (parse_bug_id_from_changelog): Fall back to parse_bug_id if we weren't able to find a bug + URL on its own line. + + * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: + (BugzillaTest.test_parse_bug_id_from_changelog): Updated expected results for test + progression, and added a new test that uses a short bug URL while I was at it. + +2011-04-01 Adam Roben <aroben@apple.com> + + Mark .vcproj/.vsprops/.sln files as being Windows-only + + Fixes <http://webkit.org/b/57489> Mac builders built 82512, but shouldn't have + + Reviewed by Anders Carlsson. + + * Scripts/webkitpy/common/config/build.py: + (_should_file_trigger_build): Added patterns to mark .vcproj/.vsprops/.sln files and .vcproj + directories as Windows-only. + + * Scripts/webkitpy/common/config/build_unittest.py: + (ShoulBuildTest): Added test cases for the above. + +2011-04-01 Keith Kyzivat <keith.kyzivat@nokia.com> + + Reviewed by Laszlo Gombos. + + [Qt] Build MiniBrowser for Symbian + https://bugs.webkit.org/show_bug.cgi?id=56319 + + Have MiniBrowser reference it's own copy of useragentlist.txt instead + of copying QtTestBrowser's. + Remove Tools/MiniBrowser/DerivedSources.pro + This reduces complexity in the Tools scripts due to Symbian limitations. + + * DerivedSources.pro: + * MiniBrowser/DerivedSources.pro: Removed. + * MiniBrowser/MiniBrowser.qrc: + * MiniBrowser/qt/MiniBrowser.pro: + * Scripts/webkitdirs.pm: + +2011-03-31 Chang Shu <cshu@webkit.org> + + Reviewed by Darin Adler. + + WebKitTestRunner needs layoutTestController.clearAllDatabases + https://bugs.webkit.org/show_bug.cgi?id=42540 + + * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: + * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: + (WTR::InjectedBundle::beginTesting): + * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: + (WTR::LayoutTestController::clearAllDatabases): + * WebKitTestRunner/InjectedBundle/LayoutTestController.h: + +2011-03-31 Chang Shu <cshu@webkit.org> + + Reviewed by Darin Adler. + + WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs + https://bugs.webkit.org/show_bug.cgi?id=42692 + + * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: + +2011-03-31 Darin Adler <darin@apple.com> + + Reviewed by Sam Weinig. + + Implement mouseDown, mouseUp, and mouseMoveTo in WebKitTestRunner + https://bugs.webkit.org/show_bug.cgi?id=57573 + + * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: + Added real definitions for mouseDown, mouseUp, mouseMoveTo and leapForward. + Removed fake definitions of keyDown and contextClick. + + * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: + (WTR::operator==): Added. So we can compare two WKPoint structs. + (WTR::parseModifier): Added. + (WTR::parseModifierArray): Added. + (WTR::EventSendingController::EventSendingController): Initialize the + new data members. + (WTR::EventSendingController::mouseDown): Added. Calls + WKBundlePageSimulateMouseDown. + (WTR::EventSendingController::mouseUp): Added. Calls + WKBundlePageSimulateMouseUp. + (WTR::EventSendingController::mouseMoveTo): Added. Calls + WKBundlePageSimulateMouseMotion. + (WTR::EventSendingController::leapForward): Added. + (WTR::EventSendingController::updateClickCount): Added. Used by the + mouseDown/Up functions to create a click count. + + * WebKitTestRunner/InjectedBundle/EventSendingController.h: Updated + for the changes above. + +2011-03-31 Sergio Villar Senin <svillar@igalia.com> + + Reviewed by Martin Robinson. + + [GTK] implement LayoutTestController::setWillSendRequestReturnsNull + https://bugs.webkit.org/show_bug.cgi?id=57362 + + Do not generate DRT output if willSendRequestReturnsNull is set. + + * DumpRenderTree/gtk/DumpRenderTree.cpp: + (willSendRequestCallback): + +2011-03-31 Vamshikrishna.Yellenki <vamshi@motorola.com> and Alejandro G. Castro <alex@igalia.com> + + Reviewed by Martin Robinson. + + Implement MiniBrowser for Gtk port. + https://bugs.webkit.org/show_bug.cgi?id=48512 + + Initial implementation of the Gtk MiniBrowser. + + * MiniBrowser/gtk/GNUmakefile.am: Added. + * MiniBrowser/gtk/main.c: Added. + (activateUriEntryCallback): + (destroyCallback): + (goBackCallback): + (goForwardCallback): + (createToolbar): + (createWebView): + (createWindow): + (argumentToURL): + (main): + +2011-03-30 Dominic Cooney <dominicc@google.com> + + Reviewed by Dimitri Glazkov. + + Adds layoutTestController.shadowRoot accessor to Mac DRT. + https://bugs.webkit.org/show_bug.cgi?id=57415 + + * DumpRenderTree/LayoutTestController.cpp: + (shadowRootCallback): + (LayoutTestController::staticFunctions): + * DumpRenderTree/LayoutTestController.h: + * DumpRenderTree/mac/LayoutTestControllerMac.mm: + (LayoutTestController::shadowRoot): + * DumpRenderTree/win/LayoutTestControllerWin.cpp: + (LayoutTestController::shadowRoot): + +2011-03-30 Matthew Delaney <mdelaney@apple.com> + + Reviewed by Chris Marrin. + + Update fast/canvas tests to avoid dumping the render tree when possible + https://bugs.webkit.org/show_bug.cgi?id=57493 + + * DumpRenderTree/mac/DumpRenderTree.mm: Make DRT aware of new default values for + accelerated drawing and accelerated drawing for canvas + +2011-03-30 Adam Roben <aroben@apple.com> + + Stop ignoring leaks in CGGradientCreateWithColorStops + + Fixes <rdar://problem/7888547>. + + Rubber-stamped by John Sullivan. + + * Scripts/old-run-webkit-tests: + (countAndPrintLeaks): Removed some code to ignore those leaks. + +2011-03-30 Timur Iskhodzhanov <timurrrr@google.com> + + Reviewed by Alexey Proskuryakov. + + Add some dynamic annotations to JavaScriptCore/wtf + https://bugs.webkit.org/show_bug.cgi?id=53747 + + By using these annotations we can improve the precision of finding + WebKit errors using dynamic analysis tools like ThreadSanitizer and Valgrind. + These annotations don't affect the compiled binaries unless USE(DYNAMIC_ANNOTATIONS) is "1". + + These files don't add new functionality, so don't need extra tests. + + * DumpRenderTree/ForwardingHeaders/wtf/DynamicAnnotations.h: Added. + +2011-03-30 Steve Falkenburg <sfalken@apple.com> + + Reviewed by Adam Roben. + + Share most vsprops between Release and Production builds in releaseproduction.vsprops + https://bugs.webkit.org/show_bug.cgi?id=57508 + + * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: + * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: + * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: + * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: + * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: + * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: + * DumpRenderTree/win/ImageDiffProduction.vsprops: + * DumpRenderTree/win/ImageDiffRelease.vsprops: + * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: + * FindSafari/FindSafariProduction.vsprops: + * FindSafari/FindSafariRelease.vsprops: + * FindSafari/FindSafariReleaseCairoCFLite.vsprops: + * FindSafari/FindSafariReleasePGO.vsprops: + * MiniBrowser/Configurations/MiniBrowserProduction.vsprops: + * MiniBrowser/Configurations/MiniBrowserRelease.vsprops: + * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops: + * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops: + * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops: + * WebKitAPITest/WebKitAPITestProduction.vsprops: + * WebKitAPITest/WebKitAPITestRelease.vsprops: + * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops: + * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: + * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: + * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: + * WebKitTestRunner/win/InjectedBundleProduction.vsprops: + * WebKitTestRunner/win/InjectedBundleRelease.vsprops: + * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: + * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops: + * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: + * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: + * WinLauncher/WinLauncherProduction.vsprops: + * WinLauncher/WinLauncherRelease.vsprops: + * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: + * record-memory-win/record-memory-winProduction.vsprops: + * record-memory-win/record-memory-winRelease.vsprops: + * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: + 2011-03-30 Steve Falkenburg <sfalken@apple.com> Reviewed by Adam Roben. |