diff options
Diffstat (limited to 'WebCore/ChangeLog')
| -rw-r--r-- | WebCore/ChangeLog | 5770 |
1 files changed, 5769 insertions, 1 deletions
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog index 6bf8f3c..48756e8 100644 --- a/WebCore/ChangeLog +++ b/WebCore/ChangeLog @@ -1,3 +1,5771 @@ +2010-11-17 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r72228. + http://trac.webkit.org/changeset/72228 + https://bugs.webkit.org/show_bug.cgi?id=49712 + + Caused many >10 regressions on Win and Linux gpu layout test + runs. (Requested by dave_levin on #webkit). + + * html/canvas/WebGLFramebuffer.cpp: + (WebCore::WebGLFramebuffer::onAccess): + (WebCore::WebGLFramebuffer::initializeRenderbuffers): + * html/canvas/WebGLFramebuffer.h: + * html/canvas/WebGLRenderingContext.cpp: + (WebCore::WebGLRenderingContext::clear): + (WebCore::WebGLRenderingContext::copyTexImage2D): + (WebCore::WebGLRenderingContext::copyTexSubImage2D): + (WebCore::WebGLRenderingContext::drawArrays): + (WebCore::WebGLRenderingContext::drawElements): + (WebCore::WebGLRenderingContext::readPixels): + (WebCore::WebGLRenderingContext::texImage2DBase): + +2010-11-17 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r72243. + http://trac.webkit.org/changeset/72243 + https://bugs.webkit.org/show_bug.cgi?id=49710 + + Seemed to cause a large set of Chromium layout test to start + failing. (Requested by dave_levin on #webkit). + + * bindings/v8/V8NPUtils.cpp: + (WebCore::convertV8ObjectToNPVariant): + +2010-11-17 Adam Roben <aroben@apple.com> + + Fix Acid3 in Safari for Windows + + Reviewed by Dave Hyatt. + + * platform/graphics/win/SimpleFontDataWin.cpp: + (WebCore::SimpleFontData::initGDIFont): Initialize all our metrics to 0 + if we have a font size of 0. + +2010-11-17 Dimitri Glazkov <dglazkov@chromium.org> + + Reviewed by Darin Adler. + + Converge means of querying a parent node into one way, which is Node::parentNode. + https://bugs.webkit.org/show_bug.cgi?id=49686 + + No change in behavior, so no new tests. + + * accessibility/AccessibilityObject.cpp: + (WebCore::renderListItemContainerForNode): Changed to use parentNode. + * accessibility/AccessibilityRenderObject.cpp: + (WebCore::AccessibilityRenderObject::mouseButtonListener): Ditto. + (WebCore::siblingWithAriaRole): Ditto. + (WebCore::AccessibilityRenderObject::getDocumentLinks): Ditto. + (WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest): Ditto. + * accessibility/mac/AccessibilityObjectWrapper.mm: Ditto. + (blockquoteLevel): Ditto. + * bindings/v8/V8GCController.cpp: + (WebCore::ObjectGrouperVisitor::visitDOMWrapper): Ditto. + * dom/ContainerNode.cpp: Ditto. + (WebCore::ContainerNode::insertBefore): Ditto. + (WebCore::ContainerNode::insertBeforeCommon): Ditto. + (WebCore::ContainerNode::replaceChild): Ditto. + (WebCore::ContainerNode::removeChild): Ditto. + (WebCore::ContainerNode::appendChild): Ditto. + (WebCore::ContainerNode::parserAddChild): Ditto. + * dom/DocumentType.cpp: + (WebCore::DocumentType::insertedIntoDocument): Ditto. + * dom/Element.cpp: + (WebCore::Element::computeInheritedLanguage): Ditto. + * dom/MouseRelatedEvent.cpp: + (WebCore::MouseRelatedEvent::receivedTarget): Ditto. + * dom/Position.cpp: + (WebCore::Position::isCandidate): Changed to use parentNode. + * dom/PositionIterator.cpp: + (WebCore::PositionIterator::isCandidate): Ditto. + * editing/AppendNodeCommand.cpp: + (WebCore::AppendNodeCommand::AppendNodeCommand): Ditto. + * editing/ApplyStyleCommand.cpp: + (WebCore::dummySpanAncestorForNode): Ditto. + (WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi): Ditto. + (WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock): Ditto. + (WebCore::highestEmbeddingAncestor): Ditto. + (WebCore::ApplyStyleCommand::splitTextElementAtEnd): Ditto. + (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical): Ditto. + (WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical): Ditto. + * editing/CompositeEditCommand.cpp: + (WebCore::CompositeEditCommand::splitTreeToNode): Ditto. + * editing/DeleteSelectionCommand.cpp: + (WebCore::updatePositionForNodeRemoval): Ditto. + * editing/Editor.cpp: + (WebCore::Editor::textDirectionForSelection): Ditto. + * editing/MergeIdenticalElementsCommand.cpp: + (WebCore::MergeIdenticalElementsCommand::doUnapply): Ditto. + * editing/htmlediting.cpp: + (WebCore::isEmptyTableCell): Ditto. + * editing/markup.cpp: + (WebCore::StyledMarkupAccumulator::serializeNodes): Ditto. + * editing/visible_units.cpp: + (WebCore::previousLinePosition): Ditto. + (WebCore::nextLinePosition): Ditto. + * html/HTMLAreaElement.cpp: + (WebCore::HTMLAreaElement::imageElement): Ditto. + * html/HTMLElement.cpp: + (WebCore::HTMLElement::setOuterHTML): Ditto. + (WebCore::HTMLElement::insertAdjacent): Ditto. + (WebCore::HTMLElement::supportsFocus): Ditto. + * html/HTMLEmbedElement.cpp: + (WebCore::HTMLEmbedElement::insertedIntoDocument): Ditto. + (WebCore::HTMLEmbedElement::attributeChanged): Ditto. + * html/HTMLTableElement.cpp: + (WebCore::HTMLTableElement::insertRow): Ditto. + * html/HTMLTableRowsCollection.cpp: Ditto. + (WebCore::isInHead): Ditto. + (WebCore::isInBody): Ditto. + (WebCore::isInFoot): Ditto. + (WebCore::HTMLTableRowsCollection::rowAfter): Ditto. + * html/HTMLViewSourceDocument.cpp: + (WebCore::HTMLViewSourceDocument::addRange): Ditto. + * html/MediaDocument.cpp: + (WebCore::MediaDocument::replaceMediaElementTimerFired): Ditto. + * html/parser/HTMLConstructionSite.cpp: + (WebCore::HTMLConstructionSite::attach): Ditto. + (WebCore::HTMLConstructionSite::findFosterSite): Ditto. + * html/parser/HTMLTreeBuilder.cpp: + * page/FocusController.cpp: + (WebCore::FocusController::findFocusableNodeInDirection): Ditto. + * rendering/MediaControlElements.cpp: + (WebCore::MediaControlElement::rendererIsNeeded): Ditto. + (WebCore::MediaControlElement::attach): Ditto. + (WebCore::MediaControlElement::updateStyle): Ditto. + (WebCore::MediaControlInputElement::rendererIsNeeded): Ditto. + (WebCore::MediaControlInputElement::attach): Ditto. + (WebCore::MediaControlInputElement::updateStyle): Ditto. + * rendering/RenderSVGGradientStop.cpp: + (WebCore::RenderSVGGradientStop::gradientElement): Ditto. + * svg/SVGAElement.cpp: + (WebCore::SVGAElement::createRenderer): Ditto. + (WebCore::SVGAElement::childShouldCreateRenderer): Ditto. + * svg/SVGFELightElement.cpp: + (WebCore::SVGFELightElement::svgAttributeChanged): Ditto. + (WebCore::SVGFELightElement::childrenChanged): Ditto. + * svg/SVGFEMergeNodeElement.cpp: + (WebCore::SVGFEMergeNodeElement::svgAttributeChanged): Ditto. + * svg/SVGLength.cpp: + (WebCore::SVGLength::determineViewport): Ditto. + * svg/SVGStyledElement.cpp: + (WebCore::SVGStyledElement::updateRelativeLengthsInformation): Ditto. + * svg/SVGUseElement.cpp: + (WebCore::SVGUseElement::removeDisallowedElementsFromSubtree): Ditto. + * svg/animation/SVGSMILElement.cpp: + (WebCore::SVGSMILElement::insertedIntoDocument): Ditto. + * xml/XPathNodeSet.cpp: + (WebCore::XPath::NodeSet::sort): Ditto. + * xml/XPathStep.cpp: + (WebCore::XPath::Step::nodesInAxis): Ditto. + * xml/XSLTProcessorLibxslt.cpp: + (WebCore::xsltStylesheetPointer): Ditto. + +2010-11-17 Kenneth Rohde Christiansen <kenneth@webkit.org> + + Reviewed by Andreas Kling. + + ScrollView: Don't translate by scrollX/scrollY or clip when paintsEntireContents() + + This makes paint() with paintEntireContents() do exactly what it's supposed to: + paint from 0,0 to contentsSize(). + + The clipping was a no-op anyway since visibleContentRect() will return the whole + rect in paintsEntireContents() mode. + + * platform/ScrollView.cpp: + (WebCore::ScrollView::paint): + +2010-11-17 Kenneth Rohde Christansen <kenneth@webkit.org> + + Reviewed by Andreas Kling. + + ScrollView: Update the actualVisibleContentRect after delegating a scroll. + + This lets us avoid updating the actualVisibleContentRect from the client + after each scroll. We had to do this synchronously for WebKit2 to support + programmatic "animated scrolling" from JS. + + * platform/ScrollView.cpp: + (WebCore::ScrollView::setScrollPosition): + +2010-11-17 Andreas Kling <kling@webkit.org> + + Reviewed by Kenneth Rohde Christiansen. + + ScrollView: Decouple actualVisibleContentRect from visibleContentRect + + Added actualVisibleContentRect() which will return the override provided + by setActualVisibleContentRect() or fall back to visibleContentRect() + if no override has been set. + + This is similar to what the iPhone does. + + * platform/ScrollView.cpp: + (WebCore::ScrollView::visibleContentRect): + * platform/ScrollView.h: + (WebCore::ScrollView::actualVisibleContentRect): + (WebCore::ScrollView::setActualVisibleContentRect): IntRect -> const IntRect& + +2010-11-17 Tony Chang <tony@chromium.org> + + Reviewed by Adam Barth. + + [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn + https://bugs.webkit.org/show_bug.cgi?id=49036 + + No new tests: Covered by plugins/npruntime/get-int-identifier-special-values.html + + In http://codereview.chromium.org/11574, the forked chromium test + plugin changed how it testGetIntIdentifier to work around a change + caused by a silverlight specific plugin fix: + http://codereview.chromium.org/11569/diff/1/2 + + It's not clear to me that this change is needed anymore since + silverlight has had multiple releases, testing without this patch + works on a test windows build, and safari win seems to run silverlight + without this either. Since there's no test for this behavior, I'm + rolling it out so we can match the upstream test. + + * bindings/v8/V8NPUtils.cpp: + (WebCore::convertV8ObjectToNPVariant): + +2010-11-17 Andreas Kling <kling@webkit.org> + + Reviewed by Kenneth Rohde Christiansen. + + ScrollView: Let visibleContentRect() return the contentsSize() if paintsEntireContents() + + * platform/ScrollView.cpp: + (WebCore::ScrollView::visibleContentRect): + +2010-11-17 James Simonsen <simonjam@chromium.org> + + Reviewed by Tony Chang. + + [chromium] Fix negative letter spacing in complex text on linux + https://bugs.webkit.org/show_bug.cgi?id=49563 + + Test: fast/text/atsui-negative-spacing-features.html + + * platform/graphics/chromium/FontLinux.cpp: Make spacing signed. + +2010-11-17 Andreas Kling <kling@webkit.org> + + Reviewed by Kenneth Rohde Christiansen. + + ScrollView: Avoid unnecessary work in setScrollPosition() when scrolling is delegated. + + * platform/ScrollView.cpp: + (WebCore::ScrollView::setScrollPosition): If delegatesScrolling(), we never use the + newScrollPosition, so move that calculation below the delegation path. + +2010-11-17 Dave Hyatt <hyatt@apple.com> + + Reviewed by Sam Weinig. + + https://bugs.webkit.org/show_bug.cgi?id=48537 + + Fonts with no vertical metrics should synthesize baselines when they appear + on lines that do use fonts with vertical metrics. Basically we want to make + sure that English text behaves like vertical-align:middle, i.e., its baseline + should be treated as though it cuts through the middle of the ascent+descent. + + The way this works is that each line in the line box tree is labeled as having + a baseline type that is either ideographic or alphabetic for the purposes of + vertical alignment. A line becomes ideographic if any font with vertical tables + is either explicitly specified as the primary font or in any of the used fonts + in the text on that line. + + This baselineType is passed down to computeLogicalBoxHeights and placeBoxesInBlockDirection, + and passed to the ascent and descent methods of the fonts that are examined. + The underlying Font code selects an appropriate baseline given the type passed in. + + This patch also rewrites vertical alignment to lop 4 bytes off all RenderInlines and + to instead carry around the cached vertical positions for RenderInlines in a new + VerticalPositionCache object. This cache only lives for a single layout + operation, but it does cache information across all the lines built and placed during the + layout. + + This matches the old behavior, since every call to layoutInlineChildren invalidated + all of the vertical positions in all of the RenderInlines anyway. + + The VerticalPositionCache consists of two HashMaps, and it caches vertical alignment + positions for both alphabetic and ideographic baseline types. + + The vertical-align computation has now been moved out of RenderBoxModelObject and + RenderInline and just placed right into verticalPositionForBox in InlineFlowBox. + This function has been changed to no longer be recursive when checking parents, + and it now relies on the fact that the parent vertical alignment computation result + has already been stored in the logicalTop() of that parent's line box. By checking + the line box logicalTop() value instead of recurring, the performance of first lines + now significantly improves to no longer have O(n^2) behavior in the depth of the line + box tree on the first line. + + All of the baselinePosition functions on the various RenderObjects have been amended + to take a FontBaseline as the first argument. This patch does not attempt to fix up + MathML or form controls yet and just hardcodes AlphabeticBaselines for those renderers. + + The RenderTableCell baselinePosition virtual method has been made non-virtual and had + all arguments removed, since it actually had no real connection with the rest of the + baseline positioning system. Cell baseline positioning works by calling firstLineBoxBaseline, + and that method has been patched to use the cached baselineType for the first line box + when computing the baseline of that line. + + Added fast/blockflow/vertical-baseline-alignment.html and fast/blockflow/vertical-align-table-baseline.html. + + * WebCore.xcodeproj/project.pbxproj: + * mathml/RenderMathMLFraction.cpp: + (WebCore::RenderMathMLFraction::baselinePosition): + * mathml/RenderMathMLFraction.h: + * mathml/RenderMathMLOperator.cpp: + (WebCore::RenderMathMLOperator::baselinePosition): + * mathml/RenderMathMLOperator.h: + * mathml/RenderMathMLRow.cpp: + (WebCore::RenderMathMLRow::baselinePosition): + * mathml/RenderMathMLRow.h: + * mathml/RenderMathMLSubSup.cpp: + (WebCore::RenderMathMLSubSup::baselinePosition): + * mathml/RenderMathMLSubSup.h: + * mathml/RenderMathMLUnderOver.cpp: + (WebCore::RenderMathMLUnderOver::layout): + (WebCore::RenderMathMLUnderOver::baselinePosition): + * mathml/RenderMathMLUnderOver.h: + * platform/graphics/SimpleFontData.h: + * rendering/InlineBox.h: + (WebCore::InlineBox::baselinePosition): + * rendering/InlineFlowBox.cpp: + (WebCore::verticalPositionForBox): + (WebCore::InlineFlowBox::computeLogicalBoxHeights): + (WebCore::InlineFlowBox::placeBoxesInBlockDirection): + * rendering/InlineFlowBox.h: + * rendering/InlineTextBox.cpp: + (WebCore::InlineTextBox::baselinePosition): + * rendering/InlineTextBox.h: + * rendering/RenderBlock.cpp: + (WebCore::RenderBlock::baselinePosition): + (WebCore::RenderBlock::firstLineBoxBaseline): + (WebCore::RenderBlock::lastLineBoxBaseline): + * rendering/RenderBlock.h: + * rendering/RenderBlockLineLayout.cpp: + (WebCore::RenderBlock::computeBlockDirectionPositionsForLine): + (WebCore::RenderBlock::layoutInlineChildren): + * rendering/RenderBox.cpp: + (WebCore::RenderBox::baselinePosition): + * rendering/RenderBox.h: + * rendering/RenderBoxModelObject.cpp: + * rendering/RenderBoxModelObject.h: + * rendering/RenderFileUploadControl.cpp: + (WebCore::RenderFileUploadControl::paintObject): + * rendering/RenderInline.cpp: + (WebCore::RenderInline::RenderInline): + (WebCore::RenderInline::baselinePosition): + * rendering/RenderInline.h: + * rendering/RenderListBox.cpp: + (WebCore::RenderListBox::baselinePosition): + * rendering/RenderListBox.h: + * rendering/RenderListMarker.cpp: + (WebCore::RenderListMarker::baselinePosition): + * rendering/RenderListMarker.h: + * rendering/RenderSlider.cpp: + (WebCore::RenderSlider::baselinePosition): + * rendering/RenderSlider.h: + * rendering/RenderTableCell.cpp: + (WebCore::RenderTableCell::baselinePosition): + * rendering/RenderTableCell.h: + * rendering/RenderTextControlMultiLine.cpp: + (WebCore::RenderTextControlMultiLine::baselinePosition): + * rendering/RenderTextControlMultiLine.h: + * rendering/RootInlineBox.cpp: + (WebCore::RootInlineBox::alignBoxesInBlockDirection): + * rendering/RootInlineBox.h: + (WebCore::RootInlineBox::baselinePosition): + * rendering/VerticalPositionCache.h: Added. + (WebCore::VerticalPositionCache::VerticalPositionCache): + (WebCore::VerticalPositionCache::get): + (WebCore::VerticalPositionCache::set): + * rendering/svg/SVGInlineTextBox.cpp: + (WebCore::SVGInlineTextBox::calculateBoundaries): + +2010-11-17 Sam Weinig <sam@webkit.org> + + Reviewed by Anders Carlsson. + + Add stubbed out ScrollAnimator for the Mac + https://bugs.webkit.org/show_bug.cgi?id=49678 + + * WebCore.xcodeproj/project.pbxproj: + Add ScrollAnimator.h/cpp. + + * platform/mac/ScrollAnimatorMac.cpp: Added. + (WebCore::ScrollAnimator::create): + (WebCore::ScrollAnimatorMac::ScrollAnimatorMac): + (WebCore::ScrollAnimatorMac::~ScrollAnimatorMac): + (WebCore::ScrollAnimatorMac::scroll): + (WebCore::ScrollAnimatorMac::setScrollPositionAndStopAnimation): + * platform/mac/ScrollAnimatorMac.h: Added. + ScrollAnimatorMac just calls through to the base class for now. + +2010-11-17 Cris Neckar <cdn@chromium.org> + + Reviewed by Adam Barth. + + Modified codepath for object fallback content which has failed to load. + Refactored CachedResource error handling to use more granular statuses instead of a boolean value. + https://bugs.webkit.org/show_bug.cgi?id=46921 + + Test: fast/html/object-image-nested-fallback.html + + * html/HTMLObjectElement.cpp: + (WebCore::HTMLObjectElement::renderFallbackContent): + * loader/cache/CachedCSSStyleSheet.cpp: + (WebCore::CachedCSSStyleSheet::error): + * loader/cache/CachedCSSStyleSheet.h: + * loader/cache/CachedFont.cpp: + (WebCore::CachedFont::ensureCustomFontData): + (WebCore::CachedFont::error): + * loader/cache/CachedFont.h: + * loader/cache/CachedImage.cpp: + (WebCore::CachedImage::data): + (WebCore::CachedImage::error): + * loader/cache/CachedImage.h: + * loader/cache/CachedResource.cpp: + (WebCore::CachedResource::CachedResource): + (WebCore::CachedResource::canUseCacheValidator): + (WebCore::CachedResource::mustRevalidate): + * loader/cache/CachedResource.h: + (WebCore::CachedResource::error): + (WebCore::CachedResource::httpStatusCodeError): + (WebCore::CachedResource::errorOccurred): + * loader/cache/CachedScript.cpp: + (WebCore::CachedScript::error): + * loader/cache/CachedScript.h: + * loader/cache/CachedXSLStyleSheet.cpp: + (WebCore::CachedXSLStyleSheet::error): + * loader/cache/CachedXSLStyleSheet.h: + * loader/loader.cpp: + (WebCore::Loader::load): + (WebCore::Loader::didFinishLoading): + (WebCore::Loader::didFail): + (WebCore::Loader::didReceiveData): + +2010-11-16 Zhenyao Mo <zmo@google.com> + + Reviewed by Kenneth Russell. + + WebGLRenderingContext needs to zero textures and renderbuffers + https://bugs.webkit.org/show_bug.cgi?id=49355 + + Test: fast/canvas/webgl/uninitialized-test.html + + * html/canvas/WebGLFramebuffer.cpp: + (WebCore::WebGLFramebuffer::onAccess): Use a parameter to decide if renderbuffer initialization is needed. + (WebCore::WebGLFramebuffer::initializeRenderbuffers): Don't return false if color buffer doesn't exist. + * html/canvas/WebGLFramebuffer.h: Modify onAccess function signature. + * html/canvas/WebGLRenderingContext.cpp: + (WebCore::WebGLRenderingContext::clear): Call onAccess with an added parameter. + (WebCore::WebGLRenderingContext::copyTexImage2D): Ditto. + (WebCore::WebGLRenderingContext::copyTexSubImage2D): Ditto. + (WebCore::WebGLRenderingContext::drawArrays): Ditto. + (WebCore::WebGLRenderingContext::drawElements): Ditto. + (WebCore::WebGLRenderingContext::readPixels): Ditto. + (WebCore::WebGLRenderingContext::texImage2DBase): Create buffer data of 0s if input is null to initialize textures. + +2010-11-17 Ryosuke Niwa <rniwa@webkit.org> + + Reviewed by Darin Adler. + + Merge ScriptElement and ScriptElementData + https://bugs.webkit.org/show_bug.cgi?id=49647 + + Merged two classes. + + * dom/AsyncScriptRunner.cpp: + (WebCore::AsyncScriptRunner::executeScriptSoon): Takes ScriptElement* instead of ScriptElementData*. + (WebCore::AsyncScriptRunner::timerFired): Uses ScriptElement* instead of ScriptElementData*. + * dom/AsyncScriptRunner.h: + * dom/ScriptElement.cpp: + (WebCore::ScriptElement::ScriptElement): Merged with ScriptElementData::ScriptElementData. + (WebCore::ScriptElement::~ScriptElement): Merged with ScriptElementData::~ScriptElementData. + (WebCore::ScriptElement::insertedIntoDocument): Calls createdByParser, isAsynchronous, requestScript, and scriptContent. + (WebCore::ScriptElement::removedFromDocument): Calls stopLoadRequest. + (WebCore::ScriptElement::childrenChanged): Calls createdByParser and accesses m_element. + (WebCore::ScriptElement::finishParsingChildren): Calls scriptContent. + (WebCore::ScriptElement::handleSourceAttribute): Calls ignoresLoadRequest and requestScript. + (WebCore::ScriptElement::requestScript): Moved from ScriptElementData; calls dispatchErrorEvent. + (WebCore::ScriptElement::evaluateScript): Moved from ScriptElementData. + (WebCore::ScriptElement::executeScript): Ditto. + (WebCore::ScriptElement::stopLoadRequest): Ditto. + (WebCore::ScriptElement::execute): Moved from ScriptElementData; calls dispatchErrorEvent and dispatchLoadEvent. + (WebCore::ScriptElement::notifyFinished): Moved from ScriptElementData. + (WebCore::ScriptElement::ignoresLoadRequest): Ditto. + (WebCore::ScriptElement::shouldExecuteAsJavaScript): Moved from ScriptElementData; calls typeAttributeValue, languageAttributeValue, + forAttributeValue, and eventAttributeValue. + (WebCore::ScriptElement::scriptCharset): Moved from ScriptElementData. + (WebCore::ScriptElement::scriptContent): Ditto. + (WebCore::ScriptElement::isAsynchronous): Moved from ScriptElementData; calls sourceAttributeValue and asyncAttributeValue. + (WebCore::ScriptElement::isDeferred): Moved from ScriptElementData; calls sourceAttributeValue, asyncAttributeValue, + and deferAttributeValue. + * dom/ScriptElement.h: + (WebCore::ScriptElement::element): + (WebCore::ScriptElement::haveFiredLoadEvent): + (WebCore::ScriptElement::setHaveFiredLoadEvent): + (WebCore::ScriptElement::createdByParser): + (WebCore::ScriptElement::isEvaluated): + +2010-11-17 Tenghui Zhu <ztenghui@google.com> + + Reviewed by Jeremy Orlow. + + profileCallback and profileEndCallback should be guarded with ENABLE_JAVASCRIPT_DEBUGGER + https://bugs.webkit.org/show_bug.cgi?id=49623 + + No new tests. Just a compiling error fix. + + * bindings/v8/custom/V8ConsoleCustom.cpp: + Add the guard ENABLE_JAVA_SCRIPT_DEBUGGER to profileCallback and profileEndCallback + +2010-11-17 John Knottenbelt <jknotten@chromium.org> + + Reviewed by Jeremy Orlow. + + Introduce GeoNotifierVector typedef for increased readability + https://bugs.webkit.org/show_bug.cgi?id=49597 + + * page/Geolocation.cpp: + (WebCore::Geolocation::Watchers::getNotifiersVector): + (WebCore::Geolocation::sendError): + (WebCore::Geolocation::sendPosition): + (WebCore::Geolocation::stopTimer): + (WebCore::Geolocation::stopTimersForOneShots): + (WebCore::Geolocation::stopTimersForWatchers): + (WebCore::Geolocation::cancelRequests): + (WebCore::Geolocation::cancelAllRequests): + (WebCore::Geolocation::handleError): + (WebCore::Geolocation::makeSuccessCallbacks): + * page/Geolocation.h: + +2010-11-17 John Knottenbelt <jknotten@chromium.org> + + Reviewed by Jeremy Orlow. + + Convert correctly between GeolocationPosition and Geoposition + timestamp formats. + https://bugs.webkit.org/show_bug.cgi?id=48518 + + Test: fast/dom/Geolocation/timestamp.html + + * page/Geolocation.cpp: + (WebCore::createGeoposition): + +2010-11-17 Chang Shu <chang.shu@nokia.com> + + Reviewed by Antonio Gomes. + + [Mac] Suppress single select popup menu when spatial navigation is enabled on Mac. + This makes spatial navigation work properly for single select box. + + Test: fast/events/spatial-navigation/snav-single-select.html + + * dom/SelectElement.cpp: + (WebCore::nextValidIndex): + (WebCore::SelectElement::menuListDefaultEventHandler): + +2010-11-17 Satish Sampath <satish@chromium.org> + + Reviewed by Jeremy Orlow. + + Clear the speech input mock explicitly before each test. + https://bugs.webkit.org/show_bug.cgi?id=49660 + + * platform/mock/SpeechInputClientMock.cpp: + (WebCore::SpeechInputClientMock::clearResults): Added clearResults method. + * platform/mock/SpeechInputClientMock.h: + +2010-11-17 Alexander Pavlov <apavlov@chromium.org> + + [Chromium] Unreviewed, fix Chromium-Mac build from r72189. + + * css/CSSPrimitiveValue.cpp: + (WebCore::CSSPrimitiveValue::getDoubleValue): + +2010-11-17 Hans Wennborg <hans@chromium.org> + + Reviewed by Jeremy Orlow. + + IndexedDB: IDBKey::whereSyntax should impose conditions on all columns + https://bugs.webkit.org/show_bug.cgi?id=49601 + + The WHERE clause should specifiy a condition for each key column to + make sure that the ObjectStoreData_composit index can be used when + querying the object store based on key. Not using the index causes + severe performance degradation for common IDB operations. + + * storage/IDBKey.cpp: + (WebCore::IDBKey::whereSyntax): + +2010-11-17 Eric Uhrhane <ericu@chromium.org> + + Reviewed by David Levin. + + [Chromium] implementation of async FileWriter for workers + https://bugs.webkit.org/show_bug.cgi?id=47681 + + Tests are in a separate changelist. + + * platform/CrossThreadCopier.h: Changed CrossThreadCopier[Base] to support PassRefPtrs + +2010-11-17 Alejandro G. Castro <alex@igalia.com> + + Reviewed by Martin Robinson. + + [gtk] r69119 modified just the gtk2 version of the + scrolled_window_paint function but not the gtk3 version + https://bugs.webkit.org/show_bug.cgi?id=49585 + + Use gtk_paint_shadow the same as the actual code from GTK+. Avoid + using state and use the same values we are using for gtk2 in the + paint function. + + * platform/gtk/ScrollbarThemeGtk.cpp: + (WebCore::ScrollbarThemeGtk::paintButton): Initialized the + depressed attribute of the state variable to avoid using it + without initialization. + * platform/gtk/gtk3drawing.c: + (moz_gtk_scrolled_window_paint): + +2010-11-16 Alexander Pavlov <apavlov@chromium.org> + + Reviewed by Simon Fraser. + + CSSPrimitiveValue.getFloatValue does not convert sizes + https://bugs.webkit.org/show_bug.cgi?id=35770 + + Implemented all same-category unit conversions (length, angle, time, frequency) and retained + absolute-relative (cm, mm, in, pt, pc) length conversions intact. + Illegal unit conversion attempts will throw an INVALID_ACCESS_ERR DOMException. + + * css/CSSPrimitiveValue.cpp: + (WebCore::unitCategory): + (WebCore::conversionToCanonicalUnitsScaleFactor): + (WebCore::CSSPrimitiveValue::getDoubleValue): + (WebCore::CSSPrimitiveValue::canonicalUnitTypeForCategory): + (WebCore::CSSPrimitiveValue::getDoubleValueInternal): + (WebCore::CSSPrimitiveValue::getIdent): + * css/CSSPrimitiveValue.h: + (WebCore::CSSPrimitiveValue::getFloatValue): + (WebCore::CSSPrimitiveValue::getIntValue): + +2010-11-17 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org> + + Reviewed by Andreas Kling. + + Document::nodesFromRect() has wrong source code documentation + https://bugs.webkit.org/show_bug.cgi?id=49610 + + * dom/Document.h: fix nodesFromRect() documentation + +2010-11-17 Alexis Menard <alexis.menard@nokia.com>, Simon Hausmann <simon.hausmann@nokia.com> + + Reviewed by Kenneth Christiansen, Tor Arne Vestbø. + + [Qt] Add support for use GStreamer with the Qt build + + Make it possible to use gstreamer with the Qt build via the USE_GSTREAMER macro. The + integration is rather basic at this point, allowing for software based rendering + only at the moment. AC integration and fullscreen playback is still missing. + + * WebCore.pro: Added a bunch of gstreamer files to the build and guard it as a + build option with the USE_GSTREAMER macro. + * platform/graphics/MediaPlayer.cpp: + (WebCore::installedMediaEngines): Don't use the generic media player registration + when using GStreamer. These #ifdefs should be removed, but the gstreamer folks want + to be able to build with gstreamer _and_ another backend simultaenously. + * platform/graphics/gstreamer/ImageGStreamer.h: + * platform/graphics/gstreamer/ImageGStreamerQt.cpp: Added. + (ImageGStreamer::createImage): + (ImageGStreamer::ImageGStreamer): + (ImageGStreamer::~ImageGStreamer): + * platform/graphics/gstreamer/PlatformVideoWindowPrivate.h: Added. + * platform/graphics/gstreamer/PlatformVideoWindowQt.cpp: Added. + (FullScreenVideoWindow::FullScreenVideoWindow): + (FullScreenVideoWindow::keyPressEvent): + (FullScreenVideoWindow::event): + (PlatformVideoWindow::PlatformVideoWindow): + (PlatformVideoWindow::~PlatformVideoWindow): + (PlatformVideoWindow::prepareForOverlay): + +2010-11-17 Alexander Pavlov <apavlov@chromium.org> + + Reviewed by Pavel Feldman. + + Web Inspector: [REGRESSION] editing disabled styles breaks style bodies. + https://bugs.webkit.org/show_bug.cgi?id=49602 + + * inspector/InspectorStyleSheet.cpp: + (WebCore::InspectorStyle::setPropertyText): + * inspector/front-end/StylesSidebarPane.js: + (WebInspector.StylePropertyTreeElement.prototype.get name): + (WebInspector.StylePropertyTreeElement.prototype.get priority): + (WebInspector.StylePropertyTreeElement.prototype.get value): + +2010-11-16 Adam Roben <aroben@apple.com> + + Move QTMovieWin's settings into a vsprops file + + Fixes <http://webkit.org/b/49644> QTMovieWin should use a vsprops file + + Reviewed by Steve Falkenburg. + + * WebCore.vcproj/QTMovieWin.vcproj: + * WebCore.vcproj/QTMovieWinCommon.vsprops: Added. + +2010-11-16 Andy Estes <aestes@apple.com> + + Reviewed by Dave Hyatt. + + WebKit mishandles line boxes where the content height exceeds the + specified line-height. + https://bugs.webkit.org/show_bug.cgi?id=49410 + + If a line height is explicitly specified on a text box and fallback + fonts are in use, only the primary font should be considered when + computing the box's ascent and descent. This prevents the inline box + from being sized larger than the specified line height. + + This patch also fixes a math error when computing a used font's descent + in the case where line height isn't explicitly set. This change results + in a number of layout tests needing re-baselining. + + Test: fast/css/line-height-determined-by-primary-font.html + + * rendering/InlineFlowBox.cpp: + (WebCore::InlineFlowBox::computeLogicalBoxHeights): + +2010-11-15 Ryosuke Niwa <rniwa@webkit.org> + + Reviewed by Darin Adler. + + ScriptElementData should be a private member of ScriptElement + https://bugs.webkit.org/show_bug.cgi?id=49578 + + Privatized m_data of ScriptElement. Added haveFiredLoadEvent, setHaveFiredLoadEvent, createdByParser, + and isEvaluated to ScriptElement to proxy calls from HTMLScriptElement and SVGScriptElement to ScriptElementData. + + No tests are added since this is a cleanup. + + * dom/ScriptElement.h: + (WebCore::ScriptElement::haveFiredLoadEvent): Added. + (WebCore::ScriptElement::setHaveFiredLoadEvent): Added. + (WebCore::ScriptElement::createdByParser): Added. + (WebCore::ScriptElement::isEvaluated): Added. + * html/HTMLScriptElement.cpp: + (WebCore::HTMLScriptElement::dispatchLoadEvent): Calls haveFiredLoadEvent and setHaveFiredLoadEvent. + (WebCore::HTMLScriptElement::cloneElementWithoutAttributesAndChildren): Calls isEvaluated. + * html/HTMLScriptElement.h: + (WebCore::HTMLScriptElement::text): Calls scriptContent. + (WebCore::HTMLScriptElement::haveFiredLoadEvent): Calls haveFiredLoadEvent. + * svg/SVGScriptElement.cpp: + (WebCore::SVGScriptElement::svgAttributeChanged): Calls haveFiredLoadEvent and createdByParser. + (WebCore::SVGScriptElement::insertedIntoDocument): Calls createdByParser. + (WebCore::SVGScriptElement::finishParsingChildren): Calls setHaveFiredLoadEvent. + (WebCore::SVGScriptElement::haveLoadedRequiredResources): Ditto. + (WebCore::SVGScriptElement::dispatchLoadEvent): Calls haveFiredLoadEvent. + (WebCore::SVGScriptElement::cloneElementWithoutAttributesAndChildren): Calls createdByParser, + haveFiredLoadEvent, and setHaveFiredLoadEvent. + +2010-11-16 Antti Koivisto <antti@apple.com> + + Reviewed by Darin Adler. + + https://bugs.webkit.org/show_bug.cgi?id=49320 + Minor ResourceLoadScheduler cleanups + + * loader/ResourceLoadScheduler.cpp: + (WebCore::ResourceLoadScheduler::scheduleLoad): + (WebCore::ResourceLoadScheduler::servePendingRequests): + (WebCore::ResourceLoadScheduler::HostInformation::~HostInformation): + (WebCore::ResourceLoadScheduler::HostInformation::remove): + (WebCore::ResourceLoadScheduler::HostInformation::hasRequests): + * loader/ResourceLoadScheduler.h: + +2010-11-16 Dave Hyatt <hyatt@apple.com> + + Reviewed by Sam Weinig. + + Add a baselineType member to RootInlineBox that caches whether the default baseline behavior for that + line should be ideographic or alphabetic. Add a requiresIdeographicsBaseline recursive function to + InlineFlowBox that scans for the use of any vertical fonts. + + * rendering/InlineFlowBox.cpp: + (WebCore::InlineFlowBox::requiresIdeographicBaseline): + * rendering/InlineFlowBox.h: + * rendering/RootInlineBox.cpp: + (WebCore::RootInlineBox::RootInlineBox): + (WebCore::RootInlineBox::alignBoxesInBlockDirection): + * rendering/RootInlineBox.h: + (WebCore::RootInlineBox::baselineType): + +2010-11-16 Dave Hyatt <hyatt@apple.com> + + Reviewed by Sam Weinig. + + Add FontBaseline.h and make ascent and descent take a baseline parameter so that both an + alphabetic and ideographic baseline can be requested. + + * WebCore.xcodeproj/project.pbxproj: + * platform/graphics/Font.h: + (WebCore::Font::ascent): + (WebCore::Font::descent): + * platform/graphics/FontBaseline.h: Added. + * platform/graphics/SimpleFontData.h: + (WebCore::SimpleFontData::ascent): + (WebCore::SimpleFontData::descent): + (WebCore::SimpleFontData::height): + +2010-11-16 Antti Koivisto <koivisto@iki.fi> + + Reviewed by Adam Barth. + + https://bugs.webkit.org/show_bug.cgi?id=31223 + Make primitive values immutable. + + Make CSSPrimitiveValue setFloatValue and setStringValue always throw NO_MODIFICATION_ALLOWED exception. + + Reasoning: + - these setters never worked correctly, style was not invalidated so changing values would have no effect on rendering + - computed style is immutable in all cases, and it wasn't + - no other engine seems to support mutable primitives, as a result there is no content using these APIs + - mutable primitive values are pointless, the usual way to change the value of a propertly is to replace it with a new value + - allowing mutation of primitive values makes optimizations harder + + * css/CSSPrimitiveValue.cpp: + (WebCore::CSSPrimitiveValue::setFloatValue): + (WebCore::CSSPrimitiveValue::setStringValue): + +2010-11-16 Steve Falkenburg <sfalken@apple.com> + + Reviewed by Adam Roben. + + Disable LTCG for Windows Release builds. Add new Release_LTCG configuration. + https://bugs.webkit.org/show_bug.cgi?id=49632 + + * WebCore.vcproj/QTMovieWin.vcproj: + * WebCore.vcproj/WebCore.make: + * WebCore.vcproj/WebCore.sln: + * WebCore.vcproj/WebCore.vcproj: + +2010-11-16 Anders Carlsson <andersca@apple.com> + + Reviewed by John Sullivan. + + Set the original URL for downloads + https://bugs.webkit.org/show_bug.cgi?id=49628 + + Export symbols needed by WebKit2. + + * WebCore.exp.in: + +2010-11-16 Dave Hyatt <hyatt@apple.com> + + Reviewed by Dan Bernstein. + + https://bugs.webkit.org/show_bug.cgi?id=11004 + + font-size:0 is ignored. Remove the minimum font size of 1 in CSSStyleSelector. + Change the pref value for minimum font size from 1 to 0. Make sure to never use the NSFont's size, + since it doesn't honor a size of 0. Instead pass the size in to the FontPlatformData(NSFont*) version + of the constructor rather than using [NSFont pointSize]. + + https://bugs.webkit.org/show_bug.cgi?id=49582 + + Negative leading is not handled correctly. There are two bugs here. The first is that + maxAscent and maxDescent can be negative, so we need a notion of whether or not we have + set them before so that we can allow them to be < 0. + + The second issue is that we should understand where fonts will end up relative to + our baseline (excluding line height), and only allow those boxes to impact ascent and + descent if the actual font box (without factoring in line height) is above or below the + root line box baseline. + + Added fast/css/negative-leading.html + + These two bug fixes have to land together to keep the Acid 3 test rendering correctly. + + * WebCore.exp.in: + * css/CSSStyleSelector.cpp: + (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize): + * platform/graphics/cocoa/FontPlatformData.h: + * platform/graphics/cocoa/FontPlatformDataCocoa.mm: + (WebCore::FontPlatformData::FontPlatformData): + * platform/graphics/mac/FontCacheMac.mm: + (WebCore::FontCache::getFontDataForCharacters): + (WebCore::FontCache::createFontPlatformData): + * platform/graphics/mac/SimpleFontDataMac.mm: + (WebCore::SimpleFontData::smallCapsFontData): + * rendering/InlineFlowBox.cpp: + (WebCore::InlineFlowBox::computeLogicalBoxHeights): + * rendering/InlineFlowBox.h: + * rendering/RootInlineBox.cpp: + (WebCore::RootInlineBox::alignBoxesInBlockDirection): + +2010-11-16 Darin Adler <darin@apple.com> + + https://bugs.webkit.org/show_bug.cgi?id=49611 + REGRESSION (r72115): 5 layout tests are broken + + * loader/FrameLoader.cpp: + (WebCore::FrameLoader::loadFrameRequest): Roll change from + https://bugs.webkit.org/show_bug.cgi?id=48603 out. I'll roll + it back in after fixing the failing tests. + +2010-11-16 Dan Bernstein <mitz@apple.com> + + Reviewed by Simon Fraser. + + <rdar://problem/8672000> REGRESSION (r72040): Error image with alt text can cause style to be frozen in a subtree + https://bugs.webkit.org/show_bug.cgi?id=49579 + + r72040 introduced a call to setNeedsStyleRecalc() from RenderImage::imageChanged(). When imageChanged() + got called beneath recalcStyle() on some ancestor element, the result was that the ancestor’s + childNeedsStyleRecalc flag got cleared, but its descendants all the way down to the image did not. + Thereafter, setNeedsStyleRecalc() would fail to propagate from that subtree up to the root. The fix + is to avoid the newly-added setNeedsStyleRecalc() in most cases, including during reclacStyle(), and + just keep it for when it is needed. + + Tests: fast/block/float/015.html + fast/images/style-access-during-imageChanged-style-freeze.html + + * dom/Document.cpp: + (WebCore::Document::isPendingStyleRecalc): Added. + * dom/Document.h: + * rendering/RenderImage.cpp: + (WebCore::RenderImage::imageChanged): Only defer intrinsic size compoutation if a style recalc + is coming (indicating that current style() is stale). + +2010-11-11 Zhenyao Mo <zmo@google.com> + + Reviewed by Kenneth Russell. + + Implement UNPACK_COLORSPACE_CONVERSION_WEBGL + https://bugs.webkit.org/show_bug.cgi?id=47196 + + * html/canvas/WebGLRenderingContext.cpp: + (WebCore::WebGLRenderingContext::texImage2DImpl): Apply UNPACK_COLORSPACE_CONVERSION settings to image uploading. + (WebCore::WebGLRenderingContext::texSubImage2DImpl): Ditto. + * platform/graphics/GraphicsContext3D.cpp: + (WebCore::GraphicsContext3D::extractImageData): Ditto. + * platform/graphics/GraphicsContext3D.h: + * platform/graphics/ImageSource.cpp: + (WebCore::ImageSource::ImageSource): Add ignoreGammaColorProfile parameter. + (WebCore::ImageSource::setData): Ditto. + * platform/graphics/ImageSource.h: + * platform/graphics/cg/GraphicsContext3DCG.cpp: + (WebCore::GraphicsContext3D::getImageData): Ditto. + * platform/graphics/cg/ImageSourceCG.cpp: + (WebCore::ImageSource::ImageSource): Ditto. + * platform/graphics/qt/GraphicsContext3DQt.cpp: + (WebCore::GraphicsContext3D::getImageData): Ditto. + * platform/graphics/qt/ImageDecoderQt.cpp: + (WebCore::ImageDecoder::create): Ditto. + (WebCore::ImageDecoderQt::ImageDecoderQt): Ditto. + * platform/graphics/qt/ImageDecoderQt.h: + * platform/graphics/skia/GraphicsContext3DSkia.cpp: + (WebCore::GraphicsContext3D::getImageData): Ditto. + * platform/image-decoders/ImageDecoder.cpp: + (WebCore::ImageDecoder::create): Ditto. + * platform/image-decoders/ImageDecoder.h: + (WebCore::ImageDecoder::ImageDecoder): Ditto. + * platform/image-decoders/bmp/BMPImageDecoder.cpp: + (WebCore::BMPImageDecoder::BMPImageDecoder): + * platform/image-decoders/bmp/BMPImageDecoder.h: + * platform/image-decoders/gif/GIFImageDecoder.cpp: + (WebCore::GIFImageDecoder::GIFImageDecoder): Ditto. + * platform/image-decoders/gif/GIFImageDecoder.h: + * platform/image-decoders/ico/ICOImageDecoder.cpp: + (WebCore::ICOImageDecoder::ICOImageDecoder): Ditto. + (WebCore::ICOImageDecoder::decodeAtIndex): Ditto. + * platform/image-decoders/ico/ICOImageDecoder.h: + * platform/image-decoders/jpeg/JPEGImageDecoder.cpp: + (WebCore::JPEGImageDecoder::JPEGImageDecoder): Ditto. + * platform/image-decoders/jpeg/JPEGImageDecoder.h: + * platform/image-decoders/png/PNGImageDecoder.cpp: + (WebCore::PNGImageDecoder::PNGImageDecoder): Ditto. + (WebCore::PNGImageDecoder::headerAvailable): Ignore gamma settings if ignoreGammaAndColorProfile is true. + * platform/image-decoders/png/PNGImageDecoder.h: + * platform/image-decoders/webp/WEBPImageDecoder.cpp: + (WebCore::WEBPImageDecoder::WEBPImageDecoder): Add ignoreGammaAndColorProfile parameter. + * platform/image-decoders/webp/WEBPImageDecoder.h: + +2010-11-16 Eric Carlson <eric.carlson@apple.com> + + Unreviewed attempt to fix GTK build after http://trac.webkit.org/changeset/72117 + + * platform/graphics/MediaPlayer.cpp: + (WebCore::installedMediaEngines): + +2010-11-12 Zhenyao Mo <zmo@google.com> + + Reviewed by Kenneth Russell. + + Refactor GL backend flags + https://bugs.webkit.org/show_bug.cgi?id=49460 + + * html/canvas/WebGLRenderingContext.cpp: + (WebCore::WebGLRenderingContext::WebGLRenderingContext): Call setupFlags(). + (WebCore::WebGLRenderingContext::initializeNewContext): Remove flag initialization to setupFlags(). + (WebCore::WebGLRenderingContext::setupFlags): Initialize GL flags. + (WebCore::WebGLRenderingContext::getRenderbufferParameter): Use accessor function instead of member. + (WebCore::WebGLRenderingContext::renderbufferStorage): Ditto. + * html/canvas/WebGLRenderingContext.h: Use flags set in setupFlags instead of querying underlying GL implementation. + (WebCore::WebGLRenderingContext::isGLES2Compliant): + (WebCore::WebGLRenderingContext::isGLES2NPOTStrict): + (WebCore::WebGLRenderingContext::isErrorGeneratedOnOutOfBoundsAccesses): + (WebCore::WebGLRenderingContext::isResourceSafe): + (WebCore::WebGLRenderingContext::isDepthStencilSupported): + * platform/graphics/Extensions3D.h: Add NPOT extension. + * platform/graphics/GraphicsContext3D.h: Remove GL flag queries at this level. + * platform/graphics/chromium/Extensions3DChromium.h: Add resource_safe and strict_attribs extensions. + * platform/graphics/mac/GraphicsContext3DMac.mm: Remove GL flag queries at this level. + +2010-11-16 Kenneth Russell <kbr@google.com> + + Reviewed by Dimitri Glazkov. + + WebIDL conversions from string to number and array to number should not generate TypeError + https://bugs.webkit.org/show_bug.cgi?id=49218 + + Recent SVG-related changes to the StrictTypeChecking extended attribute in + CodeGeneratorJS.pm and CodeGeneratorV8.pm were not correct according to the Web IDL and + ECMA-262 specifications. In particular, when an attribute or function argument is specified + as a number type (floating-point or integer), passing in a String or object is not supposed + to raise an exception. + + The original intent of the StrictTypeChecking extended attribute was to properly raise + TypeError when an interface type is required, but the supplied object does not implement the + interface type (http://dev.w3.org/2006/webapi/WebIDL/#es-interface). Historically WebKit has + silently passed null to the C++ bindings in this case. The handling of strings in the + original StrictTypeChecking implementation was also incorrect, raising exceptions when it + should not. + + The semantics of StrictTypeChecking have been changed to enforce only the restrictions on + interface types. The V8 custom bindings for WebGL have been updated to match the behavior of + the autogenerated code. + + Test: fast/canvas/webgl/type-conversion-test.html + + * bindings/scripts/CodeGeneratorJS.pm: + * bindings/scripts/CodeGeneratorV8.pm: + * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: + (WebCore::getObjectParameter): + (WebCore::V8WebGLRenderingContext::getFramebufferAttachmentParameterCallback): + (WebCore::V8WebGLRenderingContext::getParameterCallback): + (WebCore::V8WebGLRenderingContext::getProgramParameterCallback): + (WebCore::V8WebGLRenderingContext::getShaderParameterCallback): + (WebCore::vertexAttribAndUniformHelperf): + +2010-11-16 Alexey Proskuryakov <ap@apple.com> + + Windows build fix. + + * DerivedSources.cpp: Removing CSS Variables generated files. + +2010-11-16 Eric Carlson <eric.carlson@apple.com> + + Reviewed by John Sullivan. + + getMIMEType(s)ForExtension should consult system mapping + https://bugs.webkit.org/show_bug.cgi?id=49497 + + No new tests possible. + + * platform/MIMETypeRegistry.cpp: + (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension): Add the type returned by getMIMETypeForExtension. + Put the result of mediaMIMETypeMap().get() in a local variable and test instead of calling + constains() and then get(). + (WebCore::MIMETypeRegistry::getMediaMIMETypesForExtension): Ditto. + +2010-11-16 Eric Carlson <eric.carlson@apple.com> + + Reviewed by Darin Adler. + + Rename QTKit based media engine class name + https://bugs.webkit.org/show_bug.cgi?id=36663 + + No new tests as this just renames a class and restructures existing code. + + * platform/graphics/MediaPlayer.cpp: + (WebCore::installedMediaEngines): Use a macro with the platform media player class name to reduce the + number of #ifs in the code. + + * platform/graphics/mac/MediaPlayerPrivateQTKit.h: Rename MediaPlayerPrivate to MediaPlayerPrivateQTKit. + * platform/graphics/mac/MediaPlayerPrivateQTKit.mm: + (WebCore::MediaPlayerPrivateQTKit::create): + (WebCore::MediaPlayerPrivateQTKit::registerMediaEngine): + (WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit): + (WebCore::MediaPlayerPrivateQTKit::~MediaPlayerPrivateQTKit): + (WebCore::MediaPlayerPrivateQTKit::createQTMovie): + (WebCore::MediaPlayerPrivateQTKit::createQTMovieView): + (WebCore::MediaPlayerPrivateQTKit::detachQTMovieView): + (WebCore::MediaPlayerPrivateQTKit::createQTVideoRenderer): + (WebCore::MediaPlayerPrivateQTKit::destroyQTVideoRenderer): + (WebCore::MediaPlayerPrivateQTKit::createQTMovieLayer): + (WebCore::MediaPlayerPrivateQTKit::destroyQTMovieLayer): + (WebCore::MediaPlayerPrivateQTKit::currentRenderingMode): + (WebCore::MediaPlayerPrivateQTKit::preferredRenderingMode): + (WebCore::MediaPlayerPrivateQTKit::setUpVideoRendering): + (WebCore::MediaPlayerPrivateQTKit::tearDownVideoRendering): + (WebCore::MediaPlayerPrivateQTKit::hasSetUpVideoRendering): + (WebCore::MediaPlayerPrivateQTKit::createQTTime): + (WebCore::MediaPlayerPrivateQTKit::resumeLoad): + (WebCore::MediaPlayerPrivateQTKit::load): + (WebCore::MediaPlayerPrivateQTKit::loadInternal): + (WebCore::MediaPlayerPrivateQTKit::prepareToPlay): + (WebCore::MediaPlayerPrivateQTKit::platformMedia): + (WebCore::MediaPlayerPrivateQTKit::platformLayer): + (WebCore::MediaPlayerPrivateQTKit::play): + (WebCore::MediaPlayerPrivateQTKit::pause): + (WebCore::MediaPlayerPrivateQTKit::duration): + (WebCore::MediaPlayerPrivateQTKit::currentTime): + (WebCore::MediaPlayerPrivateQTKit::seek): + (WebCore::MediaPlayerPrivateQTKit::doSeek): + (WebCore::MediaPlayerPrivateQTKit::cancelSeek): + (WebCore::MediaPlayerPrivateQTKit::seekTimerFired): + (WebCore::MediaPlayerPrivateQTKit::paused): + (WebCore::MediaPlayerPrivateQTKit::seeking): + (WebCore::MediaPlayerPrivateQTKit::naturalSize): + (WebCore::MediaPlayerPrivateQTKit::hasVideo): + (WebCore::MediaPlayerPrivateQTKit::hasAudio): + (WebCore::MediaPlayerPrivateQTKit::supportsFullscreen): + (WebCore::MediaPlayerPrivateQTKit::setVolume): + (WebCore::MediaPlayerPrivateQTKit::hasClosedCaptions): + (WebCore::MediaPlayerPrivateQTKit::setClosedCaptionsVisible): + (WebCore::MediaPlayerPrivateQTKit::setRate): + (WebCore::MediaPlayerPrivateQTKit::setPreservesPitch): + (WebCore::MediaPlayerPrivateQTKit::buffered): + (WebCore::MediaPlayerPrivateQTKit::maxTimeSeekable): + (WebCore::MediaPlayerPrivateQTKit::maxTimeLoaded): + (WebCore::MediaPlayerPrivateQTKit::bytesLoaded): + (WebCore::MediaPlayerPrivateQTKit::totalBytes): + (WebCore::MediaPlayerPrivateQTKit::cancelLoad): + (WebCore::MediaPlayerPrivateQTKit::cacheMovieScale): + (WebCore::MediaPlayerPrivateQTKit::isReadyForVideoSetup): + (WebCore::MediaPlayerPrivateQTKit::prepareForRendering): + (WebCore::MediaPlayerPrivateQTKit::updateStates): + (WebCore::MediaPlayerPrivateQTKit::loadStateChanged): + (WebCore::MediaPlayerPrivateQTKit::rateChanged): + (WebCore::MediaPlayerPrivateQTKit::sizeChanged): + (WebCore::MediaPlayerPrivateQTKit::timeChanged): + (WebCore::MediaPlayerPrivateQTKit::didEnd): + (WebCore::MediaPlayerPrivateQTKit::setSize): + (WebCore::MediaPlayerPrivateQTKit::setVisible): + (WebCore::MediaPlayerPrivateQTKit::hasAvailableVideoFrame): + (WebCore::MediaPlayerPrivateQTKit::repaint): + (WebCore::MediaPlayerPrivateQTKit::paintCurrentFrameInContext): + (WebCore::MediaPlayerPrivateQTKit::paint): + (WebCore::MediaPlayerPrivateQTKit::getSupportedTypes): + (WebCore::MediaPlayerPrivateQTKit::supportsType): + (WebCore::MediaPlayerPrivateQTKit::isAvailable): + (WebCore::MediaPlayerPrivateQTKit::disableUnsupportedTracks): + (WebCore::MediaPlayerPrivateQTKit::sawUnsupportedTracks): + (WebCore::MediaPlayerPrivateQTKit::supportsAcceleratedRendering): + (WebCore::MediaPlayerPrivateQTKit::acceleratedRenderingStateChanged): + (WebCore::MediaPlayerPrivateQTKit::hasSingleSecurityOrigin): + (WebCore::MediaPlayerPrivateQTKit::movieLoadType): + (WebCore::MediaPlayerPrivateQTKit::setPreload): + (WebCore::MediaPlayerPrivateQTKit::mediaTimeForTimeValue): + (-[WebCoreMovieObserver initWithCallback:]): + +2010-11-16 Alexey Proskuryakov <ap@apple.com> + + Reviewed by Dave Hyatt. + + https://bugs.webkit.org/show_bug.cgi?id=49483 + Remove CSS Variable support + + * Android.derived.jscbindings.mk: + * Android.derived.v8bindings.mk: + * Android.mk: + * CMakeLists.txt: + * DerivedSources.make: + * GNUmakefile.am: + * WebCore.gypi: + * WebCore.pri: + * WebCore.pro: + * WebCore.vcproj/WebCore.vcproj: + * WebCore.xcodeproj/project.pbxproj: + * bindings/js/JSCSSRuleCustom.cpp: + (WebCore::toJS): + * bindings/v8/custom/V8DOMWindowCustom.cpp + * bindings/objc/DOMCSS.mm: + (kitClass): + * bindings/scripts/CodeGeneratorJS.pm: + * css/CSSComputedStyleDeclaration.cpp: + (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): + * css/CSSGrammar.y: + * css/CSSMutableStyleDeclaration.cpp: + (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration): + (WebCore::CSSMutableStyleDeclaration::removeProperty): + (WebCore::CSSMutableStyleDeclaration::addParsedProperties): + (WebCore::CSSMutableStyleDeclaration::copy): + * css/CSSMutableStyleDeclaration.h: + (WebCore::CSSMutableStyleDeclaration::create): + * css/CSSParser.cpp: + (WebCore::CSSParser::CSSParser): + (WebCore::CSSParser::~CSSParser): + (WebCore::CSSParser::parseValue): + (WebCore::CSSParser::lex): + (WebCore::CSSParser::recheckAtKeyword): + (WebCore::CSSParser::text): + (WebCore::CSSParser::createMediaRule): + (WebCore::CSSParser::createKeyframesRule): + (WebCore::CSSParser::createStyleRule): + (WebCore::CSSParser::createFontFaceRule): + (WebCore::CSSParser::addNamespace): + (WebCore::CSSParser::createPageRule): + * css/CSSParser.h: + * css/CSSParserValues.cpp: + (WebCore::CSSParserValueList::addValue): + (WebCore::CSSParserValueList::deleteValueAt): + (WebCore::CSSParserValue::createCSSValue): + * css/CSSParserValues.h: + (WebCore::CSSParserValueList::CSSParserValueList): + * css/CSSPrimitiveValue.cpp: + (WebCore::CSSPrimitiveValue::cleanup): + (WebCore::CSSPrimitiveValue::getStringValue): + (WebCore::CSSPrimitiveValue::cssText): + (WebCore::CSSPrimitiveValue::parserValue): + * css/CSSPrimitiveValue.h: + * css/CSSProperty.cpp: + (WebCore::CSSProperty::cssText): + * css/CSSPropertyNames.in: + * css/CSSRule.h: + * css/CSSRule.idl: + * css/CSSStyleDeclaration.cpp: + (WebCore::CSSStyleDeclaration::copyPropertiesInSet): + * css/CSSStyleSelector.cpp: + (WebCore::CSSStyleSelector::addMatchedDeclaration): + (WebCore::CSSRuleSet::addRulesFromSheet): + (WebCore::CSSStyleSelector::applyProperty): + * css/CSSStyleSelector.h: + * css/CSSValue.h: + * css/CSSVariableDependentValue.cpp: Removed. + * css/CSSVariableDependentValue.h: Removed. + * css/CSSVariablesDeclaration.cpp: Removed. + * css/CSSVariablesDeclaration.h: Removed. + * css/CSSVariablesDeclaration.idl: Removed. + * css/CSSVariablesRule.cpp: Removed. + * css/CSSVariablesRule.h: Removed. + * css/CSSVariablesRule.idl: Removed. + * css/StyleBase.h: + (WebCore::StyleBase::isMediaRule): + * css/tokenizer.flex: + * page/DOMWindow.idl: + +2010-11-16 Darin Adler <darin@apple.com> + + Reviewed by Sam Weinig. + + https://bugs.webkit.org/show_bug.cgi?id=48603 + Boolean logic mistake in local file check + + * loader/FrameLoader.cpp: + (WebCore::FrameLoader::loadFrameRequest): Fix logic so that both checks have to pass + before accepting a local file load. + +2010-11-15 Darin Adler <darin@apple.com> + + Reviewed by Sam Weinig. + + Harden additional string functions against large lengths + https://bugs.webkit.org/show_bug.cgi?id=49574 + + * platform/text/TextCodecUTF16.cpp: + (WebCore::TextCodecUTF16::encode): Check for length that is + too large for size_t. + + * platform/text/TextStream.cpp: + (WebCore::TextStream::operator<<): Check for length that is + too large for size_t. + +2010-11-16 Pavel Feldman <pfeldman@chromium.org> + + Not reviewed. Touching inspector controller to make gtk / qt happier. + + * inspector/InspectorController.cpp: + +2010-11-16 Carlos Garcia Campos <cgarcia@igalia.com> + + Reviewed by Martin Robinson. + + [GTK] Use gdk_pixbuf_get_from_surface() when available + https://bugs.webkit.org/show_bug.cgi?id=49532 + + * platform/graphics/gtk/GdkCairoUtilities.cpp: + (cairoImageSurfaceToGdkPixbuf): + +2010-11-16 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Yury Semikhatsky. + + Web Inspector: init front-end UI upon DOMContentLoaded, not load event. + https://bugs.webkit.org/show_bug.cgi?id=49596 + + * inspector/front-end/inspector.js: + (windowLoaded): + +2010-11-15 Alexander Pavlov <apavlov@chromium.org> + + Reviewed by Pavel Feldman. + + Web Inspector: Migrate frontend to the new CSS editing/retrieval API + https://bugs.webkit.org/show_bug.cgi?id=49492 + + Test: inspector/styles-new-API.html + + * inspector/front-end/AuditRules.js: + (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback): + (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.routine): + (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback): + (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback): + (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback): + (WebInspector.AuditRules.UnusedCssRule.prototype.doRun): + (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun): + (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.receivedImages): + * inspector/front-end/CSSStyleModel.js: + (WebInspector.CSSStyleModel.prototype.getStylesAsync): + (WebInspector.CSSStyleModel.prototype.getComputedStyleAsync): + (WebInspector.CSSStyleModel.prototype.getInlineStyleAsync): + (WebInspector.CSSStyleModel.prototype.setRuleSelector): + (WebInspector.CSSStyleModel.prototype.setRuleSelector.callback): + (WebInspector.CSSStyleModel.prototype.addRule): + (WebInspector.CSSStyleModel.prototype.addRule.callback): + (WebInspector.CSSStyleDeclaration): + (WebInspector.CSSStyleDeclaration.prototype.propertyAt): + (WebInspector.CSSStyleDeclaration.prototype.pastLastSourcePropertyIndex): + (WebInspector.CSSStyleDeclaration.prototype.newBlankProperty): + (WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt): + (WebInspector.CSSStyleDeclaration.prototype.appendProperty): + (WebInspector.CSSRule): + (WebInspector.CSSProperty.prototype.get propertyText): + (WebInspector.CSSProperty.prototype.setText): + (WebInspector.CSSProperty.prototype.setDisabled): + (WebInspector.CSSStyleSheet): + (WebInspector.CSSStyleSheet.createForId): + (WebInspector.CSSStyleSheet.prototype.getText): + (WebInspector.CSSStyleSheet.prototype.setText): + * inspector/front-end/Settings.js: + * inspector/front-end/StylesSidebarPane.js: + (WebInspector.StylePropertiesSection.prototype.onpopulate): + (WebInspector.StylePropertiesSection.prototype.addNewBlankProperty): + (WebInspector.StylePropertiesSection.prototype._debugShowStyle.removeStyleBox): + (WebInspector.StylePropertiesSection.prototype._debugShowStyle): + (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted): + (WebInspector.StylePropertyTreeElement.prototype): + (WebInspector.StylePropertyTreeElement.prototype.): + * inspector/front-end/inspector.css: + (.styles-section .properties li.not-parsed-ok): + (.styles-section .properties li.not-parsed-ok::before): + (.styles-section .properties .inactive): + +2010-11-16 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r72082. + http://trac.webkit.org/changeset/72082 + https://bugs.webkit.org/show_bug.cgi?id=49594 + + "broken SnowLeopard build" (Requested by apavlov on #webkit). + + * css/CSSPrimitiveValue.cpp: + (WebCore::scaleFactorForConversion): + (WebCore::CSSPrimitiveValue::getDoubleValue): + (WebCore::CSSPrimitiveValue::getIdent): + * css/CSSPrimitiveValue.h: + (WebCore::CSSPrimitiveValue::getFloatValue): + (WebCore::CSSPrimitiveValue::getIntValue): + +2010-11-16 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r72087. + http://trac.webkit.org/changeset/72087 + https://bugs.webkit.org/show_bug.cgi?id=49593 + + "broken build" (Requested by apavlov on #webkit). + + * css/CSSPrimitiveValue.cpp: + (WebCore::unitCategory): + +2010-11-15 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Yury Semikhatsky. + + Web Inspector: rename StoragePanel to ResourcesPanel. + https://bugs.webkit.org/show_bug.cgi?id=49534 + + * WebCore.gypi: + * WebCore.vcproj/WebCore.vcproj: + * inspector/front-end/DatabaseQueryView.js: + (WebInspector.DatabaseQueryView.prototype._queryFinished): + * inspector/front-end/DatabaseTableView.js: + (WebInspector.DatabaseTableView.prototype._queryFinished): + * inspector/front-end/ExtensionServer.js: + (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource): + * inspector/front-end/Images/storageIcon.png: Removed. + * inspector/front-end/ResourceManager.js: + (WebInspector.ResourceManager.prototype.setOverrideContent): + (WebInspector.ResourceTreeModel.prototype.addOrUpdateFrame): + (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame): + (WebInspector.ResourceTreeModel.prototype.frameDetachedFromParent): + (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources): + (WebInspector.ResourceTreeModel.prototype.addResourceToFrame): + * inspector/front-end/StoragePanel.js: Removed. + * inspector/front-end/WebKit.qrc: + * inspector/front-end/inspector.css: + (.resources.panel .sidebar): + (.resources.panel .sidebar li): + (.resources.panel .sidebar li.parent): + (.resources.panel .sidebar li.selected): + (.resources.panel .sidebar li.selected .selection): + (.resources.panel .sidebar :focus li.selected .selection): + (body.inactive .resources.panel .sidebar li.selected .selection): + (.resources.panel .sidebar .icon): + (.resources.panel .base-storage-tree-element-title): + (.resources.panel .status): + (.resources.panel li .status .bubble): + * inspector/front-end/inspector.html: + * inspector/front-end/inspector.js: + (WebInspector._createPanels): + (WebInspector.openResource): + (WebInspector.showPanel): + (WebInspector.selectDatabase): + (WebInspector.selectDOMStorage): + (WebInspector.addDatabase): + (WebInspector.addDOMStorage): + (WebInspector.updateDOMStorage): + (WebInspector.updateApplicationCacheStatus): + (WebInspector.didGetFileSystemPath): + (WebInspector.didGetFileSystemError): + (WebInspector.didGetFileSystemDisabled): + (WebInspector.updateNetworkState): + (WebInspector._choosePanelToShowSourceLine): + +2010-11-16 Alexander Pavlov <apavlov@chromium.org> + + Unreviewed SnowLeopard build fix. + + * css/CSSPrimitiveValue.cpp: + (WebCore::unitCategory): + +2010-11-16 Kenneth Rohde Christiansen <kenneth@webkit.org> + + Reviewed by Andreas Kling. + + Viewport meta tag: Fix geometry computation + + Available width and height should also be divided by the device pixel ratio. + + * dom/ViewportArguments.cpp: + (WebCore::computeViewportAttributes): + * platform/network/qt/DnsPrefetchHelper.cpp: + +2010-11-12 Alexander Pavlov <apavlov@chromium.org> + + Reviewed by Simon Fraser. + + CSSPrimitiveValue.getFloatValue does not convert sizes + https://bugs.webkit.org/show_bug.cgi?id=35770 + + Implemented all same-category unit conversions (length, angle, time, frequency) and retained + absolute-relative (cm, mm, in, pt, pc) length conversions intact. + Illegal unit conversion attempts will throw an INVALID_ACCESS_ERR DOMException. + + * css/CSSPrimitiveValue.cpp: + (WebCore::unitCategory): + (WebCore::scaleFactorForConversion): + (WebCore::CSSPrimitiveValue::getDoubleValue): + (WebCore::CSSPrimitiveValue::canonicalUnitTypeForCategory): + (WebCore::CSSPrimitiveValue::getDoubleValueInternal): + * css/CSSPrimitiveValue.h: + +2010-11-15 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Yury Semikhatsky. + + Web Inspector: extract HTML title setter in treeoutline.js. + https://bugs.webkit.org/show_bug.cgi?id=49540 + + * inspector/front-end/ElementsTreeOutline.js: + (WebInspector.ElementsTreeElement.prototype.adjustCollapsedRange): + (WebInspector.ElementsTreeElement.prototype.updateTitle): + * inspector/front-end/treeoutline.js: + (TreeElement.prototype.get titleHTML): + (TreeElement.prototype.set titleHTML): + (TreeElement.prototype._setListItemNodeContent): + +2010-11-16 John Knottenbelt <jknotten@chromium.org> + + Reviewed by Jeremy Orlow. + + Assert that DeviceOrientationClientMock is used by only one controller. + https://bugs.webkit.org/show_bug.cgi?id=48506 + + This is a design constraint of the DeviceOrientationClientMock because the + m_controller field can only store a pointer to a single instance of the + corresponding DeviceOrientationController. + + * platform/mock/DeviceOrientationClientMock.cpp: + (WebCore::DeviceOrientationClientMock::setController): + +2010-11-16 Mihai Parparita <mihaip@chromium.org> + + Reviewed by Adam Barth. + + fast/images/size-failure.html results in malloc of 2 Gb after switching to WebKit image decoders + https://bugs.webkit.org/show_bug.cgi?id=48634 + + Specify the capacity when calling CFDataCreateMutable, which can signal + malloc failures (by returning NULL), unlike CFDataSetLength. + + * platform/image-decoders/cg/ImageDecoderCG.cpp: + (WebCore::RGBA32Buffer::setSize): + +2010-11-15 Rob Buis <rwlbuis@gmail.com> + + Reviewed by Dirk Schulze and Darin Adler. + + requiredFeatures does not adapt to SVGStringList changes + https://bugs.webkit.org/show_bug.cgi?id=40887 + + Centralize the const_cast handling and only do it if needed. + Remove the const_cast in all svgAttributeChanged functions and move + it to SVGTest::handleAttributeChange. Add an early return to + handleAttributeChange to avoid unnecessary const_casts. + + No tests necessary as functionality has not changed. + + * svg/SVGCircleElement.cpp: + (WebCore::SVGCircleElement::svgAttributeChanged): + * svg/SVGEllipseElement.cpp: + (WebCore::SVGEllipseElement::svgAttributeChanged): + * svg/SVGForeignObjectElement.cpp: + (WebCore::SVGForeignObjectElement::svgAttributeChanged): + * svg/SVGGElement.cpp: + (WebCore::SVGGElement::svgAttributeChanged): + * svg/SVGImageElement.cpp: + (WebCore::SVGImageElement::svgAttributeChanged): + * svg/SVGLineElement.cpp: + (WebCore::SVGLineElement::svgAttributeChanged): + * svg/SVGPathElement.cpp: + (WebCore::SVGPathElement::svgAttributeChanged): + * svg/SVGPolyElement.cpp: + (WebCore::SVGPolyElement::svgAttributeChanged): + * svg/SVGRectElement.cpp: + (WebCore::SVGRectElement::svgAttributeChanged): + * svg/SVGSVGElement.cpp: + (WebCore::SVGSVGElement::svgAttributeChanged): + * svg/SVGTests.cpp: + (WebCore::SVGTests::handleAttributeChange): + * svg/SVGTests.h: + * svg/SVGTextContentElement.cpp: + (WebCore::SVGTextContentElement::svgAttributeChanged): + * svg/SVGUseElement.cpp: + (WebCore::SVGUseElement::svgAttributeChanged): + +2010-11-15 Dimitri Glazkov <dglazkov@chromium.org> + + Reviewed by Darin Adler. + + REGRESSION(r71934): Removing an element with a shadow DOM from under a cursor causes a crash. + https://bugs.webkit.org/show_bug.cgi?id=49569 + + Test: fast/events/remove-shadow-host-crash.html + + * rendering/TextControlInnerElements.h: + (WebCore::TextControlInnerElement::isShadowNode): + (WebCore::TextControlInnerElement::shadowParentNode): + +2010-11-12 Ryosuke Niwa <rniwa@webkit.org> + + Reviewed by Darin Adler. + + ScriptElement rather than HTMLScriptElement and SVGScriptElement should have ScriptElementData + https://bugs.webkit.org/show_bug.cgi?id=49469 + + Moved m_data, scriptCharset, scriptContent, shouldExecuteAsJavaScript, and executeScript from + HTMLScriptElement and SVGScriptElement to ScriptElementData. + + Also made insertedIntoDocument, removedFromDocument, childrenChanged, finishParsingChildren, + and handleSourceAttribute of ScriptElement non-static. + + No new tests are added since this is a cleanup. + + * dom/ScriptElement.cpp: + (WebCore::ScriptElement::scriptCharset): Added. + (WebCore::ScriptElement::scriptContent): Added. + (WebCore::ScriptElement::shouldExecuteAsJavaScript): Added. + (WebCore::ScriptElement::executeScript): Added. + (WebCore::ScriptElement::insertedIntoDocument): Made non-static. Accesses m_data. + (WebCore::ScriptElement::removedFromDocument): Ditto. + (WebCore::ScriptElement::childrenChanged): Ditto. + (WebCore::ScriptElement::finishParsingChildren): Ditto. + (WebCore::ScriptElement::handleSourceAttribute): Ditto. + * dom/ScriptElement.h: Moved the declaration of ScriptElement after that of ScriptElementData + because ScriptElement has to instantiate ScriptElementData. + (WebCore::ScriptElement::ScriptElement): Initializes m_data. + * html/HTMLScriptElement.cpp: Removed scriptCharset, scriptContent, shouldExecuteAsJavaScript, and executeScript. + (WebCore::HTMLScriptElement::HTMLScriptElement): Initializes ScriptElement instead of ScriptElementData. + (WebCore::HTMLScriptElement::childrenChanged): Calls ScriptElement::childrenChanged. + (WebCore::HTMLScriptElement::parseMappedAttribute): Calls ScriptElement::handleSourceAttribute. + (WebCore::HTMLScriptElement::finishParsingChildren): Calls ScriptElement::finishParsingChildren. + (WebCore::HTMLScriptElement::insertedIntoDocument): Calls ScriptElement::insertedIntoDocument. + (WebCore::HTMLScriptElement::removedFromDocument): Calls ScriptElement::removedFromDocument. + * html/HTMLScriptElement.h: + * svg/SVGScriptElement.cpp: Removed scriptCharset, scriptContent, shouldExecuteAsJavaScript, and executeScript. + (WebCore::SVGScriptElement::SVGScriptElement): Initializes ScriptElement instead of ScriptElementData. + (WebCore::SVGScriptElement::svgAttributeChanged): Calls ScriptElement::handleSourceAttribute. + (WebCore::SVGScriptElement::insertedIntoDocument): Calls ScriptElement::insertedIntoDocument. + (WebCore::SVGScriptElement::removedFromDocument): Calls ScriptElement::removedFromDocument. + (WebCore::SVGScriptElement::childrenChanged): Calls ScriptElement::childrenChanged. + (WebCore::SVGScriptElement::finishParsingChildren): Calls ScriptElement::finishParsingChildren. + * svg/SVGScriptElement.h: + +2010-11-15 Kent Tamura <tkent@chromium.org> + + Reviewed by Darin Adler. + + Refactor HTMLInputElement: Move a part of HTMLInputElement:: + defaultEventHandler() to InputTypes. + https://bugs.webkit.org/show_bug.cgi?id=48317 + + Move out the followings to InputTypes: + - click event processing, + - the first keydown event processing, and + - DOMActivate event processing. + + Move m_xPos and m_yPos from HTMLInputElement to ImageInputType as + m_clickLocation. It's ok to move them because they should be valid only + when HTMLInputElement::m_activeSubmit is true. For type=image, + m_activeSubmit is true only in DOMActivate event handling. So we reset + m_clickLocation in handleDOMActivateEvent() with Event::underlyingEvent(). + + No new tests because this is just a refactoring. + + * html/BaseDateAndTimeInputType.cpp: + (WebCore::BaseDateAndTimeInputType::handleKeydownEvent): + * html/BaseDateAndTimeInputType.h: + * html/FileInputType.cpp: + (WebCore::FileInputType::handleDOMActivateEvent): + * html/FileInputType.h: + * html/HTMLInputElement.cpp: + (WebCore::HTMLInputElement::HTMLInputElement): + (WebCore::HTMLInputElement::defaultEventHandler): + * html/HTMLInputElement.h: + * html/ImageInputType.cpp: + (WebCore::ImageInputType::appendFormData): + (WebCore::ImageInputType::handleDOMActivateEvent): + * html/ImageInputType.h: + * html/InputType.cpp: + (WebCore::InputType::handleClickEvent): + (WebCore::InputType::handleDOMActivateEvent): + (WebCore::InputType::handleKeydownEvent): + * html/InputType.h: + * html/NumberInputType.cpp: + (WebCore::NumberInputType::handleKeydownEvent): + * html/NumberInputType.h: + * html/RadioInputType.cpp: + (WebCore::RadioInputType::handleClickEvent): + * html/RadioInputType.h: + * html/RangeInputType.cpp: + (WebCore::RangeInputType::handleKeydownEvent): + * html/RangeInputType.h: + * html/ResetInputType.cpp: + (WebCore::ResetInputType::handleDOMActivateEvent): + * html/ResetInputType.h: + * html/SubmitInputType.cpp: + (WebCore::SubmitInputType::handleDOMActivateEvent): + * html/SubmitInputType.h: + * html/TextFieldInputType.cpp: + (WebCore::TextFieldInputType::handleKeydownEvent): + (WebCore::TextFieldInputType::handleKeydownEventForSpinButton): + * html/TextFieldInputType.h: + +2010-11-15 Chris Rogers <crogers@google.com> + + Reviewed by Kenneth Russell. + + Add AudioNode custom bindings + https://bugs.webkit.org/show_bug.cgi?id=49119 + + No new tests since audio API is not yet implemented. + + * bindings/js/JSAudioNodeCustom.cpp: Added. + (WebCore::JSAudioNode::connect): + (WebCore::JSAudioNode::disconnect): + * bindings/v8/custom/V8AudioNodeCustom.cpp: Added. + (WebCore::V8AudioNode::connectCallback): + (WebCore::V8AudioNode::disconnectCallback): + * webaudio/AudioNode.idl: + +2010-11-15 Dave Hyatt <hyatt@apple.com> + + Reviewed by Dan Bernstein. + + https://bugs.webkit.org/show_bug.cgi?id=49570 + + Put italics specialization check back in CSSFontSelector. I had to back it out, since it broke + a layout test, and the issue was that local font fallback fonts should not be considered by the + specialization check (since you never want to pick a fallback over an actual @font-face rule if + the @font-face rule can handle it). + + * css/CSSFontFace.h: + (WebCore::CSSFontFace::create): + (WebCore::CSSFontFace::isLocalFallback): + (WebCore::CSSFontFace::CSSFontFace): + * css/CSSFontSelector.cpp: + (WebCore::CSSFontSelector::addFontFaceRule): + (WebCore::compareFontFaces): + +2010-11-15 Adele Peterson <adele@apple.com> + + Reviewed by Darin Adler. + + Fix for: https://bugs.webkit.org/show_bug.cgi?id=49452 + Placeholder should not be swapped in and out of the text control's inner text element + + There's no need to swap the placeholder text in and out of the inner text element. Instead, just paint the text. + This reduces complexity and makes it easier to make independent decisions about the placeholder text and the text control value. + + * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValueFromRenderer): + Since updatePlaceholderVisibility checks the value, set the value before calling updatePlaceholderVisibility. + * rendering/RenderTextControl.cpp: + (WebCore::RenderTextControl::updatePlaceholderVisibility): Remove code that set the inner text value with the placeholder text. + (WebCore::RenderTextControl::paintObject): Paint the placeholder text during the background phase. + * rendering/RenderTextControl.h: + * rendering/RenderTextControlMultiLine.cpp: + (WebCore::RenderTextControlMultiLine::nodeAtPoint): Remove custom hit testing that tried to avoid hitting the placeholder text at the wrong time. + (WebCore::RenderTextControlMultiLine::updateFromElement): Remove code that set the inner text value with the placeholder text. + (WebCore::RenderTextControlMultiLine::createInnerTextStyle): Remove code that created the inner text style based on the placeholder pseudoelement. + (WebCore::RenderTextControlMultiLine::textBoxInsetLeft): Added. + (WebCore::RenderTextControlMultiLine::textBoxInsetRight): Added. + * rendering/RenderTextControlMultiLine.h: + * rendering/RenderTextControlSingleLine.cpp: + (WebCore::RenderTextControlSingleLine::updateFromElement): Remove code that set the inner text value with the placeholder text. + (WebCore::RenderTextControlSingleLine::createInnerTextStyle): Remove code that created the inner text style based on the placeholder pseudoelement. + (WebCore::RenderTextControlSingleLine::textBoxInsetLeft): Added. + (WebCore::RenderTextControlSingleLine::textBoxInsetRight): Added. + * rendering/RenderTextControlSingleLine.h: + * rendering/TextControlInnerElements.cpp: Removed custom hit testing that tried to avoid hitting the placeholder text at the wrong time. + +2010-11-15 Andreas Kling <kling@webkit.org> + + Unreviewed buildfix (Qt WebKit2 minimal) + + * platform/qt/CookieJarQt.cpp: Add missing <QStringList> include. + +2010-11-15 Chris Rogers <crogers@google.com> + + Reviewed by Kenneth Russell. + + Add Event and EventListener hooks for JavaScriptAudioNode and AudioProcessingEvent + https://bugs.webkit.org/show_bug.cgi?id=49357 + + No new tests since audio API is not yet implemented. + + * bindings/js/JSEventCustom.cpp: + (WebCore::toJS): + * bindings/js/JSEventTarget.cpp: + (WebCore::toJS): + * bindings/v8/V8DOMWrapper.cpp: + (WebCore::V8DOMWrapper::convertEventTargetToV8Object): + * bindings/v8/custom/V8EventCustom.cpp: + (WebCore::toV8): + * dom/Event.cpp: + (WebCore::Event::isAudioProcessingEvent): + * dom/Event.h: + * dom/EventNames.h: + * dom/EventTarget.cpp: + (WebCore::EventTarget::toJavaScriptAudioNode): + * dom/EventTarget.h: + +2010-11-15 Alexey Proskuryakov <ap@apple.com> + + Reviewed by Darin Adler. + + A minor style fix in StyledElement.cpp. + + * dom/StyledElement.cpp: + (WebCore::StyledElement::addCSSProperty): + (WebCore::StyledElement::addCSSImageProperty): + +2010-11-15 Alexey Proskuryakov <ap@apple.com> + + Reviewed by Darin Adler. + + https://bugs.webkit.org/show_bug.cgi?id=49565 + Remove Attr.style accessor + + * dom/Attr.idl: Only keep the accessor for Objective C API. Inspector doesn't seem to need + it any more. + +2010-11-15 Beth Dakin <bdakin@apple.com> + + Reviewed by Darin Adler. + + Fix for https://bugs.webkit.org/show_bug.cgi?id=49555 + Frame::scalePage() should treat the origin as an absolute + coordinate + -and corresponding- + <rdar://problem/8667138> + + * page/Frame.cpp: + (WebCore::Frame::scalePage): + +2010-11-15 Dan Bernstein <mitz@apple.com> + + Reviewed by Darin Adler. + + <rdar://problem/8662770> Error image has incorrect size when a custom font is used + + Test: fast/images/style-access-during-imageChanged-crash.html + + * rendering/RenderImage.cpp: + (WebCore::RenderImage::RenderImage): Added initialization of m_needsToSetSizeForAltText. + (WebCore::RenderImage::imageSizeForError): Factored the non-alt-text dependent size computation + out of setImageSizeForAltText() into this function. + (WebCore::RenderImage::setImageSizeForAltText): Changed to use imageSizeForError(). + (WebCore::RenderImage::styleDidChange): Added. If m_needsToSetSizeForAltText is true, sets the + intrinsic size and calls imageDimensionsChanged() as needed to cause layout or invalidation. + (WebCore::RenderImage::imageChanged): Moved some code from here... + (WebCore::RenderImage::imageDimensionsChanged): ...to here. + * rendering/RenderImage.h: + +2010-11-15 Anders Carlsson <andersca@apple.com> + + Reviewed by Dimitri Glazkov. + + ASSERTION (r72003): Assertion failure when running layout tests + https://bugs.webkit.org/show_bug.cgi?id=49561 + + r72003 added the 'formaction' URL attribute to HTMLButtonElement and HTMLInputElement, + but did not add the attribute to the isURLAttribute which lead to assertion failures + when running the layout tests with a debug build. + + * html/HTMLButtonElement.cpp: + (WebCore::HTMLButtonElement::isURLAttribute): + * html/HTMLButtonElement.h: + * html/HTMLInputElement.cpp: + (WebCore::HTMLInputElement::isURLAttribute): + +2010-11-15 Alexey Proskuryakov <ap@apple.com> + + Reviewed by Darin Adler. + + https://bugs.webkit.org/show_bug.cgi?id=49559 + DOMWindow.getComputedStyle pseudo element argument lacks ConvertUndefinedOrNullToNullString + + No observable change in behavior, so no tests. + + * page/DOMWindow.idl: Added ConvertUndefinedOrNullToNullString. + +2010-11-15 Andreas Kling <kling@webkit.org> + + Reviewed by Tor Arne Vestbø. + + [Qt] Make WTF_USE_MEEGOTOUCH available for WebKit2 as well + + Move this into WebCore/features.pri which is used by both WebCore and WebKit2. + + * WebCore.pro: + * features.pri: + +2010-11-15 Martin Robinson <mrobinson@igalia.com> + + Build fix for GTK+. + + * GNUmakefile.am: Add some missing generated files to the source list. + +2010-11-15 Kenneth Russell <kbr@google.com> + + Reviewed by James Robinson. + + [chromium] Avoid copying of SkBitmap in LayerRendererChromium + https://bugs.webkit.org/show_bug.cgi?id=49560 + + Ran CSS 3D content to test. No other new tests. + + * platform/graphics/chromium/LayerRendererChromium.cpp: + (WebCore::LayerRendererChromium::updateRootLayerTextureRect): + +2010-11-15 Vangelis Kokkevis <vangelis@chromium.org> + + Reviewed by Kenneth Russell. + + [chromium] Fixes layer opacity implementation of composited layers + https://bugs.webkit.org/show_bug.cgi?id=49233 + + This introduces a fairly drastic change in how LayerRendererChromium draws + composited layers. Layers that have non-zero opacity as well as layers that + clip their descendants (and have non-trivial transforms) are now first + rendered onto off-screen surfaces (RenderSurfaceChromium's). The compositing + operation now consists of two distinct phases: First a hierarchical traversal + of the layer tree to compute the layer transforms, determine what the necessary + RenderSurfaces are and sort layer that preserve-3d based on their z-value. A second + pass goes through all the RenderSurfaces discovered by the first pass and updates + their contents. + Additional significant side-effects of this change are: + 1. Depth buffer and depth testing is no longer used. Drawing relies on a painter's + algorithm to render layers with the preserves-3d property from back to front using + the Z coordinate of their center. This will further be improved in the future with + the intoduction of a BSP tree to properly deal with intersecting layers. + 2. Compositor no longer uses the stencil buffer to do clipping. Clipping is now performed + by rendering layer subtrees into an offscreen buffer and setting the appropriate + scissor and viewport transformation. + + Tests: abs-position-inside-opacity.html (for the opacity implementation) + and the rest of the compositing layout tests to verify that + everything still works. + + * WebCore.gypi: + * platform/graphics/chromium/ContentLayerChromium.cpp: + (WebCore::ContentLayerChromium::cleanupResources): + (WebCore::ContentLayerChromium::requiresClippedUpdateRect): + (WebCore::ContentLayerChromium::calculateClippedUpdateRect): + (WebCore::ContentLayerChromium::updateContents): + * platform/graphics/chromium/LayerChromium.cpp: + (WebCore::LayerChromium::LayerChromium): + (WebCore::LayerChromium::cleanupResources): + (WebCore::LayerChromium::createRenderSurface): + (WebCore::LayerChromium::descendantsDrawContent): + (WebCore::LayerChromium::descendantsDrawContentRecursive): + * platform/graphics/chromium/LayerChromium.h: + (WebCore::LayerChromium::drawTransform): + (WebCore::LayerChromium::layerRenderer): + * platform/graphics/chromium/LayerRendererChromium.cpp: + (WebCore::orthoMatrix): + (WebCore::isScaleOrTranslation): + (WebCore::LayerRendererChromium::compareLayerZ): + (WebCore::LayerRendererChromium::LayerRendererChromium): + (WebCore::LayerRendererChromium::prepareToDrawLayers): + (WebCore::LayerRendererChromium::drawLayers): + (WebCore::LayerRendererChromium::updateLayersRecursive): + (WebCore::LayerRendererChromium::useRenderSurface): + (WebCore::LayerRendererChromium::drawLayer): + (WebCore::LayerRendererChromium::setScissorToRect): + (WebCore::LayerRendererChromium::setDrawViewportRect): + (WebCore::LayerRendererChromium::initializeSharedObjects): + (WebCore::LayerRendererChromium::cleanupSharedObjects): + * platform/graphics/chromium/LayerRendererChromium.h: + * platform/graphics/chromium/RenderSurfaceChromium.cpp: Added. + (WebCore::RenderSurfaceChromium::RenderSurfaceChromium): + (WebCore::RenderSurfaceChromium::~RenderSurfaceChromium): + (WebCore::RenderSurfaceChromium::cleanupResources): + (WebCore::RenderSurfaceChromium::layerRenderer): + (WebCore::RenderSurfaceChromium::prepareContentsTexture): + * platform/graphics/chromium/RenderSurfaceChromium.h: Added. + (WebCore::RenderSurfaceChromium::contentRectCenter): + (WebCore::RenderSurfaceChromium::contentRect): + * platform/graphics/chromium/VideoLayerChromium.cpp: + (WebCore::VideoLayerChromium::cleanupResources): + +2010-11-15 Martin Robinson <mrobinson@igalia.com> + + Reviewed by Andreas Kling. + + [GTK] gdk_pixbuf_get_from_surface from GtkVersioning.h is broken on GTK+ 2 builds + https://bugs.webkit.org/show_bug.cgi?id=49549 + + No new tests. This can be verified by loading any existing vertical text test + in GtkLauncher and noticing the lack of CRITICAL GLib exceptions. There's currently + no automatic way of verifying custom cursors. + + * platform/gtk/GtkVersioning.c: + (gdk_pixbuf_get_from_surface): Reverse a sanity check in this method to be correct. + +2010-11-12 Jer Noble <jer.noble@apple.com> + + Reviewed by Brady Eidson. + + Can't view HTML5 video when running Safari with an authenticated proxy server + <rdar://problem/8351926> + + * platform/graphics/mac/MediaPlayerPrivateQTKit.mm: + (WebCore::MediaPlayerPrivate::createQTMovie): + +2010-11-14 Abhishek Arya <inferno@chromium.org> + + Reviewed by Dimitri Glazkov. + + Event dispatch call can blow away the node's renderer initialized + before the call in updateSelectionForMouseDrag function. We need + to initialize it after the call. + https://bugs.webkit.org/show_bug.cgi?id=49524 + + * page/EventHandler.cpp: + (WebCore::EventHandler::updateSelectionForMouseDrag): + +2010-11-15 Patrick Gansterer <paroga@webkit.org> + + Reviewed by Martin Robinson. + + Make ContextShadow compile on all platforms + https://bugs.webkit.org/show_bug.cgi?id=49535 + + Add a void* typedef for PlatformImage and PlatformContext for unsupported platforms + and move them into the WebCore namespace like all other Platform* typedefs. + + * platform/graphics/ContextShadow.h: + +2010-11-15 Renata Hodovan <reni@webkit.org> + + Reviewed by Andreas Kling. + + SVGFEImageElement doesn't support dynamic invalidation + https://bugs.webkit.org/show_bug.cgi?id=49536 + + The dynamic changes are captured by the svgAttributeChanged function. Invalidate the filter primitive if necessary. + + Tests: svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr.html + svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop.html + + * svg/SVGFEImageElement.cpp: + (WebCore::SVGFEImageElement::svgAttributeChanged): + * svg/SVGFEImageElement.h: + +2010-11-15 Yael Aharon <yael.aharon@nokia.com> + + Reviewed by Antonio Gomes. + + [Qt] Focus ring does not show on focused links. + https://bugs.webkit.org/show_bug.cgi?id=49515 + + After http://trac.webkit.org/changeset/69766 the focus ring on links is no longer + visible in Qt. + The reason is that Qt always returned true in RenderTheme::supportsFocusRing(), + but until r69766, we did not check that for links. Qt draws its own focus ring + for controls that it draws, but not for links. + Change the return value to false if the style's appearance is not something that Qt + draws by itself or does not support. + Added a Qt specific test result for the new test added in r69766. + + * platform/qt/RenderThemeQt.cpp: + (WebCore::RenderThemeQt::supportsFocusRing): + +2010-11-15 Dai Mikurube <dmikurube@google.com> + + Reviewed by Kent Tamura. + + Implement formaction, formenctype, formmethod and formtarget attributes for input and button tags + https://bugs.webkit.org/show_bug.cgi?id=49240 + + Tests: fast/forms/formaction-attribute.html + fast/forms/formmethod-attribute-button-html.html + fast/forms/formmethod-attribute-input-html.html + fast/forms/formtarget-attribute-button-html.html + fast/forms/formtarget-attribute-input-html.html + fast/forms/mailto/formenctype-attribute-button-html.html + fast/forms/mailto/formenctype-attribute-input-html.html + fast/forms/submit-form-attributes.html + + * html/HTMLAttributeNames.in: Added formaction, formmethod, formtarget and formenctype attributes + * html/HTMLButtonElement.idl: + * html/HTMLInputElement.idl: + * loader/FormSubmission.cpp: Modified to check the pressed button and its attributes + (WebCore::FormSubmission::Attributes::copyFrom): + (WebCore::FormSubmission::create): + * loader/FormSubmission.h: + +2010-11-15 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Yury Semikhatsky. + + Web Inspector: Do not hide default Ctrl+A behavior on non-Mac. + https://bugs.webkit.org/show_bug.cgi?id=49527 + + * inspector/front-end/TextPrompt.js: + (WebInspector.TextPrompt.prototype._onKeyDown): + +2010-11-15 Ilya Sherman <isherman@chromium.org> + + Reviewed by Kent Tamura. + + Add capability for displaying warnings to autofill popup + Warnings are displayed in dark gray italic. + https://bugs.webkit.org/show_bug.cgi?id=49291 + http://code.google.com/p/chromium/issues/detail?id=58509 + + * platform/chromium/PopupMenuChromium.cpp: + (WebCore::PopupListBox::getRowFont): + Use item-specific font, not just the generic menu font. + (WebCore::PopupListBox::selectIndex): + Updated to clear the selection when hovering over a non-selectable item. + * platform/chromium/PopupMenuChromium.h: Minor cleanup + +2010-11-14 David Hyatt <hyatt@apple.com> + + Back out the italics portion of the previous patch until I can figure out why it + doesn't work. + + * css/CSSFontSelector.cpp: + (WebCore::compareFontFaces): + +2010-11-14 Kent Tamura <tkent@chromium.org> + + Reviewed by Dimitri Glazkov. + + Improve API for form validation message strings + https://bugs.webkit.org/show_bug.cgi?id=34945 + + This change introduces three new functions; + validationMessageTypeMismatchFor*Text(). The implementation for each + platform is just a call to validationMessageTypeMismatchText(). + + Some validationMessage*() functions have new parameters. The parameters + are ignored in all platforms for now. + + This change doesn't change any behavior. However a platform can add + additional information to validation messages. e.g. Changing "type + mismatch" to "Please specify an e-mail address" for <input type=email>. + + * html/EmailInputType.cpp: + (WebCore::EmailInputType::typeMismatchText): Call validationMessageTypeMismatchForEmailText() + or validationMessageTypeMismatchForMultipleEmailText(). + * html/EmailInputType.h: + * html/HTMLFormControlElement.h: Add maxLength() and value() to access them from ValidityState. + * html/HTMLInputElement.cpp: Add the following functions to pass extra + information to validation message string functions. + (WebCore::HTMLInputElement::minimumString): + (WebCore::HTMLInputElement::maximumString): + (WebCore::HTMLInputElement::stepBaseString): + (WebCore::HTMLInputElement::stepString): + (WebCore::HTMLInputElement::typeMismatchText): + * html/HTMLInputElement.h: + * html/HTMLTextAreaElement.h: + * html/InputType.cpp: + (WebCore::InputType::typeMismatchText): Call validationMessageTypeMismatchText(). + * html/InputType.h: + * html/URLInputType.cpp: + (WebCore::URLInputType::typeMismatchText): Call validationMessageTypeMismatchForURLText(). + * html/URLInputType.h: + * html/ValidityState.cpp: + (WebCore::ValidityState::validationMessage): + * platform/LocalizedStrings.cpp: + (WebCore::validationMessageTypeMismatchForEmailText): + (WebCore::validationMessageTypeMismatchForMultipleEmailText): + (WebCore::validationMessageTypeMismatchForURLText): + (WebCore::validationMessageTooLongText): + (WebCore::validationMessageRangeUnderflowText): + (WebCore::validationMessageRangeOverflowText): + (WebCore::validationMessageStepMismatchText): + * platform/LocalizedStrings.h: + - Add validationMessageTypeMismatchForEmailText(), + validationMessageTypeMismatchForMultipleEmailText() and + validationMessageTypeMismatchForURLText() + - Add length parameters to validationMessageTooLongText(). + - Add the minimum value parameter to validationMessageRangeUnderflowText() + - Add the maximum value parameter to validationMessageRangeOverflowText() + - Add parameters of the base value and the step value to validationMessageStepMismatchText() + * platform/android/LocalizedStringsAndroid.cpp: + (WebCore::validationMessageTypeMismatchForEmailText): + (WebCore::validationMessageTypeMismatchForMultipleEmailText): + (WebCore::validationMessageTypeMismatchForURLText): + (WebCore::validationMessageTooLongText): + (WebCore::validationMessageRangeUnderflowText): + (WebCore::validationMessageRangeOverflowText): + (WebCore::validationMessageStepMismatchText): + * platform/brew/LocalizedStringsBrew.cpp: + (WebCore::validationMessageTypeMismatchForEmailText): + (WebCore::validationMessageTypeMismatchForMultipleEmailText): + (WebCore::validationMessageTypeMismatchForURLText): + (WebCore::validationMessageTooLongText): + (WebCore::validationMessageRangeUnderflowText): + (WebCore::validationMessageRangeOverflowText): + (WebCore::validationMessageStepMismatchText): + * platform/efl/LocalizedStringsEfl.cpp: + (WebCore::validationMessageRangeOverflowText): + (WebCore::validationMessageRangeUnderflowText): + (WebCore::validationMessageStepMismatchText): + (WebCore::validationMessageTooLongText): + (WebCore::validationMessageTypeMismatchForEmailText): + (WebCore::validationMessageTypeMismatchForMultipleEmailText): + (WebCore::validationMessageTypeMismatchForURLText): + * platform/gtk/LocalizedStringsGtk.cpp: + (WebCore::validationMessageTypeMismatchForEmailText): + (WebCore::validationMessageTypeMismatchForMultipleEmailText): + (WebCore::validationMessageTypeMismatchForURLText): + (WebCore::validationMessageTooLongText): + (WebCore::validationMessageRangeUnderflowText): + (WebCore::validationMessageRangeOverflowText): + (WebCore::validationMessageStepMismatchText): + * platform/haiku/LocalizedStringsHaiku.cpp: + (WebCore::validationMessageTypeMismatchForEmailText): + (WebCore::validationMessageTypeMismatchForMultipleEmailText): + (WebCore::validationMessageTypeMismatchForURLText): + (WebCore::validationMessageTooLongText): + (WebCore::validationMessageRangeUnderflowText): + (WebCore::validationMessageRangeOverflowText): + (WebCore::validationMessageStepMismatchText): + * platform/wx/LocalizedStringsWx.cpp: + (WebCore::validationMessageTypeMismatchForEmailText): + (WebCore::validationMessageTypeMismatchForMultipleEmailText): + (WebCore::validationMessageTypeMismatchForURLText): + (WebCore::validationMessageTooLongText): + (WebCore::validationMessageRangeUnderflowText): + (WebCore::validationMessageRangeOverflowText): + (WebCore::validationMessageStepMismatchText): + +2010-11-14 Kent Tamura <tkent@chromium.org> + + Reviewed by Andreas Kling. + + KeyboardEvent::keyIdentifier() should return "const String&" + https://bugs.webkit.org/show_bug.cgi?id=49426 + + No new tests. This shouldn't change the current behavior. + + * dom/KeyboardEvent.h: + (WebCore::KeyboardEvent::keyIdentifier): Change the return type; String -> const String& + * dom/SelectElement.cpp: + (WebCore::SelectElement::menuListDefaultEventHandler): + Change the type of a variable to have keyIdentifier(); String -> const String& + (WebCore::SelectElement::listBoxDefaultEventHandler): ditto. + * html/HTMLInputElement.cpp: + (WebCore::HTMLInputElement::defaultEventHandler): ditto. + (WebCore::HTMLInputElement::handleKeyEventForRange): ditto. + * page/EventHandler.cpp: + (WebCore::EventHandler::handleKeyboardSelectionMovement): ditto. + +2010-11-14 Kenichi Ishibashi <bashi@google.com> + + Reviewed by Kent Tamura. + + [HTML5] "form" attribute support for form control elements + https://bugs.webkit.org/show_bug.cgi?id=47813 + + Adds a list of form-associated elements with form attribute into + the Document class to support form attribute. + Adds a function to determine the right place to locate + form-associated elements with form attribute into + m_associatedElements of HTMLFormElement class. + + Tests: fast/forms/form-attribute-elements-order.html + fast/forms/form-attribute-elements-order2.html + fast/forms/form-attribute-elements.html + fast/forms/form-attribute.html + + * dom/Document.cpp: + (WebCore::Document::registerFormElementWithFormAttribute): Added. + (WebCore::Document::unregisterFormElementWithFormAttribute): Added. + (WebCore::Document::resetFormElementsOwner): Added. + * dom/Document.h: Added the list for elements with form attribute. + * html/HTMLAttributeNames.in: Added form attribute. + * html/HTMLFormControlElement.cpp: + (WebCore::HTMLFormControlElement::insertedIntoTree): Modified to handle + form attribute. + (WebCore::HTMLFormControlElement::removedFromTree): Ditto. + (WebCore::HTMLFormControlElement::resetFormOwner): Added. + (WebCore::HTMLFormControlElement::attributeChanged): Added. + * html/HTMLFormControlElement.h: + * html/HTMLFormElement.cpp: + (WebCore::HTMLFormElement::HTMLFormElement): Modified to initialize + newly-added variables. + (WebCore::HTMLFormElement::insertedIntoDocument): Modified to reset + form owner of form-associated elements. + (WebCore::HTMLFormElement::removedFromDocument): Ditto. + (WebCore::HTMLFormElement::formElementIndexWithFormAttribute): Added. + (WebCore::HTMLFormElement::formElementIndex): Modified to treat + form-associated elements with form attribute separately. + (WebCore::HTMLFormElement::removeFormElement): Modified to handle + form-associated elements with form attribute. + * html/HTMLFormElement.h: Added three variables to handle form attribute. + * html/HTMLOutputElement.cpp: Removed "FIXME" comment. + (WebCore::HTMLOutputElement::parseMappedAttribute): + * html/HTMLOutputElement.h: Removed setForm(). + +2010-11-14 David Hyatt <hyatt@apple.com> + + Reviewed by Dan Bernstein. + + https://bugs.webkit.org/show_bug.cgi?id=49521 + + REGRESSION svg/W3C-SVG-1.1/fonts-desc-02-t.svg broken by r71979. + + Refine the font selection function for @font-face to be smarter about what fonts it prefers. If + a font is labeled as only supporting small-caps, then prefer it to one that claims to support both + normal and small-caps. The specialized font is more likely to be true small-caps and to not rely + on synthesis. + + Added the same logic for italic as well. Prefer the font that is specifically restricted to + italic to one that claims it can support anything. + + * css/CSSFontSelector.cpp: + (WebCore::compareFontFaces): + +2010-11-14 Ryuan Choi <ryuan.choi@samsung.com> + + Reviewed by Martin Robinson. + + [EFL] add pango support + https://bugs.webkit.org/show_bug.cgi?id=46029 + + Include pango related files. + No new tests; functionality is unchanged. + + * CMakeListsEfl.txt: + +2010-11-12 Tenghui Zhu <ztenghui@google.com> + + Reviewed by Andreas Kling. + + [V8] Code generation script error in generating the SVGStaticListPropertyTearOff + https://bugs.webkit.org/show_bug.cgi?id=49463 + + * bindings/scripts/CodeGeneratorV8.pm: The svgNativeType is the one containing + the SVGStaticListPropertyTearOff string, not the svgListPropertyType. + +2010-11-14 Patrick Gansterer <paroga@webkit.org> + + Reviewed by Andreas Kling. + + Sort CMakeLists.txt + https://bugs.webkit.org/show_bug.cgi?id=49507 + + * CMakeLists.txt: + +2010-11-13 Patrick Gansterer <paroga@webkit.org> + + Reviewed by Yury Semikhatsky. + + Buildfix for !ENABLE(INSPECTOR) + https://bugs.webkit.org/show_bug.cgi?id=49500 + + Also unify the position of the condition in the cpp files. + + * inspector/ConsoleMessage.cpp: + * inspector/InspectorResourceAgent.cpp: + * inspector/InspectorState.cpp: + * inspector/ScriptCallFrame.cpp: + * inspector/ScriptCallStack.cpp: + +2010-11-13 David Hyatt <hyatt@apple.com> + + Reviewed by Anders Carlsson. + + https://bugs.webkit.org/show_bug.cgi?id=49506 + + Repaint is broken across writing mode boundaries. It's not enough to add in flipped offsets. You have + to flip the rect itself. + + Added fast/repaint/repaint-across-writing-mode-boundary.html + + * rendering/RenderBox.cpp: + (WebCore::RenderBox::computeRectForRepaint): + +2010-11-13 David Hyatt <hyatt@apple.com> + + Reviewed by Dan Bernstein. + + https://bugs.webkit.org/show_bug.cgi?id=49505 + + REGRESSION: @font-face doesn't work with the small-caps variant. This was broken by the addition of SVG fonts + support long ago. This patch fixes the SVG code so that it doesn't break non-SVG fonts. + + Added fast/blockflow/broken-ideograph-small-caps.html + + * css/CSSFontFace.cpp: + (WebCore::CSSFontFace::hasSVGFontFaceSource): + * css/CSSFontFace.h: + * css/CSSFontFaceSource.cpp: + (WebCore::CSSFontFaceSource::getFontData): + * css/CSSFontFaceSource.h: + * css/CSSFontSelector.cpp: + (WebCore::CSSFontSelector::addFontFaceRule): + (WebCore::CSSFontSelector::getFontData): + +2010-11-13 Dan Bernstein <mitz@apple.com> + + Reviewed by Dave Hyatt. + + fast/text/hyphen* tests have different results on Leopard + https://bugs.webkit.org/show_bug.cgi?id=43296 + + * platform/text/mac/TextBreakIteratorInternalICUMac.mm: + (WebCore::topLanguagePreference): Changed to look up the value of the AppleLanguages default + through the normal NSUserDefaults search order rather than skipping the application domain. + This makes this function respect DumpRenderTree’s setting of the default in the application + domain. + +2010-11-13 David Hyatt <hyatt@apple.com> + + Reviewed by Dan Bernstein. + + https://bugs.webkit.org/show_bug.cgi?id=49499 + + broken-ideographic-font.html causes layout test flakiness in release builds. The reason for this is + that the custom font data for m_brokenIdeographFontData was never getting pruned out of the tree. + The same problem exists for custom small caps fonts, so I made sure that the small caps fonts get + pruned as well. In addition, custom small caps fonts were never getting deleted either. + + I also made allowsLigatures in FontPlatformData orientation-independent, and the callers check it + instead. + + Unskip fast/blockflow/broken-ideographic-font.html + + * platform/graphics/SimpleFontData.cpp: + (WebCore::SimpleFontData::~SimpleFontData): + * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: + (WebCore::SimpleFontData::platformDestroy): + (WebCore::SimpleFontData::smallCapsFontData): + * platform/graphics/chromium/SimpleFontDataLinux.cpp: + (WebCore::SimpleFontData::platformDestroy): + (WebCore::SimpleFontData::smallCapsFontData): + * platform/graphics/cocoa/FontPlatformDataCocoa.mm: + (WebCore::FontPlatformData::allowsLigatures): + * platform/graphics/freetype/SimpleFontDataFreeType.cpp: + (WebCore::SimpleFontData::platformDestroy): + (WebCore::SimpleFontData::smallCapsFontData): + * platform/graphics/haiku/SimpleFontDataHaiku.cpp: + (WebCore::SimpleFontData::platformDestroy): + (WebCore::SimpleFontData::smallCapsFontData): + * platform/graphics/mac/ComplexTextControllerATSUI.cpp: + (WebCore::disableLigatures): + * platform/graphics/mac/SimpleFontDataCoreText.cpp: + (WebCore::SimpleFontData::getCFStringAttributes): + * platform/graphics/mac/SimpleFontDataMac.mm: + (WebCore::SimpleFontData::platformDestroy): + * platform/graphics/win/SimpleFontDataWin.cpp: + (WebCore::SimpleFontData::platformDestroy): + (WebCore::SimpleFontData::smallCapsFontData): + * platform/graphics/wx/SimpleFontDataWx.cpp: + (WebCore::SimpleFontData::platformDestroy): + (WebCore::SimpleFontData::smallCapsFontData): + +2010-11-13 David Hyatt <hyatt@apple.com> + + https://bugs.webkit.org/show_bug.cgi?id=49496 + + Fix broken-ideographic-font.html. I had the font installed locally on my machine, and this covered up + the fact that CoreText was implicitly using it as fallback in the vertical case only. The bots don't have + the font installed locally, and so they showed the bug. + + Make sure the GlyphPage is filled with horizontal glyphs for a broken ideograph font, so that CoreText is + willing to fill. + + * platform/graphics/mac/SimpleFontDataCoreText.cpp: + (WebCore::SimpleFontData::getCFStringAttributes): + +2010-11-13 David Hyatt <hyatt@apple.com> + + Reviewed by Dan Bernstein. + + https://bugs.webkit.org/show_bug.cgi?id=49464 + + Fix bugs with the orientation of fonts when the font is brought in via fallback, when the font contains no + vertical tables, or when the font is loaded via font-face in both horizontal and vertical forms. + + (1) Include orientation as part of the @font-face hashtables so that the fonts are treated as + distinct when used in horizontal and vertical forms. + + (2) Let the orientation member of FontPlatformData represent the desired orientation rather than + the supported one. Add an orientation member to SimpleFontData that represents the actual + supported orientation of the font. + + (3) For fonts with no vertical tables, add a brokenIdeographicsFont accessor that is invoked when + CJK ideographs are encountered. This is essentially identical to the small caps fallback mechanism + but invoked only for ideographs. The special ideograph font locks the orientation to vertical and + renders the glyphs upright even when the font has no vertical tables. Punctuation and such will + still look funny, and really this is a bug in the font, but at least this way it will be apparent + that the font is to blame. + + Added fast/blockflow/broken-ideographic-font.html and fast/blockflow/vertical-font-fallback.html. + + * css/CSSFontFaceSource.cpp: + (WebCore::CSSFontFaceSource::getFontData): + * css/CSSSegmentedFontFace.cpp: + (WebCore::CSSSegmentedFontFace::getFontData): + * platform/graphics/Font.cpp: + (WebCore::Font::isCJKIdeograph): + * platform/graphics/Font.h: + * platform/graphics/FontFastPath.cpp: + (WebCore::Font::glyphDataForCharacter): + * platform/graphics/SimpleFontData.cpp: + (WebCore::SimpleFontData::SimpleFontData): + (WebCore::SimpleFontData::~SimpleFontData): + (WebCore::SimpleFontData::brokenIdeographFontData): + * platform/graphics/SimpleFontData.h: + (WebCore::SimpleFontData::orientation): + * platform/graphics/cocoa/FontPlatformDataCocoa.mm: + (WebCore::FontPlatformData::FontPlatformData): + * platform/graphics/mac/FontMac.mm: + (WebCore::showGlyphsWithAdvances): + * platform/graphics/mac/SimpleFontDataMac.mm: + (WebCore::SimpleFontData::platformInit): + (WebCore::SimpleFontData::platformBoundsForGlyph): + (WebCore::SimpleFontData::platformWidthForGlyph): + +2010-11-13 Rob Buis <rwlbuis@gmail.com> + + Reviewed by Dirk Schulze. + + requiredFeatures does not adapt to SVGStringList changes + https://bugs.webkit.org/show_bug.cgi?id=40887 + + Centralize logic of handling of SVGElement validity changes. + The logic is to detach the SVGElement when changing from valid + to invalid, and to attach when changing from invalid to valid. + + Tests: svg/dynamic-updates/SVGCircleElement-dom-requiredFeatures.html + svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures.html + svg/dynamic-updates/SVGEllipseElement-dom-requiredFeatures.html + svg/dynamic-updates/SVGEllipseElement-svgdom-requiredFeatures.html + svg/dynamic-updates/SVGForeignObjectElement-dom-requiredFeatures.html + svg/dynamic-updates/SVGForeignObjectElement-svgdom-requiredFeatures.html + svg/dynamic-updates/SVGGElement-dom-requiredFeatures.html + svg/dynamic-updates/SVGGElement-svgdom-requiredFeatures.html + svg/dynamic-updates/SVGImageElement-dom-requiredFeatures.html + svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures.html + svg/dynamic-updates/SVGLineElement-dom-requiredFeatures.html + svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures.html + svg/dynamic-updates/SVGPathElement-dom-requiredFeatures.html + svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures.html + svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures.html + svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures.html + svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures.html + svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures.html + svg/dynamic-updates/SVGRectElement-dom-requiredFeatures.html + svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures.html + svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures.html + svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures.html + svg/dynamic-updates/SVGTextElement-dom-requiredFeatures.html + svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures.html + svg/dynamic-updates/SVGUseElement-dom-requiredFeatures.html + svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures.html + + * svg/SVGCircleElement.cpp: + (WebCore::SVGCircleElement::svgAttributeChanged): + * svg/SVGEllipseElement.cpp: + (WebCore::SVGEllipseElement::svgAttributeChanged): + * svg/SVGForeignObjectElement.cpp: + (WebCore::SVGForeignObjectElement::svgAttributeChanged): + * svg/SVGGElement.cpp: + (WebCore::SVGGElement::svgAttributeChanged): + * svg/SVGImageElement.cpp: + (WebCore::SVGImageElement::svgAttributeChanged): + * svg/SVGLineElement.cpp: + (WebCore::SVGLineElement::svgAttributeChanged): + * svg/SVGPathElement.cpp: + (WebCore::SVGPathElement::svgAttributeChanged): + * svg/SVGPolyElement.cpp: + (WebCore::SVGPolyElement::svgAttributeChanged): + * svg/SVGRectElement.cpp: + (WebCore::SVGRectElement::svgAttributeChanged): + * svg/SVGSVGElement.cpp: + (WebCore::SVGSVGElement::svgAttributeChanged): + * svg/SVGTests.cpp: + (WebCore::knownAttribute): + (WebCore::SVGTests::isKnownAttribute): + (WebCore::SVGTests::handleAttributeChange): Centralized handling of SVGElement validity changes. + * svg/SVGTests.h: + * svg/SVGTextContentElement.cpp: + (WebCore::SVGTextContentElement::svgAttributeChanged): + (WebCore::SVGTextContentElement::isKnownAttribute): + * svg/SVGTextContentElement.h: + * svg/SVGUseElement.cpp: + (WebCore::SVGUseElement::svgAttributeChanged): + +2010-11-13 Andrey Kosyakov <caseq@chromium.org> + + Reviewed by Pavel Feldman. + + Web Inspector: [refactoring] support Views in TabbedPane and streamline tab selection in resource view + https://bugs.webkit.org/show_bug.cgi?id=49493 + + * inspector/front-end/NetworkPanel.js: + (WebInspector.NetworkPanel.prototype._showResource): + * inspector/front-end/ResourceView.js: + (WebInspector.ResourceView): + (WebInspector.ResourceView.prototype.selectContentTab): + (WebInspector.ResourceView.prototype._selectTab): + (WebInspector.ResourceView.prototype._refreshCookies): + (WebInspector.ResourceCookiesTab.prototype.show): + * inspector/front-end/StoragePanel.js: + (WebInspector.StoragePanel.prototype.showResource): + * inspector/front-end/TabbedPane.js: + (WebInspector.TabbedPane.prototype.appendTab): + (WebInspector.TabbedPane.prototype.hasTab): + (WebInspector.TabbedPane.prototype.selectTabById): + (WebInspector.TabbedPane.prototype._hideTab): + (WebInspector.TabbedPane.prototype._showTab): + * inspector/front-end/inspector.css: + (.resource-view-cookies): + (.resource-view-cookies.visible): + +2010-11-13 Yury Semikhatsky <yurys@chromium.org> + + Reviewed by Pavel Feldman. + + REGRESSION(71515): Web Inspector: Safari crash calling console.log when Log JavaScript Exceptions to Console is checked + https://bugs.webkit.org/show_bug.cgi?id=49362 + + * page/Console.cpp: + (WebCore::Console::addMessage): avoid accessing ScriptArguments and ScriptCallStack after their ownership + has been passed to the inspector. + +2010-11-13 Yury Semikhatsky <yurys@chromium.org> + + Reviewed by Pavel Feldman. + + Web Inspector: DOM event listener name is cropped in Elements panel + https://bugs.webkit.org/show_bug.cgi?id=49387 + + * inspector/front-end/inspector.css: + (.event-bar): use margin-left instead of left to fit child node into its parent + +2010-11-13 Ilya Sherman <isherman@chromium.org> + + Reviewed by Shinichiro Hamaji. + + Fixes regression from previous patch -- computes y offsets for elements + that are scrolled out of the window. + https://bugs.webkit.org/show_bug.cgi?id=49306 + + * manual-tests/select-scroll.html: Added. + * platform/chromium/PopupMenuChromium.cpp: + (WebCore::PopupListBox::layout): + +2010-11-12 Daniel Bates <dbates@rim.com> + + Reviewed by Adam Barth. + + Transferred <iframe>s may not have a unique internal name + https://bugs.webkit.org/show_bug.cgi?id=48768 + + Fixes an issue where an <iframe> that is transferred from + document A to document B, where A != B, may not have a + unique internal name in B. + + Test: fast/frames/iframe-reparenting-unique-name.html + + * html/HTMLFrameElementBase.cpp: + (WebCore::HTMLFrameElementBase::setNameAndOpenURL): Inlined code from + HTMLFrameElementBase::setName() so that we can remove setName(), which + was only called being called by HTMLFrameElementBase::setNameAndOpenURL(). + * html/HTMLFrameElementBase.h: Removed HTMLFrameElementBase::setName(). + * html/HTMLFrameOwnerElement.h: Removed HTMLFrameOwnerElement::setName(). + * page/Frame.cpp: + (WebCore::Frame::transferChildFrameToNewDocument): Modified to call FrameTree::transferChild(). + * page/FrameTree.cpp: + (WebCore::FrameTree::transferChild): Added. + (WebCore::FrameTree::appendChild): Moved the majority of the code into FrameTree::actuallyAppendChild(). + (WebCore::FrameTree::actuallyAppendChild): Added. + * page/FrameTree.h: + +2010-11-12 Joseph Pecoraro <joepeck@webkit.org> + + Reviewed by Alexey Proskuryakov. + + Some FrameLoader.h Cleanup + https://bugs.webkit.org/show_bug.cgi?id=49484 + + Removed function signatures without any implementation. The functions + used to exist, and were nicely refactored into PageCache in r60688 and + the signatures were left behind. + + Removed function signature setLoadType. Added in r17238 back when the + file was named WebFrameLoader, and the implementation was lost during + the transition from its mm implementation. + + Removed function signature updateHistoryAfterClientRedirect. Implementation + and call points were removed in r18541 but the signature was left behind, + and jumped files! + + Removed unused debug variable m_didDispatchDidCommitLoad. It was added + and used in Assertions in r28399. It was removed soon after, in r28464 + because they were, "firing like crazy. Not sure why yet." It was + never used again. + + Added const qualifier and moved interruptionForPolicyChangeError to + be more like its buddies. + + * loader/FrameLoader.cpp: + (WebCore::FrameLoader::FrameLoader): + (WebCore::FrameLoader::checkLoadCompleteForThisFrame): + (WebCore::FrameLoader::interruptionForPolicyChangeError): + (WebCore::FrameLoader::dispatchDidCommitLoad): + * loader/FrameLoader.h: + +2010-11-12 Yael Aharon <yael.aharon@nokia.com> + + Reviewed by David Hyatt. + + Spatial Navigation: Cannot focus on some ContainerNode + https://bugs.webkit.org/show_bug.cgi?id=48393 + + ContainerNode::getLowerRightCorner() assumes that the lowest right corner of its last child + is its own lowest right corner. If that child is an empty text node after an image, it does + not have size and position information, so we should go to the previous child. + + Tests: fast/events/spatial-navigation/snav-container-only-white-space.html + fast/events/spatial-navigation/snav-container-white-space.html + + * dom/ContainerNode.cpp: + (WebCore::ContainerNode::getLowerRightCorner): + +2010-11-12 James Simonsen <simonjam@chromium.org> + + Reviewed by Darin Fisher. + + [Web Timing] Rename interfaces: + - Navigation -> PerformanceNavigation + - Timing -> PerformanceTiming + https://bugs.webkit.org/show_bug.cgi?id=48919 + + * DerivedSources.cpp: + * DerivedSources.make: + * GNUmakefile.am: + * WebCore.gypi: + * WebCore.vcproj/WebCore.vcproj: + * WebCore.xcodeproj/project.pbxproj: + * page/Performance.cpp: + (WebCore::Performance::navigation): + (WebCore::Performance::timing): + * page/Performance.h: + * page/Performance.idl: + * page/PerformanceNavigation.cpp: Renamed from WebCore/page/Navigation.cpp. + (WebCore::PerformanceNavigation::PerformanceNavigation): + (WebCore::PerformanceNavigation::frame): + (WebCore::PerformanceNavigation::disconnectFrame): + (WebCore::PerformanceNavigation::type): + (WebCore::PerformanceNavigation::redirectCount): + * page/PerformanceNavigation.h: Renamed from WebCore/page/Navigation.h. + (WebCore::PerformanceNavigation::create): + * page/PerformanceNavigation.idl: Renamed from WebCore/page/Navigation.idl. + * page/PerformanceTiming.cpp: Renamed from WebCore/page/Timing.cpp. + (WebCore::toIntegerMilliseconds): + (WebCore::getPossiblySkewedTimeInKnownRange): + (WebCore::PerformanceTiming::PerformanceTiming): + (WebCore::PerformanceTiming::frame): + (WebCore::PerformanceTiming::disconnectFrame): + (WebCore::PerformanceTiming::navigationStart): + (WebCore::PerformanceTiming::unloadEventEnd): + (WebCore::PerformanceTiming::redirectStart): + (WebCore::PerformanceTiming::redirectEnd): + (WebCore::PerformanceTiming::fetchStart): + (WebCore::PerformanceTiming::domainLookupStart): + (WebCore::PerformanceTiming::domainLookupEnd): + (WebCore::PerformanceTiming::connectStart): + (WebCore::PerformanceTiming::connectEnd): + (WebCore::PerformanceTiming::requestStart): + (WebCore::PerformanceTiming::requestEnd): + (WebCore::PerformanceTiming::responseStart): + (WebCore::PerformanceTiming::responseEnd): + (WebCore::PerformanceTiming::domLoading): + (WebCore::PerformanceTiming::domInteractive): + (WebCore::PerformanceTiming::domContentLoaded): + (WebCore::PerformanceTiming::domComplete): + (WebCore::PerformanceTiming::loadEventStart): + (WebCore::PerformanceTiming::loadEventEnd): + (WebCore::PerformanceTiming::documentLoader): + (WebCore::PerformanceTiming::documentTiming): + (WebCore::PerformanceTiming::documentLoadTiming): + (WebCore::PerformanceTiming::resourceLoadTiming): + (WebCore::PerformanceTiming::resourceLoadTimeRelativeToAbsolute): + * page/PerformanceTiming.h: Renamed from WebCore/page/Timing.h. + (WebCore::PerformanceTiming::create): + * page/PerformanceTiming.idl: Renamed from WebCore/page/Timing.idl. + +2010-11-12 Eric Carlson <eric.carlson@apple.com> + + Reviewed by Simon Fraser. + + Remove unused code from HTMLMediaElement + https://bugs.webkit.org/show_bug.cgi?id=49451 + + Just removing code, so no new tests. + + * html/HTMLMediaElement.cpp: Removed unused functions. + * html/HTMLMediaElement.h: + +2010-11-12 Ryosuke Niwa <rniwa@webkit.org> + + Unreviewed Xcode project fix. + + * WebCore.xcodeproj/project.pbxproj: + +2010-11-12 Alexey Proskuryakov <ap@apple.com> + + Reviewed by Simon Fraser. + + https://bugs.webkit.org/show_bug.cgi?id=49473 + WebKitCSSMatrix shouldn't inherit from StyleBase + + No change in behavior, so no tests. + + * css/WebKitCSSMatrix.cpp: + (WebCore::WebKitCSSMatrix::WebKitCSSMatrix): We don't inherit from StyleBase any more, so + no need to initialize always-null parent. + (WebCore::WebKitCSSMatrix::setMatrixValue): Since there was never a parent, useStrictParsing() + just returned true. + + * css/WebKitCSSMatrix.h: Just inherit from RefCounted<WebKitCSSMatrix>. Removed unused default + constructor and copy constructor. + + * html/canvas/WebGLRenderingContext.h: Removed an unnneded forward declaration. + +2010-11-12 Helder Correia <helder@sencha.com> + + Reviewed by Andreas Kling. + + [Qt] Path::addArc() does not set right angle direction on full arcs + https://bugs.webkit.org/show_bug.cgi?id=49138 + + Ensure correctness of nonzero winding rule for full arc paths. + Invert the sign of the span if the direction is counterclockwise. + + Test: fast/canvas/canvas-arc-360-winding.html + + * platform/graphics/qt/PathQt.cpp: + (WebCore::Path::addArc): + +2010-11-05 Dimitri Glazkov <dglazkov@chromium.org> + + Reviewed by Darin Adler. + + Implement shadow DOM-aware event targeting and introduce EventContext to track the context of each event dispatch. + https://bugs.webkit.org/show_bug.cgi?id=46015 + + Test: fast/events/shadow-boundary-crossing-2.html + + This patch adds the notion of EventContext (and a very similar-acting WindowEventContext, specifically + for DOMWindow), an abstraction that carries information around dispatching an event for any given Node. + + This abstraction is necessary to ensure that events, fired from shadow DOM nodes are properly retargeted to + appear as if they are coming from their host, thus never exposing the shadow DOM nodes to the world outside. + + * Android.mk: Added EventContext, WindowEventContext files. + * CMakeLists.txt: Ditto. + * GNUmakefile.am: Ditto. + * WebCore.gypi: Ditto. + * WebCore.pro: Ditto. + * WebCore.xcodeproj/project.pbxproj: Ditto. + * WebCore.vcproj/WebCore.vcproj: Ditto. + * dom/ContainerNode.cpp: + (WebCore::notifyChildInserted): Changed to be shadow DOM-aware. + * dom/EventContext.cpp: Added. + * dom/EventContext.h: Added. + * dom/Node.cpp: + (WebCore::Node::markAncestorsWithChildNeedsStyleRecalc): Changed to be shadow DOM-aware. + (WebCore::Node::createRendererIfNeeded): Ditto. + (WebCore::Node::parentOrHostNode): Added new helper method. + (WebCore::Node::enclosingLinkEventParentOrSelf): Changed to be shadow DOM-aware. + (WebCore::eventTargetRespectingSVGTargetRules): Collapsed two helper methods into one. + (WebCore::Node::getEventAncestors): Renamed and refactored to collect a vector of EventContexts. + (WebCore::Node::topEventContext): Added. + (WebCore::eventHasListeners): Changed to use EventContexts. + (WebCore::Node::dispatchGenericEvent): Ditto. + * dom/Node.h: Removed eventParentNode that's no longer needed, added parentOrHostNode decl, + and changed signature of eventAncestors to use EventContexts. + * dom/Text.cpp: + (WebCore::Text::createRenderer): Changed to be shadow DOM-aware. + * dom/WindowEventContext.cpp: Added. + * dom/WindowEventContext.h: Added. + * inspector/InspectorDOMAgent.cpp: + (WebCore::InspectorDOMAgent::getEventListenersForNode): Changed to use EventContexts. + * page/EventHandler.cpp: + (WebCore::EventHandler::updateMouseEventTargetNode): Removed code that's no longer necessary. + * rendering/RenderTextControlMultiLine.cpp: + (WebCore::RenderTextControlMultiLine::subtreeHasChanged): Removed event invocation that's + no longer necessary. + * rendering/ShadowElement.h: Made m_shadowParent a RefPtr to avoid stale references when parent + is deleted. + * rendering/TextControlInnerElements.cpp: + (WebCore::TextControlInnerTextElement::defaultEventHandler): Flipped the condition back + from where it was prior to r60418. + * svg/SVGElement.cpp: Removed eventParentNode that's no longer needed. + * svg/SVGElement.h: Ditto. + +2010-11-12 Ryuan Choi <ryuan.choi@samsung.com> + + Reviewed by Martin Robinson. + + [GTK] Remove unnecessary header for FontPlatformDataPango.cpp + https://bugs.webkit.org/show_bug.cgi?id=46029 + + Remove unnecessary header includes. + No new tests, as there's no functionality. + + * platform/graphics/pango/FontPlatformDataPango.cpp: + +2010-11-11 Abhishek Arya <inferno@chromium.org> + + Reviewed by Adam Barth. + + Not allow drag and drop across different origins. + https://bugs.webkit.org/show_bug.cgi?id=49098 + + Test: http/tests/security/drag-drop-different-origin.html + + * page/DragController.cpp: + (WebCore::DragController::tryDocumentDrag): + * page/SecurityOrigin.cpp: + (WebCore::SecurityOrigin::canDropOnTarget): + * page/SecurityOrigin.h: + +2010-11-11 Alexander Pavlov <apavlov@chromium.org> + + Reviewed by Yury Semikhatsky. + + Web Inspector: Inspect element tooltip obscures element metrics + https://bugs.webkit.org/show_bug.cgi?id=47822 + + * inspector/InspectorController.cpp: + (WebCore::InspectorController::drawNodeHighlight): + (WebCore::InspectorController::drawElementTitle): + +2010-11-12 Luiz Agostini <luiz.agostini@openbossa.org> + + Reviewed by Kenneth Rohde Christiansen. + + [Qt] Button's background style from default Qt Mobile Theme is overriding facebook's button style + https://bugs.webkit.org/show_bug.cgi?id=48198 + + Instead of creating gradients that goes from white to grey and cover the whole element the gradients + are created by varying the alpha channel of a dark color. This way the effect will not override the + background color of the elements. + + * css/themeQtMobile.css: + +2010-11-12 Justin Schuh <jschuh@chromium.org> + + Reviewed by Adam Barth. + + Use a RefPtr inside ContainerNode::willRemove loop + https://bugs.webkit.org/show_bug.cgi?id=49237 + + Test: fast/innerHTML/innerHTML-iframe.html + + * dom/ContainerNode.cpp: + (WebCore::ContainerNode::willRemove): + +2010-11-12 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Yury Semikhatsky. + + Web Inspector: add more event listener breakpoint types, add support for regular breakpoint hit state, beautify hit rendering. + https://bugs.webkit.org/show_bug.cgi?id=49130 + + * English.lproj/localizedStrings.js: + * inspector/front-end/BreakpointManager.js: + (WebInspector.BreakpointManager.prototype.debuggerPaused): + (WebInspector.Breakpoint.jsBreakpointId): + (WebInspector.Breakpoint.prototype.get id): + * inspector/front-end/BreakpointsSidebarPane.js: + (WebInspector.EventListenerBreakpointsSidebarPane): + (WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCategory): + * inspector/front-end/CallStackSidebarPane.js: + (WebInspector.CallStackSidebarPane.prototype._breakpointHit): don't call populateStatusMessage for JS breakpoints + since there is no specific message in that case. + * inspector/front-end/ScriptsPanel.js: + (WebInspector.ScriptsPanel): + (WebInspector.ScriptsPanel.prototype.reset): + * inspector/front-end/inspector.css: + (#elements-sidebar): + (.pane > .body): + (#scripts-sidebar): + (li.breakpoint-hit .breakpoint-hit-marker): + +2010-11-12 Andrey Kosyakov <caseq@chromium.org> + + Reviewed by Yury Semikhatsky. + + Web Inspector: [Extensions API] [refactoring] generate public API interfaces automatically + https://bugs.webkit.org/show_bug.cgi?id=49441 + + * inspector/front-end/ExtensionAPI.js: + (WebInspector.injectedExtensionAPI.PanelImpl): + (WebInspector.injectedExtensionAPI): + (WebInspector.injectedExtensionAPI.WatchExpressionSidebarPane): + (WebInspector.injectedExtensionAPI.AuditCategoryImpl): + (WebInspector.injectedExtensionAPI.AuditResultImpl): + (WebInspector.injectedExtensionAPI.AuditResultImpl.prototype.get Severity): + (WebInspector.injectedExtensionAPI.): + +2010-11-12 Renata Hodovan <reni@webkit.org> + + Reviewed by Nikolas Zimmermann. + + SVGFEDisplacementMapElement doesn't support dynamic invalidation + https://bugs.webkit.org/show_bug.cgi?id=49430 + + The dynamic changes are captured by the svgAttributeChanged function. Invalidate the filter primitive if necessary. + + Tests: svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr.html + svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr.html + svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr.html + svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr.html + svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr.html + svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop.html + svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop.html + svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop.html + svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop.html + svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop.html + + * svg/SVGFEDisplacementMapElement.cpp: + (WebCore::SVGFEDisplacementMapElement::svgAttributeChanged): + * svg/SVGFEDisplacementMapElement.h: + +2010-11-12 Andrey Kosyakov <caseq@chromium.org> + + Reviewed by Yury Semikhatsky. + + Web Inspector: [refactoring] do not use absolute positioning for tabbed panes + https://bugs.webkit.org/show_bug.cgi?id=49439 + + * inspector/front-end/TabbedPane.js: + (WebInspector.TabbedPane): + (WebInspector.TabbedPane.prototype.appendTab): + * inspector/front-end/inspector.css: + (.resource-view.visible): + (.resource-view .tabbed-pane-header): + (.resource-view-cookies): + (.tabbed-pane): + (.tabbed-pane-content): + * inspector/front-end/networkPanel.css: + +2010-11-12 John Knottenbelt <jknotten@chromium.org> + + Reviewed by Steve Block. + + Rename GeolocationControllerClient to GeolocationClient. + https://bugs.webkit.org/show_bug.cgi?id=49259 + + No new tests, renaming only. + + * GNUmakefile.am: + * WebCore.gypi: + * WebCore.order: + * WebCore.vcproj/WebCore.vcproj: + * WebCore.xcodeproj/project.pbxproj: + * page/GeolocationClient.h: Renamed from WebCore/page/GeolocationControllerClient.h. + (WebCore::GeolocationClient::~GeolocationClient): + * page/GeolocationController.cpp: + (WebCore::GeolocationController::GeolocationController): + * page/GeolocationController.h: + * page/Page.h: + +2010-11-12 Ilya Sherman <isherman@chromium.org> + + Reviewed by Eric Seidel. + + Remove some trailing whitespace + https://bugs.webkit.org/show_bug.cgi?id=49433 + + * platform/PopupMenuClient.h: + * platform/chromium/PopupMenuChromium.cpp: + (WebCore::PopupContainer::show): + (WebCore::PopupListBox::paintRow): + (WebCore::PopupListBox::scrollToRevealRow): + * platform/chromium/PopupMenuChromium.h: + * platform/chromium/SearchPopupMenuChromium.cpp: + * rendering/RenderMenuList.h: + (WebCore::RenderMenuList::toRenderMenuList): + * rendering/RenderTextControlSingleLine.h: + (WebCore::toRenderTextControlSingleLine): + +2010-11-12 Ryosuke Niwa <rniwa@webkit.org> + + Reviewed by Csaba Osztrogonác. + + [qt] script-clone tests added in r71895 fails on qt platform + https://bugs.webkit.org/show_bug.cgi?id=49429 + + Fixed parseEndElement to call ScriptElement's executeScript as supposed to that of ScriptController. + + * dom/XMLDocumentParserQt.cpp: + (WebCore::XMLDocumentParser::parseEndElement): + +2010-11-05 MORITA Hajime <morrita@google.com> + + Reviewed by Kent Tamura. + + Refactoring: Return values of TextCheckingHelper::paragraphAlignedRange should form a class. + https://bugs.webkit.org/show_bug.cgi?id=49053 + + Replaced paragraphAlignedRange() function call into + TextCheckingParagraph class. The class encapsulates a range of a + paragraph, and its relation within associated checking range. + Instance variables of the class are computed lazily. So we can save unnecessary + memory allocation and DOM tree traversal. + + No new tests, no behavior change. + + * editing/Editor.cpp: + (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Replaced paragraphAlignedRange() call. + (WebCore::Editor::changeBackToReplacedString): Replaced paragraphAlignedRange() call. + * editing/TextCheckingHelper.cpp: + (WebCore::expandToParagraphBoundary): + (WebCore::TextCheckingParagraph::TextCheckingParagraph): + (WebCore::TextCheckingParagraph::~TextCheckingParagraph): + (WebCore::TextCheckingParagraph::expandRangeToNextEnd): + (WebCore::TextCheckingParagraph::invalidateParagraphRangeValues): + (WebCore::TextCheckingParagraph::rangeLength): + (WebCore::TextCheckingParagraph::paragraphRange): + (WebCore::TextCheckingParagraph::subrange): + (WebCore::TextCheckingParagraph::offsetTo): + (WebCore::TextCheckingParagraph::isEmpty): + (WebCore::TextCheckingParagraph::offsetAsRange): + (WebCore::TextCheckingParagraph::text): + (WebCore::TextCheckingParagraph::checkingStart): + (WebCore::TextCheckingParagraph::checkingEnd): + (WebCore::TextCheckingParagraph::checkingLength): + (WebCore::TextCheckingHelper::findFirstBadGrammar): Replaced paragraphAlignedRange() call. + (WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange): Replaced paragraphAlignedRange() call. + * editing/TextCheckingHelper.h: + (WebCore::TextCheckingParagraph::textLength): + (WebCore::TextCheckingParagraph::textSubstring): + (WebCore::TextCheckingParagraph::textCharacters): + (WebCore::TextCheckingParagraph::textCharAt): + (WebCore::TextCheckingParagraph::checkingSubstring): + (WebCore::TextCheckingParagraph::checkingRangeMatches): + (WebCore::TextCheckingParagraph::isCheckingRangeCoveredBy): + (WebCore::TextCheckingParagraph::checkingRangeCovers): + (WebCore::TextCheckingParagraph::checkingRange): + (WebCore::TextCheckingParagraph::isTextEmpty): + (WebCore::TextCheckingParagraph::isRangeEmpty): + +2010-11-11 Ryosuke Niwa <rniwa@webkit.org> + + Reviewed by Darin Adler. + + Script runs more than once after a clone + https://bugs.webkit.org/show_bug.cgi?id=48966 + + The bug was caused by cloneElementWithoutChildren's not propagating isEvaluated flag, + which indicates whether or not the script has already started, and the fact + neither HTMLScriptRunner nor XMLDocumentParser was setting isEvaluated flag to true. + + Fixed the bug by making cloneElementWithoutChildren call a virtual cloneElementWithoutAttributesAndChildren, + and override it in HTMLScriptElement and SVGScriptElement to propagate isEvaluated flag, + and replacing direct access to ScriptController by a call to new ScriptElementData::executeScript, + which updates the isEvaluated flag properly. + + See also: http://www.whatwg.org/specs/web-apps/current-work/#already-started + + Tests: fast/dom/script-clone-rerun-self.html + fast/dom/script-clone-rerun.html + svg/dom/SVGScriptElement/script-clone-rerun-self.svg + svg/dom/SVGScriptElement/script-clone-rerun.svg + + * dom/Element.cpp: + (WebCore::Element::cloneElementWithoutChildren): Calls cloneElementWithoutChildren. + (WebCore::Element::cloneElementWithoutAttributesAndChildren): Extracted from cloneElementWithoutChildren. + * dom/Element.h: + * dom/ScriptElement.cpp: + (WebCore::ScriptElementData::ScriptElementData): Added isEvaluated flag to the argument list. + (WebCore::ScriptElementData::evaluateScript): Extracted from HTMLScriptRunner::executeScript. + (WebCore::ScriptElementData::executeScript): Renamed evaluated to isEvaluated. + (WebCore::ScriptElementData::ignoresLoadRequest): Renamed evaluated to isEvaluated. + * dom/ScriptElement.h: Renamed evaluated to isEvaluated. + (WebCore::ScriptElementData::isEvaluated): Added. + * dom/XMLDocumentParserLibxml2.cpp: + (WebCore::XMLDocumentParser::endElementNs): Calls ScriptElement::executeScript. + * html/HTMLScriptElement.cpp: + (WebCore::HTMLScriptElement::HTMLScriptElement): Added isEvaluated flag to the argument list. + (WebCore::HTMLScriptElement::create): Calls the constructor with the isEvaluated flag set to false. + (WebCore::HTMLScriptElement::cloneElementWithoutAttributesAndChildren): Propagates isEvaluated. + (WebCore::HTMLScriptElement::executeScript): Added; calls ScriptElementData::executeScript. + * html/HTMLScriptElement.h: + * html/parser/HTMLScriptRunner.cpp: + (WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent): Added an assertion that was lost + in extracting ScriptElementData::executeScript. + (WebCore::HTMLScriptRunner::runScript): Calls ScriptElementData::executeScript. + * html/parser/HTMLScriptRunner.h: + * svg/SVGScriptElement.cpp: + (WebCore::SVGScriptElement::SVGScriptElement): Added isEvaluated flag to the argument list. + (WebCore::SVGScriptElement::create): Calls the constructor with the isEvaluated flag set to false. + (WebCore::SVGScriptElement::cloneElementWithoutAttributesAndChildren): Propagates isEvaluated. + (WebCore::SVGScriptElement::executeScript): Added; calls ScriptElementData::executeScript. + * svg/SVGScriptElement.h: + +2010-11-11 Shinichiro Hamaji <hamaji@chromium.org> + + Reviewed by Darin Adler. + + REGRESSION: window.print in onload doesn't fire if there's an img + https://bugs.webkit.org/show_bug.cgi?id=48195 + + This issue was introduced in + https://bugs.webkit.org/show_bug.cgi?id=43658 + This happens because FrameLoader::isLoading() is false while an + image is still loading. Now, window.print() happens after all + resources are loaded. + + Also changed the name of a member variable as Darin suggested in Bug 43658. + + Added a manual test as DRT doesn't support window.print() yet. + + * loader/DocumentLoader.cpp: + (WebCore::DocumentLoader::DocumentLoader): + (WebCore::DocumentLoader::updateLoading): + * loader/DocumentLoader.h: + * page/DOMWindow.cpp: + (WebCore::DOMWindow::DOMWindow): + (WebCore::DOMWindow::print): + (WebCore::DOMWindow::finishedLoading): + * page/DOMWindow.h: + +2010-11-11 James Simonsen <simonjam@chromium.org> + + Reviewed by Tony Chang. + + [chromium] Support letter spacing and fix whitespace wrapping on linux + + When lines wrapped on RTL text, the whitespace was inserted before + the first character on the new line instead of at the end of the + previous line. This has been fixed. + + The missing cluster information needed for letter spacing was hidden in + harfbuzz's attributes struct. + + https://bugs.webkit.org/show_bug.cgi?id=49405 + + * platform/graphics/chromium/FontLinux.cpp: + (WebCore::TextRunWalker::letterSpacing): Added. + (WebCore::TextRunWalker::isWordBreak): No need for isRTL. + (WebCore::TextRunWalker::setPadding): Ditto. + (WebCore::TextRunWalker::setGlyphXPositions): Support letter spacing. No whitespace before RTL text on new line. + (WebCore::glyphIndexForXPositionInScriptRun): Support letter spacing. + +2010-11-11 Kavita Kanetkar <kkanetkar@chromium.org> + + Reviewed by Dumitru Daniliuc. + + FileSystem: Fix a link error for non-chromium WebKit build + https://bugs.webkit.org/show_bug.cgi?id=49296 + + * WebCore.xcodeproj/project.pbxproj: + * inspector/InspectorFileSystemAgent.cpp: + (WebCore::InspectorFileSystemAgentCallbacks::didOpenFileSystem): + (WebCore::InspectorFileSystemAgentCallbacks::didReadDirectoryEntry): + (WebCore::InspectorFileSystemAgentCallbacks::didReadDirectoryEntries): + (WebCore::InspectorFileSystemAgentCallbacks::didCreateFileWriter): + (WebCore::InspectorFileSystemAgentCallbacks::didFail): + (WebCore::InspectorFileSystemAgent::revealFolderInOS): + +2010-11-11 Nate Chapin <japhet@chromium.org> + + Reviewed by Antti Koivisto. + + Cleanup after http://trac.webkit.org/changeset/71562, namely: + Make deferred request handle simpler. + Don't perform callbacks associated with network load starting + (e.g., willSendRequest) until the load is in fact sent to the network. + Make ResourceLoadScheduler a friend of ResourceLoader and make + ResourceLoader::start() protected to try to ensure loads actually + go through the scheduler. + https://bugs.webkit.org/show_bug.cgi?id=49351 + + Behavior should be covered by existing tests. + + * loader/NetscapePlugInStreamLoader.cpp: + (WebCore::NetscapePlugInStreamLoader::create): + * loader/ResourceLoadScheduler.cpp: + (WebCore::ResourceLoadScheduler::servePendingRequests): + * loader/ResourceLoadScheduler.h: + (WebCore::ResourceLoadScheduler::HostInformation::limitRequests): + * loader/ResourceLoader.cpp: + (WebCore::ResourceLoader::init): + (WebCore::ResourceLoader::start): + (WebCore::ResourceLoader::setDefersLoading): + (WebCore::ResourceLoader::didCancel): + * loader/ResourceLoader.h: + (WebCore::ResourceLoader::reachedTerminalState): + (WebCore::ResourceLoader::request): + * loader/SubresourceLoader.cpp: + (WebCore::SubresourceLoader::create): + * loader/loader.cpp: + (WebCore::Loader::load): + (WebCore::Loader::willSendRequest): + * loader/loader.h: + +2010-11-11 Carol Szabo <carol.szabo@nokia.com> + + Reviewed by Kent Tamura. + + css2:order of counters in out-of flow content + https://bugs.webkit.org/show_bug.cgi?id=32412 + + Tests: fast/css/content/content-none.html + fast/css/content/content-normal.html + + * css/CSSParser.cpp: + (WebCore::CSSParser::parseContent): + Added support for none, normal, open-quote, no-open-quote, etc. + identifiers in terms of parsing only, as this has effect on the + evaluation of counters. No further implementation needed for + none and normal, the others are parsed but do not work as expected. + +2010-11-11 Julie-Jeongeun-Kim <jiyuluna@gmail.com> + + Reviewed by Kent Tamura. + + SelectionStart, selectionEnd properties return wrong values when the selection is in a read-only input or textarea element + https://bugs.webkit.org/show_bug.cgi?id=25444 + + 'rootEditableElement()' is checked on RenderTextControl::indexForVisiblePosition. + It means that just editable elements can get selection information. + ReadOnly element is not editable element. So, it just returns and can't get correct selection information. + INPUT and TEXTAREA elements can be read-only but 'indexForVisiblePosition' doesn't accept them. + So, Selectable elements, INPUT and TEXTAREA, checking is added for that case. + Even if they are read-only, they are selectable. + + new tests:fast/forms/selection-start-end-readonly.html + + * html/HTMLInputElement.idl: + * rendering/RenderTextControl.cpp: + (WebCore::RenderTextControl::isSelectableElement): + (WebCore::RenderTextControl::indexForVisiblePosition): + * rendering/RenderTextControl.h: + +2010-11-11 Adam Barth <abarth@webkit.org> + + Reviewed by David Levin. + + Add some RefPtrs to be on the safe side + https://bugs.webkit.org/show_bug.cgi?id=49301 + + Hopefully no behavior change. + + * html/parser/HTMLTreeBuilder.cpp: + (WebCore::HTMLTreeBuilder::processIsindexStartTagForInBody): + +2010-11-11 Chris Rogers <crogers@google.com> + + Reviewed by Kenneth Russell. + + Fix Accelerate.framework issues in VectorMath 32-bit ppc & i386 vs. other architectures (64-bit, ARM, etc.). + On the Mac we use the highly optimized versions in Accelerate.framework + In 32-bit mode (__ppc__ or __i386__) <Accelerate/Accelerate.h> includes <vecLib/vDSP_translate.h> which defines macros + of the same name as our namespaced function names, so we must handle this case differently. + Other architectures (64bit, ARM, etc.) do not include this header file. + + https://bugs.webkit.org/show_bug.cgi?id=49112 + + No new tests since audio API is not yet implemented. + + * platform/audio/VectorMath.cpp: + (WebCore::VectorMath::vsmul): + (WebCore::VectorMath::vadd): + +2010-11-11 Dan Bernstein <mitz@apple.com> + + Reviewed by Darin Adler. + + <rdar://problem/8657116> fast/text/justification-padding-mid-word.html fails on Windows + https://bugs.webkit.org/show_bug.cgi?id=49378 + + * platform/graphics/win/UniscribeController.cpp: + (WebCore::UniscribeController::shapeAndPlaceItem): For all characters that need to be treated + as zero-width spaces, substitute the space glyph with zero advance. Apply justification padding + and word spacing only at characters treated as (non-zero-width) spaces. + +2010-11-11 Darin Adler <darin@apple.com> + + Reviewed by Sam Weinig. + + Harden some string functions against large lengths + https://bugs.webkit.org/show_bug.cgi?id=49293 + + * rendering/RenderText.cpp: + (WebCore::makeCapitalized): Check before incrementing length. + +2010-11-10 Zhenyao Mo <zmo@google.com> + + Reviewed by Kenneth Russell. + + bufferData/bufferSubData should not crash with null data input + https://bugs.webkit.org/show_bug.cgi?id=49350 + + * html/canvas/WebGLRenderingContext.cpp: return early if input data is null. + (WebCore::WebGLRenderingContext::bufferData): + (WebCore::WebGLRenderingContext::bufferSubData): + +2010-11-10 Zhenyao Mo <zmo@google.com> + + Reviewed by Kenneth Russell. + + Implement UNPACK_COLORSPACE_CONVERSION_WEBGL + https://bugs.webkit.org/show_bug.cgi?id=47196 + + This is the first patch for this bug. We add constants and methods, but haven't hooked it up with texture uploading yet. Also, in order to check in constants.html, we need to remove out-dated constants, and update affected tests correspondingly. + + Test: fast/canvas/webgl/constants.html + + * html/canvas/WebGLRenderingContext.cpp: + (WebCore::WebGLRenderingContext::WebGLRenderingContext): Move init code to initializeNewContext. + (WebCore::WebGLRenderingContext::initializeNewContext): Ditto. + (WebCore::WebGLRenderingContext::getParameter): Implement UNPACK_COLORSPACE_CONVERSION_WEBGL. + (WebCore::WebGLRenderingContext::pixelStorei): Ditto. + * html/canvas/WebGLRenderingContext.h: Add a member to track UNPACK_COLORSPACE_CONVERSION_WEBGL setting. + * html/canvas/WebGLRenderingContext.idl: Update constants. + * platform/graphics/GraphicsContext3D.h: Update constants. + +2010-11-11 Chris Marrin <cmarrin@apple.com> + + Reviewed by James Robinson. + + Add multisampling support to DrawingBuffer. + https://bugs.webkit.org/show_bug.cgi?id=49206 + + Added support for the GL_ANGLE_framebuffer_blit and GL_ANGLE_framebuffer_multisample + extensions to Extensions3D. Then I use these to add multisample support to DrawingBuffer. + + This re-lands changes rolled out by http://trac.webkit.org/changeset/71839. It includes + the change from http://trac.webkit.org/changeset/71831 and additional changes to + DrawingBufferChromium.cpp which cause the broken canvas tests to pass. + + * platform/graphics/Extensions3D.h: + * platform/graphics/chromium/DrawingBufferChromium.cpp: + (WebCore::DrawingBuffer::DrawingBuffer): + (WebCore::DrawingBuffer::~DrawingBuffer): + (WebCore::DrawingBuffer::publishToPlatformLayer): + (WebCore::DrawingBuffer::didReset): + (WebCore::DrawingBuffer::platformColorBuffer): + * platform/graphics/chromium/Extensions3DChromium.h: + (WebCore::Extensions3DChromium::blitFramebuffer): + (WebCore::Extensions3DChromium::renderbufferStorageMultisample): + * platform/graphics/gpu/DrawingBuffer.cpp: + (WebCore::DrawingBuffer::create): + (WebCore::DrawingBuffer::clear): + (WebCore::DrawingBuffer::reset): + (WebCore::DrawingBuffer::commit): + (WebCore::DrawingBuffer::bind): + * platform/graphics/gpu/DrawingBuffer.h: + (WebCore::DrawingBuffer::multisample): + * platform/graphics/gpu/mac/DrawingBufferMac.mm: + (WebCore::DrawingBuffer::DrawingBuffer): + (WebCore::DrawingBuffer::didReset): + (WebCore::DrawingBuffer::platformColorBuffer): + * platform/graphics/opengl/Extensions3DOpenGL.cpp: + (WebCore::Extensions3DOpenGL::supports): + (WebCore::Extensions3DOpenGL::blitFramebuffer): + (WebCore::Extensions3DOpenGL::renderbufferStorageMultisample): + * platform/graphics/opengl/Extensions3DOpenGL.h: + * platform/graphics/skia/ImageBufferSkia.cpp: + (WebCore::ImageBuffer::draw): + +2010-11-11 David Hyatt <hyatt@apple.com> + + Reviewed by Simon Fraser. + + https://bugs.webkit.org/show_bug.cgi?id=48664 + + Make repaint invalidation work with flipped blocks ("rl" and "bt" writing modes). + + This patch disables the layout state for flipped blocks, since the paint offset isn't right. + + Bugs in the overflow sides for lines have been fixed. before/AfterSideVisible/LayoutOverflowForLine + now respect flipping (and don't incorrectly change sides). This is a very confusing aspect of + the overflow stuff (and at some point we should consider renaming top/left/right/bottom since they + aren't physical). + + offsetFromContainer and mapLocalToContainer remain physical and refer to the top left offset. + This means at every step up you convert to the correct physical coordinate. It also means these + functions will be unreliable during layout for flipped blocks. At first glance, this seems to be + more or less ok. + + computeRectForRepaint now delays flipping conversions until you cross a writing-mode boundary. This + allows for documents to be fully flipped and repaint during layout can still be reliable. This is + critical for incremental line layout repainting. + + Added new tests in fast/repaint and also rebaselined the tests in that directory because I'm tired + of all the stale results and failures. + + * editing/SelectionController.cpp: + (WebCore::SelectionController::absoluteBoundsForLocalRect): + (WebCore::SelectionController::paintCaret): + * rendering/InlineTextBox.cpp: + (WebCore::InlineTextBox::selectionRect): + * rendering/RenderBlock.cpp: + (WebCore::RenderBlock::layoutBlock): + (WebCore::RenderBlock::layoutOnlyPositionedObjects): + (WebCore::RenderBlock::paintSelection): + * rendering/RenderBlockLineLayout.cpp: + (WebCore::RenderBlock::beforeSideVisibleOverflowForLine): + (WebCore::RenderBlock::afterSideVisibleOverflowForLine): + (WebCore::RenderBlock::beforeSideLayoutOverflowForLine): + (WebCore::RenderBlock::afterSideLayoutOverflowForLine): + * rendering/RenderBox.cpp: + (WebCore::RenderBox::layout): + (WebCore::RenderBox::mapLocalToContainer): + (WebCore::RenderBox::offsetFromContainer): + (WebCore::RenderBox::clippedOverflowRectForRepaint): + (WebCore::RenderBox::computeRectForRepaint): + (WebCore::RenderBox::flipForWritingMode): + (WebCore::RenderBox::locationOffsetIncludingFlipping): + * rendering/RenderBox.h: + * rendering/RenderFlexibleBox.cpp: + (WebCore::RenderFlexibleBox::layoutBlock): + * rendering/RenderInline.cpp: + (WebCore::RenderInline::clippedOverflowRectForRepaint): + * rendering/RenderSlider.cpp: + (WebCore::RenderSlider::layout): + * rendering/RenderTable.cpp: + (WebCore::RenderTable::layout): + * rendering/RenderTableRow.cpp: + (WebCore::RenderTableRow::layout): + * rendering/RenderTableSection.cpp: + (WebCore::RenderTableSection::layout): + (WebCore::RenderTableSection::layoutRows): + * rendering/RenderView.cpp: + (WebCore::RenderView::computeRectForRepaint): + * rendering/ShadowElement.cpp: + (WebCore::ShadowBlockElement::layoutAsPart): + +2010-11-11 Chris Marrin <cmarrin@apple.com> + + Reviewed by Simon Fraser. + + Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations + https://bugs.webkit.org/show_bug.cgi?id=49388 + + Renamed GraphicsLayerCA.* to GraphicsLayerMac.* + + * WebCore.xcodeproj/project.pbxproj: + * platform/graphics/mac/GraphicsLayerCA.h: Removed. + * platform/graphics/mac/GraphicsLayerCA.mm: Removed. + * platform/graphics/mac/GraphicsLayerMac.h: Copied from WebCore/platform/graphics/mac/GraphicsLayerCA.h. + * platform/graphics/mac/GraphicsLayerMac.mm: Copied from WebCore/platform/graphics/mac/GraphicsLayerCA.mm. + +2010-11-11 Kenneth Russell <kbr@google.com> + + Reviewed by James Robinson. + + [chromium] Missing adoptPtr in GraphicsContext3DSkia.cpp + https://bugs.webkit.org/show_bug.cgi?id=49359 + + * platform/graphics/skia/GraphicsContext3DSkia.cpp: + (WebCore::GraphicsContext3D::getImageData): + +2010-11-11 Dan Bernstein <mitz@apple.com> + + Reviewed by Adam Roben. + + <rdar://problem/8113511> Enable auto-hyphenation + + * WebCore.vcproj/WebCore.vcproj: Included HyphenationCF.cpp instead of Hyphenation.cpp. + * platform/text/cf/HyphenationCF.cpp: Added functions and definitions for Windows to look up CFStringGetHyphenationLocationBeforeIndex + and CFStringIsHyphenationAvailableForLocale at runtime. + (wkCFStringGetHyphenationLocationBeforeIndex): + (wkCFStringIsHyphenationAvailableForLocale): + (WebCore::lastHyphenLocation): Added a cast. + +2010-11-11 Eric Carlson <eric.carlson@apple.com> + + Reviewed by Eric Seidel. + + video-pause-immediately.html sometimes fails + https://bugs.webkit.org/show_bug.cgi?id=49397 + + * html/HTMLMediaElement.cpp: + (WebCore::HTMLMediaElement::playInternal): Don't bother calling invalidateCachedTime, it + will be called from updatePlayState. + (WebCore::HTMLMediaElement::pauseInternal): Don't bother calling refreshCachedTime, it + will be called from updatePlayState. + (WebCore::HTMLMediaElement::updatePlayState): Call refreshCachedTime after telling the media + engine to pause so we cache the post-paused time. + +2010-11-11 Mihai Parparita <mihaip@chromium.org> + + Unreviewed rollout. + + Roll out r71827 and r71831, which caused many GPU canvas test failures. + + * platform/graphics/Extensions3D.h: + * platform/graphics/chromium/DrawingBufferChromium.cpp: + (WebCore::DrawingBuffer::reset): + (WebCore::DrawingBuffer::getRenderingResultsAsTexture): + * platform/graphics/chromium/Extensions3DChromium.h: + * platform/graphics/gpu/DrawingBuffer.cpp: + (WebCore::DrawingBuffer::create): + (WebCore::DrawingBuffer::clear): + (WebCore::DrawingBuffer::bind): + * platform/graphics/gpu/DrawingBuffer.h: + * platform/graphics/gpu/SharedGraphicsContext3D.cpp: + (WebCore::SharedGraphicsContext3D::create): + * platform/graphics/gpu/mac/DrawingBufferMac.mm: + (WebCore::DrawingBuffer::DrawingBuffer): + (WebCore::DrawingBuffer::reset): + * platform/graphics/opengl/Extensions3DOpenGL.cpp: + (WebCore::Extensions3DOpenGL::supports): + * platform/graphics/opengl/Extensions3DOpenGL.h: + * platform/graphics/skia/ImageBufferSkia.cpp: + (WebCore::ImageBuffer::draw): + +2010-11-11 Eric Carlson <eric.carlson@apple.com> + + Restore the portion of the ChangeLog removed in my last commit. + +2010-11-11 Eric Carlson <eric.carlson@apple.com> + + Unreviewed Leoaprd build fix. + + * html/HTMLMediaElement.cpp: + (WebCore::HTMLMediaElement::invalidateCachedTime): Make the const a double. + +2010-11-11 Dirk Schulze <krit@webkit.org> + + Unreviewed Qt build fix. + + SVGAnimation calcMode 'spline' should be useable for from-to and from-by animations + https://bugs.webkit.org/show_bug.cgi?id=49284 + + * svg/SVGAnimationElement.cpp: + (WebCore::SVGAnimationElement::calculatePercentFromKeyPoints): + (WebCore::SVGAnimationElement::startedActiveInterval): + +2010-11-11 Hans Wennborg <hans@chromium.org> + + Reviewed by Jeremy Orlow. + + IndexedDB: signal IDBFactoryBackendInterface destruction to embedder + https://bugs.webkit.org/show_bug.cgi?id=49313 + + Define IDBFactoryBackendInterface destructor out-of-line to allow + for embedder-specific implementation. For Chromium, have the + destructor call ChromiumBridge::idbShutdown(). + + * platform/chromium/ChromiumBridge.h: + * storage/IDBFactoryBackendInterface.cpp: + (WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface): + * storage/IDBFactoryBackendInterface.h: + * storage/chromium/IDBFactoryBackendInterface.cpp: + (WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface): + +2010-11-11 Dirk Schulze <krit@webkit.org> + + Reviewed by Nikolas Zimmermann. + + SVGAnimation calcMode 'spline' should be useable for from-to and from-by animations + https://bugs.webkit.org/show_bug.cgi?id=49284 + + Add support for from-to and from-by animations in combination with calcMode 'spline' for SVGAnimations. + + Tests: svg/animations/animate-calcMode-spline-by.html + svg/animations/animate-calcMode-spline-from-by.html + svg/animations/animate-calcMode-spline-from-to.html + svg/animations/animate-calcMode-spline-to.html + svg/animations/animate-calcMode-spline-values.html + + * svg/SVGAnimationElement.cpp: + (WebCore::SVGAnimationElement::calculateKeyTimesIndex): Added to share more code. + (WebCore::SVGAnimationElement::calculatePercentFromKeyPoints): + (WebCore::SVGAnimationElement::currentValuesForValuesAnimation): + (WebCore::SVGAnimationElement::startedActiveInterval): + (WebCore::SVGAnimationElement::updateAnimation): + * svg/SVGAnimationElement.h: + +2010-11-10 Chris Marrin <cmarrin@apple.com> + + Reviewed by James Robinson. + + Add multisampling support to DrawingBuffer. + https://bugs.webkit.org/show_bug.cgi?id=49206 + + Added support for the GL_ANGLE_framebuffer_blit and GL_ANGLE_framebuffer_multisample + extensions to Extensions3D. Then I use these to add multisample support to DrawingBuffer. + + * platform/graphics/Extensions3D.h: + * platform/graphics/chromium/DrawingBufferChromium.cpp: + (WebCore::DrawingBuffer::platformColorBuffer): + * platform/graphics/chromium/Extensions3DChromium.h: + (WebCore::Extensions3DChromium::blitFramebuffer): + (WebCore::Extensions3DChromium::renderbufferStorageMultisample): + * platform/graphics/gpu/DrawingBuffer.cpp: + (WebCore::DrawingBuffer::create): + (WebCore::DrawingBuffer::clear): + (WebCore::DrawingBuffer::reset): + (WebCore::DrawingBuffer::commit): + (WebCore::DrawingBuffer::bind): + * platform/graphics/gpu/DrawingBuffer.h: + (WebCore::DrawingBuffer::multisample): + * platform/graphics/gpu/mac/DrawingBufferMac.mm: + (WebCore::DrawingBuffer::DrawingBuffer): + (WebCore::DrawingBuffer::platformLayer): + (WebCore::DrawingBuffer::platformColorBuffer): + * platform/graphics/opengl/Extensions3DOpenGL.cpp: + (WebCore::Extensions3DOpenGL::supports): + (WebCore::Extensions3DOpenGL::blitFramebuffer): + (WebCore::Extensions3DOpenGL::renderbufferStorageMultisample): + * platform/graphics/opengl/Extensions3DOpenGL.h: + * platform/graphics/skia/ImageBufferSkia.cpp: + (WebCore::ImageBuffer::draw): + +2010-11-11 Eric Carlson <eric.carlson@apple.com> + + Build fix after r71824. + + * html/HTMLMediaElement.cpp: + (WebCore::HTMLMediaElement::invalidateCachedTime): Use an explicit cast from double to float. + (WebCore::HTMLMediaElement::currentTime): Ditto. + +2010-11-11 Eric Carlson <eric.carlson@apple.com> + + Reviewed by Antti Koivisto. + + Lots of time spent in MediaPlayerPrivate::currentTime() when playing multiple videos. + https://bugs.webkit.org/show_bug.cgi?id=49009 + + Make it possible for HTMLMediaElement to cache the movie time and report 'currentTime' + as [cached time + elapsed wall time]. The media engine returns the maximum duration it + is safe to calculate time before resampling the actual movie time with the new + maximumDurationToCacheMovieTime method. Because this may be different for different media + engines the default return value is 0, making it an opt-in feature. + + No new tests were added because the existing tests already check currentTime, and because + it is only possible to look for drift between the calculated and actual media time by + calculating the time AND getting the actual media time - which the defeats the purpose of + the change. Building with LOG_CACHED_TIME_WARNINGS defined enables code that does both + and logs warnings when the delta between calculated and observed is greater than 0.01. + + * html/HTMLMediaElement.cpp: + (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize new member variables. + (WebCore::HTMLMediaElement::prepareForLoad): Force a time resync before setting m_paused. + (WebCore::HTMLMediaElement::seek): Force a time resync before getting the current time before + seeking so there is no drift. + (WebCore::HTMLMediaElement::refreshCachedTime): New, update the cached movie time and the + wall clock time it was recorded. + (WebCore::HTMLMediaElement::invalidateCachedTime): New, flag the cached time as invalid. + (WebCore::HTMLMediaElement::currentTime): Use a cached movie time for as long as the media + engine says it is safe. Lots of optional logging can be enabled to help ports fine tune + the maximum cache interval. + (WebCore::HTMLMediaElement::ended): Force a time resync before setting m_paused. + (WebCore::HTMLMediaElement::endScrubbing): Fix a typo in the logging. + (WebCore::HTMLMediaElement::scheduleTimeupdateEvent): Call currentTime() instead of calling + MediaPlayer so we use the cached time as much as it possible. + (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Invalidate cached time because the engine + seeked. + (WebCore::HTMLMediaElement::mediaPlayerRateChanged): Ditto. + (WebCore::HTMLMediaElement::updatePlayState): Invalidate cached time before changing m_paused. + * html/HTMLMediaElement.h: + + * platform/graphics/MediaPlayer.cpp: + (WebCore::MediaPlayer::maximumDurationToCacheMovieTime): New. + * platform/graphics/MediaPlayer.h: + * platform/graphics/MediaPlayerPrivate.h: + (WebCore::MediaPlayerPrivateInterface::maximumDurationToCacheMovieTime): New. + + * platform/graphics/mac/MediaPlayerPrivateQTKit.h: + (WebCore::MediaPlayerPrivate::maximumDurationToCacheMovieTime): New, say it is safe to cache + time for five seconds (based on lots of experimenting with LOG_CACHED_TIME_WARNINGS enabled). + +2010-11-11 Adam Roben <aroben@apple.com> + + Windows build fix after r71816 + + r71816 renamed + WebCore/platform/graphics/cairo/FontPlatformDataCairoWin.h to + WebCore/platform/graphics/win/FontPlatformData.h. This made Apple's + Windows port pick up this header in preference to + WebCore/platform/cg/FontPlatformData.h, thus breaking the build. I + moved the file to + WebCore/platform/graphics/win/cairo/FontPlatformData.h so it won't be + picked up by Apple's Windows build. + + * WebCore.vcproj/WebCore.vcproj: Updated for file move and let VS + re-sort the files. + + * WebCore.vcproj/WebCoreCairo.vsprops: Added + platform/graphics/win/cairo to the include path. + + * WebCore.vcproj/copyForwardingHeaders.cmd: Copy files from + platform/graphics/win/cairo to $WebKitOutputDir. + + * platform/graphics/cg/FontPlatformData.h: Touched to force this file + to be recopied for Apple's build. + + * platform/graphics/win/cairo/FontPlatformData.h: Renamed from + WebCore/platform/graphics/win/FontPlatformData.h. + +2010-11-11 Balazs Kelemen <kbalazs@webkit.org> + + Reviewed by Andreas Kling. + + [Qt][WK2] Implement BackingStore + https://bugs.webkit.org/show_bug.cgi?id=49377 + No change in functionality so no tests. + + Add a way to hand off ownership of the QPainter and the underlying + QPaintDevice to the GraphicsContext. + * platform/graphics/GraphicsContext.h: + * platform/graphics/qt/GraphicsContextQt.cpp: + (WebCore::GraphicsContextPlatformPrivate::takeOwnershipOfPlatformContext): + (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): + (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate): + (WebCore::GraphicsContext::takeOwnershipOfPlatformContext): + +2010-11-11 Ryuan Choi <ryuan.choi@samsung.com> + + Reviewed by Adam Barth. + + [GTK] Move font related files. + https://bugs.webkit.org/show_bug.cgi?id=48116 + + Move pango and freetype related files to share non-GTK+ platforms. + + No new tests because this is pure refactoring. + + * CMakeListsEfl.txt: + * GNUmakefile.am: + * WebCore.vcproj/WebCore.vcproj: + * platform/graphics/cairo/FontCacheFreeType.cpp: Removed. + * platform/graphics/cairo/FontCustomPlatformData.cpp: Removed. + * platform/graphics/cairo/FontPlatformData.h: Removed. + * platform/graphics/cairo/FontPlatformDataFreeType.cpp: Removed. + * platform/graphics/cairo/FontPlatformDataFreeType.h: Removed. + * platform/graphics/cairo/GlyphPageTreeNodeCairo.cpp: Removed. + * platform/graphics/cairo/SimpleFontDataCairo.cpp: Removed. + * platform/graphics/freetype: Added. + * platform/graphics/freetype/FontCacheFreeType.cpp: Copied from WebCore/platform/graphics/cairo/FontCacheFreeType.cpp. + * platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp: Copied from WebCore/platform/graphics/cairo/FontCustomPlatformData.cpp. + * platform/graphics/freetype/FontPlatformData.h: Copied from WebCore/platform/graphics/cairo/FontPlatformDataFreeType.h. + * platform/graphics/freetype/FontPlatformDataFreeType.cpp: Copied from WebCore/platform/graphics/cairo/FontPlatformDataFreeType.cpp. + * platform/graphics/freetype/GlyphPageTreeNodeFreeType.cpp: Copied from WebCore/platform/graphics/cairo/GlyphPageTreeNodeCairo.cpp. + * platform/graphics/freetype/SimpleFontDataFreeType.cpp: Copied from WebCore/platform/graphics/cairo/SimpleFontDataCairo.cpp. + * platform/graphics/gtk/FontCachePango.cpp: Removed. + * platform/graphics/gtk/FontCustomPlatformDataPango.cpp: Removed. + * platform/graphics/gtk/FontPlatformDataPango.cpp: Removed. + * platform/graphics/gtk/FontPlatformDataPango.h: Removed. + * platform/graphics/gtk/GlyphPageTreeNodePango.cpp: Removed. + * platform/graphics/gtk/SimpleFontDataPango.cpp: Removed. + * platform/graphics/pango: Added. + * platform/graphics/pango/FontCachePango.cpp: Copied from WebCore/platform/graphics/gtk/FontCachePango.cpp. + * platform/graphics/pango/FontCustomPlatformDataPango.cpp: Copied from WebCore/platform/graphics/gtk/FontCustomPlatformDataPango.cpp. + * platform/graphics/pango/FontPlatformData.h: Copied from WebCore/platform/graphics/gtk/FontPlatformDataPango.h. + * platform/graphics/pango/FontPlatformDataPango.cpp: Copied from WebCore/platform/graphics/gtk/FontPlatformDataPango.cpp. + * platform/graphics/pango/GlyphPageTreeNodePango.cpp: Copied from WebCore/platform/graphics/gtk/GlyphPageTreeNodePango.cpp. + * platform/graphics/pango/SimpleFontDataPango.cpp: Copied from WebCore/platform/graphics/gtk/SimpleFontDataPango.cpp. + * platform/graphics/win/FontPlatformData.h: Copied from WebCore/platform/graphics/win/FontPlatformDataCairoWin.h. + * platform/graphics/win/FontPlatformDataCairoWin.h: Removed. + +2010-11-11 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Yury Semikhatsky. + + Web Inspector: size of resources in summary is 0 + when there are redirects. + https://bugs.webkit.org/show_bug.cgi?id=49242 + + * inspector/front-end/NetworkPanel.js: + (WebInspector.NetworkPanel.prototype._updateSummaryBar): + +2010-11-11 Ben Murdoch <benm@google.com> + + Reviewed by Darin Fisher. + + document.createTouch and document.createTouchList should specify EnabledAtRuntime + https://bugs.webkit.org/show_bug.cgi?id=49324 + + The createTouch and createTouchList APIs added to Document.idl in + http://trac.webkit.org/changeset/70047 should have EnabledAtRuntime + specified as touch related features are controlled by a + RuntimeEnabledFeature flag in addition to a compile time guard. + + No new tests. This should have been part of r70047 and + that revision provided adequate tests of the new feature. + + * bindings/generic/RuntimeEnabledFeatures.h: + (WebCore::RuntimeEnabledFeatures::createTouchEnabled): + (WebCore::RuntimeEnabledFeatures::createTouchListEnabled): + * dom/Document.idl: Add EnabledAtRuntime specifier to the + idl methods. + +2010-11-09 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Yury Semikhatsky. + + Web Inspector: Provide context menu item 'Reveal in Elements Panel' + on elements in inspector UI. + https://bugs.webkit.org/show_bug.cgi?id=49161 + + * English.lproj/localizedStrings.js: + * inspector/front-end/ElementsTreeOutline.js: + (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired.focusElement): + (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired): + * inspector/front-end/ObjectPropertiesSection.js: + (WebInspector.ObjectPropertyTreeElement.prototype.update): + (WebInspector.ObjectPropertyTreeElement.prototype._contextMenuEventFired): + (WebInspector.ObjectPropertyTreeElement.prototype._contextMenuEventFired.revealElement): + +2010-11-11 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Yury Semikhatsky. + + Web Inspector: Audit panel toolbar icon shifts left when clicked. + https://bugs.webkit.org/show_bug.cgi?id=48766 + + * inspector/front-end/Images/auditsIcon.png: + +2010-11-11 Nikolas Zimmermann <nzimmermann@rim.com> + + Reviewed by Dirk Schulze. + + chrome.dll!WebCore::SVGLengthInternal::valueInSpecifiedUnitsAttrGetter ReadAV@NULL (4cf97a4f3ebe8006a2f5ffcc5bc10aeb) + https://bugs.webkit.org/show_bug.cgi?id=49331 + + Test: svg/dom/SVGPolygonElement-baseVal-list-removal-crash.html + + * svg/properties/SVGListProperty.h: + (WebCore::SVGListProperty::replaceItemValuesAndWrappers): Avoid premature deletion of 'oldItem'. + (WebCore::SVGListProperty::removeItemValuesAndWrappers): Ditto. + +2010-11-11 Kenneth Rohde Christiansen <kenneth@webkit.org> + + Reviewed by Andreas Kling. + + Make it possible to override the visibleContentRect in the case the + client is handling the scrolling. This is similar to what the iPhone does. + + * platform/ScrollView.cpp: + (WebCore::ScrollView::visibleContentRect): + * platform/ScrollView.h: + (WebCore::ScrollView::setActualVisibleContentRect): + +2010-11-11 Andreas Kling <kling@webkit.org> + + Reviewed by Kenneth Rohde Christiansen. + + FrameView: Don't clip to visibleContentRect in paintEntireContents mode + https://bugs.webkit.org/show_bug.cgi?id=49375 + + In paintEntireContents mode (used in combination with tiling) we + cannot clip to the actual visibleContentRect as the clipped regions + will not be updated again on scroll. If paintsEntireContents is + enabled, return the actual content rect. + + * page/FrameView.cpp: + (WebCore::FrameView::windowClipRect): + +2010-11-10 Nikolas Zimmermann <nzimmermann@rim.com> + + Reviewed by Dirk Schulze. + + Convert SVGMatrix/SVGTransform/SVGTransformList to the new SVGPropertyTearOff concept + https://bugs.webkit.org/show_bug.cgi?id=49311 + + Move the last list type, SVGTransformList, and the last POD types, SVGMatrix & SVGTransform, over to the new SVGPropertyTearOff concept. + Removes the need for a custom JSSVGMatrix/V8SVGMatrix implementation, it's all integrated within the bindings now. + + Tests: svg/W3C-SVG-1.1-SE/coords-dom-01-f.svg + svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg + svg/W3C-SVG-1.1-SE/coords-dom-03-f.svg + svg/W3C-SVG-1.1-SE/coords-dom-04-f.svg + svg/W3C-SVG-1.1-SE/types-dom-01-b.svg + svg/W3C-SVG-1.1-SE/types-dom-02-f.svg + svg/W3C-SVG-1.1-SE/types-dom-03-b.svg + svg/W3C-SVG-1.1-SE/types-dom-04-b.svg + svg/W3C-SVG-1.1-SE/types-dom-05-b.svg + svg/dom/SVGMatrix.html + svg/dom/SVGTransform.html + svg/dom/SVGTransformList.html + + * Android.jscbindings.mk: Removed JSSVGMatrixCustom.cpp. + * Android.v8bindings.mk: Removed V8SVGMatrixCustom.cpp. + * CMakeLists.txt: Remove JSSVGMatrixCustom.cpp. + * GNUmakefile.am: Ditto. Add SVGAnimatedTransformListPropertyTearOff.h/SVGStaticPropertyWithParentTearOff.h/SVGTransformListPropertyTearOff.h/SVGAnimatedTransformList.h/SVGMatrix.h to build. + * WebCore.gypi: Ditto. + * WebCore.pro: Ditto. + * WebCore.vcproj/WebCore.vcproj: Ditto. + * WebCore.xcodeproj/project.pbxproj: Ditto. + * bindings/js/JSBindingsAllInOne.cpp: Remove JSSVGMatrixCustom.cpp + * bindings/js/JSSVGMatrixCustom.cpp: Removed. + * bindings/scripts/CodeGenerator.pm: Convert SVGMatrix/SVGTransform/SVGTransformList to the new concept. + * bindings/scripts/CodeGeneratorJS.pm: Ditto. + * bindings/scripts/CodeGeneratorObjC.pm: Ditto. + * bindings/scripts/CodeGeneratorV8.pm: Ditto. + * bindings/v8/custom/V8SVGMatrixCustom.cpp: Removed. + * svg/DeprecatedSVGAnimatedPropertyTraits.h: Remove SVGTransformList handling. + * svg/DeprecatedSVGAnimatedTemplate.h: Ditto. + * svg/SVGAnimateTransformElement.cpp: Adapt to SVGTransformList API changes. + (WebCore::transformListFor): + (WebCore::SVGAnimateTransformElement::resetToBaseValue): + (WebCore::SVGAnimateTransformElement::calculateAnimatedValue): + (WebCore::SVGAnimateTransformElement::applyResultsToTarget): + * svg/SVGAnimatedTransformList.h: Added. + * svg/SVGGradientElement.cpp: Ditto. + (WebCore::SVGGradientElement::SVGGradientElement): + (WebCore::SVGGradientElement::parseMappedAttribute): + * svg/SVGGradientElement.h: Ditto. + * svg/SVGLinearGradientElement.cpp: Ditto. + (WebCore::SVGLinearGradientElement::collectGradientAttributes): + * svg/SVGMatrix.h: Added. SVGMatrix inherits from AffineTransform, and is only used in the bindings. It implements SVGs special requirements. + (WebCore::SVGMatrix::translate): Returns a copy of the matrix, not affecting the original matrix. + (WebCore::SVGMatrix::scale): Ditto. + (WebCore::SVGMatrix::scaleNonUniform): Ditto. + (WebCore::SVGMatrix::rotate): Ditto. + (WebCore::SVGMatrix::flipX): Ditto. + (WebCore::SVGMatrix::flipY): Ditto. + (WebCore::SVGMatrix::skewX): Ditto. + (WebCore::SVGMatrix::skewY): Ditto. + (WebCore::SVGMatrix::multiply): Ditto. + (WebCore::SVGMatrix::inverse): Ditto. + (WebCore::SVGMatrix::rotateFromVector): Dittto. + * svg/SVGMatrix.idl: Enable StrictTypeChecking/RequiresAllArguments=Raise on all attributes/functions. + * svg/SVGPatternElement.cpp: Adapt to SVGTransformList API changes. + (WebCore::SVGPatternElement::SVGPatternElement): + (WebCore::SVGPatternElement::parseMappedAttribute): + (WebCore::SVGPatternElement::collectPatternAttributes): + * svg/SVGPatternElement.h: Ditto. + * svg/SVGPoint.idl: Enable StrictTypeChecking/RequiresAllArguments=Raise for 'matrixTransform', now that SVGMatrix has been converted to the new scheme. + * svg/SVGRadialGradientElement.cpp: Adapt to SVGTransformList API changes. + (WebCore::SVGRadialGradientElement::collectGradientAttributes): + * svg/SVGSVGElement.cpp: Ditto. + (WebCore::SVGSVGElement::createSVGTransformFromMatrix): + (WebCore::SVGSVGElement::viewBoxToViewTransform): + * svg/SVGSVGElement.h: Ditto. + * svg/SVGStyledTransformableElement.cpp: Ditto. + (WebCore::SVGStyledTransformableElement::SVGStyledTransformableElement): + (WebCore::SVGStyledTransformableElement::animatedLocalTransform): + (WebCore::SVGStyledTransformableElement::parseMappedAttribute): + * svg/SVGStyledTransformableElement.h: Ditto. + * svg/SVGTextElement.cpp: Ditto. + (WebCore::SVGTextElement::SVGTextElement): + (WebCore::SVGTextElement::parseMappedAttribute): + (WebCore::SVGTextElement::animatedLocalTransform): + * svg/SVGTextElement.h: Ditto. + * svg/SVGTransform.cpp: Modernize code, inlined some getters. + (WebCore::SVGTransform::SVGTransform): + (WebCore::SVGTransform::setMatrix): + * svg/SVGTransform.h: Reindent header. + (WebCore::SVGTransform::type): + (WebCore::SVGTransform::svgMatrix): + (WebCore::SVGTransform::matrix): + (WebCore::SVGTransform::angle): + (WebCore::SVGTransform::rotationCenter): + (WebCore::SVGTransform::isValid): + (WebCore::operator==): Avoid function calls, make operator== a friend of SVGTransform, and compare members directly. + (WebCore::operator!=): + * svg/SVGTransform.idl: + * svg/SVGTransformList.cpp: Rewritten as plain Vector<SVGTransform>. + (WebCore::SVGTransformList::createSVGTransformFromMatrix): + (WebCore::SVGTransformList::consolidate): + (WebCore::SVGTransformList::concatenate): + (WebCore::SVGTransformList::valueAsString): + * svg/SVGTransformList.h: + (WebCore::SVGTransformList::SVGTransformList): + * svg/SVGTransformList.idl: Enable StrictTypeChecking/RequiresAllArguments=Raise on all attributes/functions. + * svg/SVGTransformable.cpp: Adapt to SVGTransformList API changes. + (WebCore::SVGTransformable::parseTransformAttribute): + * svg/SVGTransformable.h: Ditto. + * svg/SVGViewSpec.cpp: Ditto. + (WebCore::SVGViewSpec::SVGViewSpec): + (WebCore::SVGViewSpec::setTransform): + (WebCore::SVGViewSpec::parseViewSpec): + * svg/SVGViewSpec.h: Ditto. + (WebCore::SVGViewSpec::transform): + * svg/properties/SVGAnimatedListPropertyTearOff.h: Made constructor and members protected. + * svg/properties/SVGAnimatedPropertyMacros.h: Add new helper macro DECLARE_ANIMATED_TRANSFORM_LIST_PROPERTY. This is needed until we expand all macros. + * svg/properties/SVGAnimatedTransformListPropertyTearOff.h: Added. Extends SVGAnimatedListPropertyTearOff, returning SVGTransformListPropertyTearOff objects. + (WebCore::SVGAnimatedTransformListPropertyTearOff::baseVal): + (WebCore::SVGAnimatedTransformListPropertyTearOff::animVal): + (WebCore::SVGAnimatedTransformListPropertyTearOff::create): + (WebCore::SVGAnimatedTransformListPropertyTearOff::SVGAnimatedTransformListPropertyTearOff): + * svg/properties/SVGListPropertyTearOff.h: Made construct and members protected. + * svg/properties/SVGProperty.h: Declare commitChange() as pure virtual method. + * svg/properties/SVGPropertyTraits.h: Handle SVGTransformList. + * svg/properties/SVGStaticPropertyWithParentTearOff.h: Added. Same concept as JSSVGStaticPODTypeWrapperWithParent, used to expose SVGPropertyTearOffs for types + that are using this concept themselves. (SVGMatrix attribute of SVGTransform, both are POD types, using SVGPropertyTearOff). + (WebCore::SVGStaticPropertyWithParentTearOff::create): + (WebCore::SVGStaticPropertyWithParentTearOff::commitChange): + (WebCore::SVGStaticPropertyWithParentTearOff::SVGStaticPropertyWithParentTearOff): + * svg/properties/SVGTransformListPropertyTearOff.h: Added. Extends SVGListPropertyTearOff by two special SVGTransformList methods: consolidate and createSVGTransformFromMatrix. + (WebCore::SVGTransformListPropertyTearOff::create): + (WebCore::SVGTransformListPropertyTearOff::createSVGTransformFromMatrix): + (WebCore::SVGTransformListPropertyTearOff::consolidate): + (WebCore::SVGTransformListPropertyTearOff::SVGTransformListPropertyTearOff): + +2010-11-11 Alejandro G. Castro <alex@igalia.com> + + Reviewed by Nikolas Zimmermann. + + Fixed WebKitGTK gtk3 compilation. + + * platform/gtk/WidgetRenderingContextGtk3.cpp: + (WebCore::WidgetRenderingContext::WidgetRenderingContext): + +2010-11-11 Dan Bernstein <mitz@apple.com> + + Reverted r71975:71976. That change was wrong, and the tests caught it. + + * platform/graphics/mac/ComplexTextController.h: + (WebCore::ComplexTextController::ComplexTextRun::create): + * platform/graphics/mac/ComplexTextControllerCoreText.cpp: + (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): + (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): + +2010-11-11 Matthew Delaney <mdelaney@apple.com> + + Reviewed by Dan Bernstein. + + Fix LayoutTests/canvas/philip/tests/2d.drawImage.null.html + https://bugs.webkit.org/show_bug.cgi?id=48307 + + There are no new tests because this is a fix for a pre-existing failing test.) + + * bindings/js/JSCanvasRenderingContext2DCustom.cpp: Corrected expection throwing cases to match up with spec. + +2010-11-10 Ryosuke Niwa <rniwa@webkit.org> + + Reviewed by Adam Barth. + + [HTML5] 10.2.8.4 Scripts that modify the page as it is being parsed + https://bugs.webkit.org/show_bug.cgi?id=49364 + + Fixed HTMLScriptRunner's executeScript to use the ScriptController of the frame to which script element belongs + as supposed to that of the frame associated with the HTMLScriptRunner. + + See also: http://www.whatwg.org/specs/web-apps/current-work/#scripts-that-modify-the-page-as-it-is-being-parsed + + Test: fast/parser/script-modify-page-outer.html + + * html/parser/HTMLScriptRunner.cpp: + (WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent): Calls executeScript. + (WebCore::HTMLScriptRunner::executeScript): Uses the correct ScriptController instance. + (WebCore::HTMLScriptRunner::runScript): Call executeScript. + * html/parser/HTMLScriptRunner.h: + +2010-11-10 Dan Bernstein <mitz@apple.com> + + Style fix I said I’d make then forgot to make. + + * platform/graphics/mac/ComplexTextControllerCoreText.cpp: + (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): + +2010-11-10 Ned Holbrook <nholbrook@apple.com> + + Reviewed by Dan Bernstein. + + Allow for the possibility of CoreText generating multiple runs for a single text run. + https://bugs.webkit.org/show_bug.cgi?id=49353 + + * platform/graphics/mac/ComplexTextController.h: + (WebCore::ComplexTextController::ComplexTextRun::create): + * platform/graphics/mac/ComplexTextControllerCoreText.cpp: + (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): + (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): + +2010-10-15 Martin Robinson <mrobinson@igalia.com> + + Reviewed by Xan Lopez. + + [GTK] Widgets do not support CSS transformations + https://bugs.webkit.org/show_bug.cgi?id=40139 + + Instead of rendering directly onto the target drawable when rendering + form controls on GTK+ 2.0, render onto an intermediate surface and use + cairo to blit the result back to the target surface. This has two + benefits. The first is that it always honors the current Cairo + transformation. The second is that since the intermediate drawable is + always a 32-bit GdkPixmap, we do not have to have a set of widgets + per-colormap any longer. + + This change also begins the abstraction of widget rendering so that GTK+ + 2 and GTK+ 3 can use the same code path. The WidgetRenderingContext will + eventually hide all version differences from RenderThemeGtk, which can + just focus on interpreting the GtkStyle properties. + + * GNUmakefile.am: Add WidgetRenderinContext source files to the sources list. + * platform/graphics/cairo/PlatformRefPtrCairo.cpp: + (WTF::refPlatformPtr): Add a specialization for Cairo patterns. + (WTF::derefPlatformPtr): Ditto. + * platform/graphics/cairo/PlatformRefPtrCairo.h: Ditto. + * platform/gtk/RenderThemeGtk.cpp: + (WebCore::RenderThemeGtk::RenderThemeGtk): No longer keep a set of + widgets per-colormap for GTK+, instead just determine if we can use RGBA + colormaps and go from there. + (WebCore::RenderThemeGtk::~RenderThemeGtk): Ditto. + (WebCore::RenderThemeGtk::getIndicatorMetrics): Put the logic for + getting toggle button indicator metrics into this helper. + (WebCore::RenderThemeGtk::paintRenderObject): Now uses + WidgetRenderingContext to do widget rendering. + (WebCore::setToggleSize): Use the new getIndicatorMetrics helper. + * platform/gtk/RenderThemeGtk.h: Added a member to track whether or not + the widgets are using a RGBA colormap. Also remove a defunct Page* + member. + * platform/gtk/ScrollbarThemeGtk.cpp: Switch all widget drawing + operations to use WidgetRenderingContext. + (WebCore::ScrollbarThemeGtk::paintTrackBackground): Ditto. + (WebCore::ScrollbarThemeGtk::paintScrollbarBackground): Ditto. + (WebCore::ScrollbarThemeGtk::paintThumb): Ditto. + (WebCore::ScrollbarThemeGtk::paint): Ditto. + (WebCore::ScrollbarThemeGtk::paintButton): Ditto. + * platform/gtk/WidgetRenderingContext.h: Added. + * platform/gtk/WidgetRenderingContextGtk2.cpp: Added. + (WebCore::purgeScratchBuffer): Added, this is similar to the scratch + buffer implementation from ContextShadow. + (WebCore::PurgeScratchBufferTimer::fired): Ditto. + (WebCore::scheduleScratchBufferPurge): Ditto. + (WebCore::getExtraSpaceForWidget): + (WebCore::WidgetRenderingContext::WidgetRenderingContext): Added. + (WebCore::WidgetRenderingContext::~WidgetRenderingContext): Added. + (WebCore::WidgetRenderingContext::paintMozillaWidget): Added. + * platform/gtk/WidgetRenderingContextGtk3.cpp: Added. + (WebCore::WidgetRenderingContext::WidgetRenderingContext): Added. + (WebCore::~WidgetRenderingContext::WidgetRenderingContext): Added. + (WebCore::WidgetRenderingContext::paintMozillaWidget): Added. + +2010-11-10 Beth Dakin <bdakin@apple.com> + + Reviewed by Simon Fraser. + + Fix for https://bugs.webkit.org/show_bug.cgi?id=49356 + -[WebView _scaleWebView:] should take and origin and scroll the + document + -and corresponding- + <rdar://problem/8643921> + + Apply the scale to the origin, and set a new scroll position. + * page/Frame.cpp: + (WebCore::Frame::scalePage): + * page/Frame.h: + * WebCore.exp.in: + +2010-11-10 Dan Bernstein <mitz@apple.com> + + Reviewed by Darin Adler. + + REGRESSION (r71566): r71566 breaks bidi-control-chars-treated-as-ZWS.html + https://bugs.webkit.org/show_bug.cgi?id=49295 + + * platform/graphics/mac/ComplexTextControllerATSUI.cpp: Reverted to r71565. Eliding bidi + control characters from ATSUI is no longer necessary since ComplexTextController removes + any glyphs corresponding to them. + (WebCore::ComplexTextController::ComplexTextRun::overrideLayoutOperation): + (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): + +2010-11-10 Pascal Massimino <pascal.massimino@gmail.com> + + Reviewed by Adam Barth. + + Simplify the alpha-detection code in png's decoding loop. + https://bugs.webkit.org/show_bug.cgi?id=49333 + + Added a special test for this case: png_per_row_alpha_decoding.html + + * platform/image-decoders/png/PNGImageDecoder.cpp: + (WebCore::PNGImageDecoder::rowAvailable): modified loop. + +2010-11-10 Dan Bernstein <mitz@apple.com> + + Reviewed by Simon Fraser. + + <rdar://problem/8647848> REGRESSION (r68551): Spaces shown at soft hyphens with complex justification + https://bugs.webkit.org/show_bug.cgi?id=49352 + + Test: fast/text/justification-padding-mid-word.html + + * platform/graphics/mac/ComplexTextController.cpp: + (WebCore::ComplexTextController::adjustGlyphsAndAdvances): Changed to add justification padding + and word spacing only at characters that are treated as space, instead of all characters that + use the space glyph (which includes characters treated as zero-width space as well). + +2010-11-10 Matthew Delaney <mdelaney@apple.com> + + Reviewed by Darin Adler. + + Crash in documentWillBecomeInactive() when closing window with Reader showing content with SVG + https://bugs.webkit.org/show_bug.cgi?id=49084 + + Manual test added. + + * manual-tests/svg-deep-clone-to-new-doc.html: Added manual test for reproducing bug since an automated version proved to be a bit tough to craft up. + * svg/SVGSVGElement.cpp: Added in necessary document ownership transfer calls. + * svg/SVGSVGElement.h: + +2010-11-10 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Yury Semikhatsky. + + Web Inspector: Red error bubbles don't fit content. + https://bugs.webkit.org/show_bug.cgi?id=49305 + + * inspector/front-end/textViewer.css: + (.webkit-html-message-bubble): + +2010-11-10 Alexey Proskuryakov <ap@apple.com> + + Release build fix. + + * css/StyleSheet.cpp: isAcceptableStyleSheetParent() is a debug-only function. + +2010-11-08 Alexey Proskuryakov <ap@apple.com> + + Reviewed by Darin Adler. + + https://bugs.webkit.org/show_bug.cgi?id=45205 + <rdar://problem/8391455> Detached elements shouldn't have style sheets. + + Tests: fast/dom/StyleSheet/detached-style-2.html + fast/dom/StyleSheet/detached-style-pi.xhtml + fast/dom/StyleSheet/detached-style.html + fast/dom/StyleSheet/detached-style-pi-2.xhtml + + * bindings/js/JSStyleSheetCustom.cpp: (WebCore::JSStyleSheet::markChildren): + There is no longer a need to mark owner nodes - StyleSheet->ownerNode() is only non-null when + the node is in document. + + * css/StyleSheet.cpp: (WebCore::StyleSheet::StyleSheet): Added an assertion checking that + all nodes that can be StyleSheet parents have been verified. + + * css/StyleSheet.h: (WebCore::StyleSheet::clearOwnerNode): Added. + + * dom/ProcessingInstruction.cpp: + (WebCore::ProcessingInstruction::~ProcessingInstruction): Clear stylesheet's owner node. This + shouldn't have observable effect, since a processing instruction that is in document can only + be destroyed with document, and a reachable stylsheet keeps document alive. + (WebCore::ProcessingInstruction::removedFromDocument): Clear the relationship between node and style sheet when removed. + (WebCore::ProcessingInstruction::setCSSStyleSheet): If the element was removed during load, we still + don't want to create a style sheet. + + * dom/StyleElement.cpp: + (WebCore::StyleElement::sheet): There is no reason for lazy creation. It was a wrong fix for + bug 14462, whose regression test still passes. + (WebCore::StyleElement::removedFromDocument): Clear the relationship between node and style sheet when removed. + (WebCore::StyleElement::finishParsingChildren): Don't call sheet(), it doens't have side effects any more. + (WebCore::StyleElement::createSheet): Assert that the element is in document. We never want + to create a style sheet for an element that isn't. + + * dom/StyleElement.h: (WebCore::StyleElement::sheet): Made implementation inline, now that + it's a simple getter. + + * html/HTMLLinkElement.cpp: + (WebCore::HTMLLinkElement::~HTMLLinkElement): Clear stylesheet's owner node. + (WebCore::HTMLLinkElement::process): Assert that there is no style sheet lingering for any reason. + (WebCore::HTMLLinkElement::removedFromDocument): Clear the relationship between node and style sheet when removed. + (WebCore::HTMLLinkElement::setCSSStyleSheet): If the element was removed during load, we still + don't want to create a style sheet. + + * html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::~HTMLStyleElement): + * html/HTMLStyleElement.h: + * svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::~SVGStyleElement): + * svg/SVGStyleElement.h: + Clear stylesheet's owner node. As above, this shouldn't have observable effect. + + * xml/XSLTProcessor.h: + * xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::~XSLTProcessor): + * dom/Document.cpp: (WebCore::Document::~Document): + * css/CSSParser.cpp: (WebCore::CSSParser::parseSelector): + Assert that stylesheet won't outlive its owner node. We don't really use refcounting here. + +2010-11-10 Dan Bernstein <mitz@apple.com> + + Reviewed by Dave Hyatt. + + REGRESSION (r71566): r71566 breaks bidi-control-chars-treated-as-ZWS.html + https://bugs.webkit.org/show_bug.cgi?id=49295 + + * platform/graphics/mac/ComplexTextController.h: Added m_indexOffset. + * platform/graphics/mac/ComplexTextControllerATSUI.cpp: + (WebCore::ComplexTextController::ComplexTextRun::overrideLayoutOperation): Use m_indexOffset + instead of computing the offset based on m_directionalOverride. + (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Set m_indexOffset to + the offset between indices in m_characters and indices in the text passed to ATSUI. + +2010-11-10 Pavel Feldman <pfeldman@chromium.org> + + Reviewed by Yury Semikhatsky. + + Web Inspector: Gear menu floats to right edge and expands + to bottom of "Styles" section. + https://bugs.webkit.org/show_bug.cgi?id=49303 + + This fixes computed style's option wrapping to the next line. + + * inspector/front-end/inspector.css: + (.sidebar-pane-subtitle): + +2010-11-10 Stephen White <senorblanco@chromium.org> + + Reviewed by James Robinson. + + Fix canvas.putImageData(canvas.getImageData(...)) to be lossless. + https://bugs.webkit.org/show_bug.cgi?id=49330 + + These cycles should be lossless for valid colours. A similar fix went + into the CG port at r32878. + + Covered by canvas/philip/tests/2d.imageData.put.unchanged.html. + + * platform/graphics/skia/ImageBufferSkia.cpp: + (WebCore::mulDiv255Ceil): + A helper function to do (a + b + 254) / 255 without a divide. + (WebCore::putImageData): + Use the above helper to round up when premultiplying alpha. + +2010-11-10 Csaba Osztrogonác <ossy@webkit.org> + + Reviewed by David Hyatt. + + HTML5 Ruby support should be mandatory feature + https://bugs.webkit.org/show_bug.cgi?id=49272 + + Remove Ruby as optional feature. + + * Configurations/FeatureDefines.xcconfig: + * DerivedSources.make: + * GNUmakefile.am: + * WebCorePrefix.h: Touch WebCorePrefix.h to avoid incremental build failure on Windows. + * config.h: Touch config.h to avoid incremental build failure on Windows. + * features.pri: + * html/HTMLTagNames.in: + * rendering/RenderBlock.cpp: Remove ENABLE_RUBY guard. + (WebCore::canMergeContiguousAnonymousBlocks): + * rendering/RenderObject.cpp: Remove ENABLE_RUBY guard. + (WebCore::RenderObject::createObject): + * rendering/RenderRuby.cpp: Remove ENABLE_RUBY guard. + * rendering/RenderRuby.h: Remove ENABLE_RUBY guard. + * rendering/RenderRubyBase.cpp: Remove ENABLE_RUBY guard. + * rendering/RenderRubyBase.h: Remove ENABLE_RUBY guard. + * rendering/RenderRubyRun.cpp: Remove ENABLE_RUBY guard. + * rendering/RenderRubyRun.h: Remove ENABLE_RUBY guard. + * rendering/RenderRubyText.cpp: Remove ENABLE_RUBY guard. + * rendering/RenderRubyText.h: Remove ENABLE_RUBY guard. + +2010-11-10 Martin Robinson <mrobinson@igalia.com> + + Reviewed by Xan Lopez. + + [GTK] Complex text does not have full CSS text-shadow support + https://bugs.webkit.org/show_bug.cgi?id=45597 + + Add ContextShadow support to FontGtk, which enables non-solid shadows + for complex text rendering. + + Test: platform/gtk/fonts/complex-text-shadows.html + + * platform/graphics/gtk/FontGtk.cpp: + (WebCore::destroyPangoRegion): Added this helper, which helps reduce + the number of #ifdefs when dealing with GTK+ region type differences. + (WebCore::getPangoRegionExtents): Ditto. + (WebCore::drawGlyphsShadow): Added this helper which either renders + a solid shadow manually or uses ContextShadow to render a blurry shadow. + (WebCore::Font::drawComplexText): Use the new helpers. + +2010-11-10 Alejandro G. Castro <alex@igalia.com> + + Reviewed by Martin Robinson. + + [gtk] The revision r71528 causes crashes in GObjectEventListener + https://bugs.webkit.org/show_bug.cgi?id=49314 + + Moved the addition of the event listener to the node after calling + the constructor of the event listener. This is required beacuse + the addEventListener API receives the EventListener inside a + PassRefPtr. + + * bindings/gobject/GObjectEventListener.cpp: + (WebCore::GObjectEventListener::GObjectEventListener): + * bindings/gobject/GObjectEventListener.h: + (WebCore::GObjectEventListener::addEventListener): + +2010-11-02 Alexander Pavlov <apavlov@chromium.org> + + Reviewed by Pavel Feldman. + + Web Inspector: Enable InspectorCSSAgent (not used by frontend for CSS editing yet) + https://bugs.webkit.org/show_bug.cgi?id=48834 + + Drive-by fix: use a single API method to retrieve all node-related styles instead of a bunch of separate calls. + + Test: inspector/styles-new-API.html + + * inspector/CodeGeneratorInspector.pm: + * inspector/Inspector.idl: + * inspector/InspectorCSSAgent.cpp: + (WebCore::InspectorCSSAgent::InspectorCSSAgent): + (WebCore::InspectorCSSAgent::setDOMAgent): + (WebCore::InspectorCSSAgent::reset): + (WebCore::InspectorCSSAgent::getStylesForNode2): + (WebCore::InspectorCSSAgent::getComputedStyleForNode2): + (WebCore::InspectorCSSAgent::addRule2): + (WebCore::InspectorCSSAgent::querySelectorAll): + * inspector/InspectorCSSAgent.h: + * inspector/InspectorController.cpp: + (WebCore::InspectorController::InspectorController): + (WebCore::InspectorController::connectFrontend): + (WebCore::InspectorController::releaseFrontendLifetimeAgents): + (WebCore::InspectorController::didCommitLoad): + * inspector/InspectorController.h: + (WebCore::InspectorController::cssAgent): + * inspector/InspectorDOMAgent.cpp: + * inspector/InspectorDOMAgent.h: + * inspector/InspectorStyleSheet.cpp: + (WebCore::InspectorStyle::setPropertyText): + (WebCore::InspectorStyle::styleText): + (WebCore::InspectorStyle::disableProperty): + (WebCore::InspectorStyle::populateAllProperties): + (WebCore::InspectorStyle::populateObjectWithStyleProperties): + (WebCore::InspectorStyleSheet::buildObjectForRule): + (WebCore::InspectorStyleSheet::fixUnparsedPropertyRanges): + (WebCore::InspectorStyleSheet::ensureSourceData): + (WebCore::InspectorStyleSheetForInlineStyle::text): + * inspector/InspectorStyleSheet.h: + (WebCore::InspectorStyleProperty::setRawTextFromStyleDeclaration): + (WebCore::InspectorStyleProperty::hasRawText): + +2010-11-10 Alexander Pavlov <apavlov@chromium.org> + + Reviewed by Yury Semikhatsky. + + Web Inspector: Move CSSStyleDeclaration from DOMAgent.js into CSSStyleModel.js + https://bugs.webkit.org/show_bug.cgi?id=49312 + + No new tests, as it's just code motion. + + * inspector/front-end/CSSStyleModel.js: + (WebInspector.CSSStyleDeclaration): + (WebInspector.CSSStyleDeclaration.parsePayload): + (WebInspector.CSSStyleDeclaration.prototype.get allProperties): + (WebInspector.CSSStyleDeclaration.prototype.getLiveProperty): + (WebInspector.CSSStyleDeclaration.prototype.getPropertyValue): + (WebInspector.CSSStyleDeclaration.prototype.getPropertyPriority): + (WebInspector.CSSStyleDeclaration.prototype.getPropertyShorthand): + (WebInspector.CSSStyleDeclaration.prototype.isPropertyImplicit): + (WebInspector.CSSStyleDeclaration.prototype.styleTextWithShorthands): + (WebInspector.CSSStyleDeclaration.prototype.getLonghandProperties): + (WebInspector.CSSStyleDeclaration.prototype.getShorthandValue): + (WebInspector.CSSStyleDeclaration.prototype.getShorthandPriority): + (WebInspector.CSSStyleDeclaration.prototype.appendProperty): + (WebInspector.CSSStyleDeclaration.prototype.propertyAt): + (WebInspector.CSSRule): + (WebInspector.CSSRule.parsePayload): + (WebInspector.CSSRule.prototype.get isUserAgent): + (WebInspector.CSSRule.prototype.get isUser): + (WebInspector.CSSRule.prototype.get isViaInspector): + (WebInspector.CSSRule.prototype.get isRegular): + (WebInspector.CSSProperty): + (WebInspector.CSSProperty.parsePayload): + (WebInspector.CSSProperty.prototype.get propertyText): + (WebInspector.CSSProperty.prototype.get isLive): + (WebInspector.CSSProperty.prototype.get active): + (WebInspector.CSSProperty.prototype.get styleBased): + (WebInspector.CSSProperty.prototype.get inactive): + (WebInspector.CSSProperty.prototype.get disabled): + (WebInspector.CSSProperty.prototype.setText): + (WebInspector.CSSProperty.prototype.setValue): + (WebInspector.CSSProperty.prototype.setDisabled.callback): + (WebInspector.CSSProperty.prototype.setDisabled): + * inspector/front-end/DOMAgent.js: + +2010-11-10 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r71733. + http://trac.webkit.org/changeset/71733 + https://bugs.webkit.org/show_bug.cgi?id=49319 + + made qt bot crashy and sad (Requested by kling on #webkit). + + * page/FrameView.cpp: + (WebCore::FrameView::windowClipRect): + +2010-11-10 Peter Rybin <peter.rybin@gmail.com> + + Reviewed by Adam Barth. + + HTML parser should provide script column position within HTML document to JavaScript engine + https://bugs.webkit.org/show_bug.cgi?id=45271 + + Replaces line number with TextPosition struct so that script engine + gets script starting line/column. + + * ForwardingHeaders/wtf/text/TextPosition.h: Added. + * bindings/js/ScriptSourceCode.h: + (WebCore::ScriptSourceCode::ScriptSourceCode): + * bindings/v8/ScheduledAction.cpp: + (WebCore::ScheduledAction::ScheduledAction): + * bindings/v8/ScriptController.cpp: + (WebCore::ScriptController::eventHandlerPosition): + * bindings/v8/ScriptController.h: + * bindings/v8/ScriptEventListener.cpp: + (WebCore::createAttributeEventListener): + * bindings/v8/ScriptSourceCode.h: + (WebCore::ScriptSourceCode::ScriptSourceCode): + (WebCore::ScriptSourceCode::startLine): + (WebCore::ScriptSourceCode::startPosition): + * bindings/v8/V8LazyEventListener.cpp: + (WebCore::V8LazyEventListener::V8LazyEventListener): + (WebCore::V8LazyEventListener::prepareListenerObject): + * bindings/v8/V8LazyEventListener.h: + (WebCore::V8LazyEventListener::create): + * bindings/v8/V8Proxy.cpp: + (WebCore::V8Proxy::compileScript): + (WebCore::V8Proxy::evaluate): + (WebCore::V8Proxy::runScript): + * bindings/v8/V8Proxy.h: + * bindings/v8/WorkerContextExecutionProxy.cpp: + (WebCore::WorkerContextExecutionProxy::evaluate): + (WebCore::WorkerContextExecutionProxy::runScript): + * bindings/v8/WorkerContextExecutionProxy.h: + * bindings/v8/WorkerScriptController.cpp: + (WebCore::WorkerScriptController::evaluate): + * dom/PendingScript.cpp: + (WebCore::PendingScript::releaseElementAndClear): + * dom/PendingScript.h: + (WebCore::PendingScript::PendingScript): + (WebCore::PendingScript::operator=): + (WebCore::PendingScript::startingPosition): + * dom/ScriptableDocumentParser.h: + * dom/XMLDocumentParser.h: + * dom/XMLDocumentParserLibxml2.cpp: + (WebCore::XMLDocumentParser::XMLDocumentParser): + (WebCore::XMLDocumentParser::startElementNs): + (WebCore::XMLDocumentParser::endElementNs): + (WebCore::XMLDocumentParser::lineNumber): + (WebCore::XMLDocumentParser::columnNumber): + (WebCore::XMLDocumentParser::textPosition): + (WebCore::XMLDocumentParser::textPositionOneBased): + * dom/XMLDocumentParserQt.cpp: + (WebCore::XMLDocumentParser::XMLDocumentParser): + (WebCore::XMLDocumentParser::textPosition): + (WebCore::XMLDocumentParser::parseStartElement): + (WebCore::XMLDocumentParser::parseEndElement): + * html/parser/HTMLDocumentParser.cpp: + (WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder): + (WebCore::HTMLDocumentParser::textPosition): + * html/parser/HTMLDocumentParser.h: + * html/parser/HTMLScriptRunner.cpp: + (WebCore::HTMLScriptRunner::sourceFromPendingScript): + (WebCore::HTMLScriptRunner::execute): + (WebCore::HTMLScriptRunner::runScript): + * html/parser/HTMLScriptRunner.h: + * html/parser/HTMLTreeBuilder.cpp: + (WebCore::uninitializedPositionValue1): + (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): + (WebCore::HTMLTreeBuilder::takeScriptToProcess): + (WebCore::HTMLTreeBuilder::processEndTag): + (WebCore::HTMLTreeBuilder::processScriptStartTag): + * html/parser/HTMLTreeBuilder.h: + +2010-11-10 Ilya Sherman <isherman@chromium.org> + + Reviewed by Shinichiro Hamaji. + + Fix autofill popup height computation -- take icon heights into account. + https://bugs.webkit.org/show_bug.cgi?id=49306 + + * platform/chromium/PopupMenuChromium.cpp: + (WebCore::PopupListBox::layout): + +2010-11-10 Kenneth Rohde Christiansen <kenneth@webkit.org> + + Reviewed by Andreas Kling. + + In paintEntireContents mode (used in combination with tiling) we + cannot clip to the actual visibleContentRect as the clipped regions + will not be updated again on scroll. If paintsEntireContents is + enabled, return the actual content rect. + + * page/FrameView.cpp: + (WebCore::FrameView::windowClipRect): + +2010-11-10 Shinichiro Hamaji <hamaji@chromium.org> + + Adding a manual test which I forgot to add in r71618. + + [Chromium] display:none has no effect on <option> element + https://bugs.webkit.org/show_bug.cgi?id=49169 + + * manual-tests/display-none-option.html: Added. + +2010-11-10 Shane Stephens <shanestephens@google.com> + + Reviewed by Dirk Schulze. + + SVGTextElement supplemental transforms pre-multiplied but should be + post-multiplied in animatedLocalTransform + https://bugs.webkit.org/show_bug.cgi?id=48215 + + Test: svg/animations/animate-text-nested-transforms.svg + + * svg/SVGTextElement.cpp: + (WebCore::SVGTextElement::animatedLocalTransform): + + Switched order of multiplication. Note that due to a bug in + AffineTransform's operator* implementation the order of arguments is + reversed (see http://bugs.webkit.org/show_bug.cgi?id=48031). + +2010-11-09 Abhishek Arya <inferno@chromium.org> + + Reviewed by Dan Bernstein. + + Fieldsets avoid floats. Legend elements are expected to have their parent + as fieldset. When this not the case, floats get added incorrectly added to the + legend blocks. This patch tries to prevent those floats addition. + https://bugs.webkit.org/show_bug.cgi?id=49214 + + Test: fast/blockflow/overhanging-float-legend-crash.html + + * rendering/RenderBox.cpp: + (WebCore::RenderBox::avoidsFloats): + * rendering/RenderObject.cpp: + (WebCore::RenderObject::isLegend): + * rendering/RenderObject.h: + +2010-11-10 Cris Neckar <cdn@chromium.org> + + Reviewed by Nikolas Zimmermann. + + Added check to ensure that svg viewport containers are not treated in the same way as generic svg containers. + https://bugs.webkit.org/show_bug.cgi?id=49188 + + Test: svg/dom/viewport-container-crash.svg + + * rendering/SVGImageBufferTools.cpp: + (WebCore::SVGImageBufferTools::renderSubtreeToImageBuffer): + +2010-11-09 Gyuyoung Kim <gyuyoung.kim@samsung.com> + + Reviewed by Eric Seidel. + + [WML] Fix build breaks when WML is enabled. + https://bugs.webkit.org/show_bug.cgi?id=49168 + + The backForward() of Page class returns BackForwarddController class type. + So, WML classes need to include the BackForwardController.h file. And, select() + of RenderTextControl.h was removed. Thus, the select() should be replaced by + setSelectionRange(). + + * wml/WMLDoElement.cpp: Includes BackForwardController.h. + * wml/WMLDocument.cpp: ditto. + * wml/WMLInputElement.cpp: + (WebCore::WMLInputElement::select): Replaced by setSelectionRange(). + * wml/WMLPageState.cpp: Includes BackForwardController.h. + * wml/WMLPrevElement.cpp: ditto. + +2010-11-09 Chris Rogers <crogers@google.com> + + Reviewed by Kenneth Russell. + + Add JavaScriptAudioNode files + https://bugs.webkit.org/show_bug.cgi?id=48875 + + No new tests since audio API is not yet implemented. + + * webaudio/JavaScriptAudioNode.cpp: Added. + (WebCore::JavaScriptAudioNode::create): + (WebCore::JavaScriptAudioNode::JavaScriptAudioNode): + (WebCore::JavaScriptAudioNode::~JavaScriptAudioNode): + (WebCore::JavaScriptAudioNode::initialize): + (WebCore::JavaScriptAudioNode::uninitialize): + (WebCore::JavaScriptAudioNode::toJavaScriptAudioNode): + (WebCore::JavaScriptAudioNode::process): + (WebCore::JavaScriptAudioNode::fireProcessEventDispatch): + (WebCore::JavaScriptAudioNode::fireProcessEvent): + (WebCore::JavaScriptAudioNode::reset): + (WebCore::JavaScriptAudioNode::scriptExecutionContext): + * webaudio/JavaScriptAudioNode.h: Added. + (WebCore::JavaScriptAudioNode::eventTargetData): + (WebCore::JavaScriptAudioNode::ensureEventTargetData): + (WebCore::JavaScriptAudioNode::bufferSize): + (WebCore::JavaScriptAudioNode::doubleBufferIndex): + (WebCore::JavaScriptAudioNode::swapBuffers): + (WebCore::JavaScriptAudioNode::refEventTarget): + (WebCore::JavaScriptAudioNode::derefEventTarget): + * webaudio/JavaScriptAudioNode.idl: Added. + +2010-11-09 Nico Weber <thakis@chromium.org> + + Reviewed by Kenneth Russell. + + [Chromium] Text jitter during 2D CSS transform + https://bugs.webkit.org/show_bug.cgi?id=49224 + + Text subpixel rendering only works in AlphaPremultipliedFirst | + kCGBitmapByteOrder32Host contexts: + http://www.cocoabuilder.com/archive/cocoa/228931-sub-pixel-font-smoothing-with-cgbitmapcontext.html + + Changing this has the added benefit that the data layout now matches + skia. + + * platform/graphics/chromium/ContentLayerChromium.cpp: + (WebCore::ContentLayerChromium::SharedValues::SharedValues): + (WebCore::ContentLayerChromium::updateContents): + * platform/graphics/chromium/ImageLayerChromium.cpp: + (WebCore::ImageLayerChromium::updateContents): + * platform/graphics/chromium/LayerRendererChromium.cpp: + (WebCore::LayerRendererChromium::setRootLayerCanvasSize): + +2010-11-09 Helder Correia <helder@sencha.com> + + Reviewed by Darin Adler. + + Philip Canvas test 2d.path.rect.winding fails + https://bugs.webkit.org/show_bug.cgi?id=49225 + + Rect path direction is important for nonzero winding rule. + + The rect(x, y, w, h) method must create a new subpath containing just the four points + (x, y), (x+w, y), (x+w, y+h), (x, y+h), with those four points connected by straight + lines, and must then mark the subpath as closed. + + * html/canvas/CanvasRenderingContext2D.cpp: + (WebCore::CanvasRenderingContext2D::rect): + +2010-11-09 Fumitoshi Ukai <ukai@chromium.org> + + Unreviewed build fix on Chromium/Win at r71711 + + RefCound.h reported an error that it cannot access private member + declared in class 'WebCore::FileWriterSync' at + WebCore::FileWriterSync::~FileWriterSync. + + * fileapi/FileWriterSync.h: make destructor public + +2010-11-09 Chris Rogers <crogers@google.com> + + Reviewed by James Robinson. + + AudioFileReaderMac.cpp must include <CoreServices/CoreServices.h> + https://bugs.webkit.org/show_bug.cgi?id=49270 + + * platform/audio/mac/AudioFileReaderMac.cpp: + +2010-11-09 Eric Uhrhane <ericu@chromium.org> + + Reviewed by David Levin. + + Add idl and mock classes for FileWriterSync. + https://bugs.webkit.org/show_bug.cgi?id=48693 + + No new tests, as there's no functionality. + + Build file additions. + * CMakeLists.txt: + * DerivedSources.cpp: + * DerivedSources.make: + * GNUmakefile.am: + * WebCore.gypi: + * WebCore.pro: + * WebCore.vcproj/WebCore.vcproj: + * WebCore.xcodeproj/project.pbxproj: + * bindings/scripts/CodeGeneratorV8.pm: + + * fileapi/FileWriterSync.cpp: Added. + * fileapi/FileWriterSync.h: Added. + * fileapi/FileWriterSync.idl: Added. + +2010-11-09 Mario Sanchez Prada <msanchez@igalia.com> + + Reviewed by Chris Fleizach. + + [GTK] Improve accessibility of focusable lists + https://bugs.webkit.org/show_bug.cgi?id=25679 + + Emit the 'selected' and 'focused' events as needed. + + This is the last bit of a series of patches to fix bug 25679, + which just ensures that the right signals are emmited whenever a + selection inside a listbox object changes, that is, the signals + 'state-changed::selected', 'state-changed::focused' and + 'focus-event', along with the right detail for each of them to + report if the focus/selection has been activated or not. + + * accessibility/gtk/AXObjectCacheAtk.cpp: + (WebCore::notifyChildrenSelectionChange): New, takes care of + emitting all the needed signals when children selection has + changed, both from the point of view of the container and the + selected/unselected items inside of it. It currently supports + listboxes (html 'select' controls) only. + (WebCore::AXObjectCache::postPlatformNotification): Replaced some + old code with a simple call to notifyChildrenSelectionChange(). + +2010-11-09 David Hyatt <hyatt@apple.com> + + Reviewed by Dan Bernstein. + + https://bugs.webkit.org/show_bug.cgi?id=49202 + + Make lists work with vertical text. + + (1) Patch all the CSS rules in html.css so that the margins are directionally abstract. + (2) Add a transposedRect and transposedSize method to IntRect and IntSize for swapping x/y and width/height. + (3) Add adjustLineDirectionPosition as a helper for moving a line box only in the line direction. + (4) Fix a bug in addIntrudingFLoats uncovered by list test cases where the top margin of an element was being + incorrectly added to a float's physical left side instead of its top side. + (5) Make positioning and painting and selection of list markers account for all writing modes. + (6) Add helpers for setting the start and end margins directly in a RenderStyle, since lists do this to hack + marker margins before they have been calculated and set on the box. + + Cloned a bunch of fast/lists tests into fast/lists/*-vertical.html versions. + + * css/html.css: + * platform/graphics/IntRect.h: + (WebCore::IntRect::transposedRect): + * platform/graphics/IntSize.h: + (WebCore::IntSize::transposedSize): + * rendering/InlineBox.h: + (WebCore::InlineBox::adjustLineDirectionPosition): + * rendering/RenderBlock.cpp: + (WebCore::RenderBlock::addIntrudingFloats): + * rendering/RenderListItem.cpp: + (WebCore::getParentOfFirstLineBox): + (WebCore::RenderListItem::positionListMarker): + (WebCore::RenderListItem::paint): + * rendering/RenderListMarker.cpp: + (WebCore::RenderListMarker::localSelectionRect): + (WebCore::RenderListMarker::paint): + (WebCore::RenderListMarker::layout): + (WebCore::RenderListMarker::computePreferredLogicalWidths): + (WebCore::RenderListMarker::updateMargins): + (WebCore::RenderListMarker::getRelativeMarkerRect): + * rendering/style/RenderStyle.cpp: + (WebCore::RenderStyle::setMarginStart): + (WebCore::RenderStyle::setMarginEnd): + * rendering/style/RenderStyle.h: + +2010-11-09 Abhishek Arya <inferno@chromium.org> + + Reviewed by Antti Koivisto. + + Call to SVGSMILElement::applyResultsToTarget can blow away the SVGSMILElement. + Refptr the SVGSMILElement in the ResultElementMap to protect it. + https://bugs.webkit.org/show_bug.cgi?id=49274 + + Test: svg/animations/animate-update-crash.xhtml + + * svg/animation/SMILTimeContainer.cpp: + (WebCore::SMILTimeContainer::updateAnimations): + +2010-11-09 Alexey Proskuryakov <ap@apple.com> + + Reviewed by Darin Adler. + + https://bugs.webkit.org/show_bug.cgi?id=49281 + Remove broken code for embedded CSS xml-stylesheet + + * dom/Document.cpp: (WebCore::Document::recalcStyleSelector): This made no sense, was untested, + and didn't match Firefox. + +2010-11-09 Brady Eidson <beidson@apple.com> + + Reviewed by Darin Adler. + + <rdar://problem/8613727> and https://bugs.webkit.org/show_bug.cgi?id=48720 + Customizable context menu support in WebKit2. + + Various WebCore support to allow WebKit2 to create new ContextMenuItems with + the information it has. + + * WebCore.exp.in: + + * platform/ContextMenu.h: + * platform/ContextMenuItem.h: + + * platform/mac/ContextMenuItemMac.mm: + (WebCore::ContextMenuItem::ContextMenuItem): + (WebCore::ContextMenuItem::setSubMenu): + * platform/mac/ContextMenuMac.mm: + (WebCore::platformMenuDescription): + + * platform/qt/ContextMenuItemQt.cpp: + (WebCore::ContextMenuItem::ContextMenuItem): + (WebCore::ContextMenuItem::setSubMenu): + * platform/qt/ContextMenuQt.cpp: + (WebCore::platformMenuDescription): + + * platform/win/ContextMenuItemWin.cpp: + (WebCore::ContextMenuItem::ContextMenuItem): + (WebCore::ContextMenuItem::setSubMenu): + * platform/win/ContextMenuWin.cpp: + (WebCore::platformMenuDescription): + +2010-11-09 Sam Weinig <sam@webkit.org> + + Reviewed by Anders Carlsson. + + Need WebKit2 mechanism for getting the visible page text + <rdar://problem/8646928> + https://bugs.webkit.org/show_bug.cgi?id=49275 + + * WebCore.exp.in: Add necessary exports. + +2010-11-09 Simon Fraser <simon.fraser@apple.com> + + Reviewed by James Robinson. + + Make showLayerTree() more useful for debugging + https://bugs.webkit.org/show_bug.cgi?id=49273 + + Three things to make showLayerTree() more useful when called from gdb: + 1. Add showLayerTree(RenderObject*) + 2. Make it not update layout, so you can call it when debugging layout code. + 3. Add output of the 'needs layout' flags for each renderer. + + * rendering/RenderLayer.cpp: + (showLayerTree): + * rendering/RenderLayer.h: + * rendering/RenderTreeAsText.cpp: + (WebCore::RenderTreeAsText::writeRenderObject): + (WebCore::externalRepresentation): + * rendering/RenderTreeAsText.h: + +2010-11-09 Chris Rogers <crogers@google.com> + + Reviewed by James Robinson. + + AudioChannel.h is including AudioFloatArray.h instead of AudioArray.h + https://bugs.webkit.org/show_bug.cgi?id=49269 + + * platform/audio/AudioChannel.h: + +2010-11-09 Dan Bernstein <mitz@apple.com> + + Reviewed by Dave Hyatt. + + Made tables hit-test correctly in all writing modes. + + Part of: Make tables work with vertical text + https://bugs.webkit.org/show_bug.cgi?id=46417 + + Test: fast/blockflow/table-hit-test.html + + * rendering/RenderTable.cpp: + (WebCore::RenderTable::nodeAtPoint): + * rendering/RenderTableRow.cpp: + (WebCore::RenderTableRow::nodeAtPoint): + * rendering/RenderTableSection.cpp: + (WebCore::RenderTableSection::nodeAtPoint): + +2010-11-09 Simon Fraser <simon.fraser@apple.com> + + Reviewed by Darin Adler. + + Caret fails to render with some combination of iframes and compositing + https://bugs.webkit.org/show_bug.cgi?id=49079 + + Because it's possible for the caret to jump between different + compositing layers and the view, caret repainting currently dirties + both the view and all compositing layers that intersect the caret rect, + via repaintRectangleInViewAndCompositedLayers(). + + When an iframe contained compositing layers, we erroneously skipped + invalidating the compositing layer inside the iframe, which caused + the caret to fail to blink. + + * manual-tests/compositing/caret-in-compositing-frame.html: Added. + * manual-tests/compositing/resources/editable-compositing-subframe.html: Added. + * rendering/RenderView.cpp: + (WebCore::RenderView::repaintRectangleInViewAndCompositedLayers): + +2010-11-09 Peter Rybin <peter.rybin@gmail.com> + + Reviewed by Adam Barth. + + XMLDocumentParser gets deleted and then used in LayoutTest/fast/frames/set-parent-src-synchronously.xhtml on QT/Linux + https://bugs.webkit.org/show_bug.cgi?id=48643 + + * dom/XMLDocumentParserQt.cpp: + (WebCore::XMLDocumentParser::doWrite): + +2010-11-09 Simon Fraser <simon.fraser@apple.com> + + Reviewed by Dave Hyatt. + + https://bugs.webkit.org/show_bug.cgi?id=49197 + <rdar://problem/8642746> + + When starting an accelerated transform animation on a renderer, check + that it's a RenderBox before allow transform animations (and before + calling borderBoxRect()), because transforms are currently disallowed + on inline elements. + + Test: animations/animation-on-inline-crash.html + + * rendering/RenderLayerBacking.cpp: + (WebCore::RenderLayerBacking::startAnimation): + +2010-11-09 Simon Fraser <simon.fraser@apple.com> + + Reviewed by Dave Hyatt. + + https://bugs.webkit.org/show_bug.cgi?id=49204 + <rdar://problem/8643412> + + Add checks to the CSSStyleSelector code to ensure that the + casts to the various CSSValue types are safe, and do more + rigorous checking of the lengths of CSSValueLists, and + non-null members of Pair in some cases. + + * css/CSSBorderImageValue.h: + (WebCore::CSSBorderImageValue::isBorderImageValue): + * css/CSSCursorImageValue.h: + (WebCore::CSSCursorImageValue::isCursorImageValue): + * css/CSSImageValue.h: + (WebCore::CSSImageValue::isImageValue): + * css/CSSReflectValue.h: + (WebCore::CSSReflectValue::isReflectValue): + * css/CSSStyleSelector.cpp: + (WebCore::CSSStyleSelector::resolveVariablesForDeclaration): + (WebCore::CSSRuleSet::addRulesFromSheet): + (WebCore::CSSRuleSet::addStyleRule): + (WebCore::applyCounterList): + (WebCore::CSSStyleSelector::applyProperty): + (WebCore::CSSStyleSelector::mapFillSize): + (WebCore::CSSStyleSelector::mapAnimationDelay): + (WebCore::CSSStyleSelector::mapAnimationDirection): + (WebCore::CSSStyleSelector::mapAnimationFillMode): + (WebCore::CSSStyleSelector::mapAnimationName): + (WebCore::CSSStyleSelector::mapAnimationPlayState): + (WebCore::CSSStyleSelector::mapNinePieceImage): + (WebCore::CSSStyleSelector::createTransformOperations): + * css/CSSValue.h: + (WebCore::CSSValue::isBorderImageValue): + (WebCore::CSSValue::isCursorImageValue): + (WebCore::CSSValue::isFontFamilyValue): + (WebCore::CSSValue::isReflectValue): + (WebCore::CSSValue::isShadowValue): + * css/FontFamilyValue.h: + (WebCore::FontFamilyValue::isFontFamilyValue): + * css/SVGCSSStyleSelector.cpp: + (WebCore::CSSStyleSelector::applySVGProperty): + * css/ShadowValue.h: + (WebCore::ShadowValue::isShadowValue): + * platform/graphics/transforms/TransformOperations.h: + (WebCore::TransformOperations::clear): + +2010-11-09 Ben Murdoch <benm@google.com> + + Reviewed by Steve Block. + + Android is missing implementation of V8GCController::checkMemoryUsage + https://bugs.webkit.org/show_bug.cgi?id=49255 + + This patch adds the necessary code to WebCore to implement the + functionality. The implementation of the PlatformBridge on Android + does not live upstream yet, so not patching that here. + + No new test as this is a platform specific change on Android. + + * bindings/v8/V8GCController.cpp: + (WebCore::V8GCController::checkMemoryUsage): Implement on Android. + * platform/android/PlatformBridge.h: Add necessary methods to read + device specific memory usage and constraints. + +2010-11-09 Andreas Kling <kling@webkit.org> + + Reviewed by Kenneth Rohde Christiansen. + + ScrollView::updateScrollbars() shouldn't do anything when scrolling is delegated. + + * platform/ScrollView.cpp: + (WebCore::ScrollView::updateScrollbars): + +2010-11-09 Steve Block <steveblock@google.com> + + Reviewed by Andreas Kling. + + Unused parameter warning causes JSC build failure with deviceorientation + https://bugs.webkit.org/show_bug.cgi?id=49251 + + No new tests, build fix only. + + * bindings/js/JSDeviceMotionEventCustom.cpp: + (WebCore::JSDeviceMotionEvent::interval): + * bindings/js/JSDeviceOrientationEventCustom.cpp: + (WebCore::JSDeviceOrientationEvent::alpha): + (WebCore::JSDeviceOrientationEvent::beta): + (WebCore::JSDeviceOrientationEvent::gamma): + +2010-11-09 Renata Hodovan <reni@webkit.org> + + Reviewed by Nikolas Zimmermann. + + SVGFETileElement doesn't support dynamic invalidation, when attributes change. + https://bugs.webkit.org/show_bug.cgi?id=49247 + + The dynamic changes are captured by the svgAttributeChanged function. Invalidate the filter primitive if necessary. + + Tests: svg/dynamic-updates/SVGFETileElement-dom-in-attr.html + svg/dynamic-updates/SVGFETileElement-svgdom-in-prop.html + + * svg/SVGFETileElement.cpp: + (WebCore::SVGFETileElement::svgAttributeChanged): + * svg/SVGFETileElement.h: + +2010-11-09 Jenn Braithwaite <jennb@chromium.org> + + Reviewed by Dmitry Titov. + + Update ProgressTracker when moving a frame between documents + https://bugs.webkit.org/show_bug.cgi?id=48368 + + No new tests. andersca informs me it's not possible to test + ProgressTracker changes via layouttests. Review extra carefully... + + * loader/DocumentLoader.cpp: + (WebCore::DocumentLoader::transferLoadingResourcesFromPage): + Changed to use FrameLoader to deliver the notification to the + client via the notifier. + * loader/FrameLoader.cpp: + (WebCore::FrameLoader:;transferLoadingResourcesFromPage): + Update old and new progress tracker about frame progress. + (WebCore::FrameLoader::dispatchTransferLoadingResourceFromPage): + Added to route notification via the notifier. + * loader/FrameLoader.h: + * loader/ProgressTracker.cpp: + (WebCore::ProgressTracker::completeProgress): + Comment change only. + * loader/ResourceLoadNotifier.cpp: + (WebCore::ResourceLoadNotifier::dispatchTransferLoadingResourceFromPage): + Added to provide one place to notify client and progress tracker - + and probably inspector controller (separate patch). + * loader/ResourceLoadNotifier.h: + +2010-11-09 Dai Mikurube <dmikurube@google.com> + + Reviewed by Kent Tamura. + + Too precise serialization from floating point number to string for "number" input elements + https://bugs.webkit.org/show_bug.cgi?id=48308 + + Modified to consider decimal places when handling step and base in applyStep(). + + * html/HTMLInputElement.cpp: Considering decimal places of the given "step" attribtue. + (WebCore::HTMLInputElement::getAllowedValueStep): + (WebCore::HTMLInputElement::getAllowedValueStepWithDecimalPlaces): + (WebCore::HTMLInputElement::applyStep): + * html/HTMLInputElement.h: + * html/InputType.cpp: Added virtual functions for decimal places and an acceptable error. + (WebCore::InputType::stepBaseWithDecimalPlaces): + (WebCore::InputType::acceptableError): + (WebCore::InputType::parseToDoubleWithDecimalPlaces): + * html/InputType.h: + * html/NumberInputType.cpp: + (WebCore::NumberInputType::stepMismatch): Using the virtual function acceptableError(). + (WebCore::NumberInputType::stepBaseWithDecimalPlaces): Considering decimal places of the given "base" attribute. + (WebCore::NumberInputType::parseToDoubleWithDecimalPlaces): + (WebCore::NumberInputType::acceptableError): Concrete acceptableError() for the number type. + * html/NumberInputType.h: + * html/parser/HTMLParserIdioms.cpp: + (WebCore::parseToDoubleForNumberTypeWithDecimalPlaces): Parsing numbers with decimal places. + * html/parser/HTMLParserIdioms.h: + +2010-11-09 Yuzo Fujishima <yuzo@google.com> + + Reviewed by Shinichiro Hamaji. + + Fix for Bug 48984 - [Chromium] @media print crash due to paged media support + Page context has been inheriting from document element style that becomes null if display property is none. + It should inherit from document style instead to properly handle direction property (and to avoid the null reference). + https://bugs.webkit.org/show_bug.cgi?id=48984 + + Test: printing/page-format-data-display-none.html + + * css/CSSStyleSelector.cpp: + (WebCore::CSSStyleSelector::styleForPage): Page context inherits from + document style. + +2010-11-09 Chris Rogers <crogers@google.com> + + Reviewed by Kenneth Russell. + + Add custom bindings for AudioContext + https://bugs.webkit.org/show_bug.cgi?id=49115 + + No new tests since audio API is not yet implemented. + + * bindings/js/JSAudioContextCustom.cpp: Added. + (WebCore::JSAudioContextConstructor::constructJSAudioContext): + * bindings/v8/custom/V8AudioContextCustom.cpp: Added. + (WebCore::V8AudioContext::constructorCallback): + +2010-11-09 Shinichiro Hamaji <hamaji@chromium.org> + + Reviewed by Dimitri Glazkov. + + [Chromium] display:none has no effect on <option> element + https://bugs.webkit.org/show_bug.cgi?id=49169 + + Added a manual test because it's hard to test the content of + <option> element. + + * manual-tests/display-none-option.html: Added. + * platform/PopupMenuStyle.h: + (WebCore::PopupMenuStyle::PopupMenuStyle): + (WebCore::PopupMenuStyle::isDisplayNone): + * platform/chromium/PopupMenuChromium.cpp: + (WebCore::PopupListBox::getRowHeight): + (WebCore::PopupListBox::layout): + * rendering/RenderMenuList.cpp: + (WebCore::RenderMenuList::itemStyle): + (WebCore::RenderMenuList::menuStyle): + * rendering/RenderTextControlSingleLine.cpp: + (WebCore::RenderTextControlSingleLine::menuStyle): + +2010-11-09 Chris Rogers <crogers@google.com> + + Reviewed by Kenneth Russell. + + audio engine: add audio resources abstraction + https://bugs.webkit.org/show_bug.cgi?id=34660 + + No new tests since audio API is not yet implemented. + + * platform/audio/AudioBus.h: + * platform/audio/HRTFElevation.cpp: + (WebCore::HRTFElevation::calculateKernelsForAzimuthElevation): + (WebCore::HRTFElevation::createByInterpolatingSlices): + * platform/audio/mac/AudioBusMac.mm: Added. + (WebCore::AudioBus::loadPlatformResource): + +2010-11-09 James Simonsen <simonjam@chromium.org> + + Reviewed by Dimitri Glazkov. + + [Web Timing] Remove requestEnd + https://bugs.webkit.org/show_bug.cgi?id=48924 + + * page/Timing.cpp: + * page/Timing.h: + * page/Timing.idl: + +2010-11-09 Sam Magnuson <smagnuson@netflix.com> + + Reviewed by Andreas Kling. + + [Qt] image borders do not render correctly + https://bugs.webkit.org/show_bug.cgi?id=49191 + + Test: fast/borders/border-image-01.html + + * platform/graphics/qt/ImageQt.cpp: + (WebCore::Image::drawPattern): + +2010-11-08 James Simonsen <simonjam@chromium.org> + + Reviewed by Dimitri Glazkov. + + [Web Timing] Split domContentLoaded into start/end + https://bugs.webkit.org/show_bug.cgi?id=48920 + + * dom/Document.cpp: + (WebCore::Document::finishedParsing): + * dom/DocumentTiming.h: + (WebCore::DocumentTiming::DocumentTiming): + * page/Timing.cpp: + (WebCore::Timing::domContentLoadedStart): + (WebCore::Timing::domContentLoadedEnd): + * page/Timing.h: + * page/Timing.idl: + +2010-11-08 Nate Chapin <japhet@chromium.org> + + Reviewed by Adam Barth. + + Call ApplicationCacheHost::maybeLoadResource() in + ResourceLoader::start() instead of ResourceLoader::load(). + maybeLoadResource() might mutate the ResourceRequest, and + in its current location any modifications are lost. + + https://bugs.webkit.org/show_bug.cgi?id=49221 + + Fixes a couple of http/tests/appcache tests + failing on chromium. + + * loader/ResourceLoader.cpp: + (WebCore::ResourceLoader::load): + (WebCore::ResourceLoader::start): + +2010-11-08 Chang Shu <chang.shu@nokia.com> + + Reviewed by Antonio Gomes. + + [GTK] Use Space to toggle arrow key handling for selection change or + spatial navigation. Put the logic in common code to pass both Qt and + GTK. Mac won't work because arrow keys trigger the popup. + https://bugs.webkit.org/show_bug.cgi?id=49150 + + Existing test: fast/events/spatial-navigation/snav-single-select.html + + * dom/SelectElement.cpp: + (WebCore::SelectElement::menuListDefaultEventHandler): + +2010-11-08 Jenn Braithwaite <jennb@chromium.org> + + Reviewed by Pavel Feldman. + + _bindResourceURL in ResourceManager.js may not add resource to map + https://bugs.webkit.org/show_bug.cgi?id=49088 + + No new tests. pfeldman working on better test harness and tests. + + * inspector/front-end/ResourceManager.js: + (WebInspector.ResourceManager.prototype._bindResourceURL): + +2010-11-08 John Knottenbelt <jknotten@chromium.org> + + Reviewed by Steve Block. + + Convert to and from DOMTimeStamp with converter functions. + This is a refactoring only, covered by existing layout tests. + https://bugs.webkit.org/show_bug.cgi?id=49066 + + * GNUmakefile.am: + * WebCore.gypi: + * WebCore.pro: + * WebCore.vcproj/WebCore.vcproj: + * WebCore.xcodeproj/project.pbxproj: + * dom/DOMTimeStamp.h: Added. + (WebCore::convertSecondsToDOMTimeStamp): + (WebCore::convertDOMTimeStampToSeconds): + * dom/Event.cpp: + (WebCore::Event::Event): + * dom/Event.h: + * page/Geolocation.cpp: + (WebCore::Geolocation::haveSuitableCachedPosition): + * platform/android/GeolocationServiceAndroid.cpp: + (WebCore::GeolocationServiceAndroid::isPositionMoreTimely): + +2010-11-08 Ryosuke Niwa <rniwa@webkit.org> + + Unreviewed build fix for Chromium Mac for r71590. + + * platform/graphics/mac/ComplexTextControllerCoreText.cpp: + (WebCore::provideStringAndAttributes): + +2010-11-08 Anton Muhin <antonm@chromium.org> + + Reviewed by Nate Chapin. + + [v8] Get rid of automatically generated named property getter for classes with namedItem method + https://bugs.webkit.org/show_bug.cgi?id=48770 + + * bindings/scripts/CodeGeneratorV8.pm: + * bindings/v8/custom/V8HTMLSelectElementCustom.cpp: + +2010-11-08 Ned Holbrook <nholbrook@apple.com> + + Reviewed by Adam Barth. + + Avoid CFAttributedString creation in ComplexTextController by adopting UniChar provider SPI. + https://bugs.webkit.org/show_bug.cgi?id=48886 + + * WebCore.exp.in: + * platform/graphics/mac/ComplexTextControllerCoreText.cpp: + (WebCore::provideStringAndAttributes): + (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): + * platform/mac/WebCoreSystemInterface.h: + * platform/mac/WebCoreSystemInterface.mm: + +2010-11-08 David Hyatt <hyatt@apple.com> + + Reviewed by Simon Fraser. + + https://bugs.webkit.org/show_bug.cgi?id=49228 + + REGRESSION: caret too short when a positive line height is specified. Now that lineTop no longer + accidentally incorporates the top leading, we need to use selectionTop/Bottom for the caret rect. + + * rendering/RenderText.cpp: + (WebCore::RenderText::localCaretRect): + +2010-11-08 Pierre-Antoine LaFayette <pierre.lafayette@gmail.com> + + Reviewed by Darin Fisher. + + [chromium] Adding hasUserGesture flag to the ResourceRequest + https://bugs.webkit.org/show_bug.cgi?id=37057 + + This flag is to be used on the browser side to indicate when a + download has been user initiated. + + No new tests. This change will be tested through a browser UI test. + + * platform/network/chromium/ResourceRequest.h: + (WebCore::ResourceRequest::ResourceRequest): + (WebCore::ResourceRequest::hasUserGesture): + (WebCore::ResourceRequest::setHasUserGesture): + +2010-11-08 Chris Rogers <crogers@google.com> + + Reviewed by Kenneth Russell. + + Remove obsolete PASSTHROUGH and MATRIXMIX panner mode + https://bugs.webkit.org/show_bug.cgi?id=49087 + + No new tests since audio API is not yet implemented. + + * platform/audio/Panner.cpp: + (WebCore::Panner::create): + * platform/audio/Panner.h: + * webaudio/AudioPannerNode.h: + * webaudio/AudioPannerNode.idl: + +2010-11-08 Patrick Gansterer <paroga@webkit.org> + + Reviewed by Adam Roben. + + Merge EditorWinCE.cpp into EditorWin.cpp + https://bugs.webkit.org/show_bug.cgi?id=49095 + + * platform/win/EditorWin.cpp: + (WebCore::Editor::newGeneralClipboard): + * platform/wince/EditorWinCE.cpp: Removed. + +2010-11-08 David Hyatt <hyatt@apple.com> + + Reviewed by Simon Fraser. + + https://bugs.webkit.org/show_bug.cgi?id=49217 + + Fix coordinate space mismatch in RenderReplaced and make sure RenderText retains its old behavior of + preferring later lines when there is overlap. + + * rendering/RenderReplaced.cpp: + (WebCore::RenderReplaced::positionForPoint): + * rendering/RenderText.cpp: + (WebCore::RenderText::positionForPoint): + +2010-11-08 Steve Block <steveblock@google.com> + + Reviewed by David Levin. + + Building for Android generates several compiler warnings + https://bugs.webkit.org/show_bug.cgi?id=49175 + + Fixes these warnings, most of which are trivial. + - PREFIX_FOR_WEBCORE was previously required for STL's algorithm, but is no + longer. See + http://android.git.kernel.org/?p=platform/external/webkit.git;a=commit;h=a47ab5294213cca2741f453b450b02666e08cac8 + - The definition of EXPORT is required only for the JNI entry point in + WebKit/android, so does not need to be in WebCorePrefix.h + + No new tests, fixes compile warnings only. + + * WebCorePrefix.h: + * bridge/jni/jsc/JNIUtilityPrivate.cpp: + (JSC::Bindings::convertValueToJValue): + * platform/android/FileSystemAndroid.cpp: + (WebCore::listDirectory): + +2010-11-08 Dan Bernstein <mitz@apple.com> + + Reviewed by Darin Adler. + + <rdar://problem/8119781> Crash zooming into Word document at office.live.com + https://bugs.webkit.org/show_bug.cgi?id=49203 + + Test: fast/css/zoom-change-triggering-layout.html + + RenderBox::styleDidChange() was calling scrollLeft() and scrollTop(), whose RenderTextControlSingleLine + overrides can trigger layout. + + * rendering/RenderBox.cpp: + (WebCore::RenderBox::styleDidChange): Use the layer directly for updating the scroll offsets when + the zoom factor changes. + +2010-11-08 David Hyatt <hyatt@apple.com> + + Reviewed by Simon Fraser. + + https://bugs.webkit.org/show_bug.cgi?id=48587 + + Make Ruby work with vertical text. Ruby already nearly does work. The only big issue I found was with + flipped lines writing modes. Make sure to mutate the writing-mode of the RenderRubyRun to ensure that + the ruby text is on the correct side of the ruby base. + + Added fast/blockflow tests of the various writing modes. + + * rendering/RenderBlock.cpp: + (WebCore::RenderBlock::baselinePosition): + (WebCore::RenderBlock::firstLineBoxBaseline): + (WebCore::RenderBlock::lastLineBoxBaseline): + * rendering/RenderRubyRun.cpp: + (WebCore::RenderRubyRun::staticCreateRubyRun): + +2010-11-08 Brent Fulgham <bfulgham@webkit.org> + + Unreviewed build correction after @70369/@70846. + + Please use PLATFORM(CG) to define CG-specific code, not + PLATFORM(CF). + + * platform/image-decoders/ImageDecoder.cpp: + * platform/image-decoders/ImageDecoder.h: + +2010-11-08 James Robinson <jamesr@chromium.org> + + Reviewed by Dimitri Glazkov. + + Input element with inner spin button set to display:none causes crash + https://bugs.webkit.org/show_bug.cgi?id=49121 + + Null check the inner spin button's renderer before dereferencing it. + + Test: fast/forms/input-number-spinbutton-crash.html + + * rendering/RenderTextControlSingleLine.cpp: + (WebCore::RenderTextControlSingleLine::forwardEvent): + +2010-11-08 Xiaomei Ji <xji@chromium.org> + + Reviewed by Dan Bernstein. + + Fix Unicode explicit bidi control characters are removed in editing operations, + such as insert/copy/cut/paste. + https://bugs.webkit.org/show_bug.cgi?id=25321 + + Unicode explicit bidi control characters were excluded in BidiRun and + consequently from InlineTextBoxes due to their effect on rendering complex + text with ATSUI. + The fix is including those characters in BidiRun and remove them from + ComplexTextRun with ATSUI. + + Test: editing/inserting/insert-paste-bidi-control.html + fast/text/atsui-bidi-control.html + + * platform/graphics/mac/ComplexTextControllerATSUI.cpp: + (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): + * platform/text/BidiResolver.h: + (WebCore::::checkDirectionInLowerRaiseEmbeddingLevel): + (WebCore::::lowerExplicitEmbeddingLevel): + (WebCore::::raiseExplicitEmbeddingLevel): + (WebCore::::createBidiRunsForLine): + +2010-11-08 David Hyatt <hyatt@apple.com> + + Reviewed by Dan Bernstein. + + https://bugs.webkit.org/show_bug.cgi?id=49126 + + RenderBlock::positionForPoint is not writing-mode aware. Patch the function to examine lines in the correct + writing-mode direction. Patched and renamed a number of helpers used by positionForPoint. + + Fixed a bug with RenderReplaced's positionForPoint. There was a coordinate space mismatch between what the + function expected (local coordinates) and what was passed in (containing block coords), which meant the function didn't even work. + + Fixed a bug with the propagation of selection state on RenderReplaced to its containing block. The bit double propagated + because both the base class function and the derived class function did the propagation, and the setter function did not + do the right thing if this happened. + + Patched the localSelectionRect method on RenderReplaced so that selection draws in the right place in all writing modes. + + Added new tests of positionForPoint and replaced elements in fast/blockflow. + + * editing/visible_units.cpp: + (WebCore::previousLinePosition): + (WebCore::nextLinePosition): + * platform/graphics/IntPoint.h: + (WebCore::IntPoint::transpose): + * rendering/InlineBox.cpp: + (WebCore::InlineBox::paint): + * rendering/RenderBlock.cpp: + (WebCore::RenderBlock::nodeAtPoint): + (WebCore::RenderBlock::hitTestFloats): + (WebCore::positionForPointRespectingEditingBoundaries): + (WebCore::RenderBlock::positionForPointWithInlineChildren): + (WebCore::RenderBlock::positionForPoint): + * rendering/RenderReplaced.cpp: + (WebCore::RenderReplaced::positionForPoint): + (WebCore::RenderReplaced::localSelectionRect): + (WebCore::RenderReplaced::setSelectionState): + * rendering/RenderReplaced.h: + * rendering/RenderText.cpp: + (WebCore::RenderText::positionForPoint): + * rendering/RootInlineBox.cpp: + (WebCore::RootInlineBox::closestLeafChildForLogicalLeftPosition): + * rendering/RootInlineBox.h: + +2010-11-08 Nate Chapin <japhet@chromium.org> + + Reviewed by Alexey Proskuryakov. + + Move connection-per-host counting and request prioritization out + of Loader and down to the ResourceLoader level. + + https://bugs.webkit.org/show_bug.cgi?id=27165 + + Refactor only, so no new tests. + + * CMakeLists.txt: + * GNUmakefile.am: + * WebCore.exp.in: + * WebCore.gypi: + * WebCore.pro: + * WebCore.vcproj/WebCore.vcproj: + * WebCore.xcodeproj/project.pbxproj: + * dom/ContainerNode.cpp: + (WebCore::ContainerNode::suspendPostAttachCallbacks): + (WebCore::ContainerNode::resumePostAttachCallbacks): + * loader/DocumentThreadableLoader.cpp: + (WebCore::DocumentThreadableLoader::loadRequest): + * loader/MainResourceLoader.cpp: + (WebCore::MainResourceLoader::loadNow): + * loader/NetscapePlugInStreamLoader.cpp: + (WebCore::NetscapePlugInStreamLoader::create): + * loader/NetscapePlugInStreamLoader.h: + * loader/ResourceLoadScheduler.cpp: Added. + (WebCore::ResourceLoadScheduler::hostForURL): + (WebCore::resourceLoadScheduler): Returns the single ResourceLoadScheduler instance + (WebCore::ResourceLoadScheduler::ResourceLoadScheduler): + (WebCore::ResourceLoadScheduler::scheduleSubresourceLoad): + (WebCore::ResourceLoadScheduler::schedulePluginStreamLoad): + (WebCore::ResourceLoadScheduler::addMainResourceLoad): + (WebCore::ResourceLoadScheduler::scheduleLoad): + (WebCore::ResourceLoadScheduler::remove): + (WebCore::ResourceLoadScheduler::crossOriginRedirectReceived): + (WebCore::ResourceLoadScheduler::servePendingRequests): + (WebCore::ResourceLoadScheduler::suspendPendingRequests): + (WebCore::ResourceLoadScheduler::resumePendingRequests): + (WebCore::ResourceLoadScheduler::scheduleServePendingRequests): + (WebCore::ResourceLoadScheduler::requestTimerFired): + (WebCore::ResourceLoadScheduler::assertLoaderBeingCounted): + (WebCore::ResourceLoadScheduler::HostInformation::assertLoaderBeingCounted): + (WebCore::ResourceLoadScheduler::HostInformation::HostInformation): + (WebCore::ResourceLoadScheduler::HostInformation::~HostInformation): + (WebCore::ResourceLoadScheduler::HostInformation::schedule): + (WebCore::ResourceLoadScheduler::HostInformation::addLoadInProgress): + (WebCore::ResourceLoadScheduler::HostInformation::remove): + (WebCore::ResourceLoadScheduler::HostInformation::hasRequests): + * loader/ResourceLoadScheduler.h: Added. + (WebCore::ResourceLoadScheduler::HostInformation::name): + (WebCore::ResourceLoadScheduler::HostInformation::limitRequests): + (WebCore::ResourceLoadScheduler::HostInformation::requestsPending): + * loader/ResourceLoader.cpp: + (WebCore::ResourceLoader::releaseResources): Remove this from ResourceLoadScheduler's counting. + (WebCore::ResourceLoader::load): + (WebCore::ResourceLoader::start): Create the ResourceHandle, called by ResourceLoadScheduler. + (WebCore::ResourceLoader::willSendRequest): Ensure ResourceLoadScheduler counts redirects + correctly. + * loader/ResourceLoader.h: + (WebCore::ResourceLoader::url): + * loader/icon/IconLoader.cpp: + (WebCore::IconLoader::startLoading): + * loader/loader.cpp: Move scheduling to ResourceLoadScheduler, remove Host subclass + and make Loader the SubresourceLoaderClient instead. + (WebCore::determinePriority): + (WebCore::Loader::load): Schedule the creation of the ResourceHandle, rather than + doing it immediately. + (WebCore::Loader::cancelRequests): + (WebCore::Loader::didFinishLoading): + (WebCore::Loader::didFail): + (WebCore::Loader::didReceiveResponse): + (WebCore::Loader::didReceiveData): + (WebCore::Loader::didReceiveCachedMetadata): + * loader/loader.h: + * page/EventSource.cpp: + (WebCore::EventSource::connect): + (WebCore::EventSource::endRequest): + * plugins/PluginStream.cpp: + (WebCore::PluginStream::start): + * xml/XMLHttpRequest.cpp: + (WebCore::XMLHttpRequest::XMLHttpRequest): + (WebCore::XMLHttpRequest::~XMLHttpRequest): + (WebCore::XMLHttpRequest::createRequest): + (WebCore::XMLHttpRequest::didFail): + (WebCore::XMLHttpRequest::didFinishLoading): + * xml/XMLHttpRequest.h: + 2010-11-08 Ryosuke Niwa <rniwa@webkit.org> Reviewed by Darin Adler. @@ -1655,7 +7423,7 @@ where some elements have their own layers, and cells whose writing mode differs from the table’s are not supported yet. - Make tables work with vertical text + Part of: Make tables work with vertical text https://bugs.webkit.org/show_bug.cgi?id=46417 Tests: fast/table/027-vertical.html |