diff options
Diffstat (limited to 'WebKit/efl')
-rw-r--r-- | WebKit/efl/ChangeLog | 57 | ||||
-rw-r--r-- | WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp | 3 | ||||
-rw-r--r-- | WebKit/efl/WebCoreSupport/ChromeClientEfl.h | 2 | ||||
-rw-r--r-- | WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp | 10 | ||||
-rw-r--r-- | WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.h | 5 | ||||
-rw-r--r-- | WebKit/efl/ewk/ewk_history.cpp | 10 | ||||
-rw-r--r-- | WebKit/efl/ewk/ewk_private.h | 4 | ||||
-rw-r--r-- | WebKit/efl/ewk/ewk_view.cpp | 9 |
8 files changed, 85 insertions, 15 deletions
diff --git a/WebKit/efl/ChangeLog b/WebKit/efl/ChangeLog index 1795645..bf9af1e 100644 --- a/WebKit/efl/ChangeLog +++ b/WebKit/efl/ChangeLog @@ -1,3 +1,60 @@ +2010-10-29 Darin Adler <darin@apple.com> + + Reviewed by Sam Weinig. + + Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring + https://bugs.webkit.org/show_bug.cgi?id=48574 + + * ewk/ewk_history.cpp: + (ewk_history_new): + * ewk/ewk_private.h: + * ewk/ewk_view.cpp: + (_ewk_view_priv_new): + (ewk_view_history_enable_get): + (ewk_view_history_enable_set): + (ewk_view_history_get): + Use BackForwardListImpl. + +2010-10-29 Alexey Proskuryakov <ap@apple.com> + + Reviewed by Darin Adler. + + https://bugs.webkit.org/show_bug.cgi?id=48576 + Let WebKit2 client know when a frame is a frameset + + Added a blank implementation of the new FrameLoaderClient method. + + * WebCoreSupport/FrameLoaderClientEfl.h: + * WebCoreSupport/FrameLoaderClientEfl.cpp: + (WebCore::FrameLoaderClientEfl::dispatchDidBecomeFrameset): + +2010-10-26 Jenn Braithwaite <jennb@chromium.org> + + Reviewed by Dmitry Titov. + + Resource tracking failure when trying to move a frame between documents + https://bugs.webkit.org/show_bug.cgi?id=44713 + + * WebCoreSupport/FrameLoaderClientEfl.cpp: + (WebCore::FrameLoaderClientEfl::transferLoadingResourceFromPage): + Empty method. + * WebCoreSupport/FrameLoaderClientEfl.h: + +2010-10-22 Sam Weinig <sam@webkit.org> + + Reviewed by Anders Carlsson. + + WebKit2 needs to pass the current event modifier flags when requesting a new window + https://bugs.webkit.org/show_bug.cgi?id=48140 + + * WebCoreSupport/ChromeClientEfl.cpp: + (WebCore::ChromeClientEfl::createWindow): + * WebCoreSupport/ChromeClientEfl.h: + * WebCoreSupport/FrameLoaderClientEfl.cpp: + (WebCore::FrameLoaderClientEfl::dispatchCreatePage): + * WebCoreSupport/FrameLoaderClientEfl.h: + Add NavigationAction parameter. + 2010-10-19 Ryuan Choi <ryuan.choi@samsung.com> Reviewed by Eric Seidel. diff --git a/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp b/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp index 257e824..d99f0bc 100644 --- a/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp +++ b/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp @@ -46,6 +46,7 @@ #include "HitTestResult.h" #include "IntRect.h" #include "KURL.h" +#include "NavigationAction.h" #include "NotImplemented.h" #include "PlatformString.h" #include "SecurityOrigin.h" @@ -143,7 +144,7 @@ void ChromeClientEfl::unfocus() evas_object_focus_set(m_view, EINA_FALSE); } -Page* ChromeClientEfl::createWindow(Frame*, const FrameLoadRequest& frameLoadRequest, const WindowFeatures& features) +Page* ChromeClientEfl::createWindow(Frame*, const FrameLoadRequest& frameLoadRequest, const WindowFeatures& features, const NavigationAction&) { Evas_Object* newView = ewk_view_window_create(m_view, EINA_TRUE, &features); if (!newView) diff --git a/WebKit/efl/WebCoreSupport/ChromeClientEfl.h b/WebKit/efl/WebCoreSupport/ChromeClientEfl.h index 4339b9a..f0aeb8d 100644 --- a/WebKit/efl/WebCoreSupport/ChromeClientEfl.h +++ b/WebKit/efl/WebCoreSupport/ChromeClientEfl.h @@ -54,7 +54,7 @@ public: virtual void focusedNodeChanged(Node*); - virtual Page* createWindow(Frame*, const FrameLoadRequest&, const WindowFeatures&); + virtual Page* createWindow(Frame*, const FrameLoadRequest&, const WindowFeatures&, const NavigationAction&); virtual void show(); virtual bool canRunModal(); diff --git a/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp b/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp index 1b82239..627c1b9 100644 --- a/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp +++ b/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp @@ -384,6 +384,10 @@ void FrameLoaderClientEfl::didTransferChildFrameToNewDocument(Page*) { } +void FrameLoaderClientEfl::transferLoadingResourceFromPage(unsigned long, DocumentLoader*, const ResourceRequest&, Page*) +{ +} + void FrameLoaderClientEfl::redirectDataToPlugin(Widget* pluginWidget) { ASSERT(!m_pluginView); @@ -860,7 +864,7 @@ bool FrameLoaderClientEfl::canCachePage() const return false; } -Frame* FrameLoaderClientEfl::dispatchCreatePage() +Frame* FrameLoaderClientEfl::dispatchCreatePage(const NavigationAction&) { if (!m_view) return 0; @@ -919,6 +923,10 @@ void FrameLoaderClientEfl::transitionToCommittedForNewPage() ewk_view_frame_main_cleared(m_view); } +void FrameLoaderClientEfl::dispatchDidBecomeFrameset(bool) +{ +} + PassRefPtr<FrameNetworkingContext> FrameLoaderClientEfl::createNetworkingContext() { return FrameNetworkingContextEfl::create(ewk_frame_core_get(m_frame)); diff --git a/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.h b/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.h index 1b880e6..a9dd8c1 100644 --- a/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.h +++ b/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.h @@ -111,7 +111,7 @@ class FrameLoaderClientEfl : public FrameLoaderClient { virtual void dispatchDidFirstLayout(); virtual void dispatchDidFirstVisuallyNonEmptyLayout(); - virtual Frame* dispatchCreatePage(); + virtual Frame* dispatchCreatePage(const WebCore::NavigationAction&); virtual void dispatchShow(); virtual void dispatchDecidePolicyForMIMEType(FramePolicyFunction, const String& MIMEType, const ResourceRequest&); @@ -135,6 +135,7 @@ class FrameLoaderClientEfl : public FrameLoaderClient { virtual PassRefPtr<Frame> createFrame(const KURL& url, const String& name, HTMLFrameOwnerElement* ownerElement, const String& referrer, bool allowsScrolling, int marginWidth, int marginHeight); virtual void didTransferChildFrameToNewDocument(Page*); + virtual void transferLoadingResourceFromPage(unsigned long, WebCore::DocumentLoader*, const ResourceRequest&, WebCore::Page*); virtual PassRefPtr<Widget> createPlugin(const IntSize&, HTMLPlugInElement*, const KURL&, const WTF::Vector<String>&, const WTF::Vector<String>&, const String&, bool); virtual void redirectDataToPlugin(Widget* pluginWidget); @@ -198,6 +199,8 @@ class FrameLoaderClientEfl : public FrameLoaderClient { virtual void transitionToCommittedFromCachedFrame(CachedFrame*); virtual void transitionToCommittedForNewPage(); + virtual void dispatchDidBecomeFrameset(bool); + virtual bool canCachePage() const; virtual void download(ResourceHandle*, const ResourceRequest&, const ResourceRequest&, const ResourceResponse&); diff --git a/WebKit/efl/ewk/ewk_history.cpp b/WebKit/efl/ewk/ewk_history.cpp index 8387da1..0a9d349 100644 --- a/WebKit/efl/ewk/ewk_history.cpp +++ b/WebKit/efl/ewk/ewk_history.cpp @@ -21,7 +21,7 @@ #include "config.h" #include "ewk_history.h" -#include "BackForwardList.h" +#include "BackForwardListImpl.h" #include "EWebKit.h" #include "HistoryItem.h" #include "Image.h" @@ -32,7 +32,7 @@ #include <eina_safety_checks.h> struct _Ewk_History { - WebCore::BackForwardList *core; + WebCore::BackForwardListImpl *core; }; #define EWK_HISTORY_CORE_GET_OR_RETURN(history, core_, ...) \ @@ -48,7 +48,7 @@ struct _Ewk_History { ERR("history->core is disabled!."); \ return __VA_ARGS__; \ } \ - WebCore::BackForwardList *core_ = (history)->core + WebCore::BackForwardListImpl *core_ = (history)->core struct _Ewk_History_Item { @@ -666,11 +666,11 @@ Eina_Bool ewk_history_item_visit_last_failed(const Ewk_History_Item* item) * Creates history for given view. Called internally by ewk_view and * should never be called from outside. * - * @param core WebCore::BackForwardList instance to use internally. + * @param core WebCore::BackForwardListImpl instance to use internally. * * @return newly allocated history instance or @c NULL on errors. */ -Ewk_History* ewk_history_new(WebCore::BackForwardList* core) +Ewk_History* ewk_history_new(WebCore::BackForwardListImpl* core) { Ewk_History* history; EINA_SAFETY_ON_NULL_RETURN_VAL(core, 0); diff --git a/WebKit/efl/ewk/ewk_private.h b/WebKit/efl/ewk/ewk_private.h index e2624a3..c1599e3 100644 --- a/WebKit/efl/ewk/ewk_private.h +++ b/WebKit/efl/ewk/ewk_private.h @@ -21,7 +21,7 @@ #ifndef ewk_private_h #define ewk_private_h -#include "BackForwardList.h" +#include "BackForwardListImpl.h" #include "EWebKit.h" #include "Frame.h" #include "Page.h" @@ -108,7 +108,7 @@ void ewk_view_download_request(Evas_Object *o, Ewk_Download *download); int ewk_view_dpi_get(); -Ewk_History *ewk_history_new(WebCore::BackForwardList *history); +Ewk_History *ewk_history_new(WebCore::BackForwardListImpl *history); void ewk_history_free(Ewk_History *history); Ewk_Context_Menu *ewk_context_menu_new(Evas_Object *view, WebCore::ContextMenuController *controller); diff --git a/WebKit/efl/ewk/ewk_view.cpp b/WebKit/efl/ewk/ewk_view.cpp index f1ca733..5ff3ade 100644 --- a/WebKit/efl/ewk/ewk_view.cpp +++ b/WebKit/efl/ewk/ewk_view.cpp @@ -22,6 +22,7 @@ #include "config.h" #include "ewk_view.h" +#include "BackForwardListImpl.h" #include "Chrome.h" #include "ChromeClientEfl.h" #include "ContextMenuClientEfl.h" @@ -634,7 +635,7 @@ static Ewk_View_Private_Data* _ewk_view_priv_new(Ewk_View_Smart_Data* sd) goto error_main_frame; } - priv->history = ewk_history_new(priv->page->backForwardList()); + priv->history = ewk_history_new(static_cast<WebCore::BackForwardListImpl*>(priv->page->backForwardList())); if (!priv->history) { CRITICAL("Could not create history instance for view."); goto error_history; @@ -1762,7 +1763,7 @@ Eina_Bool ewk_view_history_enable_get(const Evas_Object* o) { EWK_VIEW_SD_GET_OR_RETURN(o, sd, EINA_FALSE); EWK_VIEW_PRIV_GET_OR_RETURN(sd, priv, EINA_FALSE); - return priv->page->backForwardList()->enabled(); + return static_cast<WebCore::BackForwardListImpl*>(priv->page->backForwardList())->enabled(); } /** @@ -1778,7 +1779,7 @@ Eina_Bool ewk_view_history_enable_set(Evas_Object* o, Eina_Bool enable) { EWK_VIEW_SD_GET_OR_RETURN(o, sd, EINA_FALSE); EWK_VIEW_PRIV_GET_OR_RETURN(sd, priv, EINA_FALSE); - priv->page->backForwardList()->setEnabled(enable); + static_cast<WebCore::BackForwardListImpl*>(priv->page->backForwardList())->setEnabled(enable); return EINA_TRUE; } @@ -1802,7 +1803,7 @@ Ewk_History* ewk_view_history_get(const Evas_Object* o) { EWK_VIEW_SD_GET_OR_RETURN(o, sd, 0); EWK_VIEW_PRIV_GET_OR_RETURN(sd, priv, 0); - if (!priv->page->backForwardList()->enabled()) { + if (!static_cast<WebCore::BackForwardListImpl*>(priv->page->backForwardList())->enabled()) { ERR("asked history, but it's disabled! Returning 0!"); return 0; } |