diff options
Diffstat (limited to 'WebKitTools/ChangeLog')
| -rw-r--r-- | WebKitTools/ChangeLog | 6074 |
1 files changed, 6074 insertions, 0 deletions
diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog index c55009d..38cd459 100644 --- a/WebKitTools/ChangeLog +++ b/WebKitTools/ChangeLog @@ -1,3 +1,6077 @@ +2010-01-31 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Shinichiro Hamaji. + + Moved style error handler code to their own classes, and + related refactoring. Increased unit test code coverage of + style error handling. + + https://bugs.webkit.org/show_bug.cgi?id=34379 + + * Scripts/check-webkit-style: + - Minor change: added error_count variable. + + * Scripts/webkitpy/style/checker.py: + - Renamed ProcessorOptions.should_report_error() to is_reportable(). + - In the StyleChecker class-- + - Removed _default_style_error_handler(). + - Added _increment_error_count(). + - Refactored to use DefaultStyleErrorHandler and + PatchStyleErrorHandler constructors. + + * Scripts/webkitpy/style/checker_unittest.py: + - In the StyleStyleCheckerTest class-- + - Removed write_sample_error(). + - Removed test_default_style_error_handler(). + + * Scripts/webkitpy/style/error_handlers.py: Added. + - Added DefaultStyleErrorHandler class. + - Added PatchStyleErrorHandler class. + + * Scripts/webkitpy/style/error_handlers_unittest.py: Added. + - Added unit tests for DefaultStyleErrorHandler and + PatchStyleErrorHandler. + + * Scripts/webkitpy/style/unittests.py: + - Added error_handlers unit tests. + +2010-01-29 Mark Rowe <mrowe@apple.com> + + Rubber-stamped by Stephanie Lewis. + + Fix run-leaks with newer versions of the leaks tool. + + * Scripts/run-leaks: + +2010-01-29 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Eric Siedel. + + Top-level test drivers for running the Chromium port of run-webkit-tests + and being able to rebaseline test results from the test bots. The + files in the Scripts directory are simply wrappers around the files + in webkitpy/layout_tests for convenience. + + https://bugs.webkit.org/show_bug.cgi?id=31498 + + * Scripts/rebaseline-chromium-webkit-tests: Added. + * Scripts/run-chromium-webkit-tests: Added. + * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Added. + * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py: Added. + +2010-01-29 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Eric Siedel. + + Add in the second block of python code for the Chromium port + of run-webkit-tests. These files execute different diffs to classify + the various types of failures from a test. + + * Scripts/webkitpy/layout_tests/test_types: Added. + * Scripts/webkitpy/layout_tests/test_types/__init__.py: Added. + * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Added. + * Scripts/webkitpy/layout_tests/test_types/image_diff.py: Added. + * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: Added. + * Scripts/webkitpy/layout_tests/test_types/text_diff.py: Added. + +2010-01-29 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Eric Siedel. + + Check in the first part of the Chromium Python port of the + run-webkit-tests test driver. The files under + layout_tests/layout_layout constitute most of the implementation; + they can be roughly divided into code that parses the + "test_expectations.txt" file that describes how we expect tests to + pass or fail, platform-specific hooks for the different Chromium + ports (in platform_utils*), code for parsing the output of the + tests and generating results files and HTML and JSON for the + dashboards, auxiliary scripts for starting and stopping HTTP and + Web Socket servers, and then one of the actual driver files + (test_shell_thread). Code for actually parsing test output for + failures and the top-level driver scripts will follow shortly. + + https://bugs.webkit.org/show_bug.cgi?id=31498 + + * Scripts/webkitpy/layout_tests: Added. + * Scripts/webkitpy/layout_tests/layout_package: Added. + * Scripts/webkitpy/layout_tests/layout_package/__init__.py: Added. + * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py: Added. + * Scripts/webkitpy/layout_tests/layout_package/http_server.py: Added. + * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py: Added. + * Scripts/webkitpy/layout_tests/layout_package/httpd2.pem: Added. + - scripts to start and stop apache. Note that the apache file + generates a conf file dynamically, and we should switch to + using the same static conf file that the regular run-webkit-tests + uses, and we can also use the same httpd2.pem file. + + * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: Added. + * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Added. + - scripts to generate the JSON layout test dashboard and the + flakiness dashboard + * Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf: Added. + - default configuration for LigHTTPd (used on Windows) + * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py: Added. + - utility class that implements progress bars on the console to + be displayed while the tests are running + * Scripts/webkitpy/layout_tests/layout_package/path_utils.py: Added. + - various routines for manipulating paths and URIs + * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py: Added. + * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py: Added. + * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py: Added. + * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py: Added. + - platform-specific aspects of the drivers (binary names, paths, + process control, etc.) + * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Added. + - code for parsing the 'test_expectations.txt' file to determine + which tests are expected to fail (and how) on which platforms + * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Added. + - code for handling different kinds of failures (generating output + in the results, etc.) + * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Added. + - code to gather the lists of tests + * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: Added. + - code to actually execute tests via TestShell and process + the output + * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py: Added. + - scripts to start and stop the pywebsocket server + +2010-01-29 Dirk Pranke <dpranke@chromium.org> + + Reviewed by Eric Seidel. + + Check in a copy of the simplejson library; it will be used by + the Chromium port of run-webkit-tests. + + https://bugs.webkit.org/show_bug.cgi?id=31498 + + * simplejson: Added. + * simplejson/LICENSE.txt: Added. + * simplejson/README.txt: Added. + * simplejson/__init__.py: Added. + * simplejson/_speedups.c: Added. + (ascii_escape_char): + (ascii_escape_unicode): + (ascii_escape_str): + (py_encode_basestring_ascii): + (init_speedups): + * simplejson/decoder.py: Added. + * simplejson/encoder.py: Added. + * simplejson/jsonfilter.py: Added. + * simplejson/scanner.py: Added. + +2010-01-29 Dirk Pranke <dpranke@chromium.org> + + No review + + Add myself to the committers list + + * Scripts/webkitpy/committers.py: + +2010-01-29 Jeremy Orlow <jorlow@chromium.org> + + Reviewed by Dimitri Glazkov. + + A first step towards the Indexed Database API + https://bugs.webkit.org/show_bug.cgi?id=34342 + + Add indexed database API. + + * Scripts/build-webkit: + +2010-01-29 Andras Becsi <abecsi@webkit.org> + + Reviewed by Alexey Proskuryakov. + + Correct openHTTPD() to print requests to stdout if run-webkit-httpd is used. + This fixes a regression introduced in r53559. + + https://bugs.webkit.org/show_bug.cgi?id=34336 + + * Scripts/webkitperl/httpd.pm: + +2010-01-28 Jon Honeycutt <jhoneycutt@apple.com> + + MSAA: Crash when posting a notification for a detached object + + https://bugs.webkit.org/show_bug.cgi?id=34309 + <rdar://problem/7409759> + + Reviewed by Darin Adler. + + * DumpRenderTree/AccessibilityController.h: + Declare new functions. Add new members to store the event hook and the + mapping of accessibility elements to their JS callbacks. + + * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: + (AccessibilityController::notificationReceived): + Stubbed. + (AccessibilityController::addNotificationListener): + Stubbed. + + * DumpRenderTree/mac/AccessibilityControllerMac.mm: + (AccessibilityController::notificationReceived): + Stubbed. + (AccessibilityController::addNotificationListener): + Stubbed. + + * DumpRenderTree/win/AccessibilityControllerWin.cpp: + (AccessibilityController::AccessibilityController): + Initialize the event hook. + (AccessibilityController::~AccessibilityController): + Remove the event hook. Unprotect all of the JS functions that are stored + in the map. + (logEventProc): + Clean-up a variable. + (stringEvent): + Return a string description of the MSAA event code. + (notificationListenerProc): + Get the accessible object from the event, and query it for IAccessible. + Call the AccessibilityController's notificationReceived(). + (comparableObject): + Use QueryService to obtain the IAccessibleComparable for the + IServiceProvider. + (AccessibilityController::notificationReceived): + Iterate the map of objects that have registered for notification + callbacks. Query each for IServiceProvider, then use comparableObject() + to get an IAccessibleComparable. If we find an object matching the + notified object, call its callback, passing the event that was received. + (AccessibilityController::addNotificationListener): + If we have not created the event hook, create it. Protect the JS + callback function object, and add the object and its callback to our + map. + + * DumpRenderTree/win/AccessibilityUIElementWin.cpp: + (AccessibilityUIElement::addNotificationListener): + Call through to the AccessibilityController's addNotificationListener(). + + * DumpRenderTree/win/DumpRenderTreeWin.h: + Add an extern declaration for the shared FrameLoadDelegate extern, so we + can access it from AccessibilityController. + + * DumpRenderTree/win/FrameLoadDelegate.h: + (FrameLoadDelegate::accessibilityController): + Return the AccessibilityController. + +2010-01-29 Shinichiro Hamaji <hamaji@chromium.org> + + Reviewed by Darin Adler. + + prepare-ChangeLog outputs useless messages for a nonexistent bug ID + https://bugs.webkit.org/show_bug.cgi?id=34313 + + * Scripts/prepare-ChangeLog: + +2010-01-29 Kenneth Rohde Christiansen <kenneth@webkit.org> + + Rubberstamped by Simon Hausmann. + + [Qt] Separate implementation from class definition. + + * QtLauncher/main.cpp: + (LauncherWindow::webView): + (LauncherWindow::LauncherWindow): + (LauncherWindow::~LauncherWindow): + (LauncherWindow::keyPressEvent): + (LauncherWindow::grabZoomKeys): + (LauncherWindow::sendTouchEvent): + (LauncherWindow::eventFilter): + (LauncherWindow::loadStarted): + (LauncherWindow::loadFinished): + (LauncherWindow::showLinkHover): + (LauncherWindow::zoomIn): + (LauncherWindow::zoomOut): + (LauncherWindow::resetZoom): + (LauncherWindow::toggleZoomTextOnly): + (LauncherWindow::print): + (LauncherWindow::screenshot): + (LauncherWindow::setEditable): + (LauncherWindow::dumpHtml): + (LauncherWindow::selectElements): + (LauncherWindow::setTouchMocking): + (LauncherWindow::newWindow): + (LauncherWindow::setupUI): + +2010-01-29 Kenneth Rohde Christiansen <kenneth@webkit.org> + + Reviewed by Ariya Hidayat. + + [Qt] On Maemo5, a click/touch in the location bar (when unfocused) + should result in all text selected. + + * QtLauncher/locationedit.cpp: + (LocationEdit::focusInEvent): + * QtLauncher/locationedit.h: + +2010-01-29 Kenneth Rohde Christiansen <kenneth@webkit.org> + + Reviewed by Ariya Hidayat. + + [Qt] Show progress reaching 100% for loads. + + * QtLauncher/locationedit.cpp: + (LocationEdit::LocationEdit): + (LocationEdit::setProgress): + (LocationEdit::reset): + (LocationEdit::paintEvent): + * QtLauncher/locationedit.h: + +2010-01-29 Andreas Kling <andreas.kling@nokia.com> + + Reviewed by Kenneth Rohde Christiansen. + + [Qt] Disable the QtLauncher statusbar on Maemo + + https://bugs.webkit.org/show_bug.cgi?id=34330 + + * QtLauncher/main.cpp: + (LauncherWindow::showLinkHover): + (LauncherWindow::selectElements): + +2010-01-29 Andreas Kling <andreas.kling@nokia.com> + + Reviewed by Kenneth Rohde Christiansen. + + [Qt] Display page loading progress inside the QtLauncher location bar + + https://bugs.webkit.org/show_bug.cgi?id=34210 + + * QtLauncher/QtLauncher.pro: + * QtLauncher/locationedit.cpp: Added. + (LocationEdit::LocationEdit): + (LocationEdit::setProgress): + (LocationEdit::paintEvent): + * QtLauncher/locationedit.h: Added. + * QtLauncher/mainwindow.cpp: + (MainWindow::buildUI): + * QtLauncher/mainwindow.h: + +2010-01-29 Andreas Kling <andreas.kling@nokia.com> + + Reviewed by Kenneth Rohde Christiansen. + + [Qt] Add support for Maemo zoom keys in QtLauncher + + https://bugs.webkit.org/show_bug.cgi?id=34160 + + * QtLauncher/main.cpp: + (LauncherWindow::LauncherWindow): + (LauncherWindow::~LauncherWindow): + (LauncherWindow::keyPressEvent): + (LauncherWindow::grabZoomKeys): + +2010-01-29 Benjamin Poulain <benjamin.poulain@nokia.com> + + Reviewed by Kenneth Rohde Christiansen. + + [Qt] Implement the display() method of the layout test controller + https://bugs.webkit.org/show_bug.cgi?id=34258 + + * DumpRenderTree/qt/DumpRenderTreeQt.cpp: + (WebCore::DumpRenderTree::DumpRenderTree): + (WebCore::DumpRenderTree::showPage): + (WebCore::DumpRenderTree::hidePage): + * DumpRenderTree/qt/DumpRenderTreeQt.h: + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::reset): + (LayoutTestController::display): + * DumpRenderTree/qt/LayoutTestControllerQt.h: + +2010-01-28 Kevin Ollivier <kevino@theolliviers.com> + + [wx] Build fix for MSW, use ThreadingWin.cpp as the Windows pthreads implementation + implements pthread_t in a way that makes it impossible to check its validity, + which is needed by ThreadingPthreads.cpp. + + * DumpRenderTree/wscript: + * wx/build/settings.py: + +2010-01-28 Andras Becsi <abecsi@webkit.org> + + Adding myself to the committer list. No review needed. + + * Scripts/webkitpy/committers.py: + +2010-01-28 Hayato Ito <hayato@chromium.org> + + Reviewed by David Levin. + + Remove NULL char from input JS file because 'grep' fails if the file contains NULL char. + + https://bugs.webkit.org/show_bug.cgi?id=34252 + + * Scripts/make-script-test-wrappers: + +2010-01-28 Kevin Ollivier <kevino@theolliviers.com> + + [wx] Build fix after removal of the zlib image decoder. + + * wx/build/settings.py: + +2010-01-28 Csaba Osztrogonác <ossy@webkit.org> + + [Qt] Unreviewed, roll out r54000. + + * DumpRenderTree/qt/DumpRenderTreeQt.cpp: + (WebCore::DumpRenderTree::DumpRenderTree): + * DumpRenderTree/qt/DumpRenderTreeQt.h: + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::reset): + * DumpRenderTree/qt/LayoutTestControllerQt.h: + (LayoutTestController::display): + +2010-01-28 Benjamin Poulain <benjamin.poulain@nokia.com> + + Reviewed by Kenneth Rohde Christiansen. + + [Qt] Implement the display() method of the layout test controller + https://bugs.webkit.org/show_bug.cgi?id=34258 + + * DumpRenderTree/qt/DumpRenderTreeQt.cpp: + (WebCore::DumpRenderTree::DumpRenderTree): + (WebCore::DumpRenderTree::showPage): + (WebCore::DumpRenderTree::hidePage): + * DumpRenderTree/qt/DumpRenderTreeQt.h: + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::reset): + (LayoutTestController::display): + * DumpRenderTree/qt/LayoutTestControllerQt.h: + +2010-01-28 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Shinichiro Hamaji. + + Eliminated the filename parameter from functions in + check-webkit-style's cpp.py where it is no longer used. + + https://bugs.webkit.org/show_bug.cgi?id=34249 + + * Scripts/webkitpy/style/processors/cpp.py: + - Reduced number of occurrences of "filename" variable from + approximately 200 to 120. + + * Scripts/webkitpy/style/processors/cpp_unittest.py: + - Refactored unit tests as necessary to accommodate changes to cpp.py. + - Fixed bug in CppStyleTestBase.perform_include_what_you_use() + where the incorrect file extension was getting passed to + cpp_style.check_language(). + +2010-01-28 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Shinichiro Hamaji. + + In check-webkit-style, eliminated the dependency of + processors/cpp_unittest.py on checker.py. + + https://bugs.webkit.org/show_bug.cgi?id=34205 + + * Scripts/webkitpy/style/checker.py: + - Addressed FIXME by removing STYLE_CATEGORIES data. + - Added style_categories(). + + * Scripts/webkitpy/style/checker_unittest.py: + - Minor changes. + + * Scripts/webkitpy/style/processors/cpp.py: + - Added categories attribute to CppProcessor class (data + was originally checker.STYLE_CATEGORIES). + + * Scripts/webkitpy/style/processors/cpp_unittest.py: + - Addressed FIXME by eliminating "import" from checker.py. + +2010-01-28 Anton Muhin <antonm@chromium.org> + + Reviewed by Shinichiro Hamaji. + + Improve treatment of conditions and rest of the line for if, else, switch and alikes + https://bugs.webkit.org/show_bug.cgi?id=34173 + + * Scripts/webkitpy/style/cpp_style.py: + * Scripts/webkitpy/style/cpp_style_unittest.py: + +2010-01-28 Joe Mason <jmason@rim.com> + + Reviewed by Adam Barth. + + Limit login retries to 5 + https://bugs.webkit.org/show_bug.cgi?id=34193 + + * Scripts/webkitpy/bugzilla.py: + +2010-01-27 Martin Robinson <mrobinson@webkit.org> + + Adding myself to the committer list. No review necessary. + + * Scripts/webkitpy/committers.py: + +2010-01-27 George Wright <gwright@rim.com> + + Reviewed by Adam Treat. + + https://bugs.webkit.org/show_bug.cgi?id=34216 + + Add missing include for wtf/Platform.h + + * DumpRenderTree/AccessibilityController.h: + +2010-01-27 Diego Gonzalez <diego.gonzalez@openbossa.org> + + Reviewed by Kenneth Rohde Christiansen. + + [Qt] DRT Provide worker thread ability to track counters + https://bugs.webkit.org/show_bug.cgi?id=34221 + + Implement workerThreadCount() in LayoutTestController of Qt DRT + + Tests: + fast/workers/dedicated-worker-lifecycle.html + fast/workers/shared-worker-frame-lifecycle.html + fast/workers/shared-worker-lifecycle.html + fast/workers/worker-lifecycle.html + + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::workerThreadCount): + * DumpRenderTree/qt/LayoutTestControllerQt.h: + +2010-01-27 Kenneth Rohde Christiansen <kenneth@webkit.org> + + Rubberstamped by Simon Hausmann. + + [Qt] QtLauncher refactoring: + + Make the LauncherWindow depend less on the view, so that more + code can be shared in near future. + + * QtLauncher/main.cpp: + (LauncherWindow::sendTouchEvent): + (LauncherWindow::loadFinished): + (LauncherWindow::zoomIn): + (LauncherWindow::zoomOut): + (LauncherWindow::resetZoom): + (LauncherWindow::toggleZoomTextOnly): + (LauncherWindow::dumpHtml): + (LauncherWindow::selectElements): + (LauncherWindow::setupUI): + +2010-01-27 Kinuko Yasuda <kinuko@chromium.org> + + Reviewed by Eric Seidel. + + Correctly handle the KeyLocation argument that has been introduced + recently to test location-dependent key events in EventSender.keyDown. + http://bugs.webkit.org/show_bug.cgi?id=28247 + + Test: fast/events/keydown-numpad-keys.html + + * DumpRenderTree/gtk/EventSender.cpp: + (keyDownCallback): + +2010-01-27 Kenneth Rohde Christiansen <kenneth@webkit.org> + + Rubberstamped by Simon Hausmann. + + [Qt] QtLauncher refactoring: + + Move out code from the MainWindow (renamed to LauncherWindow) + that is not depending on the view, and add it to a new class + called MainWindow. + + * QtLauncher/QtLauncher.pro: + * QtLauncher/main.cpp: + (LauncherWindow::LauncherWindow): + (LauncherWindow::eventFilter): + (LauncherWindow::loadStarted): + (LauncherWindow::loadFinished): + (LauncherWindow::newWindow): + (LauncherWindow::setupUI): + (WebPage::createWindow): + (main): + * QtLauncher/mainwindow.cpp: Added. + (MainWindow::MainWindow): + (MainWindow::buildUI): + (MainWindow::page): + (MainWindow::setAddressUrl): + (MainWindow::addCompleterEntry): + (MainWindow::load): + (MainWindow::changeLocation): + (MainWindow::openFile): + * QtLauncher/mainwindow.h: Added. + +2010-01-27 Kenneth Rohde Christiansen <kenneth@webkit.org> + + Rubberstamped by Simon Hausmann. + + [Qt] QtLauncher, coding style fixes. + + * QtLauncher/main.cpp: + (MainWindow::MainWindow): + (MainWindow::sendTouchEvent): + (MainWindow::eventFilter): + (MainWindow::loadURL): + (MainWindow::setupUI): + (WebPage::createPlugin): + +2010-01-27 Kenneth Rohde Christiansen <kenneth@webkit.org> + + Rubberstamped by Simon Hausmann. + + [Qt] QtLauncher refactoring, separating the webview and + adding a QGraphicsWebView based version. + + * QtLauncher/QtLauncher.pro: + * QtLauncher/main.cpp: + (MainWindow::MainWindow): + * QtLauncher/webpage.h: + * QtLauncher/webview.cpp: Added. + (createContextMenu): + (WebViewGraphicsBased::mousePressEvent): + (WebViewTraditional::mousePressEvent): + (WebViewGraphicsBased::contextMenuEvent): + (WebViewTraditional::contextMenuEvent): + * QtLauncher/webview.h: Added. + (WebViewGraphicsBased::WebViewGraphicsBased): + (WebViewTraditional::WebViewTraditional): + +2010-01-27 Alexander Pavlov <apavlov@chromium.org> + + Adding myself as committer. No review necessary. + + * Scripts/webkitpy/committers.py: + +2010-01-27 Eric Seidel <eric@webkit.org> + + Reviewed by Darin Adler. + + webkit-patch needs an open-bugs command + https://bugs.webkit.org/show_bug.cgi?id=30793 + + * Scripts/test-webkitpy: import OpenBugsTest + * Scripts/webkit-patch: import OpenBugs + * Scripts/webkitpy/commands/download_unittest.py: don't import unittest + * Scripts/webkitpy/commands/early_warning_system_unittest.py: ditto + * Scripts/webkitpy/commands/queries_unittest.py: ditto + * Scripts/webkitpy/commands/queues_unittest.py: ditto + * Scripts/webkitpy/commands/upload_unittest.py: ditto + * Scripts/webkitpy/mock_bugzillatool.py: log when user.open_url is called. + +2010-01-27 Kenneth Rohde Christiansen <kenneth@webkit.org> + + Rubberstamped by Simon Hausmann + + [Qt] QtLauncher refactoring, separating utility methods. + + * QtLauncher/QtLauncher.pro: + * QtLauncher/main.cpp: + * QtLauncher/utils.cpp: Added. + (urlFromUserInput): + * QtLauncher/utils.h: Added. + +2010-01-27 Kenneth Rohde Christiansen <kenneth@webkit.org> + + Rubberstamped by Simon Hausmann + + [Qt] Refactor the code in the QtLauncher dealing with HTTP proxy. + + * QtLauncher/main.cpp: + (MainWindow::MainWindow): + * QtLauncher/webpage.cpp: + (WebPage::WebPage): + (WebPage::applyProxy): + * QtLauncher/webpage.h: + +2010-01-26 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> + + Reviewed by Tor Arne Vestbø. + + [Qt] Corrects debug build of DumpRenderTree on Windows. + + * DumpRenderTree/qt/DumpRenderTree.pro: + +2010-01-26 Daniel Bates <dbates@webkit.org> + + Reviewed by Adam Barth. + + https://bugs.webkit.org/show_bug.cgi?id=34070 + + Moves the try/catch for OSError exceptions in Executive.run_command + to Credentials.read_credentials() so that the unit test + webkitpy.scm_unittest.SCMClassTests.test_error_handlers can + assert that Executive.run_command throws an OSError exception. + + * Scripts/webkitpy/credentials.py: + * Scripts/webkitpy/executive.py: Moved try/catch for OSError to + method Credentials.read_credentials(). + * Scripts/webkitpy/executive_unittest.py: Removed tests that no longer + apply: test_run_command_with_bad_command_check_return_code and + test_run_command_with_bad_command_check_calls_error_handler. Added new + test to assert that run_command throws OSError exceptions. + +2010-01-26 Diego Gonzalez <diego.gonzalez@openbossa.org> + + Reviewed by Kenneth Rohde Christiansen. + + [Qt] DRT WebHistory support + https://bugs.webkit.org/show_bug.cgi?id=34167 + + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::reset): + (LayoutTestController::webHistoryItemCount): + (LayoutTestController::keepWebHistory): + * DumpRenderTree/qt/LayoutTestControllerQt.h: + +2010-01-26 Kent Tamura <tkent@chromium.org> + + Reviewed by Eric Seidel. + + [Win] Add modifiers parameter support to Windows DumpRenderTree + https://bugs.webkit.org/show_bug.cgi?id=34068 + + Add support for functional name modifiers; "addSelectionKey" and + "rangeSelectionKey", and modifiers parameter to eventSender.mouseDown() + and eventSender.mouseUp(). + This change is similar to r53498 for Mac. + + * DumpRenderTree/win/EventSender.cpp: + (buildModifierFlags): New function to set MK_CONTROL or MK_SHIFT to WPARAM. + (mouseDownCallback): Call buidlModifiersFlags(). + (mouseUpCallback): ditto. + (keyDownCallback): Add support for "addSelectionkey" and "rangeSelectionKey". + +2010-01-26 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Eric Seidel. + + The Python autoinstall cache directory now only gets created + in the directory containing autoinstall.py. + + https://bugs.webkit.org/show_bug.cgi?id=33365 + + * Scripts/webkitpy/autoinstall.py: + - Also added a README file to the cache directory saying + where it came from. + +2010-01-26 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Eric Seidel. + + Moved the check-webkit-style processors into a new + webkitpy/style/processors directory. + + https://bugs.webkit.org/show_bug.cgi?id=34060 + + * Scripts/webkitpy/style/checker.py: + * Scripts/webkitpy/style/checker_unittest.py: + * Scripts/webkitpy/style/cpp_style.py: Removed. + * Scripts/webkitpy/style/cpp_style_unittest.py: Removed. + * Scripts/webkitpy/style/processors: Added. + * Scripts/webkitpy/style/processors/__init__.py: Added. + * Scripts/webkitpy/style/processors/cpp.py: Copied from WebKitTools/Scripts/webkitpy/style/cpp_style.py. + * Scripts/webkitpy/style/processors/cpp_unittest.py: Copied from WebKitTools/Scripts/webkitpy/style/cpp_style_unittest.py. + * Scripts/webkitpy/style/processors/text.py: Copied from WebKitTools/Scripts/webkitpy/style/text_style.py. + * Scripts/webkitpy/style/processors/text_unittest.py: Copied from WebKitTools/Scripts/webkitpy/style/text_style_unittest.py. + * Scripts/webkitpy/style/text_style.py: Removed. + * Scripts/webkitpy/style/text_style_unittest.py: Removed. + * Scripts/webkitpy/style/unittests.py: + +2010-01-26 Kevin Ollivier <kevino@theolliviers.com> + + [wx] Build fix, make sure stub function returns a value. + + * DumpRenderTree/wx/LayoutTestControllerWx.cpp: + (LayoutTestController::counterValueForElementById): + +2010-01-26 Steve Falkenburg <sfalken@apple.com> + + Reviewed by Oliver Hunt. + + Windows build references non-existent include paths + https://bugs.webkit.org/show_bug.cgi?id=34175 + + * DumpRenderTree/win/DumpRenderTree.vcproj: + * DumpRenderTree/win/ImageDiff.vcproj: + * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: + +2010-01-26 Kenneth Rohde Christiansen <kenneth@webkit.org> + + Reviewed by Ariya Hidayat. + + [Qt] Separating out the UrlLoader from the QtLauncher in it's + own implementation and header file. + + * QtLauncher/main.cpp: + (main): + * QtLauncher/urlloader.cpp: Added. + (UrlLoader::UrlLoader): + (UrlLoader::loadNext): + (UrlLoader::init): + (UrlLoader::getUrl): + * QtLauncher/urlloader.h: Added. + +2010-01-25 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Shinichiro Hamaji. + + Refactored check-webkit-style by removing the file path + parameter from the style error handler functions. + + https://bugs.webkit.org/show_bug.cgi?id=34031 + + * Scripts/webkitpy/style/checker.py: + - Added _default_style_error_handler() to StyleChecker class. + - Moved handle_style_error() to inside _default_style_error_handler(). + + * Scripts/webkitpy/style/checker_unittest.py: + - Removed file path from calls to error handler. + + * Scripts/webkitpy/style/cpp_style.py: + - Removed file path from calls to error handler. + + * Scripts/webkitpy/style/cpp_style_unittest.py: + - Removed file path from calls to error handler. + + * Scripts/webkitpy/style/text_style.py: + - Removed file path from calls to error handler. + + * Scripts/webkitpy/style/text_style_unittest.py: + - Removed file path from calls to error handler. + +2010-01-25 Jeremy Orlow <jorlow@chromium.org> + + Adding myself as reviewer. No review necessary. + + * Scripts/webkitpy/committers.py: + +2010-01-25 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Adam Barth. + + Improved prepare-ChangeLog so that it preserves the relative + indentation of a git commit message. + + https://bugs.webkit.org/show_bug.cgi?id=34058 + + * Scripts/prepare-ChangeLog: + - Also adjusted the script so that it does not add white + space characters to empty lines. + +2010-01-24 Eric Seidel <eric@webkit.org> + + No review, rolling out r53763. + http://trac.webkit.org/changeset/53763 + https://bugs.webkit.org/show_bug.cgi?id=33895 + + Broke 20+ tests on Windows. + + * Scripts/run-webkit-tests: + * Scripts/webkitdirs.pm: + +2010-01-24 Adam Barth <abarth@webkit.org> + + Rubber stamped by Eric Seidel. + + More pep8 compliance. + + * Scripts/webkitpy/mock_bugzillatool.py: + +2010-01-24 Adam Barth <abarth@webkit.org> + + Rubber stamped by Eric Seidel. + + More pep8 compliance. + + * Scripts/webkitpy/executive.py: + * Scripts/webkitpy/grammar.py: + +2010-01-24 Adam Barth <abarth@webkit.org> + + Rubber stamped by Eric Seidel. + + More pep8 compliance. + + * Scripts/webkitpy/comments.py: + * Scripts/webkitpy/committers.py: + * Scripts/webkitpy/credentials.py: + +2010-01-24 Adam Barth <abarth@webkit.org> + + Rubber stamped by Eric Seidel. + + Make changelogs.py pass pep8. + + * Scripts/webkitpy/changelogs.py: + +2010-01-23 Kenneth Rohde Christiansen <kenneth@webkit.org> + + [Qt] Unreviewed build fix + + * QtLauncher/QtLauncher.pro: + * QtLauncher/webinspector.h: + +2010-01-23 Kenneth Rohde Christiansen <kenneth@webkit.org> + + Rubberstamped by Simon Hausmann. + + [Qt] Move the WebInspector class to it's own header file. + + * QtLauncher/main.cpp: + * QtLauncher/webinspector.h: Added. + (WebInspector::WebInspector): + (WebInspector::showEvent): + (WebInspector::hideEvent): + +2010-01-23 Robert Hogan <robert@roberthogan.net> + + Reviewed by Kenneth Rohde Christiansen. + + Qt DRT: respect window.close() and window.closed() + + Qt DRT needs to maintain a correct count of open windows + for windowCount(). It also needs to delete windows that + have been closed by window.close(). + + This fixes the following tests: + + plugins/destroy-during-npp-new.html + fast/dom/Document/early-document-access.html + fast/dom/Window/window-early-properties.html + fast/events/open-window-from-another-frame.html + fast/events/popup-blocking-click-in-iframe.html + + https://bugs.webkit.org/show_bug.cgi?id=32953 + + * DumpRenderTree/qt/DumpRenderTreeQt.cpp: + (WebCore::DumpRenderTree::DumpRenderTree): + (WebCore::DumpRenderTree::createWindow): + (WebCore::DumpRenderTree::windowCloseRequested): + * DumpRenderTree/qt/DumpRenderTreeQt.h: + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::maybeDump): + +2010-01-23 Dan Bernstein <mitz@apple.com> + + Reviewed by Mark Rowe. + + Added a user default for specifying a fallback frameworks path in case + the bundle does not contain frameworks for the current Mac OS X version. + + * WebKitLauncher/main.m: + (fallbackMacOSXVersion): Added. Looks up the fallback version in a dictionary + keyed by the FallbackSystemVersions user default and returns it. + (main): If a frameworks directory for the current system version is not found, + try the fallback. + +2010-01-22 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> + + Reviewed by Simon Hausmann. + + Make run-webkit-tests work under Cygwin for the Qt port + + setPathForRunningWebKitApp() is implemented for the Qt port + by using qmake to query for the location of the Qt libraries. + + This requires the original environment (%ENV) to be untouched, + so launchWithCurrentEnv() was refactored to launchWithEnv(), + and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV + instead. This has the added benefit of getting rid of the temp + variables used for storing the current env. + + openDumpTool() is also refactored a bit into platform-spesific, + port-spesific, and generic environment variables. + + Checks for undef was added a few places to fix Perl concat + warnings when run-webkit-tests is aborted. + + https://bugs.webkit.org/show_bug.cgi?id=33895 + + * Scripts/run-webkit-tests: + * Scripts/webkitdirs.pm: + +2010-01-22 Kevin Watters <kevinwatters@gmail.com> + + Reviewed by Kevin Ollivier. + + [wx] Remove the Bakefile build system, which is no longer being used. + + https://bugs.webkit.org/show_bug.cgi?id=34022 + + * DumpRenderTree/wx/DumpRenderTree.bkl: Removed. + * wx/browser/browser.bkl: Removed. + * wx/build-wxwebkit: Removed. + +2010-01-22 Gustavo Noronha Silva <gns@gnome.org> + + Reviewed by Simon Fraser. + + Reset zoom level to 1.0 when resetting view state. This is causing + many tests to fail after svg/custom/text-zoom.xhtml changes the + zoom level. + + * DumpRenderTree/gtk/DumpRenderTree.cpp: + (resetDefaultsToConsistentValues): + +2010-01-22 Steve Falkenburg <sfalken@apple.com> + + Reviewed by Darin Adler. + + https://bugs.webkit.org/show_bug.cgi?id=34025 + Enable client-based Geolocation abstraction for Mac, Windows AppleWebKit targets. + + * Scripts/build-webkit: + +2010-01-22 Adam Barth <abarth@webkit.org> + + Unreviewed. Arg. Someone renamed limit to output_limit on me. + + * Scripts/webkitpy/commands/queues.py: + +2010-01-22 Adam Barth <abarth@webkit.org> + + Rubber stamped by Eric Seidel. + + Make __init__.py and buildbot.py pass pep8 style checker. + + * Scripts/webkitpy/__init__.py: + * Scripts/webkitpy/buildbot.py: + +2010-01-21 Joe Mason <jmason@rim.com> + + Reviewed by Adam Barth. + + webkit-patch should retry on invalid password + https://bugs.webkit.org/show_bug.cgi?id=33955 + + Ask for bugs.webkit.org authentication in a loop. + + * Scripts/webkitpy/bugzilla.py: + +2010-01-22 Adam Barth <abarth@webkit.org> + + Unreviewed. Don't call seek on a NoneType. + + * Scripts/webkitpy/statusserver.py: + +2010-01-22 Petri Latvala <petri.latvala@nomovok.com> + + Reviewed by David Levin. + + check-webkit-style breaks on files with unknown types + https://bugs.webkit.org/show_bug.cgi?id=34001 + + For files with type FileType.NONE, dispatch_processor returns None. + + * Scripts/webkitpy/style/checker.py: Don't call process_file with a processor of value None. + +2010-01-22 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Make bugzilla.py and webkitport.py conform to pep8 + https://bugs.webkit.org/show_bug.cgi?id=34015 + + This patch makes webkitport.py and bugzilla.py mostly conform to PEP8 + style as enforced by pep8.py. I wasn't able to get rid of all the + errors because I'm not sure how to wrap some lines properly. Also, + there are a few deprication errors that I couldn't resolve easily. + However, this is a massive improvement in compliance. + + * Scripts/webkitpy/bugzilla.py: + * Scripts/webkitpy/webkitport.py: + +2010-01-22 Adam Barth <abarth@webkit.org> + + Reviewed by Darin Adler. + + Limit length of EWS results to 5MB + https://bugs.webkit.org/show_bug.cgi?id=34016 + + Hopefully this will fix the bug where the results link doesn't appear. + Our current theory is that the results blob is too big and the server + is rejecting the request with a 500 error. That causes us to re-try + the post, but when we re-try the StringIO buffer has its seek pointer + at the end. + + * Scripts/webkitpy/commands/queues.py: + * Scripts/webkitpy/statusserver.py: + +2010-01-22 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Adam Barth. + + Made check-webkit-style able to check patches when script not + run from source root. Also consolidated external references + to a single file. + + https://bugs.webkit.org/show_bug.cgi?id=33791 + + * Scripts/check-webkit-style: + - Changed to import style_references.py. + + * Scripts/webkitpy/style/__init__.py: + - Removed __path__ hack that allowed searching Scripts/ directory. + + * Scripts/webkitpy/style/checker.py: + - Changed to import style_references.py. + + * Scripts/webkitpy/style_references.py: Added. + +2010-01-22 Dmitry Titov <dimich@chromium.org> + + Reviewed by Maciej Stachowiak. + + Fix the leak of ThreadIdentifiers in threadMap across threads. + https://bugs.webkit.org/show_bug.cgi?id=32689 + + Add a new test to verify the ThreadIdentifiers are not reused across threads. + The test runs in the beginning of DumpRenderTree and spawns 2 non-WTF treads sequentially, + waiting for the previous thread to terminate before starting the next. + The treads use WTF::currentThread() in their thread function. Without a fix, this + causes both threads to have the same ThreadIdentifier which triggers ASSERT in thread function. + It also starts another thread using WTF. Without the fix, this finds pthread handle from previous + threads in the WTF threadMap and asserts in WTF::establishIdentifierForPthreadHandle(). + The test practically does not affect the DRT run time because the threads end immediately. + + * DumpRenderTree/mac/DumpRenderTree.mm: + (runThread): Test thread function. + (testThreadIdentifierMap): + (dumpRenderTree): + +2010-01-22 Kent Tamura <tkent@chromium.org> + + Reviewed by Maciej Stachowiak. + + Fix a bug that mouseDown:withModifiers: is never called. + https://bugs.webkit.org/show_bug.cgi?id=33989 + + * DumpRenderTree/mac/EventSendingController.mm: + (+[EventSendingController isSelectorExcludedFromWebScript:]): + (+[EventSendingController webScriptNameForSelector:]): + +2010-01-22 Kenneth Rohde Christiansen <kenneth@webkit.org> + + Rubberstamped by Antti Koivisto. + + [Qt] Separate out the WebPage class into it's own + cpp/header files. Also, removed the assumption that + the view is a QWebView, in preparation of a merger + of the two Qt WebKit launchers. + + * QtLauncher/QtLauncher.pro: + * QtLauncher/main.cpp: + (WebView::mousePressEvent): + * QtLauncher/webpage.cpp: Added. + (WebPage::supportsExtension): + (WebPage::extension): + (WebPage::acceptNavigationRequest): + (WebPage::openUrlInDefaultBrowser): + * QtLauncher/webpage.h: Added. + (WebPage::WebPage): + +2010-01-21 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Shinichiro Hamaji. + + Refactored to move file name and file-reading related code + from cpp_style.py and text_style.py to checker.py. + + https://bugs.webkit.org/show_bug.cgi?id=33775 + + * Scripts/check-webkit-style: + - Updates caused by changes to checker.py. + + * Scripts/webkitpy/style/checker.py: + - Added SKIPPED_FILES_WITH_WARNING list. + - Added SKIPPED_FILES_WITHOUT_WARNING list. + - Added FileType class. + - Added ProcessorDispatcher class. + - In StyleChecker class: + - Renamed process_patch() to check_patch(). + - Renamed process_file() to check_file(). + - Added _process_file(). + - Related refactoring. + - Addressed check_patch() FIXME to share code with process_file(). + + * Scripts/webkitpy/style/checker_unittest.py: + - Added ProcessorDispatcherSkipTest class. + - Added ProcessorDispatcherDispatchTest class. + - Added StyleCheckerCheckFileTest class. + + * Scripts/webkitpy/style/cpp_style.py: + - Renamed process_file_data() to _process_lines. + - Removed process_file() (moved logic to checker.py). + - Removed can_handle() (moved logic to checker.py). + - Added CppProcessor class. + - Removed is_exempt() (moved logic to checker.py). + - Added process_file_data() back as a wrapper function. + + * Scripts/webkitpy/style/cpp_style_unittest.py: + - Removed test_can_handle(). + - Removed test_is_exempt(). + - Added CppProcessorTest class. + + * Scripts/webkitpy/style/text_style.py: + - Added TextProcessor class. + - Removed process_file(). + - Removed can_handle(). + + * Scripts/webkitpy/style/text_style_unittest.py: + - Removed test_can_handle(). + - Added TextProcessorTest class. + +2010-01-21 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by David Kilzer. + + Create a unit-tested subroutine to parse patch files created + by svn-create-patch. + + https://bugs.webkit.org/show_bug.cgi?id=33475 + + * Scripts/VCSUtils.pm: + - Added parseDiff(). + - Added parsePatch(). + + * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Added. + - Added unit tests for parseDiff(). + + * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl: + - Total number of tests now computed dynamically. + + * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl: Added. + - Added unit tests for parsePatch(). + +2010-01-21 Kevin Ollivier <kevino@theolliviers.com> + + [wx] Build fix, add new directory to dir list. + + * wx/build/settings.py: + +2010-01-21 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Make the EWS transactional + https://bugs.webkit.org/show_bug.cgi?id=33978 + + Now if the EWS gets interrupted in the middle of processing a patch, + the bots will re-process the patch. + + * Scripts/test-webkitpy: + * Scripts/webkitpy/commands/queues.py: + * Scripts/webkitpy/commands/queues_unittest.py: + * Scripts/webkitpy/patchcollection.py: + * Scripts/webkitpy/patchcollection_unittest.py: Added. + +2010-01-21 Adam Barth <abarth@webkit.org> + + Unreviewed. Add missing "ago" for style in the status bubble. + + * QueueStatusServer/templates/statusbubble.html: + +2010-01-21 Adam Barth <abarth@webkit.org> + + Reviewed by David Levin. + + [style-queue] should not complain about identifier names with underscores under WebKit/gtk/webkit/ + https://bugs.webkit.org/show_bug.cgi?id=33356 + + White list unix_hacker_style names in WebKit/gtk/webkit because these + are used in the GTK+ API. + + * Scripts/webkitpy/style/cpp_style.py: + * Scripts/webkitpy/style/cpp_style_unittest.py: + +2010-01-21 Diego Gonzalez <diego.gonzalez@openbossa.org> + + Reviewed by Kenneth Rohde Christiansen. + + [Qt] add setDomainRelaxationForbiddenForURLScheme in Qt DRT + https://bugs.webkit.org/show_bug.cgi?id=33945 + + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::setDomainRelaxationForbiddenForURLScheme): + * DumpRenderTree/qt/LayoutTestControllerQt.h: + +2010-01-21 Simon Hausmann <simon.hausmann@nokia.com> + + No review, rolling out 53615 as it causes two + crashes on the bot. + + * DumpRenderTree/qt/DumpRenderTreeQt.cpp: + (WebCore::DumpRenderTree::DumpRenderTree): + (WebCore::DumpRenderTree::createWindow): + * DumpRenderTree/qt/DumpRenderTreeQt.h: + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::maybeDump): + +2010-01-21 Robert Hogan <robert@roberthogan.net> + + Reviewed by Simon Hausmann. + + Qt DRT: respect window.close() and window.closed() + + Qt DRT needs to maintain a correct count of open windows + for windowCount(). It also needs to delete windows that + have been closed by window.close(). + + This fixes the following tests: + + plugins/destroy-during-npp-new.html + fast/dom/Document/early-document-access.html + fast/dom/Window/window-early-properties.html + fast/events/open-window-from-another-frame.html + fast/events/popup-blocking-click-in-iframe.html + + https://bugs.webkit.org/show_bug.cgi?id=32953 + + * DumpRenderTree/qt/DumpRenderTreeQt.cpp: + (WebCore::DumpRenderTree::DumpRenderTree): + (WebCore::DumpRenderTree::createWindow): + (WebCore::DumpRenderTree::windowCloseRequested): + * DumpRenderTree/qt/DumpRenderTreeQt.h: + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::maybeDump): + +2010-01-20 Eric Seidel <eric@webkit.org> + + No review, rolling out r53593. + http://trac.webkit.org/changeset/53593 + https://bugs.webkit.org/show_bug.cgi?id=33496 + + Re-rollout this patch, the commit-queue should not have landed + it again, but it did due to land-diff and rollout both not + clearing flags. + + * Scripts/webkitpy/commands/early_warning_system.py: + * Scripts/webkitpy/commands/queues.py: + * Scripts/webkitpy/queueengine.py: + * Scripts/webkitpy/scm.py: + * Scripts/webkitpy/scm_unittest.py: + +2010-01-20 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + webkit-commit-queue status page is confusing + https://bugs.webkit.org/show_bug.cgi?id=33496 + + This should improve the status page by removing more Fail messages. + To do this, I re-factored the CommitQueue and the AbstractReviewQueues + to behave more like one another. This meant moving where the failure reporting was done. + Previously the AbstractReviewQueue always used the parent process to report the error, + while CommitQueue used the subprocess when possible, and the parent only reported errors + that we didn't know how to handle (bugs in the commit-queue itself). + Now the AbstractReviewQueue follow's the commit-queue's model. This got rid of a try-block + in both implementations and required teaching handle_script_error in each to post Fail messages + to the status server instead of calling exit(1). + + This will also make the style-queue share more bug posting logic with other queues: + https://bugs.webkit.org/show_bug.cgi?id=33871 + + * Scripts/webkitpy/commands/early_warning_system.py: + - Don't exit(1) as that will cause the calling queue to also report Fail to the status server. + Implementors of handle_script_error are expected to update the status server if needed, but only exit if the error could not be handled. + So we instead pass patch_has_failed_this_queue=True to _update_status_for_script_error in the case that this was a real failure. + _update_status_for_script_error knows how to post the Fail message to the status server. + - Teach _update_status_for_script_error how to post Fail messages to the status server. + * Scripts/webkitpy/commands/queues.py: + - Remove the try block from process_work_item since the caller already has one. + - Only CC watchers on failure to cut down on commit-queue generated mail. + - handle_unexpected_error needs to mark _did_fail now that the try block is gone from process_work_item. + - Abstract _format_script_error_output_for_bug to share code between all queues. + - The new _format_script_error_output_for_bug allows the style-queue to share the posting limit with other queues, as well as support linking to the full output. + - Rename _can_build_and_test to _current_checkout_builds_and_passes_tests to better explain what revision it's testing. + - Move logging out of _can_build_and_test and make the logs explain what revision we're testing. + - handle_script_error now posts Fail instead of the try block in process_work_item handling it. + * Scripts/webkitpy/queueengine.py: + - QueueEngine is no longer used just by the commit-queue, update the logging to say "processing" instead of landing. + * Scripts/webkitpy/scm.py: + - Add new checkout_revision function. + * Scripts/webkitpy/scm_unittest.py: + - Test our new checkout_revision function. + +2010-01-20 Fumitoshi Ukai <ukai@chromium.org> + + Reviewed by Alexey Proskuryakov. + + WebSocket: Missing Request-URI, when no tralling slash in host + https://bugs.webkit.org/show_bug.cgi?id=33689 + + Update pywebsocket to 0.4.7.1, which supports alias for resource + name, so that we could test for ws://127.0.0.1:8880 + + * Scripts/run-webkit-tests: + * Scripts/run-webkit-websocketserver: + * pywebsocket/mod_pywebsocket/dispatch.py: + * pywebsocket/mod_pywebsocket/handshake.py: + * pywebsocket/mod_pywebsocket/standalone.py: + * pywebsocket/setup.py: + * pywebsocket/test/test_dispatch.py: + * pywebsocket/test/test_handshake.py: + +2010-01-20 Eric Seidel <eric@webkit.org> + + No review, rolling out r53537. + http://trac.webkit.org/changeset/53537 + https://bugs.webkit.org/show_bug.cgi?id=33496 + + Added a failure condition to the commit-queue and looks to + have broken the EWS bots + + * Scripts/webkitpy/commands/early_warning_system.py: + * Scripts/webkitpy/commands/queues.py: + * Scripts/webkitpy/queueengine.py: + * Scripts/webkitpy/scm.py: + * Scripts/webkitpy/scm_unittest.py: + +2010-01-20 Jon Honeycutt <jhoneycutt@apple.com> + + MSAA: accSelect() is not implemented + + https://bugs.webkit.org/show_bug.cgi?id=33918 + <rdar://problem/7436861> + + Reviewed by Darin Adler. + + * DumpRenderTree/AccessibilityUIElement.cpp: + (takeFocusCallback): + Call the object's takeFocus() function. + (takeSelectionCallback): + Call its takeSelection() function. + (addSelectionCallback): + Call its addSelection() function. + (removeSelectionCallback): + Call its removeSelection() function. + (AccessibilityUIElement::getJSClass): + Add new functions to the JS class definition. + + * DumpRenderTree/AccessibilityUIElement.h: + Declare new functions. + + * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: + (AccessibilityUIElement::takeFocus): + Stubbed. + (AccessibilityUIElement::takeSelection): + Stubbed. + (AccessibilityUIElement::addSelection): + Stubbed. + (AccessibilityUIElement::removeSelection): + Stubbed. + + * DumpRenderTree/mac/AccessibilityUIElementMac.mm: + (AccessibilityUIElement::takeFocus): + Stubbed. + (AccessibilityUIElement::takeSelection): + Stubbed. + (AccessibilityUIElement::addSelection): + Stubbed. + (AccessibilityUIElement::removeSelection): + Stubbed. + + * DumpRenderTree/win/AccessibilityUIElementWin.cpp: + (AccessibilityUIElement::takeFocus): + Call the object's accSelect() function, passing the appropriate flag. + (AccessibilityUIElement::takeSelection): + Ditto. + (AccessibilityUIElement::addSelection): + Ditto. + (AccessibilityUIElement::removeSelection): + Ditto. + +2010-01-20 Andras Becsi <abecsi@inf.u-szeged.hu> + + Reviewed by Alexey Proskuryakov. + + Extract Apache handling to httpd.pm module and use the provided functionality + in scripts where Apache is needed. + The module httpd.pm stores the PID of Apache in a variable and cleans up + the PID directory after Apache properly shut down. Catching INT and TERM + signals allows the scripts to close Apache and clean up its PID directory + even if the testing was interrupted. + + https://bugs.webkit.org/show_bug.cgi?id=33153 + + * Scripts/webkitperl/httpd.pm: Added. + * Scripts/run-iexploder-tests: + * Scripts/run-webkit-httpd: + * Scripts/run-webkit-tests: + +2010-01-20 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> + + Reviewed by Simon Hausmann. + + [Qt] Make DumpRenderTree build on Windows + + * DumpRenderTree/qt/DumpRenderTree.pro: + * DumpRenderTree/qt/DumpRenderTreeQt.cpp: + * DumpRenderTree/qt/DumpRenderTreeQt.h: + * DumpRenderTree/qt/main.cpp: + +2010-01-20 Steve Block <steveblock@google.com> + + Reviewed by Eric Seidel. + + Fix commit bot to land patches in order of the bug last modification date. + https://bugs.webkit.org/show_bug.cgi?id=33395 + + * Scripts/webkitpy/bugzilla.py: Modified. Added 'order=Last+Changed' to bugzilla commit queue URL. + +2010-01-20 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Teach check-webkit-style about WebKit/gtk/tests + https://bugs.webkit.org/show_bug.cgi?id=33892 + + Removes false positives found in + https://bugs.webkit.org/show_bug.cgi?id=30883 + + * Scripts/webkitpy/style/cpp_style.py: + * Scripts/webkitpy/style/cpp_style_unittest.py: + +2010-01-20 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Teach check-webkit-style about QGVLauncher + https://bugs.webkit.org/show_bug.cgi?id=33890 + + Remove false positives found in + https://bugs.webkit.org/show_bug.cgi?id=33708 + + * Scripts/webkitpy/style/cpp_style.py: + * Scripts/webkitpy/style/cpp_style_unittest.py: + +2010-01-20 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + webkit-commit-queue status page is confusing + https://bugs.webkit.org/show_bug.cgi?id=33496 + + This should improve the status page by removing more Fail messages. + To do this, I re-factored the CommitQueue and the AbstractReviewQueues + to behave more like one another. This meant moving where the failure reporting was done. + Previously the AbstractReviewQueue always used the parent process to report the error, + while CommitQueue used the subprocess when possible, and the parent only reported errors + that we didn't know how to handle (bugs in the commit-queue itself). + Now the AbstractReviewQueue follow's the commit-queue's model. This got rid of a try-block + in both implementations and required teaching handle_script_error in each to post Fail messages + to the status server instead of calling exit(1). + + This will also make the style-queue share more bug posting logic with other queues: + https://bugs.webkit.org/show_bug.cgi?id=33871 + + * Scripts/webkitpy/commands/early_warning_system.py: + - Don't exit(1) as that will cause the calling queue to also report Fail to the status server. + Implementors of handle_script_error are expected to update the status server if needed, but only exit if the error could not be handled. + So we instead pass patch_has_failed_this_queue=True to _update_status_for_script_error in the case that this was a real failure. + _update_status_for_script_error knows how to post the Fail message to the status server. + - Teach _update_status_for_script_error how to post Fail messages to the status server. + * Scripts/webkitpy/commands/queues.py: + - Remove the try block from process_work_item since the caller already has one. + - Only CC watchers on failure to cut down on commit-queue generated mail. + - handle_unexpected_error needs to mark _did_fail now that the try block is gone from process_work_item. + - Abstract _format_script_error_output_for_bug to share code between all queues. + - The new _format_script_error_output_for_bug allows the style-queue to share the posting limit with other queues, as well as support linking to the full output. + - Rename _can_build_and_test to _current_checkout_builds_and_passes_tests to better explain what revision it's testing. + - Move logging out of _can_build_and_test and make the logs explain what revision we're testing. + - handle_script_error now posts Fail instead of the try block in process_work_item handling it. + * Scripts/webkitpy/queueengine.py: + - QueueEngine is no longer used just by the commit-queue, update the logging to say "processing" instead of landing. + * Scripts/webkitpy/scm.py: + - Add new checkout_revision function. + * Scripts/webkitpy/scm_unittest.py: + - Test our new checkout_revision function. + +2010-01-20 Adam Barth <abarth@webkit.org> + + Reviewed by Darin Adler. + + Exempt JavaScriptCore/qt/api from style checks + https://bugs.webkit.org/show_bug.cgi?id=33879 + + Apparently there is a JavaScriptCore API for Qt as well as a WebKit + API. + + * Scripts/webkitpy/style/cpp_style.py: + * Scripts/webkitpy/style/cpp_style_unittest.py: + +2010-01-19 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> + + Reviewed by Simon Hausmann. + + [Qt] Don't use QSocketNotifier in the DRT for reading stdin + + QSocketNotifier is not available on Windows. Instead we read + stdin synchronously after each test using signals and slots. + + * DumpRenderTree/qt/DumpRenderTreeQt.cpp: + * DumpRenderTree/qt/DumpRenderTreeQt.h: + * DumpRenderTree/qt/main.cpp: + +2010-01-19 Adam Barth <abarth@webkit.org> + + Rubber stamped by Eric Seidel. + + Move chromium-ews back to building release only to make the EWS faster. + + * Scripts/webkitpy/commands/early_warning_system.py: + +2010-01-17 Jon Honeycutt <jhoneycutt@apple.com> + + MSAA: The child <option> elements of a non-multiple <select> are not + exposed + + https://bugs.webkit.org/show_bug.cgi?id=33773 + <rdar://problem/7550556> + + Reviewed by Alice Liu. + + * DumpRenderTree/AccessibilityUIElement.cpp: + (getIsVisibleCallback): + Call the object's isVisible() function. + (getIsOffScreenCallback): + Ditto, for isOffScreen(). + (getIsCollapsedCallback): + Ditto, for isCollapsed(). + (getHasPopupCallback): + Ditto, for hasPopup(). + (AccessibilityUIElement::getJSClass): + Add isVisible and isOffScreen attributes. + + * DumpRenderTree/AccessibilityUIElement.h: + Declare new functions. + + * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: + (AccessibilityUIElement::isVisible): + Stubbed. + (AccessibilityUIElement::isOffScreen): + Stubbed. + (AccessibilityUIElement::isCollapsed): + Stubbed. + (AccessibilityUIElement::hasPopup): + Stubbed. + + * DumpRenderTree/mac/AccessibilityUIElementMac.mm: + (AccessibilityUIElement::isVisible): + Stubbed. + (AccessibilityUIElement::isOffScreen): + Stubbed. + (AccessibilityUIElement::isCollapsed): + Stubbed. + (AccessibilityUIElement::hasPopup): + Stubbed. + + * DumpRenderTree/win/AccessibilityUIElementWin.cpp: + (AccessibilityUIElement::showMenu): + Call the object's accDoDefaultAction() to show its popup menu. + (AccessibilityUIElement::isEnabled): + Check that the object does not have the "unavailable" state. + (AccessibilityUIElement::isVisible): + Check that the object does not have the "invisible" state. + (AccessibilityUIElement::isOffScreen): + Check whether the object has the "offscreen" state. + (AccessibilityUIElement::isCollapsed): + Check whether the object has the "collapsed" state. + (AccessibilityUIElement::hasPopup): + Check whether the object has the "has popup" state. + +2010-01-19 Victor Wang <victorw@chromium.org> + + Reviewed by Eric Seidel. + + Correct committer name. + https://bugs.webkit.org/show_bug.cgi?id=33868 + + * Scripts/webkitpy/committers.py: + +2010-01-19 Kent Tamura <tkent@chromium.org> + + Reviewed by Darin Adler. + + [DRT][Mac] Add modifiers parameter to eventSender.mouseDown() and eventSender.mouseUp() + https://bugs.webkit.org/show_bug.cgi?id=33783 + + Some listbox tests check selection behavior by click events with + "meta" or "shift" keys. Behaviors for such modifier keys are + platform-dependent. The new parameter of mouseDown() and mouseUp() + allows to specify not only concrete modifier keys such as + "shiftKey" "metaKey", but also functional names like + "addSelectionKey" "rangeSelectionKey". + + * DumpRenderTree/mac/EventSendingController.mm: + (+[EventSendingController isSelectorExcludedFromWebScript:]): + (+[EventSendingController webScriptNameForSelector:]): + (buildModifierFlags): + (-[EventSendingController mouseDown:withModifiers:]): + (-[EventSendingController mouseDown:]): + (-[EventSendingController mouseUp:withModifiers:]): + (-[EventSendingController mouseUp:]): + (-[EventSendingController keyDown:withModifiers:withLocation:]): + +2010-01-19 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Unbreak --request-commit + https://bugs.webkit.org/show_bug.cgi?id=33832 + + * Scripts/webkitpy/bugzilla.py: + +2010-01-19 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + validate-committer-lists throws exception and committers.py needs a refresh + https://bugs.webkit.org/show_bug.cgi?id=33831 + + * Scripts/validate-committer-lists: use webkit_logging + * Scripts/webkitpy/committers.py: Add recently minted committers. Fix Simon Hausmanns email address list to include his webkit-committers@lists address. + +2010-01-18 Adam Roben <aroben@apple.com> + + Add LayoutTestController support for calling new WebKit SPI to + disallow setting document.domain + + DRT part of fixing <http://webkit.org/b/33806> + <rdar://problem/7552837> Would like API to disallow setting of + document.domain for pages with certain URL schemes + + Reviewed by Sam Weinig. + + * DumpRenderTree/LayoutTestController.cpp: + (setDomainRelaxationForbiddenForURLSchemeCallback): Added. Calls + through to LayoutTestController. + (LayoutTestController::staticFunctions): Added + setDomainRelaxationForbiddenForURLScheme. + + * DumpRenderTree/LayoutTestController.h: Added + setDomainRelaxationForbiddenForURLScheme. + + * DumpRenderTree/mac/LayoutTestControllerMac.mm: + (LayoutTestController::setDomainRelaxationForbiddenForURLScheme): + * DumpRenderTree/win/LayoutTestControllerWin.cpp: + (LayoutTestController::setDomainRelaxationForbiddenForURLScheme): + Added. Calls through to WebKit. + + * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: + (LayoutTestController::setDomainRelaxationForbiddenForURLScheme): + * DumpRenderTree/wx/LayoutTestControllerWx.cpp: + (LayoutTestController::setDomainRelaxationForbiddenForURLScheme): + Stubbed out. + +2010-01-18 Adam Barth <abarth@webkit.org> + + Reviewed by Adam Roben. + + Rename patches-to-commit to patches-in-commit-queue + https://bugs.webkit.org/show_bug.cgi?id=33789 + + The command really lists the patches in the commit-queue not all the + patches that are pending-commit (as the FIXME commands). + + * Scripts/webkitpy/commands/queries.py: + * Scripts/webkitpy/commands/queries_unittest.py: + +2010-01-18 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> + + Reviewed by Simon Hausmann. + + [Qt] Force qmake to generate a single makefile for DerivedSources.pro + + * Scripts/webkitdirs.pm: + +2010-01-18 Adam Roben <aroben@apple.com> + + Clean up use of /useenv when invoking Visual C++ + + This change reverts things to their pre-r49485 state. That revision + (and, subsequently, r49664 and r51788) started passing /useenv to + Visual C++, even in cases where we don't want to do so (such as when + invoking Visual C++ Express), in the name of making the Chromium build + work. Now that Chromium isn't using buildVisualStudioProject or + pdevenv, we can put things back they way they were. + + Fixes <http://webkit.org/b/33797> build-webkit fails with VC++ Express + (due to /useenv flag) + + Reviewed by Sam Weinig. + + * Scripts/pdevenv: Always pass /useenv. Chromium doesn't use this + script anymore. + * Scripts/webkitdirs.pm: + (buildVisualStudioProject): Never pass /useenv anymore. pdevenv takes + care of this itself, and we don't want to pass /useenv when not using + pdevenv (e.g., when using VC++ Express, because that will cause it to + ignore the Platform SDK). + +2010-01-18 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + webkit-patch land-safely should obsolete old patches + https://bugs.webkit.org/show_bug.cgi?id=33788 + + When posting a commit-queue+ patch with land-safely, we should + obsolete the old patches on the bug. They're really confusing + because the main use case is to address reviewer feedback on a + previous patch. + + * Scripts/webkitpy/commands/upload.py: + * Scripts/webkitpy/commands/upload_unittest.py: + +2010-01-18 Adam Barth <abarth@webkit.org> + + Reviewed by David Levin. + + webkit-patch should authenticate more often + https://bugs.webkit.org/show_bug.cgi?id=33701 + + This makes it easier to work with security patches. + + * Scripts/webkitpy/bugzilla.py: + +2010-01-18 Adam Barth <abarth@webkit.org> + + Reviewed by Darin Adler. + + style checker needs to know about GObject-specific requirements + inside WebCore/bindings/gobject/ + https://bugs.webkit.org/show_bug.cgi?id=33606 + + Add an exception to the underscore rule for certain + GObject-specific names. + + * Scripts/webkitpy/style/cpp_style.py: + * Scripts/webkitpy/style/cpp_style_unittest.py: + +2010-01-18 Adam Barth <abarth@webkit.org> + + Reviewed by Shinichiro Hamaji. + + [check-webkit-style] does understand ResourceHandleWin.h + https://bugs.webkit.org/show_bug.cgi?id=32975 + + I'm not 100% convinced this fix is correct, but without more examples, + it's hard to generalize. We can always generalize the fix in the + future. + + * Scripts/webkitpy/style/cpp_style.py: + * Scripts/webkitpy/style/cpp_style_unittest.py: + +2010-01-18 Adam Barth <abarth@webkit.org> + + Unreviewed "build" fix. + + * Scripts/webkitpy/bugzilla.py: + +2010-01-18 Adam Barth <abarth@webkit.org> + + Unreviewed. Actually make land-safely mark commit-queue+ as + discussed with Eric. + + * Scripts/webkitpy/bugzilla.py: + * Scripts/webkitpy/steps/postdiffforcommit.py: + +2010-01-17 Adam Barth <abarth@webkit.org> + + Reviewed by Darin Adler. + + style-queue complains about one-line macros that include multiple statements + https://bugs.webkit.org/show_bug.cgi?id=33173 + + Add an exception for multiple statements on a line that starts a macro. + + * Scripts/webkitpy/style/cpp_style.py: + * Scripts/webkitpy/style/cpp_style_unittest.py: + +2010-01-17 Adam Barth <abarth@webkit.org> + + Reviewed by Darin Adler. + + [check-webkit-style] qt unit testing false positives + https://bugs.webkit.org/show_bug.cgi?id=32833 + + Exempt the Qt API and unit tests from the style checker. + + * Scripts/webkitpy/style/cpp_style.py: + * Scripts/webkitpy/style/cpp_style_unittest.py: + +2010-01-17 Adam Barth <abarth@webkit.org> + + Reviewed by Darin Adler. + + style-check script reports loads of errors on gtk2drawing.c + https://bugs.webkit.org/show_bug.cgi?id=33771 + + Exempt WebCore/platform/gtk/gtk2drawing.c and + WebCore/platform/gtk/gtk2drawing.h from style checks. + + * Scripts/webkitpy/style/cpp_style.py: + * Scripts/webkitpy/style/cpp_style_unittest.py: + +2010-01-17 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Shinichiro Hamaji. + + Finished eliminating _cpp_style_state global state variable from + check-webkit-style code and eliminating _CppStyleState class. + + https://bugs.webkit.org/show_bug.cgi?id=33764 + + * Scripts/webkitpy/style/checker.py: + - Minor updates caused by changes to cpp_style.py. + + * Scripts/webkitpy/style/cpp_style.py: + - Removed _CppStyleState class. + - Removed verbose_level functions. + - Added verbosity as a parameter to _FunctionState constructor. + - Added verbosity as a parameter to process_file(). + - Added verbosity as a parameter to process_file_data(). + + * Scripts/webkitpy/style/cpp_style_unittest.py: + - Added helper functions to set verbosity while running tests. + +2010-01-17 Adam Barth <abarth@webkit.org> + + Reviewed by Shinichiro Hamaji. + + check-webkit-style underscore check should be disabled for Qt methods starting with qt_ + https://bugs.webkit.org/show_bug.cgi?id=33663 + + * Scripts/webkitpy/style/cpp_style.py: + * Scripts/webkitpy/style/cpp_style_unittest.py: + +2010-01-17 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + style-queue complains about missing #include of config.h for non-WebCore projects + https://bugs.webkit.org/show_bug.cgi?id=33170 + + WebKitAPITests are consumers of the WebKit API and therefore do not + need to follow the same include discipline as the rest of WebKit. This + patch exempts them from the include checks. + + * Scripts/webkitpy/style/cpp_style.py: + * Scripts/webkitpy/style/cpp_style_unittest.py: + +2010-01-17 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + EWS (Early Warning Systems) should build both debug and release + https://bugs.webkit.org/show_bug.cgi?id=33681 + + Build both debug and release for chromium-ews. + + * Scripts/webkitpy/commands/early_warning_system.py: + +2010-01-17 Adam Barth <abarth@webkit.org> + + Reviewed by Darin Adler. + + style-queue should include instructions for how to file bugs against check-webkit-style + https://bugs.webkit.org/show_bug.cgi?id=32345 + + Added some text to the error message asking folks to file bugs against + false positives. + + * Scripts/webkitpy/commands/queues.py: + +2010-01-17 Chris Jerdonek <cjerdonek@webkit.org> + + Reviewed by Adam Barth. + + Eliminated the error_count global variable and related + check-webkit-style refactoring. + + https://bugs.webkit.org/show_bug.cgi?id=33678 + + * Scripts/check-webkit-style: + - Updated to use webkit_argument_defaults(). + - Renamed styleChecker to style_checker. + + * Scripts/webkitpy/style/checker.py: + - Prefixed the three default arguments with WEBKIT_DEFAULT. + - Added webkit_argument_defaults(). + - Added default filter_rules parameter to CategoryFilter constructor. + - Added __ne__() to CategoryFilter class. + - Added __eq__() and __ne__() to ProcessorOptions class. + - Added error_count and _write_error attributes to StyleChecker class. + - Made StyleChecker._handle_error() increment the error count. + + * Scripts/webkitpy/style/checker_unittest.py: + - Improved CategoryFilterTest.test_eq(). + - Added CategoryFilterTest.test_ne(). + - Added test_eq() and test_ne() to ProcessorOptionsTest class. + - Updated unit tests to use webkit_argument_defaults(). + - Added StyleCheckerTest class. + + * Scripts/webkitpy/style/cpp_style.py: + - Removed references to global error_count. + + * Scripts/webkitpy/style/cpp_style_unittest.py: + - Removed CppStyleStateTest class. + +2010-01-15 Jon Honeycutt <jhoneycutt@apple.com> + + get_accParent should try to retrieve parent AccessibilityObject, before + calling upon window + + https://bugs.webkit.org/show_bug.cgi?id=22893 + + Reviewed by Darin Adler. + + * DumpRenderTree/win/AccessibilityUIElementWin.cpp: + (AccessibilityUIElement::parentElement): + Get the object's parent. Query it for IAccessible, and return it. + +2010-01-16 Dan Bernstein <mitz@apple.com> + + Reviewed by Mark Rowe. + + <rdar://problem/7529519> DumpRenderTree crashes in makeLargeMallocFailSilently() + + * DumpRenderTree/mac/CheckedMalloc.cpp: + (makeLargeMallocFailSilently): Temporarily allow writing to the default + malloc zone structure while modifying it. + +2010-01-16 David Kilzer <ddkilzer@apple.com> + + Added back removed properties to iExploder input files + + While the update-iexploder-cssproperties script works great to + add new properties, it has the side-effect of removing old + properties that once were parsed. + + * iExploder/htdocs/cssproperties.in: Added back removed + properties into their own section. + * iExploder/htdocs/htmlattrs.in: Ditto. + +2010-01-16 Holger Hans Peter Freyther <zecke@selfish.org> + + Reviewed by David Kilzer. + + Update iExploder/htdocs/*.in by running update-iexploder-cssproperties + https://bugs.webkit.org/show_bug.cgi?id=33756 + + * iExploder/htdocs/cssproperties.in: New CSS attributes + * iExploder/htdocs/htmlattrs.in: New HTML attributes + * iExploder/htdocs/htmltags.in: New HTML tags + +2010-01-15 Chris Jerdonek <chris.jerdonek@gmail.com> + + Reviewed by David Kilzer. + + Altered parseDiffHeader() to skip unrecognized lines and + other minor clean-ups. + + https://bugs.webkit.org/show_bug.cgi?id=33476 + + * Scripts/VCSUtils.pm: + - Changed parseDiffHeader() as follows: + - Skips over unrecognized lines. + - Addressed FIXME to remove substitution for "diff" line. + - Renamed "version" header hash key to "sourceRevision". + - Eliminated "copiedFromVersion" header hash key. + - Included "sourceRevision" also for copied files. + - Checks that copy revision number matches "sourceRevision". + - No longer returns $foundHeaderEnding. + - Dies if header ending not found. + - Diff header dividing line now always added. + + * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl: + - Made necessary changes in parseDiffHeader() unit tests. + - Shortened the file paths in some test cases. + +2010-01-14 Yuzo Fujishima <yuzo@google.com> + + Reviewed by Alexey Proskuryakov. + + Update pywebsocket to 0.4.6 + https://bugs.webkit.org/show_bug.cgi?id=32299 + The newer pywebsocket can handle more simultaneous connections. + + * pywebsocket/mod_pywebsocket/handshake.py: + * pywebsocket/mod_pywebsocket/standalone.py: + * pywebsocket/setup.py: + * pywebsocket/test/test_handshake.py: + +2010-01-14 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + REGRESSION(53133): commit-queue no longer rejects patches with invalid committers, instead it hangs + https://bugs.webkit.org/show_bug.cgi?id=33638 + + * Scripts/webkitpy/bugzilla.py: + - Add Bug.id() to match Attachment.id() + - Give Bug.reviewed_patches and commit_queued_patches the option to return patches with invalid committers/reviewers. + - Add back a missing variable to _validate_setter_email found by the new unit tests! + * Scripts/webkitpy/commands/queries.py: + - Add FIXMEs about the commands being confusingly named. + * Scripts/webkitpy/commands/queries_unittest.py: + - Update results to reflect the newly restructured mock bug cache. + * Scripts/webkitpy/commands/queues.py: + - Add a new _validate_patches_in_commit_queue method (this is what fixes the regression). + - Add a FIXME about eventually sorting the patches into some order. + * Scripts/webkitpy/commands/queues_unittest.py: + - Update results now that with the newly restructure mock bug cache we're testing cq+'d patches with an invalid committer. + * Scripts/webkitpy/commands/upload_unittest.py: + - Update results to match the newly restructured mock bug cache. + * Scripts/webkitpy/mock_bugzillatool.py: + - Restructure fetch_ methods to not use a manual list of ids, but rather use Bug and Attachment classes to make real queries from all of the Bugs. + - Add a few more attachments and bug dictionaries for use by the tests. + +2010-01-13 Diego Gonzalez <diego.gonzalez@openbossa.org> + + Reviewed by Kenneth Christiansen. + + [Qt] DRT missing setUserStyleSheetLocation and setUserStyleSheetEnabled in LayoutTestController + https://bugs.webkit.org/show_bug.cgi?id=33617 + + * DumpRenderTree/qt/DumpRenderTreeQt.cpp: + (WebCore::WebPage::resetSettings): + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::setUserStyleSheetLocation): + (LayoutTestController::setUserStyleSheetEnabled): + * DumpRenderTree/qt/LayoutTestControllerQt.h: + +2010-01-14 Adam Roben <aroben@apple.com> + + Add LayoutTestController API to force + -webView:resource:willSendRequest:: to return null + + Enables tests for <rdar://problem/7533333> <http://webkit.org/b/33533> + window.onload never fires if page contains an <iframe> with a bad + scheme or whose load is cancelled by returning null from resource load + delegate's willSendRequest + + Reviewed by Brady Eidson. + + * DumpRenderTree/LayoutTestController.cpp: + (LayoutTestController::LayoutTestController): Initialize new member. + (setWillSendRequestReturnsNullCallback): Call through to + LayoutTestController. + (LayoutTestController::staticFunctions): Added new function. + + * DumpRenderTree/LayoutTestController.h: Added + m_willSendRequestReturnsNull. + (LayoutTestController::willSendRequestReturnsNull): + (LayoutTestController::setWillSendRequestReturnsNull): + Added standard accessors. + + * DumpRenderTree/mac/ResourceLoadDelegate.mm: + (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): + * DumpRenderTree/win/ResourceLoadDelegate.cpp: + (ResourceLoadDelegate::willSendRequest): + Return null if LayoutTestController says to. + +2010-01-14 Kevin Ollivier <kevino@theolliviers.com> + + [wx] Build fix after removal of XBM support. + + * wx/build/settings.py: + +2010-01-14 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> + + Reviewed by Simon Hausmann. + + Add support for partial building on Symbian. + + The build happens in the source directory as out of source builds are + not supported by qmake for Symbian. + + Also the actual build isn't started but it is left to the developer + to choose the architecture/configuration. + + * Scripts/webkitdirs.pm: + +2010-01-14 Simon Hausmann <simon.hausmann@nokia.com> + + Reviewed by Kenneth Rohde Christiansen. + + Add support for "detecting" Symbian environments by either + looking for the EPOCROOT environment variable or via --symbian + being passed on the commandline. + + * Scripts/webkitdirs.pm: + +2010-01-14 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> + + Unreviewed. + + [Qt] Use a different Makefile names for sources generation and compilation. + This prevents Makefile overwriting when running build-webkit twice. + + * Scripts/webkitdirs.pm: + +2010-01-14 Andreas Kling <andreas.kling@nokia.com> + + Reviewed by Kenneth Rohde Christiansen. + + [Qt] Add an "alien_QLabel" classId for manual testing of alien widgets. + + https://bugs.webkit.org/show_bug.cgi?id=33373 + + * QtLauncher/main.cpp: + (WebPage::createPlugin): + +2010-01-14 Eric Seidel <eric@webkit.org> + + No review, rolling out r53249. + http://trac.webkit.org/changeset/53249 + https://bugs.webkit.org/show_bug.cgi?id=33617 + + This caused http/tests/security/local-user-CSS-from- + remote.html to fail on the Qt Release Build Bot. + + * DumpRenderTree/qt/DumpRenderTreeQt.cpp: + (WebCore::WebPage::resetSettings): + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::overridePreference): + * DumpRenderTree/qt/LayoutTestControllerQt.h: + +2010-01-14 Chris Jerdonek <chris.jerdonek@gmail.com> + + Reviewed by Shinichiro Hamaji. + + Moved error() from cpp_style.py to checker.py. + + https://bugs.webkit.org/show_bug.cgi?id=33620 + + * Scripts/check-webkit-style: + - Addressed FIXME to not set global state. + + * Scripts/webkitpy/style/checker.py: + - Added argument validation to ProcessorOptions constructor. + - Added should_report_error() to ProcessorOptions class. + - Removed set_options(). + - Added StyleChecker class. + + * Scripts/webkitpy/style/checker_unittest.py: + - Added unit test class for ProcessorOptions class. + - Added unit test to check that parse() strips white space. + + * Scripts/webkitpy/style/cpp_style.py: + - Removed "filter" and "output_format" methods. + - Removed should_print_error() and error() functions. + - Removed default parameter value from process_file(). + + * Scripts/webkitpy/style/cpp_style_unittest.py: + - Removed call to cpp_style._should_print_error(). + - Removed test_filter() and test_filter_appending(). + + * Scripts/webkitpy/style/text_style.py: + - Removed default parameter value from process_file(). + +2010-01-14 Diego Gonzalez <diego.gonzalez@openbossa.org> + + Reviewed by Kenneth Rohde Christiansen. + + [Qt] DRT missing setUserStyleSheetLocation and setUserStyleSheetEnabled in LayoutTestController + https://bugs.webkit.org/show_bug.cgi?id=33617 + + * DumpRenderTree/qt/DumpRenderTreeQt.cpp: + (WebCore::WebPage::resetSettings): + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::setUserStyleSheetLocation): + (LayoutTestController::setUserStyleSheetEnabled): + * DumpRenderTree/qt/LayoutTestControllerQt.h: + +2010-01-13 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Fix CloseBugForLandDiff unittest to actually run + https://bugs.webkit.org/show_bug.cgi?id=33640 + + * Scripts/webkitpy/mock_bugzillatool.py: + * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py: + +2010-01-12 Jon Honeycutt <jhoneycutt@apple.com> + + MSAA: selected, selectable, extended selectable, and multiple + selectable states are not reported + + https://bugs.webkit.org/show_bug.cgi?id=33574 + <rdar://problem/7536826> + + Reviewed by Darin Adler. + + * DumpRenderTree/AccessibilityUIElement.cpp: + (getIsSelectableCallback): + Return the result of calling isSelectable(). + (getIsMultiSelectableCallback): + Return the result of calling isMultiSelectable(). + (AccessibilityUIElement::getJSClass): + Add isSelected and isMultiSelectable properties to the JSClass + definition. + + * DumpRenderTree/AccessibilityUIElement.h: + Declare isSelectable() and isMultiSelectable(). + + * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: + (AccessibilityUIElement::isSelectable): + Stubbed. + (AccessibilityUIElement::isMultiSelectable): + Stubbed. + + * DumpRenderTree/mac/AccessibilityUIElementMac.mm: + (AccessibilityUIElement::isSelectable): + Stubbed. + (AccessibilityUIElement::isMultiSelectable): + Stubbed. + + * DumpRenderTree/win/AccessibilityUIElementWin.cpp: + (accessibilityState): + Get the object's state, and return it. + (AccessibilityUIElement::isSelected): + Check the object's selected state. + (AccessibilityUIElement::isSelectable): + Check the object's selectable state. + (AccessibilityUIElement::isMultiSelectable): + Check the object's extended/multiple selectable state. + +2010-01-13 Adam Barth <abarth@webkit.org> + + Unreviewed. Repeat the below for CloseBugForLandDiff. + + * Scripts/test-webkitpy: + * Scripts/webkitpy/steps/closebugforlanddiff.py: + * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py: Added. + +2010-01-13 Adam Barth <abarth@webkit.org> + + Unreviewed. Turn the mac-ews status bubbles back on now that this bot + is running again. + + * QueueStatusServer/templates/statusbubble.html: + +2010-01-13 Adam Barth <abarth@webkit.org> + + Reviewed by Darin Adler. + + REGRESSION(53133): webkit-patch land dies if it can't find a bug id. + https://bugs.webkit.org/show_bug.cgi?id=33634 + + Deal with the case of no bug patch object in the state. + + * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py: + * Scripts/webkitpy/steps/updatechangelogswithreviewer.py: + +2010-01-13 Kenneth Russell <kbr@google.com> + + Unreviewed; added myself to the committers list. + + * Scripts/webkitpy/committers.py: + +2010-01-13 Darin Adler <darin@apple.com> + + Ignore compiled Python in more of webkitpy. + + * Scripts/webkitpy/commands: Added property svn:ignore. + * Scripts/webkitpy/steps: Added property svn:ignore. + * Scripts/webkitpy/style: Added property svn:ignore. + +2010-01-13 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> + + Reviewed by Simon Hausmann. + + [Qt] Fix build problem related to the pushd command + + * Scripts/webkitdirs.pm: + +2010-01-13 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> + + Reviewed by Simon Hausmann. + + [Qt] Split the build process in two different .pro files. + This allows qmake to be run once all source files are available. + + * Scripts/webkitdirs.pm: Add calls to make DerivedSources.pro in JSC and WC. + +2010-01-13 Shinichiro Hamaji <hamaji@chromium.org> + + Unreviewed tiny typo fix in docstrings. + + * Scripts/webkitpy/style/checker_unittest.py: + +2010-01-13 Chris Jerdonek <chris.jerdonek@gmail.com> + + Reviewed by Shinichiro Hamaji. + + Created a CategoryFilter class to encapsulate the logic of + filter rules. + + https://bugs.webkit.org/show_bug.cgi?id=33454 + + * Scripts/webkitpy/style/checker.py: + - Added CategoryFilter class. + + * Scripts/webkitpy/style/checker_unittest.py: + - Added CategoryFilter unit tests. + + * Scripts/webkitpy/style/cpp_style.py: + - Updated filter methods to use CategoryFilter. + + * Scripts/webkitpy/style/cpp_style_unittest.py: + - Updated references to filters. + +2010-01-12 Shinichiro Hamaji <hamaji@chromium.org> + + Unreviewed. Now I can review :) + + * Scripts/webkitpy/committers.py: + +2010-01-12 Brent Fulgham <bfulgham@webkit.org> + + Reviewed by Darin Adler. + + Extend WinLauncher example with better printing features. + + * WinLauncher/PrintWebUIDelegate.cpp: + (PrintWebUIDelegate::webViewPrintingMarginRect): Provide slightly + larger margins. + (PrintWebUIDelegate::webViewHeaderHeight): Compute header height based + on text metrics. + (PrintWebUIDelegate::webViewFooterHeight): Compute footer height based + on text metrics. + (PrintWebUIDelegate::drawHeaderInRect): Write useful header, along + with separating line. + (PrintWebUIDelegate::drawFooterInRect): + * WinLauncher/PrintWebUIDelegate.h: Remove stubs. + * WinLauncher/WinLauncher.cpp: + (PrintView): Correct loop used to print individual pages. + Previously it started at 0, which is a wild-card to print all + pages at once. + +2010-01-12 Alexey Proskuryakov <ap@apple.com> + + Reviewed by Darin Adler. + + https://bugs.webkit.org/show_bug.cgi?id=33540 + Make it possible to build in debug mode with assertions disabled + + * DumpRenderTree/mac/ObjCController.m: (-[ObjCController accessStoredWebScriptObject]): + +2010-01-11 Darin Fisher <darin@chromium.org> + + Reviewed by Dimitri Glazkov. + + [Chromium] "build-webkit --chromium" should run "make all" on Linux + https://bugs.webkit.org/show_bug.cgi?id=33500 + + * Scripts/webkitdirs.pm: + +2010-01-12 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + AssignToCommitter does not need to fetch bugs twice + https://bugs.webkit.org/show_bug.cgi?id=33530 + + This is a no-brainer patch now that we've added Bug.reviewed_patches + + * Scripts/webkitpy/commands/upload.py: + +2010-01-12 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + bugzilla.py should have an Attachment object instead of passing around dictionaries + https://bugs.webkit.org/show_bug.cgi?id=31594 + + * Scripts/webkitpy/bugzilla.py: + - Add a new Attachment class, with accessor methods for all the necessary properties. + - Update Bug to carry a pointer back to bugzilla (attachments need to access Bugzilla for committer validation and url()) + - Move reviewed_patches and commit_queued_patches out of Bugzilla custom methods and onto Bug + - Move committer validation logic into its own class. + - Committer rejection is only used in one place. Make the new Bug reviewed_patches and commit_queued_patches + handle the common case (of returning "reviewer" or "committer" as None), and let CommitterValidation handle + the case where we want to reject patches in bugzilla. + - Simplify fetch_patches_from_commit_queue now that committer validation is simpler. + - Make all self.bugzilla.fetch_bug access go through BugzillaQueries._fetch_bug. + - Mark set_flag_on_attachment as non-private to denote that CommitterValidation depends on it. + - Move fetch_reviewed_patches_from_bug and fetch_commit_queue_patches_from_bug logic onto the Bug class. + * Scripts/webkitpy/bugzilla_unittest.py: + - Move test_flag_permission_rejection_message into a new CommitterValidationTest class. + * Scripts/webkitpy/commands/download.py: + - Store "bug_id" in state instead of making a fake patch object. + - Update to use Attachment and Bug objects. + * Scripts/webkitpy/commands/download_unittest.py: + - Update expected results now that our testing framework covers more code. + * Scripts/webkitpy/commands/early_warning_system.py: Update to use new Attachment class. + * Scripts/webkitpy/commands/queries.py: Remove unused ReviewedPatches class. + * Scripts/webkitpy/commands/queries_unittest.py: ditto. + * Scripts/webkitpy/commands/queues.py: Update to use new Attachment and CommitterValidator classes. + * Scripts/webkitpy/commands/queuestest.py: ditto. + * Scripts/webkitpy/commands/upload.py: ditto. + * Scripts/webkitpy/mock_bugzillatool.py: + - Now that more logic has moved into Attachment and Bug, we have to actually + provide real reviewer emails as well as real reviewer flags. + - Update mock methods to return Attachment objects. + * Scripts/webkitpy/scm.py: Update to use Attachment class. + * Scripts/webkitpy/scm_unittest.py: Update to use Attachment class. + * Scripts/webkitpy/statusserver.py: ditto. + * Scripts/webkitpy/steps/applypatch.py: ditto. + * Scripts/webkitpy/steps/applypatchwithlocalcommit.py: ditto. + * Scripts/webkitpy/steps/closebug.py: ditto. + * Scripts/webkitpy/steps/closebugforlanddiff.py: Handle either state["bug_id"] or state["patch"].bug_id() + * Scripts/webkitpy/steps/closepatch.py: Update to use Attachment class. + * Scripts/webkitpy/steps/obsoletepatches.py: ditto. + * Scripts/webkitpy/steps/updatechangelogswithreviewer.py: ditto. + +2010-01-12 Adam Barth <abarth@webkit.org> + + Unreviewed typo fix. :( + + * Scripts/webkitpy/commands/early_warning_system.py: + * Scripts/webkitpy/commands/queues.py: + +2010-01-12 Adam Barth <abarth@webkit.org> + + Unreviewed. Add "error" to the right part of the message. + + * Scripts/webkitpy/commands/queues.py: + +2010-01-12 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + EWS should show purple when svn-apply fails + https://bugs.webkit.org/show_bug.cgi?id=33527 + + * Scripts/webkitpy/commands/early_warning_system.py: + * Scripts/webkitpy/commands/queues.py: + +2010-01-12 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Remove copy/paste code from subclasses of AbstractReviewQueue + https://bugs.webkit.org/show_bug.cgi?id=33525 + + * Scripts/webkitpy/commands/early_warning_system.py: + * Scripts/webkitpy/commands/queues.py: + +2010-01-12 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Add Gustavo and Xan as gtk-ews watchers + https://bugs.webkit.org/show_bug.cgi?id=33519 + + * Scripts/webkitpy/commands/early_warning_system.py: + +2010-01-12 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + webkit-patch shouldn't waste my time for with a component prompt + https://bugs.webkit.org/show_bug.cgi?id=33521 + + The component field isn't very useful for bugs created with + webkit-patch because they're likely to be resolved quickly. Instead of + always prompting for a component, we should just default to the "New + Bugs" component. If the bug stays around for more than five minutes, + we can assign it a proper component. + + * Scripts/webkitpy/bugzilla.py: + +2010-01-12 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Add experimental "land-safely" command to webkit-patch + https://bugs.webkit.org/show_bug.cgi?id=33518 + + * Scripts/webkitpy/commands/upload.py: + * Scripts/webkitpy/commands/upload_unittest.py: + * Scripts/webkitpy/steps/__init__.py: + * Scripts/webkitpy/steps/postdiffforcommit.py: Added. + +2010-01-11 Kevin Ollivier <kevino@theolliviers.com> + + [wx] Build fix after introduction of JS_NO_EXPORT + + * wx/build/settings.py: + +2010-01-11 Eric Seidel <eric@webkit.org> + + No review, rolling out r53079. + http://trac.webkit.org/changeset/53079 + https://bugs.webkit.org/show_bug.cgi?id=33197 + + Adam doens't think this actually works, and believe it caused + a regression https://bugs.webkit.org/show_bug.cgi?id=33488 so + rolling this out. + + * Scripts/test-webkitpy: + * Scripts/webkitpy/commands/abstractdiffcommand.py: Removed. + * Scripts/webkitpy/commands/abstractdiffcommand_unittest.py: Removed. + * Scripts/webkitpy/commands/download.py: + * Scripts/webkitpy/commands/upload.py: + * Scripts/webkitpy/mock_bugzillatool.py: + +2010-01-10 Adam Barth <abarth@webkit.org> + + Reviewed by David Kilzer. + + bugzilla-tool submit-patch mistakenly picks up bug URLs in non-ChangeLog files + https://bugs.webkit.org/show_bug.cgi?id=33197 + + We should just search for bug numbers in the ChangeLogs instead of in + the whole diff. + + * Scripts/test-webkitpy: + * Scripts/webkitpy/commands/abstractdiffcommand.py: Added. + * Scripts/webkitpy/commands/abstractdiffcommand_unittest.py: Added. + * Scripts/webkitpy/commands/download.py: + * Scripts/webkitpy/commands/upload.py: + * Scripts/webkitpy/mock_bugzillatool.py: + +2010-01-11 Chris Jerdonek <chris.jerdonek@gmail.com> + + Reviewed by David Kilzer. + + Created a unit-tested function to parse the header block of + a Git or SVN diff -- for future refactoring of svn-apply and + svn-unapply. + + https://bugs.webkit.org/show_bug.cgi?id=33447 + + * Scripts/VCSUtils.pm: + - Added parseDiffHeader(). + - Removed irrelevant comment from gitdiff2svndiff(). + + * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl: Added. + - Added 48 unit tests for parseDiffHeader(). + +2010-01-10 Adam Barth <abarth@webkit.org> + + Rubber stamped by David Kilzer. + + bugzilla-tool submit-patch mistakenly picks up bug URLs in non-ChangeLog files + https://bugs.webkit.org/show_bug.cgi?id=33197 + + Fix a typo: Commmand -> Command. + + * Scripts/webkitpy/commands/abstractsequencedcommand.py: + * Scripts/webkitpy/commands/download.py: + * Scripts/webkitpy/commands/queries.py: + * Scripts/webkitpy/commands/upload.py: + * Scripts/webkitpy/multicommandtool.py: + +2010-01-10 Adam Barth <abarth@webkit.org> + + Reviewed by Darin Adler. + + Let webkit-patch work with options in $EDITOR + https://bugs.webkit.org/show_bug.cgi?id=33414 + + The $EDITOR evironment variable might have command line options like + bbedit -w. This patch lets us run those $EDITORs. + + * Scripts/webkitpy/user.py: + +2010-01-10 Robert Hogan <robert@roberthogan.net> + + Reviewed by Adam Barth. + + [Qt] Add enableXSSAuditor support to QWebSettings and DRT. + + https://bugs.webkit.org/show_bug.cgi?id=33419 + + * DumpRenderTree/qt/DumpRenderTreeQt.cpp: + (WebCore::WebPage::WebPage): + (WebCore::WebPage::resetSettings): + (WebCore::DumpRenderTree::createWindow): + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::setXSSAuditorEnabled): + * DumpRenderTree/qt/LayoutTestControllerQt.h: + +2010-01-10 Adam Barth <abarth@webkit.org> + + Unreviewed cosmetic change. Remove the status bubble for mac-ews + because we don't have hardware for it at the moment. + + * QueueStatusServer/templates/statusbubble.html: + +2010-01-09 Daniel Bates <dbates@webkit.org> + + No review, rolling out r53044. + http://trac.webkit.org/changeset/53044 + https://bugs.webkit.org/show_bug.cgi?id=33419 + + We need to look into this some more because the Qt + bot is failing the XSSAuditor tests. See bug #33419 + for more details. + + * DumpRenderTree/qt/DumpRenderTreeQt.cpp: + (WebCore::WebPage::WebPage): + (WebCore::WebPage::resetSettings): + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + * DumpRenderTree/qt/LayoutTestControllerQt.h: + +2010-01-09 Daniel Bates <dbates@webkit.org> + + Reviewed by Adam Barth. + + https://bugs.webkit.org/show_bug.cgi?id=33419 + + Adds support for the XSSAuditor to the Qt DRT. + + * DumpRenderTree/qt/DumpRenderTreeQt.cpp: + (WebCore::WebPage::WebPage): + (WebCore::WebPage::resetSettings): + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::setXSSAuditorEnabled): + * DumpRenderTree/qt/LayoutTestControllerQt.h: + +2010-01-09 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Retry writes to QueueStatusServer when we get 500 errors + https://bugs.webkit.org/show_bug.cgi?id=33412 + + This prevents the queues from failing to mark a patch as "pass" or + "fail" when AppEngine throws 500 errors. + + * Scripts/test-webkitpy: + * Scripts/webkitpy/networktransaction.py: Added. + * Scripts/webkitpy/networktransaction_unittest.py: Added. + * Scripts/webkitpy/statusserver.py: + * Scripts/webkitpy/steps/closebugformarkbugfixed.py: Added. + * Scripts/webkitpy/steps/closebugregardlessofpatches.py: Added. + * Scripts/webkitpy/steps/findbugidfromsvnrevision.py: Added. + +2010-01-09 David Kilzer <ddkilzer@apple.com> + + <http://webkit.org/b/33430> Fix rounded borders in queue status on older Firefox and Safari browsers + + Reviewed by Eric Seidel. + + * QueueStatusServer/templates/statusbubble.html: Added + -moz-border-radius and -webkit-border-radius to provide rounded + borders in older Firefox and Safari browsers. + +2010-01-09 Chris Jerdonek <chris.jerdonek@gmail.com> + + Reviewed by David Kilzer. + + Modified VCSUtils::gitdiff2svndiff() to accept strings that + end in vertical white space. + + https://bugs.webkit.org/show_bug.cgi?id=33415 + + * Scripts/VCSUtils.pm: + * Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl: + +2010-01-08 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + run-javascriptcore-tests needs a --quiet flag + https://bugs.webkit.org/show_bug.cgi?id=33399 + + Until run-javascriptcore-tests has a --quiet flag, lets just stiffle the output in webkit-patch. + + * Scripts/webkitpy/steps/runtests.py: + +2010-01-08 Andras Becsi <abecsi@inf.u-szeged.hu> + + Reviewed by Alexey Proskuryakov. + + Only run http and websocket tests as last if no argument is given to be able to explicitly control the test order. + + To be able to run multiple instances of run-webkit-tests besides each other on the same machine we need to minimize + the time when Apache and WebSocketServer is locked by tests. + Because closeHTTPD() and closeWebSocketServer() is only called at the end of the testing, + we need to run http and websocket tests after all other tests. + If one however explicitly specifies the tests to run in the argument list of run-webkit-tests + we need to preserve the given order. + + * Scripts/run-webkit-tests: + +2010-01-08 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Don't post style-queue pass messages to bugs + https://bugs.webkit.org/show_bug.cgi?id=33404 + + These messages aren't needed any more now that we have the status + bubble reporting pass events passively. + + * Scripts/webkitpy/commands/queues.py: + +2010-01-08 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Optimize the number of CPUs used for building Qt and Gtk + https://bugs.webkit.org/show_bug.cgi?id=33394 + + Instead of hardcoding the number 8, we should read the number of CPUs + from the environment. + + * Scripts/webkitpy/executive.py: + * Scripts/webkitpy/webkitport.py: + * Scripts/webkitpy/webkitport_unittest.py: + +2010-01-08 Chris Fleizach <cfleizach@apple.com> + + Reviewed by Eric Seidel. + + REGRESSION(52819?): AXLoadComplete and AXLayoutComplete causes 4 tests fail on Snow Leopard Debug bot + https://bugs.webkit.org/show_bug.cgi?id=33300 + + * DumpRenderTree/AccessibilityUIElement.h: + * DumpRenderTree/mac/AccessibilityUIElementMac.mm: + (AccessibilityUIElement::AccessibilityUIElement): + (AccessibilityUIElement::~AccessibilityUIElement): + (_accessibilityNotificationCallback): + (AccessibilityUIElement::addNotificationListener): + +2010-01-08 Eric Seidel <eric@webkit.org> + + Reviewed by Simon Hausmann. + + commit-queue should run run-javascriptcore-tests + https://bugs.webkit.org/show_bug.cgi?id=33376 + + I also made it run the python and perl unit tests. + + * Scripts/webkitpy/steps/runtests.py: + * Scripts/webkitpy/webkitport.py: + +2010-01-07 Andras Becsi <abecsi@inf.u-szeged.hu> + + Reviewed by Darin Adler. + + Run the http and websocket tests after all other tests. + https://bugs.webkit.org/show_bug.cgi?id=33153 + + * Scripts/run-webkit-tests: + +2010-01-07 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Fix some test-webkitpy expectations + https://bugs.webkit.org/show_bug.cgi?id=33345 + + I forgot to change these when I added the CheckStyle step. + + * Scripts/webkitpy/commands/upload_unittest.py: + +2010-01-07 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + webkit-patch edit-changelogs (or upload) will open blank files if run outside the root + https://bugs.webkit.org/show_bug.cgi?id=33341 + + Fix this by moving to the root directory before editing ChangeLogs. + There is a related bug with CheckStyle. + + * Scripts/webkitpy/steps/checkstyle.py: + * Scripts/webkitpy/steps/editchangelog.py: + +2010-01-07 Eric Seidel <eric@webkit.org> + + Reviewed by Nikolas Zimmermann. + + media/unsupported-tracks.html is failing on Snow Leopard Release bot + https://bugs.webkit.org/show_bug.cgi?id=32339 + + This is a speculative fix. I do not have a Snow Leopard machine to test on + and I've not seen mention of someone being able to reproduce this locally. + + Prevent watchdog timer from firing after a test completes but before + the next one starts, causing the error to appear in the next test. + + * DumpRenderTree/mac/DumpRenderTree.mm: + (dump): Stop the watchdog before printing #EOF for the test content. + We only need to care about the JavaScript of the test running too long + or some hang in WebCore. Any other failures will be covered by the calling + script's own watchdog timer. + +2010-01-07 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + commit-queue is stuck spinning due to exception + https://bugs.webkit.org/show_bug.cgi?id=33358 + + * Scripts/webkitpy/commands/queues.py: + - Don't try to stringify the exception. + +2010-01-07 Mark Rowe <mrowe@apple.com> + + Reviewed by Jon Honeycutt. + + Don't leak a JSStringRef within _accessibilityNotificationCallback. + + * DumpRenderTree/mac/AccessibilityUIElementMac.mm: + (_accessibilityNotificationCallback): Have a JSRetainPtr adopt the JSStringRef so that it will be cleaned up + when it goes out of scope. + +2010-01-07 Simon Fraser <simon.fraser@apple.com> + + Reviewed by Darin Adler. + + Add proposed rename of HTMLPlugInImageElement to HTMLEmbeddedObjectElement. + + * Scripts/do-webcore-rename: + +2010-01-07 Kim Grönholm <kim.gronholm@nomovok.com> + + Reviewed by Antti Koivisto. + + Wrong state and TouchLists in TouchEvents + https://bugs.webkit.org/show_bug.cgi?id=32878 + + * DumpRenderTree/qt/EventSenderQt.cpp: + (EventSender::touchStart): + (EventSender::touchEnd): + (EventSender::clearTouchPoints): + * DumpRenderTree/qt/EventSenderQt.h: + +2010-01-07 Chris Jerdonek <chris.jerdonek@gmail.com> + + Reviewed by Adam Barth. + + Created a module that runs the style package unit tests. + + https://bugs.webkit.org/show_bug.cgi?id=32973 + + * Scripts/test-webkitpy: + * Scripts/webkitpy/style/unittests.py: Added. + +2010-01-07 Adam Barth <abarth@webkit.org> + + Reviewed by Maciej Stachowiak. + + Don't print a redundant message when confirming a diff + https://bugs.webkit.org/show_bug.cgi?id=33315 + + Instead of saying "ERROR: User declined" we should just exit because + the use knows they just declined! + + * Scripts/webkitpy/steps/confirmdiff.py: + +2010-01-07 Adam Barth <abarth@webkit.org> + + Reviewed by Maciej Stachowiak. + + Check style before uploading a patch + https://bugs.webkit.org/show_bug.cgi?id=33314 + + * Scripts/webkitpy/commands/upload.py: + * Scripts/webkitpy/steps/checkstyle.py: + * Scripts/webkitpy/steps/options.py: + +2010-01-07 Adam Barth <abarth@webkit.org> + + Reviewed by Maciej Stachowiak. + + Add prepare and post to webkit-patch main help + https://bugs.webkit.org/show_bug.cgi?id=33313 + + * Scripts/webkitpy/commands/upload.py: + +2010-01-07 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + Add Chromium bots to the list of "core builders" (builders which stop the commit-queue when they turn red) + https://bugs.webkit.org/show_bug.cgi?id=33290 + + Add the Chromium builders to our list of core builders and test that our regexps work. + I also updated our regexp testing to make sure we cover all known builders at build.webkit.org. + + * Scripts/webkitpy/buildbot.py: + * Scripts/webkitpy/buildbot_unittest.py: + +2010-01-07 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + bugzilla-tool needs a new name + https://bugs.webkit.org/show_bug.cgi?id=28459 + + Rename bugzilla-tool to webkit-patch. Also, rename some commands to + make more sense with the new name. + + * Scripts/bugzilla-tool: Removed. + * Scripts/webkit-patch: Added. + * Scripts/webkit-tools-completion.sh: + * Scripts/webkitpy/bugzilla_unittest.py: + * Scripts/webkitpy/commands/download.py: + * Scripts/webkitpy/commands/download_unittest.py: + * Scripts/webkitpy/commands/early_warning_system.py: + * Scripts/webkitpy/commands/queries.py: + * Scripts/webkitpy/commands/queues.py: + * Scripts/webkitpy/commands/queues_unittest.py: + * Scripts/webkitpy/commands/upload.py: + * Scripts/webkitpy/commands/upload_unittest.py: + * Scripts/webkitpy/queueengine.py: + * Scripts/webkitpy/steps/completerollout.py: + +2010-01-07 Chris Jerdonek <chris.jerdonek@gmail.com> + + Reviewed by Eric Seidel. + + Moved style-related modules to webkitpy.style sub-package. + + https://bugs.webkit.org/show_bug.cgi?id=32971 + + * Scripts/check-webkit-style: + - Updated import statement. + + * Scripts/test-webkitpy: + - Updated import statements. + + * Scripts/webkitpy/cpp_style.py: Removed. + - Moved to webkitpy/style. + + * Scripts/webkitpy/cpp_style_unittest.py: Removed. + - Moved to webkitpy/style. + + * Scripts/webkitpy/style.py: Removed. + - Moved to webkitpy/style/checker.py. + + * Scripts/webkitpy/style/__init__.py: Added. + - Added containing webkitpy directory to package search path. + + * Scripts/webkitpy/style/checker.py: Copied from Scripts/webkitpy/style.py. + * Scripts/webkitpy/style/checker_unittest.py: Copied from Scripts/webkitpy/style_unittest.py. + - Updated import statement. + + * Scripts/webkitpy/style/cpp_style.py: Copied from Scripts/webkitpy/cpp_style.py. + * Scripts/webkitpy/style/cpp_style_unittest.py: Copied from Scripts/webkitpy/cpp_style_unittest.py. + - Update import statement. + + * Scripts/webkitpy/style/text_style.py: Copied from Scripts/webkitpy/text_style.py. + * Scripts/webkitpy/style/text_style_unittest.py: Copied from Scripts/webkitpy/text_style_unittest.py. + * Scripts/webkitpy/style_unittest.py: Removed. + - Moved to webkitpy/style/checker_unittest.py. + + * Scripts/webkitpy/text_style.py: Removed. + - Moved to webkitpy/style. + + * Scripts/webkitpy/text_style_unittest.py: Removed. + - Moved to webkitpy/style. + +2010-01-06 Kinuko Yasuda <kinuko@chromium.org> + + Reviewed by Eric Seidel. + + [Qt] Support the 3rd argument of EventSender.keyDown that + has been recently added to report keyLocation + (see also: https://bugs.webkit.org/show_bug.cgi?id=28247). + https://bugs.webkit.org/show_bug.cgi?id=33250 + + Test: fast/events/keydown-numpad-keys.html + + * DumpRenderTree/qt/EventSenderQt.cpp: + (EventSender::keyDown): + * DumpRenderTree/qt/EventSenderQt.h: + +2010-01-06 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + Add long_help for all common commands. + https://bugs.webkit.org/show_bug.cgi?id=33261 + + For now these long_helps are pretty basic. + These were all written to just explain the steps + that each command runs. This style long_help could + be made easier by using: + https://bugs.webkit.org/show_bug.cgi?id=33257 + + * Scripts/webkitpy/commands/download.py: + * Scripts/webkitpy/commands/queries.py: + +2010-01-06 Diego Gonzalez <diego.gonzalez@openbossa.org> + + Reviewed by Kenneth Christiansen. + + [Qt] Add page zooming support to Qt DumpRenderTree + https://bugs.webkit.org/show_bug.cgi?id=32898 + + Patch by Kim Grönholm <kim.gronholm@nomovok.com>, + Diego Gonzalez <diego.gonzalez@openbossa.org> and + Afonso Costa <afonso.costa@openbossa.org> + + * DumpRenderTree/qt/EventSenderQt.cpp: + (EventSender::zoomPageIn): + (EventSender::zoomPageOut): + * DumpRenderTree/qt/EventSenderQt.h: + +2010-01-06 Eric Seidel <eric@webkit.org> + + No review, just adding Mike Belshe's new bugzilla email at his request. + + * Scripts/webkitpy/committers.py: + +2010-01-06 Eric Seidel <eric@webkit.org> + + Unreviewed. Rolling out r52869 and r52853 due to bot + and local run-webkit-test failures + + REGRESSION(52854?) fast/workers/shared-worker-constructor.html failed on Leopard Build Bot + https://bugs.webkit.org/show_bug.cgi?id=33256 + + The original bug was https://bugs.webkit.org/show_bug.cgi?id=33153 + + * Scripts/run-webkit-tests: + +2010-01-06 Eric Seidel <eric@webkit.org> + + Unreviewed "build" fix. Just adding missing include. + + bugzilla-tool rollout --complete-rollout should make a nicer bug comment + https://bugs.webkit.org/show_bug.cgi?id=29212 + + * Scripts/webkitpy/steps/completerollout.py: + +2010-01-06 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + bugzilla-tool rollout --complete-rollout should make a nicer bug comment + https://bugs.webkit.org/show_bug.cgi?id=29212 + + * Scripts/webkitpy/bugzilla.py: + - Make reopen_bug robust against the bug already being open. + * Scripts/webkitpy/commands/download.py: + - Remove dead code from Rollout. + * Scripts/webkitpy/steps/completerollout.py: + - Improve the rollout comment. + +2010-01-06 Andras Becsi <abecsi@inf.u-szeged.hu> + + Reviewed by Darin Adler. + + Set isHttpdOpen to 0 if pidfile does not exist for some reason. + Speculative fix for https://bugs.webkit.org/show_bug.cgi?id=33256. + + * Scripts/run-webkit-tests: + +2010-01-06 Andras Becsi <abecsi@inf.u-szeged.hu> + + Reviewed by Darin Adler. + + Change hardcoded /tmp in run-webkit-tests to File::Spec->tmpdir(), + and remove the httpd's pidfile directory if httpd terminated. + + * Scripts/run-webkit-tests: + +2010-01-05 Chris Jerdonek <chris.jerdonek@gmail.com> + + Reviewed by David Levin. + + Refactored check-webkit-style's argument parser to not rely + on global state, and improved its error handling and unit + test coverage. + + https://bugs.webkit.org/show_bug.cgi?id=32966 + + * Scripts/check-webkit-style: + - Adjusted to use new argument parser. + + * Scripts/webkitpy/cpp_style.py: + - Changed _CppStyleState to accept an array of filter rules + instead of a comma-delimited string. + - Eliminated cpp_style._DEFAULT_FILTER_RULES. + - Eliminated cpp_style._USAGE. + + * Scripts/webkitpy/cpp_style_unittest.py: + - Updated test_filter() and test_default_filter(). + + * Scripts/webkitpy/style.py: + - Converted style._USAGE to create_usage(). + - Corrected usage instructions by removing 0 as a valid + --verbose flag value. + - Removed use_webkit_styles(). + - Added ProcessorOptions class. + - Added ArgumentDefaults class. + - Added ArgumentPrinter class. + - Removed parse_arguments and added ArgumentParser class. + - Moved exit_with_usage() and exit_with_categories() into + ArgumentParser. + - Refactored parse_arguments() as ArgumentParser.parse(). + - Improved parser error handling. + + * Scripts/webkitpy/style_unittest.py: + - Added DefaultArgumentsTest class. + - Addressed FIXME to check style.WEBKIT_FILTER_RULES + against style.STYLE_CATEGORIES. + - Added ArgumentPrinterTest class. + - Added ArgumentParserTest class and rewrote parser unit tests. + +2010-01-05 Adam Roben <aroben@apple.com> + + Test that it's safe to call IWebView::close when + IWebView::initWithFrame hasn't been called + + Part of <http://webkit.org/b/32827> Crash when calling + IWebView::close, then releasing the WebView, without calling + DestroyWindow + + Reviewed by Steve Falkenburg. + + * WebKitAPITest/tests/WebViewDestruction.cpp: + (WebKitAPITest::CloseWithoutInitWithFrame): Calls IWebView::close + without ever calling IWebView::initWithFrame and tests that we don't + crash or leak. + +2010-01-05 Adam Roben <aroben@apple.com> + + Add more WebViewDestruction tests + + Fixes <http://webkit.org/b/33216>. + + Reviewed by Eric Seidel. + + * WebKitAPITest/tests/WebViewDestruction.cpp: + (WebKitAPITest::NoInitWithFrame): + (WebKitAPITest::CloseThenDestroyViewWindow): + (WebKitAPITest::DestroyViewWindowThenClose): + (WebKitAPITest::DestroyHostWindow): + (WebKitAPITest::DestroyHostWindowThenClose): + (WebKitAPITest::CloseThenDestroyHostWindow): + Added these tests that exercise tearing down a WebView in various + ways, all of which we eventually want to have work. Some of them + currently crash or leak. + +2010-01-05 Robert Hogan <robert@roberthogan.net> + + Reviewed by Eric Seidel. + + [Qt] fix DRT link failures on --no-svg builds when only making changes to DRT + + If you're working from a --minimal or --no-svg build and make changes to the + DRT, then recompile, the build will fail. + + This is because the current behavior at build time is to assume that the + previous Qt build supported SVG and consequently delete libQtWebKit.so. + Unfortunately, just deleting libQtWebKit.so will not cause the library to + re-link. Instead the build will see libQtWebKit.so.4 and co., pass over the + linking phase, and attempt to link the DRT with libQtWebKit.so absent. This + results in a link failure on the DRT. + + Since re-linking libQtWebKit can take up to ten minutes and should be avoided + in cases where not actually required, remove the assumption that + the previous Qt build supported SVG, and amend the symbol detection to look for + a symbol name that is not present in SVG builds. Currently webkitdirs.pm looks + for 'SVGElement' but even non-SVG builds contain the symbol 'isSVGElement'. + + https://bugs.webkit.org/show_bug.cgi?id=32992 + + * Scripts/webkitdirs.pm: + +2010-01-05 Chris Jerdonek <chris.jerdonek@gmail.com> + + Reviewed by David Kilzer. + + Switched to generating list of Perl unit test files dynamically, + instead of explicitly. + + https://bugs.webkit.org/show_bug.cgi?id=33200 + + * Scripts/test-webkitperl: + +2010-01-05 Yael Aharon <yael.aharon@nokia.com> + + Reviewed by Kenneth Rohde Christiansen. + + [Qt] Reimplement EventSender::leapForward + https://bugs.webkit.org/show_bug.cgi?id=33114 + + Follow Windows implementation of leapForward. When leapForward is called, + messages are queued and posted after the timeout. A new event loop is created to + handle those messages and the additional messages that are created as a result. + + * DumpRenderTree/qt/DumpRenderTree.pro: + * DumpRenderTree/qt/EventSenderQt.cpp: + (EventSender::EventSender): + (EventSender::mouseDown): + (EventSender::mouseUp): + (EventSender::mouseMoveTo): + (EventSender::leapForward): + (EventSender::sendOrQueueEvent): + (EventSender::replaySavedEvents): + (EventSender::eventFilter): + * DumpRenderTree/qt/EventSenderQt.h: + +2010-01-05 Adam Barth <abarth@webkit.org> + + Reviewed by Darin Adler. + + Fix obscure queue crash in queueengine + https://bugs.webkit.org/show_bug.cgi?id=33196 + + Sometimes we get an exception that can't be stringified. For example: + + AttributeError: 'ParseError' object has no attribute 'msg' + + In these cases, the whole queue dies because we're in the global + exception handler. Instead of dieing here, we should just print a less + informative message to the console. We're already printing the whole + backtrace anyway, so there's not much point to stringifying the + exception anyway. + + * Scripts/webkitpy/queueengine.py: + +2010-01-05 Dominic Mazzoni <dmazzoni@google.com> + + Reviewed by Darin Adler. + + https://bugs.webkit.org/show_bug.cgi?id=32571 + + For an object with an aria role of "checkbox" or "radiobutton", + use the "aria-checked" attribute to determine if it's checked. + These changes add an isChecked() method to AccessibilityUIElement + so that we can check for this property from a layout test. + + * DumpRenderTree/AccessibilityUIElement.cpp: + (getIsCheckedCallback): + (AccessibilityUIElement::getJSClass): + * DumpRenderTree/AccessibilityUIElement.h: + * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: + (AccessibilityUIElement::isChecked): + * DumpRenderTree/mac/AccessibilityUIElementMac.mm: + (AccessibilityUIElement::isChecked): + * DumpRenderTree/win/AccessibilityUIElementWin.cpp: + (AccessibilityUIElement::isChecked): + +2010-01-05 David Levin <levin@chromium.org> + + Reviewed by Darin Adler. + + Having a comment for the #endif for a header guard is not required WebKit style. + https://bugs.webkit.org/show_bug.cgi?id=33214 + + * Scripts/webkitpy/cpp_style.py: removed the check and made the loop exit + early when it has all the needed information to continue. + * Scripts/webkitpy/cpp_style_unittest.py: removed the corresponding tests. + +2010-01-05 Adam Roben <aroben@apple.com> + + Share more code in the WebViewDestruction tests + + Part of <http://webkit.org/b/33212> Small fixes/improvements to + WebKitAPITest + + Reviewed by Sam Weinig. + + * WebKitAPITest/tests/WebViewDestruction.cpp: + (WebKitAPITest::createAndInitializeWebView): Renamed from + createWebView. Now initializes the HostWindow and returns the + WebView's HWND via an out-parameter. + (WebKitAPITest::finishWebViewDestructionTest): Added. Code came from + the CloseWithoutDestroyWindow test. + (WebKitAPITest::CloseWithoutDestroyViewWindow): Renamed from + CloseWithoutDestroyWindow and changed to use the new functions. + (WebKitAPITest::MainFrameAfterClose): Changed to use the new + functions. + (WebKitAPITest::NoCloseOrDestroyViewWindow): Renamed from + NoCloseOrDestroyWindow and changed to use the new functions. + +2010-01-05 Adam Roben <aroben@apple.com> + + Don't show HostWindows by default + + This was making WebKitAPITest very flashy as windows appeared and + disappeared. + + Part of <http://webkit.org/b/33212> Small fixes/improvements to + WebKitAPITest + + Reviewed by Sam Weinig. + + * WebKitAPITest/HostWindow.cpp: + (WebKitAPITest::HostWindow::initialize): Removed the WS_VISIBLE style + from the window. + +2010-01-05 Adam Roben <aroben@apple.com> + + Don't hang in WebKitAPITest if no messages have been posted + + Part of <http://webkit.org/b/33212> Small fixes/improvements to + WebKitAPITest + + Reviewed by Sam Weinig. + + * WebKitAPITest/tests/WebViewDestruction.cpp: + (WebKitAPITest::runMessagePump): Use PeekMessage instead of GetMessage + to avoid hanging if no messages have been posted. + +2010-01-05 Adam Roben <aroben@apple.com> + + Fix WebKitCreateInstance helper + + Part of <http://webkit.org/b/33212> Small fixes/improvements to + WebKitAPITest + + Reviewed by Sam Weinig. + + * WebKitAPITest/tests/WebViewDestruction.cpp: + (WebKitAPITest::WebKitCreateInstance): Pass the pointer straight + through, instead of taking its address. + +2010-01-04 Maciej Stachowiak <mjs@apple.com> + + Reviewed by Darin Fisher. + + Reorganize, document and rename OS() platform macros. + https://bugs.webkit.org/show_bug.cgi?id=33198 + + Adapt to name changes. + + * DumpRenderTree/DumpRenderTree.h: + * DumpRenderTree/config.h: + +2010-01-05 Chris Jerdonek <chris.jerdonek@gmail.com> + + Reviewed by Eric Seidel. + + Minor improvements to test-webkit-scripts, as suggested + by an earlier review. + + https://bugs.webkit.org/show_bug.cgi?id=33125 + + * Scripts/test-webkit-scripts: + - Used OptionParser class instead of getopt.getopt(). + - Created main() method for __main__ block. + - Enclosed functions in a class. + +2010-01-05 Chris Fleizach <cfleizach@apple.com> + + No review. Fix DRT breakage on Tiger/Leopard. + + Add ARIA "Live Region" support + https://bugs.webkit.org/show_bug.cgi?id=33117 + + * DumpRenderTree/mac/AccessibilityUIElementMac.mm: + +2010-01-04 Chris Fleizach <cfleizach@apple.com> + + Reviewed by Darin Adler. + + Add ARIA "Live Region" support + https://bugs.webkit.org/show_bug.cgi?id=33117 + + * DumpRenderTree/AccessibilityUIElement.cpp: + (indexOfChildCallback): + (boolAttributeValueCallback): + (stringAttributeValueCallback): + (addNotificationListenerCallback): + (AccessibilityUIElement::getJSClass): + * DumpRenderTree/AccessibilityUIElement.h: + * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: + (AccessibilityUIElement::indexOfChild): + (AccessibilityUIElement::stringAttributeValue): + (AccessibilityUIElement::boolAttributeValue): + (AccessibilityUIElement::addNotificationListener): + * DumpRenderTree/mac/AccessibilityUIElementMac.mm: + (AccessibilityUIElement::indexOfChild): + (AccessibilityUIElement::stringAttributeValue): + (AccessibilityUIElement::boolAttributeValue): + (_accessibilityNotificationCallback): + (AccessibilityUIElement::addNotificationListener): + * DumpRenderTree/win/AccessibilityUIElementWin.cpp: + (AccessibilityUIElement::indexOfChild): + (AccessibilityUIElement::stringAttributeValue): + (AccessibilityUIElement::boolAttributeValue): + (AccessibilityUIElement::addNotificationListener): + +2010-01-04 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + bugzilla-tool rollout should require a reason + https://bugs.webkit.org/show_bug.cgi?id=30810 + + * Scripts/webkitpy/changelogs.py: Add support for a reason, add auto-wrapping logic. + * Scripts/webkitpy/changelogs_unittest.py: Test reason support. + * Scripts/webkitpy/commands/download.py: rollout now requires a reason, remove unused BUGID argument + * Scripts/webkitpy/commands/download_unittest.py: pass required reason + * Scripts/webkitpy/steps/preparechangelogforrevert.py: pass reason to update_for_revert + +2010-01-04 Jon Honeycutt <jhoneycutt@apple.com> + + MSAA: <select> elements should broadcast value change events + + https://bugs.webkit.org/show_bug.cgi?id=33088 + + <rdar://problem/7332364> + + Reviewed by Darin Adler. + + * DumpRenderTree/AccessibilityController.cpp: + (logValueChangeEventsCallback): + Start logging value change events. + (AccessibilityController::getJSClass): + Add a "logValueChangeEvents" to the AccessibilityController's JS class + definition. + (AccessibilityController::resetToConsistentState): + Disable logging of value change events. + + * DumpRenderTree/AccessibilityController.h: + Declare setLogValueChangeEvents(), and add a member variable for the + value change event hook. + + * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: + (AccessibilityController::setLogValueChangeEvents): + Stubbed. + + * DumpRenderTree/mac/AccessibilityControllerMac.mm: + (AccessibilityController::setLogValueChangeEvents): + Stubbed. + + * DumpRenderTree/win/AccessibilityControllerWin.cpp: + (AccessibilityController::AccessibilityController): + Initialize new member var. + (AccessibilityController::~AccessibilityController): + Disable logging of value change events. + (logEventProc): + When we receive an EVENT_OBJECT_VALUECHANGE, log the name of the object + and its value. + (AccessibilityController::setLogValueChangeEvents): + If disabling logging, unhook the event, and clear the event hook + member var. Otherwise, query for the root element to enable + accessibility, and hook EVENT_OBJECT_VALUECHANGE. + +2010-01-04 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + long_help for submit-patch + https://bugs.webkit.org/show_bug.cgi?id=33184 + + * Scripts/webkitpy/commands/upload.py: + +2010-01-04 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + commit-queue can wrongly reject patches if the buildbots are behind + https://bugs.webkit.org/show_bug.cgi?id=30098 + + Check to make sure we can currently build and test before trying to + land a patch. + + * Scripts/webkitpy/commands/queues.py: + +2010-01-04 Adam Roben <aroben@apple.com> + + Add a test harness for the Windows WebKit API, and a few tests + + We currently only have tests for a handful of bugs regarding WebView + destruction, but more tests can easily be added later. Eventually + we'll run these tests as part of run-webkit-tests. + + Fixes <http://webkit.org/b/33167>. + + Reviewed by Sam Weinig. + + * WebKitAPITest/HostWindow.cpp: Added. + (WebKitAPITest::HostWindow::HostWindow): Initialize m_window. + (WebKitAPITest::HostWindow::~HostWindow): Destroy our window if + needed. + (WebKitAPITest::HostWindow::initialize): Create our window. + (WebKitAPITest::HostWindow::clientRect): Return our window's client + rect. + (WebKitAPITest::HostWindow::registerWindowClass): Does what it says. + (WebKitAPITest::HostWindow::wndProc): Just call through to + DefWindowProcW. + + * WebKitAPITest/HostWindow.h: Added. + (WebKitAPITest::HostWindow::window): Simple getter. + + * WebKitAPITest/Test.h: Added. This file defines some macros useful + for writing tests. + + * WebKitAPITest/TestsController.cpp: Added. + (WebKitAPITest::TestsController::TestsController): Initialize our + members. + (WebKitAPITest::TestsController::shared): Return the shared instance. + (WebKitAPITest::TestsController::runAllTests): Run a message pump + until a WM_QUIT message is received, then return whether all tests + succeeded. + (WebKitAPITest::TestsController::addTest): Add the test to m_tests and + start running tests soon. + (WebKitAPITest::TestsController::testFailed): Record the failure and + print a message about it to stdout. + (WebKitAPITest::TestsController::runNextTest): If we don't have any + tests to run, post a WM_QUIT message to stop the message pump. + Otherwise, run the test and print whether it passed, then schedule the + next test. + (WebKitAPITest::TestsController::runNextTestSoon): Set a 0-delay timer + to run the next test. + (WebKitAPITest::TestsController::registerWindowClass): Does what it + says. + (WebKitAPITest::TestsController::wndProc): If the runNextTestTimer + fired, call runNextTest(). Pass everything else through to + DefWindowProcW. + + * WebKitAPITest/TestsController.h: Added. + + * WebKitAPITest/WebKitAPITest.vcproj: Added. + + * WebKitAPITest/WebKitAPITestCommon.vsprops: Added. + + * WebKitAPITest/main.cpp: Added. + (main): (Mostly) just calls TestsController::runAllTests. + + * WebKitAPITest/tests/WebViewDestruction.cpp: Added. + (WebKitAPITest::WebKitCreateInstance): Helper function template to + call through to the real WebKitCreateInstance. + (WebKitAPITest::webViewCount): Helper function to call through to + IWebKitStatistics::webViewCount. + (WebKitAPITest::createWebView): Helper function to create a WebView + and put it inside a HostWindow. + (WebKitAPITest::runMessagePump): Helper function to run a message pump + for a specified number of milliseconds, or until a WM_QUIT message is + received. + (WebKitAPITest::CloseWithoutDestroyWindow): Test for + <http://webkit.org/b/32827>. + (WebKitAPITest::MainFrameAfterClose): Test for + <http://webkit.org/b/32868>. + (WebKitAPITest::NoCloseOrDestroyWindow): Test for + <http://webkit.org/b/33162>. + +2010-01-04 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> + + Reviewed by David Kilzer. + + Add support for Git's "diff.mnemonicprefix" config option to WebKitTools + + https://bugs.webkit.org/show_bug.cgi?id=32820 + + * Scripts/VCSUtils.pm: + * Scripts/svn-apply: + * Scripts/svn-unapply: + * Scripts/test-webkitperl: Run gitdiff2svndiff test + * Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl: Added. + * Scripts/webkitpy/diff_parser.py: + * Scripts/webkitpy/diff_parser_unittest.py: + +2010-01-04 Chris Jerdonek <chris.jerdonek@gmail.com> + + Reviewed by David Kilzer. + + Divided the Perl unit tests into separate files and put + them in a separate directory, and renamed test-webkit-perl + to test-webkitperl. + + https://bugs.webkit.org/show_bug.cgi?id=33124 + + * Scripts/VCSUtils.pm: + - Renamed generateRunPatchCommand() to generatePatchCommand(). + + * Scripts/VCSUtils_unittest.pl: Removed. + - Divided into three files in Scripts/webkitperl/VCSUtils_unittest. + + * Scripts/test-webkit-perl: Removed. + - Renamed to test-webkitperl. + + * Scripts/test-webkit-scripts: + - Updated paths to test-webkitpy and test-webkitperl. + + * Scripts/test-webkitperl: Copied from Scripts/test-webkit-perl. + - Added paths to new test files. + + * Scripts/webkitperl: Added. + * Scripts/webkitperl/VCSUtils_unittest: Added. + * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: Added. + * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl: Added. + * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl: Copied from Scripts/VCSUtils_unittest.pl. + +2010-01-04 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + Make bugzilla-tool rollout include a bug link in the ChangeLog entry + https://bugs.webkit.org/show_bug.cgi?id=33146 + + One more step towards better rollouts. + + * Scripts/webkitpy/changelogs.py: + * Scripts/webkitpy/changelogs_unittest.py: + * Scripts/webkitpy/steps/preparechangelogforrevert.py: + +2010-01-04 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Sort the step options + https://bugs.webkit.org/show_bug.cgi?id=33144 + + * Scripts/webkitpy/steps/options.py: + +2010-01-04 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + Need support for longer text in per-command help + https://bugs.webkit.org/show_bug.cgi?id=33143 + + Add some minimal additional help to land-diff and + pave the way for adding better help to all commands. + + * Scripts/webkitpy/commands/download.py: Add small amount of additional help to land-diff + * Scripts/webkitpy/multicommandtool.py: support long_help + * Scripts/webkitpy/multicommandtool_unittest.py: test long_help + +2010-01-04 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Add unit test for MarkBugFixed + https://bugs.webkit.org/show_bug.cgi?id=33142 + + MarkBugFixed is way behind in command technology, but it still needs a + unit test, as the FIXME commands. + + Also, remove mark-bug-fixed and create-bug from main help since we have + more modern commands to replace them. + + * Scripts/webkitpy/commands/upload.py: + * Scripts/webkitpy/commands/upload_unittest.py: + * Scripts/webkitpy/mock_bugzillatool.py: + +2010-01-04 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Add missing unit test for CommitMessageForCurrentDiff + https://bugs.webkit.org/show_bug.cgi?id=33141 + + * Scripts/webkitpy/commands/upload.py: + * Scripts/webkitpy/commands/upload_unittest.py: + +2010-01-04 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Remove raw_input from queues in favor of user.prompt + https://bugs.webkit.org/show_bug.cgi?id=33140 + + This lets up properly mock out the user interaction instead of hacking + around it with the options. + + * Scripts/webkitpy/commands/queues.py: + * Scripts/webkitpy/commands/queuestest.py: + +2010-01-04 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + bugzilla-tool should not require users to install mechanize + https://bugs.webkit.org/show_bug.cgi?id=32635 + + * Scripts/webkitpy/__init__.py: Add missing declaration for ClientForm (which mechanize requires). + +2010-01-04 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + bugzilla-tool should not require users to install mechanize + https://bugs.webkit.org/show_bug.cgi?id=32635 + + Use the nifty "autoinstall" module from Daniel Krech: + http://pypi.python.org/pypi/autoinstall/0.2 + http://code.google.com/p/pyautoinstall/ + It's available under a WebKit-compatible BSD license. + + * Scripts/webkitpy/__init__.py: + - bind "mechanize" to an autoinstall importer which will + auto-download mechanize if necessary. + * Scripts/webkitpy/autoinstall.py: Added. + * Scripts/webkitpy/bugzilla.py: use "mechanize" instead of webkit_mechanize + * Scripts/webkitpy/statusbot.py: ditto. + * Scripts/webkitpy/webkit_mechanize.py: Removed. + +2010-01-04 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + [bzt] Move AbstractSequencedCommand to a more general location + https://bugs.webkit.org/show_bug.cgi?id=33137 + + I do what the FIXME tell me to do. + + * Scripts/webkitpy/commands/abstractsequencedcommand.py: Added. + * Scripts/webkitpy/commands/download.py: + * Scripts/webkitpy/commands/upload.py: + +2010-01-04 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Rename StatusBot to StatusServer + https://bugs.webkit.org/show_bug.cgi?id=33139 + + It's not a bot. It's a server. + + * Scripts/bugzilla-tool: + * Scripts/webkitpy/bugzilla.py: + * Scripts/webkitpy/commands/early_warning_system.py: + * Scripts/webkitpy/commands/queues.py: + * Scripts/webkitpy/mock_bugzillatool.py: + * Scripts/webkitpy/queueengine.py: + * Scripts/webkitpy/statusbot.py: Removed. + +2010-01-04 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + [bzt] submit-pach should have a -o/--open option to open the bug after submit + https://bugs.webkit.org/show_bug.cgi?id=33136 + + Python makes this very easy. + + * Scripts/webkitpy/mock_bugzillatool.py: + * Scripts/webkitpy/steps/options.py: + * Scripts/webkitpy/steps/postdiff.py: + * Scripts/webkitpy/user.py: + +2010-01-04 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + [bzt] Move steps to a submodule + https://bugs.webkit.org/show_bug.cgi?id=33135 + + For great victory. This will probably introduce some regressions + because our test coverage isn't perfect, but I've tried to be careful. + + * Scripts/test-webkitpy: + * Scripts/webkitpy/buildsteps.py: Removed. + * Scripts/webkitpy/buildsteps_unittest.py: Removed. + * Scripts/webkitpy/commands/download.py: + * Scripts/webkitpy/commands/upload.py: + * Scripts/webkitpy/steps/__init__.py: Added. + * Scripts/webkitpy/steps/abstractstep.py: Added. + * Scripts/webkitpy/steps/applypatch.py: Added. + * Scripts/webkitpy/steps/applypatchwithlocalcommit.py: Added. + * Scripts/webkitpy/steps/build.py: Added. + * Scripts/webkitpy/steps/checkstyle.py: Added. + * Scripts/webkitpy/steps/cleanworkingdirectory.py: Added. + * Scripts/webkitpy/steps/cleanworkingdirectorywithlocalcommits.py: Added. + * Scripts/webkitpy/steps/closebug.py: Added. + * Scripts/webkitpy/steps/closebugforlanddiff.py: Added. + * Scripts/webkitpy/steps/closepatch.py: Added. + * Scripts/webkitpy/steps/commit.py: Added. + * Scripts/webkitpy/steps/completerollout.py: Added. + * Scripts/webkitpy/steps/confirmdiff.py: Added. + * Scripts/webkitpy/steps/createbug.py: Added. + * Scripts/webkitpy/steps/editchangelog.py: Added. + * Scripts/webkitpy/steps/ensurebuildersaregreen.py: Added. + * Scripts/webkitpy/steps/ensurelocalcommitifneeded.py: Added. + * Scripts/webkitpy/steps/metastep.py: Added. + * Scripts/webkitpy/steps/obsoletepatches.py: Added. + * Scripts/webkitpy/steps/options.py: Added. + * Scripts/webkitpy/steps/postdiff.py: Added. + * Scripts/webkitpy/steps/preparechangelog.py: Added. + * Scripts/webkitpy/steps/preparechangelogforrevert.py: Added. + * Scripts/webkitpy/steps/promptforbugortitle.py: Added. + * Scripts/webkitpy/steps/revertrevision.py: Added. + * Scripts/webkitpy/steps/runtests.py: Added. + * Scripts/webkitpy/steps/steps_unittest.py: Added. + * Scripts/webkitpy/steps/update.py: Added. + * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py: Added. + * Scripts/webkitpy/steps/updatechangelogswithreviewer.py: Added. + * Scripts/webkitpy/stepsequence.py: + +2010-01-04 Daniel Bates <dbates@webkit.org> + + Reviewed by Eric Seidel. + + https://bugs.webkit.org/show_bug.cgi?id=33097 + + Cleans up the File menu to better conform to the File menu in Safari + both in terms of options and keyboard shortcuts. Adds a "Quit" menu + options to close all open windows. Also, renames the Tools menu to + Develop. + + * QtLauncher/main.cpp: + (MainWindow::setupUI): + +2010-01-04 Daniel Bates <dbates@webkit.org> + + https://bugs.webkit.org/show_bug.cgi?id=33039 + + Unreviewed fix. + + * Scripts/webkitpy/credentials.py: + * Scripts/webkitpy/credentials_unittest.py: + +2010-01-04 Daniel Bates <dbates@webkit.org> + + Reviewed by Eric Seidel. + + https://bugs.webkit.org/show_bug.cgi?id=33039 + + [bzt] Second attempt to fix an issue where bugzilla-tool dies + when the keychain lookup fails to find an entry for bugs.webkit.org. + + * Scripts/webkitpy/credentials.py: + * Scripts/webkitpy/credentials_unittest.py: + +2010-01-04 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + Make Rollout an AbstractSequencedCommmand + https://bugs.webkit.org/show_bug.cgi?id=33133 + + As suggested by Adam in: + https://bugs.webkit.org/show_bug.cgi?id=33131#c2 + + * Scripts/webkitpy/commands/download.py: + +2010-01-04 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + Make all commands AbstractDeclarativeCommmands instead of direct Command subclasses + https://bugs.webkit.org/show_bug.cgi?id=33131 + + Evenetually we'll probably roll AbstractDeclarativeCommmand directly into Command + but for now we just deploy it everywhere and don't try to fix up the few valid uses + of Command. + + * Scripts/webkitpy/commands/download.py: + * Scripts/webkitpy/commands/queries.py: + * Scripts/webkitpy/commands/upload.py: + * Scripts/webkitpy/multicommandtool.py: + +2010-01-03 Adam Barth <abarth@webkit.org> + + Unreviewed "build" fix. Need to import ScriptError. + + * Scripts/webkitpy/buildsteps.py: + +2010-01-03 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + [bzt] Make it easier to run submit-patch when previous run cancelled + https://bugs.webkit.org/show_bug.cgi?id=33070 + + This patch renames create-review to submit-patch (as requested by + Maciej). + + This patch makes it easier to run submit-patch after the user has + already cancelled a previous run of submit-patch by detecting when we + already have ChangeLogs and reading the bug number from them (and not + attempting to recreate them). Aside from performance and the extra + edit step, this command should not subsume post-dif. + + Also, added a --email command line argument so that the output of + prepare-ChangeLog makes sense when it can't find the user's email + address. + + * Scripts/webkitpy/bugzilla.py: + * Scripts/webkitpy/buildsteps.py: + * Scripts/webkitpy/commands/upload.py: + * Scripts/webkitpy/commands/upload_unittest.py: + * Scripts/webkitpy/mock_bugzillatool.py: + * Scripts/webkitpy/user.py: + +2010-01-03 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + Rename Scripts/modules to Scripts/webkitpy + https://bugs.webkit.org/show_bug.cgi?id=33128 + + Just search-replace and svn mv commands. + + * Scripts/bugzilla-tool: + * Scripts/check-webkit-style: + * Scripts/modules: Removed. + * Scripts/modules/BeautifulSoup.py: Removed. + * Scripts/modules/__init__.py: Removed. + * Scripts/modules/bugzilla.py: Removed. + * Scripts/modules/bugzilla_unittest.py: Removed. + * Scripts/modules/buildbot.py: Removed. + * Scripts/modules/buildbot_unittest.py: Removed. + * Scripts/modules/buildsteps.py: Removed. + * Scripts/modules/buildsteps_unittest.py: Removed. + * Scripts/modules/changelogs.py: Removed. + * Scripts/modules/changelogs_unittest.py: Removed. + * Scripts/modules/commands: Removed. + * Scripts/modules/commands/__init__.py: Removed. + * Scripts/modules/commands/commandtest.py: Removed. + * Scripts/modules/commands/download.py: Removed. + * Scripts/modules/commands/download_unittest.py: Removed. + * Scripts/modules/commands/early_warning_system.py: Removed. + * Scripts/modules/commands/early_warning_system_unittest.py: Removed. + * Scripts/modules/commands/queries.py: Removed. + * Scripts/modules/commands/queries_unittest.py: Removed. + * Scripts/modules/commands/queues.py: Removed. + * Scripts/modules/commands/queues_unittest.py: Removed. + * Scripts/modules/commands/queuestest.py: Removed. + * Scripts/modules/commands/upload.py: Removed. + * Scripts/modules/commands/upload_unittest.py: Removed. + * Scripts/modules/comments.py: Removed. + * Scripts/modules/committers.py: Removed. + * Scripts/modules/committers_unittest.py: Removed. + * Scripts/modules/cpp_style.py: Removed. + * Scripts/modules/cpp_style_unittest.py: Removed. + * Scripts/modules/credentials.py: Removed. + * Scripts/modules/credentials_unittest.py: Removed. + * Scripts/modules/diff_parser.py: Removed. + * Scripts/modules/diff_parser_unittest.py: Removed. + * Scripts/modules/executive.py: Removed. + * Scripts/modules/executive_unittest.py: Removed. + * Scripts/modules/grammar.py: Removed. + * Scripts/modules/mock.py: Removed. + * Scripts/modules/mock_bugzillatool.py: Removed. + * Scripts/modules/multicommandtool.py: Removed. + * Scripts/modules/multicommandtool_unittest.py: Removed. + * Scripts/modules/outputcapture.py: Removed. + * Scripts/modules/patchcollection.py: Removed. + * Scripts/modules/queueengine.py: Removed. + * Scripts/modules/queueengine_unittest.py: Removed. + * Scripts/modules/scm.py: Removed. + * Scripts/modules/scm_unittest.py: Removed. + * Scripts/modules/statusbot.py: Removed. + * Scripts/modules/stepsequence.py: Removed. + * Scripts/modules/style: Removed. + * Scripts/modules/style.py: Removed. + * Scripts/modules/style_unittest.py: Removed. + * Scripts/modules/text_style.py: Removed. + * Scripts/modules/text_style_unittest.py: Removed. + * Scripts/modules/user.py: Removed. + * Scripts/modules/webkit_logging.py: Removed. + * Scripts/modules/webkit_logging_unittest.py: Removed. + * Scripts/modules/webkit_mechanize.py: Removed. + * Scripts/modules/webkitport.py: Removed. + * Scripts/modules/webkitport_unittest.py: Removed. + * Scripts/test-webkit-python: Removed. + * Scripts/test-webkitpy: Copied from WebKitTools/Scripts/test-webkit-python. + * Scripts/validate-committer-lists: + * Scripts/webkitpy: Copied from WebKitTools/Scripts/modules. + * Scripts/webkitpy/bugzilla.py: + * Scripts/webkitpy/bugzilla_unittest.py: + * Scripts/webkitpy/buildbot.py: + * Scripts/webkitpy/buildbot_unittest.py: + * Scripts/webkitpy/buildsteps.py: + * Scripts/webkitpy/buildsteps_unittest.py: + * Scripts/webkitpy/commands/commandtest.py: + * Scripts/webkitpy/commands/download.py: + * Scripts/webkitpy/commands/download_unittest.py: + * Scripts/webkitpy/commands/early_warning_system.py: + * Scripts/webkitpy/commands/early_warning_system_unittest.py: + * Scripts/webkitpy/commands/queries.py: + * Scripts/webkitpy/commands/queries_unittest.py: + * Scripts/webkitpy/commands/queues.py: + * Scripts/webkitpy/commands/queues_unittest.py: + * Scripts/webkitpy/commands/queuestest.py: + * Scripts/webkitpy/commands/upload.py: + * Scripts/webkitpy/commands/upload_unittest.py: + * Scripts/webkitpy/comments.py: + * Scripts/webkitpy/credentials.py: + * Scripts/webkitpy/credentials_unittest.py: + * Scripts/webkitpy/executive.py: + * Scripts/webkitpy/executive_unittest.py: + * Scripts/webkitpy/mock_bugzillatool.py: + * Scripts/webkitpy/multicommandtool.py: + * Scripts/webkitpy/multicommandtool_unittest.py: + * Scripts/webkitpy/queueengine.py: + * Scripts/webkitpy/queueengine_unittest.py: + * Scripts/webkitpy/scm.py: + * Scripts/webkitpy/scm_unittest.py: + * Scripts/webkitpy/statusbot.py: + * Scripts/webkitpy/stepsequence.py: + * Scripts/webkitpy/webkit_logging_unittest.py: + * Scripts/webkitpy/webkitport_unittest.py: + +2010-01-03 Chris Jerdonek <chris.jerdonek@gmail.com> + + Reviewed by Eric Seidel. + + Added script to test both Perl and Python, and renamed + run-webkit-unittests to test-webkit-python. + + https://bugs.webkit.org/show_bug.cgi?id=33045 + + * Scripts/VCSUtils_unittest.pl: + - Tweaked so it can be run from outside Scripts directory. + + * Scripts/run-webkit-unittests: Removed. + - Renamed to test-webkit-python. + + * Scripts/test-webkit-perl: + - Tweaked so it can be run from outside Scripts directory. + + * Scripts/test-webkit-python: Copied from Scripts/run-webkit-unittests. + + * Scripts/test-webkit-scripts: Added. + - Runs both test-webkit-perl and test-webkit-python. + +2010-01-03 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + commit-queue/bugzilla-tool should build both Debug and Release + https://bugs.webkit.org/show_bug.cgi?id=28450 + + Add a --build-style command that lets the master process tell the child + process to build both debug and release. Eventually we want to teach + the test step to understand this option too, but that's a patch for + another day. + + * Scripts/modules/buildsteps.py: + * Scripts/modules/commands/queues.py: + * Scripts/modules/webkitport.py: + * Scripts/modules/webkitport_unittest.py: + +2010-01-03 Jakub Wieczorek <faw217@gmail.com> + + Reviewed by Eric Seidel. + + [Qt] EventSender: add support for Enter key events + https://bugs.webkit.org/show_bug.cgi?id=33064 + + Unskip 5 tests that are fixed now. + + * DumpRenderTree/qt/EventSenderQt.cpp: + (EventSender::keyDown): + +2010-01-03 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + [bzt] Add test for previous typo fix + https://bugs.webkit.org/show_bug.cgi?id=33083 + + A trivial test for a trivial fix, as requested by Eric. + + * Scripts/modules/bugzilla_unittest.py: + +2010-01-03 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Implement mac-ews + https://bugs.webkit.org/show_bug.cgi?id=33072 + + The mac-ews is slightly different than the other early warning systems + because we can't run Mac OS X inside a VM. For that reason, we only + process patches that were uploaded by committers. This isn't as much + coverage as the other EWS bots, but it's better than nothing. + + * Scripts/modules/commands/early_warning_system.py: + * Scripts/modules/commands/early_warning_system_unittest.py: + * Scripts/modules/commands/queues.py: + * Scripts/modules/commands/queuestest.py: + * Scripts/modules/mock_bugzillatool.py: + +2010-01-03 Chris Jerdonek <chris.jerdonek@gmail.com> + + Reviewed by David Kilzer. + + Refactored svn-apply and svn-unapply to use a common "patch" + command method, and added unit tests for this new method. + + https://bugs.webkit.org/show_bug.cgi?id=33098 + + * Scripts/VCSUtils.pm: + - Added generateRunPatchCommand(). + - Added runPatchCommand(). + - Added exitStatus() from webkitdirs.pm to address FIXME. + + * Scripts/VCSUtils_unittest.pl: + - Added 10 unit tests for generateRunPatchCommand(). + - Added 4 unit tests for runPatchCommand(). + - Added callSilently() method. + + * Scripts/svn-apply: + - Refactored applyPatch(). + - Removed $pathScriptWasRunFrom global variable. + - Addressed issue where "--force" option was getting added twice. + + * Scripts/svn-unapply: + - Refactored applyPatch(). + - Removed $pathScriptWasRunFrom global variable. + - Added support for --force option. + - Enhanced to return meaningful exit status. + + * Scripts/webkitdirs.pm: + - Moved exitStatus() implementation to VCSUtils.pm. + +2009-12-31 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + [bzt] Implement build-and-test + https://bugs.webkit.org/show_bug.cgi?id=33073 + + Some of the early warning system bots want to use build-and-test so + they can cover LayoutTests in addition to just compilation. + + * Scripts/modules/commands/download.py: + * Scripts/modules/commands/download_unittest.py: + +2009-12-31 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Show mac-ews status on QueueStatusServer + https://bugs.webkit.org/show_bug.cgi?id=33076 + + Also make error status purple. + + * QueueStatusServer/model/attachment.py: + * QueueStatusServer/model/queues.py: + * QueueStatusServer/templates/dashboard.html: + * QueueStatusServer/templates/statusbubble.html: + +2009-12-31 Adam Barth <abarth@webkit.org> + + Unreviewed. + + [bzt] REGRESSION: Bugzila is a typo + https://bugs.webkit.org/show_bug.cgi?id=33074 + + Eric should test his code before landing! :) + + * Scripts/modules/bugzilla.py: + +2009-12-31 Adam Barth <abarth@webkit.org> + + Unreviewed. Fix the unit tests! + + * Scripts/run-webkit-unittests: + +2009-12-30 Kevin Watters <kevinwatters@gmail.com> + + Reviewed by Kevin Ollivier. + + [wx] Alter a couple of default settings in the test app. + + https://bugs.webkit.org/show_bug.cgi?id=32956 + + * wx/browser/browser.cpp: + (MyApp::OnInit): + +2009-12-30 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + logging.py should be renamed to webkit_logging.py and eventually die + https://bugs.webkit.org/show_bug.cgi?id=33058 + + Change all imports of "logging" to webkit_logging, + except the ones which came from Google's cpp_lint.py and diff_parser.py + which clearly are assuming python's logging.py. + + * Scripts/modules/bugzilla.py: + * Scripts/modules/buildbot.py: + * Scripts/modules/buildsteps.py: + * Scripts/modules/commands/download.py: + * Scripts/modules/commands/queries.py: + * Scripts/modules/commands/queues.py: + * Scripts/modules/commands/upload.py: + * Scripts/modules/credentials.py: + * Scripts/modules/executive.py: + * Scripts/modules/multicommandtool.py: + * Scripts/modules/queueengine.py: + * Scripts/modules/scm.py: + * Scripts/modules/statusbot.py: + * Scripts/modules/stepsequence.py: + * Scripts/modules/webkit_logging.py: Renamed from WebKitTools/Scripts/modules/logging.py. + * Scripts/modules/webkit_logging_unittest.py: Renamed from WebKitTools/Scripts/modules/logging_unittest.py. + +2009-12-30 Jakub Wieczorek <faw217@gmail.com> + + Reviewed by Simon Hausmann. + + [Qt] layoutTestController.pathToLocalResource() should return a path, not an URL + https://bugs.webkit.org/show_bug.cgi?id=33051 + + Moreover, its primary function is to normalize the path in regard of platform + specific directory separators. Therefore, it can simply make use of the + QDir::toNativeSeparators function. + + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::pathToLocalResource): + +2009-12-30 David D. Kilzer <ddkilzer@webkit.org> + + Fix executable bits for r52646 + + * Scripts/VCSUtils_unittest.pl: Added property svn:executable. + * Scripts/test-webkit-perl: Ditto. + +2009-12-29 Chris Jerdonek <chris.jerdonek@gmail.com> + + Reviewed by David Kilzer. + + Fixed a bug in fixChangeLogPatch, made it work correctly in + more circumstances, and added unit tests. + + https://bugs.webkit.org/show_bug.cgi?id=32919 + + * Scripts/VCSUtils.pm: + Rewrote fixChangeLogPatch. + + * Scripts/VCSUtils_unittest.pl: Added. + Added 7 unit tests for fixChangeLogPatch. + + * Scripts/test-webkit-perl: Added. + Added test harness for unit tests of Perl code. + +2009-12-29 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + Split out BugzillaQueries class from Bugzilla + https://bugs.webkit.org/show_bug.cgi?id=33042 + + * Scripts/modules/bugzilla.py: + - Split out BugzillaQueries from Bugzilla. + - Try to isolate self.bugzilla usage into helper functions whenever possible. + - Add a bunch of FIXMEs. + - Rename fetch_bug_ids_from_needs_commit_list to fetch_bug_ids_from_pending_commit_list + * Scripts/modules/bugzilla_unittest.py: + - Create a new BugzillaQueriesTest testcase and move logic there. + * Scripts/modules/buildsteps_unittest.py: + - Use Bug 75 instead of 1 since bug 1 doesn't actually exist. + * Scripts/modules/commands/queries.py: + - Update to use bugzilla.queries + * Scripts/modules/commands/queues.py: + - Ditto. + * Scripts/modules/commands/upload.py: + - Ditto. + * Scripts/modules/mock_bugzillatool.py: + - Add a MockBugzillaQueries. + - Make patches and bugs global privates. + - Let _id_to_object_dictionary take a variable argument list instead of an array. + +2009-12-29 Daniel Bates <dbates@webkit.org> + + Reviewed by Eric Seidel. + + https://bugs.webkit.org/show_bug.cgi?id=33041 + + Speed up the test method test_read_credentials_with_SVN by not actually + creating an SVN repository to test against (by default). Instead, it is + sufficient to create a temporary directory that does not contain a Git + repository. + + Also, renamed method test_read_credentials_with_SVN to + test_read_credentials_without_git_repo, to better reflect what it is + testing. + + * Scripts/modules/credentials_unittest.py: + +2009-12-29 Daniel Bates <dbates@webkit.org> + + Reviewed by Adam Barth. + + https://bugs.webkit.org/show_bug.cgi?id=33039 + + [bzt] Fixes an issue where bugzilla-tool dies when the keychain lookup + fails to find an entry for bugs.webkit.org. + + Under Mac OS X, bugzilla-tool tries to query the keychain and Security + framework (via /usr/sbin/security) for an internet-password entry for + bugs.webkit.org so that it can use it to login to bugs.webkit.org. + However, if no such entry exists then bugzilla-tool dies with an error. + + * Scripts/modules/credentials.py: Modified method _parse_security_tool_output to return + [None, None] if /usr/sbin/security cannot find keychain entry for bugs.webkit.org. + * Scripts/modules/credentials_unittest.py: Added method test_security_output_parse_entry_not_found. + +2009-12-29 Eric Seidel <eric@webkit.org> + + Rubber-stamped by Adam Barth. + + Remove unused BugzillaException. + + * Scripts/modules/bugzilla.py: + +2009-12-29 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + Need a script to assign bugs with r+ patches to committers for landing + https://bugs.webkit.org/show_bug.cgi?id=33009 + + This is just one more small tool to help in the fight against our + ever-growing list of to-be-committed patches. + + * Scripts/modules/bugzilla.py: + - Rename assign_to_email to assigned_to_email (typo). + - Add assigned_to_email() method on Bug. + - Add reassign_bug method. + - Add Bugzilla.unassigned_email, eventually should move to some webkit_config.py module. + * Scripts/modules/bugzilla_unittest.py: + - Update test after assigned_to_email rename. + * Scripts/modules/commands/commandtest.py: + - Call bind_to_tool to that self.tool works in Command testing. + * Scripts/modules/commands/download.py: + - Move AbstractDeclarativeCommmand multicommandtool.py, it should be part of Command. + * Scripts/modules/commands/queries_unittest.py: + - One of the test patches is now posted by "eric@webkit.org" which is a committer. + - Eventually we'll mock out CommitterList and be able to better control what's a committer and what's not. + * Scripts/modules/commands/upload.py: + - Add new assign-to-committer command. + * Scripts/modules/commands/upload_unittest.py: + - Add basic assign-to-committer test. + * Scripts/modules/committers.py: + - Add bugzilla_email() accessor. + * Scripts/modules/committers_unittest.py: + - Test our assumption that bugzilla_email is the first email. + * Scripts/modules/mock_bugzillatool.py: + - Add _id_to_object_dictionary for generating bug_cache from list of bugs. + - Remove unused fetch_attachments_from_bug. + - Add fetch_bug support and a bug_cache. + * Scripts/modules/multicommandtool.py: + - Move AbstractDeclarativeCommmand here from download.py + +2009-12-29 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + [bzt] Don't crash if user types a number during PromptForBugOrTitleStep + https://bugs.webkit.org/show_bug.cgi?id=33038 + + Simple fix with test. + + * Scripts/modules/buildsteps.py: + * Scripts/modules/buildsteps_unittest.py: + +2009-12-29 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + [bzt] post-diff requires reading to the end + https://bugs.webkit.org/show_bug.cgi?id=33036 + + Catch the IOError caused by not reading to the end of the diff. We + don't have a good way to test this currently. + + * Scripts/modules/user.py: + +2009-12-29 Chang Shu <Chang.Shu@nokia.com> + + Reviewed by Adam Barth. + + [Qt] Move logic that handles Qt headers before primary headers + so that Qt headers won't be treated as primary headers by mistake. + https://bugs.webkit.org/show_bug.cgi?id=32991 + + * Scripts/modules/cpp_style.py: + * Scripts/modules/cpp_style_unittest.py: + +2009-12-29 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + Add the start of a Bug object for bugzilla.py + https://bugs.webkit.org/show_bug.cgi?id=32995 + + This allowed us to get rid of some duplicated "is_obsolete" checks. + + * Scripts/modules/bugzilla.py: + - Add a new Bug class, and move patches/unreviewed_patches filtering logic there. + - Add _fetch_bug_page for possible future mocking. + (I did not try to test fetch_*_from_bug now due to difficulties with our current validate_reviewer logic.) + - Rename fetch_bug to fetch_bug_dictionary and add a new fetch_bug which returns a Bug object. + - Use fetch_bug and attachments(), patches(), etc. instead of custom fetch_*_from_bug methods. + - Reduce code in fetch_patches_from_pending_commit_list and fetch_patches_from_review_queue + using list comprehensions. Use a sum(list, []) trick to flatten a list of lists into a single list. + * Scripts/modules/bugzilla_unittest.py: + - Remove an unneeded unicode string marker. + * Scripts/modules/buildsteps.py: + - define __all__ to include just the BuildSteps + * Scripts/modules/commands/download.py: + - import * now that we have an __all__ defined. + * Scripts/modules/commands/upload.py: + - Use fetch_bug_dictionary instead of fetch_bug. + +2009-12-29 Daniel Bates <dbates@webkit.org> + + Reviewed by Ariya Hidayat. + + https://bugs.webkit.org/show_bug.cgi?id=32925 + + Adds an Open File dialog to make it convenient to open a file + to view in the browser. + + Currently a person must either specify the path to a file as a + command-line argument or type a file URL. Instead, we should + have a file dialog to allow a person to open a file without + memorizing its path. + + * QtLauncher/main.cpp: + (MainWindow::MainWindow): Changed urlEdit->setText(qurl.toEncoded()) + to urlEdit->setText(qurl.toString()). + (MainWindow::openFile): Added. + (MainWindow::changeLocation): Moved code to load URL into method + MainWindow::loadURL. + (MainWindow::loadURL): Added. + (MainWindow::setupUI): Added menu item Open File. + +2009-12-29 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> + + Reviewed by Holger Freyther. + + [GTK] fails fast/harness/use-page-cache.html + https://bugs.webkit.org/show_bug.cgi?id=33013 + + Make sure settings are forwarded to child WebViews. + + * DumpRenderTree/gtk/DumpRenderTree.cpp: + (createWebView): + +2009-12-29 Daniel Bates <dbates@webkit.org> + + Reviewed by Eric Seidel. + + https://bugs.webkit.org/show_bug.cgi?id=32778 + + Changes $diffPercentage to be a number to resolve Perl + warning about comparing a string to a number. + + * Scripts/run-webkit-tests: + +2009-12-29 Jakub Wieczorek <faw217@gmail.com> + + Reviewed by Eric Seidel. + + [Qt] DRT: Frame loader callbacks differ from the Mac port + https://bugs.webkit.org/show_bug.cgi?id=32989 + + Remove messages from the callbacks that should not dump them to match + the expected results for the http/loading tests. + + Unskip some http/loading tests which succeed now. + + * DumpRenderTree/qt/DumpRenderTreeQt.cpp: + (WebCore::DumpRenderTree::dump): + +2009-12-29 Robert Hogan <robert@roberthogan.net> + + Reviewed by Eric Seidel. + + [Qt] fix fast/dom/Window/window-onFocus.html + + Add support for layouttestcontroller.windowIsKey to Qt DRT and fix issue where + window.onblur was getting dispatched twice from QtWebKit. + + https://bugs.webkit.org/show_bug.cgi?id=32990 + + * DumpRenderTree/qt/DumpRenderTreeQt.cpp: + (WebCore::DumpRenderTree::DumpRenderTree): + (WebCore::DumpRenderTree::switchFocus): + * DumpRenderTree/qt/DumpRenderTreeQt.h: + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::setWindowIsKey): + (LayoutTestController::setMainFrameIsFirstResponder): + * DumpRenderTree/qt/LayoutTestControllerQt.h: + +2009-12-28 Kinuko Yasuda <kinuko@chromium.org> + + Reviewed by Maciej Stachowiak. + + Extended EventSender.keyDown method to take another (3rd) argument + for indicating the keyLocation to make numeric pad key events testable. + Expected values for the argument is one of the KeyLocationCode + specified in DOM Level 3 + (http://www.w3.org/TR/DOM-Level-3-Events/#events-keyboardevents). + https://bugs.webkit.org/show_bug.cgi?id=28247 + + Test: fast/events/keydown-numpad-keys.html + + * DumpRenderTree/mac/EventSendingController.mm: + (+[EventSendingController isSelectorExcludedFromWebScript:]): + (+[EventSendingController webScriptNameForSelector:]): + (-[EventSendingController keyDown:withModifiers:withLocation:]): + +2009-12-28 Ariya Hidayat <ariya.hidayat@gmail.com> + + Unreviewed, update my email address. + + * Scripts/modules/committers.py: + +2009-12-28 Laszlo Gombos <laszlo.1.gombos@nokia.com> + + Reviewed by Adam Barth. + + [Qt] Fix build break for Qt 4.4 + https://bugs.webkit.org/show_bug.cgi?id=30327 + + * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Include QLocale + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Ditto. + * QtLauncher/main.cpp: + (MainWindow::MainWindow): Qt::WA_TranslucentBackground was + introduced in Qt version 4.5 + +2009-12-28 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + [bzt] Add an edit-changelog command + https://bugs.webkit.org/show_bug.cgi?id=32986 + + This command makes it easier to edit ChangeLogs. It's similar to + prepare-ChangeLog -o, except it works with already existing ChangeLogs. + + * Scripts/modules/commands/upload.py: + * Scripts/modules/commands/upload_unittest.py: + +2009-12-28 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + [bzt] Create an ASAD command for uploading a patch + https://bugs.webkit.org/show_bug.cgi?id=32979 + + The create-review command goes through the whole process of preparing a + code review, including creating a bug, editing the ChangeLogs, and + uploading the patch. It is indeed the All Sing, All Dance upload + command. + + * Scripts/modules/buildsteps.py: + * Scripts/modules/commands/upload.py: + * Scripts/modules/commands/upload_unittest.py: + * Scripts/modules/mock_bugzillatool.py: + * Scripts/modules/user.py: + +2009-12-28 Adam Barth <abarth@webkit.org> + + Unreviewed "build" fix (with test!). + + * Scripts/modules/bugzilla.py: + * Scripts/modules/bugzilla_unittest.py: + +2009-12-27 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + Add more awesome bug-parsing logic to bugzilla.py in preparation for assign-to-committer command + https://bugs.webkit.org/show_bug.cgi?id=32980 + + * Scripts/modules/bugzilla.py: + - Add a new _parse_bug_page function and use it in fetch_attachments_from_bug + - Replace fetch_title_from_bug with a new fetch_bug call instead. + - Use list comprehensions where possible to reduce code duplication. + * Scripts/modules/bugzilla_unittest.py: + - Add a minimal bug parsing test. + - Share code between bug parsing and attachment parsing tests with _assert_dictionaries_equal + * Scripts/modules/commands/upload.py: + - Use fetch_bug(bug_id)["title"] instead of fetch_title_from_bug + +2009-12-27 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Status bubble shouldn't be transparent for bots that haven't run yet + https://bugs.webkit.org/show_bug.cgi?id=32977 + + * QueueStatusServer/templates/statusbubble.html: + +2009-12-27 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + [QueueStatusServer] Run gc cron job less often + https://bugs.webkit.org/show_bug.cgi?id=32958 + + Now that we've cleaned out the backlog of idle messages, we don't need + to run the gc job every half hour. We could also stop logging the idle + messages, but this seems easier for the time being. + + * QueueStatusServer/cron.yaml: + +2009-12-27 Daniel Bates <dbates@webkit.org> + + Reviewed by Adam Barth. + + https://bugs.webkit.org/show_bug.cgi?id=32896 + + Fixes an issue where bugzilla-tool tries to read the username and password from + Git regardless of whether Git is installed. In particular, if Git is not + installed then bugzilla-tool dies (with a trace) when it attempts to query Git + for the authentication credentials to log into bugs.webkit.org. + + Moreover, modifies Executive.run_command to catch and pass OSError exceptions to + the specified error handler. For instance, the specified error handler will now + be called when the command does not exist (i.e. OSError errno 2). + + * Scripts/modules/credentials.py: Added check for Git. + * Scripts/modules/credentials_unittest.py: Added test method + test_read_credentials_with_SVN. + * Scripts/modules/executive.py: Modified method run_command to catch + OSError exceptions (i.e [Errno 2] No such file or directory) and call + the specified error handler. + * Scripts/modules/executive_unittest.py: Added. + * Scripts/run-webkit-unittests: Added import executive_unittest.py. + +2009-12-27 Daniel Bates <dbates@webkit.org> + + Unreviewed. Added missing file style_unittest.py that wasn't committed + in change set 52541 (http://trac.webkit.org/changeset/52541) as part of + the patch for bug #32592. + + * Scripts/modules/style_unittest.py: Added. + +2009-12-27 Daniel Bates <dbates@webkit.org> + + Reviewed by Eric Seidel. + + https://bugs.webkit.org/show_bug.cgi?id=32964 + + [bzt] Updated the unit test based on the change made in bug #32951. + + The change made in bug #32951 added the command-line argument: + --makeargs="-j8" to the build-webkit command. However, the associated + unit test was not updated. + + * Scripts/modules/webkitport_unittest.py: + +2009-12-27 Yael Aharon <yael.aharon@nokia.com> + + Reviewed by Darin Adler. + + check-webkit-style should not mark moc files inclusion as errors + https://bugs.webkit.org/show_bug.cgi?id=32669 + + Add a new header type for moc files, and skip them when checking the order of header files. + + * Scripts/modules/cpp_style.py: + +2009-12-26 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + [bzt] Make the qt build go fast + https://bugs.webkit.org/show_bug.cgi?id=32951 + + Make use of multiple cores, if available. + + * Scripts/modules/webkitport.py: + +2009-12-25 Daniel Bates <dbates@rim.com> + + Reviewed by Eric Seidel. + + https://bugs.webkit.org/show_bug.cgi?id=32682 + + Fixes an issue where checkFrameworks always dies with an error under Windows + since the clause "unless (-x $path)" is always satisfied because files under + Windows do not have an explict executable bit. + + * Scripts/webkitdirs.pm: + +2009-12-23 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + bugzilla-tool should accept global options anywhere + https://bugs.webkit.org/show_bug.cgi?id=26912 + + * Scripts/bugzilla-tool: + - Use the new global_options class property. + - Add a handle_global_options callback to avoid needing callbacks for each global option. + * Scripts/modules/multicommandtool.py: + - Make the code use one combined option parser. + This allows us to accept global options anywhere and + individual command options before commands. + - Add a handle_global_options callback to avoid needing callbacks for each global option. + - Make the Command hold the option parser, but allow the tool to override it. + - The default option parser is used for help printing and when Commands are run stand alone, + but are otherwise not used. + - Add Command.main to codify the idea that Commands should support being run stand-alone. + - Change _split_args to _split_command_name_from_args now that args are unified. + * Scripts/modules/multicommandtool_unittest.py: + - Test that "tool" and "tool help" show the same help. + - Test that args are accepted before commands + +2009-12-20 Chris Jerdonek <chris.jerdonek@gmail.com> + + Reviewed by David Levin. + + Moved some sections of code in preparation to refactor + check-webkit-style's argument parser to avoid setting + global variables. + + https://bugs.webkit.org/show_bug.cgi?id=32592 + + * Scripts/check-webkit-style: + - Moved _USAGE string to style.py. + - Addressed FIXME by eliminating dependencies on cpp_style.py. + + * Scripts/modules/cpp_style.py: + - Moved default arguments and style categories to style.py. + - Moved exit_with_usage(), exit_with_categories(), and + parse_arguments() to style.py. + - Removed references in _CppStyleState to the global + variables now in style.py. + + * Scripts/modules/cpp_style_unittest.py: + - Moved parse_arguments() unit tests to style_unittest.py. + + * Scripts/modules/style.py: + - Added _USAGE string from check-webkit-style. + - Added default arguments and style categories from cpp_style.py. + - Added exit_with_usage(), exit_with_categories(), and + parse_arguments() from cpp_sstyle.py. + + * Scripts/modules/style_unittest.py: Added. + - Added parse_arguments() unit tests from cpp_style_unittest.py. + + * Scripts/run-webkit-unittests: + - Added unit tests from style_unittest.py. + +2009-12-23 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + commit-queue should mention bug 30084 when rejecting patches until it can be fixed + https://bugs.webkit.org/show_bug.cgi?id=32911 + + * Scripts/modules/bugzilla.py: Make the message even more fancy. + * Scripts/modules/bugzilla_unittest.py: Test our new fancy message. + +2009-12-23 Laszlo Gombos <laszlo.1.gombos@nokia.com> + + Not reviewed, adding myself to the reviewers list. + + * Scripts/modules/committers.py: + +2009-12-23 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + [bzt] Create a prepare-diff command that creates a bug and a ChangeLog + https://bugs.webkit.org/show_bug.cgi?id=32895 + + The workflow Maciej and I discussed is as follows: + + 1) Write code. + 2) bugzilla-tool prepare-diff + 3) Edit ChangeLogs + 4) bugzilla-tool post-diff + + We might want to experimenting with combining 2-4 into a single + command, but that might be stressful to edit the ChangeLogs modally. + + Removed submit-patch since it has the modal ChangeLog editing but none + oof the bug creating fun. + + * Scripts/modules/bugzilla.py: + * Scripts/modules/buildsteps.py: + * Scripts/modules/commands/upload.py: + * Scripts/modules/commands/upload_unittest.py: + +2009-12-23 Gabor Loki <loki@webkit.org> + + Unreviewed; added myself to the committers list. + + * Scripts/modules/committers.py: + +2009-12-22 Adam Barth <abarth@webkit.org> + + Reviewed by Maciej Stachowiak. + + [bzt] Don't call create-patch twice during post-diff + https://bugs.webkit.org/show_bug.cgi?id=32893 + + If we call create-patch to get the bug number, cache the diff in the + state so we don't need to call it again. + + * Scripts/modules/buildsteps.py: + * Scripts/modules/commands/upload.py: + +2009-12-22 Daniel Bates <dbates@rim.com> + + Reviewed by Eric Seidel. + + https://bugs.webkit.org/show_bug.cgi?id=32680 + + Fixes an issue in builtDylibPathForName so that it returns the correct + path to the built QtWebKit library on the Qt Windows port. Currently, + it returns the path to the file named QtWebKit.dll but this file does + not exist on the Qt Windows build. Instead, the file is named + QtWebKit4.dll. + + * Scripts/webkitdirs.pm: + +2009-12-22 Marc-Antoine Ruel <maruel@chromium.org> + + Reviewed by Adam Roben. + + Remove the only dependency on perl-libwin32 in cygwin + + * Scripts/num-cpus: + +2009-12-22 Darin Adler <darin@apple.com> + + * pywebsocket/mod_pywebsocket: Added property svn:ignore to ignore + generated ".pyc" files. + +2009-12-22 Darin Adler <darin@apple.com> + + Reviewed by Mark Rowe. + + Turn off datagrid by default, at least for all platforms Apple ships. + The datagrid implementation isn't ready for general web use yet. + + * Scripts/build-webkit: Turn off datagrid by default. + +2009-12-22 Eric Seidel <eric@webkit.org> + + Reviewed by Darin Adler. + + validate-committer-lists fails when run from an SVN checkout + https://bugs.webkit.org/show_bug.cgi?id=31974 + + * Scripts/validate-committer-lists: + - Make it print a warning message instead of throwing + an exception when running from an SVN checkout. + +2009-12-22 Philippe Normand <pnormand@igalia.com> + + Reviewed by Adam Barth. + + check-webkit-style should not warn about NULL usage in g_object_{get,set} + https://bugs.webkit.org/show_bug.cgi?id=32858 + + * Scripts/modules/cpp_style.py: + * Scripts/modules/cpp_style_unittest.py: + +2009-12-22 Simon Hausmann <simon.hausmann@nokia.com> + + Rubber-stamped by Holger Freyther. + + Moved QtLauncher from WebKit/qt. + + * QtLauncher: Copied from WebKit/qt/QtLauncher. + * QtLauncher/QtLauncher.pro: + +2009-12-21 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + [bzt] Automate the process of calling prepare-ChangeLog + https://bugs.webkit.org/show_bug.cgi?id=32816 + + This patch automates the process of creating a bug and patch and + uploading it to bugzilla. The first cut just calls + prepare-ChangeLog. + + This patch required some refactoring of upload.py to the Step + model, but that's worth doing anyway. + + * Scripts/bugzilla-tool: + * Scripts/modules/buildsteps.py: + * Scripts/modules/commands/download.py: + * Scripts/modules/commands/upload.py: + * Scripts/modules/commands/upload_unittest.py: + * Scripts/modules/mock_bugzillatool.py: + +2009-12-21 Darin Adler <darin@apple.com> + + * Scripts/do-webcore-rename: Did a rename, so checking in the + version of the script I used. + +2009-12-21 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Update status-bubble to show all the queues + https://bugs.webkit.org/show_bug.cgi?id=32838 + + Also, move statusbubble over to use memcache. + + * QueueStatusServer/handlers/statusbubble.py: + * QueueStatusServer/templates/statusbubble.html: + +2009-12-21 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Delete the boring "Empty queue" status messages in QueueStatusServer + https://bugs.webkit.org/show_bug.cgi?id=32818 + + * QueueStatusServer/app.yaml: + * QueueStatusServer/cron.yaml: + * QueueStatusServer/handlers/gc.py: + * QueueStatusServer/main.py: + +2009-12-21 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Exception on queue status server + https://bugs.webkit.org/show_bug.cgi?id=32812 + + Turns out we need to pass the id to the filter. + + * QueueStatusServer/filters/webkit_extras.py: + * QueueStatusServer/templates/patch.html: + * QueueStatusServer/templates/recentstatus.html: + +2009-12-20 Chris Jerdonek <chris.jerdonek@gmail.com> + + Reviewed by Eric Seidel. + + Created "style" folder for code supporting check-webkit-style. + + * Scripts/modules/style: Added. + +2009-12-20 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + REGRESSION: error when running commit-queue + https://bugs.webkit.org/show_bug.cgi?id=32806 + + Fix typo and add test! + + * Scripts/modules/bugzilla.py: + * Scripts/modules/bugzilla_unittest.py: + +2009-12-20 Adam Barth <abarth@webkit.org> + + [bzt] Optimize status updates for new dashboard + https://bugs.webkit.org/show_bug.cgi?id=32797 + + This patch makes the queues slightly more chatty with the web service. + Also, this patch introduces some testing for the queues! + + * Scripts/modules/commands/early_warning_system.py: + * Scripts/modules/commands/early_warning_system_unittest.py: Added. + * Scripts/modules/commands/queues.py: + * Scripts/modules/commands/queues_unittest.py: + * Scripts/modules/commands/queuestest.py: Added. + * Scripts/modules/mock_bugzillatool.py: + * Scripts/modules/patchcollection.py: + * Scripts/modules/queueengine.py: + * Scripts/run-webkit-unittests: + +2009-12-20 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Prepare QueueStatusServer for new status messages + https://bugs.webkit.org/show_bug.cgi?id=32805 + + * QueueStatusServer/handlers/recentstatus.py: + * QueueStatusServer/index.html: Removed. + * QueueStatusServer/model/attachment.py: + * QueueStatusServer/model/queues.py: Added. + * QueueStatusServer/templates/recentstatus.html: Added. + +2009-12-20 Shinichiro Hamaji <hamaji@chromium.org> + + Reviewed by Adam Barth. + + [check-webkit-style] static_cast is not misnamed! + https://bugs.webkit.org/show_bug.cgi?id=32796 + + * Scripts/modules/cpp_style.py: + * Scripts/modules/cpp_style_unittest.py: + +2009-12-20 Alejandro G. Castro <alex@igalia.com> + + Reviewed by Gustavo Noronha Silva. + + [GTK] Failing test platform/gtk/editing/pasteboard/middle-button-paste.html + https://bugs.webkit.org/show_bug.cgi?id=32788 + + Do not increase the click count if we are using a different button. + + * DumpRenderTree/gtk/EventSender.cpp: + +2009-12-20 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + [QueueStatusServer] Add a per-patch details page + https://bugs.webkit.org/show_bug.cgi?id=32784 + + This is a first cut at a per-patch details page. I'm sure we'll have + to iterate. + + * QueueStatusServer/filters/webkit_extras.py: + * QueueStatusServer/handlers/patch.py: Added. + * QueueStatusServer/index.yaml: + * QueueStatusServer/main.py: + * QueueStatusServer/model/attachment.py: + * QueueStatusServer/stylesheets/dashboard.css: + * QueueStatusServer/templates/dashboard.html: + * QueueStatusServer/templates/patch.html: Added. + +2009-12-20 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Use memcache to make dashboard to fast + https://bugs.webkit.org/show_bug.cgi?id=32780 + + * QueueStatusServer/app.yaml: + * QueueStatusServer/handlers/dashboard.py: + * QueueStatusServer/handlers/updatestatus.py: + * QueueStatusServer/model/attachment.py: Added. + +2009-12-19 Brent Fulgham <bfulgham@webkit.org> + + Reviewed by Adam Roben. + + Provide an example implementation for printing under Windows. + http://bugs.webkit.org/show_bug.cgi?id=32504.` + + * WinLauncher/PrintWebUIDelegate.cpp: Added. + (PrintWebUIDelegate::QueryInterface): + (PrintWebUIDelegate::AddRef): + (PrintWebUIDelegate::Release): + (PrintWebUIDelegate::webViewPrintingMarginRect): + * WinLauncher/PrintWebUIDelegate.h: Added. + (PrintWebUIDelegate::PrintWebUIDelegate): + (PrintWebUIDelegate::createWebViewWithRequest): + (PrintWebUIDelegate::webViewShow): + (PrintWebUIDelegate::webViewClose): + (PrintWebUIDelegate::webViewFocus): + (PrintWebUIDelegate::webViewUnfocus): + (PrintWebUIDelegate::webViewFirstResponder): + (PrintWebUIDelegate::makeFirstResponder): + (PrintWebUIDelegate::setStatusText): + (PrintWebUIDelegate::webViewStatusText): + (PrintWebUIDelegate::webViewAreToolbarsVisible): + (PrintWebUIDelegate::setToolbarsVisible): + (PrintWebUIDelegate::webViewIsStatusBarVisible): + (PrintWebUIDelegate::setStatusBarVisible): + (PrintWebUIDelegate::webViewIsResizable): + (PrintWebUIDelegate::setResizable): + (PrintWebUIDelegate::setFrame): + (PrintWebUIDelegate::webViewFrame): + (PrintWebUIDelegate::setContentRect): + (PrintWebUIDelegate::webViewContentRect): + (PrintWebUIDelegate::runJavaScriptAlertPanelWithMessage): + (PrintWebUIDelegate::runJavaScriptConfirmPanelWithMessage): + (PrintWebUIDelegate::runJavaScriptTextInputPanelWithPrompt): + (PrintWebUIDelegate::runBeforeUnloadConfirmPanelWithMessage): + (PrintWebUIDelegate::runOpenPanelForFileButtonWithResultListener): + (PrintWebUIDelegate::mouseDidMoveOverElement): + (PrintWebUIDelegate::contextMenuItemsForElement): + (PrintWebUIDelegate::validateUserInterfaceItem): + (PrintWebUIDelegate::shouldPerformAction): + (PrintWebUIDelegate::dragDestinationActionMaskForDraggingInfo): + (PrintWebUIDelegate::willPerformDragDestinationAction): + (PrintWebUIDelegate::dragSourceActionMaskForPoint): + (PrintWebUIDelegate::willPerformDragSourceAction): + (PrintWebUIDelegate::contextMenuItemSelected): + (PrintWebUIDelegate::hasCustomMenuImplementation): + (PrintWebUIDelegate::trackCustomPopupMenu): + (PrintWebUIDelegate::measureCustomMenuItem): + (PrintWebUIDelegate::drawCustomMenuItem): + (PrintWebUIDelegate::addCustomMenuDrawingData): + (PrintWebUIDelegate::cleanUpCustomMenuDrawingData): + (PrintWebUIDelegate::canTakeFocus): + (PrintWebUIDelegate::takeFocus): + (PrintWebUIDelegate::registerUndoWithTarget): + (PrintWebUIDelegate::removeAllActionsWithTarget): + (PrintWebUIDelegate::setActionTitle): + (PrintWebUIDelegate::undo): + (PrintWebUIDelegate::redo): + (PrintWebUIDelegate::canUndo): + (PrintWebUIDelegate::canRedo): + (PrintWebUIDelegate::printFrame): + (PrintWebUIDelegate::ftpDirectoryTemplatePath): + (PrintWebUIDelegate::webViewHeaderHeight): + (PrintWebUIDelegate::webViewFooterHeight): + (PrintWebUIDelegate::drawHeaderInRect): + (PrintWebUIDelegate::drawFooterInRect): + (PrintWebUIDelegate::canRunModal): + (PrintWebUIDelegate::createModalDialog): + (PrintWebUIDelegate::runModal): + (PrintWebUIDelegate::isMenuBarVisible): + (PrintWebUIDelegate::setMenuBarVisible): + (PrintWebUIDelegate::runDatabaseSizeLimitPrompt): + (PrintWebUIDelegate::paintCustomScrollbar): + (PrintWebUIDelegate::paintCustomScrollCorner): + * WinLauncher/WinLauncher.cpp: Add new UI delegate for print support. + (WinLauncherWebHost::updateAddressBar): check-webkit-style fixes. + (WinLauncherWebHost::QueryInterface): check-webkit-style fixes. + (WinLauncherWebHost::AddRef): check-webkit-style fixes. + (WinLauncherWebHost::Release): check-webkit-style fixes. + (resizeSubViews): check-webkit-style fixes. + (_tWinMain): check-webkit-style fixes. + (MyRegisterClass): check-webkit-style fixes. + (InitInstance): check-webkit-style fixes. + (AbortProc): New print support function. + (getPrinterDC): New print support function. + (initDocStruct): New print support function. + (PrintView): New printing implementation. + (WndProc): Add support for printing. + (MyEditProc): check-webkit-style fixes. + (About): check-webkit-style fixes. + (loadURL): check-webkit-style fixes. + * WinLauncher/WinLauncher.h: + (WinLauncherWebHost::WinLauncherWebHost): + (WinLauncherWebHost::didStartProvisionalLoadForFrame): + (WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame): + (WinLauncherWebHost::didFailProvisionalLoadWithError): + (WinLauncherWebHost::didCommitLoadForFrame): + (WinLauncherWebHost::didReceiveTitle): + (WinLauncherWebHost::didReceiveIcon): + (WinLauncherWebHost::didFinishLoadForFrame): + (WinLauncherWebHost::didFailLoadWithError): + (WinLauncherWebHost::didChangeLocationWithinPageForFrame): + (WinLauncherWebHost::willPerformClientRedirectToURL): + (WinLauncherWebHost::didCancelClientRedirectForFrame): + (WinLauncherWebHost::willCloseFrame): + (WinLauncherWebHost::windowScriptObjectAvailable): + * WinLauncher/WinLauncher.rc: Add menu entry for printing. + * WinLauncher/WinLauncher.vcproj: Add new files. + * WinLauncher/resource.h: Add menu entry for printing. + +2009-12-19 Adam Barth <abarth@webkit.org> + + Unreviewed. Tweak the CSS to make the dashboard prettier. + + * QueueStatusServer/stylesheets/dashboard.css: + * QueueStatusServer/templates/dashboard.html: + +2009-12-19 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + QueueStatusServer needs a human readable dashboard + https://bugs.webkit.org/show_bug.cgi?id=32769 + + Here is a first cut at the dashboard. There's a lot left to do. + + * QueueStatusServer/filters/webkit_extras.py: + * QueueStatusServer/handlers/dashboard.py: Added. + * QueueStatusServer/handlers/patchstatus.py: + * QueueStatusServer/handlers/recentstatus.py: + * QueueStatusServer/handlers/showresults.py: + * QueueStatusServer/handlers/statusbubble.py: + * QueueStatusServer/handlers/updatestatus.py: + * QueueStatusServer/main.py: + * QueueStatusServer/model/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py. + * QueueStatusServer/model/queuestatus.py: Renamed from WebKitTools/QueueStatusServer/model.py. + * QueueStatusServer/stylesheets/dashboard.css: Added. + * QueueStatusServer/templates/dashboard.html: Added. + * QueueStatusServer/templates/statusbubble.html: Renamed from WebKitTools/QueueStatusServer/status_bubble.html. + * QueueStatusServer/templates/updatestatus.html: Renamed from WebKitTools/QueueStatusServer/update_status.html. + +2009-12-19 Daniel Bates <dbates@webkit.org> + + Reviewed by Timothy Hatcher. + + https://bugs.webkit.org/show_bug.cgi?id=32462 + + Added --inspector-frontend flag to build-webkit to copy any changes + to the inspector front-end files to the built WebCore framework. This + will make inspector development more consistent with the rest of + WebKit development. + + * Scripts/build-webkit: + * Scripts/webkitdirs.pm: + +2009-12-19 Adam Barth <abarth@webkit.org> + + Unreviewed fixes for me being terrible at python. + + * Scripts/modules/bugzilla.py: + * Scripts/run-webkit-unittests: + +2009-12-18 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Split QueueStatus server into modules + https://bugs.webkit.org/show_bug.cgi?id=32768 + + One monolithic file is no good. + + * QueueStatusServer/app.yaml: + * QueueStatusServer/handlers/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py. + * QueueStatusServer/handlers/patchstatus.py: Added. + * QueueStatusServer/handlers/recentstatus.py: Added. + * QueueStatusServer/handlers/showresults.py: Added. + * QueueStatusServer/handlers/statusbubble.py: Added. + * QueueStatusServer/handlers/updatestatus.py: Added. + * QueueStatusServer/main.py: Added. + * QueueStatusServer/model.py: Added. + * QueueStatusServer/queue_status.py: Removed. + +2009-12-18 Adam Barth <abarth@webkit.org> + + Rubber stamped by Eric Seidel. + + Renamed WorkQueue to QueueEngine. WorkQueue is not a queue. + + * Scripts/modules/commands/queues.py: + * Scripts/modules/queueengine.py: Added. + * Scripts/modules/queueengine_unittest.py: Added. + * Scripts/modules/stepsequence.py: + * Scripts/modules/workqueue.py: Removed. + * Scripts/modules/workqueue_unittest.py: Removed. + +2009-12-18 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Add watches for EWS + https://bugs.webkit.org/show_bug.cgi?id=32767 + + dglazkov wanted to be added. + + * Scripts/modules/bugzilla.py: + * Scripts/modules/commands/early_warning_system.py: + * Scripts/modules/commands/queues.py: + +2009-12-18 Eric Seidel <eric@webkit.org> + + Reviewed by David Levin. + + move bugzilla.py off of urllib2 + https://bugs.webkit.org/show_bug.cgi?id=32729 + + * Scripts/modules/bugzilla.py: use mechanize for all url fetching. + +2009-12-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> + + Rubber-stamped by Xan Lopez. + + [GTK] New events (pageshow and pagehide) tests failing + https://bugs.webkit.org/show_bug.cgi?id=28823 + + Original patch by Jan Michael Alonzo. + + Disable page cache for tests. + + * DumpRenderTree/gtk/DumpRenderTree.cpp: + (resetDefaultsToConsistentValues): + * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: + (copyWebSettingKey): + (LayoutTestController::overridePreference): + +2009-12-18 Fumitoshi Ukai <ukai@chromium.org> + + Reviewed by David Levin. + + Check one space before end of line comments. + https://bugs.webkit.org/show_bug.cgi?id=32597 + + Fix to check one space before end of line comments in whitespace and build/header_guard. + Also fix build/header_guard to use WebKit header guard defines. + + * Scripts/modules/cpp_style.py: + * Scripts/modules/cpp_style_unittest.py: + +2009-12-17 Sam Weinig <sam@webkit.org> + + Reviewed by Mark Rowe. + + Add BUILDING_ON_SNOW_LEOPARD #define. + + * DumpRenderTree/mac/DumpRenderTreeMac.h: + +2009-12-17 Yuzo Fujishima <yuzo@google.com> + + Reviewed by Alexey Proskuryakov. + + Update pywebsocket to 0.4.5 and make handshake checking stricter + https://bugs.webkit.org/show_bug.cgi?id=32249 + + * Scripts/run-webkit-tests: + * pywebsocket/mod_pywebsocket/handshake.py: + * pywebsocket/mod_pywebsocket/memorizingfile.py: Added. + * pywebsocket/mod_pywebsocket/standalone.py: + * pywebsocket/setup.py: + * pywebsocket/test/test_handshake.py: + * pywebsocket/test/test_memorizingfile.py: Added. + +2009-12-17 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + Command.show_in_main_help should default to False + https://bugs.webkit.org/show_bug.cgi?id=32686 + + * Scripts/modules/commands/download.py: + * Scripts/modules/commands/queries.py: + * Scripts/modules/commands/queues.py: + * Scripts/modules/commands/upload.py: + * Scripts/modules/multicommandtool.py: + +2009-12-17 Alejandro G. Castro <alex@igalia.com> + + Reviewed by Eric Seidel. + + Added the key WebKitEnableCaretBrowsing to the + layoutTestController.overridePreference in order to activate caret + browsing. + https://bugs.webkit.org/show_bug.cgi?id=32612 + + * DumpRenderTree/gtk/DumpRenderTree.cpp: Added the reset value of + the setting. + * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Inserted the new + key in the keytable. + +2009-12-17 Chris Fleizach <cfleizach@apple.com> + + Reviewed by David Kilzer. + + AX: DRT needs to support URL for accessibility + https://bugs.webkit.org/show_bug.cgi?id=32666 + + * DumpRenderTree/AccessibilityUIElement.cpp: + (getURLCallback): + (AccessibilityUIElement::getJSClass): + * DumpRenderTree/AccessibilityUIElement.h: + * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: + (AccessibilityUIElement::url): + * DumpRenderTree/mac/AccessibilityUIElementMac.mm: + (AccessibilityUIElement::url): + * DumpRenderTree/win/AccessibilityUIElementWin.cpp: + (AccessibilityUIElement::url): + +2009-12-17 Philippe Normand <pnormand@igalia.com> + + Unreviewed; added myself to committers + + * Scripts/modules/committers.py: + +2009-12-17 Benjamin Otte <otte@gnome.org> + + Unreviewed; added myself to committers + + * Scripts/modules/committers.py: + +2009-12-17 Adam Barth <abarth@webkit.org> + + Rubber stamp by Seidel. + + Clean up exception handling in WorkQueue. Basically, a bunch of the + delegate messages can throw exceptions because of network errors. We + want the queues to keep on ticking instead of erroring out. That means + we want to catch generic exceptions and continue looping. + + Also, cleaned up the exception handling in the EWS to properly log + failures. + + * Scripts/modules/commands/early_warning_system.py: + * Scripts/modules/commands/queues.py: + * Scripts/modules/workqueue.py: + +2009-12-16 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + [bzt] Make UpdateStep quiet + https://bugs.webkit.org/show_bug.cgi?id=32599 + + * Scripts/modules/buildsteps.py: + * Scripts/modules/buildsteps_unittest.py: + +2009-12-16 Evan Martin <evan@chromium.org> + + Reviewed by Adam Barth. + + Add Gtk to the early warning system WebKit port list. + + https://bugs.webkit.org/show_bug.cgi?id=32629 + + * Scripts/modules/commands/early_warning_system.py: + * Scripts/modules/webkitport.py: + * Scripts/modules/webkitport_unittest.py: + +2009-12-16 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + post-diff is failing with exception under guess_reviewer_from_bug + https://bugs.webkit.org/show_bug.cgi?id=32642 + + Also refactor output capturing code into + OutputCapture.assert_outputs to share more code between tests. + + * Scripts/modules/buildsteps.py: + - Add the missing include. + - Give guess_reviewer_from_bug a private underscore. + * Scripts/modules/buildsteps_unittest.py: Added. + - Test to make sure _guess_reviewer_from_bug works as expected. + * Scripts/modules/commands/commandtest.py: + - Custom code is now obsoleted by OutputCapture.assert_outputs + * Scripts/modules/commands/queues_unittest.py: + - ditto + * Scripts/modules/credentials_unittest.py: + - ditto + * Scripts/modules/mock_bugzillatool.py: + - fetch_reviewed_patches_from_bug can never return None + * Scripts/modules/multicommandtool_unittest.py: + - Custom code is now obsoleted by OutputCapture.assert_outputs + * Scripts/modules/outputcapture.py: + - Add assert_outputs to share more code between tests. + * Scripts/run-webkit-unittests: + - Add buildsteps_unittest.py + +2009-12-16 Adam Barth <abarth@webkit.org> + + Unreviewed. Added a default argument to _update_status so that callers + don't have to explictly pass None when they don't have a patch object. + + * Scripts/modules/commands/queues.py: + +2009-12-16 Kent Tamura <tkent@chromium.org> + + Reviewed by David Levin. + + check-webkit-style supports for TAB check against text files. + https://bugs.webkit.org/show_bug.cgi?id=32538 + + * Scripts/check-webkit-style: + Move process_patch() to style.py. + * Scripts/modules/cpp_style.py: + Add can_handle(). + * Scripts/modules/cpp_style_unittest.py: + Add tests for can_handle(). + * Scripts/modules/style.py: + Added. This is a front-end of cpp_style and text_style. It dispatches + files to an appropriate linter. + * Scripts/modules/text_style.py: + Added. This is a linter module for generic text files. It supports + only for TAB checking at this moment. + * Scripts/modules/text_style_unittest.py: + Added. Tests for text_style.py. + * Scripts/run-webkit-unittests: + Add text_style_unittest. + +2009-12-16 Eric Seidel <eric@webkit.org> + + Reviewed by David Levin. + + bugzilla-tool should not require users to install mechanize + https://bugs.webkit.org/show_bug.cgi?id=32635 + + Centralize our import logic. + + * Scripts/modules/bugzilla.py: use webkit_mechanize + * Scripts/modules/statusbot.py: use webkit_mechanize + * Scripts/modules/webkit_mechanize.py: Added. + +2009-12-16 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + Generalize commit-queue recent status page for all queues + https://bugs.webkit.org/show_bug.cgi?id=32633 + + * QueueStatusServer/index.html: + - Generalize to support other queues. + * QueueStatusServer/queue_status.py: + - Generalize MainPage to support other queues. + +2009-12-16 Evan Martin <evan@chromium.org> + + Reviewed by Adam Barth. + + Early warning system server should display output as UTF-8. + + https://bugs.webkit.org/show_bug.cgi?id=32625 + + * QueueStatusServer/queue_status.py: + +2009-12-16 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + [bzt] Add error handling to the early warning system + https://bugs.webkit.org/show_bug.cgi?id=32594 + + This should be the last step in making the EWS operational. When we + have a build error, we post the log to QueueStatusServer and add a link + to the bug. + + * Scripts/modules/commands/early_warning_system.py: + * Scripts/modules/commands/queues.py: + * Scripts/modules/executive.py: + +2009-12-16 Simon Hausmann <simon.hausmann@nokia.com> + + Reviewed by Holger Freyther. + + Fix crash with tests that use custom font faces. + + https://bugs.webkit.org/show_bug.cgi?id=32600 + + In the DRT we call QApplication::removeAllApplicationFonts(), to make sure + that custom font faces between tests don't influence each other. Calling this + function in Qt however also invalidates all existing handles with QFontDatabase. + + In order to make sure that WebCore also drops these handles we call QWebSettings::clearMemoryCaches(), + which implies a call to WebCore::FontCache::fontCache()->invalidate(). + + * DumpRenderTree/qt/DumpRenderTreeQt.cpp: + (WebCore::DumpRenderTree::open): + +2009-12-16 Andreas Kling <andreas.kling@nokia.com> + + Reviewed by Simon Hausmann. + + [Qt] Maintain button state between mouse events. + + This allows eventSender to generate drag events. + + https://bugs.webkit.org/show_bug.cgi?id=32601 + + * DumpRenderTree/qt/EventSenderQt.cpp: + (EventSender::mouseDown): + (EventSender::mouseUp): + (EventSender::mouseMoveTo): + * DumpRenderTree/qt/EventSenderQt.h: + +2009-12-15 Chris Jerdonek <chris.jerdonek@gmail.com> + + Reviewed by David Levin. + + Code clean-up in check-webkit-style as described below. + The only functional changes are minor improvements to the + script's help output. + + https://bugs.webkit.org/show_bug.cgi?id=32487 + + * Scripts/check-webkit-style: + - Added the module docstring from cpp_style.py. + - Improved wording of the --help output and added some of the + default values as substitution strings. + - Called cpp_style.exit_with_usage instead of sys.stderr.write + in main function. + - Made changes caused by changes to cpp_style.py. + + * Scripts/modules/cpp_style.py: + - Removed module docstring, as well as redundant _USAGE string + and main() function obsoleted by check-webkit-style. + - Moved specification of default script values from within a + function definition to global variables. + - Moved the default webkit filter rules to be near the other + global variables. + - Renamed "FILTER" global variables to "FILTER_RULES" to + establish unambiguous terminology. + - Renamed _ERROR_CATEGORIES to _STYLE_CATEGORIES. + - Changed _STYLE_CATEGORIES from a string to a list. + - Added default webkit filter rules to --filter= output. + - Renamed "print_" methods to "exit_with_" since they exist + and added a temporary display_help parameter. + - Added a temporary display_help parameter to parse_arguments. + + * Scripts/modules/cpp_style_unittest.py: + - Made changes caused by changes to cpp_style.py. + - Lower-cased ErrorCollector's ERROR_CATEGORIES instance + variables since they are not global. + +2009-12-15 Adam Barth <abarth@webkit.org> + + Unreviewed fix for the style-queue. + Typo: _updates_status -> _update_status + + We need to improve our testing infrastructure for the queues. + + * Scripts/modules/commands/queues.py: + +2009-12-15 Adam Barth <abarth@webkit.org> + + Unreviewed fix for the style-queue. I suspect this is a recent + regression from Eric's change below. + + * Scripts/modules/commands/queues.py: + +2009-12-15 Yaar Schnitman <yaar@chromium.org> + + Reviewed by Darin Fisher. + + update-webkit-chromium to auto-install gclient + + https://bugs.webkit.org/show_bug.cgi?id=32587 + + * Scripts/update-webkit-chromium: + +2009-12-15 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + bugzilla-tool / commit-queue should add results links to bugs when more results are available on the status bot + https://bugs.webkit.org/show_bug.cgi?id=32546 + + You can see an example of this working in: + https://bugs.webkit.org/show_bug.cgi?id=32585#c3 + + * QueueStatusServer/queue_status.py: + - Output the id of the newly created status. + * Scripts/modules/commands/queues.py: + - Tweak the commit-queue logging to include a full status link. + * Scripts/modules/statusbot.py: + - update_status should return the newly created status id. + +2009-12-15 Andras Becsi <abecsi@inf.u-szeged.hu> + + Reviewed by Tor Arne Vestbø. + + [Qt] Rename Qt DRT components to match other ports' naming convention and to be more understandable. + + * DumpRenderTree/qt/DumpRenderTree.cpp: Removed. + * DumpRenderTree/qt/DumpRenderTree.h: Removed. + * DumpRenderTree/qt/DumpRenderTree.pro: Updated. + * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Copied from WebKitTools/DumpRenderTree/qt/DumpRenderTree.cpp. + * DumpRenderTree/qt/DumpRenderTreeQt.h: Copied from WebKitTools/DumpRenderTree/qt/DumpRenderTree.h. + * DumpRenderTree/qt/GCControllerQt.cpp: Copied from WebKitTools/DumpRenderTree/qt/jsobjects.cpp. + (GCController::GCController): + * DumpRenderTree/qt/GCControllerQt.h: Copied from WebKitTools/DumpRenderTree/qt/jsobjects.h. + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + * DumpRenderTree/qt/WorkQueueItem.h: Removed. + * DumpRenderTree/qt/WorkQueueItemQt.cpp: Updated includes. + * DumpRenderTree/qt/WorkQueueItemQt.h: Copied from WebKitTools/DumpRenderTree/qt/WorkQueueItem.h. + * DumpRenderTree/qt/jsobjects.cpp: Removed. + * DumpRenderTree/qt/jsobjects.h: Removed. + * DumpRenderTree/qt/main.cpp: Updated includes. + +2009-12-15 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + We have two mark-fixed commands + https://bugs.webkit.org/show_bug.cgi?id=32073 + + * Scripts/mark-bug-fixed: Removed. + * Scripts/modules/commands/upload.py: + * Scripts/modules/commands/upload_unittest.py: + +2009-12-15 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + bugzilla-tool/commit-queue needs to upload failure logs when patches are rejected + https://bugs.webkit.org/show_bug.cgi?id=28286 + + * QueueStatusServer/index.html: + - Show [results] links if a results log was uploaded. + * QueueStatusServer/queue_status.py: + - Empty file uploads appear as u"" and Blob does not handle unicode, so convert to str(). + * Scripts/modules/commands/queues.py: + - Post to the status bot when a patch fails and include the failure log as a results file. + +2009-12-15 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + queue sub-commands need --status-host so they can report status + https://bugs.webkit.org/show_bug.cgi?id=32313 + + Make --status-bot a global option and make + run_bugzilla_tool pass --status-bot to sub-commands. + + * Scripts/bugzilla-tool: + - Rename _status to status_bot and make it non-lazy. + * Scripts/modules/commands/queues.py: + - Move status updates out of WorkQueue and into individual queues. + * Scripts/modules/commands/queues_unittest.py: + - Test that --status-host is passed to bugzilla-tool when run as subcommand. + * Scripts/modules/mock_bugzillatool.py: + - Add a MockStatusBot + * Scripts/modules/workqueue.py: + - Remove status_host and work_work_logs_directory callbacks. + - Add new work_item_log_path callback so that WorkQueue doesn't need to know about patches! + * Scripts/modules/workqueue_unittest.py: + - Update unit tests to reflect new callbacks. + +2009-12-15 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + scm_unittest.py is too slow + https://bugs.webkit.org/show_bug.cgi?id=31818 + + Now we don't run the SCM unit tests unless we get the --all flag on the + command line. Eric and I were commenting out this test because it was + too painful to run. + + * Scripts/run-webkit-unittests: + +2009-12-14 Adam Barth <abarth@webkit.org> + + Unreviewed. Fix failing unittest. + + * Scripts/modules/bugzilla_unittest.py: + +2009-12-14 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + Move Credential handling out into a separate module + https://bugs.webkit.org/show_bug.cgi?id=32531 + + * Scripts/modules/bugzilla.py: + * Scripts/modules/credentials.py: Added. + * Scripts/modules/credentials_unittest.py: Added. + * Scripts/run-webkit-unittests: + +2009-12-14 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + Kill _create_step_sequence + https://bugs.webkit.org/show_bug.cgi?id=32539 + + It's cleaner to represent not having these sequences as an empty + sequence instead of None. + + * Scripts/modules/commands/download.py: + * Scripts/modules/stepsequence.py: + +2009-12-14 Adam Barth <abarth@webkit.org> + + Unreviewed. Address reviewer comments from an earlier patch. I didn't + do this earlier because I was worried about conflicts in dependent + patches. + + * Scripts/modules/commands/download.py: + +2009-12-14 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + [bzt] Make download commands declarative + https://bugs.webkit.org/show_bug.cgi?id=32469 + + This patch "properly" factors most of the download commands. These + commands are now largely declarative, which is the final step of this + grand refactoring. + + * Scripts/modules/buildsteps.py: + * Scripts/modules/commands/download.py: + +2009-12-14 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + [bzt] Add AbstractPatchSequencingCommand to remove redundant code + https://bugs.webkit.org/show_bug.cgi?id=32468 + + Redundant code is bad. This patch moves us towards more declarative + commands. + + * Scripts/modules/commands/download.py: + +2009-12-14 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + [bzt] Kill WebKitApplyingScripts + https://bugs.webkit.org/show_bug.cgi?id=32467 + + Ah! I've been wanting to do this for a long time. This patch brings + the applying commands into the patch processing fold. + + * Scripts/bugzilla-tool: + * Scripts/modules/buildsteps.py: + * Scripts/modules/commands/download.py: + * Scripts/modules/commands/download_unittest.py: + * Scripts/modules/mock_bugzillatool.py: + +2009-12-14 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + [bzt] Convert rollout to StepSequence + https://bugs.webkit.org/show_bug.cgi?id=32406 + + * Scripts/modules/buildsteps.py: + * Scripts/modules/commands/download.py: + * Scripts/modules/commands/download_unittest.py: + * Scripts/modules/mock_bugzillatool.py: + +2009-12-14 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + [bzt] Kill LandingSequence + https://bugs.webkit.org/show_bug.cgi?id=32464 + + Removes LandingSequence in favor of StepSequence. This required + changing the Step API slightly to carry a general notion of state + instead of carrying patches specifically. + + * Scripts/modules/buildsteps.py: + * Scripts/modules/commands/download.py: + * Scripts/modules/commands/queues.py: + * Scripts/modules/landingsequence.py: Removed. + * Scripts/modules/stepsequence.py: + +2009-12-14 Robert Hogan <robert@roberthogan.net> + + Reviewed by Eric Seidel. + + [Qt] Fix https://bugs.webkit.org/show_bug.cgi?id=32437 + + Amend the behaviour of DRT::notifyDone to dump only when + the page has finished loading. + + This fix permits removal of the following tests from the Qt skipped list: + fast/forms/textarea-linewrap-dynamic.html + fast/forms/textarea-setvalue-submit.html + fast/forms/textarea-hard-linewrap-empty.html + fast/forms/submit-to-url-fragment.html + http/tests/misc/percent-sign-in-form-field-name.html + http/tests/security/escape-form-data-field-names.html + + However it also requires the following two to be added to the skipped list: + + http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html + svg/custom/use-instanceRoot-as-event-target.xhtml + + It appears the behaviour of notifyDone was masking problems with these two + tests. + + * DumpRenderTree/qt/DumpRenderTree.cpp: + (WebCore::DumpRenderTree::DumpRenderTree): + * DumpRenderTree/qt/LayoutTestControllerQt.cpp: + (LayoutTestController::reset): + (LayoutTestController::processWork): + (LayoutTestController::maybeDump): + (LayoutTestController::notifyDone): + (LayoutTestController::provisionalLoad): + * DumpRenderTree/qt/LayoutTestControllerQt.h: + (LayoutTestController::resetLoadFinished): + +2009-12-14 Simon Hausmann <hausmann@webkit.org> + + Reviewed by Holger Freyther. + + [Qt] Add support for keyboard modifiers to Qt DRT's EventSender for touch events + + https://bugs.webkit.org/show_bug.cgi?id=32482 + + * DumpRenderTree/qt/EventSenderQt.cpp: + (EventSender::setTouchModifier): + (EventSender::clearTouchPoints): + (EventSender::sendTouchEvent): + * DumpRenderTree/qt/EventSenderQt.h: + +2009-12-13 Maciej Stachowiak <mjs@apple.com> + + Reviewed by Gavin Barraclaugh. + + Fix minor problem in sunspider-compare-results which left it broken. + + * Scripts/sunspider-compare-results: Declare $parseonly + +2009-12-12 Maciej Stachowiak <mjs@apple.com> + + Reviewed by Oliver Hunt. + + Give command-line sunspider the ability to handle multiple suites and versions + https://bugs.webkit.org/show_bug.cgi?id=32477 + + * Scripts/run-sunspider: Updated for changes to command-line parameters. + * Scripts/sunspider-compare-results: ditto + +2009-12-12 Maciej Stachowiak <mjs@apple.com> + + Not reviewed, fixing previous comment. + + Remove accidental change to sunspider-compare-results + + * Scripts/sunspider-compare-results: + +2009-12-11 Yael Aharon <yael.aharon@nokia.com> + + Unreviewed build fix for Qt versions < 4.6. + Guard every slot individually with #ifdef. + + * DumpRenderTree/qt/EventSenderQt.cpp: + (EventSender::addTouchPoint): + (EventSender::updateTouchPoint): + (EventSender::touchStart): + (EventSender::touchMove): + (EventSender::touchEnd): + (EventSender::clearTouchPoints): + (EventSender::releaseTouchPoint): + (EventSender::sendTouchEvent): + * DumpRenderTree/qt/EventSenderQt.h: + +2009-12-11 Eric Seidel <eric@webkit.org> + + Reviewed by Adam Barth. + + CommandsTest.assert_execute_outputs doesn't check stderr + https://bugs.webkit.org/show_bug.cgi?id=32352 + + Fix assert_execute_outputs to check stderr + and then fix all the unit tests which needed to + pass stderr output. + + * Scripts/modules/commands/commandtest.py: + * Scripts/modules/commands/download_unittest.py: + * Scripts/modules/commands/upload_unittest.py: + +2009-12-11 Adam Barth <abarth@webkit.org> + + Reviewed by Eric Seidel. + + [check-webkit-style] False positive for tst_QWebFrame + https://bugs.webkit.org/show_bug.cgi?id=32436 + + Add an exception for function names that start with "tst_". These are + used by the Qt unit testing framework. + + * Scripts/modules/cpp_style.py: + * Scripts/modules/cpp_style_unittest.py: + +2009-12-11 Simon Hausmann <hausmann@webkit.org>, Kim Grönholm <kim.gronholm@nomovok.com> + + Reviewed by Antti Koivisto. + + Added support for creating synthetic touch events with EventSender + in Qt's DumpRenderTree. + + https://bugs.webkit.org/show_bug.cgi?id=32114 + + * DumpRenderTree/qt/EventSenderQt.cpp: + (EventSender::addTouchPoint): + (EventSender::updateTouchPoint): + (EventSender::touchStart): + (EventSender::touchMove): + (EventSender::touchEnd): + (EventSender::clearTouchPoints): + (EventSender::releaseTouchPoint): + (EventSender::sendTouchEvent): + * DumpRenderTree/qt/EventSenderQt.h: + +2009-12-11 Benjamin Poulain <benjamin.poulain@nokia.com> + + Reviewed by Darin Adler. + + The values of RuntimeArray are not enumerable + https://bugs.webkit.org/show_bug.cgi?id=29005 + + * DumpRenderTree/mac/ObjCController.m: + (+[ObjCController isSelectorExcludedFromWebScript:]): + (+[ObjCController webScriptNameForSelector:]): + (-[ObjCController arrayOfString]): + 2009-12-10 Eric Seidel <eric@webkit.org> No review, just updating unit tests to match recent checkins. |