diff options
Diffstat (limited to 'WebKitTools/QueueStatusServer/model')
-rw-r--r-- | WebKitTools/QueueStatusServer/model/workitems.py | 2 | ||||
-rw-r--r-- | WebKitTools/QueueStatusServer/model/workitems_unittest.py | 8 |
2 files changed, 2 insertions, 8 deletions
diff --git a/WebKitTools/QueueStatusServer/model/workitems.py b/WebKitTools/QueueStatusServer/model/workitems.py index fae6830..772fc39 100644 --- a/WebKitTools/QueueStatusServer/model/workitems.py +++ b/WebKitTools/QueueStatusServer/model/workitems.py @@ -52,6 +52,7 @@ class WorkItems(db.Model, QueuePropertyMixin): work_items.item_ids.append(attachment_id) work_items.put() + # Because this uses .key() self.is_saved() must be True or this will throw NotSavedError. def add_work_item(self, attachment_id): db.run_in_transaction(self._unguarded_add, self.key(), attachment_id) @@ -63,5 +64,6 @@ class WorkItems(db.Model, QueuePropertyMixin): work_items.item_ids.remove(attachment_id) work_items.put() + # Because this uses .key() self.is_saved() must be True or this will throw NotSavedError. def remove_work_item(self, attachment_id): db.run_in_transaction(self._unguarded_remove, self.key(), attachment_id) diff --git a/WebKitTools/QueueStatusServer/model/workitems_unittest.py b/WebKitTools/QueueStatusServer/model/workitems_unittest.py index d53302e..b1ff1d3 100644 --- a/WebKitTools/QueueStatusServer/model/workitems_unittest.py +++ b/WebKitTools/QueueStatusServer/model/workitems_unittest.py @@ -40,14 +40,6 @@ class WorkItemsTest(unittest.TestCase): self.assertEquals(items.display_position_for_attachment(1), 2) self.assertEquals(items.display_position_for_attachment(3), None) - def test_remove_work_item(self): - items = WorkItems() - items.item_ids = [0, 1, 2] - items.remove_work_item(0) - self.assertEqual(items.item_ids, [1, 2]) - items.remove_work_item(4) # Should not throw - self.assertEqual(items.item_ids, [1, 2]) - if __name__ == '__main__': unittest.main() |