diff options
Diffstat (limited to 'WebKitTools/Scripts/webkitpy/layout_tests/port/config_unittest.py')
| -rw-r--r-- | WebKitTools/Scripts/webkitpy/layout_tests/port/config_unittest.py | 167 |
1 files changed, 87 insertions, 80 deletions
diff --git a/WebKitTools/Scripts/webkitpy/layout_tests/port/config_unittest.py b/WebKitTools/Scripts/webkitpy/layout_tests/port/config_unittest.py index 4674cba..9bea014 100644 --- a/WebKitTools/Scripts/webkitpy/layout_tests/port/config_unittest.py +++ b/WebKitTools/Scripts/webkitpy/layout_tests/port/config_unittest.py @@ -26,150 +26,157 @@ # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. -import codecs import os -import StringIO +import sys import unittest +from webkitpy.common.system import executive +from webkitpy.common.system import executive_mock +from webkitpy.common.system import filesystem +from webkitpy.common.system import filesystem_mock from webkitpy.common.system import outputcapture import config - -# FIXME: This makes StringIO objects work with "with". Remove -# when we upgrade to 2.6. -class NewStringIO(StringIO.StringIO): - def __enter__(self): - return self - - def __exit__(self, type, value, traceback): - pass - - -class MockExecutive(object): - def __init__(self, output='', exit_code=0): - self._output = output - self._exit_code = exit_code - - def run_command(self, arg_list, return_exit_code=False, - decode_output=False): - if return_exit_code: - return self._exit_code - return self._output - - class ConfigTest(unittest.TestCase): def tearDown(self): config.clear_cached_configuration() - def assertConfiguration(self, contents, expected): - # This tests that a configuration file containing - # _contents_ endsd up being interpreted as _expected_. - # - # FIXME: rewrite this when we have a filesystem abstraction we - # can mock out more easily. - config.clear_cached_configuration() - orig_open = codecs.open - - def wrap_open(contents): - def open_wrapper(path, mode, encoding): - return NewStringIO(contents) - return open_wrapper + def make_config(self, output='', files={}, exit_code=0, exception=None): + e = executive_mock.MockExecutive2(output=output, exit_code=exit_code, + exception=exception) + fs = filesystem_mock.MockFileSystem(files) + return config.Config(e, fs) - try: - orig_exists = os.path.exists - os.path.exists = lambda p: True - codecs.open = wrap_open(contents) - - e = MockExecutive(output='foo') - c = config.Config(e) - self.assertEqual(c.default_configuration(), expected) - finally: - os.path.exists = orig_exists - codecs.open = orig_open + def assert_configuration(self, contents, expected): + # This tests that a configuration file containing + # _contents_ ends up being interpreted as _expected_. + c = self.make_config('foo', {'foo/Configuration': contents}) + self.assertEqual(c.default_configuration(), expected) def test_build_directory_toplevel(self): - e = MockExecutive(output="toplevel") - c = config.Config(e) + c = self.make_config('toplevel') self.assertEqual(c.build_directory(None), 'toplevel') # Test again to check caching self.assertEqual(c.build_directory(None), 'toplevel') def test_build_directory__release(self): - e = MockExecutive(output="release") - c = config.Config(e) + c = self.make_config('release') self.assertEqual(c.build_directory('Release'), 'release') def test_build_directory__debug(self): - e = MockExecutive(output="debug") - c = config.Config(e) + c = self.make_config('debug') self.assertEqual(c.build_directory('Debug'), 'debug') def test_build_directory__unknown(self): - e = MockExecutive(output="unknown") - c = config.Config(e) + c = self.make_config("unknown") self.assertRaises(KeyError, c.build_directory, 'Unknown') def test_build_dumprendertree__success(self): - e = MockExecutive(exit_code=0) - c = config.Config(e) + c = self.make_config(exit_code=0) self.assertTrue(c.build_dumprendertree("Debug")) self.assertTrue(c.build_dumprendertree("Release")) self.assertRaises(KeyError, c.build_dumprendertree, "Unknown") def test_build_dumprendertree__failure(self): - e = MockExecutive(exit_code=-1) - c = config.Config(e) + c = self.make_config(exit_code=-1) + # FIXME: Build failures should log errors. However, the message we + # get depends on how we're being called; as a standalone test, + # we'll get the "no handlers found" message. As part of + # test-webkitpy, we get the actual message. Really, we need + # outputcapture to install its own handler. oc = outputcapture.OutputCapture() oc.capture_output() self.assertFalse(c.build_dumprendertree('Debug')) - (out, err) = oc.restore_output() + oc.restore_output() oc.capture_output() self.assertFalse(c.build_dumprendertree('Release')) oc.restore_output() def test_default_configuration__release(self): - self.assertConfiguration('Release', 'Release') + self.assert_configuration('Release', 'Release') def test_default_configuration__debug(self): - self.assertConfiguration('Debug', 'Debug') + self.assert_configuration('Debug', 'Debug') def test_default_configuration__deployment(self): - self.assertConfiguration('Deployment', 'Release') + self.assert_configuration('Deployment', 'Release') def test_default_configuration__development(self): - self.assertConfiguration('Development', 'Debug') + self.assert_configuration('Development', 'Debug') def test_default_configuration__notfound(self): # This tests what happens if the default configuration file # doesn't exist. - config.clear_cached_configuration() - try: - orig_exists = os.path.exists - os.path.exists = lambda p: False - e = MockExecutive(output="foo") - c = config.Config(e) - self.assertEqual(c.default_configuration(), "Release") - finally: - os.path.exists = orig_exists + c = self.make_config(output='foo', files={'foo/Configuration': None}) + self.assertEqual(c.default_configuration(), "Release") def test_default_configuration__unknown(self): # Ignore the warning about an unknown configuration value. oc = outputcapture.OutputCapture() oc.capture_output() - self.assertConfiguration('Unknown', 'Unknown') + self.assert_configuration('Unknown', 'Unknown') oc.restore_output() - def test_path_from_webkit_base(self, *comps): - c = config.Config(None) + def test_default_configuration__standalone(self): + # FIXME: This test runs a standalone python script to test + # reading the default configuration to work around any possible + # caching / reset bugs. See https://bugs.webkit.org/show_bug?id=49360 + # for the motivation. We can remove this test when we remove the + # global configuration cache in config.py. + e = executive.Executive() + fs = filesystem.FileSystem() + c = config.Config(e, fs) + script = c.path_from_webkit_base('WebKitTools', 'Scripts', + 'webkitpy', 'layout_tests', 'port', 'config_standalone.py') + + # Note: don't use 'Release' here, since that's the normal default. + expected = 'Debug' + + args = [sys.executable, script, '--mock', expected] + actual = e.run_command(args).rstrip() + self.assertEqual(actual, expected) + + def test_default_configuration__no_perl(self): + # We need perl to run webkit-build-directory to find out where the + # default configuration file is. See what happens if perl isn't + # installed. (We should get the default value, 'Release'). + c = self.make_config(exception=OSError) + actual = c.default_configuration() + self.assertEqual(actual, 'Release') + + def test_default_configuration__scripterror(self): + # We run webkit-build-directory to find out where the default + # configuration file is. See what happens if that script fails. + # (We should get the default value, 'Release'). + c = self.make_config(exception=executive.ScriptError()) + actual = c.default_configuration() + self.assertEqual(actual, 'Release') + + def test_path_from_webkit_base(self): + # FIXME: We use a real filesystem here. Should this move to a + # mocked one? + c = config.Config(executive.Executive(), filesystem.FileSystem()) self.assertTrue(c.path_from_webkit_base('foo')) def test_webkit_base_dir(self): - c = config.Config(None) - self.assertTrue(c.webkit_base_dir()) + # FIXME: We use a real filesystem here. Should this move to a + # mocked one? + c = config.Config(executive.Executive(), filesystem.FileSystem()) + base_dir = c.webkit_base_dir() + self.assertTrue(base_dir) + + orig_cwd = os.getcwd() + os.chdir(os.environ['HOME']) + c = config.Config(executive.Executive(), filesystem.FileSystem()) + try: + base_dir_2 = c.webkit_base_dir() + self.assertEqual(base_dir, base_dir_2) + finally: + os.chdir(orig_cwd) if __name__ == '__main__': |