| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
WebkitTools/Scripts/create-html-entity-table was
added in http://trac.webkit.org/changeset/65351.
Change-Id: Iff5c7aaa13e79f3666ef4176ca12d284c985b005
|
|
|
|
|
|
|
|
|
|
| |
Removing call to Geolocation::stop(), which was lost in the
merge with http://trac.webkit.org/changeset/65416
We may still have memory leaks here. This is being tracked
in https://bugs.webkit.org/show_bug.cgi?id=39288
Change-Id: I69b75bf07775536ac603a450dbde8c2935c4db16
|
|
|
|
| |
Change-Id: Ifbf384f4531e3b58475a662e38195c2d9152ae79
|
|\
| |
| |
| | |
also fix Chrome issue32353 - need to patch to Chrome."
|
| |
| |
| |
| |
| |
| |
| | |
The change can also fix Chrome issue32353 - need to patch
to Chrome.
Change-Id: I08df08f2316156e78e9b63415e9c8720ab193090
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The older logic assumed that lines don't overlap, but in the
case of Google news, the lines do overlap. The new logic uses
the line centers for ordering.
Change-Id: I56074d289f76ed5027e3a498753caf50644b97f0
http://b/262451
|
|\ \ \ |
|
| | | |
| | | |
| | | |
| | | | |
Change-Id: If55cf19f648c58d0042925ad616c3357d7e136f0
|
|\ \ \ \
| |/ / / |
|
| | |/
| |/|
| | |
| | | |
Change-Id: I27900e81e58905c76fe9c62c532571451aa2abd7
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
There is a possible race condition between the IO thread finishing the request and
the WebCore thread cancelling it. If the request has already finished, ignore
subsequent calls to finish to avoid sending duplicate finish messages to WebCore.
Change-Id: I44f61c1b29baef686e59b66b40b32d9b1d9699c2
|
|/ /
| |
| |
| | |
Change-Id: I12d5632b37db581065db9bcbd49f3dc28ecd7719
|
|\ \ |
|
| | |
| | |
| | |
| | | |
Change-Id: Id7c2ae708c166da035f1fdda8351b921d86d78de
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Bug: 2582455
Never modify the focused state of the focus controller.
A corresponding java change make the active state get changed only when
the webview gains/loses focus.
Change-Id: I6f17f82c772ea4410c0209bf57d251c9bd384e6c
|
|\ \ \
| |/ /
|/| | |
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This allows web pages to have fine-grain control over the appearance
of the rings drawn around nodes.
Generated links (email, addresses, phone numbers) are no longer
given unique colors. To preserve this feature, a separate change
could add an HTML extension similar to vlink to provide the cursor
ring defintions for theses links. The mechanism implemented below
isn't appropriate since these links don't necessarily correspond to
single DOM nodes or other DOM elements.
------------
CSS examples
------------
The CSS to specify the ring looks like:
-webkit-ring-fill-color:rgba(0,0,255,0.4);
-webkit-ring-inner-width:2 px;
-webkit-ring-outer-width:3.5 px;
-webkit-ring-outset: 8 px;
-webkit-ring-pressed-inner-color:rgba(0,0,255,0.8);
-webkit-ring-pressed-outer-color:rgba(0,0,127,0.3);
-webkit-ring-radius: 10 px;
-webkit-ring-selected-inner-color:rgba(63,63,255,0.8);
-webkit-ring-selected-outer-color:rgba(63,63,127,0.3);
and may be alternately defined with a property shortcut:
-webkit-ring:rgba(255,0,0,0.4) 5px 7px
rgba(255,0,0,0.8) rgba(127,0,0,0.3) 20px
rgba(255,63,63,0.8) rgba(127,63,63,0.3);
--------------------
Property definitions
--------------------
A vertical cross-section of the ring corresponds to these
parameters as shown:
______
R / ___O_ R = corner radius
/ / __I_ o I = inner ring
/ / / _O_ ^ O = outer ring
| | | / F | F = fill
|O|I|O| L o = outset
| | | \_F_ | L = original link
\ \ \__O_ V
\ \___I_ o
R \____O_
The fill color specifies what to draw inside the ring
when the link is followed. The fill area consists of the
original link area plus the outset.
The inner and outer widths specify the stoke width of the inner
and outer rings, respectively. The widths may be specified in
fractional pixels. The implementation captures 4 bits of the
fraction.
The outset specifies the distance from the edge of the original
link to the rings' center. Both rings are drawn at the same center
location.
The radius specifies the curvature of the corners at the center
of the rings.
-------------
Data lifetime
-------------
The selected colors specify the colors of the inner and outer
rings when the trackball or D-pad hovers over the link. The
pressed colors specify the colors of the rings when the
trackball center is pressed or the link is tapped.
The CSS data is recorded in the RenderStyle when the DOM
is parsed. The widths are scaled up by 16 to preserve the fraction.
When the nav cache is built, the CSS style information is
recorded in the CachedColor class. Only unique style sets
are recorded; many CachedNode instances can share the same
CachedColor instance.
When the cursor ring is drawn, the CachedColor is
retrieved by getting the index from the CachedNode, and
looking up the entry in the CachedFrame. The widths are
scaled down by 16 since Lengths are stored by the webkit as
integers.
----------
File Edits
----------
WebCore/Android.derived.mk
- Build the CSS data property tables by concatentating
Android specific data and optionally SVG data.
WebCore/config.h
- Add switch for these rings. This switch is meant
as a convenience for finding the code in WebKit
that was added to enable this feature. Since the
old code in DrawCursor has been removed, it does
not revert to the old behavior if the switch is
turned off.
WebCore/css/AndroidCSSPropertyNames.in
- The new ring properties, plus an old one we
added before.
WebCore/css/CSSComputedStyleDeclaration.cpp
WebCore/css/CSSMutableStyleDeclaration.cpp
WebCore/css/CSSParser.cpp
WebCore/css/CSSStyleSelector.cpp
- I can guess what these functions are for as
well as anyone, but I really don't know. Do
I need all of them? Do I need to modify
Mutable at all?
WebCore/css/CSSPropertyNames.in
- Moved Android addition to AndroidCSSPropertyNames.in
WebCore/platform/graphics/Color.h
- Added initial color values here.
WebCore/platform/graphics/android/android_graphics.*
- This draws the cursor ring. The code that draws
'synthetic' links has been discarded.
WebCore/rendering/style/RenderStyle.h
- Functions to get, set, and initialize the style
data.
WebCore/rendering/style/StyleRareInheritedData.*
- The storage for the style data and an equivalence
function.
WebKit/Android.mk
- Added CachedColor to the build.
WebKit/android/nav/CacheBuilder.cpp
- Record the color from the DOM into the cache.
WebKit/android/nav/CachedColor.*
- Store the cached color info.
WebKit/android/nav/CachedFrame.*
- Where the array of colors is stored.
WebKit/android/nav/CachedNode.*
- Where the index to the colors is stored.
Change-Id: Ia3a931f41d6545e47678e245aafe7c84d4658f94
http://b/2603197
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
See https://android-git.corp.google.com/g/#change,61829
Bug: 2914450
Change-Id: Ica6864fc4dc28d92b1a98eee3c588e4007b7e803
|
|\ \ \ |
|
| | |/
| |/|
| | |
| | | |
Change-Id: Ib44e439bc272810e409f61477612dbbf30bb6371
|
|/ /
| |
| |
| |
| |
| |
| |
| | |
Adding alternate http in the end of the UA string to identify which http stack is used.
Finally, cleaning up some old includes.
Change-Id: If165403a066009ca85dbf28d6024f1419cfae4fa
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We used to use the ARCH_ARM_HAVE_VFP build flag to determine which
JS engine to use as we wanted to use JSC for performance reasons
on older hardware. This is not necessary anymore and so unless
specified with the JS_ENGINE environment variable or when building
on the simulator, we default to V8 instead of JSC.
Change-Id: I773af968d5a7e7a7882d8763de4f90f1d08104b3
|
|/ /
| |
| |
| |
| | |
Bug: 2928878, 2928899
Change-Id: I90ca6f93a61c921b520731e6a143e5b4457fa44c
|
| |
| |
| |
| | |
Change-Id: Ib097f8fda80cf33185d9b6a3a00a47ca83a7e678
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | | |
Bug: 2809660
Change-Id: Idb0bdc33dae6e1148dc92ff1d0137550cc054e3a
|
|\ \ \
| |/ /
|/| |
| | |
| | |
| | |
| | |
| | |
| | | |
WebCoreFrameBridge.cpp
Merge commit '3c54ece08a0ea9e5dc5d5788a4c49c8dc94b501f'
* commit '3c54ece08a0ea9e5dc5d5788a4c49c8dc94b501f':
activeDocumentLoader() causes crash in WebCoreFrameBridge.cpp
|
| |\ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Merge commit '5dc34a8555dde1ae4a2c174870c4296cc44f8a22' into gingerbread-plus-aosp
* commit '5dc34a8555dde1ae4a2c174870c4296cc44f8a22':
activeDocumentLoader() causes crash in WebCoreFrameBridge.cpp
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This is a fix for a crash found in real phones, there is cases when
activeDocumentLoader() can return null, probably related to closing of a
frame or canceling of a request.
Change-Id: Id340ab006b6e40e396645a4e668dcb58824a63e7
|
|\ \ \ \ |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
In Apple's DerivedSources.make, XLinkNames are built all the time.
Change our Android.derived.mk to do the same, instead of only
building when SVG is enabled.
Change-Id: I69d903788e4416e2140068f2aa907d65b336ce68
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Originally written in response to bug 2835685, which was
fixed in
https://android-git.corp.google.com/g/#change,61059
WebViewCore.cpp:
Send a message to clear the text input/remove the soft
keyboard if the click results in no text input field
being in focus.
WebView.cpp:
Remove the old checks to clear the WebTextView, which
is now done in WebViewCore.cpp. This makes clearing it
consistent with the checks for opening the WebTextView.
Change-Id: I06ba7aadc95302c90af67da16edccd46896fcdbf
|
|\ \ \ \ \ |
|
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Set the foreground clip after drawing. Use the absolute bounds to
compute the local foreground clip in order to compensate for any
outline.
Consolidate the check for overflow scrolling into RenderLayer.
Request a compositing update after computing the scroll dimensions.
Only change the foregroundRect of the layer during paint so that the
outline rect (and background/layerBounds) are correct.
Draw the outline as part of the background phase. During painting of
a layer, scroll to (0,0), paint, then scroll back.
When clicking on an element in a layer, scroll to the position of the
element but do not scroll back. This makes text input fields visible
to the tree and will properly update when typing. Record the original
scroll position of layers in order to offset the bounds of nodes when
checking the nav cache. Make sure to reset all cached layers during
setRootLayer. Otherwise we were reaching into layers from the wrong
thread.
Change-Id: Id9827ec461989b0869a8252d4d2563ecd12c5fac
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The new net stack has dependencies on V8 and so we cannot use it
in conjunction with JSC.
Fix b/2920038
Change-Id: If39db4732a66b6d3c25dba8816a3205d2bb55777
|
| |_|/
|/| |
| | |
| | | |
Change-Id: I31c2c983f0b04db6fb5d2c4ccbe0ea837fc7db2b
|
|\ \ \
| | | |
| | | |
| | | | |
all the files under given path."
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
files under given path.
Change-Id: Iac6025007a549833bf8065dacd50f942b1b2f643
|
| | | |
| | | |
| | | |
| | | | |
Change-Id: Ib30b205797425debfb48318fa9de7a9fc5cc45e0
|
|\ \ \ \ |
|
| | | | |
| | | | |
| | | | |
| | | | | |
Change-Id: I950f48ae3edaf48c1f4da1ca926683ad075ad094
|
|\ \ \ \ \
| |/ / / /
|/| | | |
| | | | | |
default"
|
| | | | |
| | | | |
| | | | |
| | | | | |
Change-Id: I2e1c3431ae16292942a360e636725e39229481b5
|
| | | | |
| | | | |
| | | | |
| | | | | |
Change-Id: I20f36620033e6249fe5b749ae74392e2ac64c09c
|
|\ \ \ \ \
| |/ / / /
|/| | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
I60a96064,I6929172f,Idefd9bec,I8cf448f2,I8791737a,I992c56b0,Ibb4b089d,I779a8ec0,Ife412e30,I2da1ae98,Ibcf41849
* changes:
Merge WebKit at r65072 : Update WebKit revision number.
Merge WebKit at r65072 : Update test_expectations.
Merge WebKit at r65072 : Complete cherry-pick of WebKit change 43848 to add EmptyDeviceMotionClient
Merge WebKit at r65072 : Implement DeviceMotionClientAndroid
Merge WebKit at r65072: JSC build fix in InspectorController.h
Merge WebKit at r65072: Fix V8 code generator.
Merge WebKit at r65072 : Build fix for JSC, update ambiguous usage of JSLock.
Merge WebKit at r65072: String class has moved to the WTF namespace.
Merge Webkit at r65072 : Fix conflicts.
Merge Webkit at r65072 : Fix Makefiles.
Merge WebKit at r65072 : Initial merge by git.
|
| | | | |
| | | | |
| | | | |
| | | | | |
Change-Id: I60a9606437bd1de3df767459641a02e594e18ffa
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This merge introduces two new Geolocation tests that to pass we need
a new LayoutTestController function. We ignore those tests until this
function is added - see b/2914450
Change-Id: I6929172fd6822b3c2c588693d743362f7edbca4f
|