1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
|
# Copyright (c) 2009 Google Inc. All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions are
# met:
#
# * Redistributions of source code must retain the above copyright
# notice, this list of conditions and the following disclaimer.
# * Redistributions in binary form must reproduce the above
# copyright notice, this list of conditions and the following disclaimer
# in the documentation and/or other materials provided with the
# distribution.
# * Neither the name of Google Inc. nor the names of its
# contributors may be used to endorse or promote products derived from
# this software without specific prior written permission.
#
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
from webkitpy.tool.commands.queues import AbstractReviewQueue
from webkitpy.common.config.committers import CommitterList
from webkitpy.common.config.ports import WebKitPort
from webkitpy.common.system.executive import ScriptError
from webkitpy.tool.bot.queueengine import QueueEngine
class AbstractEarlyWarningSystem(AbstractReviewQueue):
_build_style = "release"
def __init__(self):
AbstractReviewQueue.__init__(self)
self.port = WebKitPort.port(self.port_name)
def should_proceed_with_work_item(self, patch):
return True
def _can_build(self):
try:
self.run_webkit_patch([
"build",
self.port.flag(),
"--build-style=%s" % self._build_style,
"--force-clean",
"--no-update"])
return True
except ScriptError, e:
failure_log = self._log_from_script_error_for_upload(e)
self._update_status("Unable to perform a build", results_file=failure_log)
return False
def _build(self, patch, first_run=False):
try:
args = [
"build-attachment",
self.port.flag(),
"--build",
"--build-style=%s" % self._build_style,
"--force-clean",
"--quiet",
"--non-interactive",
patch.id()]
if not first_run:
# See commit-queue for an explanation of what we're doing here.
args.append("--no-update")
args.append("--parent-command=%s" % self.name)
self.run_webkit_patch(args)
return True
except ScriptError, e:
if first_run:
return False
raise
def review_patch(self, patch):
if patch.is_obsolete():
self._did_error(patch, "%s does not process obsolete patches." % self.name)
return False
if patch.bug().is_closed():
self._did_error(patch, "%s does not process patches on closed bugs." % self.name)
return False
if not self._build(patch, first_run=True):
if not self._can_build():
return False
self._build(patch)
return True
@classmethod
def handle_script_error(cls, tool, state, script_error):
is_svn_apply = script_error.command_name() == "svn-apply"
status_id = cls._update_status_for_script_error(tool, state, script_error, is_error=is_svn_apply)
if is_svn_apply:
QueueEngine.exit_after_handled_error(script_error)
results_link = tool.status_server.results_url_for_status(status_id)
message = "Attachment %s did not build on %s:\nBuild output: %s" % (state["patch"].id(), cls.port_name, results_link)
tool.bugs.post_comment_to_bug(state["patch"].bug_id(), message, cc=cls.watchers)
exit(1)
class GtkEWS(AbstractEarlyWarningSystem):
name = "gtk-ews"
port_name = "gtk"
watchers = AbstractEarlyWarningSystem.watchers + [
"gns@gnome.org",
"xan.lopez@gmail.com",
]
class EflEWS(AbstractEarlyWarningSystem):
name = "efl-ews"
port_name = "efl"
watchers = AbstractEarlyWarningSystem.watchers + [
"leandro@profusion.mobi",
"antognolli@profusion.mobi",
"lucas.demarchi@profusion.mobi",
"gyuyoung.kim@samsung.com",
]
class QtEWS(AbstractEarlyWarningSystem):
name = "qt-ews"
port_name = "qt"
class WinEWS(AbstractEarlyWarningSystem):
name = "win-ews"
port_name = "win"
# Use debug, the Apple Win port fails to link Release on 32-bit Windows.
# https://bugs.webkit.org/show_bug.cgi?id=39197
_build_style = "debug"
class AbstractChromiumEWS(AbstractEarlyWarningSystem):
port_name = "chromium"
watchers = AbstractEarlyWarningSystem.watchers + [
"dglazkov@chromium.org",
]
class ChromiumLinuxEWS(AbstractChromiumEWS):
# FIXME: We should rename this command to cr-linux-ews, but that requires
# a database migration. :(
name = "chromium-ews"
class ChromiumWindowsEWS(AbstractChromiumEWS):
name = "cr-win-ews"
# For platforms that we can't run inside a VM (like Mac OS X), we require
# patches to be uploaded by committers, who are generally trustworthy folk. :)
class AbstractCommitterOnlyEWS(AbstractEarlyWarningSystem):
def __init__(self, committers=CommitterList()):
AbstractEarlyWarningSystem.__init__(self)
self._committers = committers
def process_work_item(self, patch):
if not self._committers.committer_by_email(patch.attacher_email()):
self._did_error(patch, "%s cannot process patches from non-committers :(" % self.name)
return False
return AbstractEarlyWarningSystem.process_work_item(self, patch)
# FIXME: Inheriting from AbstractCommitterOnlyEWS is kinda a hack, but it
# happens to work because AbstractChromiumEWS and AbstractCommitterOnlyEWS
# provide disjoint sets of functionality, and Python is otherwise smart
# enough to handle the diamond inheritance.
class ChromiumMacEWS(AbstractChromiumEWS, AbstractCommitterOnlyEWS):
name = "cr-mac-ews"
class MacEWS(AbstractCommitterOnlyEWS):
name = "mac-ews"
port_name = "mac"
|
