1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
1650
1651
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
1698
1699
1700
1701
1702
1703
1704
1705
1706
1707
1708
1709
1710
1711
1712
1713
1714
1715
1716
1717
1718
1719
1720
1721
1722
1723
1724
1725
1726
1727
1728
1729
1730
1731
1732
1733
1734
1735
1736
1737
1738
1739
1740
1741
1742
1743
1744
1745
1746
1747
1748
1749
1750
1751
1752
1753
1754
1755
1756
1757
1758
1759
1760
1761
1762
1763
1764
1765
1766
1767
1768
1769
1770
1771
1772
1773
1774
1775
1776
1777
1778
1779
1780
1781
1782
1783
1784
1785
1786
1787
1788
1789
1790
1791
1792
1793
1794
1795
1796
1797
1798
1799
1800
1801
1802
1803
1804
1805
1806
1807
1808
1809
1810
1811
1812
1813
1814
1815
1816
1817
1818
1819
1820
1821
1822
1823
1824
1825
1826
1827
1828
1829
1830
1831
1832
1833
1834
1835
1836
1837
1838
1839
1840
1841
1842
1843
1844
1845
1846
1847
1848
1849
1850
1851
1852
1853
1854
1855
1856
1857
1858
1859
1860
1861
1862
1863
1864
1865
1866
1867
1868
1869
1870
1871
1872
1873
1874
1875
1876
1877
1878
1879
1880
1881
1882
1883
1884
1885
1886
1887
1888
1889
1890
1891
1892
1893
1894
1895
1896
1897
1898
1899
1900
1901
1902
1903
1904
1905
1906
1907
1908
1909
1910
1911
1912
1913
1914
1915
1916
1917
1918
1919
1920
1921
1922
1923
1924
1925
1926
1927
1928
1929
1930
1931
1932
1933
1934
1935
1936
1937
1938
1939
1940
1941
1942
1943
1944
1945
1946
1947
1948
1949
1950
1951
1952
1953
1954
1955
1956
1957
1958
1959
1960
1961
1962
1963
1964
1965
1966
1967
1968
1969
1970
1971
1972
1973
1974
1975
1976
1977
1978
1979
1980
1981
1982
1983
1984
1985
1986
1987
1988
1989
1990
1991
1992
1993
1994
1995
1996
1997
1998
1999
2000
2001
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2013
2014
2015
2016
2017
2018
2019
2020
2021
2022
2023
2024
2025
2026
2027
2028
2029
2030
2031
2032
2033
2034
2035
2036
2037
2038
2039
2040
2041
2042
2043
2044
2045
2046
2047
2048
2049
2050
2051
2052
2053
2054
2055
2056
2057
2058
2059
2060
2061
2062
2063
2064
2065
2066
2067
2068
2069
2070
2071
2072
2073
2074
2075
2076
2077
2078
2079
2080
2081
2082
2083
2084
2085
2086
2087
2088
2089
2090
2091
2092
2093
2094
2095
2096
2097
2098
2099
2100
2101
2102
2103
2104
2105
2106
2107
2108
2109
2110
2111
2112
2113
2114
2115
2116
2117
2118
2119
2120
2121
2122
2123
2124
2125
2126
2127
2128
2129
2130
2131
2132
2133
2134
2135
2136
2137
2138
2139
2140
2141
2142
2143
2144
2145
2146
2147
2148
2149
2150
2151
2152
2153
2154
2155
2156
2157
2158
2159
2160
2161
2162
2163
2164
2165
2166
2167
2168
2169
2170
2171
2172
2173
2174
2175
2176
2177
2178
2179
2180
2181
2182
2183
2184
2185
2186
2187
2188
2189
2190
2191
2192
2193
2194
2195
2196
2197
2198
2199
2200
2201
2202
2203
2204
2205
2206
2207
2208
2209
2210
2211
2212
2213
2214
2215
2216
2217
2218
2219
2220
2221
2222
2223
2224
2225
2226
2227
2228
2229
2230
2231
2232
2233
2234
2235
2236
2237
2238
2239
2240
2241
2242
2243
2244
2245
2246
2247
2248
2249
2250
2251
2252
2253
2254
2255
2256
2257
2258
2259
2260
2261
2262
2263
2264
2265
2266
2267
2268
2269
2270
2271
2272
2273
2274
2275
2276
2277
2278
2279
2280
2281
2282
2283
2284
2285
2286
2287
2288
2289
2290
2291
2292
2293
2294
2295
2296
2297
2298
2299
2300
2301
2302
2303
2304
2305
2306
2307
2308
2309
2310
2311
2312
2313
2314
2315
2316
2317
2318
2319
2320
2321
2322
2323
2324
2325
2326
2327
2328
2329
2330
2331
2332
2333
2334
2335
2336
2337
2338
2339
2340
2341
2342
2343
2344
2345
2346
2347
2348
2349
2350
2351
2352
2353
2354
2355
2356
2357
2358
2359
2360
2361
2362
2363
2364
2365
2366
2367
2368
2369
2370
2371
2372
2373
2374
2375
2376
2377
2378
2379
2380
2381
2382
2383
2384
2385
2386
2387
2388
2389
2390
2391
2392
2393
2394
2395
2396
2397
2398
2399
2400
2401
2402
2403
2404
2405
2406
2407
2408
2409
2410
2411
2412
2413
2414
2415
2416
2417
2418
2419
2420
2421
2422
2423
2424
2425
2426
2427
2428
2429
2430
2431
2432
2433
2434
2435
2436
2437
2438
2439
2440
2441
2442
2443
2444
2445
2446
2447
2448
2449
2450
2451
2452
2453
2454
2455
2456
2457
2458
2459
2460
2461
2462
2463
2464
2465
2466
2467
2468
2469
2470
2471
2472
2473
2474
2475
2476
2477
2478
2479
2480
2481
2482
2483
2484
2485
2486
2487
2488
2489
2490
2491
2492
2493
2494
2495
2496
2497
2498
2499
2500
2501
2502
2503
2504
2505
2506
2507
2508
2509
2510
2511
2512
2513
2514
2515
2516
2517
2518
2519
2520
2521
2522
2523
2524
2525
2526
2527
2528
2529
2530
2531
2532
2533
2534
2535
2536
2537
2538
2539
2540
2541
2542
2543
2544
2545
2546
2547
2548
2549
2550
2551
2552
2553
2554
2555
2556
2557
2558
2559
2560
2561
2562
2563
2564
2565
2566
2567
2568
2569
2570
2571
2572
2573
2574
2575
2576
2577
2578
2579
2580
2581
2582
2583
2584
2585
2586
2587
2588
2589
2590
2591
2592
2593
2594
2595
2596
2597
2598
2599
2600
2601
2602
2603
2604
2605
2606
2607
2608
2609
2610
2611
2612
2613
2614
2615
2616
2617
2618
2619
2620
2621
2622
2623
2624
2625
2626
2627
2628
2629
2630
2631
2632
2633
2634
2635
2636
2637
2638
2639
2640
2641
2642
2643
2644
2645
2646
2647
2648
2649
2650
2651
2652
2653
2654
2655
2656
2657
2658
2659
2660
2661
2662
2663
2664
2665
2666
2667
2668
2669
2670
2671
2672
2673
2674
2675
2676
2677
2678
2679
2680
2681
2682
2683
2684
2685
2686
2687
2688
2689
2690
2691
2692
2693
2694
2695
2696
2697
2698
2699
2700
2701
2702
2703
2704
2705
2706
2707
2708
2709
2710
2711
2712
2713
2714
2715
2716
2717
2718
2719
2720
2721
2722
2723
2724
2725
2726
2727
2728
2729
2730
2731
2732
2733
2734
2735
2736
2737
2738
2739
2740
2741
2742
2743
2744
2745
2746
2747
2748
2749
2750
2751
2752
2753
2754
2755
2756
2757
2758
2759
2760
2761
2762
2763
2764
2765
2766
2767
2768
2769
2770
2771
2772
2773
2774
2775
2776
2777
2778
2779
2780
2781
2782
2783
2784
2785
2786
2787
2788
2789
2790
2791
2792
2793
2794
2795
2796
2797
2798
2799
2800
2801
2802
2803
2804
2805
2806
2807
2808
2809
2810
2811
2812
2813
2814
2815
2816
2817
2818
2819
2820
2821
2822
2823
2824
2825
2826
2827
2828
2829
2830
2831
2832
2833
2834
2835
2836
2837
2838
2839
2840
2841
2842
2843
2844
2845
2846
2847
2848
2849
2850
2851
2852
2853
2854
2855
2856
2857
2858
2859
2860
2861
2862
2863
2864
2865
2866
2867
2868
2869
2870
2871
2872
2873
2874
2875
2876
2877
2878
2879
2880
2881
2882
2883
2884
2885
2886
2887
2888
2889
2890
2891
2892
2893
2894
2895
2896
2897
2898
2899
2900
2901
2902
2903
2904
2905
2906
2907
2908
2909
2910
2911
2912
2913
2914
2915
2916
2917
2918
2919
2920
2921
2922
2923
2924
2925
2926
2927
2928
2929
2930
2931
2932
2933
2934
2935
2936
2937
2938
2939
2940
2941
2942
2943
2944
2945
2946
2947
2948
2949
2950
2951
2952
2953
2954
2955
2956
2957
2958
2959
2960
2961
2962
2963
2964
2965
2966
2967
2968
2969
2970
2971
2972
2973
2974
2975
2976
2977
2978
2979
2980
2981
2982
2983
2984
2985
2986
2987
2988
2989
2990
2991
2992
2993
2994
2995
2996
2997
2998
2999
3000
3001
3002
3003
3004
3005
3006
3007
3008
3009
3010
3011
3012
3013
3014
3015
3016
3017
3018
3019
3020
3021
3022
3023
3024
3025
3026
3027
3028
3029
3030
3031
3032
3033
3034
3035
3036
3037
3038
3039
3040
3041
3042
3043
3044
3045
3046
3047
3048
3049
3050
3051
3052
3053
3054
3055
3056
3057
3058
3059
3060
3061
3062
3063
3064
3065
3066
3067
3068
3069
3070
3071
3072
3073
3074
3075
3076
3077
3078
3079
3080
3081
3082
3083
3084
3085
3086
3087
3088
3089
3090
3091
3092
3093
3094
3095
3096
3097
3098
3099
3100
3101
3102
3103
3104
3105
3106
3107
3108
3109
3110
3111
3112
3113
3114
3115
3116
3117
3118
3119
3120
3121
3122
3123
3124
3125
3126
3127
3128
3129
3130
3131
3132
3133
3134
3135
3136
3137
3138
3139
3140
3141
3142
3143
3144
3145
3146
3147
3148
3149
3150
3151
3152
3153
3154
3155
3156
3157
3158
3159
3160
3161
3162
3163
3164
3165
3166
3167
3168
3169
3170
3171
3172
3173
3174
3175
3176
3177
3178
3179
3180
3181
3182
3183
3184
3185
3186
3187
3188
3189
3190
3191
3192
3193
3194
3195
3196
3197
3198
3199
3200
3201
3202
3203
3204
3205
3206
3207
3208
3209
3210
3211
3212
3213
3214
3215
3216
3217
3218
3219
3220
3221
3222
3223
3224
3225
3226
3227
3228
3229
3230
3231
3232
3233
3234
3235
3236
3237
3238
3239
3240
3241
3242
3243
3244
3245
3246
3247
3248
3249
3250
3251
3252
3253
3254
3255
3256
3257
3258
3259
3260
3261
3262
3263
3264
3265
3266
3267
3268
3269
3270
3271
3272
3273
3274
3275
3276
3277
3278
3279
3280
3281
3282
3283
3284
3285
3286
3287
3288
3289
3290
3291
3292
3293
3294
3295
3296
3297
3298
3299
3300
3301
3302
3303
3304
3305
3306
3307
3308
3309
3310
3311
3312
3313
3314
3315
3316
3317
3318
3319
3320
3321
3322
3323
3324
3325
3326
3327
3328
3329
3330
3331
3332
3333
3334
3335
3336
3337
3338
3339
3340
3341
3342
3343
3344
3345
3346
3347
3348
3349
3350
3351
3352
3353
3354
3355
3356
3357
3358
3359
3360
3361
3362
3363
3364
3365
3366
3367
3368
3369
3370
3371
3372
3373
3374
3375
3376
3377
3378
3379
3380
3381
3382
3383
3384
3385
3386
3387
3388
3389
3390
3391
3392
3393
3394
3395
3396
3397
3398
3399
3400
3401
3402
3403
3404
3405
3406
3407
3408
3409
3410
3411
3412
3413
3414
3415
3416
3417
3418
3419
3420
3421
3422
3423
3424
3425
3426
3427
3428
3429
3430
3431
3432
3433
3434
3435
3436
3437
3438
3439
3440
3441
3442
3443
3444
3445
3446
3447
3448
3449
3450
3451
3452
3453
3454
3455
3456
3457
3458
3459
3460
3461
3462
3463
3464
3465
3466
3467
3468
3469
3470
3471
3472
3473
3474
3475
3476
3477
3478
3479
3480
3481
3482
3483
3484
3485
3486
3487
3488
3489
3490
3491
3492
3493
3494
3495
3496
3497
3498
3499
3500
3501
3502
3503
3504
3505
3506
3507
3508
3509
3510
3511
3512
3513
3514
3515
3516
3517
3518
3519
3520
3521
3522
3523
3524
3525
3526
3527
3528
3529
3530
3531
3532
3533
3534
3535
3536
3537
3538
3539
3540
3541
3542
3543
3544
3545
3546
3547
3548
3549
3550
3551
3552
3553
3554
3555
3556
3557
3558
3559
3560
3561
3562
3563
3564
3565
3566
3567
3568
3569
3570
3571
3572
3573
3574
3575
3576
3577
3578
3579
3580
3581
3582
3583
3584
3585
3586
3587
3588
3589
3590
3591
3592
3593
3594
3595
3596
3597
3598
3599
3600
3601
3602
3603
3604
3605
3606
3607
3608
3609
3610
3611
3612
3613
3614
3615
3616
3617
3618
3619
3620
3621
3622
3623
3624
3625
3626
3627
3628
3629
3630
3631
3632
3633
3634
3635
3636
3637
3638
3639
3640
3641
3642
3643
3644
3645
3646
3647
3648
3649
3650
3651
3652
3653
3654
3655
3656
3657
3658
3659
3660
3661
3662
3663
3664
3665
3666
3667
3668
3669
3670
3671
3672
3673
3674
3675
3676
3677
3678
3679
3680
3681
3682
3683
3684
3685
3686
3687
3688
3689
3690
3691
3692
3693
3694
3695
3696
3697
3698
3699
3700
3701
3702
3703
3704
3705
3706
3707
3708
3709
3710
3711
3712
3713
3714
3715
3716
3717
3718
3719
3720
3721
3722
3723
3724
3725
3726
3727
3728
3729
3730
3731
3732
3733
3734
3735
3736
3737
3738
3739
3740
3741
3742
3743
3744
3745
3746
3747
3748
3749
3750
3751
3752
3753
3754
3755
3756
3757
3758
3759
3760
3761
3762
3763
3764
3765
3766
3767
3768
3769
3770
3771
3772
3773
3774
3775
3776
3777
3778
3779
3780
3781
3782
3783
3784
3785
3786
3787
3788
3789
3790
3791
3792
3793
3794
3795
3796
3797
3798
3799
3800
3801
3802
3803
3804
3805
3806
3807
3808
3809
3810
3811
3812
3813
3814
3815
3816
3817
3818
3819
3820
3821
3822
3823
3824
3825
3826
3827
3828
3829
3830
3831
3832
3833
3834
3835
3836
3837
3838
3839
3840
3841
3842
3843
3844
3845
3846
3847
3848
3849
3850
3851
3852
3853
3854
3855
3856
3857
3858
3859
3860
3861
3862
3863
3864
3865
3866
3867
3868
3869
3870
3871
3872
3873
3874
3875
3876
3877
3878
3879
3880
3881
3882
3883
3884
3885
3886
3887
3888
3889
3890
3891
3892
3893
3894
3895
3896
3897
3898
3899
3900
3901
3902
3903
3904
3905
3906
3907
3908
3909
3910
3911
3912
3913
3914
3915
3916
3917
3918
3919
3920
3921
3922
3923
3924
3925
3926
3927
3928
3929
3930
3931
3932
3933
3934
3935
3936
3937
3938
3939
3940
3941
3942
3943
3944
3945
3946
3947
3948
3949
3950
3951
3952
3953
3954
3955
3956
3957
3958
3959
3960
3961
3962
3963
3964
3965
3966
3967
3968
3969
3970
3971
3972
3973
3974
3975
3976
3977
3978
3979
3980
3981
3982
3983
3984
3985
3986
3987
3988
3989
3990
3991
3992
3993
3994
3995
3996
3997
3998
3999
4000
4001
4002
4003
4004
4005
4006
4007
4008
4009
4010
4011
4012
4013
4014
4015
4016
4017
4018
4019
4020
4021
4022
4023
4024
4025
4026
4027
4028
4029
4030
4031
4032
4033
4034
4035
4036
4037
4038
4039
4040
4041
4042
4043
4044
4045
4046
4047
4048
4049
4050
4051
4052
4053
4054
4055
4056
4057
4058
4059
4060
4061
4062
4063
4064
4065
4066
4067
4068
4069
4070
4071
4072
4073
4074
4075
4076
4077
4078
4079
4080
4081
4082
4083
4084
4085
4086
4087
4088
4089
4090
4091
4092
4093
4094
4095
4096
4097
4098
4099
4100
4101
4102
4103
4104
4105
4106
4107
4108
4109
4110
4111
4112
4113
4114
4115
4116
4117
4118
4119
4120
4121
4122
4123
4124
4125
4126
4127
4128
4129
4130
4131
4132
4133
4134
4135
4136
4137
4138
4139
4140
4141
4142
4143
4144
4145
4146
4147
4148
4149
4150
4151
4152
4153
4154
4155
4156
4157
4158
4159
4160
4161
4162
4163
4164
4165
4166
4167
4168
4169
4170
4171
4172
4173
4174
4175
4176
4177
4178
4179
4180
4181
4182
4183
4184
4185
4186
4187
4188
4189
4190
4191
4192
4193
4194
4195
4196
4197
4198
4199
4200
4201
4202
4203
4204
4205
4206
4207
4208
4209
4210
4211
4212
4213
4214
4215
4216
4217
4218
4219
4220
4221
4222
4223
4224
4225
4226
4227
4228
4229
4230
4231
4232
4233
4234
4235
4236
4237
4238
4239
4240
4241
4242
4243
4244
4245
4246
4247
4248
4249
4250
4251
4252
4253
4254
4255
4256
4257
4258
4259
4260
4261
4262
4263
4264
4265
4266
4267
4268
4269
4270
4271
4272
4273
4274
4275
4276
4277
4278
4279
4280
4281
4282
4283
4284
4285
4286
4287
4288
4289
4290
4291
4292
4293
4294
4295
4296
4297
4298
4299
4300
4301
4302
4303
4304
4305
4306
4307
4308
4309
4310
4311
4312
4313
4314
4315
4316
4317
4318
4319
4320
4321
4322
4323
4324
4325
4326
4327
4328
4329
4330
4331
4332
4333
4334
4335
4336
4337
4338
4339
4340
4341
4342
4343
4344
4345
4346
4347
4348
4349
4350
4351
4352
4353
4354
4355
4356
4357
4358
4359
4360
4361
4362
4363
4364
4365
4366
4367
4368
4369
4370
4371
4372
4373
4374
4375
4376
4377
4378
4379
4380
4381
4382
4383
4384
4385
4386
4387
4388
4389
4390
4391
4392
4393
4394
4395
4396
4397
4398
4399
4400
4401
4402
4403
4404
4405
4406
4407
4408
4409
4410
4411
4412
4413
4414
4415
4416
4417
4418
4419
4420
4421
4422
4423
4424
4425
4426
4427
4428
4429
4430
4431
4432
4433
4434
4435
4436
4437
4438
4439
4440
4441
4442
4443
4444
4445
4446
4447
4448
4449
4450
4451
4452
4453
4454
4455
4456
4457
4458
4459
4460
4461
4462
4463
4464
4465
4466
4467
4468
4469
4470
4471
4472
4473
4474
4475
4476
4477
4478
4479
4480
4481
4482
4483
4484
4485
4486
4487
4488
4489
4490
4491
4492
4493
4494
4495
4496
4497
4498
4499
4500
4501
4502
4503
4504
4505
4506
4507
4508
4509
4510
4511
4512
4513
4514
4515
4516
4517
4518
4519
4520
4521
4522
4523
4524
4525
4526
4527
4528
4529
4530
4531
4532
4533
4534
4535
4536
4537
4538
4539
4540
4541
4542
4543
4544
4545
4546
4547
4548
4549
4550
4551
4552
4553
4554
4555
4556
4557
4558
4559
4560
4561
4562
4563
4564
4565
4566
4567
4568
4569
4570
4571
4572
4573
4574
4575
4576
4577
4578
4579
4580
4581
4582
4583
4584
4585
4586
4587
4588
4589
4590
4591
4592
4593
4594
4595
4596
4597
4598
4599
4600
4601
4602
4603
4604
4605
4606
4607
4608
4609
4610
4611
4612
4613
4614
4615
4616
4617
4618
4619
4620
4621
4622
4623
4624
4625
4626
4627
4628
4629
4630
4631
4632
4633
4634
4635
4636
4637
4638
4639
4640
4641
4642
4643
4644
4645
4646
4647
4648
4649
4650
4651
4652
4653
4654
4655
4656
4657
4658
4659
4660
4661
4662
4663
4664
4665
4666
4667
4668
4669
4670
4671
4672
4673
4674
4675
4676
4677
4678
4679
4680
4681
4682
4683
4684
4685
4686
4687
4688
4689
4690
4691
4692
4693
4694
4695
4696
4697
4698
4699
4700
4701
4702
4703
4704
4705
4706
4707
4708
4709
4710
4711
4712
4713
4714
4715
4716
4717
4718
4719
4720
4721
4722
4723
4724
4725
4726
4727
4728
4729
4730
4731
4732
4733
4734
4735
4736
4737
4738
4739
4740
4741
4742
4743
4744
4745
4746
4747
4748
4749
4750
4751
4752
4753
4754
4755
4756
4757
4758
4759
4760
4761
4762
4763
4764
4765
4766
4767
4768
4769
4770
4771
4772
4773
4774
4775
4776
4777
4778
4779
4780
4781
4782
4783
4784
4785
4786
4787
4788
4789
4790
4791
4792
4793
4794
4795
4796
4797
4798
4799
4800
4801
4802
4803
4804
4805
4806
4807
4808
4809
4810
4811
4812
4813
4814
4815
4816
4817
4818
4819
4820
4821
4822
4823
4824
4825
4826
4827
4828
4829
4830
4831
4832
4833
4834
4835
4836
4837
4838
4839
4840
4841
4842
4843
4844
4845
4846
4847
4848
4849
4850
4851
4852
4853
4854
4855
4856
4857
4858
4859
4860
4861
4862
4863
4864
4865
4866
4867
4868
4869
4870
4871
4872
4873
4874
4875
4876
4877
4878
4879
4880
4881
4882
4883
4884
4885
4886
4887
4888
4889
4890
4891
4892
4893
4894
4895
4896
4897
4898
4899
4900
4901
4902
4903
4904
4905
4906
4907
4908
4909
4910
4911
4912
4913
4914
4915
4916
4917
4918
4919
4920
4921
4922
4923
4924
4925
4926
4927
4928
4929
4930
4931
4932
4933
4934
4935
4936
4937
4938
4939
4940
4941
4942
4943
4944
4945
4946
4947
4948
4949
4950
4951
4952
4953
4954
4955
4956
4957
4958
4959
4960
4961
4962
4963
4964
4965
4966
4967
4968
4969
4970
4971
4972
4973
4974
4975
4976
4977
4978
4979
4980
4981
4982
4983
4984
4985
4986
4987
4988
4989
4990
4991
4992
4993
4994
4995
4996
4997
4998
4999
5000
5001
5002
5003
5004
5005
5006
5007
5008
5009
5010
5011
5012
5013
5014
5015
5016
5017
5018
5019
5020
5021
5022
5023
5024
5025
5026
5027
5028
5029
5030
5031
5032
5033
5034
5035
5036
5037
5038
5039
5040
5041
5042
5043
5044
5045
5046
5047
5048
5049
5050
5051
5052
5053
5054
5055
5056
5057
5058
5059
5060
5061
5062
5063
5064
5065
5066
5067
5068
5069
5070
5071
5072
5073
5074
5075
5076
5077
5078
5079
5080
5081
5082
5083
5084
5085
5086
5087
5088
5089
5090
5091
5092
5093
5094
5095
5096
5097
5098
5099
5100
5101
5102
5103
5104
5105
5106
5107
5108
5109
5110
5111
5112
5113
5114
5115
5116
5117
5118
5119
5120
5121
5122
5123
5124
5125
5126
5127
5128
5129
5130
5131
5132
5133
5134
5135
5136
5137
5138
5139
5140
5141
5142
5143
5144
5145
5146
5147
5148
5149
5150
5151
5152
5153
5154
5155
5156
5157
5158
5159
5160
5161
5162
5163
5164
5165
5166
5167
5168
5169
5170
5171
5172
5173
5174
5175
5176
5177
5178
5179
5180
5181
5182
5183
5184
5185
5186
5187
5188
5189
5190
5191
5192
5193
5194
5195
5196
5197
5198
5199
5200
5201
5202
5203
5204
5205
5206
5207
5208
5209
5210
5211
5212
5213
5214
5215
5216
5217
5218
5219
5220
5221
5222
5223
5224
5225
5226
5227
5228
5229
5230
5231
5232
5233
5234
5235
5236
5237
5238
5239
5240
5241
5242
5243
5244
5245
5246
5247
5248
5249
5250
5251
5252
5253
5254
5255
5256
5257
5258
5259
5260
5261
5262
5263
5264
5265
5266
5267
5268
5269
5270
5271
5272
5273
5274
5275
5276
5277
5278
5279
5280
5281
5282
5283
5284
5285
5286
5287
5288
5289
5290
5291
5292
5293
5294
5295
5296
5297
5298
5299
5300
5301
5302
5303
5304
5305
5306
5307
5308
5309
5310
5311
5312
5313
5314
5315
5316
5317
5318
5319
5320
5321
5322
5323
5324
5325
5326
5327
5328
5329
5330
5331
5332
5333
5334
5335
5336
5337
5338
5339
5340
5341
5342
5343
5344
5345
5346
5347
5348
5349
5350
5351
5352
5353
5354
5355
5356
5357
5358
5359
5360
5361
5362
5363
5364
5365
5366
5367
5368
5369
5370
5371
5372
5373
5374
5375
5376
5377
5378
5379
5380
5381
5382
5383
5384
5385
5386
5387
5388
5389
5390
5391
5392
5393
5394
5395
5396
5397
5398
5399
5400
5401
5402
5403
5404
5405
5406
5407
5408
5409
5410
5411
5412
5413
5414
5415
5416
5417
5418
5419
5420
5421
5422
5423
5424
5425
5426
5427
5428
5429
5430
5431
5432
5433
5434
5435
5436
5437
5438
5439
5440
5441
5442
5443
5444
5445
5446
5447
5448
5449
5450
5451
5452
5453
5454
5455
5456
5457
5458
5459
5460
5461
5462
5463
5464
5465
5466
5467
5468
5469
5470
5471
5472
5473
5474
5475
5476
5477
5478
5479
5480
5481
5482
5483
5484
5485
5486
5487
5488
5489
5490
5491
5492
5493
5494
5495
5496
5497
5498
5499
5500
5501
5502
5503
5504
5505
5506
5507
5508
5509
5510
5511
5512
5513
5514
5515
5516
5517
5518
5519
5520
5521
5522
5523
5524
5525
5526
5527
5528
5529
5530
5531
5532
5533
5534
5535
5536
5537
5538
5539
5540
5541
5542
5543
5544
5545
5546
5547
5548
5549
5550
5551
5552
5553
5554
5555
5556
5557
5558
5559
5560
5561
5562
5563
5564
5565
5566
5567
5568
5569
5570
5571
5572
5573
5574
5575
5576
5577
5578
5579
5580
5581
5582
5583
5584
5585
5586
5587
5588
5589
5590
5591
5592
5593
5594
5595
5596
5597
5598
5599
5600
5601
5602
5603
5604
5605
5606
5607
5608
5609
5610
5611
5612
5613
5614
5615
5616
5617
5618
5619
5620
5621
5622
5623
5624
5625
5626
5627
5628
5629
5630
5631
5632
5633
5634
5635
5636
5637
5638
5639
5640
5641
5642
5643
5644
5645
5646
5647
5648
5649
5650
5651
5652
5653
5654
5655
5656
5657
5658
5659
5660
5661
5662
5663
5664
5665
5666
5667
5668
5669
5670
5671
5672
5673
5674
5675
5676
5677
5678
5679
5680
5681
5682
5683
5684
5685
5686
5687
5688
5689
5690
5691
5692
5693
5694
5695
5696
5697
5698
5699
5700
5701
5702
5703
5704
5705
5706
5707
5708
5709
5710
5711
5712
5713
5714
5715
5716
5717
5718
5719
5720
5721
5722
5723
5724
5725
5726
5727
5728
5729
5730
5731
5732
5733
5734
5735
5736
5737
5738
5739
5740
5741
5742
5743
5744
5745
5746
5747
5748
5749
5750
5751
5752
5753
5754
5755
5756
5757
5758
5759
5760
5761
5762
5763
5764
5765
5766
5767
5768
5769
5770
5771
5772
5773
5774
5775
5776
5777
5778
5779
5780
5781
5782
5783
5784
5785
5786
5787
5788
5789
5790
5791
5792
5793
5794
5795
5796
5797
5798
5799
5800
5801
5802
5803
5804
5805
5806
5807
5808
5809
5810
5811
5812
5813
5814
5815
5816
5817
5818
5819
5820
5821
5822
5823
5824
5825
5826
5827
5828
5829
5830
5831
5832
5833
5834
5835
5836
5837
5838
5839
5840
5841
5842
5843
5844
5845
5846
5847
5848
5849
5850
5851
5852
5853
5854
5855
5856
5857
5858
5859
5860
5861
5862
5863
5864
5865
5866
5867
5868
5869
5870
5871
5872
5873
5874
5875
5876
5877
5878
5879
5880
5881
5882
5883
5884
5885
5886
5887
5888
5889
5890
5891
5892
5893
5894
5895
5896
5897
5898
5899
5900
5901
5902
5903
5904
5905
5906
5907
5908
5909
5910
5911
5912
5913
5914
5915
5916
5917
5918
5919
5920
5921
5922
5923
5924
5925
5926
5927
5928
5929
5930
5931
5932
5933
5934
5935
5936
5937
5938
5939
5940
5941
5942
5943
5944
5945
5946
5947
5948
5949
5950
5951
5952
5953
5954
5955
5956
5957
5958
5959
5960
5961
5962
5963
5964
5965
5966
5967
5968
5969
5970
5971
5972
5973
5974
5975
5976
5977
5978
5979
5980
5981
5982
5983
5984
5985
5986
5987
5988
5989
5990
5991
5992
5993
5994
5995
5996
5997
5998
5999
6000
6001
6002
6003
6004
6005
6006
6007
6008
6009
6010
6011
6012
6013
6014
6015
6016
6017
6018
6019
6020
6021
6022
6023
6024
6025
6026
6027
6028
6029
6030
6031
6032
6033
6034
6035
6036
6037
6038
6039
6040
6041
6042
6043
6044
6045
6046
6047
6048
6049
6050
6051
6052
6053
6054
6055
6056
6057
6058
6059
6060
6061
6062
6063
6064
6065
6066
6067
6068
6069
6070
6071
6072
6073
6074
6075
6076
6077
6078
6079
6080
6081
6082
6083
6084
6085
6086
6087
6088
6089
6090
6091
6092
6093
6094
6095
6096
6097
6098
6099
6100
6101
6102
6103
6104
6105
6106
6107
6108
6109
6110
6111
6112
6113
6114
6115
6116
6117
6118
6119
6120
6121
6122
6123
6124
6125
6126
6127
6128
6129
6130
6131
6132
6133
6134
6135
6136
6137
6138
6139
6140
6141
6142
6143
6144
6145
6146
6147
6148
6149
6150
6151
6152
6153
6154
6155
6156
6157
6158
6159
6160
6161
6162
6163
6164
6165
6166
6167
6168
6169
6170
6171
6172
6173
6174
6175
6176
6177
6178
6179
6180
6181
6182
6183
6184
6185
6186
6187
6188
6189
6190
6191
6192
6193
6194
6195
6196
6197
6198
6199
6200
6201
6202
6203
6204
6205
6206
6207
6208
6209
6210
6211
6212
6213
6214
6215
6216
6217
6218
6219
6220
6221
6222
6223
6224
6225
6226
6227
6228
6229
6230
6231
6232
6233
6234
6235
6236
6237
6238
6239
6240
6241
6242
6243
6244
6245
6246
6247
6248
6249
6250
6251
6252
6253
6254
6255
6256
6257
6258
6259
6260
6261
6262
6263
6264
6265
6266
6267
6268
6269
6270
6271
6272
6273
6274
6275
6276
6277
6278
6279
6280
6281
6282
6283
6284
6285
6286
6287
6288
6289
6290
6291
6292
6293
6294
6295
6296
6297
6298
6299
6300
6301
6302
6303
6304
6305
6306
6307
6308
6309
6310
6311
6312
6313
6314
6315
6316
6317
6318
6319
6320
6321
6322
6323
6324
6325
6326
6327
6328
6329
6330
6331
6332
6333
6334
6335
6336
6337
6338
6339
6340
6341
6342
6343
6344
6345
6346
6347
6348
6349
6350
6351
6352
6353
6354
6355
6356
6357
6358
6359
6360
6361
6362
6363
6364
6365
6366
6367
6368
6369
6370
6371
6372
6373
6374
6375
6376
6377
6378
6379
6380
6381
6382
6383
6384
6385
6386
6387
6388
6389
6390
6391
6392
6393
6394
6395
6396
6397
6398
6399
6400
6401
6402
6403
6404
6405
6406
6407
6408
6409
6410
6411
6412
6413
6414
6415
6416
6417
6418
6419
6420
6421
6422
6423
6424
6425
6426
6427
6428
6429
6430
6431
6432
6433
6434
6435
6436
6437
6438
6439
6440
6441
6442
6443
6444
6445
6446
6447
6448
6449
6450
6451
6452
6453
6454
6455
6456
6457
6458
6459
6460
6461
6462
6463
6464
6465
6466
6467
6468
6469
6470
6471
6472
6473
6474
6475
6476
6477
6478
6479
6480
6481
6482
6483
6484
6485
6486
6487
6488
6489
6490
6491
6492
6493
6494
6495
6496
6497
6498
6499
6500
6501
6502
6503
6504
6505
6506
6507
6508
6509
6510
6511
6512
6513
6514
6515
6516
6517
6518
6519
6520
6521
6522
6523
6524
6525
6526
6527
6528
6529
6530
6531
6532
6533
6534
6535
6536
6537
6538
6539
6540
6541
6542
6543
6544
6545
6546
6547
6548
6549
6550
6551
6552
6553
6554
6555
6556
6557
6558
6559
6560
6561
6562
6563
6564
6565
6566
6567
6568
6569
6570
6571
6572
6573
6574
6575
6576
6577
6578
6579
6580
6581
6582
6583
6584
6585
6586
6587
6588
6589
6590
6591
6592
6593
6594
6595
6596
6597
6598
6599
6600
6601
6602
6603
6604
6605
6606
6607
6608
6609
6610
6611
6612
6613
6614
6615
6616
6617
6618
6619
6620
6621
6622
6623
6624
6625
6626
6627
6628
6629
6630
6631
6632
6633
6634
6635
6636
6637
6638
6639
6640
6641
6642
6643
6644
6645
6646
6647
6648
6649
6650
6651
6652
6653
6654
6655
6656
6657
6658
6659
6660
6661
6662
6663
6664
6665
6666
6667
6668
6669
6670
6671
6672
6673
6674
6675
6676
6677
6678
6679
6680
6681
6682
6683
6684
6685
6686
6687
6688
6689
6690
6691
6692
6693
6694
6695
6696
6697
6698
6699
6700
6701
6702
6703
6704
6705
6706
6707
6708
6709
6710
6711
6712
6713
6714
6715
6716
6717
6718
6719
6720
6721
6722
6723
6724
6725
6726
6727
6728
6729
6730
6731
6732
6733
6734
6735
6736
6737
6738
6739
6740
6741
6742
6743
6744
6745
6746
6747
6748
6749
6750
6751
6752
6753
6754
6755
6756
6757
6758
6759
6760
6761
6762
6763
6764
6765
6766
6767
6768
6769
6770
6771
6772
6773
6774
6775
6776
6777
6778
6779
6780
6781
6782
6783
6784
6785
6786
6787
6788
6789
6790
6791
6792
6793
6794
6795
6796
6797
6798
6799
6800
6801
6802
6803
6804
6805
6806
6807
6808
6809
6810
6811
6812
6813
6814
6815
6816
6817
6818
6819
6820
6821
6822
6823
6824
6825
6826
6827
6828
6829
6830
6831
6832
6833
6834
6835
6836
6837
6838
6839
6840
6841
6842
6843
6844
6845
6846
6847
6848
6849
6850
6851
6852
6853
6854
6855
6856
6857
6858
6859
6860
6861
6862
6863
6864
6865
6866
6867
6868
6869
6870
6871
6872
6873
6874
6875
6876
6877
6878
6879
6880
6881
6882
6883
6884
6885
6886
6887
6888
6889
6890
6891
6892
6893
6894
6895
6896
6897
6898
6899
6900
6901
6902
6903
6904
6905
6906
6907
6908
6909
6910
6911
6912
6913
6914
6915
6916
6917
6918
6919
6920
6921
6922
6923
6924
6925
6926
6927
6928
6929
6930
6931
6932
6933
6934
6935
6936
6937
6938
6939
6940
6941
6942
6943
6944
6945
6946
6947
6948
6949
6950
6951
6952
6953
6954
6955
6956
6957
6958
6959
6960
6961
6962
6963
6964
6965
6966
6967
6968
6969
6970
6971
6972
6973
6974
6975
6976
6977
6978
6979
6980
6981
6982
6983
6984
6985
6986
6987
6988
6989
6990
6991
6992
6993
6994
6995
6996
6997
6998
6999
7000
7001
7002
7003
7004
7005
7006
7007
7008
7009
7010
7011
7012
7013
7014
7015
7016
7017
7018
7019
7020
7021
7022
7023
7024
7025
7026
7027
7028
7029
7030
7031
7032
7033
7034
7035
7036
7037
7038
7039
7040
7041
7042
7043
7044
7045
7046
7047
7048
7049
7050
7051
7052
7053
7054
7055
7056
7057
7058
7059
7060
7061
7062
7063
7064
7065
7066
7067
7068
7069
7070
7071
7072
7073
7074
7075
7076
7077
7078
7079
7080
7081
7082
7083
7084
7085
7086
7087
7088
7089
7090
7091
7092
7093
7094
7095
7096
7097
7098
7099
7100
7101
7102
7103
7104
7105
7106
7107
7108
7109
7110
7111
7112
7113
7114
7115
7116
7117
7118
7119
7120
7121
7122
7123
7124
7125
7126
7127
7128
7129
7130
7131
7132
7133
7134
7135
7136
7137
7138
7139
7140
7141
7142
7143
7144
7145
7146
7147
7148
7149
7150
7151
7152
7153
7154
7155
7156
7157
7158
7159
7160
7161
7162
7163
7164
7165
7166
7167
7168
7169
7170
7171
7172
7173
7174
7175
7176
7177
7178
7179
7180
7181
7182
7183
7184
7185
7186
7187
7188
7189
7190
7191
7192
7193
7194
7195
7196
7197
7198
7199
7200
7201
7202
7203
7204
7205
7206
7207
7208
7209
7210
7211
7212
7213
7214
7215
7216
7217
7218
7219
7220
7221
7222
7223
7224
7225
7226
7227
7228
7229
7230
7231
7232
7233
7234
7235
7236
7237
7238
7239
7240
7241
7242
7243
7244
7245
7246
7247
7248
7249
7250
7251
7252
7253
7254
7255
7256
7257
7258
7259
7260
7261
7262
7263
7264
7265
7266
7267
7268
7269
7270
7271
7272
7273
7274
7275
7276
7277
7278
7279
7280
7281
7282
7283
7284
7285
7286
7287
7288
7289
7290
7291
7292
7293
7294
7295
7296
7297
7298
7299
7300
7301
7302
7303
7304
7305
7306
7307
7308
7309
7310
7311
7312
7313
7314
7315
7316
7317
7318
7319
7320
7321
7322
7323
7324
7325
7326
7327
7328
7329
7330
7331
7332
7333
7334
7335
7336
7337
7338
7339
7340
7341
7342
7343
7344
7345
7346
7347
7348
7349
7350
7351
7352
7353
7354
7355
7356
7357
7358
7359
7360
7361
7362
7363
7364
7365
7366
7367
7368
7369
7370
7371
7372
7373
7374
7375
7376
7377
7378
7379
7380
7381
7382
7383
7384
7385
7386
7387
7388
7389
7390
7391
7392
7393
7394
7395
7396
7397
7398
7399
7400
7401
7402
7403
7404
7405
7406
7407
7408
7409
7410
7411
7412
7413
7414
7415
7416
7417
7418
7419
7420
7421
7422
7423
7424
7425
7426
7427
7428
7429
7430
7431
7432
7433
7434
7435
7436
7437
7438
7439
7440
7441
7442
7443
7444
7445
7446
7447
7448
7449
7450
7451
7452
7453
7454
7455
7456
7457
7458
7459
7460
7461
7462
7463
7464
7465
7466
7467
7468
7469
7470
7471
7472
7473
7474
7475
7476
7477
7478
7479
7480
7481
7482
7483
7484
7485
7486
7487
7488
7489
7490
7491
7492
7493
7494
7495
7496
7497
7498
7499
7500
7501
7502
7503
7504
7505
7506
7507
7508
7509
7510
7511
7512
7513
7514
7515
7516
7517
7518
7519
7520
7521
7522
7523
7524
7525
7526
7527
7528
7529
7530
7531
7532
7533
7534
7535
7536
7537
7538
7539
7540
7541
7542
7543
7544
7545
7546
7547
7548
7549
7550
7551
7552
7553
7554
7555
7556
7557
7558
7559
7560
7561
7562
7563
7564
7565
7566
7567
7568
7569
7570
7571
7572
7573
7574
7575
7576
7577
7578
7579
7580
7581
7582
7583
7584
7585
7586
7587
7588
7589
7590
7591
7592
7593
7594
7595
7596
7597
7598
7599
7600
7601
7602
7603
7604
7605
7606
7607
7608
7609
7610
7611
7612
7613
7614
7615
7616
7617
7618
7619
7620
7621
7622
7623
7624
7625
7626
7627
7628
7629
7630
7631
7632
7633
7634
7635
7636
7637
7638
7639
7640
7641
7642
7643
7644
7645
7646
7647
7648
7649
7650
7651
7652
7653
7654
7655
7656
7657
7658
7659
7660
7661
7662
7663
7664
7665
7666
7667
7668
7669
7670
7671
7672
7673
7674
7675
7676
7677
7678
7679
7680
7681
7682
7683
7684
7685
7686
7687
7688
7689
7690
7691
7692
7693
7694
7695
7696
7697
7698
7699
7700
7701
7702
7703
7704
7705
7706
7707
7708
7709
7710
7711
7712
7713
7714
7715
7716
7717
7718
7719
7720
7721
7722
7723
7724
7725
7726
7727
7728
7729
7730
7731
7732
7733
7734
7735
7736
7737
7738
7739
7740
7741
7742
7743
7744
7745
7746
7747
7748
7749
7750
7751
7752
7753
7754
7755
7756
7757
7758
7759
7760
7761
7762
7763
7764
7765
7766
7767
7768
7769
7770
7771
7772
7773
7774
7775
7776
7777
7778
7779
7780
7781
7782
7783
7784
7785
7786
7787
7788
7789
7790
7791
7792
7793
7794
7795
7796
7797
7798
7799
7800
7801
7802
7803
7804
7805
7806
7807
7808
7809
7810
7811
7812
7813
7814
7815
7816
7817
7818
7819
7820
7821
7822
7823
7824
7825
7826
7827
7828
7829
7830
7831
7832
7833
7834
7835
7836
7837
7838
7839
7840
7841
7842
7843
7844
7845
7846
7847
7848
7849
7850
7851
7852
7853
7854
7855
7856
7857
7858
7859
7860
7861
7862
7863
7864
7865
7866
7867
7868
7869
7870
7871
7872
7873
7874
7875
7876
7877
7878
7879
7880
7881
7882
7883
7884
7885
7886
7887
7888
7889
7890
7891
7892
7893
7894
7895
7896
7897
7898
7899
7900
7901
7902
7903
7904
7905
7906
7907
7908
7909
7910
7911
7912
7913
7914
7915
7916
7917
7918
7919
7920
7921
7922
7923
7924
7925
7926
7927
7928
7929
7930
7931
7932
7933
7934
7935
7936
7937
7938
7939
7940
7941
7942
7943
7944
7945
7946
7947
7948
7949
7950
7951
7952
7953
7954
7955
7956
7957
7958
7959
7960
7961
7962
7963
7964
7965
7966
7967
7968
7969
7970
7971
7972
7973
7974
7975
7976
7977
7978
7979
7980
7981
7982
7983
7984
7985
7986
7987
7988
7989
7990
7991
7992
7993
7994
7995
7996
7997
7998
7999
8000
8001
8002
8003
8004
8005
8006
8007
8008
8009
8010
8011
8012
8013
8014
8015
8016
8017
8018
8019
8020
8021
8022
8023
8024
8025
8026
8027
8028
8029
8030
8031
8032
8033
8034
8035
8036
8037
8038
8039
8040
8041
8042
8043
8044
8045
8046
8047
8048
8049
8050
8051
8052
8053
8054
8055
8056
8057
8058
8059
8060
8061
8062
8063
8064
8065
8066
8067
8068
8069
8070
8071
8072
8073
8074
8075
8076
8077
8078
8079
8080
8081
8082
8083
8084
8085
8086
8087
8088
8089
8090
8091
8092
8093
8094
8095
8096
8097
8098
8099
8100
8101
8102
8103
8104
8105
8106
8107
8108
8109
8110
8111
8112
8113
8114
8115
8116
8117
8118
8119
8120
8121
8122
8123
8124
8125
8126
8127
8128
8129
8130
8131
8132
8133
8134
8135
8136
8137
8138
8139
8140
8141
8142
8143
8144
8145
8146
8147
8148
8149
8150
8151
8152
8153
8154
8155
8156
8157
8158
8159
8160
8161
8162
8163
8164
8165
8166
8167
8168
8169
8170
8171
8172
8173
8174
8175
8176
8177
8178
8179
8180
8181
8182
8183
8184
8185
8186
8187
8188
8189
8190
8191
8192
8193
8194
8195
8196
8197
8198
8199
8200
8201
8202
8203
8204
8205
8206
8207
8208
8209
8210
8211
8212
8213
8214
8215
8216
8217
8218
8219
8220
8221
8222
8223
8224
8225
8226
8227
8228
8229
8230
8231
8232
8233
8234
8235
8236
8237
8238
8239
8240
8241
8242
8243
8244
8245
8246
8247
8248
8249
8250
8251
8252
8253
8254
8255
8256
8257
8258
8259
8260
8261
8262
8263
8264
8265
8266
8267
8268
8269
8270
8271
8272
8273
8274
8275
8276
8277
8278
8279
8280
8281
8282
8283
8284
8285
8286
8287
8288
8289
8290
8291
8292
8293
8294
8295
8296
8297
8298
8299
8300
8301
8302
8303
8304
8305
8306
8307
8308
8309
8310
8311
8312
8313
8314
8315
8316
8317
8318
8319
8320
8321
8322
8323
8324
8325
8326
8327
8328
8329
8330
8331
8332
8333
8334
8335
8336
8337
8338
8339
8340
8341
8342
8343
8344
8345
8346
8347
8348
8349
8350
8351
8352
8353
8354
8355
8356
8357
8358
8359
8360
8361
8362
8363
8364
8365
8366
8367
8368
8369
8370
8371
8372
8373
8374
8375
8376
8377
8378
8379
8380
8381
8382
8383
8384
8385
8386
8387
8388
8389
8390
8391
8392
8393
8394
8395
8396
8397
8398
8399
8400
8401
8402
8403
8404
8405
8406
8407
8408
8409
8410
8411
8412
8413
8414
8415
8416
8417
8418
8419
8420
8421
8422
8423
8424
8425
8426
8427
8428
8429
8430
8431
8432
8433
8434
8435
8436
8437
8438
8439
8440
8441
8442
8443
8444
8445
8446
8447
8448
8449
8450
8451
8452
8453
8454
8455
8456
8457
8458
8459
8460
8461
8462
8463
8464
8465
8466
8467
8468
8469
8470
8471
8472
8473
8474
8475
8476
8477
8478
8479
8480
8481
8482
8483
8484
8485
8486
8487
8488
8489
8490
8491
8492
8493
8494
8495
8496
8497
8498
8499
8500
8501
8502
8503
8504
8505
8506
8507
8508
8509
8510
8511
8512
8513
8514
8515
8516
8517
8518
8519
8520
8521
8522
8523
8524
8525
8526
8527
8528
8529
8530
8531
8532
8533
8534
8535
8536
8537
8538
8539
8540
8541
8542
8543
8544
8545
8546
8547
8548
8549
8550
8551
8552
8553
8554
8555
8556
8557
8558
8559
8560
8561
8562
8563
8564
8565
8566
8567
8568
8569
8570
8571
8572
8573
8574
8575
8576
8577
8578
8579
8580
8581
8582
8583
8584
8585
8586
8587
8588
8589
8590
8591
8592
8593
8594
8595
8596
8597
8598
8599
8600
8601
8602
8603
8604
8605
8606
8607
8608
8609
8610
8611
8612
8613
8614
8615
8616
8617
8618
8619
8620
8621
8622
8623
8624
8625
8626
8627
8628
8629
8630
8631
8632
8633
8634
8635
8636
8637
8638
8639
8640
8641
8642
8643
8644
8645
8646
8647
8648
8649
8650
8651
8652
8653
8654
8655
8656
8657
8658
8659
8660
8661
8662
8663
8664
8665
8666
8667
8668
8669
8670
8671
8672
8673
8674
8675
8676
8677
8678
8679
8680
8681
8682
8683
8684
8685
8686
8687
8688
8689
8690
8691
8692
8693
8694
8695
8696
8697
8698
8699
8700
8701
8702
8703
8704
8705
8706
8707
8708
8709
8710
8711
8712
8713
8714
8715
8716
8717
8718
8719
8720
8721
8722
8723
8724
8725
8726
8727
8728
8729
8730
8731
8732
8733
8734
8735
8736
8737
8738
8739
8740
8741
8742
8743
8744
8745
8746
8747
8748
8749
8750
8751
8752
8753
8754
8755
8756
8757
8758
8759
8760
8761
8762
8763
8764
8765
8766
8767
8768
8769
8770
8771
8772
8773
8774
8775
8776
8777
8778
8779
8780
8781
8782
8783
8784
8785
8786
8787
8788
8789
8790
8791
8792
8793
8794
8795
8796
8797
8798
8799
8800
8801
8802
8803
8804
8805
8806
8807
8808
8809
8810
8811
8812
8813
8814
8815
8816
8817
8818
8819
8820
8821
8822
8823
8824
8825
8826
8827
8828
8829
8830
8831
8832
8833
8834
8835
8836
8837
8838
8839
8840
8841
8842
8843
8844
8845
8846
8847
8848
8849
8850
8851
8852
8853
8854
8855
8856
8857
8858
8859
8860
8861
8862
8863
8864
8865
8866
8867
8868
8869
8870
8871
8872
8873
8874
8875
8876
8877
8878
8879
8880
8881
8882
8883
8884
8885
8886
8887
8888
8889
8890
8891
8892
8893
8894
8895
8896
8897
8898
8899
8900
8901
8902
8903
8904
8905
8906
8907
8908
8909
8910
8911
8912
8913
8914
8915
8916
8917
8918
8919
8920
8921
8922
8923
8924
8925
8926
8927
8928
8929
8930
8931
8932
8933
8934
8935
8936
8937
8938
8939
8940
8941
8942
8943
8944
8945
8946
8947
8948
8949
8950
8951
8952
8953
8954
8955
8956
8957
8958
8959
8960
8961
8962
8963
8964
8965
8966
8967
8968
8969
8970
8971
8972
8973
8974
8975
8976
8977
8978
8979
8980
8981
8982
8983
8984
8985
8986
8987
8988
8989
8990
8991
8992
8993
8994
8995
8996
8997
8998
8999
9000
9001
9002
9003
9004
9005
9006
9007
9008
9009
9010
9011
9012
9013
9014
9015
9016
9017
9018
9019
9020
9021
9022
9023
9024
9025
9026
9027
9028
9029
9030
9031
9032
9033
9034
9035
9036
9037
9038
9039
9040
9041
9042
9043
9044
9045
9046
9047
9048
9049
9050
9051
9052
9053
9054
9055
9056
9057
9058
9059
9060
9061
9062
9063
9064
9065
9066
9067
9068
9069
9070
9071
9072
9073
9074
9075
9076
9077
9078
9079
9080
9081
9082
9083
9084
9085
9086
9087
9088
9089
9090
9091
9092
9093
9094
9095
9096
9097
9098
9099
9100
9101
9102
9103
9104
9105
9106
9107
9108
9109
9110
9111
9112
9113
9114
9115
9116
9117
9118
9119
9120
9121
9122
9123
9124
9125
9126
9127
9128
9129
9130
9131
9132
9133
9134
9135
9136
9137
9138
9139
9140
9141
9142
9143
9144
9145
9146
9147
9148
9149
9150
9151
9152
9153
9154
9155
9156
9157
9158
9159
9160
9161
9162
9163
9164
9165
9166
9167
9168
9169
9170
9171
9172
9173
9174
9175
9176
9177
9178
9179
9180
9181
9182
9183
9184
9185
9186
9187
9188
9189
9190
9191
9192
9193
9194
9195
9196
9197
9198
9199
9200
9201
9202
9203
9204
9205
9206
9207
9208
9209
9210
9211
9212
9213
9214
9215
9216
9217
9218
9219
9220
9221
9222
9223
9224
9225
9226
9227
9228
9229
9230
9231
9232
9233
9234
9235
9236
9237
9238
9239
9240
9241
9242
9243
9244
9245
9246
9247
9248
9249
9250
9251
9252
9253
9254
9255
9256
9257
9258
9259
9260
9261
9262
9263
9264
9265
9266
9267
9268
9269
9270
9271
9272
9273
9274
9275
9276
9277
9278
9279
9280
9281
9282
9283
9284
9285
9286
9287
9288
9289
9290
9291
9292
9293
9294
9295
9296
9297
9298
9299
9300
9301
9302
9303
9304
9305
9306
9307
9308
9309
9310
9311
9312
9313
9314
9315
9316
9317
9318
9319
9320
9321
9322
9323
9324
9325
9326
9327
9328
9329
9330
9331
9332
9333
9334
9335
9336
9337
9338
9339
9340
9341
9342
9343
9344
9345
9346
9347
9348
9349
9350
9351
9352
9353
9354
9355
9356
9357
9358
9359
9360
9361
9362
9363
9364
9365
9366
9367
9368
9369
9370
9371
9372
9373
9374
9375
9376
9377
9378
9379
9380
9381
9382
9383
9384
9385
9386
9387
9388
9389
9390
9391
9392
9393
9394
9395
9396
9397
9398
9399
9400
9401
9402
9403
9404
9405
9406
9407
9408
9409
9410
9411
9412
9413
9414
9415
9416
9417
9418
9419
9420
9421
9422
9423
9424
9425
9426
9427
9428
9429
9430
9431
9432
9433
9434
9435
9436
9437
9438
9439
9440
9441
9442
9443
9444
9445
9446
9447
9448
9449
9450
9451
9452
9453
9454
9455
9456
9457
9458
9459
9460
9461
9462
9463
9464
9465
9466
9467
9468
9469
9470
9471
9472
9473
9474
9475
9476
9477
9478
9479
9480
9481
9482
9483
9484
9485
9486
9487
9488
9489
9490
9491
9492
9493
9494
9495
9496
9497
9498
9499
9500
9501
9502
9503
9504
9505
9506
9507
9508
9509
9510
9511
9512
9513
9514
9515
9516
9517
9518
9519
9520
9521
9522
9523
9524
9525
9526
9527
9528
9529
9530
9531
9532
9533
9534
9535
9536
9537
9538
9539
9540
9541
9542
9543
9544
9545
9546
9547
9548
9549
9550
9551
9552
9553
9554
9555
9556
9557
9558
9559
9560
9561
9562
9563
9564
9565
9566
9567
9568
9569
9570
9571
9572
9573
9574
9575
9576
9577
9578
9579
9580
9581
9582
9583
9584
9585
9586
9587
9588
9589
9590
9591
9592
9593
9594
9595
9596
9597
9598
9599
9600
9601
9602
9603
9604
9605
9606
9607
9608
9609
9610
9611
9612
9613
9614
9615
9616
9617
9618
9619
9620
9621
9622
9623
9624
9625
9626
9627
9628
9629
9630
9631
9632
9633
9634
9635
9636
9637
9638
9639
9640
9641
9642
9643
9644
9645
9646
9647
9648
9649
9650
9651
9652
9653
9654
9655
9656
9657
9658
9659
9660
9661
9662
9663
9664
9665
9666
9667
9668
9669
9670
9671
9672
9673
9674
9675
9676
9677
9678
9679
9680
9681
9682
9683
9684
9685
9686
9687
9688
9689
9690
9691
9692
9693
9694
9695
9696
9697
9698
9699
9700
9701
9702
9703
9704
9705
9706
9707
9708
9709
9710
9711
9712
9713
9714
9715
9716
9717
9718
9719
9720
9721
9722
9723
9724
9725
9726
9727
9728
9729
9730
9731
9732
9733
9734
9735
9736
9737
9738
9739
9740
9741
9742
9743
9744
9745
9746
9747
9748
9749
9750
9751
9752
9753
9754
9755
9756
9757
9758
9759
9760
9761
9762
9763
9764
9765
9766
9767
9768
9769
9770
9771
9772
9773
9774
9775
9776
9777
9778
9779
9780
9781
9782
9783
9784
9785
9786
9787
9788
9789
9790
9791
9792
9793
9794
9795
9796
9797
9798
9799
9800
9801
9802
9803
9804
9805
9806
9807
9808
9809
9810
9811
9812
9813
9814
9815
9816
9817
9818
9819
9820
9821
9822
9823
9824
9825
9826
9827
9828
9829
9830
9831
9832
9833
9834
9835
9836
9837
9838
9839
9840
9841
9842
9843
9844
9845
9846
9847
9848
9849
9850
9851
9852
9853
9854
9855
9856
9857
9858
9859
9860
9861
9862
9863
9864
9865
9866
9867
9868
9869
9870
9871
9872
9873
9874
9875
9876
9877
9878
9879
9880
9881
9882
9883
9884
9885
9886
9887
9888
9889
9890
9891
9892
9893
9894
9895
9896
9897
9898
9899
9900
9901
9902
9903
9904
9905
9906
9907
9908
9909
9910
9911
9912
9913
9914
9915
9916
9917
9918
9919
9920
9921
9922
9923
9924
9925
9926
9927
9928
9929
9930
9931
9932
9933
9934
9935
9936
9937
9938
9939
9940
9941
9942
9943
9944
9945
9946
9947
9948
9949
9950
9951
9952
9953
9954
9955
9956
9957
9958
9959
9960
9961
9962
9963
9964
9965
9966
9967
9968
9969
9970
9971
9972
9973
9974
9975
9976
9977
9978
9979
9980
9981
9982
9983
9984
9985
9986
9987
9988
9989
9990
9991
9992
9993
9994
9995
9996
9997
9998
9999
10000
10001
10002
10003
10004
10005
10006
10007
10008
10009
10010
10011
10012
10013
10014
10015
10016
10017
10018
10019
10020
10021
10022
10023
10024
10025
10026
10027
10028
10029
10030
10031
10032
10033
10034
10035
10036
10037
10038
10039
10040
10041
10042
10043
10044
10045
10046
10047
10048
10049
10050
10051
10052
10053
10054
10055
10056
10057
10058
10059
10060
10061
10062
10063
10064
10065
10066
10067
10068
10069
10070
10071
10072
10073
10074
10075
10076
10077
10078
10079
10080
10081
10082
10083
10084
10085
10086
10087
10088
10089
10090
10091
10092
10093
10094
10095
10096
10097
10098
10099
10100
10101
10102
10103
10104
10105
10106
10107
10108
10109
10110
10111
10112
10113
10114
10115
10116
10117
10118
10119
10120
10121
10122
10123
10124
10125
10126
10127
10128
10129
10130
10131
10132
10133
10134
10135
10136
10137
10138
10139
10140
10141
10142
10143
10144
10145
10146
10147
10148
10149
10150
10151
10152
10153
10154
10155
10156
10157
10158
10159
10160
10161
10162
10163
10164
10165
10166
10167
10168
10169
10170
10171
10172
10173
10174
10175
10176
10177
10178
10179
10180
10181
10182
10183
10184
10185
10186
10187
10188
10189
10190
10191
10192
10193
10194
10195
10196
10197
10198
10199
10200
10201
10202
10203
10204
10205
10206
10207
10208
10209
10210
10211
10212
10213
10214
10215
10216
10217
10218
10219
10220
10221
10222
10223
10224
10225
10226
10227
10228
10229
10230
10231
10232
10233
10234
10235
10236
10237
10238
10239
10240
10241
10242
10243
10244
10245
10246
10247
10248
10249
10250
10251
10252
10253
10254
10255
10256
10257
10258
10259
10260
10261
10262
10263
10264
10265
10266
10267
10268
10269
10270
10271
10272
10273
10274
10275
10276
10277
10278
10279
10280
10281
10282
10283
10284
10285
10286
10287
10288
10289
10290
10291
10292
10293
10294
10295
10296
10297
10298
10299
10300
10301
10302
10303
10304
10305
10306
10307
10308
10309
10310
10311
10312
10313
10314
10315
10316
10317
10318
10319
10320
10321
10322
10323
10324
10325
10326
10327
10328
10329
10330
10331
10332
10333
10334
10335
10336
10337
10338
10339
10340
10341
10342
10343
10344
10345
10346
10347
10348
10349
10350
10351
10352
10353
10354
10355
10356
10357
10358
10359
10360
10361
10362
10363
10364
10365
10366
10367
10368
10369
10370
10371
10372
10373
10374
10375
10376
10377
10378
10379
10380
10381
10382
10383
10384
10385
10386
10387
10388
10389
10390
10391
10392
10393
10394
10395
10396
10397
10398
10399
10400
10401
10402
10403
10404
10405
10406
10407
10408
10409
10410
10411
10412
10413
10414
10415
10416
10417
10418
10419
10420
10421
10422
10423
10424
10425
10426
10427
10428
10429
10430
10431
10432
10433
10434
10435
10436
10437
10438
10439
10440
10441
10442
10443
10444
10445
10446
10447
10448
10449
10450
10451
10452
10453
10454
10455
10456
10457
10458
10459
10460
10461
10462
10463
10464
10465
10466
10467
10468
10469
10470
10471
10472
10473
10474
10475
10476
10477
10478
10479
10480
10481
10482
10483
10484
10485
10486
10487
10488
10489
10490
10491
10492
10493
10494
10495
10496
10497
10498
10499
10500
10501
10502
10503
10504
10505
10506
10507
10508
10509
10510
10511
10512
10513
10514
10515
10516
10517
10518
10519
10520
10521
10522
10523
10524
10525
10526
10527
10528
10529
10530
10531
10532
10533
10534
10535
10536
10537
10538
10539
10540
10541
10542
10543
10544
10545
10546
10547
10548
10549
10550
10551
10552
10553
10554
10555
10556
10557
10558
10559
10560
10561
10562
10563
10564
10565
10566
10567
10568
10569
10570
10571
10572
10573
10574
10575
10576
10577
10578
10579
10580
10581
10582
10583
10584
10585
10586
10587
10588
10589
10590
10591
10592
10593
10594
10595
10596
10597
10598
10599
10600
10601
10602
10603
10604
10605
10606
10607
10608
10609
10610
10611
10612
10613
10614
10615
10616
10617
10618
10619
10620
10621
10622
10623
10624
10625
10626
10627
10628
10629
10630
10631
10632
10633
10634
10635
10636
10637
10638
10639
10640
10641
10642
10643
10644
10645
10646
10647
10648
10649
10650
10651
10652
10653
10654
10655
10656
10657
10658
10659
10660
10661
10662
10663
10664
10665
10666
10667
10668
10669
10670
10671
10672
10673
10674
10675
10676
10677
10678
10679
10680
10681
10682
10683
10684
10685
10686
10687
10688
10689
10690
10691
10692
10693
10694
10695
10696
10697
10698
10699
10700
10701
10702
10703
10704
10705
10706
10707
10708
10709
10710
10711
10712
10713
10714
10715
10716
10717
10718
10719
10720
10721
10722
10723
10724
10725
10726
10727
10728
10729
10730
10731
10732
10733
10734
10735
10736
10737
10738
10739
10740
10741
10742
10743
10744
10745
10746
10747
10748
10749
10750
10751
10752
10753
10754
10755
10756
10757
10758
10759
10760
10761
10762
10763
10764
10765
10766
10767
10768
10769
10770
10771
10772
10773
10774
10775
10776
10777
10778
10779
10780
10781
10782
10783
10784
10785
10786
10787
10788
10789
10790
10791
10792
10793
10794
10795
10796
10797
10798
10799
10800
10801
10802
10803
10804
10805
10806
10807
10808
10809
10810
10811
10812
10813
10814
10815
10816
10817
10818
10819
10820
10821
10822
10823
10824
10825
10826
10827
10828
10829
10830
10831
10832
10833
10834
10835
10836
10837
10838
10839
10840
10841
10842
10843
10844
10845
10846
10847
10848
10849
10850
10851
10852
10853
10854
10855
10856
10857
10858
10859
10860
10861
10862
10863
10864
10865
10866
10867
10868
10869
10870
10871
10872
10873
10874
10875
10876
10877
10878
10879
10880
10881
10882
10883
10884
10885
10886
10887
10888
10889
10890
10891
10892
10893
10894
10895
10896
10897
10898
10899
10900
10901
10902
10903
10904
10905
10906
10907
10908
10909
10910
10911
10912
10913
10914
10915
10916
10917
10918
10919
10920
10921
10922
10923
10924
10925
10926
10927
10928
10929
10930
10931
10932
10933
10934
10935
10936
10937
10938
10939
10940
10941
10942
10943
10944
10945
10946
10947
10948
10949
10950
10951
10952
10953
10954
10955
10956
10957
10958
10959
10960
10961
10962
10963
10964
10965
10966
10967
10968
10969
10970
10971
10972
10973
10974
10975
10976
10977
10978
10979
10980
10981
10982
10983
10984
10985
10986
10987
10988
10989
10990
10991
10992
10993
10994
10995
10996
10997
10998
10999
11000
11001
11002
11003
11004
11005
11006
11007
11008
11009
11010
11011
11012
11013
11014
11015
11016
11017
11018
11019
11020
11021
11022
11023
11024
11025
11026
11027
11028
11029
11030
11031
11032
11033
11034
11035
11036
11037
11038
11039
11040
11041
11042
11043
11044
11045
11046
11047
11048
11049
11050
11051
11052
11053
11054
11055
11056
11057
11058
11059
11060
11061
11062
11063
11064
11065
11066
11067
11068
11069
11070
11071
11072
11073
11074
11075
11076
11077
11078
11079
11080
11081
11082
11083
11084
11085
11086
11087
11088
11089
11090
11091
11092
11093
11094
11095
11096
11097
11098
11099
11100
11101
11102
11103
11104
11105
11106
11107
11108
11109
11110
11111
11112
11113
11114
11115
11116
11117
11118
11119
11120
11121
11122
11123
11124
11125
11126
11127
11128
11129
11130
11131
11132
11133
11134
11135
11136
11137
11138
11139
11140
11141
11142
11143
11144
11145
11146
11147
11148
11149
11150
11151
11152
11153
11154
11155
11156
11157
11158
11159
11160
11161
11162
11163
11164
11165
11166
11167
11168
11169
11170
11171
11172
11173
11174
11175
11176
11177
11178
11179
11180
11181
11182
11183
11184
11185
11186
11187
11188
11189
11190
11191
11192
11193
11194
11195
11196
11197
11198
11199
11200
11201
11202
11203
11204
11205
11206
11207
11208
11209
11210
11211
11212
11213
11214
11215
11216
11217
11218
11219
11220
11221
11222
11223
11224
11225
11226
11227
11228
11229
11230
11231
11232
11233
11234
11235
11236
11237
11238
11239
11240
11241
11242
11243
11244
11245
11246
11247
11248
11249
11250
11251
11252
11253
11254
11255
11256
11257
11258
11259
11260
11261
11262
11263
11264
11265
11266
11267
11268
11269
11270
11271
11272
11273
11274
11275
11276
11277
11278
11279
11280
11281
11282
11283
11284
11285
11286
11287
11288
11289
11290
11291
11292
11293
11294
11295
11296
11297
11298
11299
11300
11301
11302
11303
11304
11305
11306
11307
11308
11309
11310
11311
11312
11313
11314
11315
11316
11317
11318
11319
11320
11321
11322
11323
11324
11325
11326
11327
11328
11329
11330
11331
11332
11333
11334
11335
11336
11337
11338
11339
11340
11341
11342
11343
11344
11345
11346
11347
11348
11349
11350
11351
11352
11353
11354
11355
11356
11357
11358
11359
11360
11361
11362
11363
11364
11365
11366
11367
11368
11369
11370
11371
11372
11373
11374
11375
11376
11377
11378
11379
11380
11381
11382
11383
11384
11385
11386
11387
11388
11389
11390
11391
11392
11393
11394
11395
11396
11397
11398
11399
11400
11401
11402
11403
11404
11405
11406
11407
11408
11409
11410
11411
11412
11413
11414
11415
11416
11417
11418
11419
11420
11421
11422
11423
11424
11425
11426
11427
11428
11429
11430
11431
11432
11433
11434
11435
11436
11437
11438
11439
11440
11441
11442
11443
11444
11445
11446
11447
11448
11449
11450
11451
11452
11453
11454
11455
11456
11457
11458
11459
11460
11461
11462
11463
11464
11465
11466
11467
11468
11469
11470
11471
11472
11473
11474
11475
11476
11477
11478
11479
11480
11481
11482
11483
11484
11485
11486
11487
11488
11489
11490
11491
11492
11493
11494
11495
11496
11497
11498
11499
11500
11501
11502
11503
11504
11505
11506
11507
11508
11509
11510
11511
11512
11513
11514
11515
11516
11517
11518
11519
11520
11521
11522
11523
11524
11525
11526
11527
11528
11529
11530
11531
11532
11533
11534
11535
11536
11537
11538
11539
11540
11541
11542
11543
11544
11545
11546
11547
11548
11549
11550
11551
11552
11553
11554
11555
11556
11557
11558
11559
11560
11561
11562
11563
11564
11565
11566
11567
11568
11569
11570
11571
11572
11573
11574
11575
11576
11577
11578
11579
11580
11581
11582
11583
11584
11585
11586
11587
11588
11589
11590
11591
11592
11593
11594
11595
11596
11597
11598
11599
11600
11601
11602
11603
11604
11605
11606
11607
11608
11609
11610
11611
11612
11613
11614
11615
11616
11617
11618
11619
11620
11621
11622
11623
11624
11625
11626
11627
11628
11629
11630
11631
11632
11633
11634
11635
11636
11637
11638
11639
11640
11641
11642
11643
11644
11645
11646
11647
11648
11649
11650
11651
11652
11653
11654
11655
11656
11657
11658
11659
11660
11661
11662
11663
11664
11665
11666
11667
11668
11669
11670
11671
11672
11673
11674
11675
11676
11677
11678
11679
11680
11681
11682
11683
11684
11685
11686
11687
11688
11689
11690
11691
11692
11693
11694
11695
11696
11697
11698
11699
11700
11701
11702
11703
11704
11705
11706
11707
11708
11709
11710
11711
11712
11713
11714
11715
11716
11717
11718
11719
11720
11721
11722
11723
11724
11725
11726
11727
11728
11729
11730
11731
11732
11733
11734
11735
11736
11737
11738
11739
11740
11741
11742
11743
11744
11745
11746
11747
11748
11749
11750
11751
11752
11753
11754
11755
11756
11757
11758
11759
11760
11761
11762
11763
11764
11765
11766
11767
11768
11769
11770
11771
11772
11773
11774
11775
11776
11777
11778
11779
11780
11781
11782
11783
11784
11785
11786
11787
11788
11789
11790
11791
11792
11793
11794
11795
11796
11797
11798
11799
11800
11801
11802
11803
11804
11805
11806
11807
11808
11809
11810
11811
11812
11813
11814
11815
11816
11817
11818
11819
11820
11821
11822
11823
11824
11825
11826
11827
11828
11829
11830
11831
11832
11833
11834
11835
11836
11837
11838
11839
11840
11841
11842
11843
11844
11845
11846
11847
11848
11849
11850
11851
11852
11853
11854
11855
11856
11857
11858
11859
11860
11861
11862
11863
11864
11865
11866
11867
11868
11869
11870
11871
11872
11873
11874
11875
11876
11877
11878
11879
11880
11881
11882
11883
11884
11885
11886
11887
11888
11889
11890
11891
11892
11893
11894
11895
11896
11897
11898
11899
11900
11901
11902
11903
11904
11905
11906
11907
11908
11909
11910
11911
11912
11913
11914
11915
11916
11917
11918
11919
11920
11921
11922
11923
11924
11925
11926
11927
11928
11929
11930
11931
11932
11933
11934
11935
11936
11937
11938
11939
11940
11941
11942
11943
11944
11945
11946
11947
11948
11949
11950
11951
11952
11953
11954
11955
11956
11957
11958
11959
11960
11961
11962
11963
11964
11965
11966
11967
11968
11969
11970
11971
11972
11973
11974
11975
11976
11977
11978
11979
11980
11981
11982
11983
11984
11985
11986
11987
11988
11989
11990
11991
11992
11993
11994
11995
11996
11997
11998
11999
12000
12001
12002
12003
12004
12005
12006
12007
12008
12009
12010
12011
12012
12013
12014
12015
12016
12017
12018
12019
12020
12021
12022
12023
12024
12025
12026
12027
12028
12029
12030
12031
12032
12033
12034
12035
12036
12037
12038
12039
12040
12041
12042
12043
12044
12045
12046
12047
12048
12049
12050
12051
12052
12053
12054
12055
12056
12057
12058
12059
12060
12061
12062
12063
12064
12065
12066
12067
12068
12069
12070
12071
12072
12073
12074
12075
12076
12077
12078
12079
12080
12081
12082
12083
12084
12085
12086
12087
12088
12089
12090
12091
12092
12093
12094
12095
12096
12097
12098
12099
12100
12101
12102
12103
12104
12105
12106
12107
12108
12109
12110
12111
12112
12113
12114
12115
12116
12117
12118
12119
12120
12121
12122
12123
12124
12125
12126
12127
12128
12129
12130
12131
12132
12133
12134
12135
12136
12137
12138
12139
12140
12141
12142
12143
12144
12145
12146
12147
12148
12149
12150
12151
12152
12153
12154
12155
12156
12157
12158
12159
12160
12161
12162
12163
12164
12165
12166
12167
12168
12169
12170
12171
12172
12173
12174
12175
12176
12177
12178
12179
12180
12181
12182
12183
12184
12185
12186
12187
12188
12189
12190
12191
12192
12193
12194
12195
12196
12197
12198
12199
12200
12201
12202
12203
12204
12205
12206
12207
12208
12209
12210
12211
12212
12213
12214
12215
12216
12217
12218
12219
12220
12221
12222
12223
12224
12225
12226
12227
12228
12229
12230
12231
12232
12233
12234
12235
12236
12237
12238
12239
12240
12241
12242
12243
12244
12245
12246
12247
12248
12249
12250
12251
12252
12253
12254
12255
12256
12257
12258
12259
12260
12261
12262
12263
12264
12265
12266
12267
12268
12269
12270
12271
12272
12273
12274
12275
12276
12277
12278
12279
12280
12281
12282
12283
12284
12285
12286
12287
12288
12289
12290
12291
12292
12293
12294
12295
12296
12297
12298
12299
12300
12301
12302
12303
12304
12305
12306
12307
12308
12309
12310
12311
12312
12313
12314
12315
12316
12317
12318
12319
12320
12321
12322
12323
12324
12325
12326
12327
12328
12329
12330
12331
12332
12333
12334
12335
12336
12337
12338
12339
12340
12341
12342
12343
12344
12345
12346
12347
12348
12349
12350
12351
12352
12353
12354
12355
12356
12357
12358
12359
12360
12361
12362
12363
12364
12365
12366
12367
12368
12369
12370
12371
12372
12373
12374
12375
12376
12377
12378
12379
12380
12381
12382
12383
12384
12385
12386
12387
12388
12389
12390
12391
12392
12393
12394
12395
12396
12397
12398
12399
12400
12401
12402
12403
12404
12405
12406
12407
12408
12409
12410
12411
12412
12413
12414
12415
12416
12417
12418
12419
12420
12421
12422
12423
12424
12425
12426
12427
12428
12429
12430
12431
12432
12433
12434
12435
12436
12437
12438
12439
12440
12441
12442
12443
12444
12445
12446
12447
12448
12449
12450
12451
12452
12453
12454
12455
12456
12457
12458
12459
12460
12461
12462
12463
12464
12465
12466
12467
12468
12469
12470
12471
12472
12473
12474
12475
12476
12477
12478
12479
12480
12481
12482
12483
12484
12485
12486
12487
12488
12489
12490
12491
12492
12493
12494
12495
12496
12497
12498
12499
12500
12501
12502
12503
12504
12505
12506
12507
12508
12509
12510
12511
12512
12513
12514
12515
12516
12517
12518
12519
12520
12521
12522
12523
12524
12525
12526
12527
12528
12529
12530
12531
12532
12533
12534
12535
12536
12537
12538
12539
12540
12541
12542
12543
12544
12545
12546
12547
12548
12549
12550
12551
12552
12553
12554
12555
12556
12557
12558
12559
12560
12561
12562
12563
12564
12565
12566
12567
12568
12569
12570
12571
12572
12573
12574
12575
12576
12577
12578
12579
12580
12581
12582
12583
12584
12585
12586
12587
12588
12589
12590
12591
12592
12593
12594
12595
12596
12597
12598
12599
12600
12601
12602
12603
12604
12605
12606
12607
12608
12609
12610
12611
12612
12613
12614
12615
12616
12617
12618
12619
12620
12621
12622
12623
12624
12625
12626
12627
12628
12629
12630
12631
12632
12633
12634
12635
12636
12637
12638
12639
12640
12641
12642
12643
12644
12645
12646
12647
12648
12649
12650
12651
12652
12653
12654
12655
12656
12657
12658
12659
12660
12661
12662
12663
12664
12665
12666
12667
12668
12669
12670
12671
12672
12673
12674
12675
12676
12677
12678
12679
12680
12681
12682
12683
12684
12685
12686
12687
12688
12689
12690
12691
12692
12693
12694
12695
12696
12697
12698
12699
12700
12701
12702
12703
12704
12705
12706
12707
12708
12709
12710
12711
12712
12713
12714
12715
12716
12717
12718
12719
12720
12721
12722
12723
12724
12725
12726
12727
12728
12729
12730
12731
12732
12733
12734
12735
12736
12737
12738
12739
12740
12741
12742
12743
12744
12745
12746
12747
12748
12749
12750
12751
12752
12753
12754
12755
12756
12757
12758
12759
12760
12761
12762
12763
12764
12765
12766
12767
12768
12769
12770
12771
12772
12773
12774
12775
12776
12777
12778
12779
12780
12781
12782
12783
12784
12785
12786
12787
12788
12789
12790
12791
12792
12793
12794
12795
12796
12797
12798
12799
12800
12801
12802
12803
12804
12805
12806
12807
12808
12809
12810
12811
12812
12813
12814
12815
12816
12817
12818
12819
12820
12821
12822
12823
12824
12825
12826
12827
12828
12829
12830
12831
12832
12833
12834
12835
12836
12837
12838
12839
12840
12841
12842
12843
12844
12845
12846
12847
12848
12849
12850
12851
12852
12853
12854
12855
12856
12857
12858
12859
12860
12861
12862
12863
12864
12865
12866
12867
12868
12869
12870
12871
12872
12873
12874
12875
12876
12877
12878
12879
12880
12881
12882
12883
12884
12885
12886
12887
12888
12889
12890
12891
12892
12893
12894
12895
12896
12897
12898
12899
12900
12901
12902
12903
12904
12905
12906
12907
12908
12909
12910
12911
12912
12913
12914
12915
12916
12917
12918
12919
12920
12921
12922
12923
12924
12925
12926
12927
12928
12929
12930
12931
12932
12933
12934
12935
12936
12937
12938
12939
12940
12941
12942
12943
12944
12945
12946
12947
12948
12949
12950
12951
12952
12953
12954
12955
12956
12957
12958
12959
12960
12961
12962
12963
12964
12965
12966
12967
12968
12969
12970
12971
12972
12973
12974
12975
12976
12977
12978
12979
12980
12981
12982
12983
12984
12985
12986
12987
12988
12989
12990
12991
12992
12993
12994
12995
12996
12997
12998
12999
13000
13001
13002
13003
13004
13005
13006
13007
13008
13009
13010
13011
13012
13013
13014
13015
13016
13017
13018
13019
13020
13021
13022
13023
13024
13025
13026
13027
13028
13029
13030
13031
13032
13033
13034
13035
13036
13037
13038
13039
13040
13041
13042
13043
13044
13045
13046
13047
13048
13049
13050
13051
13052
13053
13054
13055
13056
13057
13058
13059
13060
13061
13062
13063
13064
13065
13066
13067
13068
13069
13070
13071
13072
13073
13074
13075
13076
13077
13078
13079
13080
13081
13082
13083
13084
13085
13086
13087
13088
13089
13090
13091
13092
13093
13094
13095
13096
13097
13098
13099
13100
13101
13102
13103
13104
13105
13106
13107
13108
13109
13110
13111
13112
13113
13114
13115
13116
13117
13118
13119
13120
13121
13122
13123
13124
13125
13126
13127
13128
13129
13130
13131
13132
13133
13134
13135
13136
13137
13138
13139
13140
13141
13142
13143
13144
13145
13146
13147
13148
13149
13150
13151
13152
13153
13154
13155
13156
13157
13158
13159
13160
13161
13162
13163
13164
13165
13166
13167
13168
13169
13170
13171
13172
13173
13174
13175
13176
13177
13178
13179
13180
13181
13182
13183
13184
13185
13186
13187
13188
13189
13190
13191
13192
13193
13194
13195
13196
13197
13198
13199
13200
13201
13202
13203
13204
13205
13206
13207
13208
13209
13210
13211
13212
13213
13214
13215
13216
13217
13218
13219
13220
13221
13222
13223
13224
13225
13226
13227
13228
13229
13230
13231
13232
13233
13234
13235
13236
13237
13238
13239
13240
13241
13242
13243
13244
13245
13246
13247
13248
13249
13250
13251
13252
13253
13254
13255
13256
13257
13258
13259
13260
13261
13262
13263
13264
13265
13266
13267
13268
13269
13270
13271
13272
13273
13274
13275
13276
13277
13278
13279
13280
13281
13282
13283
13284
13285
13286
13287
13288
13289
13290
13291
13292
13293
13294
13295
13296
13297
13298
13299
13300
13301
13302
13303
13304
13305
13306
13307
13308
13309
13310
13311
13312
13313
13314
13315
13316
13317
13318
13319
13320
13321
13322
13323
13324
13325
13326
13327
13328
13329
13330
13331
13332
13333
13334
13335
13336
13337
13338
13339
13340
13341
13342
13343
13344
13345
13346
13347
13348
13349
13350
13351
13352
13353
13354
13355
13356
13357
13358
13359
13360
13361
13362
13363
13364
13365
13366
13367
13368
13369
13370
13371
13372
13373
13374
13375
13376
13377
13378
13379
13380
13381
13382
13383
13384
13385
13386
13387
13388
13389
13390
13391
13392
13393
13394
13395
13396
13397
13398
13399
13400
13401
13402
13403
13404
13405
13406
13407
13408
13409
13410
13411
13412
13413
13414
13415
13416
13417
13418
13419
13420
13421
13422
13423
13424
13425
13426
13427
13428
13429
13430
13431
13432
13433
13434
13435
13436
13437
13438
13439
13440
13441
13442
13443
13444
13445
13446
13447
13448
13449
13450
13451
13452
13453
13454
13455
13456
13457
13458
13459
13460
13461
13462
13463
13464
13465
13466
13467
13468
13469
13470
13471
13472
13473
13474
13475
13476
13477
13478
13479
13480
13481
13482
13483
13484
13485
13486
13487
13488
13489
13490
13491
13492
13493
13494
13495
13496
13497
13498
13499
13500
13501
13502
13503
13504
13505
13506
13507
13508
13509
13510
13511
13512
13513
13514
13515
13516
13517
13518
13519
13520
13521
13522
13523
13524
13525
13526
13527
13528
13529
13530
13531
13532
13533
13534
13535
13536
13537
13538
13539
13540
13541
13542
13543
13544
13545
13546
13547
13548
13549
13550
13551
13552
13553
13554
13555
13556
13557
13558
13559
13560
13561
13562
13563
13564
13565
13566
13567
13568
13569
13570
13571
13572
13573
13574
13575
13576
13577
13578
13579
13580
13581
13582
13583
13584
13585
13586
13587
13588
13589
13590
13591
13592
13593
13594
13595
13596
13597
13598
13599
13600
13601
13602
13603
13604
13605
13606
13607
13608
13609
13610
13611
13612
13613
13614
13615
13616
13617
13618
13619
13620
13621
13622
13623
13624
13625
13626
13627
13628
13629
13630
13631
13632
13633
13634
13635
13636
13637
13638
13639
13640
13641
13642
13643
13644
13645
13646
13647
13648
13649
13650
13651
13652
13653
13654
13655
13656
13657
13658
13659
13660
13661
13662
13663
13664
13665
13666
13667
13668
13669
13670
13671
13672
13673
13674
13675
13676
13677
13678
13679
13680
13681
13682
13683
13684
13685
13686
13687
13688
13689
13690
13691
13692
13693
13694
13695
13696
13697
13698
13699
13700
13701
13702
13703
13704
13705
13706
13707
13708
13709
13710
13711
13712
13713
13714
13715
13716
13717
13718
13719
13720
13721
13722
13723
13724
13725
13726
13727
13728
13729
13730
13731
13732
13733
13734
13735
13736
13737
13738
13739
13740
13741
13742
13743
13744
13745
13746
13747
13748
13749
13750
13751
13752
13753
13754
13755
13756
13757
13758
13759
13760
13761
13762
13763
13764
13765
13766
13767
13768
13769
13770
13771
13772
13773
13774
13775
13776
13777
13778
13779
13780
13781
13782
13783
13784
13785
13786
13787
13788
13789
13790
13791
13792
13793
13794
13795
13796
13797
13798
13799
13800
13801
13802
13803
13804
13805
13806
13807
13808
13809
13810
13811
13812
13813
13814
13815
13816
13817
13818
13819
13820
13821
13822
13823
13824
13825
13826
13827
13828
13829
13830
13831
13832
13833
13834
13835
13836
13837
13838
13839
13840
13841
13842
13843
13844
13845
13846
13847
13848
13849
13850
13851
13852
13853
13854
13855
13856
13857
13858
13859
13860
13861
13862
13863
13864
13865
13866
13867
13868
13869
13870
13871
13872
13873
13874
13875
13876
13877
13878
13879
13880
13881
13882
13883
13884
13885
13886
13887
13888
13889
13890
13891
13892
13893
13894
13895
13896
13897
13898
13899
13900
13901
13902
13903
13904
13905
13906
13907
13908
13909
13910
13911
13912
13913
13914
13915
13916
13917
13918
13919
13920
13921
13922
13923
13924
13925
13926
13927
13928
13929
13930
13931
13932
13933
13934
13935
13936
13937
13938
13939
13940
13941
13942
13943
13944
13945
13946
13947
13948
13949
13950
13951
13952
13953
13954
13955
13956
13957
13958
13959
13960
13961
13962
13963
13964
13965
13966
13967
13968
13969
13970
13971
13972
13973
13974
13975
13976
13977
13978
13979
13980
13981
13982
13983
13984
13985
13986
13987
13988
13989
13990
13991
13992
13993
13994
13995
13996
13997
13998
13999
14000
14001
14002
14003
14004
14005
14006
14007
14008
14009
14010
14011
14012
14013
14014
14015
14016
14017
14018
14019
14020
14021
14022
14023
14024
14025
14026
14027
14028
14029
14030
14031
14032
14033
14034
14035
14036
14037
14038
14039
14040
14041
14042
14043
14044
14045
14046
14047
14048
14049
14050
14051
14052
14053
14054
14055
14056
14057
14058
14059
14060
14061
14062
14063
14064
14065
14066
14067
14068
14069
14070
14071
14072
14073
14074
14075
14076
14077
14078
14079
14080
14081
14082
14083
14084
14085
14086
14087
14088
14089
14090
14091
14092
14093
14094
14095
14096
14097
14098
14099
14100
14101
14102
14103
14104
14105
14106
14107
14108
14109
14110
14111
14112
14113
14114
14115
14116
14117
14118
14119
14120
14121
14122
14123
14124
14125
14126
14127
14128
14129
14130
14131
14132
14133
14134
14135
14136
14137
14138
14139
14140
14141
14142
14143
14144
14145
14146
14147
14148
14149
14150
14151
14152
14153
14154
14155
14156
14157
14158
14159
14160
14161
14162
14163
14164
14165
14166
14167
14168
14169
14170
14171
14172
14173
14174
14175
14176
14177
14178
14179
14180
14181
14182
14183
14184
14185
14186
14187
14188
14189
14190
14191
14192
14193
14194
14195
14196
14197
14198
14199
14200
14201
14202
14203
14204
14205
14206
14207
14208
14209
14210
14211
14212
14213
14214
14215
14216
14217
14218
14219
14220
14221
14222
14223
14224
14225
14226
14227
14228
14229
14230
14231
14232
14233
14234
14235
14236
14237
14238
14239
14240
14241
14242
14243
14244
14245
14246
14247
14248
14249
14250
14251
14252
14253
14254
14255
14256
14257
14258
14259
14260
14261
14262
14263
14264
14265
14266
14267
14268
14269
14270
14271
14272
14273
14274
14275
14276
14277
14278
14279
14280
14281
14282
14283
14284
14285
14286
14287
14288
14289
14290
14291
14292
14293
14294
14295
14296
14297
14298
14299
14300
14301
14302
14303
14304
14305
14306
14307
14308
14309
14310
14311
14312
14313
14314
14315
14316
14317
14318
14319
14320
14321
14322
14323
14324
14325
14326
14327
14328
14329
14330
14331
14332
14333
14334
14335
14336
14337
14338
14339
14340
14341
14342
14343
14344
14345
14346
14347
14348
14349
14350
14351
14352
14353
14354
14355
14356
14357
14358
14359
14360
14361
14362
14363
14364
14365
14366
14367
14368
14369
14370
14371
14372
14373
14374
14375
14376
14377
14378
14379
14380
14381
14382
14383
14384
14385
14386
14387
14388
14389
14390
14391
14392
14393
14394
14395
14396
14397
14398
14399
14400
14401
14402
14403
14404
14405
14406
14407
14408
14409
14410
14411
14412
14413
14414
14415
14416
14417
14418
14419
14420
14421
14422
14423
14424
14425
14426
14427
14428
14429
14430
14431
14432
14433
14434
14435
14436
14437
14438
14439
14440
14441
14442
14443
14444
14445
14446
14447
14448
14449
14450
14451
14452
14453
14454
14455
14456
14457
14458
14459
14460
14461
14462
14463
14464
14465
14466
14467
14468
14469
14470
14471
14472
14473
14474
14475
14476
14477
14478
14479
14480
14481
14482
14483
14484
14485
14486
14487
14488
14489
14490
14491
14492
14493
14494
14495
14496
14497
14498
14499
14500
14501
14502
14503
14504
14505
14506
14507
14508
14509
14510
14511
14512
14513
14514
14515
14516
14517
14518
14519
14520
14521
14522
14523
14524
14525
14526
14527
14528
14529
14530
14531
14532
14533
14534
14535
14536
14537
14538
14539
14540
14541
14542
14543
14544
14545
14546
14547
14548
14549
14550
14551
14552
14553
14554
14555
14556
14557
14558
14559
14560
14561
14562
14563
14564
14565
14566
14567
14568
14569
14570
14571
14572
14573
14574
14575
14576
14577
14578
14579
14580
14581
14582
14583
14584
14585
14586
14587
14588
14589
14590
14591
14592
14593
14594
14595
14596
14597
14598
14599
14600
14601
14602
14603
14604
14605
14606
14607
14608
14609
14610
14611
14612
14613
14614
14615
14616
14617
14618
14619
14620
14621
14622
14623
14624
14625
14626
14627
14628
14629
14630
14631
14632
14633
14634
14635
14636
14637
14638
14639
14640
14641
14642
14643
14644
14645
14646
14647
14648
14649
14650
14651
14652
14653
14654
14655
14656
14657
14658
14659
14660
14661
14662
14663
14664
14665
14666
14667
14668
14669
14670
14671
14672
14673
14674
14675
14676
14677
14678
14679
14680
14681
14682
14683
14684
14685
14686
14687
14688
14689
14690
14691
14692
14693
14694
14695
14696
14697
14698
14699
14700
14701
14702
14703
14704
14705
14706
14707
14708
14709
14710
14711
14712
14713
14714
14715
14716
14717
14718
14719
14720
14721
14722
14723
14724
14725
14726
14727
14728
14729
14730
14731
14732
14733
14734
14735
14736
14737
14738
14739
14740
14741
14742
14743
14744
14745
14746
14747
14748
14749
14750
14751
14752
14753
14754
14755
14756
14757
14758
14759
14760
14761
14762
14763
14764
14765
14766
14767
14768
14769
14770
14771
14772
14773
14774
14775
14776
14777
14778
14779
14780
14781
14782
14783
14784
14785
14786
14787
14788
14789
14790
14791
14792
14793
14794
14795
14796
14797
14798
14799
14800
14801
14802
14803
14804
14805
14806
14807
14808
14809
14810
14811
14812
14813
14814
14815
14816
14817
14818
14819
14820
14821
14822
14823
14824
14825
14826
14827
14828
14829
14830
14831
14832
14833
14834
14835
14836
14837
14838
14839
14840
14841
14842
14843
14844
14845
14846
14847
14848
14849
14850
14851
14852
14853
14854
14855
14856
14857
14858
14859
14860
14861
14862
14863
14864
14865
14866
14867
14868
14869
14870
14871
14872
14873
14874
14875
14876
14877
14878
14879
14880
14881
14882
14883
14884
14885
14886
14887
14888
14889
14890
14891
14892
14893
14894
14895
14896
14897
14898
14899
14900
14901
14902
14903
14904
14905
14906
14907
14908
14909
14910
14911
14912
14913
14914
14915
14916
14917
14918
14919
14920
14921
14922
14923
14924
14925
14926
14927
14928
14929
14930
14931
14932
14933
14934
14935
14936
14937
14938
14939
14940
14941
14942
14943
14944
14945
14946
14947
14948
14949
14950
14951
14952
14953
14954
14955
14956
14957
14958
14959
14960
14961
14962
14963
14964
14965
14966
14967
14968
14969
14970
14971
14972
14973
14974
14975
14976
14977
14978
14979
14980
14981
14982
14983
14984
14985
14986
14987
14988
14989
14990
14991
14992
14993
14994
14995
14996
14997
14998
14999
15000
15001
15002
15003
15004
15005
15006
15007
15008
15009
15010
15011
15012
15013
15014
15015
15016
15017
15018
15019
15020
15021
15022
15023
15024
15025
15026
15027
15028
15029
15030
15031
15032
15033
15034
15035
15036
15037
15038
15039
15040
15041
15042
15043
15044
15045
15046
15047
15048
15049
15050
15051
15052
15053
15054
15055
15056
15057
15058
15059
15060
15061
15062
15063
15064
15065
15066
15067
15068
15069
15070
15071
15072
15073
15074
15075
15076
15077
15078
15079
15080
15081
15082
15083
15084
15085
15086
15087
15088
15089
15090
15091
15092
15093
15094
15095
15096
15097
15098
15099
15100
15101
15102
15103
15104
15105
15106
15107
15108
15109
15110
15111
15112
15113
15114
15115
15116
15117
15118
15119
15120
15121
15122
15123
15124
15125
15126
15127
15128
15129
15130
15131
15132
15133
15134
15135
15136
15137
15138
15139
15140
15141
15142
15143
15144
15145
15146
15147
15148
15149
15150
15151
15152
15153
15154
15155
15156
15157
15158
15159
15160
15161
15162
15163
15164
15165
15166
15167
15168
15169
15170
15171
15172
15173
15174
15175
15176
15177
15178
15179
15180
15181
15182
15183
15184
15185
15186
15187
15188
15189
15190
15191
15192
15193
15194
15195
15196
15197
15198
15199
15200
15201
15202
15203
15204
15205
15206
15207
15208
15209
15210
15211
15212
15213
15214
15215
15216
15217
15218
15219
15220
15221
15222
15223
15224
15225
15226
15227
15228
15229
15230
15231
15232
15233
15234
15235
15236
15237
15238
15239
15240
15241
15242
15243
15244
15245
15246
15247
15248
15249
15250
15251
15252
15253
15254
15255
15256
15257
15258
15259
15260
15261
15262
15263
15264
15265
15266
15267
15268
15269
15270
15271
15272
15273
15274
15275
15276
15277
15278
15279
15280
15281
15282
15283
15284
15285
15286
15287
15288
15289
15290
15291
15292
15293
15294
15295
15296
15297
15298
15299
15300
15301
15302
15303
15304
15305
15306
15307
15308
15309
15310
15311
15312
15313
15314
15315
15316
15317
15318
15319
15320
15321
15322
15323
15324
15325
15326
15327
15328
15329
15330
15331
15332
15333
15334
15335
15336
15337
15338
15339
15340
15341
15342
15343
15344
15345
15346
15347
15348
15349
15350
15351
15352
15353
15354
15355
15356
15357
15358
15359
15360
15361
15362
15363
15364
15365
15366
15367
15368
15369
15370
15371
15372
15373
15374
15375
15376
15377
15378
15379
15380
15381
15382
15383
15384
15385
15386
15387
15388
15389
15390
15391
15392
15393
15394
15395
15396
15397
15398
15399
15400
15401
15402
15403
15404
15405
15406
15407
15408
15409
15410
15411
15412
15413
15414
15415
15416
15417
15418
15419
15420
15421
15422
15423
15424
15425
15426
15427
15428
15429
15430
15431
15432
15433
15434
15435
15436
15437
15438
15439
15440
15441
15442
15443
15444
15445
15446
15447
15448
15449
15450
15451
15452
15453
15454
15455
15456
15457
15458
15459
15460
15461
15462
15463
15464
15465
15466
15467
15468
15469
15470
15471
15472
15473
15474
15475
15476
15477
15478
15479
15480
15481
15482
15483
15484
15485
15486
15487
15488
15489
15490
15491
15492
15493
15494
15495
15496
15497
15498
15499
15500
15501
15502
15503
15504
15505
15506
15507
15508
15509
15510
15511
15512
15513
15514
15515
15516
15517
15518
15519
15520
15521
15522
15523
15524
15525
15526
15527
15528
15529
15530
15531
15532
15533
15534
15535
15536
15537
15538
15539
15540
15541
15542
15543
15544
15545
15546
15547
15548
15549
15550
15551
15552
15553
15554
15555
15556
15557
15558
15559
15560
15561
15562
15563
15564
15565
15566
15567
15568
15569
15570
15571
15572
15573
15574
15575
15576
15577
15578
15579
15580
15581
15582
15583
15584
15585
15586
15587
15588
15589
15590
15591
15592
15593
15594
15595
15596
15597
15598
15599
15600
15601
15602
15603
15604
15605
15606
15607
15608
15609
15610
15611
15612
15613
15614
15615
15616
15617
15618
15619
15620
15621
15622
15623
15624
15625
15626
15627
15628
15629
15630
15631
15632
15633
15634
15635
15636
15637
15638
15639
15640
15641
15642
15643
15644
15645
15646
15647
15648
15649
15650
15651
15652
15653
15654
15655
15656
15657
15658
15659
15660
15661
15662
15663
15664
15665
15666
15667
15668
15669
15670
15671
15672
15673
15674
15675
15676
15677
15678
15679
15680
15681
15682
15683
15684
15685
15686
15687
15688
15689
15690
15691
15692
15693
15694
15695
15696
15697
15698
15699
15700
15701
15702
15703
15704
15705
15706
15707
15708
15709
15710
15711
15712
15713
15714
15715
15716
15717
15718
15719
15720
15721
15722
15723
15724
15725
15726
15727
15728
15729
15730
15731
15732
15733
15734
15735
15736
15737
15738
15739
15740
15741
15742
15743
15744
15745
15746
15747
15748
15749
15750
15751
15752
15753
15754
15755
15756
15757
15758
15759
15760
15761
15762
15763
15764
15765
15766
15767
15768
15769
15770
15771
15772
15773
15774
15775
15776
15777
15778
15779
15780
15781
15782
15783
15784
15785
15786
15787
15788
15789
15790
15791
15792
15793
15794
15795
15796
15797
15798
15799
15800
15801
15802
15803
15804
15805
15806
15807
15808
15809
15810
15811
15812
15813
15814
15815
15816
15817
15818
15819
15820
15821
15822
15823
15824
15825
15826
15827
15828
15829
15830
15831
15832
15833
15834
15835
15836
15837
15838
15839
15840
15841
15842
15843
15844
15845
15846
15847
15848
15849
15850
15851
15852
15853
15854
15855
15856
15857
15858
15859
15860
15861
15862
15863
15864
15865
15866
15867
15868
15869
15870
15871
15872
15873
15874
15875
15876
15877
15878
15879
15880
15881
15882
15883
15884
15885
15886
15887
15888
15889
15890
15891
15892
15893
15894
15895
15896
15897
15898
15899
15900
15901
15902
15903
15904
15905
15906
15907
15908
15909
15910
15911
15912
15913
15914
15915
15916
15917
15918
15919
15920
15921
15922
15923
15924
15925
15926
15927
15928
15929
15930
15931
15932
15933
15934
15935
15936
15937
15938
15939
15940
15941
15942
15943
15944
15945
15946
15947
15948
15949
15950
15951
15952
15953
15954
15955
15956
15957
15958
15959
15960
15961
15962
15963
15964
15965
15966
15967
15968
15969
15970
15971
15972
15973
15974
15975
15976
15977
15978
15979
15980
15981
15982
15983
15984
15985
15986
15987
15988
15989
15990
15991
15992
15993
15994
15995
15996
15997
15998
15999
16000
16001
16002
16003
16004
16005
16006
16007
16008
16009
16010
16011
16012
16013
16014
16015
16016
16017
16018
16019
16020
16021
16022
16023
16024
16025
16026
16027
16028
16029
16030
16031
16032
16033
16034
16035
16036
16037
16038
16039
16040
16041
16042
16043
16044
16045
16046
16047
16048
16049
16050
16051
16052
16053
16054
16055
16056
16057
16058
16059
16060
16061
16062
16063
16064
16065
16066
16067
16068
16069
16070
16071
16072
16073
16074
16075
16076
16077
16078
16079
16080
16081
16082
16083
16084
16085
16086
16087
16088
16089
16090
16091
16092
16093
16094
16095
16096
16097
16098
16099
16100
16101
16102
16103
16104
16105
16106
16107
16108
16109
16110
16111
16112
16113
16114
16115
16116
16117
16118
16119
16120
16121
16122
16123
16124
16125
16126
16127
16128
16129
16130
16131
16132
16133
16134
16135
16136
16137
16138
16139
16140
16141
16142
16143
16144
16145
16146
16147
16148
16149
16150
16151
16152
16153
16154
16155
16156
16157
16158
16159
16160
16161
16162
16163
16164
16165
16166
16167
16168
16169
16170
16171
16172
16173
16174
16175
16176
16177
16178
16179
16180
16181
16182
16183
16184
16185
16186
16187
16188
16189
16190
16191
16192
16193
16194
16195
16196
16197
16198
16199
16200
16201
16202
16203
16204
16205
16206
16207
16208
16209
16210
16211
16212
16213
16214
16215
16216
16217
16218
16219
16220
16221
16222
16223
16224
16225
16226
16227
16228
16229
16230
16231
16232
16233
16234
16235
16236
16237
16238
16239
16240
16241
16242
16243
16244
16245
16246
16247
16248
16249
16250
16251
16252
16253
16254
16255
16256
16257
16258
16259
16260
16261
16262
16263
16264
16265
16266
16267
16268
16269
16270
16271
16272
16273
16274
16275
16276
16277
16278
16279
16280
16281
16282
16283
16284
16285
16286
16287
16288
16289
16290
16291
16292
16293
16294
16295
16296
16297
16298
16299
16300
16301
16302
16303
16304
16305
16306
16307
16308
16309
16310
16311
16312
16313
16314
16315
16316
16317
16318
16319
16320
16321
16322
16323
16324
16325
16326
16327
16328
16329
16330
16331
16332
16333
16334
16335
16336
16337
16338
16339
16340
16341
16342
16343
16344
16345
16346
16347
16348
16349
16350
16351
16352
16353
16354
16355
16356
16357
16358
16359
16360
16361
16362
16363
16364
16365
16366
16367
16368
16369
16370
16371
16372
16373
16374
16375
16376
16377
16378
16379
16380
16381
16382
16383
16384
16385
16386
16387
16388
16389
16390
16391
16392
16393
16394
16395
16396
16397
16398
16399
16400
16401
16402
16403
16404
16405
16406
16407
16408
16409
16410
16411
16412
16413
16414
16415
16416
16417
16418
16419
16420
16421
16422
16423
16424
16425
16426
16427
16428
16429
16430
16431
16432
16433
16434
16435
16436
16437
16438
16439
16440
16441
16442
16443
16444
16445
16446
16447
16448
16449
16450
16451
16452
16453
16454
16455
16456
16457
16458
16459
16460
16461
16462
16463
16464
16465
16466
16467
16468
16469
16470
16471
16472
16473
16474
16475
16476
16477
16478
16479
16480
16481
16482
16483
16484
16485
16486
16487
16488
16489
16490
16491
16492
16493
16494
16495
16496
16497
16498
16499
16500
16501
16502
16503
16504
16505
16506
16507
16508
16509
16510
16511
16512
16513
16514
16515
16516
16517
16518
16519
16520
16521
16522
16523
16524
16525
16526
16527
16528
16529
16530
16531
16532
16533
16534
16535
16536
16537
16538
16539
16540
16541
16542
16543
16544
16545
16546
16547
16548
16549
16550
16551
16552
16553
16554
16555
16556
16557
16558
16559
16560
16561
16562
16563
16564
16565
16566
16567
16568
16569
16570
16571
16572
16573
16574
16575
16576
16577
16578
16579
16580
16581
16582
16583
16584
16585
16586
16587
16588
16589
16590
16591
16592
16593
16594
16595
16596
16597
16598
16599
16600
16601
16602
16603
16604
16605
16606
16607
16608
16609
16610
16611
16612
16613
16614
16615
16616
16617
16618
16619
16620
16621
16622
16623
16624
16625
16626
16627
16628
16629
16630
16631
16632
16633
16634
16635
16636
16637
16638
16639
16640
16641
16642
16643
16644
16645
16646
16647
16648
16649
16650
16651
16652
16653
16654
16655
16656
16657
16658
16659
16660
16661
16662
16663
16664
16665
16666
16667
16668
16669
16670
16671
16672
16673
16674
16675
16676
16677
16678
16679
16680
16681
16682
16683
16684
16685
16686
16687
16688
16689
16690
16691
16692
16693
16694
16695
16696
16697
16698
16699
16700
16701
16702
16703
16704
16705
16706
16707
16708
16709
16710
16711
16712
16713
16714
16715
16716
16717
16718
16719
16720
16721
16722
16723
16724
16725
16726
16727
16728
16729
16730
16731
16732
16733
16734
16735
16736
16737
16738
16739
16740
16741
16742
16743
16744
16745
16746
16747
16748
16749
16750
16751
16752
16753
16754
16755
16756
16757
16758
16759
16760
16761
16762
16763
16764
16765
16766
16767
16768
16769
16770
16771
16772
16773
16774
16775
16776
16777
16778
16779
16780
16781
16782
16783
16784
16785
16786
16787
16788
16789
16790
16791
16792
16793
16794
16795
16796
16797
16798
16799
16800
16801
16802
16803
16804
16805
16806
16807
16808
16809
16810
16811
16812
16813
16814
16815
16816
16817
16818
16819
16820
16821
16822
16823
16824
16825
16826
16827
16828
16829
16830
16831
16832
16833
16834
16835
16836
16837
16838
16839
16840
16841
16842
16843
16844
16845
16846
16847
16848
16849
16850
16851
16852
16853
16854
16855
16856
16857
16858
16859
16860
16861
16862
16863
16864
16865
16866
16867
16868
16869
16870
16871
16872
16873
16874
16875
16876
16877
16878
16879
16880
16881
16882
16883
16884
16885
16886
16887
16888
16889
16890
16891
16892
16893
16894
16895
16896
16897
16898
16899
16900
16901
16902
16903
16904
16905
16906
16907
16908
16909
16910
16911
16912
16913
16914
16915
16916
16917
16918
16919
16920
16921
16922
16923
16924
16925
16926
16927
16928
16929
16930
16931
16932
16933
16934
16935
16936
16937
16938
16939
16940
16941
16942
16943
16944
16945
16946
16947
16948
16949
16950
16951
16952
16953
16954
16955
16956
16957
16958
16959
16960
16961
16962
16963
16964
16965
16966
16967
16968
16969
16970
16971
16972
16973
16974
16975
16976
16977
16978
16979
16980
16981
16982
16983
16984
16985
16986
16987
16988
16989
16990
16991
16992
16993
16994
16995
16996
16997
16998
16999
17000
17001
17002
17003
17004
17005
17006
17007
17008
17009
17010
17011
17012
17013
17014
17015
17016
17017
17018
17019
17020
17021
17022
17023
17024
17025
17026
17027
17028
17029
17030
17031
17032
17033
17034
17035
17036
17037
17038
17039
17040
17041
17042
17043
17044
17045
17046
17047
17048
17049
17050
17051
17052
17053
17054
17055
17056
17057
17058
17059
17060
17061
17062
17063
17064
17065
17066
17067
17068
17069
17070
17071
17072
17073
17074
17075
17076
17077
17078
17079
17080
17081
17082
17083
17084
17085
17086
17087
17088
17089
17090
17091
17092
17093
17094
17095
17096
17097
17098
17099
17100
17101
17102
17103
17104
17105
17106
17107
17108
17109
17110
17111
17112
17113
17114
17115
17116
17117
17118
17119
17120
17121
17122
17123
17124
17125
17126
17127
17128
17129
17130
17131
17132
17133
17134
17135
17136
17137
17138
17139
17140
17141
17142
17143
17144
17145
17146
17147
17148
17149
17150
17151
17152
17153
17154
17155
17156
17157
17158
17159
17160
17161
17162
17163
17164
17165
17166
17167
17168
17169
17170
17171
17172
17173
17174
17175
17176
17177
17178
17179
17180
17181
17182
17183
17184
17185
17186
17187
17188
17189
17190
17191
17192
17193
17194
17195
17196
17197
17198
17199
17200
17201
17202
17203
17204
17205
17206
17207
17208
17209
17210
17211
17212
17213
17214
17215
17216
17217
17218
17219
17220
17221
17222
17223
17224
17225
17226
17227
17228
17229
17230
17231
17232
17233
17234
17235
17236
17237
17238
17239
17240
17241
17242
17243
17244
17245
17246
17247
17248
17249
17250
17251
17252
17253
17254
17255
17256
17257
17258
17259
17260
17261
17262
17263
17264
17265
17266
17267
17268
17269
17270
17271
17272
17273
17274
17275
17276
17277
17278
17279
17280
17281
17282
17283
17284
17285
17286
17287
17288
17289
17290
17291
17292
17293
17294
17295
17296
17297
17298
17299
17300
17301
17302
17303
17304
17305
17306
17307
17308
17309
17310
17311
17312
17313
17314
17315
17316
17317
17318
17319
17320
17321
17322
17323
17324
17325
17326
17327
17328
17329
17330
17331
17332
17333
17334
17335
17336
17337
17338
17339
17340
17341
17342
17343
17344
17345
17346
17347
17348
17349
17350
17351
17352
17353
17354
17355
17356
17357
17358
17359
17360
17361
17362
17363
17364
17365
17366
17367
17368
17369
17370
17371
17372
17373
17374
17375
17376
17377
17378
17379
17380
17381
17382
17383
17384
17385
17386
17387
17388
17389
17390
17391
17392
17393
17394
17395
17396
17397
17398
17399
17400
17401
17402
17403
17404
17405
17406
17407
17408
17409
17410
17411
17412
17413
17414
17415
17416
17417
17418
17419
17420
17421
17422
17423
17424
17425
17426
17427
17428
17429
17430
17431
17432
17433
17434
17435
17436
17437
17438
17439
17440
17441
17442
17443
17444
17445
17446
17447
17448
17449
17450
17451
17452
17453
17454
17455
17456
17457
17458
17459
17460
17461
17462
17463
17464
17465
17466
17467
17468
17469
17470
17471
17472
17473
17474
17475
17476
17477
17478
17479
17480
17481
17482
17483
17484
17485
17486
17487
17488
17489
17490
17491
17492
17493
17494
17495
17496
17497
17498
17499
17500
17501
17502
17503
17504
17505
17506
17507
17508
17509
17510
17511
17512
17513
17514
17515
17516
17517
17518
17519
17520
17521
17522
17523
17524
17525
17526
17527
17528
17529
17530
17531
17532
17533
17534
17535
17536
17537
17538
17539
17540
17541
17542
17543
17544
17545
17546
17547
17548
17549
17550
17551
17552
17553
17554
17555
17556
17557
17558
17559
17560
17561
17562
17563
17564
17565
17566
17567
17568
17569
17570
17571
17572
17573
17574
17575
17576
17577
17578
17579
17580
17581
17582
17583
17584
17585
17586
17587
17588
17589
17590
17591
17592
17593
17594
17595
17596
17597
17598
17599
17600
17601
17602
17603
17604
17605
17606
17607
17608
17609
17610
17611
17612
17613
17614
17615
17616
17617
17618
17619
17620
17621
17622
17623
17624
17625
17626
17627
17628
17629
17630
17631
17632
17633
17634
17635
17636
17637
17638
17639
17640
17641
17642
17643
17644
17645
17646
17647
17648
17649
17650
17651
17652
17653
17654
17655
17656
17657
17658
17659
17660
17661
17662
17663
17664
17665
17666
17667
17668
17669
17670
17671
17672
17673
17674
17675
17676
17677
17678
17679
17680
17681
17682
17683
17684
17685
17686
17687
17688
17689
17690
17691
17692
17693
17694
17695
17696
17697
17698
17699
17700
17701
17702
17703
17704
17705
17706
17707
17708
17709
17710
17711
17712
17713
17714
17715
17716
17717
17718
17719
17720
17721
17722
17723
17724
17725
17726
17727
17728
17729
17730
17731
17732
17733
17734
17735
17736
17737
17738
17739
17740
17741
17742
17743
17744
17745
17746
17747
17748
17749
17750
17751
17752
17753
17754
17755
17756
17757
17758
17759
17760
17761
17762
17763
17764
17765
17766
17767
17768
17769
17770
17771
17772
17773
17774
17775
17776
17777
17778
17779
17780
17781
17782
17783
17784
17785
17786
17787
17788
17789
17790
17791
17792
17793
17794
17795
17796
17797
17798
17799
17800
17801
17802
17803
17804
17805
17806
17807
17808
17809
17810
17811
17812
17813
17814
17815
17816
17817
17818
17819
17820
17821
17822
17823
17824
17825
17826
17827
17828
17829
17830
17831
17832
17833
17834
17835
17836
17837
17838
17839
17840
17841
17842
17843
17844
17845
17846
17847
17848
17849
17850
17851
17852
17853
17854
17855
17856
17857
17858
17859
17860
17861
17862
17863
17864
17865
17866
17867
17868
17869
17870
17871
17872
17873
17874
17875
17876
17877
17878
17879
17880
17881
17882
17883
17884
17885
17886
17887
17888
17889
17890
17891
17892
17893
17894
17895
17896
17897
17898
17899
17900
17901
17902
17903
17904
17905
17906
17907
17908
17909
17910
17911
17912
17913
17914
17915
17916
17917
17918
17919
17920
17921
17922
17923
17924
17925
17926
17927
17928
17929
17930
17931
17932
17933
17934
17935
17936
17937
17938
17939
17940
17941
17942
17943
17944
17945
17946
17947
17948
17949
17950
17951
17952
17953
17954
17955
17956
17957
17958
17959
17960
17961
17962
17963
17964
17965
17966
17967
17968
17969
17970
17971
17972
17973
17974
17975
17976
17977
17978
17979
17980
17981
17982
17983
17984
17985
17986
17987
17988
17989
17990
17991
17992
17993
17994
17995
17996
17997
17998
17999
18000
18001
18002
18003
18004
18005
18006
18007
18008
18009
18010
18011
18012
18013
18014
18015
18016
18017
18018
18019
18020
18021
18022
18023
18024
18025
18026
18027
18028
18029
18030
18031
18032
18033
18034
18035
18036
18037
18038
18039
18040
18041
18042
18043
18044
18045
18046
18047
18048
18049
18050
18051
18052
18053
18054
18055
18056
18057
18058
18059
18060
18061
18062
18063
18064
18065
18066
18067
18068
18069
18070
18071
18072
18073
18074
18075
18076
18077
18078
18079
18080
18081
18082
18083
18084
18085
18086
18087
18088
18089
18090
18091
18092
18093
18094
18095
18096
18097
18098
18099
18100
18101
18102
18103
18104
18105
18106
18107
18108
18109
18110
18111
18112
18113
18114
18115
18116
18117
18118
18119
18120
18121
18122
18123
18124
18125
18126
18127
18128
18129
18130
18131
18132
18133
18134
18135
18136
18137
18138
18139
18140
18141
18142
18143
18144
18145
18146
18147
18148
18149
18150
18151
18152
18153
18154
18155
18156
18157
18158
18159
18160
18161
18162
18163
18164
18165
18166
18167
18168
18169
18170
18171
18172
18173
18174
18175
18176
18177
18178
18179
18180
18181
18182
18183
18184
18185
18186
18187
18188
18189
18190
18191
18192
18193
18194
18195
18196
18197
18198
18199
18200
18201
18202
18203
18204
18205
18206
18207
18208
18209
18210
18211
18212
18213
18214
18215
18216
18217
18218
18219
18220
18221
18222
18223
18224
18225
18226
18227
18228
18229
18230
18231
18232
18233
18234
18235
18236
18237
18238
18239
18240
18241
18242
18243
18244
18245
18246
18247
18248
18249
18250
18251
18252
18253
18254
18255
18256
18257
18258
18259
18260
18261
18262
18263
18264
18265
18266
18267
18268
18269
18270
18271
18272
18273
18274
18275
18276
18277
18278
18279
18280
18281
18282
18283
18284
18285
18286
18287
18288
18289
18290
18291
18292
18293
18294
18295
18296
18297
18298
18299
18300
18301
18302
18303
18304
18305
18306
18307
18308
18309
18310
18311
18312
18313
18314
18315
18316
18317
18318
18319
18320
18321
18322
18323
18324
18325
18326
18327
18328
18329
18330
18331
18332
18333
18334
18335
18336
18337
18338
18339
18340
18341
18342
18343
18344
18345
18346
18347
18348
18349
18350
18351
18352
18353
18354
18355
18356
18357
18358
18359
18360
18361
18362
18363
18364
18365
18366
18367
18368
18369
18370
18371
18372
18373
18374
18375
18376
18377
18378
18379
18380
18381
18382
18383
18384
18385
18386
18387
18388
18389
18390
18391
18392
18393
18394
18395
18396
18397
18398
18399
18400
18401
18402
18403
18404
18405
18406
18407
18408
18409
18410
18411
18412
18413
18414
18415
18416
18417
18418
18419
18420
18421
18422
18423
18424
18425
18426
18427
18428
18429
18430
18431
18432
18433
18434
18435
18436
18437
18438
18439
18440
18441
18442
18443
18444
18445
18446
18447
18448
18449
18450
18451
18452
18453
18454
18455
18456
18457
18458
18459
18460
18461
18462
18463
18464
18465
18466
18467
18468
18469
18470
18471
18472
18473
18474
18475
18476
18477
18478
18479
18480
18481
18482
18483
18484
18485
18486
18487
18488
18489
18490
18491
18492
18493
18494
18495
18496
18497
18498
18499
18500
18501
18502
18503
18504
18505
18506
18507
18508
18509
18510
18511
18512
18513
18514
18515
18516
18517
18518
18519
18520
18521
18522
18523
18524
18525
18526
18527
18528
18529
18530
18531
18532
18533
18534
18535
18536
18537
18538
18539
18540
18541
18542
18543
18544
18545
18546
18547
18548
18549
18550
18551
18552
18553
18554
18555
18556
18557
18558
18559
18560
18561
18562
18563
18564
18565
18566
18567
18568
18569
18570
18571
18572
18573
18574
18575
18576
18577
18578
18579
18580
18581
18582
18583
18584
18585
18586
18587
18588
18589
18590
18591
18592
18593
18594
18595
18596
18597
18598
18599
18600
18601
18602
18603
18604
18605
18606
18607
18608
18609
18610
18611
18612
18613
18614
18615
18616
18617
18618
18619
18620
18621
18622
18623
18624
18625
18626
18627
18628
18629
18630
18631
18632
18633
18634
18635
18636
18637
18638
18639
18640
18641
18642
18643
18644
18645
18646
18647
18648
18649
18650
18651
18652
18653
18654
18655
18656
18657
18658
18659
18660
18661
18662
18663
18664
18665
18666
18667
18668
18669
18670
18671
18672
18673
18674
18675
18676
18677
18678
18679
18680
18681
18682
18683
18684
18685
18686
18687
18688
18689
18690
18691
18692
18693
18694
18695
18696
18697
18698
18699
18700
18701
18702
18703
18704
18705
18706
18707
18708
18709
18710
18711
18712
18713
18714
18715
18716
18717
18718
18719
18720
18721
18722
18723
18724
18725
18726
18727
18728
18729
18730
18731
18732
18733
18734
18735
18736
18737
18738
18739
18740
18741
18742
18743
18744
18745
18746
18747
18748
18749
18750
18751
18752
18753
18754
18755
18756
18757
18758
18759
18760
18761
18762
18763
18764
18765
18766
18767
18768
18769
18770
18771
18772
18773
18774
18775
18776
18777
18778
18779
18780
18781
18782
18783
18784
18785
18786
18787
18788
18789
18790
18791
18792
18793
18794
18795
18796
18797
18798
18799
18800
18801
18802
18803
18804
18805
18806
18807
18808
18809
18810
18811
18812
18813
18814
18815
18816
18817
18818
18819
18820
18821
18822
18823
18824
18825
18826
18827
18828
18829
18830
18831
18832
18833
18834
18835
18836
18837
18838
18839
18840
18841
18842
18843
18844
18845
18846
18847
18848
18849
18850
18851
18852
18853
18854
18855
18856
18857
18858
18859
18860
18861
18862
18863
18864
18865
18866
18867
18868
18869
18870
18871
18872
18873
18874
18875
18876
18877
18878
18879
18880
18881
18882
18883
18884
18885
18886
18887
18888
18889
18890
18891
18892
18893
18894
18895
18896
18897
18898
18899
18900
18901
18902
18903
18904
18905
18906
18907
18908
18909
18910
18911
18912
18913
18914
18915
18916
18917
18918
18919
18920
18921
18922
18923
18924
18925
18926
18927
18928
18929
18930
18931
18932
18933
18934
18935
18936
18937
18938
18939
18940
18941
18942
18943
18944
18945
18946
18947
18948
18949
18950
18951
18952
18953
18954
18955
18956
18957
18958
18959
18960
18961
18962
18963
18964
18965
18966
18967
18968
18969
18970
18971
18972
18973
18974
18975
18976
18977
18978
18979
18980
18981
18982
18983
18984
18985
18986
18987
18988
18989
18990
18991
18992
18993
18994
18995
18996
18997
18998
18999
19000
19001
19002
19003
19004
19005
19006
19007
19008
19009
19010
19011
19012
19013
19014
19015
19016
19017
19018
19019
19020
19021
19022
19023
19024
19025
19026
19027
19028
19029
19030
19031
19032
19033
19034
19035
19036
19037
19038
19039
19040
19041
19042
19043
19044
19045
19046
19047
19048
19049
19050
19051
19052
19053
19054
19055
19056
19057
19058
19059
19060
19061
19062
19063
19064
19065
19066
19067
19068
19069
19070
19071
19072
19073
19074
19075
19076
19077
19078
19079
19080
19081
19082
19083
19084
19085
19086
19087
19088
19089
19090
19091
19092
19093
19094
19095
19096
19097
19098
19099
19100
19101
19102
19103
19104
19105
19106
19107
19108
19109
19110
19111
19112
19113
19114
19115
19116
19117
19118
19119
19120
19121
19122
19123
19124
19125
19126
19127
19128
19129
19130
19131
19132
19133
19134
19135
19136
19137
19138
19139
19140
19141
19142
19143
19144
19145
19146
19147
19148
19149
19150
19151
19152
19153
19154
19155
19156
19157
19158
19159
19160
19161
19162
19163
19164
19165
19166
19167
19168
19169
19170
19171
19172
19173
19174
19175
19176
19177
19178
19179
19180
19181
19182
19183
19184
19185
19186
19187
19188
19189
19190
19191
19192
19193
19194
19195
19196
19197
19198
19199
19200
19201
19202
19203
19204
19205
19206
19207
19208
19209
19210
19211
19212
19213
19214
19215
19216
19217
19218
19219
19220
19221
19222
19223
19224
19225
19226
19227
19228
19229
19230
19231
19232
19233
19234
19235
19236
19237
19238
19239
19240
19241
19242
19243
19244
19245
19246
19247
19248
19249
19250
19251
19252
19253
19254
19255
19256
19257
19258
19259
19260
19261
19262
19263
19264
19265
19266
19267
19268
19269
19270
19271
19272
19273
19274
19275
19276
19277
19278
19279
19280
19281
19282
19283
19284
19285
19286
19287
19288
19289
19290
19291
19292
19293
19294
19295
19296
19297
19298
19299
19300
19301
19302
19303
19304
19305
19306
19307
19308
19309
19310
19311
19312
19313
19314
19315
19316
19317
19318
19319
19320
19321
19322
19323
19324
19325
19326
19327
19328
19329
19330
19331
19332
19333
19334
19335
19336
19337
19338
19339
19340
19341
19342
19343
19344
19345
19346
19347
19348
19349
19350
19351
19352
19353
19354
19355
19356
19357
19358
19359
19360
19361
19362
19363
19364
19365
19366
19367
19368
19369
19370
19371
19372
19373
19374
19375
19376
19377
19378
19379
19380
19381
19382
19383
19384
19385
19386
19387
19388
19389
19390
19391
19392
19393
19394
19395
19396
19397
19398
19399
19400
19401
19402
19403
19404
19405
19406
19407
19408
19409
19410
19411
19412
19413
19414
19415
19416
19417
19418
19419
19420
19421
19422
19423
19424
19425
19426
19427
19428
19429
19430
19431
19432
19433
19434
19435
19436
19437
19438
19439
19440
19441
19442
19443
19444
19445
19446
19447
19448
19449
19450
19451
19452
19453
19454
19455
19456
19457
19458
19459
19460
19461
19462
19463
19464
19465
19466
19467
19468
19469
19470
19471
19472
19473
19474
19475
19476
19477
19478
19479
19480
19481
19482
19483
19484
19485
19486
19487
19488
19489
19490
19491
19492
19493
19494
19495
19496
19497
19498
19499
19500
19501
19502
19503
19504
19505
19506
19507
19508
19509
19510
19511
19512
19513
19514
19515
19516
19517
19518
19519
19520
19521
19522
19523
19524
19525
19526
19527
19528
19529
19530
19531
19532
19533
19534
19535
19536
19537
19538
19539
19540
19541
19542
19543
19544
19545
19546
19547
19548
19549
19550
19551
19552
19553
19554
19555
19556
19557
19558
19559
19560
19561
19562
19563
19564
19565
19566
19567
19568
19569
19570
19571
19572
19573
19574
19575
19576
19577
19578
19579
19580
19581
19582
19583
19584
19585
19586
19587
19588
19589
19590
19591
19592
19593
19594
19595
19596
19597
19598
19599
19600
19601
19602
19603
19604
19605
19606
19607
19608
19609
19610
19611
19612
19613
19614
19615
19616
19617
19618
19619
19620
19621
19622
19623
19624
19625
19626
19627
19628
19629
19630
19631
19632
19633
19634
19635
19636
19637
19638
19639
19640
19641
19642
19643
19644
19645
19646
19647
19648
19649
19650
19651
19652
19653
19654
19655
19656
19657
19658
19659
19660
19661
19662
19663
19664
19665
19666
19667
19668
19669
19670
19671
19672
19673
19674
19675
19676
19677
19678
19679
19680
19681
19682
19683
19684
19685
19686
19687
19688
19689
19690
19691
19692
19693
19694
19695
19696
19697
19698
19699
19700
19701
19702
19703
19704
19705
19706
19707
19708
19709
19710
19711
19712
19713
19714
19715
19716
19717
19718
19719
19720
19721
19722
19723
19724
19725
19726
19727
19728
19729
19730
19731
19732
19733
19734
19735
19736
19737
19738
19739
19740
19741
19742
19743
19744
19745
19746
19747
19748
19749
19750
19751
19752
19753
19754
19755
19756
19757
19758
19759
19760
19761
19762
19763
19764
19765
19766
19767
19768
19769
19770
19771
19772
19773
19774
19775
19776
19777
19778
19779
19780
19781
19782
19783
19784
19785
19786
19787
19788
19789
19790
19791
19792
19793
19794
19795
19796
19797
19798
19799
19800
19801
19802
19803
19804
19805
19806
19807
19808
19809
19810
19811
19812
19813
19814
19815
19816
19817
19818
19819
19820
19821
19822
19823
19824
19825
19826
19827
19828
19829
19830
19831
19832
19833
19834
19835
19836
19837
19838
19839
19840
19841
19842
19843
19844
19845
19846
19847
19848
19849
19850
19851
19852
19853
19854
19855
19856
19857
19858
19859
19860
19861
19862
19863
19864
19865
19866
19867
19868
19869
19870
19871
19872
19873
19874
19875
19876
19877
19878
19879
19880
19881
19882
19883
19884
19885
19886
19887
19888
19889
19890
19891
19892
19893
19894
19895
19896
19897
19898
19899
19900
19901
19902
19903
19904
19905
19906
19907
19908
19909
19910
19911
19912
19913
19914
19915
19916
19917
19918
19919
19920
19921
19922
19923
19924
19925
19926
19927
19928
19929
19930
19931
19932
19933
19934
19935
19936
19937
19938
19939
19940
19941
19942
19943
19944
19945
19946
19947
19948
19949
19950
19951
19952
19953
19954
19955
19956
19957
19958
19959
19960
19961
19962
19963
19964
19965
19966
19967
19968
19969
19970
19971
19972
19973
19974
19975
19976
19977
19978
19979
19980
19981
19982
19983
19984
19985
19986
19987
19988
19989
19990
19991
19992
19993
19994
19995
19996
19997
19998
19999
20000
20001
20002
20003
20004
20005
20006
20007
20008
20009
20010
20011
20012
20013
20014
20015
20016
20017
20018
20019
20020
20021
20022
20023
20024
20025
20026
20027
20028
20029
20030
20031
20032
20033
20034
20035
20036
20037
20038
20039
20040
20041
20042
20043
20044
20045
20046
20047
20048
20049
20050
20051
20052
20053
20054
20055
20056
20057
20058
20059
20060
20061
20062
20063
20064
20065
20066
20067
20068
20069
20070
20071
20072
20073
20074
20075
20076
20077
20078
20079
20080
20081
20082
20083
20084
20085
20086
20087
20088
20089
20090
20091
20092
20093
20094
20095
20096
20097
20098
20099
20100
20101
20102
20103
20104
20105
20106
20107
20108
20109
20110
20111
20112
20113
20114
20115
20116
20117
20118
20119
20120
20121
20122
20123
20124
20125
20126
20127
20128
20129
20130
20131
20132
20133
20134
20135
20136
20137
20138
20139
20140
20141
20142
20143
20144
20145
20146
20147
20148
20149
20150
20151
20152
20153
20154
20155
20156
20157
20158
20159
20160
20161
20162
20163
20164
20165
20166
20167
20168
20169
20170
20171
20172
20173
20174
20175
20176
20177
20178
20179
20180
20181
20182
20183
20184
20185
20186
20187
20188
20189
20190
20191
20192
20193
20194
20195
20196
20197
20198
20199
20200
20201
20202
20203
20204
20205
20206
20207
20208
20209
20210
20211
20212
20213
20214
20215
20216
20217
20218
20219
20220
20221
20222
20223
20224
20225
20226
20227
20228
20229
20230
20231
20232
20233
20234
20235
20236
20237
20238
20239
20240
20241
20242
20243
20244
20245
20246
20247
20248
20249
20250
20251
20252
20253
20254
20255
20256
20257
20258
20259
20260
20261
20262
20263
20264
20265
20266
20267
20268
20269
20270
20271
20272
20273
20274
20275
20276
20277
20278
20279
20280
20281
20282
20283
20284
20285
20286
20287
20288
20289
20290
20291
20292
20293
20294
20295
20296
20297
20298
20299
20300
20301
20302
20303
20304
20305
20306
20307
20308
20309
20310
20311
20312
20313
20314
20315
20316
20317
20318
20319
20320
20321
20322
20323
20324
20325
20326
20327
20328
20329
20330
20331
20332
20333
20334
20335
20336
20337
20338
20339
20340
20341
20342
20343
20344
20345
20346
20347
20348
20349
20350
20351
20352
20353
20354
20355
20356
20357
20358
20359
20360
20361
20362
20363
20364
20365
20366
20367
20368
20369
20370
20371
20372
20373
20374
20375
20376
20377
20378
20379
20380
20381
20382
20383
20384
20385
20386
20387
20388
20389
20390
20391
20392
20393
20394
20395
20396
20397
20398
20399
20400
20401
20402
20403
20404
20405
20406
20407
20408
20409
20410
20411
20412
20413
20414
20415
20416
20417
20418
20419
20420
20421
20422
20423
20424
20425
20426
20427
20428
20429
20430
20431
20432
20433
20434
20435
20436
20437
20438
20439
20440
20441
20442
20443
20444
20445
20446
20447
20448
20449
20450
20451
20452
20453
20454
20455
20456
20457
20458
20459
20460
20461
20462
20463
20464
20465
20466
20467
20468
20469
20470
20471
20472
20473
20474
20475
20476
20477
20478
20479
20480
20481
20482
20483
20484
20485
20486
20487
20488
20489
20490
20491
20492
20493
20494
20495
20496
20497
20498
20499
20500
20501
20502
20503
20504
20505
20506
20507
20508
20509
20510
20511
20512
20513
20514
20515
20516
20517
20518
20519
20520
20521
20522
20523
20524
20525
20526
20527
20528
20529
20530
20531
20532
20533
20534
20535
20536
20537
20538
20539
20540
20541
20542
20543
20544
20545
20546
20547
20548
20549
20550
20551
20552
20553
20554
20555
20556
20557
20558
20559
20560
20561
20562
20563
20564
20565
20566
20567
20568
20569
20570
20571
20572
20573
20574
20575
20576
20577
20578
20579
20580
20581
20582
20583
20584
20585
20586
20587
20588
20589
20590
20591
20592
20593
20594
20595
20596
20597
20598
20599
20600
20601
20602
20603
20604
20605
20606
20607
20608
20609
20610
20611
20612
20613
20614
20615
20616
20617
20618
20619
20620
20621
20622
20623
20624
20625
20626
20627
20628
20629
20630
20631
20632
20633
20634
20635
20636
20637
20638
20639
20640
20641
20642
20643
20644
20645
20646
20647
20648
20649
20650
20651
20652
20653
20654
20655
20656
20657
20658
20659
20660
20661
20662
20663
20664
20665
20666
20667
20668
20669
20670
20671
20672
20673
20674
20675
20676
20677
20678
20679
20680
20681
20682
20683
20684
20685
20686
20687
20688
20689
20690
20691
20692
20693
20694
20695
20696
20697
20698
20699
20700
20701
20702
20703
20704
20705
20706
20707
20708
20709
20710
20711
20712
20713
20714
20715
20716
20717
20718
20719
20720
20721
20722
20723
20724
20725
20726
20727
20728
20729
20730
20731
20732
20733
20734
20735
20736
20737
20738
20739
20740
20741
20742
20743
20744
20745
20746
20747
20748
20749
20750
20751
20752
20753
20754
20755
20756
20757
20758
20759
20760
20761
20762
20763
20764
20765
20766
20767
20768
20769
20770
20771
20772
20773
20774
20775
20776
20777
20778
20779
20780
20781
20782
20783
20784
20785
20786
20787
20788
20789
20790
20791
20792
20793
20794
20795
20796
20797
20798
20799
20800
20801
20802
20803
20804
20805
20806
20807
20808
20809
20810
20811
20812
20813
20814
20815
20816
20817
20818
20819
20820
20821
20822
20823
20824
20825
20826
20827
20828
20829
20830
20831
20832
20833
20834
20835
20836
20837
20838
20839
20840
20841
20842
20843
20844
20845
20846
20847
20848
20849
20850
20851
20852
20853
20854
20855
20856
20857
20858
20859
20860
20861
20862
20863
20864
20865
20866
20867
20868
20869
20870
20871
20872
20873
20874
20875
20876
20877
20878
20879
20880
20881
20882
20883
20884
20885
20886
20887
20888
20889
20890
20891
20892
20893
20894
20895
20896
20897
20898
20899
20900
20901
20902
20903
20904
20905
20906
20907
20908
20909
20910
20911
20912
20913
20914
20915
20916
20917
20918
20919
20920
20921
20922
20923
20924
20925
20926
20927
20928
20929
20930
20931
20932
20933
20934
20935
20936
20937
20938
20939
20940
20941
20942
20943
20944
20945
20946
20947
20948
20949
20950
20951
20952
20953
20954
20955
20956
20957
20958
20959
20960
20961
20962
20963
20964
20965
20966
20967
20968
20969
20970
20971
20972
20973
20974
20975
20976
20977
20978
20979
20980
20981
20982
20983
20984
20985
20986
20987
20988
20989
20990
20991
20992
20993
20994
20995
20996
20997
20998
20999
21000
21001
21002
21003
21004
21005
21006
21007
21008
21009
21010
21011
21012
21013
21014
21015
21016
21017
21018
21019
21020
21021
21022
21023
21024
21025
21026
21027
21028
21029
21030
21031
21032
21033
21034
21035
21036
21037
21038
21039
21040
21041
21042
21043
21044
21045
21046
21047
21048
21049
21050
21051
21052
21053
21054
21055
21056
21057
21058
21059
21060
21061
21062
21063
21064
21065
21066
21067
21068
21069
21070
21071
21072
21073
21074
21075
21076
21077
21078
21079
21080
21081
21082
21083
21084
21085
21086
21087
21088
21089
21090
21091
21092
21093
21094
21095
21096
21097
21098
21099
21100
21101
21102
21103
21104
21105
21106
21107
21108
21109
21110
21111
21112
21113
21114
21115
21116
21117
21118
21119
21120
21121
21122
21123
21124
21125
21126
21127
21128
21129
21130
21131
21132
21133
21134
21135
21136
21137
21138
21139
21140
21141
21142
21143
21144
21145
21146
21147
21148
21149
21150
21151
21152
21153
21154
21155
21156
21157
21158
21159
21160
21161
21162
21163
21164
21165
21166
21167
21168
21169
21170
21171
21172
21173
21174
21175
21176
21177
21178
21179
21180
21181
21182
21183
21184
21185
21186
21187
21188
21189
21190
21191
21192
21193
21194
21195
21196
21197
21198
21199
21200
21201
21202
21203
21204
21205
21206
21207
21208
21209
21210
21211
21212
21213
21214
21215
21216
21217
21218
21219
21220
21221
21222
21223
21224
21225
21226
21227
21228
21229
21230
21231
21232
21233
21234
21235
21236
21237
21238
21239
21240
21241
21242
21243
21244
21245
21246
21247
21248
21249
21250
21251
21252
21253
21254
21255
21256
21257
21258
21259
21260
21261
21262
21263
21264
21265
21266
21267
21268
21269
21270
21271
21272
21273
21274
21275
21276
21277
21278
21279
21280
21281
21282
21283
21284
21285
21286
21287
21288
21289
21290
21291
21292
21293
21294
21295
21296
21297
21298
21299
21300
21301
21302
21303
21304
21305
21306
21307
21308
21309
21310
21311
21312
21313
21314
21315
21316
21317
21318
21319
21320
21321
21322
21323
21324
21325
21326
21327
21328
21329
21330
21331
21332
21333
21334
21335
21336
21337
21338
21339
21340
21341
21342
21343
21344
21345
21346
21347
21348
21349
21350
21351
21352
21353
21354
21355
21356
21357
21358
21359
21360
21361
21362
21363
21364
21365
21366
21367
21368
21369
21370
21371
21372
21373
21374
21375
21376
21377
21378
21379
21380
21381
21382
21383
21384
21385
21386
21387
21388
21389
21390
21391
21392
21393
21394
21395
21396
21397
21398
21399
21400
21401
21402
21403
21404
21405
21406
21407
21408
21409
21410
21411
21412
21413
21414
21415
21416
21417
21418
21419
21420
21421
21422
21423
21424
21425
21426
21427
21428
21429
21430
21431
21432
21433
21434
21435
21436
21437
21438
21439
21440
21441
21442
21443
21444
21445
21446
21447
21448
21449
21450
21451
21452
21453
21454
21455
21456
21457
21458
21459
21460
21461
21462
21463
21464
21465
21466
21467
21468
21469
21470
21471
21472
21473
21474
21475
21476
21477
21478
21479
21480
21481
21482
21483
21484
21485
21486
21487
21488
21489
21490
21491
21492
21493
21494
21495
21496
21497
21498
21499
21500
21501
21502
21503
21504
21505
21506
21507
21508
21509
21510
21511
21512
21513
21514
21515
21516
21517
21518
21519
21520
21521
21522
21523
21524
21525
21526
21527
21528
21529
21530
21531
21532
21533
21534
21535
21536
21537
21538
21539
21540
21541
21542
21543
21544
21545
21546
21547
21548
21549
21550
21551
21552
21553
21554
21555
21556
21557
21558
21559
21560
21561
21562
21563
21564
21565
21566
21567
21568
21569
21570
21571
21572
21573
21574
21575
21576
21577
21578
21579
21580
21581
21582
21583
21584
21585
21586
21587
21588
21589
21590
21591
21592
21593
21594
21595
21596
21597
21598
21599
21600
21601
21602
21603
21604
21605
21606
21607
21608
21609
21610
21611
21612
21613
21614
21615
21616
21617
21618
21619
21620
21621
21622
21623
21624
21625
21626
21627
21628
21629
21630
21631
21632
21633
21634
21635
21636
21637
21638
21639
21640
21641
21642
21643
21644
21645
21646
21647
21648
21649
21650
21651
21652
21653
21654
21655
21656
21657
21658
21659
21660
21661
21662
21663
21664
21665
21666
21667
21668
21669
21670
21671
21672
21673
21674
21675
21676
21677
21678
21679
21680
21681
21682
21683
21684
21685
21686
21687
21688
21689
21690
21691
21692
21693
21694
21695
21696
21697
21698
21699
21700
21701
21702
21703
21704
21705
21706
21707
21708
21709
21710
21711
21712
21713
21714
21715
21716
21717
21718
21719
21720
21721
21722
21723
21724
21725
21726
21727
21728
21729
21730
21731
21732
21733
21734
21735
21736
21737
21738
21739
21740
21741
21742
21743
21744
21745
21746
21747
21748
21749
21750
21751
21752
21753
21754
21755
21756
21757
21758
21759
21760
21761
21762
21763
21764
21765
21766
21767
21768
21769
21770
21771
21772
21773
21774
21775
21776
21777
21778
21779
21780
21781
21782
21783
21784
21785
21786
21787
21788
21789
21790
21791
21792
21793
21794
21795
21796
21797
21798
21799
21800
21801
21802
21803
21804
21805
21806
21807
21808
21809
21810
21811
21812
21813
21814
21815
21816
21817
21818
21819
21820
21821
21822
21823
21824
21825
21826
21827
21828
21829
21830
21831
21832
21833
21834
21835
21836
21837
21838
21839
21840
21841
21842
21843
21844
21845
21846
21847
21848
21849
21850
21851
21852
21853
21854
21855
21856
21857
21858
21859
21860
21861
21862
21863
21864
21865
21866
21867
21868
21869
21870
21871
21872
21873
21874
21875
21876
21877
21878
21879
21880
21881
21882
21883
21884
21885
21886
21887
21888
21889
21890
21891
21892
21893
21894
21895
21896
21897
21898
21899
21900
21901
21902
21903
21904
21905
21906
21907
21908
21909
21910
21911
21912
21913
21914
21915
21916
21917
21918
21919
21920
21921
21922
21923
21924
21925
21926
21927
21928
21929
21930
21931
21932
21933
21934
21935
21936
21937
21938
21939
21940
21941
21942
21943
21944
21945
21946
21947
21948
21949
21950
21951
21952
21953
21954
21955
21956
21957
21958
21959
21960
21961
21962
21963
21964
21965
21966
21967
21968
21969
21970
21971
21972
21973
21974
21975
21976
21977
21978
21979
21980
21981
21982
21983
21984
21985
21986
21987
21988
21989
21990
21991
21992
21993
21994
21995
21996
21997
21998
21999
22000
22001
22002
22003
22004
22005
22006
22007
22008
22009
22010
22011
22012
22013
22014
22015
22016
22017
22018
22019
22020
22021
22022
22023
22024
22025
22026
22027
22028
22029
22030
22031
22032
22033
22034
22035
22036
22037
22038
22039
22040
22041
22042
22043
22044
22045
22046
22047
22048
22049
22050
22051
22052
22053
22054
22055
22056
22057
22058
22059
22060
22061
22062
22063
22064
22065
22066
22067
22068
22069
22070
22071
22072
22073
22074
22075
22076
22077
22078
22079
22080
22081
22082
22083
22084
22085
22086
22087
22088
22089
22090
22091
22092
22093
22094
22095
22096
22097
22098
22099
22100
22101
22102
22103
22104
22105
22106
22107
22108
22109
22110
22111
22112
22113
22114
22115
22116
22117
22118
22119
22120
22121
22122
22123
22124
22125
22126
22127
22128
22129
22130
22131
22132
22133
22134
22135
22136
22137
22138
22139
22140
22141
22142
22143
22144
22145
22146
22147
22148
22149
22150
22151
22152
22153
22154
22155
22156
22157
22158
22159
22160
22161
22162
22163
22164
22165
22166
22167
22168
22169
22170
22171
22172
22173
22174
22175
22176
22177
22178
22179
22180
22181
22182
22183
22184
22185
22186
22187
22188
22189
22190
22191
22192
22193
22194
22195
22196
22197
22198
22199
22200
22201
22202
22203
22204
22205
22206
22207
22208
22209
22210
22211
22212
22213
22214
22215
22216
22217
22218
22219
22220
22221
22222
22223
22224
22225
22226
22227
22228
22229
22230
22231
22232
22233
22234
22235
22236
22237
22238
22239
22240
22241
22242
22243
22244
22245
22246
22247
22248
22249
22250
22251
22252
22253
22254
22255
22256
22257
22258
22259
22260
22261
22262
22263
22264
22265
22266
22267
22268
22269
22270
22271
22272
22273
22274
22275
22276
22277
22278
22279
22280
22281
22282
22283
22284
22285
22286
22287
22288
22289
22290
22291
22292
22293
22294
22295
22296
22297
22298
22299
22300
22301
22302
22303
22304
22305
22306
22307
22308
22309
22310
22311
22312
22313
22314
22315
22316
22317
22318
22319
22320
22321
22322
22323
22324
22325
22326
22327
22328
22329
22330
22331
22332
22333
22334
22335
22336
22337
22338
22339
22340
22341
22342
22343
22344
22345
22346
22347
22348
22349
22350
22351
22352
22353
22354
22355
22356
22357
22358
22359
22360
22361
22362
22363
22364
22365
22366
22367
22368
22369
22370
22371
22372
22373
22374
22375
22376
22377
22378
22379
22380
22381
22382
22383
22384
22385
22386
22387
22388
22389
22390
22391
22392
22393
22394
22395
22396
22397
22398
22399
22400
22401
22402
22403
22404
22405
22406
22407
22408
22409
22410
22411
22412
22413
22414
22415
22416
22417
22418
22419
22420
22421
22422
22423
22424
22425
22426
22427
22428
22429
22430
22431
22432
22433
22434
22435
22436
22437
22438
22439
22440
22441
22442
22443
22444
22445
22446
22447
22448
22449
22450
22451
22452
22453
22454
22455
22456
22457
22458
22459
22460
22461
22462
22463
22464
22465
22466
22467
22468
22469
22470
22471
22472
22473
22474
22475
22476
22477
22478
22479
22480
22481
22482
22483
22484
22485
22486
22487
22488
22489
22490
22491
22492
22493
22494
22495
22496
22497
22498
22499
22500
22501
22502
22503
22504
22505
22506
22507
22508
22509
22510
22511
22512
22513
22514
22515
22516
22517
22518
22519
22520
22521
22522
22523
22524
22525
22526
22527
22528
22529
22530
22531
22532
22533
22534
22535
22536
22537
22538
22539
22540
22541
22542
22543
22544
22545
22546
22547
22548
22549
22550
22551
22552
22553
22554
22555
22556
22557
22558
22559
22560
22561
22562
22563
22564
22565
22566
22567
22568
22569
22570
22571
22572
22573
22574
22575
22576
22577
22578
22579
22580
22581
22582
22583
22584
22585
22586
22587
22588
22589
22590
22591
22592
22593
22594
22595
22596
22597
22598
22599
22600
22601
22602
22603
22604
22605
22606
22607
22608
22609
22610
22611
22612
22613
22614
22615
22616
22617
22618
22619
22620
22621
22622
22623
22624
22625
22626
22627
22628
22629
22630
22631
22632
22633
22634
22635
22636
22637
22638
22639
22640
22641
22642
22643
22644
22645
22646
22647
22648
22649
22650
22651
22652
22653
22654
22655
22656
22657
22658
22659
22660
22661
22662
22663
22664
22665
22666
22667
22668
22669
22670
22671
22672
22673
22674
22675
22676
22677
22678
22679
22680
22681
22682
22683
22684
22685
22686
22687
22688
22689
22690
22691
22692
22693
22694
22695
22696
22697
22698
22699
22700
22701
22702
22703
22704
22705
22706
22707
22708
22709
22710
22711
22712
22713
22714
22715
22716
22717
22718
22719
22720
22721
22722
22723
22724
22725
22726
22727
22728
22729
22730
22731
22732
22733
22734
22735
22736
22737
22738
22739
22740
22741
22742
22743
22744
22745
22746
22747
22748
22749
22750
22751
22752
22753
22754
22755
22756
22757
22758
22759
22760
22761
22762
22763
22764
22765
22766
22767
22768
22769
22770
22771
22772
22773
22774
22775
22776
22777
22778
22779
22780
22781
22782
22783
22784
22785
22786
22787
22788
22789
22790
22791
22792
22793
22794
22795
22796
22797
22798
22799
22800
22801
22802
22803
22804
22805
22806
22807
22808
22809
22810
22811
22812
22813
22814
22815
22816
22817
22818
22819
22820
22821
22822
22823
22824
22825
22826
22827
22828
22829
22830
22831
22832
22833
22834
22835
22836
22837
22838
22839
22840
22841
22842
22843
22844
22845
22846
22847
22848
22849
22850
22851
22852
22853
22854
22855
22856
22857
22858
22859
22860
22861
22862
22863
22864
22865
22866
22867
22868
22869
22870
22871
22872
22873
22874
22875
22876
22877
22878
22879
22880
22881
22882
22883
22884
22885
22886
22887
22888
22889
22890
22891
22892
22893
22894
22895
22896
22897
22898
22899
22900
22901
22902
22903
22904
22905
22906
22907
22908
22909
22910
22911
22912
22913
22914
22915
22916
22917
22918
22919
22920
22921
22922
22923
22924
22925
22926
22927
22928
22929
22930
22931
22932
22933
22934
22935
22936
22937
22938
22939
22940
22941
22942
22943
22944
22945
22946
22947
22948
22949
22950
22951
22952
22953
22954
22955
22956
22957
22958
22959
22960
22961
22962
22963
22964
22965
22966
22967
22968
22969
22970
22971
22972
22973
22974
22975
22976
22977
22978
22979
22980
22981
22982
22983
22984
22985
22986
22987
22988
22989
22990
22991
22992
22993
22994
22995
22996
22997
22998
22999
23000
23001
23002
23003
23004
23005
23006
23007
23008
23009
23010
23011
23012
23013
23014
23015
23016
23017
23018
23019
23020
23021
23022
23023
23024
23025
23026
23027
23028
23029
23030
23031
23032
23033
23034
23035
23036
23037
23038
23039
23040
23041
23042
23043
23044
23045
23046
23047
23048
23049
23050
23051
23052
23053
23054
23055
23056
23057
23058
23059
23060
23061
23062
23063
23064
23065
23066
23067
23068
23069
23070
23071
23072
23073
23074
23075
23076
23077
23078
23079
23080
23081
23082
23083
23084
23085
23086
23087
23088
23089
23090
23091
23092
23093
23094
23095
23096
23097
23098
23099
23100
23101
23102
23103
23104
23105
23106
23107
23108
23109
23110
23111
23112
23113
23114
23115
23116
23117
23118
23119
23120
23121
23122
23123
23124
23125
23126
23127
23128
23129
23130
23131
23132
23133
23134
23135
23136
23137
23138
23139
23140
23141
23142
23143
23144
23145
23146
23147
23148
23149
23150
23151
23152
23153
23154
23155
23156
23157
23158
23159
23160
23161
23162
23163
23164
23165
23166
23167
23168
23169
23170
23171
23172
23173
23174
23175
23176
23177
23178
23179
23180
23181
23182
23183
23184
23185
23186
23187
23188
23189
23190
23191
23192
23193
23194
23195
23196
23197
23198
23199
23200
23201
23202
23203
23204
23205
23206
23207
23208
23209
23210
23211
23212
23213
23214
23215
23216
23217
23218
23219
23220
23221
23222
23223
23224
23225
23226
23227
23228
23229
23230
23231
23232
23233
23234
23235
23236
23237
23238
23239
23240
23241
23242
23243
23244
23245
23246
23247
23248
23249
23250
23251
23252
23253
23254
23255
23256
23257
23258
23259
23260
23261
23262
23263
23264
23265
23266
23267
23268
23269
23270
23271
23272
23273
23274
23275
23276
23277
23278
23279
23280
23281
23282
23283
23284
23285
23286
23287
23288
23289
23290
23291
23292
23293
23294
23295
23296
23297
23298
23299
23300
23301
23302
23303
23304
23305
23306
23307
23308
23309
23310
23311
23312
23313
23314
23315
23316
23317
23318
23319
23320
23321
23322
23323
23324
23325
23326
23327
23328
23329
23330
23331
23332
23333
23334
23335
23336
23337
23338
23339
23340
23341
23342
23343
23344
23345
23346
23347
23348
23349
23350
23351
23352
23353
23354
23355
23356
23357
23358
23359
23360
23361
23362
23363
23364
23365
23366
23367
23368
23369
23370
23371
23372
23373
23374
23375
23376
23377
23378
23379
23380
23381
23382
23383
23384
23385
23386
23387
23388
23389
23390
23391
23392
23393
23394
23395
23396
23397
23398
23399
23400
23401
23402
23403
23404
23405
23406
23407
23408
23409
23410
23411
23412
23413
23414
23415
23416
23417
23418
23419
23420
23421
23422
23423
23424
23425
23426
23427
23428
23429
23430
23431
23432
23433
23434
23435
23436
23437
23438
23439
23440
23441
23442
23443
23444
23445
23446
23447
23448
23449
23450
23451
23452
23453
23454
23455
23456
23457
23458
23459
23460
23461
23462
23463
23464
23465
23466
23467
23468
23469
23470
23471
23472
23473
23474
23475
23476
23477
23478
23479
23480
23481
23482
23483
23484
23485
23486
23487
23488
23489
23490
23491
23492
23493
23494
23495
23496
23497
23498
23499
23500
23501
23502
23503
23504
23505
23506
23507
23508
23509
23510
23511
23512
23513
23514
23515
23516
23517
23518
23519
23520
23521
23522
23523
23524
23525
23526
23527
23528
23529
23530
23531
23532
23533
23534
23535
23536
23537
23538
23539
23540
23541
23542
23543
23544
23545
23546
23547
23548
23549
23550
23551
23552
23553
23554
23555
23556
23557
23558
23559
23560
23561
23562
23563
23564
23565
23566
23567
23568
23569
23570
23571
23572
23573
23574
23575
23576
23577
23578
23579
23580
23581
23582
23583
23584
23585
23586
23587
23588
23589
23590
23591
23592
23593
23594
23595
23596
23597
23598
23599
23600
23601
23602
23603
23604
23605
23606
23607
23608
23609
23610
23611
23612
23613
23614
23615
23616
23617
23618
23619
23620
23621
23622
23623
23624
23625
23626
23627
23628
23629
23630
23631
23632
23633
23634
23635
23636
23637
23638
23639
23640
23641
23642
23643
23644
23645
23646
23647
23648
23649
23650
23651
23652
23653
23654
23655
23656
23657
23658
23659
23660
23661
23662
23663
23664
23665
23666
23667
23668
23669
23670
23671
23672
23673
23674
23675
23676
23677
23678
23679
23680
23681
23682
23683
23684
23685
23686
23687
23688
23689
23690
23691
23692
23693
23694
23695
23696
23697
23698
23699
23700
23701
23702
23703
23704
23705
23706
23707
23708
23709
23710
23711
23712
23713
23714
23715
23716
23717
23718
23719
23720
23721
23722
23723
23724
23725
23726
23727
23728
23729
23730
23731
23732
23733
23734
23735
23736
23737
23738
23739
23740
23741
23742
23743
23744
23745
23746
23747
23748
23749
23750
23751
23752
23753
23754
23755
23756
23757
23758
23759
23760
23761
23762
23763
23764
23765
23766
23767
23768
23769
23770
23771
23772
23773
23774
23775
23776
23777
23778
23779
23780
23781
23782
23783
23784
23785
23786
23787
23788
23789
23790
23791
23792
23793
23794
23795
23796
23797
23798
23799
23800
23801
23802
23803
23804
23805
23806
23807
23808
23809
23810
23811
23812
23813
23814
23815
23816
23817
23818
23819
23820
23821
23822
23823
23824
23825
23826
23827
23828
23829
23830
23831
23832
23833
23834
23835
23836
23837
23838
23839
23840
23841
23842
23843
23844
23845
23846
23847
23848
23849
23850
23851
23852
23853
23854
23855
23856
23857
23858
23859
23860
23861
23862
23863
23864
23865
23866
23867
23868
23869
23870
23871
23872
23873
23874
23875
23876
23877
23878
23879
23880
23881
23882
23883
23884
23885
23886
23887
23888
23889
23890
23891
23892
23893
23894
23895
23896
23897
23898
23899
23900
23901
23902
23903
23904
23905
23906
23907
23908
23909
23910
23911
23912
23913
23914
23915
23916
23917
23918
23919
23920
23921
23922
23923
23924
23925
23926
23927
23928
23929
23930
23931
23932
23933
23934
23935
23936
23937
23938
23939
23940
23941
23942
23943
23944
23945
23946
23947
23948
23949
23950
23951
23952
23953
23954
23955
23956
23957
23958
23959
23960
23961
23962
23963
23964
23965
23966
23967
23968
23969
23970
23971
23972
23973
23974
23975
23976
23977
23978
23979
23980
23981
23982
23983
23984
23985
23986
23987
23988
23989
23990
23991
23992
23993
23994
23995
23996
23997
23998
23999
24000
24001
24002
24003
24004
24005
24006
24007
24008
24009
24010
24011
24012
24013
24014
24015
24016
24017
24018
24019
24020
24021
24022
24023
24024
24025
24026
24027
24028
24029
24030
24031
24032
24033
24034
24035
24036
24037
24038
24039
24040
24041
24042
24043
24044
24045
24046
24047
24048
24049
24050
24051
24052
24053
24054
24055
24056
24057
24058
24059
24060
24061
24062
24063
24064
24065
24066
24067
24068
24069
24070
24071
24072
24073
24074
24075
24076
24077
24078
24079
24080
24081
24082
24083
24084
24085
24086
24087
24088
24089
24090
24091
24092
24093
24094
24095
24096
24097
24098
24099
24100
24101
24102
24103
24104
24105
24106
24107
24108
24109
24110
24111
24112
24113
24114
24115
24116
24117
24118
24119
24120
24121
24122
24123
24124
24125
24126
24127
24128
24129
24130
24131
24132
24133
24134
24135
24136
24137
24138
24139
24140
24141
24142
24143
24144
24145
24146
24147
24148
24149
24150
24151
24152
24153
24154
24155
24156
24157
24158
24159
24160
24161
24162
24163
24164
24165
24166
24167
24168
24169
24170
24171
24172
24173
24174
24175
24176
24177
24178
24179
24180
24181
24182
24183
24184
24185
24186
24187
24188
24189
24190
24191
24192
24193
24194
24195
24196
24197
24198
24199
24200
24201
24202
24203
24204
24205
24206
24207
24208
24209
24210
24211
24212
24213
24214
24215
24216
24217
24218
24219
24220
24221
24222
24223
24224
24225
24226
24227
24228
24229
24230
24231
24232
24233
24234
24235
24236
24237
24238
24239
24240
24241
24242
24243
24244
24245
24246
24247
24248
24249
24250
24251
24252
24253
24254
24255
24256
24257
24258
24259
24260
24261
24262
24263
24264
24265
24266
24267
24268
24269
24270
24271
24272
24273
24274
24275
24276
24277
24278
24279
24280
24281
24282
24283
24284
24285
24286
24287
24288
24289
24290
24291
24292
24293
24294
24295
24296
24297
24298
24299
24300
24301
24302
24303
24304
24305
24306
24307
24308
24309
24310
24311
24312
24313
24314
24315
24316
24317
24318
24319
24320
24321
24322
24323
24324
24325
24326
24327
24328
24329
24330
24331
24332
24333
24334
24335
24336
24337
24338
24339
24340
24341
24342
24343
24344
24345
24346
24347
24348
24349
24350
24351
24352
24353
24354
24355
24356
24357
24358
24359
24360
24361
24362
24363
24364
24365
24366
24367
24368
24369
24370
24371
24372
24373
24374
24375
24376
24377
24378
24379
24380
24381
24382
24383
24384
24385
24386
24387
24388
24389
24390
24391
24392
24393
24394
24395
24396
24397
24398
24399
24400
24401
24402
24403
24404
24405
24406
24407
24408
24409
24410
24411
24412
24413
24414
24415
24416
24417
24418
24419
24420
24421
24422
24423
24424
24425
24426
24427
24428
24429
24430
24431
24432
24433
24434
24435
24436
24437
24438
24439
24440
24441
24442
24443
24444
24445
24446
24447
24448
24449
24450
24451
24452
24453
24454
24455
24456
24457
24458
24459
24460
24461
24462
24463
24464
24465
24466
24467
24468
24469
24470
24471
24472
24473
24474
24475
24476
24477
24478
24479
24480
24481
24482
24483
24484
24485
24486
24487
24488
24489
24490
24491
24492
24493
24494
24495
24496
24497
24498
24499
24500
24501
24502
24503
24504
24505
24506
24507
24508
24509
24510
24511
24512
24513
24514
24515
24516
24517
24518
24519
24520
24521
24522
24523
24524
24525
24526
24527
24528
24529
24530
24531
24532
24533
24534
24535
24536
24537
24538
24539
24540
24541
24542
24543
24544
24545
24546
24547
24548
24549
24550
24551
24552
24553
24554
24555
24556
24557
24558
24559
24560
24561
24562
24563
24564
24565
24566
24567
24568
24569
24570
24571
24572
24573
24574
24575
24576
24577
24578
24579
24580
24581
24582
24583
24584
24585
24586
24587
24588
24589
24590
24591
24592
24593
24594
24595
24596
24597
24598
24599
24600
24601
24602
24603
24604
24605
24606
24607
24608
24609
24610
24611
24612
24613
24614
24615
24616
24617
24618
24619
24620
24621
24622
24623
24624
24625
24626
24627
24628
24629
24630
24631
24632
24633
24634
24635
24636
24637
24638
24639
24640
24641
24642
24643
24644
24645
24646
24647
24648
24649
24650
24651
24652
24653
24654
24655
24656
24657
24658
24659
24660
24661
24662
24663
24664
24665
24666
24667
24668
24669
24670
24671
24672
24673
24674
24675
24676
24677
24678
24679
24680
24681
24682
24683
24684
24685
24686
24687
24688
24689
24690
24691
24692
24693
24694
24695
24696
24697
24698
24699
24700
24701
24702
24703
24704
24705
24706
24707
24708
24709
24710
24711
24712
24713
24714
24715
24716
24717
24718
24719
24720
24721
24722
24723
24724
24725
24726
24727
24728
24729
24730
24731
24732
24733
24734
24735
24736
24737
24738
24739
24740
24741
24742
24743
24744
24745
24746
24747
24748
24749
24750
24751
24752
24753
24754
24755
24756
24757
24758
|
2008-11-03 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Simon Hausmann.
Add methods for getting and setting user data on History Item.
This change is limited to QT port only. Tests were added in
the patch for https://bugs.webkit.org/show_bug.cgi?id=21864.
Minor change by Simon: made the functions inline and added a missing
const.
* history/HistoryItem.h:
2008-11-01 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22030
Make EventNames usable from multiple threads
* platform/text/AtomicString.cpp:
(WebCore::stringTable):
(WebCore::AtomicString::add):
(WebCore::AtomicString::remove):
(WebCore::AtomicString::find):
(WebCore::AtomicString::init):
* platform/text/AtomicString.h:
Atomic string table is now per-thread. Individual strings cannot be shared between threads,
so global AtomicString constants cannot be used from threads other than the main one.
* dom/EventNames.cpp:
(WebCore::EventNames::EventNames):
(WebCore::eventNames):
(WebCore::EventNames::init):
* dom/EventNames.h:
Made EventNames a ThreadSpecific struct. Individual event names are now accessed as
eventNames().fooEvent, not EventNames::fooEvent. This makes EventNames usable from all
threads.
* WebCore.base.exp:
* bindings/js/JSDOMWindowBase.cpp:
* bindings/js/JSEventListener.cpp:
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::processingUserGesture):
* dom/BeforeTextInsertedEvent.cpp:
(WebCore::BeforeTextInsertedEvent::BeforeTextInsertedEvent):
* dom/BeforeUnloadEvent.cpp:
(WebCore::BeforeUnloadEvent::BeforeUnloadEvent):
* dom/CharacterData.cpp:
(WebCore::CharacterData::dispatchModifiedEvent):
* dom/ContainerNode.cpp:
(WebCore::dispatchChildInsertionEvents):
(WebCore::dispatchChildRemovalEvents):
* dom/DedicatedWorker.cpp:
(WebCore::DedicatedWorker::dispatchErrorEvent):
* dom/Document.cpp:
(WebCore::Document::implicitClose):
(WebCore::Document::setFocusedNode):
(WebCore::Document::addListenerTypeIfNeeded):
(WebCore::Document::removeWindowInlineEventListenerForType):
(WebCore::Document::addWindowEventListener):
(WebCore::Document::removeWindowEventListener):
(WebCore::Document::finishedParsing):
* dom/EventTargetNode.cpp:
(WebCore::EventTargetNode::dispatchGenericEvent):
(WebCore::EventTargetNode::dispatchSubtreeModifiedEvent):
(WebCore::EventTargetNode::dispatchWindowEvent):
(WebCore::EventTargetNode::dispatchUIEvent):
(WebCore::EventTargetNode::dispatchSimulatedClick):
(WebCore::EventTargetNode::dispatchMouseEvent):
(WebCore::EventTargetNode::dispatchFocusEvent):
(WebCore::EventTargetNode::dispatchBlurEvent):
(WebCore::EventTargetNode::defaultEventHandler):
(WebCore::EventTargetNode::on*): (multiple methods)
(WebCore::EventTargetNode::setOn*): (multiple methods)
* dom/KeyboardEvent.cpp:
(WebCore::eventTypeForKeyboardEventType):
(WebCore::KeyboardEvent::keyCode):
(WebCore::KeyboardEvent::charCode):
* dom/MessageEvent.cpp:
(WebCore::MessageEvent::MessageEvent):
* dom/MessagePort.cpp:
(WebCore::MessagePort::dispatchMessages):
(WebCore::MessagePort::dispatchCloseEvent):
* dom/MouseEvent.cpp:
(WebCore::MouseEvent::isDragEvent):
(WebCore::MouseEvent::toElement):
(WebCore::MouseEvent::fromElement):
* dom/OverflowEvent.cpp:
(WebCore::OverflowEvent::OverflowEvent):
* dom/TextEvent.cpp:
(WebCore::TextEvent::TextEvent):
* dom/WebKitAnimationEvent.cpp:
(WebCore::WebKitAnimationEvent::WebKitAnimationEvent):
(WebCore::WebKitAnimationEvent::~WebKitAnimationEvent):
(WebCore::WebKitAnimationEvent::initWebKitAnimationEvent):
(WebCore::WebKitAnimationEvent::animationName):
(WebCore::WebKitAnimationEvent::elapsedTime):
* dom/WebKitTransitionEvent.cpp:
(WebCore::WebKitTransitionEvent::WebKitTransitionEvent):
(WebCore::WebKitTransitionEvent::~WebKitTransitionEvent):
(WebCore::WebKitTransitionEvent::initWebKitTransitionEvent):
(WebCore::WebKitTransitionEvent::propertyName):
(WebCore::WebKitTransitionEvent::elapsedTime):
* dom/WheelEvent.cpp:
(WebCore::WheelEvent::WheelEvent):
(WebCore::WheelEvent::initWheelEvent):
* dom/XMLTokenizerLibxml2.cpp:
* dom/XMLTokenizerQt.cpp:
* editing/DeleteButton.cpp:
(WebCore::DeleteButton::defaultEventHandler):
* editing/EditCommand.cpp:
* editing/Editor.cpp:
(WebCore::Editor::canDHTMLCut):
(WebCore::Editor::canDHTMLCopy):
(WebCore::Editor::canDHTMLPaste):
(WebCore::Editor::tryDHTMLCopy):
(WebCore::Editor::tryDHTMLCut):
(WebCore::Editor::tryDHTMLPaste):
(WebCore::dispatchEditableContentChangedEvents):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::ReplacementFragment):
* editing/SelectionController.cpp:
(WebCore::SelectionController::setFocused):
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::defaultEventHandler):
* html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::parseMappedAttribute):
* html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::parseMappedAttribute):
(WebCore::HTMLButtonElement::defaultEventHandler):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::parseMappedAttribute):
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::onChange):
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::handleLocalEvents):
(WebCore::HTMLFormElement::prepareSubmit):
(WebCore::HTMLFormElement::reset):
(WebCore::HTMLFormElement::parseMappedAttribute):
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::parseMappedAttribute):
* html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::parseMappedAttribute):
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseMappedAttribute):
* html/HTMLImageLoader.cpp:
(WebCore::HTMLImageLoader::dispatchLoadEvent):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseMappedAttribute):
(WebCore::HTMLInputElement::setValueFromRenderer):
(WebCore::HTMLInputElement::preDispatchEventHandler):
(WebCore::HTMLInputElement::postDispatchEventHandler):
(WebCore::HTMLInputElement::defaultEventHandler):
(WebCore::HTMLInputElement::onSearch):
* html/HTMLLabelElement.cpp:
(WebCore::HTMLLabelElement::defaultEventHandler):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::load):
(WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::progressEventTimerFired):
(WebCore::HTMLMediaElement::seek):
(WebCore::HTMLMediaElement::setDefaultPlaybackRate):
(WebCore::HTMLMediaElement::setPlaybackRate):
(WebCore::HTMLMediaElement::play):
(WebCore::HTMLMediaElement::pause):
(WebCore::HTMLMediaElement::setVolume):
(WebCore::HTMLMediaElement::setMuted):
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::documentWillBecomeInactive):
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parseMappedAttribute):
* html/HTMLOptionElement.cpp:
* html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::parseMappedAttribute):
(WebCore::HTMLScriptElement::dispatchLoadEvent):
(WebCore::HTMLScriptElement::dispatchErrorEvent):
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::parseMappedAttribute):
(WebCore::HTMLSelectElement::defaultEventHandler):
(WebCore::HTMLSelectElement::menuListDefaultEventHandler):
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::parseMappedAttribute):
(WebCore::HTMLTextAreaElement::defaultEventHandler):
* html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::notifyFinished):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopLoading):
(WebCore::FrameLoader::canCachePage):
* loader/ImageDocument.cpp:
(WebCore::ImageEventListener::handleEvent):
* loader/ImageLoader.cpp:
* loader/MediaDocument.cpp:
(WebCore::MediaDocument::defaultEventHandler):
* loader/appcache/DOMApplicationCache.cpp:
(WebCore::DOMApplicationCache::callCheckingListener):
(WebCore::DOMApplicationCache::callErrorListener):
(WebCore::DOMApplicationCache::callNoUpdateListener):
(WebCore::DOMApplicationCache::callDownloadingListener):
(WebCore::DOMApplicationCache::callProgressListener):
(WebCore::DOMApplicationCache::callUpdateReadyListener):
(WebCore::DOMApplicationCache::callCachedListener):
* page/AccessibilityObject.cpp:
* page/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::mouseButtonListener):
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::handleContextMenuEvent):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::on*): (multiple methods)
(WebCore::DOMWindow::setOn*): (multiple methods)
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseDoubleClickEvent):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::EventHandler::updateDragAndDrop):
(WebCore::EventHandler::cancelDragAndDrop):
(WebCore::EventHandler::performDragAndDrop):
(WebCore::EventHandler::updateMouseEventTargetNode):
(WebCore::EventHandler::dispatchMouseEvent):
(WebCore::EventHandler::sendContextMenuEvent):
(WebCore::EventHandler::canMouseDownStartSelect):
(WebCore::EventHandler::canMouseDragExtendSelect):
(WebCore::EventHandler::defaultKeyboardEventHandler):
(WebCore::EventHandler::dragSourceMovedTo):
(WebCore::EventHandler::dragSourceEndedAt):
(WebCore::EventHandler::handleDrag):
(WebCore::EventHandler::handleTextInputEvent):
* page/FocusController.cpp:
* page/Frame.cpp:
(WebCore::Frame::sendResizeEvent):
(WebCore::Frame::sendScrollEvent):
* page/Page.cpp:
(WebCore::networkStateChanged):
* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::updateStateMachine):
(WebCore::AnimationBase::animationTimerCallbackFired):
(WebCore::AnimationBase::primeEventTimers):
* page/animation/ImplicitAnimation.cpp:
(WebCore::ImplicitAnimation::onAnimationEnd):
(WebCore::ImplicitAnimation::sendTransitionEvent):
* page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::onAnimationStart):
(WebCore::KeyframeAnimation::onAnimationIteration):
(WebCore::KeyframeAnimation::onAnimationEnd):
(WebCore::KeyframeAnimation::sendAnimationEvent):
* page/gtk/EventHandlerGtk.cpp:
* page/mac/EventHandlerMac.mm:
(WebCore::isKeyboardOptionTab):
* page/mac/FrameMac.mm:
* page/qt/EventHandlerQt.cpp:
(WebCore::isKeyboardOptionTab):
* plugins/PluginView.cpp:
* plugins/gtk/PluginViewGtk.cpp:
* plugins/qt/PluginViewQt.cpp:
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::handleKeyboardEvent):
(WebCore::PluginView::handleMouseEvent):
* rendering/MediaControlElements.cpp:
(WebCore::MediaControlMuteButtonElement::defaultEventHandler):
(WebCore::MediaControlPlayButtonElement::defaultEventHandler):
(WebCore::MediaControlSeekButtonElement::defaultEventHandler):
(WebCore::MediaControlTimelineElement::defaultEventHandler):
(WebCore::MediaControlFullscreenButtonElement::defaultEventHandler):
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::userResize):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollToOffset):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::valueChanged):
* rendering/RenderMedia.cpp:
(WebCore::RenderMedia::forwardEvent):
* rendering/RenderObject.cpp:
* rendering/RenderSlider.cpp:
(WebCore::HTMLSliderThumbElement::defaultEventHandler):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::forwardEvent):
(WebCore::RenderTextControl::selectionChanged):
* rendering/RenderWidget.cpp:
* rendering/TextControlInnerElements.cpp:
(WebCore::TextControlInnerTextElement::defaultEventHandler):
(WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
(WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
* storage/LocalStorageArea.cpp:
(WebCore::LocalStorageArea::dispatchStorageEvent):
* storage/SessionStorageArea.cpp:
(WebCore::SessionStorageArea::dispatchStorageEvent):
* svg/SVGAElement.cpp:
(WebCore::SVGAElement::defaultEventHandler):
* svg/SVGDocument.cpp:
(WebCore::SVGDocument::dispatchZoomEvent):
(WebCore::SVGDocument::dispatchScrollEvent):
* svg/SVGElement.cpp:
(WebCore::SVGElement::parseMappedAttribute):
(WebCore::hasLoadListener):
(WebCore::SVGElement::sendSVGLoadEventIfPossible):
* svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::on*): (multiple methods)
(WebCore::SVGElementInstance::setOn*): (multiple methods)
* svg/SVGImageLoader.cpp:
(WebCore::SVGImageLoader::dispatchLoadEvent):
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::parseMappedAttribute):
* svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::dispatchErrorEvent):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::dispatchReadyStateChangeEvent):
(WebCore::XMLHttpRequest::dispatchAbortEvent):
(WebCore::XMLHttpRequest::dispatchErrorEvent):
(WebCore::XMLHttpRequest::dispatchLoadEvent):
(WebCore::XMLHttpRequest::dispatchLoadStartEvent):
(WebCore::XMLHttpRequest::dispatchProgressEvent):
* xml/XMLHttpRequestUpload.cpp:
(WebCore::XMLHttpRequestUpload::dispatchAbortEvent):
(WebCore::XMLHttpRequestUpload::dispatchErrorEvent):
(WebCore::XMLHttpRequestUpload::dispatchLoadEvent):
(WebCore::XMLHttpRequestUpload::dispatchLoadStartEvent):
(WebCore::XMLHttpRequestUpload::dispatchProgressEvent):
* xml/XPathResult.cpp:
(WebCore::XPathResult::XPathResult):
(WebCore::XPathResult::~XPathResult):
(WebCore::XPathResult::invalidateIteratorState):
Access event names via eventNames() function.
2008-11-04 Cameron Zwarich <zwarich@apple.com>
Reviewed by Mark Rowe.
Delete unused forwarding headers.
* ForwardingHeaders/kjs/Activation.h: Removed.
* ForwardingHeaders/kjs/Register.h: Removed.
* ForwardingHeaders/kjs/RegisterID.h: Removed.
2008-11-04 Cameron Zwarich <zwarich@apple.com>
Not reviewed.
Fix stupid typo in previous build fix.
* bindings/js/JSStorageCustom.cpp:
* bindings/scripts/CodeGeneratorJS.pm:
* bridge/NP_jsobject.cpp:
2008-11-03 Cameron Zwarich <zwarich@apple.com>
Not reviewed.
Fix the build for all non-Mac platforms.
* ForwardingHeaders/kjs/PropertyNameArray.h: Removed.
* ForwardingHeaders/runtime/PropertyNameArray.h: Copied from ForwardingHeaders/kjs/PropertyNameArray.h.
* bindings/js/JSStorageCustom.cpp:
* bindings/scripts/CodeGeneratorJS.pm:
* bridge/NP_jsobject.cpp:
2008-11-03 Cameron Zwarich <zwarich@apple.com>
Not reviewed.
Fix the wxWindows build.
* bridge/c/c_instance.cpp:
2008-11-03 Cameron Zwarich <zwarich@apple.com>
Rubber-stamped by Maciej Stachowiak.
Move more files into the runtime subdirectory of JavaScriptCore.
* ForwardingHeaders/kjs/ArgList.h: Removed.
* ForwardingHeaders/kjs/CollectorHeapIterator.h: Removed.
* ForwardingHeaders/kjs/ExecState.h: Removed.
* ForwardingHeaders/kjs/InitializeThreading.h: Removed.
* ForwardingHeaders/kjs/JSGlobalData.h: Removed.
* ForwardingHeaders/kjs/JSLock.h: Removed.
* ForwardingHeaders/kjs/SymbolTable.h: Removed.
* ForwardingHeaders/runtime/ArgList.h: Copied from ForwardingHeaders/kjs/ArgList.h.
* ForwardingHeaders/runtime/CollectorHeapIterator.h: Copied from ForwardingHeaders/kjs/CollectorHeapIterator.h.
* ForwardingHeaders/runtime/ExecState.h: Copied from ForwardingHeaders/kjs/ExecState.h.
* ForwardingHeaders/runtime/InitializeThreading.h: Copied from ForwardingHeaders/kjs/InitializeThreading.h.
* ForwardingHeaders/runtime/JSGlobalData.h: Copied from ForwardingHeaders/kjs/JSGlobalData.h.
* ForwardingHeaders/runtime/JSLock.h: Copied from ForwardingHeaders/kjs/JSLock.h.
* ForwardingHeaders/runtime/SymbolTable.h: Copied from ForwardingHeaders/kjs/SymbolTable.h.
* bindings/js/GCController.cpp:
* bindings/js/JSCustomPositionCallback.cpp:
* bindings/js/JSCustomPositionErrorCallback.cpp:
* bindings/js/JSCustomSQLStatementCallback.cpp:
* bindings/js/JSCustomSQLStatementErrorCallback.cpp:
* bindings/js/JSCustomSQLTransactionCallback.cpp:
* bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
* bindings/js/JSCustomVoidCallback.cpp:
* bindings/js/JSCustomXPathNSResolver.cpp:
* bindings/js/JSDOMWindowBase.cpp:
* bindings/js/JSEventCustom.cpp:
* bindings/js/JSEventListener.cpp:
* bindings/js/JSNodeFilterCondition.cpp:
* bindings/js/ScheduledAction.cpp:
* bindings/js/ScriptController.cpp:
* bindings/js/ScriptControllerMac.mm:
* bindings/objc/WebScriptObject.mm:
* bridge/NP_jsobject.cpp:
* bridge/c/c_class.cpp:
* bridge/c/c_instance.cpp:
* bridge/c/c_runtime.cpp:
* bridge/c/c_utility.cpp:
* bridge/jni/jni_class.cpp:
* bridge/jni/jni_instance.cpp:
* bridge/jni/jni_jsobject.mm:
* bridge/jni/jni_objc.mm:
* bridge/jni/jni_runtime.cpp:
* bridge/jni/jni_runtime.h:
* bridge/jni/jni_utility.cpp:
* bridge/npruntime.cpp:
* bridge/objc/objc_instance.mm:
* bridge/objc/objc_runtime.mm:
* bridge/objc/objc_utility.mm:
* bridge/runtime.cpp:
* dom/Document.cpp:
* dom/Node.cpp:
* dom/NodeFilter.cpp:
* dom/NodeIterator.cpp:
* dom/TreeWalker.cpp:
* history/CachedPage.cpp:
* inspector/InspectorController.cpp:
* inspector/JavaScriptCallFrame.cpp:
* inspector/JavaScriptCallFrame.h:
* inspector/JavaScriptDebugServer.cpp:
* inspector/JavaScriptProfileNode.cpp:
* loader/FrameLoader.cpp:
* loader/icon/IconDatabase.cpp:
* page/Console.cpp:
* page/Page.cpp:
* page/mac/FrameMac.mm:
* plugins/PluginView.cpp:
* plugins/gtk/PluginViewGtk.cpp:
* plugins/qt/PluginViewQt.cpp:
* plugins/win/PluginViewWin.cpp:
* storage/Database.cpp:
* xml/XMLHttpRequest.cpp:
2008-11-03 Cameron Zwarich <zwarich@apple.com>
Reviewed by Sam Weinig.
Remove the forwarding header for FunctionCallProfile, because it was
renamed to ProfileNode in r33466.
* ForwardingHeaders/kjs/FunctionCallProfile.h: Removed.
2008-11-03 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dave Hyatt
https://bugs.webkit.org/show_bug.cgi?id=22026
When computing the bounds of the transparency layer, we need to
map the clipRect through the enclosing transform.
Test: fast/layers/opacity-transforms.html
* rendering/RenderLayer.cpp:
(WebCore::transparencyClipBox):
2008-11-03 Kevin Decker <kdecker@apple.com>
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=22053
Added additional support needed for the NPDrawingModelCoreAnimation drawing model.
* bridge/npapi.h:
2008-11-03 Xan Lopez <xan@gnome.org>
Reviewed by Alp Toker.
Update parseDataUrl() function in the libsoup http backend with
the one from the curl backend which has recent correctness and crash
fixes.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::parseDataUrl):
2008-11-03 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Alp Toker.
https://bugs.webkit.org/show_bug.cgi?id=22041
Fix CURL crashes on the test suite
Fix segfault with setDefersLoading(). Do not call into curl when we
don't have a CURL handle.
It is attempted to defer the loading before the load has been
started (no curl handle was allocated yet). If that happens then
just remember that. ResourceHandleManager::startJob is already taking
care of this and in initResourceHandle the the downloading will
be paused if needed.
Fixes fast/loader/simultaneous-reloads-assert.html
* platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::ResourceHandle::setDefersLoading):
2008-11-03 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Alp Toker.
https://bugs.webkit.org/show_bug.cgi?id=22041
Fix CURL crashes on the test suite
Do not send "no data" to WebCore in parseDataUrl().
Fixes assert on fast/tokenizer/image-empty-crash.html
* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::parseDataUrl):
2008-11-02 Xan Lopez <xan@gnome.org>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=22009
HTML5 Video with GStreamer pulls gnome-vfs without using it
* platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
Remove gnome-vfs include.
2008-11-01 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Be sure to check the final URLs of requested resources to make sure we
don't get fooled by HTTP redirects.
https://bugs.webkit.org/show_bug.cgi?id=21963
Tests: http/tests/security/xss-DENIED-xsl-document-redirect.xml
http/tests/security/xss-DENIED-xsl-external-entity-redirect.xml
* dom/XMLTokenizerLibxml2.cpp:
(WebCore::openFunc):
* loader/DocLoader.cpp:
(WebCore::DocLoader::canRequest):
(WebCore::DocLoader::requestResource):
* loader/DocLoader.h:
* xml/XSLTProcessor.cpp:
(WebCore::docLoaderFunc):
2008-11-01 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22001
AtomicStringImpl* keys of event listener maps can outlive their strings
Test: fast/events/destroyed-atomic-string.html
* dom/MessagePort.cpp:
(WebCore::MessagePort::addEventListener):
(WebCore::MessagePort::removeEventListener):
(WebCore::MessagePort::dispatchEvent):
* dom/MessagePort.h:
* loader/appcache/DOMApplicationCache.cpp:
(WebCore::DOMApplicationCache::addEventListener):
(WebCore::DOMApplicationCache::removeEventListener):
(WebCore::DOMApplicationCache::dispatchEvent):
* loader/appcache/DOMApplicationCache.h:
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::addEventListener):
(WebCore::XMLHttpRequest::removeEventListener):
(WebCore::XMLHttpRequest::dispatchEvent):
* xml/XMLHttpRequest.h:
* xml/XMLHttpRequestUpload.cpp:
(WebCore::XMLHttpRequestUpload::addEventListener):
(WebCore::XMLHttpRequestUpload::removeEventListener):
(WebCore::XMLHttpRequestUpload::dispatchEvent):
* xml/XMLHttpRequestUpload.h:
Changed EventListenersMap to use AtomicString as key (instead of AtomicStringImpl*).
2008-10-31 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=21998
Use JSDOMGlobalObject in EventListener-related bindings
* dom/MessagePort.idl: Auto-generate bindings for onclose and onmessage.
* bindings/scripts/CodeGeneratorJS.pm: Use JSDOMGlobalObject instead of JSDOMWindow in JS
bindings for inline event handlers.
* bindings/js/JSDOMApplicationCacheCustom.cpp:
(WebCore::JSDOMApplicationCache::addEventListener):
(WebCore::JSDOMApplicationCache::removeEventListener):
* bindings/js/JSEventTargetNodeCustom.cpp:
(WebCore::JSEventTargetNode::addEventListener):
(WebCore::JSEventTargetNode::removeEventListener):
* bindings/js/JSMessagePortCustom.cpp:
(WebCore::JSMessagePort::removeEventListener):
* bindings/js/JSSVGElementInstanceCustom.cpp:
(WebCore::JSSVGElementInstance::addEventListener):
(WebCore::JSSVGElementInstance::removeEventListener):
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::addEventListener):
(WebCore::JSXMLHttpRequest::removeEventListener):
* bindings/js/JSXMLHttpRequestUploadCustom.cpp:
(WebCore::JSXMLHttpRequestUpload::addEventListener):
(WebCore::JSXMLHttpRequestUpload::removeEventListener):
Use ScriptExecutionContext and JSDOMGlobalObject in bindings.
* dom/EventTarget.h:
* dom/EventTargetNode.cpp:
(WebCore::EventTargetNode::scriptExecutionContext):
* dom/EventTargetNode.h:
* dom/MessagePort.cpp:
* dom/MessagePort.h:
(WebCore::MessagePort::scriptExecutionContext):
* loader/appcache/DOMApplicationCache.cpp:
(WebCore::DOMApplicationCache::scriptExecutionContext):
* loader/appcache/DOMApplicationCache.h:
* svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::scriptExecutionContext):
* svg/SVGElementInstance.h:
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::scriptExecutionContext):
* xml/XMLHttpRequest.h:
* xml/XMLHttpRequestUpload.cpp:
(WebCore::XMLHttpRequestUpload::scriptExecutionContext):
* xml/XMLHttpRequestUpload.h:
Remove associatedFrame() method, and provide scriptExecutionContext() where it wasn't
available yet.
2008-10-31 Cameron Zwarich <zwarich@apple.com>
Rubber-stamped by Geoff Garen.
Rename SourceRange.h to SourceCode.h.
* ForwardingHeaders/kjs/SourceCode.h: Copied from ForwardingHeaders/kjs/SourceRange.h.
* ForwardingHeaders/kjs/SourceRange.h: Removed.
* bindings/js/StringSourceProvider.h:
* bridge/NP_jsobject.cpp:
2008-10-31 Cameron Zwarich <zwarich@apple.com>
Reviewed by Darin Adler.
Bug 22019: Move JSC::Interpreter::shouldPrintExceptions() to WebCore::Console
<https://bugs.webkit.org/show_bug.cgi?id=22019>
* WebCore.base.exp:
* page/Console.cpp:
(WebCore::printToStandardOut):
(WebCore::Console::shouldPrintExceptions):
(WebCore::Console::setShouldPrintExceptions):
* page/Console.h:
2008-10-31 Dan Bernstein <mitz@apple.com>
Reviewed by John Sullivan.
- WebCore part of <rdar://problem/6334641> Add WebView SPI for disabling document.cookie
* dom/Document.cpp:
(WebCore::Document::cookie): Added checking if cookies are disabled.
(WebCore::Document::setCookie): Ditto.
* page/Navigator.cpp:
(WebCore::Navigator::cookieEnabled): Ditto.
* page/Page.cpp:
(WebCore::Page::Page): Initialize m_cookieEnabled to true.
* page/Page.h:
(WebCore::Page::cookieEnabled): Added.
(WebCore::Page::setCookieEnabled): Added.
2008-10-31 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
WebCore Windows part of fix for <rdar://problem/5839256> FILE CONTROL: multi-file upload.
https://bugs.webkit.org/show_bug.cgi?id=22008
* platform/FileChooser.cpp: (WebCore::FileChooser::chooseIcon):
Rename newIconForFile and newIconForFiles to createIconForFile and createIconForFiles.
* platform/graphics/Icon.h: ditto.
* platform/graphics/gtk/IconGtk.cpp:
(WebCore::Icon::createIconForFile): ditto.
(WebCore::Icon::createIconForFiles): ditto.
* platform/graphics/mac/IconMac.mm:
(WebCore::Icon::createIconForFile): ditto.
(WebCore::Icon::createIconForFiles): ditto.
* platform/graphics/qt/IconQt.cpp:
(WebCore::Icon::createIconForFile): ditto.
(WebCore::Icon::createIconForFiles): ditto.
* platform/wx/TemporaryLinkStubs.cpp:
(Icon::createIconForFile): ditto.
(Icon::createIconForFiles): ditto.
* platform/graphics/win/IconWin.cpp:
(WebCore::Icon::createIconForFile): ditto.
(WebCore::Icon::createIconForFiles): Add creation of an icon for multiple files.
* rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
Improve icon creation code to match new code in Icon::createIconForFiles
2008-10-31 Timothy Hatcher <timothy@apple.com>
Add manual tests that check breakpoints on a blockless body of "for" loops.
https://bugs.webkit.org/show_bug.cgi?id=22004
Reviewed by Darin Adler.
* manual-tests/inspector/debugger-pause-on-for-in-statements.html: Added.
* manual-tests/inspector/debugger-pause-on-for-statements.html: Added.
2008-10-31 Darin Adler <darin@apple.com>
- fix build
* platform/win/WCDataObject.cpp: Added missing include of "config.h".
2008-10-30 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=21970
Make MessagePort event dispatch work in workers
* bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData):
(WebCore::JSDOMGlobalObject::~JSDOMGlobalObject):
(WebCore::JSDOMGlobalObject::findJSEventListener):
(WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
(WebCore::JSDOMGlobalObject::findJSUnprotectedEventListener):
(WebCore::JSDOMGlobalObject::findOrCreateJSUnprotectedEventListener):
(WebCore::JSDOMGlobalObject::jsEventListeners):
(WebCore::JSDOMGlobalObject::jsInlineEventListeners):
(WebCore::JSDOMGlobalObject::jsUnprotectedEventListeners):
(WebCore::JSDOMGlobalObject::jsUnprotectedInlineEventListeners):
(WebCore::JSDOMGlobalObject::setCurrentEvent):
(WebCore::JSDOMGlobalObject::currentEvent):
(WebCore::toJSDOMGlobalObject):
* bindings/js/JSDOMGlobalObject.h:
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData):
(WebCore::JSDOMWindowBase::~JSDOMWindowBase):
(WebCore::JSDOMWindowBase::clearHelperObjectProperties):
* bindings/js/JSDOMWindowBase.h:
Moved event listener tracking from JSDOMWindow to JSDOMGlobalObject.
* bindings/js/JSEventListener.cpp:
(WebCore::JSAbstractEventListener::handleEvent):
(WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener):
(WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener):
(WebCore::JSUnprotectedEventListener::globalObject):
(WebCore::JSUnprotectedEventListener::clearGlobalObject):
(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::~JSEventListener):
(WebCore::JSEventListener::globalObject):
(WebCore::JSEventListener::clearGlobalObject):
(WebCore::JSLazyEventListener::JSLazyEventListener):
(WebCore::JSLazyEventListener::parseCode):
* bindings/js/JSEventListener.h:
(WebCore::JSUnprotectedEventListener::create):
(WebCore::JSEventListener::create):
(WebCore::JSLazyEventListener::create):
Changed to use JSDOMGlobalObject and ScriptExecutionContext.
* bindings/js/JSMessagePortCustom.cpp:
(WebCore::JSMessagePort::startConversation):
(WebCore::JSMessagePort::addEventListener):
(WebCore::JSMessagePort::removeEventListener):
(WebCore::JSMessagePort::setOnmessage):
(WebCore::JSMessagePort::setOnclose):
Updated bindings to work with JSDOMGlobalObject. Next step is to make code generator emit
such code, and stop using a custom implementation for JSMessagePort inline event handler
getters and setters.
* dom/Document.cpp:
(WebCore::Document::virtualURL):
* dom/Document.h:
* dom/ScriptExecutionContext.h:
Expose url() method on ScriptExecutionContext (necessary for compiling scripts in
JSLazyEventListener).
2008-10-31 Cameron Zwarich <zwarich@apple.com>
Not reviewed.
Speculative wxWindows build fix.
* webcore-base.bkl:
2008-10-30 Mark Rowe <mrowe@apple.com>
Reviewed by Jon Homeycutt.
Explicitly default to building for only the native architecture in debug and release builds.
* Configurations/DebugRelease.xcconfig:
2008-10-30 Cameron Zwarich <zwarich@apple.com>
Rubber-stamped by Sam Weinig.
Create a debugger directory in JavaScriptCore and move the relevant
files to it.
* ForwardingHeaders/debugger: Added.
* ForwardingHeaders/debugger/Debugger.h: Copied from ForwardingHeaders/kjs/debugger.h.
* ForwardingHeaders/debugger/DebuggerCallFrame.h: Copied from ForwardingHeaders/kjs/DebuggerCallFrame.h.
* ForwardingHeaders/kjs/DebuggerCallFrame.h: Removed.
* ForwardingHeaders/kjs/debugger.h: Removed.
* WebCore.pro:
* bindings/js/ScriptController.cpp:
* inspector/JavaScriptCallFrame.cpp:
* inspector/JavaScriptCallFrame.h:
* inspector/JavaScriptDebugServer.cpp:
* inspector/JavaScriptDebugServer.h:
2008-10-30 Tony Chang <tony@chromium.org>
Fix 2 Windows theme bugs:
1) Checkboxes marked readonly were rendered incorrectly
2) If a button has focus and is pressed, it was rendered
as focused rather than pressed.
https://bugs.webkit.org/show_bug.cgi?id=21859
Reviewed by Dave Hyatt.
* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::determineState):
(WebCore::RenderThemeWin::determineButtonState):
2008-10-30 Benjamin K. Stuhl <bks24@cornell.edu>
gcc 4.3.3/linux-x86 generates "suggest parentheses around && within ||"
warnings; add some parentheses to disambiguate things. No functional
changes, so no tests.
https://bugs.webkit.org/show_bug.cgi?id=21973
Add parentheses to clean up some gcc warnings
Reviewed by Dan Bernstein.
* platform/graphics/Font.h:
(WebCore::Font::treatAsZeroWidthSpace):
2008-10-30 Aaron Boodman <aa@chromium.org>
Added an explicit dependency on HashMap.h. It was getting pulled in via
<kjs/identifier.h> in the case of JSC, causing errors for the Chromium port.
Reviewed by Darin Adler.
* platform/text/PlatformString.h:
2008-10-30 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Sam Weinig
https://bugs.webkit.org/show_bug.cgi?id=21967
For some platforms the GeolocationService must be suspended and resumed.
* page/Geolocation.cpp:
(WebCore::Geolocation::clearWatch): now uses Geolocation::hasListeners()
(WebCore::Geolocation::suspend): calls GeolocationService::suspend() if there are listeners
(WebCore::Geolocation::resume): calls GeolocationService::resume() if there are listeners
(WebCore::Geolocation::geolocationServicePositionChanged): now uses Geolocation::hasListeners()
* page/Geolocation.h:
(WebCore::Geolocation::hasListeners): Indicates of the Geolocation has interested GeolocationService listeners
* platform/GeolocationService.h:
(WebCore::GeolocationService::suspend): empty implementation
(WebCore::GeolocationService::resume): empty implementation
2008-10-30 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Sam Weinig
https://bugs.webkit.org/show_bug.cgi?id=21966
The Geolocation spec was updated on 10/27/2008. This brings WebCore up to date.
http://dev.w3.org/geo/api/spec-source.html
* page/Geolocation.cpp:
(WebCore::Geolocation::GeoNotifier::GeoNotifier): PositionOptions' timeout now unsigned
* page/Geoposition.cpp: velocity is now called speed
(WebCore::Geoposition::toString):
* page/Geoposition.h: velocity is now called speed
(WebCore::Geoposition::create):
(WebCore::Geoposition::speed):
(WebCore::Geoposition::Geoposition):
* page/Geoposition.idl: velocity is now called speed
* page/PositionOptions.h: timeout is now unsigned
(WebCore::PositionOptions::create):
(WebCore::PositionOptions::timeout):
(WebCore::PositionOptions::setTimeout):
(WebCore::PositionOptions::PositionOptions):
* page/PositionOptions.idl: timeout is now unsigned long
2008-10-30 Justin Garcia <justin.garcia@apple.com>
Also handle preserved newlines.
* editing/BreakBlockquoteCommand.cpp:
(WebCore::BreakBlockquoteCommand::doApply):
2008-10-30 Justin Garcia <justin.garcia@apple.com>
Reviewed by Beth Dakin.
<rdar://problem/6104369> Hitting return at the end of a quoted line creates an extraneous quoted line
* editing/BreakBlockquoteCommand.cpp:
(WebCore::BreakBlockquoteCommand::doApply):
Don't store the endingSelection() in selection, just call endingSelection() in the few places it's
needed. This function is cheap since it just returns a reference to a Selection instead of creating one.
Don't store an affinity. In the one place that it was used, isLastVisiblePositionInNode(VisiblePosition(pos, affinity), topBlockquote),
we now use visiblePos (in order to avoid VisiblePosition creation).
Set pos after we delete the current selection (if there is one), and be consistent about what we set
pos to. Before, we upstream()ed it if there was a selection to delete and left it alone otherwise. In fact...
...we need to use downstream() for pos so that when a caret is at the boundary between two nodes, pos is
in the first node that we want to move. This fixes the bug, since it lets code that checks for the case
where the caret is between text and a br work correctly.
2008-10-30 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Darin Adler.
Fix the Qt build.
https://bugs.webkit.org/show_bug.cgi?id=21969
* inspector/front-end/WebKit.qrc:
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBufferData::ImageBufferData):
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::context):
(WebCore::ImageBuffer::image):
(WebCore::ImageBuffer::toDataURL):
2008-10-30 Justin Garcia <justin.garcia@apple.com>
Reviewed by Darin Adler.
More preparation for:
<rdar://problem/6104369> Hitting return at the end of a quoted line creates an extraneous quoted line
* editing/BreakBlockquoteCommand.cpp:
(WebCore::BreakBlockquoteCommand::doApply): Added comments. Don't need to use newStartNode. If the
startNode needs to change, change it. Afterwords, check to make sure that it hasn't left topBlockquote.
This is slightly stricter than before, where we just made sure that it still had a topBlockquote. This
doesn't really fix a bug, since we can't really get into a situation where we move to a different
topBlockquote, but it simplifies the code.
2008-10-30 Dirk Schulze <vbs85@gmx.de>
Reviewed by Alp Toker.
https://bugs.webkit.org/show_bug.cgi?id=21883
[CAIRO] globalAlpha has to be stored and restored
Cairo's globalAlpha has to be stored and reloaded on calling
save() and restore(). We use the power of GraphicsContextState for this.
* platform/graphics/GraphicsContextPrivate.h:
(WebCore::GraphicsContextState::GraphicsContextState):
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::setAlpha):
(WebCore::GraphicsContext::getAlpha):
* platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
2008-10-29 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Maciej Stachowiak.
Rename "attachedToEventTargetNode" to "isInline".
Inline (onXXX) attributes are used not just with event target nodes, but also with Window,
XMLHttpRequest, MessagePort et al.
Also renamed createHTMLEventHandler() (which was a leftover from earlier isHTMLEvent ->
attachedToEventTargetNode rename made for SVG) to createInlineEventListener().
And also renamed EventTargetNode, Document and Window "eventListenerForType" methods to
"inlineEventListenerForType", as they work with inline listeners.
* bindings/js/JSDOMApplicationCacheCustom.cpp:
(WebCore::JSDOMApplicationCache::addEventListener):
(WebCore::JSDOMApplicationCache::removeEventListener):
* bindings/js/JSMessagePortCustom.cpp:
(WebCore::JSMessagePort::setOnmessage):
(WebCore::JSMessagePort::setOnclose):
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::addEventListener):
(WebCore::JSXMLHttpRequest::removeEventListener):
* bindings/js/JSXMLHttpRequestUploadCustom.cpp:
(WebCore::JSXMLHttpRequestUpload::addEventListener):
(WebCore::JSXMLHttpRequestUpload::removeEventListener):
Pass a correct value for this argument - callers used to be confused, because they didn't
consider themselves event target nodes. This doesn't affect behavior however, as the only
difference between inline and non-inline event handlers is that the former treat
"return false" as "event.preventDefault()", which is not important to any of these objects.
* bindings/js/JSEventListener.cpp: (WebCore::JSLazyEventListener::parseCode):
Assert that isInline is true instead of checking its value, as the constructor of this class
always sets it to true.
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::~JSDOMWindowBase):
(WebCore::JSDOMWindowBase::findJSEventListener):
(WebCore::JSDOMWindowBase::findOrCreateJSEventListener):
(WebCore::JSDOMWindowBase::findJSUnprotectedEventListener):
(WebCore::JSDOMWindowBase::findOrCreateJSUnprotectedEventListener):
(WebCore::JSDOMWindowBase::jsInlineEventListeners):
(WebCore::JSDOMWindowBase::jsUnprotectedInlineEventListeners):
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSEventListener.cpp:
(WebCore::JSAbstractEventListener::handleEvent):
(WebCore::JSAbstractEventListener::isInline):
(WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener):
(WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener):
(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::~JSEventListener):
(WebCore::JSLazyEventListener::parseCode):
* bindings/js/JSEventListener.h:
(WebCore::JSAbstractEventListener::JSAbstractEventListener):
(WebCore::JSUnprotectedEventListener::create):
(WebCore::JSEventListener::create):
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::createInlineEventHandler):
* bindings/js/ScriptController.h:
* dom/Document.cpp:
(WebCore::Document::setWindowInlineEventListenerForType):
(WebCore::Document::windowInlineEventListenerForType):
(WebCore::Document::removeWindowInlineEventListenerForType):
(WebCore::Document::createEventListener):
(WebCore::Document::setWindowInlineEventListenerForTypeAndAttribute):
* dom/Document.h:
* dom/EventListener.h:
(WebCore::EventListener::isInline):
* dom/EventTargetNode.cpp:
(WebCore::EventTargetNode::removeInlineEventListenerForType):
(WebCore::EventTargetNode::setInlineEventListenerForType):
(WebCore::EventTargetNode::setInlineEventListenerForTypeAndAttribute):
(WebCore::EventTargetNode::inlineEventListenerForType):
(WebCore::EventTargetNode::on*): (many methods)
(WebCore::EventTargetNode::setOn*): (many methods)
* dom/EventTargetNode.h:
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::ReplacementFragment):
* html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::parseMappedAttribute):
* html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::parseMappedAttribute):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::parseMappedAttribute):
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::parseMappedAttribute):
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::parseMappedAttribute):
* html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::parseMappedAttribute):
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseMappedAttribute):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseMappedAttribute):
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parseMappedAttribute):
* html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::parseMappedAttribute):
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::parseMappedAttribute):
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::parseMappedAttribute):
* page/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::mouseButtonListener):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::setInlineEventListenerForType):
(WebCore::DOMWindow::inlineEventListenerForType):
(WebCore::DOMWindow::on*): (many methods)
(WebCore::DOMWindow::setOn*): (many methods)
* page/DOMWindow.h:
* svg/SVGElement.cpp:
(WebCore::SVGElement::parseMappedAttribute):
* svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::on*): (many methods)
(WebCore::SVGElementInstance::setOn*): (many methods)
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::parseMappedAttribute):
Rename things, as described above.
2008-10-29 Gustavo Noronha Silva <gns@gnome.org>
Reviewed and slightly changed by Holger Freyther.
Added all the files that need to be installed for the Inspector to
work.
* GNUmakefile.am: Invoke the shell to get the files.
2008-10-29 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Darin Adler
Add MediaPlayerPrivateChromium to MediaPlayer
https://bugs.webkit.org/show_bug.cgi?id=21930
* platform/graphics/MediaPlayer.cpp:
2008-10-29 Justin Garcia <justin.garcia@apple.com>
Reviewed by Darin Adler.
Some preparation for:
<rdar://problem/6104369> Hitting return at the end of a quoted line creates an extraneous quoted line
Added an early return to avoid a level of if-nesting. No other changes. We probably don't
need to rebalance whitespace before the early return but for now don't risk any change in behavior
I'll revisit that later.
* editing/BreakBlockquoteCommand.cpp:
(WebCore::BreakBlockquoteCommand::doApply):
2008-10-29 Kevin Ollivier <kevino@theolliviers.com>
wx build fixes after addition of runtime and ImageBuffer changes.
* platform/graphics/wx/ImageBufferData.h: Added.
* platform/graphics/wx/ImageBufferWx.cpp:
(WebCore::ImageBufferData::ImageBufferData):
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::context):
* webcore-base.bkl:
2008-10-29 Brett Wilson <brettw@chromium.org>
Reviewed by Darin Adler
https://bugs.webkit.org/attachment.cgi?id=24745
Allow Skia implementations to get text style changed notifications.
* platform/graphics/GraphicsContext.cpp:
2008-10-29 Timothy Hatcher <timothy@apple.com>
Add a manual test that checks breakpoints on a blockless body of
an "else" statement.
https://bugs.webkit.org/show_bug.cgi?id=21944
Reviewed by Maciej Stachowiak.
* manual-tests/inspector/debugger-pause-on-else-statements.html: Added.
2008-10-29 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=21921
MessagePort messages are dispatched to documents that are not fully active
Covered by corrected fast/events/message-port-inactive-document.html
* bindings/js/JSEventListener.cpp:
(WebCore::JSAbstractEventListener::handleEvent): Don't dispatch messages to contexts
that are not fully active.
2008-10-29 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=21922
Expose MessagePort global constructor
Covered by existing dumper tests.
* dom/MessagePort.idl:
* page/DOMWindow.idl:
2008-10-29 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=21924
HashTable internal index is not always deleted
* bindings/js/JSDOMBinding.cpp: (WebCore::DOMObjectHashTableMap::~DOMObjectHashTableMap):
Call deleteTable for HashTables that are being deleted.
2008-10-28 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=21923
Create an abstraction for script execution context
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
Added ScriptExecutionContext.{h,cpp}.
* bindings/js/JSAudioConstructor.cpp:
(WebCore::JSAudioConstructor::JSAudioConstructor):
* bindings/js/JSAudioConstructor.h:
* bindings/js/JSImageConstructor.cpp:
(WebCore::JSImageConstructor::JSImageConstructor):
* bindings/js/JSImageConstructor.h:
* bindings/js/JSOptionConstructor.cpp:
(WebCore::JSOptionConstructor::JSOptionConstructor):
* bindings/js/JSOptionConstructor.h:
* bindings/js/JSXMLHttpRequestConstructor.cpp:
(WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
* bindings/js/JSXMLHttpRequestConstructor.h:
Pass ScriptExecutionContext instead of Document to make getDOMConstructor() happy.
Since these objects can only work within documents now, it is immediately converted back
to Document.
* bindings/js/JSMessageChannelConstructor.cpp:
(WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor):
(WebCore::JSMessageChannelConstructor::construct):
* bindings/js/JSMessageChannelConstructor.h:
(WebCore::JSMessageChannelConstructor::scriptExecutionContext):
MessageChannel needs to be supported in workers right away, so the constructor operates with
it directly.
* dom/ActiveDOMObject.cpp:
(WebCore::ActiveDOMObject::ActiveDOMObject):
(WebCore::ActiveDOMObject::~ActiveDOMObject):
(WebCore::ActiveDOMObject::contextDestroyed):
* dom/ActiveDOMObject.h:
(WebCore::ActiveDOMObject::scriptExecutionContext):
* bindings/js/JSDOMBinding.cpp:
(WebCore::markActiveObjectsForContext):
(WebCore::markCrossHeapDependentObjectsForContext):
Use ScriptExecutionContext instead of Document, now that ActiveDOMObject and MessagePort
tracking is handled by ScriptExecutionContext.
* bindings/js/JSDOMBinding.h: (WebCore::getDOMPrototype): Moved to JSDOMGlobalObject.
* bindings/js/JSDOMGlobalObject.h:
(WebCore::getDOMConstructor): Moved to this file, as constructors live in JSDOMGlobalObject.
Also, the two-argument version that used to be in JSDOMWindowBase.cpp need to be accessible
to worker context implementation.
(WebCore::scriptExecutionContext): Added a pure virtual method to access
ScriptExecutionContext, implemented by subclasses.
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::scriptExecutionContext):
Implement by returning the associated document. Note that this method currently gives bogus
results after navigation - DOMWindow Frame reference is not zeroed out, so we get a document
that is currently in the frame, not the one associated with this window.
* bindings/js/JSDedicatedWorkerConstructor.cpp: Removed unnecessary include of DOMWindow.h.
* bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::mark):
Call markActiveObjectsForContext() by its new name.
* dom/DedicatedWorker.cpp:
(WebCore::DedicatedWorker::DedicatedWorker):
(WebCore::DedicatedWorker::document):
* dom/DedicatedWorker.h:
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::document):
* xml/XMLHttpRequest.h:
Added a document() function that upcasts ScriptExecutionContext, as these objects only work
within documents currently (at least for XMLHttpRequest, this will change soon though).
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
Moved active object and MessagePort tracking up to ScriptExecutionContext, to share code
with workers.
* dom/Document.h:
(WebCore::Document::isDocument):
(WebCore::Document::refScriptExecutionContext):
(WebCore::Document::derefScriptExecutionContext):
Inherit from ScriptExecutionContext.
* dom/MessageChannel.cpp:
(WebCore::MessageChannel::MessageChannel):
* dom/MessageChannel.h:
(WebCore::MessageChannel::create):
Use ScriptExecutionContext instead of Document.
* dom/MessagePort.cpp:
(WebCore::CloseMessagePortTimer::CloseMessagePortTimer): Make m_port a RefPtr, because
MessagePort doesn't ref() itself when posting this event any more (this is a fix for an
unrelated issue that was causing random crashes in layout tests).
(WebCore::MessagePort::MessagePort):
(WebCore::MessagePort::~MessagePort):
(WebCore::MessagePort::associatedFrame):
(WebCore::MessagePort::clone):
(WebCore::MessagePort::postMessage):
(WebCore::MessagePort::startConversation):
(WebCore::MessagePort::start):
(WebCore::MessagePort::contextDestroyed):
(WebCore::MessagePort::dispatchMessages):
* dom/MessagePort.h:
(WebCore::MessagePort::create):
(WebCore::MessagePort::scriptExecutionContext):
Use ScriptExecutionContext instead of Document. This is a step toward making MessagePort
work in worker contexts - we need to also make some its method thread safe for cross-thread
messaging, and make event dispatching thread safe.
* dom/ScriptExecutionContext.cpp: Added.
* dom/ScriptExecutionContext.h: Added.
ActiveDOMObject and MessagePort tracking is moved from Document.
It is debatable whether ScriptExecutionContext should be a parent of Document or DOMWindow,
but as I'm just moving Document code, and it is Document that is the main context object
in our implementation currently.
Changing ScriptExecutionContext to be a parent of DOMWindow causes a number of bugs that
seem non-trivial to fix, and isn't really a part of this task.
2008-10-28 Alp Toker <alp@nuanti.com>
List newly-added ImageBufferData.h in build system.
* GNUmakefile.am:
2008-10-28 Alp Toker <alp@nuanti.com>
Reviewed by Cameron Zwarich.
De-list unused WebCore ForwardingHeaders to fix the dist target.
* GNUmakefile.am:
2008-10-28 Cameron Zwarich <zwarich@apple.com>
Not reviewed.
Attempt to fix the Windows build by generating Forwardingheaders for the
runtime directory in JavaScriptCore.
* WebCore.vcproj/WebCore.vcproj:
2008-10-28 Justin Garcia <justin.garcia@apple.com>
Reviewed by Darin Adler.
<rdar://problem/5188560> REGRESSION: Spell checker doesn't clear spelling/grammar marker after error is marked as Ignored
* editing/Editor.cpp:
(WebCore::Editor::ignoreSpelling): Remove misspelling markers from the word.
(WebCore::Editor::learnSpelling): Added a FIXME about <rdar://problem/5396072>, which
will probably require a change more complicated than just marking the learned word as
misspelled. I'll address it with a separate patch.
* editing/EditorCommand.cpp:
(WebCore::executeIgnoreSpelling): Added.
(WebCore::CommandEntry::): Added an entry for IgnoreSpelling.
2008-10-28 Cameron Zwarich <zwarich@apple.com>
Reviewed by Mark Rowe.
Move ForwardingHeaders to their correct location after the creation of
the runtime directory in JavaScriptCore.
* ForwardingHeaders/kjs/ArrayPrototype.h: Removed.
* ForwardingHeaders/kjs/BooleanObject.h: Removed.
* ForwardingHeaders/kjs/CallData.h: Removed.
* ForwardingHeaders/kjs/ConstructData.h: Removed.
* ForwardingHeaders/kjs/DateInstance.h: Removed.
* ForwardingHeaders/kjs/Error.h: Removed.
* ForwardingHeaders/kjs/FunctionConstructor.h: Removed.
* ForwardingHeaders/kjs/FunctionPrototype.h: Removed.
* ForwardingHeaders/kjs/InternalFunction.h: Removed.
* ForwardingHeaders/kjs/JSArray.h: Removed.
* ForwardingHeaders/kjs/JSFunction.h: Removed.
* ForwardingHeaders/kjs/JSGlobalObject.h: Removed.
* ForwardingHeaders/kjs/JSNumberCell.h: Removed.
* ForwardingHeaders/kjs/JSObject.h: Removed.
* ForwardingHeaders/kjs/JSString.h: Removed.
* ForwardingHeaders/kjs/JSValue.h: Removed.
* ForwardingHeaders/kjs/ObjectPrototype.h: Removed.
* ForwardingHeaders/kjs/PropertyMap.h: Removed.
* ForwardingHeaders/kjs/PrototypeFunction.h: Removed.
* ForwardingHeaders/kjs/StringObject.h: Removed.
* ForwardingHeaders/kjs/StringObjectThatMasqueradesAsUndefined.h: Removed.
* ForwardingHeaders/kjs/StringPrototype.h: Removed.
* ForwardingHeaders/kjs/StructureID.h: Removed.
* ForwardingHeaders/runtime: Added.
* ForwardingHeaders/runtime/ArrayPrototype.h: Copied from ForwardingHeaders/kjs/ArrayPrototype.h.
* ForwardingHeaders/runtime/BooleanObject.h: Copied from ForwardingHeaders/kjs/BooleanObject.h.
* ForwardingHeaders/runtime/CallData.h: Copied from ForwardingHeaders/kjs/CallData.h.
* ForwardingHeaders/runtime/ConstructData.h: Copied from ForwardingHeaders/kjs/ConstructData.h.
* ForwardingHeaders/runtime/DateInstance.h: Copied from ForwardingHeaders/kjs/DateInstance.h.
* ForwardingHeaders/runtime/Error.h: Copied from ForwardingHeaders/kjs/Error.h.
* ForwardingHeaders/runtime/FunctionConstructor.h: Copied from ForwardingHeaders/kjs/FunctionConstructor.h.
* ForwardingHeaders/runtime/FunctionPrototype.h: Copied from ForwardingHeaders/kjs/FunctionPrototype.h.
* ForwardingHeaders/runtime/InternalFunction.h: Copied from ForwardingHeaders/kjs/InternalFunction.h.
* ForwardingHeaders/runtime/JSArray.h: Copied from ForwardingHeaders/kjs/JSArray.h.
* ForwardingHeaders/runtime/JSFunction.h: Copied from ForwardingHeaders/kjs/JSFunction.h.
* ForwardingHeaders/runtime/JSGlobalObject.h: Copied from ForwardingHeaders/kjs/JSGlobalObject.h.
* ForwardingHeaders/runtime/JSNumberCell.h: Copied from ForwardingHeaders/kjs/JSNumberCell.h.
* ForwardingHeaders/runtime/JSObject.h: Copied from ForwardingHeaders/kjs/JSObject.h.
* ForwardingHeaders/runtime/JSString.h: Copied from ForwardingHeaders/kjs/JSString.h.
* ForwardingHeaders/runtime/JSValue.h: Copied from ForwardingHeaders/kjs/JSValue.h.
* ForwardingHeaders/runtime/ObjectPrototype.h: Copied from ForwardingHeaders/kjs/ObjectPrototype.h.
* ForwardingHeaders/runtime/PropertyMap.h: Copied from ForwardingHeaders/kjs/PropertyMap.h.
* ForwardingHeaders/runtime/PrototypeFunction.h: Copied from ForwardingHeaders/kjs/PrototypeFunction.h.
* ForwardingHeaders/runtime/StringObject.h: Copied from ForwardingHeaders/kjs/StringObject.h.
* ForwardingHeaders/runtime/StringObjectThatMasqueradesAsUndefined.h: Copied from ForwardingHeaders/kjs/StringObjectThatMasqueradesAsUndefined.h.
* ForwardingHeaders/runtime/StringPrototype.h: Copied from ForwardingHeaders/kjs/StringPrototype.h.
* ForwardingHeaders/runtime/StructureID.h: Copied from ForwardingHeaders/kjs/StructureID.h.
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
* bindings/js/JSCanvasRenderingContext2DCustom.cpp:
* bindings/js/JSClipboardCustom.cpp:
* bindings/js/JSConsoleCustom.cpp:
* bindings/js/JSCustomPositionCallback.h:
* bindings/js/JSCustomPositionErrorCallback.h:
* bindings/js/JSCustomSQLStatementCallback.h:
* bindings/js/JSCustomSQLStatementErrorCallback.h:
* bindings/js/JSCustomSQLTransactionErrorCallback.h:
* bindings/js/JSCustomVoidCallback.h:
* bindings/js/JSCustomXPathNSResolver.h:
* bindings/js/JSDOMBinding.cpp:
* bindings/js/JSDOMBinding.h:
* bindings/js/JSDOMGlobalObject.h:
* bindings/js/JSDOMWindowBase.cpp:
* bindings/js/JSDOMWindowCustom.cpp:
* bindings/js/JSDOMWindowShell.cpp:
* bindings/js/JSDatabaseCustom.cpp:
* bindings/js/JSEventListener.cpp:
* bindings/js/JSEventTarget.h:
* bindings/js/JSHTMLDocumentCustom.cpp:
* bindings/js/JSHistoryCustom.cpp:
* bindings/js/JSInspectedObjectWrapper.cpp:
* bindings/js/JSJavaScriptCallFrameCustom.cpp:
* bindings/js/JSLocationCustom.cpp:
* bindings/js/JSNodeFilterCondition.h:
* bindings/js/JSQuarantinedObjectWrapper.cpp:
* bindings/js/JSQuarantinedObjectWrapper.h:
* bindings/js/JSXMLHttpRequestCustom.cpp:
* bindings/js/JSXMLHttpRequestUploadCustom.cpp:
* bindings/objc/WebScriptObject.mm:
* bindings/objc/WebScriptObjectPrivate.h:
* bindings/scripts/CodeGeneratorJS.pm:
* bridge/NP_jsobject.cpp:
* bridge/c/c_instance.cpp:
* bridge/c/c_utility.cpp:
* bridge/c/c_utility.h:
* bridge/jni/jni_instance.cpp:
* bridge/jni/jni_jsobject.h:
* bridge/jni/jni_jsobject.mm:
* bridge/jni/jni_runtime.cpp:
* bridge/jni/jni_utility.cpp:
* bridge/jni/jni_utility.h:
* bridge/objc/objc_instance.mm:
* bridge/objc/objc_runtime.h:
* bridge/objc/objc_runtime.mm:
* bridge/objc/objc_utility.h:
* bridge/objc/objc_utility.mm:
* bridge/runtime.h:
* bridge/runtime_array.cpp:
* bridge/runtime_array.h:
* bridge/runtime_method.cpp:
* bridge/runtime_method.h:
* bridge/runtime_object.cpp:
* bridge/runtime_object.h:
* bridge/runtime_root.cpp:
* inspector/JavaScriptCallFrame.cpp:
* inspector/JavaScriptProfile.cpp:
* inspector/JavaScriptProfile.h:
* inspector/JavaScriptProfileNode.cpp:
* inspector/JavaScriptProfileNode.h:
* loader/FrameLoader.cpp:
* page/Console.cpp:
* plugins/PluginView.cpp:
* plugins/gtk/PluginViewGtk.cpp:
* plugins/qt/PluginViewQt.cpp:
* plugins/win/PluginViewWin.cpp:
2008-10-28 Adele Peterson <adele@apple.com>
Windows build fix. This removes Cairo include directories from non-Cairbo build configurations.
* WebCore.vcproj/WebCore.vcproj:
2008-10-28 Adele Peterson <adele@apple.com>
Windows build fix.
* platform/graphics/ImageBuffer.h:
(WebCore::ImageBuffer::create):
2008-10-28 Cameron Zwarich <zwarich@apple.com>
Not reviewed.
Roll out a mistaken attempt at fixing the GTK build in r37947.
* GNUmakefile.am:
2008-10-28 Adele Peterson <adele@apple.com>
Reviewed by John Sullivan.
Fix for https://bugs.webkit.org/show_bug.cgi?id=21880
"files" string for multifile uploads needs to be localized
* page/mac/WebCoreViewFactory.h:
* platform/LocalizedStrings.h:
* platform/gtk/FileChooserGtk.cpp: (WebCore::FileChooser::basenameForWidth):
* platform/gtk/LocalizedStringsGtk.cpp: (WebCore::multipleFileUploadText):
* platform/mac/FileChooserMac.mm: (WebCore::FileChooser::basenameForWidth):
* platform/mac/LocalizedStringsMac.mm: (WebCore::multipleFileUploadText):
* platform/qt/Localizations.cpp: (WebCore::multipleFileUploadText):
* platform/wx/LocalizedStringsWx.cpp: (WebCore::multipleFileUploadText):
2008-10-28 Brett Wilson <brettw@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=21816
Remove platform ifdefs in ImageBuffer.h by moving platform specific code
into a new PlatformImageBuffer class. Move the static create function
into the header because it can be cross-platform. Initialization now
happens in the cunstructor which sets a flag that create uses to know
whether it should return null or not. I also made passing of IntSize
more consistent (always by reference).
This change also changes the ifdefs in GraphicsContext to allow Skia
ports to implement text drawing modes.
* platform/graphics/ImageBuffer.h:
(WebCore::ImageBuffer::create):
(WebCore::ImageBuffer::size):
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBufferData::ImageBufferData):
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::~ImageBuffer):
(WebCore::ImageBuffer::image):
(WebCore::ImageBuffer::getImageData):
(WebCore::ImageBuffer::putImageData):
* platform/graphics/cairo/ImageBufferData.h:
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBufferData::ImageBufferData):
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::~ImageBuffer):
(WebCore::ImageBuffer::getImageData):
(WebCore::ImageBuffer::putImageData):
* platform/graphics/cg/ImageBufferData.h:
* platform/graphics/qt/ImageBufferData.h:
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBufferData::ImageBufferData):
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::~ImageBuffer):
2008-10-28 Cameron Zwarich <zwarich@apple.com>
Not reviewed.
Fix the GTK build.
* GNUmakefile.am:
2008-10-28 Cameron Zwarich <zwarich@apple.com>
Not reviewed.
Another Qt build fix.
* WebCore.pro:
2008-10-28 Greg Bolsinga <bolsinga@apple.com>
Reviewed by David Kilzer.
https://bugs.webkit.org/show_bug.cgi?id=21932
Add non-pointer constant lookups to SoftLinking.h
* platform/mac/SoftLinking.h:
2008-10-28 Greg Bolsinga <bolsinga@apple.com>
Reviewed by David Kilzer.
https://bugs.webkit.org/show_bug.cgi?id=2192
Missing semi-colons in Geoposition.idl
* page/Geoposition.idl: Add missing semi-colons
2008-10-28 Timothy Hatcher <timothy@apple.com>
Make the Profiles panel in the Web Inspector have an enable screen.
Profiling now needs to be enabled before console.profile() works.
<rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
not slow down JavaScript all the time
Reviewed by Darin Adler and Kevin McCullough.
* English.lproj/localizedStrings.js: New strings.
* WebCore.base.exp: New and changed exports.
* WebCore.vcproj/WebCore.vcproj: Add the PanelEnablerView.js file.
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::supportsProfiling): Call InspectorController:profilerEnabled.
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController): Initialize the m_startProfiling
Timer to call InspectorController::startUserInitiatedProfiling.
(WebCore::InspectorController::startUserInitiatedProfilingSoon): Start a one-shot timer
that calls InspectorController::startUserInitiatedProfiling.
(WebCore::InspectorController::startUserInitiatedProfiling): Recompile all JavaScript
and enable the profiler if the profiler was not enabled.
(WebCore::InspectorController::stopUserInitiatedProfiling): Rearrange code for readability.
(WebCore::InspectorController::enableProfiler): Recompile all the JavaScript functions
if the skipRecompile argument is false. Call the profilerWasEnabled script function.
(WebCore::InspectorController::disableProfiler): Recompile all the JavaScript functions.
Call the profilerWasEnabled script function.
(WebCore::InspectorController::disableDebugger): Set m_attachDebuggerWhenShown to false,
so it won't be started later.
* inspector/InspectorController.h:
(WebCore::InspectorController::profilerEnabled): Return enabled() && m_profilerEnabled.
* inspector/front-end/Images/debuggingButtons.png: Remove.
* inspector/front-end/Images/enableButtons.png: Added.
* inspector/front-end/Images/profilesSilhouette.png: Added.
* inspector/front-end/Images/scriptsSilhouette.png: Added.
* inspector/front-end/PanelEnablerView.js: Added.
(WebInspector.PanelEnablerView):
(WebInspector.PanelEnablerView.prototype._enableButtonCicked): Fire the "enable clicked"
event so listeners can do their thing.
(WebInspector.PanelEnablerView.prototype._windowResized): Test if the icon should be hidden.
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel): Create the PanelEnablerView and the strings needed for it.
(WebInspector.ProfilesPanel.prototype.get statusBarItems): Include the enableToggleButton.
(WebInspector.ProfilesPanel.prototype.profilerWasEnabled): Call reset and populateInterface.
(WebInspector.ProfilesPanel.prototype.profilerWasDisabled): Call reset.
(WebInspector.ProfilesPanel.prototype.reset): Call _updateInterface.
(WebInspector.ProfilesPanel.prototype.setRecordingProfile): Moved in the code, no changes.
(WebInspector.ProfilesPanel.prototype._updateInterface): Update the toggle button and
show/hide other buttons. Also show/hide the PanelEnablerView.
(WebInspector.ProfilesPanel.prototype._enableProfiling): Call _toggleProfiling if not enabled.
(WebInspector.ProfilesPanel.prototype._toggleProfiling): Call InspectorController's
disableProfiler or enableProfiler.
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel): Replace the overlay element with a PanelEnablerView. Replace the
debuggingButton with the enableToggleButton.
(WebInspector.ScriptsPanel.prototype.get statusBarItems): Replace the debuggingButton with
the enableToggleButton.
(WebInspector.ScriptsPanel.prototype._updateDebuggerButtons): Hide/show the pauseOnExceptionButton
when needed. Replace the overlay element with a PanelEnablerView. Replace the debuggingButton
with the enableToggleButton.
(WebInspector.ScriptsPanel.prototype._enableDebugging): Call _toggleDebugging when not enabled.
(WebInspector.ScriptsPanel.prototype._toggleDebugging): Remove the call to _clearInterface,
since reset is called from debuggerWasEnabled and debuggerWasDisabled.
* inspector/front-end/View.js: Inherit from WebInspector.Object.
* inspector/front-end/WebKit.qrc: Add the PanelEnablerView.js file.
* inspector/front-end/inspector.css: New styles for the PanelEnablerView.
* inspector/front-end/inspector.html: Add the PanelEnablerView.js file.
* inspector/front-end/inspector.js:
(WebInspector.profilerWasEnabled): Added. Calls the ProfilesPanel.
(WebInspector.profilerWasDisabled): Ditto.
* page/Console.cpp:
(WebCore::Console::error): Remove null check for m_frame, since m_frame isn't used.
(WebCore::Console::info): Ditto.
(WebCore::Console::log): Ditto.
(WebCore::Console::assertCondition): Ditto.
(WebCore::Console::dirxml): Remove null check for m_frame and use this->page().
(WebCore::Console::count): Ditto.
(WebCore::Console::profile): Return early if InspectorController::profilerEnabled is false.
(WebCore::Console::profileEnd): Ditto.
(WebCore::Console::warn): Remove null check for m_frame, since m_frame isn't used.
* page/Settings.cpp:
(WebCore::Settings::Settings): Remove initialization of m_didInitializeDeveloperExtrasEnabled.
(WebCore::Settings::setDeveloperExtrasEnabled): Remove code that recompiled functions.
Now just sets the member boolean.
* page/Settings.h: Remove m_didInitializeDeveloperExtrasEnabled.
2008-10-28 Timothy Hatcher <timothy@apple.com>
Rename a few methods related to attaching and detaching the debugger. Also
adds stub methods for enabling and disabling the profiler.
* Rename attachDebugger to enableDebugger.
* Rename detachDebugger to disableDebugger.
* Rename the debuggerAttached getter to debuggerEnabled.
* Rename the debuggerAttached callback to debuggerWasEnabled.
* Rename the debuggerDetached callback to debuggerWasDisabled.
Reviewed by Darin Adler.
* WebCore.base.exp:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::setWindowVisible):
(WebCore::InspectorController::windowScriptObjectAvailable):
(WebCore::InspectorController::close):
(WebCore::InspectorController::enableProfiler):
(WebCore::InspectorController::disableProfiler):
(WebCore::InspectorController::enableDebugger):
(WebCore::InspectorController::disableDebugger):
(WebCore::InspectorController::pauseInDebugger):
(WebCore::InspectorController::resumeDebugger):
(WebCore::InspectorController::stepOverStatementInDebugger):
(WebCore::InspectorController::stepIntoStatementInDebugger):
(WebCore::InspectorController::stepOutOfFunctionInDebugger):
* inspector/InspectorController.h:
(WebCore::InspectorController::profilerEnabled):
(WebCore::InspectorController::debuggerEnabled):
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint):
(WebInspector.BreakpointsSidebarPane.prototype.removeBreakpoint):
(WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
* inspector/front-end/Object.js:
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype.get statusBarItems):
(WebInspector.ScriptsPanel.prototype.debuggerWasEnabled):
(WebInspector.ScriptsPanel.prototype.debuggerWasDetached):
(WebInspector.ScriptsPanel.prototype.reset):
(WebInspector.ScriptsPanel.prototype.canShowResource):
(WebInspector.ScriptsPanel.prototype._updatePauseOnExceptionsButton):
(WebInspector.ScriptsPanel.prototype._updateDebuggerButtons):
(WebInspector.ScriptsPanel.prototype._toggleDebugging):
* inspector/front-end/View.js:
* inspector/front-end/inspector.css:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector.addResource):
(WebInspector.debuggerWasEnabled):
(WebInspector.debuggerWasDisabled):
2008-10-28 Timothy Hatcher <timothy@apple.com>
Fix an exception when searching the Resources panel while there
and resources queued to be added to the list.
Reviewed by Kevin McCullough.
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.searchCanceled): Null check
the _resourcesTreeElement property.
(WebInspector.ResourcesPanel.prototype.performSearch): Ditto.
2008-10-28 Alp Toker <alp@nuanti.com>
GTK+ build fix for older versions of Pango where PANGO_VERSION_CHECK
isn't defined.
* platform/graphics/gtk/FontGtk.cpp:
(WebCore::getDefaultPangoLayout):
* platform/graphics/gtk/FontPlatformDataPango.cpp:
2008-10-28 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=21893
Character set is incorrect for external scripts in XHTML pages
<rdar://problem/6317451> Incorrect encoding for text in a popup at http://xpoint.ru/
Test: fast/encoding/external-script-charset.xhtml
Expose scriptCharset() function on all ScriptElements, and call it from XML tokenizer.
* dom/ScriptElement.h:
* dom/XMLTokenizerLibxml2.cpp:
(WebCore::XMLTokenizer::endElementNs):
* dom/XMLTokenizerQt.cpp:
(WebCore::XMLTokenizer::parseEndElement):
* html/HTMLScriptElement.h:
* svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::scriptCharset):
* svg/SVGScriptElement.h:
2008-10-28 Alp Toker <alp@nuanti.com>
Include copyright license files in the autotools dist target and
exclude unused zlib headers.
Change suggested by Mike Hommey.
* GNUmakefile.am:
2008-10-27 Sam Weinig <sam@webkit.org>
Reviewed by Maciej Stachowiak.
Clear the window shell when destroying a page to allow documents
which have no way of being reached anymore, to be torn down.
* page/Frame.cpp:
(WebCore::Frame::pageDestroyed):
2008-10-27 Kevin Watters <kevinwatters@gmail.com>
Reviewed by Kevin Ollivier.
Update the active state as well as the focused state as both need to be true
for the caret to be drawn.
https://bugs.webkit.org/show_bug.cgi?id=21900
* WebView.cpp:
(wxWebView::OnSetFocus):
(wxWebView::OnKillFocus):
2008-10-27 Kevin Ollivier <kevino@theolliviers.com>
wx build fix on Linux/GTK. Enable support for #include <JavaScriptCore/XYZ.h> style includes.
* webcore-wx.bkl:
2008-10-27 Michael Knaup <michael.knaup@mac.com>
Reviewed and tweaked by Darin Adler.
- https://bugs.webkit.org/show_bug.cgi?id=8988
Bug 8988: Add support for Mozilla CSS custom cursors.
Added -webkit-grab and -webkit-grabbing cursor suppport
for the Mac, dummy implementations for other platforms.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Updated since the
-webkit-grabbing cursor is now the last one.
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added
CURSOR_WEBKIT_GRAB and CURSOR_WEBKIT_GRABBING.
* css/CSSValueKeywords.in: Added -webkit-grab and
-webkit-grabbing.
* manual-tests/cursor.html: Added -webkit-zoom-in,
webkit-zoom-out, -webkit-grab, and -webkit-grabbing.
* page/EventHandler.cpp:
(WebCore::EventHandler::selectCursor): Added
CURSOR_WEBKIT_GRAB and CURSOR_WEBKIT_GRABBING.
* platform/Cursor.h: Added grabCursor and grabbingCursor.
* platform/gtk/CursorGtk.cpp:
(WebCore::grabCursor): Added.
(WebCore::grabbingCursor): Added.
* platform/mac/CursorMac.mm:
(WebCore::grabCursor): Added.
(WebCore::grabbingCursor): Added.
* platform/qt/CursorQt.cpp:
(WebCore::grabCursor): Added.
(WebCore::grabbingCursor): Added.
* platform/win/CursorWin.cpp:
(WebCore::grabCursor): Added.
(WebCore::grabbingCursor): Added.
* platform/wx/CursorWx.cpp:
(WebCore::grabCursor): Added.
(WebCore::grabbingCursor): Added.
* rendering/style/RenderStyleConstants.h:
Added CURSOR_WEBKIT_GRAB and CURSOR_WEBKIT_GRABBING.
Also broke ECursor out into a single constant per line.
Also added a couple of comments.
2008-10-27 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
* svg/SVGAnimatedTemplate.h: needed a HashMap define
2008-10-21 Eric Seidel <eric@webkit.org>
Reviewed by Dave Hyatt.
Infinite recursion crash in WebCore::RenderSVGRoot::absoluteClippedOverflowRect on a <stop> element outside of a gradient block
https://bugs.webkit.org/show_bug.cgi?id=20400
Test: svg/custom/stop-crash.svg
* WebCore.xcodeproj/project.pbxproj:
* rendering/RenderSVGGradientStop.h:
(WebCore::RenderSVGGradientStop::absoluteClippedOverflowRect):
2008-10-27 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
No need to call release if the connection is null.
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::start):
2008-10-27 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
<rdar://problem/6322650> Crash in fast/loader/simultaneous-reloads-assert.html
Make sure to null check the NSURLConnection object.
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::setDefersLoading):
2008-10-27 Alexey Proskuryakov <ap@webkit.org>
Fix non-Mac builds.
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCoreSources.bkl:
Renamed JSHTMLOptionElementConstructor to JSOptionConstructor.
2008-10-26 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=21886
window.HTMLOptionElement == "[object HTMLElementConstructor]" instead of HTMLOptionElementConstructor
Test: fast/dom/HTMLOptionElement/option-prototype.html
We now have separate objects for window.Option and window.HTMLOptionElement - the latter
"constructor" cannot be used to construct anything. This matches Firefox behavior.
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMWindowBase.cpp:
(jsDOMWindowBaseOption):
* bindings/js/JSHTMLOptionElementConstructor.cpp: Removed.
* bindings/js/JSHTMLOptionElementConstructor.h: Removed.
* bindings/js/JSOptionConstructor.cpp: Copied from WebCore/bindings/js/JSHTMLOptionElementConstructor.cpp.
* bindings/js/JSOptionConstructor.h: Copied from WebCore/bindings/js/JSHTMLOptionElementConstructor.h.
* html/HTMLOptionElement.idl:
Renamed JSHTMLOptionElementConstructor to JSOptionConstructor.
* html/HTMLOptionElement.idl: Generate a constructor.
2008-10-25 Geoffrey Garen <ggaren@apple.com>
Not reviewed.
Try to fix Mac debug build on the buildbot.
* platform/FileChooser.cpp:
(WebCore::FileChooserClient::~FileChooserClient):
* platform/FileChooser.h: Moved destructor to .cpp file, to avoid a
weak exported symbol.
2008-10-25 Jade Han <jade.han@nokia.com>
Reviewed by Anders.
Enable custom properties for Qt runtime objects in QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=21813
* bridge/runtime_object.cpp:
(JSC::RuntimeObjectImp::getOwnPropertySlot):
(JSC::RuntimeObjectImp::put):
2008-10-24 Sam Weinig <sam@webkit.org>
Fix windows build.
* page/Chrome.cpp:
* page/Chrome.h:
2008-10-24 Sam Weinig <sam@webkit.org>
Fix Qt build.
* platform/qt/FileChooserQt.cpp:
2008-10-24 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Fix https://bugs.webkit.org/show_bug.cgi?id=21759
Layering violation: FileChooser should not depend on Document/Frame/Page
Move file choosing into WebKit ChromeClient.
* loader/EmptyClients.h:
(WebCore::EmptyChromeClient::runOpenPanel):
* page/Chrome.cpp:
(WebCore::Chrome::runOpenPanel):
* page/Chrome.h:
* page/ChromeClient.h:
* page/mac/ChromeMac.mm:
* platform/FileChooser.h:
* platform/mac/FileChooserMac.mm:
* platform/qt/FileChooserQt.cpp:
* platform/win/FileChooserWin.cpp:
* platform/wx/TemporaryLinkStubs.cpp:
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::click):
2008-10-24 Kevin Ollivier <kevino@theolliviers.com>
wx build fix - add newIconForFiles stub.
* platform/wx/TemporaryLinkStubs.cpp:
(Icon::newIconForFiles):
2008-10-24 Kevin Watters <kevinwatters@gmail.com>
Reviewed by Kevin Ollivier.
Use the CGFont metrics APIs for more accurate measurements, and tweak the y
value the text is drawn at (it was a couple pixels off before because wx
internally adds to the y value.
https://bugs.webkit.org/show_bug.cgi?id=21853
* platform/wx/wxcode/mac/carbon/fontprops.cpp:
(wxFontProperties::wxFontProperties):
* platform/wx/wxcode/mac/carbon/non-kerned-drawing.cpp:
(WebCore::drawTextWithSpacing):
2008-10-24 Eric Seidel <eric@webkit.org>
Reviewed by Sam Weinig.
Generate missing constructors and add test to prevent missing ones in the future
https://bugs.webkit.org/show_bug.cgi?id=21846
Test: fast/js/global-constructors.html
* css/CSSStyleSheet.idl:
* css/RGBColor.idl:
* dom/NodeIterator.idl:
* dom/TreeWalker.idl:
* xml/XPathExpression.idl:
2008-10-24 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=21836
REGRESSION: Sign-in on Fancast.com causes crash in Webkit nightly
Test: http/tests/xmlhttprequest/detaching-frame.html
* xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::dropProtection): Null check the window -
even though XHR needs a context (AKA frame) to be serviced, the frame may be disconnected
when dispatching the same callback that results in this function being called.
2008-10-24 David Kilzer <ddkilzer@apple.com>
Gtk build fix.
* platform/gtk/TemporaryLinkStubs.cpp:
(WebCore::setFocusRingColorChangeFunction): Removed in r37858.
2008-10-24 Mark Rowe <mrowe@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/6164952> Use constant kCGInterpolationMedium in GraphicsContextCG.cpp rather than hard-coded values.
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::setImageInterpolationQuality):
(WebCore::GraphicsContext::imageInterpolationQuality):
2008-10-24 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/5440917> Support NPN_Construct
* WebCore.NPAPI.exp:
Export _NPN_Construct.
* bridge/NP_jsobject.cpp:
(_NPN_Construct):
Implement this.
* bridge/c/c_instance.cpp:
(JSC::Bindings::CInstance::supportsConstruct):
(JSC::Bindings::CInstance::invokeConstruct):
Have this call the appropriate NPClass method.
* bridge/npruntime.h:
Add NPN_Construct.
* bridge/npruntime_impl.h:
Add _NPN_Construct.
* bridge/runtime.h:
(JSC::Bindings::Instance::supportsConstruct):
(JSC::Bindings::Instance::invokeConstruct):
New methods.
* bridge/runtime_object.cpp:
(JSC::callRuntimeConstructor):
Call the native instance.
(JSC::RuntimeObjectImp::getConstructData):
Implement this.
* bridge/runtime_object.h:
Add new method declarations.
* plugins/gtk/PluginPackageGtk.cpp:
(WebCore::PluginPackage::load):
* plugins/qt/PluginPackageQt.cpp:
(WebCore::PluginPackage::load):
* plugins/win/PluginPackageWin.cpp:
(WebCore::PluginPackage::load):
Initialize m_pluginFuncs.construct.
2008-10-24 Adele Peterson <adele@apple.com>
Build fix.
* platform/FileChooser.h: (WebCore::FileChooserClient::~FileChooserClient):
* platform/graphics/mac/IconMac.mm: (WebCore::Icon::newIconForFiles):
2008-10-24 Greg Bolsinga <bolsinga@apple.com>
Fix GTK build break.
Reviewed by David Kilzer.
* GNUmakefile.am: Do not include .idl files whose generated files should not be
compiled.
2008-10-24 David Kilzer <ddkilzer@apple.com>
Wx build fix.
* platform/wx/TemporaryLinkStubs.cpp:
(WebCore::setFocusRingColorChangeFunction): Removed in r37858.
2008-10-24 Adele Peterson <adele@apple.com>
Reviewed by Sam Weinig.
WebCore part of fix for <rdar://problem/5839256> FILE CONTROL: multi-file upload.
This change adds support for multiple file selection in an <input type="file"> control when the "multiple" attribute is used.
This is consistent with the direction HTML5 will be going in the future.
The initial implementation here will show "n files" as the text next to the control when multiple files are selected. You can view
the individual files in a tooltip for now. Improvements to this control will come later.
Web developers will be able to access the FileList from the HTMLInputElement element, where they can get a base name and a size for each file.
These FileList Files can also be sent in an XMLHTTPRequest.
* manual-tests/post-multi-file-upload.html: Added.
* manual-tests/resources/multiFileResources: Added.
* manual-tests/resources/multiFileResources/post-echo-and-notify-done.cgi: Added.
* manual-tests/resources/multiFileResources/testFile1.html: Added.
* manual-tests/resources/multiFileResources/testFile2.html: Added.
* manual-tests/resources/multiFileResources/testFile3.html: Added.
* WebCore.base.exp: Added support to export the new "chooseFilenames" method to be used in WebKit.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseMappedAttribute): Add support for the multiple attribute.
(WebCore::HTMLInputElement::value): Added comments. The HTML5 spec says that value shouldn't apply for the file upload control,
but we don't want to break the behavior for existing websites that may rely on this.
(WebCore::HTMLInputElement::setValue): ditto.
(WebCore::HTMLInputElement::setValueFromRenderer): This is no longer used for file upload controls. setFileListFromRenderer is used instead.
(WebCore::HTMLInputElement::setFileListFromRenderer): Added.
* html/HTMLInputElement.h:
* page/Chrome.cpp: (WebCore::Chrome::setToolTip): Show a tooltip with the file name list for the multi-file upload control.
* page/DragController.cpp: (WebCore::DragController::concludeDrag): Updated to support multiple files.
* platform/FileChooser.cpp: Add support for maintaining a list of file paths that can be retrieved by the renderer.
(WebCore::FileChooser::FileChooser):
(WebCore::FileChooser::create):
(WebCore::FileChooser::clear):
(WebCore::FileChooser::chooseFile):
(WebCore::FileChooser::chooseFiles):
(WebCore::FileChooser::chooseIcon):
* platform/FileChooser.h:
(WebCore::FileChooser::filePaths):
(WebCore::FileChooser::allowsMultipleFiles):
* platform/graphics/Icon.h:
* platform/graphics/mac/IconMac.mm: (WebCore::Icon::newIconForFiles): Returns a generic icon for multiple files.
* platform/graphics/gtk/IconGtk.cpp: (WebCore::Icon::newIconForFiles): stubbed out.
* platform/graphics/qt/IconQt.cpp: (WebCore::Icon::newIconForFiles): ditto.
* platform/graphics/win/IconWin.cpp: (WebCore::Icon::newIconForFiles): ditto.
* platform/gtk/FileChooserGtk.cpp: (WebCore::FileChooser::basenameForWidth): Updated to deal with new filenames vector.
* platform/mac/FileChooserMac.mm: (WebCore::FileChooser::basenameForWidth): ditto.
* platform/qt/FileChooserQt.cpp:
(WebCore::FileChooser::openFileChooser):
(WebCore::FileChooser::basenameForWidth):
* platform/win/FileChooserWin.cpp: (WebCore::FileChooser::basenameForWidth):
* platform/network/mac/FormDataStreamMac.mm: (WebCore::disassociateStreamWithResourceHandle):
Removed unnecessary assertion. This can get hit when connectionDidFinishLoading and cancel
both get called for the same ResourceHandle. This getting called twice has no negative effect.
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::valueChanged): Calls setFileListFromRenderer.
(WebCore::RenderFileUploadControl::allowsMultipleFiles): Added.
(WebCore::RenderFileUploadControl::updateFromElement): Uses the new filenames call from FileChooser.
(WebCore::RenderFileUploadControl::receiveDroppedFiles): Updated to support multiple files.
* rendering/RenderFileUploadControl.h:
2008-10-23 Peter Kasting <pkasting@google.com>
Reviewed by David Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=21844
Remove setFocusRingColorChangeFunction.
* page/Page.cpp:
(WebCore::Page::Page):
* platform/graphics/Color.h:
* platform/graphics/mac/ColorMac.mm:
(WebCore::focusRingColor):
* platform/graphics/qt/GraphicsContextQt.cpp:
* platform/graphics/win/ColorSafari.cpp:
2008-10-24 David Kilzer <ddkilzer@apple.com>
Build fix for Qt.
Reviewed by Greg.
* WebCore.pro: Added missing *.idl files.
2008-10-24 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=21475
Provide support for the Geolocation API
http://dev.w3.org/geo/api/spec-source.html
Test: geolocation/geolocation-not-implemented.html
* DerivedSources.make:
* GNUmakefile.am: Added Geolocation support
* WebCore.pro: Added Geolocation support
* WebCore.vcproj/WebCore.vcproj: Added Geolocation support
* WebCore.xcodeproj/project.pbxproj: Added Geolocation support
* WebCoreSources.bkl: Added Geolocation support
* bindings/js/JSCustomPositionCallback.cpp: Added.
(WebCore::JSCustomPositionCallback::JSCustomPositionCallback):
(WebCore::JSCustomPositionCallback::handleEvent):
* bindings/js/JSCustomPositionCallback.h: Added.
(WebCore::JSCustomPositionCallback::create):
* bindings/js/JSCustomPositionErrorCallback.cpp: Added.
(WebCore::JSCustomPositionErrorCallback::JSCustomPositionErrorCallback):
(WebCore::JSCustomPositionErrorCallback::handleEvent):
* bindings/js/JSCustomPositionErrorCallback.h: Added.
(WebCore::JSCustomPositionErrorCallback::create):
* bindings/js/JSDOMBinding.cpp: move markDOMObjectWrapper here from JSDOMWindowCustom
(WebCore::markDOMObjectWrapper):
* bindings/js/JSDOMBinding.h: move markDOMObjectWrapper here from JSDOMWindowCustom
* bindings/js/JSDOMWindowCustom.cpp: move markDOMObjectWrapper to JSDOMBinding
* bindings/js/JSGeolocationCustom.cpp: Added.
(WebCore::JSGeolocation::getCurrentPosition):
(WebCore::JSGeolocation::watchPosition):
* bindings/js/JSNavigatorCustom.cpp: handle marking Geolocation
(WebCore::JSNavigator::mark):
* dom/Document.cpp:
(WebCore::Document::Document):
* dom/Document.h:
(WebCore::Document::setUsingGeolocation):
(WebCore::Document::usingGeolocation):
* loader/FrameLoader.cpp: don't add to back forward cache if using Geolocation
(WebCore::FrameLoader::canCachePage):
* page/Geolocation.cpp: Added.
(WebCore::Geolocation::GeoNotifier::GeoNotifier):
(WebCore::Geolocation::GeoNotifier::timerFired):
(WebCore::Geolocation::Geolocation):
(WebCore::Geolocation::disconnectFrame):
(WebCore::Geolocation::getCurrentPosition):
(WebCore::Geolocation::watchPosition):
(WebCore::Geolocation::clearWatch):
(WebCore::Geolocation::stopUpdatingIfEmpty):
(WebCore::Geolocation::sendErrorToOneShots):
(WebCore::Geolocation::sendErrorToWatchers):
(WebCore::Geolocation::sendPositionToOneShots):
(WebCore::Geolocation::sendPositionToWatchers):
(WebCore::Geolocation::handleError):
(WebCore::Geolocation::geolocationServicePositionChanged):
(WebCore::Geolocation::geolocationServiceErrorOccurred):
* page/Geolocation.h: Added.
(WebCore::Geolocation::create):
(WebCore::Geolocation::~Geolocation):
(WebCore::Geolocation::lastPosition):
(WebCore::Geolocation::GeoNotifier::create):
* page/Geolocation.idl: Added.
* page/Geoposition.cpp: Added.
(WebCore::Geoposition::toString):
* page/Geoposition.h: Added.
(WebCore::Geoposition::create):
(WebCore::Geoposition::latitude):
(WebCore::Geoposition::longitude):
(WebCore::Geoposition::altitude):
(WebCore::Geoposition::accuracy):
(WebCore::Geoposition::altitudeAccuracy):
(WebCore::Geoposition::heading):
(WebCore::Geoposition::velocity):
(WebCore::Geoposition::timestamp):
(WebCore::Geoposition::Geoposition):
* page/Geoposition.idl: Added.
* page/Navigator.cpp:
(WebCore::Navigator::disconnectFrame): disconnect Geolocation
(WebCore::Navigator::geolocation): accessor for Geolocation
* page/Navigator.h:
(WebCore::Navigator::optionalGeolocation): accessor for Geolocation
* page/Navigator.idl: accessor for Geolocation
* page/PositionCallback.h: Added.
(WebCore::PositionCallback::~PositionCallback):
* page/PositionCallback.idl: Added.
* page/PositionError.h: Added.
(WebCore::PositionError::):
(WebCore::PositionError::create):
(WebCore::PositionError::code):
(WebCore::PositionError::message):
(WebCore::PositionError::PositionError):
* page/PositionError.idl: Added.
* page/PositionErrorCallback.h: Added.
(WebCore::PositionErrorCallback::~PositionErrorCallback):
* page/PositionErrorCallback.idl: Added.
* page/PositionOptions.h: Added.
(WebCore::PositionOptions::create):
(WebCore::PositionOptions::enableHighAccuracy):
(WebCore::PositionOptions::setEnableHighAccuracy):
(WebCore::PositionOptions::timeout):
(WebCore::PositionOptions::setTimeout):
(WebCore::PositionOptions::PositionOptions):
* page/PositionOptions.idl: Added.
* platform/GeolocationService.cpp: Added.
(WebCore::GeolocationService::GeolocationService):
(WebCore::GeolocationService::positionChanged):
(WebCore::GeolocationService::errorOccurred):
* platform/GeolocationService.h: Added.
(WebCore::GeolocationServiceClient::~GeolocationServiceClient):
(WebCore::GeolocationServiceClient::geolocationServicePositionChanged):
(WebCore::GeolocationServiceClient::geolocationServiceErrorOccurred):
(WebCore::GeolocationService::~GeolocationService):
2008-10-24 Simon Fraser <simon.fraser@apple.com>
Reviewed by Darin Adler
https://bugs.webkit.org/show_bug.cgi?id=21818
Add HashTraits for AtomicString so that AtomicString can be used as
the key for a HashMap or HashSet.
* GNUmakefile.am: add AtomicStringHash.h
* WebCore.vcproj/WebCore.vcproj: add AtomicStringHash.h
* WebCore.xcodeproj/project.pbxproj: add AtomicStringHash.h
* platform/text/AtomicString.h:
(WebCore::AtomicString::AtomicString):
(WebCore::AtomicString::isHashTableDeletedValue):
specialize DefaultHash for AtomicString to use AtomicStringHash
* platform/text/AtomicStringHash.h: Added.
* platform/text/StringImpl.cpp:
(WebCore::StringImpl::StringImpl):
compute the hash up-front for the empty string
* platform/text/StringImpl.h:
(WebCore::StringImpl::existingHash):
method to get the hash without a test and branch, for callers like
AtomicStringHash who can guarantee that the hash has already been computed.
2008-10-24 Simon Fraser <simon.fraser@apple.com>
Reviewed by Sam Weinig
https://bugs.webkit.org/show_bug.cgi?id=21857
Add WebKitCSSKeyframeRule and WebKitCSSKeyframesRule to the
switch in _wrapCSSRule.
* bindings/objc/DOMCSS.mm:
(+[DOMCSSRule _wrapCSSRule:WebCore::]):
2008-10-24 Adam Roben <aroben@apple.com>
Windows build fix
* plugins/PluginView.cpp:
2008-10-24 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig.
- fix https://bugs.webkit.org/show_bug.cgi?id=21851
<rdar://problem/6304151> REGRESSION (r36513): Crash when removing a widget with percent height
Test: fast/replaced/percent-height-in-anonymous-block-widget.html
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::destroy): Copied code added to
RenderBox::destroy() in r36513 into this function.
2008-10-24 Timothy Hatcher <timothy@apple.com>
Add a mechanism to ask the InspectorClient for key/value setting pairs.
These settings can be strings, numbers, booleans or string vectors. The
settings are also bridged to and from JavaScript.
https://bugs.webkit.org/show_bug.cgi?id=21856
Reviewed by Darin Adler.
* WebCore.base.exp: Expose the String CFStringRef constructor.
* inspector/InspectorClient.h:
(WebCore::InspectorClient::populateSetting): Added, pure virtual.
(WebCore::InspectorClient::storeSetting): Ditto.
(WebCore::InspectorClient::removeSetting): Ditto.
* inspector/InspectorController.cpp:
(WebCore::setting): Calls InspectorController::setting and wraps the result in script types.
(WebCore::setSetting): Calls InspectorController::setSetting after converting from script types.
(WebCore::InspectorController::InspectorController): Increment a global static
to track the number of live InspectorControllers.
(WebCore::InspectorController::~InspectorController): Decrement the global static
that tracks the number of live InspectorControllers. Delete the setting cache if there
are no more live controllers.
(WebCore::InspectorController::setting): Check the cache and return the setting from there,
otherwise make a new Setting and ask the client to populate it.
(WebCore::InspectorController::setSetting): Change the cache and ask the client to store it.
(WebCore::InspectorController::windowScriptObjectAvailable): Add setting and setSetting
to the InspectorController script class.
* inspector/InspectorController.h:
(WebCore::InspectorController::Setting::Setting):
(WebCore::InspectorController::Setting::operator=):
(WebCore::InspectorController::Setting::type): Return m_type.
(WebCore::InspectorController::Setting::string): Return m_string. Assert the type is correct.
(WebCore::InspectorController::Setting::stringVector): Return m_stringVector.
Assert the type is correct.
(WebCore::InspectorController::Setting::doubleValue): Return m_simpleContent.m_double.
Assert the type is correct.
(WebCore::InspectorController::Setting::integerValue): Return m_simpleContent.m_integer.
Assert the type is correct.
(WebCore::InspectorController::Setting::booleanValue): Return m_simpleContent.m_boolean.
Assert the type is correct.
(WebCore::InspectorController::Setting::set): Overloaded for each data type, sets the right
field and the type.
* loader/EmptyClients.h:
(WebCore::EmptyInspectorClient::populateSetting): Added, empty method.
(WebCore::EmptyInspectorClient::storeSetting): Ditto.
(WebCore::EmptyInspectorClient::removeSetting): Ditto.
2008-10-24 Cameron Zwarich <zwarich@apple.com>
Reviewed by Sam Weinig.
Remove some C-style casts.
* html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::addViewSourceToken):
2008-10-24 Darin Adler <darin@apple.com>
- finish rolling out https://bugs.webkit.org/show_bug.cgi?id=21732
* bindings/js/JSAttrCustom.cpp:
* bindings/js/JSCSSRuleCustom.cpp:
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
* bindings/js/JSCSSValueCustom.cpp:
* bindings/js/JSCanvasPixelArrayCustom.h:
* bindings/js/JSCanvasRenderingContext2DCustom.cpp:
* bindings/js/JSClipboardCustom.cpp:
* bindings/js/JSConsoleCustom.cpp:
* bindings/js/JSCustomSQLStatementCallback.cpp:
* bindings/js/JSCustomSQLStatementErrorCallback.cpp:
* bindings/js/JSCustomSQLTransactionCallback.cpp:
* bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
* bindings/js/JSCustomVoidCallback.cpp:
* bindings/js/JSCustomVoidCallback.h:
* bindings/js/JSCustomXPathNSResolver.cpp:
* bindings/js/JSCustomXPathNSResolver.h:
* bindings/js/JSDOMApplicationCacheCustom.cpp:
* bindings/js/JSDOMBinding.cpp:
* bindings/js/JSDOMBinding.h:
* bindings/js/JSDOMWindowBase.cpp:
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSDOMWindowCustom.cpp:
* bindings/js/JSDOMWindowCustom.h:
* bindings/js/JSDOMWindowShell.cpp:
* bindings/js/JSDOMWindowShell.h:
* bindings/js/JSDatabaseCustom.cpp:
* bindings/js/JSDedicatedWorkerCustom.cpp:
* bindings/js/JSDocumentCustom.cpp:
* bindings/js/JSElementCustom.cpp:
* bindings/js/JSEventCustom.cpp:
* bindings/js/JSEventListener.cpp:
* bindings/js/JSEventTarget.cpp:
* bindings/js/JSEventTarget.h:
* bindings/js/JSEventTargetBase.h:
* bindings/js/JSEventTargetNodeCustom.cpp:
* bindings/js/JSHTMLAllCollection.h:
* bindings/js/JSHTMLAppletElementCustom.cpp:
* bindings/js/JSHTMLCollectionCustom.cpp:
* bindings/js/JSHTMLDocumentCustom.cpp:
* bindings/js/JSHTMLEmbedElementCustom.cpp:
* bindings/js/JSHTMLFormElementCustom.cpp:
* bindings/js/JSHTMLFrameElementCustom.cpp:
* bindings/js/JSHTMLFrameSetElementCustom.cpp:
* bindings/js/JSHTMLIFrameElementCustom.cpp:
* bindings/js/JSHTMLInputElementCustom.cpp:
* bindings/js/JSHTMLObjectElementCustom.cpp:
* bindings/js/JSHTMLOptionsCollectionCustom.cpp:
* bindings/js/JSHTMLSelectElementCustom.cpp:
* bindings/js/JSHTMLSelectElementCustom.h:
* bindings/js/JSHistoryCustom.cpp:
* bindings/js/JSImageDataCustom.cpp:
* bindings/js/JSInspectedObjectWrapper.cpp:
* bindings/js/JSInspectedObjectWrapper.h:
* bindings/js/JSInspectorCallbackWrapper.cpp:
* bindings/js/JSInspectorCallbackWrapper.h:
* bindings/js/JSJavaScriptCallFrameCustom.cpp:
* bindings/js/JSLocationCustom.cpp:
* bindings/js/JSMessagePortCustom.cpp:
* bindings/js/JSMimeTypeArrayCustom.cpp:
* bindings/js/JSNamedNodeMapCustom.cpp:
* bindings/js/JSNamedNodesCollection.cpp:
* bindings/js/JSNamedNodesCollection.h:
* bindings/js/JSNavigatorCustom.cpp:
* bindings/js/JSNodeCustom.cpp:
* bindings/js/JSNodeFilterCondition.cpp:
* bindings/js/JSNodeFilterCondition.h:
* bindings/js/JSNodeFilterCustom.cpp:
* bindings/js/JSNodeIteratorCustom.cpp:
* bindings/js/JSNodeListCustom.cpp:
* bindings/js/JSPluginArrayCustom.cpp:
* bindings/js/JSPluginCustom.cpp:
* bindings/js/JSPluginElementFunctions.cpp:
* bindings/js/JSPluginElementFunctions.h:
* bindings/js/JSQuarantinedObjectWrapper.cpp:
* bindings/js/JSQuarantinedObjectWrapper.h:
* bindings/js/JSRGBColor.cpp:
* bindings/js/JSRGBColor.h:
* bindings/js/JSSQLResultSetRowListCustom.cpp:
* bindings/js/JSSQLTransactionCustom.cpp:
* bindings/js/JSSVGElementInstanceCustom.cpp:
* bindings/js/JSSVGLengthCustom.cpp:
* bindings/js/JSSVGMatrixCustom.cpp:
* bindings/js/JSSVGPathSegCustom.cpp:
* bindings/js/JSSVGPathSegListCustom.cpp:
* bindings/js/JSSVGPointListCustom.cpp:
* bindings/js/JSSVGTransformListCustom.cpp:
* bindings/js/JSStorageCustom.cpp:
* bindings/js/JSStyleSheetCustom.cpp:
* bindings/js/JSStyleSheetListCustom.cpp:
* bindings/js/JSTextCustom.cpp:
* bindings/js/JSTreeWalkerCustom.cpp:
* bindings/js/JSXMLHttpRequestCustom.cpp:
* bindings/js/JSXMLHttpRequestUploadCustom.cpp:
* bindings/js/JSXSLTProcessorCustom.cpp:
* bindings/js/ScheduledAction.cpp:
* bindings/js/ScheduledAction.h:
* bindings/js/ScriptController.cpp:
* bindings/js/ScriptController.h:
* bindings/objc/WebScriptObject.mm:
* bindings/objc/WebScriptObjectPrivate.h:
* bindings/scripts/CodeGeneratorJS.pm:
* bridge/NP_jsobject.cpp:
* bridge/c/c_instance.cpp:
* bridge/c/c_instance.h:
* bridge/c/c_runtime.cpp:
* bridge/c/c_runtime.h:
* bridge/c/c_utility.cpp:
* bridge/c/c_utility.h:
* bridge/jni/jni_instance.cpp:
* bridge/jni/jni_instance.h:
* bridge/jni/jni_jsobject.h:
* bridge/jni/jni_jsobject.mm:
* bridge/jni/jni_objc.mm:
* bridge/jni/jni_runtime.cpp:
* bridge/jni/jni_runtime.h:
* bridge/jni/jni_utility.cpp:
* bridge/jni/jni_utility.h:
* bridge/objc/WebScriptObject.h:
* bridge/objc/objc_class.h:
* bridge/objc/objc_class.mm:
* bridge/objc/objc_instance.h:
* bridge/objc/objc_instance.mm:
* bridge/objc/objc_runtime.h:
* bridge/objc/objc_runtime.mm:
* bridge/objc/objc_utility.h:
* bridge/objc/objc_utility.mm:
* bridge/qt/qt_class.cpp:
* bridge/qt/qt_class.h:
* bridge/qt/qt_instance.cpp:
* bridge/qt/qt_instance.h:
* bridge/qt/qt_runtime.cpp:
* bridge/qt/qt_runtime.h:
* bridge/runtime.cpp:
* bridge/runtime.h:
* bridge/runtime_array.cpp:
* bridge/runtime_array.h:
* bridge/runtime_method.cpp:
* bridge/runtime_method.h:
* bridge/runtime_object.cpp:
* bridge/runtime_object.h:
* bridge/testqtbindings.cpp:
* inspector/JavaScriptCallFrame.cpp:
* inspector/JavaScriptCallFrame.h:
* inspector/JavaScriptProfile.cpp:
* inspector/JavaScriptProfile.h:
* inspector/JavaScriptProfileNode.cpp:
* inspector/JavaScriptProfileNode.h:
* loader/FrameLoader.cpp:
* loader/FrameLoader.h:
* page/Console.cpp:
* page/Console.h:
* plugins/MimeTypeArray.h:
* plugins/Plugin.h:
* plugins/PluginArray.h:
* plugins/PluginView.cpp:
* xml/XMLHttpRequest.cpp:
Use JSValue* instead of JSValuePtr.
2008-10-24 Simon Hausmann <hausmann@webkit.org>
Fix the Qt build.
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtField::valueFromInstance):
2008-10-24 David Kilzer <ddkilzer@apple.com>
Rolled out r37840 and r37841.
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* bindings/js/JSCustomPositionCallback.cpp: Removed.
* bindings/js/JSCustomPositionCallback.h: Removed.
* bindings/js/JSCustomPositionErrorCallback.cpp: Removed.
* bindings/js/JSCustomPositionErrorCallback.h: Removed.
* bindings/js/JSDOMBinding.cpp:
* bindings/js/JSDOMBinding.h:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::markDOMObjectWrapper):
* bindings/js/JSGeolocationCustom.cpp: Removed.
* bindings/js/JSNavigatorCustom.cpp:
* dom/Document.cpp:
(WebCore::Document::Document):
* dom/Document.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::canCachePage):
* page/Geolocation.cpp: Removed.
* page/Geolocation.h: Removed.
* page/Geolocation.idl: Removed.
* page/Geoposition.cpp: Removed.
* page/Geoposition.h: Removed.
* page/Geoposition.idl: Removed.
* page/Navigator.cpp:
(WebCore::Navigator::disconnectFrame):
* page/Navigator.h:
* page/Navigator.idl:
* page/PositionCallback.h: Removed.
* page/PositionCallback.idl: Removed.
* page/PositionError.h: Removed.
* page/PositionError.idl: Removed.
* page/PositionErrorCallback.h: Removed.
* page/PositionErrorCallback.idl: Removed.
* page/PositionOptions.h: Removed.
* page/PositionOptions.idl: Removed.
* platform/GeolocationService.cpp: Removed.
* platform/GeolocationService.h: Removed.
2008-10-23 David Kilzer <ddkilzer@apple.com>
Attempt to fix GTK build.
* GNUmakefile.am: Added new *.idl files that were missing.
2008-10-23 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=21475
Provide support for the Geolocation API
http://dev.w3.org/geo/api/spec-source.html
Test: geolocation/geolocation-not-implemented.html
* DerivedSources.make:
* GNUmakefile.am: Added Geolocation support
* WebCore.pro: Added Geolocation support
* WebCore.vcproj/WebCore.vcproj: Added Geolocation support
* WebCore.xcodeproj/project.pbxproj: Added Geolocation support
* WebCoreSources.bkl: Added Geolocation support
* bindings/js/JSCustomPositionCallback.cpp: Added.
(WebCore::JSCustomPositionCallback::JSCustomPositionCallback):
(WebCore::JSCustomPositionCallback::handleEvent):
* bindings/js/JSCustomPositionCallback.h: Added.
(WebCore::JSCustomPositionCallback::create):
* bindings/js/JSCustomPositionErrorCallback.cpp: Added.
(WebCore::JSCustomPositionErrorCallback::JSCustomPositionErrorCallback):
(WebCore::JSCustomPositionErrorCallback::handleEvent):
* bindings/js/JSCustomPositionErrorCallback.h: Added.
(WebCore::JSCustomPositionErrorCallback::create):
* bindings/js/JSDOMBinding.cpp: move markDOMObjectWrapper here from JSDOMWindowCustom
(WebCore::markDOMObjectWrapper):
* bindings/js/JSDOMBinding.h: move markDOMObjectWrapper here from JSDOMWindowCustom
* bindings/js/JSDOMWindowCustom.cpp: move markDOMObjectWrapper to JSDOMBinding
* bindings/js/JSGeolocationCustom.cpp: Added.
(WebCore::JSGeolocation::getCurrentPosition):
(WebCore::JSGeolocation::watchPosition):
* bindings/js/JSNavigatorCustom.cpp: handle marking Geolocation
(WebCore::JSNavigator::mark):
* dom/Document.cpp:
(WebCore::Document::Document):
* dom/Document.h:
(WebCore::Document::setUsingGeolocation):
(WebCore::Document::usingGeolocation):
* loader/FrameLoader.cpp: don't add to back forward cache if using Geolocation
(WebCore::FrameLoader::canCachePage):
* page/Geolocation.cpp: Added.
(WebCore::Geolocation::GeoNotifier::GeoNotifier):
(WebCore::Geolocation::GeoNotifier::timerFired):
(WebCore::Geolocation::Geolocation):
(WebCore::Geolocation::disconnectFrame):
(WebCore::Geolocation::getCurrentPosition):
(WebCore::Geolocation::watchPosition):
(WebCore::Geolocation::clearWatch):
(WebCore::Geolocation::stopUpdatingIfEmpty):
(WebCore::Geolocation::sendErrorToOneShots):
(WebCore::Geolocation::sendErrorToWatchers):
(WebCore::Geolocation::sendPositionToOneShots):
(WebCore::Geolocation::sendPositionToWatchers):
(WebCore::Geolocation::handleError):
(WebCore::Geolocation::geolocationServicePositionChanged):
(WebCore::Geolocation::geolocationServiceErrorOccurred):
* page/Geolocation.h: Added.
(WebCore::Geolocation::create):
(WebCore::Geolocation::~Geolocation):
(WebCore::Geolocation::lastPosition):
(WebCore::Geolocation::GeoNotifier::create):
* page/Geolocation.idl: Added.
* page/Geoposition.cpp: Added.
(WebCore::Geoposition::toString):
* page/Geoposition.h: Added.
(WebCore::Geoposition::create):
(WebCore::Geoposition::latitude):
(WebCore::Geoposition::longitude):
(WebCore::Geoposition::altitude):
(WebCore::Geoposition::accuracy):
(WebCore::Geoposition::altitudeAccuracy):
(WebCore::Geoposition::heading):
(WebCore::Geoposition::velocity):
(WebCore::Geoposition::timestamp):
(WebCore::Geoposition::Geoposition):
* page/Geoposition.idl: Added.
* page/Navigator.cpp:
(WebCore::Navigator::disconnectFrame): disconnect Geolocation
(WebCore::Navigator::geolocation): accessor for Geolocation
* page/Navigator.h:
(WebCore::Navigator::optionalGeolocation): accessor for Geolocation
* page/Navigator.idl: accessor for Geolocation
* page/PositionCallback.h: Added.
(WebCore::PositionCallback::~PositionCallback):
* page/PositionCallback.idl: Added.
* page/PositionError.h: Added.
(WebCore::PositionError::):
(WebCore::PositionError::create):
(WebCore::PositionError::code):
(WebCore::PositionError::message):
(WebCore::PositionError::PositionError):
* page/PositionError.idl: Added.
* page/PositionErrorCallback.h: Added.
(WebCore::PositionErrorCallback::~PositionErrorCallback):
* page/PositionErrorCallback.idl: Added.
* page/PositionOptions.h: Added.
(WebCore::PositionOptions::create):
(WebCore::PositionOptions::enableHighAccuracy):
(WebCore::PositionOptions::setEnableHighAccuracy):
(WebCore::PositionOptions::timeout):
(WebCore::PositionOptions::setTimeout):
(WebCore::PositionOptions::PositionOptions):
* page/PositionOptions.idl: Added.
* platform/GeolocationService.cpp: Added.
(WebCore::GeolocationService::GeolocationService):
(WebCore::GeolocationService::positionChanged):
(WebCore::GeolocationService::errorOccurred):
* platform/GeolocationService.h: Added.
(WebCore::GeolocationServiceClient::~GeolocationServiceClient):
(WebCore::GeolocationServiceClient::geolocationServicePositionChanged):
(WebCore::GeolocationServiceClient::geolocationServiceErrorOccurred):
(WebCore::GeolocationService::~GeolocationService):
2008-10-23 Alp Toker <alp@nuanti.com>
Fix typo in comment in previous commit. GTK -> GLIB
* platform/gtk/guriescape.c:
2008-10-23 Kalle Vahlman <kalle.vahlman@movial.com>
Reviewed by Alp Toker.
https://bugs.webkit.org/show_bug.cgi?id=21824
[GTK] FileSystem abstraction uses features from Glib 2.16
Wrap g_uri_unescape_string() to fix building with pre-2.16 Glib
* platform/gtk/guriescape.c:
(unescape_character):
(_webcore_g_uri_unescape_segment):
(_webcore_g_uri_unescape_string):
* platform/gtk/guriescape.h:
2008-10-23 Jan Michael Alonzo <jmalonzo@webkit.org>
Fix Gtk build typo introduced in http://trac.webkit.org/changeset/37826.
* GNUmakefile.am:
2008-10-23 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
m_frame null checked but then dereferenced
https://bugs.webkit.org/show_bug.cgi?id=21845
This error was found using a static analysis tool, and so I do not know
how to produce a null m_frame on entry to this method. Hence, I have
not included a regression test.
* page/EventHandler.cpp:
(WebCore::EventHandler::allowDHTMLDrag): Add an early return.
2008-10-23 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig with no hesitation.
- fix the HTML/CSS case of https://bugs.webkit.org/show_bug.cgi?id=19839
<rdar://problem/6304805> A PDF,RLE sequence that should be a no-op affects bidi reordering
Test: fast/text/bidi-embedding-pop-and-push-same.html
* platform/text/BidiResolver.h:
(WebCore::BidiResolver::embed): Changed to only add the embedding
operation to a vector of pending operations.
(WebCore::BidiResolver::lowerExplicitEmbeddingLevel): Added. Moved the
code that used to be in the PDF case of embed() here, except the part
that sets the context.
(WebCore::BidiResolver::raiseExplicitEmbeddingLevel): Added. Moved the
code that used to be in the non-PDF case of embed() here, except the
part the sets the context.
(WebCore::BidiResolver::commitExplicitEmbedding): Added. Processes the
explicit embedding operations in the vector by creating an updated
context and determining the old and new embedding levels. If the levels
are not the same, calls {lower,raise}ExplicitEmbeddingLevel(). Always
sets the context to the new one.
(WebCore::BidiResolver::createBidiRunsForLine): Added calls to
commitExplicitEmbedding() after calling embed() and after calling
increment().
* rendering/bidi.cpp:
(WebCore::bidiFirst): Added calls to commitExplicitEmbedding() because
this function increments the resolver.
(WebCore::RenderBlock::skipLeadingWhitespace): Ditto.
2008-10-23 Jan Michael Alonzo <jmalonzo@webkit.org>
Gtk build fix. Not reviewed.
Add DNSCurl and DNSSoup to the Gtk build
* GNUmakefile.am:
* platform/gtk/TemporaryLinkStubs.cpp:
* platform/network/soup/DNSSoup.cpp: Copied from WebCore/platform/network/curl/DNSCurl.cpp.
(WebCore::prefetchDNS):
2008-10-23 Eric Seidel <eric@webkit.org>
Reviewed by Sam Weinig.
Un-break the Darwin build.
* platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
* platform/graphics/cg/ImageCG.cpp:
2008-10-23 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
Fix forward decls to be struct instead of class.
https://bugs.webkit.org/show_bug.cgi?id=21838
* rendering/style/StyleRareInheritedData.h:
* rendering/style/StyleRareNonInheritedData.h:
2008-10-23 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Oliver Hunt.
* platform/network/curl/ResourceRequest.h: A better implementation
of CFURLRequest, rather than void*. This gives better compatibility
with the WebKit.idl interface.
(WebCore::ResourceRequest::cfURLRequest):
2008-10-23 Mike Pinkerton <pinkerton@chromium.org>
Reviewed by Eric Seidel.
PLATFORM(CHROMIUM) uses CG the same way PLATFORM(MAC) does so fix
ifdefs to reflect that.
* platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
* platform/graphics/cg/ImageCG.cpp:
2008-10-23 Peter Kasting <pkasting@google.com>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=21833
Place JavaScript Debugger hooks under #if ENABLE(JAVASCRIPT_DEBUGGER).
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::setWindowVisible):
(WebCore::InspectorController::windowScriptObjectAvailable):
(WebCore::InspectorController::close):
* inspector/InspectorController.h:
* page/Page.cpp:
(WebCore::Page::Page):
2008-10-23 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim Hatcher.
https://bugs.webkit.org/show_bug.cgi?id=21817
Bug 21817: Manual profiler tests should be made into layout tests
-Moving the tests before diffing so that it's clear what changed.
* manual-tests/inspector/profiler-test-anonymous-event-handler.html: Removed.
* manual-tests/inspector/profiler-test-anonymous-function-called-from-different-contexts.html: Removed.
* manual-tests/inspector/profiler-test-anonymous-function-calls-built-in-functions.html: Removed.
* manual-tests/inspector/profiler-test-anonymous-function-calls-eval.html: Removed.
* manual-tests/inspector/profiler-test-apply.html: Removed.
* manual-tests/inspector/profiler-test-built-in-function-calls-anonymous.html: Removed.
* manual-tests/inspector/profiler-test-built-in-function-calls-user-defined-function.html: Removed.
* manual-tests/inspector/profiler-test-call-nodelist-as-function.html: Removed.
* manual-tests/inspector/profiler-test-calling-the-function-that-started-the-profiler-from-another-scope.html: Removed.
* manual-tests/inspector/profiler-test-compare-multiple-profiles.html: Removed.
* manual-tests/inspector/profiler-test-constructor.html: Removed.
* manual-tests/inspector/profiler-test-dead-time.html: Removed.
* manual-tests/inspector/profiler-test-deep-recursion.html: Removed.
* manual-tests/inspector/profiler-test-document-dot-write.html: Removed.
* manual-tests/inspector/profiler-test-event-handler.html: Removed.
* manual-tests/inspector/profiler-test-execution-context-and-eval-on-same-line.html: Removed.
* manual-tests/inspector/profiler-test-heavy-view.html: Removed.
* manual-tests/inspector/profiler-test-inline-event-handler.html: Removed.
* manual-tests/inspector/profiler-test-multiple-and-different-scoped-anonymous-function-calls.html: Removed.
* manual-tests/inspector/profiler-test-multiple-and-different-scoped-function-calls.html: Removed.
* manual-tests/inspector/profiler-test-multiple-frames.html: Removed.
* manual-tests/inspector/profiler-test-multiple-windows.html: Removed.
* manual-tests/inspector/profiler-test-nested-anonymous-functon.html: Removed.
* manual-tests/inspector/profiler-test-nested-start-and-stop-profiler.html: Removed.
* manual-tests/inspector/profiler-test-no-execution-context.html: Removed.
* manual-tests/inspector/profiler-test-one-execution-context.html: Removed.
* manual-tests/inspector/profiler-test-profile-calls-in-included-file.html: Removed.
* manual-tests/inspector/profiler-test-profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html: Removed.
* manual-tests/inspector/profiler-test-profiling-from-a-nested-location.html: Removed.
* manual-tests/inspector/profiler-test-simple-event-call.html: Removed.
* manual-tests/inspector/profiler-test-simple-no-level-change.html: Removed.
* manual-tests/inspector/profiler-test-start-and-stop-profiler-multiple-times.html: Removed.
* manual-tests/inspector/profiler-test-start-and-stop-profiling-in-the-same-function.html: Removed.
* manual-tests/inspector/profiler-test-start-but-dont-stop-profiling.html: Removed.
* manual-tests/inspector/profiler-test-stop-profiling-after-setTimeout.html: Removed.
* manual-tests/inspector/profiler-test-stop-then-function-call.html: Removed.
* manual-tests/inspector/profiler-test-throw-exception-from-eval.html: Removed.
* manual-tests/inspector/profiler-test-two-execution-contexts.html: Removed.
* manual-tests/inspector/profiler-test-user-defined-function-calls-built-in-functions.html: Removed.
* manual-tests/inspector/profiler-test-window-dot-eval.html: Removed.
* manual-tests/inspector/resources/other-frame.html: Removed.
* manual-tests/inspector/resources/other-window.html: Removed.
* manual-tests/inspector/resources/profiler-test-JS-resources.js: Removed.
2008-10-23 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=21826
Add accessor for SecurityOrigin::m_domainWasSetInDOM.
* page/SecurityOrigin.h:
(WebCore::SecurityOrigin::domainWasSetInDOM):
2008-10-23 Darin Adler <darin@apple.com>
- roll out https://bugs.webkit.org/show_bug.cgi?id=21732
* bindings/js/ScheduledAction.h:
* inspector/InspectorController.cpp:
ProtectedPtr<JSValue> instead of ProtectedPtr<JSValuePtr>.
2008-10-23 Simon Hausmann <hausmann@webkit.org>
Fix the Qt build.
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtConnectionObject::execute):
* bridge/qt/qt_runtime.h:
(JSC::Bindings::QtRuntimeMethod::createStructureID):
2008-10-23 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=21825
JSDOMBinding should not blindly cast the global object to JSDOMWindow
* bindings/js/JSDOMGlobalObject.cpp:
* bindings/js/JSDOMGlobalObject.h:
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
Added JSDOMGlobalObject, a base class to be used by both Window and worker contexts.
* bindings/js/JSDOMBinding.cpp:
(WebCore::getCachedDOMStructure):
(WebCore::cacheDOMStructure):
(WebCore::getCachedDOMConstructor):
(WebCore::cacheDOMConstructor):
Cast to JSDOMGlobalObject, as DOM objects live in DOM global objects.
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBase):
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::mark):
Moved constructor and structure tracking to JSDOMGlobalObject.
2008-10-23 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=21787
Update postMessage to send origin = "null" for non-serializable
origins to match latest spec. Merge SecurityOrigin::toString and
SecurityOrigin::toHTTPOrigin because they are now the same.
Test: http/tests/security/postMessage/data-url-sends-null-origin.html
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::outgoingOrigin):
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::addHTTPOriginIfNeeded):
(WebCore::FrameLoader::loadItem):
* loader/loader.cpp:
(WebCore::Loader::Host::servePendingRequests):
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::toString):
* page/SecurityOrigin.h:
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::makeSimpleCrossSiteAccessRequest):
(WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
(WebCore::XMLHttpRequest::handleAsynchronousPreflightResult):
(WebCore::XMLHttpRequest::didReceiveResponsePreflight):
2008-10-22 David Kilzer <ddkilzer@apple.com>
Bug 21781: WebCore::Settings should have a maximum decoded image size setting
<https://bugs.webkit.org/show_bug.cgi?id=21781>
Reviewed by Antti.
No tests since there is no change in behavior.
* loader/CachedImage.cpp:
(WebCore::CachedImage::maximumDecodedImageSize): Added. Returns
WebCore::Settings::maximumDecodedImageSize() or 0 on error.
(WebCore::CachedImage::data): Flag an error if the image being
loaded is too big.
* loader/CachedImage.h:
(WebCore::CachedImage::maximumDecodedImageSize): Added declaration.
* page/Settings.cpp:
(WebCore::Settings::Settings): Initialize m_maximumDecodedImageSize
to the maximum value of size_t.
* page/Settings.h:
(WebCore::Settings::setMaximumDecodedImageSize): Added method.
(WebCore::Settings::maximumDecodedImageSize): Ditto.
2008-10-22 Mike Pinkerton <pinkerton@chromium.org>
Reviewed by Dan Bernstein.
Landed and tweaked a bit by Darin Adler.
- fix https://bugs.webkit.org/show_bug.cgi?id=21809
Remove PLATFORM(MAC) wrapping USE(ATSUI). It's redundant and inhibits
its use for PLATFORM(CHROMIUM) in the future.
* platform/graphics/SimpleFontData.h:
2008-10-22 David Smith <catfish.man@gmail.com>
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=19974
getElementsByClassName not live enough
Test: fast/dom/getElementsByClassName/015.html
* dom/StyledElement.cpp:
(WebCore::StyledElement::classAttributeChanged): call dispatchSubtreeModifiedEvent()
2008-10-22 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
- fix https://bugs.webkit.org/show_bug.cgi?id=21294
Bug 21294: Devirtualize getOwnPropertySlot()
* bindings/js/JSDOMWindowShell.h:
(WebCore::JSDOMWindowShell::createStructureID): Added. Returns a structure without
HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
* bindings/js/JSInspectorCallbackWrapper.cpp:
(WebCore::JSInspectorCallbackWrapper::wrap): Change to use a unique structure
for this class rather than sharing nullProtoStructureID, which no longer exists.
* bindings/js/JSNamedNodesCollection.h:
(WebCore::JSNamedNodesCollection::createStructureID): Added. Returns a structure without
HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
* bindings/js/JSRGBColor.h:
(WebCore::JSRGBColor::createStructureID): Ditto.
* bindings/scripts/CodeGeneratorJS.pm: Added createStructureID functions for the wrappers,
constructors, and prototypes in any case where they override getOwnPropertySlot, without
HasStandardGetOwnPropertySlot.
* bridge/objc/objc_runtime.h:
(JSC::Bindings::ObjcFallbackObjectImp::createStructureID): Added. Returns a structure
without HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
* bridge/qt/qt_runtime.h:
(JSC::Bindings::QtRuntimeMethod::createStructureID): Ditto.
* bridge/runtime_array.h:
(JSC::RuntimeArray::createStructureID): Ditto.
* bridge/runtime_method.h:
(JSC::RuntimeMethod::createStructureID): Ditto.
* bridge/runtime_object.h:
(JSC::RuntimeObjectImp::createStructureID): Ditto.
2008-10-22 Brent Fulgham <bfulgham@gmail.com>
Bring Windows Cairo Port's font handling in line with CG.
http://bugs.webkit.org/show_bug.cgi?id=21812.
Reviewed by Adam Roben.
* platform/graphics/win/FontCacheWin.cpp:
(WebCore::createGDIFont): Remove unnecessary special-case for Cairo
TrueType font search. It should match CG in all font selections.
2008-10-22 Brent Fulgham <bfulgham@gmail.com>
http://bugs.webkit.org/show_bug.cgi?id=21812.
Bring Windows Cairo Port's font handling in line with CG.
Reviewed by David Hyatt.
* platform/graphics/win/FontCacheWin.cpp:
(WebCore::createGDIFont): Remove unnecessary special-case for Cairo TrueType font search. It should match CG in all font selections.
2008-10-22 Brady Eidson <beidson@apple.com>
Reviewed by Adam Roben
<rdar://6261773> - autocomplete="off" doesn't work on Windows
Visual Studio makes a poor decision regarding the combination of enums and bitfields, such that a
statement like "m_autocomplete = Off" followed by "return m_autocomplete == Off" would return "false"
instead of the much more correct "true."
In the past we have worked around this by declaring the bitfield member as an unsigned instead
of the enum type.
For more discussion, see http://trac.webkit.org/changeset/25329
* html/HTMLInputElement.h: Work around insane Visual Studio enum issue *sigh*
2008-10-22 Kevin McCullough <kmccullough@apple.com>
Reviewed by Oliver Hunt and Tim Hatcher.
https://bugs.webkit.org/show_bug.cgi?id=19225
Bug 19225: JSProfiler: Create automated profiler tests
- This change exports profiles on the console object so that they can be
iterated over via JavaScript, and thus can be used in automated tests.
* bindings/js/JSConsoleCustom.cpp: Get the profiles and return an array
that JS can use.
(WebCore::JSConsole::profiles):
* inspector/InspectorController.h: Use the new typedef.
(WebCore::InspectorController::profiles):
* page/Console.cpp: Keep our own array of profile objects.
(WebCore::Console::profileEnd):
* page/Console.h: Ditto.
(WebCore::Console::profiles):
* page/Console.idl: Expose the profiles to JS.
2008-10-22 David Hyatt <hyatt@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=21775
Convert buttons over to use the new Theme API on OS X.
Reviewed by Adam Roben
* platform/LengthBox.h:
(WebCore::LengthBox::LengthBox):
* platform/Theme.cpp:
(WebCore::Theme::controlBorder):
(WebCore::Theme::controlPadding):
* platform/Theme.h:
(WebCore::Theme::controlFont):
(WebCore::Theme::controlSize):
(WebCore::Theme::minControlSize):
(WebCore::Theme::controlRequiresPreWhiteSpace):
* platform/mac/ThemeMac.h:
(WebCore::ThemeMac::controlRequiresPreWhiteSpace):
* platform/mac/ThemeMac.mm:
(WebCore::checkboxSize):
(WebCore::radioSize):
(WebCore::buttonSizes):
(WebCore::buttonMargins):
(WebCore::button):
(WebCore::paintButton):
(WebCore::ThemeMac::controlFont):
(WebCore::ThemeMac::controlSize):
(WebCore::ThemeMac::minControlSize):
(WebCore::ThemeMac::controlBorder):
(WebCore::ThemeMac::controlPadding):
(WebCore::ThemeMac::inflateControlPaintRect):
(WebCore::ThemeMac::paint):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::controlStatesForRenderer):
(WebCore::RenderTheme::isDefault):
(WebCore::RenderTheme::adjustRadioStyle):
* rendering/RenderTheme.h:
(WebCore::RenderTheme::setRadioSize):
* rendering/RenderThemeMac.h:
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::adjustRepaintRect):
(WebCore::menuListButtonSizes):
(WebCore::RenderThemeMac::adjustMenuListStyle):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::paddingBox):
(WebCore::InheritedFlags::setPaddingBox):
2008-10-22 Chris Marrin <cmarrin@apple.com>
Reviewed by Dave Hyatt
Make sure that the AtomicString that identifies a set of animation keyframes
stays live by keeping a copy in the WebKitCSSKeyframesRule.
Also call styleSheetChanged() when the keyframes name changes, but
add an internal method that doesn't call styleSheetChanged() for use
during normal stylesheet parsing.
Test: animations/change-keyframes-name.html
* css/CSSGrammar.y:
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::WebKitCSSKeyframesRule::setName):
* css/WebKitCSSKeyframesRule.h:
(WebCore::WebKitCSSKeyframesRule::setNameInternal):
2008-10-22 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=21791
WebCore JS bindings should be able to use non-static hash tables for properties
Add a map for HashTables to WebCore JS client data.
This makes property access noticeably slower, so it is an opt-in. For classes that need to be
supported in workers in forseeable future this is not critical.
* bindings/js/JSDOMBinding.cpp:
(WebCore::DOMObjectHashTableMap::get):
(WebCore::DOMObjectHashTableMap::mapFor):
(WebCore::getHashTableForGlobalData):
(WebCore::DOMObjectWrapperMap::mapFor):
WebCore client data is now a class that contains both a DOM wrapper map and a property hash
table one.
* bindings/js/JSDOMBinding.h: Added getHashTableForGlobalData() to query the hash table map.
* bindings/scripts/CodeGeneratorJS.pm: If the class has a NoStaticTables attribute, use
JSDOMBinding map to access its property hash tables.
* dom/MessageChannel.idl:
* dom/MessagePort.idl:
Added NoStaticTables attribute.
2008-10-22 Gustavo Noronha Silva <gns@gnome.org>
Reviewed by Timothy Hatcher.
Build failure because of missing include
https://bugs.webkit.org/show_bug.cgi?id=21765
Build failure fix for WebKit/GTK+; added missing
include (GOwnPtr.h)
* platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
2008-10-22 Alp Toker <alp@nuanti.com>
Reviewed by Adam Roben.
Fix crashes on older GTK+ versions (2.8). gtk_widget_style_get()
doesn't initialize values if the requested property doesn't exist, so
initialize the values to the documented defaults before calling it
where necessary. Additionally, avoid critical warnings by not calling
gtk_widget_style_get() when we know the property isn't available.
Note that this is an imported source file which doesn't follow the
WebKit coding style.
* platform/gtk/gtk2drawing.c:
(moz_gtk_init):
(moz_gtk_button_get_inner_border):
(moz_gtk_combo_box_paint):
(moz_gtk_toolbar_separator_paint):
(moz_gtk_menu_separator_paint):
(moz_gtk_get_widget_border):
(moz_gtk_get_tab_scroll_arrow_size):
(moz_gtk_get_toolbar_separator_width):
(moz_gtk_get_menu_separator_height):
2008-10-22 Alp Toker <alp@nuanti.com>
Fix build for Cairo 1.2.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::clipOut):
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::paintMozWidget):
2008-10-22 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
A little more PLATFORM(CHROMIUM) in WebCore
https://bugs.webkit.org/show_bug.cgi?id=21758
* page/AccessibilityObject.h:
* platform/graphics/Icon.h:
2008-10-21 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Darin Adler.
Test: fast/events/message-channel-gc-3.html
https://bugs.webkit.org/show_bug.cgi?id=21769
MessagePort should be GC protected if there are messages to be delivered
* dom/MessagePort.h: Removed pending activity count. Now we track if a close event is
pending, and check if the queue is non-empty.
(WebCore::MessagePort::workerContext): Added a stub implementation for a cross-heap GC bug
fix (below).
* dom/MessagePort.cpp:
(WebCore::CloseMessagePortTimer::fired):
(WebCore::MessagePort::MessagePort):
(WebCore::MessagePort::queueCloseEvent):
(WebCore::MessagePort::dispatchCloseEvent):
(WebCore::MessagePort::hasPendingActivity):
Track message and close event activity separately.
* bindings/js/JSDOMBinding.cpp:
(WebCore::markCrossHeapDependentObjectsForDocument): Fixed a bug in cross-heap GC that was
causing same-heap ports to never be deleted.
2008-10-21 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig.
- remove unreachable code
* platform/text/BidiResolver.h:
(WebCore::::embed):
2008-10-21 Beth Dakin <bdakin@apple.com>
Reviewed by Darin Adler.
Fix for https://bugs.webkit.org/show_bug.cgi?id=20352
REGRESSION(r31030-31055): Choosing "Print window" from frame set
prints blank page
and corresponding: <rdar://problem/6142398>
viewHeight() and viewWidth() only return valuable information if we
are not printing. Everywhere else in the code, we make sure we are
not printing before we call these functions. Adding a check for
printing here fixes this bug, and framesets print again.
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::layout):
2008-10-21 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Simon.
Pixmap in canvas tag was not getting initialized.
See https://bugs.webkit.org/show_bug.cgi?id=21771
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBuffer::create):
2008-10-20 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein
Add a comment explaining layoutDelta(), and an assertion
that checks that delta changes were correctly paired during layout.
* rendering/RenderView.cpp:
(WebCore::RenderView::layout):
* rendering/RenderView.h:
2008-10-20 Timothy Hatcher <timothy@apple.com>
Make auto-complete only suggest properties that are valid syntax
when using dot-notation. Also when completing numeric properties,
the quotes are omitted inside the brackets.
https://bugs.webkit.org/show_bug.cgi?id=21760
https://bugs.webkit.org/show_bug.cgi?id=21761
Reviewed by Oliver Hunt.
* inspector/front-end/Console.js:
(WebInspector.Console.prototype.completions): Skip properties that
are not valid identifies when using dot-notation. And omit the quotes
when completing numbers in bracket-notation.
2008-10-20 Timothy Hatcher <timothy@apple.com>
Fixes the Profiles panel in the Web Inspector, which was broken by
the JSValue base-class changes. Also renames some functions and
variables in JavaScriptProfileNode.cpp that where title case.
https://bugs.webkit.org/show_bug.cgi?id=21764
Reviewed by Oliver Hunt.
* inspector/JavaScriptProfile.cpp:
(WebCore::toJS): Use a JSObject pointer instead of JSValuePtr so the
returned JSValuePtr will be treated as an object and not a value.
* inspector/JavaScriptProfileNode.cpp:
(WebCore::toJS): Ditto.
2008-10-20 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Remove FrameLoaderClient::detachedFromParent4. It is no longer used by any port.
* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::detachedFromParent4):.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::detachFromParent):
* loader/FrameLoaderClient.h:
2008-10-20 Antti Koivisto <antti@apple.com>
Reviewed by Adele Peterson.
Fix https://bugs.webkit.org/show_bug.cgi?id=21763
REGRESSION (r36108-r36113): Can't load picture content on wired.com galleries
<rdar://problem/6285025
If we get 304 response we need to explicitly check if that completes the frame load.
No test case, simulating the condition is pretty difficult.
* loader/loader.cpp:
(WebCore::Loader::Host::didReceiveResponse):
2008-10-20 Anders Carlsson <andersca@apple.com>
Reviewed by Mark Rowe.
Work around <rdar://problem/6301728>.
Don't assert that loads are deferred when we're using CFNetwork on Mac or Windows.
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::didReceiveResponse):
(WebCore::MainResourceLoader::didReceiveData):
(WebCore::MainResourceLoader::didFinishLoading):
(WebCore::MainResourceLoader::didFail):
2008-10-20 Beth Dakin <bdakin@apple.com>
Reviewed by Adele Peterson.
Speculative fix for <rdar://problem/6242585> CrashTracer: [USER] 19
crashes in Safari at com.apple.WebCore
WebCore::ScrollView::visibleContentRect const + 153
d->m_view can be null and is null-checked at other points in the
code. The logs indicate that this crash occurs when closing a
window containing a PDF, so in case where we crash, the PDF's view
is probably already null. So the fix is to simply add a null-check.
* page/Frame.cpp:
(WebCore::Frame::selectionRect):
2008-10-20 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
* html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData):
Removed stray increment that would screw up any form with multiple files in it.
2008-10-20 Sam Weinig <sam@webkit.org>
Rubber-stamped by David Hyatt.
Split LengthBox and LengthSize into their own files.
* GNUmakefile.am:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/Length.h:
(WebCore::Length::blend):
* platform/LengthBox.h: Copied from platform/Length.h.
(WebCore::LengthBox::LengthBox):
(WebCore::LengthBox::nonZero):
* platform/LengthSize.h: Copied from platform/Length.h.
(WebCore::LengthSize::LengthSize):
(WebCore::LengthSize::setWidth):
(WebCore::LengthSize::setHeight):
(WebCore::LengthSize::height):
* platform/Theme.h:
* rendering/style/FillLayer.h:
* rendering/style/NinePieceImage.h:
(WebCore::NinePieceImage::NinePieceImage):
* rendering/style/RenderStyle.h:
* rendering/style/StyleDashboardRegion.h:
* rendering/style/StyleSurroundData.h:
* rendering/style/StyleVisualData.h:
2008-10-20 Dan Bernstein <mitz@apple.com>
- Mac build fix
* WebCore.xcodeproj/project.pbxproj:
2008-10-20 Alp Toker <alp@nuanti.com>
Fix autotools dist build target by listing recently added header
files only. Not reviewed.
* GNUmakefile.am:
2008-10-20 David Hyatt <hyatt@apple.com>
Clean up some USE(NEW_THEME) ifdefs (I botched one of them and have broken non-Mac platforms). Also
refactor some of the code that I put in ThemeMac to be cross-platform, since it was in RenderTheme.cpp
originally.
ifdef some methods in RenderTheme.cpp also that are no longer needed with the new Theme.
Reviewed by Adam Roben
* WebCore.xcodeproj/project.pbxproj:
* platform/Theme.cpp: Added.
(WebCore::Theme::controlSupportsBorder):
(WebCore::Theme::controlSupportsPadding):
* platform/Theme.h:
* platform/mac/ThemeMac.h:
* platform/mac/ThemeMac.mm:
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
* rendering/RenderTheme.h:
2008-10-20 David Hyatt <hyatt@apple.com>
Rename LengthBox's members to have m_ in front of them.
Reviewed by Sam Weinig
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForNinePieceImage):
(WebCore::getPositionOffsetValue):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::mapNinePieceImage):
* platform/Length.h:
(WebCore::LengthBox::LengthBox):
(WebCore::LengthBox::left):
(WebCore::LengthBox::right):
(WebCore::LengthBox::top):
(WebCore::LengthBox::bottom):
(WebCore::LengthBox::operator==):
(WebCore::LengthBox::nonZero):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::paintNinePieceImage):
(WebCore::RenderObject::addDashboardRegions):
* rendering/style/RenderStyle.cpp:
(WebCore::positionedObjectMoved):
(WebCore::RenderStyle::setClip):
(WebCore::RenderStyle::noneDashboardRegions):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::left):
(WebCore::InheritedFlags::right):
(WebCore::InheritedFlags::top):
(WebCore::InheritedFlags::bottom):
(WebCore::InheritedFlags::clipLeft):
(WebCore::InheritedFlags::clipRight):
(WebCore::InheritedFlags::clipTop):
(WebCore::InheritedFlags::clipBottom):
(WebCore::InheritedFlags::marginTop):
(WebCore::InheritedFlags::marginBottom):
(WebCore::InheritedFlags::marginLeft):
(WebCore::InheritedFlags::marginRight):
(WebCore::InheritedFlags::paddingTop):
(WebCore::InheritedFlags::paddingBottom):
(WebCore::InheritedFlags::paddingLeft):
(WebCore::InheritedFlags::paddingRight):
(WebCore::InheritedFlags::setLeft):
(WebCore::InheritedFlags::setRight):
(WebCore::InheritedFlags::setTop):
(WebCore::InheritedFlags::setBottom):
(WebCore::InheritedFlags::setDashboardRegion):
(WebCore::InheritedFlags::setClipLeft):
(WebCore::InheritedFlags::setClipRight):
(WebCore::InheritedFlags::setClipTop):
(WebCore::InheritedFlags::setClipBottom):
(WebCore::InheritedFlags::setMarginTop):
(WebCore::InheritedFlags::setMarginBottom):
(WebCore::InheritedFlags::setMarginLeft):
(WebCore::InheritedFlags::setMarginRight):
(WebCore::InheritedFlags::setPaddingTop):
(WebCore::InheritedFlags::setPaddingBottom):
(WebCore::InheritedFlags::setPaddingLeft):
(WebCore::InheritedFlags::setPaddingRight):
2008-10-20 Timothy Hatcher <timothy@apple.com>
Make the Resource panel perform graph updates atomically, so when resources
are added the graph and summary graph update at the same time.
https://bugs.webkit.org/show_bug.cgi?id=21755
Reviewed by Kevin McCullough.
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.get startTime): Return -1 if the _startTime
property is undefined, null or 0. This allows callers to check for -1 and not
the other values when there is no startTime yet.
(WebInspector.Resource.prototype.get responseReceivedTime): Ditto.
(WebInspector.Resource.prototype.get endTime): Ditto.
(WebInspector.Resource.prototype.get duration): Remove an extra empty line.
(WebInspector.Resource.prototype.get latency): Ditto.
(WebInspector.Resource.prototype.get contentLength): Return 0 if the _duration
property is undefined or null. This allows callers to always assume a number.
(WebInspector.Resource.prototype.get expectedContentLength): Ditto.
(WebInspector.Resource.prototype.get errors): Simplify the case where there is
no _errors property yet.
(WebInspector.Resource.prototype.set errors): Remove the check if the new value
if the same as the previous value, since there is no work to guard.
(WebInspector.Resource.prototype.get warnings): Simplify the case where there is
no _warnings property yet.
(WebInspector.Resource.prototype.set warnings): Remove the check if the new value
if the same as the previous value, since there is no work to guard.
(WebInspector.Resource.CompareByResponseReceivedTime): Add cases for when the
responseReceivedTime is -1.
(WebInspector.Resource.CompareByEndTime): Add cases for when the endTime is -1.
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.get searchableViews): If a resource does not
have a _resourcesTreeElement yet, exclude it from the searchable views.
(WebInspector.ResourcesPanel.prototype.set calculator): Set _staleResource to _resources
and call refresh to refresh the entire graph.
(WebInspector.ResourcesPanel.prototype.set needsRefresh): Set a timeout if the panel
is visible that calls refresh.
(WebInspector.ResourcesPanel.prototype.refresh): Create the resource tree element and
graph for a resource if it hasn't been created yet. If the boundaries changed during
the first stale resource pass, do a full pass of all resources when updating the graphs.
(WebInspector.ResourcesPanel.prototype.reset): Remove the legend items.
(WebInspector.ResourcesPanel.prototype.addResource): Don't create the tree element and
graph, these are now created during the first refresh.
(WebInspector.ResourcesPanel.prototype.removeResource): Null check _resourcesTreeElement.
(WebInspector.ResourcesPanel.prototype.addMessageToResource): Ditto.
(WebInspector.ResourcesPanel.prototype.clearMessages): Ditto.
(WebInspector.ResourcesPanel.prototype.refreshResource): Remove most of the work, just
add the resource to the _staleResources and set needsRefresh.
(WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded): Null check
_resourcesTreeElement.
(WebInspector.ResourcesPanel.prototype._sortResourcesIfNeeded): Remove code to clear
the timeout used by the deleted _sortResourcesSoonIfNeeded. Remove call to removeChild
since the insertBefore call will do it if needed.
(WebInspector.ResourcesPanel.prototype._updateGraphDividersIfNeeded): Remove code to
clear the timeout used by the deleted _updateGraphDividersSoonIfNeeded.
(WebInspector.ResourcesPanel.prototype._updateSummaryGraph): Remove code to clear the
timeout used by the deleted _updateSummaryGraphSoon. No need to remove the totalLegendLabel,
since all the legend items are removed in one pass right before.
(WebInspector.ResourcesPanel.prototype._changeSortingFunction): Set the sortingFunction
before the calculator so the correct sortingFunction is there when a refresh happens.
(WebInspector.ResourceTimeCalculator.prototype.computeBarGraphPercentages): Set start to 0
when the startTime is -1, since that looks best visually. Also set middle and end
to the start and middle (respectfully) when startAtZero. This looks best visually.
(WebInspector.ResourceGraph): Start the graph as hidden until the first refresh.
(WebInspector.ResourceGraph.prototype.refresh): Remove the hidden class.
2008-10-20 David Hyatt <hyatt@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=21733
Make sure that the haveMetadata flag is set to true for generated images from image buffers, so that
no attempt is made to re-cache the frame from a non-existent image source.
Reviewed by Sam Weinig
* platform/graphics/cairo/ImageCairo.cpp:
(WebCore::BitmapImage::BitmapImage):
* platform/graphics/cg/ImageCG.cpp:
(WebCore::BitmapImage::BitmapImage):
2008-10-20 Dan Bernstein <mitz@apple.com>
Reviewed by John Sullivan.
- make hasARenderedDescendant() have internal linkage
* editing/CompositeEditCommand.cpp:
(WebCore::hasARenderedDescendant):
2008-10-20 Chris Fleizach <cfleizach@apple.com>
Reviewed by Jon Honeycutt
Fix a crash in Accessibility where a table section was being
referenced without first checking if it was null
https://bugs.webkit.org/show_bug.cgi?id=21721
Test: accessibility/table-nofirstbody.html
* page/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::addChildren):
2008-10-20 David Hyatt <hyatt@apple.com>
Avoid some stderr spew from CG by checking if we have a decoder yet in ImageSourceCG.
Reviewed by Darin Adler
* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::repetitionCount):
(WebCore::ImageSource::frameDurationAtIndex):
2008-10-20 Alp Toker <alp@nuanti.com>
Reviewed by Mark Rowe.
Fix the pthread conditionals in the FTP code to correctly define
threadsafe *_r functions on Windows. Partly fixes the GTK+/Win32
build.
* loader/FTPDirectoryDocument.cpp:
* loader/FTPDirectoryParser.cpp:
2008-10-20 David Hyatt <hyatt@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=21751
Convert checkboxes and radio buttons on OS X over to the new Theme API.
Reviewed by Adam Roben
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::mapFillSize):
* platform/Length.h:
(WebCore::LengthSize::LengthSize):
(WebCore::LengthSize::operator==):
(WebCore::LengthSize::width):
(WebCore::LengthSize::height):
(WebCore::LengthSize::setWidth):
(WebCore::LengthSize::setHeight):
* platform/Theme.h:
(WebCore::Theme::controlSize):
(WebCore::Theme::controlSupportsBorder):
(WebCore::Theme::controlSupportsPadding):
(WebCore::Theme::paint):
(WebCore::Theme::inflateControlPaintRect):
* platform/ThemeTypes.h:
(WebCore::):
* platform/mac/ThemeMac.h:
* platform/mac/ThemeMac.mm:
(WebCore::):
(WebCore::controlSizeForFont):
(WebCore::sizeFromFont):
(WebCore::setControlSize):
(WebCore::updateStates):
(WebCore::inflateRect):
(WebCore::checkboxSizes):
(WebCore::checkboxMargins):
(WebCore::checkboxSize):
(WebCore::checkbox):
(WebCore::paintCheckbox):
(WebCore::radioSizes):
(WebCore::radioMargins):
(WebCore::radioSize):
(WebCore::radio):
(WebCore::paintRadio):
(WebCore::ThemeMac::baselinePositionAdjustment):
(WebCore::ThemeMac::controlSize):
(WebCore::ThemeMac::controlSupportsBorder):
(WebCore::ThemeMac::controlSupportsPadding):
(WebCore::ThemeMac::inflateControlPaintRect):
(WebCore::ThemeMac::paint):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::calculateBackgroundSize):
* rendering/RenderObject.cpp:
(WebCore::mustRepaintFillLayers):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::baselinePosition):
(WebCore::RenderTheme::adjustRepaintRect):
(WebCore::RenderTheme::controlStatesForRenderer):
(WebCore::RenderTheme::isFocused):
* rendering/RenderTheme.h:
* rendering/RenderThemeMac.h:
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::adjustRepaintRect):
* rendering/style/FillLayer.cpp:
(WebCore::FillLayer::operator==):
2008-10-18 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Fixed https://bugs.webkit.org/show_bug.cgi?id=21735
Emit profiling instrumentation only if the Web Inspector's profiling
feature is enabled
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::supportsProfiling):
* bindings/js/JSDOMWindowBase.h: Implemented the interface for specifying
whether a target global object has the Web Inspector's profiling feature
enabled.
* inspector/JavaScriptDebugServer.cpp:
(WebCore::JavaScriptDebugServer::recompileAllJSFunctionsSoon):
(WebCore::JavaScriptDebugServer::didAddListener):
(WebCore::JavaScriptDebugServer::didRemoveListener):
* inspector/JavaScriptDebugServer.h: Exported an API for recompiling,
used by the Settings object.
* page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setDeveloperExtrasEnabled):
* page/Settings.h: Recompile when the developer menu is enabled/disabled
for the first time, to add/remove profiling hooks. In the future, with
better Web Inspector UI, we can do this on a page-by-page basis,
instead of a global basis.
2008-10-20 David Hyatt <hyatt@apple.com>
Move Length to platform/.
Reviewed by Adam Roben
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* platform/Length.cpp: Copied from rendering/Length.cpp.
* platform/Length.h: Copied from rendering/Length.h.
2008-10-20 Darin Adler <darin@apple.com>
- try to fix Qt build
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMetaMethod::connectGetter): Add asObject calls.
(JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter): Ditto.
2008-10-20 Darin Adler <darin@apple.com>
- try to fix Qt build
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtInstance::mark): Use JSValue* instead of JSValuePtr.
(JSC::Bindings::QtField::valueFromInstance): Ditto.
* bridge/qt/qt_instance.h: Ditto.
2008-10-20 Darin Adler <darin@apple.com>
- try to fix Tiger build
* bridge/objc/objc_instance.mm:
(ObjcInstance::invokeMethod): Add a const_cast to remove the unwanted
volatile qualifier.
(ObjcInstance::invokeDefaultMethod): Ditto.
(ObjcInstance::getValueOfUndefinedField): Ditto.
* bridge/objc/objc_runtime.mm:
(JSC::Bindings::ObjcField::valueFromInstance): Ditto.
2008-10-20 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=21750
Eliminate the notion of "temporary events"
We mark some events as temporary when dispatching, for the sole reason of
manually calling forgetDOMObject when done dispatching.
There doesn't seem to be any reason to call it manually, as JSEvent destructor
will do this automatically right away.
* bindings/js/ScriptController.cpp:
* bindings/js/ScriptController.h:
Removed ScriptController::finishedWithEvent(), which was called after dispatching
a temporary event.
* dom/ContainerNode.cpp:
(WebCore::dispatchChildInsertionEvents):
(WebCore::dispatchChildRemovalEvents):
* dom/EventTarget.h:
* dom/EventTargetNode.cpp:
(WebCore::EventTargetNode::dispatchEvent):
(WebCore::EventTargetNode::dispatchGenericEvent):
(WebCore::EventTargetNode::dispatchSubtreeModifiedEvent):
(WebCore::EventTargetNode::dispatchWindowEvent):
(WebCore::EventTargetNode::dispatchUIEvent):
(WebCore::EventTargetNode::dispatchKeyEvent):
(WebCore::EventTargetNode::dispatchMouseEvent):
(WebCore::EventTargetNode::dispatchWheelEvent):
(WebCore::EventTargetNode::dispatchWebKitAnimationEvent):
(WebCore::EventTargetNode::dispatchWebKitTransitionEvent):
(WebCore::EventTargetNode::dispatchEventForType):
(WebCore::EventTargetNode::dispatchProgressEvent):
(WebCore::EventTargetNode::dispatchStorageEvent):
* dom/EventTargetNode.h:
* dom/MessagePort.cpp:
(WebCore::MessagePort::dispatchMessages):
(WebCore::MessagePort::dispatchCloseEvent):
(WebCore::MessagePort::dispatchEvent):
* dom/MessagePort.h:
* editing/Editor.cpp:
(WebCore::Editor::dispatchCPPEvent):
(WebCore::dispatchEditableContentChangedEvents):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::ReplacementFragment):
* editing/TypingCommand.cpp:
(WebCore::TypingCommand::insertText):
* loader/appcache/DOMApplicationCache.cpp:
(WebCore::DOMApplicationCache::dispatchEvent):
(WebCore::DOMApplicationCache::callListener):
* loader/appcache/DOMApplicationCache.h:
* page/EventHandler.cpp:
(WebCore::EventHandler::dispatchDragEvent):
(WebCore::EventHandler::keyEvent):
(WebCore::EventHandler::handleTextInputEvent):
* page/FrameView.cpp:
(WebCore::FrameView::scheduleEvent):
(WebCore::FrameView::updateOverflowStatus):
(WebCore::FrameView::dispatchScheduledEvents):
* page/FrameView.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollToOffset):
(WebCore::RenderLayer::updateOverflowStatus):
* svg/SVGElement.cpp:
(WebCore::SVGElement::sendSVGLoadEventIfPossible):
* svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::dispatchEvent):
* svg/SVGElementInstance.h:
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::dispatchEvent):
(WebCore::XMLHttpRequest::dispatchReadyStateChangeEvent):
(WebCore::XMLHttpRequest::dispatchXMLHttpRequestProgressEvent):
* xml/XMLHttpRequest.h:
* xml/XMLHttpRequestUpload.cpp:
(WebCore::XMLHttpRequestUpload::dispatchEvent):
(WebCore::XMLHttpRequestUpload::dispatchXMLHttpRequestProgressEvent):
* xml/XMLHttpRequestUpload.h:
Don't pass the tempEvent boolean around.
2008-10-20 Alp Toker <alp@nuanti.com>
Remove unused includes only. Partial GTK+/Win build fix.
* platform/graphics/gtk/SimpleFontDataPango.cpp:
2008-10-20 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=21705
Implement Web Workers client-side API
The implementation is experimental, and disabled by default. It doesn't quite match the
published draft, being influenced by further WHATWG discussions.
This only implements the client-side API, and does not actually create any threads or
global contexts yet.
* DerivedSources.make: Added DedicatedWorker. SharedWorker is not implemented yet, as I'm
still not sure if having separate classes for these helps at all.
* WebCore.xcodeproj/project.pbxproj: Added new files.
* bindings/js/JSDOMWindowBase.cpp:
(jsDOMWindowBaseWorker):
(WebCore::JSDOMWindowBase::put):
(setJSDOMWindowBaseWorker):
Added window.Worker constructor. Moved JSXSLTProcessorConstructor.h include out of ifdef
to match prevailing style.
* bindings/js/JSDedicatedWorkerConstructor.cpp: Added.
* bindings/js/JSDedicatedWorkerConstructor.h: Added.
* bindings/js/JSDedicatedWorkerCustom.cpp: Added.
The implementation of event listeners are left custom intentionally, for easier implementation
of listeners that are not tied to any Document in the future.
* dom/DedicatedWorker.cpp: Added.
* dom/DedicatedWorker.h: Added.
* dom/DedicatedWorker.idl: Added.
Added an implementation that can only load requested scripts for now.
2008-10-19 Darin Adler <darin@apple.com>
Reviewed by Dan Bernstein.
- fix assertion seen when opening inspector
* bindings/js/JSQuarantinedObjectWrapper.cpp:
(WebCore::JSQuarantinedObjectWrapper::getOwnPropertySlot):
Removed unneeded asObject cast.
2008-10-19 Dan Bernstein <mitz@apple.com>
Rubber-stamped by Timothy Hatcher.
- remove empty directories and correct the MIME type of inspector images
* page/inspector: Removed.
* page/inspector/Images: Removed.
2008-10-19 Timothy Hatcher <timothy@apple.com>
Make the Web Inspector Resources panel open quicker and change graphs
faster. There was some accidental n^2 logic at fault when updating the
graph boundaries.
https://bugs.webkit.org/show_bug.cgi?id=21742
Reviewed by Darin Adler.
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.set calculator): Return early for
a null calculator. Remove the second argument passed to _refreshAllResources.
(WebInspector.ResourcesPanel.prototype.refresh): Call updateBoundaries on
the calculator for all the stale resources before calling refreshResource.
Pass true for the first argument of refreshResource to skip the boundary update.
(WebInspector.ResourcesPanel.prototype._updateGraphBoundariesIfNeeded): Remove
the second argument passed to _refreshAllResources.
(WebInspector.ResourcesPanel.prototype._refreshAllResourcesSoon): Remove the
skipSort argument since every passed true, and it would be bad to pass false.
(WebInspector.ResourcesPanel.prototype._refreshAllResources): Ditto. And if
skipBoundaryUpdate is false, call updateBoundaries on the calculator for all
the resources before calling refreshResource. Pass true for the first argument
of refreshResource to skip the boundary update.
2008-10-19 Timothy Hatcher <timothy@apple.com>
Visually distinguish resources that loaded from the memory cache.
https://bugs.webkit.org/show_bug.cgi?id=14279
Reviewed by Dan Bernstein.
* English.lproj/localizedStrings.js: New string.
* inspector/front-end/Images/timelineHollowPillBlue.png: Added.
* inspector/front-end/Images/timelineHollowPillGray.png: Added.
* inspector/front-end/Images/timelineHollowPillGreen.png: Added.
* inspector/front-end/Images/timelineHollowPillOrange.png: Added.
* inspector/front-end/Images/timelineHollowPillPurple.png: Added.
* inspector/front-end/Images/timelineHollowPillRed.png: Added.
* inspector/front-end/Images/timelineHollowPillYellow.png: Added.
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourceCalculator.prototype.computeBarGraphLabels):
Add the "(from cache)" suffix to the tooltip.
(WebInspector.ResourceTimeCalculator.prototype.computeBarGraphLabels):
Add the "(from cache)" suffix to the tooltip.
(WebInspector.ResourceGraph): Add the "resource-cached" class.
* inspector/front-end/inspector.css: New styles to make the timeline
bars use the hollow pill images.
2008-10-19 Timothy Hatcher <timothy@apple.com>
Update the scroll position in the Resources panel when loading
a new page or toggling on small resource rows.
https://bugs.webkit.org/show_bug.cgi?id=20114
Reviewed by Darin Adler.
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.reset): Scroll to the top,
since all the resource are being removed.
(WebInspector.ResourcesPanel.prototype.removeResource): Call
_adjustScrollPosition in case the view is shorter and needs scrolled.
(WebInspector.ResourcesPanel.prototype._toggleLargerResources): Ditto.
(WebInspector.ResourcesPanel.prototype._adjustScrollPosition): Check
the height of the sidebar against the scrollTop and height of the
resourcesContainerElement. If the sidebar is shorter, scroll up
so the last resource is at the bottom again.
2008-10-19 Timothy Hatcher <timothy@apple.com>
Show per resource times and sizes when hovering over the bar graph for a resource.
https://bugs.webkit.org/show_bug.cgi?id=14300
rdar://problem/5712802
Reviewed by Cameron Zwarich.
* English.lproj/localizedStrings.js: Add new strings.
* inspector/front-end/Images/graphLabelCalloutLeft.png: Added.
* inspector/front-end/Images/graphLabelCalloutRight.png: Added.
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.refreshResource): Pass the calculator to the
ResourceGraph.refresh function.
(WebInspector.ResourceCalculator.prototype.computeBarGraphLabels): Default implementation
returns the formatted value.
(WebInspector.ResourceTimeCalculator.prototype.computeBarGraphLabels): Return discrete values
for the latency and download times. Also generate a custom tooltip.
(WebInspector.ResourceGraph): Add a mouseover event listener that calls refreshLabelPositions.
(WebInspector.ResourceGraph.prototype.refreshLabelPositions): Added. Updates the label positions
in case the bar has changed size.
(WebInspector.ResourceGraph.prototype.refresh): Set the label text and tooltips.
* inspector/front-end/inspector.css: New styles for the labels.
2008-10-19 Darin Adler <darin@apple.com>
Reviewed by Oliver Hunt.
- next step of https://bugs.webkit.org/show_bug.cgi?id=21732
improve performance by eliminating JSValue as a base class for JSCell
Remove most uses of JSValue, which will be removed in a future patch.
* bindings/js/JSCustomXPathNSResolver.h: Removed declaration of JSValue
and used JSValuePtr instead.
* bindings/js/JSEventTarget.h: Ditto.
* bindings/js/JSNodeFilterCondition.h: Ditto.
* bindings/js/ScheduledAction.h: Ditto.
* bindings/js/ScriptController.h: Ditto.
* bindings/objc/WebScriptObjectPrivate.h: Ditto.
* bridge/c/c_utility.h: Ditto.
* bridge/jni/jni_jsobject.h: Ditto.
* bridge/jni/jni_utility.h: Ditto.
* bridge/objc/WebScriptObject.h: Ditto.
* dom/Traversal.h: Ditto.
* inspector/InspectorController.cpp: Ditto.
* inspector/JavaScriptProfile.h: Ditto.
* inspector/JavaScriptProfileNode.h: Ditto.
* loader/FrameLoader.h: Ditto.
* page/Console.h: Ditto.
* plugins/MimeTypeArray.h: Ditto.
* plugins/Plugin.h: Ditto.
* plugins/PluginArray.h: Ditto.
* plugins/PluginView.cpp:
(WebCore::getString): Ditto.
(WebCore::PluginView::performRequest): Ditto.
* plugins/gtk/PluginViewGtk.cpp: Ditto.
* plugins/qt/PluginViewQt.cpp: Ditto.
* plugins/win/PluginViewWin.cpp: Ditto.
* bridge/qt/qt_class.cpp:
(JSC::Bindings::QtClass::fallbackObject): Use JSValuePtr and JSObject*
instead of JSValue*.
* bridge/qt/qt_class.h: Ditto.
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtInstance::mark): Ditto.
(JSC::Bindings::QtInstance::invokeMethod): Ditto.
(JSC::Bindings::QtInstance::defaultValue): Ditto.
(JSC::Bindings::QtInstance::stringValue): Ditto.
(JSC::Bindings::QtInstance::numberValue): Ditto.
(JSC::Bindings::QtInstance::booleanValue): Ditto.
(JSC::Bindings::QtInstance::valueOf): Ditto.
(JSC::Bindings::QtField::valueFromInstance): Ditto.
(JSC::Bindings::QtField::setValueToInstance): Ditto.
* bridge/qt/qt_instance.h: Ditto.
* bridge/qt/qt_runtime.cpp: Ditto.
(JSC::Bindings::valueRealType): Ditto.
(JSC::Bindings::convertValueToQVariant): Ditto.
(JSC::Bindings::convertQVariantToValue): Ditto.
(JSC::Bindings::findMethodIndex): Ditto.
(JSC::Bindings::QtRuntimeMetaMethod::call): Ditto.
(JSC::Bindings::QtRuntimeMetaMethod::lengthGetter): Ditto.
(JSC::Bindings::QtRuntimeMetaMethod::connectGetter): Ditto.
(JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter): Ditto.
(JSC::Bindings::QtRuntimeConnectionMethod::call): Ditto.
(JSC::Bindings::QtRuntimeConnectionMethod::lengthGetter): Ditto.
(JSC::Bindings::QtArray::setValueAt): Ditto.
(JSC::Bindings::QtArray::valueAt): Ditto.
* bridge/qt/qt_runtime.h: Ditto.
* bridge/testqtbindings.cpp:
(main): Use JSValuePtr.
2008-10-18 Darin Adler <darin@apple.com>
Reviewed by Oliver Hunt.
- next step of https://bugs.webkit.org/show_bug.cgi?id=21732
improve performance by eliminating JSValue as a base class for JSCell
Tweak a little more to get closer to where we can make JSValuePtr a class.
* bindings/js/JSAudioConstructor.cpp:
(WebCore::JSAudioConstructor::JSAudioConstructor): Use asObject.
(WebCore::constructAudio): Ditto.
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::nameGetter): Ditto.
* bindings/js/JSCanvasRenderingContext2DCustom.cpp:
(WebCore::toHTMLCanvasStyle): Use asString and asObject.
(WebCore::JSCanvasRenderingContext2D::setFillColor): Ditto.
(WebCore::JSCanvasRenderingContext2D::setStrokeColor): Ditto.
(WebCore::JSCanvasRenderingContext2D::drawImage): Ditto.
(WebCore::JSCanvasRenderingContext2D::drawImageFromRect): Ditto.
(WebCore::JSCanvasRenderingContext2D::setShadow): Ditto.
(WebCore::JSCanvasRenderingContext2D::createPattern): Ditto.
* bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
(WebCore::JSCustomSQLTransactionErrorCallback::handleEvent): Use JSValuePtr.
* bindings/js/JSDOMBinding.cpp:
(WebCore::setDOMException): Use noValue.
* bindings/js/JSDOMBinding.h:
(WebCore::getDOMPrototype): Use asObject.
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::showModalDialog): Use noValue.
(jsDOMWindowBaseEvent): Use asObject.
(jsDOMWindowBaseImage): Ditto.
(jsDOMWindowBaseMessageChannel): Ditto.
(jsDOMWindowBaseOption): Ditto.
(jsDOMWindowBaseXMLHttpRequest): Ditto.
(jsDOMWindowBaseAudio): Ditto.
(jsDOMWindowBaseXSLTProcessor): Ditto.
(WebCore::JSDOMWindowBase::childFrameGetter): Ditto.
(WebCore::JSDOMWindowBase::indexGetter): Ditto.
(WebCore::JSDOMWindowBase::namedItemGetter): Ditto.
(WebCore::JSDOMWindowBase::getOwnPropertySlot): Ditto.
(WebCore::JSDOMWindowBase::findJSEventListener): Ditto.
(WebCore::JSDOMWindowBase::findOrCreateJSEventListener): Ditto.
(WebCore::JSDOMWindowBase::findJSUnprotectedEventListener): Ditto.
(WebCore::JSDOMWindowBase::findOrCreateJSUnprotectedEventListener): Ditto.
(windowProtoFuncOpen): Use noValue.
(WebCore::toJSDOMWindow): Use asObject.
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::setTimeoutOrInterval): Use asString.
(WebCore::toDOMWindow): Use asObject.
* bindings/js/JSEventListener.cpp:
(WebCore::JSAbstractEventListener::handleEvent): Use noValue.
(WebCore::JSLazyEventListener::parseCode): Use asObject.
* bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::JSHTMLCollection::nameGetter): Use asObject.
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::nameGetter): Ditto.
* bindings/js/JSHTMLElementCustom.cpp:
(WebCore::JSHTMLElement::pushEventHandlerScope): Ditto.
* bindings/js/JSHTMLFormElementCustom.cpp:
(WebCore::JSHTMLFormElement::nameGetter): Ditto.
* bindings/js/JSHTMLFrameSetElementCustom.cpp:
(WebCore::JSHTMLFrameSetElement::nameGetter): Ditto.
* bindings/js/JSHTMLOptionElementConstructor.cpp:
(WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor): Ditto.
(WebCore::constructHTMLOptionElement): Ditto.
* bindings/js/JSHTMLOptionsCollectionCustom.cpp:
(WebCore::JSHTMLOptionsCollection::remove): Ditto.
* bindings/js/JSImageConstructor.cpp:
(WebCore::JSImageConstructor::JSImageConstructor): Ditto.
(WebCore::constructImage): Ditto.
* bindings/js/JSInspectedObjectWrapper.cpp:
(WebCore::JSInspectedObjectWrapper::wrap): Ditto.
* bindings/js/JSInspectorCallbackWrapper.cpp:
(WebCore::JSInspectorCallbackWrapper::wrap): Ditto.
* bindings/js/JSJavaScriptCallFrameCustom.cpp:
(WebCore::JSJavaScriptCallFrame::evaluate): Use noValue.
* bindings/js/JSMessageChannelConstructor.cpp:
(WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor): Use asObject.
(WebCore::JSMessageChannelConstructor::construct): Ditto.
* bindings/js/JSMimeTypeArrayCustom.cpp:
(WebCore::JSMimeTypeArray::nameGetter): Ditto.
* bindings/js/JSNamedNodeMapCustom.cpp:
(WebCore::JSNamedNodeMap::nameGetter): Ditto.
* bindings/js/JSNamedNodesCollection.cpp:
(WebCore::JSNamedNodesCollection::lengthGetter): Ditto.
(WebCore::JSNamedNodesCollection::indexGetter): Ditto.
* bindings/js/JSNodeFilterCustom.cpp:
(WebCore::toNodeFilter): Ditto.
* bindings/js/JSNodeListCustom.cpp:
(WebCore::JSNodeList::nameGetter): Ditto.
* bindings/js/JSPluginArrayCustom.cpp:
(WebCore::JSPluginArray::nameGetter): Ditto.
* bindings/js/JSPluginCustom.cpp:
(WebCore::JSPlugin::nameGetter): Ditto.
* bindings/js/JSPluginElementFunctions.cpp:
(WebCore::runtimeObjectGetter): Ditto.
(WebCore::runtimeObjectPropertyGetter): Ditto.
* bindings/js/JSQuarantinedObjectWrapper.cpp:
(WebCore::JSQuarantinedObjectWrapper::asWrapper): Ditto.
(WebCore::JSQuarantinedObjectWrapper::getOwnPropertySlot): Ditto.
(WebCore::JSQuarantinedObjectWrapper::construct): Ditto.
* bindings/js/JSRGBColor.cpp:
(jsRGBColorRed): Ditto.
(jsRGBColorGreen): Ditto.
(jsRGBColorBlue): Ditto.
* bindings/js/JSSQLResultSetRowListCustom.cpp:
(WebCore::JSSQLResultSetRowList::item): Use noValue.
* bindings/js/JSStorageCustom.cpp:
(WebCore::JSStorage::nameGetter): Use asObject.
(WebCore::JSStorage::deleteProperty): Ditto.
(WebCore::JSStorage::customPut): Ditto.
* bindings/js/JSStyleSheetListCustom.cpp:
(WebCore::JSStyleSheetList::nameGetter): Ditto.
* bindings/js/JSXMLHttpRequestConstructor.cpp:
(WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor): Ditto.
* bindings/js/JSXSLTProcessorCustom.cpp:
(WebCore::JSXSLTProcessor::importStylesheet): Ditto.
(WebCore::JSXSLTProcessor::transformToFragment): Ditto.
(WebCore::JSXSLTProcessor::transformToDocument): Ditto.
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::evaluate): Use noValue.
* bindings/objc/DOMInternal.mm:
(-[WebScriptObject _initializeScriptDOMNodeImp]): Ditto.
* bindings/objc/WebScriptObject.mm:
(-[WebScriptObject evaluateWebScript:]): Use JSValuePtr.
(-[WebScriptObject valueForKey:]): Ditto.
(-[WebScriptObject webScriptValueAtIndex:]): Ditto.
(+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
Use asObject and asString.
* bindings/scripts/CodeGeneratorJS.pm: Use asObject.
* bridge/c/c_instance.h: Use JSValuePtr.
* bridge/c/c_runtime.cpp:
(JSC::Bindings::CField::setValueToInstance): Ditto.
* bridge/c/c_utility.cpp:
(JSC::Bindings::convertValueToNPVariant): Use asObject.
* bridge/jni/jni_instance.cpp:
(JavaInstance::booleanValue): Use JSValuePtr.
(JavaInstance::invokeMethod): Ditto. And noValue.
* bridge/jni/jni_jsobject.mm:
(JavaJSObject::getSlot): Ditto.
(JavaJSObject::convertValueToJObject): Ditto.
* bridge/jni/jni_runtime.cpp:
(JavaField::dispatchValueFromInstance): Ditto.
(JavaField::valueFromInstance): Ditto.
(JavaField::dispatchSetValueToInstance): Ditto.
(JavaField::setValueToInstance): Ditto.
(JavaArray::setValueAt): Ditto.
(JavaArray::valueAt): Ditto.
* bridge/jni/jni_runtime.h: Ditto.
* bridge/jni/jni_utility.cpp:
(JSC::Bindings::convertArrayInstanceToJavaArray): Take a JSArray*
instead of a JSValue*.
(JSC::Bindings::convertValueToJValue): Use asObject and asArray.
* bridge/objc/objc_class.h: Use JSValuePtr.
* bridge/objc/objc_instance.h: Ditto.
* bridge/objc/objc_runtime.h: Ditto.
* bridge/objc/objc_runtime.mm:
(JSC::Bindings::callObjCFallbackObject): Use asObject.
* bridge/objc/objc_utility.h: Use JSValuePtr.
* bridge/objc/objc_utility.mm:
(JSC::Bindings::convertValueToObjcValue): Use JSValuePtr and asObject.
(JSC::Bindings::convertObjcValueToValue): Use jsUndefined() instead of 0.
* bridge/runtime.cpp:
(JSC::Bindings::Instance::getValueOfField): Use JSValuePtr.
(JSC::Bindings::Instance::setValueOfField): Ditto.
* bridge/runtime_array.cpp:
(JSC::RuntimeArray::lengthGetter): Use JSValuePtr and asObject.
(JSC::RuntimeArray::indexGetter): Ditto.
* bridge/runtime_array.h: Ditto.
* bridge/runtime_method.cpp:
(JSC::RuntimeMethod::lengthGetter): Ditto.
(JSC::callRuntimeMethod): Ditto.
* bridge/runtime_object.cpp:
(JSC::RuntimeObjectImp::fallbackObjectGetter): Ditto.
(JSC::RuntimeObjectImp::fieldGetter): Ditto.
(JSC::RuntimeObjectImp::methodGetter): Ditto.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::executeScript): Use noValue.
* page/Console.cpp:
(WebCore::Console::trace): Use asInternalFunction.
2008-10-19 Dan Bernstein <mitz@apple.com>
Reviewed by Timothy Hatcher.
- lower the default button repaint frequency
* rendering/RenderButton.cpp:
(WebCore::RenderButton::styleDidChange): Changed the timer interval from
0.01 to 0.03.
2008-10-18 Dan Bernstein <mitz@apple.com>
Reviewed by Mark Rowe.
- Windows build fix
* rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::paintMediaFullscreenButton):
(WebCore::RenderThemeSafari::paintMediaMuteButton):
(WebCore::RenderThemeSafari::paintMediaPlayButton):
(WebCore::RenderThemeSafari::paintMediaSeekBackButton):
(WebCore::RenderThemeSafari::paintMediaSeekForwardButton):
(WebCore::RenderThemeSafari::paintMediaSliderThumb):
2008-10-18 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig.
- WebCore part of https://bugs.webkit.org/show_bug.cgi?id=21736
Long-dead decoded image data make up for most of the object cache's memory use over time
Add a cache setting for how long decoded image data should be allowed to
persist in memory after the image has died. By default, this is set to
0, which means "forever".
* loader/Cache.cpp:
(WebCore::Cache::Cache): Initialize m_deadDecodedDataDeletionInterval.
* loader/Cache.h:
(WebCore::Cache::setDeadDecodedDataDeletionInterval): Added a setter.
(WebCore::Cache::deadDecodedDataDeletionInterval): Added a getter.
* loader/CachedImage.cpp:
(WebCore::CachedImage::CachedImage): Initialize the decoded data
deletion timer.
(WebCore::CachedImage::decodedDataDeletionTimerFired): Added. Destroys
the decoded image data.
(WebCore::CachedImage::addClient): Stop the timer if it is active.
(WebCore::CachedImage::allClientsRemoved): Start the decoded data
deletion timer.
* loader/CachedImage.h:
2008-10-18 Darin Adler <darin@apple.com>
Reviewed by Dan Bernstein.
- fix https://bugs.webkit.org/show_bug.cgi?id=21645
REGRESSION (r37469-r37605): File Input not Uploaded in Multipart/Form-data Form
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::formData):
Fix loop that goes through the FormDataList to go two at a time in a clearer
way. My last patch screwed up the way it got form content from the items.
This "two at a time" approach is a confusing way to do things, which explains
why I got it wrong last time through, but I decided to just fix it locally for
now rather than changing the design of FormDataList.
2008-10-18 Darin Adler <darin@apple.com>
Reviewed by Cameron Zwarich.
- next step on https://bugs.webkit.org/show_bug.cgi?id=21732
improve performance by eliminating JSValue as a base class for JSCell
Use JSValuePtr everywhere instead of JSValue*. In the future, we'll be
changing JSValuePtr to be a class, and then eventually renaming it
to JSValue once that's done.
* bindings/js/JSAttrCustom.cpp:
* bindings/js/JSCSSRuleCustom.cpp:
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
* bindings/js/JSCSSValueCustom.cpp:
* bindings/js/JSCanvasPixelArrayCustom.h:
* bindings/js/JSCanvasRenderingContext2DCustom.cpp:
* bindings/js/JSClipboardCustom.cpp:
* bindings/js/JSConsoleCustom.cpp:
* bindings/js/JSCustomSQLStatementCallback.cpp:
* bindings/js/JSCustomSQLStatementErrorCallback.cpp:
* bindings/js/JSCustomSQLTransactionCallback.cpp:
* bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
* bindings/js/JSCustomVoidCallback.cpp:
* bindings/js/JSCustomVoidCallback.h:
* bindings/js/JSCustomXPathNSResolver.cpp:
* bindings/js/JSDOMApplicationCacheCustom.cpp:
* bindings/js/JSDOMBinding.cpp:
* bindings/js/JSDOMBinding.h:
* bindings/js/JSDOMWindowBase.cpp:
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSDOMWindowCustom.cpp:
* bindings/js/JSDOMWindowCustom.h:
* bindings/js/JSDOMWindowShell.cpp:
* bindings/js/JSDOMWindowShell.h:
* bindings/js/JSDatabaseCustom.cpp:
* bindings/js/JSDocumentCustom.cpp:
* bindings/js/JSElementCustom.cpp:
* bindings/js/JSEventCustom.cpp:
* bindings/js/JSEventListener.cpp:
* bindings/js/JSEventTarget.cpp:
* bindings/js/JSEventTargetBase.h:
* bindings/js/JSEventTargetNodeCustom.cpp:
* bindings/js/JSHTMLAllCollection.h:
* bindings/js/JSHTMLAppletElementCustom.cpp:
* bindings/js/JSHTMLCollectionCustom.cpp:
* bindings/js/JSHTMLDocumentCustom.cpp:
* bindings/js/JSHTMLEmbedElementCustom.cpp:
* bindings/js/JSHTMLFormElementCustom.cpp:
* bindings/js/JSHTMLFrameElementCustom.cpp:
* bindings/js/JSHTMLFrameSetElementCustom.cpp:
* bindings/js/JSHTMLIFrameElementCustom.cpp:
* bindings/js/JSHTMLInputElementCustom.cpp:
* bindings/js/JSHTMLObjectElementCustom.cpp:
* bindings/js/JSHTMLOptionsCollectionCustom.cpp:
* bindings/js/JSHTMLSelectElementCustom.cpp:
* bindings/js/JSHTMLSelectElementCustom.h:
* bindings/js/JSHistoryCustom.cpp:
* bindings/js/JSImageDataCustom.cpp:
* bindings/js/JSInspectedObjectWrapper.cpp:
* bindings/js/JSInspectedObjectWrapper.h:
* bindings/js/JSInspectorCallbackWrapper.cpp:
* bindings/js/JSInspectorCallbackWrapper.h:
* bindings/js/JSJavaScriptCallFrameCustom.cpp:
* bindings/js/JSLocationCustom.cpp:
* bindings/js/JSMessagePortCustom.cpp:
* bindings/js/JSMimeTypeArrayCustom.cpp:
* bindings/js/JSNamedNodeMapCustom.cpp:
* bindings/js/JSNamedNodesCollection.cpp:
* bindings/js/JSNamedNodesCollection.h:
* bindings/js/JSNavigatorCustom.cpp:
* bindings/js/JSNodeCustom.cpp:
* bindings/js/JSNodeFilterCondition.cpp:
* bindings/js/JSNodeFilterCustom.cpp:
* bindings/js/JSNodeIteratorCustom.cpp:
* bindings/js/JSNodeListCustom.cpp:
* bindings/js/JSPluginArrayCustom.cpp:
* bindings/js/JSPluginCustom.cpp:
* bindings/js/JSPluginElementFunctions.cpp:
* bindings/js/JSPluginElementFunctions.h:
* bindings/js/JSQuarantinedObjectWrapper.cpp:
* bindings/js/JSQuarantinedObjectWrapper.h:
* bindings/js/JSRGBColor.cpp:
* bindings/js/JSRGBColor.h:
* bindings/js/JSSQLResultSetRowListCustom.cpp:
* bindings/js/JSSQLTransactionCustom.cpp:
* bindings/js/JSSVGElementInstanceCustom.cpp:
* bindings/js/JSSVGLengthCustom.cpp:
* bindings/js/JSSVGMatrixCustom.cpp:
* bindings/js/JSSVGPathSegCustom.cpp:
* bindings/js/JSSVGPathSegListCustom.cpp:
* bindings/js/JSSVGPointListCustom.cpp:
* bindings/js/JSSVGTransformListCustom.cpp:
* bindings/js/JSStorageCustom.cpp:
* bindings/js/JSStyleSheetCustom.cpp:
* bindings/js/JSStyleSheetListCustom.cpp:
* bindings/js/JSTextCustom.cpp:
* bindings/js/JSTreeWalkerCustom.cpp:
* bindings/js/JSXMLHttpRequestCustom.cpp:
* bindings/js/JSXMLHttpRequestUploadCustom.cpp:
* bindings/js/JSXSLTProcessorCustom.cpp:
* bindings/js/ScheduledAction.cpp:
* bindings/js/ScheduledAction.h:
* bindings/js/ScriptController.cpp:
* bindings/js/ScriptController.h:
* bindings/objc/WebScriptObject.mm:
* bindings/scripts/CodeGeneratorJS.pm:
* bridge/NP_jsobject.cpp:
* bridge/c/c_instance.cpp:
* bridge/c/c_instance.h:
* bridge/c/c_runtime.cpp:
* bridge/c/c_runtime.h:
* bridge/c/c_utility.cpp:
* bridge/jni/jni_instance.cpp:
* bridge/jni/jni_instance.h:
* bridge/jni/jni_jsobject.mm:
* bridge/jni/jni_objc.mm:
* bridge/jni/jni_runtime.cpp:
* bridge/jni/jni_runtime.h:
* bridge/jni/jni_utility.cpp:
* bridge/objc/objc_class.mm:
* bridge/objc/objc_instance.h:
* bridge/objc/objc_instance.mm:
* bridge/objc/objc_runtime.h:
* bridge/objc/objc_runtime.mm:
* bridge/objc/objc_utility.h:
* bridge/objc/objc_utility.mm:
* bridge/runtime.h:
* bridge/runtime_array.cpp:
* bridge/runtime_array.h:
* bridge/runtime_method.cpp:
* bridge/runtime_method.h:
* bridge/runtime_object.cpp:
* bridge/runtime_object.h:
* inspector/JavaScriptCallFrame.cpp:
* inspector/JavaScriptCallFrame.h:
* inspector/JavaScriptProfile.cpp:
* inspector/JavaScriptProfileNode.cpp:
* loader/FrameLoader.cpp:
* loader/FrameLoader.h:
* page/Console.cpp:
* page/Console.h:
* plugins/MimeTypeArray.h:
* plugins/Plugin.h:
* plugins/PluginArray.h:
* xml/XMLHttpRequest.cpp:
Replace JSValue* with JSValuePtr.
2008-10-18 Darin Adler <darin@apple.com>
Reviewed by Oliver Hunt.
- first step of https://bugs.webkit.org/show_bug.cgi?id=21732
improve performance by eliminating JSValue as a base class for JSCell
Update for change to make PreferredPrimitiveType no longer
a member of JSValue.
* bridge/c/c_instance.cpp:
(JSC::Bindings::CInstance::defaultValue): Removed JSValue:: prefix.
* bridge/jni/jni_instance.cpp:
(JavaInstance::defaultValue): Ditto.
* bridge/objc/objc_instance.mm:
(ObjcInstance::defaultValue): Ditto.
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtInstance::defaultValue): Ditto.
* bridge/runtime.h: Ditto. Also removed typedef.
2008-10-18 Darin Adler <darin@apple.com>
- try to fix Windows build
* rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::paintCheckbox): Explicitly qualify part name with
SafariTheme namespace, since there is now an identically named constant in
the ControlPart enum.
(WebCore::RenderThemeSafari::paintButton): Ditto.
(WebCore::RenderThemeSafari::paintTextField): Ditto.
(WebCore::RenderThemeSafari::paintTextArea): Ditto.
(WebCore::RenderThemeSafari::paintSearchField): Ditto.
(WebCore::RenderThemeSafari::paintSearchFieldCancelButton): Ditto.
(WebCore::RenderThemeSafari::paintSearchFieldResultsDecoration): Ditto.
(WebCore::RenderThemeSafari::paintSearchFieldResultsButton): Ditto.
2008-10-18 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Alp Toker.
[GTK] crash after selecting a file on an <input type=file>
https://bugs.webkit.org/show_bug.cgi?id=21385
Follow Mac and Win's behaviors for Icon::paint
* platform/graphics/gtk/IconGtk.cpp:
(WebCore::Icon::paint): check if painting is enabled before
painting the icon
2008-10-18 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Oliver Hunt.
Qt port build fix.
* platform/qt/RenderThemeQt.h:
2008-10-17 Kevin Watters <kevinwatters@gmail.com>
Reviewed by Kevin Ollivier
Fix wx port's scrollbar and drawing handling after recent changes.
https://bugs.webkit.org/show_bug.cgi?id=21720
* platform/ScrollView.h:
* platform/wx/ScrollViewWx.cpp:
(WebCore::ScrollView::platformVisibleContentRect):
(WebCore::ScrollView::platformContentsSize):
(WebCore::ScrollView::platformSetContentsSize):
* platform/wx/WidgetWx.cpp:
(WebCore::Widget::paint):
2008-10-17 Kevin Ollivier <kevino@theolliviers.com>
wx build fix. EAppearance -> ControlPart.
* platform/wx/RenderThemeWx.cpp:
(WebCore::RenderThemeWx::isControlStyled):
(WebCore::RenderThemeWx::adjustRepaintRect):
(WebCore::RenderThemeWx::controlSupportsTints):
(WebCore::RenderThemeWx::supportsFocus):
(WebCore::RenderThemeWx::paintButton):
2008-10-17 David Hyatt <hyatt@apple.com>
Eliminate the EAppearance enum in favor of the new ControlPart enum. Cut out the scrollbar
values from the enum since they are handled by ScrollbarTheme instead.
Reviewed by Tim Hatcher
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator ControlPart):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::adjustRenderStyle):
* css/CSSValueKeywords.in:
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::supportsFocus):
(WebCore::RenderThemeGtk::baselinePosition):
(WebCore::setToggleSize):
(WebCore::RenderThemeGtk::setCheckboxSize):
(WebCore::RenderThemeGtk::setRadioSize):
(WebCore::RenderThemeGtk::adjustButtonStyle):
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::baselinePosition):
(WebCore::RenderThemeQt::controlSupportsTints):
(WebCore::RenderThemeQt::adjustRepaintRect):
(WebCore::RenderThemeQt::isControlStyled):
(WebCore::computeSizeBasedOnStyle):
(WebCore::RenderThemeQt::paintButton):
(WebCore::RenderThemeQt::paintTextField):
(WebCore::RenderThemeQt::paintMenuList):
(WebCore::RenderThemeQt::supportsFocus):
(WebCore::RenderThemeQt::applyTheme):
(WebCore::RenderThemeQt::adjustSliderThumbSize):
* platform/qt/RenderThemeQt.h:
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::createThumbStyle):
(WebCore::RenderSlider::layout):
(WebCore::RenderSlider::setValueForPosition):
(WebCore::RenderSlider::setPositionFromValue):
(WebCore::RenderSlider::positionForOffset):
(WebCore::RenderSlider::currentPosition):
(WebCore::RenderSlider::setCurrentPosition):
(WebCore::RenderSlider::trackSize):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::paintBorderOnly):
(WebCore::RenderTheme::paintDecorations):
(WebCore::RenderTheme::isControlContainer):
(WebCore::RenderTheme::isControlStyled):
(WebCore::RenderTheme::supportsFocusRing):
(WebCore::RenderTheme::isDefault):
* rendering/RenderTheme.h:
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::isControlStyled):
(WebCore::RenderThemeMac::adjustRepaintRect):
(WebCore::RenderThemeMac::baselinePosition):
(WebCore::RenderThemeMac::controlSupportsTints):
(WebCore::RenderThemeMac::adjustButtonStyle):
(WebCore::RenderThemeMac::setButtonCellState):
(WebCore::RenderThemeMac::popupInternalPaddingLeft):
(WebCore::RenderThemeMac::popupInternalPaddingRight):
(WebCore::RenderThemeMac::popupInternalPaddingTop):
(WebCore::RenderThemeMac::popupInternalPaddingBottom):
(WebCore::RenderThemeMac::paintSliderTrack):
(WebCore::RenderThemeMac::paintSliderThumb):
(WebCore::RenderThemeMac::adjustSliderThumbSize):
* rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::isControlStyled):
(WebCore::RenderThemeSafari::adjustRepaintRect):
(WebCore::RenderThemeSafari::baselinePosition):
(WebCore::RenderThemeSafari::controlSupportsTints):
(WebCore::RenderThemeSafari::adjustButtonStyle):
(WebCore::RenderThemeSafari::popupInternalPaddingLeft):
(WebCore::RenderThemeSafari::popupInternalPaddingRight):
(WebCore::RenderThemeSafari::popupInternalPaddingTop):
(WebCore::RenderThemeSafari::popupInternalPaddingBottom):
(WebCore::RenderThemeSafari::paintSliderTrack):
(WebCore::RenderThemeSafari::adjustSliderThumbSize):
* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::supportsFocus):
(WebCore::RenderThemeWin::determineClassicState):
(WebCore::RenderThemeWin::getClassicThemeData):
(WebCore::RenderThemeWin::getThemeData):
(WebCore::drawControl):
(WebCore::RenderThemeWin::paintSliderTrack):
(WebCore::RenderThemeWin::adjustSliderThumbSize):
* rendering/RenderThemeWin.h:
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::hasAppearance):
(WebCore::InheritedFlags::appearance):
(WebCore::InheritedFlags::setAppearance):
(WebCore::InheritedFlags::initialAppearance):
* rendering/style/RenderStyleConstants.h:
2008-10-17 David Hyatt <hyatt@apple.com>
Beginning of the RenderTheme re-architecture (to share more code). Add the new Theme API header
file. Add new USE(NEW_THEME) switch that is enabled on Mac. The Mac theme will be converted first.
Reviewed by Tim Hatcher
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* config.h:
* platform/Theme.h: Added.
(WebCore::Theme::Theme):
(WebCore::Theme::~Theme):
(WebCore::Theme::baselinePositionAdjustment):
(WebCore::Theme::controlHasInactiveAppearance):
(WebCore::Theme::controlsCanHaveInactiveAppearance):
(WebCore::Theme::controlsCanHaveHoveredAppearance):
(WebCore::Theme::controlDrawsBorder):
(WebCore::Theme::controlDrawsBackground):
(WebCore::Theme::controlDrawsFocusOutline):
(WebCore::Theme::selectionColor):
(WebCore::Theme::textSearchHighlightColor):
(WebCore::Theme::systemColor):
(WebCore::Theme::systemFont):
(WebCore::Theme::caretBlinkFrequency):
(WebCore::Theme::themeChanged):
(WebCore::Theme::controlSize):
(WebCore::Theme::controlFont):
(WebCore::Theme::controlPadding):
(WebCore::Theme::controlInternalPadding):
(WebCore::Theme::controlBorder):
(WebCore::Theme::controlBorderRadius):
(WebCore::Theme::paint):
(WebCore::Theme::inflateControlPaintRect):
* platform/ThemeTypes.h: Added.
(WebCore::):
(WebCore::ControlBox::ControlBox):
(WebCore::ControlBox::top):
(WebCore::ControlBox::right):
(WebCore::ControlBox::bottom):
(WebCore::ControlBox::left):
* platform/mac/ThemeMac.h: Added.
(WebCore::ThemeMac::ThemeMac):
(WebCore::ThemeMac::~ThemeMac):
* platform/mac/ThemeMac.mm: Added.
(WebCore::platformTheme):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::RenderTheme):
* rendering/RenderTheme.h:
2008-10-17 Marco Barisione <marco.barisione@collabora.co.uk>
Reviewed by Sam Weinig. Landed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=21603
[GTK] Minor fixes to GOwnPtr
* platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mediaPlayerPrivateErrorCallback):
2008-10-17 Timothy Hatcher <timothy@apple.com>
Recompile the JavaScript functions when removing any listener, so functions that are
not being debugged can resume normal speed again.
https://bugs.webkit.org/show_bug.cgi?id=21715
Reviewed by Geoffrey Garen.
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::globalExec): Changed an assert into an if check. This assert
was firing when closing the window and having the recompile fire after. This was an
overzelious assert now.
* inspector/JavaScriptDebugServer.cpp:
(WebCore::JavaScriptDebugServer::didRemoveListener): Start the recompile timer.
(WebCore::JavaScriptDebugServer::didRemoveLastListener): Removed the recompile timer start.
2008-10-17 Timothy Hatcher <timothy@apple.com>
Fixes a regression where starting a debugging session in
another Web Inspector window would not show any scripts.
Also only attach the debugger to only the required Pages.
https://bugs.webkit.org/show_bug.cgi?id=21708
Reviewed by Darin Adler.
* inspector/JavaScriptDebugServer.cpp:
(WebCore::JavaScriptDebugServer::addListener): Add an assert and
remove the call to willAddFirstListener(). Add a call to
didAddListener().
(WebCore::JavaScriptDebugServer::removeListener): Add an assert
and call to didRemoveListener().
(WebCore::JavaScriptDebugServer::pageCreated): Attach the debugger
if there is a listener interested in the new Page.
(WebCore::JavaScriptDebugServer::hasListenersInterestedInPage):
Use hasGlobalListeners() instead of isEmpty().
(WebCore::JavaScriptDebugServer::sourceParsed): Ditto.
(WebCore::JavaScriptDebugServer::didAddListener): Added. Attach the
debugger to the page if non-null, or all pages if page is null.
(WebCore::JavaScriptDebugServer::didRemoveListener): Added. Detach
the debugger only if there are no interested listeners.
(WebCore::JavaScriptDebugServer::didRemoveLastListener): Remove the
call to Page::setDebuggerForAllPages().
* inspector/JavaScriptDebugServer.h:
(WebCore::JavaScriptDebugServer::hasGlobalListeners): Added.
2008-10-15 Brett Wilson <brettw@chromium.org>
Reviewed by Timothy Hatcher.
Have ImageDocument generate its own filename for the title of images
without relying on the suggested filename from the network layer, which
may be nonexistant or not relevant.
https://bugs.webkit.org/show_bug.cgi?id=21565
* loader/ImageDocument.cpp:
(WebCore::ImageTokenizer::finish):
2008-10-17 Alexey Proskuryakov <ap@webkit.org>
Non-Mac build fix.
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCoreSources.bkl:
Added ActiveDOMObject to the build.
2008-10-17 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=21642
Abstract out active object tracking
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMBinding.cpp:
(WebCore::markActiveObjectsForDocument):
* dom/ActiveDOMObject.cpp: Added.
(WebCore::ActiveDOMObject::ActiveDOMObject):
(WebCore::ActiveDOMObject::~ActiveDOMObject):
(WebCore::ActiveDOMObject::contextDestroyed):
(WebCore::ActiveDOMObject::stop):
* dom/ActiveDOMObject.h: Added.
(WebCore::ActiveDOMObject::document):
(WebCore::ActiveDOMObject::hasPendingActivity):
(WebCore::ActiveDOMObject::setPendingActivity):
(WebCore::ActiveDOMObject::unsetPendingActivity):
* dom/Document.cpp:
(WebCore::Document::~Document):
(WebCore::Document::stopActiveDOMObjects):
(WebCore::Document::createdActiveDOMObject):
(WebCore::Document::destroyedActiveDOMObject):
* dom/Document.h:
(WebCore::Document::activeDOMObjects):
* dom/MessagePort.cpp:
(WebCore::MessagePort::contextDestroyed):
* dom/MessagePort.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopLoading):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::~XMLHttpRequest):
(WebCore::XMLHttpRequest::associatedFrame):
(WebCore::XMLHttpRequest::responseXML):
(WebCore::XMLHttpRequest::callReadyStateChangeListener):
(WebCore::XMLHttpRequest::initSend):
(WebCore::XMLHttpRequest::send):
(WebCore::XMLHttpRequest::createRequest):
(WebCore::XMLHttpRequest::makeSimpleCrossSiteAccessRequest):
(WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
(WebCore::XMLHttpRequest::handleAsynchronousPreflightResult):
(WebCore::XMLHttpRequest::loadRequestSynchronously):
(WebCore::XMLHttpRequest::loadRequestAsynchronously):
(WebCore::XMLHttpRequest::dropProtection):
(WebCore::XMLHttpRequest::setRequestHeader):
(WebCore::XMLHttpRequest::processSyncLoadResults):
(WebCore::XMLHttpRequest::didFinishLoading):
(WebCore::XMLHttpRequest::didFinishLoadingPreflight):
(WebCore::XMLHttpRequest::willSendRequest):
(WebCore::XMLHttpRequest::accessControlCheck):
(WebCore::XMLHttpRequest::didReceiveResponsePreflight):
(WebCore::XMLHttpRequest::stop):
(WebCore::XMLHttpRequest::contextDestroyed):
* xml/XMLHttpRequest.h:
Move activity tracking to a new ActiveDOMObject class.
2008-10-16 David Hyatt <hyatt@apple.com>
Simplify styleForRenderer to avoid confusion. Callers in the SVG filter code thought "forRenderer" meant
they would be given a style that corresponded to the RenderObject* passed in. This is not what the code
did though. This patch removes the renderer argument and the Element subclass shadow implementation
so that confusion like this can't occur again.
Reviewed by Oliver Hunt
* dom/Element.cpp:
* dom/Element.h:
* dom/Node.cpp:
(WebCore::Node::createRendererIfNeeded):
(WebCore::Node::styleForRenderer):
* dom/Node.h:
* html/HTMLOptGroupElement.cpp:
(WebCore::HTMLOptGroupElement::attach):
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::attach):
* svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::canvasResource):
* svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::build):
* svg/SVGFEFloodElement.cpp:
(WebCore::SVGFEFloodElement::build):
* svg/SVGFESpecularLightingElement.cpp:
(WebCore::SVGFESpecularLightingElement::build):
* svg/SVGGradientElement.cpp:
(WebCore::SVGGradientElement::buildStops):
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::attachShadowTree):
2008-10-16 David Hyatt <hyatt@apple.com>
https://bugs.webkit.org/attachment.cgi?bugid=21647
Make RenderStyle inherit from RefCounted so that it works with RefPtr. RenderStyle was being malloced
out of the RenderArena. Years and years ago (before TCMalloc), the plan was to make RenderStyles and
all their associated sub-structs use the arena. However only the RenderStyle itself was ever changed
to use the arena.
At a later point style sharing was implemented, which made using the arena for styles pretty pointless,
as the bulk of the styles on a given page are actually shared. Not ever making the sub-structs use the
arena also limited the usefulness.
Now that we have RefPtr/PassRefPtr to eliminate manual ref/deref and now that we use TCMalloc for fast
mallocs, there is no reason to keep RenderStyles in the arena. The benefits of being able to eliminate
manual ref/deref far outweigh keeping them in the arena.
Reviewed by Adam Roben
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::~CSSStyleSelector):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::keyframeStylesForAnimation):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
These methods now return a PassRefPtr. They will null out the m_style variable as they hand it back
so that it isn't left pointing to the previous style resolve RenderStyle (which is what the old code did).
(WebCore::CSSStyleSelector::updateFont):
(WebCore::CSSStyleSelector::checkSelector):
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::mapFillSize):
(WebCore::CSSStyleSelector::mapFillXPosition):
(WebCore::CSSStyleSelector::mapFillYPosition):
* css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::style):
* dom/Document.cpp:
(WebCore::Document::recalcStyle):
* dom/Element.cpp:
(WebCore::Element::styleForRenderer):
(WebCore::Element::recalcStyle):
(WebCore::Element::computedStyle):
* dom/Element.h:
* dom/ElementRareData.h:
(WebCore::ElementRareData::ElementRareData):
(WebCore::ElementRareData::resetComputedStyle):
* dom/Node.cpp:
(WebCore::Node::diff):
(WebCore::Node::createRendererIfNeeded):
(WebCore::Node::styleForRenderer):
(WebCore::Node::setRenderStyle):
* dom/Node.h:
* html/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setFont):
* html/HTMLOptGroupElement.cpp:
(WebCore::HTMLOptGroupElement::attach):
(WebCore::HTMLOptGroupElement::detach):
(WebCore::HTMLOptGroupElement::setRenderStyle):
(WebCore::HTMLOptGroupElement::nonRendererRenderStyle):
* html/HTMLOptGroupElement.h:
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::attach):
(WebCore::HTMLOptionElement::detach):
(WebCore::HTMLOptionElement::setRenderStyle):
(WebCore::HTMLOptionElement::nonRendererRenderStyle):
* html/HTMLOptionElement.h:
* page/animation/AnimationBase.h:
(WebCore::AnimationBase::animate):
* page/animation/AnimationController.cpp:
(WebCore::AnimationController::updateAnimations):
* page/animation/AnimationController.h:
* page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimationPrivate::updateTransitions):
(WebCore::CompositeAnimationPrivate::updateKeyframeAnimations):
(WebCore::CompositeAnimationPrivate::animate):
(WebCore::CompositeAnimation::animate):
* page/animation/CompositeAnimation.h:
* page/animation/ImplicitAnimation.cpp:
(WebCore::ImplicitAnimation::ImplicitAnimation):
(WebCore::ImplicitAnimation::~ImplicitAnimation):
(WebCore::ImplicitAnimation::animate):
(WebCore::ImplicitAnimation::reset):
(WebCore::ImplicitAnimation::isTargetPropertyEqual):
(WebCore::ImplicitAnimation::blendPropertyValueInStyle):
* page/animation/ImplicitAnimation.h:
(WebCore::ImplicitAnimation::create):
* page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::KeyframeAnimation):
(WebCore::KeyframeAnimation::~KeyframeAnimation):
(WebCore::KeyframeAnimation::animate):
(WebCore::KeyframeAnimation::validateTransformFunctionList):
* page/animation/KeyframeAnimation.h:
(WebCore::KeyframeAnimation::create):
(WebCore::KeyframeAnimation::unanimatedStyle):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
* rendering/MediaControlElements.cpp:
(WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement):
(WebCore::MediaControlInputElement::MediaControlInputElement):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::updateFirstLetter):
* rendering/RenderContainer.cpp:
(WebCore::RenderContainer::addChild):
(WebCore::RenderContainer::updateBeforeAfterContentForContainer):
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::updateFromElement):
(WebCore::RenderFileUploadControl::createButtonStyle):
* rendering/RenderFileUploadControl.h:
* rendering/RenderFlow.cpp:
(WebCore::RenderFlow::createAnonymousFlow):
* rendering/RenderFlow.h:
* rendering/RenderInline.cpp:
(WebCore::RenderInline::addChildToFlow):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateScrollCornerStyle):
(WebCore::RenderLayer::updateResizerStyle):
(WebCore::RenderLayer::updateReflectionStyle):
* rendering/RenderListItem.cpp:
(WebCore::RenderListItem::styleDidChange):
* rendering/RenderMedia.cpp:
(WebCore::RenderMedia::createPanel):
(WebCore::RenderMedia::createTimeDisplay):
(WebCore::RenderMedia::changeOpacity):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::selectionBackgroundColor):
(WebCore::RenderObject::selectionForegroundColor):
(WebCore::RenderObject::createAnonymousBlock):
(WebCore::RenderObject::setAnimatableStyle):
(WebCore::RenderObject::setStyle):
(WebCore::RenderObject::setStyleInternal):
(WebCore::RenderObject::arenaDelete):
(WebCore::RenderObject::firstLineStyle):
(WebCore::RenderObject::getPseudoStyle):
* rendering/RenderObject.h:
(WebCore::RenderObject::style):
* rendering/RenderSVGBlock.cpp:
(WebCore::RenderSVGBlock::setStyle):
* rendering/RenderSVGBlock.h:
* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::getScrollbarPseudoStyle):
(WebCore::RenderScrollbar::updateScrollbarPart):
* rendering/RenderScrollbar.h:
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::styleDidChange):
(WebCore::RenderSlider::createThumbStyle):
(WebCore::RenderSlider::updateFromElement):
* rendering/RenderSlider.h:
* rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild):
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::addChild):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::addChild):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::styleDidChange):
(WebCore::RenderTextControl::createInnerBlockStyle):
(WebCore::RenderTextControl::createInnerTextStyle):
(WebCore::RenderTextControl::createResultsButtonStyle):
(WebCore::RenderTextControl::createCancelButtonStyle):
(WebCore::RenderTextControl::createSubtreeIfNeeded):
(WebCore::RenderTextControl::updatePlaceholderVisibility):
* rendering/RenderTextControl.h:
* rendering/TextControlInnerElements.cpp:
(WebCore::TextControlInnerElement::attachInnerElement):
* rendering/TextControlInnerElements.h:
* rendering/style/KeyframeList.cpp:
(WebCore::KeyframeList::clear):
(WebCore::KeyframeList::operator==):
(WebCore::KeyframeList::insert):
* rendering/style/KeyframeList.h:
(WebCore::KeyframeValue::KeyframeValue):
(WebCore::KeyframeValue::~KeyframeValue):
(WebCore::KeyframeValue::key):
(WebCore::KeyframeValue::style):
* rendering/style/RenderStyle.cpp:
(WebCore::defaultStyle):
(WebCore::RenderStyle::create):
(WebCore::RenderStyle::createDefaultStyle):
(WebCore::RenderStyle::clone):
(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::getCachedPseudoStyle):
(WebCore::RenderStyle::addCachedPseudoStyle):
* rendering/style/RenderStyle.h:
(WebCore::):
(WebCore::InheritedFlags::operator!=):
* svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::canvasResource):
* svg/SVGGradientElement.cpp:
(WebCore::SVGGradientElement::buildStops):
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::resolveStyle):
* svg/SVGStyledElement.h:
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::recalcStyle):
(WebCore::SVGUseElement::attachShadowTree):
2008-10-16 Kenneth Russell <kenneth.russell@sun.com>
Reviewed and landed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=21587
NPN_PluginThreadAsyncCall does not work properly
* plugins/PluginMainThreadScheduler.cpp:
(WebCore::PluginMainThreadScheduler::dispatchCalls):
Make sure to set m_callPending to false once the queue has been cleared.
2008-10-15 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=21609
Make MessagePorts protect their peers across heaps
* dom/MessagePort.cpp:
(WebCore::MessagePort::MessagePort):
* dom/MessagePort.h:
(WebCore::MessagePort::setJSWrapperIsKnownToBeInaccessible):
(WebCore::MessagePort::jsWrapperIsKnownToBeInaccessible):
Track objects whose JS wrappers are no longer reachable in MessagePort. Unfortunately, this
means that the implementation object knows about JS bindings - but it is not possible to
access JS wrappers from another heap/thread.
* bindings/js/JSDOMBinding.cpp:
(WebCore::markCrossHeapDependentObjectsForDocument):
* bindings/js/JSDOMBinding.h:
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::markCrossHeapDependentObjects):
* bindings/js/JSDOMWindowBase.h:
Implement cross-heap dependency tracking for entangled MessagePorts. If a wrapper object
hasn't been marked normally, it is marked as inaccessible. It is then marked manually,
as long as its entangled port is accessible itself.
2008-10-15 Jon Honeycutt <jhoneycutt@apple.com>
Remove unneeded check of whether a Page defers loading before running it
in a modal dialog.
No test possible.
Reviewed by Tim Hatcher.
* page/Chrome.cpp:
2008-10-15 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Fixed https://bugs.webkit.org/show_bug.cgi?id=21345
Start the debugger without reloading the inspected page
* WebCore.base.exp: New symbols.
* ForwardingHeaders/kjs/CollectorHeapIterator.h: Copied from ForwardingHeaders/kjs/ustring.h.
* ForwardingHeaders/kjs/Parser.h: Copied from ForwardingHeaders/kjs/ustring.h.
* WebCore.xcodeproj/project.pbxproj: New forwarding headers.
* inspector/InspectorController.cpp:
(WebCore::InspectorController::setWindowVisible):
(WebCore::InspectorController::windowScriptObjectAvailable):
(WebCore::InspectorController::startDebugging):
* inspector/InspectorController.h: Renamed startDebuggingAndReloadInspectedPage
to startDebugging, and changed its behavior to match.
* inspector/JavaScriptDebugListener.h:
* inspector/JavaScriptDebugServer.cpp:
(WebCore::JavaScriptDebugServer::JavaScriptDebugServer):
(WebCore::JavaScriptDebugServer::addListener):
(WebCore::JavaScriptDebugServer::removeListener):
(WebCore::JavaScriptDebugServer::recompileAllJSFunctions):
(WebCore::JavaScriptDebugServer::willAddFirstListener):
(WebCore::JavaScriptDebugServer::didRemoveLastListener):
* inspector/JavaScriptDebugServer.h: Refactored the
JavaScriptDebugServer to centralize handling of adding the first listener
and removing the last. Then, added a feature to recompile all JS functions
in these cases. This allows us to dynamically add and remove hooks like
the debugger hooks without reloading the page.
* inspector/front-end/ScriptsPanel.js:
* English.lproj/localizedStrings.js: Updated for startDebuggingAndReloadInspectedPage =>
startDebugging rename. Removed all UI that claimed that starting the
debugger would reload the page.
2008-10-15 Adele Peterson <adele@apple.com>
Attempt to fix the Tiger build.
* platform/network/mac/ResourceHandleMac.mm:
2008-10-15 Holger Hans Peter Freyther <zecke@selfish.org>
Build fix attempt.
Try to fix static/non-static declaration of g_string_append_uri_escape
by renaming that string. Another look needs to be taken.
* platform/gtk/guriescape.c:
(_webcore_g_string_append_uri_escaped):
(_webcore_g_uri_escape_string):
2008-10-15 Holger Hans Peter Freyther <zecke@selfish.org>
Build fix.
m_animatingImageType is gone.
* platform/graphics/cairo/ImageCairo.cpp:
(WebCore::BitmapImage::BitmapImage):
2008-10-15 Jeff Cook <cookiecaper@gmail.com>
Reviewed by Holger Freyther.
Stop SIGSEGV when leaving a page with a Flash object by reordering
window destruction and plugin stop.
See https://bugs.webkit.org/show_bug.cgi?id=20779
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::stop):
2008-10-15 Adele Peterson <adele@apple.com>
Reviewed by Sam Weinig.
Implement didSendBodyData delegate method, and use older code path when that delegate doesn't exist.
* platform/network/ResourceHandle.h:
* platform/network/mac/FormDataStreamMac.mm: (WebCore::formRead):
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::didSendBodyDataDelegateExists):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::cancel):
(-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
(-[WebCoreResourceHandleAsDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]):
(-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]):
(-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]):
2008-10-15 Peter Kasting <pkasting@google.com>
Reviewed by David Hyatt.
Qt build bustage fix.
* platform/graphics/qt/StillImageQt.h:
(WebCore::StillImage::destroyDecodedData):
2008-10-15 David Hyatt <hyatt@apple.com>
Make sure scrollbar styles get deleted if they aren't assigned to a renderer.
Reviewed by Mark Rowe
* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::getScrollbarPseudoStyle):
(WebCore::RenderScrollbar::updateScrollbarPart):
2008-10-15 Peter Kasting <pkasting@google.com>
Reviewed by David Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=19663 (Second attempt)
Account for paint and timer lag when animating images. Also pretend
that images whose animations were paused (by becoming invisible)
continued to animate, by "catching up" to the correct frame when they're
shown again.
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::destroyDecodedData):
(WebCore::BitmapImage::cacheFrame):
(WebCore::BitmapImage::frameIsCompleteAtIndex):
(WebCore::BitmapImage::frameDurationAtIndex):
(WebCore::BitmapImage::frameHasAlphaAtIndex):
(WebCore::BitmapImage::repetitionCount):
(WebCore::BitmapImage::shouldAnimate):
(WebCore::BitmapImage::startAnimation):
(WebCore::BitmapImage::resetAnimation):
(WebCore::BitmapImage::advanceAnimation):
(WebCore::BitmapImage::internalAdvanceAnimation):
(WebCore::BitmapImage::notifyObserverAndTrimDecodedData):
* platform/graphics/BitmapImage.h:
(WebCore::FrameData::FrameData):
(WebCore::BitmapImage::):
* platform/graphics/GeneratedImage.h:
(WebCore::GeneratedImage::destroyDecodedData):
* platform/graphics/Image.h:
* platform/graphics/cairo/ImageCairo.cpp:
(WebCore::FrameData::clear):
(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::draw):
* platform/graphics/cg/ImageCG.cpp:
(WebCore::FrameData::clear):
(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::draw):
* platform/graphics/cg/PDFDocumentImage.h:
(WebCore::PDFDocumentImage::destroyDecodedData):
* platform/graphics/qt/ImageQt.cpp:
(WebCore::FrameData::clear):
(WebCore::BitmapImage::draw):
* platform/graphics/wx/ImageWx.cpp:
(WebCore::FrameData::clear):
(WebCore::BitmapImage::draw):
* svg/graphics/SVGImage.h:
(WebCore::SVGImage::destroyDecodedData):
2008-10-14 Maxime Britto <britto@apple.com>
Reviewed by Darin Adler, tweaked and landed by Beth.
* WebCore.base.exp: Exposes two functions to be able to create a
selection from a point on the screen. Also exposes the new
TextIterator::currentNode function.
* WebCore/editing/TextIterator.cpp:
(TextIterator::currentNode) : New function that returns the current
text node or NULL if there is no text node.
2008-10-15 Marco Barisione <marco.barisione@collabora.co.uk>
Reviewed by Holger Freyther.
http://bugs.webkit.org/show_bug.cgi?id=21211
[CURL] Upload doesn't work because cancel is called
FormDataStream::read returns 0 when retrieving data from the form
fails, but also when there is no more data to send. This means that
ResourceHandleManager::cancel is always called even when the data was
successfully sent.
Check if there are more elements in the form before calling
FormDataStream::read.
* platform/network/curl/FormDataStreamCurl.cpp:
(WebCore::FormDataStream::hasMoreElements):
* platform/network/curl/FormDataStreamCurl.h:
* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::readCallback):
2008-10-15 Marco Barisione <marco.barisione@collabora.co.uk>
Reviewed by Holger Freyther.
http://bugs.webkit.org/show_bug.cgi?id=20664
[GTK] File names are not always encodable in UTF-8
On Linux file names are just raw data and cannot always be directly
encoded in UTF-8 or in any other encodings, so we escape them before
storing the file name in a String and unescape them before passing
them to native functions handling files.
* GNUmakefile.am:
* platform/FileSystem.h:
* platform/gtk/FileChooserGtk.cpp:
(WebCore::stringByAdoptingFileSystemRepresentation):
(WebCore::FileChooser::basenameForWidth):
* platform/gtk/FileSystemGtk.cpp:
(WebCore::filenameToString):
(WebCore::filenameFromString):
(WebCore::filenameForDisplay):
(WebCore::fileExists):
(WebCore::deleteFile):
(WebCore::deleteEmptyDirectory):
(WebCore::getFileSize):
(WebCore::getFileModificationTime):
(WebCore::makeAllDirectories):
(WebCore::homeDirectoryPath):
(WebCore::pathGetFileName):
(WebCore::listDirectory):
* platform/gtk/KURLGtk.cpp:
(WebCore::KURL::fileSystemPath):
* platform/gtk/SharedBufferGtk.cpp:
(WebCore::SharedBuffer::createWithContentsOfFile):
* platform/gtk/guriescape.c: Added.
(is_valid):
(gunichar_ok):
(g_string_append_uri_escaped):
(_webcore_g_uri_escape_string):
* platform/gtk/guriescape.h: Added.
2008-10-15 Dirk Schulze <vbs85@gmx.de>
Reviewed by Eric Seidel.
- part of https://bugs.webkit.org/show_bug.cgi?id=20543
Moved gradient spread method out of SVG into the GraphicsContext.
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::spreadMethod):
(WebCore::GraphicsContext::setSpreadMethod):
* platform/graphics/GraphicsContext.h:
(WebCore::):
* platform/graphics/GraphicsContextPrivate.h:
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::applySpreadMethod):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::applySpreadMethod):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
* svg/GradientAttributes.h:
(WebCore::GradientAttributes::GradientAttributes):
(WebCore::GradientAttributes::spreadMethod):
(WebCore::GradientAttributes::setSpreadMethod):
* svg/SVGGradientElement.cpp:
(WebCore::SVGGradientElement::parseMappedAttribute):
* svg/SVGGradientElement.h:
* svg/SVGLinearGradientElement.cpp:
(WebCore::SVGLinearGradientElement::collectGradientProperties):
* svg/SVGRadialGradientElement.cpp:
(WebCore::SVGRadialGradientElement::collectGradientProperties):
* svg/graphics/SVGPaintServerGradient.cpp:
(WebCore::operator<<):
(WebCore::SVGPaintServerGradient::SVGPaintServerGradient):
(WebCore::SVGPaintServerGradient::spreadMethod):
(WebCore::SVGPaintServerGradient::setGradientSpreadMethod):
(WebCore::SVGPaintServerGradient::externalRepresentation):
* svg/graphics/SVGPaintServerGradient.h:
* svg/graphics/cairo/SVGPaintServerGradientCairo.cpp:
(WebCore::SVGPaintServerGradient::setup):
* svg/graphics/qt/SVGPaintServerGradientQt.cpp:
(WebCore::SVGPaintServerGradient::setup):
2008-10-09 Darin Fisher <darin@chromium.org>
Reviewed by Sam Weinig.
Make pan scrolling a platform configurable option
https://bugs.webkit.org/show_bug.cgi?id=21515
* page/EventHandler.cpp:
(WebCore::EventHandler::handleAutoscroll):
(WebCore::EventHandler::autoscrollTimerFired):
(WebCore::EventHandler::stopAutoscrollTimer):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::keyEvent):
2008-10-10 Darin Fisher <darin@chromium.org>
Reviewed by Darin Adler.
Add some PLATFORM(CHROMIUM) ifdefs to WebCore
https://bugs.webkit.org/show_bug.cgi?id=21511
* loader/FTPDirectoryDocument.cpp:
* loader/FTPDirectoryParser.cpp:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::finishedLoadingDocument):
* platform/ContextMenuItem.h:
* platform/Cursor.h:
* platform/DragData.h:
* platform/DragImage.h:
* platform/Pasteboard.h:
* platform/PlatformKeyboardEvent.h:
(WebCore::PlatformKeyboardEvent::isSystemKey):
* platform/PlatformMenuDescription.h:
* platform/PlatformMouseEvent.h:
* platform/PlatformWheelEvent.h:
* platform/PopupMenu.h:
* platform/ScrollView.h:
* platform/Widget.h:
* platform/network/NetworkStateNotifier.h:
2008-10-14 Chris Marrin <cmarrin@apple.com>
Reviewed by Darin Adler.
Fixed https://bugs.webkit.org/show_bug.cgi?id=21490
Optimize keyframe style sheet changes by avoiding styleSheetChanged()
Test: css3/change-keyframes.html
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::WebKitCSSKeyframesRule::append):
(WebCore::WebKitCSSKeyframesRule::deleteRule):
2008-10-14 David Hyatt <hyatt@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=21595
Clean up background and overflow propagation from the body to the viewport. Make it match the
latest CSS2.1 spec thinking.
Reviewed by Adam Roben
Added many tests at fast/body-propagation/. These are Simon Pieters' tests of propagation handling
(available at http://simon.html5.org/test/css/magic-body/).
* dom/Document.cpp:
(WebCore::Document::body):
* page/FrameView.cpp:
(WebCore::FrameView::layout):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::paintRootBoxDecorations):
(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::repaintLayerRectsForImage):
2008-10-14 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed and landed by Sam Weinig.
Due to change in spec (http://dev.w3.org/2006/webapi/selectors-api/#namespace),
remove NSResolver code, leaving only checking for selectors that need
NS resolution and throwing a coresponding error.
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* bindings/js/JSDocumentCustom.cpp:
* bindings/js/JSDocumentFragmentCustom.cpp:
* bindings/js/JSElementCustom.cpp:
* bindings/js/JSNSResolver.cpp: Removed.
* bindings/js/JSNSResolver.h: Removed.
* dom/Document.idl:
* dom/DocumentFragment.idl:
* dom/Element.idl:
* dom/NSResolver.h: Removed.
* dom/NSResolver.idl: Removed.
* dom/Node.h:
* dom/Node.cpp:
(WebCore::forEachTagSelector):
(WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()):
(WebCore::selectorNeedsNamespaceResolution):
(WebCore::Node::querySelector):
(WebCore::Node::querySelectorAll):
2008-10-14 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig (all but the FormDataListItem rename).
- https://bugs.webkit.org/show_bug.cgi?id=21593
Bug 21593: add multiple-file support to HTMLFormElement
* html/FormDataList.cpp: Removed appendFile since it's now inline.
Also took incorrect old copyrights off of this file that are left
over from when it was split.
* html/FormDataList.h: Ditto. Renamed FormDataListItem to Item and
made it a member of FormDataList. Changed it to hold a File object
instead of a path. And made its data members private. Changed
FormDataList::appendFile accordingly.
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::formData): Updated for above changes.
Removed the code that special-cases HTMLInputElement, because now
the FormDataListItem has everything we need. And if there are
multiple files, we'll get multiple list items for them.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::appendFormData): Changed the code for
<input type=file> to use File objects instead of path strings and
also to append multiple files if the file list has them.
2008-10-14 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Fix QtWebKit scrollbar painting errors
* platform/qt/ScrollbarThemeQt.cpp:
(WebCore::ScrollbarThemeQt::paint):
(WebCore::ScrollbarThemeQt::paintScrollCorner):
2008-10-14 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Fix scrollbar arrows for horizontal scrollbars
* platform/qt/ScrollbarThemeQt.cpp:
(WebCore::styleOptionSlider):
2008-10-14 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Use style-painter to draw scrollbars in ScrollbarThemeQt
This has the benefit of setting up the painter properly without
antialiasing and saving and restoring the brush. It also ensures
that we use the style of the QWebView over the QApplication style
if possible.
* platform/qt/RenderThemeQt.cpp:
(WebCore::StylePainter::StylePainter):
(WebCore::StylePainter::init):
* platform/qt/RenderThemeQt.h:
* platform/qt/ScrollbarThemeQt.cpp:
(WebCore::ScrollbarThemeQt::paint):
2008-10-13 David Hyatt <hyatt@apple.com>
Add support for CSS transitions on some SVG properties. This patch is intended to be a guideline
for how to add support for the rest.
Reviewed by Oliver Hunt
* page/animation/AnimationBase.cpp:
(WebCore::ensurePropertyMap):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::fillOpacity):
(WebCore::RenderStyle::setFillOpacity):
(WebCore::RenderStyle::strokeOpacity):
(WebCore::RenderStyle::setStrokeOpacity):
(WebCore::RenderStyle::floodOpacity):
(WebCore::RenderStyle::setFloodOpacity):
2008-10-13 David Hyatt <hyatt@apple.com>
<rdar://problem/6289712> REGRESSION(r37432-37490): Scroll bar is not drawn in Bookmark View, Preferences sheets.
Fix for disabled scrollbars not painting in Windows Safari. Make sure that the Windows theme
implements paintTrackBackground so that when the thumb is not present the track still paints.
Reviewed by Oliver Hunt
* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::paint):
* platform/win/ScrollbarThemeWin.cpp:
(WebCore::ScrollbarThemeWin::paintTrackBackground):
* platform/win/ScrollbarThemeWin.h:
2008-10-13 David Hyatt <hyatt@apple.com>
Fix over-invalidation of native scrollbars.
Reviewed by Oliver Hunt
* platform/Scrollbar.h:
(WebCore::Scrollbar::styleChanged):
* platform/mac/ScrollbarThemeMac.mm:
(+[ScrollbarPrefsObserver appearancePrefsChanged:]):
* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::styleChanged):
2008-10-13 Alp Toker <alp@nuanti.com>
Fix autotools dist build target by listing recently added header
files only. Not reviewed.
* GNUmakefile.am:
2008-10-13 Mark Rowe <mrowe@apple.com>
Reviewed by Brady Eidson.
Don't run a SQLite query on every iteration of the sync thread when the query
will touch a large portion of the icon database while performing no useful work.
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::writeToDatabase): Don't call checkForDanglingPageURLs unless
we modified the database.
(WebCore::IconDatabase::checkForDanglingPageURLs): Don't do any work in a release build
unless we've been asked to prune any dangling pageURLs that we find.
2008-10-13 Maciej Stachowiak <mjs@apple.com>
Rubber stamped by Mark Rowe.
- use gcc 4.2 when building with Xcode 3.1 or newer on Leopard, even though this is not the default
* Configurations/DebugRelease.xcconfig:
2008-10-13 David Hyatt <hyatt@apple.com>
Make dropdown lists on Windows work with CSS custom scrollbars.
Reviewed by Adele
* platform/PopupMenu.h:
(WebCore::PopupMenu::scrollbarCornerPresent):
* platform/PopupMenuClient.h:
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::show):
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::createScrollbar):
* rendering/RenderMenuList.h:
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::createScrollbar):
* rendering/RenderTextControl.h:
2008-10-13 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
<rdar://problem/6271864> Links from image maps not being included in AXLinkUIElements
Links from image maps were not being included in the web area's AXLinkUIElements attribute.
The position of image map links was being reported incorrectly and the parent-chain
hierarchy for image map links was incorrect because image map links did not have a reference
to their parent image.
Test: accessibility/document-links.html
* page/AccessibilityImageMapLink.cpp:
(WebCore::AccessibilityImageMapLink::parentObject):
(WebCore::AccessibilityImageMapLink::actionElement):
(WebCore::AccessibilityImageMapLink::elementRect):
* page/AccessibilityImageMapLink.h:
(WebCore::AccessibilityImageMapLink::setHTMLMapElement):
(WebCore::AccessibilityImageMapLink::setParent):
* page/AccessibilityObject.cpp:
* page/AccessibilityObject.h:
* page/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityParentForImageMap):
(WebCore::AccessibilityRenderObject::getDocumentLinks):
(WebCore::AccessibilityRenderObject::addChildren):
* page/AccessibilityRenderObject.h:
* page/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
2008-10-13 David Hyatt <hyatt@apple.com>
Make RenderListBox work with CSS scrollbars. Refactoring this code to support creation/destruction in
the same way RenderLayer does also fixes a bug where the PLT would assert on the next-to-last page (no
idea how to make a test case for that, though, since I couldn't repro without running the whole PLT).
Reviewed by Tim Hatcher
Added scrollbars/listbox-scrollbar-combinations.html
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::~RenderListBox):
(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::createScrollbar):
(WebCore::RenderListBox::destroyScrollbar):
(WebCore::RenderListBox::setHasVerticalScrollbar):
* rendering/RenderListBox.h:
2008-10-13 David Hyatt <hyatt@apple.com>
In order to always match the :corner-present pseudo-class properly, delay initial updating of
scrollbar styles until the layer has the scrollbars in its member variables.
Reviewed by Tim Hatcher
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setHasHorizontalScrollbar):
(WebCore::RenderLayer::setHasVerticalScrollbar):
* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::RenderScrollbar):
2008-10-13 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Fix for https://bugs.webkit.org/show_bug.cgi?id=21577
5 false positive StructureID leaks
In WebCore, we intentionally leak the common JSGlobalData which in turn
leaks 5 StructureIDs. Use the new JSGlobalData::createLeaked in order to
ignore the StructureIDs leaked within.
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::commonJSGlobalData):
2008-10-13 David Hyatt <hyatt@apple.com>
Add support for the :corner-present pseudoclass, which enables scrollbar pieces to change their
artwork based on whether there is a scrollbar corner present.
Reviewed by Tim Hatcher
* css/CSSSelector.cpp:
(WebCore::CSSSelector::extractPseudoType):
* css/CSSSelector.h:
(WebCore::CSSSelector::):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
* platform/ScrollView.cpp:
(WebCore::ScrollView::scrollbarCornerPresent):
* platform/ScrollView.h:
* platform/ScrollbarClient.h:
* rendering/RenderLayer.cpp:
(WebCore::cornerRect):
(WebCore::scrollCornerRect):
(WebCore::resizerCornerRect):
(WebCore::RenderLayer::scrollbarCornerPresent):
(WebCore::RenderLayer::setHasHorizontalScrollbar):
(WebCore::RenderLayer::setHasVerticalScrollbar):
* rendering/RenderLayer.h:
(WebCore::RenderLayer::horizontalScrollbar):
(WebCore::RenderLayer::verticalScrollbar):
* rendering/RenderListBox.h:
(WebCore::RenderListBox::scrollbarCornerPresent):
2008-10-13 David Hyatt <hyatt@apple.com>
Make resizers and scrollbar corners respect :window-inactive (one more bug fix and then Tim's master
test case for all this can land).
Reviewed by Tim Hatcher
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
(WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintOverflowControls):
(WebCore::RenderLayer::paintScrollCorner):
(WebCore::RenderLayer::paintResizer):
(WebCore::RenderLayer::styleChanged):
(WebCore::RenderLayer::updateScrollCornerStyle):
(WebCore::RenderLayer::updateResizerStyle):
* rendering/RenderLayer.h:
* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::paint):
* rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::paintIntoRect):
2008-10-13 David Hyatt <hyatt@apple.com>
Rework resizer and scroll corner painting so that custom resizers and scroll corners will paint
and invalidate properly as images load, etc.
Reviewed by Tim Hatcher
* rendering/RenderLayer.cpp:
(WebCore::cornerRect):
(WebCore::scrollCornerRect):
(WebCore::resizerCornerRect):
(WebCore::RenderLayer::positionOverflowControls):
(WebCore::RenderLayer::paintOverflowControls):
(WebCore::RenderLayer::paintScrollCorner):
(WebCore::RenderLayer::paintResizer):
(WebCore::RenderLayer::isPointInResizeControl):
(WebCore::RenderLayer::hitTestOverflowControls):
(WebCore::RenderLayer::styleChanged):
* rendering/RenderLayer.h:
* rendering/RenderObject.h:
(WebCore::RenderObject::setRect):
* rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::styleDidChange):
(WebCore::RenderScrollbarPart::imageChanged):
2008-10-13 Marco Barisione <marco.barisione@collabora.co.uk>
Reviewed by Darin Adler. Landed by Jan Alonzo.
WebKit GTK Port needs a smartpointer to handle g_free (GFreePtr?)
http://bugs.webkit.org/show_bug.cgi?id=20483
Start the conversion to use GOwnPtr and fix a memory leak.
* platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mediaPlayerPrivateErrorCallback):
2008-10-12 Jon Honeycutt <jhoneycutt@apple.com>
Windows build fix.
* loader/TextResourceDecoder.cpp:
2008-10-12 Darin Fisher <darin@chromium.org>
Reviewed by Darin Adler.
- fix https://bugs.webkit.org/show_bug.cgi?id=21229
Bug 21229: NetworkStateNotifier.h lacks a #include <windows.h> for PLATFORM(WIN)
* platform/network/NetworkStateNotifier.h: Add the #include.
2008-10-12 Darin Adler <darin@apple.com>
Based on work by Holger Freyther.
- part of https://bugs.webkit.org/show_bug.cgi?id=20953
Split WidthIterator into its own source file.
* GNUmakefile.am: Added new source files.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* WebCoreSources.bkl: Ditto.
* platform/graphics/Font.cpp: Use WidthIterator from its new place.
* platform/graphics/WidthIterator.cpp: Added.
* platform/graphics/WidthIterator.h: Added.
2008-10-12 Tony Chang <tony@chromium.org>
Reviewed by Sam Weinig.
- https://bugs.webkit.org/show_bug.cgi?id=21480
Remove duplicate definitions of MimeClassInfo and PluginInfo.
* plugins/PluginInfoStore.cpp: Added an include.
* plugins/PluginInfoStore.h: Removed struct declarations.
2008-10-12 Darin Adler <darin@apple.com>
Reviewed by Dan Bernstein.
- https://bugs.webkit.org/show_bug.cgi?id=21563
Bug 21563: platform Gradient class should not use the CSS parser
* platform/graphics/Gradient.cpp: Removed the overload of addColorStop
that accepts a CSS color string. That's handled in the DOM now, not here.
(WebCore::Gradient::addColorStop): Use getRGBA instead of having our own
copy of it here.
* platform/graphics/Gradient.h: More of the same. Tweak formatting a bit.
2008-10-12 Glenn Wilson <gwilson@google.com>
Reviewed by Darin Adler.
- https://bugs.webkit.org/show_bug.cgi?id=20461
Added feature to allow multi-line inputs into text fields.
HTMLInputElement would cut the set text at the first 'system' character,
so it would truncate at the first carriage return or newline.
This fix modifies that behavior to truncate at any non-space system character
but changes \r, \n, and \r\n to a single space.
Tests: editing/pasteboard/paste-multiline-text-input.html
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::constrainValue):
2008-10-12 Dirk Schulze <vbs85@gmx.de>
Reviewed by Eric Seidel.
- https://bugs.webkit.org/show_bug.cgi?id=20435
Added exception codes to canvas gradients to match current specification.
Tests: fast/canvas/gradient-addColorStop-with-invalid-color.html
fast/canvas/linearGradient-infinite-values.html
fast/canvas/radialGradient-infinite-values.html
* html/CanvasGradient.cpp:
(WebCore::CanvasGradient::addColorStop):
* html/CanvasGradient.h:
* html/CanvasGradient.idl:
* html/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::createLinearGradient):
(WebCore::CanvasRenderingContext2D::createRadialGradient):
* html/CanvasRenderingContext2D.h:
* html/CanvasRenderingContext2D.idl:
2008-10-12 Eric Roman <eroman@chromium.org>
- https://bugs.webkit.org/show_bug.cgi?id=20246
Implement RenderThemeWin::systemColor() to match Windows colors.
Reviewed by David Hyatt.
* rendering/RenderThemeWin.cpp:
(WebCore::cssValueIdToSysColorIndex):
(WebCore::RenderThemeWin::systemColor):
* rendering/RenderThemeWin.h:
2008-10-12 Aaron Bockover <abockover@novell.com>
Reviewed by Alp Toker.
Add version parsing for Flash, and the PluginQuirkDontSetNullWindowHandleOnDestroy
plugin quirk if Flash 10 or newer since at least in b218, setting a NULL window
handler on destroy crashes WebKit <https://bugs.webkit.org/show_bug.cgi?id=19859>
* plugins/gtk/PluginPackageGtk.cpp:
2008-10-12 Jonathon Jongsma <jonathon.jongsma@collabora.co.uk>
Reviewed by Oliver Hunt.
- https://bugs.webkit.org/show_bug.cgi?id=19331
<rdar://problem/5984433>: Drag and drop of links in edit mode violates assert in MoveSelectionCommand::doApply()
* page/DragController.cpp:
(WebCore::DragController::startDrag): When a link is dragged without any
text selected (note: for this to work, the EditableLinkBehavior setting must be
set to 'live' or 'default') and then dropped into an editable html document it
will eventually violate an ASSERT in MoveSelectionCommand that requires that there
is a selection. To prevent this, expand the selection to the enclosing anchor tag
when the drag begins.
2008-10-12 Darin Adler <darin@apple.com>
Reviewed by Mark Rowe.
- fix https://bugs.webkit.org/show_bug.cgi?id=21557
Bug 21557: REGRESSION: generated-layer-scrollbar-crash.html is crashing
* rendering/RenderObject.cpp:
(WebCore::RenderObject::getPseudoStyle): Keep walking up the parent chain
until we hit an Element. Nowadays, Node::isElementNode() is just as efficient
as RenderObject::isText(), and this guarantees that the node can be cast to
Element*, which is done just below. The reason this is hit is that RenderLayer
can call getPseudoStyle on a RenderView, which has the document as its
element() -- and a document is neither a Text node nor an Element. A loose
end is that this seems to mean you can't style the scrollbar corner or the
resizer on a RenderView. Hyatt may want to look into that later.
2008-10-12 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
- https://bugs.webkit.org/show_bug.cgi?id=21556
Bug 21556: non-ASCII digits are allowed in places where only ASCII should be
Tests: fast/dom/HTMLFontElement/size-attribute.html
fast/dom/HTMLInputElement/size-attribute.html
fast/dom/HTMLTableElement/cellpadding-attribute.html
* html/HTMLFontElement.cpp:
(WebCore::parseFontSizeNumber): Use isASCIIDigit instead of
Unicode::isDigit, since non-ASCII digits are not valid here.
* html/HTMLFontElement.h: Tweaked formatting a bit and removed
the unneeded destructor declaration.
* platform/text/String.cpp:
(WebCore::lengthOfCharactersAsInteger): Use isASCIIDigit instead
of Unicode::isDigit, since non-ASCII digits are not valid.
2008-10-12 Jungshik Shin <jshin@chromium.org>
Reviewed by Darin Adler.
Treat x-user-defined as windows-1252 for html files with meta charset
declaration to be compatible with Indian web sites.
( https://bugs.webkit.org/show_bug.cgi?id=18270 )
Test: fast/encoding/charset-xuser-defined.html
* loader/TextResourceDecoder.cpp:
(WebCore::TextResourceDecoder::setEncoding):
2008-10-12 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Remove unneeded forward declaration.
* platform/graphics/ImageBuffer.h:
2008-10-12 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Fix for https://bugs.webkit.org/show_bug.cgi?id=21560
Layering violation: String should not be responsible for creating Lengths
It was a layering violation for String to know haw to parse
into Lengths, LengthArrays, and CoordsArrays.
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::parseMappedAttribute):
* html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::parseMappedAttribute):
* platform/text/AtomicString.h:
(WebCore::AtomicString::percentage):
* platform/text/PlatformString.h:
* platform/text/String.cpp:
* platform/text/StringImpl.cpp:
* platform/text/StringImpl.h:
* rendering/Length.cpp: Added.
(WebCore::parseLength):
(WebCore::countCharacter):
(WebCore::newCoordsArray):
(WebCore::newLengthArray):
* rendering/Length.h:
(WebCore::LengthSize::LengthSize):
2008-10-12 Brad Garcia <bgarcia@google.com>
Reviewed by Darin Adler.
Interpret fractional percentage values for %MultiLength values.
Fix for https://bugs.webkit.org/show_bug.cgi?id=3591
Test: fast/frames/frame-length-fractional-percentage.html
* platform/text/StringImpl.cpp:
(WebCore::parseLength):
2008-10-12 Timothy Hatcher <timothy@apple.com>
Remember the expanded state of the rules in the Styles pane. So
collapsing a rule will persist across all the elements that have
that same rule. The same applies to Computed Style, so the Computed
Style rule is now collapsed by default. This should help lessen the
confusion on why Computed Style can't be edited (a common confusion.)
https://bugs.webkit.org/show_bug.cgi?id=21553
Reviewed by Darin Adler.
* inspector/front-end/PropertiesSection.js:
(WebInspector.PropertiesSection): Set the _expanded property directly,
instead of using the setter. Expanded is the default, so no work is needed.
This prevents calling StylesSidebarPane.collapse before object initialization
is complete.
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype.update): Check the Preferences object
for the expanded state of the StylePropertiesSection. Collapse computed style
by default and expand everything else.
(WebInspector.StylePropertiesSection): Make a semi unique identifier to be used
when remembering expanded state.
(WebInspector.StylePropertiesSection.prototype.expand): Set the expanded state
to true for this identifier in Preferences.styleRulesExpandedState. Don't remember
the state if the dontRememberState property is true.
(WebInspector.StylePropertiesSection.prototype.collapse): Set the expanded state
to false for this identifier in Preferences.styleRulesExpandedState.
* inspector/front-end/inspector.js:
(Preferences.styleRulesExpandedState): Initialize to an empty object.
2008-10-12 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Alp Toker.
[Gtk] Remove libWebCoreJS.la when doing make clean
https://bugs.webkit.org/show_bug.cgi?id=21544
Remove libWebCoreJS.la when doing a clean target
* GNUmakefile.am: add libWebCoreJS.la to CLEANFILES
2008-10-11 Alp Toker <alp@nuanti.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=20592
The focus ring is not shown while navigating on some pages
Fix drawFocusRing() so it doesn't depend on the current graphics
state, thus matching other platforms which already work this way.
This patch provides two code paths: one using straight Cairo and
one specialised for the GTK+ port with a more conventional appearance.
Also change focusRingColor() to return a null color, allowing the
focus ring to pick up the style's current color if it isn't overridden
with CSS.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawFocusRing):
* platform/gtk/TemporaryLinkStubs.cpp:
(WebCore::focusRingColor):
2008-10-11 Dan Bernstein <mitz@apple.com>
Rubber-stamped by Sam Weinig.
- change all internal callers to use Cache::evict() instead of remove()
* loader/Cache.cpp:
(WebCore::Cache::revalidateResource):
(WebCore::Cache::revalidationSucceeded):
(WebCore::Cache::pruneDeadResources):
(WebCore::Cache::setDisabled):
2008-10-11 David Hyatt <hyatt@apple.com>
Make sure invalidatePart knows how to invalidate the track and scrollbar backgrounds.
Reviewed by Tim Hatcher
* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::invalidatePart):
2008-10-11 David Hyatt <hyatt@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=21549 (regression in before/after track pieces).
Also fixed resizer positioning problems.
Reviewed by Tim Hatcher
* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::splitTrack):
(WebCore::ScrollbarThemeComposite::trackPosition):
(WebCore::ScrollbarThemeComposite::trackLength):
* platform/ScrollbarThemeComposite.h:
(WebCore::ScrollbarThemeComposite::constrainTrackRectToTrackPieces):
* rendering/RenderLayer.cpp:
(WebCore::scrollCornerRect):
(WebCore::RenderLayer::positionOverflowControls):
(WebCore::RenderLayer::paintOverflowControls):
(WebCore::RenderLayer::isPointInResizeControl):
(WebCore::RenderLayer::hitTestOverflowControls):
* rendering/RenderScrollbarTheme.cpp:
(WebCore::RenderScrollbarTheme::constrainTrackRectToTrackPieces):
* rendering/RenderScrollbarTheme.h:
2008-10-11 Alp Toker <alp@nuanti.com>
Reviewed by David Hyatt.
Implement release/retain for Widget GTK+.
* platform/Widget.cpp:
* platform/gtk/WidgetGtk.cpp:
(WebCore::Widget::~Widget):
(WebCore::Widget::releasePlatformWidget):
(WebCore::Widget::retainPlatformWidget):
2008-10-11 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig.
- rename WebCoreSetAlwaysUseATSU to WebCoreSetAlwaysUsesComplexTextCodePath
and add a corresponding getter; add the same functions on Windows
* WebCore.base.exp:
* platform/graphics/Font.cpp:
(WebCore::Font::setCodePath):
(WebCore::codePath):
(WebCore::Font::canUseGlyphCache):
* platform/graphics/Font.h:
* platform/mac/WebCoreTextRenderer.h:
* platform/mac/WebCoreTextRenderer.mm:
(WebCoreSetAlwaysUsesComplexTextCodePath):
(WebCoreAlwaysUsesComplexTextCodePath):
* platform/win/WebCoreTextRenderer.cpp:
(WebCore::WebCoreSetAlwaysUsesComplexTextCodePath):
(WebCore::WebCoreAlwaysUsesComplexTextCodePath):
* platform/win/WebCoreTextRenderer.h:
2008-10-11 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich.
Stop leaking the event parameter names. The protected strings were showing up
in the caches window after one use. No measurable performance loss.
* bindings/js/JSEventListener.cpp:
(WebCore::eventParameterName):
2008-10-11 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich.
Remove unused function getNodeEventListener.
* bindings/js/JSEventListener.cpp:
* bindings/js/JSEventListener.h:
2008-10-11 David Hyatt <hyatt@apple.com>
Add support for both positive and negative margins to tracks and track pieces.
Reviewed by Tim Hatcher
* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::paint):
(WebCore::ScrollbarThemeComposite::hitTest):
(WebCore::ScrollbarThemeComposite::splitTrack):
(WebCore::ScrollbarThemeComposite::trackPieceRects):
(WebCore::ScrollbarThemeComposite::trackPosition):
(WebCore::ScrollbarThemeComposite::trackLength):
* platform/ScrollbarThemeComposite.h:
(WebCore::ScrollbarThemeComposite::adjustTrackPieceRect):
* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::trackRect):
(WebCore::RenderScrollbar::trackPieceRectWithMargins):
* rendering/RenderScrollbar.h:
* rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::computeScrollbarWidth):
(WebCore::RenderScrollbarPart::computeScrollbarHeight):
* rendering/RenderScrollbarTheme.cpp:
(WebCore::RenderScrollbarTheme::adjustTrackPieceRect):
* rendering/RenderScrollbarTheme.h:
2008-10-10 David Hyatt <hyatt@apple.com>
Drop -webkit-scrollbar- from all the scrollbar pseudo-classes, since they are scoped to
the scrollbar pseudo-elements anyway.
Reviewed by Tim Hatcher
* css/CSSSelector.cpp:
(WebCore::CSSSelector::extractPseudoType):
* css/CSSSelector.h:
(WebCore::CSSSelector::):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
2008-10-10 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig.
- separate Cache::remove() into a private method and a public interface,
then make Cache::pruneDeadResources() use the private method.
* loader/Cache.cpp:
(WebCore::Cache::pruneDeadResources):
(WebCore::Cache::evict):
* loader/Cache.h:
(WebCore::Cache::remove):
2008-10-10 David Hyatt <hyatt@apple.com>
Fix a math error when splitting a vertical track. Clean up more of ScrollbarThemeComposite
now that the track pieces meet under the thumb.
Reviewed by Tim Hatcher
* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::paint):
(WebCore::ScrollbarThemeComposite::splitTrack):
2008-10-10 David Hyatt <hyatt@apple.com>
Make the track pieces of a scrollbar extend under the thumb (each gets half the thumb).
Reviewed by Tim Hatcher
* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::hitTest):
(WebCore::ScrollbarThemeComposite::splitTrack):
2008-10-10 David Hyatt <hyatt@apple.com>
Make sure specialized ::scrollbar rules are still triggering custom scrollbar creation.
Reviewed by Tim Hatcher
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::createScrollbar):
* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::createCustomScrollbar):
(WebCore::RenderScrollbar::RenderScrollbar):
(WebCore::RenderScrollbar::setParent):
(WebCore::RenderScrollbar::updateScrollbarParts):
(WebCore::RenderScrollbar::updateScrollbarPart):
* rendering/RenderScrollbar.h:
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::):
2008-10-10 David Hyatt <hyatt@apple.com>
Make sure scrollbar background images cause proper part invalidation to occur.
Reviewed by Tim Hatcher
* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::setHoveredPart):
(WebCore::RenderScrollbar::setPressedPart):
* rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::styleDidChange):
(WebCore::RenderScrollbarPart::imageChanged):
* rendering/RenderScrollbarPart.h:
2008-10-10 Simon Fraser <simon.fraser@apple.com>
Reviewed by Darin Adler
https://bugs.webkit.org/show_bug.cgi?id=21538
The blendFunc() for TransformOperations should never mess with the
operation lists by replacing some ops with identity, otherwise the lists
no longer match and transitions break.
Test: transitions/matched-transform-functions.html
* page/animation/AnimationBase.cpp:
(WebCore::blendFunc):
2008-10-10 Simon Fraser <simon.fraser@apple.com>
Reviewed by Darin Adler
https://bugs.webkit.org/show_bug.cgi?id=21537
Fix re-targetting a running transition; if the target property
changes, we do need to make a new ImplicitAnimation.
Test: transitions/retargetted-transition.html
* page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimationPrivate::updateTransitions):
2008-10-10 Oliver Hunt <oliver@apple.com>
Reviewed by Cameron Zwarich.
Part of <rdar://problem/6278147> Cannot stop a slow script -- Fix assertion.
When JS is terminated by the user choosing to stop a slow script
the exception toString method throws, yet the console logger does
not perform exception checks after logging. This leaves an
exception on the Machine, which in turn results in an assertion
failure next time we attempt to enter JS. The solution is just to
clear the exception state after attempting to record the exception.
* page/Console.cpp:
(WebCore::Console::reportException):
2008-10-10 David Hyatt <hyatt@apple.com>
Make textareas work with custom CSS scrollbars and resizers. Need to access the correct renderer
when looking for pseudo styles.
Reviewed by Tim Hatcher
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::createScrollbar):
(WebCore::RenderLayer::styleChanged):
2008-10-10 David Hyatt <hyatt@apple.com>
Add the ability to style the scroll corner and the resizer from CSS.
Reviewed by Tim Hatcher
* css/CSSSelector.cpp:
(WebCore::CSSSelector::extractPseudoType):
* css/CSSSelector.h:
(WebCore::CSSSelector::):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::~RenderLayer):
(WebCore::RenderLayer::paintOverflowControls):
(WebCore::RenderLayer::paintScrollCorner):
(WebCore::RenderLayer::paintResizer):
(WebCore::RenderLayer::styleChanged):
* rendering/RenderLayer.h:
* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::updateScrollbarPart):
(WebCore::RenderScrollbar::paintPart):
* rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::RenderScrollbarPart):
(WebCore::RenderScrollbarPart::paintIntoRect):
* rendering/RenderScrollbarPart.h:
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::):
2008-10-10 David Hyatt <hyatt@apple.com>
Make CSS scrollbars respect the OS setting regarding where buttons should be placed.
Reviewed by Sam Weinig
No test case possible, since the OS setting can vary.
* css/CSSSelector.cpp:
(WebCore::CSSSelector::extractPseudoType):
* css/CSSSelector.h:
(WebCore::CSSSelector::):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
* platform/Scrollbar.h:
(WebCore::Scrollbar::styleChanged):
* platform/mac/ScrollbarThemeMac.mm:
(+[ScrollbarPrefsObserver appearancePrefsChanged:]):
(WebCore::ScrollbarThemeMac::preferencesChanged):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::invalidateScrollbarRect):
* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::styleChanged):
(WebCore::RenderScrollbar::updateScrollbarPart):
* rendering/RenderScrollbar.h:
* rendering/RenderScrollbarTheme.h:
(WebCore::RenderScrollbarTheme::buttonsPlacement):
2008-10-10 Timothy Hatcher <timothy@apple.com>
Fixes a regression with input search fields, where the placeholder text
would not be updated when the value of the placeholder attribute changed.
https://bugs.webkit.org/show_bug.cgi?id=21521
Reviewed by Adele Peterson.
Test: fast/forms/search-placeholder-value-changed.html
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseMappedAttribute): Pass true for the
placeholderValueChanged parameter of updatePlaceholderVisibility.
(WebCore::HTMLInputElement::updatePlaceholderVisibility): Add parameter
for placeholderValueChanged that informs the method that the value changed.
* html/HTMLInputElement.h: Add the placeholderValueChanged to the
updatePlaceholderVisibility method. Made it default to false.
2008-10-10 David Hyatt <hyatt@apple.com>
Allow the track part to have negative margins so that it can slightly overlap buttons. This
is necessary to emulate the Aqua look in CSS.
Reviewed by Sam Weinig
* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::paint):
(WebCore::ScrollbarThemeComposite::hitTest):
* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::setHoveredPart):
(WebCore::RenderScrollbar::trackRect):
* rendering/RenderScrollbar.h:
* rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::computeScrollbarWidth):
(WebCore::RenderScrollbarPart::computeScrollbarHeight):
* rendering/RenderScrollbarTheme.cpp:
(WebCore::RenderScrollbarTheme::backButtonRect):
(WebCore::RenderScrollbarTheme::forwardButtonRect):
(WebCore::RenderScrollbarTheme::trackRect):
2008-10-10 David Hyatt <hyatt@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=21527
Make CSS scrollbars support :not, :hover and :active.
Reviewed by Adam Roben
Added WebCore/manual-tests/scrollbar-hover-active.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
(WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::autoscrollPressedPart):
(WebCore::Scrollbar::startTimerIfNeeded):
(WebCore::Scrollbar::setHoveredPart):
(WebCore::Scrollbar::setPressedPart):
(WebCore::Scrollbar::mouseMoved):
(WebCore::Scrollbar::mouseExited):
(WebCore::Scrollbar::mouseUp):
(WebCore::Scrollbar::mouseDown):
* platform/Scrollbar.h:
* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::setHoveredPart):
(WebCore::RenderScrollbar::setPressedPart):
(WebCore::RenderScrollbar::updateScrollbarParts):
(WebCore::pseudoForScrollbarPart):
(WebCore::RenderScrollbar::updateScrollbarPart):
* rendering/RenderScrollbar.h:
2008-10-10 Chris Marrin <cmarrin@apple.com>
Reviewed by Dan Bernstein.
Fix for https://bugs.webkit.org/show_bug.cgi?id=21025
CSS transition with duration=0 and delay=0 doesn't override ongoing transition
Test: transitions/interrupt-zero-duration.html
* page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::updateTransitions):
2008-10-10 Kevin Ollivier <kevino@theolliviers.com>
wx build fix. Add new scrollbar-related sources.
* WebCoreSources.bkl:
2008-10-10 David Hyatt <hyatt@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=21522
Support increment/decrement/start/end on scrollbars. Allows a fully functional scrollbar to be
created. (Just :hover/:active left to finish it up.)
Reviewed by Adam Roben
Added scrollbars/scrollbar-buttons.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
2008-10-10 David Hyatt <hyatt@apple.com>
Rename some pseudoclasses. Removing "-scrollbar-" from a bunch of the pseudoclasses. Renaming
back/forward to decrement/increment. Adding start/end pseudoclasses.
Reviewed by Eric Seidel
* css/CSSSelector.cpp:
(WebCore::CSSSelector::extractPseudoType):
* css/CSSSelector.h:
(WebCore::CSSSelector::):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
2008-10-10 David Hyatt <hyatt@apple.com>
Switch window-active to window-inactive, since that will work better as far as degrading in other
browsers.
Reviewed by Tim Hatcher
* css/CSSSelector.cpp:
(WebCore::CSSSelector::extractPseudoType):
* css/CSSSelector.h:
(WebCore::CSSSelector::):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
2008-10-09 Chris Marrin <cmarrin@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=21310
Redesigned how animation events are sent in order to get rid of
AnimationEventDispatcher. ImplicitAnimation and KeyframeAnimation
are now ref counted. While calling the event handler, I keep a
reference to this class to avoid it getting destroyed out from under me.
I also moved most of the functionality of CompositeAnimation to
and internal class (CompositeAnimationPrivate) to reduce the exposure
of the internals of the various animation classes.
We have several transition and animation LayoutTests which verify that
this fix works as expected and continues to avoid crashes.
* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::AnimationBase):
* page/animation/AnimationBase.h:
(WebCore::AnimationBase::cancelTimers):
(WebCore::AnimationBase::waitingForStyleAvailable):
* page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimationPrivate::CompositeAnimationPrivate):
(WebCore::CompositeAnimationPrivate::suspended):
(WebCore::CompositeAnimationPrivate::~CompositeAnimationPrivate):
(WebCore::CompositeAnimationPrivate::updateTransitions):
(WebCore::CompositeAnimationPrivate::updateKeyframeAnimations):
(WebCore::CompositeAnimationPrivate::animate):
(WebCore::CompositeAnimationPrivate::setAnimating):
(WebCore::CompositeAnimationPrivate::animating):
(WebCore::CompositeAnimationPrivate::getAnimationForProperty):
(WebCore::CompositeAnimationPrivate::resetTransitions):
(WebCore::CompositeAnimationPrivate::resetAnimations):
(WebCore::CompositeAnimationPrivate::cleanupFinishedAnimations):
(WebCore::CompositeAnimationPrivate::setAnimationStartTime):
(WebCore::CompositeAnimationPrivate::setTransitionStartTime):
(WebCore::CompositeAnimationPrivate::suspendAnimations):
(WebCore::CompositeAnimationPrivate::resumeAnimations):
(WebCore::CompositeAnimationPrivate::overrideImplicitAnimations):
(WebCore::CompositeAnimationPrivate::resumeOverriddenImplicitAnimations):
(WebCore::compareAnimationIndices):
(WebCore::CompositeAnimationPrivate::styleAvailable):
(WebCore::CompositeAnimationPrivate::isAnimatingProperty):
(WebCore::CompositeAnimationPrivate::setWaitingForStyleAvailable):
(WebCore::CompositeAnimation::CompositeAnimation):
(WebCore::CompositeAnimation::~CompositeAnimation):
(WebCore::CompositeAnimation::animate):
(WebCore::CompositeAnimation::animating):
(WebCore::CompositeAnimation::setWaitingForStyleAvailable):
(WebCore::CompositeAnimation::resetTransitions):
(WebCore::CompositeAnimation::suspendAnimations):
(WebCore::CompositeAnimation::resumeAnimations):
(WebCore::CompositeAnimation::suspended):
(WebCore::CompositeAnimation::styleAvailable):
(WebCore::CompositeAnimation::setAnimating):
(WebCore::CompositeAnimation::isAnimatingProperty):
(WebCore::CompositeAnimation::setAnimationStartTime):
(WebCore::CompositeAnimation::setTransitionStartTime):
(WebCore::CompositeAnimation::overrideImplicitAnimations):
(WebCore::CompositeAnimation::resumeOverriddenImplicitAnimations):
* page/animation/CompositeAnimation.h:
* page/animation/ImplicitAnimation.cpp:
(WebCore::ImplicitAnimation::sendTransitionEvent):
* page/animation/ImplicitAnimation.h:
(WebCore::ImplicitAnimation::create):
* page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::sendAnimationEvent):
* page/animation/KeyframeAnimation.h:
(WebCore::KeyframeAnimation::create):
2008-10-09 David Hyatt <hyatt@apple.com>
Add support for scrollbar orientation as a pseudoclass. Add support for whether or not the scrollbar
is active as well.
Reviewed by Tim Hatcher
Added scrollbars/scrollbar-orientation.html
* css/CSSSelector.cpp:
(WebCore::CSSSelector::extractPseudoType):
* css/CSSSelector.h:
(WebCore::CSSSelector::):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::isWindowActive):
* platform/Scrollbar.h:
* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::paint):
(WebCore::RenderScrollbar::partForStyleResolve):
* rendering/RenderScrollbar.h:
2008-10-09 David Hyatt <hyatt@apple.com>
Add support for pseudo classes on scrollbar pseudo elements. As an initial proof of concept only
:enabled/:disabled are supported. More pseudo classes will follow quickly now that this works.
Reviewed by Tim Hatcher
Added scrollbars/disabled-scrollbar.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
(WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
* css/CSSStyleSelector.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::getPseudoStyle):
* rendering/RenderObject.h:
* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::setEnabled):
(WebCore::RenderScrollbar::scrollbarForStyleResolve):
(WebCore::RenderScrollbar::getScrollbarPseudoStyle):
(WebCore::RenderScrollbar::paintPart):
* rendering/RenderScrollbar.h:
2008-10-09 Eric Carlson <eric.carlson@apple.com>
Media controls should not show when element is not visible
https://bugs.webkit.org/show_bug.cgi?id=21155
Reviewed by Adele Peterson.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::recalcStyle): New, call renderer()->updateFromElement to stay
in sync with visibility changes
* html/HTMLMediaElement.h:
* rendering/RenderMedia.cpp:
(WebCore::RenderMedia::RenderMedia): initialize m_previousVisible
(WebCore::RenderMedia::updateControlVisibility): consider style()->visibility() when determining
if element is visible or not. Don't animate controller visibility when change triggered by
showing or hiding media element.
* rendering/RenderMedia.h: declare m_previousVisible
2008-10-09 Timothy Hatcher <timothy@apple.com>
Annotate the Objective-C DOM APIs with the JavaScriptCore/WebKitAvailability.h
availability macros and version macros.
https://bugs.webkit.org/show_bug.cgi?id=21496
rdar://problem/6259225
Reviewed by Sam Weinig.
* bindings/objc/DOMCSS.h: Add a version #if around catgory interface.
* bindings/objc/DOMEventException.h: Include JavaScriptCore/WebKitAvailability.h
and add an #if around the enum.
* bindings/objc/DOMException.h: Ditto. Give the enum a name and remove the
comment to match the other headers.
* bindings/objc/DOMExtensions.h: Annotate the methods with version 3.0 or later.
* bindings/objc/DOMObject.h: Add a version #if around class interface.
* bindings/objc/DOMRangeException.h: Include JavaScriptCore/WebKitAvailability.h
and add a version #if around the enum.
* bindings/objc/DOMSVGException.h: Ditto. Use the latest version since SVG is new.
* bindings/objc/DOMXPathException.h: Ditto. Use the 3.0 version.
* bindings/objc/PublicDOMInterfaces.h: Annotate classes and protocols for
when they where added to WebKit. Also annotate individual methods that are
deprecated or where added after the class was added to WebKit.
* bindings/objc/WebScriptObject.h: Include JavaScriptCore/WebKitAvailability.h
since this header is included by most DOM headers. Annotate the JSObject method.
* bindings/scripts/CodeGeneratorObjC.pm:
(ReadPublicInterfaces): Parse out the availability macro for each function/property.
And parse out the availability version for the class/protocol. Default to
WEBKIT_VERSION_LATEST if the class is new.
(GenerateHeader): Include JavaScriptCore/WebKitAvailability.h if needed. Add the
interface availability version check if the class has a required version. Create
a public interface key (used to lookup in $publicInterfaces) and make a declaration
suffix that includes the availability macro (if needed). Use the "available in 1.3
and later but deprecated in 3.0" macro instead of "deprecated in 10.5 and later" as
the default availability macro for old style methods. Tweak line breaks in the generated
headers to look good and not have too many extra lines.
2008-10-09 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dave Hyatt
https://bugs.webkit.org/show_bug.cgi?id=20947
Refactor setStyle() methods into styleWillChange()
and styleDidChange(), so most of the setStyle() overrides can
be removed.
* rendering/RenderBR.cpp:
(WebCore::RenderBR::styleDidChange):
* rendering/RenderBR.h:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleWillChange):
(WebCore::RenderBlock::styleDidChange):
* rendering/RenderBlock.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::~RenderBox):
(WebCore::RenderBox::destroy):
(WebCore::RenderBox::styleWillChange):
(WebCore::RenderBox::styleDidChange):
* rendering/RenderBox.h:
* rendering/RenderButton.cpp:
(WebCore::RenderButton::styleWillChange):
(WebCore::RenderButton::styleDidChange):
* rendering/RenderButton.h:
* rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::styleDidChange):
* rendering/RenderFieldset.h:
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::styleDidChange):
* rendering/RenderFileUploadControl.h:
* rendering/RenderInline.cpp:
(WebCore::RenderInline::styleDidChange):
* rendering/RenderInline.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::styleChanged):
* rendering/RenderLayer.h:
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::styleDidChange):
* rendering/RenderListBox.h:
* rendering/RenderListItem.cpp:
(WebCore::RenderListItem::styleDidChange):
* rendering/RenderListItem.h:
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::styleWillChange):
(WebCore::RenderListMarker::styleDidChange):
* rendering/RenderListMarker.h:
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::styleDidChange):
* rendering/RenderMenuList.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::setStyle):
(WebCore::RenderObject::setStyleInternal):
(WebCore::RenderObject::styleWillChange):
(WebCore::RenderObject::styleDidChange):
* rendering/RenderObject.h:
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::styleDidChange):
* rendering/RenderReplaced.h:
* rendering/RenderSVGGradientStop.cpp:
(WebCore::RenderSVGGradientStop::styleDidChange):
* rendering/RenderSVGGradientStop.h:
* rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::styleDidChange):
* rendering/RenderScrollbarPart.h:
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::styleDidChange):
* rendering/RenderSlider.h:
* rendering/RenderTable.cpp:
(WebCore::RenderTable::styleDidChange):
* rendering/RenderTable.h:
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::styleWillChange):
(WebCore::RenderTableCell::styleDidChange):
* rendering/RenderTableCell.h:
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::styleWillChange):
* rendering/RenderTableRow.h:
* rendering/RenderText.cpp:
(WebCore::RenderText::styleDidChange):
* rendering/RenderText.h:
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::styleDidChange):
* rendering/RenderTextControl.h:
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::styleDidChange):
* rendering/RenderWidget.h:
2008-10-09 David Hyatt <hyatt@apple.com>
Make sure to destroy a custom scrollbar's RenderObjects before the arena goes away. When our widget
parent is nulled out is a good time.
Reviewed by Oliver Hunt
* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::~RenderScrollbar):
(WebCore::RenderScrollbar::setParent):
(WebCore::RenderScrollbar::updateScrollbarPart):
* rendering/RenderScrollbar.h:
2008-10-09 David Hyatt <hyatt@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=21446
This patch gets CSS scrollbars up and limping. There's no way to distinguish between states or between
orientation and back vs. forward on the buttons, but it's a start.
Reviewed by Oliver Hunt
Added scrollbars/basic-scrollbar.html
* WebCore.xcodeproj/project.pbxproj:
* css/CSSSelector.cpp:
(WebCore::CSSSelector::extractPseudoType):
* css/CSSSelector.h:
(WebCore::CSSSelector::):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
* platform/ScrollTypes.h:
(WebCore::):
* platform/Scrollbar.h:
(WebCore::Scrollbar::styleChanged):
* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::paint):
(WebCore::ScrollbarThemeComposite::splitTrack):
* platform/ScrollbarThemeComposite.h:
(WebCore::ScrollbarThemeComposite::paintScrollbarBackground):
(WebCore::ScrollbarThemeComposite::paintTrackBackground):
(WebCore::ScrollbarThemeComposite::paintTrackPiece):
* platform/win/ScrollbarThemeSafari.cpp:
(WebCore::ScrollbarThemeSafari::paintTrackBackground):
* platform/win/ScrollbarThemeSafari.h:
* platform/win/ScrollbarThemeWin.cpp:
(WebCore::ScrollbarThemeWin::paintTrack):
* platform/win/ScrollbarThemeWin.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::createScrollbar):
(WebCore::RenderLayer::styleChanged):
* rendering/RenderScrollbar.cpp: Added.
(WebCore::RenderScrollbar::createCustomScrollbar):
(WebCore::RenderScrollbar::RenderScrollbar):
(WebCore::RenderScrollbar::~RenderScrollbar):
(WebCore::RenderScrollbar::getScrollbarPseudoStyle):
(WebCore::RenderScrollbar::updateScrollbarParts):
(WebCore::RenderScrollbar::updateScrollbarPart):
(WebCore::RenderScrollbar::paintPart):
(WebCore::RenderScrollbar::buttonRect):
(WebCore::RenderScrollbar::minimumThumbLength):
* rendering/RenderScrollbar.h: Added.
(WebCore::RenderScrollbar::styleChanged):
(WebCore::RenderScrollbar::owningRenderer):
* rendering/RenderScrollbarPart.cpp: Added.
(WebCore::RenderScrollbarPart::RenderScrollbarPart):
(WebCore::RenderScrollbarPart::~RenderScrollbarPart):
(WebCore::RenderScrollbarPart::layout):
(WebCore::RenderScrollbarPart::layoutHorizontalPart):
(WebCore::RenderScrollbarPart::layoutVerticalPart):
(WebCore::calcScrollbarThicknessUsing):
(WebCore::RenderScrollbarPart::computeScrollbarWidth):
(WebCore::RenderScrollbarPart::computeScrollbarHeight):
(WebCore::RenderScrollbarPart::calcPrefWidths):
(WebCore::RenderScrollbarPart::setStyle):
* rendering/RenderScrollbarPart.h: Added.
(WebCore::RenderScrollbarPart::renderName):
(WebCore::RenderScrollbarPart::requiresLayer):
* rendering/RenderScrollbarTheme.cpp: Added.
(WebCore::RenderScrollbarTheme::renderScrollbarTheme):
(WebCore::RenderScrollbarTheme::buttonSizesAlongTrackAxis):
(WebCore::RenderScrollbarTheme::hasButtons):
(WebCore::RenderScrollbarTheme::hasThumb):
(WebCore::RenderScrollbarTheme::minimumThumbLength):
(WebCore::RenderScrollbarTheme::backButtonRect):
(WebCore::RenderScrollbarTheme::forwardButtonRect):
(WebCore::RenderScrollbarTheme::trackRect):
(WebCore::RenderScrollbarTheme::paintScrollCorner):
(WebCore::RenderScrollbarTheme::paintScrollbarBackground):
(WebCore::RenderScrollbarTheme::paintTrackBackground):
(WebCore::RenderScrollbarTheme::paintTrackPiece):
(WebCore::RenderScrollbarTheme::paintButton):
(WebCore::RenderScrollbarTheme::paintThumb):
* rendering/RenderScrollbarTheme.h: Added.
(WebCore::RenderScrollbarTheme::~RenderScrollbarTheme):
(WebCore::RenderScrollbarTheme::scrollbarThickness):
(WebCore::RenderScrollbarTheme::buttonsPlacement):
(WebCore::RenderScrollbarTheme::supportsControlTints):
(WebCore::RenderScrollbarTheme::shouldCenterOnThumb):
(WebCore::RenderScrollbarTheme::initialAutoscrollTimerDelay):
(WebCore::RenderScrollbarTheme::autoscrollTimerDelay):
(WebCore::RenderScrollbarTheme::registerScrollbar):
(WebCore::RenderScrollbarTheme::unregisterScrollbar):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::):
2008-10-09 Eric Seidel <eric@webkit.org>
Reviewed by Oliver Hunt.
Fix Canvex DOOM Game
Gradient clips were not getting cleared after filling the
gradient, this was causing nothing to draw in Canvex
https://bugs.webkit.org/show_bug.cgi?id=21498
Tests forthcoming.
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
2008-10-09 Eric Seidel <eric@webkit.org>
Reviewed by Oliver Hunt.
Fix transformed patterns
https://bugs.webkit.org/show_bug.cgi?id=21498
Test: fast/canvas/patternfill-repeat.html
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::setStrokePattern):
(WebCore::GraphicsContext::setFillPattern):
(WebCore::GraphicsContext::setStrokeGradient):
(WebCore::GraphicsContext::setFillGradient):
* platform/graphics/GraphicsContext.h:
* platform/graphics/cairo/GraphicsContextCairo.cpp:
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::applyStrokePattern):
(WebCore::applyFillPattern):
(WebCore::GraphicsContext::drawPath):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
* platform/graphics/qt/GraphicsContextQt.cpp:
* platform/graphics/wx/GraphicsContextWx.cpp:
2008-10-09 Kevin Ollivier <kevino@theolliviers.com>
wx build fixes.
* platform/wx/WidgetWx.cpp:
* plugins/wx/PluginViewWx.cpp:
(WebCore::PluginView::invalidateRect):
* webcore-base.bkl:
2008-10-09 Chris Marrin <cmarrin@apple.com>
Reviewed by Darin Adler.
Fix for https://bugs.webkit.org/show_bug.cgi?id=21217
Animations assert when navigating from page
Changed assertions to test the right flag for the paused state
* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::updateStateMachine):
2008-10-09 Chris Marrin <cmarrin@apple.com>
Reviewed by Dan Bernstein.
Fixed > 180 degree rotation bug
Ensure that validateTransformFunctionList() is called after updating keyframe styles
https://bugs.webkit.org/show_bug.cgi?id=21420
Test: animations/big-rotation.html
* page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::KeyframeAnimation):
2008-10-09 Brady Eidson <beidson@apple.com>
Reviewed by Anders
<rdar://problem/6250856> - Calling [WebView close] from within a redirection callback can cause bad things
The API usage to reveal this crash was so particular that a layout test is not possible with our current infrastructure.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::changeLocation): Protect the Frame from deletion
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy): stopAllLoaders() might clear the Frame's page,
so perform a second null check on the page. Bail if it has been cleared.
2008-10-09 Alp Toker <alp@nuanti.com>
Build fix for recent DOM generation Makefile changes when custom
CFLAGS/CXXFLAGS are passed in.
* GNUmakefile.am:
2008-10-09 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Alp Toker.
https://bugs.webkit.org/show_bug.cgi?id=21390
[Gtk] Linux/Gtk: GtkLauncher crashes on Acid3 (but after test 80 this time)
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::platformRemoveChild):
2008-10-09 Darin Adler <darin@apple.com>
- try to fix Qt build
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertQVariantToValue): Pass JSGlobalData instead of ExecState to RegExp constructor.
2008-10-08 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Oliver Hunt & Sam Weinig.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=15413 (SVGElementInstance does not implement EventTarget)
Fixes: https://bugs.webkit.org/show_bug.cgi?id=15430 (SVGElementInstances should rebuild themselves lazily)
Fixes: https://bugs.webkit.org/show_bug.cgi?id=20550 (SVGUseElement.setAttribute crashes Safari)
Rebuild SVG use element shadow tree lazily. Mark SVGElementInstance with the "needsUpdate" flag.
Next time SVGUseElement::recalcStyle is invoked (ie. via Document::updateDocumentsRendering()) the
use tree is rebuild.
Make SVGElementInstance a real EventTarget, as the SVG specification demands.
When dispatching events to a shadow tree element of a use element, the associated SVGElementInstance
is used as event target. The SVGElementInstance, the shadow tree element and the corresponding element
share an event listener list. Every event listener change on the SVGElementInstance object is forwared
to the corresponding element. Each change marks the SVGElementInstance tree dirty, and causes a reclone.
Each event listener defined via attributes (onclick/onkeydown/...) is copied from the correspondingElement
to the shadow tree element - through the cloneNode calls - if the use element's shadow tree gets rebuild.
Each listener, dynamically created using addEventListener, gets copied to the corersponding element as well.
Now that the target/currentTarget properties of the Events are correct, event bubbling works as expected,
see resources/use-instanceRoot-event-bubbling.js for details.
Tests: svg/custom/use-elementInstance-event-target.svg (reenabled)
svg/custom/use-elementInstance-methods.svg (reenabled)
svg/custom/use-setAttribute-crash.svg (covers bug 20550)
svg/custom/use-instanceRoot-as-event-target.xhtml (covers bug 15413)
svg/custom/use-instanceRoot-event-bubbling.xhtml (covers bug 15413)
svg/custom/use-instanceRoot-event-listeners.xhtml (covers bug 15413 & 15430)
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSEventListener.h:
(WebCore::JSLazyEventListener::wasCreatedFromMarkup):
* bindings/js/JSEventTarget.cpp:
* bindings/js/JSEventTargetSVGElementInstance.cpp: Removed.
* bindings/js/JSEventTargetSVGElementInstance.h: Removed.
* bindings/js/JSSVGElementInstanceCustom.cpp:
(WebCore::JSSVGElementInstance::addEventListener):
(WebCore::JSSVGElementInstance::removeEventListener):
(WebCore::JSSVGElementInstance::pushEventHandlerScope):
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/CodeGeneratorObjC.pm:
* dom/EventListener.h:
(WebCore::EventListener::wasCreatedFromMarkup):
* dom/EventTargetNode.cpp:
(WebCore::updateSVGElementInstancesAfterEventListenerChange):
(WebCore::EventTargetNode::addEventListener):
(WebCore::EventTargetNode::removeEventListener):
(WebCore::eventTargetAsSVGElementInstance):
(WebCore::eventTargetRespectingSVGTargetRules):
(WebCore::EventTargetNode::dispatchEvent):
(WebCore::EventTargetNode::dispatchGenericEvent):
(WebCore::EventTargetNode::removeEventListenerForType):
* page/EventHandler.cpp:
(WebCore::EventHandler::clear):
(WebCore::instanceAssociatedWithShadowTreeElement):
(WebCore::EventHandler::updateMouseEventTargetNode):
* page/EventHandler.h:
* svg/EventTargetSVGElementInstance.cpp: Removed.
* svg/EventTargetSVGElementInstance.h: Removed.
* svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::SVGElementInstance):
(WebCore::SVGElementInstance::~SVGElementInstance):
(WebCore::SVGElementInstance::childNodes):
(WebCore::SVGElementInstance::setShadowTreeElement):
(WebCore::SVGElementInstance::forgetWrapper):
(WebCore::SVGElementInstance::appendChild):
(WebCore::SVGElementInstance::invalidateAllInstancesOfElement):
(WebCore::SVGElementInstance::setNeedsUpdate):
(WebCore::SVGElementInstance::associatedFrame):
(WebCore::SVGElementInstance::addEventListener):
(WebCore::SVGElementInstance::removeEventListener):
(WebCore::SVGElementInstance::dispatchEvent):
(WebCore::SVGElementInstance::onabort):
(WebCore::SVGElementInstance::setOnabort):
(WebCore::SVGElementInstance::onblur):
(WebCore::SVGElementInstance::setOnblur):
(WebCore::SVGElementInstance::onchange):
(WebCore::SVGElementInstance::setOnchange):
(WebCore::SVGElementInstance::onclick):
(WebCore::SVGElementInstance::setOnclick):
(WebCore::SVGElementInstance::oncontextmenu):
(WebCore::SVGElementInstance::setOncontextmenu):
(WebCore::SVGElementInstance::ondblclick):
(WebCore::SVGElementInstance::setOndblclick):
(WebCore::SVGElementInstance::onerror):
(WebCore::SVGElementInstance::setOnerror):
(WebCore::SVGElementInstance::onfocus):
(WebCore::SVGElementInstance::setOnfocus):
(WebCore::SVGElementInstance::oninput):
(WebCore::SVGElementInstance::setOninput):
(WebCore::SVGElementInstance::onkeydown):
(WebCore::SVGElementInstance::setOnkeydown):
(WebCore::SVGElementInstance::onkeypress):
(WebCore::SVGElementInstance::setOnkeypress):
(WebCore::SVGElementInstance::onkeyup):
(WebCore::SVGElementInstance::setOnkeyup):
(WebCore::SVGElementInstance::onload):
(WebCore::SVGElementInstance::setOnload):
(WebCore::SVGElementInstance::onmousedown):
(WebCore::SVGElementInstance::setOnmousedown):
(WebCore::SVGElementInstance::onmousemove):
(WebCore::SVGElementInstance::setOnmousemove):
(WebCore::SVGElementInstance::onmouseout):
(WebCore::SVGElementInstance::setOnmouseout):
(WebCore::SVGElementInstance::onmouseover):
(WebCore::SVGElementInstance::setOnmouseover):
(WebCore::SVGElementInstance::onmouseup):
(WebCore::SVGElementInstance::setOnmouseup):
(WebCore::SVGElementInstance::onmousewheel):
(WebCore::SVGElementInstance::setOnmousewheel):
(WebCore::SVGElementInstance::onbeforecut):
(WebCore::SVGElementInstance::setOnbeforecut):
(WebCore::SVGElementInstance::oncut):
(WebCore::SVGElementInstance::setOncut):
(WebCore::SVGElementInstance::onbeforecopy):
(WebCore::SVGElementInstance::setOnbeforecopy):
(WebCore::SVGElementInstance::oncopy):
(WebCore::SVGElementInstance::setOncopy):
(WebCore::SVGElementInstance::onbeforepaste):
(WebCore::SVGElementInstance::setOnbeforepaste):
(WebCore::SVGElementInstance::onpaste):
(WebCore::SVGElementInstance::setOnpaste):
(WebCore::SVGElementInstance::ondragenter):
(WebCore::SVGElementInstance::setOndragenter):
(WebCore::SVGElementInstance::ondragover):
(WebCore::SVGElementInstance::setOndragover):
(WebCore::SVGElementInstance::ondragleave):
(WebCore::SVGElementInstance::setOndragleave):
(WebCore::SVGElementInstance::ondrop):
(WebCore::SVGElementInstance::setOndrop):
(WebCore::SVGElementInstance::ondragstart):
(WebCore::SVGElementInstance::setOndragstart):
(WebCore::SVGElementInstance::ondrag):
(WebCore::SVGElementInstance::setOndrag):
(WebCore::SVGElementInstance::ondragend):
(WebCore::SVGElementInstance::setOndragend):
(WebCore::SVGElementInstance::onreset):
(WebCore::SVGElementInstance::setOnreset):
(WebCore::SVGElementInstance::onresize):
(WebCore::SVGElementInstance::setOnresize):
(WebCore::SVGElementInstance::onscroll):
(WebCore::SVGElementInstance::setOnscroll):
(WebCore::SVGElementInstance::onsearch):
(WebCore::SVGElementInstance::setOnsearch):
(WebCore::SVGElementInstance::onselect):
(WebCore::SVGElementInstance::setOnselect):
(WebCore::SVGElementInstance::onselectstart):
(WebCore::SVGElementInstance::setOnselectstart):
(WebCore::SVGElementInstance::onsubmit):
(WebCore::SVGElementInstance::setOnsubmit):
(WebCore::SVGElementInstance::onunload):
(WebCore::SVGElementInstance::setOnunload):
* svg/SVGElementInstance.h:
(WebCore::SVGElementInstance::needsUpdate):
(WebCore::SVGElementInstance::toNode):
(WebCore::SVGElementInstance::toSVGElementInstance):
(WebCore::SVGElementInstance::correspondingElement):
(WebCore::SVGElementInstance::correspondingUseElement):
(WebCore::SVGElementInstance::shadowTreeElement):
(WebCore::SVGElementInstance::parentNode):
(WebCore::SVGElementInstance::previousSibling):
(WebCore::SVGElementInstance::nextSibling):
(WebCore::SVGElementInstance::firstChild):
(WebCore::SVGElementInstance::lastChild):
(WebCore::SVGElementInstance::ownerDocument):
(WebCore::SVGElementInstance::hasChildNodes):
(WebCore::SVGElementInstance::setFirstChild):
(WebCore::SVGElementInstance::setLastChild):
(WebCore::SVGElementInstance::setNextSibling):
(WebCore::SVGElementInstance::setPreviousSibling):
(WebCore::SVGElementInstance::refEventTarget):
(WebCore::SVGElementInstance::derefEventTarget):
* svg/SVGElementInstance.idl:
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::svgAttributeChanged):
(WebCore::SVGStyledElement::childrenChanged):
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::svgAttributeChanged):
(WebCore::shadowTreeContainsChangedNodes):
(WebCore::SVGUseElement::recalcStyle):
(WebCore::dumpInstanceTree):
(WebCore::SVGUseElement::buildPendingResource):
(WebCore::SVGUseElement::buildInstanceTree):
(WebCore::SVGUseElement::transferEventListenersToShadowTree):
* svg/SVGUseElement.h:
2008-10-08 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich.
Fix for https://bugs.webkit.org/show_bug.cgi?id=21241
REGRESSION (r36977): getRGBColorValue().red returning incorrect value
Update JSRGBColor to use the new static function per getter approach.
Test: fast/dom/css-RGBValue.html
* bindings/js/JSRGBColor.cpp:
(WebCore::):
(jsRGBColorRed):
(jsRGBColorGreen):
(jsRGBColorBlue):
* bindings/js/JSRGBColor.h:
2008-10-08 Eric Seidel <eric@webkit.org>
Reviewed by Darin Adler, Nikolas Zimmermann and Dave Hyatt.
svgElement.className.baseValue = "foo" does not work
https://bugs.webkit.org/show_bug.cgi?id=20651
* dom/StyledElement.cpp:
(WebCore::StyledElement::classAttributeChanged):
(WebCore::StyledElement::parseMappedAttribute):
* dom/StyledElement.h:
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::svgAttributeChanged):
2008-10-08 Anthony Ricaud <rik24d@gmail.com>
Make the toolbar label text-shadow not disappear when clicking on the
search result count or around the search field.
Reviewed by Timothy Hatcher.
* inspector/front-end/inspector.css:
(.toolbar-item:active .toolbar-label): Make this rule also require the
toggleable class with the toolbar-item class.
2008-10-08 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Updated the qrc file for the Web Inspector to contain the current set
of images.
* inspector/front-end/WebKit.qrc:
2008-10-08 Prasanth Ullattil <pullatti@trolltech.com>
Reviewed by Simon.
Fix the linking of applications against WebKit on Qt/Windows.
The prl files that qmake creates are buggy on Unix, but we they're
fine on Windows and we have to have them there in order to get the
dependencies correct.
* WebCore.pro:
2008-10-08 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon.
Speed up rectangle filling by not re-creating a QBrush all the time.
This triggers faster path in QPainter where the brush is reused.
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
(WebCore::GraphicsContext::fillRect):
2008-10-08 Thiago Macieira <thiago.macieira@nokia.com>
Reviewed by Simon.
Fixes: Encoding of Qt URLs
This encoding was added by Simon and I because QUrl's
tolerant parser wasn't tolerant enough. Now it is, so we don't need
this anymore.
* platform/qt/KURLQt.cpp:
(WebCore::KURL::operator QUrl):
2008-10-08 Marius Storm-Olsen <marius@trolltech.com>
Reviewed by Simon.
Fixes dependencies in qmake generated visual studio projects.
Only add debug lib name if we're in the debug build_pass, else the release version.
The MSVC solution generator would pick up the debug javascriptcore lib as a dependency.
* WebCore.pro:
2008-10-08 Prasanth Ullattil <pullatti@trolltech.com>
Reviewed by Simon.
Fix compilation errors on VS2008 64Bit
* platform/text/TextStream.cpp:
(WebCore::TextStream::operator<<):
* platform/text/TextStream.h:
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::init):
2008-10-07 Alp Toker <alp@nuanti.com>
GTK+ build fix for older automake versions (1.7). Discussed in bug
#21392.
* GNUmakefile.am:
2008-10-07 Anders Carlsson <andersca@apple.com>
Reviewed by Antti Koivisto.
<rdar://problem/6273887> Crash in ApplicationCacheGroup
Make sure to stop loading even before a cache update is in progress so that the
manifest load will be stopped.
* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::~ApplicationCacheGroup):
(WebCore::ApplicationCacheGroup::stopLoading):
(WebCore::ApplicationCacheGroup::cacheUpdateFailed):
2008-10-07 Timothy Hatcher <timothy@apple.com>
Auto-generate DOMDocument's createNodeIterator: and createTreeWalker: methods.
https://bugs.webkit.org/show_bug.cgi?id=21433
Reviewed by Sam Weinig.
* WebCore.xcodeproj/project.pbxproj: Add ObjCNodeFilterCondition.{mm,h}.
* bindings/objc/DOM.mm: Remove previous category implementations
on DOMDocument for createNodeIterator: and createTreeWalker:. Also
moves ObjCNodeFilterCondition to its own file.
* bindings/objc/DOMTraversal.h: Remove the category methods that added
createNodeIterator: and createTreeWalker: to DOMDocument. This is fine
to do since DOmDocument.h is included still, and has these methods.
* bindings/objc/DOMUtility.mm:
(JSC::createDOMWrapper): Remove special case for JSNodeIterator and
JSTreeWalker now that the ObjC binding conforms to the standard wrap.
* bindings/objc/ObjCNodeFilterCondition.h: Split out from DOM.mm.
(WebCore::ObjCNodeFilterCondition::create): Moved from DOM.mm.
(WebCore::ObjCNodeFilterCondition::ObjCNodeFilterCondition): Ditto.
* bindings/objc/ObjCNodeFilterCondition.mm: Split out from DOM.mm.
(WebCore::ObjCNodeFilterCondition::acceptNode): Moved from DOM.mm.
* bindings/objc/PublicDOMInterfaces.h: Add the createNodeIterator: and
createTreeWalker: methods to DOMDocument.
* bindings/scripts/CodeGeneratorObjC.pm:
(GetObjCTypeGetter): Add a case for NodeFilter.
(AddIncludesForType): Include ObjCNodeFilterCondition.h for NodeFilter.
(GenerateImplementation): Remove existing NodeFilter special case that
used the m_filter member variable. Add a new special getter for protocol
types that aren't EventTarget, so the right class is used for NodeFilter.
Add a special case for NodeFilter where it creates an ObjCNodeFilterCondition.
* dom/Document.idl: Remove the #ifdef LANGUAGE_OBJECTIVE_C. Add the
OldStyleObjC extended attribute to createNodeIterator and createTreeWalker.
Rename the entityReferenceExpansion parameter to expandEntityReferences to
match the previous ObjC API.
* dom/NodeIterator.idl: Remove ObjCIvar from the filter attribute. The
m_filter member variable was never used in practice, it was always nil!
We can remove it and not pad the object because this can't be subclassed.
* dom/TreeWalker.idl: Ditto.
2008-10-07 Timothy Hatcher <timothy@apple.com>
Auto-generate the DOMEventTarget protocol implementation for
DOMNode and DOMSVGElementInstance.
https://bugs.webkit.org/show_bug.cgi?id=21432
Reviewed by Darin Adler.
* WebCore.xcodeproj/project.pbxproj: Add ObjCEventListener.{mm,h}.
* bindings/objc/DOM.mm: Remove many unneeded header includes. Move
ObjCEventListener to it's own file. Remove the manual impelmentations
of the DOMEventTarget protocol for DOMNode and DOMSVGElementInstance.
* bindings/objc/DOMEvents.h: Remove the categories that defined
DOMEventTarget for DOMNode and DOMSVGElementInstance.
* bindings/objc/ObjCEventListener.h: Split out from DOM.mm.
* bindings/objc/ObjCEventListener.mm: Split out from DOM.mm.
(WebCore::ObjCEventListener::find): Moved from DOM.mm.
(WebCore::ObjCEventListener::wrap): Use PassRefPtr to prevent the
callers from doing a manual deref.
(WebCore::ObjCEventListener::ObjCEventListener): Moved from DOM.mm.
(WebCore::ObjCEventListener::~ObjCEventListener): Ditto.
* bindings/scripts/CodeGeneratorObjC.pm:
(GetObjCTypeGetter): Add a case for EventListener and use WTF::getPtr.
(AddIncludesForType): Include ObjCEventListener.h for EventListener.
And include EventTargetSVGElementInstance.h for SVGElementInstance.
(GenerateHeader): Remove the check for multiple parents.
(GenerateImplementation): Remove the check for multiple parents. Remove
the @deprecatedFunctions array since deprecated methods get generated
into the main @interface now to work with protocols. Add support
for the EventTargetNodeCast extended attribute. Add support for
EventListener parameters.
* dom/Node.idl: Define superclasses for ObjC so the implementation
and interface implement the DOMEventTarget protocol. Explicitly
specify Object as a superclass to use DOMEventTarget. Object will turn
into DOMObject. This is needed to take the code generator down the right
path of multiple super-classes as protocols. It is ObjC only for legacy
reasons. The event target methods are normally on NodeEventTarget, a
subclass of Node. But the ObjC API has never has this subclass and
they are on DOMNode.
* svg/SVGElementInstance.idl: Ditto.
2008-10-07 David Hyatt <hyatt@apple.com>
Add new pseudo-elements and pseudo-classes that will enable scrollbars to be styled by CSS.
The new pseudo-elements are:
scrollbar
scrollbar-button
scrollbar-corner
scrollbar-thumb
scrollbar-track
These elements will work with all the usual pseudo-classes (:hover, :active, :enabled, :disabled, etc.) and with
the following new pseudo-classes:
scrollbar-active
scrollbar-back
scrollbar-forward
scrollbar-horizontal
scrollbar-vertical
Reviewed by Adele
* css/CSSSelector.cpp:
(WebCore::CSSSelector::extractPseudoType):
* css/CSSSelector.h:
(WebCore::CSSSelector::):
2008-10-06 Timothy Hatcher <timothy@apple.com>
Add support to the Resources panel for queries like "#123", "foo #123",
"line: 123" and "foo line: 123". These will match the query limiting
the search only to the line specified. If only a line is specified,
the whole line is matched.
https://bugs.webkit.org/show_bug.cgi?id=21422
Reviewed by Darin Adler.
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.sourceRow): Don't return the last
row if the index is greater than the rows collection. Let it return
undefined by indexing out-of-bounds.
* inspector/front-end/SourceView.js:
(WebInspector.SourceView.prototype.performSearch): Add support for
queries like "#123", "foo #123", "line: 123" and "foo line: 123".
Also match the whole query to the whole document in case there are
colors like "#333".
2008-10-07 Alp Toker <alp@nuanti.com>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=21392
[GTK] Auto-generate JS DOM binding sources list
Remove the huge lists of generated DOM binding sources and headers in
the build system. These are difficult to maintain and can be derived
automatically.
The new strategy is to re-use the existing lists of IDL sources (which
are needed for dist support anyway). This will also ease the addition
of new language bindings.
* GNUmakefile.am:
2008-10-07 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Don't attempt to paint when updating control tints
We don't have a valid PlatformGraphicsContext so schedule
the dirty scrollbar/scrollview area for repaint instead.
* platform/qt/ScrollbarThemeQt.cpp:
(WebCore::ScrollbarThemeQt::paint):
(WebCore::ScrollbarThemeQt::paintScrollCorner):
2008-10-07 Holger Hans Peter Freyther <zecke@selfish.org>
[qt] Build fix after Scrollbar.h and Widget.h changes.
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::getValue):
(WebCore::PluginView::init):
2008-10-06 David Hyatt <hyatt@apple.com>
Enable viewless Mac WebKit to (kinda sorta) paint basic pages (with no frames on them).
Reviewed by Sam Weinig
* WebCore.base.exp:
* WebCore.xcodeproj/project.pbxproj:
* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::hasWebView):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::transitionToCommitted):
* loader/FrameLoaderClient.h:
* page/FocusController.cpp:
(WebCore::FocusController::setActive):
* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::init):
(WebCore::FrameView::layoutIfNeededRecursive):
* page/FrameView.h:
2008-10-06 Dan Bernstein <mitz@apple.com>
- build fix
* bindings/objc/DOMEvents.h:
2008-10-06 Mark Mentovai <mark@moxienet.com>
Reviewed by Tim Hatcher.
Use #if ENABLE(feature) where possible, and #if ENABLE_feature where
Platform.h is not available, in preference to #ifdef ENABLE_feature.
#ifdef is wrong now that features are disabled by #defining
ENABLE_feature to 0.
https://bugs.webkit.org/show_bug.cgi?id=21338
* bindings/objc/DOMEvents.h:
* bindings/objc/PublicDOMInterfaces.h:
* dom/Document.idl:
* page/DOMWindow.idl:
* svg/svgtags.in:
2008-10-06 Mark Mentovai <mark@moxienet.com>
Reviewed by Sam Weinig.
* platform/network/mac/FormDataStreamMac.mm: #import <wtf/Threading.h>
to get the declaration for isMainThread().
2008-10-06 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Tim Hatcher.
WebCoreObjCExtras.c is actually an obj-c++ file, so change its name
to reflect that.
* WebCore.xcodeproj/project.pbxproj:
* platform/mac/WebCoreObjCExtras.c: Removed.
* platform/mac/WebCoreObjCExtras.mm: Copied from WebCore/platform/mac/WebCoreObjCExtras.c.
2008-10-06 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Dan Bernstein.
Added C++ forward declaration for the NSURLAuthenticationChallenge class
so that the m_currentMacChallenge variable doesn't cause a
compilation error when ResourceHandleInternal.h is included from a C++ file.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=21411
* platform/network/ResourceHandleInternal.h:
2008-10-06 Steve Falkenburg <sfalken@apple.com>
Windows build fix.
* WebCore.vcproj/WebCore.vcproj:
2008-10-06 Steve Falkenburg <sfalken@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=21416
Add missing null checks identified by Application Verifier.
Reviewed by Darin Adler.
* platform/win/SharedTimerWin.cpp:
(WebCore::clearTimer):
2008-10-06 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim Hatcher.
Removed accidentally left in debugging statement.
* inspector/front-end/inspector.js:
2008-10-06 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim Hatcher and Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=21412
Bug 21412: Refactor user initiated profile count to be more stable
* inspector/InspectorController.cpp: Keep track of the user-initiated
profiles here now.
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::startUserInitiatedProfiling):
(WebCore::InspectorController::stopUserInitiatedProfiling):
* inspector/InspectorController.h:
The front end will now need to check for the existence of the user-
initiated profile title and use its count instead of keeping its own.
* inspector/front-end/ProfilesPanel.js:
2008-10-06 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig.
- separate GDI text drawing into its own function
* platform/graphics/win/FontCGWin.cpp:
(WebCore::drawGDIGlyphs):
(WebCore::Font::drawGlyphs):
2008-10-03 Steve Falkenburg <sfalken@apple.com>
<rdar://problem/6249833> Fix default button appearance
Reviewed by Adele Peterson.
* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::supportsFocus):
(WebCore::RenderThemeWin::determineClassicState):
(WebCore::RenderThemeWin::determineButtonState):
(WebCore::RenderThemeWin::getClassicThemeData):
(WebCore::RenderThemeWin::getThemeData):
(WebCore::drawControl):
* rendering/RenderThemeWin.h:
2008-10-06 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Add native virtual keycode to PlatformKeyboardEvent
* platform/PlatformKeyboardEvent.h:
* platform/gtk/KeyEventGtk.cpp:
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
* platform/mac/KeyEventMac.mm:
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
* platform/qt/PlatformKeyboardEventQt.cpp:
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
* platform/win/KeyEventWin.cpp:
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
* platform/wx/KeyboardEventWx.cpp:
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
2008-10-06 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Enable WebCore::String <> CFStringRef conversion functions for QtWebKit/Mac
* platform/text/PlatformString.h:
* platform/text/StringImpl.h:
* platform/text/cf/StringCF.cpp:
* platform/text/cf/StringImplCF.cpp:
2008-10-06 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Use bundles on QtWebKit/Mac for platform modules
* platform/FileSystem.h:
* platform/qt/FileSystemQt.cpp:
(WebCore::unloadModule):
2008-10-06 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon.
Build fix for MinGW.
* platform/win/SystemTimeWin.cpp:
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::invalidateRect):
2008-10-06 Adam Roben <aroben@apple.com>
Mimic the inspector/ directory structure in WebCore.vcproj
* WebCore.vcproj/WebCore.vcproj:
2008-10-06 Adam Roben <aroben@apple.com>
Windows build fix
* WebCore.vcproj/WebCore.vcproj: Update the Include path for all
configurations to include WebCore/inspector.
2008-10-04 Eric Seidel <eric@webkit.org>
Reviewed by Darin Adler.
SVG should support ascent and descent properties <font-face> instead of <font>!
https://bugs.webkit.org/show_bug.cgi?id=21365
Tested by many many existing SVG tests.
* svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::ascent):
(WebCore::SVGFontFaceElement::descent):
2008-10-05 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
REGRESSION: crash in ScriptElement::notifyFinished
Fixes https://bugs.webkit.org/show_bug.cgi?id=21329
* dom/ScriptElement.cpp:
(WebCore::ScriptElementData::notifyFinished): Revert part of r35744 to
ensure that the ScriptElementData object is not destroyed prematurely.
2008-10-05 Chris Lord <chris@openedhand.com>
Reviewed by Alp Toker. Landed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=20624
WebKit-gtk uses deprecated GtkType/GtkObject
* plugins/gtk/gtk2xtbin.c:
(gtk_xtbin_get_type):
* plugins/gtk/gtk2xtbin.h:
2008-10-05 Luke Kenneth Casson Leighton <lkcl@lkcl.net>
Reviewed by David Hyatt.
GTK_WINDOW_HWND not GTK_WINDOWING_HWND
https://bugs.webkit.org/show_bug.cgi?id=20725
Updated to ToT by Jan Alonzo.
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::getValue):
2008-10-05 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Darin Adler.
Invalid cast from GdkWindow to GtkWidget
https://bugs.webkit.org/show_bug.cgi?id=21391
Fix a misplaced closing parenthesis to actually cast the widget, not the window
* platform/gtk/PlatformScreenGtk.cpp:
(WebCore::screenDepth):
2008-10-05 Adam Barth <abarth@webkit.org>
Reviewed by Darin Alder.
Attach the Origin header to POST requests to help defend against
cross-site request forgery.
https://bugs.webkit.org/show_bug.cgi?id=20792
Collin Jackson <collinj@webkit.org> also contributed to this patch.
Tests: http/tests/security/originHeader/origin-header-for-data.html
http/tests/security/originHeader/origin-header-for-empty.html
http/tests/security/originHeader/origin-header-for-get.html
http/tests/security/originHeader/origin-header-for-https.html
http/tests/security/originHeader/origin-header-for-post.html
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::createWindow):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::createWindow):
(WebCore::FrameLoader::urlSelected):
(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::outgoingOrigin):
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::addExtraFieldsToRequest):
(WebCore::FrameLoader::loadPostRequest):
(WebCore::FrameLoader::loadResourceSynchronously):
(WebCore::FrameLoader::loadItem):
* loader/FrameLoader.h:
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::create):
* loader/loader.cpp:
(WebCore::Loader::Host::servePendingRequests):
* platform/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::toHTTPOrigin):
* platform/SecurityOrigin.h:
* platform/network/ResourceRequestBase.h:
(WebCore::ResourceRequestBase::httpOrigin):
(WebCore::ResourceRequestBase::setHTTPOrigin):
(WebCore::ResourceRequestBase::clearHTTPOrigin):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::makeSimpleCrossSiteAccessRequest):
(WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
(WebCore::XMLHttpRequest::handleAsynchronousPreflightResult):
(WebCore::XMLHttpRequest::didReceiveResponsePreflight):
2008-10-04 Oliver Hunt <oliver@apple.com>
Reviewed by Tim Hatcher.
Bug 21381: Incremental parsing of html causes bogus line numbers in some cases
<https://bugs.webkit.org/show_bug.cgi?id=21381>
If we hit a parsing boundary (end of a packet, etc) in the middle of a
<script> element when we are doing an incremental parse, we exit the
parser, and reenter later when more data is available. During this
reentry we incorrectly reset the scriptStartLineno to the current line
in the parser, which is now part way through the script element.
The solution is to track whether we are entering or reentering the parsing
of a script element. We do this simply by 0 checking scriptStartLineno,
and resetting it after we complete parsing of each script element.
Test: http/tests/incremental/pause-in-script-element.pl
* ChangeLog:
* html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::parseSpecial):
(WebCore::HTMLTokenizer::scriptHandler):
2008-10-04 Alp Toker <alp@nuanti.com>
Reviewed by David Hyatt. Landed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=20924
[Gtk] Linux/Gtk: Recent tree revisions fail Acid2 and Acid3
https://bugs.webkit.org/show_bug.cgi?id=19578
[CURL] problem in parseDataUrl
De-obfuscate parseDataUrl() and fix regressions introduced in r35954.
This patch also fixes encoding support in escaped (non-Base64) data
URLs. All manual data URL tests now pass in both GLib and non-GLib
code paths.
* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::parseDataUrl):
2008-10-04 Timothy Hatcher <timothy@apple.com>
Makes breakpoints and debugging code during page load work in the
Web Inspector's debugger. Specifically, this makes the source
code for loading resources show up in the Scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=19053
rdar://problem/5933408
Reviewed by Mark Rowe.
* WebCore.xcodeproj/project.pbxproj: Mark the inspector group as
not using tabs and a tab width of 8.
* inspector/InspectorController.cpp:
(WebCore::addResourceSourceToFrame): Return a bool to report if the
source was added successfully or not.
(WebCore::addSourceToFrame): Ditto.
* inspector/front-end/ScriptView.js:
(WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded):
Return early if the InspectorController.addSourceToFrame fails.
Moved the delete of the _frameNeedsSetup property after that call so
if the source wasn't added it will be attempted again.
* inspector/front-end/SourceView.js:
(WebInspector.SourceView.prototype.detach): Move a comment.
(WebInspector.SourceView.prototype.setupSourceFrameIfNeeded):
Don't check if the resource is finished or failed, just attempt
to add the source to the frame. WebCore has the source, but the
finished property hasn't been set yet. Return early if the
InspectorController.addSourceToFrame fails. Moved the delete
of the _frameNeedsSetup property after that call so if the source
wasn't added it will be attempted again.
(WebInspector.SourceView.prototype._resourceLoadingFinished):
Clear the _frameNeedsSetup and _sourceFrameSetup properties so
the source frame will we populated again now that the resource
load has finished.
* manual-tests/inspector/debugger-pause-during-load.html: Added.
2008-10-04 Mark Rowe <mrowe@apple.com>
Reviewed by Tim Hatcher.
Add a 'Check For Weak VTables' build phase to catch weak vtables as early as possible.
* WebCore.xcodeproj/project.pbxproj:
2008-10-04 David Hyatt <hyatt@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=21373
Tear down scrollbars in FrameView rather than ScrollView so that the connection to the hostWindow()
is still present.
Reviewed by Mark Rowe
* page/FrameView.cpp:
(WebCore::FrameView::~FrameView):
2008-10-04 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Avoid copying a Vector when using getSupportedKeySizes.
* html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::HTMLKeygenElement):
* platform/SSLKeyGenerator.h:
* platform/gtk/TemporaryLinkStubs.cpp:
(WebCore::getSupportedKeySizes):
* platform/mac/SSLKeyGeneratorMac.mm:
(WebCore::getSupportedKeySizes):
* platform/qt/TemporaryLinkStubs.cpp:
(WebCore::getSupportedKeySizes):
* platform/win/TemporaryLinkStubs.cpp:
(WebCore::getSupportedKeySizes):
* platform/wx/TemporaryLinkStubs.cpp:
(WebCore::getSupportedKeySizes):
2008-10-04 Darin Adler <darin@apple.com>
Reviewed by Cameron Zwarich.
- prepare for https://bugs.webkit.org/show_bug.cgi?id=21295
Bug 21295: Replace ExecState with a call frame Register pointer
* bindings/js/JSQuarantinedObjectWrapper.cpp:
(WebCore::JSQuarantinedObjectWrapper::allowsUnwrappedAccessFrom):
Remove bogus "const".
* bindings/js/JSQuarantinedObjectWrapper.h: Ditto.
2008-10-04 David Hyatt <hyatt@apple.com>
Make PopupMenuClient obey the platform abstraction. Remove any connection to Document and RenderStyle.
Reviewed by Darin Adler
* WebCore.xcodeproj/project.pbxproj:
* platform/PopupMenuClient.h:
* platform/gtk/PopupMenuGtk.cpp:
(WebCore::PopupMenu::show):
* platform/mac/PopupMenuMac.mm:
(WebCore::PopupMenu::populate):
(WebCore::PopupMenu::show):
* platform/qt/PopupMenuQt.cpp:
(WebCore::PopupMenu::populate):
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::calculatePositionAndSize):
(WebCore::PopupMenu::paint):
(WebCore::PopupWndProc):
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::itemStyle):
(WebCore::RenderMenuList::menuStyle):
(WebCore::RenderMenuList::hostWindow):
* rendering/RenderMenuList.h:
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::itemStyle):
(WebCore::RenderTextControl::menuStyle):
(WebCore::RenderTextControl::hostWindow):
* rendering/RenderTextControl.h:
2008-10-04 Matt Lilek <webkit@mattlilek.com>
Build fix - restore Private role to headers that had it before the move.
* WebCore.xcodeproj/project.pbxproj:
2008-10-04 Darin Adler <darin@apple.com>
- try to fix build
* DerivedSources.make: Add new inspector directory to VPATH.
* GNUmakefile.am: Add new inspector directory to includes.
Re-sort the IDL_BINDINGS list. Add new inspector directory
to VPATH.
2008-10-04 Matt Lilek <webkit@mattlilek.com>
Not reviewed, attempt to fix Gtk build.
* GNUmakefile.am:
2008-10-03 Timothy Hatcher <timothy@apple.com>
Move the Web Inspector files into a top-level "inspector" folder.
https://bugs.webkit.org/show_bug.cgi?id=21359
Reviewed by Dave Hyatt.
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* inspector/InspectorClient.h: Renamed from WebCore/page/InspectorClient.h.
* inspector/InspectorController.cpp: Renamed from WebCore/page/InspectorController.cpp.
* inspector/InspectorController.h: Renamed from WebCore/page/InspectorController.h.
* inspector/JavaScriptCallFrame.cpp: Renamed from WebCore/page/JavaScriptCallFrame.cpp.
* inspector/JavaScriptCallFrame.h: Renamed from WebCore/page/JavaScriptCallFrame.h.
* inspector/JavaScriptCallFrame.idl: Renamed from WebCore/page/JavaScriptCallFrame.idl.
* inspector/JavaScriptDebugListener.h: Renamed from WebCore/page/JavaScriptDebugListener.h.
* inspector/JavaScriptDebugServer.cpp: Renamed from WebCore/page/JavaScriptDebugServer.cpp.
* inspector/JavaScriptDebugServer.h: Renamed from WebCore/page/JavaScriptDebugServer.h.
* inspector/JavaScriptProfile.cpp: Renamed from WebCore/page/JavaScriptProfile.cpp.
* inspector/JavaScriptProfile.h: Renamed from WebCore/page/JavaScriptProfile.h.
* inspector/JavaScriptProfileNode.cpp: Renamed from WebCore/page/JavaScriptProfileNode.cpp.
* inspector/JavaScriptProfileNode.h: Renamed from WebCore/page/JavaScriptProfileNode.h.
* inspector/front-end/Breakpoint.js: Renamed from WebCore/page/inspector/Breakpoint.js.
* inspector/front-end/BreakpointsSidebarPane.js: Renamed from WebCore/page/inspector/BreakpointsSidebarPane.js.
* inspector/front-end/CallStackSidebarPane.js: Renamed from WebCore/page/inspector/CallStackSidebarPane.js.
* inspector/front-end/Console.js: Renamed from WebCore/page/inspector/Console.js.
* inspector/front-end/DataGrid.js: Renamed from WebCore/page/inspector/DataGrid.js.
* inspector/front-end/Database.js: Renamed from WebCore/page/inspector/Database.js.
* inspector/front-end/DatabaseQueryView.js: Renamed from WebCore/page/inspector/DatabaseQueryView.js.
* inspector/front-end/DatabaseTableView.js: Renamed from WebCore/page/inspector/DatabaseTableView.js.
* inspector/front-end/DatabasesPanel.js: Renamed from WebCore/page/inspector/DatabasesPanel.js.
* inspector/front-end/ElementsPanel.js: Renamed from WebCore/page/inspector/ElementsPanel.js.
* inspector/front-end/ElementsTreeOutline.js: Renamed from WebCore/page/inspector/ElementsTreeOutline.js.
* inspector/front-end/FontView.js: Renamed from WebCore/page/inspector/FontView.js.
* inspector/front-end/ImageView.js: Renamed from WebCore/page/inspector/ImageView.js.
* inspector/front-end/Images/back.png: Renamed from WebCore/page/inspector/Images/back.png.
* inspector/front-end/Images/checker.png: Renamed from WebCore/page/inspector/Images/checker.png.
* inspector/front-end/Images/clearConsoleButtons.png: Renamed from WebCore/page/inspector/Images/clearConsoleButtons.png.
* inspector/front-end/Images/closeButtons.png: Renamed from WebCore/page/inspector/Images/closeButtons.png.
* inspector/front-end/Images/consoleButtons.png: Renamed from WebCore/page/inspector/Images/consoleButtons.png.
* inspector/front-end/Images/database.png: Renamed from WebCore/page/inspector/Images/database.png.
* inspector/front-end/Images/databaseTable.png: Renamed from WebCore/page/inspector/Images/databaseTable.png.
* inspector/front-end/Images/databasesIcon.png: Renamed from WebCore/page/inspector/Images/databasesIcon.png.
* inspector/front-end/Images/debuggerContinue.png: Renamed from WebCore/page/inspector/Images/debuggerContinue.png.
* inspector/front-end/Images/debuggerPause.png: Renamed from WebCore/page/inspector/Images/debuggerPause.png.
* inspector/front-end/Images/debuggerStepInto.png: Renamed from WebCore/page/inspector/Images/debuggerStepInto.png.
* inspector/front-end/Images/debuggerStepOut.png: Renamed from WebCore/page/inspector/Images/debuggerStepOut.png.
* inspector/front-end/Images/debuggerStepOver.png: Renamed from WebCore/page/inspector/Images/debuggerStepOver.png.
* inspector/front-end/Images/debuggingButtons.png: Renamed from WebCore/page/inspector/Images/debuggingButtons.png.
* inspector/front-end/Images/disclosureTriangleSmallDown.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallDown.png.
* inspector/front-end/Images/disclosureTriangleSmallDownBlack.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallDownBlack.png.
* inspector/front-end/Images/disclosureTriangleSmallDownWhite.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallDownWhite.png.
* inspector/front-end/Images/disclosureTriangleSmallRight.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRight.png.
* inspector/front-end/Images/disclosureTriangleSmallRightBlack.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRightBlack.png.
* inspector/front-end/Images/disclosureTriangleSmallRightDown.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRightDown.png.
* inspector/front-end/Images/disclosureTriangleSmallRightDownBlack.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRightDownBlack.png.
* inspector/front-end/Images/disclosureTriangleSmallRightDownWhite.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRightDownWhite.png.
* inspector/front-end/Images/disclosureTriangleSmallRightWhite.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRightWhite.png.
* inspector/front-end/Images/dockButtons.png: Renamed from WebCore/page/inspector/Images/dockButtons.png.
* inspector/front-end/Images/elementsIcon.png: Renamed from WebCore/page/inspector/Images/elementsIcon.png.
* inspector/front-end/Images/errorIcon.png: Renamed from WebCore/page/inspector/Images/errorIcon.png.
* inspector/front-end/Images/errorMediumIcon.png: Renamed from WebCore/page/inspector/Images/errorMediumIcon.png.
* inspector/front-end/Images/excludeButtons.png: Renamed from WebCore/page/inspector/Images/excludeButtons.png.
* inspector/front-end/Images/focusButtons.png: Renamed from WebCore/page/inspector/Images/focusButtons.png.
* inspector/front-end/Images/forward.png: Renamed from WebCore/page/inspector/Images/forward.png.
* inspector/front-end/Images/glossyHeader.png: Renamed from WebCore/page/inspector/Images/glossyHeader.png.
* inspector/front-end/Images/glossyHeaderPressed.png: Renamed from WebCore/page/inspector/Images/glossyHeaderPressed.png.
* inspector/front-end/Images/glossyHeaderSelected.png: Renamed from WebCore/page/inspector/Images/glossyHeaderSelected.png.
* inspector/front-end/Images/glossyHeaderSelectedPressed.png: Renamed from WebCore/page/inspector/Images/glossyHeaderSelectedPressed.png.
* inspector/front-end/Images/goArrow.png: Renamed from WebCore/page/inspector/Images/goArrow.png.
* inspector/front-end/Images/largerResourcesButtons.png: Renamed from WebCore/page/inspector/Images/largerResourcesButtons.png.
* inspector/front-end/Images/nodeSearchButtons.png: Renamed from WebCore/page/inspector/Images/nodeSearchButtons.png.
* inspector/front-end/Images/paneBottomGrow.png: Renamed from WebCore/page/inspector/Images/paneBottomGrow.png.
* inspector/front-end/Images/paneBottomGrowActive.png: Renamed from WebCore/page/inspector/Images/paneBottomGrowActive.png.
* inspector/front-end/Images/paneGrowHandleLine.png: Renamed from WebCore/page/inspector/Images/paneGrowHandleLine.png.
* inspector/front-end/Images/pauseOnExceptionButtons.png: Renamed from WebCore/page/inspector/Images/pauseOnExceptionButtons.png.
* inspector/front-end/Images/percentButtons.png: Renamed from WebCore/page/inspector/Images/percentButtons.png.
* inspector/front-end/Images/profileGroupIcon.png: Renamed from WebCore/page/inspector/Images/profileGroupIcon.png.
* inspector/front-end/Images/profileIcon.png: Renamed from WebCore/page/inspector/Images/profileIcon.png.
* inspector/front-end/Images/profileSmallIcon.png: Renamed from WebCore/page/inspector/Images/profileSmallIcon.png.
* inspector/front-end/Images/profilesIcon.png: Renamed from WebCore/page/inspector/Images/profilesIcon.png.
* inspector/front-end/Images/recordButtons.png: Renamed from WebCore/page/inspector/Images/recordButtons.png.
* inspector/front-end/Images/reloadButtons.png: Renamed from WebCore/page/inspector/Images/reloadButtons.png.
* inspector/front-end/Images/resourceCSSIcon.png: Renamed from WebCore/page/inspector/Images/resourceCSSIcon.png.
* inspector/front-end/Images/resourceDocumentIcon.png: Renamed from WebCore/page/inspector/Images/resourceDocumentIcon.png.
* inspector/front-end/Images/resourceDocumentIconSmall.png: Renamed from WebCore/page/inspector/Images/resourceDocumentIconSmall.png.
* inspector/front-end/Images/resourceJSIcon.png: Renamed from WebCore/page/inspector/Images/resourceJSIcon.png.
* inspector/front-end/Images/resourcePlainIcon.png: Renamed from WebCore/page/inspector/Images/resourcePlainIcon.png.
* inspector/front-end/Images/resourcePlainIconSmall.png: Renamed from WebCore/page/inspector/Images/resourcePlainIconSmall.png.
* inspector/front-end/Images/resourcesIcon.png: Renamed from WebCore/page/inspector/Images/resourcesIcon.png.
* inspector/front-end/Images/resourcesSizeGraphIcon.png: Renamed from WebCore/page/inspector/Images/resourcesSizeGraphIcon.png.
* inspector/front-end/Images/resourcesTimeGraphIcon.png: Renamed from WebCore/page/inspector/Images/resourcesTimeGraphIcon.png.
* inspector/front-end/Images/scriptsIcon.png: Renamed from WebCore/page/inspector/Images/scriptsIcon.png.
* inspector/front-end/Images/searchSmallBlue.png: Renamed from WebCore/page/inspector/Images/searchSmallBlue.png.
* inspector/front-end/Images/searchSmallBrightBlue.png: Renamed from WebCore/page/inspector/Images/searchSmallBrightBlue.png.
* inspector/front-end/Images/searchSmallGray.png: Renamed from WebCore/page/inspector/Images/searchSmallGray.png.
* inspector/front-end/Images/searchSmallWhite.png: Renamed from WebCore/page/inspector/Images/searchSmallWhite.png.
* inspector/front-end/Images/segment.png: Renamed from WebCore/page/inspector/Images/segment.png.
* inspector/front-end/Images/segmentEnd.png: Renamed from WebCore/page/inspector/Images/segmentEnd.png.
* inspector/front-end/Images/segmentHover.png: Renamed from WebCore/page/inspector/Images/segmentHover.png.
* inspector/front-end/Images/segmentHoverEnd.png: Renamed from WebCore/page/inspector/Images/segmentHoverEnd.png.
* inspector/front-end/Images/segmentSelected.png: Renamed from WebCore/page/inspector/Images/segmentSelected.png.
* inspector/front-end/Images/segmentSelectedEnd.png: Renamed from WebCore/page/inspector/Images/segmentSelectedEnd.png.
* inspector/front-end/Images/splitviewDimple.png: Renamed from WebCore/page/inspector/Images/splitviewDimple.png.
* inspector/front-end/Images/splitviewDividerBackground.png: Renamed from WebCore/page/inspector/Images/splitviewDividerBackground.png.
* inspector/front-end/Images/statusbarBackground.png: Renamed from WebCore/page/inspector/Images/statusbarBackground.png.
* inspector/front-end/Images/statusbarBottomBackground.png: Renamed from WebCore/page/inspector/Images/statusbarBottomBackground.png.
* inspector/front-end/Images/statusbarButtons.png: Renamed from WebCore/page/inspector/Images/statusbarButtons.png.
* inspector/front-end/Images/statusbarMenuButton.png: Renamed from WebCore/page/inspector/Images/statusbarMenuButton.png.
* inspector/front-end/Images/statusbarMenuButtonSelected.png: Renamed from WebCore/page/inspector/Images/statusbarMenuButtonSelected.png.
* inspector/front-end/Images/statusbarResizerHorizontal.png: Renamed from WebCore/page/inspector/Images/statusbarResizerHorizontal.png.
* inspector/front-end/Images/statusbarResizerVertical.png: Renamed from WebCore/page/inspector/Images/statusbarResizerVertical.png.
* inspector/front-end/Images/timelinePillBlue.png: Renamed from WebCore/page/inspector/Images/timelinePillBlue.png.
* inspector/front-end/Images/timelinePillGray.png: Renamed from WebCore/page/inspector/Images/timelinePillGray.png.
* inspector/front-end/Images/timelinePillGreen.png: Renamed from WebCore/page/inspector/Images/timelinePillGreen.png.
* inspector/front-end/Images/timelinePillOrange.png: Renamed from WebCore/page/inspector/Images/timelinePillOrange.png.
* inspector/front-end/Images/timelinePillPurple.png: Renamed from WebCore/page/inspector/Images/timelinePillPurple.png.
* inspector/front-end/Images/timelinePillRed.png: Renamed from WebCore/page/inspector/Images/timelinePillRed.png.
* inspector/front-end/Images/timelinePillYellow.png: Renamed from WebCore/page/inspector/Images/timelinePillYellow.png.
* inspector/front-end/Images/tipBalloon.png: Renamed from WebCore/page/inspector/Images/tipBalloon.png.
* inspector/front-end/Images/tipBalloonBottom.png: Renamed from WebCore/page/inspector/Images/tipBalloonBottom.png.
* inspector/front-end/Images/tipIcon.png: Renamed from WebCore/page/inspector/Images/tipIcon.png.
* inspector/front-end/Images/tipIconPressed.png: Renamed from WebCore/page/inspector/Images/tipIconPressed.png.
* inspector/front-end/Images/toolbarItemSelected.png: Renamed from WebCore/page/inspector/Images/toolbarItemSelected.png.
* inspector/front-end/Images/treeDownTriangleBlack.png: Renamed from WebCore/page/inspector/Images/treeDownTriangleBlack.png.
* inspector/front-end/Images/treeDownTriangleWhite.png: Renamed from WebCore/page/inspector/Images/treeDownTriangleWhite.png.
* inspector/front-end/Images/treeRightTriangleBlack.png: Renamed from WebCore/page/inspector/Images/treeRightTriangleBlack.png.
* inspector/front-end/Images/treeRightTriangleWhite.png: Renamed from WebCore/page/inspector/Images/treeRightTriangleWhite.png.
* inspector/front-end/Images/treeUpTriangleBlack.png: Renamed from WebCore/page/inspector/Images/treeUpTriangleBlack.png.
* inspector/front-end/Images/treeUpTriangleWhite.png: Renamed from WebCore/page/inspector/Images/treeUpTriangleWhite.png.
* inspector/front-end/Images/userInputIcon.png: Renamed from WebCore/page/inspector/Images/userInputIcon.png.
* inspector/front-end/Images/userInputPreviousIcon.png: Renamed from WebCore/page/inspector/Images/userInputPreviousIcon.png.
* inspector/front-end/Images/warningIcon.png: Renamed from WebCore/page/inspector/Images/warningIcon.png.
* inspector/front-end/Images/warningMediumIcon.png: Renamed from WebCore/page/inspector/Images/warningMediumIcon.png.
* inspector/front-end/Images/warningsErrors.png: Renamed from WebCore/page/inspector/Images/warningsErrors.png.
* inspector/front-end/MetricsSidebarPane.js: Renamed from WebCore/page/inspector/MetricsSidebarPane.js.
* inspector/front-end/Object.js: Renamed from WebCore/page/inspector/Object.js.
* inspector/front-end/ObjectPropertiesSection.js: Renamed from WebCore/page/inspector/ObjectPropertiesSection.js.
* inspector/front-end/Panel.js: Renamed from WebCore/page/inspector/Panel.js.
* inspector/front-end/Placard.js: Renamed from WebCore/page/inspector/Placard.js.
* inspector/front-end/ProfileView.js: Renamed from WebCore/page/inspector/ProfileView.js.
* inspector/front-end/ProfilesPanel.js: Renamed from WebCore/page/inspector/ProfilesPanel.js.
* inspector/front-end/PropertiesSection.js: Renamed from WebCore/page/inspector/PropertiesSection.js.
* inspector/front-end/PropertiesSidebarPane.js: Renamed from WebCore/page/inspector/PropertiesSidebarPane.js.
* inspector/front-end/Resource.js: Renamed from WebCore/page/inspector/Resource.js.
* inspector/front-end/ResourceCategory.js: Renamed from WebCore/page/inspector/ResourceCategory.js.
* inspector/front-end/ResourceView.js: Renamed from WebCore/page/inspector/ResourceView.js.
* inspector/front-end/ResourcesPanel.js: Renamed from WebCore/page/inspector/ResourcesPanel.js.
* inspector/front-end/ScopeChainSidebarPane.js: Renamed from WebCore/page/inspector/ScopeChainSidebarPane.js.
* inspector/front-end/Script.js: Renamed from WebCore/page/inspector/Script.js.
* inspector/front-end/ScriptView.js: Renamed from WebCore/page/inspector/ScriptView.js.
* inspector/front-end/ScriptsPanel.js: Renamed from WebCore/page/inspector/ScriptsPanel.js.
* inspector/front-end/SidebarPane.js: Renamed from WebCore/page/inspector/SidebarPane.js.
* inspector/front-end/SidebarTreeElement.js: Renamed from WebCore/page/inspector/SidebarTreeElement.js.
* inspector/front-end/SourceFrame.js: Renamed from WebCore/page/inspector/SourceFrame.js.
* inspector/front-end/SourceView.js: Renamed from WebCore/page/inspector/SourceView.js.
* inspector/front-end/StylesSidebarPane.js: Renamed from WebCore/page/inspector/StylesSidebarPane.js.
* inspector/front-end/TextPrompt.js: Renamed from WebCore/page/inspector/TextPrompt.js.
* inspector/front-end/View.js: Renamed from WebCore/page/inspector/View.js.
* inspector/front-end/WebKit.qrc: Renamed from WebCore/page/inspector/WebKit.qrc.
* inspector/front-end/inspector.css: Renamed from WebCore/page/inspector/inspector.css.
* inspector/front-end/inspector.html: Renamed from WebCore/page/inspector/inspector.html.
* inspector/front-end/inspector.js: Renamed from WebCore/page/inspector/inspector.js.
* inspector/front-end/treeoutline.js: Renamed from WebCore/page/inspector/treeoutline.js.
* inspector/front-end/utilities.js: Renamed from WebCore/page/inspector/utilities.js.
2008-10-03 Timothy Hatcher <timothy@apple.com>
Adds support to the Web Inspector's Elements panel for fast tag name,
class name, id and attribute name searching. The panel first tries
using getElementById, getElementsByClassName and getElementsByTagName
with the search query. Then does a slower search using XPath for partial
matches, text and comment matches.
Adds support for search queries like "<div>", "<h" and "frame>".
These forms limit the search to tag names, text and comment matches.
https://bugs.webkit.org/show_bug.cgi?id=21353
Reviewed by Maciej Stachowiak.
* page/inspector/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.performSearch): Add tag syntax
support. Add new search functions that try exact matches first.
2008-10-03 Timothy Hatcher <timothy@apple.com>
Changes how searching works in the Web Inspector's Elements
panel. The search tasks are divided into chunks that are small
units of work that are performed at a time interval. This
change also prevents queries that will select all elements,
since that isn't useful.
https://bugs.webkit.org/show_bug.cgi?id=21285
Reviewed by Oliver Hunt.
* page/inspector/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.searchCancled):
Remove the searchResultsProperty form results since there might
be an unfinished search.
(WebInspector.ElementsPanel.prototype.performSearch): Divide the
documents and search functions into chunks that are performed on
a interval of 25ms. Prevent searches for "//*" and "*".
2008-10-03 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
- "this" object in methods called on primitives should be wrapper object
https://bugs.webkit.org/show_bug.cgi?id=21362
Updated so toThis conversion for the split window is handled properly.
* bindings/scripts/CodeGeneratorJS.pm:
2008-10-03 Sam Weinig <sam@webkit.org>
Reviewed by David "The Motivator" Hyatt.
Patch for https://bugs.webkit.org/show_bug.cgi?id=21355
Move SecurityOrigin out of platform/ to page/.
It was a layering violation for SecurityOrigin to be in platform
as it depended on FrameLoader.
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* page/SecurityOrigin.cpp: Copied from platform/SecurityOrigin.cpp.
* page/SecurityOrigin.h: Copied from platform/SecurityOrigin.h.
* page/SecurityOriginHash.h: Copied from platform/SecurityOriginHash.h.
* platform/SecurityOrigin.cpp: Removed.
* platform/SecurityOrigin.h: Removed.
* platform/SecurityOriginHash.h: Removed.
2008-10-03 Marco Barisione <marco.barisione@collabora.co.uk>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=18832
[curl] file upload does not work
The curl_off_t integer type has a different size depending if large
file support is enabled or not. There is no different public API for
the two cases, so the same function accepts a different type based on
a compilation option the could be different in WebKit and libcurl.
To fix the bug we query libcurl at runtime for large file support and
pass the right type based on that.
* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::setupPOST):
2008-10-03 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by David Hyatt.
Gtk build fixes.
* platform/gtk/FileChooserGtk.cpp:
(WebCore::FileChooser::openFileChooser):
* platform/gtk/PlatformScreenGtk.cpp:
(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
(WebCore::screenAvailableRect):
* platform/gtk/PopupMenuGtk.cpp:
(WebCore::PopupMenu::show):
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::platformAddChild):
(WebCore::ScrollView::platformRemoveChild):
* platform/gtk/WidgetGtk.cpp:
(WebCore::Widget::setCursor):
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::getValue):
(WebCore::PluginView::forceRedraw):
(WebCore::PluginView::init):
2008-10-03 David Hyatt <hyatt@apple.com>
Fix Qt bustage from missing include.
* platform/qt/PlatformScreenQt.cpp:
2008-10-03 David Hyatt <hyatt@apple.com>
Fix Windows scrollbar bustage in popup menus.
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupWndProc):
2008-10-03 David Hyatt <hyatt@apple.com>
Fix Windows bustage.
* platform/win/FileChooserWin.cpp:
(WebCore::FileChooser::openFileChooser):
* platform/win/PlatformScreenWin.cpp:
(WebCore::monitorInfoForWidget):
* platform/win/WidgetWin.cpp:
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::getValue):
(WebCore::PluginView::forceRedraw):
(WebCore::PluginView::init):
2008-10-03 Darin Adler <darin@apple.com>
* bindings/js/JSInspectedObjectWrapper.cpp: Try to fix a build failure
seen on some machines but not others by adding an include.
2008-10-03 Darin Adler <darin@apple.com>
- Qt build fix
* bridge/qt/qt_runtime.cpp: Remove long-obsolete codeType and
execute functions. Declarations for these relied on the CodeType
enumeration, which used to be in ExecState.h; but the functions
aren't needed at all.
* bridge/qt/qt_runtime.h: Ditto.
2008-10-03 Darin Adler <darin@apple.com>
Reviewed by Geoff Garen.
- next step of https://bugs.webkit.org/show_bug.cgi?id=21295
Turn ExecState into a call frame pointer.
Remove m_globalObject and m_globalData from ExecState.
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData):
Removed an argument now that JSGlobalObject doesn't need it any more.
(WebCore::JSDOMWindowBase::JSDOMWindowBase): Removed the argument from
the JSDOMWindowBaseData constructor, and added the this argument to the
JSGlobalObject constructor. This is because a couple key bits of
initialization moved from the data constructor to the JSGlobalObject
constructor.
* bindings/js/JSDOMWindowBase.h: Ditto.
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
* bridge/runtime_method.cpp:
(JSC::RuntimeMethod::RuntimeMethod):
Pass JSGlobalData* instead of ExecState* to the InternalFunction
constructor.
2008-10-03 David Hyatt <hyatt@apple.com>
Fix Windows/Qt build bustage.
Reviewed by ggaren
* loader/EmptyClients.h:
(WebCore::EmptyChromeClient::platformWindow):
* page/Chrome.cpp:
(WebCore::Chrome::platformWindow):
* page/Chrome.h:
* page/ChromeClient.h:
* platform/HostWindow.h:
* platform/qt/PlatformScreenQt.cpp:
(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
(WebCore::screenIsMonochrome):
(WebCore::screenRect):
(WebCore::screenAvailableRect):
* platform/qt/PopupMenuQt.cpp:
(WebCore::PopupMenu::show):
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::show):
(WebCore::PopupMenu::calculatePositionAndSize):
(WebCore::PopupWndProc):
2008-10-03 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dave Hyatt
Make setStyle() take a const RenderStyle, to ensure that an
earlier RenderStyle::diff() remains valid.
* rendering/RenderBR.cpp:
* rendering/RenderBR.h:
* rendering/RenderBlock.cpp:
* rendering/RenderBlock.h:
* rendering/RenderBox.cpp:
* rendering/RenderBox.h:
* rendering/RenderButton.cpp:
* rendering/RenderButton.h:
* rendering/RenderFieldset.cpp:
* rendering/RenderFieldset.h:
* rendering/RenderFileUploadControl.cpp:
* rendering/RenderFileUploadControl.h:
* rendering/RenderInline.cpp:
* rendering/RenderInline.h:
* rendering/RenderListBox.cpp:
* rendering/RenderListBox.h:
* rendering/RenderListItem.cpp:
* rendering/RenderListItem.h:
* rendering/RenderListMarker.cpp:
* rendering/RenderListMarker.h:
* rendering/RenderMenuList.cpp:
* rendering/RenderMenuList.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::setStyle):
* rendering/RenderObject.h:
* rendering/RenderReplaced.cpp:
* rendering/RenderReplaced.h:
* rendering/RenderSVGBlock.cpp:
(WebCore::RenderSVGBlock::setStyle):
* rendering/RenderSVGBlock.h:
* rendering/RenderSVGGradientStop.cpp:
* rendering/RenderSVGGradientStop.h:
* rendering/RenderSlider.cpp:
* rendering/RenderSlider.h:
* rendering/RenderTable.cpp:
* rendering/RenderTable.h:
* rendering/RenderTableCell.cpp:
* rendering/RenderTableCell.h:
* rendering/RenderTableRow.cpp:
* rendering/RenderTableRow.h:
* rendering/RenderText.cpp:
* rendering/RenderText.h:
* rendering/RenderTextControl.cpp:
* rendering/RenderTextControl.h:
* rendering/RenderWidget.cpp:
* rendering/RenderWidget.h:
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::isDisplayReplacedType):
(WebCore::RenderStyle::isDisplayInlineType):
2008-10-03 David Hyatt <hyatt@apple.com>
Preparation for enabling scrollbars to hit test properly inside transforms. Clean up the scrollbar
event handlers to no longer be virtual. Don't pass a mouse event where none is needed. Add a new
method on Scrollbars called transformEvent that will apply all of the transforms to make a new event
that will work properly for hit testing. This patch just stubs out that method to return the same
event untransformed.
Reviewed by Darin Adler
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseDoubleClickEvent):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::EventHandler::passMousePressEventToScrollbar):
* page/gtk/EventHandlerGtk.cpp:
* page/mac/EventHandlerMac.mm:
* page/qt/EventHandlerQt.cpp:
* page/win/EventHandlerWin.cpp:
* page/wx/EventHandlerWx.cpp:
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::mouseMoved):
(WebCore::Scrollbar::mouseExited):
(WebCore::Scrollbar::mouseUp):
(WebCore::Scrollbar::mouseDown):
(WebCore::Scrollbar::transformEvent):
* platform/Scrollbar.h:
2008-10-03 David Hyatt <hyatt@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=21340
Remove "containingWindow()/setContainingWindow()" from Widget. HostWindow covers this now.
Reviewed by Dan Bernstein & Darin Adler
* platform/ScrollView.cpp:
(WebCore::ScrollView::addChild):
* platform/Widget.cpp:
(WebCore::Widget::init):
* platform/Widget.h:
* platform/mac/WidgetMac.mm:
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::show):
2008-10-03 Adele Peterson <adele@apple.com>
Reviewed by Sam Weinig.
* css/CSSFontSelector.cpp: (WebCore::fontDataForGenericFamily):
Return early if settings is nil.
2008-10-03 Rob Buis <buis@kde.org>
Reviewed by Darin.
https://bugs.webkit.org/show_bug.cgi?id=20134
REGRESSION (2.0.4-3.0.4): No default value set for <input type=range> with an even difference of (max - min)
Make sure the input element gets the right default value when no value is set.
Test: fast/forms/range-default-value.html
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::setPositionFromValue):
2008-10-03 David Hyatt <hyatt@apple.com>
Instead of a cross-platform init/destroy that forces every ScrollView platform to have a constructor/
destructor that calls them, switch to having a cross-platform constructor/destructor that calls
platform-specific init/destroy methods.
With this change, ScrollViewWin.cpp can be removed from the build (yay!).
Reviewed by Darin Adler
* WebCore.vcproj/WebCore.vcproj:
* platform/ScrollView.cpp:
(WebCore::ScrollView::ScrollView):
(WebCore::ScrollView::~ScrollView):
(WebCore::ScrollView::platformInit):
(WebCore::ScrollView::platformDestroy):
(WebCore::ScrollView::platformAddChild):
(WebCore::ScrollView::platformRemoveChild):
* platform/ScrollView.h:
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::platformInit):
(WebCore::ScrollView::platformDestroy):
* platform/mac/ScrollViewMac.mm:
* platform/qt/ScrollViewQt.cpp:
(WebCore::ScrollView::platformInit):
(WebCore::ScrollView::platformDestroy):
* platform/win/ScrollViewWin.cpp: Removed.
* platform/wx/ScrollViewWx.cpp:
(WebCore::ScrollView::platformInit):
(WebCore::ScrollView::platformDestroy):
(WebCore::ScrollView::setPlatformWidget):
2008-10-03 Adele Peterson <adele@apple.com>
Reviewed by Dan Bernstein.
Fix for <rdar://problem/6012018>
https://bugs.webkit.org/show_bug.cgi?id=21335
CrashTracer: [USER] 4959 crashes in Safari at com.apple.WebCore: WebCore::Frame::settings const + 8
* css/CSSFontSelector.cpp: (WebCore::fontDataForGenericFamily): Return early if the frame is nil.
2008-10-03 Ariya Hidayat <ariya.hidayat@trolltech.com>
Build fix.
* platform/qt/WidgetQt.cpp:
(WebCore::Widget::invalidateRect):
2008-10-03 Alp Toker <alp@nuanti.com>
Remove some left-over GTK+ includes. No change in functionality.
* platform/Cursor.h:
* platform/graphics/Icon.h:
* platform/gtk/RenderThemeGtk.h:
2008-10-03 Alp Toker <alp@nuanti.com>
Build fix for trailing comment after #endif
* dom/ElementRareData.h:
2008-10-03 David Hyatt <hyatt@apple.com>
Remove addToDirtyRegion.
Reviewed by Oliver Hunt
* page/Chrome.cpp:
* page/Chrome.h:
* page/ChromeClient.h:
* platform/ScrollView.h:
* platform/gtk/ScrollViewGtk.cpp:
* platform/qt/ScrollViewQt.cpp:
* platform/win/ScrollViewWin.cpp:
2008-10-03 Dan Bernstein <mitz@apple.com>
Reviewed by Maciej Stachowiak.
- fix a CachedResource leak introduced in r37176
Undo r37176 and instead allow pruneDeadResources() to be re-entered, but
afterwards bail out of the outer pruneDeadResources().
* loader/Cache.cpp:
(WebCore::Cache::Cache):
(WebCore::Cache::pruneDeadResources):
(WebCore::Cache::remove):
* loader/Cache.h:
2008-10-03 David Hyatt <hyatt@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=21330
Fix Gtk adjustments so that they are properly checked again before creating horizontal/vertical
scrollbars.
Reviewed by Oliver Hunt
* platform/ScrollView.cpp:
(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):
(WebCore::ScrollView::platformHasHorizontalAdjustment):
(WebCore::ScrollView::platformHasVerticalAdjustment):
* platform/ScrollView.h:
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::adjustmentChanged):
(WebCore::ScrollView::ScrollView):
(WebCore::ScrollView::~ScrollView):
(WebCore::ScrollView::setGtkAdjustments):
(WebCore::ScrollView::platformHandleHorizontalAdjustment):
(WebCore::ScrollView::platformHandleVerticalAdjustment):
2008-10-03 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Maciej Stachowiak.
Bug 21106: .in format discussed changes
https://bugs.webkit.org/show_bug.cgi?id=21106
Change "upperCase" to "interfaceName" per-tag parameter as
discussed on the mailing list. Removed the per-attribute version
as it was not used.
Also add the "Element" suffix to all interfaceName parameter to match
the class name (and thus remove it from make_names.pl).
* dom/make_names.pl:
* html/HTMLTagNames.in:
* svg/svgtags.in:
2008-10-03 David Hyatt <hyatt@apple.com>
Preserve Qt's disabling of blitting when any native widgets are present anywhere on the page (ick).
Hopefully this is a temporary hack that could eventually be removed.
Reviewed by Sam Weinig
* platform/ScrollView.cpp:
(WebCore::ScrollView::scrollContents):
* platform/ScrollView.h:
(WebCore::ScrollView::rootPreventsBlitting):
* platform/qt/ScrollViewQt.cpp:
(WebCore::ScrollView::ScrollView):
(WebCore::ScrollView::~ScrollView):
(WebCore::ScrollView::platformAddChild):
(WebCore::ScrollView::platformRemoveChild):
2008-10-02 David Hyatt <hyatt@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=21328
Make widget invalidation more cross-platform.
(1) Make invalidateRect a pure virtual function on Widget. All leaf widgets must now implement this function.
(2) Scrollbars now send invalidations through the ScrollbarClient. windowClipRect on ScrollbarClient has been removed and replaced with this invalidation call.
This allows all scrollbar invalidations to go through the render tree so that transforms and reflections will be respected.
(3) Plugins now have the native window invalidation code for windowed plugins. Windowless plugins do a repaintRectangle on the plugin's renderer.
(4) FrameViews now do a repaintRectangle on their owner element's renderer.
Reviewed by Sam Weinig
* WebCore.base.exp:
* page/FrameView.cpp:
(WebCore::FrameView::invalidateRect):
(WebCore::FrameView::invalidateScrollbarRect):
* page/FrameView.h:
* platform/PopupMenu.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::scrollContents):
* platform/ScrollView.h:
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::setEnabled):
(WebCore::Scrollbar::invalidateRect):
* platform/Scrollbar.h:
* platform/ScrollbarClient.h:
* platform/Widget.h:
* platform/gtk/WidgetGtk.cpp:
* platform/mac/WidgetMac.mm:
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::invalidateScrollbarRect):
* platform/win/WidgetWin.cpp:
* plugins/PluginView.cpp:
(WebCore::PluginView::invalidateTimerFired):
(WebCore::PluginView::invalidateWindowlessPluginRect):
* plugins/PluginView.h:
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::invalidateRect):
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::invalidateRect):
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::invalidateRect):
(WebCore::PluginView::invalidateRegion):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::invalidateScrollbarRect):
* rendering/RenderLayer.h:
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::paintObject):
(WebCore::RenderListBox::paintScrollbar):
(WebCore::RenderListBox::invalidateScrollbarRect):
* rendering/RenderListBox.h:
2008-10-02 Dan Bernstein <mitz@apple.com>
Reviewed by Geoffrey Garen and Sam Weinig.
- fix SVGFontFaceElement leaks seen in Acid3
- make font-face elements take effect only when they are in the document tree
Test: svg/custom/font-face-not-in-document.svg
* svg/SVGFontData.h: Changed the m_svgFontFaceElement member from a
RefPtr to a plain pointer to break a ref cycle.
(WebCore::SVGFontData::svgFontFaceElement):
* svg/SVGFontFaceElement.cpp: Changed to insert and remove the
@font-face rule from the document's mapped element sheet when the
element is inserted and removed from the document, and to update it
only when the element is in the document.
(WebCore::SVGFontFaceElement::SVGFontFaceElement):
(WebCore::SVGFontFaceElement::parseMappedAttribute):
(WebCore::SVGFontFaceElement::rebuildFontFace):
(WebCore::SVGFontFaceElement::insertedIntoDocument):
(WebCore::SVGFontFaceElement::removedFromDocument):
(WebCore::SVGFontFaceElement::childrenChanged):
(WebCore::SVGFontFaceElement::removeFromMappedElementSheet):
* svg/SVGFontFaceElement.h:
2008-10-01 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dave Hyatt
Fix RenderFileUploadControl::setStyle() and
RenderMenuList::setStyle() to not touch the style; replace
with html4.css and CSSStyleSelector changes.
https://bugs.webkit.org/show_bug.cgi?id=21287
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::adjustRenderStyle):
* css/html4.css:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::setStyle):
* rendering/RenderFileUploadControl.cpp:
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::setStyle):
2008-10-01 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dave Hyatt
Clean up code that changes the RenderStyle passed in to
table renderer setStyle() methods.
https://bugs.webkit.org/show_bug.cgi?id=21287
Tests: fast/table/floating-th.html
fast/table/table-display-types-strict.html
fast/table/table-display-types.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::adjustRenderStyle):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::setStyle):
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::setStyle):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::setStyle):
2008-10-02 Darin Adler <darin@apple.com>
- fix build
* bindings/scripts/CodeGeneratorJS.pm: Need to replace the -> with a . here too.
Not just locally in my generated file!
2008-10-02 Adele Peterson <adele@apple.com>
Reviewed by Dan Bernstein.
Fix for https://bugs.webkit.org/show_bug.cgi?id=21299
REGRESSION: <input> color specified in inline style applies to placeholder
I recently added a pseudo-class for the placeholder, but that can be overridden by inline style changes. A pseudo-element
is more appropriate. This change adds "-webkit-input-placeholder".
* css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
Added definition for "-webkit-input-placeholder" pseudo element.
* css/CSSSelector.h: (WebCore::CSSSelector::): Added PseudoInputPlaceholder.
* css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
Added case for PseudoInputPlaceholder.
* css/html4.css: Added rule for -webkit-input-placeholder pseudo-element.
* rendering/style/RenderStyle.h: (WebCore::RenderStyle::): Added INPUT_PLACEHOLDER.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setValue): Check that its a text field before calling updatePlaceholderVisibility.
(WebCore::HTMLInputElement::setValueFromRenderer): ditto.
(WebCore::HTMLInputElement::updatePlaceholderVisibility): Instead of calling setChanged(), call updatePlaceholderVisibility on the renderer.
setChanged wouldn't actually trigger setStyle since the style for the input element won't actually change.
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::createInnerTextStyle): Get the pseudoStyle when the placeholder is visible.
(WebCore::RenderTextControl::updatePlaceholderVisibility): Sets the style on the inner text block, and calls updateFromElement so
the text will be updated correctly.
* rendering/RenderTextControl.h:
2008-10-02 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=21280
<rdar://problem/6227690> There are a bunch of tables on this page that don't seem to be real tables
Updated AXTable detection to be more robust to false-positives. Specifically, added checks
to ensure that there is more than one valid table cell, and that at least half of the cells
have borders or have specific background colors. Modified the table detection layout test
to test for the tables mentioned in the bug
* page/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
2008-10-02 Darin Adler <darin@apple.com>
Reviewed by Geoff Garen.
- https://bugs.webkit.org/show_bug.cgi?id=21321
Bug 21321: speed up JavaScriptCore by inlining Heap in JSGlobalData
* bindings/js/GCController.cpp:
(WebCore::collect): Use heap. instead of heap-> to work with the heap.
(WebCore::GCController::gcTimerFired): Ditto.
(WebCore::GCController::garbageCollectNow): Ditto.
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::operator new): Ditto.
* storage/Database.cpp:
(WebCore::Database::Database): Ditto.
2008-10-02 Dan Bernstein <mitz@apple.com>
Reviewed by Alexey Proskuryakov.
- fix a Database leak that resulted in Document leaks
* storage/Database.cpp:
(WebCore::Database::openDatabase): Account for the fact that RefCounted
objects start out with a ref count of 1.
2008-10-02 Sam Weinig <sam@webkit.org>
Reviewed by Mr. Geoffrey Garen.
Always mark your parent before marking members.
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::mark):
2008-10-02 David Hyatt <hyatt@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=21314
Make scrollBackingStore cross-platform.
Reviewed by Sam Weinig
* loader/EmptyClients.h:
(WebCore::EmptyChromeClient::repaint):
(WebCore::EmptyChromeClient::scroll):
* page/Chrome.cpp:
(WebCore::Chrome::repaint):
(WebCore::Chrome::scroll):
* page/Chrome.h:
* page/ChromeClient.h:
* page/EventHandler.cpp:
(WebCore::EventHandler::handleAutoscroll):
* platform/HostWindow.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::scrollContents):
(WebCore::ScrollView::addPanScrollIcon):
(WebCore::ScrollView::removePanScrollIcon):
* platform/ScrollView.h:
* platform/gtk/ScrollViewGtk.cpp:
* platform/qt/ScrollViewQt.cpp:
(WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
(WebCore::ScrollView::~ScrollView):
* platform/win/ScrollViewWin.cpp:
(WebCore::ScrollView::ScrollView):
(WebCore::ScrollView::~ScrollView):
2008-10-02 Kevin Ollivier <kevino@theolliviers.com>
wx build fixes after Frame/ScrollView changes.
* WebCoreSources.bkl:
* platform/wx/ScrollViewWx.cpp:
(WebCore::ScrollView::platformContentsToScreen):
(WebCore::ScrollView::platformScreenToContents):
(WebCore::ScrollView::platformIsOffscreen):
2008-10-02 Brett Wilson <brettw@chromium.org>
Reviewed by Sam Weinig
https://bugs.webkit.org/show_bug.cgi?id=21292
Revert the changes to enclosingIntRect made in r12530 since the new code
doesn't round correctly.
* ChangeLog:
* platform/graphics/FloatRect.cpp:
(WebCore::enclosingIntRect):
2008-10-02 Dan Bernstein <mitz@apple.com>
Reviewed by Anders Carlsson and Eric Seidel.
- fix HTMLCanvaseElement leak from -webkit-canvas() values
Changed the m_element member of CSSCanvasValue from a RefPtr to a plain
pointer, as the document owns the canvas elements. Added code to release
those elements in Document::removedLastRef() because they reference
the document.
* css/CSSCanvasValue.cpp:
(WebCore::CSSCanvasValue::element):
* css/CSSCanvasValue.h:
(WebCore::CSSCanvasValue::CSSCanvasValue):
* dom/Document.cpp:
(WebCore::Document::removedLastRef):
2008-10-02 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Maciej Stachowiak.
Build fix for platforms that don't implement WTF::ThreadSpecific.
* bindings/js/JSDOMBinding.cpp: (WebCore::wrapperSet):
Guard ThreadSpecific use with #if ENABLE(WORKERS). No platform defines this yet, but this
code is only needed for JS bindings in worker threads.
2008-10-01 David Hyatt <hyatt@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=21298
Make updateScrollbars cross-platform. For now a stubbed out scrollContents function is invoked to do the scrolling of the backing store. Next patch
will make that cross-platform.
The ScrollView now implements ScrollbarClient, which means that there was a clash of windowClipRect methods from the
multiple inheritance. For now I solved this by adding a Scrollbar* to the ScrollbarClient version of the method, but longer term
windowClipRect is going to be removed from ScrollbarClient (when Widget invalidation gets rewritten).
Reviewed by Sam Weinig
* page/FrameView.cpp:
(WebCore::FrameView::windowClipRect):
(WebCore::FrameView::isActive):
* page/FrameView.h:
(WebCore::FrameView::visibleContentsResized):
* platform/PopupMenu.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::init):
(WebCore::ScrollView::destroy):
(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):
(WebCore::ScrollView::valueChanged):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::scrollContents):
(WebCore::ScrollView::platformHandleHorizontalAdjustment):
(WebCore::ScrollView::platformHandleVerticalAdjustment):
* platform/ScrollView.h:
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::windowClipRect):
* platform/ScrollbarClient.h:
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::platformHandleHorizontalAdjustment):
(WebCore::ScrollView::platformHandleVerticalAdjustment):
* platform/qt/ScrollViewQt.cpp:
(WebCore::ScrollView::scrollContents):
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::windowClipRect):
* platform/win/ScrollViewWin.cpp:
(WebCore::ScrollView::scrollContents):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::windowClipRect):
* rendering/RenderLayer.h:
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::panScroll):
(WebCore::RenderListBox::windowClipRect):
* rendering/RenderListBox.h:
2008-10-02 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=21304
Stop using a static wrapper map for WebCore JS bindings
The static domObjects map was not thread safe.
* dom/Document.h:
(WebCore::Document::messagePorts): Added an accessor for JSDocument to iterate over message
ports.
(WebCore::Document::xmlHttpRequests): Ditto for XMLHttpRequests.
* dom/Document.cpp:
(WebCore::Document::createdXMLHttpRequest):
(WebCore::Document::destroyedXMLHttpRequest):
Moved XMLHttpRequest tracking from a global map to Document.
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* webcore-base.bkl:
* bindings/DOMProtect.cpp: Removed.
* bindings/DOMProtect.h: Removed.
Removed gcProtect(Unprotect)DOMObject - its callers do not have a JSGlobalData reference,
so they can no longer protect bindings objects.
* dom/MessagePort.cpp:
(WebCore::CloseMessagePortTimer::CloseMessagePortTimer):
(WebCore::CloseMessagePortTimer::fired):
(WebCore::MessagePort::MessagePort):
(WebCore::MessagePort::queueCloseEvent):
(WebCore::MessagePort::setPendingActivity):
(WebCore::MessagePort::unsetPendingActivity):
* dom/MessagePort.h:
(WebCore::MessagePort::hasPendingActivity):
MessagePort now counts outstanding async events, so JSDocument::mark can decide whether
to protect it.
* xml/XMLHttpRequest.h:
(WebCore::XMLHttpRequest::hasPendingActivity):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::~XMLHttpRequest):
(WebCore::XMLHttpRequest::loadRequestAsynchronously):
(WebCore::XMLHttpRequest::dropProtection):
(WebCore::XMLHttpRequest::didFinishLoadingPreflight):
(WebCore::XMLHttpRequest::cancelRequests):
(WebCore::XMLHttpRequest::detachRequests):
(WebCore::XMLHttpRequest::setPendingActivity):
(WebCore::XMLHttpRequest::unsetPendingActivity):
Moved XMLHttpRequest tracking from a global map to Document.
* bindings/js/JSDOMBinding.cpp:
(WebCore::wrapperSet):
(WebCore::DOMObjectWrapperMap::mapFor):
(WebCore::DOMObjectWrapperMap::get):
(WebCore::DOMObjectWrapperMap::set):
(WebCore::DOMObjectWrapperMap::remove):
(WebCore::getCachedDOMObjectWrapper):
(WebCore::cacheDOMObjectWrapper):
(WebCore::forgetDOMObject):
(WebCore::getCachedDOMNodeWrapper):
(WebCore::forgetDOMNode):
(WebCore::cacheDOMNodeWrapper):
(WebCore::markActiveObjectsForDocument):
* bindings/js/JSDOMBinding.h:
(WebCore::createDOMObjectWrapper):
(WebCore::getDOMObjectWrapper):
Wrapper map is now kept as JSGlobalData::clientData. Also changed debug-only wrapperSet
to be per-thread (this is slower than going to JSGlobalData, but fast enough for debug).
WebCore objects can never migrate between threads.
* bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::mark):
Call markActiveObjectsForDocument() from JSDOMBinding.
* bindings/js/JSCSSRuleCustom.cpp:
(WebCore::toJS):
* bindings/js/JSCSSValueCustom.cpp:
(WebCore::toJS):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::markDOMObjectWrapper):
(WebCore::JSDOMWindow::mark):
* bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
* bindings/js/JSEventTarget.cpp:
(WebCore::toJS):
* bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::toJS):
* bindings/js/JSImageDataCustom.cpp:
(WebCore::toJS):
* bindings/js/JSMessageChannelCustom.cpp:
(WebCore::JSMessageChannel::mark):
* bindings/js/JSMessagePortCustom.cpp:
(WebCore::JSMessagePort::mark):
* bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::mark):
* bindings/js/JSSVGPathSegCustom.cpp:
(WebCore::toJS):
* bindings/js/JSStyleSheetCustom.cpp:
(WebCore::toJS):
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::mark):
* bindings/js/JSXMLHttpRequestUploadCustom.cpp:
(WebCore::JSXMLHttpRequestUpload::mark):
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::finishedWithEvent):
* bindings/scripts/CodeGeneratorJS.pm:
Pass a JSGlobalData reference to functions that track JS wrapper objects.
2008-10-02 Dan Bernstein <mitz@apple.com>
- build fix
* page/JavaScriptCallFrame.idl:
2008-10-02 Oliver Hunt <oliver@apple.com>
Reviewed by NOBODY (Build fix).
Add new file to project files
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
2008-10-02 Geoffrey Garen <ggaren@apple.com>
Not reviewed.
Try to fix some more builds.
* GNUmakefile.am:
* WebCore.pro:
2008-10-02 Geoffrey Garen <ggaren@apple.com>
Not reviewed.
Try to fix Windows build.
* WebCore.vcproj/WebCore.vcproj:
2008-10-01 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler and Cameron Zwarich.
Updated for JavaScriptCore API changes: use a SourceCode instead of
broken out parameters; treat sourceId as intptr_t.
* ForwardingHeaders/kjs/SourceRange.h: Copied from ForwardingHeaders/kjs/SourceProvider.h.
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::send):
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::evaluate):
* bindings/js/StringSourceProvider.h:
(WebCore::StringSourceProvider::create):
(WebCore::StringSourceProvider::StringSourceProvider):
(WebCore::makeSource): Added a makeSource function for convenience.
* bindings/objc/WebScriptObject.mm:
(-[WebScriptObject evaluateWebScript:]):
* bridge/NP_jsobject.cpp:
(_NPN_Evaluate):
* bridge/jni/jni_jsobject.mm:
(JavaJSObject::call):
(JavaJSObject::eval):
(JavaJSObject::getMember):
(JavaJSObject::setMember):
(JavaJSObject::removeMember):
* bridge/jni/jni_runtime.h:
(JSC::Bindings::JavaString::operator UString): Replaced the explicit
ustring() function with an implicit operator because this class already
holds a UString::rep.
* page/Console.cpp:
(WebCore::retrieveLastCaller):
(WebCore::Console::trace):
* page/InspectorController.cpp:
(WebCore::jsStringRef):
(WebCore::InspectorController::addBreakpoint):
(WebCore::InspectorController::removeBreakpoint):
(WebCore::InspectorController::didParseSource):
(WebCore::InspectorController::failedToParseSource):
* page/InspectorController.h:
* page/JavaScriptCallFrame.cpp:
(WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
* page/JavaScriptCallFrame.h:
(WebCore::JavaScriptCallFrame::create):
(WebCore::JavaScriptCallFrame::sourceIdentifier):
(WebCore::JavaScriptCallFrame::update):
* page/JavaScriptDebugListener.h:
* page/JavaScriptDebugServer.cpp:
(WebCore::JavaScriptDebugServer::addBreakpoint):
(WebCore::JavaScriptDebugServer::removeBreakpoint):
(WebCore::JavaScriptDebugServer::hasBreakpoint):
(WebCore::dispatchDidParseSource):
(WebCore::dispatchFailedToParseSource):
(WebCore::JavaScriptDebugServer::sourceParsed):
(WebCore::JavaScriptDebugServer::callEvent):
(WebCore::JavaScriptDebugServer::atStatement):
(WebCore::JavaScriptDebugServer::returnEvent):
(WebCore::JavaScriptDebugServer::exception):
(WebCore::JavaScriptDebugServer::willExecuteProgram):
(WebCore::JavaScriptDebugServer::didExecuteProgram):
(WebCore::JavaScriptDebugServer::didReachBreakpoint):
* page/JavaScriptDebugServer.h:
* page/inspector/ScriptsPanel.js: Renamed internal uses of sourceId and
sourceIdentifier to sourceID.
2008-10-01 Dan Bernstein <mitz@apple.com>
Reviewed by Geoffrey Garen.
- fix SVGFontFaceElement leak seen on svg/custom/acid3-test-77.html
Broke a ref cycle by changing the m_svgFontFaceElement members of
CSSFontFaceSource and CSSFontFaceSrcValue from RefPtrs to plain
pointers. Also made sure that the @font-face rule added by
SVGFontFaceElement to the document's mapped element sheet is removed
when the font-face element is deleted or moved to another document.
* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::CSSFontFaceSource):
(WebCore::CSSFontFaceSource::getFontData):
* css/CSSFontFaceSource.h:
(WebCore::CSSFontFaceSource::svgFontFaceElement):
* css/CSSFontFaceSrcValue.h:
(WebCore::CSSFontFaceSrcValue::svgFontFaceElement):
(WebCore::CSSFontFaceSrcValue::CSSFontFaceSrcValue):
* svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::~SVGFontFaceElement):
(WebCore::SVGFontFaceElement::willMoveToNewOwnerDocument):
(WebCore::SVGFontFaceElement::didMoveToNewOwnerDocument):
(WebCore::SVGFontFaceElement::removeFromMappedElementSheet):
* svg/SVGFontFaceElement.h:
2008-10-01 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Bug 20315: Memory leak with Canvas getImageData
<https://bugs.webkit.org/show_bug.cgi?id=20315>
This wasn't a leak, the issue was that we were reporting the cost
of the CanvasPixelArray when creating the JSCanvasPixelArray wrapper
and we should have been reporting the cost when we create the
JSImageData wrapper.
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSCanvasPixelArrayCustom.cpp: Removed.
This was only needed to report the extra memory cost
of the CPA.
* bindings/js/JSImageDataCustom.cpp:
(WebCore::toJS):
We need a custom toJS function now so that we can report
the extra memory cost.
* bindings/scripts/CodeGeneratorJS.pm:
Need to replace the reference to CanvasPixelArray with ImageData
to be able to create the custom toJS implementation.
* html/CanvasPixelArray.idl:
* html/ImageData.idl:
2008-10-01 Dan Bernstein <mitz@apple.com>
Reviewed by Mark Rowe.
- https://bugs.webkit.org/show_bug.cgi?id=21293
REGRESSION: Crash beneath RenderSVGViewportContainer::viewportTransform() during SVGSVGElement destruction
* svg/SVGMarkerElement.cpp:
(WebCore::SVGMarkerElement::~SVGMarkerElement): Call detach() here so
that renderer destruction happens before the SVGMarkerElement is
destroyed.
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::~SVGSVGElement): Ditto for SVGSVGElement.
2008-10-01 Evan Martin <evan@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=20669
* css/makeprop.pl:
Die if gperf fails.
2008-10-01 Evan Martin <evan@chromium.org>
Reviewed by Eric Seidel.
* loader/icon/IconDatabase.h:
IconDatabase uses HashMap, so it needs to #include the header.
2008-10-01 Dan Bernstein <mitz@apple.com>
Reviewed by Mark Rowe.
- fix an assertion failure in http/tests/security/canvas-remote-read-svg-image.html due to re-entry into Cache::pruneDeadResources()
* loader/Cache.cpp:
(WebCore::Cache::remove): Disable pruning temporarily during
CachedResource deletion.
2008-10-01 Dan Bernstein <mitz@apple.com>
Reviewed by Mark Rowe.
- fix SVGFontElement leaks seen on buildbot by breaking a ref cycle
* svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::rebuildFontFace):
* svg/SVGFontFaceElement.h:
(WebCore::SVGFontFaceElement::associatedFontElement):
2008-10-01 Brett Wilson <brettw@chromium.org>
Reviewed by Maciej Stachowiak.
Document the rounding behavior of the mapRect(IntRect) function in
AffineTransform.h.
* platform/graphics/AffineTransform.h:
2008-10-01 David Hyatt <hyatt@apple.com>
Move prohibitsScrolling from the Frame to the ScrollView.
Reviewed by Sam Weinig
* WebCore.base.exp:
* page/Frame.cpp:
(WebCore::FramePrivate::FramePrivate):
* page/Frame.h:
* page/FramePrivate.h:
* page/FrameView.cpp:
(WebCore::FrameView::scrollRectIntoViewRecursively):
(WebCore::FrameView::setScrollPosition):
* platform/ScrollView.cpp:
(WebCore::ScrollView::init):
(WebCore::ScrollView::scrollRectIntoViewRecursively):
(WebCore::ScrollView::setScrollPosition):
* platform/ScrollView.h:
(WebCore::ScrollView::setProhibitsScrolling):
(WebCore::ScrollView::prohibitsScrolling):
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::updateScrollbars):
* platform/qt/ScrollViewQt.cpp:
(WebCore::ScrollView::updateScrollbars):
* platform/win/ScrollViewWin.cpp:
(WebCore::ScrollView::updateScrollbars):
2008-10-01 Mark Rowe <mrowe@apple.com>
Reviewed by Geoff Garen.
Fix leaks seen during http/tests/xmlhttprequest/access-control-basic-non-simple-allow.html.
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::didFinishLoadingPreflight): Balance the ref and GC protect
that we do during the loadRequestAsynchronously of the preflight request with a deref and
GC unprotect.
2008-10-01 David Hyatt <hyatt@apple.com>
Rename allowsScrolling/setAllowsScrolling to canHaveScrollbars/setCanHaveScrollbars to make it more
clear that the boolean doesn't actually stop all scrolling. It just gets rid of scrollbars.
Reviewed by Tim Hatcher
* WebCore.base.exp:
* page/FrameView.cpp:
(WebCore::FrameView::setCanHaveScrollbars):
* page/FrameView.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::setCanHaveScrollbars):
(WebCore::ScrollView::wheelEvent):
* platform/ScrollView.h:
(WebCore::ScrollView::canHaveScrollbars):
2008-10-01 Dan Bernstein <mitz@apple.com>
Reviewed by Mark Rowe.
- fix some CachedResource leaks seen on buildbot
The issue here was that emptying the cache was a no-op when it only
contained resources with no data. Changed to go after those
resources when the desired cache capacity is zero.
* loader/Cache.cpp:
(WebCore::Cache::pruneLiveResources):
(WebCore::Cache::pruneDeadResources):
* loader/Cache.h:
(WebCore::Cache::prune):
2008-10-01 David Hyatt <hyatt@apple.com>
Make isOffscreen cross-platform. Only Mac implements this method, so hold off on adding API to the
HostWindow object until other platforms decide they want this method. (We need it for Win though at some point.)
Reviewed by Adam Roben
* platform/ScrollView.cpp:
(WebCore::ScrollView::isOffscreen):
(WebCore::ScrollView::platformIsOffscreen):
* platform/ScrollView.h:
* platform/gtk/ScrollViewGtk.cpp:
* platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::platformIsOffscreen):
* platform/qt/ScrollViewQt.cpp:
* platform/wx/ScrollViewWx.cpp:
2008-10-01 David Hyatt <hyatt@apple.com>
Make show/hide/setParentVisible cross-platform on ScrollView.
Reviewed by Adam Roben
* platform/ScrollView.cpp:
(WebCore::ScrollView::setParentVisible):
(WebCore::ScrollView::show):
(WebCore::ScrollView::hide):
* platform/ScrollView.h:
* platform/win/ScrollViewWin.cpp:
2008-10-01 Kevin McCullough <kmccullough@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=21284
Bug 21284: Max height affects max width
- Looks like a cut and paste bug
- Added layout test fast/css/max-height-and-max-width.html
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2008-10-01 David Hyatt <hyatt@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=21282
Make contentsToScreen/screenToContents cross-platform. Only implemented by Mac/Win right now.
Reviewed by Adam Roben
* loader/EmptyClients.h:
(WebCore::EmptyChromeClient::screenToWindow):
(WebCore::EmptyChromeClient::windowToScreen):
* page/Chrome.cpp:
(WebCore::Chrome::screenToWindow):
(WebCore::Chrome::windowToScreen):
* page/Chrome.h:
* page/ChromeClient.h:
* platform/HostWindow.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::contentsToScreen):
(WebCore::ScrollView::screenToContents):
(WebCore::ScrollView::platformContentsToScreen):
(WebCore::ScrollView::platformScreenToContents):
* platform/ScrollView.h:
* platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::platformContentsToScreen):
(WebCore::ScrollView::platformScreenToContents):
* platform/win/ScrollViewWin.cpp:
2008-10-01 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
- fix <rdar://problem/6255862> domfuzz: null deref in WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks(WebCore::HTMLStackElem*)
Test: fast/parser/residual-style-close-across-removed-block.html
* html/HTMLParser.cpp:
(WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Removed
an assertion that turned out to be wrong in this case, and changed to
terminate the algorithm at the first empty block.
2008-10-01 David Hyatt <hyatt@apple.com>
Make setFrameRect on ScrollView cross-platform.
Reviewed by Sam Weinig
* page/FrameView.h:
(WebCore::FrameView::contentsResized):
* platform/ScrollView.cpp:
(WebCore::ScrollView::setFrameRect):
* platform/ScrollView.h:
* platform/gtk/ScrollViewGtk.cpp:
* platform/qt/ScrollViewQt.cpp:
* platform/win/ScrollViewWin.cpp:
2008-10-01 Sam Weinig <sam@webkit.org>
Reviewed by Adele Peterson.
Move setTimeout, clearTimeout, setInterval, clearInterval, atob and btoa
to JSDOMWindow from JSDOMWindowBase.
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::removeTimeout):
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::setTimeoutOrInterval):
(WebCore::JSDOMWindow::setTimeout):
(WebCore::JSDOMWindow::clearTimeout):
(WebCore::JSDOMWindow::setInterval):
(WebCore::JSDOMWindow::clearInterval):
(WebCore::JSDOMWindow::atob):
(WebCore::JSDOMWindow::btoa):
* page/DOMWindow.idl:
2008-10-01 Dan Bernstein <mitz@apple.com>
- Mac build fix
* WebCore.base.exp:
2008-10-01 Timothy Hatcher <timothy@apple.com>
Prevent stealing focus from the search field when focusing a DOM node.
https://bugs.webkit.org/show_bug.cgi?id=21275
Reviewed by Kevin McCullough.
* page/inspector/ElementsPanel.js:
(WebInspector.ElementsPanel.treeOutline.focusedNodeChanged):
Don't steal focus if the current focus element is the search field.
2008-09-30 Sam Weinig <sam@webkit.org>
Reviewed by Nikolas Zimmermann and Alexey Proskuryakov.
Final patch for https://bugs.webkit.org/show_bug.cgi?id=21122
Autogenerate JS event listeners
- Generate getting/setting of EventListeners.
- Adding a new named EventListener now has the same process as adding any other DOM
attribute. (Add a method with the same name in the c++ file).
(The EventListeners for MessagePort have been intentionally left custom so that we
can continue to experiment with making those EventListeners work in a frame-less world.)
* bindings/js/JSDOMApplicationCacheCustom.cpp: Remove custom methods.
* bindings/js/JSDOMWindowCustom.cpp: ditto.
* bindings/js/JSEventTargetNodeCustom.cpp: ditto.
* bindings/js/JSXMLHttpRequestCustom.cpp: ditto.
* bindings/js/JSXMLHttpRequestUploadCustom.cpp: ditto.
* bindings/scripts/CodeGeneratorJS.pm: Add code to generate EventListener
getter/setters
* dom/EventTargetNode.cpp: Add getter/setters for named EventListener.
* dom/EventTargetNode.h: ditto.
* dom/EventTargetNode.idl: Mark EventListeners as Protected so that the codegenerator
will use JSEventListerner instead of JSUnprotectedEventListener.
* loader/appcache/DOMApplicationCache.idl: Remove custom attributes..
* page/DOMWindow.cpp: Add getter/setters for named EventListener
* page/DOMWindow.h: ditto.
* page/DOMWindow.idl: Mark EventListeners as Protected so that the codegenerator
will use JSEventListerner instead of JSUnprotectedEventListener.
* xml/XMLHttpRequest.idl: Remove custom attributes.
* xml/XMLHttpRequestUpload.idl: ditto.
2008-09-30 Mark Rowe <mrowe@apple.com>
Reviewed by Dan Bernstein.
Add a leak counter for CachedResources since we've had two recent leaks involving them.
* loader/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::~CachedResource):
2008-09-30 Dan Bernstein <mitz@apple.com>
Reviewed by Dave Hyatt.
- fix https://bugs.webkit.org/show_bug.cgi?id=21127
<rdar://problem/6259134> REGRESSION: CFF format fonts fail to load
If TTLoadEmbeddedFont fails, use AddFontMemResourceEx after changing
the font name in memory.
* WebCore.vcproj/WebCore.vcproj: Renamed GetEOTHeader.* to
OpenTypeUtilities.*.
* platform/graphics/win/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::~FontCustomPlatformData): Added a call
to RemoveFontMemResourceEx to match AddFontMemResourceEx when it is
used.
(WebCore::FontCustomPlatformData::fontPlatformData): Added a code path
for fonts loaded using AddFontMemResourceEx.
(WebCore::createFontCustomPlatformData): Added a call to
renameAndActivateFont() if TTLoadEmbeddedFont fails. If
TTLoadEmbeddedFont succeeds, set the font name to the null string, as
fontPlatformData() will retrieve the name from the font reference.
* platform/graphics/win/FontCustomPlatformData.h:
(WebCore::FontCustomPlatformData::FontCustomPlatformData): Added a
font name member.
* platform/graphics/win/GetEOTHeader.cpp: Renamed.
* platform/graphics/win/GetEOTHeader.h: Renamed.
* platform/graphics/win/OpenTypeUtilities.cpp: Copied from platform/graphics/win/GetEOTHeader.cpp.
(WebCore::BigEndianUShort::BigEndianUShort): Added a constructor.
(WebCore::BigEndianULong::BigEndianULong): Ditto.
(WebCore::renameAndActivateFont): Added. Creates an in-memory copy of
the font data and modifies it to have the given name, then activates
it using AddFontMemResourceEx.
* platform/graphics/win/OpenTypeUtilities.h: Copied from platform/graphics/win/GetEOTHeader.h.
2008-09-30 Mark Rowe <mrowe@apple.com>
Reviewed by Dan Bernstein.
Fix many leaks seen on fast/backgrounds/svg-as-mask.html.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::arenaDelete): Balance the calls to addClient on maskLayer's images
with calls to removeClient when we're being destroyed.
2008-09-30 Eric Carlson <eric.carlson@apple.com>
Reviewed by Antti Koivisto.
https://bugs.webkit.org/show_bug.cgi?id=21243
Fix loopstart and loopend default values.
Tests: media/loopend-limits.html
media/loopstart-limits.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loopStart): the spec says start() is the default value
(WebCore::HTMLMediaElement::loopEnd): the spec says end() is the default value
2008-09-30 Kevin Ollivier <kevino@theolliviers.com>
wx build fixes. Add file to build and remove call to (now gone) ScrollView::update.
* WebCoreSources.bkl:
* platform/wx/ScrollViewWx.cpp:
(WebCore::ScrollView::ScrollViewPrivate::OnScrollWinEvents):
2008-09-30 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig.
- fix HTMLViewSourceDocument leaks by breaking a ref cycle which
was fixed in r17249 and re-introduced in r31435.
* html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
(WebCore::HTMLViewSourceDocument::addSpanWithClassName):
(WebCore::HTMLViewSourceDocument::addLine):
(WebCore::HTMLViewSourceDocument::addLink):
* html/HTMLViewSourceDocument.h:
2008-09-30 Sam Weinig <sam@webkit.org>
Reviewed by Eric Seidel.
More for https://bugs.webkit.org/show_bug.cgi?id=21122
Autogenerate JS event listeners
- Make EventListener getter/setters names in c++ files match those in
JS (ie. onLoadListener -> onload).
- Add standard way to access the frame associated with the EventTarget
for EventListener lookup.
- Autogenerate dispatchEvent, it wasn't doing anything custom.
* bindings/js/JSDOMApplicationCacheCustom.cpp:
(WebCore::JSDOMApplicationCache::mark):
(WebCore::JSDOMApplicationCache::addEventListener):
(WebCore::JSDOMApplicationCache::removeEventListener):
(WebCore::JSDOMApplicationCache::setOnchecking):
(WebCore::JSDOMApplicationCache::onchecking):
(WebCore::JSDOMApplicationCache::setOnerror):
(WebCore::JSDOMApplicationCache::onerror):
(WebCore::JSDOMApplicationCache::setOnnoupdate):
(WebCore::JSDOMApplicationCache::onnoupdate):
(WebCore::JSDOMApplicationCache::setOndownloading):
(WebCore::JSDOMApplicationCache::ondownloading):
(WebCore::JSDOMApplicationCache::setOnprogress):
(WebCore::JSDOMApplicationCache::onprogress):
(WebCore::JSDOMApplicationCache::setOnupdateready):
(WebCore::JSDOMApplicationCache::onupdateready):
(WebCore::JSDOMApplicationCache::setOncached):
(WebCore::JSDOMApplicationCache::oncached):
* bindings/js/JSEventTargetNodeCustom.cpp:
(WebCore::JSEventTargetNode::addEventListener):
(WebCore::JSEventTargetNode::removeEventListener):
(WebCore::JSEventTargetNode::getListener):
(WebCore::JSEventTargetNode::setListener):
* bindings/js/JSMessagePortCustom.cpp:
(WebCore::JSMessagePort::mark):
(WebCore::JSMessagePort::addEventListener):
(WebCore::JSMessagePort::removeEventListener):
(WebCore::JSMessagePort::setOnmessage):
(WebCore::JSMessagePort::onmessage):
(WebCore::JSMessagePort::setOnclose):
(WebCore::JSMessagePort::onclose):
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::mark):
(WebCore::JSXMLHttpRequest::onreadystatechange):
(WebCore::JSXMLHttpRequest::setOnreadystatechange):
(WebCore::JSXMLHttpRequest::onabort):
(WebCore::JSXMLHttpRequest::setOnabort):
(WebCore::JSXMLHttpRequest::onerror):
(WebCore::JSXMLHttpRequest::setOnerror):
(WebCore::JSXMLHttpRequest::onload):
(WebCore::JSXMLHttpRequest::setOnload):
(WebCore::JSXMLHttpRequest::onloadstart):
(WebCore::JSXMLHttpRequest::setOnloadstart):
(WebCore::JSXMLHttpRequest::onprogress):
(WebCore::JSXMLHttpRequest::setOnprogress):
(WebCore::JSXMLHttpRequest::addEventListener):
(WebCore::JSXMLHttpRequest::removeEventListener):
* bindings/js/JSXMLHttpRequestUploadCustom.cpp:
(WebCore::JSXMLHttpRequestUpload::mark):
(WebCore::JSXMLHttpRequestUpload::onabort):
(WebCore::JSXMLHttpRequestUpload::setOnabort):
(WebCore::JSXMLHttpRequestUpload::onerror):
(WebCore::JSXMLHttpRequestUpload::setOnerror):
(WebCore::JSXMLHttpRequestUpload::onload):
(WebCore::JSXMLHttpRequestUpload::setOnload):
(WebCore::JSXMLHttpRequestUpload::onloadstart):
(WebCore::JSXMLHttpRequestUpload::setOnloadstart):
(WebCore::JSXMLHttpRequestUpload::onprogress):
(WebCore::JSXMLHttpRequestUpload::setOnprogress):
(WebCore::JSXMLHttpRequestUpload::addEventListener):
(WebCore::JSXMLHttpRequestUpload::removeEventListener):
* bindings/scripts/CodeGeneratorJS.pm:
* dom/EventTarget.h:
* dom/EventTargetNode.cpp:
(WebCore::EventTargetNode::associatedFrame):
* dom/EventTargetNode.h:
* dom/EventTargetNode.idl:
* dom/MessagePort.cpp:
(WebCore::MessagePort::associatedFrame):
* dom/MessagePort.h:
(WebCore::MessagePort::setOnmessage):
(WebCore::MessagePort::onmessage):
(WebCore::MessagePort::setOnclose):
(WebCore::MessagePort::onclose):
* dom/MessagePort.idl:
* loader/appcache/DOMApplicationCache.h:
(WebCore::DOMApplicationCache::setOnchecking):
(WebCore::DOMApplicationCache::onchecking):
(WebCore::DOMApplicationCache::setOnerror):
(WebCore::DOMApplicationCache::onerror):
(WebCore::DOMApplicationCache::setOnnoupdate):
(WebCore::DOMApplicationCache::onnoupdate):
(WebCore::DOMApplicationCache::setOndownloading):
(WebCore::DOMApplicationCache::ondownloading):
(WebCore::DOMApplicationCache::setOnprogress):
(WebCore::DOMApplicationCache::onprogress):
(WebCore::DOMApplicationCache::setOnupdateready):
(WebCore::DOMApplicationCache::onupdateready):
(WebCore::DOMApplicationCache::setOncached):
(WebCore::DOMApplicationCache::oncached):
(WebCore::DOMApplicationCache::associatedFrame):
* loader/appcache/DOMApplicationCache.idl:
* svg/EventTargetSVGElementInstance.cpp:
(WebCore::EventTargetSVGElementInstance::associatedFrame):
(WebCore::EventTargetSVGElementInstance::addEventListener):
(WebCore::EventTargetSVGElementInstance::removeEventListener):
(WebCore::EventTargetSVGElementInstance::dispatchEvent):
* svg/EventTargetSVGElementInstance.h:
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::associatedFrame):
* xml/XMLHttpRequest.h:
(WebCore::XMLHttpRequest::setOnreadystatechange):
(WebCore::XMLHttpRequest::onreadystatechange):
(WebCore::XMLHttpRequest::setOnabort):
(WebCore::XMLHttpRequest::onabort):
(WebCore::XMLHttpRequest::setOnerror):
(WebCore::XMLHttpRequest::onerror):
(WebCore::XMLHttpRequest::setOnload):
(WebCore::XMLHttpRequest::onload):
(WebCore::XMLHttpRequest::setOnloadstart):
(WebCore::XMLHttpRequest::onloadstart):
(WebCore::XMLHttpRequest::setOnprogress):
(WebCore::XMLHttpRequest::onprogress):
* xml/XMLHttpRequest.idl:
* xml/XMLHttpRequestUpload.cpp:
(WebCore::XMLHttpRequestUpload::associatedFrame):
* xml/XMLHttpRequestUpload.h:
(WebCore::XMLHttpRequestUpload::setOnabort):
(WebCore::XMLHttpRequestUpload::onabort):
(WebCore::XMLHttpRequestUpload::setOnerror):
(WebCore::XMLHttpRequestUpload::onerror):
(WebCore::XMLHttpRequestUpload::setOnload):
(WebCore::XMLHttpRequestUpload::onload):
(WebCore::XMLHttpRequestUpload::setOnloadstart):
(WebCore::XMLHttpRequestUpload::onloadstart):
(WebCore::XMLHttpRequestUpload::setOnprogress):
(WebCore::XMLHttpRequestUpload::onprogress):
* xml/XMLHttpRequestUpload.idl:
2008-09-30 Darin Adler <darin@apple.com>
- roll out assertion breaking regression tests
* platform/ScrollView.cpp:
(WebCore::ScrollView::repaintContentRectangle): Temporarily remove assertion
that fires in regression tests. Hyatt can add it back later. The assertion
fires in the regression test because of layout that triggers repaint occuring
during the process of removing a frame.
2008-09-30 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Fix for https://bugs.webkit.org/show_bug.cgi?id=21227
<rdar://problem/6222134> add a way to set color for input placeholder text
Test: fast/forms/placeholder-pseudo-style.html
This change adds "-webkit-input-placeholder-mode" as a pseudo class that can be used to style
input elements when they are displaying the placeholder text.
* css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Add case for inputPlaceholderMode.
* css/CSSSelector.h: (WebCore::CSSSelector::): Add PseudoInputPlaceholderMode.
* css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
Add check for PseudoInputPlaceholderMode that asks the node if placeholderShouldBeVisible is true.
* css/html4.css: Add rule to make placeholder text default to darkGray.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::init): Initialize m_placeholderShouldBeVisible.
(WebCore::HTMLInputElement::dispatchFocusEvent): Call updatePlaceholderVisibility.
(WebCore::HTMLInputElement::dispatchBlurEvent): ditto.
(WebCore::HTMLInputElement::parseMappedAttribute): ditto.
(WebCore::HTMLInputElement::setValue): ditto.
(WebCore::HTMLInputElement::setValueFromRenderer): ditto.
(WebCore::HTMLInputElement::updatePlaceholderVisibility): Sets m_placeholderShouldBeVisible based on the current value and the focus state.
This calculation used to be done in the renderer, but since the node knows everything about the state, it can make that decision, and the
renderer will just ask the node if it should draw the placeholder.
* html/HTMLInputElement.h: (WebCore::HTMLInputElement::placeholderShouldBeVisible):
* rendering/RenderTextControl.cpp:
(WebCore::disabledTextColor): Moved to the top of the file. If there's not very much contrast between the disabled color and the background color,
just leave the text color alone. We don't want to change a good contrast color scheme so that it has really bad contrast.
If the the contrast was already poor, then it doesn't do any good to change it to a different poor contrast color scheme.
(WebCore::RenderTextControl::createInnerTextStyle): If the node says the placeholder should be visible, prepare by overriding the text security to be "none".
This can only happen as a result of either a setStyle call (which will be followed by a call to updateFromElement) or from createSubtreeIfNeeded, which
is called directly from updateFromElement. updateFromElement will immediately update the text displayed.
(WebCore::RenderTextControl::updateFromElement): If the placeholder visibility has changed, update the text that is displayed.
(WebCore::RenderTextControl::forwardEvent): Remove calls to update the placeholder state. This is now done in HTMLInputElement.
* rendering/RenderTextControl.h:
2008-09-30 Beth Dakin <bdakin@apple.com>
Reviewed by Darin Adler.
Fix for https://bugs.webkit.org/show_bug.cgi?id=20396 Abort caused
by failed allocation due to invalid counter/attr
and corresponding: <rdar://problem/6152371>
* css/CSSParser.cpp:
(WebCore::CSSParser::parseCounterContent): The spec indicates that
only identifiers should be accepted here.
2008-09-30 Kevin McCullough <kmccullough@apple.com>
Reviewed by Oliver Hunt.
Bug 21255: console.profileEnd() without a console.profile() crashes the
web inspector
* page/Console.cpp:
(WebCore::Console::profileEnd):
2008-09-30 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim Hatcher.
Bug 21252: calling console.profile() with a title that is 2 chars or
shorter does not linkify it
- Previously we tried to not linkify very short URLs but since profile
titles can be any length this is not always true.
* page/inspector/inspector.js:
2008-09-30 Dave Hyatt <hyatt@apple.com>
Remove the update() method on ScrollView. This method was only called in one place, and its purpose
was to cause a display/flush to happen. Here is a breakdown of the method use on each platform:
(1) Not used on Mac
(2) Used on Windows
(3) Used on Qt, but implemented incorrectly to cause a full repaint for no reason.
(4) Used on Gtk, but implemented incorrectly to cause a full repaint for no reason.
(5) Used on wx, but probably not needed (since wx has platform widgets like Mac).
There is now a paint method on HostWindow that does an immediate mode repaint of an empty rect to
cause the display/flush to happen if needed (thus saving an extra method on ChromeClient).
With the changes to this method, the new behavior is as follows:
(1) Not used on Mac
(2) Used on Windows
(3) Nothing happens on Qt, but only because they have not implemented immediate mode updating.
(4) Gtk now behaves like Windows and will process updates but not do any incorrect additional invalidation.
(5) Not used on wx
This method was originally added for Windows. It's not clear the display/flush is really even necessary on the other
platforms. At the very least stopping unnecessary full invalidations on Qt/Gtk is a good thing. :)
Reviewed by Sam Weinig
* ChangeLog:
* dom/Document.cpp:
(WebCore::Document::implicitClose):
* platform/HostWindow.h:
(WebCore::HostWindow::paint):
* platform/ScrollView.h:
* platform/gtk/ScrollViewGtk.cpp:
* platform/mac/ScrollViewMac.mm:
* platform/qt/ScrollViewQt.cpp:
* platform/win/ScrollViewWin.cpp:
* platform/wx/ScrollViewWx.cpp:
2008-09-30 Timothy Hatcher <timothy@apple.com>
Focus the DOM tree in the Web Inspector when a node is inspected.
So when the search field has focus, the focus moves to the tree,
allowing the arrow keys work. This can happen when using the new
find in page feature.
https://bugs.webkit.org/show_bug.cgi?id=21251
Reviewed by Geoff Garen.
* page/inspector/ElementsPanel.js:
(WebInspector.ElementsPanel): Set currentFocusElement to
the main-panels element if the panel is visible.
(WebInspector.ElementsPanel.prototype.updateBreadcrumb):
Remove a set of currentFocusElement since this moved.
* page/inspector/inspector.js:
(WebInspector.set currentFocusElement): Always focus the element.
This ensures that when focus changes in the page and we don't
catch it, we will still focus the elements even if we think it
was already focused.
2008-09-30 Timothy Hatcher <timothy@apple.com>
Make the Web Inspector's toolbar icons darker when the mouse is
pressed on them. This matches the standard NSToolbar look.
https://bugs.webkit.org/show_bug.cgi?id=21249
rdar://problem/6033752
Reviewed by Adam Roben.
* page/inspector/Images/databasesIcon.png:
* page/inspector/Images/elementsIcon.png:
* page/inspector/Images/profilesIcon.png:
* page/inspector/Images/resourcesIcon.png:
* page/inspector/Images/scriptsIcon.png:
* page/inspector/Panel.js:
* page/inspector/inspector.css:
2008-09-30 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim Hatcher.
Bug 21139: Profiler log message is wrong
- Correctly fix =(
Don't call _format twice.
* page/Page.h:
* page/inspector/Console.js:
* page/inspector/ProfilesPanel.js:
* page/inspector/inspector.js:
2008-09-30 Dave Hyatt <hyatt@apple.com>
http://bugs.webkit.org/show_bug.cgi?id=21250
Rename updateContents to repaintContentRectangle and make it cross-platform by always sending
repaints up through the ChromeClient.
Reviewed by Darin Adler
* loader/EmptyClients.h:
(WebCore::EmptyChromeClient::repaint):
* page/Chrome.cpp:
(WebCore::Chrome::repaint):
* page/Chrome.h:
* page/ChromeClient.h:
* page/FrameView.cpp:
(WebCore::FrameView::hostWindow):
(WebCore::FrameView::repaintContentRectangle):
* page/FrameView.h:
* platform/HostWindow.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::repaintContentRectangle):
(WebCore::ScrollView::platformRepaintContentRectangle):
* platform/ScrollView.h:
* platform/gtk/ScrollViewGtk.cpp:
* platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::platformRepaintContentRectangle):
* platform/qt/ScrollViewQt.cpp:
* platform/win/ScrollViewWin.cpp:
* platform/wx/ScrollViewWx.cpp:
(WebCore::ScrollView::platformRepaintContentRectangle):
2008-09-30 Alexey Proskuryakov <ap@webkit.org>
Non-Mac build fixes.
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCoreSources.bkl:
* webcore-base.bkl:
Added DOMProtect.{cpp,h}.
2008-09-39 Kevin Decker <kdecker@apple.com>
Reviewed by John Sullivan.
* bridge/npapi.h: Added skeleton for a new plug-in drawing model, the NPCoreAnimationDrawingModel. This model will eventually pave the way
for hardware accelerated drawing in plug-ins and out of process plug-in rendering.
2008-09-29 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Maciej Stachowiak.
Bug 21106: .in format discussed changes
https://bugs.webkit.org/show_bug.cgi?id=21106
- Removed "cppNamespace" global parameter and hard-coded "WebCore" as it
is the only namespace used.
- Removed "generateFactory" and "generateWrapperFactory" parameters and
re-introduced the command line options.
- Cleaned up the output of make_names.pl (removed unneeded new line).
* DerivedSources.make: Added factories command line options.
* GNUmakefile.am: Ditto.
* WebCore.pro: Ditto and removed some arguments that were migrated to
the .in files.
* dom/make_names.pl: Clean up (see above).
* html/HTMLAttributeNames.in: Removed "cppNamespace", "generateFactory"
and "generateWrapperFactory" occurences.
* html/HTMLTagNames.in: Ditto.
* svg/svgattrs.in: Ditto.
* svg/svgtags.in: Ditto.
* svg/xlinkattrs.in: Ditto.
* xml/xmlattrs.in: Ditto.
2008-09-29 Chris Fleizach <cfleizach@apple.com>
Reviewed by John Sullivan.
<rdar://problem/6255456> AX: <file> input button shouldn't have children exposed
Make sure that certain types of elements do not return children and, moreover, do not waste their
energy trying to return children
Test: accessibility/nochildren-elements.html
* page/AccessibilityObject.h:
(WebCore::AccessibilityObject::canHaveChildren):
* page/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::canHaveChildren):
(WebCore::AccessibilityRenderObject::addChildren):
* page/AccessibilityRenderObject.h:
2008-09-30 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=21213
MessagePort crash when GC collects an object with a pending close event
Test: fast/events/message-channel-gc-2.html
fast/events/message-channel-listener-circular-ownership.html
* bindings/DOMProtect.cpp: Added.
(WebCore::gcProtectDOMObject):
(WebCore::gcUnprotectDOMObject):
* bindings/DOMProtect.h: Added.
Added an abstraction for GC protection to avoid the need to call JS bindings code from
DOM objects directly.
* dom/MessagePort.cpp:
(WebCore::CloseMessagePortTimer::fired):
(WebCore::MessagePort::queueCloseEvent):
GC protect MessagePort wrapper while there is a pending close event.
This may be necessary for message events, too, but that case is not a crasher, and actually
behaves to the letter of the current HTML5 text, so I'll consider it later.
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::loadRequestAsynchronously):
(WebCore::XMLHttpRequest::dropProtection):
Use gcProtectDOMObject here, too. Unfortunately, XMLHttpRequest has more dependencies on JSC.
* bindings/js/JSMessagePortCustom.cpp:
(WebCore::JSMessagePort::addEventListener):
(WebCore::JSMessagePort::removeEventListener):
(WebCore::JSMessagePort::setOnmessage):
(WebCore::JSMessagePort::setOnclose):
Don't tell DOMWindowBase that MessagePort is a NodeEventTarget, this is not true. I do not
know if this was causing any real issues, but we shouldn't lie to DOMWindowBase.
* bindings/js/JSXMLHttpRequestUploadCustom.cpp:
(WebCore::JSXMLHttpRequestUpload::mark):
While at it, changed to use a typedef for event listeners from XMLHttpRequestUpload, not
from XMLHttpRequest.
2008-09-30 Adam Roben <aroben@apple.com>
Windows build fix
* DerivedSources.cpp: Add JSEventTargetNode.cpp.
2008-09-29 Sam Weinig <sam@webkit.org>
Reviewed by Tim Hatcher.
Patch for https://bugs.webkit.org/show_bug.cgi?id=21122
Autogenerate JS event listeners
- Generate EventTargetNode.
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* bindings/js/JSEventListener.cpp:
* bindings/js/JSEventTarget.cpp: Added.
(WebCore::toJS):
* bindings/js/JSEventTarget.h: Added.
* bindings/js/JSEventTargetBase.cpp: Removed.
* bindings/js/JSEventTargetBase.h:
* bindings/js/JSEventTargetNode.cpp: Removed.
* bindings/js/JSEventTargetNode.h: Removed.
* bindings/js/JSEventTargetNodeCustom.cpp: Added.
(WebCore::JSEventTargetNode::addEventListener):
(WebCore::JSEventTargetNode::removeEventListener):
(WebCore::JSEventTargetNode::dispatchEvent):
(WebCore::JSEventTargetNode::getListener):
(WebCore::JSEventTargetNode::setListener):
(WebCore::JSEventTargetNode::pushEventHandlerScope):
* bindings/js/JSEventTargetSVGElementInstance.cpp:
(WebCore::):
(WebCore::JSEventTargetSVGElementInstancePrototype::self):
(WebCore::JSEventTargetSVGElementInstancePrototype::getOwnPropertySlot):
(jsEventTargetAddEventListener):
(jsEventTargetRemoveEventListener):
(jsEventTargetDispatchEvent):
* bindings/js/JSEventTargetSVGElementInstance.h:
(WebCore::JSEventTargetSVGElementInstancePrototype::JSEventTargetSVGElementInstancePrototype):
(WebCore::JSEventTargetSVGElementInstancePrototype::classInfo):
* bindings/scripts/CodeGeneratorJS.pm:
* dom/EventTargetNode.idl: Added.
2008-09-29 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
- https://bugs.webkit.org/show_bug.cgi?id=21214
work on getting rid of ExecState
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBase): Removed globalThisValue argument
for base class constructor.
2008-09-29 David Hyatt <hyatt@apple.com>
Add the new HostWindow base class. A HostWindow hosts a hierarchy of Widgets. The Chrome object on Page
now subclasses from HostWindow. The new class will allow objects in platform/ like Widgets, Scrollbars
and ScrollViews to talk to the HostWindow object in order to do backing store operations and invalidations.
(Right now the platform layering is simply being violated by ScrollViews going directly to the ChromeClient.)
Reviewed by Sam Weinig
* WebCore.xcodeproj/project.pbxproj:
* page/Chrome.h:
* platform/HostWindow.h: Added.
(WebCore::HostWindow::HostWindow):
(WebCore::HostWindow::~HostWindow):
2008-09-29 Kevin Decker <kdecker@apple.com>
Reviewed by Anders Carlsson.
* bridge/npapi.h: Tweaked NPNVariable enum. NPNVsupportsCocoaBool, NPNVsupportsCarbonBool are now in the 3000 range instead of
2000.
2008-09-29 Dan Bernstein <mitz@apple.com>
Reviewed by Adam Roben.
- WebCore part of fixing <rdar://problem/6247906> REGRESSION (r19500): Crash on quit beneath CloseThemeData
* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::setWebKitIsBeingUnloaded): Added.
(WebCore::RenderThemeWin::~RenderThemeWin): Check if WebKit is being
unloaded, to avoid calling uxtheme.dll functions after that library has
been unloaded.
* rendering/RenderThemeWin.h:
2008-09-29 Chris Fleizach <cfleizach@apple.com>
Reviewed by John Sullivan
<rdar://problem/6240743> AXLoadComplete is sent for non-top level web areas and bogus web areas
Sends AXLoadComplete only when the top level web area is finished loading
* dom/Document.cpp:
(WebCore::Document::implicitClose):
2008-09-29 Timothy Hatcher <timothy@apple.com>
Makes the node highlight always show up when hovering a node in
the Web Inspector now that the highlight does not scroll to reveal
the node. Also adds a hover effect in the inspector when hovering
causes a highlight in the page. This ties the user hovering action
to the highlight so it is clear what causes the highlight to appear.
Also the highlight now temporarily shows up for 2 seconds after
selecting a node in the DOM tree. So arrowing around in the tree
will show the node on the page, providing feedback to the user.
Plus fixes an issue where quickly moving away from hovering
a node would keep showing the page highlight. This was happening
in breadcrumbs and the DOM tree.
https://bugs.webkit.org/show_bug.cgi?id=21220
Reviewed by Kevin McCullough.
* page/inspector/Console.js:
(WebInspector.Console.prototype._mouseOverNode): Added. Used for
hovering DOM nodes in the console.
(WebInspector.Console.prototype._mouseOutOfNode): Ditto.
(WebInspector.Console.prototype._formatnode): Use the new event
listeners and add a class name to the anchor element.
* page/inspector/ElementsPanel.js:
(WebInspector.ElementsPanel): Add new event listeners to the
crumbs element to do the node hovering highlight.
(WebInspector.ElementsPanel.prototype.hide):
(WebInspector.ElementsPanel.prototype.reset):
(WebInspector.ElementsPanel.prototype._mouseMovedInCrumbs):
(WebInspector.ElementsPanel.prototype._mouseMovedOutOfCrumbs):
(WebInspector.ElementsPanel.prototype.updateBreadcrumb):
* page/inspector/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode):
Show the node hishlight for 2 seconds then restore the highlight
to the current hovered node.
(WebInspector.ElementsTreeOutline.prototype._onmousemove): Set the
hovered node and set the hovered state on the tree element.
(WebInspector.ElementsTreeOutline.prototype._onmouseout): Set the
hovered node to null and removed the hovered state from the previous
hovered tree element.
(WebInspector.ElementsTreeElement.prototype.set/get hovered): Adds
the hovered class to the list item.
(WebInspector.ElementsTreeElement.prototype.onattach): Ditto.
* page/inspector/inspector.css:
* page/inspector/inspector.js:
(WebInspector.set hoveredDOMNode): Pass a delay to _updateHoverHighlightSoon
based on the showingDOMNodeHighlight property of 50ms or 500ms. This
causes the highlight to change sooner if there is one already showing
and appear later if there isn't one showing. This is like tooltips,
hovering a node for 500ms will cause highlight then mousing between nodes
will keep the highlight and change to the new node.
(WebInspector._updateHoverHighlightSoon): Take a delay being passed in and
always reset the timeout so continuous mousing does not keep flasshing
the highlight on the screen.
(WebInspector._updateHoverHighlight): Removed the alt key check and added
the showingDOMNodeHighlight property.
(WebInspector.documentKeyDown): Removed the alt key check.
(WebInspector.documentKeyUp): Ditto.
(WebInspector.reset): Clear the hoveredDOMNode.
2008-09-29 Simon Fraser <simon.fraser@apple.com>
Reviewed by Anders Carlsson
Fix RenderStyle leak in animation code, and assert that
keyframe resolution in CSSStyleSelector is not going to clobber
m_style.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::keyframeStylesForAnimation):
* page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::~KeyframeAnimation):
2008-09-29 Chris Marrin <cmarrin@apple.com>
Reviewed by Dave Hyatt
Fixed https://bugs.webkit.org/show_bug.cgi?id=20995
Rewrite keyframe resolution to be like styleForElement()
Test: animations/lineheight-animation.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::addKeyframeStyle):
(WebCore::CSSStyleSelector::~CSSStyleSelector):
(WebCore::CSSStyleSelector::keyframeStylesForAnimation):
(WebCore::CSSRuleSet::addRulesFromSheet):
(WebCore::CSSStyleSelector::mapAnimationName):
* css/CSSStyleSelector.h:
* page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::updateKeyframeAnimations):
* page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::KeyframeAnimation):
(WebCore::KeyframeAnimation::animate):
(WebCore::KeyframeAnimation::hasAnimationForProperty):
(WebCore::KeyframeAnimation::sendAnimationEvent):
(WebCore::KeyframeAnimation::overrideAnimations):
(WebCore::KeyframeAnimation::resumeOverriddenAnimations):
(WebCore::KeyframeAnimation::affectsProperty):
(WebCore::KeyframeAnimation::validateTransformFunctionList):
* page/animation/KeyframeAnimation.h:
* rendering/style/Animation.cpp:
(WebCore::Animation::animationsMatch):
* rendering/style/Animation.h:
* rendering/style/KeyframeList.cpp:
(WebCore::KeyframeList::~KeyframeList):
(WebCore::KeyframeList::clear):
(WebCore::KeyframeList::insert):
* rendering/style/KeyframeList.h:
(WebCore::KeyframeValue::KeyframeValue):
(WebCore::KeyframeList::KeyframeList):
(WebCore::KeyframeList::operator!=):
(WebCore::KeyframeList::animationName):
(WebCore::KeyframeList::addProperty):
(WebCore::KeyframeList::containsProperty):
(WebCore::KeyframeList::beginProperties):
(WebCore::KeyframeList::endProperties):
(WebCore::KeyframeList::isEmpty):
(WebCore::KeyframeList::size):
(WebCore::KeyframeList::beginKeyframes):
(WebCore::KeyframeList::endKeyframes):
* rendering/style/RenderStyle.h:
* rendering/style/StyleRareNonInheritedData.cpp:
* rendering/style/StyleRareNonInheritedData.h:
2008-09-29 Chris Marrin <cmarrin@apple.com>
Reviewed by Eric Seidel
Clean up fix in PropertyWrapperGetter::equals
https://bugs.webkit.org/show_bug.cgi?id=21011
Test: transitions/override-transition-crash.html
* page/animation/AnimationBase.cpp:
(WebCore::PropertyWrapperGetter::equals):
* page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::updateTransitions):
2008-09-29 Chris Marrin <cmarrin@apple.com>
Reviewed by Eric Seidel
https://bugs.webkit.org/show_bug.cgi?id=21001
Starting transition after animation, when animation
is finished, transition is wrong.
Test: animations/transition-and-animation-2.html
* page/animation/AnimationBase.h:
* page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::updateTransitions):
(WebCore::CompositeAnimation::updateKeyframeAnimations):
(WebCore::CompositeAnimation::resetTransitions):
(WebCore::CompositeAnimation::cleanupFinishedAnimations):
* page/animation/ImplicitAnimation.cpp:
(WebCore::ImplicitAnimation::ImplicitAnimation):
(WebCore::ImplicitAnimation::~ImplicitAnimation):
(WebCore::ImplicitAnimation::animate):
(WebCore::ImplicitAnimation::reset):
* page/animation/ImplicitAnimation.h:
2008-09-29 Chris Marrin <cmarrin@apple.com>
Reviewed by Sam Weinig
https://bugs.webkit.org/show_bug.cgi?id=20921
-webkit-animation-timing-function: inside of keyframes is ignored
Test: animations/keyframe-timing-functions.html
* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::progress):
* page/animation/AnimationBase.h:
* page/animation/ImplicitAnimation.cpp:
(WebCore::ImplicitAnimation::animate):
* page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::animate):
2008-09-29 Dan Bernstein <mitz@apple.com>
- Windows build fix
* platform/ScrollView.cpp:
(WebCore::ScrollView::platformScroll):
2008-09-29 Dan Bernstein <mitz@apple.com>
- another attempt at a Windows build fix
* platform/ScrollView.cpp:
(WebCore::platformScroll):
2008-09-29 Dan Bernstein <mitz@apple.com>
- Windows build fix
* platform/ScrollView.cpp:
(WebCore::ScrollView::platformSetScrollPosition):
2008-09-29 David Hyatt <hyatt@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=21218
Accidentally removed a check to see if the scrollbar modes were equal. This caused a crash on Windows.
It's silly that the code was this fragile, but for now just put the check back in.
Reviewed by Dan Bernstein
* platform/ScrollView.cpp:
(WebCore::ScrollView::setScrollbarModes):
2008-09-29 David Hyatt <hyatt@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=21216
Make setScrollPosition and scroll() cross-platform.
Reviewed by Anders
* platform/ScrollView.cpp:
(WebCore::ScrollView::setScrollPosition):
(WebCore::ScrollView::scroll):
* platform/ScrollView.h:
* platform/gtk/ScrollViewGtk.cpp:
* platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::platformSetScrollPosition):
(WebCore::ScrollView::platformScroll):
* platform/qt/ScrollViewQt.cpp:
* platform/win/ScrollViewWin.cpp:
* platform/wx/ScrollViewWx.cpp:
(WebCore::ScrollView::platformSetScrollPosition):
(WebCore::ScrollView::platformScroll):
2008-09-29 Kevin McCullough <kmccullough@apple.com>
Reviewed by Oliver.
Bug 21139: Profiler log message is wrong
- Because _format was called twice the number in the log was incremented
too many times, but we were passing it around in the link the whole time
* page/inspector/ProfilesPanel.js:
* page/inspector/inspector.js:
2008-09-29 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich.
Autogenerate EventListeners, addEventListener and removeEventListener
for JSDOMWindow.
* bindings/js/JSDOMWindowBase.cpp:
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::onwebkitanimationstart):
(WebCore::JSDOMWindow::setOnwebkitanimationstart):
(WebCore::JSDOMWindow::onwebkitanimationiteration):
(WebCore::JSDOMWindow::setOnwebkitanimationiteration):
(WebCore::JSDOMWindow::onwebkitanimationend):
(WebCore::JSDOMWindow::setOnwebkitanimationend):
(WebCore::JSDOMWindow::onwebkittransitionend):
(WebCore::JSDOMWindow::setOnwebkittransitionend):
(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener):
(WebCore::JSDOMWindow::setListener):
(WebCore::JSDOMWindow::getListener):
* bindings/scripts/CodeGeneratorJS.pm:
* page/DOMWindow.idl:
2008-09-29 Thiago Macieira <thiago.macieira@nokia.com>
Reviewed by Simon.
Changed copyright from Trolltech ASA to Nokia.
Nokia acquired Trolltech ASA, assets were transferred on September 26th 2008.
* bindings/js/JSMimeTypeArrayCustom.cpp:
* bindings/js/JSNavigatorCustom.cpp:
* bindings/js/JSPluginArrayCustom.cpp:
* bindings/js/JSPluginCustom.cpp:
* bindings/js/ScriptControllerMac.mm:
* bindings/js/ScriptControllerQt.cpp:
* bridge/qt/qt_class.cpp:
* bridge/qt/qt_class.h:
* bridge/qt/qt_instance.cpp:
* bridge/qt/qt_instance.h:
* bridge/qt/qt_runtime.cpp:
* bridge/qt/qt_runtime.h:
* bridge/testqtbindings.cpp:
* css/makegrammar.pl:
* css/makeprop.pl:
* css/makevalues.pl:
* dom/Node.cpp:
* dom/TagNodeList.cpp:
* dom/TagNodeList.h:
* dom/XMLTokenizer.cpp:
* dom/XMLTokenizer.h:
* dom/XMLTokenizerLibxml2.cpp:
* dom/XMLTokenizerQt.cpp:
* editing/Editor.cpp:
* editing/EditorCommand.cpp:
* html/CanvasRenderingContext2D.cpp:
* html/CanvasStyle.cpp:
* html/HTMLAppletElement.cpp:
* html/HTMLEmbedElement.cpp:
* html/HTMLObjectElement.cpp:
* loader/FrameLoader.cpp:
* page/Chrome.cpp:
* page/EditorClient.h:
* page/Frame.cpp:
* page/Frame.h:
* page/FramePrivate.h:
* page/Navigator.cpp:
* page/Navigator.h:
* page/Navigator.idl:
* page/mac/FrameMac.mm:
* page/qt/EventHandlerQt.cpp:
* platform/graphics/qt/FontCacheQt.cpp:
* platform/graphics/qt/FontCustomPlatformData.cpp:
* platform/graphics/qt/FontCustomPlatformData.h:
* platform/graphics/qt/FontPlatformData.h:
* platform/graphics/qt/FontQt.cpp:
* platform/graphics/qt/GlyphPageTreeNodeQt.cpp:
* platform/graphics/qt/GraphicsContextQt.cpp:
* platform/graphics/qt/ImageDecoderQt.cpp:
* platform/graphics/qt/ImageDecoderQt.h:
* platform/graphics/qt/ImageSourceQt.cpp:
* platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
* platform/graphics/qt/MediaPlayerPrivatePhonon.h:
* platform/graphics/qt/SimpleFontDataQt.cpp:
* platform/gtk/MIMETypeRegistryGtk.cpp:
* platform/mac/MIMETypeRegistryMac.mm:
* platform/network/qt/QNetworkReplyHandler.cpp:
* platform/network/qt/QNetworkReplyHandler.h:
* platform/network/qt/ResourceHandleQt.cpp:
* platform/network/qt/ResourceRequestQt.cpp:
* platform/qt/ClipboardQt.cpp:
* platform/qt/EventLoopQt.cpp:
* platform/qt/KURLQt.cpp:
* platform/qt/LoggingQt.cpp:
* platform/qt/MIMETypeRegistryQt.cpp:
* platform/qt/PasteboardQt.cpp:
* platform/qt/PlatformScreenQt.cpp:
* platform/qt/PopupMenuQt.cpp:
* platform/qt/QWebPopup.cpp:
* platform/qt/QWebPopup.h:
* platform/qt/RenderThemeQt.cpp:
* platform/qt/ScrollbarQt.cpp:
* platform/qt/ScrollbarThemeQt.cpp:
* platform/qt/WheelEventQt.cpp:
* platform/qt/html4-adjustments-qt.css:
* platform/wx/MimeTypeRegistryWx.cpp:
* plugins/MimeType.cpp:
* plugins/MimeType.h:
* plugins/MimeType.idl:
* plugins/MimeTypeArray.cpp:
* plugins/MimeTypeArray.h:
* plugins/MimeTypeArray.idl:
* plugins/Plugin.cpp:
* plugins/Plugin.h:
* plugins/Plugin.idl:
* plugins/PluginArray.cpp:
* plugins/PluginArray.h:
* plugins/PluginArray.idl:
* plugins/PluginData.cpp:
* plugins/PluginData.h:
* plugins/gtk/PluginDataGtk.cpp:
* plugins/mac/PluginDataMac.mm:
* plugins/qt/PluginDataQt.cpp:
* plugins/win/PluginDataWin.cpp:
* rendering/RenderTableCol.cpp:
* rendering/RenderTableCol.h:
2008-09-29 Thiago Macieira <thiago.macieira@trolltech.com>
Reviewed by Simon
Fix compilation with gcc 4.3
gcc 4.3 is stricter and ctype.h isn't getting included
automatically here by dependencies. So do it directly.
* platform/qt/PlatformKeyboardEventQt.cpp:
2008-09-29 Morten Sørvig <msorvig@trolltech.com>
Reviewed by Simon.
Fix compilation with Qt/Mac without plugins.
* platform/qt/TemporaryLinkStubs.cpp:
2008-09-29 Mark Rowe <mrowe@apple.com>
Reviewed by Sam Weinig.
Apply the ASCII fast path optimization from StringImpl::lower to StringImpl::upper.
In the few places that we call .upper() in WebCore the strings represent things like
tag and attribute names, which are nearly always going to be ASCII.
* platform/text/StringImpl.cpp:
(WebCore::StringImpl::lower): If we have to resize the buffer, be sure to pass the new length
in to Unicode::toLower the second time.
(WebCore::StringImpl::upper):
2008-09-28 Mark Rowe <mrowe@apple.com>
Reviewed by Sam Weinig.
Speed up getPropertyValue('clip') by 25% by using a Vector<UChar> for building a string,
rather than String::operator+=.
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::cssText):
2008-09-28 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver Hunt.
Speed up computedStyle.getPropertyValue('color') by 4.5x.
Using a Vector<UChar> while building up the property's cssText is substantially cheaper than using String::operator+=
as it avoids many memory reallocations.
This also speeds up the jQuery .offset() benchmark at <http://dev.jquery.com/~john/speed/1.2.6/offset-1.2.6.html>
by 20% due to jQuery's strange need to call getPropertyValue('color') when retrieving the computed styles for
unrelated properties on an element.
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::cssText): Build the result for the color types into a Vector<UChar>
and use appendNumber rather than the String::number in order to cut down on memory allocations.
* platform/text/PlatformString.h:
(WebCore::appendNumber): A helper function for formatting an unsigned character as a number
into a Vector<UChar>.
2008-09-28 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Remove spurious call to lower().
* css/MediaQueryEvaluator.cpp:
(WebCore::MediaQueryEvaluator):
2008-09-28 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Use a CaseFoldingHash instead of calling lower on family strings.
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule):
(WebCore::CSSFontSelector::getFontData):
* css/CSSFontSelector.h:
2008-09-28 Timothy Hatcher <timothy@apple.com>
Remove the scrollIntoViewIfNeeded() call when drawing the
Inspector node highlight.
<rdar://problem/6115804> Don't scroll when highlighting (21000)
https://bugs.webkit.org/show_bug.cgi?id=21000
Reviewed by Dan Bernstein.
* page/InspectorController.cpp:
(WebCore::InspectorController::drawNodeHighlight):
2008-09-28 David Hyatt <hyatt@apple.com>
Fix crash when WebKit has no instantiated Scrollbars and the appearance prefs for scrollbars are
changed.
Reviewed by Dan Bernstein
* platform/mac/ScrollbarThemeMac.mm:
(+[ScrollbarPrefsObserver appearancePrefsChanged:]):
2008-09-28 Timothy Hatcher <timothy@apple.com>
Clear the current search results in the Inspector when
the search query is less than 3 characters long. Incremental
searches only occur for 3 characters or longer, but deleting
under this limit would not clear the results unless the whole
query was deleted.
https://bugs.webkit.org/show_bug.cgi?id=21196
Reviewed by Dan Bernstein.
* page/inspector/inspector.js:
(WebInspector.performSearch): Check for short queries in the
if statement that triggers the clear.
2008-09-28 Dan Bernstein <mitz@apple.com>
Reviewed by Dave Hyatt.
- fix <rdar://problem/6202962> "Tibetan Machine Uni" font does not work as a web font on Windows because TTLoadEmbeddedFont fails with E_NAMECHANGEFAILED
* platform/graphics/win/FontCustomPlatformData.cpp:
(WebCore::EOTStream::EOTStream): Added overlayDst, overlaySrc and
overlayLength parameters.
(WebCore::EOTStream::read): Added code to overlay the
m_overlayLength bytes starting at m_overlayDst with the same number of
bytes from m_overlaySrc.
(WebCore::createFontCustomPlatformData): Changed to get overlay
parameters from getEOTHeader.
* platform/graphics/win/GetEOTHeader.cpp:
(WebCore::getEOTHeader): Added code to specify overlaying of the
family name with the prefix of the full name if they differ, because
that such a difference causes TTLoadEmbeddedFont to fail.
* platform/graphics/win/GetEOTHeader.h:
2008-09-28 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=20366
Reproducible test failure for editing/undo/undo-iframe-location-change.html
* ChangeLog-2006-05-10: Added bug URLs for a fix that included this test.
2008-09-28 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig (except for a few comment and header tweaks).
- https://bugs.webkit.org/show_bug.cgi?id=21158
reduce use of virtual functions in Node for speed
Speeds up Dromaeo a bit less than 1%.
* bindings/js/JSNamedNodesCollection.cpp: Include Element.h instead of
Node.h now that some inlines are in there.
* dom/Attr.h: Override both the virtual and non-virtual name functions.
* dom/ChildNodeList.cpp:
(WebCore::ChildNodeList::nodeMatches): Updated to take an Element.
* dom/ChildNodeList.h: Ditto.
* dom/ClassNodeList.cpp:
(WebCore::ClassNodeList::nodeMatches): Ditto.
* dom/ClassNodeList.h: Ditto.
* dom/Document.h: Put the Node::isDocumentNode() function's inline
definition here where it can see the Document class definition.
* dom/DynamicNodeList.cpp:
(WebCore::DynamicNodeList::length): Changed to pass an Element.
(WebCore::DynamicNodeList::itemForwardsFromCurrent): Ditto.
(WebCore::DynamicNodeList::itemBackwardsFromCurrent): Ditto.
(WebCore::DynamicNodeList::itemWithName): Ditto.
* dom/DynamicNodeList.h: Ditto.
* dom/Element.cpp: Removed virtualHasTagName.
* dom/Element.h: Made localName, prefix, namespaceURI, and
styleForRenderer non-virtual. Added virtualPrefix, virtualLocalName,
virtualNamespaceURI, and removed virtualHasTagName. Put the
Node::hasTagName, Node::hasAttributes, and Node::attributes
functions' inline definitions here where they can see the Element
class definition.
* dom/NameNodeList.cpp:
(WebCore::NameNodeList::nodeMatches): Updated to take an Element.
* dom/NameNodeList.h: Ditto.
* dom/Node.cpp:
(WebCore::Node::virtualPrefix): Renamed from prefix.
(WebCore::Node::virtualLocalName): Renamed from localName.
(WebCore::Node::virtualNamespaceURI): Renamed from namespaceURI.
(WebCore::Node::styleForRenderer): Handle the Element case here.
* dom/Node.h: Removed definition of hasTagName that calls virtual,
since we now have a non-virtual version. Made hasAttributes,
attributes, remove, localName, namespaceURI, prefix, isDocumentNode,
and styleForRenderer non-virtual. Added virtualPrefix,
virtualLocalName, and virtualNamespaceURI. Removed isMalformed
and setMalformed, which are used only on HTMLFormElement objects.
* dom/TagNodeList.cpp:
(WebCore::TagNodeList::nodeMatches): Updated to take an Element.
* dom/TagNodeList.h: Ditto.
* html/HTMLAnchorElement.cpp: Added a comment.
* html/HTMLFormControlElement.cpp: Ditto.
* html/HTMLAnchorElement.h: Removed unused, unimplemented setTabIndex
function. Marked tabIndex function virtual explicitly for clarity.
* html/HTMLAreaElement.h: Removed unused, unimplemented setTabIndex
function. Marked isFocusable function virtual explicitly for clarity.
* html/HTMLElement.h: Marked tabIndex function virtual explicitly for
clarity.
* html/HTMLFormControlElement.h: Ditto.
* html/HTMLFormElement.h: Made isMalformed non-virtual.
* html/HTMLParser.cpp:
(WebCore::HTMLParser::handleError): Use the already-cast-to-HTMLElement
pointer to call localName since that one does not need to call a virtual
function.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock): Cast to HTMLFormElement before
calling isMalformed. We already did a tag name check so we know it's
an HTMLFormELement.
* xml/XPathUtil.cpp:
(WebCore::XPath::isValidContextNode): Rewrote to not make so many calls
to nodeType(), since it's a virtual function.
2008-09-28 David Hyatt <hyatt@apple.com>
Make frameRectsChanged() cross-platform on ScrollView.
Reviewed by Oliver Hunt
* platform/ScrollView.cpp:
(WebCore::ScrollView::frameRectsChanged):
* platform/ScrollView.h:
* platform/gtk/ScrollViewGtk.cpp:
* platform/qt/ScrollViewQt.cpp:
* platform/win/ScrollViewWin.cpp:
* platform/wx/ScrollViewWx.cpp:
2008-09-28 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Bug 21141: REGRESSION: Exception messages for user entered commands are poor
<https://bugs.webkit.org/show_bug.cgi?id=21141>
The bug repsonsible for this was the the JSInspectedObjectWrapper instances
were not initialising their StructureID's to indicate that the wrapper
overrides hasInstance, etc. The solution is simply to use the createStructureID
helper on JSQuarantinedObjectWrapper to create a correct StructureID.
* bindings/js/JSInspectedObjectWrapper.cpp:
(WebCore::JSInspectedObjectWrapper::wrap):
2008-09-28 David Hyatt <hyatt@apple.com>
Make sure pixel wheel scrolls (formerly "continuous" wheel events) send deltas to DOM wheel events in
terms of lines.
Reviewed by Oliver Hunt
* dom/EventTargetNode.cpp:
(WebCore::EventTargetNode::dispatchWheelEvent):
2008-09-28 David Hyatt <hyatt@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=21191
Rework mouse wheeling significantly to make the platform event less messy and to enable wheelEvent
on ScrollView to be cross-platform.
Give the wheel event a concept of granularity (pixel, line or page). What used to be called continuous
events are now pixel wheel events.
Page scrolling as implemented in bug 17589 was completely broken. It had the following problems:
(1) Page scrolling has been corrected to be properly detected (on Windows
page wheeling is only done in the vertical direction and it is keyed off a special return value of -1). The
old code had some bizarre incorrect heuristic for "guessing" that you should page scroll and also thought
you could page scroll horizontally.
(2) Page scrolling a layer used the enclosing ScrollView's width/height instead of the layer's width/height.
This caused the scroll amount for page scrolling to be way too large on layers.
Bug 17589 got the default horizontal scrolling value wrong. It assumed 1, when the Vista default is 3.
Incorporate WebCore's line multiplier right into the deltas of the event. This eliminates the need
for separate multiplier fields (or for the need to ask if you're looking for line sensitivity).
Reviewed by Oliver Hunt
* editing/EditorCommand.cpp:
(WebCore::verticalScrollDistance):
* page/EventHandler.cpp:
(WebCore::scrollAndAcceptEvent):
(WebCore::EventHandler::handleWheelEvent):
* platform/PlatformWheelEvent.h:
(WebCore::):
(WebCore::PlatformWheelEvent::pos):
(WebCore::PlatformWheelEvent::globalPos):
(WebCore::PlatformWheelEvent::deltaX):
(WebCore::PlatformWheelEvent::deltaY):
(WebCore::PlatformWheelEvent::granularity):
(WebCore::PlatformWheelEvent::x):
(WebCore::PlatformWheelEvent::globalX):
(WebCore::PlatformWheelEvent::ignore):
(WebCore::PlatformWheelEvent::horizontalLineMultiplier):
(WebCore::PlatformWheelEvent::verticalLineMultiplier):
* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
* platform/Scrollbar.h:
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::updateScrollbars):
* platform/gtk/WheelEventGtk.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
* platform/mac/ScrollViewMac.mm:
* platform/mac/WheelEventMac.mm:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
* platform/qt/ScrollViewQt.cpp:
(WebCore::ScrollView::updateScrollbars):
* platform/qt/WheelEventQt.cpp:
* platform/win/ScrollViewWin.cpp:
(WebCore::ScrollView::updateScrollbars):
* platform/win/WheelEventWin.cpp:
(WebCore::PlatformWheelEvent::horizontalLineMultiplier):
(WebCore::PlatformWheelEvent::verticalLineMultiplier):
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
* platform/wx/ScrollViewWx.cpp:
(WebCore::ScrollView::ScrollViewPrivate::OnScrollWinEvents):
(WebCore::ScrollView::wheelEvent):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
2008-09-27 Eric Carlson <eric.carlson@apple.com>
Reviewed by Sam Weinig.
fix https://bugs.webkit.org/show_bug.cgi?id=20994
<rdar://problem/6171023> HTMLVideoElement width and height attributes are now unsigned
HTML5 spec says HTMLVideoElement width and height attributes should be unsigned. Convert
all unsigned media attributes from string with toUInt() instead of toInt().
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::playCount): convert from attribute with toUInt().
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::videoWidth):
(WebCore::HTMLVideoElement::videoHeight): return unsigned to match idl.
(WebCore::HTMLVideoElement::width): convert from attribute with toUInt() and return
unsigned value.
(WebCore::HTMLVideoElement::height): Ditto.
(WebCore::HTMLVideoElement::setWidth): take unsigned value.
(WebCore::HTMLVideoElement::setHeight): Ditto.
* html/HTMLVideoElement.h: width, height, videoWidth, and videoHeight are unsigned.
* html/HTMLVideoElement.idl: make width and height unsigned to match HTML5 spec.
2008-09-27 Timothy Hatcher <timothy@apple.com>
Fixes an exception when typing a command in the Console.
Reviewed by Oliver Hunt.
* page/inspector/Console.js:
(WebInspector.Console.prototype.addMessage): Null check
this.previosMessage.
2008-09-27 Timothy Hatcher <timothy@apple.com>
Fixes a bug where the Profiles panel sidebar would be empty
after closing and reopening the Web Inspector.
https://bugs.webkit.org/show_bug.cgi?id=21179
Reviewed by Sam Weinig.
* page/inspector/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.reset): Don't call
populateInterface, it is called automatically.
(WebInspector.ProfilesPanel.prototype._populateProfiles):
Return early if the sidebar is already populated.
2008-09-27 Dave Hyatt <hyatt@apple.com>
Bug 21190. The line scroll amount on Windows is way too small. A patch for bug 17589 for wheel sensitivity
incorrectly applied the tinier wheel step delta (unmultiplied) to line scrolling. Line scrolling with the
scrollbar has nothing to do with mouse wheeling. This patch reverts the scrollbars to use the same line
step as other platforms while leaving the wheel delta alone for use with wheel scrolling.
There was a lot wrong with 17589, so more patches will be coming to deal with the fallout of this patch
(which should never have landed in the first place).
Reviewed by Tim Hatcher, Sam Weinig
* platform/win/ScrollViewWin.cpp:
(WebCore::adjustDeltaForPageScrollMode):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::wheelEvent):
2008-09-27 David Hyatt <hyatt@apple.com>
Make the scrollbarUnderMouse method cross-platform.
Reviewed by Sam Weinig
* platform/ScrollView.cpp:
(WebCore::ScrollView::scrollbarUnderMouse):
* platform/gtk/ScrollViewGtk.cpp:
* platform/mac/ScrollViewMac.mm:
* platform/qt/ScrollViewQt.cpp:
* platform/win/ScrollViewWin.cpp:
* platform/wx/ScrollViewWx.cpp:
2008-09-27 Holger Hans Peter Freyther <zecke@selfish.org>
Gtk+ build fix.
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::ScrollViewPrivate::valueChanged):
2008-09-27 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=20287
[Gtk] disable plugins for gtk/directfb target
Introduce WTF_PLATFORM_X11 for X11 builds.
Also use target-specific packages when building the port
* platform/gtk/PlatformScreenGtk.cpp:
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::getValueStatic):
(WebCore::PluginView::getValue):
(WebCore::PluginView::init):
2008-09-27 David Hyatt <hyatt@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=21188
Make scrollbar suppression and resizer avoidance cross-platform.
Reviewed by Anders
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::transitionToCommitted):
* page/FrameView.cpp:
(WebCore::FrameView::resetScrollbars):
(WebCore::FrameView::clear):
(WebCore::FrameView::layout):
(WebCore::FrameView::restoreScrollbar):
(WebCore::FrameView::windowResizerRect):
* page/FrameView.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::init):
(WebCore::ScrollView::resizerOverlapsContent):
(WebCore::ScrollView::adjustScrollbarsAvoidingResizerCount):
(WebCore::ScrollView::setParent):
(WebCore::ScrollView::setScrollbarsSuppressed):
(WebCore::ScrollView::platformSetScrollbarsSuppressed):
* platform/ScrollView.h:
(WebCore::ScrollView::scrollbarsSuppressed):
(WebCore::ScrollView::windowResizerRect):
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::setFrameRect):
(WebCore::Scrollbar::setParent):
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
(WebCore::ScrollView::ScrollViewPrivate::adjustmentChanged):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::paint):
* platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::ScrollView):
(WebCore::ScrollView::~ScrollView):
(WebCore::ScrollView::platformSetScrollbarsSuppressed):
(WebCore::ScrollView::setScrollPosition):
* platform/qt/ScrollViewQt.cpp:
(WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
(WebCore::ScrollView::ScrollViewPrivate::valueChanged):
(WebCore::ScrollView::frameRectsChanged):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::paint):
* platform/win/ScrollViewWin.cpp:
(WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
(WebCore::ScrollView::ScrollViewPrivate::valueChanged):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::paint):
* platform/wx/ScrollViewWx.cpp:
(WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
2008-09-27 Holger Hans Peter Freyther <zecke@selfish.org>
Rubber-stamped by Anders Carlsson.
Compile fix.
* plugins/PluginView.cpp:
(WebCore::PluginView::load):
2008-09-27 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Sam Weinig.
Fix <https://bugs.webkit.org/show_bug.cgi?id=21184>.
Bug 21184: REGRESSION: Reproducible crash below StringImpl::hash while running editing/deleting/5408255.html
Remove an assertion that was incorrect and that if made correct would have duplicated a check that occurred earlier in the function.
* loader/CachedResource.cpp:
(WebCore::CachedResource::~CachedResource):
2008-09-27 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Simon Hausmann.
[qt] Use QImageReader to figure out which image formats are supported
- Qt can have many different plugins for different image formats. Instead
of checking only for a few in WebCore use Qt to determine if this data
can be treated as an image.
* platform/graphics/qt/ImageSourceQt.cpp:
(WebCore::canHandleImage):
(WebCore::createDecoder):
2008-09-27 Holger Hans Peter Freyther <zecke@selfish.org>
[qt] Clean the pattern code
- Use save/restore on the painter after manipulating the
pen/brush
- Make the context and object null checking consistent. CG is using
the object unconditionally so the Qt webkit platform can do the
same.
- Move code below the early exit. Only use the m_ownerElement before
the early exit as the CG code is doing it.
* svg/graphics/SVGPaintServerPattern.h:
* svg/graphics/qt/SVGPaintServerPatternQt.cpp:
(WebCore::SVGPaintServerPattern::setup):
(WebCore::SVGPaintServerPattern::teardown):
2008-09-27 Keishi Hattori <casey.hattori@gmail.com>
Added support for console.trace.
https://bugs.webkit.org/show_bug.cgi?id=19157
Reviewed by Kevin McCullough and Tim Hatcher.
* bindings/js/JSConsoleCustom.cpp:
(WebCore::JSConsole::trace):
* page/Console.cpp:
(WebCore::Console::trace): Calls Machine::retrieveCaller to
get a stack trace.
* page/Console.h:
(WebCore::): Added TraceMessageLevel.
* page/Console.idl: Added console.trace.
* page/inspector/Console.js:
(ConsoleMessage): Added case for TraceMessageLevel.
2008-09-27 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=21178
<rdar://problem/6248651>
Check if the plug-in is allowed to load the resource. This matches Firefox.
Test: http/tests/plugins/local-geturl-from-remote.html
* plugins/PluginView.cpp:
(WebCore::PluginView::load):
2008-09-22 Dirk Schulze <vbs85@gmx.de>
Reviewed by Eric Seidel.
Added SVG pattern support to Qt.
[Qt] SVG patterns are missing
https://bugs.webkit.org/show_bug.cgi?id=20973
* svg/graphics/qt/SVGPaintServerPatternQt.cpp:
(WebCore::SVGPaintServerPattern::setup):
2008-09-27 Keishi Hattori <casey.hattori@gmail.com>
Fixed a bug in the JS syntax highlighter with multiple line tokens.
https://bugs.webkit.org/show_bug.cgi?id=21171
Reviewed by Tim Hatcher.
* page/inspector/SourceFrame.js:
(syntaxHighlightJavascriptLine): Initialize previousMatchLength.
2008-09-27 Timothy Hatcher <timothy@apple.com>
Change searching in the Profiles panel to not match the
Self and Total columns when there are no units. The only
column that is matched for unitless number searches is
now the Calls column.
https://bugs.webkit.org/show_bug.cgi?id=21169
Reviewed by Sam Weinig.
* page/inspector/ProfileView.js:
(WebInspector.ProfileView.prototype.performSearch):
2008-09-27 David Hyatt <hyatt@apple.com>
Rename boundsGeometry -> boundsRect. Rename geometryChanged -> frameRectsChanged.
Reviewed by Sam Weinig
* platform/ScrollView.h:
* platform/Widget.h:
(WebCore::Widget::boundsRect):
(WebCore::Widget::invalidate):
(WebCore::Widget::frameRectsChanged):
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollViewScrollbar::frameRectsChanged):
(WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
(WebCore::ScrollView::setFrameRect):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::frameRectsChanged):
* platform/gtk/ScrollbarGtk.cpp:
(ScrollbarGtk::setFrameRect):
(ScrollbarGtk::frameRectsChanged):
* platform/gtk/ScrollbarGtk.h:
* platform/gtk/WidgetGtk.cpp:
* platform/qt/ScrollViewQt.cpp:
(WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
(WebCore::ScrollView::setFrameRect):
(WebCore::ScrollView::frameRectsChanged):
(WebCore::ScrollView::updateScrollbars):
* platform/win/ScrollViewWin.cpp:
(WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
(WebCore::ScrollView::setFrameRect):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::frameRectsChanged):
* plugins/PluginView.cpp:
(WebCore::PluginView::frameRectsChanged):
* plugins/PluginView.h:
2008-09-27 Simon Hausmann <hausmann@webkit.org>
Refix the previous build fix to compile on non-Qt platforms, too.
* WebCore.pro: Don't pass -i to create_hashtable, added missing -n
WebCore to generate the PrototypeTable in the WebCore namespace
* bindings/js/JSEventTargetBase.h: Revert previous fix, the Prototype
table remains in the Webcore namespace
(WebCore::JSEventTargetBasePrototype::getOwnPropertySlot):
2008-09-27 Simon Hausmann <hausmann@webkit.org>
Fix compilation with gcc 4.3 (probably > 4.0)
* bindings/js/JSDOMWindowBase.cpp: Don't define static property
get/put functions inside the WebCore namespace.
* bindings/js/JSEventTargetBase.cpp: Ditto.
* bindings/js/JSEventTargetNode.cpp: Ditto.
* bindings/js/JSEventTargetSVGElementInstance.cpp: Ditto.
* bindings/js/JSEventTargetBase.h: Forward declare
JSEventTargetPrototypeTable in the JSC namespace as the lut.h file
defines it in the JSC namespace.
(WebCore::JSEventTargetBasePrototype::getOwnPropertySlot): Add JSC::
prefix for PrototypeTable symbol.
2008-09-27 David Hyatt <hyatt@apple.com>
Rename frameGeometry to frameRect. Rename setFrameGeometry to setFrameRect.
Reviewed by Dan Bernstein
* WebCore.base.exp:
* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::updateControlTints):
* platform/ScrollView.h:
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::Scrollbar):
(WebCore::Scrollbar::paint):
(WebCore::Scrollbar::setFrameRect):
* platform/Scrollbar.h:
* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::paint):
* platform/Widget.h:
(WebCore::Widget::x):
(WebCore::Widget::y):
(WebCore::Widget::width):
(WebCore::Widget::height):
(WebCore::Widget::size):
(WebCore::Widget::pos):
(WebCore::Widget::resize):
(WebCore::Widget::move):
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollViewScrollbar::geometryChanged):
(WebCore::ScrollView::update):
(WebCore::ScrollView::setFrameRect):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::scrollbarUnderMouse):
(WebCore::ScrollView::paint):
* platform/gtk/ScrollbarGtk.cpp:
(ScrollbarGtk::setFrameRect):
(ScrollbarGtk::geometryChanged):
* platform/gtk/ScrollbarGtk.h:
* platform/gtk/WidgetGtk.cpp:
(WebCore::Widget::frameRect):
(WebCore::Widget::setFrameRect):
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::trackRect):
(WebCore::ScrollbarThemeMac::paint):
* platform/mac/WidgetMac.mm:
(WebCore::Widget::frameRect):
(WebCore::Widget::setFrameRect):
* platform/qt/ScrollViewQt.cpp:
(WebCore::ScrollView::setFrameRect):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::scrollbarUnderMouse):
(WebCore::ScrollView::paint):
* platform/qt/ScrollbarThemeQt.cpp:
(WebCore::styleOptionSlider):
* platform/qt/WidgetQt.cpp:
(WebCore::Widget::frameRect):
(WebCore::Widget::setFrameRect):
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::invalidateItem):
(WebCore::PopupMenu::valueChanged):
(WebCore::PopupWndProc):
* platform/win/ScrollViewWin.cpp:
(WebCore::ScrollView::setFrameRect):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::scrollbarUnderMouse):
(WebCore::ScrollView::paint):
* platform/win/ScrollbarThemeSafari.cpp:
(WebCore::ScrollbarThemeSafari::trackRect):
* platform/win/WidgetWin.cpp:
(WebCore::Widget::frameRect):
(WebCore::Widget::setFrameRect):
* platform/wx/WidgetWx.cpp:
(WebCore::Widget::frameRect):
(WebCore::Widget::setFrameRect):
* plugins/PluginView.cpp:
(WebCore::PluginView::setFrameRect):
* plugins/PluginView.h:
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paint):
(WebCore::PluginView::init):
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::init):
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paintMissingPluginIcon):
(WebCore::PluginView::paint):
(WebCore::PluginView::init):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::positionOverflowControls):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::paintScrollbar):
* rendering/RenderPart.cpp:
(WebCore::RenderPart::updateWidgetPosition):
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidgetGeometry):
(WebCore::RenderWidget::updateWidgetPosition):
2008-09-27 David Hyatt <hyatt@apple.com>
<rdar://problem/6252041> REGRESSION (4dp-TOT): Crash in Widget::platformWidget() when closing a PDF
This crash was lurking for a while and basically got exposed by my changes to visibleContentRect() to
access an actual member variable.
Reviewed by Dan Bernstein
* page/FocusController.cpp:
(WebCore::FocusController::setFocusedFrame):
2008-09-27 Jan Michael Alonzo <jmalonzo@webkit.org>
Attempt to fix QT Build. Not reviewed.
* WebCore.pro: add -n WebCore parameter to create_hash_table
2008-09-26 Gwenole Beauchesne <gbeauchesne@splitted-desktop.org>
Reviewed by Eric Seidel.
http://bugs.webkit.org/show_bug.cgi?id=18905
[GTK] Fix build with older pango (1.14.8)
* platform/graphics/gtk/FontGtk.cpp:
* platform/gtk/Language.cpp:
(_pango_get_lc_ctype):
(pango_language_get_default):
2008-09-26 David Hyatt <hyatt@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=21168
Make contentsToWindow/windowToContents cross-platform.
Reviewed by Oliver Hunt
* platform/ScrollView.cpp:
(WebCore::ScrollView::windowToContents):
(WebCore::ScrollView::contentsToWindow):
* platform/ScrollView.h:
* platform/gtk/ScrollViewGtk.cpp:
* platform/mac/ScrollViewMac.mm:
* platform/qt/ScrollViewQt.cpp:
* platform/win/ScrollViewWin.cpp:
* platform/wx/ScrollViewWx.cpp:
2008-09-26 Sam Weinig <sam@webkit.org>
GTK build fix.
* GNUmakefile.am:
2008-09-26 David Hyatt <hyatt@apple.com>
Eliminate shouldUpdateWhileOffscreen from ScrollView. Make the concept of not invalidating while
offscreen cross-platform. Rename the inWindow method to isOffscreen (which flips the boolean), since that
more clearly conveys the intent of the method. Make isOffscreen also check NSWindow visibility on Mac.
Reviewed by Oliver Hunt
* page/FrameView.cpp:
(WebCore::FrameView::repaintContentRectangle):
* page/FrameView.h:
* platform/ScrollView.h:
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::isOffscreen):
* platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::updateContents):
(WebCore::ScrollView::isOffscreen):
* platform/qt/ScrollViewQt.cpp:
(WebCore::ScrollView::isOffscreen):
* platform/win/ScrollViewWin.cpp:
(WebCore::ScrollView::isOffscreen):
* platform/wx/ScrollViewWx.cpp:
(WebCore::ScrollView::isOffscreen):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::willRenderImage):
2008-09-26 David Hyatt <hyatt@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=21164
Rework concept of allowsScrolling/setAllowsScrolling to be cross-platform.
Reviewed by Sam Weinig
* WebCore.base.exp:
* page/FrameView.cpp:
(WebCore::FrameView::setAllowsScrolling):
* page/FrameView.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::setAllowsScrolling):
* platform/ScrollView.h:
(WebCore::ScrollView::allowsScrolling):
* platform/win/ScrollViewWin.cpp:
(WebCore::ScrollView::wheelEvent):
2008-09-26 Kevin Ollivier <kevino@theolliviers.com>
wx build fixes after Widget/ScrollView changes.
* platform/wx/PopupMenuWx.cpp:
(WebCore::PopupMenu::show):
* platform/wx/ScrollViewWx.cpp:
(WebCore::ScrollView::platformSetContentsSize):
(WebCore::ScrollView::platformSetScrollbarModes):
(WebCore::ScrollView::wheelEvent):
* platform/wx/TemporaryLinkStubs.cpp:
* platform/wx/WidgetWx.cpp:
(WebCore::Widget::containingWindow):
2008-09-26 Timothy Hatcher <timothy@apple.com>
Allow searching for paths by always performing the
three search methods in the Elements panel and not
assume a search with a "/" is a XPath query.
https://bugs.webkit.org/show_bug.cgi?id=21159
Reviewed by Geoff Garen.
* page/inspector/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.performSearch):
2008-09-26 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Patch for https://bugs.webkit.org/show_bug.cgi?id=21152
Speedup static property get/put
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMBinding.cpp:
* bindings/js/JSDOMBinding.h:
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::getDOMConstructor):
(WebCore::jsDOMWindowBaseCrypto):
(WebCore::jsDOMWindowBaseEvent):
(WebCore::jsDOMWindowBaseImage):
(WebCore::jsDOMWindowBaseMessageChannel):
(WebCore::jsDOMWindowBaseOption):
(WebCore::jsDOMWindowBaseXMLHttpRequest):
(WebCore::jsDOMWindowBaseAudio):
(WebCore::jsDOMWindowBaseXSLTProcessor):
(WebCore::jsDOMWindowBaseOnabort):
(WebCore::jsDOMWindowBaseOnblur):
(WebCore::jsDOMWindowBaseOnchange):
(WebCore::jsDOMWindowBaseOnclick):
(WebCore::jsDOMWindowBaseOndblclick):
(WebCore::jsDOMWindowBaseOnerror):
(WebCore::jsDOMWindowBaseOnfocus):
(WebCore::jsDOMWindowBaseOnkeydown):
(WebCore::jsDOMWindowBaseOnkeypress):
(WebCore::jsDOMWindowBaseOnkeyup):
(WebCore::jsDOMWindowBaseOnload):
(WebCore::jsDOMWindowBaseOnmousedown):
(WebCore::jsDOMWindowBaseOnmousemove):
(WebCore::jsDOMWindowBaseOnmouseout):
(WebCore::jsDOMWindowBaseOnmouseover):
(WebCore::jsDOMWindowBaseOnmouseup):
(WebCore::jsDOMWindowBaseOnMouseWheel):
(WebCore::jsDOMWindowBaseOnreset):
(WebCore::jsDOMWindowBaseOnresize):
(WebCore::jsDOMWindowBaseOnscroll):
(WebCore::jsDOMWindowBaseOnsearch):
(WebCore::jsDOMWindowBaseOnselect):
(WebCore::jsDOMWindowBaseOnsubmit):
(WebCore::jsDOMWindowBaseOnbeforeunload):
(WebCore::jsDOMWindowBaseOnunload):
(WebCore::jsDOMWindowBaseOnWebKitAnimationStart):
(WebCore::jsDOMWindowBaseOnWebKitAnimationIteration):
(WebCore::jsDOMWindowBaseOnWebKitAnimationEnd):
(WebCore::jsDOMWindowBaseOnWebKitTransitionEnd):
(WebCore::JSDOMWindowBase::getOwnPropertySlot):
(WebCore::JSDOMWindowBase::put):
(WebCore::setJSDOMWindowBaseOnabort):
(WebCore::setJSDOMWindowBaseOnblur):
(WebCore::setJSDOMWindowBaseOnchange):
(WebCore::setJSDOMWindowBaseOnclick):
(WebCore::setJSDOMWindowBaseOndblclick):
(WebCore::setJSDOMWindowBaseOnerror):
(WebCore::setJSDOMWindowBaseOnfocus):
(WebCore::setJSDOMWindowBaseOnkeydown):
(WebCore::setJSDOMWindowBaseOnkeypress):
(WebCore::setJSDOMWindowBaseOnkeyup):
(WebCore::setJSDOMWindowBaseOnload):
(WebCore::setJSDOMWindowBaseOnmousedown):
(WebCore::setJSDOMWindowBaseOnmousemove):
(WebCore::setJSDOMWindowBaseOnmouseout):
(WebCore::setJSDOMWindowBaseOnmouseover):
(WebCore::setJSDOMWindowBaseOnmouseup):
(WebCore::setJSDOMWindowBaseOnMouseWheel):
(WebCore::setJSDOMWindowBaseOnreset):
(WebCore::setJSDOMWindowBaseOnresize):
(WebCore::setJSDOMWindowBaseOnscroll):
(WebCore::setJSDOMWindowBaseOnsearch):
(WebCore::setJSDOMWindowBaseOnselect):
(WebCore::setJSDOMWindowBaseOnsubmit):
(WebCore::setJSDOMWindowBaseOnbeforeunload):
(WebCore::setJSDOMWindowBaseOnunload):
(WebCore::setJSDOMWindowBaseOnWebKitAnimationStart):
(WebCore::setJSDOMWindowBaseOnWebKitAnimationIteration):
(WebCore::setJSDOMWindowBaseOnWebKitAnimationEnd):
(WebCore::setJSDOMWindowBaseOnWebKitTransitionEnd):
(WebCore::setJSDOMWindowBaseEvent):
(WebCore::setJSDOMWindowBaseAudio):
(WebCore::setJSDOMWindowBaseImage):
(WebCore::setJSDOMWindowBaseMessageChannel):
(WebCore::setJSDOMWindowBaseOption):
(WebCore::setJSDOMWindowBaseXMLHttpRequest):
(WebCore::setJSDOMWindowBaseXSLTProcessor):
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::nonCachingStaticCloseFunctionGetter):
(WebCore::nonCachingStaticBlurFunctionGetter):
(WebCore::nonCachingStaticFocusFunctionGetter):
(WebCore::nonCachingStaticPostMessageFunctionGetter):
* bindings/js/JSDOMWindowCustom.h:
(WebCore::JSDOMWindow::customGetOwnPropertySlot):
* bindings/js/JSEventTargetBase.cpp:
* bindings/js/JSEventTargetBase.h:
(WebCore::JSEventTargetBasePrototype::getOwnPropertySlot):
(WebCore::JSEventTargetBasePrototype::classInfo):
* bindings/js/JSEventTargetNode.cpp:
(WebCore::):
(WebCore::JSEventTargetNode::getOwnPropertySlot):
(WebCore::JSEventTargetNode::put):
* bindings/js/JSEventTargetNode.h:
(WebCore::JSEventTargetNode::classInfo):
(WebCore::JSEventTargetNode::prototypeClassName):
* bindings/js/JSEventTargetSVGElementInstance.cpp:
(WebCore::):
(WebCore::JSEventTargetSVGElementInstance::getOwnPropertySlot):
(WebCore::JSEventTargetSVGElementInstance::put):
* bindings/js/JSEventTargetSVGElementInstance.h:
(WebCore::JSEventTargetSVGElementInstance::classInfo):
(WebCore::JSEventTargetSVGElementInstance::prototypeClassName):
* bindings/js/JSHTMLInputElementCustom.cpp:
(WebCore::JSHTMLInputElement::customGetOwnPropertySlot):
* bindings/js/JSHistoryCustom.cpp:
(WebCore::nonCachingStaticBackFunctionGetter):
(WebCore::nonCachingStaticForwardFunctionGetter):
(WebCore::nonCachingStaticGoFunctionGetter):
(WebCore::JSHistory::customGetOwnPropertySlot):
* bindings/js/JSLocationCustom.cpp:
(WebCore::nonCachingStaticReplaceFunctionGetter):
(WebCore::nonCachingStaticReloadFunctionGetter):
(WebCore::nonCachingStaticAssignFunctionGetter):
(WebCore::JSLocation::customGetOwnPropertySlot):
(WebCore::JSLocation::customPut):
* bindings/scripts/CodeGeneratorJS.pm:
2008-09-26 David Hyatt <hyatt@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=21149
Make the concept of scroll modes cross-platform. Move the scrollbars up into ScrollView as well.
Eliminate the unused isScrollable() method.
Reviewed by Sam Weinig
* WebCore.base.exp:
* page/FrameView.cpp:
(WebCore::FrameView::resetScrollbars):
(WebCore::FrameView::initScrollbars):
(WebCore::FrameView::layout):
* page/FrameView.h:
* page/mac/WebCoreFrameView.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::init):
(WebCore::ScrollView::setScrollbarModes):
(WebCore::ScrollView::scrollbarModes):
(WebCore::ScrollView::platformSetScrollbarModes):
(WebCore::ScrollView::platformScrollbarModes):
* platform/ScrollView.h:
(WebCore::ScrollView::horizontalScrollbar):
(WebCore::ScrollView::verticalScrollbar):
(WebCore::ScrollView::isScrollViewScrollbar):
(WebCore::ScrollView::setHorizontalScrollbarMode):
(WebCore::ScrollView::setVerticalScrollbarMode):
(WebCore::ScrollView::horizontalScrollbarMode):
(WebCore::ScrollView::verticalScrollbarMode):
(WebCore::ScrollView::convertSelfToChild):
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
(WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
(WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar):
(WebCore::ScrollView::ScrollViewPrivate::valueChanged):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::scrollbarUnderMouse):
(WebCore::ScrollView::isScrollViewScrollbar):
(WebCore::ScrollView::paint):
(WebCore::ScrollView::scroll):
* platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::platformSetScrollbarModes):
(WebCore::ScrollView::platformScrollbarModes):
* platform/qt/ScrollViewQt.cpp:
(WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
(WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar):
(WebCore::ScrollView::ScrollViewPrivate::valueChanged):
(WebCore::ScrollView::horizontalScrollbar):
(WebCore::ScrollView::verticalScrollbar):
(WebCore::ScrollView::invalidateScrollbars):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::scrollbarUnderMouse):
(WebCore::ScrollView::paint):
(WebCore::ScrollView::scroll):
* platform/win/ScrollViewWin.cpp:
(WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
(WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
(WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar):
(WebCore::ScrollView::ScrollViewPrivate::valueChanged):
(WebCore::ScrollView::ScrollViewPrivate::setAllowsScrolling):
(WebCore::ScrollView::ScrollViewPrivate::allowsScrolling):
(WebCore::ScrollView::suppressScrollbars):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::scrollbarUnderMouse):
(WebCore::ScrollView::paint):
(WebCore::ScrollView::scroll):
* platform/wx/ScrollViewWx.cpp:
(WebCore::ScrollView::platformSetScrollbarModes):
(WebCore::ScrollView::platformScrollbarModes):
2008-09-26 David Kilzer <ddkilzer@apple.com>
Fix Mac build with XPATH and XSLT disabled
Reviewed by Alexey.
* bindings/objc/DOMUtility.mm:
(JSC::createDOMWrapper): Conditionalize code with ENABLE(XPATH).
* dom/XMLTokenizerLibxml2.cpp:
(WebCore::errorFunc): Conditionalize method with ENABLE(XSLT) to
prevent an unused code warning.
2008-09-26 Kevin McCullough <kmccullough@apple.com>
Rubber stamped by Tim Hatcher.
Bug 21098: Crashing under Console::log
- Speculative ASSERT to help find the problem.
* page/InspectorController.cpp:
(WebCore::ConsoleMessage::isEqual):
2008-09-26 Holger Hans Peter Freyther <zecke@selfish.org>
[gtk+] Build fix for the latest ScrollView changes
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::ScrollViewPrivate::adjustmentChanged):
(WebCore::ScrollView::ScrollViewPrivate::valueChanged):
2008-09-26 Timothy Hatcher <timothy@apple.com>
Fixes a bug where the console message repeat count would be wrong
when typing commands in between repeated messages.
https://bugs.webkit.org/show_bug.cgi?id=21145
Reviewed by Kevin McCullough.
* page/InspectorController.cpp:
(WebCore::InspectorController::clearConsoleMessages): Reset m_groupLevel.
(WebCore::InspectorController::didCommitLoad): Call clearConsoleMessages.
* page/inspector/Console.js:
(WebInspector.Console.prototype.addMessage): Remember the original repeat count
for each message as totalRepeatCount, since we now modify repeatCount to mean
repeats since previous console command. If repeatCountBeforeCommand is a number,
subtract that value from the repeatCount.
(WebInspector.Console.prototype.clearMessages): Delete the repeatCountBeforeCommand
and commandSincePreviousMessage properties.
2008-09-26 Eric Carlson <eric.carlson@apple.com>
Reviewed by Antti
https://bugs.webkit.org/show_bug.cgi?id=21116
<rdar://problem/5726325> Audio from <video> can still be heard after navigating
back to page with <video>, then closing tab
Rename willSaveToCache/didRestoreFromCache callbacks to documentWillBecomeInactive/
documentDidBecomeActive, and post documentWillBecomeInactive when a page is marked for
deletion.
* dom/Document.cpp:
(WebCore::Document::documentWillBecomeInactive):
(WebCore::Document::documentDidBecomeActive):
(WebCore::Document::registerForDocumentActivationCallbacks):
(WebCore::Document::unregisterForDocumentActivationCallbacks):
* dom/Document.h:
* dom/Element.h:
(WebCore::Element::documentWillBecomeInactive):
(WebCore::Element::documentDidBecomeActive):
* history/CachedPage.cpp:
(WebCore::CachedPage::CachedPage):
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::~HTMLFormElement):
(WebCore::HTMLFormElement::parseMappedAttribute):
(WebCore::HTMLFormElement::documentDidBecomeActive):
(WebCore::HTMLFormElement::willMoveToNewOwnerDocument):
(WebCore::HTMLFormElement::didMoveToNewOwnerDocument):
* html/HTMLFormElement.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::~HTMLInputElement):
(WebCore::HTMLInputElement::setInputType):
(WebCore::HTMLInputElement::parseMappedAttribute):
(WebCore::HTMLInputElement::needsActivationCallback):
(WebCore::HTMLInputElement::registerForActivationCallbackIfNeeded):
(WebCore::HTMLInputElement::unregisterForActivationCallbackIfNeeded):
(WebCore::HTMLInputElement::documentDidBecomeActive):
(WebCore::HTMLInputElement::willMoveToNewOwnerDocument):
(WebCore::HTMLInputElement::didMoveToNewOwnerDocument):
* html/HTMLInputElement.h:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::documentWillBecomeInactive):
(WebCore::HTMLMediaElement::documentDidBecomeActive):
* html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::inActiveDocument):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::opened):
* page/Page.cpp:
(WebCore::Page::~Page):
* rendering/RenderMedia.cpp:
(WebCore::RenderMedia::updateControls):
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::updatePlayer):
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::SVGSVGElement):
(WebCore::SVGSVGElement::~SVGSVGElement):
(WebCore::SVGSVGElement::documentWillBecomeInactive):
(WebCore::SVGSVGElement::documentDidBecomeActive):
* svg/SVGSVGElement.h:
2008-09-26 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon
Fix the build inside Qt, don't create faulty prl files for now.
* WebCore.pro:
2008-09-26 Simon Hausmann <hausmann@webkit.org>
Fix compilation on Qt/Windows
* Add WebCore/ to the include path so that config.h is found that enables JSC
* Link against winmm for the multimedia timer functions
* Include DateMath.h instead of JavaScriptCore/DateMath.h as file is in the kjs/
subdirectory
* In PluginViewWin.cpp don't use setPlatformWidget with the HWND for the Qt/Windows port
but set m_window directly as setPlatformWidget takes a QWidget*.
* WebCore.pro:
* platform/win/SystemTimeWin.cpp:
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::init):
2008-09-26 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Bug 21054: Construction of certain DOM objects is heavily regressed by r36675
<https://bugs.webkit.org/show_bug.cgi?id=21054>
This performance regression is actually just a symptom of a correctness
bug. The constructor objects for a number of properties that have security
checks on access were returning new objects each time. The most obvious
symptom of this bug is that window.Image != window.Image, etc.
The solution to this is to make sure we cache these constructors
in the same way as all the other DOM constructors. To achieve this
without causing any refcount cycles it is necessary to replace the
refcounted document pointer in the Image, MessageChannel, Option,
XMLHttpRequest, and Audio constructor objects with a reference to
the document's JS wrapper.
Tests: fast/dom/constructors-cached-navigate.html
fast/dom/constructors-cached.html
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSAudioConstructor.cpp:
(WebCore::JSAudioConstructor::mark):
* bindings/js/JSAudioConstructor.h:
(WebCore::JSAudioConstructor::document):
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::getDOMConstructor):
(WebCore::JSDOMWindowBase::getValueProperty):
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSHTMLOptionElementConstructor.cpp:
(WebCore::JSHTMLOptionElementConstructor::mark):
* bindings/js/JSHTMLOptionElementConstructor.h:
(WebCore::JSHTMLOptionElementConstructor::document):
* bindings/js/JSImageConstructor.cpp:
(WebCore::JSImageConstructor::mark):
* bindings/js/JSImageConstructor.h:
(WebCore::JSImageConstructor::document):
* bindings/js/JSXMLHttpRequestConstructor.cpp:
(WebCore::JSXMLHttpRequestConstructor::mark):
* bindings/js/JSXMLHttpRequestConstructor.h:
(WebCore::JSXMLHttpRequestConstructor::document):
2008-09-26 Simon Hausmann <hausmann@webkit.org>
Unreviewed one-liner build fix for the Qt/Windows build.
The build requires NPAPI support to be enabled, fix the condition in
the .pro file for that.
* WebCore.pro:
2008-09-26 Trenton Schulz <twschulz@trolltech.com>
Reviewed by Simon.
Fix compilation with the Qt/Cocoa port.
* platform/qt/ScrollViewQt.cpp:
(WebCore::ScrollView::updateScrollbars):
2008-09-26 Simon Hausmann <hausmann@webkit.org>
Reviewed by Holger.
Fix compilation with VC9SP1, work around bug in TR1 library by
disabling it.
* WebCore.pro:
2008-09-26 Simon Hausmann <hausmann@webkit.org>
Reviewed by Holger.
Fix an lupdate() warning.
Don't use tr() in a class that is not a QObject, use
QCoreApplication::translate() directly.
* platform/qt/ScrollbarQt.cpp:
(WebCore::Scrollbar::handleContextMenuEvent):
2008-09-25 David Hyatt <hyatt@apple.com>
Remove the scrollTo() method from FrameView, since it is not used by anyone.
Reviewed by Oliver Hunt
* page/FrameView.cpp:
* page/FrameView.h:
2008-09-25 David Hyatt <hyatt@apple.com>
Make scrollRectIntoViewRecursively cross-platform.
Reviewed by Oliver Hunt
* platform/ScrollView.cpp:
(WebCore::ScrollView::scrollRectIntoViewRecursively):
* platform/gtk/ScrollViewGtk.cpp:
* platform/mac/ScrollViewMac.mm:
* platform/qt/ScrollViewQt.cpp:
* platform/win/ScrollViewWin.cpp:
* platform/wx/ScrollViewWx.cpp:
2008-09-25 David Hyatt <hyatt@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=21133
Rename resizeContents method on ScrollView to setContentsSize (to match contentsSize()). Make it
cross-platform.
Reviewed by Oliver Hunt
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::begin):
* page/FrameView.cpp:
(WebCore::FrameView::adjustViewSize):
* platform/ScrollView.cpp:
(WebCore::ScrollView::setContentsSize):
* platform/ScrollView.h:
(WebCore::ScrollView::updateScrollbars):
* platform/gtk/ScrollViewGtk.cpp:
* platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::platformSetContentsSize):
* platform/qt/ScrollViewQt.cpp:
* platform/win/ScrollViewWin.cpp:
* platform/wx/ScrollViewWx.cpp:
(WebCore::ScrollView::platformSetContentsSize):
2008-09-25 David Hyatt <hyatt@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=21132
Clean up the methods that actually do the scrolling in ScrollView.
Reviewed by Oliver Hunt
* html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::setScrollLeft):
(WebCore::HTMLBodyElement::setScrollTop):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::restoreScrollPositionAndViewState):
* loader/ImageDocument.cpp:
(WebCore::ImageDocument::imageClicked):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::scrollBy):
(WebCore::DOMWindow::scrollTo):
* page/FrameView.cpp:
(WebCore::FrameView::scrollTo):
(WebCore::FrameView::setScrollPosition):
* page/FrameView.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::maximumScrollPosition):
* platform/ScrollView.h:
(WebCore::ScrollView::contentsWidth):
(WebCore::ScrollView::contentsHeight):
(WebCore::ScrollView::scrollBy):
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::setScrollPosition):
* platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::setScrollPosition):
* platform/qt/ScrollViewQt.cpp:
(WebCore::ScrollView::setScrollPosition):
(WebCore::ScrollView::scrollRectIntoViewRecursively):
* platform/win/ScrollViewWin.cpp:
(WebCore::ScrollView::setScrollPosition):
(WebCore::ScrollView::scrollRectIntoViewRecursively):
* platform/wx/ScrollViewWx.cpp:
(WebCore::ScrollView::setScrollPosition):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollByRecursively):
(WebCore::RenderLayer::scrollRectToVisible):
2008-09-25 Dan Bernstein <mitz@apple.com>
- attempted Windows build fix
* platform/win/ScrollViewWin.cpp:
(WebCore::ScrollView::ScrollViewPrivate::valueChanged):
(WebCore::ScrollView::setContentsPos):
(WebCore::ScrollView::paint):
2008-09-25 Timothy Hatcher <timothy@apple.com>
Revert the padding changes done in r36905 to prevent the
scrollbar from overlapping the URLs in the Console.
https://bugs.webkit.org/show_bug.cgi?id=21126
* page/inspector/inspector.css:
2008-09-25 David Hyatt <hyatt@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=21129
Refactor contents size and scroll offset to be cross-platform. Reduce further the number
of platform-specific methods required of ScrollView implementations.
Reviewed by Tim Hatcher
* dom/MouseRelatedEvent.cpp:
(WebCore::contentsX):
(WebCore::contentsY):
* html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::scrollLeft):
(WebCore::HTMLBodyElement::setScrollLeft):
(WebCore::HTMLBodyElement::scrollTop):
(WebCore::HTMLBodyElement::setScrollTop):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::saveScrollPositionAndViewStateToItem):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::scrollX):
(WebCore::DOMWindow::scrollY):
* page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):
* page/FrameView.cpp:
(WebCore::FrameView::scrollTo):
(WebCore::FrameView::windowClipRect):
* platform/ScrollView.cpp:
(WebCore::ScrollView::visibleContentRect):
(WebCore::ScrollView::contentsSize):
(WebCore::ScrollView::platformContentsSize):
* platform/ScrollView.h:
(WebCore::ScrollView::scrollPosition):
(WebCore::ScrollView::scrollOffset):
(WebCore::ScrollView::scrollX):
(WebCore::ScrollView::scrollY):
(WebCore::ScrollView::contentsWidth):
(WebCore::ScrollView::contentsHeight):
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::ScrollViewPrivate::adjustmentChanged):
(WebCore::ScrollView::setGtkAdjustments):
(WebCore::ScrollView::resizeContents):
(WebCore::ScrollView::contentsWidth):
(WebCore::ScrollView::contentsHeight):
(WebCore::ScrollView::scrollOffset):
(WebCore::ScrollView::maximumScroll):
(WebCore::ScrollView::scrollBy):
(WebCore::ScrollView::suppressScrollbars):
(WebCore::ScrollView::setHScrollbarMode):
(WebCore::ScrollView::setVScrollbarMode):
(WebCore::ScrollView::setScrollbarsMode):
(WebCore::ScrollView::setFrameGeometry):
(WebCore::ScrollView::updateScrollbars):
* platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::platformContentsSize):
(WebCore::ScrollView::scrollBy):
* platform/mac/WidgetMac.mm:
(WebCore::Widget::convertFromContainingWindow):
(WebCore::Widget::convertToContainingWindow):
* platform/qt/ScrollViewQt.cpp:
(WebCore::ScrollView::ScrollViewPrivate::valueChanged):
(WebCore::ScrollView::resizeContents):
(WebCore::ScrollView::setFrameGeometry):
(WebCore::ScrollView::scrollOffset):
(WebCore::ScrollView::maximumScroll):
(WebCore::ScrollView::scrollBy):
(WebCore::ScrollView::setHScrollbarMode):
(WebCore::ScrollView::setVScrollbarMode):
(WebCore::ScrollView::setScrollbarsMode):
(WebCore::ScrollView::updateScrollbars):
* platform/win/ScrollViewWin.cpp:
(WebCore::ScrollView::ScrollViewPrivate::valueChanged):
(WebCore::ScrollView::ScrollViewPrivate::setAllowsScrolling):
(WebCore::ScrollView::resizeContents):
(WebCore::ScrollView::setFrameGeometry):
(WebCore::ScrollView::scrollOffset):
(WebCore::ScrollView::maximumScroll):
(WebCore::ScrollView::scrollBy):
(WebCore::ScrollView::setHScrollbarMode):
(WebCore::ScrollView::setVScrollbarMode):
(WebCore::ScrollView::setScrollbarsMode):
(WebCore::ScrollView::updateScrollbars):
* platform/wx/ScrollViewWx.cpp:
(WebCore::ScrollView::platformVisibleContentRect):
(WebCore::ScrollView::platformContentsSize):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeAtPoint):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollRectToVisible):
(WebCore::RenderLayer::calculateClipRects):
(WebCore::RenderLayer::calculateRects):
* rendering/RenderView.cpp:
(WebCore::RenderView::absolutePosition):
(WebCore::RenderView::computeAbsoluteRepaintRect):
2008-09-25 David Smith <catfish.man@gmail.com>
Reviewed by Dave Hyatt.
Fix a nasty regression I introduced in the previous commit, which caused infinite recursion on facebook.
* dom/Element.cpp:
(WebCore::Element::rareData):
* dom/Element.h:
* dom/Node.cpp:
(WebCore::Node::rareData):
* dom/Node.h:
2008-09-25 David Smith <catfish.man@gmail.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=20980
Split off uncommonly used data from Node similar to ElementRareData
Saves an OwnPtr and a short on Node, as well as providing room for an isContainer bit,
which in turn allows inlining firstChild(), lastChild(), childNodeCount(), and childNode()
for a 5-10+% performance win on SlickSpeed and assorted speedups on other tests.
* WebCore.base.exp:
* WebCore.xcodeproj/project.pbxproj:
* dom/ChildNodeList.cpp: Include ContainerNode to pick up its definitions for childNodeCount(), etc...
* dom/ContainerNode.cpp: Set isContainer to true
(WebCore::ContainerNode::ContainerNode):
* dom/ContainerNode.h: These Node inlines are here to avoid including ContainerNode.h in Node.h
(WebCore::Node::containerChildNodeCount): Use ContainerNode's definition, having proved that the Node is a container
(WebCore::Node::containerChildNode): ditto
(WebCore::Node::containerFirstChild): ditto
(WebCore::Node::containerLastChild): ditto
* dom/Element.cpp: Most of the changes here are moving ElementRareData to ElementRareData.h and NodeRareData.h
(WebCore::Element::Element):
(WebCore::Element::~Element):
(WebCore::Element::rareData):
(WebCore::Element::ensureRareData): Renamed from createRareData
(WebCore::Element::createRareData): Used by ensureRareData to get the correct rareData type
(WebCore::Element::attach): Check hasRareData rather than null-checking rareData()
(WebCore::Element::detach): ditto
(WebCore::Element::recalcStyle): ditto
(WebCore::Element::focus):
(WebCore::Element::minimumSizeForResizing): ditto
(WebCore::Element::setMinimumSizeForResizing): ditto
(WebCore::Element::computedStyle):
(WebCore::Element::cancelFocusAppearanceUpdate): ditto
* dom/Element.h:
* dom/ElementRareData.h: Added; everything copied from Element.cpp
(WebCore::defaultMinimumSizeForResizing):
(WebCore::ElementRareData::ElementRareData):
(WebCore::ElementRareData::resetComputedStyle):
* dom/EventTargetNode.cpp:
(WebCore::EventTargetNode::EventTargetNode): Pass the isContainer flag up the chain
* dom/EventTargetNode.h:
* dom/Node.cpp:
(WebCore::Node::Node):
(WebCore::Node::~Node): rareData cleanup code moved from Element and changed to use hasRareData
(WebCore::Node::rareData):
(WebCore::Node::ensureRareData):
(WebCore::Node::createRareData):
(WebCore::Node::tabIndex): nonzero tab indexes are now in rareData
(WebCore::Node::setTabIndexExplicitly):
(WebCore::Node::childNodes): NodeLists are now in rareData
(WebCore::Node::setFocus):
(WebCore::Node::rareDataFocused):
(WebCore::Node::isFocusable):
(WebCore::Node::isKeyboardFocusable):
(WebCore::Node::registerDynamicNodeList): NodeLists are now in rareData
(WebCore::Node::unregisterDynamicNodeList): ditto
(WebCore::Node::notifyLocalNodeListsAttributeChanged): ditto
(WebCore::Node::notifyLocalNodeListsChildrenChanged): ditto
(WebCore::Node::getElementsByName): ditto
(WebCore::Node::getElementsByClassName): ditto
* dom/Node.h:
(WebCore::Node::firstChild): Use isContainerNode() to devirtualize
(WebCore::Node::lastChild): ditto
(WebCore::Node::isContainerNode): Take advantage of a newly freed bit to store whether we're a container
(WebCore::Node::focused): focus is in rareData if set
(WebCore::Node::childTypeAllowed):
(WebCore::Node::childNodeCount): Use isContainerNode() to devirtualize
(WebCore::Node::childNode): ditto
(WebCore::Node::hasRareData): Use another newly freed bit to store whether we have rare data; avoids doing hash lookups in the common case
* dom/NodeRareData.h: Added. Most of this is just properties moved from Node
(WebCore::NodeListsNodeData::~NodeListsNodeData): Moved from Node.cpp since we NodeRareData needs to put them in a HashTable :(
(WebCore::NodeRareData::NodeRareData):
(WebCore::NodeRareData::rareDataMap):
(WebCore::NodeRareData::rareDataFromMap):
(WebCore::NodeRareData::clearNodeLists):
(WebCore::NodeRareData::setNodeLists):
(WebCore::NodeRareData::nodeLists):
(WebCore::NodeRareData::tabIndex):
(WebCore::NodeRareData::setTabIndex):
(WebCore::NodeRareData::tabIndexSetExplicitly):
* dom/TreeWalker.cpp: Include ContainerNode to pick up its definitions for childNodeCount(), etc...
* xml/XPathUtil.cpp: Include ContainerNode to pick up its definitions for childNodeCount(), etc...
2008-09-25 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Simon Hausmann.
[qt] ImageBuffer::toDataURL implementation
There needs to be a Qt specific test result for the above mentioned
implementation.
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBuffer::toDataURL):
2008-09-25 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Simon Hausmann.
[qt] Implement SharedBuffer for Qt.
* WebCore.pro:
* platform/qt/SharedBufferQt.cpp: Added.
(WebCore::SharedBuffer::createWithContentsOfFile):
* platform/qt/TemporaryLinkStubs.cpp:
2008-09-25 Feng Qian <feng@chromium.org>
Fix bug: https://bugs.webkit.org/show_bug.cgi?id=21032
<rdar://problem/6243032>
Reviewed by Dave Hyatt.
Test: fast/dom/attribute-downcast-right.html
Add isMappedAttribute function to Attribute for checking if an object
is an instance of MappedAttribute. Removed attributeItem,
getAttributeItem functions from NamedMappedAttrMap, and callers
expecting MappedAttribute have to check isMappedAttribute before
downcasting the return value to MappedAttribute.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForElement):
* dom/Attribute.h:
(WebCore::Attribute::isMappedAttribute):
* dom/MappedAttribute.h:
(WebCore::MappedAttribute::isMappedAttribute):
* dom/NamedMappedAttrMap.cpp:
(WebCore::NamedMappedAttrMap::declCount):
(WebCore::NamedMappedAttrMap::mapsEquivalent):
* dom/NamedMappedAttrMap.h:
* dom/StyledElement.cpp:
(WebCore::StyledElement::attributeChanged):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setInputType):
* svg/SVGForeignObjectElement.cpp:
(WebCore::addCSSPropertyAndNotifyAttributeMap):
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::getPresentationAttribute):
2008-09-25 David Hyatt <hyatt@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=21120
Make visibleContentRect cross-platform. Note this does add new horizontal/verticalScrollbar accessors
to a bunch of platforms. This is a temporary evil until the scrollbars get made cross-platform (and I
didn't want to mix that change in with this patch).
Reviewed by Sam Weinig
* page/Frame.cpp:
(WebCore::Frame::markAllMatchesForText):
* page/FrameView.cpp:
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::windowClipRect):
(WebCore::FrameView::updateControlTints):
* platform/ScrollView.cpp:
(WebCore::ScrollView::visibleContentRect):
(WebCore::ScrollView::platformVisibleContentRect):
* platform/ScrollView.h:
(WebCore::ScrollView::visibleWidth):
(WebCore::ScrollView::visibleHeight):
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::horizontalScrollbar):
(WebCore::ScrollView::verticalScrollbar):
* platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::horizontalScrollbar):
(WebCore::ScrollView::verticalScrollbar):
(WebCore::ScrollView::platformVisibleContentRect):
* platform/qt/ScrollViewQt.cpp:
(WebCore::ScrollView::horizontalScrollbar):
(WebCore::ScrollView::verticalScrollbar):
* platform/win/ScrollViewWin.cpp:
(WebCore::ScrollView::horizontalScrollbar):
(WebCore::ScrollView::verticalScrollbar):
* platform/wx/ScrollViewWx.cpp:
(WebCore::ScrollView::platformVisibleContentRect):
(WebCore::ScrollView::horizontalScrollbar):
(WebCore::ScrollView::verticalScrollbar):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollRectToVisible):
(WebCore::frameVisibleRect):
* rendering/RenderView.cpp:
(WebCore::RenderView::viewRect):
2008-09-25 David Smith <catfish.man@gmail.com>
Reviewed by Timothy Hatcher
https://bugs.webkit.org/show_bug.cgi?id=21052
Generalize id selector special case for querySelectorAll
By checking the element we get with getElementById against the selector, we can use the special case in many more circumstances.
Changes results on http://native.khan.mozilla.org
from
#title: 2ms
h1#title: 55ms
div #title: 55ms
to:
#title: 1ms
h1#title: 2ms
div #title: 5ms
* dom/Node.cpp:
(WebCore::Node::querySelector):
* dom/SelectorNodeList.cpp:
(WebCore::createSelectorNodeList):
2008-09-25 David Hyatt <hyatt@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=21118
Make the concept of whether you can blit on scroll cross-platform on ScrollView.
Reviewed by Sam Weinig
* page/FrameView.cpp:
(WebCore::FrameView::clear):
(WebCore::FrameView::layout):
(WebCore::FrameView::setUseSlowRepaints):
(WebCore::FrameView::addSlowRepaintObject):
(WebCore::FrameView::removeSlowRepaintObject):
* platform/ScrollView.cpp:
(WebCore::ScrollView::init):
(WebCore::ScrollView::addChild):
(WebCore::ScrollView::removeChild):
(WebCore::ScrollView::setCanBlitOnScroll):
* platform/ScrollView.h:
(WebCore::ScrollView::canBlitOnScroll):
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
(WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
(WebCore::ScrollView::ScrollView):
* platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::ScrollView):
(WebCore::ScrollView::platformAddChild):
(WebCore::ScrollView::platformRemoveChild):
(WebCore::ScrollView::platformSetCanBlitOnScroll):
* platform/qt/ScrollViewQt.cpp:
(WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
(WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
(WebCore::ScrollView::ScrollView):
* platform/win/ScrollViewWin.cpp:
(WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
(WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
(WebCore::ScrollView::ScrollView):
* platform/wx/ScrollViewWx.cpp:
(WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
(WebCore::ScrollView::ScrollView):
(WebCore::ScrollView::scrollBy):
2008-09-25 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim Hatcher.
Bug 21109: Console should right-align urls
* page/inspector/Console.js: Re-order the message elements so that when
it overflows it doesn't get mixed in with the next message.
* page/inspector/inspector.css:
2008-09-25 David Hyatt <hyatt@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=21113
Putting r36771 back in with a fix to the addPendingSheet check in CSSImportRule::insertedIntoParent.
Reviewed by Darin Adler
* css/CSSImportRule.cpp:
(WebCore::CSSImportRule::insertedIntoParent):
* css/CSSRule.cpp:
(WebCore::CSSRule::parentStyleSheet):
(WebCore::CSSRule::parentRule):
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::CSSStyleSheet):
* css/CSSStyleSheet.h:
2008-09-25 Darin Adler <darin@apple.com>
Reviewed by Adele Peterson.
- fix https://bugs.webkit.org/show_bug.cgi?id=21115
<rdar://problem/6245773> REGRESSION (r34702): Safari no longer zips
bundled documents
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::formData): Use files() instead of value()
to get the path, since value() now returns just the basename.
2008-09-25 Brady Eidson <beidson@apple.com>
Rubberstamped by Mark Rowe
Roll out 36771 as it caused <rdar://problem/6246554>
"nytimes.com doesn't display after returning to it with back/forward"
* css/CSSImportRule.cpp:
(WebCore::CSSImportRule::insertedIntoParent):
* css/CSSRule.cpp:
(WebCore::CSSRule::parentStyleSheet):
(WebCore::CSSRule::parentRule):
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::CSSStyleSheet):
(WebCore::CSSStyleSheet::docLoader):
* css/CSSStyleSheet.h:
(WebCore::CSSStyleSheet::doc):
2008-09-25 Adam Roben <aroben@apple.com>
Windows build fix
* WebCore.vcproj/WebCore.vcproj: Add ScrollView.cpp to the project.
2008-09-25 Dan Bernstein <mitz@apple.com>
- Windows build fix
* platform/win/ScrollViewWin.cpp:
(WebCore::ScrollView::addChildPlatformWidget):
(WebCore::ScrollView::removeChildPlatformWidget):
2008-09-25 Timothy Hatcher <timothy@apple.com>
Fixes a leak of ConsoleMessage seen when repeated console
messages occur.
Reviewed by Mark Rowe.
* page/InspectorController.cpp:
(WebCore::InspectorController::addConsoleMessage): Delete the repeat
since we don't add it to m_consoleMessages.
2008-09-25 Kevin McCullough <kmccullough@apple.com>
Reviewed by Dan Bernstein.
Bug 21105: XHRs logged in the console may show the wrong URL for the
source
- Get the url at the time of the send() and pass it on to the XHR.
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::send):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::didFinishLoading):
* xml/XMLHttpRequest.h:
(WebCore::XMLHttpRequest::setLastSendURL):
2008-09-25 Kevin McCullough <kmccullough@apple.com>
Reviewed by Geoff and Tim.
Bug 20322: XHRs logged in the console do not have line numbers
- Get the line number at the time of the send and pass it on to the XHR.
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::send):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::didFinishLoading):
* xml/XMLHttpRequest.h:
(WebCore::XMLHttpRequest::setLastSendLineNumber):
2008-09-25 Eric Carlson <eric.carlson@apple.com>
Reviewed by Eric Seidel.
<rdar://problem/6171047> HTMLMediaElement "begin" event is now "loadstart"
https://bugs.webkit.org/show_bug.cgi?id=21003
* dom/EventNames.h: remove "begin" event
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::load): Post "loadstart" event instead of "begin"
2008-09-25 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=21097
Calling a MessageChannel constructor from a destroyed document results in a crash
Test: fast/events/message-port-constructor-for-deleted-document.html
* bindings/js/JSMessageChannelConstructor.cpp:
(WebCore::JSMessageChannelConstructor::construct):
* bindings/js/JSMessageChannelConstructor.h:
Made m_document a RefPtr.
2008-09-24 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Sam Weinig, Anders Carlsson, and (unofficially) Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=20879
Implement HTML5 channel messaging
Tests: fast/events/message-channel-gc.html
fast/events/message-port-deleted-document.html
fast/events/message-port-deleted-frame.html
fast/events/message-port-inactive-document.html
fast/events/message-port.html
http/tests/security/MessagePort/event-listener-context.html
* Configurations/WebCore.xcconfig:
Removed unused ENABLE_CROSS_DOCUMENT_MESSAGING macro.
* DerivedSources.make:
Added MessageChannel and MessagePort.
* WebCore.pro: Made MessageEvent compilation unconditional, as it could not possibly be
turmed off anyway. Added new files.
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
Added new files.
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::getValueProperty):
Added suport for window.MessageChannel constructor.
* bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::postMessage):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::postMessage):
* page/DOMWindow.h:
* page/DOMWindow.idl:
Added support for three-argument postMessage (that posts a MessagePort).
* dom/EventTarget.cpp:
(WebCore::EventTarget::toMessagePort):
* dom/EventTarget.h:
* bindings/js/JSEventTargetBase.cpp: (WebCore::toJS): Added MessagePort as yet another
EventTarget variant.
* bindings/js/JSMessageChannelConstructor.h:
* bindings/js/JSMessageChannelConstructor.cpp: Added a custom constructor, so that it could
take a browsing context (document) parameter.
* bindings/js/JSMessageChannelCustom.cpp: Added.
(WebCore::JSMessageChannel::mark): JSMessageChannel uses a custom mark function to mark
port1 and port2 that it owns.
* bindings/js/JSMessagePortCustom.cpp: Added.
(WebCore::JSMessagePort::startConversation):
(WebCore::JSMessagePort::addEventListener):
(WebCore::JSMessagePort::removeEventListener):
(WebCore::JSMessagePort::dispatchEvent):
(WebCore::JSMessagePort::setOnmessage):
(WebCore::JSMessagePort::onmessage):
(WebCore::JSMessagePort::setOnclose):
(WebCore::JSMessagePort::onclose):
(WebCore::JSMessagePort::mark):
* dom/MessagePort.cpp: Added.
* dom/MessagePort.h: Added.
* dom/MessagePort.idl: Added.
Added a MessagePort implementation. Currently, it is not thread-safe at all, and only works
with Documents as contexts, but in the future, it will be used for communication with worker
threads.
* bindings/objc/DOMInternal.h: Include "DOMMessagePortInternal.h". The new APIs do not
really have Obj-C bindings, as they are far from being final, but a MessagePort stub is
needed for MessageEvent.
* bindings/scripts/CodeGeneratorJS.pm: Include PlatformString.h for MessagePort happiness.
* dom/Document.cpp:
(WebCore::MessagePortTimer::MessagePortTimer):
(WebCore::MessagePortTimer::fired):
(WebCore::Document::processMessagePortMessagesSoon):
(WebCore::Document::~Document):
(WebCore::Document::dispatchMessagePortEvents):
(WebCore::Document::createdMessagePort):
(WebCore::Document::destroyedMessagePort):
* dom/Document.h:
Document keeps track of all MessagePort objects that were created when it was fully active
in its context.
* dom/EventNames.h: Added closeEvent.
* dom/MessageChannel.cpp: Added.
(WebCore::MessageChannel::MessageChannel):
(WebCore::MessageChannel::~MessageChannel):
* dom/MessageChannel.h: Added.
(WebCore::MessageChannel::create):
(WebCore::MessageChannel::port1):
(WebCore::MessageChannel::port2):
* dom/MessageChannel.idl: Added.
Addded JSMessageChannel implementation.
* dom/MessageEvent.cpp:
(WebCore::MessageEvent::MessageEvent):
(WebCore::MessageEvent::initMessageEvent):
* dom/MessageEvent.h:
(WebCore::MessageEvent::create):
(WebCore::MessageEvent::messagePort):
* dom/MessageEvent.idl:
MessageEvent has a MessagePort member now, making it possible to pass ports across
documents.
2008-09-25 David Smith <catfish.man@gmail.com>
Reviewed by Eric Seidel
fix https://bugs.webkit.org/show_bug.cgi?id=21091
Regression: querySelector matches tag names case sensitively
Tests: fast/dom/SelectorAPI/caseTag.html
fast/dom/SelectorAPI/caseTagX.xhtml
* css/CSSParser.cpp:
(WebCore::CSSParser::parseSelector): Add a Document argument, since tag case sensitivity is different for HTML documents
* css/CSSParser.h:
* dom/Node.cpp:
(WebCore::Node::querySelector):
(WebCore::Node::querySelectorAll):
2008-09-24 David Hyatt <hyatt@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=21084
Make the m_children member of ScrollView cross-platform. Consolidate children add/remove
functionality. Add platform stubs for connecting/disconnecting the platform widgets.
Reviewed by Sam Weinig
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* platform/ScrollView.h:
(WebCore::ScrollView::children):
* platform/Widget.h:
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::addChildPlatformWidget):
(WebCore::ScrollView::removeChildPlatformWidget):
(WebCore::ScrollView::geometryChanged):
* platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::addChildPlatformWidget):
(WebCore::ScrollView::removeChildPlatformWidget):
* platform/qt/ScrollViewQt.cpp:
(WebCore::ScrollView::geometryChanged):
(WebCore::ScrollView::addChildPlatformWidget):
(WebCore::ScrollView::removeChildPlatformWidget):
* platform/win/ScrollViewWin.cpp:
(WebCore::ScrollView::geometryChanged):
(WebCore::ScrollView::setParentVisible):
(WebCore::ScrollView::show):
(WebCore::ScrollView::hide):
* platform/wx/ScrollViewWx.cpp:
(WebCore::ScrollView::addChildPlatformWidget):
(WebCore::ScrollView::removeChildPlatformWidget):
2008-09-25 Dan Bernstein <mitz@apple.com>
Reviewed by Dave Hyatt.
- fix https://bugs.webkit.org/show_bug.cgi?id=21024
<rdar://problem/6240821> Scrollbar not painted until hovered
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidgetGeometry): Replaced resizeWidget with
this method, which sets both the location and the size.
(WebCore::RenderWidget::setWidget): Replaced the call to resizeWidget
with a call to the new method setWidgetGeometry. Positioning the
widget correctly ensures that the scroll bars invalidate correctly when
they are created and resized.
* rendering/RenderWidget.h:
2008-09-24 Dan Bernstein <mitz@apple.com>
Rubber-stamped by Sam Weinig.
- create a "style" subfolder under "rendering" and move style files to that folder
* WebCore.vcproj/WebCore.vcproj:
2008-09-24 Sam Weinig <sam@webkit.org>
Reviewed by Maciej Stachowiak.
Remove staticFunctionGetter. There is only one remaining user of
staticFunctionGetter and it can be converted to use setUpStaticFunctionSlot.
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::getOwnPropertySlot):
2008-09-24 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Dan Bernstein.
Test: editing/spelling/inline_spelling_markers.html
- https://bugs.webkit.org/show_bug.cgi?id=20092
Spelling markers positioned incorrectly in RTL text
Measure spelling markers with selectionRectForText() to fix RTL.
This patch also fixes hit-testing for spelling marker tool tips,
which used to work only on the first line.
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
2008-09-24 David Hyatt <hyatt@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=21074
Make sure the viewless scrollbar knows how to paint properly when transformed.
Reviewed by Sam Weinig
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::ScrollbarThemeMac):
(WebCore::ScrollbarThemeMac::paint):
2008-09-24 Nikolas Zimmermann <zimmermann@kde.org>
Not reviewed. Try to fix win build.
* bindings/js/JSSVGElementInstanceCustom.cpp:
(WebCore::toJS):
* dom/ContainerNodeAlgorithms.h:
(WebCore::removeAllChildrenInContainer):
(WebCore::appendChildToContainer):
(WebCore::Private::addChildNodesToDeletionQueue):
2008-09-24 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Oliver.
Add ContainerNodeAlgorithms.h, as central place to share algorithms
operating on TreeShared-derived classes with a Node-style interface.
This allows SVGElementInstance & ContainerNode to share code.
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeAllChildren):
(WebCore::ContainerNode::addChild):
* dom/ContainerNode.h:
* dom/ContainerNodeAlgorithms.h: Added.
(WebCore::removeAllChildrenInContainer):
(WebCore::appendChildToContainer):
(WebCore::Private::NodeRemovalDispatcher::dispatch):
(WebCore::Private::addChildNodesToDeletionQueue):
2008-09-24 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dave Hyatt
Wrap up dirtying the z-order list of the stacking context
RenderLayer into a method.
https://bugs.webkit.org/show_bug.cgi?id=21072
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setHasVisibleContent):
(WebCore::RenderLayer::addChild):
(WebCore::RenderLayer::removeChild):
(WebCore::RenderLayer::dirtyStackingContextZOrderLists):
(WebCore::RenderLayer::styleChanged):
* rendering/RenderLayer.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::setStyle):
2008-09-24 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim.
Bug 21070: REGRESSION Repeated messages with arguments are not repeated
or displayed multiple times
- The Insepctor Controller was comparing JSValue pointers so thought the
message was not a repeat, but the JS of the inspector compared the
strings and so knew it was the same message and so overwrote the old
message.
* page/InspectorController.cpp:
(WebCore::ConsoleMessage::isEqual):
(WebCore::InspectorController::addMessageToConsole):
(WebCore::InspectorController::addConsoleMessage):
(WebCore::InspectorController::startGroup):
(WebCore::InspectorController::endGroup):
* page/InspectorController.h:
2008-09-24 David Hyatt <hyatt@apple.com>
Make sure the viewless Mac scrollbar responds properly to system preference changes (including the
arrow placement preference and the thumb jump preference).
Reviewed by Adam Roben
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::Scrollbar):
(WebCore::Scrollbar::~Scrollbar):
* platform/ScrollbarTheme.h:
(WebCore::ScrollbarTheme::registerScrollbar):
(WebCore::ScrollbarTheme::unregisterScrollbar):
* platform/mac/ScrollbarThemeMac.h:
* platform/mac/ScrollbarThemeMac.mm:
(+[ScrollbarPrefsObserver appearancePrefsChanged:]):
(+[ScrollbarPrefsObserver behaviorPrefsChanged:]):
(+[ScrollbarPrefsObserver registerAsObserver]):
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::unregisterScrollbar):
(WebCore::ScrollbarThemeMac::ScrollbarThemeMac):
(WebCore::ScrollbarThemeMac::preferencesChanged):
2008-09-24 Rob Buis <buis@kde.org>
Reviewed by Darin.
https://bugs.webkit.org/show_bug.cgi?id=20557
getScreenCTM() returns wrong values
Use the absolute position of the svg root when
determining the screen ctm.
Test: svg/custom/getscreenctm-in-mixed-content2.xhtml
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::getScreenCTM):
2008-09-24 David Hyatt <hyatt@apple.com>
Turn off support for CSS variables.
* ChangeLog:
* css/CSSParser.cpp:
(WebCore::CSSParser::createVariablesRule):
(WebCore::CSSParser::addVariable):
(WebCore::CSSParser::addVariableDeclarationBlock):
2008-09-24 David Hyatt <hyatt@apple.com>
Back out the alternate forms of CSS variable call syntax (leaving only the -webkit-var version).
* css/CSSGrammar.y:
* css/CSSParserValues.cpp:
(WebCore::CSSParserValue::isVariable):
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::getStringValue):
(WebCore::CSSPrimitiveValue::cssText):
(WebCore::CSSPrimitiveValue::parserValue):
* css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::):
(WebCore::CSSPrimitiveValue::isVariable):
2008-09-24 Timothy Hatcher <timothy@apple.com>
Fixes a regression where the "incorrect MIME-type" warning would not
show up correctly in the Console or the resources sidebar.
Reviewed by Kevin McCullough.
* page/inspector/Resource.js:
(WebInspector.Resource.prototype._addTip): Add the repeat count argument
to the WebInspector.ConsoleMessage constructor call.
(WebInspector.Resource.prototype._checkWarning): Ditto.
2008-09-23 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Remove deprecated JS Qt bindings object call/construct code and fix autotests
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtInstance::QtInstance):
* bridge/qt/qt_instance.h:
2008-09-23 Julien Chaffraix <jchaffraix@pleyo.com>
Reviewed by Alp Toker. Landed by Jan Alonzo.
Bug 20883: [CURL] Add deferred loading
https://bugs.webkit.org/show_bug.cgi?id=20883
Implement deferred loading for the libcURL backend using curl_easy_pause.
As the method was introduced in version 7.18.0, all the code checks for libcURL
version.
* platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::ResourceHandle::setDefersLoading):
* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::writeCallback): Add an assertion that deferred loading is not
activated.
(WebCore::headerCallback): Ditto.
(WebCore::readCallback): Ditto.
(WebCore::ResourceHandleManager::dispatchSynchronousJob): Force
defersLoading to be false in order to avoid triggering an assertion.
(WebCore::ResourceHandleManager::initializeHandle): If deferred loading is
activated, pause the easy handle.
2008-09-23 Matt Lilek <webkit@mattlilek.com>
Reviewed by Tim Hatcher.
Inspector search field style tweaks.
* page/inspector/inspector.css:
2008-09-23 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Eric.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=21046 (Several LayoutTests crash)
Fix missing negation in EventTargetNode::insertedIntoDocument.
Made handleLocalEvents() virtual again, HTMLFormElement overrides it.
Remove code, that wasn't supposed to go in in dispatchGenericEvent().
* dom/EventTargetNode.cpp:
(WebCore::EventTargetNode::insertedIntoDocument):
(WebCore::EventTargetNode::dispatchGenericEvent):
* dom/EventTargetNode.h:
2008-09-23 Timothy Hatcher <timothy@apple.com>
Adds search support to the Profiles panel.
The Profiles panel supports a few types of queries:
* Standard string matching for function names and file URLs.
* Greater than and less than search for numeric columns.
So a query of ">24" will match all rows that have calls
greater than 24. Or "<=42" will match all 42 or less.
* Percent and time units. Adding a unit of "s", "ms" or "%"
is supported and will match only the Self and Total columns.
So a query of ">1.25s" will match all rows that took longer
than 1.25 seconds.
Reviewed by Oliver Hunt.
* page/inspector/ProfileView.js:
(WebInspector.ProfileView.prototype.hide): Reset _currentSearchResultIndex to -1. So the next time
it will start at the first result.
(WebInspector.ProfileView.prototype.refreshShowAsPercents): Moved from the bottom of the file.
(WebInspector.ProfileView.prototype.searchCanceled): Clear the search properties and refresh highlighted
data grid nodes.
(WebInspector.ProfileView.prototype.performSearch): Search the profile nodes.
(WebInspector.ProfileView.prototype.jumpToFirstSearchResult): Does what the function says. Calls _jumpToSearchResult.
(WebInspector.ProfileView.prototype.jumpToLastSearchResult): Ditto.
(WebInspector.ProfileView.prototype.jumpToNextSearchResult): Ditto.
(WebInspector.ProfileView.prototype.jumpToPreviousSearchResult): Ditto.
(WebInspector.ProfileView.prototype.showingFirstSearchResult): Does what the function says.
(WebInspector.ProfileView.prototype.showingLastSearchResult): Ditto.
(WebInspector.ProfileView.prototype._jumpToSearchResult): Select and reveal the profile node.
Expand all the ancestors first so the profile node will have a DataGridNode.
(WebInspector.ProfileView.prototype._changeView): Perform the search again on the new tree.
(WebInspector.ProfileDataGridNode.prototype.createCell): Add the highlight class to cells that
have search matches.
* page/inspector/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.reset): Call searchCanceled and delete the currentQuery.
(WebInspector.ProfilesPanel.prototype.showProfile): Use profileViewForProfile.
(WebInspector.ProfilesPanel.prototype.showView): Call showProfile. Used by Panel to show a view.
(WebInspector.ProfilesPanel.prototype.profileViewForProfile): Create the ProfileView if needed.
(WebInspector.ProfilesPanel.prototype.closeVisibleView): Renamed visibleProfileView to visibleView.
(WebInspector.ProfilesPanel.prototype.get searchableViews): Return all the views.
(WebInspector.ProfilesPanel.prototype.searchMatchFound): Update the sidebar search matches.
(WebInspector.ProfilesPanel.prototype.searchCanceled): Clear all the sidebar search matches.
(WebInspector.ProfileSidebarTreeElement.prototype.set searchMatches): Set the class and bubbleText.
* page/inspector/inspector.css: New style rules for the cell highlight color.
2008-09-23 Timothy Hatcher <timothy@apple.com>
Adds search support to the Resources and Scripts panels.
https://bugs.webkit.org/show_bug.cgi?id=21005
Reviewed by Oliver Hunt.
* page/inspector/Images/searchSmallBlue.png: Added.
* page/inspector/Images/searchSmallBrightBlue.png: Added.
* page/inspector/Images/searchSmallGray.png: Added.
* page/inspector/Images/searchSmallWhite.png: Added.
* page/inspector/ResourceView.js:
(WebInspector.ResourceView.prototype.attach): Attempt to attach to "resource-views"
or "script-resource-views" since one might not be created yet.
* page/inspector/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.show): Hide any views that are visible that
are not this panel's current visible view. This can happen when a ResourceView is
visible in the Scripts panel then switched to the this panel.
(WebInspector.ResourcesPanel.prototype.get searchableViews): Return all views, with the
visibleView first.
(WebInspector.ResourcesPanel.prototype.searchResultsSortFunction): Return a sort function
that uses the current graph search function. So cycling through results will be in the order
things appear in the sidebar.
(WebInspector.ResourcesPanel.prototype.searchMatchFound): Update the search matches on the
resource's sidebar tree element.
(WebInspector.ResourcesPanel.prototype.searchCanceled): Restore the error and warning bubbles
in the sidebar. Calls the Panel prototype's searchCanceled.
(WebInspector.ResourcesPanel.prototype.performSearch): Hide all the error and warning bubbles
in the sidebar. Calls the Panel prototype's performSearch.
(WebInspector.ResourcesPanel.prototype.reset): Call searchCanceled and delete the currentQuery.
(WebInspector.ResourcesPanel.prototype.addMessageToResource): Don't call updateErrorsAndWarnings
if there is a current search query.
(WebInspector.ResourcesPanel.prototype.clearMessages): Ditto.
(WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded): Ditto.
(WebInspector.ResourcesPanel.prototype.showView): Call showResource. Used by Panel to show a view.
(WebInspector.ResourceSidebarTreeElement.prototype.resetBubble): Clear all the classes and content.
(WebInspector.ResourceSidebarTreeElement.prototype.set searchMatches): Set the bubbleText and class.
(WebInspector.ResourceSidebarTreeElement.prototype.updateErrorsAndWarnings): Call resetBubble.
* page/inspector/ScriptView.js:
(WebInspector.ScriptView): Set _sourceFrameSetup to flase.
(WebInspector.ScriptView.prototype.hide): Reset _currentSearchResultIndex to -1. So the next time
it will start at the first result.
(WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded): Add an event listener for "syntax
highlighting complete".
(WebInspector.ScriptView.prototype): Share many methods with SourceView.
* page/inspector/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.show): Hide any views that are visible that are not this
This can happen when a ResourceView is visible in the Resources panel then switched to the this panel.
(WebInspector.ScriptsPanel.prototype.get searchableViews): Return all views, with the visibleView first.
(WebInspector.ScriptsPanel.prototype.reset): Call searchCanceled and delete the currentQuery.
(WebInspector.ScriptsPanel.prototype.showView): Call _showScriptOrResource. Used by Panel to show a view.
(WebInspector.ScriptsPanel.prototype._sourceViewForScriptOrResource): Added helper.
* page/inspector/SourceFrame.js:
(WebInspector.SourceFrame.prototype.syntaxHighlightJavascript): Dispatch a "syntax highlighting complete" event.
* page/inspector/SourceView.js:
(WebInspector.SourceView.prototype.hide):
(WebInspector.SourceView.prototype.detach):
(WebInspector.SourceView.prototype._resourceLoadingFinished): Moved from the bottom of the file.
(WebInspector.SourceView.prototype._addBreakpoint): Ditto.
(WebInspector.SourceView.prototype.searchCanceled): Delete search properties.
(WebInspector.SourceView.prototype.performSearch): Search the frame if it is loaded, otherwise
store the worker function as _delayedFindSearchMatches and call it later in _sourceFrameSetupFinished.
(WebInspector.SourceView.prototype.jumpToFirstSearchResult):
(WebInspector.SourceView.prototype.jumpToLastSearchResult):
(WebInspector.SourceView.prototype.jumpToNextSearchResult):
(WebInspector.SourceView.prototype.jumpToPreviousSearchResult):
(WebInspector.SourceView.prototype.showingFirstSearchResult):
(WebInspector.SourceView.prototype.showingLastSearchResult):
(WebInspector.SourceView.prototype._jumpToSearchResult): Selects the found Range.
(WebInspector.SourceView.prototype._sourceFrameSetupFinished): Calls _delayedFindSearchMatches.
(WebInspector.SourceView.prototype._syntaxHighlightingComplete): Call _sourceFrameSetupFinished.
* page/inspector/inspector.css:
2008-09-23 Timothy Hatcher <timothy@apple.com>
Rename some properties of ResourcesPanel and ScriptsPanel to be the same,
so future code can be shared.
https://bugs.webkit.org/show_bug.cgi?id=21005
Reviewed by Oliver Hunt.
* page/inspector/ResourcesPanel.js: Renamed resourceViews to viewsContainerElement.
And visibleResourceView to visibleView.
* page/inspector/ScriptsPanel.js: Renamed scriptResourceViews to viewsContainerElement.
2008-09-23 Timothy Hatcher <timothy@apple.com>
Highlight all matched search results in the Elements panel DOM tree.
https://bugs.webkit.org/show_bug.cgi?id=21005
Reviewed by Oliver Hunt.
* page/inspector/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.searchCanceled): Clear the highlight
on all previous search results.
(WebInspector.ElementsPanel.prototype.performSearch): Set the hihglight
on all new search results.
* page/inspector/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement): Delay setting the title until onattach.
(WebInspector.ElementsTreeElement.prototype.get/set highlighted): Sets or removes
the highlighted class on the listItemElement.
(WebInspector.ElementsTreeElement.prototype.onattach): Set the highlighted class
if needed. Calls _updateTitle.
(WebInspector.ElementsTreeElement.prototype._updateTitle): Adds a span with the highlight
class so it can be styled when the highlighted class is present.
* page/inspector/inspector.css: New style rules for the hihglight.
2008-09-23 Timothy Hatcher <timothy@apple.com>
Add search support to the Elements panel.
https://bugs.webkit.org/show_bug.cgi?id=21005
Reviewed by Oliver Hunt.
* page/inspector/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.searchCanceled): Call updateSearchMatchesCount
with a 0 match count to rest. Reset the other search properties.
(WebInspector.ElementsPanel.prototype.performSearch): Evaluates the search as an XPath
query and a CSS selector on all the Documents in the page. Remembers the found nodes
and avoids duplicates. Focuses the first result.
(WebInspector.ElementsPanel.prototype.jumpToNextSearchResult): Focuses the next result.
(WebInspector.ElementsPanel.prototype.jumpToPreviousSearchResult): Focuses the previous result.
2008-09-23 Timothy Hatcher <timothy@apple.com>
Add support to Panel that allows easy searching of sub-views.
https://bugs.webkit.org/show_bug.cgi?id=21005
Reviewed by Oliver Hunt.
* page/inspector/Panel.js:
(WebInspector.Panel.prototype.searchCanceled): Call searchCanceled on all the
views in the search results and delete the currentQuery property. Call
WebInspector.updateSearchMatchesCount wit ha 0 match count to rest. Reset the
other search properties.
(WebInspector.Panel.prototype.performSearch): Call searchCanceled since it will
reset everything we need before doing a new search. Get an array of searchableViews
from the panel, implemented by sub-classes. Iterate over the views one-by-one
with an interval to prevent blocking the UI for large lists of searchableViews.
This keeps the interface really responsive. Pass a finishedCallback function to
the performSearch on each view so it can notify the panel of results.
(WebInspector.Panel.prototype.jumpToNextSearchResult): Finds the index in the
searchResults of the visibleView, so we know where in the results we are.
This is done every time incase the user manually navigates to a new view.
If the view is showing the last result, jump to the next view and show it's
first result. Otherwise jump to the next result in the current view.
(WebInspector.Panel.prototype.jumpToPreviousSearchResult): Ditto, but in reverse.
2008-09-23 Timothy Hatcher <timothy@apple.com>
Add support for asking the current panel to perform a search, find next/previous and clear.
A search is performed on the new new current panel when switching between panels. The search
label/placeholder in the toolbar now includes the panel name to make it clear that panel will
be searched. The search field contents are selected when Command/Control-F or Enter/Return
is pressed, so the user can easily type an entirely new query. The search match count shows
up in the toolbar next to the search field.
Also changed:
* Rename lastQuery to currentQuery since it better matches the truth.
* Set the search field "results" attribute to zero since results arn't saved for
how we use the search field.
* Make repeated presses of the Return key jump to the next search result instead
of doing nothing.
* Increased the search field width.
https://bugs.webkit.org/show_bug.cgi?id=21005
Reviewed by Oliver Hunt.
* English.lproj/localizedStrings.js: New strings.
* page/inspector/inspector.css: New styles.
* page/inspector/inspector.html: Add the search-results-matches element. Add the
incremental attribute to the search field and set the results attribute to zero.
* page/inspector/inspector.js:
(WebInspector.set currentPanel): perform the search on the new panel.
(WebInspector.loaded): Change the event listeners and remove code that changes
the search label text.
(WebInspector.documentKeyDown): Add support for Command/Control-G and
Command/Control-Shift-G. To jump to the next and previous search results.
(WebInspector.updateSearchLabel): Added. Update the search placeholder/label.
This does different things depending on the attached state.
(WebInspector.searchKeyDown): Call preventDefault since this was the Enter key.
This prevents a "search" event from firing for key down. We handle the Enter key
on key up in searchKeyUp. This stops performSearch from being called twice in a row.
(WebInspector.searchKeyUp): Calls performSearch when it is the Enter key.
(WebInspector.performSearch): Delete the currentQuery property and call searchCanceled
on all the panels. Call jumpToNextSearchResult when this is the same query or a forced search.
Call updateSearchMatchesCount to reset the matches count in the toolbar.
(WebInspector.updateSearchMatchesCount): Added. Updates the matches count in the toolbar.
2008-09-23 Timothy Hatcher <timothy@apple.com>
Remove the previous Inspector search code to make room for the new stuff.
https://bugs.webkit.org/show_bug.cgi?id=21005
Reviewed by Oliver Hunt.
* page/inspector/inspector.css:
* page/inspector/inspector.html:
* page/inspector/inspector.js:
(WebInspector.get/set showingSearchResults): Removed.
(WebInspector.searchResultsKeyDown): Removed.
(WebInspector.searchResultsResizerDragStart): Removed.
(WebInspector.searchResultsResizerDragEnd): Removed.
(WebInspector.searchResultsResizerDrag): Removed.
(WebInspector.performSearch): Removed searching parts.
2008-09-23 Timothy Hatcher <timothy@apple.com>
Use the Array.remove helper function in more places.
https://bugs.webkit.org/show_bug.cgi?id=21037
Reviewed by Kevin McCullough.
* page/inspector/ResourceCategory.js:
(WebInspector.ResourceCategory.prototype.removeResource): Use Array.remove.
* page/inspector/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.removeResource): Ditto.
* page/inspector/inspector.js:
(WebInspector.removeResource): Ditto.
2008-09-23 Timothy Hatcher <timothy@apple.com>
Fixes a bug where inspecting a node after reloading the page
would not reveal the node in the DOM tree. The TreeOutline
was not being told to forget decendants of a removed child.
So old TreeElements would be found that are not in the tree.
https://bugs.webkit.org/show_bug.cgi?id=21036
Reviewed by Kevin McCullough.
* page/inspector/treeoutline.js:
(TreeOutline._removeChildAtIndex): Call _forgetChildrenRecursive
in addition to _forgetTreeElement.
(TreeOutline._removeChildren): Call _forgetChildrenRecursive
in addition to _forgetTreeElement.
(TreeOutline._rememberTreeElement): Use Array.indexOf to quickly
search for known elements.
(TreeOutline._forgetTreeElement): Use Array.remove to remove elements.
(TreeOutline._forgetChildrenRecursive): Recursively traverse the
descendants and call _forgetTreeElement.
* page/inspector/utilities.js:
(Array.prototype.remove): Speed up this function by using Array.indexOf
when onlyFirst is true.
2008-09-23 Timothy Hatcher <timothy@apple.com>
Fixes a bug where inspecting some short text nodes does
not reveal them in the Elements panel DOM tree.
https://bugs.webkit.org/show_bug.cgi?id=21035
Reviewed by Oliver Hunt.
* page/inspector/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode):
The revealAndSelectNode() method might find a different element
if there is inlined text, and the select() call would change the
focusedDOMNode and reenter this setter. So to avoid calling
focusedNodeChanged() twice, first check if _focusedDOMNode is
the same node as the one passed in.
(WebInspector.ElementsTreeOutline.prototype.update): Remove use of
this.treeOutline, since this is the TreeOutline.
(WebInspector.ElementsTreeOutline.prototype.findTreeElement): Added.
Provides default functions for isAncestor, getParet and equal.
Calls the base protoype's findTreeElement. If that returns null
and the node is a text node, try finding it's parent.
(WebInspector.ElementsTreeOutline.prototype.revealNode): Removed.
Renamed to revealAndSelectNode.
(WebInspector.ElementsTreeOutline.prototype.revealAndSelectNode):
Selects and reveals the node passed in. Use the simple findTreeElement.
(WebInspector.ElementsTreeOutline.prototype._treeElementFromEvent):
Remove use of this.treeOutline, since this is the TreeOutline.
2008-09-23 Timothy Hatcher <timothy@apple.com>
Fixes an exception that happened when removing a Resource
from the ResourcesPanel.
https://bugs.webkit.org/show_bug.cgi?id=21034
Reviewed by Kevin McCullough.
* page/inspector/ResourcesPanel.js:
(WebInspctor.ResourcesPanel.prototype.removeResource):
Remove the graphElement.
2008-09-23 Kevin McCullough <kmccullough@apple.com>
Fixed "Time" to "Tim"
* ChangeLog:
2008-09-23 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Oliver.
Move mapInstanceToElement/removeInstanceMapping/instancesForElement
from SVGDocumentExtensions to SVGElement. It's more useful to store
the list of SVGElementInstances per SVGElement, instead of using
a document-wide hash for this purpose.
* svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::applyResultsToTarget):
* svg/SVGAnimateTransformElement.cpp:
(WebCore::SVGAnimateTransformElement::applyResultsToTarget):
* svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):
* svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::~SVGDocumentExtensions):
* svg/SVGDocumentExtensions.h:
* svg/SVGElement.cpp:
(WebCore::SVGElement::mapInstanceToElement):
(WebCore::SVGElement::removeInstanceMapping):
(WebCore::SVGElement::instancesForElement):
* svg/SVGElement.h:
* svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::SVGElementInstance):
(WebCore::SVGElementInstance::~SVGElementInstance):
(WebCore::SVGElementInstance::updateAllInstancesOfElement):
* svg/SVGElementInstance.h:
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::svgAttributeChanged):
(WebCore::SVGStyledElement::childrenChanged):
* svg/SVGStyledElement.h:
2008-09-23 Kevin Ollivier <kevino@theolliviers.com>
wx build fix.
* WebCoreSources.bkl:
2008-09-23 Nikolas Zimmermann <zimmermann@kde.org>
Rubber stamped by Sam.
Move code from EventTarget to EventTargetNode.
I refactored most parts to live in EventTarget, a year ago,
though the implementation of EventTargetSVGElementInstance is
done in another way, that obsoletes this.
* dom/Document.cpp:
(WebCore::Document::addListenerTypeIfNeeded):
* dom/Document.h:
* dom/EventTarget.cpp:
* dom/EventTarget.h:
(WebCore::allowEventDispatch):
* dom/EventTargetNode.cpp:
(WebCore::EventTargetNode::insertedIntoDocument):
(WebCore::EventTargetNode::removedFromDocument):
(WebCore::EventTargetNode::willMoveToNewOwnerDocument):
(WebCore::EventTargetNode::didMoveToNewOwnerDocument):
(WebCore::EventTargetNode::addEventListener):
(WebCore::EventTargetNode::removeEventListener):
(WebCore::EventTargetNode::removeAllEventListeners):
(WebCore::EventTargetNode::handleLocalEvents):
(WebCore::setCurrentEventTargetRespectingSVGTargetRules):
(WebCore::EventTargetNode::dispatchEvent):
(WebCore::EventTargetNode::dispatchGenericEvent):
(WebCore::EventTargetNode::dispatchWindowEvent):
(WebCore::EventTargetNode::removeEventListenerForType):
* dom/EventTargetNode.h:
* svg/EventTargetSVGElementInstance.cpp:
(WebCore::EventTargetSVGElementInstance::dispatchEvent):
* svg/SVGElement.cpp:
(WebCore::SVGElement::sendSVGLoadEventIfPossible):
* svg/SVGElement.h:
(WebCore::SVGElement::supplementalTransform):
2008-09-23 Dave Hyatt <hyatt@apple.com>
Fix for bug 21012. The Aqua scrollbar was returning the wrong track rect on Windows Aqua theme. Make
sure to not accidentally fall into the vertical scrollbar case for horizontal scrollbars. :)
Reviewed by Sam Weinig
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::trackRect):
* platform/win/ScrollbarThemeSafari.cpp:
(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::ScrollbarThemeSafari::trackRect):
2008-09-23 Beth Dakin <bdakin@apple.com>
Reviewed by Sam Weinig.
Fix for https://bugs.webkit.org/show_bug.cgi?id=21041 "Add Contact"
link at gmail does not support AXPress action
and corresponding: <rdar://problem/6216178>
I fixed this bug by making AccessibilityObject::anchorElement
support ARIA links.
* page/AccessibilityImageMapLink.cpp:
(WebCore::AccessibilityImageMapLink::anchorElement):
* page/AccessibilityImageMapLink.h:
* page/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::anchorElement):
* page/AccessibilityObject.h:
(WebCore::AccessibilityObject::isNativeAnchor):
* page/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isNativeAnchor):
(WebCore::AccessibilityRenderObject::anchorElement):
(WebCore::AccessibilityRenderObject::internalLinkElement):
(WebCore::AccessibilityRenderObject::url):
* page/AccessibilityRenderObject.h:
* page/mac/AccessibilityObjectWrapper.mm:
(AXLinkElementForNode):
2008-09-23 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim and Oliver.
Bug 20949: Catch repeated messages in Inspector Controller to limit
memory usage
- Store the repeat count in the Console Message object, in the
Inspector Controller and JS ConsoleMessage object.
* page/InspectorController.cpp:
(WebCore::ConsoleMessage::ConsoleMessage):
(WebCore::ConsoleMessage::operator==):
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::addConsoleMessage):
(WebCore::InspectorController::addScriptConsoleMessage):
* page/InspectorController.h:
* page/inspector/Console.js:
* page/inspector/Resource.js:
* page/inspector/ResourcesPanel.js:
* page/inspector/SourceFrame.js:
2008-09-23 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Eric.
Working on proper EventTarget support for SVGElementInstance.
Add new EventTargetSVGElementInstance class, and it's corresponding JS wrapper.
Finally JSEventTargetBase, is actually used for another class than JSEventTargetnode.
Remove EventTarget inheritance from SVGElementInstance, and the manual "TreeShared"
implementation. Let it use TreeShared directly.
It's not activated so far (SVGUseElement still creating SVGElementInstance objects).
The transition to EventTargetSVGElementInstance will be done in a few individual patches.
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSEventTargetBase.cpp:
(WebCore::retrieveEventTargetAndCorrespondingNode):
(WebCore::toJS):
* bindings/js/JSEventTargetBase.h:
* bindings/js/JSEventTargetSVGElementInstance.cpp: Added.
(WebCore::):
(WebCore::JSEventTargetSVGElementInstance::JSEventTargetSVGElementInstance):
(WebCore::JSEventTargetSVGElementInstance::createPrototype):
(WebCore::JSEventTargetSVGElementInstance::setListener):
(WebCore::JSEventTargetSVGElementInstance::getListener):
(WebCore::toEventTargetSVGElementInstance):
* bindings/js/JSEventTargetSVGElementInstance.h: Added.
(WebCore::JSEventTargetSVGElementInstance::prototypeClassName):
(WebCore::JSEventTargetSVGElementInstance::getOwnPropertySlot):
(WebCore::JSEventTargetSVGElementInstance::getValueProperty):
(WebCore::JSEventTargetSVGElementInstance::put):
(WebCore::JSEventTargetSVGElementInstance::putValueProperty):
* bindings/js/JSSVGElementInstanceCustom.cpp: Added.
(WebCore::toJS):
* bindings/objc/DOM.mm:
(+[DOMNode _wrapEventTarget:WebCore::]):
(-[DOMSVGElementInstance _initWithSVGElementInstance:WebCore::]):
(+[DOMSVGElementInstance _wrapSVGElementInstance:WebCore::]):
(+[DOMSVGElementInstance _wrapEventTarget:WebCore::]):
(-[DOMSVGElementInstance WebCore::]):
(-[DOMSVGElementInstance addEventListener:listener:useCapture:]):
(-[DOMSVGElementInstance addEventListener:::]):
(-[DOMSVGElementInstance removeEventListener:listener:useCapture:]):
(-[DOMSVGElementInstance removeEventListener:::]):
(-[DOMSVGElementInstance dispatchEvent:]):
* bindings/objc/DOMEvents.h:
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/CodeGeneratorObjC.pm:
* svg/EventTargetSVGElementInstance.cpp: Added.
(WebCore::EventTargetSVGElementInstance::EventTargetSVGElementInstance):
(WebCore::EventTargetSVGElementInstance::~EventTargetSVGElementInstance):
(WebCore::EventTargetSVGElementInstance::addEventListener):
(WebCore::EventTargetSVGElementInstance::removeEventListener):
(WebCore::EventTargetSVGElementInstance::dispatchEvent):
* svg/EventTargetSVGElementInstance.h: Added.
(WebCore::EventTargetSVGElementInstance::isEventTargetSVGElementInstance):
(WebCore::EventTargetSVGElementInstance::toNode):
(WebCore::EventTargetSVGElementInstance::toSVGElementInstance):
(WebCore::EventTargetSVGElementInstance::refEventTarget):
(WebCore::EventTargetSVGElementInstance::derefEventTarget):
(WebCore::EventTargetSVGElementInstanceCast):
* svg/SVGElement.cpp:
(WebCore::SVGElement::dispatchEvent):
* svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::SVGElementInstance):
(WebCore::SVGElementInstance::~SVGElementInstance):
* svg/SVGElementInstance.h:
(WebCore::SVGElementInstance::isEventTargetSVGElementInstance):
* svg/SVGElementInstance.idl:
2008-09-23 Dan Bernstein <mitz@apple.com>
Reviewed by Dave Hyatt.
- https://bugs.webkit.org/show_bug.cgi?id=21040
Pass NULL instead of the identity matrix to CTFontCreateWithGraphicsFont()
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::getCTFont):
2008-09-23 David Hyatt <hyatt@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=21039
Teach the viewless Mac scrollbar how to avoid NSWindow's resizer.
Reviewed by Sam Weinig
* platform/ScrollView.h:
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::setFrameGeometry):
* platform/Scrollbar.h:
* platform/Widget.cpp:
(WebCore::Widget::convertFromContainingWindow):
* platform/Widget.h:
* platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
(WebCore::ScrollView::ScrollView):
(WebCore::ScrollView::~ScrollView):
(WebCore::ScrollView::windowResizerRect):
(WebCore::ScrollView::resizerOverlapsContent):
(WebCore::ScrollView::adjustOverlappingScrollbarCount):
(WebCore::ScrollView::setParent):
* platform/mac/WidgetMac.mm:
(WebCore::Widget::convertFromContainingWindow):
2008-09-23 Dirk Schulze <vbs85@gmx.de>
Reviewed by Darin Adler. Landed by Jan Alonzo.
Added support for getImageData() and putImageData()
to Cairo.
[CAIRO] needs getImageData and putImageData support
https://bugs.webkit.org/show_bug.cgi?id=20838
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::getImageData):
(WebCore::ImageBuffer::putImageData):
2008-09-23 Marco Barisione <marco.barisione@collabora.co.uk>
Reviewed by Holger Freyther.
http://bugs.webkit.org/show_bug.cgi?id=18987
[GTK] Implement SharedBuffer::createWithContentsOfFile and
KURL::fileSystemPath
* GNUmakefile.am: Add KURLGtk.cpp and SharedBufferGtk.cpp.
* platform/gtk/KURLGtk.cpp: Added.
(WebCore::KURL::fileSystemPath): Implemented.
* platform/gtk/SharedBufferGtk.cpp: Added.
(WebCore::SharedBuffer::createWithContentsOfFile): Implemented.
* platform/gtk/TemporaryLinkStubs.cpp: Remove the old stubs.
2008-09-23 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Oliver Hunt, okayed by Darin Adler.
<rdar://problem/5575547> REGRESSION: ATOK has no phrase boundary on Safari/Mail.app
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintCompositionUnderline): Add 2 pixel spacing between clauses.
2008-09-23 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=21023
Don't use TEC for encodings supported by ICU
* platform/text/mac/mac-encodings.txt: Removed x-mac-centraleurroman, x-mac-cyrillic,
x-mac-greek, and x-mac-turkish.
* platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames):
Register aliases for these encodings that are not registered automatically; updated comments.
2008-09-23 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin.
- speed up instanceof some more
https://bugs.webkit.org/show_bug.cgi?id=20818
~2% speedup on EarleyBoyer
(WebCore updates.)
* bindings/js/JSQuarantinedObjectWrapper.h:
(WebCore::JSQuarantinedObjectWrapper::createStructureID):
2008-09-22 Darin Adler <darin@apple.com>
Reviewed by Oliver Hunt.
- fix https://bugs.webkit.org/show_bug.cgi?id=21008
getting pixels by index from CanvasPixelArray is unnecessarily slow
* GNUmakefile.am: Added JSCanvasPixelArrayCustom.h.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* bindings/js/JSCanvasPixelArrayCustom.cpp: Removed indexGetter and
indexSetter. These are now both inlined, so in the header.
* bindings/js/JSCanvasPixelArrayCustom.h: Added. The getByIndex
function is what's used for HasCustomIndexGetter. Also moved the
indexSetter function here.
* bindings/scripts/CodeGeneratorJS.pm: Changed HasCustomIndexGetter
to use a getByIndex member function rather than an indexGetter static
member function in a property slot. This lets us avoid the property
slot mechanism's rule where it turns numeric property names into
strings in the identifier table, which is good because that's slow.
Also added a new property CustomHeader that allows IDL files to
introduce headers to be included -- useful when we have functions
that we want to inline into the binding.
* html/CanvasPixelArray.idl: Added CustomHeader attribute.
2008-09-23 Eric Seidel <eric@webkit.org>
No review, build fix only.
Another blind stab in the dark.
* svg/graphics/cg/SVGResourceClipperCg.cpp: Add missing header.
2008-09-23 Eric Seidel <eric@webkit.org>
No review, build fix only.
Third time's the charm, eh? My local build is sadly still not done...
* platform/graphics/AffineTransform.cpp: remove extra &
* platform/graphics/AffineTransform.h: remove extra &
2008-09-22 Eric Seidel <eric@webkit.org>
No review, build fix only.
* platform/graphics/AffineTransform.cpp: remove extra ;
2008-09-22 Eric Seidel <eric@webkit.org>
No review, build fix only.
Speculative fix for the build while I wait for my compile to finish.
* platform/graphics/AffineTransform.cpp:
2008-09-22 Dirk Schulze <vbs85@gmx.de>
Reviewed by eseidel. Landed by eseidel.
Moved makeMapBetweenRects from SVG/CG to AffineTransform
Make SVGResourceClipper::applyClip more cross-platform
* platform/graphics/AffineTransform.cpp:
* platform/graphics/AffineTransform.h:
* svg/graphics/cg/CgSupport.cpp:
* svg/graphics/cg/CgSupport.h:
* svg/graphics/cg/SVGPaintServerGradientCg.cpp:
(WebCore::SVGPaintServerGradient::handleBoundingBoxModeAndGradientTransformation):
* svg/graphics/cg/SVGResourceClipperCg.cpp:
(WebCore::SVGResourceClipper::applyClip):
2008-09-22 Alp Toker <alp@nuanti.com>
Reviewed by David Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=16331
[Gtk] no focus when button/checkbox/radiobutton clicked, only when tabbed
Obey GTK+ focusing conventions for controls and anchor elements.
It could be interesting to push these decisions up to Settings or
ChromeClient some day but this gets things working.
Right and middle click events still need some work to match GTK+
conventions.
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::isMouseFocusable):
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::isMouseFocusable):
* page/EventHandler.cpp:
(WebCore::EventHandler::sendContextMenuEvent):
2008-09-22 Darin Adler <darin@apple.com>
* page/mac/FrameMac.mm:
(WebCore::Frame::baseWritingDirectionForSelectionStart): Fix indentation.
2008-09-22 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Patch for https://bugs.webkit.org/show_bug.cgi?id=21013
Match Firefox in how we hide HTMLInputElement.selectionStart, selectionEnd
and setSelectionRange. This also allows us to remove the legacy JSHTMLInputElementBase
class!
- selectionStart, selectionEnd and setSelectionRange now are visible in iteration of
non-selectable input types, but return undefined when accessed.
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* bindings/js/JSHTMLInputElementBase.cpp: Removed.
* bindings/js/JSHTMLInputElementBase.h: Removed.
* bindings/js/JSHTMLInputElementCustom.cpp: Added.
(WebCore::JSHTMLInputElement::customGetOwnPropertySlot):
(WebCore::JSHTMLInputElement::selectionStart):
(WebCore::JSHTMLInputElement::selectionEnd):
* bindings/js/JSHTMLInputElementCustom.h: Added.
* html/HTMLInputElement.idl:
2008-09-22 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig.
- fix <rdar://problem/5699571> Mail: Unable to change writing direction to LTR in an empty message
Not testable in DumpRenderTree or in Safari
* page/mac/FrameMac.mm:
(WebCore::Frame::baseWritingDirectionForSelectionStart): Account for the
case that the selection start node is a block.
2008-09-22 David Hyatt <hyatt@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=21007
Make sure that the scrollbar gets sent a release event on platforms that call handleMouseDoubleClickEvent.
Reviewed by Sam Weinig
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseDoubleClickEvent):
2008-09-22 Eric Seidel <eric@webkit.org>
No review, rollback only.
Roll out Peter's change (per his request)
http://trac.webkit.org/changeset/36069
https://bugs.webkit.org/show_bug.cgi?id=19663
This change has been the source of numerous regressions
(several of which were latent bugs revealed by this change,
others were bugs in this change)
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::startAnimation):
(WebCore::BitmapImage::advanceAnimation):
* platform/graphics/BitmapImage.h:
* platform/graphics/cairo/ImageCairo.cpp:
(WebCore::BitmapImage::draw):
* platform/graphics/cg/ImageCG.cpp:
(WebCore::BitmapImage::draw):
* platform/graphics/qt/ImageQt.cpp:
(WebCore::BitmapImage::draw):
* platform/graphics/wx/ImageWx.cpp:
(WebCore::BitmapImage::draw):
2008-09-22 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig.
- fix <rdar://problem/5158514> Switch the complex text code path to Core Text
Tests: platform/mac-snowleopard/fast/text/myanmar-shaping.html
platform/mac-snowleopard/fast/text/thai-combining-mark-positioning.html
* config.h: Use Core Text if not building for Leopard or Tiger.
2008-09-22 David Hyatt <hyatt@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=21006
Add code that paints an NSView-less scroller using HIThemeDrawTrack. This scrollbar is still not
switched on. There are still a few more refinements to make to the rendering and behavior.
Reviewed by Darin Adler
* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::paint):
* platform/ScrollbarThemeComposite.h:
(WebCore::ScrollbarThemeComposite::paintTrack):
(WebCore::ScrollbarThemeComposite::paintButton):
(WebCore::ScrollbarThemeComposite::paintThumb):
* platform/mac/ScrollbarThemeMac.h:
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::backButtonRect):
(WebCore::ScrollbarThemeMac::forwardButtonRect):
(WebCore::scrollbarPartToHIPressedState):
(WebCore::ScrollbarThemeMac::paint):
* platform/mac/WidgetMac.mm:
(WebCore::Widget::invalidateRect):
2008-09-22 Chris Marrin <cmarrin@apple.com>
Reviewed by Sam Weinig
transition end event when -webkit-transition-property: all puts wrong
propertyName in event
https://bugs.webkit.org/show_bug.cgi?id=20903
* page/animation/ImplicitAnimation.cpp:
(WebCore::ImplicitAnimation::sendTransitionEvent):
2008-09-22 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6230234> AXTable should probably not be exposed in there's only one cell
Test: accessibility/table-one-cell.html
* page/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
2008-09-22 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6167779> Setting AXSelectedTextRange for TextAreas in a WebView behaves incorrectly
Test: accessibility/textarea-selected-text-range.html
* page/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::setSelectedTextRange):
2008-09-22 David Hyatt <hyatt@apple.com>
Clean up some parent relationships in the back end stylesheet code. Make sure parentStyleSheet
properly walks up nested rule blocks to reach the parent sheet instead of giving up at the immediate
parent. Also fix the doc() method so that it is properly set when the parent of the sheet is an import
rule.
Reviewed by Sam Weinig
Added fast/css/nested-rule-parent-sheet.html
* css/CSSImportRule.cpp:
(WebCore::CSSImportRule::insertedIntoParent):
* css/CSSRule.cpp:
(WebCore::CSSRule::parentStyleSheet):
(WebCore::CSSRule::parentRule):
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::CSSStyleSheet):
* css/CSSStyleSheet.h:
2008-09-22 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig.
- fix https://bugs.webkit.org/show_bug.cgi?id=21002
Make the ATSUI code path respect spacingDisabled()
Fixes svg/text/text-spacing-01-b.svg in run-webkit-tests --complex-text
* platform/graphics/mac/FontMacATSUI.mm:
(WebCore::overrideLayoutOperation):
2008-09-22 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
- speed up instanceof operator by replacing implementsHasInstance method with a TypeInfo flag
Partial work towards <https://bugs.webkit.org/show_bug.cgi?id=20818>
2.2% speedup on EarleyBoyer benchmark.
* bindings/js/JSQuarantinedObjectWrapper.cpp:
* bindings/js/JSQuarantinedObjectWrapper.h:
(WebCore::JSQuarantinedObjectWrapper::createStructureID):
* bindings/scripts/CodeGeneratorJS.pm:
2008-09-22 Adam Roben <aroben@apple.com>
Windows build fix
* WebCore.vcproj/WebCore.vcproj: Add a missing </File> tag.
2008-09-22 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dave Hyatt.
Based on initial work by Darin Adler.
- replace masqueradesAsUndefined virtual method with a flag in TypeInfo
- use this to JIT inline code for eq_null and neq_null
https://bugs.webkit.org/show_bug.cgi?id=20823
* WebCore.xcodeproj/project.pbxproj:
* WebCore.vcproj/WebCore.vcproj:
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::nameGetter):
* bindings/js/JSHTMLAllCollection.cpp: Added.
(WebCore::):
* bindings/js/JSHTMLAllCollection.h:
(WebCore::JSHTMLAllCollection::createStructureID):
(WebCore::JSHTMLAllCollection::toBoolean):
2008-09-22 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Fix the QtWebKit build
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtRuntimeObjectImp::construct):
* bridge/qt/qt_runtime.cpp:
2008-09-22 Alp Toker <alp@nuanti.com>
Suggested by David Hyatt.
Build fix: ScrollView::update() is still used by Document.cpp on !MAC
so make it public.
* platform/ScrollView.h:
2008-09-22 David Hyatt <hyatt@apple.com>
Fix a regression in Windows scrollbar painting. (Also fix the same
bug in my new viewless Mac scrollbar painting code). The track rect
was being improperly inflated when painting resulting in the scrollbar
being too tall and painting in the border of overflow sections.
Reviewed by Oliver Hunt
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::trackRect):
* platform/win/ScrollbarThemeSafari.cpp:
(WebCore::ScrollbarThemeSafari::trackRect):
2008-09-22 David Hyatt <hyatt@apple.com>
Fix a hit testing bug where events are mistakenly passed to subframes
if the mouse is over the border or padding area of the frame. Add
a boolean flag, isOverWidget(), to hit test results so that EventHandler
can check it to tell if the mouse is really over the content box of a
RenderWidget and not just in the border/padding area.
This is not testable, since the old code properly recovered when it detected
that the mouse was outside the bounds of the view, but this prevents
the extra passdown from even occurring (and is basically a nice cleanup).
Reviewed by Oliver Hunt
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::hitTestResultAtPoint):
(WebCore::subframeForHitTestResult):
(WebCore::EventHandler::handleMouseDoubleClickEvent):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::EventHandler::handleWheelEvent):
* page/MouseEventWithHitTestResults.h:
(WebCore::MouseEventWithHitTestResults::isOverWidget):
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::HitTestResult):
(WebCore::HitTestResult::operator=):
* rendering/HitTestResult.h:
(WebCore::HitTestResult::isOverWidget):
(WebCore::HitTestResult::setIsOverWidget):
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::nodeAtPoint):
* rendering/RenderWidget.h:
2008-09-21 David Hyatt <hyatt@apple.com>
Rename FrameView's repaintRectangle method to repaintContentRectangle. Make
both it and ScrollView's updateContents method be off-limits to everyone in
WebCore except for RenderView.
Make repaintViewRectangle the only possible method for WebCore code to do
an invalidation. This ensures that all invalidates triggered by WebCore
cross-platform code that cross ownerElement() boundaries are transform-aware.
Make sure that iframes/frames contained inside objects that have transforms
or reflections are not allowed to blit (this was already true for transparency).
It is not possible to make a test for any of this, since iframe scrolling
still doesn't work on Mac (since the invalidates are not being done
through WebCore's cross-platform invalidation code but are instead going
through NSScrollView's setNeedsDisplay still).
Reviewed by Oliver Hunt
* editing/SelectionController.cpp:
(WebCore::SelectionController::recomputeCaretRect):
(WebCore::SelectionController::invalidateCaretRect):
(WebCore::SelectionController::focusedOrActiveStateChanged):
* page/FrameView.cpp:
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::endDeferredRepaints):
* page/FrameView.h:
* platform/ScrollView.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintFillLayerExtended):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::enclosingPositionedAncestor):
(WebCore::RenderLayer::requiresSlowRepaints):
* rendering/RenderLayer.h:
(WebCore::RenderLayer::hasTransform):
* rendering/RenderView.cpp:
(WebCore::RenderView::paintBoxDecorations):
(WebCore::RenderView::repaintViewRectangle):
(WebCore::RenderView::setSelection):
2008-09-21 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin.
- introduce a TypeInfo class, for holding per-type (in the C++ class sense) date in StructureID
https://bugs.webkit.org/show_bug.cgi?id=20981
* bindings/js/JSAudioConstructor.cpp:
(WebCore::JSAudioConstructor::JSAudioConstructor):
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::nameGetter):
* bindings/js/JSDOMBinding.cpp:
(WebCore::createDOMStructure):
* bindings/js/JSDOMBinding.h:
(WebCore::getDOMStructure):
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::JSDOMWindowShell):
(WebCore::JSDOMWindowShell::setWindow):
* bindings/js/JSEventTargetNode.cpp:
(WebCore::JSEventTargetNode::createPrototype):
* bindings/js/JSHTMLOptionElementConstructor.cpp:
(WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor):
* bindings/js/JSImageConstructor.cpp:
(WebCore::JSImageConstructor::JSImageConstructor):
* bindings/js/JSXMLHttpRequestConstructor.cpp:
(WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
* bindings/js/JSXSLTProcessorConstructor.cpp:
(WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
* bindings/scripts/CodeGeneratorJS.pm:
2008-09-21 Darin Adler <darin@apple.com>
Reviewed by Maciej Stachowiak.
- fix problem Maciej noticed where every JSNamedNodesCollection
gets its own StructureID
* bindings/js/JSNamedNodesCollection.cpp:
(WebCore::JSNamedNodesCollection::JSNamedNodesCollection): Use
getDOMStructure to get the structure.
* bindings/js/JSNamedNodesCollection.h:
(WebCore::JSNamedNodesCollection::createPrototype): Return the
object prototype.
2008-09-20 David Hyatt <hyatt@apple.com>
Make sure transformed scrollbars in overflow sections position
properly. This patch mimics the same behavior that works for
iframes, namely making sure that the same code that dynamically
adjusts iframe widget positions at paint time for fixed positioning
and transforms also applies to scrollbars. (This is as simple as passing
in the current translation factor at paint time rather than crawling
up the layer tree to compute a "false" absolute position.)
An existing transform test covers this (although only a pixel result
reveals the correct rendering).
Reviewed by Darin Adler
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::positionOverflowControls):
(WebCore::RenderLayer::paintOverflowControls):
(WebCore::RenderLayer::paintLayer):
* rendering/RenderLayer.h:
2008-09-21 Steve Falkenburg <sfalken@apple.com>
Removed unnecessary nested timer check.
Rubber-stamped by Dan Bernstein.
* platform/win/SharedTimerWin.cpp:
(WebCore::TimerWindowWndProc):
2008-09-21 Steve Falkenburg <sfalken@apple.com>
Improve timer resolution on WinXP.
https://bugs.webkit.org/show_bug.cgi?id=20979
Removed last-chance timer. It should not be necessary.
Change timeEndPeriod timer to fire in 300ms instead of 20ms. Calling timeBeginPeriod/timeEndPeriod too often throws off accuracy.
Remove Vista checks. We now run the same code on both XP and Vista.
Call through to JSC::getCurrentUTCTimeWithMicroseconds from WebCore::currentTime.
The code previously called GetSystemTimeAsFileTime, which is always low-resolution on XP, even within timeBeginPeriod(1).
Reviewed by Maciej Stachowiak.
* platform/win/SharedTimerWin.cpp:
(WebCore::):
(WebCore::TimerWindowWndProc):
(WebCore::setSharedTimerFireTime):
* platform/win/SystemTimeWin.cpp:
(WebCore::currentTime):
2008-09-21 Dirk Schulze <vbs85@gmx.de>
Reviewed by eseidel. Landed by eseidel.
All platforms use the DashArray in the GraphicsContext.
* svg/graphics/SVGPaintServer.h:
* svg/graphics/cairo/SVGPaintServerGradientCairo.cpp:
(WebCore::SVGPaintServerGradient::setup):
* svg/graphics/cairo/SVGPaintServerPatternCairo.cpp:
(WebCore::SVGPaintServerPattern::setup):
* svg/graphics/cairo/SVGPaintServerSolidCairo.cpp:
(WebCore::SVGPaintServerSolid::setup):
* svg/graphics/qt/SVGPaintServerGradientQt.cpp:
(WebCore::SVGPaintServerGradient::setup):
* svg/graphics/qt/SVGPaintServerQt.cpp:
* svg/graphics/qt/SVGPaintServerSolidQt.cpp:
(WebCore::SVGPaintServerSolid::setup):
2008-09-21 Dirk Schulze <vbs85@gmx.de>
Reviewed by eseidel. Landed by eseidel.
Moved DashArray to GraphicsContext.
* GNUmakefile.am:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/DashArray.h: Added.
* platform/graphics/GraphicsContext.h:
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::setLineDash):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::setLineDash):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::setLineDash):
* svg/graphics/SVGPaintServer.cpp:
(WebCore::applyStrokeStyleToContext):
* svg/graphics/SVGPaintServer.h:
* svg/graphics/cg/CgSupport.cpp:
* svg/graphics/cg/CgSupport.h:
2008-09-21 Dan Bernstein <mitz@apple.com>
Reviewed by Mark Rowe.
- fix linker warnings
* WebCore.base.exp:
2008-09-20 Darin Adler <darin@apple.com>
- another try at fixing Qt
* bridge/qt/qt_runtime.cpp: "using namespce WebCore"
2008-09-20 Darin Adler <darin@apple.com>
- blind attempt to fix Qt build
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertQVariantToValue): Use regExpStructure instead
of regExpPrototype to make a RegExpObject. There should really be
some sort of public helper function for this. Same thing for
DateInstance and dateStructure. For JSObject, use constructEmptyObject.
(JSC::Bindings::):
(JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod): Use getDOMStructure.
It is not correct to do this inside the constructor because it could
cause a garbage collect while the QtRuntimeMethod object is half-
allocated, which could lead to a crash; note that RuntimeMethod,
QtRuntimeObjectImp, and RuntimeObjectImp have the same bug.
* bridge/qt/qt_runtime.h: Add s_info and createPrototype.
2008-09-20 Collin Jackson <collinj@webkit.org>
Prefetch DNS for hyperlinks that the user mouses over.
https://bugs.webkit.org/show_bug.cgi?id=20931
Reviewed by Sam Weinig.
* page/Chrome.cpp:
(WebCore::Chrome::mouseDidMoveOverElement):
2008-09-20 Darin Adler <darin@apple.com>
Reviewed by Maciej Stachowiak.
- finish https://bugs.webkit.org/show_bug.cgi?id=20858
make each distinct C++ class get a distinct JSC::Structure
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::nameGetter): Pass in a structure
ID. Note that this makes a new structure every time -- we could
optimize this slightly be caching and reusing a single one.
* bridge/runtime_method.cpp:
(JSC::RuntimeMethod::RuntimeMethod): Create a unique structure using
getDOMStructure.
* bridge/runtime_method.h:
(JSC::RuntimeMethod::createPrototype): Added createPrototype so
getDOMStructure will work.
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::JSDOMWindowShell): Initialize m_window to
0; needed in case garbage collection happens while creating the
JSDOMWindow.
2008-09-20 Dan Bernstein <mitz@apple.com>
Reviewed by Eric Seidel.
- fix https://bugs.webkit.org/show_bug.cgi?id=20950
<rdar://problem/6234059> Reproducible assertion failure running svg/custom/acid3-test-77.html multiple times under guard malloc
* svg/SVGTextContentElement.cpp:
(WebCore::SVGInlineTextBoxQueryWalker::chunkPortionCallback): Changed to
not include the first character in the extraCharsAvailable count.
2008-09-20 Kevin Ollivier <kevino@theolliviers.com>
Reviewed by Dan Bernstein.
Fix memory leak.
https://bugs.webkit.org/show_bug.cgi?id=20505
* platform/wx/wxcode/mac/carbon/fontprops.cpp:
(GetTextExtent):
2008-09-20 Kevin Ollivier <kevino@theolliviers.com>
wx build fixes. Added/removed build sources, and nativeWindow->platformWidget updates.
* WebCoreSources.bkl:
* platform/ScrollView.h:
* platform/wx/PopupMenuWx.cpp:
(WebCore::PopupMenu::show):
* platform/wx/RenderThemeWx.cpp:
(WebCore::RenderThemeWx::paintButton):
(WebCore::RenderThemeWx::paintTextField):
(WebCore::RenderThemeWx::paintMenuList):
(WebCore::RenderThemeWx::paintMenuListButton):
* platform/wx/ScrollViewWx.cpp:
(WebCore::ScrollView::setPlatformWidget):
(WebCore::ScrollView::updateContents):
(WebCore::ScrollView::update):
(WebCore::ScrollView::visibleWidth):
(WebCore::ScrollView::visibleHeight):
(WebCore::ScrollView::scrollBy):
(WebCore::ScrollView::resizeContents):
(WebCore::ScrollView::contentsWidth):
(WebCore::ScrollView::contentsHeight):
(WebCore::ScrollView::isScrollViewScrollbar):
(WebCore::ScrollView::adjustScrollbars):
(WebCore::ScrollView::inWindow):
(WebCore::ScrollView::removeChild):
* platform/wx/WidgetWx.cpp:
* plugins/wx/PluginViewWx.cpp:
(WebCore::PluginView::setParentVisible):
(WebCore::PluginView::updatePluginWidget):
2008-09-20 Timothy Hatcher <timothy@apple.com>
Fix the new Node Search button image to not be blurry.
* page/inspector/Images/nodeSearchButtons.png:
2008-09-20 Matt Lilek <webkit@mattlilek.com>
Reviewed by Tim Hatcher.
Cut down some of the inspector javascript -> InspectorController glue code
with two new macros. Also rearrange the exposed function list to be grouped
by implementation and to all explicitly use the WebCore namespace.
* page/InspectorController.cpp:
(WebCore::InspectorController::windowScriptObjectAvailable):
2008-09-20 Matt Lilek <webkit@mattlilek.com>
Reviewed by Tim Hatcher.
Fix regression from my previous patch where the breadcrumbs bar was not displayed.
* page/inspector/inspector.css:
2008-09-20 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Eric.
Refactor HTMLImageLoader/SVGImageLoader code.
Move html/HTMLImageLoader.* to loader/ImageLoader.*
Let HTMLImageLoader & SVGImageLoader inherit from the new base class.
SVGImageLoader used to inherit from HTMLImageLoader which is awkward.
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* dom/Document.cpp:
(WebCore::Document::dispatchImageLoadEventSoon):
(WebCore::Document::removeImage):
(WebCore::Document::dispatchImageLoadEventsNow):
* dom/Document.h:
* html/HTMLImageLoader.cpp:
(WebCore::HTMLImageLoader::HTMLImageLoader):
(WebCore::HTMLImageLoader::~HTMLImageLoader):
(WebCore::HTMLImageLoader::sourceURI):
(WebCore::HTMLImageLoader::notifyFinished):
* html/HTMLImageLoader.h:
* loader/DocLoader.h:
* loader/ImageLoader.cpp: Copied from html/HTMLImageLoader.cpp.
(WebCore::ImageLoader::ImageLoader):
(WebCore::ImageLoader::~ImageLoader):
(WebCore::ImageLoader::setImage):
(WebCore::ImageLoader::setLoadingImage):
(WebCore::ImageLoader::updateFromElement):
(WebCore::ImageLoader::notifyFinished):
* loader/ImageLoader.h: Copied from html/HTMLImageLoader.h.
* svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::attach):
(WebCore::SVGImageElement::insertedIntoDocument):
(WebCore::SVGImageElement::imageSourceAttributeName):
* svg/SVGImageElement.h:
* svg/SVGImageLoader.cpp:
(WebCore::SVGImageLoader::SVGImageLoader):
(WebCore::SVGImageLoader::dispatchLoadEvent):
(WebCore::SVGImageLoader::sourceURI):
* svg/SVGImageLoader.h:
2008-09-20 Holger Hans Peter Freyther <zecke@selfish.org>
Build fix.
[qtwebkit] ScrollBar build fix after r36684.
BackButtonPart was split into Start and End Part
ForwardButtonPart was split into Start and End Part
* platform/qt/ScrollbarThemeQt.cpp:
(WebCore::scPart):
(WebCore::scrollbarPart):
(WebCore::styleOptionSlider):
2008-09-20 Holger Hans Peter Freyther <zecke@selfish.org>
Build fix.
[qtwebkit] Make qt_instance.cpp compile.
Revision of 36675 introduced getDOMStructure to give unique
structure id's to C++ classes. Catch up. RuntimeObjectImp assigns
the the StructureID inside the c'tor, do the same in QtRuntimeObjectImp
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtInstance::getRuntimeObject):
2008-09-20 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Nikolas Zimmermann.
[svg] Change SVGLocatable to deal with a plain SVGElement
There is no requirement in the code that we have to have a
SVGStyledElement. Remove that artificial limitation and compile
with SVGElement.
* svg/SVGLocatable.cpp:
* svg/SVGLocatable.h:
2008-09-20 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Nikolas Zimmermann.
[svg] Use OwnPtr for the SVGExtensions to avoid custom lifetime
management.
* dom/Document.cpp:
(WebCore::Document::~Document):
(WebCore::Document::svgExtensions):
(WebCore::Document::accessSVGExtensions):
* dom/Document.h:
2008-09-19 David Hyatt <hyatt@apple.com>
Fix for crash in updateTransitions. Make sure to test for a style
being null when comparing two RenderStyles.
Reviewed by Oliver Hunt
* page/animation/AnimationBase.cpp:
(WebCore::PropertyWrapperGetter::equals):
2008-09-19 David Hyatt <hyatt@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=20954
Roll out r36628 since it has caused horrible regressions with
animated GIF CPU usage.
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::cacheFrame):
(WebCore::BitmapImage::startAnimation):
* platform/graphics/BitmapImage.h:
(WebCore::FrameData::FrameData):
* platform/graphics/cairo/ImageCairo.cpp:
(WebCore::FrameData::clear):
* platform/graphics/cg/ImageCG.cpp:
(WebCore::FrameData::clear):
* platform/graphics/qt/ImageQt.cpp:
(WebCore::FrameData::clear):
* platform/graphics/wx/ImageWx.cpp:
(WebCore::FrameData::clear):
2008-09-20 Alp Toker <alp@nuanti.com>
Reviewed by Timothy Hatcher.
https://bugs.webkit.org/show_bug.cgi?id=20913
Avoid redudant includes
Document.h is included excessively such that a modification to Document.h (or
any of the header it includes itself) triggers a rebuild of many files
including the whole of SVG and a lot of the JS bindings.
Some of these includes can be avoided by only including Document.h where
necessary.
* bindings/js/JSAttrCustom.cpp:
* bindings/js/JSElementCustom.cpp:
* bindings/js/JSEventTargetBase.cpp:
* bindings/js/JSEventTargetBase.h:
* bindings/js/JSEventTargetNode.cpp:
* bindings/js/JSHTMLFrameElementCustom.cpp:
* bindings/js/JSHTMLIFrameElementCustom.cpp:
* bindings/scripts/CodeGeneratorJS.pm:
* css/CSSCursorImageValue.cpp:
* css/SVGCSSStyleSelector.cpp:
* dom/make_names.pl:
* svg/SVGAnimateElement.h:
* svg/SVGAnimatedProperty.h:
(WebCore::::baseValue):
(WebCore::::setBaseValue):
(WebCore::::startAnimation):
(WebCore::::stopAnimation):
* svg/SVGElement.cpp:
(WebCore::SVGElement::accessDocumentSVGExtensions):
* svg/SVGElement.h:
* svg/SVGElementInstance.cpp:
* svg/SVGFitToViewBox.cpp:
* svg/SVGFontElement.cpp:
* svg/SVGFontFaceElement.cpp:
* svg/SVGLinearGradientElement.cpp:
* svg/SVGMPathElement.cpp:
* svg/SVGViewSpec.cpp:
2008-09-19 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Antti & Eric.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=20372
Finish HTMLScriptElement / SVGScriptElement unification.
SVG <script> support is complete now, full SVGLoad event
respecting the influence of the externalResourcesRequired attribute
as well as SVGError event support. All other features shared with HTML.
Tests: fast/dom/HTMLScriptElement/script-reexecution.html
svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading.svg
svg/dom/SVGScriptElement/script-load-and-error-events.svg
svg/dom/SVGScriptElement/script-reexecution.svg
svg/dom/SVGScriptElement/script-set-href.svg
* dom/ScriptElement.cpp:
(WebCore::ScriptElementData::ScriptElementData):
(WebCore::ScriptElementData::requestScript):
* dom/ScriptElement.h:
(WebCore::ScriptElementData::haveFiredLoadEvent):
(WebCore::ScriptElementData::setHaveFiredLoadEvent):
* dom/XMLTokenizer.cpp:
(WebCore::XMLTokenizer::notifyFinished):
* html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::dispatchLoadEvent):
* svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::setCreatedByParser):
(WebCore::SVGScriptElement::parseMappedAttribute):
(WebCore::SVGScriptElement::svgAttributeChanged):
(WebCore::SVGScriptElement::insertedIntoDocument):
(WebCore::SVGScriptElement::removedFromDocument):
(WebCore::SVGScriptElement::childrenChanged):
(WebCore::SVGScriptElement::isURLAttribute):
(WebCore::SVGScriptElement::finishParsingChildren):
(WebCore::SVGScriptElement::type):
(WebCore::SVGScriptElement::setType):
(WebCore::SVGScriptElement::haveLoadedRequiredResources):
(WebCore::SVGScriptElement::dispatchLoadEvent):
(WebCore::SVGScriptElement::dispatchErrorEvent):
* svg/SVGScriptElement.h:
2008-09-19 Dan Bernstein <mitz@apple.com>
Reviewed by John Sullivan.
- fix https://bugs.webkit.org/show_bug.cgi?id=20951
Typo in Position::getInlineBoxAndOffset()
and add an assertion
Without the fix, the newly-added assertion fails in platform/mac/editing/input/caret-primary-bidi.html
* dom/Position.cpp:
(WebCore::Position::getInlineBoxAndOffset):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::positionForOffset):
2008-09-19 David Hyatt <hyatt@apple.com>
Add support for hit testing of all five possible scrollbar button placements.
Reviewed by Sam Weinig
* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::paint):
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::):
(WebCore::ScrollbarThemeMac::backButtonRect):
(WebCore::ScrollbarThemeMac::forwardButtonRect):
(WebCore::ScrollbarThemeMac::trackRect):
(WebCore::ScrollbarThemeMac::paintButton):
2008-09-19 Darin Adler <darin@apple.com>
- try to fix Qt build
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtRuntimeObjectImp::QtRuntimeObjectImp): Add structure argument.
(JSC::Bindings::QtInstance::getRuntimeObject): Ditto.
* bridge/runtime_object.cpp:
(JSC::RuntimeObjectImp::RuntimeObjectImp): Add an overload just for Qt.
* bridge/runtime_object.h: Ditto.
2008-09-19 Chris Marrin <cmarrin@apple.com>
Reviewed by Dave Hyatt.
Transition starts running when it shouldn't
https://bugs.webkit.org/show_bug.cgi?id=20892
When there is a transition and an animation on the
same element, make sure the animation wins.
The fix is to save the unanimated style when an animation is started.
Then, when starting a transition, check to see if there is a current
animation on the same prop. If so, use the unanimated style as the
fromStyle rather than the current style.
Test: animations/transition-and-animation-1.html
* page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::updateTransitions):
(WebCore::CompositeAnimation::updateKeyframeAnimations):
(WebCore::CompositeAnimation::animate):
(WebCore::CompositeAnimation::getAnimationForProperty):
* page/animation/CompositeAnimation.h:
* page/animation/ImplicitAnimation.cpp:
(WebCore::ImplicitAnimation::reset):
* page/animation/ImplicitAnimation.h:
* page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::hasAnimationForProperty):
* page/animation/KeyframeAnimation.h:
(WebCore::KeyframeAnimation::KeyframeAnimation):
(WebCore::KeyframeAnimation::unanimatedStyle):
2008-09-19 David Hyatt <hyatt@apple.com>
Add support for painting/hit testing of four possible scrollbar buttons.
The Windows themes simply ignore the two parts that they will never
show. The Mac theme also ignores the other two buttons for now.
The cross-platform base for all three themes, ScrollbarThemeComposite,
has all the proper support though.
Reviewed by Sam Weinig
* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::hitTest):
(WebCore::ScrollbarThemeComposite::invalidatePart):
* platform/ScrollbarThemeComposite.h:
* platform/mac/ScrollbarThemeMac.h:
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::backButtonRect):
(WebCore::ScrollbarThemeMac::forwardButtonRect):
(WebCore::ScrollbarThemeMac::paintButton):
* platform/win/ScrollbarThemeSafari.cpp:
(WebCore::ScrollbarThemeSafari::backButtonRect):
(WebCore::ScrollbarThemeSafari::forwardButtonRect):
(WebCore::ScrollbarThemeSafari::paintButton):
* platform/win/ScrollbarThemeSafari.h:
* platform/win/ScrollbarThemeWin.cpp:
(WebCore::ScrollbarThemeWin::backButtonRect):
(WebCore::ScrollbarThemeWin::forwardButtonRect):
(WebCore::ScrollbarThemeWin::paintButton):
* platform/win/ScrollbarThemeWin.h:
2008-09-19 Matt Lilek <webkit@mattlilek.com>
Reviewed by Tim Hatcher.
Bug 17772: Inspector should support point-and-click to select a node to inspect
https://bugs.webkit.org/show_bug.cgi?id=17772
<rdar://problem/5792395>
* English.lproj/localizedStrings.js:
* page/Chrome.cpp:
(WebCore::Chrome::mouseDidMoveOverElement):
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEvent):
* page/InspectorController.cpp:
(WebCore::toggleNodeSearch):
(WebCore::searchingForNode):
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::toggleSearchForNodeInPage):
(WebCore::InspectorController::mouseDidMoveOverElement):
(WebCore::InspectorController::handleMousePressOnNode):
(WebCore::InspectorController::windowScriptObjectAvailable):
* page/InspectorController.h:
(WebCore::InspectorController::searchingForNodeInPage):
* page/inspector/ElementsPanel.js:
* page/inspector/Images/nodeSearchButtons.png: Added.
* page/inspector/inspector.css:
2008-09-19 David Hyatt <hyatt@apple.com>
Add new scrollbar parts to be able to represent back and forward buttons
at either end of the scrollbar. The current scrollbar still just draws
a single button at either end, but the parts now exist.
Reviewed by Sam Weinig
* platform/ScrollTypes.h:
(WebCore::):
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::autoscrollTimerFired):
(WebCore::Scrollbar::pressedPartScrollDirection):
(WebCore::Scrollbar::pressedPartScrollGranularity):
(WebCore::Scrollbar::handleMouseMoveEvent):
* platform/ScrollbarTheme.h:
(WebCore::ScrollbarTheme::buttonsPlacement):
(WebCore::ScrollbarTheme::invalidateParts):
* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::paint):
(WebCore::ScrollbarThemeComposite::hitTest):
(WebCore::ScrollbarThemeComposite::invalidatePart):
* platform/ScrollbarThemeComposite.h:
2008-09-19 Beth Dakin <bdakin@apple.com>
Reviewed by Dave Hyatt.
Fix for <rdar://problem/6231308> crash in AutoTableLayout
The code assumes later on that a TableSection's grid's row vector
will never be empty. So make 1 the minimum number of columns.
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::ensureRows):
2008-09-19 David Hyatt <hyatt@apple.com>
Add a new ScrollbarButtonsPlacement type for specifying where
the button arrows are in a scrollbar.
Read in the placement settings for Mac. Nothing is done with the
setting yet.
Add a new buttonsPlacement() method to ScrollbarTheme composite
so that the arrow settings can be obtained.
Reviewed by Sam Weinig
* platform/ScrollTypes.h:
(WebCore::):
* platform/ScrollbarThemeComposite.h:
(WebCore::ScrollbarThemeComposite::buttonsPlacement):
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::updateArrowPlacement):
(WebCore::ScrollbarThemeMac::ScrollbarThemeMac):
2008-09-19 Steve Falkenburg <sfalken@apple.com>
Roll out r36626. It is causing variance in SunSpider numbers on XP.
Rubber stamped by Mark Rowe.
* platform/win/SharedTimerWin.cpp:
(WebCore::isRunningOnVistaOrLater):
(WebCore::setSharedTimerFireTime):
2008-09-19 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim.
https://bugs.webkit.org/show_bug.cgi?id=20942
Bug 20942: Repeated messages in resources don't collapse
- Now repeated messages in a resource's view are collapsed and a message
says how many were repeated.
* English.lproj/localizedStrings.js:
* manual-tests/inspector/multiple-console-messages.html:
* page/inspector/Console.js: Send all the messages to the resource's
view before possibly returning early if the message is a repeat.
* page/inspector/SourceFrame.js: Add the text about the message being
repeated, if it is, and increment it when necessary.
2008-09-19 Chris Fleizach <cfleizach@apple.com>
Removed unnecessary #if
* page/mac/AccessibilityObjectWrapper.mm:
2008-09-19 David Hyatt <hyatt@apple.com>
Read in prefs for the scroll delay repeat values for buttons. Also
honor the option-click pref for jumping to the thumb when clicking in
the track.
Reviewed by Sam Weinig
* platform/mac/ScrollbarThemeMac.h:
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::ScrollbarThemeMac):
(WebCore::ScrollbarThemeMac::initialAutoscrollTimerDelay):
(WebCore::ScrollbarThemeMac::autoscrollTimerDelay):
(WebCore::ScrollbarThemeMac::shouldCenterOnThumb):
2008-09-19 David Hyatt <hyatt@apple.com>
Move ScrollbarThemeMac.cpp to ScrollbarThemeMac.mm so it can use Obj-C.
Set the initial button repeat delay to 0.5 for Mac.
Reviewed by Sam Weinig
* WebCore.xcodeproj/project.pbxproj:
* platform/mac/ScrollbarThemeMac.cpp: Removed.
* platform/mac/ScrollbarThemeMac.h:
(WebCore::ScrollbarThemeMac::initialAutoscrollTimerDelay):
* platform/mac/ScrollbarThemeMac.mm: Copied from platform/mac/ScrollbarThemeMac.cpp.
2008-09-19 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
- part 2 of https://bugs.webkit.org/show_bug.cgi?id=20858
make each distinct C++ class get a distinct JSC::Structure
+ Fixed all cases where we were using a shared structure for multiple
C++ classes in WebCore. This still has to be done in JavaScriptCore.
+ Got rid of cacheGlobalObject.
+ Improved use of PassRefPtr in bindings code.
+ Removed a couple cases where we were potentially allocating prototypes
inside a JSObject's construction process -- this can lead to trouble if
we do a garbage collection while an object is only partly constructed.
* bindings/js/JSAudioConstructor.cpp:
(WebCore::JSAudioConstructor::JSAudioConstructor): Create a structure explicitly
so we don't implicitly share the structure with other objects that use the object
prototype.
* bindings/js/JSDOMBinding.cpp:
(WebCore::getCachedDOMConstructor): Added. To be used for constructors so we
don't need cacheGlobalObject any more.
(WebCore::cacheDOMConstructor): Ditto.
* bindings/js/JSDOMBinding.h: Removed DOMObject constructor that takes a prototype.
Added functions and a function template for getting cached DOM constructors.
Removed cacheGlobalObject function template.
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBase): Take a PassRefPtr<DOMWindow> since
we're taking ownership.
* bindings/js/JSDOMWindowBase.h: Changed constructor to take PassRefPtr, since
we're taking ownership. Added constructor map.
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::mark): Mark the constructors in the map.
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::JSDOMWindowShell): Take a PassRefPtr<DOMWindow> since
we're taking ownership. Use the new setWindow function to create the JSDOMWindow;
this is now done in only that one place.
(WebCore::JSDOMWindowShell::setWindow): Added. Creates the JSDOMWindow based on
the passed-in DOMWindow. Code was moved here and changed to allocate unique
structures for both the window prototype and the window.
* bindings/js/JSDOMWindowShell.h: Ditto.
* bindings/js/JSEventTargetBase.h: Changed class template argument so it doesn't
have the same name (JSEventTarget) as an actual class. Removed unhelpful use of
private/friend in JSEventTargetBase. Removed comments referring to defunct
macros. Changed JSEventTargetBasePrototype to get the prototype with the new
rather than its own copy of cacheGlobalObject (I missed this during pass 1).
Changed JSEventTargetBasePrototype so it doesn't have so many template arguments.
* bindings/js/JSEventTargetNode.cpp: Added s_info; needed for the new scheme
for caching structures and prototypes.
(WebCore::JSEventTargetNode::JSEventTargetNode): Use PassRefPtr.
(WebCore::JSEventTargetNode::createPrototype): Added.
* bindings/js/JSEventTargetNode.h: Updated for above changes.
* bindings/js/JSHTMLAllCollection.h:
(WebCore::JSHTMLAllCollection::JSHTMLAllCollection): Use PassRefPtr.
* bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::getNamedItems): Pass ExecState instead of prototype.
* bindings/js/JSHTMLFormElementCustom.cpp:
(WebCore::JSHTMLFormElement::nameGetter): Ditto.
* bindings/js/JSHTMLInputElementBase.cpp:
(WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase): Use PassRefPtr.
* bindings/js/JSHTMLInputElementBase.h: Ditto.
* bindings/js/JSHTMLOptionElementConstructor.cpp:
(WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor):
Create a unique structure instead of sharing.
* bindings/js/JSImageConstructor.cpp:
(WebCore::JSImageConstructor::JSImageConstructor): Ditto.
* bindings/js/JSInspectedObjectWrapper.cpp:
(WebCore::JSInspectedObjectWrapper::wrap): Removed overload that takes
a prototype rather than a structure. Made the use of inheritorID() here
explicit.
* bindings/js/JSInspectedObjectWrapper.h: Ditto.
* bindings/js/JSInspectorCallbackWrapper.cpp:
(WebCore::JSInspectorCallbackWrapper::wrap): Ditto.
* bindings/js/JSInspectorCallbackWrapper.h: Ditto.
* bindings/js/JSNamedNodesCollection.cpp:
(WebCore::JSNamedNodesCollection::JSNamedNodesCollection): Changed to
take an ExecState argument instead of a prototype. Create a unique
StructureID instead of sharing.
* bindings/js/JSNamedNodesCollection.h: Ditto.
* bindings/js/JSQuarantinedObjectWrapper.cpp: Removed overloaded
constructor that takes a prototype instead of a structure.
* bindings/js/JSQuarantinedObjectWrapper.h: Ditto.
* bindings/js/JSRGBColor.cpp:
(WebCore::JSRGBColor::JSRGBColor): Take ExecState instead of a
prototype; create a unique structure.
(WebCore::getJSRGBColor): Ditto.
* bindings/js/JSRGBColor.h: Ditto.
* bindings/js/JSSQLResultSetRowListCustom.cpp:
(WebCore::JSSQLResultSetRowList::item): Use constructEmptyObject instead
of explicit coding the idiom for making a new object.
* bindings/js/JSXMLHttpRequestConstructor.cpp:
(WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
Create a unique structure instead of the shared one.
* bindings/js/JSXSLTProcessorConstructor.cpp:
(WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
Ditto.
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::clearWindowShell): Let the window shell's
setWindow function create the JSDOMWindow instead of doing it here.
* bindings/scripts/CodeGeneratorJS.pm: Changed to use PassRefPtr for
the structure and the wrapped object when creating wrappers.
Simplified some of the special cases for DOMWindow so they are
different only in ways the need to be. Eliminated the
JSDOMWindow::createPrototype and JSDOMWindowPrototype::self
functions. Moved responsibility for creating the structure and
parent prototype out of the prototype constructor into the
createPrototype function. Removed the unused "DoNotCache" flag for
objects other than DOMWindow. Use getDOMConstructor instead of
cacheGlobalObject for constructors. Make each constructor have
a unique structure ID.
* bridge/objc/objc_runtime.h: Added createPrototype and changed the
name of the info member to s_info so we can use the standard DOM
binding macros to handl the prototype.
* bridge/objc/objc_runtime.mm: Fixed namespacing a bit.
(JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):
Create a unique structure using getDOMStructure.
* bridge/runtime_array.cpp: Fixed namespacing a bit.
(JSC::RuntimeArray::RuntimeArray): Create a unique structure using
getDOMStructure.
* bridge/runtime_array.h: Added createPrototype so getDOMStructure
will work.
* bridge/runtime_object.cpp:
(JSC::RuntimeObjectImp::RuntimeObjectImp): Create a unique structure using
getDOMStructure.
* bridge/runtime_object.h: Added createPrototype so getDOMStructure
will work.
* history/CachedPage.cpp:
(WebCore::CachedPage::restore): Let the window shell's
setWindow function create the JSDOMWindow instead of doing it here.
* page/DOMWindow.idl: Removed DoNotCache, which is no longer used.
2008-09-19 Dan Bernstein <mitz@apple.com>
Reviewed by Dave Hyatt.
This optimization was suggested by Daniel Fenwick
- speed up measuring text on the Core Text code path by not specifying a paragraph writing direction
Specifying LTR paragraph directionality when measuring runs of RTL text
resulted in typically two CTRuns being generated for every run instead
of one, due to the leading space being reordered to the left.
* platform/graphics/SimpleFontData.h: Removed the ltr parameter to
getCFStringAttributes() and changed m_CFStringAttributes from an array
to a single value.
* platform/graphics/mac/CoreTextController.cpp:
(WebCore::CoreTextController::CoreTextController): Added a
mayUseNaturalWritingDirection parameter.
(WebCore::CoreTextController::collectCoreTextRunsForCharacters): Changed
to force the bidi embedding level whenever
m_mayUseNaturalWritingDirectrion is false. Since this is now a common
case, made the typesetter options dictionaries static.
* platform/graphics/mac/CoreTextController.h:
* platform/graphics/mac/FontMacCoreText.cpp:
(WebCore::Font::selectionRectForComplexText): Renamed a local variable.
(WebCore::Font::floatWidthForComplexText): Changed to allow the
CoreTextController to not set the writing direction.
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::getCFStringAttributes): Removed the ltr
parameter and the paragraph style attribute.
2008-09-19 David Hyatt <hyatt@apple.com>
Reviewed by Sam Weinig
https://bugs.webkit.org/show_bug.cgi?id=20941
Incorrect height calculation for replaced element inside nested
positioned elements (where the inner has a percentage height and
the outer implicitly has a fixed height because of explicit top/bottom
values).
Added fast/block/positioning/replaced-inside-top-bottom.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::availableHeightUsing):
2008-09-19 Chris Fleizach <cfleizach@apple.com>
Fix Tiger bustage
* page/mac/AccessibilityObjectWrapper.mm:
2008-09-18 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6211041> Expose legend tag in accessibility
Exposes the legend tag as the titleUIElement of a fieldset
Test: accessibility/legend.html
* page/AccessibilityObject.h:
(WebCore::AccessibilityObject::isFieldset):
* page/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isFieldset):
(WebCore::AccessibilityRenderObject::titleUIElement):
* page/AccessibilityRenderObject.h:
* rendering/RenderFieldset.h:
2008-09-19 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6213171> WebKit should use new array-centric methods for AX performance
Implement a few AX API methods that will be called by AppKit, which will
speed up access to accessibility objects
* page/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
(-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
(-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
2008-09-19 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Simon Hausmann.
[qtwebkit] Set the m_should* flags to their proper value on entry
With plugins it was possible that we finished a job twice. This was
some kind of reentrancy in QNetworkReplyHandler::sendQueuedItems. By
setting the flag to (m_loadMode == LoadDeferred) they will always have
the right value and we will not send responses twice.
* platform/network/qt/QNetworkReplyHandler.cpp:
2008-09-19 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Simon Hausmann.
[qtwebkit] Pass test 70 of acid3. Handle text decoding errors
Handle text decoding errors before instructing the parser to parse. We
have converted the text to QString and all encoding errors are gone and
the parser will not be able to detect them. So handle them before parsing.
* dom/XMLTokenizerQt.cpp:
(WebCore::XMLTokenizer::doWrite):
2008-09-18 Darin Adler <darin@apple.com>
Reviewed by Maciej Stachowiak.
- part 1 of https://bugs.webkit.org/show_bug.cgi?id=20858
make each distinct C++ class get a distinct JSC::Structure
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::customPut): Use setDOMException
instead of DOMExceptionTranslator.
* bindings/js/JSDOMBinding.cpp:
(WebCore::getCachedDOMObjectWrapper): Updated function name.
(WebCore::cacheDOMObjectWrapper): Ditto.
(WebCore::forgetDOMObject): Ditto.
(WebCore::getCachedDOMNodeWrapper): Ditto.
(WebCore::forgetDOMNode): Ditto.
(WebCore::cacheDOMNodeWrapper): Ditto.
(WebCore::forgetAllDOMNodesForDocument): Ditto.
(WebCore::markDOMNodesForDocument): Ditto.
(WebCore::updateDOMNodeDocument): Ditto.
(WebCore::getCachedDOMStructure): Added.
(WebCore::createDOMStructure): Ditto.
* bindings/js/JSDOMBinding.h: Get rid of the ScriptInterpreter
class and replace the static member functions with non-member
functions. Added many other functions for getting at structures,
prototypes, wrappers, and creating them. Also moved the
cacheGlobalObject function here from JavaScriptCore; eventually
I'll remove that once I get rid of the remaining callers. Also
removed the DOMExceptionTranslator class.
* bindings/js/JSDOMWindowBase.h: Added JSDOMStructureMap type,
and put one of those maps in each window.
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::markDOMObjectWrapper): Updated for function name change.
(WebCore::JSDOMWindow::mark): Added code to mark all the structures
in the structure map.
* bindings/js/JSEventTargetNode.cpp:
(WebCore::JSEventTargetNode::JSEventTargetNode): Changed to take
a structure instead of a prototype.
* bindings/js/JSEventTargetNode.h: Ditto.
* bindings/js/JSHTMLAllCollection.h:
(WebCore::JSHTMLAllCollection::JSHTMLAllCollection): Ditto.
* bindings/js/JSHTMLInputElementBase.cpp:
(WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase): Removed
use of the JSC_IMPLEMENT_PROTOTYPE macro, and changed to take a
structure instead of a prototype.
* bindings/js/JSHTMLInputElementBase.h: Removed use of the
JSC_DEFINE_PROTOTYPE_WITH_PROTOTYPE macro, and changed constructor
to take a structure instead of a prototype. Created a dummy prototype
class that causes the HTMLInputElement prototype to have the
HTMLElement prototype.
* bindings/scripts/CodeGeneratorJS.pm: Change constructors to take
structures instead of prototypes. Changed the prototype self function
to use the getDOMPrototype function -- later we can eliminate it and
have callers invoke getDOMPrototype directly instead. Updated other
functions that have name changes. Added code to generate the
createPrototype member function. Changed use of cacheGlobalObject to
get it from the WebCore namespace instead of the JSC namespace.
Changed cacheDOMObject calls to use getDOMObjectWrapper instead.
* dom/Document.cpp:
(WebCore::Document::~Document): Updated for name change and also
removed unnecessary JSLock use -- there's no need to lock around this.
* dom/Node.cpp:
(WebCore::Node::setDocument): Ditto.
* dom/make_names.pl: Changed to use CREATE_DOM_NODE_WRAPPER macro
instead of calling new directly.
* bindings/js/JSCSSRuleCustom.cpp:
(WebCore::toJS): Updated for function name changes and used the
CREATE_DOM_OBJECT_WRAPPER macro.
* bindings/js/JSCSSValueCustom.cpp:
(WebCore::toJS): Ditto.
* bindings/js/JSCanvasPixelArrayCustom.cpp:
(WebCore::toJS): Ditto.
* bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::mark): Ditto.
(WebCore::toJS): Ditto.
* bindings/js/JSElementCustom.cpp:
(WebCore::toJSNewlyCreated): Ditto.
* bindings/js/JSEventCustom.cpp:
(WebCore::toJS): Ditto.
* bindings/js/JSEventTargetBase.cpp:
(WebCore::jsEventTargetDispatchEvent): Use setDOMException instead
of DOMExceptionTranslator.
(WebCore::toJS): Updated for function name changes and used the
CREATE_DOM_OBJECT_WRAPPER macro.
* bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::toJS): Ditto.
* bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::mark): Ditto.
(WebCore::createWrapper): Ditto.
(WebCore::toJS): Ditto.
* bindings/js/JSSVGPathSegCustom.cpp:
(WebCore::toJS): Ditto.
* bindings/js/JSStyleSheetCustom.cpp:
(WebCore::toJS): Ditto.
(WebCore::JSStyleSheet::mark): Ditto.
* bindings/js/JSTextCustom.cpp:
(WebCore::toJSNewlyCreated): Ditto.
* bindings/js/JSXMLHttpRequestConstructor.cpp:
(WebCore::constructXMLHttpRequest): Ditto.
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::mark): Ditto.
* bindings/js/JSXMLHttpRequestUploadCustom.cpp:
(WebCore::JSXMLHttpRequestUpload::mark): Ditto.
* bindings/js/JSXSLTProcessorConstructor.cpp:
(WebCore::constructXSLTProcessor): Ditto.
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::finishedWithEvent): Ditto.
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::loadRequestAsynchronously): Ditto.
(WebCore::XMLHttpRequest::dropProtection): Ditto.
2008-09-18 David Hyatt <hyatt@apple.com>
This patch gets a viewless scrollbar working on Mac. It is turned off
by default. Hit testing works. For now the scrollbar just paints ugly
debug rects in the place of the buttons, track and thumb. It does match
Aqua metrics though.
Reviewed by Sam Weinig
* WebCore.xcodeproj/project.pbxproj:
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passMousePressEventToScrollbar):
* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::paint):
(WebCore::ScrollbarThemeComposite::trackPosition):
* platform/ScrollbarThemeComposite.h:
* platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::addChild):
* platform/mac/ScrollbarThemeMac.cpp:
(WebCore::):
(WebCore::ScrollbarThemeMac::hasButtons):
(WebCore::ScrollbarThemeMac::hasThumb):
(WebCore::buttonRepaintRect):
(WebCore::ScrollbarThemeMac::backButtonRect):
(WebCore::ScrollbarThemeMac::forwardButtonRect):
(WebCore::trackRepaintRect):
(WebCore::ScrollbarThemeMac::trackRect):
(WebCore::ScrollbarThemeMac::minimumThumbLength):
(WebCore::ScrollbarThemeMac::shouldCenterOnThumb):
(WebCore::ScrollbarThemeMac::paintTrack):
(WebCore::ScrollbarThemeMac::paintButton):
(WebCore::ScrollbarThemeMac::paintThumb):
* platform/mac/ScrollbarThemeMac.h:
(WebCore::ScrollbarThemeMac::supportsControlTints):
* platform/qt/ScrollbarThemeQt.cpp:
(WebCore::ScrollbarThemeQt::trackPosition):
2008-09-18 Collin Jackson <collinj@webkit.org>
Build fix; added missing header file to GNUmakefile.am
* GNUmakefile.am:
2008-09-18 Sam Weinig <sam@webkit.org>
Reviewed by David "the Hair" Hyatt.
Move DataRef, SVGRenderStyle and SVGRenderStyleDefs in render/style.
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* rendering/DataRef.h: Removed.
* rendering/SVGRenderStyle.cpp: Removed.
* rendering/SVGRenderStyle.h: Removed.
* rendering/SVGRenderStyleDefs.cpp: Removed.
* rendering/SVGRenderStyleDefs.h: Removed.
* rendering/style/DataRef.h: Copied from rendering/DataRef.h.
* rendering/style/SVGRenderStyle.cpp: Copied from rendering/SVGRenderStyle.cpp.
* rendering/style/SVGRenderStyle.h: Copied from rendering/SVGRenderStyle.h.
* rendering/style/SVGRenderStyleDefs.cpp: Copied from rendering/SVGRenderStyleDefs.cpp.
* rendering/style/SVGRenderStyleDefs.h: Copied from rendering/SVGRenderStyleDefs.h.
2008-09-18 Mark Rowe <mrowe@apple.com>
Reviewed by Dan Bernstein.
Add a means of clearing a FrameTree's name.
* WebCore.base.exp:
* page/FrameTree.cpp:
(WebCore::FrameTree::clearName):
* page/FrameTree.h:
2008-09-18 David Hyatt <hyatt@apple.com>
Eliminate addToSuperview from Widget, since it was only called
by ScrollViewMac's addChild method. Just shift the original body
of addToSuperView into addChild.
Reviewed by Sam Weinig
* platform/Widget.h:
* platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::addChild):
* platform/mac/WidgetMac.mm:
2008-09-18 Collin Jackson <collinj@webkit.org>
Reviewed by Antti Koivisto and Mark Rowe.
Test: http/tests/misc/dns-prefetch-control.html
https://bugs.webkit.org/show_bug.cgi?id=20690
Invoke WebCore::prefetchDNS() on host names that appear in
in the href of hyperlinks and <link rel="dns-prefetch">. This
can be used to implement DNS prefetching.
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::processHttpEquiv):
(WebCore::Document::setSecurityOrigin):
(WebCore::Document::initDNSPrefetch):
(WebCore::Document::parseDNSPrefetchControlHeader):
* dom/Document.h:
(WebCore::Document::isDNSPrefetchEnabled):
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::parseMappedAttribute):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::HTMLLinkElement):
(WebCore::HTMLLinkElement::parseMappedAttribute):
(WebCore::HTMLLinkElement::tokenizeRelAttribute):
(WebCore::HTMLLinkElement::process):
* html/HTMLLinkElement.h:
* html/PreloadScanner.cpp:
(WebCore::PreloadScanner::processAttribute):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::begin):
* platform/gtk/TemporaryLinkStubs.cpp:
(WebCore::prefetchDNS):
* platform/network/DNS.h: Added.
* platform/network/cf/DNSCFNet.cpp: Added.
(WebCore::prefetchDNS):
* platform/qt/TemporaryLinkStubs.cpp:
(WebCore::prefetchDNS):
* platform/wx/TemporaryLinkStubs.cpp:
(WebCore::prefetchDNS):
2008-09-18 David Hyatt <hyatt@apple.com>
Eliminate the convertToScreenCoordinate method on Widget, since
ScrollView has redundant methods that already do the same thing.
Reviewed by Sam Weinig
* editing/mac/SelectionControllerMac.mm:
(WebCore::SelectionController::notifyAccessibilityForSelectionChange):
* platform/Widget.h:
* platform/mac/WidgetMac.mm:
(WebCore::Widget::containingWindow):
2008-09-18 David Hyatt <hyatt@apple.com>
Move to only one constructor for Widgets. Rename data to m_data and make
it have an #ifdef only for platforms that have platform-specific data (Mac
and Gtk).
Reviewed by Sam Weinig
* WebCore.base.exp:
* platform/Widget.cpp:
(WebCore::Widget::init):
* platform/Widget.h:
* platform/gtk/WidgetGtk.cpp:
(WebCore::Widget::Widget):
(WebCore::Widget::~Widget):
(WebCore::Widget::cursor):
(WebCore::Widget::setCursor):
* platform/mac/WidgetMac.mm:
(WebCore::Widget::Widget):
(WebCore::Widget::~Widget):
(WebCore::Widget::addToSuperview):
(WebCore::Widget::removeFromSuperview):
(WebCore::Widget::beforeMouseDown):
(WebCore::Widget::afterMouseDown):
* platform/qt/WidgetQt.cpp:
(WebCore::Widget::Widget):
* platform/win/WidgetWin.cpp:
(WebCore::Widget::Widget):
* platform/wx/WidgetWx.cpp:
(WebCore::Widget::Widget):
2008-09-18 David Hyatt <hyatt@apple.com>
Move Qt's isNPAPIPlugin boolean from Widget down to PluginView, since there
was no reason for it to be on Widget. This change eliminates Qt ifdefs
from Widget.
Reviewed by Sam Weinig
* bindings/js/ScriptControllerQt.cpp:
(WebCore::ScriptController::createScriptInstanceForWidget):
* platform/qt/WidgetQt.cpp:
(WebCore::WidgetPrivate::WidgetPrivate):
(WebCore::WidgetPrivate::~WidgetPrivate):
(WebCore::Widget::Widget):
(WebCore::Widget::~Widget):
* plugins/PluginView.cpp:
(WebCore::PluginView::PluginView):
* plugins/PluginView.h:
(WebCore::PluginView::isNPAPIPlugin):
(WebCore::PluginView::setIsNPAPIPlugin):
2008-09-18 David Hyatt <hyatt@apple.com>
Make geometryChanged() cross-platform on Widget. GTK and WIN platform
ifdefs are now gone from Widget!
Reviewed by Sam Weinig
* platform/Widget.h:
(WebCore::Widget::geometryChanged):
* platform/gtk/WidgetGtk.cpp:
* platform/qt/WidgetQt.cpp:
2008-09-18 David Hyatt <hyatt@apple.com>
Consolidate convertTo/FromContainingWindow methods so that all platforms
but Mac share the same code.
Move convertSelfToChild and convertChildToSelf to ScrollView, since
Widget should know nothing about children. Make the methods cross-platform
on ScrollView.
Reviewed by Sam Weinig
* platform/ScrollView.h:
(WebCore::ScrollView::convertChildToSelf):
(WebCore::ScrollView::convertSelfToChild):
* platform/Widget.cpp:
(WebCore::Widget::convertToContainingWindow):
(WebCore::Widget::convertFromContainingWindow):
* platform/Widget.h:
(WebCore::Widget::geometryChanged):
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::isScrollViewScrollbar):
* platform/gtk/WidgetGtk.cpp:
* platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::isScrollViewScrollbar):
* platform/mac/WidgetMac.mm:
* platform/qt/ScrollViewQt.cpp:
(WebCore::ScrollView::isScrollViewScrollbar):
* platform/qt/WidgetQt.cpp:
* platform/win/ScrollViewWin.cpp:
(WebCore::ScrollView::isScrollViewScrollbar):
* platform/win/WidgetWin.cpp:
2008-09-18 David Hyatt <hyatt@apple.com>
Make the conversion methods that go to and from some containingWindow
cross-platform. Implement them on Mac.
Reviewed by Sam Weinig
* platform/Widget.h:
(WebCore::Widget::setContainingWindow):
* platform/mac/WidgetMac.mm:
(WebCore::Widget::convertFromContainingWindow):
(WebCore::Widget::convertToContainingWindow):
2008-09-18 Sam Weinig <sam@webkit.org>
Rubber-stamped by David "Yeah-yeah" Hyatt.
Cleanup RenderStyle.
* WebCore.xcodeproj/project.pbxproj:
* rendering/style/CounterContent.h:
* rendering/style/RenderStyle.cpp:
* rendering/style/RenderStyle.h:
2008-09-18 Chris Marrin <cmarrin@apple.com>
Reviewed by Sam Weinig
Fixed https://bugs.webkit.org/show_bug.cgi?id=20908
Now TransformOperations and AnimationList no longer
inherit from Vector<> but rather have API to access.
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::computedTransform):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::createTransformOperations):
* page/animation/AnimationBase.cpp:
(WebCore::blendFunc):
* page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::updateTransitions):
(WebCore::CompositeAnimation::updateKeyframeAnimations):
(WebCore::CompositeAnimation::animate):
* page/animation/ImplicitAnimation.cpp:
(WebCore::ImplicitAnimation::validateTransformFunctionList):
* page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::validateTransformFunctionList):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateReflectionStyle):
* rendering/style/AnimationList.cpp:
(WebCore::AnimationList::operator==):
* rendering/style/AnimationList.h:
(WebCore::AnimationList::operator!=):
(WebCore::AnimationList::size):
(WebCore::AnimationList::isEmpty):
(WebCore::AnimationList::resize):
(WebCore::AnimationList::remove):
(WebCore::AnimationList::append):
(WebCore::AnimationList::animation):
* rendering/style/RenderStyle.cpp:
(WebCore::StyleRareNonInheritedData::updateKeyframes):
(WebCore::RenderStyle::applyTransform):
(WebCore::RenderStyle::adjustAnimations):
(WebCore::RenderStyle::adjustTransitions):
(WebCore::RenderStyle::transitionForProperty):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::hasTransform):
* rendering/style/TransformOperations.cpp:
(WebCore::TransformOperations::TransformOperations):
(WebCore::TransformOperations::operator==):
* rendering/style/TransformOperations.h:
(WebCore::TransformOperations::apply):
(WebCore::TransformOperations::operations):
2008-09-18 Holger Hans Peter Freyther <zecke@selfish.org>
Build fix.
[qt] Build fixes after the Widget/ScrollView cleanup
topLevel() is now root()
* platform/qt/ScrollViewQt.cpp:
(WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
(WebCore::ScrollView::addChild):
(WebCore::ScrollView::removeChild):
2008-09-18 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=20437
XMLTokenizer.cpp used to contain two different implementations. One was using
libxml2 and the other was using the Qt XML StreamReader. Clean up the code by
separating the two implementations from each other.
Common code and some small bits are kept inside the XMLTokenizer.cpp, the Qt code
was moved to XMLTokenizerQt.cpp and the Libxml2 based code was moved to
XMLTokenizerLibxml2.cpp. There should be no functional changes.
Attempt to add XMLTokenizerLibxml2.cpp to every buildsystem so the build continues
to work.
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* dom/XMLTokenizer.cpp:
(WebCore::isScriptElement):
(WebCore::castToScriptElement):
(WebCore::XMLTokenizer::setCurrentNode):
(WebCore::XMLTokenizer::write):
(WebCore::XMLTokenizer::eventuallyMarkAsParserCreated):
(WebCore::XMLTokenizer::enterText):
(WebCore::toString):
(WebCore::XMLTokenizer::exitText):
(WebCore::XMLTokenizer::end):
(WebCore::XMLTokenizer::insertErrorMessageBlock):
* dom/XMLTokenizer.h:
(WebCore::XMLTokenizer::wellFormed):
* dom/XMLTokenizerLibxml2.cpp: Copied from WebCore/dom/XMLTokenizer.cpp.
(WebCore::createMemoryParser):
(WebCore::XMLTokenizer::XMLTokenizer):
(WebCore::XMLTokenizer::~XMLTokenizer):
(WebCore::XMLTokenizer::doWrite):
(WebCore::ignorableWhitespaceHandler):
(WebCore::XMLTokenizer::initializeParserContext):
(WebCore::XMLTokenizer::doEnd):
(WebCore::XMLTokenizer::lineNumber):
(WebCore::XMLTokenizer::columnNumber):
(WebCore::XMLTokenizer::stopParsing):
(WebCore::XMLTokenizer::resumeParsing):
(WebCore::parseXMLDocumentFragment):
(WebCore::attributesStartElementNsHandler):
(WebCore::parseAttributes):
* dom/XMLTokenizerQt.cpp: Copied from WebCore/dom/XMLTokenizer.cpp.
(WebCore::EntityResolver::resolveUndeclaredEntity):
(WebCore::XMLTokenizer::XMLTokenizer):
(WebCore::XMLTokenizer::~XMLTokenizer):
(WebCore::XMLTokenizer::doWrite):
(WebCore::XMLTokenizer::initializeParserContext):
(WebCore::XMLTokenizer::doEnd):
(WebCore::XMLTokenizer::lineNumber):
(WebCore::XMLTokenizer::columnNumber):
(WebCore::XMLTokenizer::stopParsing):
(WebCore::XMLTokenizer::resumeParsing):
(WebCore::parseXMLDocumentFragment):
(WebCore::attributesStartElementNsHandler):
(WebCore::parseAttributes):
(WebCore::):
2008-09-18 Beth Dakin <bdakin@apple.com>
Reviewed by Geoff Garen.
Build fix for non-Mac builds.
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::cssText):
2008-09-18 Peter Kasting <pkasting@google.com>
Reviewed by hyatt. Landed by eseidel.
https://bugs.webkit.org/show_bug.cgi?id=20745
Animated GIFs do not animate properly with (at least) CG.
* WebCore\platform\graphics\BitmapImage.cpp:
* WebCore\platform\graphics\BitmapImage.h:
* WebCore\platform\graphics\cairo\ImageCairo.cpp:
* WebCore\platform\graphics\cg\ImageCG.cpp:
* WebCore\platform\graphics\qt\ImageQt.cpp:
* WebCore\platform\graphics\wx\ImageWx.cpp:
2008-09-18 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin
<rdar://problem/6224222> AX: should not expose a <table> as an AXTable if ARIA
role specifies otherwise
If a <table> isn't an AXTable, the rows and cells should default to AccessibilityRenderObject
Test: accessibility/table-with-aria-role.html
* page/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
(WebCore::AccessibilityTable::addChildren):
(WebCore::AccessibilityTable::roleValue):
(WebCore::AccessibilityTable::accessibilityIsIgnored):
(WebCore::AccessibilityTable::title):
* page/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::accessibilityIsIgnored):
(WebCore::AccessibilityTableCell::isTableCell):
(WebCore::AccessibilityTableCell::roleValue):
* page/AccessibilityTableCell.h:
* page/AccessibilityTableRow.cpp:
(WebCore::AccessibilityTableRow::roleValue):
(WebCore::AccessibilityTableRow::isTableRow):
(WebCore::AccessibilityTableRow::accessibilityIsIgnored):
* page/AccessibilityTableRow.h:
2008-09-18 Steve Falkenburg <sfalken@apple.com>
Use higher-resolution timers on all variants of Windows.
Reviewed by Darin Adler.
* platform/win/SharedTimerWin.cpp:
(WebCore::setSharedTimerFireTime):
2008-09-18 David Hyatt <hyatt@apple.com>
Make containingWindow() and setContainingWindow() cross-platform.
Add a root() function cross-platform so Qt doesn't have to
define its own.
Reviewed by Darin Adler
* platform/Widget.cpp:
(WebCore::Widget::root):
* platform/Widget.h:
(WebCore::Widget::setContainingWindow):
* platform/gtk/WidgetGtk.cpp:
(WebCore::Widget::Widget):
(WebCore::Widget::containingWindow):
* platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::addChild):
(WebCore::ScrollView::removeChild):
* platform/mac/WidgetMac.mm:
(WebCore::Widget::containingWindow):
* platform/qt/WidgetQt.cpp:
(WebCore::Widget::invalidateRect):
(WebCore::Widget::containingWindow):
* platform/win/WidgetWin.cpp:
(WebCore::Widget::Widget):
(WebCore::Widget::~Widget):
(WebCore::Widget::containingWindow):
2008-09-18 Beth Dakin <bdakin@apple.com>
Reviewed by Dave Hyatt.
Fix for https://bugs.webkit.org/show_bug.cgi?id=20515 Crash upon
parsing CSS: unicode-range: searchfield-cancel-buttonpt=-webkit-
dashboard-region=
and corresponding: <rdar://problem/6174100>
This patch makes CSSParserValue::createCSSValue handle unknown
identifiers.
* css/CSSParserValues.cpp:
(WebCore::CSSParserValue::createCSSValue): If we have an identifier
with no id (an unknown identifier) create a CSSPrimitiveValue of
type CSS_PARSER_IDENTIFIER
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::cssText):
(WebCore::CSSPrimitiveValue::parserValue):
* css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::):
2008-09-18 Sam Weinig <sam@webkit.org>
Rubber-stamped by David "I'd prefer not" Hyatt.
More the remaining class out of RenderStyle.h/cpp
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* rendering/style/CursorData.h: Copied from rendering/style/RenderStyle.h.
(WebCore::CursorData::CursorData):
(WebCore::CursorData::operator==):
(WebCore::CursorData::operator!=):
* rendering/style/CursorList.h: Copied from rendering/style/RenderStyle.h.
(WebCore::CursorList::operator[]):
(WebCore::CursorList::CursorList):
* rendering/style/RenderStyle.cpp:
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::deref):
(WebCore::RenderStyle::hasOneRef):
(WebCore::RenderStyle::InheritedFlags::operator!=):
(WebCore::RenderStyle::NonInheritedFlags::operator!=):
(WebCore::RenderStyle::hasBackground):
(WebCore::RenderStyle::outlineWidth):
(WebCore::RenderStyle::autoWrap):
(WebCore::RenderStyle::preserveNewline):
(WebCore::RenderStyle::collapseWhiteSpace):
(WebCore::RenderStyle::isCollapsibleWhiteSpace):
(WebCore::RenderStyle::breakOnlyAfterWhiteSpace):
(WebCore::RenderStyle::breakWords):
(WebCore::RenderStyle::outlineOffset):
(WebCore::RenderStyle::setLeft):
(WebCore::RenderStyle::setRight):
(WebCore::RenderStyle::setTop):
(WebCore::RenderStyle::setBottom):
(WebCore::RenderStyle::setDashboardRegion):
(WebCore::RenderStyle::setBackgroundColor):
(WebCore::RenderStyle::setBorderImage):
(WebCore::RenderStyle::setBorderRadius):
(WebCore::RenderStyle::setFontDescription):
(WebCore::RenderStyle::adjustBackgroundLayers):
(WebCore::RenderStyle::adjustMaskLayers):
(WebCore::RenderStyle::deleteBindingURIs):
(WebCore::RenderStyle::inheritBindingURIs):
(WebCore::RenderStyle::isDisplayReplacedType):
(WebCore::RenderStyle::isDisplayInlineType):
(WebCore::RenderStyle::isOriginalDisplayInlineType):
* rendering/style/StyleInheritedData.cpp: Copied from rendering/style/RenderStyle.cpp.
* rendering/style/StyleInheritedData.h: Copied from rendering/style/RenderStyle.h.
(WebCore::StyleInheritedData::operator!=):
* rendering/style/StyleRareInheritedData.cpp: Copied from rendering/style/RenderStyle.cpp.
* rendering/style/StyleRareInheritedData.h: Copied from rendering/style/RenderStyle.h.
(WebCore::StyleRareInheritedData::operator!=):
* rendering/style/StyleRareNonInheritedData.cpp: Copied from rendering/style/RenderStyle.cpp.
* rendering/style/StyleRareNonInheritedData.h: Copied from rendering/style/RenderStyle.h.
* rendering/style/StyleReflection.h: Copied from rendering/style/RenderStyle.h.
2008-09-18 David Hyatt <hyatt@apple.com>
Move the concept of suppression invalidation on Widgets to Scrollbar
instead. Since this is only used by Scrollbars, there is no need for
it to be on Widget.
Reviewed by Sam Weinig
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::Scrollbar):
(WebCore::Scrollbar::invalidateRect):
* platform/Scrollbar.h:
(WebCore::Scrollbar::suppressInvalidation):
(WebCore::Scrollbar::setSuppressInvalidation):
* platform/Widget.h:
* platform/gtk/WidgetGtk.cpp:
(WebCore::Widget::Widget):
(WebCore::Widget::invalidateRect):
* platform/qt/WidgetQt.cpp:
(WebCore::WidgetPrivate::WidgetPrivate):
(WebCore::Widget::invalidateRect):
* platform/win/WidgetWin.cpp:
(WebCore::Widget::Widget):
(WebCore::Widget::invalidateRect):
2008-09-18 David Hyatt <hyatt@apple.com>
Make invalidate() on Widget non-virtual and make it just call
invalidateRect() on the boundsGeometry() of the Widget.
Reviewed by Dan Bernstein
* platform/Widget.h:
(WebCore::Widget::boundsGeometry):
(WebCore::Widget::invalidate):
* platform/gtk/WidgetGtk.cpp:
* platform/mac/WidgetMac.mm:
* platform/qt/WidgetQt.cpp:
* platform/win/WidgetWin.cpp:
* platform/wx/WidgetWx.cpp:
2008-09-18 Sam Weinig <sam@webkit.org>
Rubber-stamped in exile by David Hyatt.
Split Animation, AnimationList, BindingURI, ContentData, CounterContent,
KeyframeList, ShadowData, StyleFlexibleBoxData and TimingFunction out of
RenderStyle.h/cpp
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* css/CSSStyleSelector.cpp:
* css/CSSStyleSelector.h:
* page/animation/CompositeAnimation.cpp:
* page/animation/KeyframeAnimation.cpp:
* page/animation/KeyframeAnimation.h:
* rendering/RenderCounter.h:
* rendering/style/Animation.cpp: Copied from rendering/style/RenderStyle.cpp.
(WebCore::Animation::~Animation):
(WebCore::Animation::animationsMatch):
(WebCore::Animation::keyframeList):
(WebCore::Animation::setAnimationKeyframe):
* rendering/style/Animation.h: Copied from rendering/style/RenderStyle.h.
* rendering/style/AnimationList.cpp: Copied from rendering/style/RenderStyle.cpp.
* rendering/style/AnimationList.h: Copied from rendering/style/RenderStyle.h.
* rendering/style/BindingURI.cpp: Copied from rendering/style/RenderStyle.cpp.
* rendering/style/BindingURI.h: Copied from rendering/style/RenderStyle.h.
(WebCore::BindingURI::operator!=):
* rendering/style/ContentData.cpp: Copied from rendering/style/RenderStyle.cpp.
* rendering/style/ContentData.h: Copied from rendering/style/RenderStyle.h.
(WebCore::ContentData::ContentData):
(WebCore::ContentData::~ContentData):
* rendering/style/CounterContent.h: Copied from rendering/style/RenderStyle.h.
(WebCore::CounterContent::CounterContent):
* rendering/style/CounterDirectives.cpp: Copied from rendering/style/RenderStyle.cpp.
* rendering/style/CounterDirectives.h: Copied from rendering/style/RenderStyle.h.
(WebCore::CounterDirectives::CounterDirectives):
* rendering/style/KeyframeList.cpp: Copied from rendering/style/RenderStyle.cpp.
(WebCore::KeyframeList::insert):
* rendering/style/KeyframeList.h: Copied from rendering/style/RenderStyle.h.
(WebCore::KeyframeValue::KeyframeValue):
(WebCore::KeyframeList::create):
(WebCore::KeyframeList::KeyframeList):
* rendering/style/RenderStyle.cpp:
* rendering/style/RenderStyle.h:
* rendering/style/ShadowData.cpp: Copied from rendering/style/RenderStyle.cpp.
* rendering/style/ShadowData.h: Copied from rendering/style/RenderStyle.h.
(WebCore::ShadowData::ShadowData):
(WebCore::ShadowData::~ShadowData):
(WebCore::ShadowData::operator!=):
* rendering/style/StyleFlexibleBoxData.cpp: Copied from rendering/style/RenderStyle.cpp.
* rendering/style/StyleFlexibleBoxData.h: Copied from rendering/style/RenderStyle.h.
(WebCore::StyleFlexibleBoxData::operator!=):
* rendering/style/TimingFunction.h: Copied from rendering/style/RenderStyle.h.
(WebCore::TimingFunction::TimingFunction):
(WebCore::TimingFunction::operator==):
2008-09-18 Adele Peterson <adele@apple.com>
Reviewed by Dan Bernstein.
Fix RenderStyle leaks.
* rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createSubtreeIfNeeded):
2008-09-18 Kevin McCullough <kmccullough@apple.com>
Accidentally checked in code.
* html/HTMLElementFactory.cpp:
(WebCore::frameConstructor):
(WebCore::iframeConstructor):
2008-09-18 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim.
<rdar://problem/5722310> gracefully handle too many console messages
(20904)
- Keep track of the most previous message and then compare it to the
subsequent messages as they come in. If there are multiple of the same
message create a count that indicates the current number.
* manual-tests/inspector/multiple-console-messages.html: Added.
* page/inspector/Console.js:
* page/inspector/inspector.css:
2008-09-18 Jonathon Jongsma <jonathon@quotidian.org>
Reviewed by Alp Toker
https://bugs.webkit.org/show_bug.cgi?id=20830
[GTK] Don't use deprecated pango API
Replace deprecated pango functions with non-deprecated ones for newer
versions of pango
* platform/graphics/gtk/FontGtk.cpp:
(WebCore::getDefaultPangoLayout):
* platform/graphics/gtk/FontPlatformDataPango.cpp:
(WebCore::FontPlatformData::FontPlatformData):
2008-09-18 Alp Toker <alp@nuanti.com>
Build fix for r36587. Add new sources (and sort the lists).
* GNUmakefile.am:
2008-09-17 Sam Weinig <sam@webkit.org>
Fix Windows build.
* WebCore.vcproj/WebCore.vcproj:
2008-09-17 David Hyatt <hyatt@apple.com>
Switch back to having frameGeometry be virtual in order to keep Mac
the way it used to be.
Reviewed by Sam Weinig
* WebCore.base.exp:
* platform/Widget.cpp:
(WebCore::Widget::setParent):
* platform/Widget.h:
* platform/gtk/WidgetGtk.cpp:
(WebCore::Widget::frameGeometry):
(WebCore::Widget::setFrameGeometry):
* platform/mac/WidgetMac.mm:
(WebCore::Widget::frameGeometry):
(WebCore::Widget::setFrameGeometry):
* platform/qt/WidgetQt.cpp:
(WebCore::Widget::frameGeometry):
(WebCore::Widget::setFrameGeometry):
* platform/win/WidgetWin.cpp:
(WebCore::Widget::frameGeometry):
(WebCore::Widget::setFrameGeometry):
* platform/wx/WidgetWx.cpp:
(WebCore::Widget::frameGeometry):
(WebCore::Widget::setFrameGeometry):
* plugins/PluginView.cpp:
(WebCore::PluginView::setFrameGeometry):
(WebCore::PluginView::geometryChanged):
* plugins/PluginView.h:
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::updatePluginWidget):
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::updatePluginWidget):
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::updatePluginWidget):
2008-09-17 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Fix assertion in DOMWindow::adjustWindowRect where we were passing
in garbage values and were getting lucky that they were a not Nan.
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::windowProtoFuncOpen):
2008-09-17 Sam Weinig <sam@webkit.org>
Fix gtk build.
* rendering/style/MatrixTransformOperation.cpp:
2008-09-17 Sam Weinig <sam@webkit.org>
Rubber-stamped with love by David Hyatt.
Split IdentityTransformOperation, MatrixTransformOperation, RotateTransformOperation,
ScaleTransformOperation, SkewTransformOperation, StyleTransformData, TransformOperation,
TransformOperations and TranslateTransformOperation out of RenderStyle.h/cpp
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* css/CSSStyleSelector.cpp:
* page/animation/AnimationBase.cpp:
(WebCore::solveEpsilon):
* rendering/RenderLayer.cpp:
* rendering/style/IdentityTransformOperation.h: Copied from rendering/style/RenderStyle.h.
* rendering/style/MatrixTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
* rendering/style/MatrixTransformOperation.h: Copied from rendering/style/RenderStyle.h.
(WebCore::MatrixTransformOperation::MatrixTransformOperation):
* rendering/style/RenderStyle.cpp:
* rendering/style/RenderStyle.h:
* rendering/style/RotateTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
* rendering/style/RotateTransformOperation.h: Copied from rendering/style/RenderStyle.h.
(WebCore::RotateTransformOperation::RotateTransformOperation):
* rendering/style/ScaleTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
* rendering/style/ScaleTransformOperation.h: Copied from rendering/style/RenderStyle.h.
(WebCore::ScaleTransformOperation::ScaleTransformOperation):
* rendering/style/SkewTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
* rendering/style/SkewTransformOperation.h: Copied from rendering/style/RenderStyle.h.
(WebCore::SkewTransformOperation::SkewTransformOperation):
* rendering/style/StyleTransformData.cpp: Copied from rendering/style/RenderStyle.cpp.
* rendering/style/StyleTransformData.h: Copied from rendering/style/RenderStyle.h.
(WebCore::StyleTransformData::operator!=):
* rendering/style/TransformOperation.h: Copied from rendering/style/RenderStyle.h.
(WebCore::TransformOperation::):
* rendering/style/TransformOperations.cpp: Copied from rendering/style/RenderStyle.cpp.
(WebCore::TransformOperations::TransformOperations):
* rendering/style/TransformOperations.h: Copied from rendering/style/RenderStyle.h.
(WebCore::TransformOperations::operator!=):
* rendering/style/TranslateTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
* rendering/style/TranslateTransformOperation.h: Copied from rendering/style/RenderStyle.h.
(WebCore::TranslateTransformOperation::TranslateTransformOperation):
2008-09-17 Mark Rowe <mrowe@apple.com>
Build fix.
* rendering/style/StyleDashboardRegion.h: PlatformString.h rather than String.h.
2008-09-17 David Hyatt <hyatt@apple.com>
(1) Inline a bunch of methods for accessing frame geometry.
(2) Make sure frameGeometry() works even when you have no underlying
native widget.
(3) Cache a frame geometry rect cross-platform (even for widgets that
have underlying native widgets.
(4) PluginView's updateWindow call is now a virtual function on Widget.
Reviewed by Sam Weinig
* ChangeLog:
* WebCore.base.exp:
* platform/Widget.cpp:
(WebCore::Widget::setFrameGeometry):
* platform/Widget.h:
(WebCore::Widget::x):
(WebCore::Widget::y):
(WebCore::Widget::width):
(WebCore::Widget::height):
(WebCore::Widget::size):
(WebCore::Widget::pos):
(WebCore::Widget::frameGeometry):
(WebCore::Widget::resize):
(WebCore::Widget::move):
(WebCore::Widget::isFrameView):
(WebCore::Widget::windowClipRect):
* platform/mac/WidgetMac.mm:
(WebCore::Widget::~Widget):
(WebCore::Widget::updatePlatformWidgetFrameGeometry):
* platform/win/WidgetWin.cpp:
(WebCore::Widget::updatePlatformWidgetFrameGeometry):
* plugins/PluginView.cpp:
(WebCore::PluginView::setFrameGeometry):
(WebCore::PluginView::geometryChanged):
* plugins/PluginView.h:
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::updatePlatformWidgetFrameGeometry):
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::updatePlatformWidgetFrameGeometry):
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::updatePlatformWidgetFrameGeometry):
* plugins/wx/PluginViewWx.cpp:
2008-09-17 Sam Weinig <sam@webkit.org>
Reviewed by David "Waterman" Hyatt.
Fix a leak of NSViews in WidgetMac.mm.
* platform/mac/WidgetMac.mm:
(WebCore::Widget::~Widget):
2008-09-17 Sam Weinig <sam@webkit.org>
Rubber-stamped by David Waterman Hyatt.
Split FillLayer, StyleBackgroundData, StyleBoxData, StyleDashboardRegion, StyleMarqueeData
StyleMultiColData and StyleVisualData out of RenderStyle.h/cpp
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* rendering/style/FillLayer.cpp: Copied from rendering/style/RenderStyle.cpp.
* rendering/style/FillLayer.h: Copied from rendering/style/RenderStyle.h.
(WebCore::FillLayer::operator!=):
(WebCore::FillLayer::hasImage):
(WebCore::FillLayer::hasFixedImage):
* rendering/style/RenderStyle.cpp:
* rendering/style/RenderStyle.h:
* rendering/style/StyleBackgroundData.cpp: Copied from rendering/style/RenderStyle.cpp.
(WebCore::StyleBackgroundData::StyleBackgroundData):
* rendering/style/StyleBackgroundData.h: Copied from rendering/style/RenderStyle.h.
(WebCore::StyleBackgroundData::~StyleBackgroundData):
(WebCore::StyleBackgroundData::operator!=):
* rendering/style/StyleBoxData.cpp: Copied from rendering/style/RenderStyle.cpp.
* rendering/style/StyleBoxData.h: Copied from rendering/style/RenderStyle.h.
(WebCore::StyleBoxData::operator!=):
* rendering/style/StyleDashboardRegion.h: Copied from rendering/style/RenderStyle.h.
(WebCore::StyleDashboardRegion::operator!=):
* rendering/style/StyleMarqueeData.cpp: Copied from rendering/style/RenderStyle.cpp.
* rendering/style/StyleMarqueeData.h: Copied from rendering/style/RenderStyle.h.
(WebCore::StyleMarqueeData::operator!=):
* rendering/style/StyleMultiColData.cpp: Copied from rendering/style/RenderStyle.cpp.
* rendering/style/StyleMultiColData.h: Copied from rendering/style/RenderStyle.h.
(WebCore::StyleMultiColData::operator!=):
(WebCore::StyleMultiColData::ruleWidth):
* rendering/style/StyleVisualData.cpp: Copied from rendering/style/RenderStyle.cpp.
* rendering/style/StyleVisualData.h: Copied from rendering/style/RenderStyle.h.
(WebCore::StyleVisualData::operator==):
2008-09-17 David Hyatt <hyatt@apple.com>
Remove WidgetClient from Widget.
Reviewed by Sam Weinig
* WebCore.xcodeproj/project.pbxproj:
* platform/Widget.h:
(WebCore::Widget::setClient):
(WebCore::Widget::client):
* platform/WidgetClient.h: Removed.
* platform/gtk/WidgetGtk.cpp:
* platform/mac/WidgetMac.mm:
(WebCore::Widget::Widget):
(WebCore::Widget::show):
(WebCore::Widget::hide):
* platform/qt/WidgetQt.cpp:
(WebCore::WidgetPrivate::WidgetPrivate):
* platform/win/WidgetWin.cpp:
(WebCore::Widget::Widget):
* platform/wx/WidgetWx.cpp:
(WebCore::Widget::Widget):
2008-09-17 David Hyatt <hyatt@apple.com>
Remove isEnabled/setEnabled from Widget. The concept of being enabled now
only applies to Scrollbars so the method has been moved there and made
cross-platform. Scrollbar subclasses that have a corresponding native
widget can subclass setEnabled to change the enabled state of the native
widget.
Reviewed by Sam Weinig & Darin Adler
* WebCore.base.exp:
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::Scrollbar):
* platform/Scrollbar.h:
(WebCore::Scrollbar::enabled):
(WebCore::Scrollbar::setEnabled):
* platform/Widget.h:
* platform/gtk/ScrollbarGtk.cpp:
(ScrollbarGtk::setEnabled):
* platform/gtk/ScrollbarGtk.h:
* platform/gtk/WidgetGtk.cpp:
* platform/mac/ScrollbarMac.h:
* platform/mac/ScrollbarMac.mm:
(WebCore::ScrollbarMac::scrollbarHit):
(WebCore::ScrollbarMac::setEnabled):
* platform/mac/WidgetMac.mm:
* platform/qt/WidgetQt.cpp:
(WebCore::WidgetPrivate::WidgetPrivate):
* platform/win/WidgetWin.cpp:
(WebCore::Widget::Widget):
* platform/wx/WidgetWx.cpp:
2008-09-17 Sam Weinig <sam@webkit.org>
Rubber-stamped by David Hyatt.
Split all RenderStyle enums into their own file.
* GNUmakefile.am:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* rendering/style/BorderValue.h:
* rendering/style/CollapsedBorderValue.h:
* rendering/style/RenderStyle.h:
* rendering/style/RenderStyleConstants.h: Copied from rendering/style/RenderStyle.h.
(WebCore::):
* rendering/style/StyleCachedImage.h:
* rendering/style/StyleGeneratedImage.h:
* rendering/style/StyleImage.h:
2008-09-17 Steve Falkenburg <sfalken@apple.com>
Add back isFrameView check to fix failed assertion during scroll bar teardown.
Reviewed by Dave Hyatt.
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::setParent):
2008-09-17 Brady Eidson <beidson@apple.com>
Reviewed by Mac build fix
* WebCore.xcodeproj/project.pbxproj: Send appropriate headers to WebKit
2008-09-17 Steve Falkenburg <sfalken@apple.com>
Fix build.
* platform/win/ScrollViewWin.cpp:
(WebCore::ScrollView::setParentVisible):
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::init):
2008-09-17 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Simon.
[QtWebKit] Implement error handling in TextCodecQt::decode
Use the QTextCodec parsing state to set the sawError out variable. This
is needed to pass Test 70 of acid3. The test case for this bug is
fast/encoding/invalid-xml.html that is now partially passed. To pass
it completely the Qt text codecs need to be adjusted to have proper
error handling.
* platform/text/qt/TextCodecQt.cpp:
(WebCore::TextCodecQt::decode):
2008-09-17 Sam Weinig <sam@webkit.org>
Rubber-stamped by Dave Hyatt.
Split BorderData, BorderValue, CollapsedBorderValue, OutlineValue and StyleSurroundData
out of RenderStyle.h/cpp
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* rendering/style/BorderData.h: Copied from rendering/style/RenderStyle.h.
(WebCore::BorderData::hasBorderRadius):
(WebCore::BorderData::borderLeftWidth):
(WebCore::BorderData::borderRightWidth):
(WebCore::BorderData::borderTopWidth):
(WebCore::BorderData::borderBottomWidth):
(WebCore::BorderData::operator!=):
* rendering/style/BorderValue.h: Copied from rendering/style/RenderStyle.h.
(WebCore::):
(WebCore::BorderValue::BorderValue):
(WebCore::BorderValue::nonZero):
(WebCore::BorderValue::isTransparent):
(WebCore::BorderValue::isVisible):
* rendering/style/CollapsedBorderValue.h: Copied from rendering/style/RenderStyle.h.
(WebCore::):
(WebCore::CollapsedBorderValue::CollapsedBorderValue):
(WebCore::CollapsedBorderValue::operator==):
* rendering/style/OutlineValue.h: Copied from rendering/style/RenderStyle.h.
(WebCore::OutlineValue::OutlineValue):
* rendering/style/RenderStyle.cpp:
* rendering/style/RenderStyle.h:
* rendering/style/StyleSurroundData.cpp: Copied from rendering/style/RenderStyle.cpp.
* rendering/style/StyleSurroundData.h: Copied from rendering/style/RenderStyle.h.
(WebCore::StyleSurroundData::operator!=):
2008-09-17 Beth Dakin <bdakin@apple.com>
Reviewed by Darin Adler.
This is a better fix for: Invalid CSS code crashes Safari
https://bugs.webkit.org/show_bug.cgi?id=20512
The spec indicates that the only valid input for a counter is a
number or an identifier. So that is exactly what we allow.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseCounterContent):
2008-09-17 Alp Toker <alp@nuanti.com>
GTK+ build fix. Adapt to use PlatformWidget functions.
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollViewScrollbar::geometryChanged):
(WebCore::ScrollView::addChild):
(WebCore::ScrollView::removeChild):
* platform/gtk/ScrollbarGtk.cpp:
(ScrollbarGtk::ScrollbarGtk):
(ScrollbarGtk::~ScrollbarGtk):
(ScrollbarGtk::geometryChanged):
2008-09-17 Sam Weinig <sam@webkit.org>
Reviewed by Adele Peterson.
Patch for <rdar://problem/6133884>
Calling window.resizeTo() on a subframe shouldn't change the window size
Test: fast/dom/Window/window-resize-and-move-sub-frame.html
* page/DOMWindow.cpp:
(WebCore::DOMWindow::moveBy):
(WebCore::DOMWindow::moveTo):
(WebCore::DOMWindow::resizeBy):
(WebCore::DOMWindow::resizeTo):
2008-09-17 Beth Dakin <bdakin@apple.com>
Reviewed by Adam Roben.
Fix for https://bugs.webkit.org/show_bug.cgi?id=20512 Invalid CSS
code crashes Safari
and corresponding: <rdar://problem/6173832>
Reading through the spec, it seems like a function is not valid
input for a counter. So this patch checks for that and bails in the
case of invalid input.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseCounterContent):
2008-09-17 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Antti Koivisto.
Fix <rdar://problem/6227089>
Crash in WebCore::Frame::setNeedsReapplyStyles()
View is null checked elsewhere too.
* page/Frame.cpp:
(WebCore::Frame::setNeedsReapplyStyles):
2008-09-17 David Hyatt <hyatt@apple.com>
Make the notion of having a native widget backing a Widget cross-platform.
The PlatformWidget abstraction (which already existed) is used for this.
Windows = HWND
Qt = QWidget
Mac = NSView
wx = wxWindow
Gtk = GtkWidget
There are new cross-platform methods that replace all of the unique
platform-specific methods.
platformWidget()
setPlatformWidget()
For plugins, on every platform except Qt on Windows, the plugin's native
widget is now stored in the Widget base class. Since Qt on Windows uses
HWNDs for plugins instead of QWidget, it is the only platform to keep the
m_window variable in PluginView.
Reviewed by Sam Weinig
* WebCore.base.exp:
* bindings/js/ScriptControllerMac.mm:
(WebCore::ScriptController::createScriptInstanceForWidget):
* page/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper attachmentView]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passMouseDownEventToWidget):
(WebCore::EventHandler::mouseDownViewIfStillGood):
(WebCore::EventHandler::passWheelEventToWidget):
(WebCore::EventHandler::sendFakeEventsAfterWidgetTracking):
* platform/Widget.cpp:
(WebCore::Widget::init):
(WebCore::Widget::setParent):
(WebCore::Widget::releasePlatformWidget):
(WebCore::Widget::retainPlatformWidget):
* platform/Widget.h:
(WebCore::Widget::platformWidget):
(WebCore::Widget::setPlatformWidget):
* platform/gtk/WidgetGtk.cpp:
(WebCore::Widget::Widget):
(WebCore::Widget::setFocus):
(WebCore::gdkDrawable):
(WebCore::Widget::setCursor):
(WebCore::Widget::show):
(WebCore::Widget::hide):
(WebCore::Widget::setEnabled):
(WebCore::Widget::isEnabled):
(WebCore::Widget::paint):
* platform/mac/PlatformScreenMac.mm:
(WebCore::screenRect):
(WebCore::screenAvailableRect):
* platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::scrollView):
(WebCore::ScrollView::update):
(WebCore::ScrollView::inWindow):
* platform/mac/ScrollbarMac.mm:
(WebCore::ScrollbarMac::ScrollbarMac):
(WebCore::ScrollbarMac::~ScrollbarMac):
(WebCore::ScrollbarMac::updateThumbPosition):
(WebCore::ScrollbarMac::updateThumbProportion):
(WebCore::ScrollbarMac::scrollbarHit):
* platform/mac/WidgetMac.mm:
(WebCore::Widget::Widget):
(WebCore::Widget::setEnabled):
(WebCore::Widget::isEnabled):
(WebCore::Widget::setFocus):
(WebCore::Widget::getOuterView):
(WebCore::Widget::paint):
(WebCore::Widget::invalidate):
(WebCore::Widget::invalidateRect):
(WebCore::Widget::setIsSelected):
(WebCore::Widget::releasePlatformWidget):
(WebCore::Widget::retainPlatformWidget):
* platform/qt/WidgetQt.cpp:
(WebCore::WidgetPrivate::WidgetPrivate):
(WebCore::Widget::Widget):
(WebCore::Widget::setFrameGeometry):
(WebCore::Widget::show):
(WebCore::Widget::hide):
(WebCore::Widget::isEnabled):
(WebCore::Widget::setEnabled):
(WebCore::Widget::invalidateRect):
(WebCore::Widget::containingWindow):
* platform/win/WidgetWin.cpp:
(WebCore::Widget::Widget):
* platform/wx/WidgetWx.cpp:
(WebCore::Widget::Widget):
(WebCore::Widget::frameGeometry):
(WebCore::Widget::setFocus):
(WebCore::Widget::setCursor):
(WebCore::Widget::show):
(WebCore::Widget::hide):
(WebCore::Widget::setFrameGeometry):
(WebCore::Widget::setEnabled):
(WebCore::Widget::isEnabled):
(WebCore::Widget::invalidate):
(WebCore::Widget::invalidateRect):
(WebCore::Widget::paint):
* plugins/PluginView.cpp:
(WebCore::PluginView::PluginView):
* plugins/PluginView.h:
(WebCore::PluginView::platformPluginWidget):
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::updateWindow):
(WebCore::PluginView::setFocus):
(WebCore::PluginView::show):
(WebCore::PluginView::hide):
(WebCore::PluginView::setParent):
(WebCore::PluginView::setNPWindowRect):
(WebCore::PluginView::setParentVisible):
(WebCore::PluginView::getValue):
(WebCore::PluginView::forceRedraw):
(WebCore::PluginView::init):
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::updateWindow):
(WebCore::PluginView::setFocus):
(WebCore::PluginView::show):
(WebCore::PluginView::hide):
(WebCore::PluginView::setParent):
(WebCore::PluginView::setNPWindowRect):
(WebCore::PluginView::setParentVisible):
(WebCore::PluginView::getValue):
(WebCore::PluginView::~PluginView):
(WebCore::PluginView::init):
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::updateWindow):
(WebCore::PluginView::setFocus):
(WebCore::PluginView::show):
(WebCore::PluginView::hide):
(WebCore::PluginView::paint):
(WebCore::PluginView::setParent):
(WebCore::PluginView::setParentVisible):
(WebCore::PluginView::setNPWindowRect):
(WebCore::PluginView::stop):
(WebCore::PluginView::invalidateRect):
(WebCore::PluginView::forceRedraw):
(WebCore::PluginView::~PluginView):
(WebCore::PluginView::init):
2008-09-17 Sam Weinig <sam@webkit.org>
Fix assert.
* platform/Widget.cpp:
(WebCore::Widget::setParent):
2008-09-17 David Hyatt <hyatt@apple.com>
Beginnings of Widget refactoring (in order to make the mixing of
widgets with and without corresponding native widgets more cross-platform).
This first patch makes the concept of a parent ScrollView cross-platform.
Note the similarity of the show/hide methods on the three PluginViews. This
will be refactored better in a later patch so that they can all share
a base class Widget show/hide method. For now the changes were made
simply to be able to bring WidgetWin's setParent method up into Widget.
Reviewed by Sam Weinig
* WebCore.base.exp:
* platform/ScrollView.h:
* platform/Widget.cpp:
(WebCore::Widget::init):
(WebCore::Widget::setParent):
* platform/Widget.h:
(WebCore::Widget::isSelfVisible):
(WebCore::Widget::isParentVisible):
(WebCore::Widget::isVisible):
(WebCore::Widget::setParentVisible):
(WebCore::Widget::isPluginView):
(WebCore::Widget::parent):
(WebCore::Widget::handleEvent):
(WebCore::Widget::geometryChanged):
* platform/gtk/WidgetGtk.cpp:
(WebCore::Widget::Widget):
* platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::addChild):
(WebCore::ScrollView::removeChild):
* platform/mac/ScrollbarMac.mm:
(WebCore::ScrollbarMac::~ScrollbarMac):
* platform/mac/WidgetMac.mm:
(WebCore::Widget::Widget):
(WebCore::Widget::~Widget):
* platform/qt/WidgetQt.cpp:
(WebCore::WidgetPrivate::WidgetPrivate):
(WebCore::Widget::Widget):
(WebCore::Widget::topLevel):
* platform/win/ScrollViewWin.cpp:
(WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
(WebCore::ScrollView::setAncestorVisible):
(WebCore::ScrollView::show):
(WebCore::ScrollView::hide):
* platform/win/WidgetWin.cpp:
(WebCore::Widget::Widget):
(WebCore::Widget::setParent):
* platform/wx/WidgetWx.cpp:
(WebCore::Widget::Widget):
* plugins/PluginView.cpp:
(WebCore::PluginView::PluginView):
* plugins/PluginView.h:
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::show):
(WebCore::PluginView::hide):
(WebCore::PluginView::setParentVisible):
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::show):
(WebCore::PluginView::hide):
(WebCore::PluginView::setParentVisible):
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::show):
(WebCore::PluginView::hide):
(WebCore::PluginView::setParentVisible):
2008-09-17 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Adam Roben.
<rdar://problem/6219577> Spew in console at launch about encoding mappings when running with ICU 4.0
* platform/text/TextCodecICU.cpp:
(WebCore::TextCodecICU::registerExtendedEncodingNames): Updated for new encoding names.
2008-09-17 Tor Arne Vestbø <tavestbo@trolltech.com>
Fix the QtWebKit/Mac build
* platform/qt/ScrollViewQt.cpp: add include
2008-09-17 David Hyatt <hyatt@apple.com>
Add a #define to control whether or not to use an NSScroller on Mac.
This ifdef will allow the new NSView-less NSScroller on Mac to be
developed side by side with the current one.
The new scroller paints a debug red if turned on (although due to
Widget issues you won't see anything paint yet).
Reviewed by olliej
* platform/Scrollbar.cpp:
* platform/Scrollbar.h:
* platform/mac/ScrollbarMac.h:
* platform/mac/ScrollbarMac.mm:
* platform/mac/ScrollbarThemeMac.cpp:
(WebCore::ScrollbarThemeMac::paint):
* platform/mac/ScrollbarThemeMac.h:
2008-09-16 Marco Barisione <marco.barisione@collabora.co.uk>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=20854
[GTK] Windows can be not realized in ScrollView::update
Do not call gdk_window_invalidate_rect on a non-realized GtkWidget.
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::update):
2008-09-16 Alp Toker <alp@nuanti.com>
Suggested by Dave Hyatt.
Build fix and cleanup. Rename ScrollBar to Scrollbar.
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* editing/EditorCommand.cpp:
* page/EventHandler.cpp:
* page/gtk/EventHandlerGtk.cpp:
* page/mac/EventHandlerMac.mm:
* page/mac/FrameMac.mm:
* page/qt/EventHandlerQt.cpp:
* page/wx/EventHandlerWx.cpp:
* platform/PopupMenu.h:
* platform/ScrollBar.cpp: Removed.
* platform/ScrollBar.h: Removed.
* platform/Scrollbar.cpp: Copied from WebCore/platform/ScrollBar.cpp.
* platform/Scrollbar.h: Copied from WebCore/platform/ScrollBar.h.
* platform/gtk/ScrollbarGtk.cpp:
(ScrollbarGtk::ScrollbarGtk):
* platform/gtk/ScrollbarGtk.h:
* platform/mac/ScrollbarMac.h:
* platform/qt/ScrollViewQt.cpp:
* platform/qt/ScrollbarQt.cpp:
* platform/qt/ScrollbarThemeQt.cpp:
* platform/win/PlatformScrollBar.h:
* platform/win/PopupMenuWin.cpp:
* platform/win/ScrollViewWin.cpp:
* platform/win/ScrollbarThemeWin.cpp:
* platform/wx/ScrollViewWx.cpp:
* platform/wx/TemporaryLinkStubs.cpp:
* rendering/HitTestResult.cpp:
* rendering/RenderLayer.cpp:
* rendering/RenderTextControl.cpp:
2008-09-16 David Hyatt <hyatt@apple.com>
Fix Qt build bustage by making moveThumb a member of Scrollbar so that
it can be called from ScrollbarQt.
* platform/ScrollBar.cpp:
(WebCore::Scrollbar::moveThumb):
(WebCore::Scrollbar::handleMouseMoveEvent):
(WebCore::Scrollbar::handleMousePressEvent):
* platform/ScrollBar.h:
* platform/qt/ScrollViewQt.cpp:
* platform/qt/ScrollbarQt.cpp:
(WebCore::Scrollbar::handleContextMenuEvent):
2008-09-16 David Hyatt <hyatt@apple.com>
Eliminate PlatformScrollbar. Mac and Gtk now have subclasses for their
native-widget scrollbars (ScrollbarMac and ScrollbarGtk). Other platforms
now just use Scrollbar.
Reviewed by Sam Weinig
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* page/mac/FrameMac.mm:
* platform/PopupMenu.h:
(WebCore::PopupMenu::scrollbar):
* platform/ScrollBar.cpp:
(WebCore::createNativeScrollbar):
* platform/ScrollBar.h:
* platform/gtk/PlatformScrollBar.h: Removed.
* platform/gtk/PlatformScrollBarGtk.cpp: Removed.
* platform/gtk/ScrollbarGtk.cpp: Copied from platform/gtk/PlatformScrollBarGtk.cpp.
(gtkScrollEventCallback):
(ScrollbarGtk::ScrollbarGtk):
(ScrollbarGtk::~ScrollbarGtk):
(ScrollbarGtk::updateThumbPosition):
(ScrollbarGtk::updateThumbProportion):
(ScrollbarGtk::setFrameGeometry):
(ScrollbarGtk::geometryChanged):
(ScrollbarGtk::gtkValueChanged):
* platform/gtk/ScrollbarGtk.h: Copied from platform/gtk/PlatformScrollBar.h.
* platform/mac/PlatformScrollBar.h: Removed.
* platform/mac/PlatformScrollBarMac.mm: Removed.
* platform/mac/ScrollbarMac.h: Copied from platform/mac/PlatformScrollBar.h.
* platform/mac/ScrollbarMac.mm: Copied from platform/mac/PlatformScrollBarMac.mm.
(-[WebCoreScrollBar initWithScrollbarMac:]):
(-[WebCoreScrollBar detachScrollbarMac]):
(WebCore::Scrollbar::createNativeScrollbar):
(WebCore::ScrollbarMac::ScrollbarMac):
(WebCore::ScrollbarMac::~ScrollbarMac):
(WebCore::ScrollbarMac::updateThumbPosition):
(WebCore::ScrollbarMac::updateThumbProportion):
(WebCore::ScrollbarMac::scrollbarHit):
* platform/qt/PlatformScrollBar.h: Removed.
* platform/qt/PlatformScrollBarQt.cpp: Removed.
* platform/qt/ScrollbarQt.cpp: Copied from platform/qt/PlatformScrollBarQt.cpp.
(WebCore::Scrollbar::handleContextMenuEvent):
* rendering/HitTestResult.cpp:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::createScrollbar):
(WebCore::RenderLayer::destroyScrollbar):
* rendering/RenderLayer.h:
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::~RenderListBox):
(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::isPointInOverflowControl):
* rendering/RenderObject.h:
* rendering/RenderTextControl.cpp:
2008-09-16 David Hyatt <hyatt@apple.com>
Make the scrollbar resizer-dodging logic cross-platform in the
Scrollbar class.
Reviewed by Sam Weinig
* platform/ScrollBar.cpp:
(WebCore::Scrollbar::setFrameGeometry):
(WebCore::Scrollbar::setParent):
(WebCore::Scrollbar::windowClipRect):
* platform/ScrollBar.h:
* platform/ScrollView.h:
(WebCore::ScrollView::windowResizerRect):
(WebCore::ScrollView::resizerOverlapsContent):
(WebCore::ScrollView::adjustOverlappingScrollbarCount):
* platform/Widget.h:
(WebCore::Widget::setParent):
* platform/mac/WidgetMac.mm:
(WebCore::Widget::convertToContainingWindow):
* platform/win/PlatformScrollBar.h:
* platform/win/PlatformScrollBarWin.cpp:
2008-09-16 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
- fix https://bugs.webkit.org/show_bug.cgi?id=15129
<rdar://problem/4644824> adding a new line with DOM does unnecessary additional repaint
Covered by fast/repaint/4776765.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock): Avoid repainting this object if it
did not have layout in the beginning.
(WebCore::RenderBlock::layoutBlockChildren): If a child did not have
layout in the beginning, repaint it in its new position, to compensate
for the above (regardless of whether it "moved").
* rendering/RenderObject.cpp:
(WebCore::RenderObject::checkForRepaintDuringLayout): Added a comment
about generalizing this fix in the future.
2008-09-16 Dan Bernstein <mitz@apple.com>
Reviewed by Dave Hyatt.
- fix https://bugs.webkit.org/show_bug.cgi?id=15384
Div does not notice when grandparent changes height
Test: fast/block/basic/quirk-percent-height-grandchild.html
- fix https://bugs.webkit.org/show_bug.cgi?id=20714
Resizing Gmail inbox vertically results in whitespace at the bottom of the window
Test: fast/replaced/percent-height-in-anonymous-block.html
Added a two-way mapping between boxes with percentage heights and
their non-parent ancestors up to the one the height is computed relative
to. In quirks mode (the first bug), this can be any number of containing
block with auto height. In strict mode (the second bug) this can be
the containing block of an anonymous block containing a replaced
element.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::~RenderBlock): Added code to remove the all the
mapping to/from this block to percentage-height descendants.
(WebCore::RenderBlock::layoutBlockChildren): Added code to mark
percentage-height descendants (and their containing block ancestry chain
up to this block) for layout. This ensures that those descendants whose
height depends on the height of this block (or an ancestor) are updated.
(WebCore::RenderBlock::addPercentHeightDescendant): Added. Establishes
a two-way mapping between this block and the given box.
(WebCore::RenderBlock::removePercentHeightDescendant): Added. Removes
all the mapping to/from this box.
* rendering/RenderBlock.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::setStyle): Added calls to
removePercentHeightDescendant() when style changes and the box
previously had a percentage height. An exception is when the style
change does not require layout, in which case the box still has
a percentage height and the mappings are valid. In all other cases,
any required mappings will be (re-)established during layout.
(WebCore::RenderBox::destroy): Added a call to
removePercentHeightDescendant.
(WebCore::RenderBox::calcPercentageHeight): Added code that, in quirks
mode, if a higher-than-parent containing block is affecting the box's
height, creates a mapping between the box and that block.
(WebCore::RenderBox::calcReplacedHeightUsing): Changed to skip over
anonymous containing blocks, if any, and when that happens, use
addPercentHeightDescendant() to ensure that the non-anonymous block
is aware of the dependent percent-height box.
2008-09-16 Dirk Schulze <vbs85@gmx.de>
Reviewed by Oliver Hunt and Alp Toker.
Implemented toDataURL in Cairo. Only PNG support
at the moment.
Qt, Cairo and wx require toDataURL implementations
https://bugs.webkit.org/show_bug.cgi?id=17719
* platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedImageMIMETypesForEncoding):
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::writeFunction):
(WebCore::ImageBuffer::toDataURL):
2008-09-16 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Hide unused media element controls in the QtWebKit port
* platform/qt/html4-adjustments-qt.css
2008-09-16 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon.
Fix compilation of the Qt scrollbar code.
* platform/qt/PlatformScrollBarQt.cpp:
(WebCore::scPart):
(WebCore::styleOptionSlider):
(WebCore::thumbLength):
(WebCore::pixelPosToRangeValue):
(WebCore::PlatformScrollbar::handleContextMenuEvent):
2008-09-16 Adam Treat <treat@kde.org>
Reviewed by Anders Carlsson.
Prevent accesses off of the end of the buffer introduced in r36450
and when checking for descriptions of mime. Also, coding style fix.
* plugins/qt/PluginPackageQt.cpp:
(WebCore::PluginPackage::fetchInfo):
2008-09-15 Rob Buis <buis@kde.org>
Reviewed by Eric.
https://bugs.webkit.org/show_bug.cgi?id=20634
SVG transform attribute is ignored by <use> in <clipPath>
Transform the paths with the local transform when part
of a clip path.
Test: svg/custom/use-clipped-transform.svg
* svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::canvasResource):
* svg/SVGStyledTransformableElement.cpp:
(WebCore::SVGStyledTransformableElement::toClipPath):
* svg/SVGStyledTransformableElement.h:
2008-09-15 Dave Hyatt <hyatt@apple.com>
Convert Qt over to its ScrollbarTheme. Add cross-platform support for jumping the thumb location directly
to a pressed location on the track (this is done with the middle mouse on Qt and with Shift-Click on Windows).
Reviewed by Sam Weinig
* platform/ScrollBar.cpp:
(WebCore::thumbUnderMouse):
(WebCore::Scrollbar::autoscrollPressedPart):
(WebCore::Scrollbar::startTimerIfNeeded):
(WebCore::moveThumb):
(WebCore::Scrollbar::handleMouseMoveEvent):
(WebCore::Scrollbar::handleMousePressEvent):
* platform/ScrollBar.h:
(WebCore::Scrollbar::pressedPos):
(WebCore::Scrollbar::pixelStep):
(WebCore::Scrollbar::setPressedPos):
* platform/ScrollbarTheme.h:
(WebCore::ScrollbarTheme::thumbPosition):
(WebCore::ScrollbarTheme::thumbLength):
(WebCore::ScrollbarTheme::trackPosition):
(WebCore::ScrollbarTheme::trackLength):
* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::trackPosition):
* platform/ScrollbarThemeComposite.h:
* platform/qt/PlatformScrollBarQt.cpp:
(WebCore::PlatformScrollbar::PlatformScrollbar):
(WebCore::):
* platform/qt/ScrollbarThemeQt.cpp:
(WebCore::styleOptionSlider):
(WebCore::ScrollbarThemeQt::hitTest):
(WebCore::ScrollbarThemeQt::shouldCenterOnThumb):
(WebCore::ScrollbarThemeQt::invalidatePart):
(WebCore::ScrollbarThemeQt::thumbPosition):
(WebCore::):
* platform/qt/ScrollbarThemeQt.h:
* platform/win/ScrollbarThemeSafari.cpp:
(WebCore::ScrollbarThemeSafari::shouldCenterOnThumb):
* platform/win/ScrollbarThemeSafari.h:
* platform/win/ScrollbarThemeWin.cpp:
(WebCore::ScrollbarThemeWin::shouldCenterOnThumb):
* platform/win/ScrollbarThemeWin.h:
2008-09-15 David Smith <catfish.man@gmail.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=20180
Cache the result of parsing the an+b expression in :nth-child(an+b). Roughly a 2x speedup for :nth-child on SlickSpeed.
* GNUmakefile.am: Add CSSNthSelector
* WebCore.pro: Add CSSNthSelector
* WebCore.vcproj/WebCore.vcproj: Add CSSNthSelector
* WebCore.xcodeproj/project.pbxproj: Add CSSNthSelector
* css/CSSGrammar.y: Create CSSNthSelectors instead of CSSSelectors for :nth-*
* css/CSSNthSelector.cpp: Added.
(WebCore::CSSNthSelector::parseNth): Moved from CSSStyleSelector and modified to cache
(WebCore::CSSNthSelector::matchNth): Moved from CSSStyleSelector and modified to use the cache
* css/CSSNthSelector.h: Added.
(WebCore::CSSNthSelector::CSSNthSelector):
(WebCore::CSSNthSelector::~CSSNthSelector):
* css/CSSParser.cpp:
(WebCore::CSSParser::createFloatingNthSelector):
* css/CSSParser.h:
* css/CSSSelector.h: Use the free bit here to store a flag for CSSNthSelector
(WebCore::CSSSelector::CSSSelector):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Take advantage of knowing that all :nth-* selectors are CSSNthSelectors
2008-09-15 Matt Lilek <webkit@mattlilek.com>
Reviewed by Tim Hatcher.
Clean up some inspector JS callbacks to remove an extra return.
* page/InspectorController.cpp:
(WebCore::hideDOMNodeHighlight):
(WebCore::loaded):
(WebCore::unloading):
(WebCore::attach):
(WebCore::detach):
(WebCore::startDebuggingAndReloadInspectedPage):
(WebCore::stopDebugging):
(WebCore::debuggerAttached):
(WebCore::pauseOnExceptions):
(WebCore::pauseInDebugger):
(WebCore::resumeDebugger):
(WebCore::stepOverStatementInDebugger):
(WebCore::stepIntoStatementInDebugger):
(WebCore::stepOutOfFunctionInDebugger):
(WebCore::isWindowVisible):
(WebCore::closeWindow):
2008-09-15 Dave Hyatt <hyatt@apple.com>
Completely switch Windows scrollbars over to ScrollbarTheme. The Aqua windows scrollbar and native scrollbar
now share most of their code.
Also removing mini size scrollbar support, since it would have crashed Windows had it ever been used, and it
also is never used in our code anyway.
Reviewed by Sam Weinig
* WebCore.vcproj/WebCore.vcproj:
* platform/ScrollTypes.h:
(WebCore::):
* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::splitTrack):
(WebCore::ScrollbarThemeComposite::thumbLength):
(WebCore::ScrollbarThemeComposite::minimumThumbLength):
* platform/ScrollbarThemeComposite.h:
* platform/mac/PlatformScrollBarMac.mm:
(NSControlSizeForScrollBarControlSize):
* platform/win/PlatformScrollBar.h:
* platform/win/PlatformScrollBarSafari.cpp: Removed.
* platform/win/PlatformScrollBarWin.cpp:
(WebCore::PlatformScrollbar::PlatformScrollbar):
* platform/win/ScrollbarThemeSafari.cpp:
(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::):
(WebCore::scrollbarControlStateFromThemeState):
(WebCore::ScrollbarThemeSafari::hasButtons):
(WebCore::ScrollbarThemeSafari::hasThumb):
(WebCore::buttonRepaintRect):
(WebCore::ScrollbarThemeSafari::backButtonRect):
(WebCore::ScrollbarThemeSafari::forwardButtonRect):
(WebCore::trackRepaintRect):
(WebCore::ScrollbarThemeSafari::trackRect):
(WebCore::ScrollbarThemeSafari::minimumThumbLength):
(WebCore::ScrollbarThemeSafari::paintTrack):
(WebCore::ScrollbarThemeSafari::paintButton):
(WebCore::ScrollbarThemeSafari::paintThumb):
* platform/win/ScrollbarThemeSafari.h:
* platform/win/ScrollbarThemeWin.cpp:
* platform/win/ScrollbarThemeWin.h:
2008-09-15 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler, Beth Dakin
<rdar://problem/4003789> Expose lists as AXList
<rdar://problem/5707399> VO: Definition lists not announced in Safari
Lists are now exposed through AX. On the mac (in SnowLeopard) they use two new subroles
AXContentList for <ul>, <ol> and AXDefinitionList for <dl>
Inside the definition list, each <dt> "term" has an accessibility description ("term"),
as does each <dd> tag ("definition")
Test: accessibility/lists.html
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* page/AXObjectCache.cpp:
* page/AccessibilityList.cpp: Added.
* page/AccessibilityList.h: Added.
* page/AccessibilityObject.h:
* page/AccessibilityRenderObject.cpp:
* page/AccessibilityTable.cpp:
* page/mac/AccessibilityObjectWrapper.mm:
* page/mac/WebCoreViewFactory.h:
* platform/LocalizedStrings.h:
* platform/mac/LocalizedStringsMac.mm:
* platform/qt/Localizations.cpp:
2008-09-15 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Eric.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=20865
Prepare HTMLScriptElement & SVGScriptElement unification, and unification of event handling.
Several renames:
dispatchHTMLEvent -> dispatchEventForType
setHTMLEventListener -> setEventListenerForType
getHTMLEventListener -> eventListenerForType
removeHTMLEventListener -> removeEventListenerForType
isHTMLEventListener -> isAttachedToEventTargetNode
...
Similar renames for the dispatch/get/set/*Window*Event functions.
Kill JSSVGLazyEventListener and merge with JSLazyEventListener.
Most important change: Rename setHTMLEventListener to setEventListenerForTypeAndAttribute,
as there exists a generic createEventListener() method now, taking care of JSLazyEventListener creation.
setHTMLEventListener() used createHTMLEventListener() before and was HTML specific.
SVG is able to use the code as well now. This affects most files in html/.
No functional changes.
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::~JSDOMWindowBase):
(WebCore::JSDOMWindowBase::setListener):
(WebCore::JSDOMWindowBase::getListener):
(WebCore::JSDOMWindowBase::findJSEventListener):
(WebCore::JSDOMWindowBase::findOrCreateJSEventListener):
(WebCore::JSDOMWindowBase::findJSUnprotectedEventListener):
(WebCore::JSDOMWindowBase::findOrCreateJSUnprotectedEventListener):
(WebCore::JSDOMWindowBase::jsEventListenersAttachedToEventTargetNodes):
(WebCore::JSDOMWindowBase::jsUnprotectedEventListenersAttachedToEventTargetNodes):
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSEventListener.cpp:
(WebCore::JSAbstractEventListener::handleEvent):
(WebCore::JSAbstractEventListener::isAttachedToEventTargetNode):
(WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener):
(WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener):
(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::~JSEventListener):
(WebCore::JSLazyEventListener::JSLazyEventListener):
(WebCore::eventParameterName):
(WebCore::JSLazyEventListener::parseCode):
(WebCore::getNodeEventListener):
* bindings/js/JSEventListener.h:
(WebCore::JSAbstractEventListener::JSAbstractEventListener):
(WebCore::JSUnprotectedEventListener::create):
(WebCore::JSEventListener::create):
(WebCore::JSLazyEventListener::):
(WebCore::JSLazyEventListener::create):
* bindings/js/JSEventTargetNode.cpp:
(WebCore::JSEventTargetNode::setListener):
(WebCore::JSEventTargetNode::getListener):
* bindings/js/JSSVGLazyEventListener.cpp: Removed.
* bindings/js/JSSVGLazyEventListener.h: Removed.
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::createHTMLEventHandler):
(WebCore::ScriptController::createSVGEventHandler):
* dom/Document.cpp:
(WebCore::Document::setFocusedNode):
(WebCore::Document::handleWindowEvent):
(WebCore::Document::setWindowEventListenerForType):
(WebCore::Document::windowEventListenerForType):
(WebCore::Document::removeWindowEventListenerForType):
(WebCore::Document::addWindowEventListener):
(WebCore::Document::hasWindowEventListener):
(WebCore::Document::removePendingFrameBeforeUnloadEventCount):
(WebCore::Document::createEventListener):
(WebCore::Document::setWindowEventListenerForTypeAndAttribute):
* dom/Document.h:
* dom/EventListener.h:
(WebCore::EventListener::isAttachedToEventTargetNode):
* dom/EventTargetNode.cpp:
(WebCore::EventTargetNode::dispatchFocusEvent):
(WebCore::EventTargetNode::dispatchBlurEvent):
(WebCore::EventTargetNode::dispatchEventForType):
(WebCore::EventTargetNode::removeEventListenerForType):
(WebCore::EventTargetNode::setEventListenerForType):
(WebCore::EventTargetNode::setEventListenerForTypeAndAttribute):
(WebCore::EventTargetNode::eventListenerForType):
* dom/EventTargetNode.h:
* dom/XMLTokenizer.cpp:
(WebCore::XMLTokenizer::notifyFinished):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::ReplacementFragment):
* html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::parseMappedAttribute):
* html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::parseMappedAttribute):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::parseMappedAttribute):
(WebCore::HTMLElement::checkDTD):
* html/HTMLElement.h:
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::onChange):
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::prepareSubmit):
(WebCore::HTMLFormElement::reset):
(WebCore::HTMLFormElement::parseMappedAttribute):
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::parseMappedAttribute):
* html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::parseMappedAttribute):
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseMappedAttribute):
* html/HTMLImageLoader.cpp:
(WebCore::HTMLImageLoader::dispatchLoadEvent):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseMappedAttribute):
(WebCore::HTMLInputElement::setValueFromRenderer):
(WebCore::HTMLInputElement::onSearch):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::asyncEventTimerFired):
(WebCore::HTMLMediaElement::load):
(WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::seek):
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::willSaveToCache):
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parseMappedAttribute):
* html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::parseMappedAttribute):
(WebCore::HTMLScriptElement::dispatchLoadEvent):
(WebCore::HTMLScriptElement::dispatchErrorEvent):
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::parseMappedAttribute):
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::parseMappedAttribute):
* html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::notifyFinished):
* page/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::mouseButtonListener):
* page/EventHandler.cpp:
(WebCore::EventHandler::canMouseDownStartSelect):
(WebCore::EventHandler::canMouseDragExtendSelect):
* page/Frame.cpp:
(WebCore::Frame::sendScrollEvent):
* page/Page.cpp:
(WebCore::networkStateChanged):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::valueChanged):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::selectionChanged):
* svg/SVGDocumentExtensions.cpp:
* svg/SVGDocumentExtensions.h:
* svg/SVGElement.cpp:
(WebCore::SVGElement::parseMappedAttribute):
(WebCore::SVGElement::finishParsingChildren):
* svg/SVGElement.h:
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::parseMappedAttribute):
* svg/SVGSVGElement.h:
2008-09-15 Dave Hyatt <hyatt@apple.com>
Convert PlatformScrollbarWin to use ScrollbarTheme for hit testing. PlatformScrollbarQt/Gtk still
need to be converted.
Reviewed by Sam Weinig
* platform/ScrollBar.cpp:
(WebCore::Scrollbar::Scrollbar):
(WebCore::Scrollbar::updateThumbPosition):
(WebCore::Scrollbar::updateThumbProportion):
(WebCore::Scrollbar::autoscrollPressedPart):
(WebCore::Scrollbar::startTimerIfNeeded):
* platform/ScrollBar.h:
* platform/ScrollbarTheme.h:
(WebCore::ScrollbarTheme::invalidateParts):
* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::hitTest):
(WebCore::ScrollbarThemeComposite::invalidatePart):
(WebCore::ScrollbarThemeComposite::thumbPosition):
(WebCore::ScrollbarThemeComposite::thumbLength):
(WebCore::ScrollbarThemeComposite::trackLength):
* platform/ScrollbarThemeComposite.h:
* platform/win/PlatformScrollBarSafari.cpp:
(WebCore::PlatformScrollbar::PlatformScrollbar):
* platform/win/PlatformScrollBarWin.cpp:
(WebCore::PlatformScrollbar::PlatformScrollbar):
2008-09-15 David Smith <catfish.man@gmail.com>
"Just do it"'d by Mark Rowe
https://bugs.webkit.org/show_bug.cgi?id=20856
Add missing license header
* dom/NodeRenderStyle.h:
2008-09-15 Dean Jackson <dino@apple.com>
Reviewed by Tim Hatcher.
Add default constructor for ShadowData
https://bugs.webkit.org/show_bug.cgi?id=20757
Test: transitions/shadow.html
* rendering/style/RenderStyle.h:
2008-09-15 Dean Jackson <dino@apple.com>
Reviewed by Tim Hatcher.
RenderStyle should update keyframes.
http://bugs.webkit.org/show_bug.cgi?id=20756
* rendering/style/RenderStyle.cpp:
(WebCore::StyleRareNonInheritedData::updateKeyframes):
2008-09-15 Dean Jackson <dino@apple.com>
Reviewed by Tim Hatcher.
Unnecessary ASSERT in ImplicitAnimation destructor.
https://bugs.webkit.org/show_bug.cgi?id=20817
* page/animation/ImplicitAnimation.cpp:
(WebCore::ImplicitAnimation::~ImplicitAnimation):
2008-09-15 Adam Treat <treat@kde.org>
Reviewed by Simon.
Fix plugin extension info. It was returning the mimetype where the
extension was given.
* plugins/qt/PluginPackageQt.cpp:
(WebCore::PluginPackage::fetchInfo):
2008-09-15 Dean Jackson <dino@apple.com>
Reviewed by Tim Hatcher
Coding style violation!!!! Cleanup AnimationBase.cpp
* page/animation/AnimationBase.cpp:
(WebCore::blendFunc):
2008-09-15 David Hyatt <hyatt@apple.com>
Move all hit testing code for scrollbars into the base class. Refactor
it to accommodate all platform-specific behaviors using virtual ScrollbarTheme
functions.
No platform is using this code yet. Although it has been moved and compiles
(even on Mac), it is not being used on any platform.
Reviewed by Sam Weinig
* platform/ScrollBar.cpp:
(WebCore::Scrollbar::autoscrollPressedPart):
(WebCore::Scrollbar::startTimerIfNeeded):
(WebCore::Scrollbar::handleMouseMoveEvent):
(WebCore::Scrollbar::handleMouseOutEvent):
(WebCore::Scrollbar::handleMouseReleaseEvent):
(WebCore::Scrollbar::handleMousePressEvent):
* platform/ScrollBar.h:
(WebCore::Scrollbar::handleContextMenuEvent):
* platform/ScrollbarTheme.h:
(WebCore::ScrollbarTheme::hitTest):
(WebCore::ScrollbarTheme::invalidateOnMouseEnterExit):
(WebCore::ScrollbarTheme::invalidatePart):
(WebCore::ScrollbarTheme::shouldCenterOnThumb):
(WebCore::ScrollbarTheme::centerOnThumb):
(WebCore::ScrollbarTheme::thumbPosition):
(WebCore::ScrollbarTheme::thumbLength):
(WebCore::ScrollbarTheme::trackLength):
(WebCore::ScrollbarTheme::initialAutoscrollTimerDelay):
(WebCore::ScrollbarTheme::autoscrollTimerDelay):
* platform/Widget.h:
(WebCore::Widget::parent):
* platform/mac/PlatformScrollBar.h:
(WebCore::PlatformScrollbar::handleMouseMoveEvent):
(WebCore::PlatformScrollbar::handleMouseOutEvent):
(WebCore::PlatformScrollbar::handleMousePressEvent):
(WebCore::PlatformScrollbar::handleMouseReleaseEvent):
* platform/mac/WidgetMac.mm:
(WebCore::Widget::convertFromContainingWindow):
* platform/win/ScrollbarThemeWin.cpp:
(WebCore::ScrollbarThemeWin::invalidateOnMouseEnterExit):
* platform/win/ScrollbarThemeWin.h:
2008-09-15 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig.
- fix <rdar://problem/5842247> Single long breakable word takes O(n^2) to lay out
Cache the next breakable position for text nodes in InlineIterator.
* rendering/bidi.cpp:
(WebCore::InlineIterator::InlineIterator):
(WebCore::InlineIterator::increment):
(WebCore::RenderBlock::findNextLineBreak):
2008-09-15 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein
Fix assertion and integral pixel issue when creating subimages.
https://bugs.webkit.org/show_bug.cgi?id=20786
* platform/graphics/cg/ImageCG.cpp:
(WebCore::BitmapImage::draw):
2008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Implment seek() and clean up and improve debugging output
* platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
(debugMediaObject):
(WebCore::MediaPlayerPrivate::seek):
(WebCore::MediaPlayerPrivate::setVolume):
(WebCore::MediaPlayerPrivate::setMuted):
(WebCore::MediaPlayerPrivate::updateStates):
(WebCore::MediaPlayerPrivate::naturalSize):
(WebCore::MediaPlayerPrivate::paint):
(WebCore::MediaPlayerPrivate::stateChanged):
(WebCore::MediaPlayerPrivate::tick):
2008-09-15 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Simon.
Remove bogus Q_ASSERTs from the MediaPlayer Phonon implementation
m_mediaObject, m_audioOutput, m_videoWidget get created in the
c'tor and will only be deleted in the c'tor. The Q_ASSERTs would
only check if we use the MediaPlayerPrivate after it has been deleted.
Acked-by: Tor Arne Vestbø <tavestbo@trolltech.com>
* platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
(WebCore::MediaPlayerPrivate::play):
(WebCore::MediaPlayerPrivate::setVolume):
(WebCore::MediaPlayerPrivate::updateStates):
2008-09-15 Anders Carlsson <andersca@apple.com>
Reviewed by Maciej.
<rdar://problem/6163988>
https://bugs.webkit.org/show_bug.cgi?id=20457
Canvas: createPattern crashes WebKit in WTF::RefPtr<WebCore::Image>::operator!() const + 9 with a 1D pattern
Check the width and height and throw an exception if any of them are 0.
* html/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::createPattern):
2008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Render media element controls with antialiasing enabled
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::paintMediaMuteButton):
(WebCore::RenderThemeQt::paintMediaPlayButton):
(WebCore::RenderThemeQt::paintMediaSliderTrack):
(WebCore::RenderThemeQt::paintMediaSliderThumb):
2008-09-15 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon.
Upon non fatal error, switch to the pause state (so that playback can continue)
* platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
(WebCore::MediaPlayerPrivate::updateStates):
2008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Don't set WTF_USE_JSC in WebCore.pro now that it's set in config.h
* WebCore.pro:
2008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Make QtInstance::create() private and fix caching
* bindings/js/ScriptControllerQt.cpp:
(WebCore::ScriptController::createScriptInstanceForWidget):
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtInstance::getQtInstance):
(JSC::Bindings::QtInstance::getRuntimeObject):
* bridge/qt/qt_instance.h:
(JSC::Bindings::QtInstance::create):
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertQVariantToValue):
(JSC::Bindings::QtConnectionObject::execute):
2008-09-15 David Smith <catfish.man@gmail.com>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=20180
>2x speedup on querySelector[All] with :nth-child by removing the collectRulesOnly argument on SelectorChecker.
With collectRulesOnly set to true (the default) an optimization is turned off, and no callers were intentionally leaving it true.
querySelector[All] assumed that the default was probably the right way to go, and so ended up being slow.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::SelectorChecker::SelectorChecker):
* css/CSSStyleSelector.h:
2008-09-14 Dave Hyatt <hyatt@apple.com>
Refactor PlatformScrollbarWin's painting so that it is now done by ScrollbarThemeWin. PlatformScrollbarSafari
is still painting itself (a subsequent patch will move its painting into ScrollbarThemeSafari).
Reviewed by Sam Weinig
* platform/ScrollBar.h:
(WebCore::Scrollbar::client):
(WebCore::Scrollbar::currentPos):
(WebCore::Scrollbar::totalSize):
* platform/ScrollbarTheme.h:
* platform/ScrollbarThemeComposite.cpp:
(WebCore::pageForScrollView):
(WebCore::ScrollbarThemeComposite::paint):
* platform/ScrollbarThemeComposite.h:
(WebCore::ScrollbarThemeComposite::trackIsSinglePiece):
* platform/win/PlatformScrollBar.h:
* platform/win/PlatformScrollBarSafari.cpp:
* platform/win/PlatformScrollBarWin.cpp:
* platform/win/ScrollbarThemeSafari.h:
(WebCore::ScrollbarThemeSafari::hasButtons):
(WebCore::ScrollbarThemeSafari::hasThumb):
(WebCore::ScrollbarThemeSafari::backButtonRect):
(WebCore::ScrollbarThemeSafari::forwardButtonRect):
(WebCore::ScrollbarThemeSafari::trackRect):
(WebCore::ScrollbarThemeSafari::splitTrack):
(WebCore::ScrollbarThemeSafari::paintTrack):
(WebCore::ScrollbarThemeSafari::paintButton):
(WebCore::ScrollbarThemeSafari::paintThumb):
* platform/win/ScrollbarThemeWin.cpp:
(WebCore::isRunningOnVistaOrLater):
(WebCore::checkAndInitScrollbarTheme):
(WebCore::ScrollbarThemeWin::ScrollbarThemeWin):
(WebCore::ScrollbarThemeWin::themeChanged):
(WebCore::ScrollbarThemeWin::hasThumb):
(WebCore::ScrollbarThemeWin::backButtonRect):
(WebCore::ScrollbarThemeWin::forwardButtonRect):
(WebCore::ScrollbarThemeWin::trackRect):
(WebCore::ScrollbarThemeWin::splitTrack):
(WebCore::ScrollbarThemeWin::paintTrack):
(WebCore::ScrollbarThemeWin::paintButton):
(WebCore::gripperRect):
(WebCore::paintGripper):
(WebCore::ScrollbarThemeWin::paintThumb):
(WebCore::ScrollbarThemeWin::thumbPosition):
(WebCore::ScrollbarThemeWin::thumbLength):
(WebCore::ScrollbarThemeWin::trackLength):
* platform/win/ScrollbarThemeWin.h:
(WebCore::ScrollbarThemeWin::hasButtons):
(WebCore::ScrollbarThemeWin::trackIsSinglePiece):
2008-09-14 Anthony Ricaud <rik24d@gmail.com>
Moving all resource graphs under the same container for future scalable feature.
This is a speedup on resize but maybe a loss on changing the sorting function.
https://bugs.webkit.org/show_bug.cgi?id=20555
Reviewed by Timothy Hatcher.
* page/inspector/ResourcesPanel.js: Added a container for all resource graphs.
Added WebInspector.ResourceGraph. No more _updateGraphBars on resize.
* page/inspector/inspector.css: Edited corresponding rules and removed unnecessaries.
2008-09-14 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=20738
compareBoundaryPoints gives incorrect results
Test: fast/dom/Range/compareBoundaryPoints-2.html
* dom/Range.cpp: (WebCore::Range::compareBoundaryPoints): Correct meanings of START_TO_END
and END_TO_START.
* page/DOMSelection.cpp: (WebCore::DOMSelection::addRange): Updated for this change.
2008-09-14 Maciej Stachowiak <mjs@apple.com>
Unreviewed build fix.
Trying again.
* bindings/js/JSQuarantinedObjectWrapper.cpp:
(WebCore::JSQuarantinedObjectWrapper::hasInstance):
2008-09-14 Maciej Stachowiak <mjs@apple.com>
Unreviewed build fix.
Blind attempt to fix build. Correct parameters for hasInstance.
* bindings/js/JSQuarantinedObjectWrapper.cpp:
(WebCore::JSQuarantinedObjectWrapper::hasInstance):
* bindings/js/JSQuarantinedObjectWrapper.h:
2008-09-14 Dan Bernstein <mitz@apple.com>
Rubber-stamped by Sam Weinig.
- revert <http://trac.webkit.org/changeset/36382> because it exposed
<https://bugs.webkit.org/show_bug.cgi?id=20846> and resulted in crashes
on Tiger.
* platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getLastResortFallbackFont):
2008-09-14 Dave Hyatt <hyatt@apple.com>
Add a new ScrollbarThemeComposite base class that is shared by ScrollbarThemeSafari and
ScrollbarThemeWin. Any scrollbar that wants to render by ScrollbarPart can subclass from this
theme.
Reviewed by Sam Weinig
* WebCore.vcproj/WebCore.vcproj:
* platform/win/ScrollbarThemeSafari.h:
* platform/win/ScrollbarThemeWin.h:
2008-09-14 Alp Toker <alp@nuanti.com>
https://bugs.webkit.org/show_bug.cgi?id=20320
[GTK] A white rectangle is visible behind widgets with rounded corners
Sync bundled gtk2drawing.c to the latest version from Mozilla (coding
style exempt).
Requested by Michael Monreal.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::RenderThemeGtk):
* platform/gtk/gtk2drawing.c:
(moz_gtk_set_widget_name):
(ensure_window_widget):
(setup_widget_prototype):
(ensure_button_arrow_widget):
(moz_gtk_get_combo_box_inner_button):
(moz_gtk_get_combo_box_button_inner_widgets):
(ensure_combo_box_widgets):
(moz_gtk_get_combo_box_entry_inner_widgets):
(moz_gtk_get_combo_box_entry_arrow):
(ensure_combo_box_entry_widgets):
(ensure_toolbar_widget):
(ensure_tooltip_widget):
(ensure_menu_bar_widget):
(ensure_menu_bar_item_widget):
(ensure_menu_popup_widget):
(ensure_menu_item_widget):
(ensure_image_menu_item_widget):
(ensure_menu_separator_widget):
(ensure_check_menu_item_widget):
(ensure_tree_header_cell_widget):
(ensure_scrolled_window_widget):
(moz_gtk_button_paint):
(moz_gtk_init):
(moz_gtk_button_get_inner_border):
(moz_gtk_toggle_paint):
(calculate_button_inner_rect):
(calculate_arrow_rect):
(moz_gtk_scrollbar_button_paint):
(moz_gtk_scrollbar_thumb_paint):
(moz_gtk_caret_paint):
(moz_gtk_entry_paint):
(moz_gtk_treeview_paint):
(moz_gtk_tree_header_cell_paint):
(moz_gtk_combo_box_paint):
(moz_gtk_downarrow_paint):
(moz_gtk_combo_box_entry_button_paint):
(moz_gtk_toolbar_paint):
(moz_gtk_tab_scroll_arrow_paint):
(moz_gtk_menu_bar_paint):
(moz_gtk_menu_item_paint):
(moz_gtk_get_widget_border):
(moz_gtk_get_combo_box_entry_button_size):
(moz_gtk_get_tab_scroll_arrow_size):
(moz_gtk_get_downarrow_size):
(moz_gtk_images_in_menus):
(moz_gtk_widget_paint):
(moz_gtk_shutdown):
* platform/gtk/gtkdrawing.h:
2008-09-14 David Hyatt <hyatt@apple.com>
Convert Mac, Gtk, wx and Qt over to the new ScrollbarTheme for
painting. Mac and Gtk themes don't do anything and just let the
underlying widget paint. Qt now uses the theme to paint. wx doesn't
do anything yet.
Reviewed by Sam Weinig
* platform/ScrollBar.cpp:
(WebCore::Scrollbar::paint):
* platform/ScrollBar.h:
(WebCore::Scrollbar::value):
(WebCore::Scrollbar::visibleSize):
(WebCore::Scrollbar::maximum):
(WebCore::Scrollbar::lineStep):
(WebCore::Scrollbar::pageStep):
(WebCore::Scrollbar::pixelStep):
(WebCore::Scrollbar::pressedPart):
(WebCore::Scrollbar::hoveredPart):
(WebCore::Scrollbar::theme):
* platform/ScrollbarTheme.h:
(WebCore::ScrollbarTheme::paint):
(WebCore::ScrollbarTheme::scrollbarThickness):
(WebCore::ScrollbarTheme::supportsControlTints):
(WebCore::ScrollbarTheme::themeChanged):
* platform/gtk/PlatformScrollBar.h:
* platform/gtk/PlatformScrollBarGtk.cpp:
* platform/mac/PlatformScrollBar.h:
* platform/mac/PlatformScrollBarMac.mm:
* platform/qt/PlatformScrollBar.h:
* platform/qt/PlatformScrollBarQt.cpp:
* platform/qt/ScrollbarThemeQt.cpp:
(WebCore::styleOptionSlider):
* platform/qt/ScrollbarThemeQt.h:
(WebCore::ScrollbarThemeQt::paint):
* platform/win/PlatformScrollBarSafari.cpp:
(WebCore::PlatformScrollbar::paint):
* platform/win/ScrollbarThemeSafari.h:
(WebCore::ScrollbarThemeSafari::supportsControlTints):
* platform/wx/PlatformScrollBar.h:
* platform/wx/TemporaryLinkStubs.cpp:
(PlatformScrollbar::~PlatformScrollbar):
2008-09-14 Sam Weinig <sam@webkit.org>
Qt build fix.
* platform/qt/PlatformScrollBarQt.cpp:
2008-09-14 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Remove extraneous semicolons.
* bindings/scripts/CodeGeneratorObjC.pm:
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::tokenizeRelAttribute):
* html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::charsetAttributeValue):
(WebCore::HTMLScriptElement::typeAttributeValue):
* platform/graphics/qt/GradientQt.cpp:
(WebCore::Gradient::platformGradient):
* platform/qt/ScrollViewQt.cpp:
(WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
* platform/win/ScrollViewWin.cpp:
(WebCore::ScrollView::updateScrollbars):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintEllipsisBoxes):
* svg/SVGPathSegList.cpp:
(WebCore::SVGPathSegList::toPathData):
2008-09-14 Sam Weinig <sam@webkit.org>
Qt build fix.
* platform/qt/ScrollViewQt.cpp:
(WebCore::ScrollView::updateScrollbars):
2008-09-14 Sam Weinig <sam@webkit.org>
Qt build fix.
* platform/qt/PlatformScrollBarQt.cpp:
(WebCore::PlatformScrollbar::PlatformScrollbar):
(WebCore::PlatformScrollbar::paint):
2008-09-13 Jan Michael Alonzo <jmalonzo@webkit.org>
Gtk build fix, not reviewed.
* platform/gtk/PlatformScrollBarGtk.cpp:
(PlatformScrollbar::PlatformScrollbar):
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::updateScrollbars):
2008-09-13 Dave Hyatt <hyatt@apple.com>
Remove scrollbar's setRect method. Clients can now just call setFrameGeometry (the corresponding Widget) method
to set the dimensions of a scrollbar.
Reviewed by Sam Weinig
* platform/ScrollBar.h:
* platform/gtk/PlatformScrollBar.h:
* platform/gtk/PlatformScrollBarGtk.cpp:
(PlatformScrollbar::setFrameGeometry):
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::updateScrollbars):
* platform/mac/PlatformScrollBarMac.mm:
* platform/qt/PlatformScrollBarQt.cpp:
* platform/qt/ScrollViewQt.cpp:
(WebCore::ScrollView::updateScrollbars):
* platform/win/PlatformScrollBar.h:
* platform/win/PlatformScrollBarSafari.cpp:
(WebCore::PlatformScrollbar::PlatformScrollbar):
(WebCore::PlatformScrollbar::setFrameGeometry):
* platform/win/PlatformScrollBarWin.cpp:
(WebCore::PlatformScrollbar::PlatformScrollbar):
(WebCore::PlatformScrollbar::setFrameGeometry):
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupWndProc):
* platform/win/ScrollViewWin.cpp:
(WebCore::ScrollView::updateScrollbars):
* platform/wx/PlatformScrollBar.h:
* platform/wx/TemporaryLinkStubs.cpp:
(PlatformScrollbar::updateThumbProportion):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::positionOverflowControls):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::paintScrollbar):
2008-09-13 Dave Hyatt <hyatt@apple.com>
Remove setEnabled() from all Scrollbar classes that were just using their Widget base class methods.
Reviewed by Sam Weinig
* platform/ScrollBar.h:
* platform/gtk/PlatformScrollBar.h:
* platform/gtk/PlatformScrollBarGtk.cpp:
* platform/mac/PlatformScrollBar.h:
* platform/mac/PlatformScrollBarMac.mm:
* platform/win/PlatformScrollBar.h:
* platform/win/PlatformScrollBarSafari.cpp:
* platform/win/PlatformScrollBarWin.cpp:
* platform/wx/PlatformScrollBar.h:
* platform/wx/TemporaryLinkStubs.cpp:
(PlatformScrollbar::~PlatformScrollbar):
2008-09-13 Dave Hyatt <hyatt@apple.com>
Remove width()/height() from Scrollbar now that it derives from Widget. Remove width()/height() from
all PlatformScrollbar subclasses that just called the Widget base class versions of those methods.
Reviewed by Sam Weinig
* platform/ScrollBar.h:
* platform/gtk/PlatformScrollBar.h:
* platform/gtk/PlatformScrollBarGtk.cpp:
* platform/mac/PlatformScrollBar.h:
* platform/mac/PlatformScrollBarMac.mm:
* platform/win/PlatformScrollBarSafari.cpp:
* platform/win/PlatformScrollBarWin.cpp:
* platform/wx/PlatformScrollBar.h:
* platform/wx/TemporaryLinkStubs.cpp:
(PlatformScrollbar::~PlatformScrollbar):
2008-09-13 Dave Hyatt <hyatt@apple.com>
Move stopTimerIfNeeded out of PlatformScrollbar destructors and into Scrollbar.
Reviewed by Sam Weinig
* platform/ScrollBar.cpp:
(WebCore::Scrollbar::~Scrollbar):
* platform/ScrollBar.h:
* platform/qt/PlatformScrollBarQt.cpp:
(WebCore::PlatformScrollbar::~PlatformScrollbar):
* platform/win/PlatformScrollBarSafari.cpp:
(WebCore::PlatformScrollbar::~PlatformScrollbar):
* platform/win/PlatformScrollBarWin.cpp:
(WebCore::PlatformScrollbar::~PlatformScrollbar):
2008-09-13 David Hyatt <hyatt@apple.com>
Move maximum() from Qt's PlatformScrollbar to be a cross-platform
function on Scrollbar. Fixes Qt build bustage.
Reviewed by Sam Weinig
* platform/ScrollBar.h:
(WebCore::Scrollbar::orientation):
(WebCore::Scrollbar::value):
(WebCore::Scrollbar::maximum):
* platform/qt/PlatformScrollBar.h:
2008-09-13 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig.
- use the LastResort font for missing glyphs instead of showing the
primary font's missing glyph
Test: platform/mac/fast/text/last-resort-font.html
* platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::getFontDataForCharacters): Changed to return the
last resort font if a substitute font cannot be found.
(WebCore::FontCache::getLastResortFallbackFont): Removed an outdated
comment (the user's preferred standard font is included in the search
thanks to code in FontCache::getFontData()) and changed to return the
LastResort font.
2008-09-13 Dave Hyatt <hyatt@apple.com>
This patch adds ScrollbarTheme to the build. ScrollbarTheme is similar to RenderTheme (but for
scrollbars only). For now ScrollbarTheme just handles returning the size of scrollbars. Subsequent
patches will move rendering and hit testing functionality into this class.
Implemented ScrollbarTheme subclasses for four ports (Mac, Win, Gtk, Qt). The wxWidgets port does not
implement scrollbars yet, so I added a temporary link stub to keep things compiling on wx.
Reviewed by Sam Weinig
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* platform/ScrollBar.cpp:
(WebCore::Scrollbar::Scrollbar):
* platform/ScrollBar.h:
* platform/ScrollbarTheme.h: Added.
(WebCore::ScrollbarTheme::~ScrollbarTheme):
(WebCore::ScrollbarTheme::scrollbarThickness):
(WebCore::ScrollbarTheme::themeChanged):
* platform/gtk/ScrollbarThemeGtk.cpp: Added.
(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::ScrollbarThemeGtk::~ScrollbarThemeGtk):
(WebCore::ScrollbarThemeGtk::scrollbarThickness):
* platform/gtk/ScrollbarThemeGtk.h: Added.
* platform/mac/PlatformScrollBar.h:
* platform/mac/ScrollbarThemeMac.cpp: Added.
(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::):
(WebCore::ScrollbarThemeMac::~ScrollbarThemeMac):
(WebCore::ScrollbarThemeMac::scrollbarThickness):
* platform/mac/ScrollbarThemeMac.h: Added.
* platform/qt/PlatformScrollBarQt.cpp:
* platform/qt/ScrollbarThemeQt.cpp: Added.
(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::ScrollbarThemeQt::~ScrollbarThemeQt):
(WebCore::ScrollbarThemeQt::scrollbarThickness):
* platform/qt/ScrollbarThemeQt.h: Added.
* platform/win/PlatformScrollBar.h:
* platform/win/PlatformScrollBarSafari.cpp:
* platform/win/PlatformScrollBarWin.cpp:
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::calculatePositionAndSize):
* platform/win/ScrollViewWin.cpp:
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::themeChanged):
* platform/win/ScrollbarThemeSafari.cpp: Added.
(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::):
(WebCore::ScrollbarThemeSafari::~ScrollbarThemeSafari):
(WebCore::ScrollbarThemeSafari::scrollbarThickness):
* platform/win/ScrollbarThemeSafari.h: Added.
* platform/win/ScrollbarThemeWin.cpp: Added.
(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::ScrollbarThemeWin::~ScrollbarThemeWin):
(WebCore::ScrollbarThemeWin::scrollbarThickness):
(WebCore::ScrollbarThemeWin::themeChanged):
* platform/win/ScrollbarThemeWin.h: Added.
* platform/wx/TemporaryLinkStubs.cpp:
(ScrollbarTheme::nativeTheme):
* rendering/RenderLayer.cpp:
(WebCore::scrollCornerRect):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::calcHeight):
(WebCore::RenderTextControl::calcPrefWidths):
2008-09-13 Chris Fleizach <cfleizach@apple.com>
Reviewed by Timothy Hatcher.
<rdar://problem/5060439> Web elements should have an AXTopLevelUIElement
* page/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
2008-09-13 Dan Bernstein <mitz@apple.com>
Reviewed by Timothy Hatcher.
- fix <rdar://problem/6171280> REGRESSION (r35667): Assertion failure in WebCore::FrameView::scheduleRelayout() when releasing a page with counters from the b/f cache
No regression test because the back/forward cache is disabled in DumpRenderTree
* rendering/RenderContainer.cpp:
(WebCore::RenderContainer::invalidateCounters): Bail out if the document
is being destroyed.
2008-09-13 Kevin Ollivier <kevino@theolliviers.com>
wx build fixes for new methods recently introduced.
* platform/graphics/wx/AffineTransformWx.cpp:
(WebCore::AffineTransform::AffineTransform):
(WebCore::AffineTransform::setMatrix):
(WebCore::AffineTransform::setA):
(WebCore::AffineTransform::setB):
(WebCore::AffineTransform::setC):
(WebCore::AffineTransform::setD):
(WebCore::AffineTransform::setE):
(WebCore::AffineTransform::setF):
* platform/wx/LocalizedStringsWx.cpp:
(WebCore::AXDefinitionListTermText):
(WebCore::AXDefinitionListDefinitionText):
2008-09-12 Dave Hyatt <hyatt@apple.com>
Move the member variables of PlatformScrollbar up into Scrollbar. Move autoscroll timer handling
up into scrollbar. Make sure a bunch of cross-platform code now just uses "Scrollbar" instead of
"PlatformScrollbar."
Reviewed by Sam Weinig
* WebCore.vcproj/WebCore.vcproj:
* editing/EditorCommand.cpp:
* page/EventHandler.cpp:
(WebCore::EventHandler::selectCursor):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseMoveEvent):
* page/EventHandler.h:
* page/MouseEventWithHitTestResults.cpp:
(WebCore::MouseEventWithHitTestResults::scrollbar):
* page/MouseEventWithHitTestResults.h:
* page/gtk/EventHandlerGtk.cpp:
(WebCore::EventHandler::passMousePressEventToScrollbar):
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passMousePressEventToScrollbar):
* page/qt/EventHandlerQt.cpp:
(WebCore::EventHandler::passMousePressEventToScrollbar):
* page/win/EventHandlerWin.cpp:
(WebCore::EventHandler::passMousePressEventToScrollbar):
* page/wx/EventHandlerWx.cpp:
(WebCore::EventHandler::passMousePressEventToScrollbar):
* platform/PopupMenu.h:
* platform/ScrollBar.cpp:
(WebCore::Scrollbar::Scrollbar):
(WebCore::Scrollbar::autoscrollTimerFired):
(WebCore::Scrollbar::autoscrollPressedPart):
(WebCore::Scrollbar::startTimerIfNeeded):
(WebCore::Scrollbar::stopTimerIfNeeded):
(WebCore::Scrollbar::pressedPartScrollDirection):
(WebCore::Scrollbar::pressedPartScrollGranularity):
* platform/ScrollBar.h:
(WebCore::Scrollbar::handleMousePressEvent):
(WebCore::Scrollbar::invalidatePart):
(WebCore::Scrollbar::thumbUnderMouse):
* platform/ScrollView.h:
* platform/ScrollbarClient.h: Added.
(WebCore::ScrollbarClient::~ScrollbarClient):
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::scrollbarUnderMouse):
* platform/qt/PlatformScrollBar.h:
* platform/qt/PlatformScrollBarQt.cpp:
(WebCore::PlatformScrollbar::PlatformScrollbar):
(WebCore::scrollbarPart):
(WebCore::PlatformScrollbar::handleMouseMoveEvent):
(WebCore::PlatformScrollbar::handleMouseOutEvent):
(WebCore::PlatformScrollbar::handleMousePressEvent):
(WebCore::PlatformScrollbar::handleMouseReleaseEvent):
* platform/qt/ScrollViewQt.cpp:
(WebCore::ScrollView::scrollbarUnderMouse):
(WebCore::ScrollView::wheelEvent):
* platform/win/PlatformScrollBar.h:
* platform/win/PlatformScrollBarSafari.cpp:
(WebCore::PlatformScrollbar::PlatformScrollbar):
* platform/win/PlatformScrollBarWin.cpp:
(WebCore::PlatformScrollbar::PlatformScrollbar):
* platform/win/ScrollViewWin.cpp:
(WebCore::ScrollView::scrollbarUnderMouse):
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::setScrollbar):
* rendering/HitTestResult.h:
(WebCore::HitTestResult::scrollbar):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTestOverflowControls):
* rendering/RenderLayer.h:
* rendering/RenderListBox.h:
2008-09-12 Steve Falkenburg <sfalken@apple.com>
Fix Mac build.
* css/CSSStyleSelector.cpp:
(WebCore::getTransformOperationType):
2008-09-12 Chris Marrin <cmarrin@apple.com>
Reviewed by Dave Hyatt.
Make transform animation behavior match spec
https://bugs.webkit.org/show_bug.cgi?id=20770
Tests: transitions/transform-op-list-match.html
transitions/transform-op-list-no-match.html
* css/CSSStyleSelector.cpp:
* css/CSSStyleSelector.h:
* page/animation/AnimationBase.cpp:
* page/animation/AnimationBase.h:
* page/animation/ImplicitAnimation.cpp:
* page/animation/ImplicitAnimation.h:
* page/animation/KeyframeAnimation.cpp:
* page/animation/KeyframeAnimation.h:
* rendering/RenderLayer.cpp:
* rendering/style/RenderStyle.cpp:
* rendering/style/RenderStyle.h:
2008-09-12 Ojan Vafai <ojan@chromium.org>
Properly escape contents of links added to the inspector.
For now, just build the link with the DOM and get the
outerHTML. Eventually, we probably just want to do
this entirely with the DOM.
Reviewed by Timothy Hatcher.
https://bugs.webkit.org/show_bug.cgi?id=20684
* manual-tests/inspector/escape-links.html: Added.
* page/inspector/StylesSidebarPane.js:
* page/inspector/inspector.js:
* page/inspector/utilities.js:
2008-09-12 Adele Peterson <adele@apple.com>
Reviewed by John Sullivan and Kevin McCullough.
Fix for <rdar://problem/6216951> REGRESSION (r36000?): Crash due to infinite recursion into EventHandler::hitTestResultAtPoint() with disconnected frames
* page/EventHandler.cpp: (WebCore::EventHandler::hitTestResultAtPoint):
Hit testing again on the main frame will only work if we aren't already on the main frame. If we are already on the main frame, that will
cause infinite recursion. This change checks that we're not already on the main frame before hit testing again.
2008-09-12 Kevin McCullough <kmccullough@apple.com>
RS by Tim .
Re-introducing the code since it was not the cause of the crash.
See r36343.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::canBeProgramaticallyScrolled):
* rendering/RenderObject.h:
2008-09-12 Chris Marrin <cmarrin@apple.com>
Reviewed by Dave Hyatt.
When changing one animation in a list, don't reset other animations
https://bugs.webkit.org/show_bug.cgi?id=20675
Test: animations/change-one-anim.html
* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::getNumProperties):
* page/animation/AnimationBase.h:
* page/animation/AnimationController.cpp:
* page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::updateKeyframeAnimations):
* page/animation/CompositeAnimation.h:
* page/animation/ImplicitAnimation.cpp:
* page/animation/KeyframeAnimation.cpp:
* page/animation/KeyframeAnimation.h:
(WebCore::KeyframeAnimation::setIndex):
2008-09-12 Brady Eidson <beidson@apple.com>
Reviewed by Mitz Pettel
Fix the ASSERT and failure in webarchive/archive-empty-frame-source.html
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::mainResource): Further restoration of original WebArchive behavior.
Subresources can never be created from nil data, but there is always a MainResource, whether
or not there's any data. So in the case where the main resource has no data, fake it for the
sake of creating the ArchiveResource.
2008-09-12 Dave Hyatt <hyatt@apple.com>
Preparation for major scrollbar rearchitecture. Eliminate the concept of non-widget based
scrollbars (which we never supported anyway). Make Scrollbar derive from Widget directly.
Remove all the isWidget and hasPlatformScrollbars guards.
Reviewed by Tim Hatcher
* platform/ScrollBar.h:
* platform/gtk/PlatformScrollBar.h:
* platform/mac/PlatformScrollBar.h:
* platform/qt/PlatformScrollBar.h:
* platform/win/PlatformScrollBar.h:
* platform/win/ScrollViewWin.cpp:
(WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
(WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar):
* platform/wx/PlatformScrollBar.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::horizontalScrollbarWidget):
(WebCore::RenderLayer::verticalScrollbarWidget):
(WebCore::RenderLayer::createScrollbar):
(WebCore::RenderLayer::destroyScrollbar):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::~RenderListBox):
(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::isPointInOverflowControl):
2008-09-12 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig.
- https://bugs.webkit.org/show_bug.cgi?id=20793 clean up page/animation
* page/animation/AnimationController.cpp:
* page/animation/AnimationController.h:
* page/animation/CompositeAnimation.cpp:
* page/animation/CompositeAnimation.h:
* page/animation/ImplicitAnimation.cpp:
* page/animation/ImplicitAnimation.h:
* page/animation/KeyframeAnimation.cpp:
* page/animation/KeyframeAnimation.h:
2008-09-11 Timothy Hatcher <timothy@apple.com>
Add a renderedImage method to DOMNode to get an image
of the rendering for the node and it's descendants.
<rdar://problem/5849349> Would like API to create
an image for a DOM node
Reviewed by Oliver Hunt.
* bindings/objc/DOM.mm:
(-[DOMNode renderedImage]): Call Frame::nodeImage.
* bindings/objc/DOMPrivate.h:
* page/Frame.h:
* page/mac/FrameMac.mm:
(WebCore::Frame::nodeImage):
2008-09-08 Chris Marrin <cmarrin@apple.com>
Reviewed by Dave Hyatt
Need to support comma separated list of key times in keyframes selectors
https://bugs.webkit.org/show_bug.cgi?id=20680
Test: animations/keyframes-comma-separated.html
* css/CSSGrammar.y:
* css/CSSParser.cpp:
(WebCore::CSSParser::createKeyframeRule):
* css/CSSParser.h:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::addKeyframeStyle):
* css/WebKitCSSKeyframeRule.cpp:
(WebCore::WebKitCSSKeyframeRule::WebKitCSSKeyframeRule):
(WebCore::WebKitCSSKeyframeRule::cssText):
(WebCore::WebKitCSSKeyframeRule::parseKeyString):
* css/WebKitCSSKeyframeRule.h:
(WebCore::WebKitCSSKeyframeRule::keyText):
(WebCore::WebKitCSSKeyframeRule::setKeyText):
(WebCore::WebKitCSSKeyframeRule::getKeys):
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::WebKitCSSKeyframesRule::append):
(WebCore::WebKitCSSKeyframesRule::insertRule):
(WebCore::WebKitCSSKeyframesRule::deleteRule):
(WebCore::WebKitCSSKeyframesRule::findRule):
(WebCore::WebKitCSSKeyframesRule::findRuleIndex):
* css/WebKitCSSKeyframesRule.h:
* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::blendProperties):
2008-09-11 Kevin McCullough <kmccullough@apple.com>
RS by Tim.
Reverting because this caused a crash.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::canBeProgramaticallyScrolled):
(WebCore::RenderObject::hasScrollableView):
* rendering/RenderObject.h:
2008-09-11 Dean Jackson <dino@apple.com>
Reviewed by Dan Bernstein.
Fix assertion on transition property "none"
https://bugs.webkit.org/show_bug.cgi?id=20751
Test: transitions/transition-end-event-set-none.html
* page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::updateTransitions):
2008-09-11 David Smith <catfish.man@gmail.com>
Rubber-stamped by mitzpettel.
Remove an accidentally added extra file.
* WebCore: Removed.
2008-09-11 David Smith <catfish.man@gmail.com>
Reviewed by Darin
https://bugs.webkit.org/show_bug.cgi?id=20180
This speeds up :nth-child matching as tested by querySelectorAll by around 10% by inlining the common case of Node::renderStyle(). Many thanks to mitzpettel and othermaciej for suggestions and help.
* WebCore.xcodeproj/project.pbxproj: Add NodeRenderStyle.h
* css/CSSStyleSelector.cpp: include NodeRenderStyle.h
* dom/Element.cpp: include NodeRenderStyle.h
* dom/Node.cpp: Remove the definition of renderStyle()
(WebCore::Node::nonRendererRenderStyle):
* dom/Node.h: Make renderStyle() nonvirtual and add nonRendererRenderStyle()
* dom/NodeRenderStyle.h: Added.
(WebCore::Node::renderStyle): Inline the common case of this, call nonRendererRenderStyle for the part that needed to be virtual
* html/HTMLOptGroupElement.cpp: include NodeRenderStyle.h
* html/HTMLOptGroupElement.h:
(WebCore::HTMLOptGroupElement::nonRendererRenderStyle): override to return m_style
* html/HTMLOptionElement.cpp: include NodeRenderStyle.h
* html/HTMLOptionElement.h:
(WebCore::HTMLOptionElement::nonRendererRenderStyle): override to return m_style
* rendering/RenderListBox.cpp: include NodeRenderStyle.h
* rendering/RenderMenuList.cpp: include NodeRenderStyle.h
* svg/SVGUseElement.cpp: include NodeRenderStyle.h
2008-09-11 Kevin McCullough <kmccullough@apple.com>
Reviewed by Adele and Tim.
<rdar://problem/6100597> REGRESSION: clicking on search results in Web
Inspector does not scroll to the line of the results (20167)
- This was put in by Max to fix auto scrolling but is not correct for
the whole web: rdar://problem/6213098
* rendering/RenderObject.cpp:
(WebCore::RenderObject::canBeProgramaticallyScrolled):
* rendering/RenderObject.h:
2008-09-11 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin
<rdar://problem/6210511> AX: if a frame has a title, that should be reported as the AXWebArea's title
Test: accessibility/frame-with-title.html
* page/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityDescription):
2008-09-11 Dirk Schulze <vbs85@gmx.de>
Reviewed by Simon.
Fixed stroke() and strokeRect() to support gradients
and patterns on Qt.
[Qt] Canvas stroke don't work for gradients and patterns
[https://bugs.webkit.org/show_bug.cgi?id=20749]
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::strokeRect):
2008-09-11 Dirk Schulze <vbs85@gmx.de>
Reviewed by Simon.
https://bugs.webkit.org/show_bug.cgi?id=20729
Fixed canvas gradients for Qt
[Qt] Canvas gradients don't work as expected
[https://bugs.webkit.org/show_bug.cgi?id=20729]
* platform/graphics/qt/GradientQt.cpp:
(WebCore::Gradient::platformGradient):
2008-09-11 Dirk Schulze <vbs85@gmx.de>
Reviewed by Simon.
https://bugs.webkit.org/show_bug.cgi?id=20568
Add support for patterns to Qt.
* platform/graphics/qt/PatternQt.cpp:
(WebCore::Pattern::createPlatformPattern):
2008-09-10 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig.
- clean up AnimationBase
* page/animation/AnimationBase.cpp:
* page/animation/AnimationBase.h:
* page/animation/CompositeAnimation.cpp:
* page/animation/ImplicitAnimation.cpp:
* page/animation/ImplicitAnimation.h:
* page/animation/KeyframeAnimation.cpp:
* page/animation/KeyframeAnimation.h:
2008-09-10 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=20741
REGRESSION: ISO-8859-8-I encoding is registered incorrectly
Turns out that there were no real behavior changes for 8859-8, as it was only a debug-only
check to ignore this specific registration that was failing. Yet, I decided to add a bunch of
tests for ISO-8859-8 encoding aliases, as we handle them in a quite complicated manner.
I also found and fixed a potential crasher for non-Mac ports.
Tests: fast/encoding/hebrew/8859-8-e.html
fast/encoding/hebrew/8859-8-i.html
fast/encoding/hebrew/8859-8.html
fast/encoding/hebrew/csISO88598I.html
fast/encoding/hebrew/hebrew.html
fast/encoding/hebrew/iso-ir-138.html
fast/encoding/hebrew/logical.html
* platform/text/TextEncodingRegistry.cpp: (WebCore::checkExistingName): Check for iso-8859-8
(case-insensitively, because different versions of ICU report this MIME name in different
case).
* platform/text/TextCodecICU.cpp:
(WebCore::TextCodecICU::registerExtendedEncodingNames): Updated some comments.
(WebCore::TextCodecICU::registerExtendedCodecs): Try both MIME and IANA names here, too.
There are four names in ICU that only have MIME names (x-mac-* ones), so we could end up
with an encoding map entry, but no codec for these. This was not an issue on the Mac, as
we also support these via TEC (which we should stop doing), but on Windows, this would
likely crash.
2008-09-09 Dave Hyatt <hyatt@apple.com
Resurrect PlatformScrollbarWin.
Reviewed by Adam Roben
* WebCore.vcproj/WebCore.vcproj:
* platform/win/PlatformScrollBarWin.cpp:
(WebCore::isRunningOnVistaOrLater):
(WebCore::checkAndInitScrollbarTheme):
(WebCore::PlatformScrollbar::PlatformScrollbar):
(WebCore::PlatformScrollbar::invalidateTrack):
(WebCore::PlatformScrollbar::invalidatePart):
(WebCore::PlatformScrollbar::paint):
(WebCore::PlatformScrollbar::hasButtons):
(WebCore::PlatformScrollbar::hasThumb):
(WebCore::PlatformScrollbar::backButtonRect):
(WebCore::PlatformScrollbar::forwardButtonRect):
(WebCore::PlatformScrollbar::trackRect):
(WebCore::PlatformScrollbar::gripperRect):
(WebCore::PlatformScrollbar::thumbLength):
(WebCore::PlatformScrollbar::paintButton):
(WebCore::PlatformScrollbar::paintTrack):
(WebCore::PlatformScrollbar::paintThumb):
(WebCore::PlatformScrollbar::paintGripper):
(WebCore::PlatformScrollbar::hitTest):
(WebCore::PlatformScrollbar::handleMouseMoveEvent):
(WebCore::PlatformScrollbar::handleMouseOutEvent):
(WebCore::PlatformScrollbar::themeChanged):
2008-09-09 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej Stachowiak.
Bug 20759: Remove MacroAssembler
<https://bugs.webkit.org/show_bug.cgi?id=20759>
Make the necessary changes to ForwardingHeaders to remove
MacroAssembler.
* ForwardingHeaders/masm/IA32MacroAsm.h: Removed.
* ForwardingHeaders/masm/MacroAssembler.h: Removed.
* ForwardingHeaders/masm/X86Assembler.h: Added.
2008-09-09 Alp Toker <alp@nuanti.com>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=16792
[GTK] Fails to render Japanese/Chinese text with simple path
https://bugs.webkit.org/show_bug.cgi?id=16942
[GTK] Oddities in font selection and fall back
https://bugs.webkit.org/show_bug.cgi?id=16862
[GTK] Custom fonts hard-coded to use grayscale antialiasing and no hinting
GTK+ font fixes and enhancements.
Implement font fallback for the simple FontConfig-based text path and
improve the Pango-based complex text path to make use of requested
font properties and available font selection.
Add text shadow support to the complex path.
* platform/graphics/gtk/FontCacheGtk.cpp:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
* platform/graphics/gtk/FontGtk.cpp:
(WebCore::setPangoAttributes):
(WebCore::Font::drawComplexText):
(WebCore::getDefaultPangoLayout):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):
* platform/graphics/gtk/FontPlatformData.h:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::hash):
* platform/graphics/gtk/FontPlatformDataGtk.cpp:
(WebCore::FontPlatformData::FontPlatformData):
* platform/graphics/gtk/SimpleFontDataGtk.cpp:
(WebCore::SimpleFontData::platformDestroy):
2008-09-09 Dave Hyatt <hyatt@apple.com>
Make the Windows classic case work again. Overlap in slider constants and other constants broke
the push state for buttons and checkboxes. Make sure to check the RenderObject's appearance
value to make sure it's really a slider thumb to resolve this conflict.
Reviewed by Adam Roben
* rendering/RenderThemeWin.cpp:
(WebCore::drawControl):
2008-09-05 Chris Marrin <cmarrin@apple.com>
Reviewed by Sam Weinig.
Need to handle the case when 0% or 100% keyframe is omitted
https://bugs.webkit.org/show_bug.cgi?id=20679
Tests: animations/keyframes-from-missing.html
animations/keyframes-to-missing.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::addKeyframeStyle):
2008-09-09 Dave Hyatt <hyatt@apple.com>
Resurrect Safari's original RenderThemeWin and bring it up to date with ToT. Having a current
RenderThemeWin that does not have any Skia dependencies should provide a good basis for a potential
merge of Google Chrome's RenderThemeWin (to help us see where the Skia stuff can be cut and to see
what changes have been made as compared with the old RenderThemeWin).
Fix CSS2 system fonts to properly set both the rendering mode (so that they properly pick up GDI vs. CG
text rendering modes) and the printer font setting (so that OS X system fonts properly pick up screen
vs. printer advancement rounding).
Reviewed by Adam/Sam
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* platform/graphics/Icon.h:
(WebCore::Icon::create):
* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::RenderThemeWin):
(WebCore::RenderThemeWin::~RenderThemeWin):
(WebCore::RenderThemeWin::buttonTheme):
(WebCore::RenderThemeWin::textFieldTheme):
(WebCore::RenderThemeWin::menuListTheme):
(WebCore::RenderThemeWin::sliderTheme):
(WebCore::RenderThemeWin::close):
(WebCore::RenderThemeWin::themeChanged):
(WebCore::RenderThemeWin::supportsHover):
(WebCore::fillFontDescription):
(WebCore::RenderThemeWin::systemFont):
(WebCore::RenderThemeWin::supportsFocus):
(WebCore::RenderThemeWin::determineClassicState):
(WebCore::RenderThemeWin::determineState):
(WebCore::RenderThemeWin::determineSliderThumbState):
(WebCore::RenderThemeWin::getClassicThemeData):
(WebCore::RenderThemeWin::getThemeData):
(WebCore::drawControl):
(WebCore::RenderThemeWin::paintButton):
(WebCore::RenderThemeWin::paintTextField):
(WebCore::RenderThemeWin::paintMenuList):
(WebCore::RenderThemeWin::adjustMenuListStyle):
(WebCore::RenderThemeWin::adjustMenuListButtonStyle):
(WebCore::RenderThemeWin::paintMenuListButton):
(WebCore::RenderThemeWin::paintSliderTrack):
(WebCore::RenderThemeWin::paintSliderThumb):
(WebCore::RenderThemeWin::adjustSliderThumbSize):
(WebCore::RenderThemeWin::paintSearchField):
(WebCore::RenderThemeWin::adjustSearchFieldStyle):
(WebCore::RenderThemeWin::paintSearchFieldCancelButton):
(WebCore::RenderThemeWin::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeWin::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeWin::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeWin::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeWin::paintSearchFieldResultsButton):
* rendering/RenderThemeWin.h:
(WebCore::ThemeData::ThemeData):
(WebCore::RenderThemeWin::paintSearchFieldDecoration):
(WebCore::RenderThemeWin::adjustButtonStyle):
(WebCore::RenderThemeWin::adjustTextFieldStyle):
(WebCore::RenderThemeWin::adjustTextAreaStyle):
2008-09-09 Dean Jackson <dino@apple.com>
Reviewed by Sam Weinig.
Document::createEvent missing cases for animation and
transition events.
https://bugs.webkit.org/show_bug.cgi?id=20734
Test: transitions/transition-end-event-create.html
Test: animations/animation-events-create.html
* dom/Document.cpp:
(WebCore::Document::createEvent):
- add the two cases
2008-09-09 Dan Bernstein <mitz@apple.com>
- Tiger build fix
* WebCore.Tiger.exp:
* WebCore.base.exp:
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
2008-09-09 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
- WebCore part of <rdar://problem/6206244> Use alternate character-to-glyph interface on Leopard
* WebCore.Tiger.exp:
* WebCore.base.exp:
* platform/graphics/SimpleFontData.h:
* platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
(WebCore::GlyphPage::fill):
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::initFontData):
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformDestroy):
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
2008-09-09 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim.
<rdar://problem/6198545> REGRESSION: Inspector debugger barfs on
breakpoints inside eval.
* page/inspector/inspector.js:
2008-09-09 Joerg Bornemann <joerg.bornemann@trolltech.com>
Reviewed by Simon.
Fix compilation of the Qt port with disabled plugins on Windows
* WebCore.pro:
* plugins/PluginView.cpp:
(WebCore::PluginView::PluginView):
* plugins/PluginView.h:
2008-09-09 Jungshik Shin <jungshik.shin@gmail.com>
Reviewed by Alexey Proskuryakov.
Try MIME charset names before trying IANA names
( https://bugs.webkit.org/show_bug.cgi?id=17537 )
With this change, shorter and more widely used names (preferred MIME
names) are returned by document.charset, document.characterSet,
document.inputEncoding rather than IANA names. This helps
fixing bug 18085 in addition to web developers who are more familiar
with MIME names. For instance, EUC-JP, ISO-8859-X and US-ASCII will be
returned instead of Extended_UNIX_Code_Packed_Format_for_Japanese,
ISO-8859-X:19xx, and ANSI_X3.4-1968. It also replaces IBM8xx with cp8xx.
Note that cp/IBM 8xx are extremly rare in today's web. Even if they're
used, the former is still recognized as aliases to the latter so that
there's very little, if any, to worry about.
* platform/text/TextCodecICU.cpp:
(WebCore::TextCodecICU::registerExtendedEncodingNames):
2008-09-08 Sam Weinig <sam@webkit.org>
Reviewed by Maciej Stachowiak and Oliver Hunt.
Add forwarding headers.
* ForwardingHeaders/wtf/HashFunctions.h: Added.
2008-09-05 Dean Jackson <dino@apple.com>
Reviewed by Dan Bernstein.
Update grammar so that we can add a keyframe rule via the DOM.
https://bugs.webkit.org/show_bug.cgi?id=20613
* css/CSSGrammar.y:
* css/tokenizer.flex:
2008-09-08 Antti Koivisto <antti@apple.com>
Reviewed by Dan Bernstein.
Allow <br> for simple UA stylesheet. Editing code generates them. It does not
actually show up in any of the default stylesheets.
* css/CSSStyleSelector.cpp:
(WebCore::elementCanUseSimpleDefaultStyle):
2008-09-08 Dimitri Glazkov <dglazkov@google.com>
Reviewed by Dan Bernstein.
- fix https://bugs.webkit.org/show_bug.cgi?id=20237
Zero width and space characters are displayed incorrectly if not contained in a fallback font
Adds an extra check for Object Replacement Character (U+FFFC) to address
the issue with fast/text/zero-width-characters.html test when run
with Windows system default fonts.
* platform/graphics/Font.h:
(WebCore::Font::treatAsZeroWidthSpace):
2008-09-08 Dean Jackson <dino@apple.com>
Reviewed by Sam Weinig.
Code style issue I forgot to fix from previous commit.
* platform/graphics/AffineTransform.cpp:
(WebCore::AffineTransform::blend):
2008-09-08 Chris Marrin <cmarrin@apple.com>
Reviewed by Sam Weinig
- Animation of -webkit-transform matrix() function should not do linear interpolation
https://bugs.webkit.org/show_bug.cgi?id=20667
Test: animations/matrix-anim.html
* ChangeLog:
* platform/graphics/AffineTransform.cpp:
(WebCore::affineTransformDecompose):
(WebCore::affineTransformCompose):
(WebCore::AffineTransform::blend):
* platform/graphics/AffineTransform.h:
* rendering/style/RenderStyle.cpp:
(WebCore::MatrixTransformOperation::blend):
2008-09-08 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=20668
multipart/form-data does not always include Content-type for submitted files
Cannot be tested with DRT or manual tests.
* platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedNonImageMimeTypes): Fix spacing.
(WebCore::MIMETypeRegistry::getMIMETypeForPath): Default to application/octet-stream for
unknown extensions, not just missing ones.
2008-09-08 Simon Hausmann <hausmann@webkit.org>
Build fix for the Qt/Windows build, define USE_JSC to
enable the WebCore::String -> JSC::UString operator that
MSVC insists on seeing
* WebCore.pro:
2008-09-08 Anders Carlsson <andersca@apple.com>
Reviewed by Maciej.
<rdar://problem/5850387> Showing bookmarks reloads Google Reader instead.
In some cases, timeouts scheduled by a page in the onunload handler could fire even when the
page had been unloaded and replaced by a non-HTML representation based view (such as the bookmarks view).
Fix this by clearing timeouts for pages that aren't cached when the provisional load is committed.
* bindings/js/JSDOMWindowBase.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::commitProvisionalLoad):
2008-09-07 Antti Koivisto <antti@apple.com>
Reviewed by Dave Hyatt.
Don't leak the simple stylesheet.
Also call RenderTheme::adjustDefaultStyleSheet() in right place.
* css/CSSStyleSelector.cpp:
(WebCore::loadFullDefaultStyle):
(WebCore::loadSimpleDefaultStyle):
(WebCore::CSSStyleSelector::styleForElement):
2008-09-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Oliver Hunt.
Bug 20711: Change KJS prefix on preprocessor macros to JSC
<https://bugs.webkit.org/show_bug.cgi?id=20711>
* bindings/js/JSEventTargetBase.h:
* bindings/js/JSHTMLInputElementBase.cpp:
* bindings/js/JSHTMLInputElementBase.h:
* bindings/scripts/CodeGeneratorJS.pm:
2008-09-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej Stachowiak.
Bug 20704: Replace the KJS namespace
<https://bugs.webkit.org/show_bug.cgi?id=20704>
Rename the KJS namespace to JSC. There are still some uses of KJS in the
names of JNI functions, and I will check if these are safe to change
as well.
* WebCore.base.exp:
* bindings/js/GCController.cpp:
* bindings/js/JSAttrCustom.cpp:
* bindings/js/JSAudioConstructor.cpp:
* bindings/js/JSAudioConstructor.h:
(WebCore::JSAudioConstructor::classInfo):
* bindings/js/JSCSSRuleCustom.cpp:
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
* bindings/js/JSCSSValueCustom.cpp:
* bindings/js/JSCanvasPixelArrayCustom.cpp:
* bindings/js/JSCanvasRenderingContext2DCustom.cpp:
* bindings/js/JSClipboardCustom.cpp:
* bindings/js/JSConsoleCustom.cpp:
* bindings/js/JSCustomSQLStatementCallback.cpp:
(WebCore::JSCustomSQLStatementCallback::handleEvent):
* bindings/js/JSCustomSQLStatementCallback.h:
(WebCore::JSCustomSQLStatementCallback::create):
* bindings/js/JSCustomSQLStatementErrorCallback.cpp:
(WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
* bindings/js/JSCustomSQLStatementErrorCallback.h:
(WebCore::JSCustomSQLStatementErrorCallback::create):
* bindings/js/JSCustomSQLTransactionCallback.cpp:
(WebCore::JSCustomSQLTransactionCallback::handleEvent):
* bindings/js/JSCustomSQLTransactionCallback.h:
(WebCore::JSCustomSQLTransactionCallback::create):
* bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
(WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
* bindings/js/JSCustomSQLTransactionErrorCallback.h:
(WebCore::JSCustomSQLTransactionErrorCallback::create):
* bindings/js/JSCustomVoidCallback.cpp:
(WebCore::JSCustomVoidCallback::handleEvent):
* bindings/js/JSCustomVoidCallback.h:
(WebCore::JSCustomVoidCallback::create):
* bindings/js/JSCustomXPathNSResolver.cpp:
(WebCore::JSCustomXPathNSResolver::create):
* bindings/js/JSCustomXPathNSResolver.h:
* bindings/js/JSDOMApplicationCacheCustom.cpp:
(WebCore::JSDOMApplicationCache::dispatchEvent):
* bindings/js/JSDOMBinding.cpp:
(WebCore::jsOwnedStringOrNull):
* bindings/js/JSDOMBinding.h:
(WebCore::DOMObject::DOMObject):
(WebCore::cacheDOMObject):
(WebCore::cacheSVGDOMObject):
(WebCore::DOMExceptionTranslator::DOMExceptionTranslator):
(WebCore::toJS):
* bindings/js/JSDOMWindowBase.cpp:
* bindings/js/JSDOMWindowBase.h:
(WebCore::JSDOMWindowBase::classInfo):
(WebCore::JSDOMWindowBase::d):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::getPropertyAttributes):
* bindings/js/JSDOMWindowCustom.h:
(WebCore::asJSDOMWindow):
(WebCore::JSDOMWindow::customGetOwnPropertySlot):
(WebCore::JSDOMWindow::customPut):
(WebCore::JSDOMWindowBase::allowsAccessFrom):
(WebCore::JSDOMWindowBase::allowsAccessFromNoErrorMessage):
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::getPropertyAttributes):
* bindings/js/JSDOMWindowShell.h:
(WebCore::JSDOMWindowShell::classInfo):
* bindings/js/JSDatabaseCustom.cpp:
* bindings/js/JSDocumentCustom.cpp:
* bindings/js/JSDocumentFragmentCustom.cpp:
* bindings/js/JSElementCustom.cpp:
* bindings/js/JSEventCustom.cpp:
* bindings/js/JSEventListener.cpp:
* bindings/js/JSEventListener.h:
(WebCore::JSUnprotectedEventListener::create):
(WebCore::JSEventListener::create):
* bindings/js/JSEventTargetBase.cpp:
* bindings/js/JSEventTargetBase.h:
(WebCore::JSEventTargetBase::getValueProperty):
(WebCore::JSEventTargetBase::putValueProperty):
(WebCore::JSEventTargetBase::getOwnPropertySlot):
(WebCore::JSEventTargetBase::put):
(WebCore::JSEventTargetPrototype::JSEventTargetPrototype):
(WebCore::JSEventTargetPrototype::self):
(WebCore::JSEventTargetPrototype::getOwnPropertySlot):
(WebCore::JSEventTargetPrototype::classInfo):
* bindings/js/JSEventTargetNode.cpp:
* bindings/js/JSEventTargetNode.h:
(WebCore::JSEventTargetNode::getOwnPropertySlot):
(WebCore::JSEventTargetNode::getValueProperty):
(WebCore::JSEventTargetNode::put):
(WebCore::JSEventTargetNode::putValueProperty):
* bindings/js/JSHTMLAllCollection.h:
(WebCore::JSHTMLAllCollection::JSHTMLAllCollection):
(WebCore::JSHTMLAllCollection::toBoolean):
* bindings/js/JSHTMLAppletElementCustom.cpp:
* bindings/js/JSHTMLCollectionCustom.cpp:
* bindings/js/JSHTMLDocumentCustom.cpp:
* bindings/js/JSHTMLElementCustom.cpp:
* bindings/js/JSHTMLEmbedElementCustom.cpp:
* bindings/js/JSHTMLFormElementCustom.cpp:
* bindings/js/JSHTMLFrameElementCustom.cpp:
* bindings/js/JSHTMLFrameSetElementCustom.cpp:
* bindings/js/JSHTMLIFrameElementCustom.cpp:
* bindings/js/JSHTMLInputElementBase.cpp:
(WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase):
(WebCore::JSHTMLInputElementBase::getOwnPropertySlot):
* bindings/js/JSHTMLInputElementBase.h:
(WebCore::JSHTMLInputElementBase::classInfo):
* bindings/js/JSHTMLObjectElementCustom.cpp:
* bindings/js/JSHTMLOptionElementConstructor.cpp:
* bindings/js/JSHTMLOptionElementConstructor.h:
(WebCore::JSHTMLOptionElementConstructor::classInfo):
* bindings/js/JSHTMLOptionsCollectionCustom.cpp:
* bindings/js/JSHTMLSelectElementCustom.cpp:
(WebCore::selectIndexSetter):
(WebCore::JSHTMLSelectElement::indexSetter):
* bindings/js/JSHTMLSelectElementCustom.h:
* bindings/js/JSHistoryCustom.cpp:
* bindings/js/JSImageConstructor.cpp:
* bindings/js/JSImageConstructor.h:
(WebCore::JSImageConstructor::classInfo):
* bindings/js/JSInspectedObjectWrapper.cpp:
* bindings/js/JSInspectedObjectWrapper.h:
(WebCore::JSInspectedObjectWrapper::wrapOutgoingValue):
(WebCore::JSInspectedObjectWrapper::classInfo):
* bindings/js/JSInspectorCallbackWrapper.cpp:
* bindings/js/JSInspectorCallbackWrapper.h:
(WebCore::JSInspectorCallbackWrapper::classInfo):
(WebCore::JSInspectorCallbackWrapper::wrapOutgoingValue):
* bindings/js/JSJavaScriptCallFrameCustom.cpp:
* bindings/js/JSLocationCustom.cpp:
* bindings/js/JSMimeTypeArrayCustom.cpp:
* bindings/js/JSNSResolver.cpp:
* bindings/js/JSNSResolver.h:
(WebCore::JSNSResolver::create):
* bindings/js/JSNamedNodeMapCustom.cpp:
* bindings/js/JSNamedNodesCollection.cpp:
(WebCore::JSNamedNodesCollection::JSNamedNodesCollection):
* bindings/js/JSNamedNodesCollection.h:
(WebCore::JSNamedNodesCollection::classInfo):
* bindings/js/JSNavigatorCustom.cpp:
* bindings/js/JSNodeCustom.cpp:
* bindings/js/JSNodeFilterCondition.cpp:
(WebCore::JSNodeFilterCondition::acceptNode):
* bindings/js/JSNodeFilterCondition.h:
(WebCore::JSNodeFilterCondition::create):
* bindings/js/JSNodeFilterCustom.cpp:
* bindings/js/JSNodeIteratorCustom.cpp:
* bindings/js/JSNodeListCustom.cpp:
* bindings/js/JSPluginArrayCustom.cpp:
* bindings/js/JSPluginCustom.cpp:
* bindings/js/JSPluginElementFunctions.cpp:
(WebCore::getRuntimeObject):
* bindings/js/JSPluginElementFunctions.h:
* bindings/js/JSQuarantinedObjectWrapper.cpp:
(WebCore::JSQuarantinedObjectWrapper::construct):
(WebCore::JSQuarantinedObjectWrapper::call):
* bindings/js/JSQuarantinedObjectWrapper.h:
(WebCore::JSQuarantinedObjectWrapper::unwrappedObject):
(WebCore::JSQuarantinedObjectWrapper::unwrappedGlobalObject):
(WebCore::JSQuarantinedObjectWrapper::className):
* bindings/js/JSRGBColor.cpp:
* bindings/js/JSRGBColor.h:
(WebCore::JSRGBColor::classInfo):
* bindings/js/JSSQLResultSetRowListCustom.cpp:
* bindings/js/JSSQLTransactionCustom.cpp:
* bindings/js/JSSVGLazyEventListener.cpp:
* bindings/js/JSSVGLazyEventListener.h:
* bindings/js/JSSVGLengthCustom.cpp:
* bindings/js/JSSVGMatrixCustom.cpp:
(WebCore::JSSVGMatrix::inverse):
(WebCore::JSSVGMatrix::rotateFromVector):
* bindings/js/JSSVGPathSegCustom.cpp:
* bindings/js/JSSVGPathSegListCustom.cpp:
(WebCore::JSSVGPathSegList::initialize):
(WebCore::JSSVGPathSegList::getItem):
(WebCore::JSSVGPathSegList::insertItemBefore):
(WebCore::JSSVGPathSegList::replaceItem):
(WebCore::JSSVGPathSegList::removeItem):
(WebCore::JSSVGPathSegList::appendItem):
* bindings/js/JSSVGPointListCustom.cpp:
* bindings/js/JSSVGTransformListCustom.cpp:
* bindings/js/JSStorageCustom.cpp:
* bindings/js/JSStyleSheetCustom.cpp:
* bindings/js/JSStyleSheetListCustom.cpp:
* bindings/js/JSTextCustom.cpp:
* bindings/js/JSTreeWalkerCustom.cpp:
* bindings/js/JSXMLHttpRequestConstructor.cpp:
* bindings/js/JSXMLHttpRequestConstructor.h:
(WebCore::JSXMLHttpRequestConstructor::classInfo):
* bindings/js/JSXMLHttpRequestCustom.cpp:
* bindings/js/JSXMLHttpRequestUploadCustom.cpp:
* bindings/js/JSXSLTProcessorConstructor.cpp:
* bindings/js/JSXSLTProcessorConstructor.h:
(WebCore::JSXSLTProcessorConstructor::classInfo):
* bindings/js/JSXSLTProcessorCustom.cpp:
* bindings/js/ScheduledAction.cpp:
* bindings/js/ScheduledAction.h:
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::attachDebugger):
(WebCore::ScriptController::windowScriptNPObject):
* bindings/js/ScriptController.h:
* bindings/js/ScriptControllerGtk.cpp:
(WebCore::ScriptController::createScriptInstanceForWidget):
* bindings/js/ScriptControllerMac.mm:
(WebCore::ScriptController::createScriptInstanceForWidget):
(WebCore::ScriptController::windowScriptObject):
(WebCore::ScriptController::clearPlatformScriptObjects):
(WebCore::updateRenderingForBindings):
(WebCore::ScriptController::initJavaJSBindings):
* bindings/js/ScriptControllerQt.cpp:
(WebCore::ScriptController::createScriptInstanceForWidget):
* bindings/js/ScriptControllerWin.cpp:
(WebCore::ScriptController::createScriptInstanceForWidget):
* bindings/js/ScriptControllerWx.cpp:
(WebCore::ScriptController::createScriptInstanceForWidget):
* bindings/js/StringSourceProvider.h:
(WebCore::StringSourceProvider::getRange):
* bindings/objc/DOM.mm:
(-[DOMNode JSC::Bindings::]):
* bindings/objc/DOMInternal.h:
* bindings/objc/DOMInternal.mm:
(-[WebScriptObject _initializeScriptDOMNodeImp]):
* bindings/objc/DOMUtility.mm:
(JSC::createDOMWrapper):
(WebCore::createDOMWrapper):
* bindings/objc/WebScriptObject.mm:
(WebCore::createJSWrapper):
(-[WebScriptObject _initWithJSObject:JSC::originRootObject:JSC::Bindings::rootObject:JSC::Bindings::]):
* bindings/objc/WebScriptObjectPrivate.h:
* bindings/scripts/CodeGeneratorJS.pm:
* bridge/NP_jsobject.cpp:
* bridge/NP_jsobject.h:
* bridge/c/c_class.cpp:
* bridge/c/c_class.h:
* bridge/c/c_instance.cpp:
* bridge/c/c_instance.h:
* bridge/c/c_runtime.cpp:
* bridge/c/c_runtime.h:
* bridge/c/c_utility.cpp:
* bridge/c/c_utility.h:
* bridge/jni/jni_class.cpp:
* bridge/jni/jni_class.h:
* bridge/jni/jni_instance.cpp:
* bridge/jni/jni_instance.h:
* bridge/jni/jni_jsobject.h:
* bridge/jni/jni_jsobject.mm:
(JavaJSObject::call):
(JavaJSObject::convertJObjectToValue):
* bridge/jni/jni_objc.mm:
(JSC::Bindings::dispatchJNICall):
* bridge/jni/jni_runtime.cpp:
* bridge/jni/jni_runtime.h:
* bridge/jni/jni_utility.cpp:
* bridge/jni/jni_utility.h:
* bridge/npruntime.cpp:
(_NPN_GetStringIdentifier):
* bridge/objc/WebScriptObject.h:
* bridge/objc/objc_class.h:
* bridge/objc/objc_class.mm:
* bridge/objc/objc_instance.h:
* bridge/objc/objc_instance.mm:
* bridge/objc/objc_runtime.h:
* bridge/objc/objc_runtime.mm:
* bridge/objc/objc_utility.h:
* bridge/objc/objc_utility.mm:
* bridge/qt/qt_class.cpp:
* bridge/qt/qt_class.h:
* bridge/qt/qt_instance.cpp:
* bridge/qt/qt_instance.h:
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertQVariantToValue):
(JSC::Bindings::):
* bridge/qt/qt_runtime.h:
* bridge/runtime.cpp:
* bridge/runtime.h:
* bridge/runtime_array.cpp:
* bridge/runtime_array.h:
* bridge/runtime_method.cpp:
* bridge/runtime_method.h:
* bridge/runtime_object.cpp:
* bridge/runtime_object.h:
* bridge/runtime_root.cpp:
(JSC::Bindings::RootObject::invalidate):
(JSC::Bindings::RootObject::gcProtect):
(JSC::Bindings::RootObject::gcUnprotect):
* bridge/runtime_root.h:
* bridge/testbindings.cpp:
* bridge/testbindings.mm:
* bridge/testqtbindings.cpp:
* dom/Document.cpp:
(WebCore::Document::~Document):
* dom/NSResolver.h:
* dom/Node.cpp:
(WebCore::Node::setDocument):
(WebCore::ResolveNamespaceFunctor::ResolveNamespaceFunctor):
(WebCore::resolveNamespacesForSelector):
(WebCore::Node::querySelector):
(WebCore::Node::querySelectorAll):
* dom/Node.h:
* dom/NodeFilter.cpp:
* dom/NodeFilter.h:
* dom/NodeFilterCondition.cpp:
* dom/NodeFilterCondition.h:
* dom/NodeIterator.cpp:
* dom/NodeIterator.h:
* dom/Traversal.cpp:
* dom/Traversal.h:
* dom/TreeWalker.cpp:
* dom/TreeWalker.h:
* dom/make_names.pl:
* history/CachedPage.cpp:
* history/CachedPage.h:
* html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::getInstance):
* html/HTMLPlugInElement.h:
* loader/FrameLoader.cpp:
* loader/FrameLoader.h:
* loader/icon/IconDatabase.cpp:
(WebCore::iconDatabase):
* page/Console.cpp:
* page/Console.h:
* page/InspectorController.cpp:
(WebCore::XMLHttpRequestResource::XMLHttpRequestResource):
(WebCore::XMLHttpRequestResource::~XMLHttpRequestResource):
(WebCore::InspectorResource::setXMLHttpRequestProperties):
(WebCore::InspectorResource::sourceString):
(WebCore::getResourceDocumentNode):
(WebCore::search):
(WebCore::InspectorController::focusNode):
(WebCore::InspectorController::inspectedWindowScriptObjectCleared):
(WebCore::InspectorController::addDatabaseScriptResource):
(WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
* page/InspectorController.h:
(WebCore::InspectorController::profiles):
* page/JavaScriptCallFrame.cpp:
(WebCore::JavaScriptCallFrame::scopeChain):
* page/JavaScriptCallFrame.h:
(WebCore::JavaScriptCallFrame::create):
(WebCore::JavaScriptCallFrame::update):
* page/JavaScriptDebugListener.h:
* page/JavaScriptDebugServer.cpp:
(WebCore::dispatchDidParseSource):
* page/JavaScriptDebugServer.h:
* page/JavaScriptProfile.cpp:
* page/JavaScriptProfile.h:
* page/JavaScriptProfileNode.cpp:
(WebCore::getTotalTime):
(WebCore::getSelfTime):
(WebCore::getTotalPercent):
(WebCore::getSelfPercent):
(WebCore::getNumberOfCalls):
(WebCore::getChildren):
(WebCore::getVisible):
* page/JavaScriptProfileNode.h:
* page/Page.cpp:
(WebCore::Page::setDebuggerForAllPages):
(WebCore::Page::setDebugger):
* page/Page.h:
(WebCore::Page::debugger):
* page/mac/FrameMac.mm:
* platform/KURL.h:
(WebCore::KURL::operator JSC::UString):
* platform/text/AtomicString.cpp:
(WebCore::AtomicString::add):
(WebCore::AtomicString::find):
* platform/text/AtomicString.h:
(WebCore::AtomicString::AtomicString):
* platform/text/PlatformString.h:
* platform/text/String.cpp:
(WebCore::charactersToDouble):
* platform/win/BString.cpp:
* platform/win/BString.h:
* plugins/MimeTypeArray.h:
* plugins/Plugin.h:
* plugins/PluginArray.h:
* plugins/PluginView.cpp:
(WebCore::PluginView::start):
(WebCore::PluginView::performRequest):
(WebCore::PluginView::bindingInstance):
* plugins/PluginView.h:
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::paint):
(WebCore::PluginView::handleKeyboardEvent):
(WebCore::PluginView::handleMouseEvent):
(WebCore::PluginView::setNPWindowRect):
(WebCore::PluginView::stop):
(WebCore::PluginView::init):
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::setNPWindowRect):
(WebCore::PluginView::stop):
(WebCore::PluginView::init):
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::dispatchNPEvent):
(WebCore::PluginView::handleKeyboardEvent):
(WebCore::PluginView::handleMouseEvent):
(WebCore::PluginView::setNPWindowRect):
(WebCore::PluginView::stop):
* storage/Database.cpp:
(WebCore::Database::Database):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::responseText):
(WebCore::XMLHttpRequest::loadRequestAsynchronously):
(WebCore::XMLHttpRequest::clearResponse):
(WebCore::XMLHttpRequest::dropProtection):
(WebCore::XMLHttpRequest::didFinishLoading):
(WebCore::XMLHttpRequest::didReceiveData):
* xml/XMLHttpRequest.h:
2008-09-07 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Adopt opener restriction on frame navigation.
https://bugs.webkit.org/show_bug.cgi?id=20642
This restriction helps prevent an attacker from navigating top-level
windows that were created by another web site.
Tests: http/tests/security/frameNavigation/not-opener.html
http/tests/security/frameNavigation/opener.html
* loader/FrameLoader.cpp:
(WebCore::canAccessAncestor):
(WebCore::FrameLoader::shouldAllowNavigation):
2008-09-07 Dan Bernstein <mitz@apple.com>
Reviewed by Maciej Stachowiak.
- use the correct sign for vertical offsets of combining marks
* platform/graphics/win/UniscribeController.cpp:
(WebCore::UniscribeController::shapeAndPlaceItem):
2008-09-07 Dan Bernstein <mitz@apple.com>
Reviewed by Dave Hyatt.
- add the combining mark offsets in two places where I forgot them
* platform/graphics/win/FontCGWin.cpp:
(WebCore::Font::drawGlyphs):
2008-09-07 Dan Bernstein <mitz@apple.com>
Reviewed by Dave Hyatt.
- correct glyph advances in complex text using web fonts rendered with
Core Graphics
* platform/graphics/win/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
2008-09-07 Keishi Hattori <casey.hattori@gmail.com>
Adds console.dirxml support to the Web Inspector.
https://bugs.webkit.org/show_bug.cgi?id=19156
Reviewed by Timothy Hatcher.
* WebCore.vcproj/WebCore.vcproj: Added ElementsTreeOutline.js.
* bindings/js/JSConsoleCustom.cpp:
(WebCore::JSConsole::dirxml):
* page/Console.cpp:
(WebCore::Console::dirxml): Adds a ConsoleMessage with NodeMessageLevel.
* page/Console.h:
(WebCore::): Added NodeMessageLevel.
* page/Console.idl: Added console.dirxml.
* page/inspector/Console.js: A NodeMessage creates a ElementsTreeOutline.
* page/inspector/ElementsPanel.js: Modified to use ElementsTreeOutline. The ElementsTreeOutline
in the ElementsPanel has includeRootDOMNode and selectEnabled set to true.
* page/inspector/ElementsTreeOutline.js: Added.
(WebInspector.ElementsTreeOutline): A subclass of TreeOutline for displaying a DOM node tree.
(WebInspector.ElementsTreeElement): A subclass of TreeElement for ElementsTreeOutline.
* page/inspector/WebKit.qrc: Added ElementsTreeOutline.js.
* page/inspector/inspector.css:
* page/inspector/inspector.html: Added ElementsTreeOutline.js.
* page/inspector/inspector.js: Moved hover related methods to WebInspector.
(WebInspector.altKeyDown):
(WebInspector.forceHoverHighlight):
(WebInspector.hoveredDOMNode):
(WebInspector._updateHoverHighlightSoon):
(WebInspector._updateHoverHighlight):
(WebInspector.documentKeyDown): Updates WebInspector.altKeyDown
(WebInspector.documentKeyUp): Updates WebInspector.altKeyDown
* page/inspector/utilities.js: Added getDocumentForNode, parentNodeOrFrameElement,
isAncestorIncludingParentFrames.
2008-09-06 Mark Rowe <mrowe@apple.com>
Qt build fix.
* bridge/qt/qt_runtime.cpp:
(KJS::Bindings::convertQVariantToValue):
=== End merge of squirrelfish-extreme ===
2008-09-05 Oliver Hunt <oliver@apple.com>
Start bringing up SFX on windows.
Reviewed by Mark Rowe and Sam Weinig
Start doing the work to bring up SFX on windows. Initially
just working on WREC, as it does not make any calls so reduces
the amount of code that needs to be corrected.
Add forwarding headers
* ChangeLog:
* ForwardingHeaders/masm/MacroAssembler.h: Added.
* WebCore.vcproj/WebCore.vcproj:
2008-08-27 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver Hunt.
Fix the build of the full WebKit stack.
Add forwarding headers.
* ForwardingHeaders/masm/IA32MacroAsm.h: Added.
* ForwardingHeaders/wrec/WREC.h: Added.
=== Start merge of squirrelfish-extreme ===
2008-09-06 Antti Koivisto <antti@apple.com>
Reviewed by Dave Hyatt.
<rdar://problem/6187043>
Don't parse full HTML user agent style sheet unless it is actually needed
<rdar://problem/6131889>
WebView is significantly more expensive to create recently
Parsing the html4.css takes significant amount of time and memory (~50kb) on application
startup. Some clients may never use most of the rules.
With this patch we use simplified UA stylesheet until we hit something it can't handle.
This avoids full stylesheet parsing on application startup (due to empty document construction)
and also makes it possible for clients with very simple demands (divs and spans only) never to load
the full style.
It also delays view source style parsing until it is used.
* css/CSSStyleSelector.cpp:
(WebCore::elementCanUseSimpleDefaultStyle):
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::loadFullDefaultStyle):
(WebCore::loadSimpleDefaultStyle):
(WebCore::loadViewSourceStyle):
(WebCore::CSSStyleSelector::matchUARules):
(WebCore::CSSStyleSelector::styleForElement):
2008-09-06 Kevin Ollivier <kevino@theolliviers.com>
wx build fix.
* WebCoreSources.bkl:
2008-09-06 Antti Koivisto <antti@apple.com>
Reverting r35953 which was causing problems on Windows which relies on
WebCore timers in nested event loops. r36132 did alternative fix.
* page/Chrome.cpp:
(WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
(WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
2008-09-06 Antti Koivisto <antti@apple.com>
Reviewed by Dan Bernstein.
Fix <rdar://problem/6201644>
https://bugs.webkit.org/show_bug.cgi?id=20493
Crash after OK in dialog box and reloading page in secure mode
Limited loader only fix since the general timer fix is causing problems on Windows.
* loader/loader.cpp:
(WebCore::Loader::servePendingRequests):
(WebCore::Loader::Host::Host):
(WebCore::Loader::Host::didFinishLoading):
(WebCore::Loader::Host::didFail):
(WebCore::Loader::Host::didReceiveData):
* loader/loader.h:
(WebCore::Loader::Host::processingResource):
2008-09-06 Dan Bernstein <mitz@apple.com>
Reviewed by Dave Hyatt.
The initial Core Text adoption prototype was made by Daniel Fenwick.
- <rdar://problem/5158514> Add a Core Text-based complex text code path
Currently the Core Text code path is not used in any configuration.
* WebCore.xcodeproj/project.pbxproj: Added files.
* config.h: Defined WTF_USE_ATSUI and WTF_USE_CORE_TEXT.
* platform/graphics/Font.cpp:
(WebCore::WidthIterator::advance): Moved the spacingDisabled() test out
of the loop.
* platform/graphics/GlyphBuffer.h:
(WebCore::GlyphBuffer::add): Added this version that takes an advance.
* platform/graphics/SimpleFontData.h: Added ATSUI and CORE_TEXT #ifdefs.
Added getCTFont() and getCFStringAttributes() and corresponding data
members for Core Text.
* platform/graphics/mac/CoreTextController.cpp: Added.
(WebCore::roundCGFloat): Helper function.
(WebCore::ceilCGFloat): Helper function.
(WebCore::CoreTextController::CoreTextRun::CoreTextRun):
(WebCore::CoreTextController::CoreTextController):
(WebCore::CoreTextController::offsetForPosition):
(WebCore::CoreTextController::collectCoreTextRuns): Added. Segments the
run into subruns as necessary such that each subrun can be rendered with
a single font. Also separates out soft hyphens and replaces them with
real hyphens, because Core Text does not emit a glyph for soft hyphens.
Then calls collectCoreTextRunsForCharacters() on each subrun.
(WebCore::CoreTextController::advance):
(WebCore::CoreTextController::collectCoreTextRunsForCharacters): Creates
a CTLine from the given subrun and collects its CoreTextRuns.
(WebCore::CoreTextController::adjustGlyphsAndAdvances): Applies the
rounding hacks, letter- and word-spacing and glyph substitutions and
stores the resulting adjusted glyphs and advances.
* platform/graphics/mac/CoreTextController.h: Copied from WebCore/platform/graphics/win/UniscribeController.h.
(WebCore::CoreTextController::totalWidth):
(WebCore::CoreTextController::finalRoundingWidth):
(WebCore::CoreTextController::CoreTextRun::ctRun):
(WebCore::CoreTextController::CoreTextRun::glyphCount):
(WebCore::CoreTextController::CoreTextRun::fontData):
(WebCore::CoreTextController::CoreTextRun::characters):
(WebCore::CoreTextController::CoreTextRun::stringLocation):
(WebCore::CoreTextController::CoreTextRun::stringLength):
(WebCore::CoreTextController::CoreTextRun::indexAt):
* platform/graphics/mac/FontMac.mm: Moved the ATSUI-specific parts to
FontMacATSUI.mm.
* platform/graphics/mac/FontMacATSUI.mm: Copied from WebCore/platform/graphics/mac/FontMac.mm.
(WebCore::disableLigatures): Changed to call
FontPlatformData::allowsLigatures().
(WebCore::overrideLayoutOperation): Changed to call
FontPlatformData::roundsGlyphAdvances().
* platform/graphics/mac/FontMacCoreText.cpp: Copied from WebCore/platform/graphics/win/FontWin.cpp.
(WebCore::Font::selectionRectForComplexText): Changed to use
totalWidth() instead of advancing to the end and using runWidthSoFar().
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText): Ditto.
(WebCore::Font::offsetForPositionForComplexText):
* platform/graphics/mac/FontPlatformData.h:
* platform/graphics/mac/FontPlatformDataMac.mm:
(WebCore::FontPlatformData::setFont):
(WebCore::FontPlatformData::roundsGlyphAdvances): Added. Checks the
AppKit rendering mode.
(WebCore::FontPlatformData::allowsLigatures): Added. Implements the
heuristic that allows ligatures in fonts that do not have a glyph for
'a', based on the assumption that such fonts are only used in complex
text.
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::getCTFont): Added.
(WebCore::SimpleFontData::getCFStringAttributes): Added. Caches and
returns an attributes dictionary.
* platform/text/mac/ShapeArabic.c: Added ATSUI #ifdefs.
* platform/text/mac/ShapeArabic.h: Ditto.
2008-09-06 Dan Bernstein <mitz@apple.com>
Reviewed by Dave Hyatt.
- make combining mark offsets work in CG text on Windows
* platform/graphics/win/FontCGWin.cpp:
(WebCore::Font::drawGlyphs): The old code tried to translate the text
matrix, but failed for two reasons: it did not actually change the
matrix, and even if it did, CGContextSetTextPosition overwrites the
translation values in the text matrix. Instead, just added the
translation to the anchor point.
2008-09-05 Gustavo Noronha Silva <gns@gnome.org>
Reviewed by Alp Toker.
https://bugs.webkit.org/show_bug.cgi?id=18346
[GTK] Remove build warnings
Applied some casts, and removed an unused typedef to make the
compiler happy, printing less warnings when building.
* page/gtk/AccessibilityObjectWrapperAtk.cpp:
* platform/graphics/gtk/SimpleFontDataPango.cpp:
(WebCore::SimpleFontData::containsCharacters):
* platform/graphics/gtk/VideoSinkGStreamer.cpp:
(webkit_video_sink_set_caps):
* platform/network/soup/ResourceHandleSoup.cpp:
2008-09-05 Eric Seidel <eric@webkit.org>
Reviewed by Adam Roben.
Build fix for WebKitWin and Chromium
* platform/FileSystem.h:
2008-09-05 Eric Seidel <eric@webkit.org>
Reviewed by Darin Adler.
Try to make Chromium compile with ToT:
- Wrap a few places which depend on KJS:: in #if USE(JSC)
- Include some windows forward declarations
* dom/Node.h:
* page/Console.h:
* page/animation/CompositeAnimation.h:
* platform/FileSystem.h:
* platform/graphics/Image.h:
* platform/text/AtomicString.h:
* platform/text/String.cpp:
* rendering/style/RenderStyle.h:
2008-09-05 Dave Hyatt <hyatt@apple.com>
Add support for runtime switchability of the Aqua look and the native look on Windows.
Make RenderThemeWin compile by default even when USE(SAFARI_THEME) is set.
Reviewed by Adam Roben
* WebCore.vcproj/WebCore.vcproj:
* page/Settings.cpp:
(WebCore::Settings::setShouldPaintNativeControls):
* page/Settings.h:
(WebCore::Settings::shouldPaintNativeControls):
* rendering/RenderThemeSafari.cpp:
(WebCore::theme):
* rendering/RenderThemeWin.cpp:
2008-09-05 Antti Koivisto <antti@apple.com>
Qt build fix.
* svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::build):
2008-09-05 Dirk Schulze <vbs85@gmx.de>
Gtk build fix
* GNUmakefile.am:
2008-09-05 Antti Koivisto <antti@apple.com>
Another build fix.
* svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::notifyFinished):
2008-09-05 Antti Koivisto <antti@apple.com>
Build fixes.
* WebCore.xcodeproj/project.pbxproj:
* svg/graphics/filters/SVGFEImage.cpp:
(WebCore::FEImage::cachedImage):
2008-09-05 Antti Koivisto <antti@apple.com>
Reviewed by Darin Adler.
Most of the implementation for https://bugs.webkit.org/show_bug.cgi?id=17998
When a resource is cached locally, WebKit should follow RFC 2616 "Specific end-to-end revalidation" instead of "Unspecified end-to-end revalidation"
Implement HTTP 1.1 "Specific end-to-end revalidation" for WebCore memory cache. This patch does
not yet enable it for the biggest use case, reloading. However it is good for general browsing as
well. Doing this in WebCore level as opposed to relying on disk cache has big benefit that
we avoid re-decoding resources, especially images.
To be exact the enabled case is not actually the "Specific end-to-end revalidation" since it does not include
CacheControl: max-age=0 header. That would be added in reload case.
The approach for revalidation is to kick the original resource out from the memory cache
and create a new CachedResource that represents the revalidation request. In case
we get 304 back for the request we put the original resource back to the cache, update
its expiration date and switch the clients registered to revalidation resource to be
clients of the original resource.
All heap allocated CachedImage pointers now use CachedResourceHandle<CachedImage> (and so on) instead.
This allows updating the handles to point to the original resource when the revalidation succeeds. It
also acts as refcounting smart pointer.
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSFontFaceSource.h:
* css/CSSImportRule.h:
* dom/Clipboard.h:
(WebCore::Clipboard::dragImage):
* dom/ProcessingInstruction.h:
* dom/ScriptElement.h:
* dom/XMLTokenizer.cpp:
(WebCore::XMLTokenizer::isWaitingForScripts):
* dom/XMLTokenizer.h:
* html/HTMLImageLoader.cpp:
(WebCore::HTMLImageLoader::setImage):
(WebCore::HTMLImageLoader::updateFromElement):
(WebCore::HTMLImageLoader::notifyFinished):
* html/HTMLImageLoader.h:
(WebCore::HTMLImageLoader::image):
* html/HTMLLinkElement.h:
* html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::reset):
(WebCore::HTMLTokenizer::scriptHandler):
(WebCore::HTMLTokenizer::notifyFinished):
* html/HTMLTokenizer.h:
* loader/Cache.cpp:
(WebCore::Cache::revalidateResource):
(WebCore::Cache::revalidationSucceeded):
(WebCore::Cache::revalidationFailed):
* loader/Cache.h:
* loader/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::~CachedResource):
(WebCore::CachedResource::isExpired):
(WebCore::CachedResource::setResponse):
(WebCore::CachedResource::deleteIfPossible):
(WebCore::CachedResource::setResourceToRevalidate):
(WebCore::CachedResource::clearResourceToRevalidate):
(WebCore::CachedResource::switchClientsToRevalidatedResource):
(WebCore::CachedResource::canUseCacheValidator):
(WebCore::CachedResource::mustRevalidate):
* loader/CachedResource.h:
(WebCore::CachedResource::canDelete):
(WebCore::CachedResource::registerHandle):
(WebCore::CachedResource::unregisterHandle):
(WebCore::CachedResource::isCacheValidator):
(WebCore::CachedResource::resourceToRevalidate):
(WebCore::CachedResource::setExpirationDate):
* loader/CachedResourceHandle.cpp: Added.
(WebCore::CachedResourceHandleBase::setResource):
* loader/CachedResourceHandle.h: Added.
(WebCore::CachedResourceHandleBase::~CachedResourceHandleBase):
(WebCore::CachedResourceHandleBase::get):
(WebCore::CachedResourceHandleBase::operator!):
(WebCore::CachedResourceHandleBase::operator UnspecifiedBoolType):
(WebCore::CachedResourceHandleBase::CachedResourceHandleBase):
(WebCore::CachedResourceHandleBase::operator=):
(WebCore::CachedResourceHandle::CachedResourceHandle):
(WebCore::CachedResourceHandle::get):
(WebCore::CachedResourceHandle::operator->):
(WebCore::CachedResourceHandle::operator=):
(WebCore::CachedResourceHandle::operator==):
(WebCore::CachedResourceHandle::operator!=):
(WebCore::operator==):
(WebCore::operator!=):
* loader/DocLoader.cpp:
(WebCore::DocLoader::checkForReload):
* loader/UserStyleSheetLoader.h:
* loader/loader.cpp:
(WebCore::Loader::Host::servePendingRequests):
(WebCore::Loader::Host::didFinishLoading):
(WebCore::Loader::Host::didFail):
(WebCore::Loader::Host::didReceiveResponse):
(WebCore::Loader::Host::didReceiveData):
* page/EventHandler.cpp:
(WebCore::EventHandler::selectCursor):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::setCachedImage):
(WebCore::RenderImage::imageChanged):
* rendering/RenderImage.h:
(WebCore::RenderImage::cachedImage):
(WebCore::RenderImage::imagePtr):
* rendering/style/RenderStyle.h:
* rendering/style/StyleCachedImage.h:
(WebCore::StyleCachedImage::data):
(WebCore::StyleCachedImage::cachedImage):
* svg/SVGFEImageElement.h:
* svg/graphics/filters/SVGFEImage.h:
* xml/XSLImportRule.h:
2008-09-04 Brady Eidson <beidson@apple.com>
Reviewed by Mitz
<rdar://problem/6180236> - Safari times out connections after 1 or 2 minutes
A 60-second default timeout was added in http://trac.webkit.org/changeset/17144 in an attempt
to model default NSURLRequest behavior in a cross-platform manner.
Sadly by always enforcing this 60 second timeout, WebCore was stomping over the wishes of any Webkit
client that wished to enforce a much larger default timeout using NSURLRequest API.
Additionally, upon reviewing what all other browsers do, it seems apparent that "no limit" is desirable
behavior on the web and this restores previous Safari/WebKit behavior.
It would be easy to write a layout test for this, but to be effective it would have
to run for at least 61 seconds, which seems insane until will can parallelize run-webkit-tests
* manual-tests/timeout-test.html: Added.
* manual-tests/timeout-test.php: Added.
* platform/network/ResourceRequestBase.h:
(WebCore::ResourceRequestBase::ResourceRequestBase): Rename the constant to "unspecifiedTimeoutInterval"
and make it UINT_MAX so platforms that do set it have an effective "no timeout." (Windows, for example)
* platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::doUpdatePlatformRequest): If the timeout for this request is
"unspecifiedTimeoutInterval", then don't bother setting the timeout using NSURLRequest API, allowing
WebKit applications to enforce their own default timeout.
2008-09-04 Dan Bernstein <mitz@apple.com>
Reviewed by Beth Dakin.
- fix <rdar://problem/6198514> Changing a button's opacity triggers relayout
Test: fast/repaint/button-spurious-layout-hint.html
* rendering/RenderButton.cpp:
(WebCore::RenderButton::setStyle): Reset the inner block's style box
flex to 0 to avoid getting a spurious layout hint.
2008-09-04 Kevin Ollivier <kevino@theolliviers.com>
wx build fixes.
* WebCoreSources.bkl:
* bindings/js/ScriptControllerWx.cpp: Added.
(WebCore::ScriptController::createScriptInstanceForWidget):
* page/wx/AccessibilityObjectWx.cpp: Added.
(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
* platform/graphics/wx/GraphicsContextWx.cpp:
* webcore-base.bkl:
* webcore-wx.bkl:
2008-09-04 Dan Bernstein <mitz@apple.com>
Reviewed by Mark Rowe.
- roll out r36050 because it made svg/custom/invalid-fill-hex.svg fail,
and fixing https://bugs.webkit.org/show_bug.cgi?id=15360 appears to
require a different approach
* css/CSSGrammar.y:
2008-09-04 Mark Rowe <mrowe@apple.com>
Reviewed by Eric Seidel.
Fix https://bugs.webkit.org/show_bug.cgi?id=20639.
Bug 20639: ENABLE_DASHBOARD_SUPPORT does not need to be a FEATURE_DEFINE
* Configurations/WebCore.xcconfig: Remove ENABLE_DASHBOARD_SUPPORT from FEATURE_DEFINES.
* DerivedSources.make: Revert to checking for ENABLE_DASHBOARD_SUPPORT rather than looking
for ENABLE_DASHBOARD_SUPPORT in FEATURE_DEFINES.
2008-09-04 Mark Rowe <mrowe@apple.com>
Mac build fix.
* config.h: Only check the value of HAVE_CONFIG_H if it is defined.
2008-09-04 Eric Seidel <eric@webkit.org>
Build fix only, no review.
* dom/XMLTokenizer.cpp: Fix the Chromium merge build by adding a missing header (the Mac files must include it somewhere).
2008-09-04 Marco Barisione <marco.barisione@collabora.co.uk>
Reviewed by Eric Seidel.
http://bugs.webkit.org/show_bug.cgi?id=20380
[GTK][AUTOTOOLS] Include autotoolsconfig.h from config.h
* config.h: Include the configuration header generated by autotools if
available.
2008-09-04 Dan Bernstein <mitz@apple.com>
Rubber-stamped by Dave Hyatt.
- rename CachedResource::allReferencesRemoved() to allClientsRemoved()
* loader/CachedFont.cpp:
(WebCore::CachedFont::allClientsRemoved):
* loader/CachedFont.h:
* loader/CachedImage.cpp:
(WebCore::CachedImage::allClientsRemoved):
* loader/CachedImage.h:
* loader/CachedResource.cpp:
(WebCore::CachedResource::removeClient):
* loader/CachedResource.h:
(WebCore::CachedResource::allClientsRemoved):
2008-09-04 Adam Roben <aroben@apple.com>
Windows build fix after r36071
We were getting these errors:
error C2356: initialization segment must not change during translation
unit
This was happening because multiple files #included by
DerivedSources.cpp were themselves #including StaticConstructors.h. I
fixed the error by adding header guards to StaticConstructors.h so its
contents will only be included once.
But it's also not a good idea for StaticConstructors.h to end up in
DerivedSources.cpp, since it ends up "polluting" all the source files
we have in there. So I removed all the files that include
StaticConstructors.h and added some preprocessor directives to
DerivedSources.cpp to catch this error in the future.
* DerivedSources.cpp: Removed the *Names.cpp files, which include
StaticConstructors.h, and added some preprocessor directives to make
sure we don't end up accidentally including StaticConstructors.h in
the future.
* WebCore.vcproj/WebCore.vcproj: Added the *Names.cpp files.
* platform/StaticConstructors.h: Added header guards.
2008-09-04 Adam Roben <aroben@apple.com>
Windows build fix
* platform/graphics/win/FontPlatformData.h: Added a missing #include
of PassRefPtr.h, and corrected the capitalization of RefCounted.h.
* platform/text/PlatformString.h: Added a missing #include of
PassRefPtr.h.
2008-09-04 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Fix the QtWebKit build to match changes in r36016
* WebCore.pro:
* bridge/qt/qt_instance.cpp:
(KJS::Bindings::QtInstance::getRuntimeObject):
* bridge/qt/qt_runtime.cpp:
(KJS::Bindings::convertQVariantToValue):
(KJS::Bindings::QtConnectionObject::execute):
2008-09-04 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Re-enable support for user stylesheets in QtWebKit
QtWebKit now follows the FRAME_LOADS_USER_STYLESHEET
code path, which allows us to keep API support for
loading user style sheets from remote URLs.
As part of the change UserStyleSheetLoader.cpp/h was
moved from WebCore/loader/mac to WebCore/loader.
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.h:
* loader/UserStyleSheetLoader.cpp: Renamed from WebCore/loader/mac/UserStyleSheetLoader.cpp.
(UserStyleSheetLoader::UserStyleSheetLoader):
(UserStyleSheetLoader::~UserStyleSheetLoader):
* loader/UserStyleSheetLoader.h: Renamed from WebCore/loader/mac/UserStyleSheetLoader.h.
* page/qt/FrameQt.cpp:
(WebCore::Frame::setUserStyleSheetLocation):
(WebCore::Frame::setUserStyleSheet):
2008-09-04 Alp Toker <alp@nuanti.com>
Reviewed by Eric.
Remove left-over QT and CAIRO platform checks.
* html/CanvasRenderingContext2D.cpp:
2008-09-04 Eric Seidel <eric@webkit.org>
Reviewed by Mark Rowe.
Fix leak of TextMetrics due to over-ref as see on buildbot.
* html/TextMetrics.h: use adoptRef since RefCounted starts @ refcount 1 instead of 0 now.
2008-09-04 Dan Bernstein <mitz@apple.com>
Reviewed by Dave Hyatt.
- fix https://bugs.webkit.org/show_bug.cgi?id=19717
<rdar://problem/6026832> REGRESSION (r31876): menu items render horizontally at the Economist
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutOnlyPositionedObjects): In the
positioned movement only case, call
tryLayoutDoingPositionedMovementOnly() and fall back on doing a full
layout if that fails.
(WebCore::RenderBlock::layoutPositionedObjects): Ditto.
* rendering/RenderBox.h:
(WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly): Renamed
layoutDoingPositionedMovementOnly to this, and made this function
check if the width changed. If it did, return, leaving the object
dirty. The caller can then call layout(). The width can change even
in the "positioned movement only" case if the object is shrink-to-fit
and the available width constraint is met. (This was the case in the
bug).
* rendering/RenderObject.h:
(WebCore::RenderObject::tryLayoutDoingPositionedMovementOnly):
Renamed layoutDoingPositionedMovementOnly() to this.
2008-09-03 Eric Seidel <eric@webkit.org>
No review, build fix only.
Attempt to fix the Qt build.
* WebCore.pro: add page/animation to include path
2008-09-03 Mark Rowe <mrowe@apple.com>
Mac build fix. Correctly detect whether dashboard support is enabled.
* DerivedSources.make:
2008-09-03 Eric Seidel <eric@webkit.org>
Reviewed by Sam.
Clean up Platform.h and add PLATFORM(CHROMIUM), PLATFORM(SKIA) and USE(V8_BINDINGS)
* Configurations/WebCore.xcconfig: add missing ENABLE_*
* config.h: add rules for V8_BINDINGS
2008-09-03 Eric Seidel <eric@webkit.org>
Reviewed by Sam.
https://bugs.webkit.org/show_bug.cgi?id=20620
Add #if USE(JSC) around KJS dependencies
Remove !USE(JAVASCRIPTCORE_BINDINGS) support for 3 reasons:
1. Most platforms have it on anyway
2. V8 is going to want to share some of that code
3. Those platforms which want it off, should have a separate file instead of an #ifdef in our .cpp
* bindings/js/JSPluginElementFunctions.cpp: remove !USE(JAVASCRIPTCORE_BINDINGS) support
* config.h: change JAVASCRIPTCORE_BINDINGS to JSC and add USE(V8)
* html/HTMLAppletElement.cpp: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
* html/HTMLAppletElement.h: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
* html/HTMLEmbedElement.cpp: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
* html/HTMLEmbedElement.h: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
* html/HTMLObjectElement.cpp: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
* html/HTMLObjectElement.h: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
* html/HTMLPlugInElement.cpp: replace USE(JAVASCRIPTCORE_BINDINGS) with USE(JSC) where needed
* html/HTMLPlugInElement.h: replace USE(JAVASCRIPTCORE_BINDINGS) with USE(JSC) where needed
* platform/text/AtomicString.cpp: add USE(JSC)
* platform/text/AtomicString.h: add USE(JSC)
* platform/text/PlatformString.h: add USE(JSC)
* platform/text/String.cpp: add USE(JSC)
* platform/text/StringImpl.cpp: add USE(JSC)
* platform/text/StringImpl.h: add USE(JSC)
2008-09-03 Dean McNamee <deanm@chromium.org>
Reviewed by Darin Adler.
Fix https://bugs.webkit.org/show_bug.cgi?id=20511
Bug 20511: Remove static initializers on Windows
Avoid static initializers on Windows by forcing Visual C++ to put
all static initializers in a code segment that is never executed.
* config.h:
* css/MediaFeatureNames.cpp:
* dom/EventNames.cpp:
* dom/QualifiedName.cpp:
* dom/make_names.pl:
* platform/StaticConstructors.h:
* platform/text/AtomicString.cpp:
2008-09-03 Dirk Schulze <vbs85@gmx.de>
Reviewed by Dave Hyatt.
Make FontCairo draw TextStroke and TextFill separately.
[CAIRO] draw TextFill and TextStroke separately.
[https://bugs.webkit.org/show_bug.cgi?id=20631]
* platform/graphics/cairo/FontCairo.cpp:
(WebCore::Font::drawGlyphs):
2008-09-03 Peter Kasting <pkasting@google.com>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=19663
Account for paint and timer lag when animating images. Also pretend
that images whose animations were paused (by becoming invisible)
continued to animate, by "catching up" to the correct frame when they're
shown again.
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::startAnimation):
(WebCore::BitmapImage::advanceAnimation):
(WebCore::BitmapImage::internalAdvanceAnimation):
(WebCore::BitmapImage::notifyObserverAndTrimDecodedData):
* platform/graphics/BitmapImage.h:
* platform/graphics/cairo/ImageCairo.cpp:
(WebCore::BitmapImage::draw):
* platform/graphics/cg/ImageCG.cpp:
(WebCore::BitmapImage::draw):
* platform/graphics/qt/ImageQt.cpp:
(WebCore::BitmapImage::draw):
* platform/graphics/wx/ImageWx.cpp:
(WebCore::BitmapImage::draw):
2008-09-03 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim.
Remove the rest of the "zombie" code from the profiler.
- There is no longer a need for the ProfilerClient callback mechanism.
* page/Console.cpp:
(WebCore::Console::Console):
(WebCore::Console::profile):
(WebCore::Console::profileEnd): Move the variables from the header to
here since we don't have to wait for a callback to use them.
* page/Console.h:
* page/InspectorController.cpp:
(WebCore::InspectorController::startUserInitiatedProfiling):
(WebCore::InspectorController::stopUserInitiatedProfiling):
* page/InspectorController.h:
2008-09-03 Ada Chan <adachan@apple.com>
Windows build fix.
* WebCore.vcproj/WebCore.vcproj: Added JSWebKitCSSKeyframeRule.cpp and JSWebKitCSSKeyframesRule.cpp to the project.
2008-09-01 Dean Jackson <dino@apple.com>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=20594
Add DOM interfaces for WebKitCSSKeyframeRule
and WebKitCSSKeyframesRule.
TEST: LayoutTests/css3/keyframes-rule.html
* css/WebKitCSSKeyframeRule.idl: Added
* css/WebKitCSSKeyframesRule.idl: Added
* bindings/js/JSCSSRuleCustom.cpp:
(WebCore::toJS):
Add return of new JS Keyframe rules
* bindings/objc/DOMInternal.h:
Include new internal header
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
Build configs for new files
2008-09-03 Adam Roben <aroben@apple.com>
Windows build fix
* DerivedSources.cpp: Add JSTextMetrics.cpp to fix the build.
* WebCore.vcproj/WebCore.vcproj: Add JSTextMetrics.h for
convenience/consistency.
2008-09-03 Adele Peterson <adele@apple.com>
Build fix.
* WebCore.vcproj/WebCore.vcproj:
2008-09-03 David Hyatt <hyatt@apple.com>
Fix for bug 18203, right floats should be allowed to overflow past the left border edge.
Reviewed by Darin (ages ago)
Added fast/block/float/clamped-right-float.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::positionNewFloats):
2008-09-02 David Hyatt <hyatt@apple.com>
Add support for canvas text drawing APIs.
Reviewed by olliej
Tests added as fast/canvas/canvas-text-*.html
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSCanvasRenderingContext2DCustom.cpp:
(WebCore::JSCanvasRenderingContext2D::fillText):
(WebCore::JSCanvasRenderingContext2D::strokeText):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::initForStyleResolve):
(WebCore::CSSStyleSelector::applyPropertyToStyle):
* css/CSSStyleSelector.h:
* html/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::State::State):
(WebCore::CanvasRenderingContext2D::font):
(WebCore::CanvasRenderingContext2D::setFont):
(WebCore::CanvasRenderingContext2D::textAlign):
(WebCore::CanvasRenderingContext2D::setTextAlign):
(WebCore::CanvasRenderingContext2D::textBaseline):
(WebCore::CanvasRenderingContext2D::setTextBaseline):
(WebCore::CanvasRenderingContext2D::fillText):
(WebCore::CanvasRenderingContext2D::strokeText):
(WebCore::CanvasRenderingContext2D::measureText):
(WebCore::CanvasRenderingContext2D::drawTextInternal):
(WebCore::CanvasRenderingContext2D::accessFont):
* html/CanvasRenderingContext2D.h:
* html/CanvasRenderingContext2D.idl:
* html/TextMetrics.h: Added.
(WebCore::TextMetrics::create):
(WebCore::TextMetrics::width):
(WebCore::TextMetrics::setWidth):
(WebCore::TextMetrics::TextMetrics):
* html/TextMetrics.idl: Added.
* platform/graphics/Font.cpp:
(WebCore::Font::lineGap):
* platform/graphics/Font.h:
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawBidiText):
* platform/graphics/GraphicsContext.h:
* platform/graphics/GraphicsTypes.cpp:
(WebCore::textAlignName):
(WebCore::parseTextAlign):
(WebCore::textBaselineName):
(WebCore::parseTextBaseline):
* platform/graphics/GraphicsTypes.h:
(WebCore::):
2008-09-03 John Sullivan <sullivan@apple.com>
Fixed <rdar://problem/6193022> <rdar://problem/6193022> Crash occurs at WebCore::AnimationBase::propertiesEqual () after certain steps
Fixed by Darin, reviewed by me
* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::propertiesEqual):
added ensurePropertyMap() to this static function
(WebCore::AnimationBase::getPropertyAtIndex):
ditto
(WebCore::AnimationBase::getNumProperties):
ditto
2008-09-03 Kevin McCullough <kmccullough@apple.com>
Reviewed by Darin and Tim.
Remove most of the "zombie" mode from the profiler. Next we will need
to remove the client callback mechanism in profiles.
- These changes are a result of changes to JSCore.
* manual-tests/inspector/profiler-test-nested-start-and-stop-profiler.html:
* page/Console.cpp:
(WebCore::retrieveLastCaller):
(WebCore::Console::profileEnd):
* page/InspectorController.cpp:
(WebCore::InspectorController::stopUserInitiatedProfiling):
2008-09-03 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Test: fast/forms/search-display-none-cancel-button.html
Allow display:none to work on a search field's cancel button. Prepare for adding more style-ability for the results button too.
* css/html4.css: Set display:inline-block for these buttons. Now they can be overridden by a web author.
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::setStyle): Add nil checks for the button renderers.
(WebCore::RenderTextControl::createResultsButtonStyle): Don't set the display explicitly. This is now done in html4.css.
(WebCore::RenderTextControl::createCancelButtonStyle): ditto.
(WebCore::RenderTextControl::createSubtreeIfNeeded):
Reorganize this code so our complicated way of adding shadow nodes is abstracted out into the TextControlInnerElement class.
(WebCore::RenderTextControl::updateFromElement): Added nil checks for the button renderers.
(WebCore::RenderTextControl::subtreeHasChanged): ditto.
(WebCore::RenderTextControl::calcHeight): ditto.
(WebCore::RenderTextControl::nodeAtPoint): ditto.
(WebCore::RenderTextControl::layout): ditto.
(WebCore::RenderTextControl::calcPrefWidths): ditto.
(WebCore::RenderTextControl::clientPaddingLeft): ditto.
(WebCore::RenderTextControl::clientPaddingRight): ditto.
* rendering/TextControlInnerElements.cpp:
(WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock): Moved from RenderTextControl.cpp.
(WebCore::RenderTextControlInnerBlock::nodeAtPoint): ditto.
(WebCore::TextControlInnerElement::attachInnerElement): Added.
This does all the separate steps of attaching a shadow node that used to be repeated in RenderTextControl::createSubtreeIfNeeded for each element.
(WebCore::TextControlInnerTextElement::createRenderer): Added. Creates a RenderTextControlInnerBlock.
* rendering/TextControlInnerElements.h:
2008-08-28 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Maciej.
Elminate SQLiteAuthorizer class.
* WebCore.xcodeproj/project.pbxproj:
* WebCore.vcproj/WebCore.vcproj:
* GNUmakefile.am
Removed SQLiteAuthorizer.h.
* platform/sql/SQLiteAuthorizer.cpp:
* platform/sql/SQLiteAuthorizer.h: Removed.
* platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::authorizerFunction):
(WebCore::SQLiteDatabase::setAuthorizer):
* platform/sql/SQLiteDatabase.h:
* storage/DatabaseAuthorizer.h:
(WebCore::DatabaseAuthorizer::create):
(WebCore::DatabaseAuthorizer::createView):
(WebCore::DatabaseAuthorizer::createTempView):
(WebCore::DatabaseAuthorizer::dropView):
(WebCore::DatabaseAuthorizer::dropTempView):
(WebCore::DatabaseAuthorizer::allowSelect):
(WebCore::DatabaseAuthorizer::allowReindex):
Merge SQLiteAuthorizer and DatabaseAuthorizer, as keeping them separate serves no purpose.
2008-09-03 Dirk Schulze <vbs85@gmx.de>
Reviewed by Mark Rowe.
WebKitGtk build fix.
* GNUmakefile.am:
* page/animation/AnimationController.h:
2008-09-02 Robert Blaut <webkit@blaut.biz>
Reviewed by Geoff Garen.
Fix for <https://bugs.webkit.org/show_bug.cgi?id=16913>
Misplaced elements should not close DL lists.
Test: fast/invalid/test-case-tr-th-td-should-not-close-dl-list.html
* html/HTMLParser.cpp:
(WebCore::HTMLParser::handleError):
2008-09-02 Glenn Wilson <wilsong@gmail.com>
Reviewed by Darin Adler.
Fix for <https://bugs.webkit.org/show_bug.cgi?id=15360>
Bug 15360: color:#{predefined colorName} is treated as colorName in Safari
We would inappropriately interpret and apply an invalid CSS "color" property
when the value is a predefined color preceded by a '#' symbol. For example,
style="color:#gray;" would apply the color gray when it should not.
In the bison template, "hexcolor" was defined as both "HEX maybe_space" OR "IDENT maybe_space".
This caused identifiers not fitting the appropriate hex format but preceded by a '#' to be
interpreted as a valid color (CSSPrimitiveValue::CSS_PARSER_HEXCOLOR), when it was really just
an ignorable token.
To correct this, "IDENT maybe_space" was removed from "hexcolor" and added under "term" as
'#' IDENT maybe_space, which is then processed as a CSSPrimitiveValue::CSS_STRING instead of
CSSPrimitiveValue::CSS_PARSER_HEXCOLOR.
Test: css1/color_and_background/invalid_color.html
* css/CSSGrammar.y:
2008-09-02 Mihnea Ovidenie <mihnea@adobe.com>
Reviewed by Darin Adler.
Fix for https://bugs.webkit.org/show_bug.cgi?id=19964
Bug 19964: Divide by zero crash in RenderBox::calculateBackgroundSize with 0,0 bmp background image
Add a check to RenderBox::repaintLayerRectsForImage to make sure the current layer image can be rendered.
Test: css3/khtml-background-size-0x0-bmp.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::repaintLayerRectsForImage):
2008-09-02 Glenn Wilson <wilsong@gmail.com>
Reviewed by Eric Seidel.
Fix https://bugs.webkit.org/show_bug.cgi?id=20397
Bug 20397: Invalid webkit-border-bottom-left-radius property causes crash
The function checkForOrphanedUnits() would change the length of a list whose size was
was already determined before the call to checkForOrphanedUnits was made. Later in
the caller, the old size was being used for boundary management.
This has been fixed by moving the call to checkForOrphanedUnits() earlier in the
calling function, before the size of the list is determined.
Test: fast/css/orphaned_units_crash.html
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Moved call to checkForOrphanedUnits() earlier in the function.
2008-09-02 Dirk Schulze <vbs85@gmx.de>
Reviewed by Darin Adler.
Fallback on invalid fill or stroke styles in Canvas was
transparent black. Changed it to last valid style.
Canvas fillStyle() and strokeStyle() needs fallback
https://bugs.webkit.org/show_bug.cgi?id=20474
Tests: fast/canvas/canvas-invalid-fillstyle.html
fast/canvas/canvas-invalid-strokestyle.html
* html/CanvasStyle.cpp:
(WebCore::CanvasStyle::applyStrokeColor):
(WebCore::CanvasStyle::applyFillColor):
2008-09-02 Dirk Schulze <vbs85@gmx.de>
Reviewed by Darin Adler.
Fix https://bugs.webkit.org/show_bug.cgi?id=20468
Updated drawImage() in canvas to match the current specification.
Test: fast/canvas/drawImage-with-negative-source-destination.html
* html/CanvasRenderingContext2D.cpp:
(WebCore::normalizeRect):
(WebCore::CanvasRenderingContext2D::drawImage):
2008-08-26 Mark Rowe <mrowe@apple.com>
Reviewed by Darin Adler.
<rdar://problem/5768210> Switch back to the system version of SQLite
Use the system version of SQLite when it is new enough to provide the functionality
that WebCore requires.
* Configurations/Base.xcconfig:
* Configurations/DebugRelease.xcconfig:
* Configurations/WebCore.xcconfig:
2008-09-02 Dan Bernstein <mitz@apple.com>
- build fix
* page/animation/AnimationBase.h:
2008-09-02 Chris Marrin <cmarrin@apple.com>
Reviewed by Dave Hyatt.
AnimationController.cpp should be split into separate files
https://bugs.webkit.org/show_bug.cgi?id=20604
Note: All makefiles, except WebCore.xcodeproj have been changed without testing, upon
recommendation of Dave Hyatt.
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
Build files.
* page/AnimationController.cpp: Removed.
* page/AnimationController.h: Removed.
* page/animation: Added.
* page/animation/AnimationBase.cpp: Added.
* page/animation/AnimationBase.h: Added.
* page/animation/AnimationController.cpp: Copied from WebCore/page/AnimationController.cpp.
* page/animation/AnimationController.h: Copied from WebCore/page/AnimationController.h.
* page/animation/CompositeAnimation.cpp: Added.
* page/animation/CompositeAnimation.h: Added.
* page/animation/ImplicitAnimation.cpp: Added.
* page/animation/ImplicitAnimation.h: Added.
* page/animation/KeyframeAnimation.cpp: Added.
* page/animation/KeyframeAnimation.h: Added.
2008-09-02 Dan Bernstein <mitz@apple.com>
- release build fix
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::calculateDrawingMode):
2008-09-02 Timothy Hatcher <timothy@apple.com>
Make console functions log the correct resource URL and
line number for where the call originated.
https://bugs.webkit.org/show_bug.cgi?id=17234
<rdar://problem/5732837>
Reviewed by Kevin McCullough.
Test: manual-tests/inspector/console-call-line-numbers.html
* bindings/js/JSConsoleCustom.cpp:
(WebCore::JSConsole::count): Call the impl.
(WebCore::JSConsole::timeEnd): Ditto.
* manual-tests/inspector/console-call-line-numbers.html: Added.
* manual-tests/inspector/resources/script-console-calls.js: Added.
* page/Console.cpp:
(WebCore::retrieveLastCaller): Helper to get the URL and line.
(WebCore::Console::error): Call retrieveLastCaller to get the URL and
line number to pass to addMessageToConsole.
(WebCore::Console::info): Ditto.
(WebCore::Console::log): Ditto.
(WebCore::Console::assertCondition): Ditto.
(WebCore::Console::count): Ditto.
(WebCore::Console::timeEnd): Ditto.
(WebCore::Console::warn): Ditto.
* page/Console.h:
* page/Console.idl: Make count and timeEnd custom.
2008-09-02 Timothy Hatcher <timothy@apple.com>
Removed IDL files from WebCore's framework resources.
* WebCore.xcodeproj/project.pbxproj:
2008-09-02 Dan Bernstein <mitz@apple.com>
Reviewed by Dave Hyatt.
- <rdar://problem/5681647> pages at http://www.stendmarsofa.com/ are so slow to calculate style it seems like a hang
* html/HTMLParser.cpp:
(WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Added a
cap on the number of consecutive identical residual style tags to
reopen.
(WebCore::HTMLParser::popBlock): Ditto.
2008-09-02 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Adam Roben.
A little database quota management cleanup.
* storage/OriginQuotaManager.cpp:
(WebCore::OriginQuotaManager::OriginQuotaManager):
(WebCore::OriginQuotaManager::lock):
(WebCore::OriginQuotaManager::unlock):
(WebCore::OriginQuotaManager::trackOrigin):
(WebCore::OriginQuotaManager::tracksOrigin):
(WebCore::OriginQuotaManager::addDatabase):
(WebCore::OriginQuotaManager::removeDatabase):
(WebCore::OriginQuotaManager::removeOrigin):
(WebCore::OriginQuotaManager::markDatabase):
(WebCore::OriginQuotaManager::diskUsage):
* storage/OriginQuotaManager.h:
Changed to assert that a lock is taken more directly and reliably. Removed comments about
main/background threads, as this is likely to stop being true with synchronous Database calls
being made on worker threads.
* storage/OriginUsageRecord.cpp:
(WebCore::OriginUsageRecord::OriginUsageRecord):
(WebCore::OriginUsageRecord::addDatabase):
(WebCore::OriginUsageRecord::removeDatabase):
(WebCore::OriginUsageRecord::markDatabase):
(WebCore::OriginUsageRecord::diskUsage):
* storage/OriginUsageRecord.h:
(WebCore::OriginUsageRecord::DatabaseEntry::DatabaseEntry):
Don't use a magic value for unknown. It is totally unnecessary for DatabaseEntry, and
can be replaced with a single boolean for OriginUsageRecord.
Added assertions for string parameters being unshared.
2008-09-01 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=19760
Make granting LoadLocalResources conditional on a policy.
* WebCore.base.exp:
* dom/Document.cpp:
(WebCore::Document::initSecurityContext):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::setLocalLoadPolicy):
(WebCore::FrameLoader::restrictAccessToLocal):
* loader/FrameLoader.h:
(WebCore::FrameLoader::):
* platform/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::grantLoadLocalResources):
* platform/SecurityOrigin.h:
2008-09-01 Dean Jackson <dino@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=20571
Make sure Window object can assign Animation/Transition event
listeners via attributes.
Also added a bunch of transition event tests, although
only transition-end-event-window is directly relevant to this patch.
(WebCore::JSDOMWindowBase::put):
Tests: transitions/transition-end-event-all-properties.html
transitions/transition-end-event-attributes.html
transitions/transition-end-event-container.html
transitions/transition-end-event-left.html
transitions/transition-end-event-multiple-01.html
transitions/transition-end-event-multiple-02.html
transitions/transition-end-event-multiple-03.html
transitions/transition-end-event-multiple-04.html
transitions/transition-end-event-nested.html
transitions/transition-end-event-transform.html
transitions/transition-end-event-window.html
2008-09-01 Dean Jackson <dino@apple.com>
Reviewed by Sam Weinig
Code styling cleanup.
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::getValueProperty):
(WebCore::JSDOMWindowBase::put):
2008-09-01 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
First cut at inline caching for access to vanilla JavaScript properties.
Updated for JavaScriptCore changes. Mostly mechanical addition of StructureIDs
to WebCore classes, and PutPropertySlot& arguments to put functions.
(WebCore::JSCSSStyleDeclaration::customPut): Be sure to play nice with
inline caching for global properties, so global assignment can be optimized.
* ForwardingHeaders/kjs/StructureID.h: Added.
* bindings/js/JSDOMBinding.h:
(WebCore::DOMObject::DOMObject):
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::put):
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSDOMWindowCustom.h:
(WebCore::JSDOMWindow::customPut):
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::JSDOMWindowShell):
(WebCore::JSDOMWindowShell::put):
* bindings/js/JSDOMWindowShell.h:
* bindings/js/JSEventTargetBase.h:
(WebCore::JSEventTargetBase::put):
* bindings/js/JSEventTargetNode.h:
(WebCore::JSEventTargetNode::put):
* bindings/js/JSHTMLAppletElementCustom.cpp:
(WebCore::JSHTMLAppletElement::customPut):
* bindings/js/JSHTMLEmbedElementCustom.cpp:
(WebCore::JSHTMLEmbedElement::customPut):
* bindings/js/JSHTMLInputElementBase.cpp:
(WebCore::JSHTMLInputElementBase::put):
* bindings/js/JSHTMLInputElementBase.h:
* bindings/js/JSHTMLObjectElementCustom.cpp:
(WebCore::JSHTMLObjectElement::customPut):
* bindings/js/JSHistoryCustom.cpp:
(WebCore::JSHistory::customPut):
* bindings/js/JSInspectedObjectWrapper.cpp:
(WebCore::JSInspectedObjectWrapper::wrap):
(WebCore::JSInspectedObjectWrapper::JSInspectedObjectWrapper):
* bindings/js/JSInspectedObjectWrapper.h:
* bindings/js/JSInspectorCallbackWrapper.cpp:
(WebCore::JSInspectorCallbackWrapper::wrap):
(WebCore::JSInspectorCallbackWrapper::JSInspectorCallbackWrapper):
* bindings/js/JSInspectorCallbackWrapper.h:
* bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::customPut):
* bindings/js/JSPluginElementFunctions.cpp:
(WebCore::runtimeObjectCustomPut):
* bindings/js/JSPluginElementFunctions.h:
* bindings/js/JSQuarantinedObjectWrapper.cpp:
(WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper):
(WebCore::JSQuarantinedObjectWrapper::put):
* bindings/js/JSQuarantinedObjectWrapper.h:
* bindings/js/JSStorageCustom.cpp:
(WebCore::JSStorage::customPut):
* bindings/objc/WebScriptObject.mm:
(-[WebScriptObject setValue:forKey:]):
* bindings/scripts/CodeGeneratorJS.pm:
* bridge/NP_jsobject.cpp:
(_NPN_SetProperty):
* bridge/jni/jni_jsobject.mm:
(JavaJSObject::setMember):
* bridge/objc/objc_class.mm:
(KJS::Bindings::ObjcClass::fallbackObject):
* bridge/objc/objc_runtime.h:
* bridge/objc/objc_runtime.mm:
(ObjcFallbackObjectImp::ObjcFallbackObjectImp):
(ObjcFallbackObjectImp::put):
* bridge/runtime.cpp:
(KJS::Bindings::Instance::createRuntimeObject):
* bridge/runtime_array.cpp:
(RuntimeArray::put):
* bridge/runtime_array.h:
* bridge/runtime_object.cpp:
(RuntimeObjectImp::RuntimeObjectImp):
(RuntimeObjectImp::put):
* bridge/runtime_object.h:
2008-09-01 Dirk Schulze <vbs85@gmx.de>
Reviewed by Eric Seidel.
Fixed border-radius for Cairo.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::strokeArc):
2008-09-01 Dirk Schulze <vbs85@gmx.de>
Reviewed by Eric Seidel.
Added canvas's globalAlpha to cairo.
* platform/graphics/GraphicsContext.h:
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::setAlpha):
(WebCore::GraphicsContext::getAlpha):
* platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
* platform/graphics/cairo/ImageCairo.cpp:
(WebCore::BitmapImage::draw):
2008-08-31 Simon Hausmann <hausmann@webkit.org>
Unreviewed Qt build fix.
* WebCore.pro: Add TextControlInnerElements.cpp to SOURCES instead of
the .h file
2008-08-30 Darin Adler <darin@apple.com>
Reviewed by Maciej.
- adopt some new JavaScriptCore functions where appropriate
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::windowProtoFuncAToB): Adopted jsEmptyString.
(WebCore::windowProtoFuncBToA): Ditto.
* bindings/js/JSEventListener.cpp:
(WebCore::JSLazyEventListener::eventParameterName): Adopted
jsNontrivialString.
* bindings/js/JSSVGLazyEventListener.cpp:
(WebCore::JSSVGLazyEventListener::eventParameterName): Ditto.
2008-08-29 Brady Eidson <beidson@apple.com>
Reviewed by Anders' rubberstamp
Style cleanup to match MediaTokenizer::writeRawData()
* loader/PluginDocument.cpp:
(WebCore::PluginTokenizer::writeRawData):
2008-08-29 Brady Eidson <beidson@apple.com>
Reviewed by Anders
https://bugs.webkit.org/show_bug.cgi?id=20556
<rdar://problem/6181817> REGRESSION (r35946): media/video-click-dlbclick-standalone.html [sic] fails because load never fires
Fix regression I introducted in 35946
Already covered by media/video-click-dlbclick-standalone.html
* loader/MediaDocument.cpp:
(WebCore::MediaTokenizer::createDocumentStructure): Don't cancel the load here - too early!
(WebCore::MediaTokenizer::writeRawData): Call finish() here so onload() can be called. Also add
an ASSERT signifying that this method should only be called once, to more closely follow the
PluginDocument case.
2008-08-29 Beth Dakin <bdakin@apple.com>
Reviewed by Sam Weinig.
Fix for <rdar://problem/6181588>
This patch makes hit testing take into account the new concept of a
disconnected frame, in which some of the content may not be
visible. The current hit testing mechanism starts at a target frame
and drills down for a HitTestResult. In some cases, drilling down
will find a non-visible result. When this happens, we need to try
again, starting at a higher level -- namely, starting at the main
frame.
* editing/Editor.cpp:
(WebCore::Editor::insideVisibleArea): New function that tests if a
point is inside the visible area for a disconnected frame.
* editing/Editor.h:
* page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):
2008-08-29 Adele Peterson <adele@apple.com>
Reviewed by Adam Roben.
Rename HTMLTextFieldInnerElement.h/.cpp to TextControlInnerElements.h/.cpp
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* html/HTMLTextFieldInnerElement.cpp: Removed.
* html/HTMLTextFieldInnerElement.h: Removed.
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::createSubtreeIfNeeded):
* rendering/RenderTextControl.h:
* rendering/TextControlInnerElements.cpp: Copied from html/HTMLTextFieldInnerElement.cpp.
(WebCore::TextControlInnerElement::TextControlInnerElement):
(WebCore::TextControlInnerTextElement::TextControlInnerTextElement):
(WebCore::TextControlInnerTextElement::defaultEventHandler):
(WebCore::SearchFieldResultsButtonElement::SearchFieldResultsButtonElement):
(WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
(WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement):
(WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
* rendering/TextControlInnerElements.h: Copied from html/HTMLTextFieldInnerElement.h.
2008-08-29 Eric Seidel <eric@webkit.org>
Rubber-stamped by aroben.
Add GraphicsContext.h include to GraphcisContextPrivate.h
GraphicsContextPrivate uses StrokeStyle which is defined
in GraphicsContext.h but it doesn't include that header.
CoreGraphics build doesn't fail here due to the order
it happens to include files.
* platform/graphics/GraphicsContextPrivate.h:
2008-08-29 Eric Seidel <eric@webkit.org>
Reviewed by hyatt.
Fix GeneratedImage to respect Image's refcounting
Fixing potential crashers (future if not current)
https://bugs.webkit.org/show_bug.cgi?id=20567
I don't know if it's possible to make the current code
crash, thus I've not made a test.
* css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::image):
* css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::removeClient):
(WebCore::CSSImageGeneratorValue::getImage):
* css/CSSImageGeneratorValue.h:
* platform/graphics/GeneratedImage.h:
(WebCore::GeneratedImage::GeneratedImage):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setContent):
* rendering/style/RenderStyle.h:
2008-08-29 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele.
Fix for <rdar://problem/6093767>
https://bugs.webkit.org/show_bug.cgi?id=20526
Don't allow video to render until unsupported track types have been disabled.
* platform/graphics/win/QTMovieWin.cpp:
(QTMovieWinPrivate::task):
(QTMovieWinPrivate::drawingComplete):
(QTMovieWinPrivate::clearGWorld):
2008-08-29 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele.
Fix for https://bugs.webkit.org/show_bug.cgi?id=20525
<rdar://problem/6169301>
Return the size of the movie data instead of 1000.
Test: media/progress-event-total.html
* platform/graphics/win/QTMovieWin.cpp:
(QTMovieWin::dataSize):
2008-08-29 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Eric Seidel.
[janitor/qt] Start replacing port specific getters with the generic native getter
To get the native presentation of an image we currently have platform
specific #ifdef's and a generic getter using NativeImagePtr. This patch
extends this to the ImageBuffer and updates the Qt platform to get rid
of the special #ifdefs.
https://bugs.webkit.org/attachment.cgi?id=22861
* platform/graphics/BitmapImage.h:
* platform/graphics/Image.h:
* platform/graphics/qt/ImageQt.cpp:
* platform/graphics/qt/StillImageQt.cpp:
* platform/graphics/qt/StillImageQt.h:
* platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::createDragImage):
(WebCore::ClipboardQt::declareAndWriteDragImage):
* platform/qt/CursorQt.cpp:
* platform/qt/PasteboardQt.cpp:
(WebCore::Pasteboard::writeImage):
2008-08-29 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Simon.
[svg/qt] Stop crashing... when no RenderPath/RenderObject is given...
* svg/graphics/qt/SVGPaintServerQt.cpp:
(WebCore::SVGPaintServer::renderPath):
* svg/graphics/qt/SVGPaintServerSolidQt.cpp:
(WebCore::SVGPaintServerSolid::setup):
2008-08-29 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Simon.
[network/qt] Implement defering of loading ResourceHandle's
This is needed otherwise we end in an ASSERT in the MainResourceLoader. The
implementation is simply not forwarding anything to the
ResourceHandleClient until we are allowed to. This might lead to a deadlock
in Qt as we do not empty the QNetworkReply input buffer and wait until we
are allowed to read. If that happens we are forced to buffer the data
within QNetworkReplyHandler, for now this is not done.
Manual test:
- Open http://acid3.acidtests.org
- Wait for the test to complete
- Click on the Reference Rendering link
- Be fast and see the results of acid3
=> assert
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::setLoadMode):
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::forwardData):
(WebCore::QNetworkReplyHandler::start):
(WebCore::QNetworkReplyHandler::resetState):
(WebCore::QNetworkReplyHandler::sendQueuedItems):
* platform/network/qt/QNetworkReplyHandler.h:
(WebCore::QNetworkReplyHandler::):
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):
(WebCore::ResourceHandle::setDefersLoading):
2008-08-29 Simon Hausmann <hausmann@webkit.org>
Reviewed by Holger.
Don't crash when drawing patterns with the HTML canvas. Patterns
remain unimplemented but at least they don't crash anymore. This is
done by changing the PlatformPatternPtr to be a brush for the Qt
platform.
* platform/graphics/Pattern.h:
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
* platform/graphics/qt/PatternQt.cpp:
(WebCore::Pattern::createPlatformPattern):
2008-08-29 Simon Hausmann <hausmann@webkit.org>
Fix the Qt build, fontSelector() is not used by the Qt port yet
and we just return 0 in Font::fontSelector().
* platform/graphics/Font.h:
2008-08-28 Alp Toker <alp@nuanti.com>
GTK+ dist/build fix. List newly added header files.
* GNUmakefile.am:
2008-08-28 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dave Hyatt
Various WebKitCSSTransformValue-related fixes
https://bugs.webkit.org/show_bug.cgi?id=20562
Test: css3/transform-value-types.html
* bindings/js/JSCSSValueCustom.cpp:
(WebCore::toJS):
* css/CSSValue.h:
* css/WebKitCSSTransformValue.cpp:
(WebCore::WebKitCSSTransformValue::cssText):
* css/WebKitCSSTransformValue.h:
(WebCore::WebKitCSSTransformValue::):
* css/WebKitCSSTransformValue.idl:
2008-08-28 Dan Bernstein <mitz@apple.com>
Reviewed by Steve Falkenburg.
- do not let the "last chance" WM_TIMER trigger WebCore timers when they should be deferred
* platform/win/SharedTimerWin.cpp:
(WebCore::TimerWindowWndProc):
2008-08-28 David Hyatt <hyatt@apple.com>
RenderStyle cleanup.
Break out StyleImage, StyleGeneratedImage, StyleCachedImage and NinePieceImage into separate files.
Reviewed by Adam
* css/CSSImageGeneratorValue.cpp:
* css/CSSImageValue.cpp:
* css/CSSStyleSelector.cpp:
* rendering/RenderImageGeneratedContent.cpp:
* rendering/style/NinePieceImage.cpp: Added.
* rendering/style/NinePieceImage.h: Added.
* rendering/style/RenderStyle.cpp:
(WebCore::FillLayer::operator==):
(WebCore::FillLayer::containsImage):
(WebCore::StyleInheritedData::operator==):
(WebCore::RenderStyle::contentDataEquivalent):
* rendering/style/RenderStyle.h:
* rendering/style/StyleCachedImage.cpp: Added.
* rendering/style/StyleCachedImage.h: Added.
* rendering/style/StyleGeneratedImage.cpp: Added.
* rendering/style/StyleGeneratedImage.h: Added.
* rendering/style/StyleImage.h: Added.
2008-08-28 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dave Hyatt
Make all the 'isFoo()' methods on CSSValue const,
and fix the subclasses.
https://bugs.webkit.org/show_bug.cgi?id=20561
* css/CSSTimingFunctionValue.h:
* css/CSSValue.h:
(WebCore::CSSValue::isFontValue):
(WebCore::CSSValue::isImageGeneratorValue):
(WebCore::CSSValue::isImageValue):
(WebCore::CSSValue::isImplicitInitialValue):
* css/CSSValueList.h:
* css/FontValue.h:
2008-08-28 David Hyatt <hyatt@apple.com>
The great RenderStyle cleanup begins!
Move LengthBox and LengthSize out of RenderStyle and into Length.
Reviewed by Adam
* rendering/Length.h:
(WebCore::):
(WebCore::Length::Length):
(WebCore::Length::operator==):
(WebCore::Length::operator!=):
(WebCore::Length::value):
(WebCore::Length::rawValue):
(WebCore::Length::percent):
(WebCore::Length::type):
(WebCore::Length::quirk):
(WebCore::Length::setValue):
(WebCore::Length::setRawValue):
(WebCore::Length::calcValue):
(WebCore::Length::calcMinValue):
(WebCore::Length::calcFloatValue):
(WebCore::Length::isUndefined):
(WebCore::Length::isZero):
(WebCore::Length::isPositive):
(WebCore::Length::isNegative):
(WebCore::Length::isAuto):
(WebCore::Length::isRelative):
(WebCore::Length::isPercent):
(WebCore::Length::isFixed):
(WebCore::Length::isStatic):
(WebCore::Length::isIntrinsicOrAuto):
(WebCore::Length::blend):
(WebCore::LengthBox::LengthBox):
(WebCore::LengthBox::operator=):
(WebCore::LengthBox::operator==):
(WebCore::LengthBox::operator!=):
(WebCore::LengthBox::nonZero):
(WebCore::LengthSize::LengthSize):
* rendering/style/RenderStyle.h:
2008-08-28 David Hyatt <hyatt@apple.com>
Reviewed by Darin
https://bugs.webkit.org/show_bug.cgi?id=18091
font-size should be animatable using -webkit-transition.
* page/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::ensurePropertyMap):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::setFontSize):
2008-08-28 Brad Garcia <bgarcia@google.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=20549
Correctly determine when cursor is over a resizable border within
a nested frameset.
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::canResizeRow):
(WebCore::RenderFrameSet::canResizeColumn):
2008-08-28 Simon Fraser <simon.fraser@apple.com>
Reviewed by Eric Seidel
Add RuleTypes to CSSRule.idl for keyframes and keyframe rules.
https://bugs.webkit.org/show_bug.cgi?id=20552
Test: animations/animation-css-rule-types.html
* css/CSSRule.idl:
2008-08-28 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin and Darin.
<rdar://problem/6182541>
https://bugs.webkit.org/show_bug.cgi?id=20202
Missing http status line from the http headers.
Add a status line to the header string.
* plugins/PluginStream.cpp:
(WebCore::PluginStream::startStream):
2008-08-28 Holger Hans Peter Freyther <zecke@selfish.org>
Rubber-stamped by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=17261
Make it possible to theme the default Url icon and enable this for
the Qt port. To have a minimal usage of #ifdef in the code the setting
of the icon was moved to a new method which comes in two flavors.
* loader/icon/IconDatabase.cpp:
(WebCore::loadDefaultIconRecord): Load or set the default icon
(WebCore::IconDatabase::defaultIcon):
2008-08-28 Holger Hans Peter Freyther <zecke@selfish.org>
Unreviewed compile fix
* platform/graphics/qt/GraphicsContextQt.cpp: Remove redefinitions
2008-08-28 Adam Roben <aroben@apple.com>
Windows (and others?) build fix
* page/Chrome.cpp: Added a missing #include.
(WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): Fixed typo.
2008-08-27 Eric Seidel <eric@webkit.org>
Reviewed by Oliver Hunt.
Qt and Cairo support from krit (and blind stab @ wx compile support)
https://bugs.webkit.org/show_bug.cgi?id=20373
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::drawPath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::setPlatformFillColor):
(WebCore::GraphicsContext::setPlatformStrokeColor):
(WebCore::GraphicsContext::setPlatformStrokeStyle):
(WebCore::GraphicsContext::strokeRect):
(WebCore::GraphicsContext::setImageInterpolationQuality):
(WebCore::GraphicsContext::imageInterpolationQuality):
(WebCore::GraphicsContext::setPlatformFillPattern):
(WebCore::GraphicsContext::setPlatformStrokePattern):
(WebCore::GraphicsContext::setPlatformFillGradient):
(WebCore::GraphicsContext::setPlatformStrokeGradient):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::strokeRect):
(WebCore::GraphicsContext::clipToImageBuffer):
(WebCore::GraphicsContext::setPlatformFillPattern):
(WebCore::GraphicsContext::setPlatformStrokePattern):
(WebCore::GraphicsContext::setPlatformFillGradient):
(WebCore::GraphicsContext::setPlatformStrokeGradient):
(WebCore::GraphicsContext::setImageInterpolationQuality):
(WebCore::GraphicsContext::imageInterpolationQuality):
* platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::clipToImageBuffer):
(WebCore::GraphicsContext::setImageInterpolationQuality):
(WebCore::GraphicsContext::imageInterpolationQuality):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::drawPath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::setPlatformFillPattern):
(WebCore::GraphicsContext::setPlatformStrokePattern):
(WebCore::GraphicsContext::setPlatformFillGradient):
2008-08-27 Eric Seidel <eric@webkit.org>
Reviewed by Oliver Hunt.
Add stroke/fill Gradient and Pattern support to GraphicsContext and update <canvas> to use it.
https://bugs.webkit.org/show_bug.cgi?id=20373
Changed pattern() to canvasPattern() on CanvasStyle to match canvasGradient()
Made Generator (aka Gradient) RefCounted so that GraphicsContext didn't
have to store large Gradient objects in the GraphicsContextState
Made Pattern RefCounted for the same reason.
Many updates to GraphicsContext to support easier drawing with
Patterns and Gradients.
* WebCore.xcodeproj/project.pbxproj: Add pre-existing GraphicsContextPrivate.h
* bindings/js/JSCanvasRenderingContext2DCustom.cpp:
(WebCore::toJS):
* css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::createGradient):
* css/CSSGradientValue.h:
* html/CanvasGradient.cpp:
(WebCore::CanvasGradient::CanvasGradient):
* html/CanvasGradient.h:
(WebCore::CanvasGradient::gradient):
(WebCore::CanvasGradient::addColorStop):
(WebCore::CanvasGradient::getColor):
* html/CanvasPattern.cpp:
* html/CanvasPattern.h:
(WebCore::CanvasPattern::pattern):
(WebCore::CanvasPattern::originClean):
* html/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::State::State):
(WebCore::CanvasRenderingContext2D::setStrokeStyle):
(WebCore::CanvasRenderingContext2D::setFillStyle):
(WebCore::CanvasRenderingContext2D::fill):
(WebCore::CanvasRenderingContext2D::stroke):
(WebCore::CanvasRenderingContext2D::fillRect):
(WebCore::CanvasRenderingContext2D::strokeRect):
* html/CanvasRenderingContext2D.h:
* html/CanvasStyle.cpp:
(WebCore::CanvasStyle::applyStrokeColor):
(WebCore::CanvasStyle::applyFillColor):
* html/CanvasStyle.h:
* platform/graphics/GeneratedImage.h:
(WebCore::GeneratedImage::GeneratedImage):
* platform/graphics/Generator.h:
* platform/graphics/Gradient.h:
(WebCore::Gradient::create):
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::fillRule):
(WebCore::GraphicsContext::setFillRule):
(WebCore::GraphicsContext::setStrokePattern):
(WebCore::GraphicsContext::setFillPattern):
(WebCore::GraphicsContext::setStrokeGradient):
(WebCore::GraphicsContext::setFillGradient):
* platform/graphics/GraphicsContext.h:
* platform/graphics/GraphicsContextPrivate.h:
(WebCore::):
(WebCore::GraphicsContextState::GraphicsContextState):
* platform/graphics/GraphicsTypes.h:
* platform/graphics/Path.h:
* platform/graphics/Pattern.h:
(WebCore::Pattern::create):
(WebCore::Pattern::tileImage):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::calculateDrawingMode):
(WebCore::GraphicsContext::drawPath):
(WebCore::fillPathWithFillRule):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::setPlatformStrokePattern):
(WebCore::GraphicsContext::setPlatformFillPattern):
(WebCore::GraphicsContext::setPlatformStrokeGradient):
(WebCore::GraphicsContext::setPlatformFillGradient):
2008-08-20 Eric Seidel <eric@webkit.org>
Reviewed by Darin and Alexey.
Close a leak of PausedTimeouts if the JavaScriptDebugServer was destroyed
with timeouts paused.
https://bugs.webkit.org/show_bug.cgi?id=20469
I attempted to clean up the memory management of PausedTimeouts, I'm not
sure the solution I came up with is "cleaner", but it's in some ways
"safer", since it no longer uses raw pointers and manual new/delete.
This also now prevents CachedPage from needlessly creating Window
objects when caching pages which didn't already have one. :)
I also made Chrome.cpp no longer depend on the JavaScript bindings
(aka JSDOMWindowBase.h), since there was no real reason for it to.
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::pauseTimeouts):
(WebCore::JSDOMWindowBase::resumeTimeouts):
* bindings/js/JSDOMWindowBase.h:
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::pauseTimeouts):
(WebCore::ScriptController::resumeTimeouts):
* bindings/js/ScriptController.h:
* history/CachedPage.cpp:
(WebCore::CachedPage::CachedPage):
(WebCore::CachedPage::restore):
* page/Chrome.cpp:
(WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
(WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
* page/JavaScriptDebugServer.cpp:
(WebCore::JavaScriptDebugServer::~JavaScriptDebugServer):
(WebCore::JavaScriptDebugServer::setJavaScriptPaused):
2008-08-27 Holger Hans Peter Freyther <zecke@selfish.org>
Unreviewed compile fix
Add the stub for the Qt port.
* WebCore.pro:
* page/qt/AccessibilityObjectQt.cpp: Added.
(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
2008-08-27 Alp Toker <alp@nuanti.com>
Reviewed by Eric.
https://bugs.webkit.org/show_bug.cgi?id=20551
[GTK] search popup crash
* platform/gtk/SearchPopupMenuGtk.cpp:
(WebCore::SearchPopupMenu::enabled):
Fix a search popup crasher by disabling the history popup since we
don't support this feature yet in the GTK+ port.
2008-08-27 Alp Toker <alp@nuanti.com>
Reviewed by Eric.
https://bugs.webkit.org/show_bug.cgi?id=20551
[GTK] curl crashers
* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::startScheduledJobs):
Remove the resource handle from the pending list before starting the
job, not afterwards. Fixes crashers in the test suite.
Test: fast/dom/clientWidthAfterDocumentIsRemoved.html
Test: fast/encoding/char-encoding.html
2008-08-27 Dirk Schulze <vbs85@gmx.de>
Reviewed by eseidel.
Fix canvas drawImage to support composite operations.
Composite had no effect on canvas elements like these:
http://philip.html5.org/tests/canvas/suite/tests/index.2d.composite.canvas.html
[CAIRO] Canvas composite don't work on canvas-elements.
https://bugs.webkit.org/show_bug.cgi?id=20548
* html/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage): pass the current composite operator to the drawImage call
2008-08-27 Mario Bensi <mbensi@pleyo.com>
Reviewed by Eric Seidel.
Fix the data content of an image with a base64.
* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::parseDataUrl): Remove the String and use only the data
Vector because the data.latin1().data() convert the data content and
the image test ( https://bugs.webkit.org/attachment.cgi?id=21726 ) is
not drawn correctly.
2008-08-27 Antti Koivisto <antti@apple.com>
Reviewed by Eric Seidel.
Crash after OK in dialog box and reloading page in secure mode
https://bugs.webkit.org/show_bug.cgi?id=20493
The new run loop spawned by a modal dialog causes a timer in the loader to run
synchronously inside didFinishLoading() deleting "this" object.
Defer all WebCore timers when a modal dialog is up. They are not
safe to execute.
* page/Chrome.cpp:
(WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
(WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
2008-08-27 Chris Marrin <cmarrin@apple.com>
Reviewed by Dave Hyatt
Memory leaks when animating transforms
https://bugs.webkit.org/show_bug.cgi?id=20532
* rendering/style/RenderStyle.cpp:
(WebCore::ScaleTransformOperation::blend):
(WebCore::RotateTransformOperation::blend):
(WebCore::SkewTransformOperation::blend):
(WebCore::TranslateTransformOperation::blend):
(WebCore::MatrixTransformOperation::blend):
* rendering/style/RenderStyle.h:
2008-08-27 Timothy Hatcher <timothy@apple.com>
Add support for support for -webkit-appearance: default-button on the Mac platform.
<rdar://problem/6173530>
Reviewed by Dave Hyatt.
* WebCore.base.exp: Export new symbols.
* platform/mac/WebCoreSystemInterface.h: Add wkAdvanceDefaultButtonPulseAnimation.
* platform/mac/WebCoreSystemInterface.mm: Ditto.
* rendering/RenderButton.cpp:
(WebCore::RenderButton::RenderButton): Remove #if PLATFORM(WIN).
(WebCore::RenderButton::setStyle): Ditto.
* rendering/RenderButton.h: Ditto.
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::adjustRepaintRect): Add a case for DefaultButtonAppearance.
(WebCore::RenderThemeMac::setButtonCellState): Set the key equivalent to the return
key if the button is default, otherwise reset the key equivalent.
(WebCore::RenderThemeMac::paintButton): If the button is default call setDefaultButtonCell:
on the window, then wkAdvanceDefaultButtonPulseAnimation before painting. Restore
the window's previous default button cell when finished.
2008-08-26 David Hyatt <hyatt@apple.com>
First cut at making form controls on OS X respect full page zoom. There are lots of bugs.
Reviewed by weinig
Added fast/forms/zoomed-controls.html
* css/CSSStyleSelector.cpp:
(WebCore::addIntrinsicMargins):
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::calcPrefWidths):
* rendering/RenderThemeMac.h:
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::adjustRepaintRect):
(WebCore::RenderThemeMac::inflateRect):
(WebCore::RenderThemeMac::baselinePosition):
(WebCore::RenderThemeMac::setControlSize):
(WebCore::RenderThemeMac::sizeForFont):
(WebCore::RenderThemeMac::sizeForSystemFont):
(WebCore::RenderThemeMac::setFontFromControlSize):
(WebCore::RenderThemeMac::paintCheckbox):
(WebCore::RenderThemeMac::setCheckboxCellState):
(WebCore::RenderThemeMac::paintRadio):
(WebCore::RenderThemeMac::setRadioCellState):
(WebCore::RenderThemeMac::setButtonPaddingFromControlSize):
(WebCore::RenderThemeMac::adjustButtonStyle):
(WebCore::RenderThemeMac::setButtonCellState):
(WebCore::RenderThemeMac::paintButton):
(WebCore::RenderThemeMac::paintMenuList):
(WebCore::RenderThemeMac::paintMenuListButton):
(WebCore::RenderThemeMac::popupInternalPaddingLeft):
(WebCore::RenderThemeMac::popupInternalPaddingRight):
(WebCore::RenderThemeMac::popupInternalPaddingTop):
(WebCore::RenderThemeMac::popupInternalPaddingBottom):
(WebCore::RenderThemeMac::setPopupButtonCellState):
(WebCore::RenderThemeMac::paintSliderTrack):
(WebCore::RenderThemeMac::paintSliderThumb):
(WebCore::RenderThemeMac::adjustSliderThumbSize):
(WebCore::RenderThemeMac::paintSearchField):
(WebCore::RenderThemeMac::adjustSearchFieldStyle):
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::paintSearchFieldResultsButton):
2008-08-27 Brady Eidson <beidson@apple.com>
Reviewed by Anders
<rdar://problem/6134133> - Crash when loading large movie as a standalone document
We hand off these loads to Quicktime which manages and spools the data itself, but we also continued
to load and buffer the data for the movie in WebCore. With large media files, this results in blowing
away the virtual address space and a crash.
* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::pluginWillHandleLoadError):
* loader/FrameLoaderClient.h: Added client method to get platform specific error for
"plugin will handle load"
* loader/MediaDocument.cpp:
(WebCore::MediaTokenizer::createDocumentStructure): Tell the MainResourceLoader to not buffer data,
and cancel the WebCore-managed load
(WebCore::MediaTokenizer::writeRawData):
(WebCore::MediaTokenizer::finish):
2008-08-26 Simon Fraser <simon.fraser@apple.com>
Reviewed by Eric Seidel
Linear timing functions should have control points 0, 0, 1, 1.
https://bugs.webkit.org/show_bug.cgi?id=20535
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::mapAnimationTimingFunction):
* rendering/style/RenderStyle.h:
2008-08-27 Adam Roben <aroben@apple.com>
Windows build fix
* WebCore.vcproj/WebCore.vcproj: Fix file extension.
2008-08-26 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
<rdar://problem/6069462> REGRESSION: webkit is returning flash objects as AXUnknown
Added platform-specific accessibilityIgnoreAttachment, which allows the platform
to determine if an attachment is ignored through accessibility. Added equivalent
methods in Gtk, Win and Mac
Test: accessibility/plugin.html
* GNUmakefile.am:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* page/AccessibilityObject.h:
* page/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
* page/gtk/AccessibilityObjectAtk.cpp: Added.
(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
* page/mac/AccessibilityObjectMac.mm: Added.
(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
* page/mac/AccessibilityObjectWrapper.h:
* page/win/AccessibilityObjectWin.cpp: Added.
(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
2008-08-26 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
<rdar://problem/5817770> can't bring up contextual menu for embedded objects in WebText
* page/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
(-[AccessibilityObjectWrapper accessibilityShowContextMenu]):
2008-08-26 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6176924> CrashTracer: [USER] 4 crashes in Safari at com.apple.WebCore: WebCore::RenderTableSection::numColumns
Tests: accessibility/table-notbody.html
* page/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
2008-08-26 Sam Weinig <sam@webkit.org>
Reviewed by Beth Dakin.
Fix typo.
* dom/DOMCoreException.h:
2008-08-26 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Fix https://bugs.webkit.org/show_bug.cgi?id=20479
<rdar://problem/6167660>
Take image redirects into account when tainting the canvas.
Test: http/tests/security/canvas-remote-read-redirect-to-remote-image.html
* html/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::drawImageFromRect):
2008-08-26 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Change canvas tainting logic to ask the image if it contains
any resources outside of its own origin. Since there is no
way to determine if SVG images contain any resources outside its
origin, we always assume it does.
* html/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::drawImageFromRect):
* platform/graphics/BitmapImage.h:
(WebCore::BitmapImage::hasSingleSecurityOrigin):
* platform/graphics/GeneratedImage.h:
(WebCore::GeneratedImage::hasSingleSecurityOrigin):
* platform/graphics/Image.h:
(WebCore::Image::hasSingleSecurityOrigin):
* platform/graphics/cg/PDFDocumentImage.h:
(WebCore::PDFDocumentImage::hasSingleSecurityOrigin):
* svg/graphics/SVGImage.h:
2008-08-26 Maxime Britto <britto@apple.com>
Reviewed by Adele.
<rdar://6159244> Pan-scrolling does not work on particular sites (starmagazine.com, nytimes.com)
This patch fixes the issues and modify the behavior of the panscroll by allowing it to jump to a parent layer when it reaches the end of its scrollable area.
This is matching the behavior of the mouse wheel when trying to scroll in a smaller layer of the page (div, textarea, ...) and when we reach the edge and keep scrolling then the whole page scrolls.
* page/EventHandler.cpp:
(WebCore::EventHandler::updateAutoscrollRenderer): if we switch to the parent layer to do the scroll we want to change the renderer for the panning
* page/EventHandler.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::panScrollFromPoint): now calls the scrollByRecursively method when it has computed the xDelta and yDelta
(WebCore::RenderLayer::scrollByRecursively): try to scroll the current layer by the xDelta and yDelta provided, if it can't it ask its parent layer to do so.
* rendering/RenderLayer.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::canBeProgramaticallyScrolled): a RenderObject must have a RenderLayer to be programatically scrolled
(WebCore::RenderObject::autoscroll): No need to check for the layer anymore since we verify it's present in the upmentionned method
(WebCore::RenderObject::panScroll): No need to check for the layer anymore too.
2008-08-25 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Darin Adler.
Bug 20247: setAttributeNode() does not work when attribute name has a capital letter in it
https://bugs.webkit.org/show_bug.cgi?id=20247
<rdar://problem/6118218>
Add a boolean parameter to getAttributeItem to choose between case sensitive and case insensitive
check. This keeps the behaviour for setAttribute / hasAttribute (case sensitive) and getAttribute
(case insensitive for HTML elements).
Test: fast/dom/Element/getAttribute-check-case-sensitivity.html
* dom/Element.cpp:
(WebCore::Element::getAttribute):
* dom/NamedAttrMap.cpp:
(WebCore::NamedAttrMap::getNamedItem):
(WebCore::NamedAttrMap::getAttributeItem):
* dom/NamedAttrMap.h:
2008-08-25 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Fix for https://bugs.webkit.org/show_bug.cgi?id=20514
<rdar://problem/6174096>
Treat SVG images as dirty when drawing to a canvas.
Test: http/tests/security/canvas-remote-read-svg-image.html
* html/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::drawImageFromRect):
* platform/graphics/Image.h:
(WebCore::Image::isSVGImage):
* svg/graphics/SVGImage.h:
(WebCore::SVGImage::isSVGImage):
2008-08-25 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Fix https://bugs.webkit.org/show_bug.cgi?id=20377
Leak in XMLHttpRequest.
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
2008-08-25 Brady Eidson <beidson@apple.com>
Reviewed by Anders
Speculative fix for <rdar://problem/6173217>
Moves the "clearArchivedResources()" call to exactly where it used to be in the old version of WebArchive code.
Also, adds a null check for m_documentLoader since DocumentLoader::stopLoading() can end up clearing it, rendering
the first null check invalid.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopAllLoaders):
2008-08-25 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim.
<rdar://problem/6157711> Heavy/Tree view selector is not grayed out if
there is no profile, can cause crash
* page/inspector/ProfilesPanel.js:
2008-08-25 Dean Jackson <dino@apple.com>
Reviewed by Dave Hyatt
Make sure 'inherit' is handled by transition property.
https://bugs.webkit.org/show_bug.cgi?id=20513
Test: transitions/inherit.html
Test: transitions/inherit-other-props.html
* css/CSSStyleSelector.cpp:
fix macro to check existence of list before getting size
2008-08-25 Anders Carlsson <andersca@apple.com>
Reviewed by Mark.
<rdar://problem/6149787> crash @ com.apple.JavaScriptCore: WTF::callOnMainThread + 37.
Initialize threading in the call to WebCoreObjCFinalizeOnMainThread. We currently assume
(safely) that any class that needs finalization on the main thread will also need to be deallocated
on the main thread, and calling initializeThreading from WebCoreObjCFinalizeOnMainThread instead of
calling it from WebCoreObjCScheduleDeallocateOnMainThread seems safer.
* platform/mac/WebCoreObjCExtras.c:
(WebCoreObjCFinalizeOnMainThread):
2008-08-25 Antti Koivisto <antti@apple.com>
Reviewed by Dan Bernstein.
Rename CachedResource::referenced() to CachedResource::hasClients() to
match previous ref() -> addClient() rename.
* loader/Cache.cpp:
(WebCore::Cache::pruneLiveResources):
(WebCore::Cache::pruneDeadResources):
(WebCore::Cache::remove):
(WebCore::Cache::getStatistics):
(WebCore::Cache::dumpLRULists):
* loader/CachedResource.cpp:
(WebCore::CachedResource::addClient):
(WebCore::CachedResource::removeClient):
(WebCore::CachedResource::setDecodedSize):
(WebCore::CachedResource::setEncodedSize):
* loader/CachedResource.h:
(WebCore::CachedResource::hasClients):
(WebCore::CachedResource::canDelete):
2008-08-25 Anthony Ricaud <rik24d@gmail.com>
Add a missing Inspector localized string for "other".
https://bugs.webkit.org/show_bug.cgi?id=20509
Reviewed by Tim Hatcher.
* English.lproj/localizedStrings.js:
2008-08-22 Kevin McCullough <kmccullough@apple.com>
Reviewed by Geoff, Mark and Tim.
<rdar://problem/6150623> JSProfiler: It would be nice if the profiles
in the console said what file and line number they came from
- Lay the foundation for getting line numbers and other data from the
JavaScript engine.
* ForwardingHeaders/VM: Added.
* ForwardingHeaders/VM/Machine.h: Added.
* page/Console.cpp: Gather the line number and file information when
profileEnd has been called, but don't use it until didFinishProfiling is
called. We won't need to wait once we remove the profiler "zombie" mode
which this patch helps pave the foundation for.
(WebCore::Console::Console):
(WebCore::Console::profileEnd):
(WebCore::Console::finishedProfiling):
* page/Console.h:
* page/InspectorController.cpp: Modify calls to
addProfileMessageToConsole to satisfy the new arguments it takes.
(WebCore::InspectorController::finishedProfiling):
(WebCore::InspectorController::addProfile):
(WebCore::InspectorController::addProfileMessageToConsole):
(WebCore::InspectorController::finishedProfiling):
* page/InspectorController.h:
2008-08-25 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Simon.
[inspector] Update the WebKit.qrc Qt resources file
Catchup with the changes in the directory.
* page/inspector/WebKit.qrc:
2008-08-25 Dirk Schulze <vbs85@gmx.de>
Reviewed by Simon.
Transformed the radian to degree, to get rotate()
in canvas work as expected.
[Qt] Canvas.rotate() doesn't work
https://bugs.webkit.org/show_bug.cgi?id=20496
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::rotate):
2008-08-24 Steve Falkenburg <sfalken@apple.com>
Add a "last chance" WM_TIMER to the Windows shared timer.
The last chance timer fires every 5 seconds to run any lost WM_TIMER based timers.
Failure to fire a timer is fatal to the cross-platform Timer code, since it won't re-schedule
timers if a timer with an earlier expiration is already pending. This results in no timers
firing from that point on.
We lose WM_TIMER messages occasionally (in the neighborhood of 1 per hour) probably due to a
buggy window message hook.
This timer will start when the first WM_TIMER is scheduled, and will
fire every 5 seconds thereafter, causing any lost timers to be fired.
Found this via one of its symptoms: leaking WebFrames. The fix prevents timers from stalling
and prevents the WebFrame leak.
Reviewed by Darin Adler, Geoff Garen.
* platform/win/SharedTimerWin.cpp:
(WebCore::):
(WebCore::TimerWindowWndProc):
(WebCore::setSharedTimerFireTime):
2008-08-24 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
- fix <rdar://problem/6065547> REGRESSION (r34879): "Subject" in unread emails in Yahoo mail is not shown in bold
Test: fast/css/font-property-priority.html
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Changed to pass the 'important' flag
to the font-property-parsing functions.
(WebCore::CSSParser::parseFontStyle): Added an 'important' argument and
changed to use it rather than the m_important member.
(WebCore::CSSParser::parseFontVariant): Ditto.
(WebCore::CSSParser::parseFontWeight): Ditto.
* css/CSSParser.h:
2008-08-24 Timothy Hatcher <timothy@apple.com>
Fixes a bug where the Inspector's UI would not animate or
fully function because JavaScript timeouts, intervals and
CSS animation timers where not firing while paused at a
a breakpoint in the inspected page.
https://bugs.webkit.org/show_bug.cgi?id=20042
Reviewed by Darin Adler.
Test: manual-tests/inspector/forzen-ui-while-paused.html
* page/JavaScriptDebugServer.cpp:
(WebCore::JavaScriptDebugServer::pauseIfNeeded):
Add a call to TimerBase::fireTimersInNestedEventLoop before
spinning the EventLoop.
2008-08-24 Rob Buis <buis@kde.org>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=20324
A change in SVG Glyph wont show up
Invalidate the glyph cache when the d attribute is set.
Test: svg/custom/glyph-setting-d-attribute.svg
* svg/SVGGlyphElement.cpp:
(WebCore::SVGGlyphElement::invalidateGlyphCache):
(WebCore::SVGGlyphElement::parseMappedAttribute):
(WebCore::SVGGlyphElement::insertedIntoDocument):
(WebCore::SVGGlyphElement::removedFromDocument):
* svg/SVGGlyphElement.h:
2008-08-24 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig.
- fix https://bugs.webkit.org/show_bug.cgi?id=13864
<rdar://problem/5451470> REGRESSION: Uninitialized value in RenderBlock::calcInlinePrefWidths()
* rendering/RenderText.cpp:
(WebCore::RenderText::trimmedPrefWidths): Moved the assignment to
beginWS and endWS before the early return to ensure that they are
initialized in that case.
2008-08-23 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Rubber-stamped by Mark Rowe.
Remove modelines.
* WebCore.pro:
* bridge/testbindings.cpp:
* dom/DocPtr.h:
* loader/SubstituteData.h:
* page/Chrome.cpp:
* page/Chrome.h:
* page/ChromeClient.h:
* page/Frame.h:
* page/FrameLoadRequest.h:
* page/FrameTree.cpp:
* page/FrameTree.h:
* page/Page.h:
* page/mac/ChromeMac.mm:
* platform/network/HTTPHeaderMap.h:
* platform/network/ResourceErrorBase.cpp:
* platform/network/ResourceErrorBase.h:
* platform/network/ResourceHandleInternal.h:
* platform/network/ResourceRequestBase.cpp:
* platform/network/ResourceRequestBase.h:
* platform/network/ResourceResponseBase.cpp:
* platform/network/ResourceResponseBase.h:
* platform/network/cf/ResourceError.h:
* platform/network/cf/ResourceRequest.h:
* platform/network/cf/ResourceRequestCFNet.h:
* platform/network/cf/ResourceResponse.h:
* platform/network/cf/ResourceResponseCFNet.h:
* platform/network/curl/ResourceError.h:
* platform/network/curl/ResourceRequest.h:
* platform/network/curl/ResourceResponse.h:
* platform/network/mac/ResourceError.h:
* platform/network/mac/ResourceErrorMac.mm:
* platform/network/mac/ResourceRequest.h:
* platform/network/mac/ResourceRequestMac.mm:
* platform/network/mac/ResourceResponse.h:
* platform/network/mac/ResourceResponseMac.mm:
* platform/network/qt/ResourceError.h:
* platform/network/qt/ResourceRequest.h:
* platform/network/qt/ResourceResponse.h:
* platform/network/soup/CookieJarSoup.cpp:
* platform/network/soup/ResourceError.h:
* platform/network/soup/ResourceRequest.h:
* platform/network/soup/ResourceResponse.h:
2008-08-23 Dan Bernstein <mitz@apple.com>
Reviewed by Dave Hyatt.
- fix <rdar://problem/6065143> Reflowed image in first line of table doesn't affect baseline
Test: fast/table/vertical-align-baseline.html
* rendering/RenderTable.cpp:
(WebCore::RenderTable::getBaselineOfFirstLineBox): Added. Returns the
baseline of the first table row, if there is one, -1 otherwise.
* rendering/RenderTable.h:
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::baselinePosition): Changed to follow the
CSS2.1 definition of the baseline of a table cell.
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::getBaselineOfFirstLineBox): Added. Returns
the baseline of the first row in the section.
* rendering/RenderTableSection.h:
2008-08-18 Jon Honeycutt <jhoneycutt@apple.com>
Add SPI to make a Windows WebView transparent.
Reviewed by Dan Bernstein.
* platform/graphics/GraphicsContext.h: Add a parameter, hasAlpha, that
determines whether the created context has an alpha channel.
* platform/graphics/win/GraphicsContextCGWin.cpp:
(WebCore::CGContextWithHDC):
2008-08-22 Timothy Hatcher <timothy@apple.com>
Rolls out r35834 because it caused a regression in the Inspector's
Console where some expressions always threw a syntax error.
https://bugs.webkit.org/show_bug.cgi?id=20487
* page/inspector/Console.js:
(Console.prototype._evalInInspectedWindow): Removes parenthesis
around the expression.
2008-08-22 Timothy Hatcher <timothy@apple.com>
Makes getStyleProperty return a value for the overflow property
when overflow-x and overflow-y are equal.
https://bugs.webkit.org/show_bug.cgi?id=20485
Reviewed by Dan Bernstein.
Test: fast/css/overflow-property.html
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::getPropertyValue):
2008-08-22 Timothy Hatcher <timothy@apple.com>
Fixes a bug where while editing in the Inspector the
sidebar scroll position would jump to the top.
https://bugs.webkit.org/show_bug.cgi?id=20484
Reviewed by Darin Adler.
* page/inspector/treeoutline.js:
(TreeOutline._removeChildren): Remove the offsetTop call that
was forcing a layout, since layout causes scroll positions
to be clamped to the new scrollHeight/Width. Layout will happen
normally when needed.
2008-08-22 Kevin Ollivier <kevino@theolliviers.com>
wx build fix. Add AccessibilityTable sources.
* WebCoreSources.bkl:
2008-08-21 Dan Bernstein <mitz@apple.com>
Reviewed by Jon Honeycutt and Alexey Proskuryakov.
- fix <rdar://problem/6162701> WebKit should correct Geeza Pro's font metrics
Test: platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformInit): Add 8% to Geeza Pro's reported
ascent and 100% to its reported descent.
2008-08-21 Kalle Vahlman <kalle.vahlman@movial.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=20267
[GTK] Crash on some pages due to a plugin
Fix handling of badly formatted and empty plugin mime descriptions
* plugins/gtk/PluginPackageGtk.cpp:
(WebCore::PluginPackage::fetchInfo):
2008-08-21 Kevin Watters <kevinwatters@gmail.com>
Reviewed by Darin Adler.
Follow other ports (and IE) in ImageSourceWx.cpp never to return an
animated GIF frame duration of less than 50ms.
* platform/graphics/wx/ImageSourceWx.cpp:
(WebCore::ImageSource::frameDurationAtIndex):
2008-08-21 Maxime Britto <britto@apple.com>
Reviewed by Kevin McCullough.
Test: fast/events/autoscroll-nonscrollable-iframe-in-scrollable-div.html
https://bugs.webkit.org/show_bug.cgi?id=20451
rdar://problem/6166435 Inspector doesn't auto scroll when selecting text (20451)
When we climb up the rendering tree looking for a scrollable renderer, we need to be able to jump outside of an iframe.
This way we can see if what is embedding the iframe can be scrolled even if the iframe content can't.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseDraggedEvent): when we reach the document node and it can't be scrolled we set the next parent as the document's owner element if it exists.
(WebCore::EventHandler::handleMousePressEvent): ditto
2008-08-21 Anthony Ricaud <rik24d@gmail.com>
Small optimization for when the dividers in the Inspector's
Resources panel are updated.
Reviewed by Tim Hatcher.
* page/inspector/ResourcesPanel.js:
(WebInsector.ResourcesPanel.prototype._updateGraphDividersIfNeeded):
Combind a for loop and clone the divider element.
2008-08-21 Chris Marrin <cmarrin@apple.com>
Allow 0 (without units) for Time eg. duration
Fix for https://bugs.webkit.org/show_bug.cgi?id=20467
Reviewed by Dave Hyatt.
Test: css1/units/zero-duration-without-units.html
* css/CSSParser.cpp:
(WebCore::CSSParser::validUnit):
2008-08-21 Timothy Hatcher <timothy@apple.com>
Make deleting all text while editing a DOM attribute in
the Inspector delete the attribute. This also fixes
an exception that would happen before.
https://bugs.webkit.org/show_bug.cgi?id=20472
Reviewed by Kevin McCullough.
* page/inspector/ElementsPanel.js:
(WebInspector.DOMNodeTreeElement.prototype._attributeEditingCommitted):
Don't check for hasAttributes on the parseElement, continuing
through the function will correctly remove the attribute.
If the parseElement is null, call _editingCancelled not
editingCancelled, this fixes an exception.
2008-08-21 Timothy Hatcher <timothy@apple.com>
Update the Inspector's Metrics pane when editing in
the Styles pane. This makes sure the metrics shown
always match what the Styles pane shows.
https://bugs.webkit.org/show_bug.cgi?id=20470
Reviewed by Kevin McCullough.
* page/inspector/ElementsPanel.js:
(WebInspector.ElementsPanel): Add event listeners for
the "style edited" and "style property toggled" events,
so the Metrics pane is updated.
(WebInspector.ElementsPanel.prototype._stylesPaneEdited):
Update the Metrics pane.
* page/inspector/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype.toggleEnabled):
Dispatch the "style property toggled" event.
(WebInspector.StylePropertyTreeElement.prototype.editingCancelled):
Dispatch the "style edited" event when the CSS text is restored.
(WebInspector.StylePropertyTreeElement.prototype.applyStyleText):
Dispatch the "style edited" event.
2008-08-21 Timothy Hatcher <timothy@apple.com>
Make the Inspector's Metrics sidebar pane editable.
https://bugs.webkit.org/show_bug.cgi?id=17218
rdar://problem/5732818
Reviewed by Kevin McCullough.
* page/inspector/ElementsPanel.js:
(WebInspector.ElementsPanel): Add an event listener for
the "metrics edited" event, so the Styles pane is updated.
* page/inspector/MetricsSidebarPane.js:
(WebInspector.MetricsSidebarPane.prototype.update): Remember the node
so future updates work. Add a double click event listener for the
metric values to start editing.
(WebInspector.MetricsSidebarPane.prototype.startEditing):
Call WebInspector.startEditing with some context.
(WebInspector.MetricsSidebarPane.prototype.editingCancelled):
(WebInspector.MetricsSidebarPane.prototype.editingCommitted):
Set the user input on the elements inline style. Fire the
"metrics edited" event.
2008-08-21 Steve Falkenburg <sfalken@apple.com>
Fix a race condition in Windows timer code.
Timer function could end up being called with a 0 timer, leading to a Windows exception.
Don't post a timer message if one is already pending.
Reviewed by Ada Chan.
* platform/win/SharedTimerWin.cpp:
(WebCore::TimerWindowWndProc):
(WebCore::clearTimer):
(WebCore::queueTimerProc):
(WebCore::setSharedTimerFireTime):
2008-08-21 Anthony Ricaud <rik24d@gmail.com>
After trying to add the expression, try again with quotes for
easier edition.
https://bugs.webkit.org/show_bug.cgi?id=20466
Reviewed by Tim Hatcher.
* page/inspector/ObjectPropertiesSection.js: Added an
evaluateExpression function.
2008-08-21 Anthony Ricaud <rik24d@gmail.com>
Perform Inspector searches on search event to clear results when
clicking the cross to empty it. Delete the lastQuery when the field
is emptied in order to perform the search if exactly the same query
is entered next.
https://bugs.webkit.org/show_bug.cgi?id=20462
Reviewed by Tim Hatcher.
* page/inspector/inspector.js:
2008-08-21 Marco Barisione <marco.barisione@collabora.co.uk>
Reviewed by Mark Rowe.
http://bugs.webkit.org/show_bug.cgi?id=19656
[SOUP] The gio code should call didFail() instead of
didFinishLoading() in case of error
In case of error call didFail() instead of didReceiveResponse() and
didFinishLoading().
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::networkErrorForFile):
(WebCore::readCallback):
(WebCore::openCallback):
(WebCore::queryInfoCallback):
2008-08-20 Mark Rowe <mrowe@apple.com>
Reviewed by Jon Honeycutt.
Fix build failure.
* bridge/c/c_instance.cpp:
(KJS::Bindings::CInstance::getPropertyNames): Declare count as uint32_t rather than unsigned
as that is what NPEnumerationFunctionPtr is declared as accepting.
2008-08-20 Mark Rowe <mrowe@apple.com>
Reviewed by Dan Bernstein.
Build fix. Handle kCGInterpolationMedium in switch statements if it is available.
* platform/graphics/GraphicsContext.h:
(WebCore::):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::setImageInterpolationQuality):
(WebCore::GraphicsContext::imageInterpolationQuality):
2008-08-20 Dan Bernstein <mitz@apple.com>
Rubber-stamped by John Sullivan.
- rename shouldUpdateWhileHidden to shouldUpdateWhileOffscreen and
rename related methods and variables accordingly.
* WebCore.base.exp:
* page/FrameView.cpp:
(WebCore::FrameViewPrivate::FrameViewPrivate):
(WebCore::FrameView::shouldUpdateWhileOffscreen):
(WebCore::FrameView::setShouldUpdateWhileOffscreen):
* page/FrameView.h:
* platform/ScrollView.h:
* platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::updateContents):
2008-08-20 Brady Eidson <beidson@apple.com>
Reviewed by Mitzpettel
<rdar://problem/6163636> - Many images broken in Mail
This can be traced back to the preload scanner. With that change, CachedResources are created a lot
sooner than before and confuse the WebArchive machinery.
When referencing WebArchive subresources directly through the WebKit API it is appropriate to ignore
such CachedResources since they are placeholders and have not been submitted to the ResourceLoadDelegate
machinery and nothing is known about where the data will eventually come from.
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::subresource): Ignore a CachedResource if its preloadResult is
CachedResource::PreloadReferenced.
2008-08-20 Holger Hans Peter Freyther <zecke@selfish.org>
Unreviewed compile fix
Catch up with the JSValue::type elimination.
* bridge/qt/qt_instance.cpp:
(KJS::Bindings::QtRuntimeObjectImp::construct):
(KJS::Bindings::QtInstance::defaultValue):
* bridge/qt/qt_runtime.cpp:
(KJS::Bindings::QtRuntimeConnectionMethod::call):
2008-08-20 Chris Teague <chris.teague@gmail.com>
Reviewed by Mark Rowe.
Fix https://bugs.webkit.org/show_bug.cgi?id=20449
Bug 20449: Build fails if LOW_BANDWIDTH_DISPLAY is defined
* ChangeLog:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
2008-08-20 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dave Hyatt
getComputedStyle() for webkitTransform should return a transform
that does not have the transform origin baked into it.
https://bugs.webkit.org/show_bug.cgi?id=20464
Test: fast/css/getComputedStyle-transform.html
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::computedTransform):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::applyTransform):
* rendering/style/RenderStyle.h:
2008-08-20 Josh Aas <joshmoz@gmail.com>
Reviewed and landed by Anders.
<rdar://problem/6163636>
rename NPCocoaEvent's "event" struct to "data" (20446)
* bridge/npapi.h:
(_NPCocoaEvent::):
2008-08-20 Beth Dakin <bdakin@apple.com>
Reviewed by Darin Adler.
Fix for <rdar://problem/6145626>
This patch fixes a number of remaining problems getting
disconnected frames to work correctly with markAllMatchesForText()
and findString(). Details inline.
This was a static helper function in Frame, but this patch requires
the same functionality in Editor, so I just added it as a function
on Node.
* dom/Node.cpp:
(WebCore::Node::isInShadowTree):
* dom/Node.h:
* editing/Editor.cpp:
(WebCore::Editor::insideVisibleArea): Returns false if
excludeFromTextSearch() is true.
In a normal (non-disconnected) frame, findString returns a range of
the document node if the text is not found in the frame. I changed
firstVisibleRange and lastVisibleRange to match that behavior when
the text is not found
(WebCore::Editor::firstVisibleRange):
(WebCore::Editor::lastVisibleRange):
Here are the bulk of the changes in the patch. A lot of text was
not being found in disconnected frames because I failed to account
for all of the possible problems associated with shadow trees. That
is fixed here.
(WebCore::Editor::nextVisibleRange):
* editing/Editor.h:
excludeFromTextSearch() is new. It allows a WebKit client to mark a
frame as not-text-searchable through SPI.
* WebCore.base.exp:
* page/Frame.cpp:
(WebCore::Frame::excludeFromTextSearch):
(WebCore::Frame::setExcludeFromTextSearch):
(WebCore::FramePrivate::FramePrivate):
* page/Frame.h:
* page/FramePrivate.h:
(WebCore::Frame::findString):
(WebCore::Frame::markAllMatchesForText): I kept running into an
assertion failure in paining code because of the forced paint on
empty visible rects.
2008-08-20 Timothy Hatcher <timothy@apple.com>
Adds a positon box to the Inspector's Metrics sidebar
pane. When an element is not statically positioned, there
is now a position box that show top, right, bottom and
left computed values.
Reviewed by Kevin McCullough.
* English.lproj/localizedStrings.js: Updated the strings.
* page/inspector/MetricsSidebarPane.js:
(WebInspector.MetricsSidebarPane.prototype.update):
Renamed the boxPartValue function to createBoxPartElement
and made it create the entire element. Made it understand
how to get position style properties. Don't use the figure dash
when 0px is used for positions, since the 0 is meaningful there.
Instead use the figure dash when a position is auto.
* page/inspector/inspector.css: Added a new rule for position.
2008-08-20 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin
Qt build fix
* WebCore.pro:
2008-08-20 Dan Bernstein <mitz@apple.com>
Reviewed by Anders Carlsson.
- avoid using a deprecated NSScroller method on Leopard
* platform/mac/PlatformScrollBarMac.mm:
(WebCore::PlatformScrollbar::updateThumbPosition):
(WebCore::PlatformScrollbar::updateThumbProportion):
2008-08-20 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Oliver Hunt.
Gtk build fix
* GNUmakefile.am:
* page/AccessibilityTable.cpp: Change nil to 0
(WebCore::AccessibilityTable::cellForColumnAndRow):
2008-08-19 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Geoff Garen.
Bring back shared JSGlobalData and implicit locking, because too many clients rely on it.
* ForwardingHeaders/kjs/JSLock.h: Added.
* WebCore.vcproj/WebCore.vcproj:
* bindings/js/GCController.cpp:
(WebCore::collect):
(WebCore::GCController::gcTimerFired):
(WebCore::GCController::garbageCollectNow):
* bindings/js/JSCustomSQLStatementCallback.cpp:
(WebCore::JSCustomSQLStatementCallback::handleEvent):
* bindings/js/JSCustomSQLStatementErrorCallback.cpp:
(WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
* bindings/js/JSCustomSQLTransactionCallback.cpp:
(WebCore::JSCustomSQLTransactionCallback::handleEvent):
* bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
(WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
* bindings/js/JSCustomVoidCallback.cpp:
(WebCore::JSCustomVoidCallback::handleEvent):
* bindings/js/JSCustomXPathNSResolver.cpp:
(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::DOMWindowTimer::~DOMWindowTimer):
(WebCore::JSDOMWindowBase::clear):
(WebCore::JSDOMWindowBase::timerFired):
* bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
* bindings/js/JSEventListener.cpp:
(WebCore::JSAbstractEventListener::handleEvent):
* bindings/js/JSNSResolver.cpp:
(WebCore::JSNSResolver::lookupNamespaceURI):
* bindings/js/JSNodeFilterCondition.cpp:
(WebCore::JSNodeFilterCondition::acceptNode):
* bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::execute):
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::evaluate):
(WebCore::ScriptController::clearWindowShell):
(WebCore::ScriptController::createHTMLEventHandler):
(WebCore::ScriptController::createSVGEventHandler):
(WebCore::ScriptController::initScript):
(WebCore::ScriptController::updateDocument):
(WebCore::ScriptController::bindingRootObject):
(WebCore::ScriptController::windowScriptNPObject):
(WebCore::ScriptController::createScriptObjectForPluginElement):
(WebCore::ScriptController::clearScriptObjects):
* bindings/js/ScriptControllerMac.mm:
(WebCore::ScriptController::windowScriptObject):
* bindings/objc/WebScriptObject.mm:
(_didExecute):
(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject evaluateWebScript:]):
(-[WebScriptObject setValue:forKey:]):
(-[WebScriptObject valueForKey:]):
(-[WebScriptObject removeWebScriptKey:]):
(-[WebScriptObject stringRepresentation]):
(-[WebScriptObject webScriptValueAtIndex:]):
(-[WebScriptObject setWebScriptValueAtIndex:value:]):
(+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
* bridge/NP_jsobject.cpp:
(_NPN_InvokeDefault):
(_NPN_Invoke):
(_NPN_Evaluate):
(_NPN_GetProperty):
(_NPN_SetProperty):
(_NPN_RemoveProperty):
(_NPN_HasProperty):
(_NPN_HasMethod):
(_NPN_Enumerate):
* bridge/c/c_class.cpp:
(KJS::Bindings::CClass::~CClass):
(KJS::Bindings::CClass::methodsNamed):
(KJS::Bindings::CClass::fieldNamed):
* bridge/c/c_instance.cpp:
(KJS::Bindings::CInstance::invokeMethod):
(KJS::Bindings::CInstance::invokeDefaultMethod):
(KJS::Bindings::CInstance::getPropertyNames):
* bridge/c/c_runtime.cpp:
(KJS::Bindings::CField::valueFromInstance):
(KJS::Bindings::CField::setValueToInstance):
* bridge/c/c_utility.cpp:
(KJS::Bindings::convertValueToNPVariant):
(KJS::Bindings::convertNPVariantToValue):
* bridge/jni/jni_class.cpp:
(JavaClass::JavaClass):
(JavaClass::~JavaClass):
* bridge/jni/jni_instance.cpp:
(JavaInstance::stringValue):
* bridge/jni/jni_jsobject.mm:
(JavaJSObject::call):
(JavaJSObject::eval):
(JavaJSObject::getMember):
(JavaJSObject::setMember):
(JavaJSObject::removeMember):
(JavaJSObject::getSlot):
(JavaJSObject::setSlot):
(JavaJSObject::toString):
(JavaJSObject::convertValueToJObject):
(JavaJSObject::convertJObjectToValue):
* bridge/jni/jni_objc.mm:
(KJS::Bindings::dispatchJNICall):
* bridge/jni/jni_runtime.cpp:
(appendClassName):
(JavaMethod::signature):
* bridge/jni/jni_runtime.h:
(KJS::Bindings::JavaString::JavaString):
(KJS::Bindings::JavaString::_commonInit):
(KJS::Bindings::JavaString::~JavaString):
(KJS::Bindings::JavaString::UTF8String):
* bridge/jni/jni_utility.cpp:
(KJS::Bindings::convertValueToJValue):
* bridge/npruntime.cpp:
(_NPN_GetStringIdentifier):
* bridge/objc/objc_instance.mm:
(ObjcInstance::moveGlobalExceptionToExecState):
(ObjcInstance::invokeMethod):
(ObjcInstance::invokeDefaultMethod):
(ObjcInstance::setValueOfUndefinedField):
(ObjcInstance::getValueOfUndefinedField):
* bridge/objc/objc_runtime.mm:
(ObjcField::valueFromInstance):
(ObjcField::setValueToInstance):
* bridge/objc/objc_utility.mm:
(KJS::Bindings::convertValueToObjcValue):
(KJS::Bindings::convertNSStringToString):
(KJS::Bindings::convertObjcValueToValue):
* bridge/qt/qt_instance.cpp:
(KJS::Bindings::QtRuntimeObjectImp::removeFromCache):
(KJS::Bindings::QtInstance::~QtInstance):
(KJS::Bindings::QtInstance::getQtInstance):
(KJS::Bindings::QtInstance::getRuntimeObject):
* bridge/qt/qt_runtime.cpp:
(KJS::Bindings::convertValueToQVariant):
(KJS::Bindings::convertQVariantToValue):
(KJS::Bindings::QtRuntimeMetaMethod::call):
(KJS::Bindings::QtRuntimeConnectionMethod::call):
(KJS::Bindings::QtConnectionObject::QtConnectionObject):
(KJS::Bindings::QtConnectionObject::execute):
* bridge/runtime.cpp:
(KJS::Bindings::Instance::createRuntimeObject):
* bridge/testbindings.cpp:
(main):
* bridge/testbindings.mm:
(main):
* bridge/testqtbindings.cpp:
(main):
* dom/Document.cpp:
(WebCore::Document::~Document):
* dom/Node.cpp:
(WebCore::Node::setDocument):
* history/CachedPage.cpp:
(WebCore::CachedPage::CachedPage):
(WebCore::CachedPage::restore):
(WebCore::CachedPage::clear):
* loader/FrameLoader.cpp:
(WebCore::getString):
* page/InspectorController.cpp:
(WebCore::ConsoleMessage::ConsoleMessage):
(WebCore::XMLHttpRequestResource::XMLHttpRequestResource):
(WebCore::XMLHttpRequestResource::~XMLHttpRequestResource):
(WebCore::getResourceDocumentNode):
(WebCore::search):
(WebCore::inspectedWindow):
(WebCore::wrapCallback):
(WebCore::currentCallFrame):
(WebCore::profiles):
(WebCore::InspectorController::focusNode):
(WebCore::InspectorController::inspectedWindowScriptObjectCleared):
(WebCore::InspectorController::addDatabaseScriptResource):
(WebCore::InspectorController::addScriptProfile):
* page/JavaScriptCallFrame.cpp:
(WebCore::JavaScriptCallFrame::evaluate):
* page/JavaScriptProfileNode.cpp:
(WebCore::getTotalTime):
(WebCore::getSelfTime):
(WebCore::getTotalPercent):
(WebCore::getSelfPercent):
(WebCore::getNumberOfCalls):
(WebCore::getChildren):
(WebCore::getVisible):
* page/Page.cpp:
* page/mac/FrameMac.mm:
* plugins/PluginView.cpp:
(WebCore::PluginView::start):
(WebCore::getString):
(WebCore::PluginView::performRequest):
(WebCore::PluginView::bindingInstance):
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::paint):
(WebCore::PluginView::handleKeyboardEvent):
(WebCore::PluginView::handleMouseEvent):
(WebCore::PluginView::setNPWindowRect):
(WebCore::PluginView::stop):
(WebCore::PluginView::init):
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::setNPWindowRect):
(WebCore::PluginView::stop):
(WebCore::PluginView::init):
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::dispatchNPEvent):
(WebCore::PluginView::handleKeyboardEvent):
(WebCore::PluginView::handleMouseEvent):
(WebCore::PluginView::setNPWindowRect):
(WebCore::PluginView::stop):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::clearResponse):
(WebCore::XMLHttpRequest::didFinishLoading):
(WebCore::XMLHttpRequest::didReceiveData):
2008-08-19 Eric Seidel <eric@webkit.org>
Reviewed by Geoff Garen.
Add the beginnings of Skia graphics support to WebCore
as I try to begin the long process of un-forking the changes
needed to WebCore to make Andriod's WebCore build.
I'll follow this up with actual *Skia.cpp files in a separate patch.
* platform/graphics/AffineTransform.h:
* platform/graphics/FloatPoint.h:
* platform/graphics/FloatRect.h:
* platform/graphics/Gradient.h:
* platform/graphics/GraphicsContext.h:
* platform/graphics/Image.h:
* platform/graphics/ImageBuffer.h:
* platform/graphics/ImageSource.h:
* platform/graphics/IntPoint.h:
* platform/graphics/IntRect.h:
* platform/graphics/Path.h:
* platform/graphics/Pattern.h:
* svg/graphics/SVGPaintServerPattern.h:
* svg/graphics/SVGPaintServerSolid.h:
2008-08-19 Steve Falkenburg <sfalken@apple.com>
Fix Windows build more.
* WebCore.vcproj/WebCore.vcproj:
2008-08-19 Steve Falkenburg <sfalken@apple.com>
Fix Windows build.
* page/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::canSetFocusAttribute):
2008-08-19 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
<rdar://problem/4003764> Expose tables as AXTables
Tests: accessibility/table-attributes.html
accessibility/table-cell-spans.html
accessibility/table-cells.html
accessibility/table-detection.html
accessibility/table-sections.html
accessibility/table-with-rules.html
* WebCore.xcodeproj/project.pbxproj:
* page/AXObjectCache.cpp:
(WebCore::AXObjectCache::get):
* page/AccessibilityObject.h:
(WebCore::):
(WebCore::AccessibilityObject::isDataTable):
(WebCore::AccessibilityObject::isTableRow):
(WebCore::AccessibilityObject::isTableColumn):
(WebCore::AccessibilityObject::isTableCell):
* page/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::canSetFocusAttribute):
* page/AccessibilityTable.cpp: Added.
(WebCore::AccessibilityTable::AccessibilityTable):
(WebCore::AccessibilityTable::~AccessibilityTable):
(WebCore::AccessibilityTable::create):
(WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
(WebCore::AccessibilityTable::clearChildren):
(WebCore::AccessibilityTable::addChildren):
(WebCore::AccessibilityTable::headerContainer):
(WebCore::AccessibilityTable::columns):
(WebCore::AccessibilityTable::rows):
(WebCore::AccessibilityTable::rowHeaders):
(WebCore::AccessibilityTable::columnHeaders):
(WebCore::AccessibilityTable::cells):
(WebCore::AccessibilityTable::columnCount):
(WebCore::AccessibilityTable::rowCount):
(WebCore::AccessibilityTable::cellForColumnAndRow):
(WebCore::AccessibilityTable::roleValue):
(WebCore::AccessibilityTable::accessibilityIsIgnored):
(WebCore::AccessibilityTable::title):
(WebCore::AccessibilityTable::isDataTable):
* page/AccessibilityTable.h: Added.
* page/AccessibilityTableCell.cpp: Added.
(WebCore::AccessibilityTableCell::AccessibilityTableCell):
(WebCore::AccessibilityTableCell::~AccessibilityTableCell):
(WebCore::AccessibilityTableCell::create):
(WebCore::AccessibilityTableCell::accessibilityIsIgnored):
(WebCore::AccessibilityTableCell::rowIndexRange):
(WebCore::AccessibilityTableCell::columnIndexRange):
* page/AccessibilityTableCell.h: Added.
(WebCore::AccessibilityTableCell::isTableCell):
(WebCore::AccessibilityTableCell::roleValue):
* page/AccessibilityTableColumn.cpp: Added.
(WebCore::AccessibilityTableColumn::AccessibilityTableColumn):
(WebCore::AccessibilityTableColumn::~AccessibilityTableColumn):
(WebCore::AccessibilityTableColumn::create):
(WebCore::AccessibilityTableColumn::setParentTable):
(WebCore::AccessibilityTableColumn::elementRect):
(WebCore::AccessibilityTableColumn::size):
(WebCore::AccessibilityTableColumn::children):
(WebCore::AccessibilityTableColumn::headerObject):
(WebCore::AccessibilityTableColumn::headerObjectForSection):
(WebCore::AccessibilityTableColumn::addChildren):
* page/AccessibilityTableColumn.h: Added.
(WebCore::AccessibilityTableColumn::parentObject):
(WebCore::AccessibilityTableColumn::roleValue):
(WebCore::AccessibilityTableColumn::accessibilityIsIgnored):
(WebCore::AccessibilityTableColumn::isTableColumn):
(WebCore::AccessibilityTableColumn::setColumnIndex):
(WebCore::AccessibilityTableColumn::columnIndex):
* page/AccessibilityTableHeaderContainer.cpp: Added.
(WebCore::AccessibilityTableHeaderContainer::AccessibilityTableHeaderContainer):
(WebCore::AccessibilityTableHeaderContainer::~AccessibilityTableHeaderContainer):
(WebCore::AccessibilityTableHeaderContainer::create):
(WebCore::AccessibilityTableHeaderContainer::children):
(WebCore::AccessibilityTableHeaderContainer::elementRect):
(WebCore::AccessibilityTableHeaderContainer::size):
(WebCore::AccessibilityTableHeaderContainer::addChildren):
* page/AccessibilityTableHeaderContainer.h: Added.
(WebCore::AccessibilityTableHeaderContainer::roleValue):
(WebCore::AccessibilityTableHeaderContainer::setParentTable):
(WebCore::AccessibilityTableHeaderContainer::parentObject):
(WebCore::AccessibilityTableHeaderContainer::accessibilityIsIgnored):
* page/AccessibilityTableRow.cpp: Added.
(WebCore::AccessibilityTableRow::AccessibilityTableRow):
(WebCore::AccessibilityTableRow::~AccessibilityTableRow):
(WebCore::AccessibilityTableRow::create):
(WebCore::AccessibilityTableRow::accessibilityIsIgnored):
(WebCore::AccessibilityTableRow::headerObject):
* page/AccessibilityTableRow.h: Added.
(WebCore::AccessibilityTableRow::isTableRow):
(WebCore::AccessibilityTableRow::roleValue):
(WebCore::AccessibilityTableRow::setRowIndex):
(WebCore::AccessibilityTableRow::rowIndex):
* page/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(RoleEntry::):
(-[AccessibilityObjectWrapper roleDescription]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
2008-08-19 Steve Falkenburg <sfalken@apple.com>
Build fix.
Add buildfailed support to stop builds early (preventing inaccurate error messages).
Add missing post-build rule to Release.
* WebCore.vcproj/QTMovieWin.vcproj:
2008-08-19 Keishi Hattori <casey.hattori@gmail.com>
Added support for console.count in the inspector.
Reviewed by Geoff Garen.
* page/Console.cpp:
(WebCore::Console::count):
* page/Console.h:
* page/Console.idl: Added console.count.
* page/InspectorController.cpp:
(WebCore::InspectorController::didCommitLoad): Clears m_counts.
(WebCore::InspectorController::count): Updates the count number
sing "title@source:line" as the identifier, and adds a
message to the console.
* page/InspectorController.h: Added m_counts.
2008-08-19 Keishi Hattori <casey.hattori@gmail.com>
Clear console.time timers when changing page.
Reviewed by Geoff Garen.
* page/InspectorController.cpp:
(WebCore::InspectorController::didCommitLoad):
2008-08-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele.
Fix for <rdar://problem/6154695> Full-page movies flicker while playing
https://bugs.webkit.org/show_bug.cgi?id=20404
Ignore setVisible() when visibility doesn't change.
* platform/graphics/mac/MediaPlayerPrivateQTKit.h:
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::setVisible):
2008-08-19 Timothy Hatcher <timothy@apple.com>
Fixes a bug in the Profile view where switching sort order, then
switching from heavy to tree mode would show the tree in the
previous sort order.
https://bugs.webkit.org/show_bug.cgi?id=20441
Reviewed by Kevin McCullough.
* page/inspector/ProfileView.js:
(WebInspector.ProfileView.prototype._changeView): Call _sortProfile
on the next profile before assigning it to this.profile.
(WebInspector.ProfileView.prototype._sortData): Call _sortProfile.
(WebInspector.ProfileView.prototype._sortProfile): Moves from
_sortData and takes a profile argument. If the profile passed in
matches the this.profile, then call refresh.
2008-08-18 Timothy Hatcher <timothy@apple.com>
Changed the default sort order now that heavy view is the default.
Also fixes a bug where the heavy profile was not sorted at first.
https://bugs.webkit.org/show_bug.cgi?id=20440
Reviewed by Kevin McCullough.
* page/inspector/ProfileView.js:
(WebInspector.ProfileView): Changed the default sort column. Also assign
heavyProfile to profile, so the sortSelfTimeDescending call happens
on the heavy profile before assigning to this.profile.
2008-08-18 Timothy Hatcher <timothy@apple.com>
Add support for editing DOM properties and scope variables by double
clicking a property to enter edit mode.
https://bugs.webkit.org/show_bug.cgi?id=20415
Reviewed by Kevin McCullough.
* page/inspector/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertiesSection): Set editable to true by default.
(WebInspector.ObjectPropertiesSection.prototype.onpopulate):
Factored out code into update, and calls update.
(WebInspector.ObjectPropertiesSection.prototype.update): Moved from onpopulate.
Call removeChildren since this method can be called multiple times now.
(WebInspector.ObjectPropertyTreeElement): Pass an empty title, the title
gets made later in onattach.
(WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): Don't return early
if shouldRefreshChildren is true. Call removeChildren since this method can be
called multiple times now.
(WebInspector.ObjectPropertyTreeElement.prototype.ondblclick): Call startEditing.
(WebInspector.ObjectPropertyTreeElement.prototype.onattach): Call update.
(WebInspector.ObjectPropertyTreeElement.prototype.update): Update the title for
this element (code moved from the constructor.)
(WebInspector.ObjectPropertyTreeElement.prototype.updateSiblings): Recreate all
sibling property elements.
(WebInspector.ObjectPropertyTreeElement.prototype.startEditing): Call
WebInspector.startEditing after rememebring some context.
(WebInspector.ObjectPropertyTreeElement.prototype.editingEnded): Reset the scrollLeft
for the list element, since it might have scrolled during editing.
(WebInspector.ObjectPropertyTreeElement.prototype.editingCancelled): Call editingEnded
then restore the state from the context. Then call update to restore the title.
(WebInspector.ObjectPropertyTreeElement.prototype.editingCommitted): Call editingCancelled
if the user input and the previous input are the same. Call editingEnded, then call applyExpression
to commit the user input.
(WebInspector.ObjectPropertyTreeElement.prototype.applyExpression): Evaluates the input expression
and stores the result on the object for the property name of this element. If the expression is
empty, delete the property and remove the tree element.
* page/inspector/ScopeChainSidebarPane.js:
(WebInspector.ScopeChainSidebarPane.prototype.update): Set the editInSelectedCallFrameWhenPaused
property on each ObjectPropertiesSection.
(WebInspector.ScopeVariableTreeElement.prototype.onattach): Call ObjectPropertyTreeElement's onattach
since it is now implemented.
* page/inspector/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame): Added an updateInterface argument
that defaults to true if omitted. It specifies whether to call update on the scope chain.
* page/inspector/inspector.css: New styles.
* page/inspector/treeoutline.js:
(TreeElement.prototype._attach): Fixed an exception that fired when handling the shouldRefreshChildren
change. The nextSibling would exist but have a _listItemNode that didn't match the new parent.
2008-08-18 Timothy Hatcher <timothy@apple.com>
Surround the expression to be evaluated in parenthesis so the
result of the eval is the result of the whole expression not
the last potential sub-expression. So evaluating {x: 123}
will show the Object not 123.
https://bugs.webkit.org/show_bug.cgi?id=20428
Reviewed by Kevin McCullough.
* page/inspector/Console.js:
(Console.prototype._evalInInspectedWindow): Add parenthesis
around the expression. And add couple comments.
2008-08-19 Kevin McCullough <kmccullough@apple.com>
Reviewed by Geoff.
-Implement a page() function to extract a common code pattern.
* WebCore.xcodeproj/project.pbxproj:
* page/Console.cpp:
(WebCore::Console::addMessage):
(WebCore::Console::error):
(WebCore::Console::info):
(WebCore::Console::log):
(WebCore::Console::dir):
(WebCore::Console::assertCondition):
(WebCore::Console::time):
(WebCore::Console::timeEnd):
(WebCore::Console::group):
(WebCore::Console::groupEnd):
(WebCore::Console::finishedProfiling):
(WebCore::Console::warn):
(WebCore::Console::framePage):
* page/Console.h:
2008-08-12 Darin Adler <darin@apple.com>
Reviewed by Geoff.
- eliminate JSValue::type()
* bridge/c/c_instance.cpp:
(KJS::Bindings::CInstance::defaultValue): Take PreferredPrimitiveType
argument instead of JSType argument. Removed unneeded code to handle
boolean, since that's never passed.
* bridge/c/c_instance.h: Ditto.
* bridge/c/c_utility.cpp:
(KJS::Bindings::convertValueToNPVariant): Use JSValue::is functions
instead of JSValue::type(). Removed unneeded code to handle
"unspecified".
* bridge/jni/jni_instance.cpp:
(JavaInstance::defaultValue): Take PreferredPrimitiveType argument
instead of JSType argument. Removed unneeded code to handle boolean.
* bridge/jni/jni_instance.h: Ditto.
* bridge/jni/jni_jsobject.mm:
(JavaJSObject::convertValueToJObject): Use JSValue::is functions
instead of JSValue::type().
* bridge/objc/objc_instance.h: Take PreferredPrimitiveType argument
instead of JSType argument. Removed unused argument.
* bridge/objc/objc_instance.mm:
(ObjcInstance::getValueOfUndefinedField): Removed unused argument.
(ObjcInstance::defaultValue): Take PreferredPrimitiveType argument
instead of JSType argument. Removed unneeded code to handle boolean
and another dead code path for unknown types.
* bridge/objc/objc_runtime.h: Take PreferredPrimitiveType argument
instead of JSType argument. Removed override of type() that caused
the fallback object to return "UndefinedType" when there is no
invokeUndefinedMethodFromWebScript:withArguments: method defined.
That didn't accomplish much, since most checks for undefined don't
ever call type().
* bridge/objc/objc_runtime.mm:
(ObjcFallbackObjectImp::defaultValue): Ditto.
* bridge/qt/qt_instance.cpp:
(KJS::Bindings::QtInstance::defaultValue): Take PreferredPrimitiveType
argument instead of JSType argument. Removed unneeded code to handle
boolean.
* bridge/qt/qt_instance.h: Ditto.
* bridge/runtime.h:
(KJS::Bindings::Instance::getValueOfUndefinedField): Removed
unsed argument.
* bridge/runtime_object.cpp:
(RuntimeObjectImp::defaultValue): Take PreferredPrimitiveType
argument instead of JSType argument.
* bridge/runtime_object.h: Ditto.
2008-08-18 Maxime Britto <britto@apple.com>
Reviewed by Adele.
<rdar://6157207> Mouse pointer does not change when new window is opened after pan-scrolling original window
Related to the discussion from rdar://6102511 , we should disable every key event (except for the esc key which stops the panning).
We shouldn't be able to create another window while we are in pan scrolling.
Other browsers behaviors :
FF3 : Most of the keys are disabled, there is no way to create another window while in panscroll mode
IE7 : Keys are not disabled but stops immediately the panning.
This patch matches FF3 behavior by disabling every key but the esc key.
* page/EventHandler.cpp:
(WebCore::EventHandler::stopAutoscrollTimer): Change the cursor back to the regular arrow cursor when the pannning is stopped.
(WebCore::EventHandler::keyEvent): When a key event is received while in panning or autoscroll we swallow the event early.
2008-08-18 Dan Bernstein <mitz@apple.com>
Reviewed by Dave Hyatt.
- fix <rdar://problem/5862634> REGRESSION (3.1.1): In iChat, inline image not resizable past current size after another IM is received
Test: fast/replaced/max-width-percent.html
Added an includeMaxWidth boolean to RenderBox::calcReplaedWidth().
When false, max-width is not factored into the
calculation.
Changed RenderReplaced and subclasses' calcPrefWidths() to call
calcReplacedWidth(false) and then apply max-width only if it has a
fixed, positive value.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::calcReplacedWidth):
* rendering/RenderBox.h:
* rendering/RenderImage.cpp:
(WebCore::RenderImage::calcReplacedWidth):
(WebCore::RenderImage::calcPrefWidths):
* rendering/RenderImage.h:
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::calcPrefWidths):
* rendering/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::calcPrefWidths):
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::calcReplacedWidth):
(WebCore::RenderVideo::calcPrefWidths):
* rendering/RenderVideo.h:
2008-08-18 Daniel Macks <dmacks@netspace.org>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=20410
More portable/self-documenting replacement for SIZE_MAX.
* platform/network/curl/FormDataStreamCurl.cpp:
(WebCore::FormDataStream::read):
2008-08-18 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dave Hyatt
Need to make sure we have an Animation in the AnimationList
before setting the initial value.
https://bugs.webkit.org/show_bug.cgi?id=20408
Test: fast/css/transition_shorthand_parsing.html
* css/CSSStyleSelector.cpp:
2008-08-18 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim.
<rdar://problem/6150593> JSProfiler: Empty profiles disappear when there
is another profile.
* page/inspector/ProfilesPanel.js:
2008-08-18 Kevin McCullough <kmccullough@apple.com>
Reviewed by Geoff.
<rdar://problem/6150642> REGRESSION: Closing the Web Inspector clears
all console messages
* page/inspector/Console.js:
2008-08-18 Dirk Schulze <vbs85@gmx.de>
Reviewed by Eric Seidel.
Fixed Canvas for Cairo. Stroke and fill colors didn't work after
the canvas clean up.
https://bugs.webkit.org/show_bug.cgi?id=20405
* html/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::fill):
(WebCore::CanvasRenderingContext2D::stroke):
(WebCore::CanvasRenderingContext2D::fillRect):
2008-08-17 Timothy Hatcher <timothy@apple.com>
Complete in scope variables in the Console when paused.
https://bugs.webkit.org/show_bug.cgi?id=19115
Reviewed by Geoffrey Garen.
* page/inspector/Console.js:
(WebInspector.Console.prototype.completions): If the expressionString
is null or empty and the debugger is paused, call variablesInScopeForSelectedCallFrame
to get an object that declares all the in scope variables. That way
"top level" expressions are completed.
* page/inspector/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.variablesInScopeForSelectedCallFrame):
Return an object that has all the variables that are in scope for the
selected call frame. The value of each property is just true.
The return object is useful for quick lookups or auto completion.
2008-08-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Not reviewed.
Speculative Qt build fix.
* bridge/qt/qt_runtime.cpp:
(KJS::Bindings::convertValueToQVariant):
(KJS::Bindings::QtRuntimeMethod::QtRuntimeMethod):
2008-08-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Updated project files to XCode 3.1.
* manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj/project.pbxproj:
2008-08-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Made room for a free word in JSCell.
Changed JSDOMWindowBase to store its auxiliary data in a subclass of
JSGlobalData, so the two could share a pointer.
Added a bunch of ASSERTs, to help catch over-sized objects.
2008-08-15 Mark Rowe <mrowe@apple.com>
Reviewed by Dan Bernstein.
Disable dead code stripping in debug builds.
* Configurations/Base.xcconfig:
* WebCore.xcodeproj/project.pbxproj:
2008-08-15 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Geoff Garen.
<rdar://problem/6139914> Please include a _debug version of JavaScriptCore framework
* Configurations/Base.xcconfig: Factor out the debug-only settings so that they can shared
between the Debug configuration and debug Production variant.
* WebCore.xcodeproj/project.pbxproj: Enable the debug variant.
2008-08-15 Antti Koivisto <antti@apple.com>
Reviewed by Anders.
Don't start preloading body resources before the head is complete. This prevents
body preloads from slowing down initial display when there is limited amount
of bandwidth available.
Works by queuing up found body preloads to DocLoader and only issuing them
after document has rendering.
With bandwidth capped to 300kbit/s this speeds up cnn.com initial display by ~25% or 5s
without affecting complete load time.
* html/PreloadScanner.cpp:
(WebCore::PreloadScanner::PreloadScanner):
(WebCore::PreloadScanner::scanningBody):
(WebCore::PreloadScanner::emitTag):
(WebCore::PreloadScanner::emitCSSRule):
* html/PreloadScanner.h:
* loader/DocLoader.cpp:
(WebCore::DocLoader::preload):
(WebCore::DocLoader::checkForPendingPreloads):
(WebCore::DocLoader::requestPreload):
* loader/DocLoader.h:
* loader/loader.cpp:
(WebCore::Loader::Host::didFinishLoading):
(WebCore::Loader::Host::didFail):
2008-08-15 Ada Chan <adachan@apple.com>
Use item's computed style if the render style is 0 before falling back to the <select>'s style.
This way style set on an <hr> within a <select> will be honored.
Reviewed by Dave Hyatt and Dan Bernstein.
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::itemStyle):
2008-08-15 Antti Koivisto <antti@apple.com>
Reviewed by Oliver.
Some loader performance tweaks:
- Make stylesheets highest priority instead of scripts. We block script execution on stylesheets.
Especially if a stylesheet @imports other stylesheets it is important to get them to the front of the queue
to not delay rendering.
- Issue the first resource load for a host immediately even if the resource is low priority. TCP connection setup
can take long time when latency is high so it is good to get started early.
- When the document is fully parsed and stylesheets have been loaded there is no need to keep managing the
load queues. Issue remaining loads to the network layer.
* loader/loader.cpp:
(WebCore::Loader::determinePriority):
(WebCore::Loader::load):
(WebCore::Loader::Host::servePendingRequests):
* loader/loader.h:
2008-08-15 Timothy Hatcher <timothy@apple.com>
Detach the script debugger when the Web Inspector's window closes.
This has always been the intended design, but never fully implemented.
https://bugs.webkit.org/show_bug.cgi?id=20402
Reviewed by Adam Roben.
* page/InspectorController.cpp:
(WebCore::InspectorController::setWindowVisible): Call stopDebugging()
if the window is no longer visible.
2008-08-15 Håvard Wall <hwall@trolltech.com>
Reviewed by Simon.
Fixes: compile with QT_NO_CONTEXTMENU
* platform/qt/PlatformMouseEventQt.cpp:
(WebCore::PlatformMouseEvent::PlatformMouseEvent):
* platform/qt/PlatformScrollBarQt.cpp:
(WebCore::PlatformScrollbar::handleMouseMoveEvent):
(WebCore::PlatformScrollbar::handleContextMenuEvent):
2008-08-15 Håvard Wall <hwall@trolltech.com>
Reviewed by Simon.
Fixes: compile with QT_NO_WHEELEVENT
* platform/qt/WheelEventQt.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
2008-08-15 Keishi Hattori <casey.hattori@gmail.com>
Fixed Bug 20210: Console groups are incorrect when closing and reopening the Inspector
https://bugs.webkit.org/show_bug.cgi?id=20210
Reviewed by Tim Hatcher.
* page/Console.cpp:
(WebCore::Console::group):
(WebCore::Console::groupEnd):
* page/Console.h:
(WebCore::): Removed GroupTitleMessageLevel. Added StartGroupMessaageLevel and EndGroupMessageLevel.
* page/InspectorController.cpp:
(WebCore::InspectorController::startGroup): Increments group level by
one and adds console message with StartGroupMessaageLevel.
(WebCore::InspectorController::endGroup): Decrements group level by one
and adds console message with EndGroupMessaageLevel.
* page/InspectorController.h:
* page/inspector/Console.js:
(WebInspector.Console.prototype.addMessage): Creates new ConsoleGroup
if the message is StartGroupMessaageLevel.
(WebInspector.ConsoleMessage.prototype.toMessageElement):
(WebInspector.ConsoleGroup.prototype.addMessage):
* page/inspector/inspector.js:
2008-08-15 Keishi Hattori <casey.hattori@gmail.com>
Adds support for console.dir to the Inspector
https://bugs.webkit.org/show_bug.cgi?id=19155
Reviewed by Tim Hatcher.
* bindings/js/JSConsoleCustom.cpp:
(WebCore::JSConsole::dir):
* page/Console.cpp:
(WebCore::Console::dir):
* page/Console.h: Added ObjectMessageLevel.
* page/Console.idl: Added console.dir.
* page/inspector/Console.js:
(WebInspector.ConsoleMessage.prototypet.toMessageElement): Creates an
ObjectPropertiesSection if the MessageLevel is Object.
* page/inspector/ObjectPropertiesSection.js: "in" operator can't be
used on primitive data types.
* page/inspector/inspector.css:
2008-08-15 Keishi Hattori <casey.hattori@gmail.com>
Adds support for clear() in the Inspector console.
https://bugs.webkit.org/show_bug.cgi?id=19873
Reviewed by Tim Hatcher.
* page/inspector/Console.js:
2008-08-15 Anthony Ricaud <rik24d@gmail.com>
Cmd-F on Mac or Ctrl-F on other platforms now focus the search field.
Platform distinction and modifier key matching adjusted
by Daniel Jalkut <jalkut@red-sweater.com>
Bug 16313: text search (find) keybindings should work in the Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=16313
Reviewed by Tim Hatcher.
* page/inspector/inspector.js: Added a case for the F key
2008-08-15 Keishi Hattori <casey.hattori@gmail.com>
Fix for error when the string doesn't contain a webkit-profile link.
https://bugs.webkit.org/show_bug.cgi?id=20399
Reviewed by Tim Hatcher.
* page/inspector/inspector.js:
2008-08-15 Timothy Hatcher <timothy@apple.com>
Fixes two bugs where JavaScript could be executed from the page
while the debugger is paused.
The first issue was JSLazyEventListener not checking the paused
state before parsing the code.
The second issue was with the PageGroup version of
JavaScriptDebugServer::setJavaScriptPaused always passing false
to the Page version of JavaScriptDebugServer::setJavaScriptPaused,
and not the paused argument.
https://bugs.webkit.org/show_bug.cgi?id=20284
Reviewed by Adam Roben.
* bindings/js/JSEventListener.cpp:
(WebCore::JSLazyEventListener::parseCode): Check the paused
state of the ScriptController. Return early if paused.
* manual-tests/inspector/debugger-execution-while-paused.html: Added.
* page/JavaScriptDebugServer.cpp:
(WebCore::JavaScriptDebugServer::setJavaScriptPaused):
Pass the paused argument to the Page version of setJavaScriptPaused.
2008-08-15 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Geoff Garen.
JSStringRef is created context-free, but can get linked to one via an identifier table,
breaking an implicit API contract.
* page/InspectorController.cpp:
(WebCore::jsStringRef):
(WebCore::InspectorController::didParseSource):
(WebCore::InspectorController::failedToParseSource):
* page/JavaScriptProfile.cpp:
(WebCore::getTitleCallback):
Updated for JavaScriptCore changes.
2008-08-14 Kevin Ollivier <kevino@theolliviers.com>
wx !USE(WXGC) build fix. This is necessary until we find a way to replace GDI with
an alternative that performs reasonably well. (GDI+ is too slow in many cases.)
* platform/graphics/AffineTransform.h:
2008-08-14 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele.
Fix for https://bugs.webkit.org/show_bug.cgi?id=20388
<video> elements on Windows never becomes visible when a page is restored from the cache
Always pass "set" calls down to MediaPlayerPrivate instead of only when the
value is different from the cached value. Let the implementation decide when
to avoid work because nothing has changed.
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::setVolume):
(WebCore::MediaPlayer::setRate):
(WebCore::MediaPlayer::setRect):
(WebCore::MediaPlayer::setVisible):
2008-08-14 Keishi Hattori <casey.hattori@gmail.com>
Make Firebug command line API respect predefined variables.
https://bugs.webkit.org/show_bug.cgi?id=20385
Reviewed by Tim Hatcher.
* page/inspector/Console.js:
2008-08-14 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen and Timothy Hatcher.
Allow programatically setting the HTMLTokenizers time delay and chunk size
which are used for determining how aggressively we yield.
* WebCore.base.exp:
* html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::begin):
(WebCore::HTMLTokenizer::continueProcessing):
* html/HTMLTokenizer.h:
* page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::setCustomHTMLTokenizerTimeDelay):
(WebCore::Page::setCustomHTMLTokenizerChunkSize):
* page/Page.h:
(WebCore::Page::hasCustomHTMLTokenizerTimeDelay):
(WebCore::Page::customHTMLTokenizerTimeDelay):
(WebCore::Page::hasCustomHTMLTokenizerChunkSize):
(WebCore::Page::customHTMLTokenizerChunkSize):
2008-08-14 Eric Seidel <eric@webkit.org>
Reviewed by Beth.
Move us one step closer to cross-platform svg/graphics code
* WebCore.xcodeproj/project.pbxproj:
* html/CanvasStyle.cpp:
* platform/graphics/Color.cpp:
(WebCore::colorWithOverrideAlpha):
* platform/graphics/Color.h:
* svg/graphics/cg/CgSupport.cpp:
(WebCore::applyStrokeStyleToContext):
(WebCore::strokeBoundingBox):
* svg/graphics/cg/SVGPaintServerSolidCg.cpp:
(WebCore::SVGPaintServerSolid::setup):
2008-08-14 Eric Seidel <eric@webkit.org>
Reviewed by Alexey.
Remove un-need includes from HTMLCanvas and use the
Gradient platform abstraction in one place in CanvasStyle
* html/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::fillRect):
* html/CanvasStyle.cpp:
* html/HTMLCanvasElement.cpp:
2008-08-14 Eric Seidel <eric@webkit.org>
Reviewed by Alexey.
Clean up GlyphBuffer.h, removing more #ifdefs
* platform/graphics/GlyphBuffer.h:
(WebCore::GlyphBuffer::glyphAt):
(WebCore::GlyphBuffer::advanceAt):
(WebCore::GlyphBuffer::add):
2008-08-14 Eric Seidel <eric@webkit.org>
Reviewed by Sam.
Clean up AffineTransform.h, removing #ifdefs
* platform/graphics/AffineTransform.h:
* platform/graphics/cairo/AffineTransformCairo.cpp:
* platform/graphics/cg/AffineTransformCG.cpp:
* platform/graphics/qt/AffineTransformQt.cpp:
* platform/graphics/wx/AffineTransformWx.cpp:
2008-08-14 Dan Bernstein <mitz@apple.com>
- fix non-CG builds by adding an ImageSource::frameSizeAtIndex() that returns size().
* platform/graphics/cairo/ImageSourceCairo.cpp:
(WebCore::ImageSource::frameSizeAtIndex):
* platform/graphics/qt/ImageSourceQt.cpp:
(WebCore::ImageSource::frameSizeAtIndex):
* platform/graphics/wx/ImageSourceWx.cpp:
(WebCore::ImageSource::frameSizeAtIndex):
2008-08-14 Dan Bernstein <mitz@apple.com>
Reviewed by Brady Eidson.
- fix <rdar://problem/5993323> REGRESSION (r34210): Apple.com favicon appears stretched/clipped
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::BitmapImage): Added initialization of
m_hasUniformFrameSize.
(WebCore::BitmapImage::cacheFrame): Added code to get the size of the
cached frame for use in decoded size computation and for setting
m_hasUniformFrameSize.
(WebCore::BitmapImage::currentFrameSize): Added.
(WebCore::BitmapImage::dataChanged): Added code to reset
m_hasUniformFrameSize.
* platform/graphics/BitmapImage.h: Added currentFrameSize() and
m_hasUniformFrameSize.
* platform/graphics/ImageSource.h: Added frameSizeAtIndex().
* platform/graphics/cg/ImageCG.cpp:
(WebCore::BitmapImage::draw): Changed to use currentFrameSize(). This
fixes the bug, which resulted from assuming that the frame being drawn
was the same size as the first frame.
* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::frameSizeAtIndex): Renamed size() to this and
changed to get the size of the frame at the given index.
(WebCore::ImageSource::size): Added. Returns frameSizeAtIndex(0).
2008-08-13 Simon Fraser <simon.fraser@apple.com>
Reviewed by Eric Seidel
Fix @font-face inside @media rule crash.
https://bugs.webkit.org/show_bug.cgi?id=20367
Test: fast/css/font-face-in-media-rule.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSRuleSet::addRulesFromSheet):
2008-08-14 Kevin Ollivier <kevino@theolliviers.com>
wx build fixes after recent changes to Canvas and Image classes.
* platform/graphics/Pattern.h:
* platform/graphics/wx/GradientWx.cpp:
(WebCore::Gradient::fill):
* platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::applyFillPattern):
(WebCore::GraphicsContext::applyStrokePattern):
* platform/graphics/wx/ImageBufferWx.cpp:
(WebCore::ImageBuffer::image):
* platform/graphics/wx/ImageWx.cpp:
(WebCore::Image::loadPlatformResource):
2008-08-14 Maxime Britto <britto@apple.com>
Reviewed by Sam Weinig.
rdar://6102511
When pan-scrolling, typing on the keyboard should either stop the pan scroll or be ignored
IE and FF are both preventing the keyboard event to interact with the page while scrolling.
Some differences exist between them concerning the kind of key which is pressed :
IE7 : every key leads to a stop of the panning
FF3 : the ESC and TAB keys leads to a stop, the other keys are inactive.
For WebKit this patch is adopting the FF3 behavior except for the TAB key which is inactive too.
* page/EventHandler.cpp:
(WebCore::EventHandler::keyEvent): Verifies which key has been hit and decide either to stop the pan scroll or to swallow the key event.
2008-08-14 Christian Dywan <christian@twotoasts.de>
Gtk+/ Cairo build fix, patch by Dirk Schulze.
* html/CanvasStyle.cpp:
* platform/graphics/cairo/PatternCairo.cpp:
(WebCore::Pattern::createPlatformPattern):
* svg/graphics/cairo/SVGResourceMaskerCairo.cpp:
2008-08-14 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim.
<rdar://problem/6115819> Notify of profile in console
* page/InspectorController.cpp:
(WebCore::InspectorController::addProfile):
(WebCore::InspectorController::addProfileMessageToConsole): Called by
addProfile this is the function that adds a message to the console that
a profile finished.
* page/InspectorController.h:
* page/JavaScriptProfile.cpp: Expose the profiler's unique ID to match
the console log to the profile in the web inspector.
(WebCore::getUniqueIdCallback):
(WebCore::ProfileClass):
* page/inspector/ProfilesPanel.js: Created a map of all the profiles by
Id to bring up the requested profile. Also select and reveal the
profile in the profile panel. And created displayTitleForProfileLink()
which formats a title taking into account if it's user initiated or if
there are multiples. Lasty, I put the user initiated profile in a
variable.
* page/inspector/inspector.js: Make the profile title be a clickable
link that will take the user to the identified profile. Also expose
the count of user initiated profiles so they can be displayed in the
console with the correct count.
2008-08-14 Timothy Hatcher <timothy@apple.com>
Avoid formating ConsoleMessages twice unless the message will be
displayed in bubbles of a SourceFrame.
Reviewed by Kevin McCullough.
* page/inspector/Console.js:
(WebInspector.ConsoleMessage): Only format the plain text message
if the URL and line are valid and the level is error or warning.
(WebInspector.ConsoleMessage.prototype.isErrorOrWarning): Added.
Helper to test for error or warning level.
* page/inspector/SourceFrame.js:
(WebInspector.SourceFrame.prototype.addMessage): Don't add the
message if there is no message or valid line or if the msg
isn't an error or warning.
2008-08-14 Jan Michael Alonzo <jmalonzo@webkit.org>
partial Gtk build fix, not reviewed
* platform/graphics/cairo/PatternCairo.cpp:
2008-08-13 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Fix style issue.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::pickMedia):
2008-08-13 Nikolas Zimmermann <zimmermann@kde.org>
Build fix for Cairo, not reviewed. (exposed by gtk build slave)
Continue Erics build fixes, after the Image cleanup.
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::image):
2008-08-13 Nikolas Zimmermann <zimmermann@kde.org>
Build fix for Qt, not reviewed.
Don't declare eventuallyMarkAsParserCreated in a block wrapped by !USE_QXMLSTREAM.
* dom/XMLTokenizer.cpp:
(WebCore::eventuallyMarkAsParserCreated): Was erre
2008-08-13 Nikolas Zimmermann <zimmermann@kde.org>
Build fix, not reviewed.
Add ScriptElement.cpp to Gtk build.
* GNUmakefile.am:
2008-08-13 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Eric.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=20372
Refactor HTMLScriptElement's code into a common base class: ScriptElement.
SVGScriptElement will be converted to use ScriptElement in a follow-up patch.
This resolves code duplications and allows us to completly replace the old
SVGScriptElement (which doesn't use CachedScript, no dynamic injected scripts etc..)
As ScriptElement, doesn't actually inherit from Element, we may want to rename
it, though StyleElement uses the same naming convention, so I left it as is for now.
Eventually we'll rename both files in future.
No functional changes yet, as SVGScriptElement doesn't yet use the new base class.
* WebCore.pro: Add new ScriptElement.cpp to build.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* WebCoreSources.bkl: Dutto.
* dom/ScriptElement.cpp: Added. 1:1 based on HTMLScriptElement
(WebCore::ScriptElement::insertedIntoDocument):
(WebCore::ScriptElement::removedFromDocument):
(WebCore::ScriptElement::childrenChanged):
(WebCore::ScriptElement::finishParsingChildren):
(WebCore::ScriptElement::handleSourceAttribute):
(WebCore::isSupportedJavaScriptLanguage):
(WebCore::ScriptElementData::ScriptElementData):
(WebCore::ScriptElementData::~ScriptElementData):
(WebCore::ScriptElementData::requestScript):
(WebCore::ScriptElementData::evaluateScript):
(WebCore::ScriptElementData::stopLoadRequest):
(WebCore::ScriptElementData::notifyFinished):
(WebCore::ScriptElementData::ignoresLoadRequest):
(WebCore::ScriptElementData::shouldExecuteAsJavaScript):
(WebCore::ScriptElementData::scriptCharset):
(WebCore::ScriptElementData::scriptContent):
* dom/ScriptElement.h: Added.
(WebCore::ScriptElement::ScriptElement):
(WebCore::ScriptElement::~ScriptElement):
(WebCore::ScriptElementData::element):
(WebCore::ScriptElementData::createdByParser):
(WebCore::ScriptElementData::setCreatedByParser):
* dom/XMLTokenizer.cpp:
(WebCore::isScriptElement):
(WebCore::castToScriptElement):
(WebCore::eventuallyMarkAsParserCreated):
(WebCore::XMLTokenizer::startElementNs):
(WebCore::XMLTokenizer::endElementNs):
(WebCore::createXHTMLParserErrorHeader):
(WebCore::XMLTokenizer::insertErrorMessageBlock):
* html/HTMLScriptElement.cpp: Refactored code, pushed most code down to ScriptElement.
(WebCore::HTMLScriptElement::HTMLScriptElement):
(WebCore::HTMLScriptElement::~HTMLScriptElement):
(WebCore::HTMLScriptElement::isURLAttribute):
(WebCore::HTMLScriptElement::setCreatedByParser):
(WebCore::HTMLScriptElement::shouldExecuteAsJavaScript):
(WebCore::HTMLScriptElement::childrenChanged):
(WebCore::HTMLScriptElement::parseMappedAttribute):
(WebCore::HTMLScriptElement::finishParsingChildren):
(WebCore::HTMLScriptElement::insertedIntoDocument):
(WebCore::HTMLScriptElement::removedFromDocument):
(WebCore::HTMLScriptElement::text):
(WebCore::HTMLScriptElement::setText):
(WebCore::HTMLScriptElement::setHtmlFor):
(WebCore::HTMLScriptElement::setEvent):
(WebCore::HTMLScriptElement::charset):
(WebCore::HTMLScriptElement::src):
(WebCore::HTMLScriptElement::type):
(WebCore::HTMLScriptElement::scriptCharset):
(WebCore::HTMLScriptElement::scriptContent):
(WebCore::HTMLScriptElement::sourceAttributeValue):
(WebCore::HTMLScriptElement::charsetAttributeValue):
(WebCore::HTMLScriptElement::typeAttributeValue):
(WebCore::HTMLScriptElement::languageAttributeValue):
(WebCore::HTMLScriptElement::dispatchLoadEvent):
(WebCore::HTMLScriptElement::dispatchErrorEvent):
* html/HTMLScriptElement.h:
* svg/SVGScriptElement.cpp: Inherit from ScriptElement, don't actually use it yet.
* svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::SVGScriptElement):
(WebCore::SVGScriptElement::scriptContent):
(WebCore::SVGScriptElement::sourceAttributeValue):
(WebCore::SVGScriptElement::charsetAttributeValue):
(WebCore::SVGScriptElement::typeAttributeValue):
(WebCore::SVGScriptElement::languageAttributeValue):
(WebCore::SVGScriptElement::dispatchLoadEvent):
(WebCore::SVGScriptElement::dispatchErrorEvent):
* svg/SVGScriptElement.h:
(WebCore::SVGScriptElement::setCreatedByParser):
2008-08-13 Eric Seidel <eric@webkit.org>
Attempt to fix the Gtk build, no review.
I removed the bogus GraphicsContext::translatePoint() hack for Gtk in the process.
* platform/graphics/GraphicsContext.h:
* platform/graphics/cairo/GraphicsContextCairo.cpp:
* platform/graphics/qt/GradientQt.cpp:
* platform/graphics/qt/GraphicsContextQt.cpp:
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::paintMozWidget):
2008-08-13 Eric Seidel <eric@webkit.org>
Yet another attempt to fix the Qt build, no review.
* platform/graphics/qt/GradientQt.cpp:
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::applyStrokePattern):
(WebCore::GraphicsContext::applyFillPattern):
2008-08-13 Eric Seidel <eric@webkit.org>
Attempt to fix the Windows build, no review.
* platform/win/CursorWin.cpp:
(WebCore::loadCursorByName):
* platform/win/ScrollViewWin.cpp:
(WebCore::ScrollView::paint):
2008-08-13 Eric Seidel <eric@webkit.org>
Attempt to fix the Windows build, no review.
* platform/win/CursorWin.cpp:
(WebCore::loadCursorByName):
* platform/win/ScrollViewWin.cpp:
(WebCore::ScrollView::paint):
2008-08-13 Eric Seidel <eric@webkit.org>
Attempt to fix the Qt build, no review.
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBuffer::image):
2008-08-13 Eric Seidel <eric@webkit.org>
Attempt to fix the Windows build, no review.
* platform/graphics/win/ImageWin.cpp:
(WebCore::Image::loadPlatformResource):
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::paintMissingPluginIcon):
2008-08-13 Eric Seidel <eric@webkit.org>
Another attempt to fix the Qt build, no review.
* platform/graphics/qt/ImageQt.cpp:
* platform/graphics/qt/StillImageQt.h:
2008-08-13 Eric Seidel <eric@webkit.org>
No review, build fix only.
Fix mac build, due to change in new code since my patch was written.
* svg/graphics/cg/SVGResourceMaskerCg.mm:
(WebCore::SVGResourceMasker::applyMask):
2008-08-13 Eric Seidel <eric@webkit.org>
Build fix only, no review.
Attempt to fix the Qt build.
* platform/graphics/qt/ImageBufferQt.cpp:
* platform/graphics/qt/StillImageQt.h:
(WebCore::StillImage::create):
(WebCore::StillImage::destroyDecodedData):
(WebCore::StillImage::decodedSize):
2008-08-13 Eric Seidel <eric@webkit.org>
Build fix only, no review.
Attempt to fix the Qt build.
* html/CanvasStyle.cpp:
(WebCore::CanvasStyle::applyStrokeColor):
(WebCore::CanvasStyle::applyFillColor):
2008-08-13 Eric Seidel <eric@webkit.org>
Reviewed by Sam.
Match HTML5 spec by throwing INVALID_STATE_ERR when
createPattern is called and the HTMLImageElement is not
yet done loading the image (!isComplete)
https://bugs.webkit.org/show_bug.cgi?id=20351
Test: http/misc/canvas-pattern-from-incremental-image.html
* html/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::createPattern):
2008-08-13 Eric Seidel <eric@webkit.org>
Reviewed by Niko.
Split out a Pattern class from CanvasPattern
and remove all the Pattern-related #ifdefs
(This will break non-mac platforms! I will fix them.)
https://bugs.webkit.org/show_bug.cgi?id=20351
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* html/CanvasPattern.cpp:
(WebCore::CanvasPattern::parseRepetitionType):
(WebCore::CanvasPattern::CanvasPattern):
* html/CanvasPattern.h:
(WebCore::CanvasPattern::create):
(WebCore::CanvasPattern::pattern):
(WebCore::CanvasPattern::originClean):
* html/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::createPattern):
(WebCore::CanvasRenderingContext2D::applyStrokePattern):
(WebCore::CanvasRenderingContext2D::applyFillPattern):
* html/CanvasRenderingContext2D.h:
* html/HTMLCanvasElement.cpp:
* html/HTMLCanvasElement.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::createHistoryItem):
* platform/graphics/GraphicsContext.h:
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::applyStrokePattern):
(WebCore::GraphicsContext::applyFillPattern):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::clipToImageBuffer):
(WebCore::GraphicsContext::applyStrokePattern):
(WebCore::GraphicsContext::applyFillPattern):
2008-08-13 Eric Seidel <eric@webkit.org>
Reviewed by Niko.
Make Images RefCounted (and clean up callers)
https://bugs.webkit.org/show_bug.cgi?id=20351
* editing/DeleteButtonController.cpp:
(WebCore::DeleteButtonController::createDeletionUI):
* loader/CachedImage.cpp:
(WebCore::CachedImage::CachedImage):
(WebCore::brokenImage):
(WebCore::nullImage):
(WebCore::CachedImage::image):
(WebCore::CachedImage::notifyObservers):
(WebCore::CachedImage::createImage):
* loader/CachedImage.h:
* loader/icon/IconRecord.cpp:
(WebCore::IconRecord::setImageData):
(WebCore::IconRecord::loadImageFromResource):
* loader/icon/IconRecord.h:
* platform/graphics/BitmapImage.h:
(WebCore::BitmapImage::create):
* platform/graphics/GeneratedImage.h:
* platform/graphics/Gradient.cpp:
* platform/graphics/Gradient.h:
* platform/graphics/Image.cpp:
(WebCore::Image::nullImage):
* platform/graphics/Image.h:
* platform/graphics/ImageBuffer.h:
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::image):
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::image):
(WebCore::ImageBuffer::getImageData):
(WebCore::ImageBuffer::putImageData):
* platform/graphics/cg/PDFDocumentImage.h:
(WebCore::PDFDocumentImage::create):
(WebCore::PDFDocumentImage::destroyDecodedData):
(WebCore::PDFDocumentImage::decodedSize):
* platform/graphics/gtk/ImageGtk.cpp:
(WebCore::Image::loadPlatformResource):
* platform/graphics/mac/ImageMac.mm:
(WebCore::Image::loadPlatformResource):
* rendering/RenderImage.cpp:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintOverflowControls):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::nativeImageForCurrentFrame):
* svg/graphics/SVGImage.h:
(WebCore::SVGImage::create):
(WebCore::SVGImage::destroyDecodedData):
(WebCore::SVGImage::decodedSize):
(WebCore::SVGImage::frameAtIndex):
* svg/graphics/cairo/SVGPaintServerPatternCairo.cpp:
(WebCore::SVGPaintServerPattern::setup):
* svg/graphics/cairo/SVGResourceMaskerCairo.cpp:
(WebCore::SVGResourceMasker::applyMask):
* svg/graphics/cg/SVGPaintServerPatternCg.cpp:
(WebCore::patternCallback):
* svg/graphics/cg/SVGResourceMaskerCg.mm:
(WebCore::SVGResourceMasker::applyMask):
2008-08-13 Eric Seidel <eric@webkit.org>
Reviewed by Niko.
Remove #ifdefs from CanvasStyle by using platform/Color.h
https://bugs.webkit.org/show_bug.cgi?id=20351
There are some down-sides to this commit.
This commit limits us to 255 levels of grey for calls like:
context.setStrokeStyle(.37, 1.0)
previously CG might have used up to 32bits to store the grey level
Since setStrokeStyle is not part of HTML5, I don't suspect the web will notice.
Likewise, setStrokeStyle/setFillStyle calls which used float colors are now limited
to RGBA32 (like all the rest of colors in WebCore), thus:
context.setStrokStyle(.37, .24, .456, .99) will now have the same precision as:
context.strokeStyle = "rgba(.37, .24, .456, .99)", which is to say RGBA32
If this is a problem for Dashboard, we can either roll out this commit
or add a beefier Color abstraction, which can be used internally by GraphicsContext
when keeping state, and then GraphicsContext can grow some additional set* routines
for setting the a grey/float/whatever fill and stroke.
* html/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setFillStyle):
* html/CanvasStyle.cpp:
(WebCore::CanvasStyle::CanvasStyle):
(WebCore::colorWithOverrideAlpha):
(WebCore::CanvasStyle::applyStrokeColor):
(WebCore::CanvasStyle::applyFillColor):
* html/CanvasStyle.h:
* platform/graphics/Color.cpp:
(WebCore::colorFloatToRGBAByte):
(WebCore::makeRGBA32FromFloats):
* platform/graphics/Color.h:
2008-08-13 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele Peterson.
Fix for <rdar://problem/6137931>
https://bugs.webkit.org/show_bug.cgi?id=20360
Remove all parameters from the MIME type before checking with the MIME type registry
Tests: media/video-source-type-params.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::pickMedia): only pass the portion before the first ';'
to isSupportedMediaMIMEType()
2008-08-13 Beth Dakin <bdakin@apple.com>
Reviewed by Sam Weinig.
Fix for <rdar://problem/6141345>
This patch refines findString and markAllMatchesForText functions'
interactions with disconnected frames. They no longer rely on
knowing where a range is relative to the visible region and work
with disconnected frames that contain frames.
* editing/Editor.cpp:
(WebCore::Editor::insideVisibleArea): Now returns a bool instead of
the visiblity enum.
(WebCore::Editor::firstVisibleRange): This now returns the very
first visible range in the document. It's no longer dependent on
searching forward.
(WebCore::Editor::lastVisibleRange): This now returns the very last
visible range in the document. It's no longer dependent on
searching backwards.
(WebCore::Editor::nextVisibleRange): This returns the next visible
range in the appropriate direction from the current range.
* editing/Editor.h:
* page/Frame.cpp:
(WebCore::Frame::findString):
(WebCore::Frame::markAllMatchesForText):
2008-08-13 Kevin Ollivier <kevino@theolliviers.com>
wx build fix for case-sensitive platforms, like Linux.
* WebCoreSources.bkl:
2008-08-13 Marco Barisione <marco.barisione@collabora.co.uk>
Reviewed by Holger Freyther.
http://bugs.webkit.org/show_bug.cgi?id=16881
[GTK] PlatformScreenGtk is unimplemented
Original patch by Christian Dywan.
* platform/gtk/PlatformScreenGtk.cpp:
(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
(WebCore::screenIsMonochrome):
(WebCore::screenRect):
(WebCore::screenAvailableRect):
2008-08-13 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Holger Freyther.
http://bugs.webkit.org/show_bug.cgi?id=20318
SharedTimerGtk should use G_PRIORITY_DEFAULT_IDLE for g_idle_add
g_idle_add is the same as g_idle_add_full with a priority of
G_PRIORITY_DEFAULT_IDLE, so we can safely use that.
* platform/gtk/SharedTimerGtk.cpp:
(WebCore::setSharedTimerFireTime):
2008-08-13 Timothy Hatcher <timothy@apple.com>
Changed the InspectorController so it can be notified when the
attached state of the Inspector changes in WebKit.
Reviewed by Kevin McCullough.
* WebCore.base.exp: Updated the symbol for setWindowVisible.
* page/InspectorController.cpp:
(WebCore::InspectorController::setWindowVisible): Added an attached argument,
that defaults to false.Call setAttachedWindow with the attached argument.
(WebCore::InspectorController::setAttachedWindow): Call the script version
of setAttachedWindow.
* page/InspectorController.h:
* page/inspector/inspector.js:
(WebInspector.setAttachedWindow): Set the attached property.
2008-08-12 Timothy Hatcher <timothy@apple.com>
Added a close button to the Inspector's toolbar when docked.
https://bugs.webkit.org/show_bug.cgi?id=14270
Reviewed by Kevin McCullough.
* page/InspectorController.cpp:
(WebCore::closeWindow): Call InspectorController::closeWindow.
(WebCore::InspectorController::windowScriptObjectAvailable):
Added closeWindow to the script class.
* page/InspectorController.h:
* page/inspector/Images/closeButtons.png: Added.
* page/inspector/inspector.css: Added and changed styles.
* page/inspector/inspector.html: Added the close button.
* page/inspector/inspector.js:
(WebInspector.loaded): Added click event listener to the close button.
(WebInspector.close): Call InspectorController.closeWindow.
2008-08-12 Timothy Hatcher <timothy@apple.com>
Make the docked Web Inspector resizable. This is the cross platform
portion of the code. Each InspectorClient needs to implement the
real resize code.
https://bugs.webkit.org/show_bug.cgi?id=14282
Reviewed by Kevin McCullough.
* loader/EmptyClients.h: Added an empty setAttachedWindowHeight.
* page/InspectorClient.h: Added setAttachedWindowHeight.
* page/InspectorController.cpp:
(WebCore::setAttachedWindowHeight): Call setAttachedWindowHeight
on the InspectorController.
(WebCore::InspectorController::setAttachedWindowHeight): Call
setAttachedWindowHeight on the client.
(WebCore::InspectorController::windowScriptObjectAvailable):
Added setAttachedWindowHeight to the script class.
* page/InspectorController.h:
* page/inspector/inspector.css: Make the cursor on the toolbar be
row-resize when docked.
* page/inspector/inspector.js:
(WebInspector.loaded): Always add the toolbarDragStart event listener.
(WebInspector.toolbarDragStart): Return early if we are not attached
and not on Leopard. Call WebInspector.elementDragStart.
(WebInspector.toolbarDragEnd): Call WebInspector.elementDragEnd.
(WebInspector.toolbarDrag): When attached call setAttachedWindowHeight,
otherwise call moveByUnrestricted.
2008-08-13 Simon Hausmann <hausmann@webkit.org>
Reviewed by Holger.
Initialize m_zoomsTextOnly in the Settings constructor.
* page/Settings.cpp:
(WebCore::Settings::Settings):
2008-08-13 Brad Hughes <bhughes@trolltech.com>
Reviewed by Simon.
Fix compiling of QtWebKit in release mode with the Intel C++ Compiler for Linux
The latest upgrade of the intel compiler allows us to compile all of
Qt with optimizations enabled (yay!).
* WebCore.pro:
2008-08-13 Prasanth Ullattil <prasanth.ullattil@trolltech.com>
Reviewed by Simon.
Fix QtWebKit not displaying content on 403 HTTP responses
Just like with 404 responses also display content with 403, as
used by http://audiio.ejamming.proteus-tech.com/audiio/profile/original_signup/
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::finish):
2008-08-13 Simon Hausmann <hausmann@webkit.org>
Reviewed by Holger.
Qt part of https://bugs.webkit.org/show_bug.cgi?id=18994
Make the formatting of String::format() locale independent through the use of QString::vsprintf.
* platform/text/String.cpp:
(WebCore::String::format):
2008-08-13 Simon Hausmann <hausmann@webkit.org>
Reviewed by Lars.
Fix QWebFrame::setHtml() not setting the new contents immediately.
Added a setter to the DocumentLoader to toggle the deferred loading of the main
resource when it comes from substitute data.
Disable deferred loading of the main resource when we have valid substitute data,
as used by QWebFrame::setHtml.
* loader/DocumentLoader.h:
2008-08-13 Mark Rowe <mrowe@apple.com>
Speculative GTK build fix.
* GNUmakefile.am: Add dependency info for JSSVGElementWrapperFactory.cpp.
2008-08-13 Thiago Macieira <tjmaciei@trolltech.com>
Reviewed by Simon.
Fix encoding of [ and ] in the host part of the URL
Until QUrl is fixed (making QUrl's tolerant parser more tolerant), we have to
add this workaround to the QUrl <> WebCore::KURL conversion operator so that it
doesn't encode [ and ] when they are found in the host part. That is, the
following URL:
http://[::1]/
is valid and should not be reencoded to:
http://%5b::1%5d/
* platform/qt/KURLQt.cpp:
(WebCore::KURL::operator QUrl):
2008-08-12 Mihnea Ovidenie <mihnea@adobe.com>
Fix for https://bugs.webkit.org/show_bug.cgi?id=19891
Broken HTML object elements cause de-reference of pointer to freed memory.
If we fail to load an image for an object tag and we no longer believe the object tag points at
an image, then clear m_imageLoader in the HTMLObjectElement so that we attempt to render the
fall back content.
Reviewed by Dave Hyatt and Alexey Proskuryakov.
Test: http/tests/misc/object-image-error-with-onload.html
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::renderFallbackContent):
* page/Frame.cpp:
(WebCore::Frame::Frame):
2008-08-12 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Dave.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=19798
Masks are translated, and the mask images are swapped on the y-axis.
Turned out that http://trac.webkit.org/changeset/31830/trunk/WebCore/svg/graphics/cg/SVGResourceMaskerCg.mm
is guilty. GraphicsContext::clipToImageBuffer() does some extra transformations that SVGResourcesMaskerCg does not want.
Long term goal is to remove the SVGResource*/SVGPaintServer* classes anyway, so it's okay to duplicate
the "clip to image buffer" functionality, in the CG specific SVGResourceMaskerCg class - as it was before.
* svg/graphics/cg/SVGResourceMaskerCg.mm:
(WebCore::SVGResourceMasker::applyMask): Changed back to use CG clipping again.
2008-08-12 Dan Bernstein <mitz@apple.com>
- WebCore part of <rdar://problem/6121636>
Make fast*alloc() abort() on failure and add "try" variants that
return NULL on failure.
Reviewed by Darin Adler.
* platform/Arena.cpp:
(WebCore::ArenaAllocate): Removed null checking of fastMalloc()'s
result.
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::create): Changed to use tryFastCalloc().
2008-08-12 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
- fix https://bugs.webkit.org/show_bug.cgi?id=19348
<rdar://problem/5978447> REGRESSION (r34193): Setting the size of a frame with javascript document.body.row no longer works
Test: fast/frames/frameset-style-recalc.html
* html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::recalcStyle): Changed to call the base
class implementation after marking for layout.
2008-08-12 Dan Bernstein <mitz@apple.com>
Reviewed by John Sullivan.
- move shouldUpdateWhenOffscreen from Settings to FrameView and rename it shouldUpdateWhileHidden
* WebCore.base.exp:
* page/FrameView.cpp:
(WebCore::FrameViewPrivate::FrameViewPrivate):
(WebCore::FrameView::shouldUpdateWhileHidden):
(WebCore::FrameView::setShouldUpdateWhileHidden):
* page/FrameView.h:
* page/Settings.cpp:
* page/Settings.h:
2008-08-12 Adam Roben <aroben@apple.com>
Windows build fix
* bindings/js/JSSVGPODTypeWrapper.h: Align
JSSVGDynamicPODTypeWrapper's and JSSVGStaticPODTypeWrapperWithParent's
members on 16-byte boundaries to avoid an alignment warning.
2008-08-12 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Oliver.
Add new dynamice-update layout tests covering SVGMarkerElement.
Fix bug: SVGMarkerElement's SVG DOM function calls don't update rendering.
Fix orientAngle/orientType confusion: "auto" orient should always return "0" as angle.
Tests: svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr.html
svg/dynamic-updates/SVGMarkerElement-dom-markerUnits-attr.html
svg/dynamic-updates/SVGMarkerElement-dom-markerWidth-attr.html
svg/dynamic-updates/SVGMarkerElement-dom-orient-attr.html
svg/dynamic-updates/SVGMarkerElement-dom-refX-attr.html
svg/dynamic-updates/SVGMarkerElement-dom-refY-attr.html
svg/dynamic-updates/SVGMarkerElement-svgdom-markerHeight-prop.html
svg/dynamic-updates/SVGMarkerElement-svgdom-markerUnits-prop.html
svg/dynamic-updates/SVGMarkerElement-svgdom-markerWidth-prop.html
svg/dynamic-updates/SVGMarkerElement-svgdom-orientAngle-prop.html
svg/dynamic-updates/SVGMarkerElement-svgdom-orientType-prop.html
svg/dynamic-updates/SVGMarkerElement-svgdom-refX-prop.html
svg/dynamic-updates/SVGMarkerElement-svgdom-refY-prop.html
svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call.html
svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAuto-call.html
* svg/SVGMarkerElement.cpp:
(WebCore::SVGMarkerElement::SVGMarkerElement):
(WebCore::SVGMarkerElement::parseMappedAttribute):
(WebCore::SVGMarkerElement::svgAttributeChanged):
(WebCore::SVGMarkerElement::childrenChanged):
(WebCore::SVGMarkerElement::setOrientToAuto):
(WebCore::SVGMarkerElement::setOrientToAngle):
(WebCore::SVGMarkerElement::canvasResource):
2008-08-12 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Oliver.
Add new dynamic-update layout tests covering SVGImageElement.
Fix bug: SVGImageElement doesn't react on 'preserveAspectRatio' changes.
Tests: svg/dynamic-updates/SVGImageElement-dom-height-attr.html
svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr.html
svg/dynamic-updates/SVGImageElement-dom-width-attr.html
svg/dynamic-updates/SVGImageElement-dom-x-attr.html
svg/dynamic-updates/SVGImageElement-dom-y-attr.html
svg/dynamic-updates/SVGImageElement-svgdom-height-prop.html
svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop.html
svg/dynamic-updates/SVGImageElement-svgdom-width-prop.html
svg/dynamic-updates/SVGImageElement-svgdom-x-prop.html
svg/dynamic-updates/SVGImageElement-svgdom-y-prop.html
* svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::svgAttributeChanged):
2008-08-11 Anthony Ricaud <rik24d@gmail.com>
Changed Option/Alt-Up or Down in CSS editing when the value is
near zero to jump to the next integer.
Reviewed by Tim Hatcher.
https://bugs.webkit.org/show_bug.cgi?id=20326
* page/inspector/StylesSidebarPane.js:
2008-08-11 Anthony Ricaud <rik24d@gmail.com>
Changed the line highlight transition for an easier animation.
Reviewed by Tim Hatcher.
* page/inspector/SourceFrame.js:
2008-08-11 Keishi Hattori <casey.hattori@gmail.com>
Added support for some Firebug Command Line APIs.
Reviewed by Tim Hatcher.
https://bugs.webkit.org/show_bug.cgi?id=19867
https://bugs.webkit.org/show_bug.cgi?id=19868
https://bugs.webkit.org/show_bug.cgi?id=19869
https://bugs.webkit.org/show_bug.cgi?id=19875
https://bugs.webkit.org/show_bug.cgi?id=19876
https://bugs.webkit.org/show_bug.cgi?id=19880
* page/inspector/Console.js:
(WebInspector.Console.prototype._evalInInspectedWindow):
Create an object on the inspected window that holds the console
command line API functions. This object is used in a with statement
around the typed expression.
2008-08-11 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Antti.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=17736
JS wrapper objects around SVG POD types, that contain other SVG POD types with writable properties
failed to update. Modification of the values were completly ignored (ie. transform.matrix.a = 50, didn't take any effect)
Added tests: svg/custom/svg-modify-currentTranslate.html
svg/custom/tearoffs-with-tearoffs.html
svg/custom/immutable-properties.html
Fixed tests: svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop.html
* bindings/js/JSSVGPODTypeWrapper.h:
(WebCore::JSSVGDynamicPODTypeWrapper::commitChange):
(WebCore::JSSVGStaticPODTypeWrapperWithPODTypeParent::create):
(WebCore::JSSVGStaticPODTypeWrapperWithPODTypeParent::commitChange):
(WebCore::JSSVGStaticPODTypeWrapperWithPODTypeParent::JSSVGStaticPODTypeWrapperWithPODTypeParent):
(WebCore::JSSVGStaticPODTypeWrapperWithParent::create):
(WebCore::JSSVGStaticPODTypeWrapperWithParent::operator PODType):
(WebCore::JSSVGStaticPODTypeWrapperWithParent::commitChange):
(WebCore::JSSVGStaticPODTypeWrapperWithParent::JSSVGStaticPODTypeWrapperWithParent):
* bindings/scripts/CodeGenerator.pm:
* bindings/scripts/CodeGeneratorJS.pm:
* svg/SVGSVGElement.idl: Add [Immutable] markers to SVG POD attributes, that contain POD types with writable attributes.
* svg/SVGZoomEvent.idl: SVG specification explicitely demands these attributes to be readonly, even its content.
2008-08-11 Brady Eidson <beidson@apple.com>
Reviewed by John and Anders
Fix for <rdar://problem/6141797>
When WebArchives were entirely a WebKit concept, there was a guarantee that a WebResource
would never have nil data.
When they were pushed down into WebCore, that guarantee was lost, subtly changing a few
semantics with some WebKit applications.
The guarantee was a good one and should be restored.
Note that ApplicationCacheResource doesn't need any updates to follow this rule as it already
creates an empty data object in the case of null data for its own purposes.
* loader/SubstituteResource.h:
(WebCore::SubstituteResource::SubstituteResource): ASSERT that the data is not null. This
well help any future subclassers not make this mistake.
* loader/archive/ArchiveResource.cpp:
(WebCore::ArchiveResource::create): Return 0 if the data is null.
2008-08-11 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dave Hyatt
https://bugs.webkit.org/show_bug.cgi?id=20328
Fix a problem when an 'all' transition transition with more than
one property changing is interrupted, and did some AnimationController
cleanup.
Test: transitions/interrupted-all-transition.html
* page/AnimationController.cpp:
(WebCore::ImplicitAnimation::ImplicitAnimation):
(WebCore::AnimationControllerPrivate::blendProperties):
(WebCore::CompositeAnimation::updateTransitions):
(WebCore::CompositeAnimation::cleanupFinishedAnimations):
(WebCore::CompositeAnimation::setTransitionStartTime):
(WebCore::CompositeAnimation::overrideImplicitAnimations):
(WebCore::CompositeAnimation::resumeOverriddenImplicitAnimations):
(WebCore::ImplicitAnimation::animate):
(WebCore::ImplicitAnimation::onAnimationEnd):
(WebCore::ImplicitAnimation::sendTransitionEvent):
(WebCore::ImplicitAnimation::affectsProperty):
(WebCore::KeyframeAnimation::endAnimation):
(WebCore::KeyframeAnimation::onAnimationEnd):
2008-08-11 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim.
- Because console messages have group levels now, newly created messages
that do not specify the level lose their message since the number of
arguments is wrong.
* page/inspector/Console.js:
* page/inspector/Resource.js:
2008-08-11 Alp Toker <alp@nuanti.com>
Build fix. Add new files from r35666 (WebKitAnimationEvent). Also take
the opportunity to sort the sources lists.
* GNUmakefile.am:
2008-08-11 Timothy Hatcher <timothy@apple.com>
Speed up the the JavaScript syntax highlighter by generating
the finders only once per script instead of per line.
https://bugs.webkit.org/show_bug.cgi?id=20346
Reviewed by Adam Roben.
* page/inspector/SourceFrame.js:
(WebInspector.SourceFrame.prototype._syntaxHighlightJavascriptLine):
Removed, factored into syntaxHighlightJavascript as an inline function.
(WebInspector.SourceFrame.prototype.syntaxHighlightJavascript):
Pulled in the _syntaxHighlightJavascriptLine so it will create a closure.
Generate the finders before iterating the lines.
2008-08-11 Adam Roben <aroben@apple.com>
Windows build fix
* WebCore.vcproj/WebCore.vcproj: Added JSWebKitAnimationEvent.cpp and
JSWebKitTransitionEvent.cpp to the project. Let VS reformat the file,
too.
2008-08-11 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
- fix <rdar://problem/6131096> Reproducible crash in CounterNode::isReset under guard malloc
Test: fast/css/counters/invalidate-cached-counter-node.html
* rendering/RenderContainer.cpp:
(WebCore::RenderContainer::invalidateCounters): Added. Invalidates all
RenderCounters in :before and :after content.
* rendering/RenderContainer.h:
* rendering/RenderCounter.cpp:
(WebCore::RenderCounter::isCounter): Renamed isRenderCounter() to this
to match the RenderObject method.
(WebCore::RenderCounter::invalidate): Added. Resets the cached
CounterNode and invalidates the object's layout and preferred widths.
(WebCore::destroyCounterNodeChildren): Added a call to
invalidateCounters().
* rendering/RenderCounter.h:
* rendering/RenderObject.h:
(WebCore::RenderObject::invalidateCounters):
2008-08-11 Dean Jackson <dino@apple.com>
Implement CSS Animation and Transition Events
https://bugs.webkit.org/show_bug.cgi?id=20337
Implement the events defined in the CSS Animations
and Transitions specifications so code can react
to animations and transitions.
Reviewed by Tim Hatcher and Dave Hyatt.
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
Build configs for new files
* bindings/js/JSDOMWindowBase.cpp:
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSEventCustom.cpp:
* dom/Document.h:
* dom/Event.cpp:
* dom/Event.h:
* dom/EventTarget.cpp:
* dom/EventTargetNode.cpp:
* dom/EventTargetNode.h:
* html/HTMLElement.cpp:
* page/AnimationController.cpp:
do all the new event stuff
* html/HTMLAttributeNames.in:
the onwebkitanimation* and onwebkittransitionend attrs
* dom/WebKitAnimationEvent.cpp: Added.
* dom/WebKitAnimationEvent.h: Added.
* dom/WebKitAnimationEvent.idl: Added.
* dom/WebKitTransitionEvent.cpp: Added.
* dom/WebKitTransitionEvent.h: Added.
* dom/WebKitTransitionEvent.idl: Added.
New files for the events
* manual-tests/transition-events.html: Added.
New testfile
2008-08-11 Adam Roben <aroben@apple.com>
Add a ForwardingHeader for wtf/NotFound.h
Rubberstamped by Darin Adler.
* ForwardingHeaders/wtf/NotFound.h: Added.
2008-08-11 Timothy Hatcher <timothy@apple.com>
Fixes a bug where error bubbles in JavaScript resources would
be clobbered by the syntax highlighter.
https://bugs.webkit.org/show_bug.cgi?id=20345
Reviewed by Adam Roben.
* manual-tests/inspector/resources/script-error.js: Added.
* manual-tests/inspector/styled-error-bubbles-in-scripts.html: Added.
* page/inspector/SourceFrame.js:
(WebInspector.SourceFrame.prototype._addMessageToSource):
Check the nodeType and not the nodeName, this is less fragile.
(WebInspector.SourceFrame.prototype._syntaxHighlightJavascriptLine):
Check if the lastChild is an error bubble, if so remove it before
getting the line's textContent. Add the error bubble back at the end.
== Rolled over to ChangeLog-2008-08-10 ==
|