1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
|
#!/usr/bin/perl -w
#
# Copyright (C) 2010 Chris Jerdonek (chris.jerdonek@gmail.com)
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions are
# met:
#
# * Redistributions of source code must retain the above copyright
# notice, this list of conditions and the following disclaimer.
# * Redistributions in binary form must reproduce the above
# copyright notice, this list of conditions and the following disclaimer
# in the documentation and/or other materials provided with the
# distribution.
# * Neither the name of Apple Computer, Inc. ("Apple") nor the names of
# its contributors may be used to endorse or promote products derived
# from this software without specific prior written permission.
#
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
# Unit tests of parseDiffHeader().
use strict;
use warnings;
use Test::More;
use VCSUtils;
my @diffHeaderHashRefKeys = ( # The $diffHeaderHashRef keys to check.
"copiedFromPath",
"indexPath",
"sourceRevision",
"svnConvertedText",
);
# The array of test cases.
my @testCaseHashRefs = (
{
# New test
diffName => "SVN: simple",
inputText => <<'END',
Index: WebKitTools/Scripts/VCSUtils.pm
===================================================================
--- WebKitTools/Scripts/VCSUtils.pm (revision 53004)
+++ WebKitTools/Scripts/VCSUtils.pm (working copy)
@@ -32,6 +32,7 @@ use strict;
use warnings;
END
# Header keys to check
svnConvertedText => <<'END',
Index: WebKitTools/Scripts/VCSUtils.pm
===================================================================
--- WebKitTools/Scripts/VCSUtils.pm (revision 53004)
+++ WebKitTools/Scripts/VCSUtils.pm (working copy)
END
copiedFromPath => undef,
indexPath => "WebKitTools/Scripts/VCSUtils.pm",
sourceRevision => "53004",
# Other values to check
lastReadLine => "@@ -32,6 +32,7 @@ use strict;\n",
nextLine => " use warnings;\n",
},
{
# New test
diffName => "SVN: new file",
inputText => <<'END',
Index: WebKitTools/Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl
===================================================================
--- WebKitTools/Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl (revision 0)
+++ WebKitTools/Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl (revision 0)
@@ -0,0 +1,262 @@
+#!/usr/bin/perl -w
END
# Header keys to check
svnConvertedText => <<'END',
Index: WebKitTools/Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl
===================================================================
--- WebKitTools/Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl (revision 0)
+++ WebKitTools/Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl (revision 0)
END
copiedFromPath => undef,
indexPath => "WebKitTools/Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl",
sourceRevision => undef,
# Other values to check
lastReadLine => "@@ -0,0 +1,262 @@\n",
nextLine => "+#!/usr/bin/perl -w\n",
},
{
# New test
diffName => "SVN: copy",
inputText => <<'END',
Index: index_path.py
===================================================================
--- index_path.py (revision 53048) (from copied_from_path.py:53048)
+++ index_path.py (working copy)
@@ -0,0 +1,7 @@
+# Python file...
END
# Header keys to check
svnConvertedText => <<'END',
Index: index_path.py
===================================================================
--- index_path.py (revision 53048) (from copied_from_path.py:53048)
+++ index_path.py (working copy)
END
copiedFromPath => "copied_from_path.py",
indexPath => "index_path.py",
sourceRevision => 53048,
# Other values to check
lastReadLine => "@@ -0,0 +1,7 @@\n",
nextLine => "+# Python file...\n",
},
{
# New test
diffName => "SVN: \\r\\n lines",
inputText => <<END, # No single quotes to allow interpolation of "\r"
Index: index_path.py\r
===================================================================\r
--- index_path.py (revision 53048) (from copied_from_path.py:53048)\r
+++ index_path.py (working copy)\r
@@ -0,0 +1,7 @@\r
+# Python file...\r
END
# Header keys to check
svnConvertedText => <<END, # No single quotes to allow interpolation of "\r"
Index: index_path.py\r
===================================================================\r
--- index_path.py (revision 53048) (from copied_from_path.py:53048)\r
+++ index_path.py (working copy)\r
END
copiedFromPath => "copied_from_path.py",
indexPath => "index_path.py",
sourceRevision => 53048,
# Other values to check
lastReadLine => "@@ -0,0 +1,7 @@\r\n",
nextLine => "+# Python file...\r\n",
},
{
# New test
diffName => "SVN: path corrections",
inputText => <<'END',
Index: index_path.py
===================================================================
--- bad_path (revision 53048) (from copied_from_path.py:53048)
+++ bad_path (working copy)
@@ -0,0 +1,7 @@
+# Python file...
END
# Header keys to check
svnConvertedText => <<'END',
Index: index_path.py
===================================================================
--- index_path.py (revision 53048) (from copied_from_path.py:53048)
+++ index_path.py (working copy)
END
copiedFromPath => "copied_from_path.py",
indexPath => "index_path.py",
sourceRevision => 53048,
# Other values to check
lastReadLine => "@@ -0,0 +1,7 @@\n",
nextLine => "+# Python file...\n",
},
{
# New test
diffName => "Git: simple",
inputText => <<'END',
diff --git a/WebCore/rendering/style/StyleFlexibleBoxData.h b/WebCore/rendering/style/StyleFlexibleBoxData.h
index f5d5e74..3b6aa92 100644
--- a/WebCore/rendering/style/StyleFlexibleBoxData.h
+++ b/WebCore/rendering/style/StyleFlexibleBoxData.h
@@ -47,7 +47,6 @@ public:
END
# Header keys to check
svnConvertedText => <<'END',
Index: WebCore/rendering/style/StyleFlexibleBoxData.h
===================================================================
--- WebCore/rendering/style/StyleFlexibleBoxData.h
+++ WebCore/rendering/style/StyleFlexibleBoxData.h
END
copiedFromPath => undef,
indexPath => "WebCore/rendering/style/StyleFlexibleBoxData.h",
sourceRevision => undef,
# Other values to check
lastReadLine => "@@ -47,7 +47,6 @@ public:\n",
nextLine => undef,
},
{
# New test
diffName => "Git: unrecognized lines",
inputText => <<'END',
diff --git a/LayoutTests/http/tests/security/listener/xss-inactive-closure.html b/LayoutTests/http/tests/security/listener/xss-inactive-closure.html
new file mode 100644
index 0000000..3c9f114
--- /dev/null
+++ b/LayoutTests/http/tests/security/listener/xss-inactive-closure.html
@@ -0,0 +1,34 @@
+<html>
END
# Header keys to check
svnConvertedText => <<'END',
Index: LayoutTests/http/tests/security/listener/xss-inactive-closure.html
===================================================================
--- LayoutTests/http/tests/security/listener/xss-inactive-closure.html
+++ LayoutTests/http/tests/security/listener/xss-inactive-closure.html
END
copiedFromPath => undef,
indexPath => "LayoutTests/http/tests/security/listener/xss-inactive-closure.html",
sourceRevision => undef,
# Other values to check
lastReadLine => "@@ -0,0 +1,34 @@\n",
nextLine => "+<html>\n",
},
);
# Return the arguments for each assertion per test case.
#
# In particular, the number of assertions per test case is the length
# of the return value of this subroutine on a sample input.
#
# Returns @assertionArgsArrayRefs:
# $assertionArgsArrayRef: A reference to an array of parameters to pass
# to each call to is(). The parameters are--
# $got: The value obtained
# $expected: The expected value
# $testName: The name of the test
sub testParseDiffHeaderAssertionArgs($)
{
my ($testCaseHashRef) = @_;
my $fileHandle;
open($fileHandle, "<", \$testCaseHashRef->{inputText});
my $line = <$fileHandle>;
my ($headerHashRef, $lastReadLine) = VCSUtils::parseDiffHeader($fileHandle, $line);
my $testNameStart = "parseDiffHeader(): [$testCaseHashRef->{diffName}] ";
my @assertionArgsArrayRefs; # Return value
my @assertionArgs;
foreach my $diffHeaderHashRefKey (@diffHeaderHashRefKeys) {
my $testName = "${testNameStart}key=\"$diffHeaderHashRefKey\"";
@assertionArgs = ($headerHashRef->{$diffHeaderHashRefKey}, $testCaseHashRef->{$diffHeaderHashRefKey}, $testName);
push(@assertionArgsArrayRefs, \@assertionArgs);
}
@assertionArgs = ($lastReadLine, $testCaseHashRef->{lastReadLine}, "${testNameStart}lastReadLine");
push(@assertionArgsArrayRefs, \@assertionArgs);
my $nextLine = <$fileHandle>;
@assertionArgs = ($nextLine, $testCaseHashRef->{nextLine}, "${testNameStart}nextLine");
push(@assertionArgsArrayRefs, \@assertionArgs);
return @assertionArgsArrayRefs;
}
# Test parseDiffHeader() for the given test case.
sub testParseDiffHeader($)
{
my ($testCaseHashRef) = @_;
my @assertionArgsArrayRefs = testParseDiffHeaderAssertionArgs($testCaseHashRef);
foreach my $arrayRef (@assertionArgsArrayRefs) {
# The parameters are -- is($got, $expected, $testName).
is($arrayRef->[0], $arrayRef->[1], $arrayRef->[2]);
}
}
# Count the number of assertions per test case to calculate the total number
# of Test::More tests. We could have used any test case for the count.
my $assertionCount = testParseDiffHeaderAssertionArgs($testCaseHashRefs[0]);
plan(tests => @testCaseHashRefs * $assertionCount); # Total number of tests
foreach my $testCaseHashRef (@testCaseHashRefs) {
testParseDiffHeader($testCaseHashRef);
}
|