diff options
author | Eino-Ville Talvala <etalvala@google.com> | 2013-09-03 13:29:28 -0700 |
---|---|---|
committer | Eino-Ville Talvala <etalvala@google.com> | 2013-09-03 13:32:53 -0700 |
commit | 0a4df03542e7d7aab716a60e206dceaf5da178f3 (patch) | |
tree | a95c5df29592ac85f4ea8f65bcd7456e3d5e0c93 | |
parent | 4585e8f0ff47580fdb81ed8652bde32db1770050 (diff) | |
download | frameworks_av-0a4df03542e7d7aab716a60e206dceaf5da178f3.zip frameworks_av-0a4df03542e7d7aab716a60e206dceaf5da178f3.tar.gz frameworks_av-0a4df03542e7d7aab716a60e206dceaf5da178f3.tar.bz2 |
Camera2/3: Increase precapture start timeout
Currently, we only wait 200 ms for the HAL to switch to the precapture
state. This is insufficient at low preview frame rates (dark
conditions, ~10 fps), where a 3-request-deep HAL pipeline will take
300 ms to produce a precapture trigger output. In those cases, we
would prematurely skip the precapture sequence, causing bad quality
pictures.
Since this is a fallback timeout to prevent deadlock in case of a bad
HAL or framework implementation, increase the timeout to 1 second. Has
no impact on correctly-working implementations
Bug: 10430191
Change-Id: I08e99f8e7f3beb8f15dcee32632cdebfe3dca8b3
-rw-r--r-- | services/camera/libcameraservice/api1/client2/CaptureSequencer.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/services/camera/libcameraservice/api1/client2/CaptureSequencer.h b/services/camera/libcameraservice/api1/client2/CaptureSequencer.h index 76750aa..7ad461a 100644 --- a/services/camera/libcameraservice/api1/client2/CaptureSequencer.h +++ b/services/camera/libcameraservice/api1/client2/CaptureSequencer.h @@ -100,7 +100,7 @@ class CaptureSequencer: * Internal to CaptureSequencer */ static const nsecs_t kWaitDuration = 100000000; // 100 ms - static const int kMaxTimeoutsForPrecaptureStart = 2; // 200 ms + static const int kMaxTimeoutsForPrecaptureStart = 10; // 1 sec static const int kMaxTimeoutsForPrecaptureEnd = 20; // 2 sec static const int kMaxTimeoutsForCaptureEnd = 40; // 4 sec |