diff options
author | Igor Murashkin <iam@google.com> | 2013-05-06 16:20:37 -0700 |
---|---|---|
committer | Android Git Automerger <android-git-automerger@android.com> | 2013-05-06 16:20:37 -0700 |
commit | 13320af823b7e539af13f66cb0fa4654cbae6beb (patch) | |
tree | 44444f026fdde0f72c9346cebe0715c523283c1a | |
parent | 61aa989a5768b9b0571ca14edaf15886509a0ec8 (diff) | |
parent | 41348da3a614bca05e7a4f6c96b0a91d7df924fe (diff) | |
download | frameworks_av-13320af823b7e539af13f66cb0fa4654cbae6beb.zip frameworks_av-13320af823b7e539af13f66cb0fa4654cbae6beb.tar.gz frameworks_av-13320af823b7e539af13f66cb0fa4654cbae6beb.tar.bz2 |
am 41348da3: am ef33d308: Merge "camera3: Don\'t eagerly finish configuring bidi streams more than once" into jb-mr2-dev
* commit '41348da3a614bca05e7a4f6c96b0a91d7df924fe':
camera3: Don't eagerly finish configuring bidi streams more than once
-rw-r--r-- | services/camera/libcameraservice/Camera3Device.cpp | 16 |
1 files changed, 10 insertions, 6 deletions
diff --git a/services/camera/libcameraservice/Camera3Device.cpp b/services/camera/libcameraservice/Camera3Device.cpp index 5f87e8b..5e5bfc2 100644 --- a/services/camera/libcameraservice/Camera3Device.cpp +++ b/services/camera/libcameraservice/Camera3Device.cpp @@ -1060,7 +1060,7 @@ status_t Camera3Device::configureStreamsLocked() { // TODO: Try to relax this later back to lazy completion, which should be // faster - if (mInputStream != NULL) { + if (mInputStream != NULL && mInputStream->isConfiguring()) { res = mInputStream->finishConfiguration(mHal3Device); if (res != OK) { SET_ERR_L("Can't finish configuring input stream %d: %s (%d)", @@ -1070,11 +1070,15 @@ status_t Camera3Device::configureStreamsLocked() { } for (size_t i = 0; i < mOutputStreams.size(); i++) { - res = mOutputStreams.editValueAt(i)->finishConfiguration(mHal3Device); - if (res != OK) { - SET_ERR_L("Can't finish configuring output stream %d: %s (%d)", - mOutputStreams[i]->getId(), strerror(-res), res); - return res; + sp<Camera3OutputStreamInterface> outputStream = + mOutputStreams.editValueAt(i); + if (outputStream->isConfiguring()) { + res = outputStream->finishConfiguration(mHal3Device); + if (res != OK) { + SET_ERR_L("Can't finish configuring output stream %d: %s (%d)", + outputStream->getId(), strerror(-res), res); + return res; + } } } |