summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEric Laurent <elaurent@google.com>2014-12-20 01:37:10 +0000
committerAndroid (Google) Code Review <android-gerrit@google.com>2014-12-20 01:37:11 +0000
commit5886252a7b08fb5c5d8829443e56a63956986148 (patch)
tree5f59ad8973bf6caeee2182f07a5cc8edb0aa7ef0
parent0a0662ea48b060716e0e982661836df9a0958111 (diff)
parenta34c9ce292ea984e92d8f70d2c056e5372c4f452 (diff)
downloadframeworks_av-5886252a7b08fb5c5d8829443e56a63956986148.zip
frameworks_av-5886252a7b08fb5c5d8829443e56a63956986148.tar.gz
frameworks_av-5886252a7b08fb5c5d8829443e56a63956986148.tar.bz2
Merge "audio policy: fix isSourceActive() for hotword" into lmp-mr1-dev
-rw-r--r--services/audiopolicy/AudioPolicyManager.cpp21
1 files changed, 16 insertions, 5 deletions
diff --git a/services/audiopolicy/AudioPolicyManager.cpp b/services/audiopolicy/AudioPolicyManager.cpp
index be7158f..34c677c 100644
--- a/services/audiopolicy/AudioPolicyManager.cpp
+++ b/services/audiopolicy/AudioPolicyManager.cpp
@@ -2055,12 +2055,23 @@ bool AudioPolicyManager::isSourceActive(audio_source_t source) const
{
for (size_t i = 0; i < mInputs.size(); i++) {
const sp<AudioInputDescriptor> inputDescriptor = mInputs.valueAt(i);
- if ((inputDescriptor->mInputSource == (int)source ||
- (source == AUDIO_SOURCE_VOICE_RECOGNITION &&
- inputDescriptor->mInputSource == AUDIO_SOURCE_HOTWORD))
- && (inputDescriptor->mRefCount > 0)) {
+ if (inputDescriptor->mRefCount == 0) {
+ continue;
+ }
+ if (inputDescriptor->mInputSource == (int)source) {
return true;
}
+ // AUDIO_SOURCE_HOTWORD is equivalent to AUDIO_SOURCE_VOICE_RECOGNITION only if it
+ // corresponds to an active capture triggered by a hardware hotword recognition
+ if ((source == AUDIO_SOURCE_VOICE_RECOGNITION) &&
+ (inputDescriptor->mInputSource == AUDIO_SOURCE_HOTWORD)) {
+ // FIXME: we should not assume that the first session is the active one and keep
+ // activity count per session. Same in startInput().
+ ssize_t index = mSoundTriggerSessions.indexOfKey(inputDescriptor->mSessions.itemAt(0));
+ if (index >= 0) {
+ return true;
+ }
+ }
}
return false;
}
@@ -5296,7 +5307,7 @@ uint32_t AudioPolicyManager::activeInputsCount() const
for (size_t i = 0; i < mInputs.size(); i++) {
const sp<AudioInputDescriptor> desc = mInputs.valueAt(i);
if (desc->mRefCount > 0) {
- return count++;
+ count++;
}
}
return count;