diff options
author | Eric Laurent <elaurent@google.com> | 2014-11-05 12:15:36 -0800 |
---|---|---|
committer | Eric Laurent <elaurent@google.com> | 2014-11-05 12:33:59 -0800 |
commit | 74adca9ad30b7f8a70d40c5237bade0d16c4ea58 (patch) | |
tree | 13e642689e945e69b76ac095a6bec978debf4084 | |
parent | ed1e55c5276a1c031e9b2f016387c7d2fe7bc47f (diff) | |
download | frameworks_av-74adca9ad30b7f8a70d40c5237bade0d16c4ea58.zip frameworks_av-74adca9ad30b7f8a70d40c5237bade0d16c4ea58.tar.gz frameworks_av-74adca9ad30b7f8a70d40c5237bade0d16c4ea58.tar.bz2 |
IAudioPolicyService: bound array size in queryDefaultPreProcessing
Bug: 18226810.
Change-Id: Ib8e2bfe835a8681aac50bf23161db14e50c9a124
-rw-r--r-- | include/media/AudioEffect.h | 9 | ||||
-rw-r--r-- | media/libmedia/IAudioPolicyService.cpp | 9 |
2 files changed, 13 insertions, 5 deletions
diff --git a/include/media/AudioEffect.h b/include/media/AudioEffect.h index 4932d40..583695d 100644 --- a/include/media/AudioEffect.h +++ b/include/media/AudioEffect.h @@ -133,10 +133,11 @@ public: * * Returned value * *descriptor updated with descriptors of pre processings enabled by default - * *count number of descriptors returned if returned status is N_ERROR. + * *count number of descriptors returned if returned status is NO_ERROR. * total number of pre processing enabled by default if returned status is * NO_MEMORY. This happens if the count passed as input is less than the number - * of descriptors to return + * of descriptors to return. + * *count is limited to kMaxPreProcessing on return. */ static status_t queryDefaultPreProcessing(int audioSession, effect_descriptor_t *descriptors, @@ -391,6 +392,10 @@ public: */ static status_t guidToString(const effect_uuid_t *guid, char *str, size_t maxLen); + // kMaxPreProcessing is a reasonable value for the maximum number of preprocessing effects + // that can be applied simultaneously. + static const uint32_t kMaxPreProcessing = 10; + protected: bool mEnabled; // enable state int32_t mSessionId; // audio session ID diff --git a/media/libmedia/IAudioPolicyService.cpp b/media/libmedia/IAudioPolicyService.cpp index 256cb3f..180f5fb 100644 --- a/media/libmedia/IAudioPolicyService.cpp +++ b/media/libmedia/IAudioPolicyService.cpp @@ -23,6 +23,7 @@ #include <binder/Parcel.h> +#include <media/AudioEffect.h> #include <media/IAudioPolicyService.h> #include <system/audio.h> @@ -916,16 +917,18 @@ status_t BnAudioPolicyService::onTransact( CHECK_INTERFACE(IAudioPolicyService, data, reply); int audioSession = data.readInt32(); uint32_t count = data.readInt32(); + if (count > AudioEffect::kMaxPreProcessing) { + count = AudioEffect::kMaxPreProcessing; + } uint32_t retCount = count; - effect_descriptor_t *descriptors = - (effect_descriptor_t *)new char[count * sizeof(effect_descriptor_t)]; + effect_descriptor_t *descriptors = new effect_descriptor_t[count]; status_t status = queryDefaultPreProcessing(audioSession, descriptors, &retCount); reply->writeInt32(status); if (status != NO_ERROR && status != NO_MEMORY) { retCount = 0; } reply->writeInt32(retCount); - if (retCount) { + if (retCount != 0) { if (retCount < count) { count = retCount; } |