diff options
author | Robert Shih <robertshih@google.com> | 2013-11-22 12:58:43 -0800 |
---|---|---|
committer | Robert Shih <robertshih@google.com> | 2013-11-22 17:29:02 -0800 |
commit | 9bb976e1c78048081cf9df4d8a1db67311413e5b (patch) | |
tree | 90f633078dd96d51cf05b28c3bf8d69b3ca0bda9 | |
parent | 0f3984ed3271484e223826e8a2e5f70c4111e08f (diff) | |
download | frameworks_av-9bb976e1c78048081cf9df4d8a1db67311413e5b.zip frameworks_av-9bb976e1c78048081cf9df4d8a1db67311413e5b.tar.gz frameworks_av-9bb976e1c78048081cf9df4d8a1db67311413e5b.tar.bz2 |
Avoid the call to CameraSourceTimeLapse::trySettingVideoSize if initialization
failed in the parent class ctor CameraSource::CameraSource.
Bug: 11636771
Change-Id: I5e6bffc1ebeeb1c2b84d6ed2049b2b3676ac046a
-rw-r--r-- | include/media/stagefright/CameraSource.h | 3 | ||||
-rw-r--r-- | media/libstagefright/CameraSourceTimeLapse.cpp | 3 |
2 files changed, 4 insertions, 2 deletions
diff --git a/include/media/stagefright/CameraSource.h b/include/media/stagefright/CameraSource.h index a829916..69cfbd0 100644 --- a/include/media/stagefright/CameraSource.h +++ b/include/media/stagefright/CameraSource.h @@ -185,6 +185,8 @@ protected: virtual void dataCallbackTimestamp(int64_t timestampUs, int32_t msgType, const sp<IMemory> &data); + void releaseCamera(); + private: friend class CameraSourceListener; @@ -233,7 +235,6 @@ private: int32_t frameRate); void stopCameraRecording(); - void releaseCamera(); status_t reset(); CameraSource(const CameraSource &); diff --git a/media/libstagefright/CameraSourceTimeLapse.cpp b/media/libstagefright/CameraSourceTimeLapse.cpp index 20214e8..07f0271 100644 --- a/media/libstagefright/CameraSourceTimeLapse.cpp +++ b/media/libstagefright/CameraSourceTimeLapse.cpp @@ -81,7 +81,8 @@ CameraSourceTimeLapse::CameraSourceTimeLapse( mVideoWidth = videoSize.width; mVideoHeight = videoSize.height; - if (!trySettingVideoSize(videoSize.width, videoSize.height)) { + if (OK == mInitCheck && !trySettingVideoSize(videoSize.width, videoSize.height)) { + releaseCamera(); mInitCheck = NO_INIT; } |