diff options
| author | Wei Jia <wjia@google.com> | 2015-10-05 10:44:23 -0700 |
|---|---|---|
| committer | Wei Jia <wjia@google.com> | 2015-10-05 15:46:22 -0700 |
| commit | b3694ff5a5bcecd4b6cedca156f6effb55bbf4ca (patch) | |
| tree | 6fb76e88eab9d2c8314e114a8557884d95b73c60 | |
| parent | a9a899d3970f41162c8e9c720bf05f3e6226a90a (diff) | |
| download | frameworks_av-b3694ff5a5bcecd4b6cedca156f6effb55bbf4ca.zip frameworks_av-b3694ff5a5bcecd4b6cedca156f6effb55bbf4ca.tar.gz frameworks_av-b3694ff5a5bcecd4b6cedca156f6effb55bbf4ca.tar.bz2 | |
ID3: check possible integer overflow for extendedHeaderSize and paddingSize.
Bug: 24623447
Change-Id: Ifbc74454d6e28ad7136efe35ab638a07e46398b1
| -rw-r--r-- | media/libstagefright/id3/ID3.cpp | 21 |
1 files changed, 19 insertions, 2 deletions
diff --git a/media/libstagefright/id3/ID3.cpp b/media/libstagefright/id3/ID3.cpp index 00f87aa..4410579 100644 --- a/media/libstagefright/id3/ID3.cpp +++ b/media/libstagefright/id3/ID3.cpp @@ -194,6 +194,13 @@ struct id3_header { if (header.version_major == 4) { void *copy = malloc(size); + if (copy == NULL) { + free(mData); + mData = NULL; + ALOGE("b/24623447, no more memory"); + return false; + } + memcpy(copy, mData, size); bool success = removeUnsynchronizationV2_4(false /* iTunesHack */); @@ -234,7 +241,14 @@ struct id3_header { return false; } - size_t extendedHeaderSize = U32_AT(&mData[0]) + 4; + size_t extendedHeaderSize = U32_AT(&mData[0]); + if (extendedHeaderSize > SIZE_MAX - 4) { + free(mData); + mData = NULL; + ALOGE("b/24623447, extendedHeaderSize is too large"); + return false; + } + extendedHeaderSize += 4; if (extendedHeaderSize > mSize) { free(mData); @@ -252,7 +266,10 @@ struct id3_header { if (extendedHeaderSize >= 10) { size_t paddingSize = U32_AT(&mData[6]); - if (mFirstFrameOffset + paddingSize > mSize) { + if (paddingSize > SIZE_MAX - mFirstFrameOffset) { + ALOGE("b/24623447, paddingSize is too large"); + } + if (paddingSize > mSize - mFirstFrameOffset) { free(mData); mData = NULL; |