diff options
| author | Eric Laurent <elaurent@google.com> | 2011-04-07 09:41:46 -0700 |
|---|---|---|
| committer | Eric Laurent <elaurent@google.com> | 2011-04-07 09:41:46 -0700 |
| commit | cc8ace7989f663fe6c6c1ed0febca0d9d1f19c7a (patch) | |
| tree | f788a310454b02147ac7669e661cdb9afaf0d92e | |
| parent | c30268b9d118309a0514bcf280a03ee69f81403f (diff) | |
| download | frameworks_av-cc8ace7989f663fe6c6c1ed0febca0d9d1f19c7a.zip frameworks_av-cc8ace7989f663fe6c6c1ed0febca0d9d1f19c7a.tar.gz frameworks_av-cc8ace7989f663fe6c6c1ed0febca0d9d1f19c7a.tar.bz2 | |
Do not disable effect in AudioEffect destructor.
Current implementation of AudioEffect class destructor disables
the effect before disconnecting from IAudioEffect interface.
This is problematic when more than one client has a handle on the same
effect engine as destroying one handle will disable the effect which is
not the intended behavior.
Change-Id: I10eacf981506469a7ef4eb9a1650813f0848de5d
| -rw-r--r-- | media/libmedia/AudioEffect.cpp | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/media/libmedia/AudioEffect.cpp b/media/libmedia/AudioEffect.cpp index aadeba5..a043329 100644 --- a/media/libmedia/AudioEffect.cpp +++ b/media/libmedia/AudioEffect.cpp @@ -170,7 +170,6 @@ AudioEffect::~AudioEffect() LOGV("Destructor %p", this); if (mStatus == NO_ERROR || mStatus == ALREADY_EXISTS) { - setEnabled(false); if (mIEffect != NULL) { mIEffect->disconnect(); mIEffect->asBinder()->unlinkToDeath(mIEffectClient); |