diff options
author | Wei Jia <wjia@google.com> | 2015-06-05 16:25:38 +0000 |
---|---|---|
committer | Android Git Automerger <android-git-automerger@android.com> | 2015-06-05 16:25:38 +0000 |
commit | e0095a19666afbab36dd0e8e4544e7f4ec9f890c (patch) | |
tree | c391f9cfdc365ce198a5f78ff9f83a69062a000a | |
parent | f02c5c9e4e13a493adcf39d0cba2a549d8caa4de (diff) | |
parent | 86174e2c09986b2d2ebcaf95a4a3e614bcf134ef (diff) | |
download | frameworks_av-e0095a19666afbab36dd0e8e4544e7f4ec9f890c.zip frameworks_av-e0095a19666afbab36dd0e8e4544e7f4ec9f890c.tar.gz frameworks_av-e0095a19666afbab36dd0e8e4544e7f4ec9f890c.tar.bz2 |
am 86174e2c: Merge "Prevent reading past the end of the buffer in 3GPP" into lmp-dev
* commit '86174e2c09986b2d2ebcaf95a4a3e614bcf134ef':
Prevent reading past the end of the buffer in 3GPP
-rw-r--r-- | media/libstagefright/MPEG4Extractor.cpp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/media/libstagefright/MPEG4Extractor.cpp b/media/libstagefright/MPEG4Extractor.cpp index e74d9a6..053bfbf 100644 --- a/media/libstagefright/MPEG4Extractor.cpp +++ b/media/libstagefright/MPEG4Extractor.cpp @@ -2395,11 +2395,11 @@ status_t MPEG4Extractor::parseITunesMetaData(off64_t offset, size_t size) { } status_t MPEG4Extractor::parse3GPPMetaData(off64_t offset, size_t size, int depth) { - if (size < 4) { + if (size < 4 || size == SIZE_MAX) { return ERROR_MALFORMED; } - uint8_t *buffer = new (std::nothrow) uint8_t[size]; + uint8_t *buffer = new (std::nothrow) uint8_t[size + 1]; if (buffer == NULL) { return ERROR_MALFORMED; } @@ -2495,6 +2495,7 @@ status_t MPEG4Extractor::parse3GPPMetaData(off64_t offset, size_t size, int dept } if (isUTF8) { + buffer[size] = 0; mFileMetaData->setCString(metadataKey, (const char *)buffer + 6); } else { // Convert from UTF-16 string to UTF-8 string. |